Spaces:
Sleeping
Sleeping
File size: 17,078 Bytes
3e56848 |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 |
import ast
import inspect
import sys
import types
import warnings
import executing
from functools import lru_cache
from string import Formatter
from types import CodeType
from typing import Any, Literal, TypeVar
from typing_extensions import NotRequired, TypedDict
from .constants import MESSAGE_FORMATTED_VALUE_LENGTH_LIMIT
from .stack_info import get_user_frame_and_stacklevel
Truncatable = TypeVar('Truncatable', str, bytes, 'list[Any]', 'tuple[Any, ...]')
class LiteralChunk(TypedDict):
t: Literal['lit']
v: str
class ArgChunk(TypedDict):
t: Literal['arg']
v: str
spec: NotRequired[str]
class KnownFormattingError(Exception):
"""An error raised when there's something wrong with a format string or the field values.
In other words this should correspond to errors that would be raised when using `str.format`,
and generally indicate a user error, most likely that they weren't trying to pass a template string at all.
"""
class FStringAwaitError(Exception):
"""An error raised when an await expression is found in an f-string.
This is a specific case that can't be handled by f-string introspection and requires
pre-evaluating the await expression before logging.
"""
class FormattingFailedWarning(UserWarning):
pass
class InspectArgumentsFailedWarning(Warning):
pass
class ChunksFormatter(Formatter):
def chunks(
self,
format_string: str,
kwargs: dict[str, Any],
*,
fstring_frame: types.FrameType = None,
) -> tuple[list[LiteralChunk | ArgChunk], dict[str, Any], str]:
# Returns
# 1. A list of chunks
# 2. A dictionary of extra attributes to add to the span/log.
# These can come from evaluating values in f-strings,
# or from noting scrubbed values.
# 3. The final message template, which may differ from `format_string` if it was an f-string.
if fstring_frame:
result = self._fstring_chunks(kwargs, fstring_frame)
if result: # returns None if faile
return result
chunks = self._vformat_chunks(
format_string,
kwargs=kwargs
)
# When there's no f-string magic, there's no changes in the template string.
return chunks, {}, format_string
def _fstring_chunks(
self,
kwargs: dict[str, Any],
frame: types.FrameType,
) -> tuple[list[LiteralChunk | ArgChunk], dict[str, Any], str]:
# `frame` is the frame of the method that's being called by the user
# called_code = frame.f_code
frame = frame.f_back or frame # type: ignore
assert frame is not None
# This is where the magic happens. It has caching.
ex = executing.Source.executing(frame)
call_node = ex.node
if call_node is None: # type: ignore[reportUnnecessaryComparison]
# `executing` failed to find a node.
# This shouldn't happen in most cases, but it's best not to rely on it always working.
if not ex.source.text:
# This is a very likely cause.
# There's nothing we could possibly do to make magic work here,
# and it's a clear case where the user should turn the magic off.
warn_inspect_arguments(
'No source code available. '
'This happens when running in an interactive shell, '
'using exec(), or running .pyc files without the source .py files.',
get_stacklevel(frame),
)
return None
msg = '`executing` failed to find a node.'
if sys.version_info[:2] < (3, 11): # pragma: no cover
# inspect_arguments is only on by default for 3.11+ for this reason.
# The AST modifications made by auto-tracing
# mean that the bytecode doesn't match the source code seen by `executing`.
# In 3.11+, a different algorithm is used by `executing` which can deal with this.
msg += ' This may be caused by a combination of using Python < 3.11 and auto-tracing.'
# Try a simple fallback heuristic to find the node which should work in most cases.
main_nodes: list[ast.AST] = []
for statement in ex.statements:
if isinstance(statement, ast.With):
# Only look at the 'header' of a with statement, not its body.
main_nodes += statement.items
else:
main_nodes.append(statement)
call_nodes = [
node
for main_node in main_nodes
for node in ast.walk(main_node)
if isinstance(node, ast.Call)
if node.args or node.keywords
]
if len(call_nodes) != 1:
warn_inspect_arguments(msg, get_stacklevel(frame))
return None
[call_node] = call_nodes
if not isinstance(call_node, ast.Call): # pragma: no cover
# Very unlikely.
warn_inspect_arguments(
'`executing` unexpectedly identified a non-Call node.',
get_stacklevel(frame),
)
return None
if call_node.args:
arg_node = call_node.args[0]
else:
# Very unlikely.
warn_inspect_arguments(
"Couldn't identify the `msg_template` argument in the call.",
get_stacklevel(frame),
)
return None
if not isinstance(arg_node, ast.JoinedStr):
# Not an f-string, not a problem.
# Just use normal formatting.
return None
# We have an f-string AST node.
# Now prepare the namespaces that we will use to evaluate the components.
global_vars = frame.f_globals
local_vars = {**frame.f_locals, **kwargs}
# Now for the actual formatting!
result: list[LiteralChunk | ArgChunk] = []
# We construct the message template (i.e. the span name) from the AST.
# We don't use the source code of the f-string because that gets messy
# if there's escaped quotes or implicit joining of adjacent strings.
new_template = ''
extra_attrs: dict[str, Any] = {}
for node_value in arg_node.values:
if isinstance(node_value, ast.Constant):
# These are the parts of the f-string not enclosed by `{}`, e.g. 'foo ' in f'foo {bar}'
value: str = node_value.value
result.append({'v': value, 't': 'lit'})
new_template += value
else:
# These are the parts of the f-string enclosed by `{}`, e.g. 'bar' in f'foo {bar}'
assert isinstance(node_value, ast.FormattedValue)
# This is cached.
source, value_code, formatted_code = compile_formatted_value(node_value, ex.source)
# Note that this doesn't include:
# - The format spec, e.g. `:0.2f`
# - The conversion, e.g. `!r`
# - The '=' sign within the braces, e.g. `{bar=}`.
# The AST represents f'{bar = }' as f'bar = {bar}' which is how the template will look.
new_template += '{' + source + '}'
# The actual value of the expression.
value = eval(value_code, global_vars, local_vars)
extra_attrs[source] = value
# Format the value according to the format spec, converting to a string.
formatted = eval(formatted_code, global_vars, {**local_vars, '@fvalue': value})
formatted = self._clean_value(formatted)
result.append({'v': formatted, 't': 'arg'})
return result, extra_attrs, new_template
def _vformat_chunks(
self,
format_string: str,
kwargs: dict[str, Any],
*,
recursion_depth: int = 2,
) -> list[LiteralChunk | ArgChunk]:
"""Copied from `string.Formatter._vformat` https://github.com/python/cpython/blob/v3.11.4/Lib/string.py#L198-L247 then altered."""
if recursion_depth < 0:
raise KnownFormattingError('Max format spec recursion exceeded')
result: list[LiteralChunk | ArgChunk] = []
# We currently don't use positional arguments
args = ()
for literal_text, field_name, format_spec, conversion in self.parse(format_string):
# output the literal text
if literal_text:
result.append({'v': literal_text, 't': 'lit'})
# if there's a field, output it
if field_name is not None:
# this is some markup, find the object and do
# the formatting
if field_name == '':
raise KnownFormattingError('Empty curly brackets `{}` are not allowed. A field name is required.')
# ADDED BY US:
if field_name.endswith('='):
if result and result[-1]['t'] == 'lit':
result[-1]['v'] += field_name
else:
result.append({'v': field_name, 't': 'lit'})
field_name = field_name[:-1]
# given the field_name, find the object it references
# and the argument it came from
try:
obj, _arg_used = self.get_field(field_name, args, kwargs)
except IndexError:
raise KnownFormattingError('Numeric field names are not allowed.')
except KeyError as exc1:
if str(exc1) == repr(field_name):
raise KnownFormattingError(f'The field {{{field_name}}} is not defined.') from exc1
try:
# field_name is something like 'a.b' or 'a[b]'
# Evaluating that expression failed, so now just try getting the whole thing from kwargs.
# In particular, OTEL attributes with dots in their names are normal and handled here.
obj = kwargs[field_name]
except KeyError as exc2:
# e.g. neither 'a' nor 'a.b' is defined
raise KnownFormattingError(f'The fields {exc1} and {exc2} are not defined.') from exc2
except Exception as exc:
raise KnownFormattingError(f'Error getting field {{{field_name}}}: {exc}') from exc
# do any conversion on the resulting object
if conversion is not None:
try:
obj = self.convert_field(obj, conversion)
except Exception as exc:
raise KnownFormattingError(f'Error converting field {{{field_name}}}: {exc}') from exc
# expand the format spec, if needed
format_spec_chunks = self._vformat_chunks(
format_spec or '', kwargs, recursion_depth=recursion_depth - 1
)
format_spec = ''.join(chunk['v'] for chunk in format_spec_chunks)
try:
value = self.format_field(obj, format_spec)
except Exception as exc:
raise KnownFormattingError(f'Error formatting field {{{field_name}}}: {exc}') from exc
value = self._clean_value(value)
d: ArgChunk = {'v': value, 't': 'arg'}
if format_spec:
d['spec'] = format_spec
result.append(d)
return result
def _clean_value(self, value: str) -> str:
return truncate_sequence(seq=value, max_length=MESSAGE_FORMATTED_VALUE_LENGTH_LIMIT, middle='...')
def warn_inspect_arguments(msg: str, stacklevel: int):
"""Warn about an error in inspecting arguments.
This is a separate function so that it can be called from multiple places.
"""
msg = (
'Failed to introspect calling code. '
'Falling back to normal message formatting '
'which may result in loss of information if using an f-string. '
'The problem was:\n'
) + msg
warnings.warn(msg, InspectArgumentsFailedWarning, stacklevel=stacklevel)
def get_stacklevel(frame: types.FrameType):
"""Get a stacklevel which can be passed to warn_inspect_arguments
which points at the given frame, where the f-string was found.
"""
current_frame = inspect.currentframe()
stacklevel = 0
while current_frame: # pragma: no branch
if current_frame == frame:
break
stacklevel += 1
current_frame = current_frame.f_back
return stacklevel
@lru_cache
def compile_formatted_value(node: ast.FormattedValue, ex_source: executing.Source) -> tuple[str, CodeType, CodeType]:
"""Returns three things that can be expensive to compute.
1. Source code corresponding to the node value (excluding the format spec).
2. A compiled code object which can be evaluated to calculate the value.
3. Another code object which formats the value.
"""
source = get_node_source_text(node.value, ex_source)
# Check if the expression contains await before attempting to compile
for sub_node in ast.walk(node.value):
if isinstance(sub_node, ast.Await):
raise FStringAwaitError(source)
value_code = compile(source, '<fvalue1>', 'eval')
expr = ast.Expression(
ast.JoinedStr(
values=[
# Similar to the original FormattedValue node,
# but replace the actual expression with a simple variable lookup
# so that it the expression doesn't need to be evaluated again.
# Use @ in the variable name so that it can't possibly conflict
# with a normal variable.
# The value of this variable will be provided in the eval() call
# and will come from evaluating value_code above.
ast.FormattedValue(
value=ast.Name(id='@fvalue', ctx=ast.Load()),
conversion=node.conversion,
format_spec=node.format_spec,
)
]
)
)
ast.fix_missing_locations(expr)
formatted_code = compile(expr, '<fvalue2>', 'eval')
return source, value_code, formatted_code
def get_node_source_text(node: ast.AST, ex_source: executing.Source):
"""Returns some Python source code representing `node`.
Preferably the actual original code given by `ast.get_source_segment`,
but falling back to `ast.unparse(node)` if the former is incorrect.
This happens sometimes due to Python bugs (especially for older Python versions)
in the source positions of AST nodes inside f-strings.
"""
# ast.unparse is not available in Python 3.8, which is why inspect_arguments is forbidden in 3.8.
source_unparsed = ast.unparse(node)
source_segment = ast.get_source_segment(ex_source.text, node) or ''
try:
# Verify that the source segment is correct by checking that the AST is equivalent to what we have.
source_segment_unparsed = ast.unparse(ast.parse(source_segment, mode='eval'))
except Exception: # probably SyntaxError, but ast.parse can raise other exceptions too
source_segment_unparsed = ''
return source_segment if source_unparsed == source_segment_unparsed else source_unparsed
def truncate_sequence(seq: Truncatable, *, max_length: int, middle: Truncatable) -> Truncatable:
"""Return a sequence at with `len()` at most `max_length`, with `middle` in the middle if truncated."""
if len(seq) <= max_length:
return seq
remaining_length = max_length - len(middle)
half = remaining_length // 2
return seq[:half] + middle + seq[-half:]
def warn_at_user_stacklevel(msg: str, category: type[Warning]):
"""Warn at the user's stack level.
"""
_frame, stacklevel = get_user_frame_and_stacklevel()
warnings.warn(msg, stacklevel=stacklevel, category=category)
def warn_formatting(msg: str):
"""Warn about a formatting error.
"""
warn_at_user_stacklevel(
f'\n'
f' Ensure you are either:\n'
' (1) passing an f-string directly, or\n'
' (2) passing a literal `str.format`-style template, not a preformatted string.\n'
f' The problem was: {msg}',
category=FormattingFailedWarning,
)
def warn_fstring_await(msg: str):
"""Warn about an await expression in an f-string.
"""
warn_at_user_stacklevel(
f'\n'
f' Cannot evaluate await expression in f-string. Pre-evaluate the expression before logging.\n'
f' The problematic f-string value was: {msg}',
category=FormattingFailedWarning,
)
chunks_formatter = ChunksFormatter()
|