Fix dropdown mismatch error when changing training preset

degraded_requirements.txt

@@ -38,6 +38,7 @@ git+https://github.com/LLaVA-VL/LLaVA-NeXT.git
 # for our frontend
 gradio==5.23.3
 gradio_toggle
+gradio_modal
 
 # used for the monitor
 matplotlib

requirements.txt

@@ -36,6 +36,7 @@ git+https://github.com/LLaVA-VL/LLaVA-NeXT.git
 # for our frontend
 gradio==5.23.3
 gradio_toggle
+gradio_modal
 
 # used for the monitor
 matplotlib

vms/ui/app_ui.py

@@ -269,8 +269,8 @@ class AppUI:
                 prose_header_text_weight='400'
             ),
 
-            # Let's hack Gradio!
-            css="#main-tabs > .tab-wrapper{ display: none; }",
+            # Let's hack Gradio and gradio_modal!
+            css="#main-tabs > .tab-wrapper{ display: none; } .modal{ z-index: 1000; } .modal-block{ max-width: 420px; }",
             ) as app:
             self.app = app
             

vms/ui/models/tabs/drafts_tab.py

@@ -6,6 +6,7 @@ import gradio as gr
 import logging
 from typing import Dict, Any, List, Optional, Tuple
 from datetime import datetime
+from gradio_modal import Modal
 
 from vms.utils.base_tab import BaseTab
 
@@ -92,22 +93,49 @@ class DraftsTab(BaseTab):
                                     )
                                 with gr.Column(scale=1, min_width=10):
                                     delete_btn = gr.Button("🗑️ Delete", size="sm", variant="stop")
-                                
+                                    
+                                    # Create a modal for this specific model deletion
+                                    with Modal(visible=False) as delete_modal:
+                                        gr.Markdown("## ⚠️ Confirm Deletion")
+                                        gr.Markdown(f"Are you sure you want to delete model {model.id[:8]}...?")
+                                        gr.Markdown("This action cannot be undone!")
+                                        
+                                        with gr.Row():
+                                            cancel_btn = gr.Button("🫢 No, cancel", variant="secondary")
+                                            confirm_btn = gr.Button("🚨 Yes, delete", variant="primary")
+                                    
+                                    # Connect the buttons to the modal
                                     delete_btn.click(
+                                        fn=lambda: Modal(visible=True),
+                                        inputs=[],
+                                        outputs=[delete_modal]
+                                    )
+                                    
+                                    cancel_btn.click(
+                                        fn=lambda: Modal(visible=False),
+                                        inputs=[],
+                                        outputs=[delete_modal]
+                                    )
+                                    
+                                    confirm_btn.click(
                                         fn=lambda model_id=model.id: self.delete_model(model_id),
                                         inputs=[],
                                         outputs=[new_container]
+                                    ).then(
+                                        fn=lambda: Modal(visible=False),
+                                        inputs=[],
+                                        outputs=[delete_modal]
                                     )
         
         return new_container
     
-    def edit_model(self, model_id: str) -> None:
+    def edit_model(self, model_id: str) -> gr.Tabs:
         """Switch to editing the selected model"""
         if self.app:
             # Switch to project view with this model
             self.app.switch_project(model_id)
             # Set main tab to Project (index 0)
-            return self.app.main_tabs.update(selected=0)
+            return gr.Tabs(selected=0)
             
     def delete_model(self, model_id: str) -> gr.Column:
         """Delete a model and refresh the list"""

vms/ui/models/tabs/trained_tab.py

@@ -5,6 +5,7 @@ Trained tab for Models view in Video Model Studio UI
 import gradio as gr
 import logging
 from typing import Dict, Any, List, Optional, Tuple
+from gradio_modal import Modal
 
 from vms.utils.base_tab import BaseTab
 
@@ -90,6 +91,16 @@ class TrainedTab(BaseTab):
                                 publish_btn = gr.Button("🌐 Publish", size="sm")
                                 delete_btn = gr.Button("🗑️ Delete", size="sm", variant="stop")
                                 
+                                # Create a modal for this specific model deletion
+                                with Modal(visible=False) as delete_modal:
+                                    gr.Markdown("## ⚠️ Confirm Deletion")
+                                    gr.Markdown(f"Are you sure you want to delete model {model.id[:8]}...?")
+                                    gr.Markdown("This action cannot be undone!")
+                                    
+                                    with gr.Row():
+                                        cancel_btn = gr.Button("🫢 No, cancel", variant="secondary")
+                                        confirm_btn = gr.Button("🚨 Yes, delete", variant="primary")
+
                                 # Connect event handlers for this specific model
                                 preview_btn.click(
                                     fn=lambda model_id=model.id: self.preview_model(model_id),
@@ -109,10 +120,29 @@ class TrainedTab(BaseTab):
                                     outputs=[self.app.main_tabs]
                                 )
                                 
+                                # Connect delete button to show modal
                                 delete_btn.click(
+                                    fn=lambda: Modal(visible=True),
+                                    inputs=[],
+                                    outputs=[delete_modal]
+                                )
+                                
+                                # Connect cancel button to hide modal
+                                cancel_btn.click(
+                                    fn=lambda: Modal(visible=False),
+                                    inputs=[],
+                                    outputs=[delete_modal]
+                                )
+                                
+                                # Connect confirm button to delete and hide modal
+                                confirm_btn.click(
                                     fn=lambda model_id=model.id: self.delete_model(model_id),
                                     inputs=[],
                                     outputs=[new_container]
+                                ).then(
+                                    fn=lambda: Modal(visible=False),
+                                    inputs=[],
+                                    outputs=[delete_modal]
                                 )
         
         return new_container

vms/ui/project/tabs/manage_tab.py

@@ -7,6 +7,7 @@ import logging
 import shutil
 from pathlib import Path
 from typing import Dict, Any, List, Optional
+from gradio_modal import Modal
 
 from vms.utils import BaseTab, validate_model_repo
 from vms.config import (
@@ -90,6 +91,20 @@ class ManageTab(BaseTab):
                         interactive=False,
                         visible=False
                     )
+                    
+                    # Modal for dataset deletion confirmation
+                    with Modal(visible=False) as dataset_delete_modal:
+                        gr.Markdown("## ⚠️ Confirm Deletion")
+                        gr.Markdown("Are you sure you want to delete all dataset files (images, videos, captions)?")
+                        gr.Markdown("This action cannot be undone!")
+                        
+                        with gr.Row():
+                            cancel_dataset_btn = gr.Button("🫢 No, cancel", variant="secondary")
+                            confirm_dataset_btn = gr.Button("🚨 Yes, delete", variant="primary")
+
+                    self.components["dataset_delete_modal"] = dataset_delete_modal
+                    self.components["cancel_dataset_btn"] = cancel_dataset_btn
+                    self.components["confirm_dataset_btn"] = confirm_dataset_btn
                 
                 with gr.Column(scale=1):
                     self.components["delete_model_btn"] = gr.Button(
@@ -101,6 +116,20 @@ class ManageTab(BaseTab):
                         interactive=False,
                         visible=False
                     )
+                    
+                    # Modal for model deletion confirmation
+                    with Modal(visible=False) as model_delete_modal:
+                        gr.Markdown("## ⚠️ Confirm Deletion")
+                        gr.Markdown("Are you sure you want to delete all model files (checkpoints, weights, config)?")
+                        gr.Markdown("This action cannot be undone!")
+                        
+                        with gr.Row():
+                            cancel_model_btn = gr.Button("🫢 No, cancel", variant="secondary")
+                            confirm_model_btn = gr.Button("🚨 Yes, delete", variant="primary")
+
+                    self.components["model_delete_modal"] = model_delete_modal
+                    self.components["cancel_model_btn"] = cancel_model_btn
+                    self.components["confirm_model_btn"] = confirm_model_btn
                 
             with gr.Row():
                 with gr.Column():
@@ -117,6 +146,24 @@ class ManageTab(BaseTab):
                     interactive=False,
                     visible=False
                 )
+                
+                # Modal for global deletion confirmation
+                with Modal(visible=False) as global_delete_modal:
+                    gr.Markdown("## ⚠️ Confirm Complete Data Deletion")
+                    gr.Markdown("Are you sure you want to delete ALL project data and models?")
+                    gr.Markdown("This includes:")
+                    gr.Markdown("- All original datasets (images, videos, captions)")
+                    gr.Markdown("- All training datasets")
+                    gr.Markdown("- All model outputs (weights, checkpoints, settings)")
+                    gr.Markdown("This action cannot be undone!")
+                    
+                    with gr.Row():
+                        cancel_global_btn = gr.Button("🫢 No, cancel", variant="secondary")
+                        confirm_global_btn = gr.Button("🚨 Yes, delete", variant="primary")
+
+                self.components["global_delete_modal"] = global_delete_modal
+                self.components["cancel_global_btn"] = cancel_global_btn
+                self.components["confirm_global_btn"] = confirm_global_btn
         
         return tab
     
@@ -140,26 +187,76 @@ class ManageTab(BaseTab):
             outputs=[self.components["download_model_btn"]]
         )
         
-        # New delete dataset button
+        # Dataset deletion with modal
         self.components["delete_dataset_btn"].click(
+            fn=lambda: Modal(visible=True),
+            inputs=[],
+            outputs=[self.components["dataset_delete_modal"]]
+        )
+        
+        # Modal cancel button
+        self.components["cancel_dataset_btn"].click(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["dataset_delete_modal"]]
+        )
+        
+        # Modal confirm button
+        self.components["confirm_dataset_btn"].click(
             fn=self.delete_dataset,
             outputs=[
                 self.components["delete_dataset_status"],
                 self.app.tabs["caption_tab"].components["training_dataset"]
             ]
+        ).then(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["dataset_delete_modal"]]
         )
         
-        # New delete model button
+        # Model deletion with modal
         self.components["delete_model_btn"].click(
+            fn=lambda: Modal(visible=True),
+            inputs=[],
+            outputs=[self.components["model_delete_modal"]]
+        )
+        
+        # Modal cancel button
+        self.components["cancel_model_btn"].click(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["model_delete_modal"]]
+        )
+        
+        # Modal confirm button
+        self.components["confirm_model_btn"].click(
             fn=self.delete_model,
             outputs=[
                 self.components["delete_model_status"],
                 self.app.tabs["train_tab"].components["status_box"]
             ]
+        ).then(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["model_delete_modal"]]
         )
         
-        # Global stop button
+        # Global stop button with modal
         self.components["global_stop_btn"].click(
+            fn=lambda: Modal(visible=True),
+            inputs=[],
+            outputs=[self.components["global_delete_modal"]]
+        )
+        
+        # Modal cancel button
+        self.components["cancel_global_btn"].click(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["global_delete_modal"]]
+        )
+        
+        # Modal confirm button
+        self.components["confirm_global_btn"].click(
             fn=self.handle_global_stop,
             outputs=[
                 self.components["global_status"],
@@ -169,6 +266,10 @@ class ManageTab(BaseTab):
                 self.app.tabs["import_tab"].components["import_status"],
                 self.app.tabs["caption_tab"].components["preview_status"]
             ]
+        ).then(
+            fn=lambda: Modal(visible=False),
+            inputs=[],
+            outputs=[self.components["global_delete_modal"]]
         )
         
         # Push model button 

vms/ui/project/tabs/train_tab.py

@@ -1118,32 +1118,35 @@ class TrainTab(BaseTab):
         # Create the model version dropdown update
         model_version_update = gr.Dropdown(choices=model_versions, value=default_model_version)
 
-        # Return values in the same order as the output components
+        # Return values in the same order as the output components listed in line 644
+        # Make sure we return exactly 24 values to match what's expected
         return (
-            model_display_name,
-            training_display_name,
-            lora_rank_val,
-            lora_alpha_val,
-            train_steps_val,
-            batch_size_val,
-            learning_rate_val,
-            save_iterations_val,
-            info_text,
-            gr.Row(visible=show_lora_params),
-            num_gpus_val,
-            precomputation_items_val,
-            lr_warmup_steps_val,
-            model_version_update,
+            model_display_name,                             # model_type
+            training_display_name,                          # training_type
+            lora_rank_val,                                 # lora_rank
+            lora_alpha_val,                                # lora_alpha
+            train_steps_val,                               # train_steps
+            batch_size_val,                                # batch_size
+            learning_rate_val,                             # learning_rate
+            save_iterations_val,                           # save_iterations
+            info_text,                                     # preset_info
+            gr.Row(visible=show_lora_params),              # lora_params_row
+            gr.Row(visible=show_lora_params),              # lora_settings_row (added missing row)
+            num_gpus_val,                                  # num_gpus
+            precomputation_items_val,                      # precomputation_items
+            lr_warmup_steps_val,                           # lr_warmup_steps
+            model_version_update,                          # model_version
             # Control parameters rows visibility
-            gr.Row(visible=show_control_params),
-            gr.Row(visible=show_control_params),
-            gr.Row(visible=show_control_params),
+            gr.Row(visible=show_control_params),           # control_params_row
+            gr.Row(visible=show_control_params),           # control_settings_row
+            gr.Row(visible=show_control_params),           # frame_conditioning_row
+            gr.Row(visible=show_control_params),           # control_options_row
             # Control parameter values
-            control_type_val,
-            train_qk_norm_val,
-            frame_conditioning_type_val,
-            frame_conditioning_index_val,
-            frame_conditioning_concatenate_mask_val,
+            control_type_val,                              # control_type
+            train_qk_norm_val,                             # train_qk_norm
+            frame_conditioning_type_val,                   # frame_conditioning_type
+            frame_conditioning_index_val,                  # frame_conditioning_index
+            frame_conditioning_concatenate_mask_val,       # frame_conditioning_concatenate_mask
         )