Spaces:
Sleeping
Sleeping
File size: 5,509 Bytes
ca2592c |
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 |
import pytest
from commafixer.src.baseline import BaselineCommaFixer, _remove_punctuation
from commafixer.src.fixer import CommaFixer
# TODO look up best practices and duplication for tests like these
@pytest.fixture()
def baseline_fixer():
yield BaselineCommaFixer()
@pytest.fixture()
def comma_fixer():
yield CommaFixer()
@pytest.mark.parametrize(
"test_input",
['',
'Hello world.',
'This test string should not have any commas inside it.',
'aAaalLL the.. weird?~! punctuation.should also . be kept-as is! Only fixing-commas.']
)
class TestCorrectStringsAreUnchanged:
def test_model_fix_commas_leaves_correct_strings_unchanged(self, comma_fixer, test_input):
result = comma_fixer.fix_commas(s=test_input)
assert result == test_input
def test_baseline_fix_commas_leaves_correct_strings_unchanged(self, baseline_fixer, test_input):
result = baseline_fixer.fix_commas(s=test_input)
assert result == test_input
@pytest.mark.parametrize(
"test_input, expected",
[
['I, am.', 'I am.'],
['A complex clause however it misses a comma something else and a dot...?',
'A complex clause, however, it misses a comma, something else and a dot...?'],
['a pen an apple, \tand a pineapple!',
'a pen, an apple \tand a pineapple!'],
['Even newlines\ntabs\tand others get preserved.',
'Even newlines,\ntabs\tand others get preserved.'],
['I had no Creativity left, therefore, I come here, and write useless examples, for this test.',
'I had no Creativity left, therefore I come here and write useless examples for this test.'],
[' This is a sentence. With, a lot of, useless punctuation!!??. O.o However we have to insert commas O-O, '
'nonetheless or we will fail this test.',
' This is a sentence. With a lot of useless punctuation!!??. O.o However, we have to insert commas O-O '
'nonetheless, or we will fail this test.'],
[
" The ship 's secondary armament consisted of fourteen 45 @-@ calibre 6 @-@ inch ( 152 mm ) quick @-@ firing ( QF ) guns mounted in casemates . Lighter guns consisted of eight 47 @-@ millimetre ( 1 @.@ 9 in ) three @-@ pounder Hotchkiss guns and four 47 @-@ millimetre 2 @.@ 5 @-@ pounder Hotchkiss guns . The ship was also equipped with four submerged 18 @-@ inch torpedo tubes two on each broadside .",
" The ship 's secondary armament consisted of fourteen 45 @-@ calibre 6 @-@ inch ( 152 mm ) quick @-@ firing ( QF ) guns mounted in casemates . Lighter guns consisted of eight 47 @-@ millimetre ( 1 @.@ 9 in ) three @-@ pounder Hotchkiss guns and four 47 @-@ millimetre 2 @.@ 5 @-@ pounder Hotchkiss guns . The ship was also equipped with four submerged 18 @-@ inch torpedo tubes, two on each broadside ."]
]
)
def test_main_model_fix_commas_fixes_correct_commas(comma_fixer, test_input, expected):
result = comma_fixer.fix_commas(s=test_input)
assert result == expected
@pytest.mark.parametrize(
"test_input, expected",
[
['I, am.', 'I am.'],
['A complex clause however it misses a comma something else and a dot...?',
'A complex clause, however, it misses a comma, something else and a dot...?'],
['a pen an apple, \tand a pineapple!',
'a pen, an apple \tand a pineapple!'],
['Even newlines\ntabs\tand others get preserved.',
'Even newlines,\ntabs\tand others get preserved.'],
['I had no Creativity left, therefore, I come here, and write useless examples, for this test.',
'I had no Creativity left therefore, I come here and write useless examples for this test.'],
[' This is a sentence. With, a lot of, useless punctuation!!??. O.o However we have to insert commas O-O, '
'nonetheless or we will fail this test.',
' This is a sentence. With a lot of useless punctuation!!??. O.o However, we have to insert commas O-O '
'nonetheless, or we will fail this test.'],
[
" The ship 's secondary armament consisted of fourteen 45 @-@ calibre 6 @-@ inch ( 152 mm ) quick @-@ firing ( QF ) guns mounted in casemates . Lighter guns consisted of eight 47 @-@ millimetre ( 1 @.@ 9 in ) three @-@ pounder Hotchkiss guns and four 47 @-@ millimetre 2 @.@ 5 @-@ pounder Hotchkiss guns . The ship was also equipped with four submerged 18 @-@ inch torpedo tubes two on each broadside .",
" The ship 's secondary armament consisted of fourteen 45 @-@ calibre 6 @-@ inch ( 152 mm ) quick @-@ firing ( QF ) guns mounted in casemates . Lighter guns consisted of eight 47 @-@ millimetre ( 1 @.@ 9 in ), three @-@ pounder Hotchkiss guns and four 47 @-@ millimetre 2 @.@ 5 @-@ pounder Hotchkiss guns . The ship was also equipped with four submerged 18 @-@ inch torpedo tubes, two on each broadside ."]
]
)
def test_baseline_fix_commas_fixes_incorrect_commas(baseline_fixer, test_input, expected):
result = baseline_fixer.fix_commas(s=test_input)
assert result == expected
@pytest.mark.parametrize(
"test_input, expected",
[['', ('', [])],
[' world...', (' world', [6, 7, 8])],
[',,,', ('', [])],
['This: test - string should not, have any commas inside it...?',
('This test string should not have any commas inside it', [4, 11, 57, 58, 59, 60])]]
)
def test__remove_punctuation(test_input, expected):
assert _remove_punctuation(test_input) == expected
|