Update core/visual_engine.py

core/visual_engine.py

@@ -4,7 +4,7 @@ import base64
 import mimetypes
 import numpy as np
 import os
-import openai # OpenAI v1.x.x+
+import openai
 import requests
 import io
 import time
@@ -15,17 +15,16 @@ from moviepy.editor import (ImageClip, VideoFileClip, concatenate_videoclips, Te
                             CompositeVideoClip, AudioFileClip)
 import moviepy.video.fx.all as vfx
 
-try: # MONKEY PATCH for Pillow/MoviePy compatibility
-    if hasattr(Image, 'Resampling') and hasattr(Image.Resampling, 'LANCZOS'): # Pillow 9+
+try: # MONKEY PATCH
+    if hasattr(Image, 'Resampling') and hasattr(Image.Resampling, 'LANCZOS'):
         if not hasattr(Image, 'ANTIALIAS'): Image.ANTIALIAS = Image.Resampling.LANCZOS
-    elif hasattr(Image, 'LANCZOS'): # Pillow 8
+    elif hasattr(Image, 'LANCZOS'):
          if not hasattr(Image, 'ANTIALIAS'): Image.ANTIALIAS = Image.LANCZOS
-    elif not hasattr(Image, 'ANTIALIAS'):
-             print("WARNING: Pillow version lacks common Resampling or ANTIALIAS. MoviePy effects might fail.")
-except Exception as e_mp: print(f"WARNING: ANTIALIAS monkey-patch error: {e_mp}")
+    elif not hasattr(Image, 'ANTIALIAS'): print("WARNING: Pillow ANTIALIAS/Resampling issue.")
+except Exception as e_mp: print(f"WARNING: ANTIALIAS patch error: {e_mp}")
 
 logger = logging.getLogger(__name__)
-# logger.setLevel(logging.DEBUG) # Uncomment for maximum verbosity during active debugging
+# logger.setLevel(logging.DEBUG) # Uncomment for verbose debugging
 
 ELEVENLABS_CLIENT_IMPORTED = False; ElevenLabsAPIClient = None; Voice = None; VoiceSettings = None
 try:
@@ -42,126 +41,96 @@ try:
     logger.info("RunwayML SDK imported.")
 except Exception as e_rwy_imp: logger.warning(f"RunwayML SDK import failed: {e_rwy_imp}. RunwayML disabled.")
 
-
 class VisualEngine:
     DEFAULT_FONT_SIZE_PIL = 10; PREFERRED_FONT_SIZE_PIL = 20
     VIDEO_OVERLAY_FONT_SIZE = 30; VIDEO_OVERLAY_FONT_COLOR = 'white'
     DEFAULT_MOVIEPY_FONT = 'DejaVu-Sans-Bold'; PREFERRED_MOVIEPY_FONT = 'Liberation-Sans-Bold'
 
-    # <<< CRITICAL __init__ METHOD - ENSURE IT MATCHES THIS >>>
     def __init__(self, output_dir="temp_cinegen_media", default_elevenlabs_voice_id="Rachel"):
         self.output_dir = output_dir
         try:
             os.makedirs(self.output_dir, exist_ok=True)
             logger.info(f"VisualEngine output directory set/ensured: {os.path.abspath(self.output_dir)}")
-            # Test writability immediately
             test_file_path = os.path.join(self.output_dir, ".ve_write_test.txt")
-            with open(test_file_path, "w") as f_test:
-                f_test.write("VisualEngine write test OK")
-            os.remove(test_file_path)
-            logger.info(f"Write test to output directory '{self.output_dir}' successful.")
-        except Exception as e_mkdir_init: # More specific exception catching
-            logger.critical(f"CRITICAL FAILURE: Could not create or write to output directory '{os.path.abspath(self.output_dir)}': {e_mkdir_init}", exc_info=True)
-            raise OSError(f"VisualEngine failed to initialize output directory '{self.output_dir}'. Check permissions and path.") from e_mkdir_init
-
+            with open(test_file_path, "w") as f_test: f_test.write("VisualEngine write test OK")
+            os.remove(test_file_path); logger.info(f"Write test to '{self.output_dir}' OK.")
+        except Exception as e_mkdir: logger.critical(f"CRITICAL: Failed to create/write to output dir '{os.path.abspath(self.output_dir)}': {e_mkdir}", exc_info=True); raise OSError(f"VisualEngine failed to init output dir: {self.output_dir}") from e_mkdir
         self.font_filename_pil_preference = "DejaVuSans-Bold.ttf"
-        font_paths_to_try = [ self.font_filename_pil_preference, f"/usr/share/fonts/truetype/dejavu/{self.font_filename_pil_preference}", f"/usr/share/fonts/truetype/liberation/LiberationSans-Bold.ttf", f"/System/Library/Fonts/Supplemental/Arial.ttf", f"C:/Windows/Fonts/arial.ttf", f"/usr/local/share/fonts/truetype/mycustomfonts/arial.ttf"]
-        self.resolved_font_path_pil = next((p for p in font_paths_to_try if os.path.exists(p)), None)
-        
-        self.active_font_pil = ImageFont.load_default() 
-        self.active_font_size_pil = self.DEFAULT_FONT_SIZE_PIL
-        self.active_moviepy_font_name = self.DEFAULT_MOVIEPY_FONT
-
+        font_paths = [ self.font_filename_pil_preference, f"/usr/share/fonts/truetype/dejavu/{self.font_filename_pil_preference}", f"/usr/share/fonts/truetype/liberation/LiberationSans-Bold.ttf", f"/System/Library/Fonts/Supplemental/Arial.ttf", f"C:/Windows/Fonts/arial.ttf", f"/usr/local/share/fonts/truetype/mycustomfonts/arial.ttf"]
+        self.resolved_font_path_pil = next((p for p in font_paths if os.path.exists(p)), None)
+        self.active_font_pil = ImageFont.load_default(); self.active_font_size_pil = self.DEFAULT_FONT_SIZE_PIL; self.active_moviepy_font_name = self.DEFAULT_MOVIEPY_FONT
         if self.resolved_font_path_pil:
-            try:
-                self.active_font_pil = ImageFont.truetype(self.resolved_font_path_pil, self.PREFERRED_FONT_SIZE_PIL)
-                self.active_font_size_pil = self.PREFERRED_FONT_SIZE_PIL
-                logger.info(f"Pillow font loaded: {self.resolved_font_path_pil} at size {self.active_font_size_pil}.")
-                self.active_moviepy_font_name = 'DejaVu-Sans-Bold' if "dejavu" in self.resolved_font_path_pil.lower() else ('Liberation-Sans-Bold' if "liberation" in self.resolved_font_path_pil.lower() else self.DEFAULT_MOVIEPY_FONT)
-            except IOError as e_font_load: logger.error(f"Pillow font IOError for '{self.resolved_font_path_pil}': {e_font_load}. Using default.")
-        else: logger.warning("Preferred Pillow font not found in predefined paths. Using default.")
-        
+            try: self.active_font_pil = ImageFont.truetype(self.resolved_font_path_pil, self.PREFERRED_FONT_SIZE_PIL); self.active_font_size_pil = self.PREFERRED_FONT_SIZE_PIL; logger.info(f"Pillow font: {self.resolved_font_path_pil} sz {self.active_font_size_pil}."); self.active_moviepy_font_name = 'DejaVu-Sans-Bold' if "dejavu" in self.resolved_font_path_pil.lower() else ('Liberation-Sans-Bold' if "liberation" in self.resolved_font_path_pil.lower() else self.DEFAULT_MOVIEPY_FONT)
+            except IOError as e_font: logger.error(f"Pillow font IOError '{self.resolved_font_path_pil}': {e_font}. Default.")
+        else: logger.warning("Preferred Pillow font not found. Default.")
         self.openai_api_key = None; self.USE_AI_IMAGE_GENERATION = False; self.dalle_model = "dall-e-3"; self.image_size_dalle3 = "1792x1024"
         self.video_frame_size = (1280, 720)
-        
-        self.elevenlabs_api_key = None; self.USE_ELEVENLABS = False; self.elevenlabs_client_instance = None
-        self.elevenlabs_voice_id = default_elevenlabs_voice_id 
-        logger.info(f"VisualEngine __init__: ElevenLabs Voice ID initially set to: {self.elevenlabs_voice_id}")
-
+        self.elevenlabs_api_key = None; self.USE_ELEVENLABS = False; self.elevenlabs_client_instance = None; self.elevenlabs_voice_id = default_elevenlabs_voice_id
+        logger.info(f"VisualEngine __init__: 11L Voice ID initially: {self.elevenlabs_voice_id}")
         if VoiceSettings and ELEVENLABS_CLIENT_IMPORTED: self.elevenlabs_voice_settings_obj = VoiceSettings(stability=0.60, similarity_boost=0.80, style=0.15, use_speaker_boost=True)
         else: self.elevenlabs_voice_settings_obj = None
-        
         self.pexels_api_key = None; self.USE_PEXELS = False
         self.runway_api_key = None; self.USE_RUNWAYML = False; self.runway_ml_sdk_client_instance = None
-        
         if RUNWAYML_SDK_IMPORTED and RunwayMLAPIClientClass and os.getenv("RUNWAYML_API_SECRET"):
-            try: self.runway_ml_sdk_client_instance = RunwayMLAPIClientClass(); self.USE_RUNWAYML = True; logger.info("RunwayML Client initialized using RUNWAYML_API_SECRET env var at startup.")
-            except Exception as e_rwy_init_constructor: logger.error(f"Initial RunwayML client initialization via env var failed: {e_rwy_init_constructor}"); self.USE_RUNWAYML = False
-        
-        logger.info("VisualEngine __init__ sequence fully completed.")
+            try: self.runway_ml_sdk_client_instance = RunwayMLAPIClientClass(); self.USE_RUNWAYML = True; logger.info("RunwayML Client init from env var at startup.")
+            except Exception as e_rwy_init: logger.error(f"Initial RunwayML client init failed: {e_rwy_init}"); self.USE_RUNWAYML = False
+        logger.info("VisualEngine __init__ sequence complete.")
 
-    def set_openai_api_key(self, api_key_value): self.openai_api_key = api_key_value; self.USE_AI_IMAGE_GENERATION = bool(api_key_value); logger.info(f"DALL-E status: {'Ready' if self.USE_AI_IMAGE_GENERATION else 'Disabled'}")
-    
-    def set_elevenlabs_api_key(self, api_key_value, voice_id_from_secret=None):
-        self.elevenlabs_api_key = api_key_value
-        if voice_id_from_secret: self.elevenlabs_voice_id = voice_id_from_secret; logger.info(f"11L Voice ID updated via set_elevenlabs_api_key to: {self.elevenlabs_voice_id}")
-        
-        if api_key_value and ELEVENLABS_CLIENT_IMPORTED and ElevenLabsAPIClient:
-            try: self.elevenlabs_client_instance = ElevenLabsAPIClient(api_key=api_key_value); self.USE_ELEVENLABS = bool(self.elevenlabs_client_instance); logger.info(f"11L Client: {'Ready' if self.USE_ELEVENLABS else 'Failed Initialization'} (Using Voice: {self.elevenlabs_voice_id})")
-            except Exception as e_11l_setkey_init: logger.error(f"11L client initialization error: {e_11l_setkey_init}. Service Disabled.", exc_info=True); self.USE_ELEVENLABS=False; self.elevenlabs_client_instance=None
-        else: self.USE_ELEVENLABS = False; logger.info(f"11L Service Disabled (API key not provided or SDK component issue).")
-    
-    def set_pexels_api_key(self, api_key_value): self.pexels_api_key = api_key_value; self.USE_PEXELS = bool(api_key_value); logger.info(f"Pexels status: {'Ready' if self.USE_PEXELS else 'Disabled'}")
-    
-    def set_runway_api_key(self, api_key_value):
-        self.runway_api_key = api_key_value
-        if api_key_value:
+    # --- API Key Setters (Keep as previously corrected) ---
+    def set_openai_api_key(self, k): self.openai_api_key=k; self.USE_AI_IMAGE_GENERATION=bool(k); logger.info(f"DALL-E: {'Ready' if self.USE_AI_IMAGE_GENERATION else 'Disabled'}")
+    def set_elevenlabs_api_key(self, k, vid=None):
+        self.elevenlabs_api_key=k;
+        if vid: self.elevenlabs_voice_id = vid; logger.info(f"11L Voice ID updated to: {vid}")
+        if k and ELEVENLABS_CLIENT_IMPORTED and ElevenLabsAPIClient:
+            try: self.elevenlabs_client_instance = ElevenLabsAPIClient(api_key=k); self.USE_ELEVENLABS=True; logger.info(f"11L Client: Ready (Voice:{self.elevenlabs_voice_id})")
+            except Exception as e: logger.error(f"11L client init err: {e}. Disabled.", exc_info=True); self.USE_ELEVENLABS=False; self.elevenlabs_client_instance=None
+        else: self.USE_ELEVENLABS = False; logger.info(f"11L Disabled (key/SDK).")
+    def set_pexels_api_key(self, k): self.pexels_api_key=k; self.USE_PEXELS=bool(k); logger.info(f"Pexels: {'Ready' if self.USE_PEXELS else 'Disabled'}")
+    def set_runway_api_key(self, k):
+        self.runway_api_key = k
+        if k:
             if RUNWAYML_SDK_IMPORTED and RunwayMLAPIClientClass:
-                if not self.runway_ml_sdk_client_instance: # If not already initialized by env var
+                if not self.runway_ml_sdk_client_instance:
                     try:
-                        original_env_secret_val = os.getenv("RUNWAYML_API_SECRET") # Renamed
-                        if not original_env_secret_val: os.environ["RUNWAYML_API_SECRET"] = api_key_value; logger.info("Temporarily set RUNWAYML_API_SECRET from provided key for SDK client init.")
-                        self.runway_ml_sdk_client_instance = RunwayMLAPIClientClass(); self.USE_RUNWAYML = True; logger.info("RunwayML Client initialized successfully via set_runway_api_key.")
-                        if not original_env_secret_val: del os.environ["RUNWAYML_API_SECRET"]; logger.info("Cleared temporary RUNWAYML_API_SECRET environment variable.")
-                    except Exception as e_runway_setkey_init_local: logger.error(f"RunwayML Client initialization in set_runway_api_key failed: {e_runway_setkey_init_local}", exc_info=True); self.USE_RUNWAYML=False;self.runway_ml_sdk_client_instance=None # Renamed
-                else: self.USE_RUNWAYML = True; logger.info("RunwayML Client was already initialized (likely from environment variable). API key stored.")
-            else: logger.warning("RunwayML SDK not imported. API key stored, but current integration relies on SDK. Service effectively disabled."); self.USE_RUNWAYML = False
-        else: self.USE_RUNWAYML = False; self.runway_ml_sdk_client_instance = None; logger.info("RunwayML Service Disabled (no API key provided).")
+                        orig_secret = os.getenv("RUNWAYML_API_SECRET")
+                        if not orig_secret: os.environ["RUNWAYML_API_SECRET"]=k; logger.info("Temp set RUNWAYML_API_SECRET for SDK.")
+                        self.runway_ml_sdk_client_instance=RunwayMLAPIClientClass(); self.USE_RUNWAYML=True; logger.info("RunwayML Client init via set_key.")
+                        if not orig_secret: del os.environ["RUNWAYML_API_SECRET"]; logger.info("Cleared temp RUNWAYML_API_SECRET.")
+                    except Exception as e: logger.error(f"RunwayML Client init in set_key fail: {e}", exc_info=True); self.USE_RUNWAYML=False;self.runway_ml_sdk_client_instance=None
+                else: self.USE_RUNWAYML=True; logger.info("RunwayML Client already init.")
+            else: logger.warning("RunwayML SDK not imported. Disabled."); self.USE_RUNWAYML=False
+        else: self.USE_RUNWAYML=False; self.runway_ml_sdk_client_instance=None; logger.info("RunwayML Disabled (no key).")
 
-    # --- Helper Methods (_image_to_data_uri, _map_resolution_to_runway_ratio, etc.) ---
-    # (These should be the corrected versions from previous iterations)
-    def _image_to_data_uri(self, image_path_in): # Renamed image_path
+    # --- Helper Methods (_image_to_data_uri, _map_resolution_to_runway_ratio, _get_text_dimensions, etc.) ---
+    # (These should be the corrected versions from previous iterations - ensure try/except blocks are complete)
+    def _image_to_data_uri(self, image_path_in):
         try:
-            mime_type_val, _ = mimetypes.guess_type(image_path_in) # Renamed
-            if not mime_type_val:
-                file_ext = os.path.splitext(image_path_in)[1].lower() # Renamed
-                mime_type_map = {".png": "image/png", ".jpg": "image/jpeg", ".jpeg": "image/jpeg", ".webp": "image/webp"} # Renamed
-                mime_type_val = mime_type_map.get(file_ext, "application/octet-stream")
-                if mime_type_val == "application/octet-stream": logger.warning(f"Could not determine MIME type for {image_path_in} from ext '{file_ext}', using default {mime_type_val}.")
-            with open(image_path_in, "rb") as img_file_handle: img_binary_data = img_file_handle.read() # Renamed
-            encoded_b64_str = base64.b64encode(img_binary_data).decode('utf-8') # Renamed
-            final_data_uri = f"data:{mime_type_val};base64,{encoded_b64_str}"; logger.debug(f"Data URI for {os.path.basename(image_path_in)} (MIME:{mime_type_val}): {final_data_uri[:100]}..."); return final_data_uri # Renamed
+            mime_type_val, _ = mimetypes.guess_type(image_path_in)
+            if not mime_type_val: ext = os.path.splitext(image_path_in)[1].lower(); mime_map = {".png": "image/png", ".jpg": "image/jpeg", ".jpeg": "image/jpeg", ".webp": "image/webp"}; mime_type_val = mime_map.get(ext, "application/octet-stream");
+            if mime_type_val == "application/octet-stream": logger.warning(f"Unknown MIME for {image_path_in}, using {mime_type_val}.")
+            with open(image_path_in, "rb") as img_file_handle: img_binary_data = img_file_handle.read()
+            encoded_b64_str = base64.b64encode(img_binary_data).decode('utf-8')
+            final_data_uri = f"data:{mime_type_val};base64,{encoded_b64_str}"; logger.debug(f"Data URI for {os.path.basename(image_path_in)} (MIME:{mime_type_val}): {final_data_uri[:100]}..."); return final_data_uri
         except FileNotFoundError: logger.error(f"Img not found {image_path_in} for data URI."); return None
-        except Exception as e_to_data_uri: logger.error(f"Error converting {image_path_in} to data URI:{e_to_data_uri}", exc_info=True); return None # Renamed
+        except Exception as e_to_data_uri: logger.error(f"Error converting {image_path_in} to data URI:{e_to_data_uri}", exc_info=True); return None
 
-    def _map_resolution_to_runway_ratio(self, width_in, height_in): # Renamed
-        ratio_string = f"{width_in}:{height_in}"; supported_ratios = ["1280:720","720:1280","1104:832","832:1104","960:960","1584:672"]; # Renamed
+    def _map_resolution_to_runway_ratio(self, width_in, height_in):
+        ratio_string = f"{width_in}:{height_in}"; supported_ratios = ["1280:720","720:1280","1104:832","832:1104","960:960","1584:672"];
         if ratio_string in supported_ratios: return ratio_string
-        logger.warning(f"Res {ratio_string} not in Gen-4 list. Default 1280:720 for Runway."); return "1280:720"
+        logger.warning(f"Res {ratio_string} not in Gen-4 list. Default 1280:720 for Runway.");return "1280:720"
 
-    def _get_text_dimensions(self, text_str, font_pil_obj): # Renamed
+    def _get_text_dimensions(self, text_str, font_pil_obj):
         def_h = getattr(font_pil_obj, 'size', self.active_font_size_pil);
         if not text_str: return 0, def_h
         try:
-            if hasattr(font_pil_obj,'getbbox'): box = font_pil_obj.getbbox(text_str); w_val=box[2]-box[0]; h_val=box[3]-box[1]; return w_val, h_val if h_val > 0 else def_h # Renamed
-            elif hasattr(font_pil_obj,'getsize'): w_val,h_val=font_pil_obj.getsize(text_str); return w_val, h_val if h_val > 0 else def_h # Renamed
+            if hasattr(font_pil_obj,'getbbox'): box = font_pil_obj.getbbox(text_str); w_val=box[2]-box[0]; h_val=box[3]-box[1]; return w_val, h_val if h_val > 0 else def_h
+            elif hasattr(font_pil_obj,'getsize'): w_val,h_val=font_pil_obj.getsize(text_str); return w_val, h_val if h_val > 0 else def_h
             else: return int(len(text_str)*def_h*0.6), int(def_h*1.2)
-        except Exception as e_get_dim: logger.warning(f"Error in _get_text_dimensions: {e_get_dim}"); return int(len(text_str)*self.active_font_size_pil*0.6),int(self.active_font_size_pil*1.2) # Renamed
+        except Exception as e_get_dim: logger.warning(f"Error in _get_text_dimensions: {e_get_dim}"); return int(len(text_str)*self.active_font_size_pil*0.6),int(self.active_font_size_pil*1.2)
 
-    def _create_placeholder_image_content(self,text_desc_val, filename_val, size_val=None): # Renamed
-        # (Corrected version from previous responses)
+    def _create_placeholder_image_content(self,text_desc_val, filename_val, size_val=None):
         if size_val is None: size_val = self.video_frame_size
-        placeholder_img = Image.new('RGB', size_val, color=(20, 20, 40)); placeholder_draw = ImageDraw.Draw(placeholder_img); ph_padding = 25 # Renamed
+        placeholder_img = Image.new('RGB', size_val, color=(20, 20, 40)); placeholder_draw = ImageDraw.Draw(placeholder_img); ph_padding = 25
         ph_max_w = size_val[0] - (2 * ph_padding); ph_lines = []
         if not text_desc_val: text_desc_val = "(Placeholder Image)"
         ph_words = text_desc_val.split(); ph_current_line = ""
@@ -197,44 +166,33 @@ class VisualEngine:
         try: placeholder_img.save(ph_filepath); return ph_filepath
         except Exception as e_ph_save: logger.error(f"Saving placeholder image '{ph_filepath}' error: {e_ph_save}", exc_info=True); return None
 
-    def _search_pexels_image(self, pexels_query, pexels_output_fn_base): # Renamed
+    def _search_pexels_image(self, query_str_px, output_fn_base_px):
         if not self.USE_PEXELS or not self.pexels_api_key: return None
-        pexels_headers = {"Authorization": self.pexels_api_key}
-        pexels_params = {"query": pexels_query, "per_page": 1, "orientation": "landscape", "size": "large2x"}
-        pexels_base_name, _ = os.path.splitext(pexels_output_fn_base)
-        pexels_output_filename = pexels_base_name + f"_pexels_{random.randint(1000,9999)}.jpg"
-        pexels_filepath = os.path.join(self.output_dir, pexels_output_filename)
+        http_headers_px = {"Authorization": self.pexels_api_key}
+        http_params_px = {"query": query_str_px, "per_page": 1, "orientation": "landscape", "size": "large2x"}
+        base_name_for_pexels_img, _ = os.path.splitext(output_fn_base_px)
+        pexels_filename_output = base_name_for_pexels_img + f"_pexels_{random.randint(1000,9999)}.jpg"
+        filepath_for_pexels_img = os.path.join(self.output_dir, pexels_filename_output)
         try:
-            logger.info(f"Pexels: Searching for '{pexels_query}'")
-            pexels_eff_query = " ".join(pexels_query.split()[:5])
-            pexels_params["query"] = pexels_eff_query
-            pexels_response = requests.get("https://api.pexels.com/v1/search", headers=pexels_headers, params=pexels_params, timeout=20)
-            pexels_response.raise_for_status()
-            pexels_data = pexels_response.json()
-            if pexels_data.get("photos") and len(pexels_data["photos"]) > 0:
-                pexels_photo_details = pexels_data["photos"][0]
-                pexels_photo_url = pexels_photo_details.get("src", {}).get("large2x")
-                if not pexels_photo_url: logger.warning(f"Pexels: 'large2x' URL missing for '{pexels_eff_query}'. Details: {pexels_photo_details}"); return None
-                pexels_image_response = requests.get(pexels_photo_url, timeout=60); pexels_image_response.raise_for_status()
-                pexels_img_pil_data = Image.open(io.BytesIO(pexels_image_response.content))
-                if pexels_img_pil_data.mode != 'RGB': pexels_img_pil_data = pexels_img_pil_data.convert('RGB')
-                pexels_img_pil_data.save(pexels_filepath); logger.info(f"Pexels: Image saved to {pexels_filepath}"); return pexels_filepath
-            else: logger.info(f"Pexels: No photos for '{pexels_eff_query}'."); return None
-        except requests.exceptions.RequestException as e_pexels_req: logger.error(f"Pexels: RequestException for '{pexels_query}': {e_pexels_req}", exc_info=False); return None
-        except Exception as e_pexels_general: logger.error(f"Pexels: General error for '{pexels_query}': {e_pexels_general}", exc_info=True); return None
-
-    # ... (Rest of methods: _generate_video_clip_with_runwayml, generate_scene_asset, generate_narration_audio, assemble_animatic_from_assets)
-    # Ensure these are taken from the last fully corrected versions provided, paying close attention to their specific fixes.
-    # For example, generate_narration_audio had its own try-except fix.
-    # assemble_animatic_from_assets had extensive debugging for image corruption.
-
-    # For brevity, I will paste the corrected generate_narration_audio and the
-    # structure for generate_scene_asset and assemble_animatic_from_assets.
-    # You MUST ensure the internal logic of generate_scene_asset and assemble_animatic_from_assets
-    # matches the last "expert" versions that included detailed debugging for image/video issues.
+            logger.info(f"Pexels: Searching for '{query_str_px}'")
+            effective_query_for_pexels = " ".join(query_str_px.split()[:5])
+            http_params_px["query"] = effective_query_for_pexels
+            response_from_pexels = requests.get("https://api.pexels.com/v1/search", headers=http_headers_px, params=http_params_px, timeout=20)
+            response_from_pexels.raise_for_status()
+            data_from_pexels = response_from_pexels.json()
+            if data_from_pexels.get("photos") and len(data_from_pexels["photos"]) > 0:
+                photo_details_item_px = data_from_pexels["photos"][0]
+                photo_url_item_px = photo_details_item_px.get("src", {}).get("large2x")
+                if not photo_url_item_px: logger.warning(f"Pexels: 'large2x' URL missing for '{effective_query_for_pexels}'. Details: {photo_details_item_px}"); return None
+                image_response_get_px = requests.get(photo_url_item_px, timeout=60); image_response_get_px.raise_for_status()
+                img_pil_data_from_pexels = Image.open(io.BytesIO(image_response_get_px.content))
+                if img_pil_data_from_pexels.mode != 'RGB': img_pil_data_from_pexels = img_pil_data_from_pexels.convert('RGB')
+                img_pil_data_from_pexels.save(filepath_for_pexels_img); logger.info(f"Pexels: Image saved to {filepath_for_pexels_img}"); return filepath_for_pexels_img
+            else: logger.info(f"Pexels: No photos for '{effective_query_for_pexels}'."); return None
+        except requests.exceptions.RequestException as e_req_px_loop: logger.error(f"Pexels: RequestException for '{query_str_px}': {e_req_px_loop}", exc_info=False); return None
+        except Exception as e_px_gen_loop: logger.error(f"Pexels: General error for '{query_str_px}': {e_px_gen_loop}", exc_info=True); return None
 
     def _generate_video_clip_with_runwayml(self, motion_prompt_rwy, input_img_path_rwy, scene_id_base_fn_rwy, duration_s_rwy=5):
-        # (Keep robust RunwayML logic from before, with proper SDK client instance: self.runway_ml_sdk_client_instance)
         if not self.USE_RUNWAYML or not self.runway_ml_sdk_client_instance: logger.warning("RunwayML skip: Not enabled/client not init."); return None
         if not input_img_path_rwy or not os.path.exists(input_img_path_rwy): logger.error(f"Runway Gen-4 needs input img. Invalid: {input_img_path_rwy}"); return None
         img_data_uri_rwy = self._image_to_data_uri(input_img_path_rwy)
@@ -283,9 +241,8 @@ class VisualEngine:
                 except Exception as e_close_placeholder_clip: logger.warning(f"Ignoring error closing placeholder TextClip: {e_close_placeholder_clip}")
     
     def generate_scene_asset(self, image_generation_prompt_text, motion_prompt_text_for_video,
-                             scene_data_dict, scene_identifier_fn_base,
-                             generate_as_video_clip_flag=False, runway_target_dur_val=5):
-        # (Corrected DALL-E loop from previous response)
+                             scene_data_dictionary, scene_identifier_fn_base,
+                             generate_as_video_clip_flag=False, runway_target_duration_val=5):
         base_name_current_asset, _ = os.path.splitext(scene_identifier_fn_base)
         asset_info_return_obj = {'path': None, 'type': 'none', 'error': True, 'prompt_used': image_generation_prompt_text, 'error_message': 'Asset generation init failed'}
         path_to_input_image_for_runway = None
@@ -323,41 +280,33 @@ class VisualEngine:
             else:logger.warning("RunwayML selected but disabled. Use base img.");asset_info_return_obj['error']=True;asset_info_return_obj['error_message']=(asset_info_return_obj.get('error_message',"Base img ok.")+" RunwayML disabled; use base img.").strip();asset_info_return_obj['path']=path_to_input_image_for_runway;asset_info_return_obj['type']='image';asset_info_return_obj['prompt_used']=image_generation_prompt_text
         return asset_info_return_obj
 
-    def generate_narration_audio(self, text_to_narrate, output_filename="narration_overall.mp3"):
-        # <<< CORRECTED METHOD with try/except >>>
-        if not self.USE_ELEVENLABS or not self.elevenlabs_client_instance or not text_to_narrate:
-            logger.info("ElevenLabs conditions not met (service disabled, client not init, or no text). Skipping audio generation.")
-            return None
-        audio_filepath_narration = os.path.join(self.output_dir, output_filename)
-        try: # Main try block for the entire operation
-            logger.info(f"Generating ElevenLabs audio (Voice ID: {self.elevenlabs_voice_id}) for text: \"{text_to_narrate[:70]}...\"")
-            audio_stream_method_11l = None
-            if hasattr(self.elevenlabs_client_instance, 'text_to_speech') and hasattr(self.elevenlabs_client_instance.text_to_speech, 'stream'):
-                audio_stream_method_11l = self.elevenlabs_client_instance.text_to_speech.stream; logger.info("Using ElevenLabs SDK method: client.text_to_speech.stream()")
-            elif hasattr(self.elevenlabs_client_instance, 'generate_stream'):
-                audio_stream_method_11l = self.elevenlabs_client_instance.generate_stream; logger.info("Using ElevenLabs SDK method: client.generate_stream()")
-            elif hasattr(self.elevenlabs_client_instance, 'generate'):
-                logger.info("Using ElevenLabs SDK method: client.generate() (non-streaming).")
-                voice_param_11l = str(self.elevenlabs_voice_id)
-                if Voice and self.elevenlabs_voice_settings_obj: voice_param_11l = Voice(voice_id=str(self.elevenlabs_voice_id), settings=self.elevenlabs_voice_settings_obj)
-                audio_bytes_data = self.elevenlabs_client_instance.generate(text=text_to_narrate, voice=voice_param_11l, model="eleven_multilingual_v2")
-                with open(audio_filepath_narration, "wb") as audio_file_out: audio_file_out.write(audio_bytes_data)
-                logger.info(f"ElevenLabs audio (non-streamed) saved successfully to: {audio_filepath_narration}"); return audio_filepath_narration
-            else: logger.error("No recognized audio generation method found on the ElevenLabs client instance."); return None
-
-            if audio_stream_method_11l:
-                params_for_voice_stream = {"voice_id": str(self.elevenlabs_voice_id)}
+    def generate_narration_audio(self, narration_text, output_fn="narration_overall.mp3"):
+        if not self.USE_ELEVENLABS or not self.elevenlabs_client_instance or not narration_text: logger.info("11L conditions not met. Skip audio."); return None
+        narration_fp = os.path.join(self.output_dir, output_fn)
+        try:
+            logger.info(f"11L audio (Voice:{self.elevenlabs_voice_id}): \"{narration_text[:70]}...\"")
+            stream_method = None
+            if hasattr(self.elevenlabs_client_instance,'text_to_speech') and hasattr(self.elevenlabs_client_instance.text_to_speech,'stream'): stream_method=self.elevenlabs_client_instance.text_to_speech.stream; logger.info("Using 11L .text_to_speech.stream()")
+            elif hasattr(self.elevenlabs_client_instance,'generate_stream'): stream_method=self.elevenlabs_client_instance.generate_stream; logger.info("Using 11L .generate_stream()")
+            elif hasattr(self.elevenlabs_client_instance,'generate'):
+                logger.info("Using 11L .generate() (non-streaming).")
+                voice_p = Voice(voice_id=str(self.elevenlabs_voice_id),settings=self.elevenlabs_voice_settings_obj) if Voice and self.elevenlabs_voice_settings_obj else str(self.elevenlabs_voice_id)
+                audio_b = self.elevenlabs_client_instance.generate(text=narration_text,voice=voice_p,model="eleven_multilingual_v2")
+                with open(narration_fp,"wb") as f_audio: f_audio.write(audio_b); logger.info(f"11L audio (non-stream): {narration_fp}"); return narration_fp
+            else: logger.error("No recognized 11L audio method."); return None
+            if stream_method:
+                voice_stream_params={"voice_id":str(self.elevenlabs_voice_id)}
                 if self.elevenlabs_voice_settings_obj:
-                    if hasattr(self.elevenlabs_voice_settings_obj, 'model_dump'): params_for_voice_stream["voice_settings"] = self.elevenlabs_voice_settings_obj.model_dump()
-                    elif hasattr(self.elevenlabs_voice_settings_obj, 'dict'): params_for_voice_stream["voice_settings"] = self.elevenlabs_voice_settings_obj.dict()
-                    else: params_for_voice_stream["voice_settings"] = self.elevenlabs_voice_settings_obj
-                audio_data_iterator_11l = audio_stream_method_11l(text=text_to_narrate, model_id="eleven_multilingual_v2", **params_for_voice_stream)
-                with open(audio_filepath_narration, "wb") as audio_file_out_stream:
-                    for audio_chunk_data in audio_data_iterator_11l:
-                        if audio_chunk_data: audio_file_out_stream.write(audio_chunk_data)
-                logger.info(f"ElevenLabs audio (streamed) saved successfully to: {audio_filepath_narration}"); return audio_filepath_narration
-        except AttributeError as ae_11l_sdk: logger.error(f"AttributeError with ElevenLabs SDK client: {ae_11l_sdk}. SDK version/methods might differ.", exc_info=True); return None
-        except Exception as e_11l_general_audio: logger.error(f"General error during ElevenLabs audio generation: {e_11l_general_audio}", exc_info=True); return None
+                    if hasattr(self.elevenlabs_voice_settings_obj,'model_dump'): voice_stream_params["voice_settings"]=self.elevenlabs_voice_settings_obj.model_dump()
+                    elif hasattr(self.elevenlabs_voice_settings_obj,'dict'): voice_stream_params["voice_settings"]=self.elevenlabs_voice_settings_obj.dict()
+                    else: voice_stream_params["voice_settings"]=self.elevenlabs_voice_settings_obj
+                audio_iter = stream_method(text=narration_text,model_id="eleven_multilingual_v2",**voice_stream_params)
+                with open(narration_fp,"wb") as f_audio_stream:
+                    for chunk_item in audio_iter:
+                        if chunk_item: f_audio_stream.write(chunk_item)
+                logger.info(f"11L audio (stream): {narration_fp}"); return narration_fp
+        except AttributeError as e_11l_attr: logger.error(f"11L SDK AttrError: {e_11l_attr}. SDK/methods changed?", exc_info=True); return None
+        except Exception as e_11l_gen: logger.error(f"11L audio gen error: {e_11l_gen}", exc_info=True); return None
 
     def assemble_animatic_from_assets(self, asset_data_list, overall_narration_path=None, output_filename="final_video.mp4", fps=24):
         if not asset_data_list: logger.warning("No assets for animatic."); return None
@@ -394,8 +343,7 @@ class VisualEngine:
                     logger.debug(f"S{num_of_scene} (6-ImageClip): Base ImageClip. Duration: {base_image_clip_mvpy.duration}")
 
                     debug_path_moviepy_frame = os.path.join(self.output_dir,f"debug_7_MOVIEPY_FRAME_S{num_of_scene}.png")
-                    # <<< THIS IS THE CORRECTED TRY-EXCEPT BLOCK >>>
-                    try:
+                    try: # <<< CORRECTED: This try now has an except >>>
                         save_frame_time = min(0.1, base_image_clip_mvpy.duration / 2 if base_image_clip_mvpy.duration > 0 else 0.1)
                         base_image_clip_mvpy.save_frame(debug_path_moviepy_frame, t=save_frame_time) 
                         logger.info(f"CRITICAL DEBUG: Saved frame FROM MOVIEPY ImageClip S{num_of_scene} to {debug_path_moviepy_frame}")
@@ -403,12 +351,13 @@ class VisualEngine:
                         logger.error(f"DEBUG: Error saving frame FROM MOVIEPY ImageClip S{num_of_scene}: {e_save_mvpy_frame}", exc_info=True)
                     
                     fx_image_clip_mvpy = base_image_clip_mvpy
-                    try:
+                    try: # Ken Burns try block
                         scale_end_kb_val = random.uniform(1.03, 1.08)
                         if duration_for_scene > 0: fx_image_clip_mvpy = base_image_clip_mvpy.fx(vfx.resize, lambda t_val: 1 + (scale_end_kb_val - 1) * (t_val / duration_for_scene)).set_position('center'); logger.debug(f"S{num_of_scene} (8-KenBurns): Ken Burns applied.")
                         else: logger.warning(f"S{num_of_scene}: Duration zero, skipping Ken Burns.")
-                    except Exception as e_kb_fx_loop: logger.error(f"S{num_of_scene} Ken Burns error: {e_kb_fx_loop}", exc_info=False)
-                    active_scene_clip = fx_image_clip_mvpy
+                    except Exception as e_kb_fx_loop: # Except for Ken Burns
+                        logger.error(f"S{num_of_scene} Ken Burns error: {e_kb_fx_loop}", exc_info=False)
+                    active_scene_clip = fx_image_clip_mvpy # Assign result (either original or with FX)
                 elif type_of_asset == 'video':
                     source_video_clip_obj=None
                     try:
@@ -429,7 +378,8 @@ class VisualEngine:
                             try: source_video_clip_obj.close()
                             except Exception as e_close_src_vid: logger.warning(f"S{num_of_scene}: Error closing source VideoFileClip: {e_close_src_vid}")
                 else: logger.warning(f"S{num_of_scene} Unknown asset type '{type_of_asset}'. Skipping."); continue
-                if active_scene_clip and action_in_key:
+                
+                if active_scene_clip and action_in_key: # Text Overlay
                     try:
                         dur_text_overlay_val=min(active_scene_clip.duration-0.5,active_scene_clip.duration*0.8)if active_scene_clip.duration>0.5 else (active_scene_clip.duration if active_scene_clip.duration > 0 else 0)
                         start_text_overlay_val=0.25 if active_scene_clip.duration > 0.5 else 0
@@ -439,11 +389,12 @@ class VisualEngine:
                             logger.debug(f"S{num_of_scene}: Text overlay composited.")
                         else: logger.warning(f"S{num_of_scene}: Text overlay duration zero or negative ({dur_text_overlay_val}). Skipping text overlay.")
                     except Exception as e_txt_comp_loop:logger.error(f"S{num_of_scene} TextClip compositing error:{e_txt_comp_loop}. Proceeding without text for this scene.",exc_info=True)
+                
                 if active_scene_clip: processed_moviepy_clips_list.append(active_scene_clip); logger.info(f"S{num_of_scene}: Asset successfully processed. Clip duration: {active_scene_clip.duration:.2f}s. Added to final list.")
             except Exception as e_asset_loop_main_exc: logger.error(f"MAJOR UNHANDLED ERROR processing asset for S{num_of_scene} (Path: {path_of_asset}): {e_asset_loop_main_exc}", exc_info=True)
-            finally:
-                if active_scene_clip and hasattr(active_scene_clip,'close'):
-                    try: active_scene_clip.close()
+            finally: # Ensure individual clip created in this iteration is closed if it's not added or an error occurs
+                if active_scene_clip and active_scene_clip not in processed_moviepy_clips_list and hasattr(active_scene_clip,'close'):
+                    try: active_scene_clip.close(); logger.debug(f"S{num_of_scene}: Closed active_scene_clip in asset loop finally block.")
                     except Exception as e_close_active_err: logger.warning(f"S{num_of_scene}: Error closing active_scene_clip in error handler: {e_close_active_err}")
         
         if not processed_moviepy_clips_list: logger.warning("No MoviePy clips were successfully processed. Aborting animatic assembly before concatenation."); return None
@@ -471,9 +422,16 @@ class VisualEngine:
         except Exception as e_vid_write_final_op: logger.error(f"Error during final animatic video file writing or composition stage: {e_vid_write_final_op}", exc_info=True); return None
         finally:
             logger.debug("Closing all MoviePy clips in `assemble_animatic_from_assets` main finally block.")
-            all_clips_for_closure = processed_moviepy_clips_list[:]
+            all_clips_for_closure = processed_moviepy_clips_list[:] # Start with a copy of the list of clips that were successfully processed and added
             if narration_audio_clip_mvpy and hasattr(narration_audio_clip_mvpy, 'close'): all_clips_for_closure.append(narration_audio_clip_mvpy)
-            if final_video_output_clip and hasattr(final_video_output_clip, 'close'): all_clips_for_closure.append(final_video_output_clip)
+            # final_video_output_clip itself is composed of other clips; closing it might close its sources if not already closed.
+            # If concatenate_videoclips or effects create new intermediate clips that aren't in processed_moviepy_clips_list,
+            # those might need more careful handling. However, MoviePy usually manages this.
+            # We will explicitly close the final composite clip if it exists.
+            if final_video_output_clip and hasattr(final_video_output_clip, 'close'):
+                 if final_video_output_clip not in all_clips_for_closure : # Avoid double-adding if it was the only clip
+                    all_clips_for_closure.append(final_video_output_clip)
+
             for clip_to_close_item_final in all_clips_for_closure:
                 if clip_to_close_item_final and hasattr(clip_to_close_item_final, 'close'):
                     try: clip_to_close_item_final.close()