Update app.py

app.py

@@ -32,7 +32,6 @@ if 'GEMINI_API_KEY' not in st.session_state:
 if 'gemini_handler' not in st.session_state:
     st.session_state.gemini_handler = GeminiHandler(api_key=st.session_state.GEMINI_API_KEY)
 if 'visual_engine' not in st.session_state:
-    # Ensure VisualEngine is initialized (it will print font loading status)
     st.session_state.visual_engine = VisualEngine(output_dir="temp_cinegen_media")
 
 # Story and generated content
@@ -59,11 +58,13 @@ def initialize_new_story():
     st.session_state.scene_image_prompts = []
     st.session_state.generated_images_paths = []
     st.session_state.video_path = None
-    # Clear old media files if any (optional, good for space management on persistent storage)
-    # For Hugging Face Spaces, temp files are usually cleared on restart/rebuild anyway.
+    # Optional: Clear old media files
     # if os.path.exists(st.session_state.visual_engine.output_dir):
-    #     for f in os.listdir(st.session_state.visual_engine.output_dir):
-    #         os.remove(os.path.join(st.session_state.visual_engine.output_dir, f))
+    #     for f_name in os.listdir(st.session_state.visual_engine.output_dir):
+    #         try:
+    #             os.remove(os.path.join(st.session_state.visual_engine.output_dir, f_name))
+    #         except OSError: # File might be in use by video player, handle gracefully
+    #             print(f"Could not remove {f_name}, it might be in use.")
 
 
 def generate_visual_for_scene_wrapper(scene_index, scene_data, is_regeneration=False, version_count=1):
@@ -71,61 +72,49 @@ def generate_visual_for_scene_wrapper(scene_index, scene_data, is_regeneration=F
     Wrapper to generate the textual image prompt and then the actual visual.
     Updates session state for prompts and image paths.
     """
-    st.info(f"Generating visual concept for Scene {scene_data.get('scene_number', scene_index + 1)}...")
+    scene_num_for_log = scene_data.get('scene_number', scene_index + 1)
+    st.info(f"Processing visual concept for Scene {scene_num_for_log} (v{version_count})...")
     
-    # 1. Get/Regenerate the detailed image prompt TEXT
+    textual_image_prompt = ""
     if is_regeneration and scene_index < len(st.session_state.scene_image_prompts):
-        # For regeneration, we assume the prompt text is already updated in session state
-        # (e.g., by a call to create_visual_regeneration_prompt and Gemini)
         textual_image_prompt = st.session_state.scene_image_prompts[scene_index]
+        st.caption(f"Using (potentially refined) prompt for Scene {scene_num_for_log}.")
     else:
         textual_image_prompt = create_image_prompt_from_scene_data(
             scene_data,
             st.session_state.character_definitions,
             st.session_state.style_reference_description
         )
-        # Optional: Call Gemini here to refine this initial prompt if desired
-        # textual_image_prompt = st.session_state.gemini_handler.generate_image_prompt(textual_image_prompt)
+        st.caption(f"Generated initial prompt for Scene {scene_num_for_log}.")
 
     if not textual_image_prompt:
-        st.error(f"Failed to create textual image prompt for Scene {scene_data.get('scene_number', scene_index + 1)}.")
+        st.error(f"Failed to create/retrieve textual image prompt for Scene {scene_num_for_log}.")
         return False
 
-    # Update session state for the textual prompt
-    if scene_index < len(st.session_state.scene_image_prompts):
-        st.session_state.scene_image_prompts[scene_index] = textual_image_prompt
-    else:
-        # Ensure list is long enough before appending (shouldn't happen if initialized correctly)
+    # Update session state for the textual prompt if it's new or changed
+    if scene_index >= len(st.session_state.scene_image_prompts):
         while len(st.session_state.scene_image_prompts) <= scene_index:
              st.session_state.scene_image_prompts.append("")
-        st.session_state.scene_image_prompts[scene_index] = textual_image_prompt
-
+    st.session_state.scene_image_prompts[scene_index] = textual_image_prompt
 
-    # 2. Generate the actual visual (AI or placeholder) using the textual prompt
-    image_filename = f"scene_{scene_data.get('scene_number', scene_index + 1)}_visual_v{version_count}.png"
+    image_filename = f"scene_{scene_num_for_log}_visual_v{version_count}.png"
     
     generated_image_path = st.session_state.visual_engine.generate_image_visual(
         textual_image_prompt,
         image_filename
     )
 
+    # Ensure generated_images_paths is long enough
+    while len(st.session_state.generated_images_paths) <= scene_index:
+        st.session_state.generated_images_paths.append(None)
+
     if generated_image_path and os.path.exists(generated_image_path):
-        st.success(f"Visual concept for Scene {scene_data.get('scene_number', scene_index + 1)} generated: {os.path.basename(generated_image_path)}")
-        if scene_index < len(st.session_state.generated_images_paths):
-            st.session_state.generated_images_paths[scene_index] = generated_image_path
-        else:
-            while len(st.session_state.generated_images_paths) <= scene_index:
-                st.session_state.generated_images_paths.append(None)
-            st.session_state.generated_images_paths[scene_index] = generated_image_path
+        st.success(f"Visual concept for Scene {scene_num_for_log} (v{version_count}) available: {os.path.basename(generated_image_path)}")
+        st.session_state.generated_images_paths[scene_index] = generated_image_path
         return True
     else:
-        st.error(f"Visual generation failed for Scene {scene_data.get('scene_number', scene_index + 1)} (path: {generated_image_path}).")
-        if scene_index < len(st.session_state.generated_images_paths):
-            st.session_state.generated_images_paths[scene_index] = None
-        else:
-            while len(st.session_state.generated_images_paths) <= scene_index:
-                st.session_state.generated_images_paths.append(None)
-            st.session_state.generated_images_paths[scene_index] = None
+        st.error(f"Visual generation failed for Scene {scene_num_for_log} (v{version_count}). Path: {generated_image_path}")
+        st.session_state.generated_images_paths[scene_index] = None
         return False
 
 # --- UI Sidebar ---
@@ -135,7 +124,7 @@ with st.sidebar:
     user_idea = st.text_area("Enter your core story idea:", "A detective in a cyberpunk city investigates a rogue AI that believes it's the next step in evolution.", height=100, key="user_idea_input")
     genre = st.selectbox("Genre:", ["Sci-Fi", "Fantasy", "Noir", "Thriller", "Drama", "Horror"], index=2, key="genre_select")
     mood = st.selectbox("Mood:", ["Suspenseful", "Mysterious", "Gritty", "Epic", "Dark", "Hopeful"], index=2, key="mood_select")
-    num_scenes_val = st.slider("Number of Scenes:", 1, 5, 3, key="num_scenes_slider") # Max 5 for now
+    num_scenes_val = st.slider("Number of Scenes:", 1, 5, 3, key="num_scenes_slider")
 
     if st.button("✨ Generate Full Story Concept", type="primary", key="generate_full_story_btn"):
         initialize_new_story()
@@ -148,7 +137,6 @@ with st.sidebar:
                     st.session_state.story_scenes = st.session_state.gemini_handler.generate_story_breakdown(story_prompt_text)
                     st.toast("Script breakdown complete!", icon="✅")
 
-                    # Initialize placeholders for prompts and images based on number of scenes
                     num_actual_scenes = len(st.session_state.story_scenes)
                     st.session_state.scene_image_prompts = [""] * num_actual_scenes
                     st.session_state.generated_images_paths = [None] * num_actual_scenes
@@ -160,8 +148,8 @@ with st.sidebar:
             if st.session_state.story_scenes:
                 with st.spinner("Phase 2: Generating initial visual concepts... 🖼️"):
                     success_count = 0
-                    for i, scene_data_loop_var in enumerate(st.session_state.story_scenes):
-                        if generate_visual_for_scene_wrapper(i, scene_data_loop_var, version_count=1):
+                    for i_loop, scene_data_loop_var in enumerate(st.session_state.story_scenes):
+                        if generate_visual_for_scene_wrapper(i_loop, scene_data_loop_var, version_count=1):
                             success_count +=1
                     if success_count == len(st.session_state.story_scenes):
                         st.toast("Initial visual concepts generated!", icon="🖼️")
@@ -170,24 +158,24 @@ with st.sidebar:
 
 
     st.markdown("---")
-    st.markdown("### Advanced Options (Conceptual)")
+    st.markdown("### Advanced Options")
     with st.expander("Character Consistency", expanded=False):
-        char_name_input = st.text_input("Character Name (e.g., Eva)", key="char_name")
-        char_desc_input = st.text_area("Character Description (for visual consistency)", key="char_desc", height=80)
-        if st.button("Add/Update Character", key="add_char_btn"):
+        char_name_input = st.text_input("Character Name (e.g., Eva)", key="char_name_adv_input") # Unique key
+        char_desc_input = st.text_area("Character Description (for visual consistency)", key="char_desc_adv_input", height=80) # Unique key
+        if st.button("Add/Update Character", key="add_char_adv_btn"): # Unique key
             if char_name_input and char_desc_input:
                 st.session_state.character_definitions[char_name_input] = char_desc_input
                 st.success(f"Character '{char_name_input}' defined.")
             else:
                 st.warning("Please provide both name and description.")
         if st.session_state.character_definitions:
-            st.write("Defined Characters:")
+            st.caption("Defined Characters:")
             for char, desc in st.session_state.character_definitions.items():
-                st.caption(f"**{char}:** {desc}")
+                st.markdown(f"**{char}:** _{desc}_")
 
     with st.expander("Style Transfer", expanded=False):
-        style_ref_text = st.text_area("Describe Style (e.g., 'Van Gogh inspired, swirling brushstrokes')", key="style_text_input", height=80)
-        if st.button("Apply Textual Style", key="apply_style_btn"):
+        style_ref_text = st.text_area("Describe Style (e.g., 'Van Gogh inspired, swirling brushstrokes')", key="style_text_adv_input", height=80) # Unique key
+        if st.button("Apply Textual Style", key="apply_style_adv_btn"): # Unique key
             st.session_state.style_reference_description = style_ref_text
             st.success("Style reference applied. Re-generate visuals or full story to see changes.")
 
@@ -199,14 +187,16 @@ if not st.session_state.story_scenes:
 else:
     for i, scene_data_display in enumerate(st.session_state.story_scenes):
         scene_num_display = scene_data_display.get('scene_number', i + 1)
-        # Use a unique key part for expanders if scene numbers can repeat or change
-        expander_key_part = scene_data_display.get('key_action', f"scene{i}")[:20].replace(" ", "")
+        # Create a more robust unique part for keys, sanitizing special characters
+        action_summary = scene_data_display.get('key_action', f"scene{i}")
+        key_part_raw = ''.join(e for e in action_summary if e.isalnum() or e.isspace())
+        unique_key_part = key_part_raw.replace(" ", "_")[:20] # Take first 20 alphanumeric/space chars
 
         st.subheader(f"Scene {scene_num_display}: {scene_data_display.get('emotional_beat', 'Untitled Scene')}")
 
-        col1, col2 = st.columns([2, 3])
+        col1, col2 = st.columns([2, 3]) # Ratio for text vs image
 
-        with col1: # Scene Details
+        with col1: 
             with st.expander("Scene Details", expanded=True):
                 st.markdown(f"**Setting:** {scene_data_display.get('setting_description', 'N/A')}")
                 st.markdown(f"**Characters:** {', '.join(scene_data_display.get('characters_involved', []))}")
@@ -215,28 +205,25 @@ else:
                 st.markdown(f"**Visual Style:** {scene_data_display.get('visual_style_suggestion', 'N/A')}")
                 st.markdown(f"**Camera:** {scene_data_display.get('camera_angle_suggestion', 'N/A')}")
                 
-                if i < len(st.session_state.scene_image_prompts) and st.session_state.scene_image_prompts[i]:
-                     with st.popover("View Image Prompt Text"):
+                current_textual_prompt = st.session_state.scene_image_prompts[i] if i < len(st.session_state.scene_image_prompts) else None
+                if current_textual_prompt:
+                     with st.popover("View Image Prompt Text"): 
                         st.markdown(f"**Textual Prompt for Image Generation:**")
-                        st.code(st.session_state.scene_image_prompts[i], language='text')
+                        st.code(current_textual_prompt, language='text')
 
-        with col2: # Image and Interactive Editing
-            if i < len(st.session_state.generated_images_paths) and \
-               st.session_state.generated_images_paths[i] and \
-               os.path.exists(st.session_state.generated_images_paths[i]):
-                st.image(st.session_state.generated_images_paths[i], caption=f"Visual Concept for Scene {scene_num_display}")
+        with col2: 
+            current_image_path = st.session_state.generated_images_paths[i] if i < len(st.session_state.generated_images_paths) else None
+            if current_image_path and os.path.exists(current_image_path):
+                st.image(current_image_path, caption=f"Visual Concept for Scene {scene_num_display}")
             else:
-                if st.session_state.story_scenes: # Only show if story generation was attempted
-                    st.warning("Visual concept not generated or path is invalid for this scene.")
-
-            # Interactive Storyboarding UI using unique keys for each scene's widgets
-            popover_script_key = f"pop_script_{expander_key_part}_{i}"
-            popover_visual_key = f"pop_visual_{expander_key_part}_{i}"
-            
-            with st.popover(f"✏️ Edit Scene {scene_num_display} Script", key=popover_script_key):
+                if st.session_state.story_scenes: 
+                    st.info("Visual concept for this scene is pending or failed.")
+
+            # Removed 'key' argument from st.popover calls
+            with st.popover(f"✏️ Edit Scene {scene_num_display} Script"): 
                 feedback_script = st.text_area("Describe changes to script details:",
-                    key=f"script_feedback_{expander_key_part}_{i}", height=100)
-                if st.button(f"🔄 Regenerate Scene {scene_num_display} Script", key=f"regen_script_btn_{expander_key_part}_{i}"):
+                    key=f"script_feedback_{unique_key_part}_{i}", height=100) 
+                if st.button(f"🔄 Regenerate Scene {scene_num_display} Script", key=f"regen_script_btn_{unique_key_part}_{i}"): 
                     if feedback_script:
                         with st.spinner(f"Gemini is rewriting Scene {scene_num_display}..."):
                             regen_prompt = create_scene_regeneration_prompt(
@@ -244,66 +231,58 @@ else:
                             )
                             try:
                                 updated_scene_data = st.session_state.gemini_handler.regenerate_scene_script_details(regen_prompt)
-                                st.session_state.story_scenes[i] = updated_scene_data
+                                st.session_state.story_scenes[i] = updated_scene_data 
                                 st.toast(f"Scene {scene_num_display} script updated!", icon="✍️")
-                                # Regenerate visuals for this updated scene with new script details
-                                # Increment version for the image filename
-                                current_version = 1
-                                if st.session_state.generated_images_paths[i]:
-                                    try: # Try to extract version from existing filename
-                                        base, ext = os.path.splitext(os.path.basename(st.session_state.generated_images_paths[i]))
-                                        if '_v' in base:
-                                            current_version = int(base.split('_v')[-1]) + 1
-                                    except ValueError: pass # Keep current_version as 1 if parsing fails
                                 
-                                generate_visual_for_scene_wrapper(i, updated_scene_data, is_regeneration=True, version_count=current_version)
+                                version = 1
+                                if current_image_path:
+                                    try: 
+                                        base, _ = os.path.splitext(os.path.basename(current_image_path))
+                                        if '_v' in base: version = int(base.split('_v')[-1]) + 1
+                                    except (ValueError, AttributeError, TypeError): pass
+                                
+                                generate_visual_for_scene_wrapper(i, updated_scene_data, is_regeneration=True, version_count=version)
                                 st.rerun()
                             except Exception as e:
                                 st.error(f"Error regenerating scene script: {e}")
                     else:
                         st.warning("Please provide feedback for script regeneration.")
 
-            with st.popover(f"🎨 Edit Scene {scene_num_display} Visuals", key=popover_visual_key):
-                current_prompt_for_edit = st.session_state.scene_image_prompts[i] if i < len(st.session_state.scene_image_prompts) else "No prompt yet."
+            with st.popover(f"🎨 Edit Scene {scene_num_display} Visuals"): 
+                prompt_for_edit_visuals = st.session_state.scene_image_prompts[i] if i < len(st.session_state.scene_image_prompts) else "No prompt text available."
                 st.caption("Current Image Prompt Text:")
-                st.code(current_prompt_for_edit, language='text')
+                st.code(prompt_for_edit_visuals, language='text')
                 
                 feedback_visual = st.text_area("Describe visual changes to apply to the prompt:",
-                    key=f"visual_feedback_{expander_key_part}_{i}", height=100)
-                if st.button(f"🔄 Regenerate Scene {scene_num_display} Visuals", key=f"regen_visual_btn_{expander_key_part}_{i}"):
+                    key=f"visual_feedback_{unique_key_part}_{i}", height=100) 
+                if st.button(f"🔄 Regenerate Scene {scene_num_display} Visuals", key=f"regen_visual_btn_{unique_key_part}_{i}"): 
                     if feedback_visual:
                         with st.spinner(f"Refining image prompt for Scene {scene_num_display}..."):
-                            # This creates a prompt FOR GEMINI to refine the image prompt
                             prompt_refinement_request = create_visual_regeneration_prompt(
-                                current_prompt_for_edit,
-                                feedback_visual,
-                                scene_data_display 
+                                prompt_for_edit_visuals, feedback_visual, scene_data_display 
                             )
                             try:
-                                # Gemini refines the textual image prompt
                                 refined_textual_image_prompt = st.session_state.gemini_handler.regenerate_image_prompt_from_feedback(prompt_refinement_request)
-                                st.session_state.scene_image_prompts[i] = refined_textual_image_prompt
+                                st.session_state.scene_image_prompts[i] = refined_textual_image_prompt 
                                 st.toast(f"Image prompt for Scene {scene_num_display} refined!", icon="💡")
 
-                                # Now generate the new visual using the refined prompt
-                                current_version = 1
-                                if st.session_state.generated_images_paths[i]:
+                                version = 1
+                                if current_image_path:
                                     try:
-                                        base, ext = os.path.splitext(os.path.basename(st.session_state.generated_images_paths[i]))
-                                        if '_v' in base:
-                                            current_version = int(base.split('_v')[-1]) + 1
-                                    except ValueError: pass
+                                        base, _ = os.path.splitext(os.path.basename(current_image_path))
+                                        if '_v' in base: version = int(base.split('_v')[-1]) + 1
+                                    except (ValueError, AttributeError, TypeError): pass
                                 
-                                generate_visual_for_scene_wrapper(i, scene_data_display, is_regeneration=True, version_count=current_version)
+                                generate_visual_for_scene_wrapper(i, scene_data_display, is_regeneration=True, version_count=version)
                                 st.rerun()
                             except Exception as e:
                                 st.error(f"Error refining image prompt or regenerating visual: {e}")
                     else:
                         st.warning("Please provide feedback for visual regeneration.")
         st.markdown("---")
-
+    
     # Video Generation Button
-    if st.session_state.story_scenes and any(p for p in st.session_state.generated_images_paths): # Check if any image exists
+    if st.session_state.story_scenes and any(p for p in st.session_state.generated_images_paths if p is not None):
         if st.button("🎬 Assemble Animatic Video", key="assemble_video_btn", type="primary"):
             with st.spinner("Assembling video... This might take a moment."):
                 valid_image_paths_for_video = [p for p in st.session_state.generated_images_paths if p and os.path.exists(p)]
@@ -317,32 +296,29 @@ else:
                         st.toast("Animatic video assembled!", icon="🎞️")
                         st.balloons()
                     else:
-                        st.error("Video assembly failed. Check logs for details.")
+                        st.error("Video assembly failed. Check application logs for details from VisualEngine.")
                 else:
-                    st.error("No valid images found to assemble video. Please generate visuals for scenes first.")
-    elif st.session_state.story_scenes: # Story exists but no images yet
-         st.warning("Generate visuals for scenes before assembling the video.")
-
+                    st.error("No valid images found to assemble video. Please ensure visuals were generated successfully.")
+    elif st.session_state.story_scenes:
+         st.info("Generate visuals for scenes before assembling the video.")
 
     if st.session_state.video_path and os.path.exists(st.session_state.video_path):
         st.header("🎬 Generated Animatic Video")
         try:
-            with open(st.session_state.video_path, 'rb') as video_file:
-                video_bytes = video_file.read()
-            st.video(video_bytes)
-            st.markdown(f"Video saved at: `{st.session_state.video_path}` (within the Space's file system)")
-            # Provide a download button for the video
-            with open(st.session_state.video_path, "rb") as fp_download:
+            with open(st.session_state.video_path, 'rb') as video_file_obj:
+                video_bytes_content = video_file_obj.read()
+            st.video(video_bytes_content)
+            # Download button
+            with open(st.session_state.video_path, "rb") as fp_download_video:
                 st.download_button(
                     label="Download Animatic Video",
-                    data=fp_download,
-                    file_name=os.path.basename(st.session_state.video_path),
+                    data=fp_download_video,
+                    file_name=os.path.basename(st.session_state.video_path), # e.g., "cinegen_pro_animatic.mp4"
                     mime="video/mp4"
                 )
         except Exception as e:
             st.error(f"Error displaying or preparing video for download: {e}")
 
-
-# --- Footer or additional info ---
+# --- Footer ---
 st.sidebar.markdown("---")
-st.sidebar.info("CineGen AI by [Your Name/Company]. Powered by Gemini & Streamlit.")
+st.sidebar.caption("CineGen AI Pro | Powered by Gemini & Streamlit")