Update app.py

app.py

@@ -9,7 +9,6 @@ from core.prompt_engineering import (
     create_visual_regeneration_prompt
 )
 import os
-# import json # Only if you need to st.json for debugging
 
 # --- Configuration & Initialization ---
 st.set_page_config(page_title="CineGen AI Pro", layout="wide", initial_sidebar_state="expanded")
@@ -36,27 +35,23 @@ if 'gemini_handler' not in st.session_state:
 # Initialize Visual Engine and set OpenAI API Key
 if 'visual_engine' not in st.session_state:
     st.session_state.visual_engine = VisualEngine(output_dir="temp_cinegen_media")
-    # --- TRY TO SET OPENAI API KEY FOR VISUAL ENGINE ---
     openai_key_from_secrets = None
     try:
-        # Check Streamlit Cloud secrets first
         if "OPENAI_API_KEY" in st.secrets:
             openai_key_from_secrets = st.secrets["OPENAI_API_KEY"]
-    except AttributeError: # st.secrets might not exist in all local dev environments
+    except AttributeError: 
         print("st.secrets not available (likely local dev without secrets.toml). Checking environment variables.")
     except Exception as e:
         print(f"Could not access st.secrets for OPENAI_API_KEY: {e}")
 
-    if not openai_key_from_secrets and "OPENAI_API_KEY" in os.environ: # Fallback to env var
+    if not openai_key_from_secrets and "OPENAI_API_KEY" in os.environ: 
         openai_key_from_secrets = os.environ["OPENAI_API_KEY"]
     
     if openai_key_from_secrets:
         st.session_state.visual_engine.set_openai_api_key(openai_key_from_secrets)
-        # st.sidebar.caption("OpenAI API Key loaded. DALL-E ready.") # Optional UI feedback
     else:
         st.session_state.visual_engine.set_openai_api_key(None) 
         st.sidebar.caption("OpenAI API Key for DALL-E not found. Visuals will be placeholders.")
-    # --- END OF OPENAI API KEY SETUP ---
 
 # Story and generated content state
 if 'story_scenes' not in st.session_state: 
@@ -81,42 +76,31 @@ def initialize_new_story():
 
 def generate_visual_for_scene_wrapper(scene_index, scene_data, is_regeneration=False, version_count=1):
     scene_num_for_log = scene_data.get('scene_number', scene_index + 1)
-    
     textual_image_prompt = ""
     if is_regeneration and scene_index < len(st.session_state.scene_image_prompts) and st.session_state.scene_image_prompts[scene_index]:
         textual_image_prompt = st.session_state.scene_image_prompts[scene_index]
-        # st.caption(f"Using refined prompt for Scene {scene_num_for_log}.") # Can be noisy
     else:
         textual_image_prompt = create_image_prompt_from_scene_data(
             scene_data,
             st.session_state.character_definitions,
             st.session_state.style_reference_description
         )
-        # st.caption(f"Generated initial prompt for Scene {scene_num_for_log}.") # Can be noisy
-
     if not textual_image_prompt:
-        # st.error(f"Failed to create/retrieve textual image prompt for Scene {scene_num_for_log}.") # Handled by status
         return False
-
     if scene_index >= len(st.session_state.scene_image_prompts):
         while len(st.session_state.scene_image_prompts) <= scene_index:
              st.session_state.scene_image_prompts.append("")
     st.session_state.scene_image_prompts[scene_index] = textual_image_prompt
-
     image_filename = f"scene_{scene_num_for_log}_visual_v{version_count}.png"
-    
     generated_image_path = st.session_state.visual_engine.generate_image_visual(
         textual_image_prompt, image_filename
     )
-
     while len(st.session_state.generated_images_paths) <= scene_index:
         st.session_state.generated_images_paths.append(None)
-
     if generated_image_path and os.path.exists(generated_image_path):
         st.session_state.generated_images_paths[scene_index] = generated_image_path
         return True
     else:
-        # st.warning(f"Visual for Scene {scene_num_for_log} (v{version_count}) failed or path invalid.") # Handled by status
         st.session_state.generated_images_paths[scene_index] = None
         return False
 
@@ -127,7 +111,7 @@ with st.sidebar:
     user_idea = st.text_area("Enter your core story idea:", "A lone astronaut discovers a glowing alien artifact on Mars, a sense of wonder and slight dread.", height=100, key="user_idea_input")
     genre = st.selectbox("Genre:", ["Sci-Fi", "Fantasy", "Noir", "Thriller", "Drama", "Horror", "Cyberpunk"], index=6, key="genre_select")
     mood = st.selectbox("Mood:", ["Suspenseful", "Mysterious", "Gritty", "Epic", "Dark", "Hopeful", "Wonder"], index=6, key="mood_select")
-    num_scenes_val = st.slider("Number of Scenes:", 1, 5, 3, key="num_scenes_slider") # Max 5 for sensible generation times
+    num_scenes_val = st.slider("Number of Scenes:", 1, 5, 1, key="num_scenes_slider") # Default to 1 for faster testing
 
     if st.button("✨ Generate Full Story Concept", type="primary", key="generate_full_story_btn", use_container_width=True):
         initialize_new_story()
@@ -140,18 +124,15 @@ with st.sidebar:
                 try:
                     st.session_state.story_scenes = st.session_state.gemini_handler.generate_story_breakdown(story_prompt_text)
                     status_main.update(label="Script breakdown complete! ✅", state="running", expanded=True)
-
                     num_actual_scenes = len(st.session_state.story_scenes)
                     st.session_state.scene_image_prompts = [""] * num_actual_scenes
                     st.session_state.generated_images_paths = [None] * num_actual_scenes
-
                 except Exception as e:
                     status_main.update(label=f"Failed to generate story breakdown: {e}", state="error", expanded=True)
-                    st.session_state.story_scenes = [] # Ensure it's empty on failure
+                    st.session_state.story_scenes = [] 
                     st.stop() 
-
                 if st.session_state.story_scenes:
-                    st.write("Phase 2: Generating initial visual concepts... 🖼️ (This may take a few minutes per scene with DALL-E)")
+                    st.write("Phase 2: Generating initial visual concepts... 🖼️ (This may take time with DALL-E)")
                     success_count = 0
                     for i_loop, scene_data_loop_var in enumerate(st.session_state.story_scenes):
                         scene_num_log = scene_data_loop_var.get('scene_number', i_loop + 1)
@@ -161,7 +142,6 @@ with st.sidebar:
                             st.write(f"Visual for Scene {scene_num_log} done.")
                         else:
                             st.write(f"Visual for Scene {scene_num_log} failed.")
-                    
                     if success_count == len(st.session_state.story_scenes):
                         status_main.update(label="All concepts generated successfully! 🎉", state="complete", expanded=False)
                     elif success_count > 0:
@@ -176,7 +156,6 @@ with st.sidebar:
         char_desc_input = st.text_area("Character Description (e.g., 'female, short red hair, green eyes, wearing a blue jumpsuit')", key="char_desc_adv_input", height=100)
         if st.button("Add/Update Character", key="add_char_adv_btn"):
             if char_name_input and char_desc_input:
-                # Store character names in lowercase for easier matching, but keep original for display if needed
                 st.session_state.character_definitions[char_name_input.strip().lower()] = char_desc_input.strip()
                 st.success(f"Character '{char_name_input.strip()}' defined.")
             else:
@@ -184,7 +163,7 @@ with st.sidebar:
         if st.session_state.character_definitions:
             st.caption("Defined Characters:")
             for char_key, desc_val in st.session_state.character_definitions.items():
-                st.markdown(f"**{char_key.title()}:** _{desc_val}_") # Display with title case
+                st.markdown(f"**{char_key.title()}:** _{desc_val}_")
 
     with st.expander("Style Transfer", expanded=False):
         style_ref_text = st.text_area("Describe Visual Style (e.g., 'impressionistic oil painting, vibrant colors')", key="style_text_adv_input", height=100)
@@ -224,7 +203,8 @@ else:
         with col2: 
             current_image_path = st.session_state.generated_images_paths[i] if i < len(st.session_state.generated_images_paths) else None
             if current_image_path and os.path.exists(current_image_path):
-                st.image(current_image_path, caption=f"Visual Concept for Scene {scene_num_display}", use_column_width=True)
+                # MODIFICATION HERE: Removed use_column_width=True
+                st.image(current_image_path, caption=f"Visual Concept for Scene {scene_num_display}") 
             else:
                 if st.session_state.story_scenes: 
                     st.caption("Visual for this scene is pending or failed to generate.")
@@ -242,14 +222,12 @@ else:
                                 updated_scene_data = st.session_state.gemini_handler.regenerate_scene_script_details(regen_prompt)
                                 st.session_state.story_scenes[i] = updated_scene_data 
                                 status_script_regen.update(label="Script updated! Regenerating visual...", state="running")
-                                
                                 version = 1
                                 if current_image_path:
                                     try: 
                                         base, _ = os.path.splitext(os.path.basename(current_image_path))
                                         if '_v' in base: version = int(base.split('_v')[-1]) + 1
                                     except : pass
-                                
                                 if generate_visual_for_scene_wrapper(i, updated_scene_data, is_regeneration=True, version_count=version):
                                     status_script_regen.update(label="Scene script & visual updated! 🎉", state="complete", expanded=False)
                                 else:
@@ -264,7 +242,6 @@ else:
                 prompt_for_edit_visuals = st.session_state.scene_image_prompts[i] if i < len(st.session_state.scene_image_prompts) else "No prompt text available."
                 st.caption("Current Image Prompt Text:")
                 st.code(prompt_for_edit_visuals, language='text')
-                
                 feedback_visual = st.text_area("Describe visual changes to apply to the prompt:",
                     key=f"visual_feedback_{unique_key_part}_{i}", height=100) 
                 if st.button(f"🔄 Regenerate Scene {scene_num_display} Visuals", key=f"regen_visual_btn_{unique_key_part}_{i}"): 
@@ -277,15 +254,12 @@ else:
                                 refined_textual_image_prompt = st.session_state.gemini_handler.regenerate_image_prompt_from_feedback(prompt_refinement_request)
                                 st.session_state.scene_image_prompts[i] = refined_textual_image_prompt 
                                 status_visual_regen.update(label="Image prompt refined! Regenerating visual...", state="running")
-
                                 version = 1
                                 if current_image_path:
                                     try:
                                         base, _ = os.path.splitext(os.path.basename(current_image_path))
                                         if '_v' in base: version = int(base.split('_v')[-1]) + 1
                                     except : pass
-                                
-                                # Pass current scene_data_display as scene content hasn't changed, only the prompt.
                                 if generate_visual_for_scene_wrapper(i, scene_data_display, is_regeneration=True, version_count=version):
                                     status_visual_regen.update(label="Visual for Scene updated! 🎉", state="complete", expanded=False)
                                 else:
@@ -309,7 +283,6 @@ else:
                             'scene_num': scene_info.get('scene_number', idx + 1),
                             'key_action': scene_info.get('key_action', '') 
                         })
-                
                 if image_data_for_video:
                     st.session_state.video_path = st.session_state.visual_engine.create_video_from_images(
                         image_data_for_video, 
@@ -332,12 +305,12 @@ else:
         try:
             with open(st.session_state.video_path, 'rb') as video_file_obj:
                 video_bytes_content = video_file_obj.read()
-            st.video(video_bytes_content, format="video/mp4") # Specify format for better compatibility
+            st.video(video_bytes_content, format="video/mp4") 
             with open(st.session_state.video_path, "rb") as fp_download_video:
                 st.download_button(
                     label="Download Enhanced Animatic", data=fp_download_video,
                     file_name=os.path.basename(st.session_state.video_path), mime="video/mp4",
-                    use_container_width=True, key="download_video_btn" # Added key
+                    use_container_width=True, key="download_video_btn" 
                 )
         except Exception as e:
             st.error(f"Error displaying or preparing video for download: {e}")