Update app.py

app.py

@@ -10,12 +10,13 @@ from core.prompt_engineering import (
     create_visual_regeneration_prompt   
 )
 import os
-import logging # For better logging
+import logging
 
 # --- Configuration & Initialization ---
 st.set_page_config(page_title="CineGen AI Ultra+", layout="wide", initial_sidebar_state="expanded")
+# Setup logger for this app module
 logging.basicConfig(level=logging.INFO, format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
-logger = logging.getLogger(__name__)
+logger = logging.getLogger(__name__) # Use __name__ for module-specific logger
 
 # --- Global State Variables & API Key Setup ---
 def load_api_key(key_name_streamlit, key_name_env, service_name):
@@ -24,7 +25,7 @@ def load_api_key(key_name_streamlit, key_name_env, service_name):
         if secrets_available and key_name_streamlit in st.secrets:
             key = st.secrets[key_name_streamlit]
             if key: logger.info(f"{service_name} API Key found in Streamlit secrets.")
-    except Exception as e: logger.warning(f"Could not access st.secrets for {key_name_streamlit}: {e}")
+    except Exception as e: logger.warning(f"Could not access st.secrets for {key_name_streamlit} (may be local dev or misconfiguration): {e}")
     if not key and key_name_env in os.environ:
         key = os.environ[key_name_env]
         if key: logger.info(f"{service_name} API Key found in environment variable.")
@@ -39,7 +40,7 @@ if 'services_initialized' not in st.session_state:
     st.session_state.PEXELS_API_KEY = load_api_key("PEXELS_API_KEY", "PEXELS_API_KEY", "Pexels")
     
     if not st.session_state.GEMINI_API_KEY: 
-        st.error("CRITICAL: Gemini API Key is essential and missing! Application cannot proceed."); logger.critical("Gemini API Key missing. Halting."); st.stop()
+        st.error("CRITICAL: Gemini API Key is essential and missing! Please set it in secrets or environment variables."); logger.critical("Gemini API Key missing. Halting."); st.stop()
     
     try:
         st.session_state.gemini_handler = GeminiHandler(api_key=st.session_state.GEMINI_API_KEY)
@@ -54,9 +55,10 @@ if 'services_initialized' not in st.session_state:
         logger.info("VisualEngine initialized and API keys set (or attempted).")
     except Exception as e:
         st.error(f"Failed to init VisualEngine or set its API keys: {e}"); logger.critical(f"VisualEngine init/key setting failed: {e}", exc_info=True)
-        st.warning("VisualEngine critical setup issue. Some features will be disabled.")
+        st.warning("VisualEngine critical setup issue. Some features will be disabled.") # App can continue with placeholders
     st.session_state.services_initialized = True; logger.info("Service initialization sequence complete.")
 
+# Initialize other session state variables
 for key, default_val in [
     ('story_treatment_scenes', []), ('scene_dalle_prompts', []), ('generated_visual_paths', []),
     ('video_path', None), ('character_definitions', {}), ('global_style_additions', ""),
@@ -64,7 +66,6 @@ for key, default_val in [
 ]:
     if key not in st.session_state: st.session_state[key] = default_val
 
-# --- Helper Functions ---
 def initialize_new_project(): # Same
     st.session_state.story_treatment_scenes, st.session_state.scene_dalle_prompts, st.session_state.generated_visual_paths = [], [], []
     st.session_state.video_path, st.session_state.overall_narration_audio_path, st.session_state.narration_script_display = None, None, ""
@@ -104,10 +105,10 @@ with st.sidebar:
                     status.write("Phase 1: Gemini crafting cinematic treatment... 📜"); logger.info("Phase 1: Cinematic Treatment Gen.")
                     treatment_prompt = create_cinematic_treatment_prompt(user_idea, genre, mood, num_scenes, actual_creative_guidance)
                     treatment_result_json = st.session_state.gemini_handler.generate_story_breakdown(treatment_prompt)
-                    if not isinstance(treatment_result_json, list) or not treatment_result_json: raise ValueError("Gemini returned invalid scene list.")
+                    if not isinstance(treatment_result_json, list) or not treatment_result_json: raise ValueError("Gemini returned invalid scene list for treatment.")
                     st.session_state.story_treatment_scenes = treatment_result_json; num_gen_scenes = len(st.session_state.story_treatment_scenes)
                     st.session_state.scene_dalle_prompts = [""]*num_gen_scenes; st.session_state.generated_visual_paths = [None]*num_gen_scenes
-                    logger.info(f"Phase 1 complete. {num_gen_scenes} scenes.")
+                    logger.info(f"Phase 1 complete. Generated {num_gen_scenes} scenes.")
                     status.update(label="Treatment complete! ✅ Generating visuals...", state="running")
 
                     status.write("Phase 2: Creating visuals (DALL-E/Pexels)... 🖼️"); logger.info("Phase 2: Visual Gen.")
@@ -118,10 +119,9 @@ with st.sidebar:
                         if generate_visual_for_scene_core(i, sc_data, version=1): visual_successes += 1
                     
                     current_status_label_ph2 = "Visuals ready! "
-                    next_step_state = "running"
                     if visual_successes == 0 and num_gen_scenes > 0: 
-                        logger.error("Visual gen failed all scenes."); current_status_label_ph2 = "Visual gen FAILED for all scenes."; next_step_state="error"; 
-                        status.update(label=current_status_label_ph2, state=next_step_state, expanded=True); st.stop()
+                        logger.error("Visual gen failed all scenes."); current_status_label_ph2 = "Visual gen FAILED for all scenes."; 
+                        status.update(label=current_status_label_ph2, state="error", expanded=True); st.stop()
                     elif visual_successes < num_gen_scenes: 
                         logger.warning(f"Visuals partial ({visual_successes}/{num_gen_scenes})."); current_status_label_ph2 = f"Visuals partially generated ({visual_successes}/{num_gen_scenes}). "
                     else: logger.info("All visuals OK.")
@@ -137,17 +137,17 @@ with st.sidebar:
                     st.session_state.overall_narration_audio_path = st.session_state.visual_engine.generate_narration_audio(st.session_state.narration_script_display)
                     
                     final_label = "All components ready! Storyboard below. 🚀"
-                    final_state_val = "complete"
+                    final_state_val = "complete" # Default to complete
                     if not st.session_state.overall_narration_audio_path:
-                        final_label = f"{current_status_label_ph2}Storyboard ready (Voiceover skipped/failed)."
-                        logger.warning("Voiceover was skipped or failed.")
+                        final_label = f"{current_status_label_ph2}Storyboard ready (Voiceover skipped or failed)." # Adjust label if voice failed
+                        logger.warning("Voiceover was skipped or failed, but other components might be ready.")
                     else: logger.info("Voiceover generated successfully.")
-                    status.update(label=final_label, state=final_state_val, expanded=False)
+                    status.update(label=final_label, state=final_state_val, expanded=False) # Keep state complete, label reflects issues
 
-                except ValueError as ve: logger.error(f"ValueError: {ve}", exc_info=True); status.update(label=f"Input/Gemini response error: {ve}", state="error", expanded=True); 
+                except ValueError as ve: logger.error(f"ValueError: {ve}", exc_info=True); status.update(label=f"Input or Gemini response error: {ve}", state="error", expanded=True); 
                 except Exception as e: logger.error(f"Unhandled Exception: {e}", exc_info=True); status.update(label=f"An unexpected error occurred: {e}", state="error", expanded=True);
     
-    st.markdown("---"); st.markdown("### Fine-Tuning Options")
+    st.markdown("---"); st.markdown("### Fine-Tuning Options") # UI for these remain same as previous full app.py
     with st.expander("Define Characters", expanded=False):
         char_name = st.text_input("Character Name", key="char_name_adv_ultra_v3"); char_desc = st.text_area("Visual Description", key="char_desc_adv_ultra_v3", height=100, placeholder="e.g., Jax: rugged male astronaut...")
         if st.button("Save Character", key="add_char_adv_ultra_v3"):
@@ -169,12 +169,12 @@ with st.sidebar:
         if cur_style: st.caption(f"Active global styles: \"{cur_style}\"")
 
     with st.expander("Voice Customization (ElevenLabs)", expanded=False):
-        el_voices = ["Rachel", "Adam", "Bella", "Antoni", "Elli", "Josh", "Arnold", "Domi"] 
+        el_voices_conceptual = ["Rachel", "Adam", "Bella", "Antoni", "Elli", "Josh", "Arnold", "Domi", "Fin", "Sarah", "Charlie", "Clyde", "Dorothy", "George"] 
         engine_v_id = "Rachel"; 
         if hasattr(st.session_state, 'visual_engine') and st.session_state.visual_engine: engine_v_id = st.session_state.visual_engine.elevenlabs_voice_id
-        try: cur_v_idx = el_voices.index(engine_v_id)
+        try: cur_v_idx = el_voices_conceptual.index(engine_v_id)
         except ValueError: cur_v_idx = 0 
-        sel_el_voice = st.selectbox("Narrator Voice:", el_voices, index=cur_v_idx, key="el_voice_sel_ultra_v3")
+        sel_el_voice = st.selectbox("Narrator Voice:", el_voices_conceptual, index=cur_v_idx, key="el_voice_sel_ultra_v3")
         prompt_v_styles = {"Cinematic Trailer": "cinematic_trailer", "Neutral Documentary": "documentary_neutral", "Character Introspection": "introspective_character"}
         sel_prompt_v_style_key = st.selectbox("Narration Script Style:", list(prompt_v_styles.keys()), key="narr_style_sel_v3")
         if st.button("Set Narrator Voice & Style", key="set_voice_btn_ultra_v3"):
@@ -182,7 +182,6 @@ with st.sidebar:
             st.session_state.selected_voice_style_for_generation = prompt_v_styles[sel_prompt_v_style_key]
             st.success(f"Narrator: {sel_el_voice}. Script Style: {sel_prompt_v_style_key}")
 
-
 # --- Main Content Area ---
 st.header("🎬 Cinematic Storyboard & Treatment")
 if st.session_state.narration_script_display:
@@ -192,12 +191,11 @@ if not st.session_state.story_treatment_scenes: st.info("Use the sidebar to gene
 else:
     for i_main, scene_content_display in enumerate(st.session_state.story_treatment_scenes):
         scene_n = scene_content_display.get('scene_number', i_main + 1); scene_t = scene_content_display.get('scene_title', 'Untitled')
-        key_base = f"s{scene_n}_{''.join(filter(str.isalnum, scene_t[:10]))}_v3" # Added version to key_base for uniqueness
+        key_base = f"s{scene_n}_{''.join(filter(str.isalnum, scene_t[:10]))}_v3" 
         if "director_note" in scene_content_display and scene_content_display['director_note']: st.info(f"🎬 Director Note S{scene_n}: {scene_content_display['director_note']}")
         st.subheader(f"SCENE {scene_n}: {scene_t.upper()}"); col_d, col_v = st.columns([0.45, 0.55])
         with col_d:
             with st.expander("📝 Scene Treatment", expanded=True):
-                # ... (markdown display of scene details, same as before) ...
                 st.markdown(f"**Beat:** {scene_content_display.get('emotional_beat', 'N/A')}"); st.markdown(f"**Setting:** {scene_content_display.get('setting_description', 'N/A')}"); st.markdown(f"**Chars:** {', '.join(scene_content_display.get('characters_involved', ['N/A']))}"); st.markdown(f"**Focus Moment:** _{scene_content_display.get('character_focus_moment', 'N/A')}_"); st.markdown(f"**Plot Beat:** {scene_content_display.get('key_plot_beat', 'N/A')}"); st.markdown(f"**Dialogue Hook:** `\"{scene_content_display.get('suggested_dialogue_hook', '...')}\"`"); st.markdown("---"); st.markdown(f"**Dir. Visual Style:** _{scene_content_display.get('PROACTIVE_visual_style_감독', 'N/A')}_"); st.markdown(f"**Dir. Camera:** _{scene_content_display.get('PROACTIVE_camera_work_감독', 'N/A')}_"); st.markdown(f"**Dir. Sound:** _{scene_content_display.get('PROACTIVE_sound_design_감독', 'N/A')}_")
                 cur_d_prompt = st.session_state.scene_dalle_prompts[i_main] if i_main < len(st.session_state.scene_dalle_prompts) else None
                 if cur_d_prompt:
@@ -206,7 +204,7 @@ else:
                 if pexels_q: st.caption(f"Pexels Fallback Query: `{pexels_q}`")
         with col_v:
             cur_img_p = st.session_state.generated_visual_paths[i_main] if i_main < len(st.session_state.generated_visual_paths) else None
-            if cur_img_p and os.path.exists(cur_img_p): st.image(cur_img_p, caption=f"Scene {scene_n}: {scene_t}", use_column_width='always') 
+            if cur_img_p and os.path.exists(cur_img_p): st.image(cur_img_p, caption=f"Scene {scene_n}: {scene_t}") # Removed use_column_width
             else:
                 if st.session_state.story_treatment_scenes: st.caption("Visual pending/failed.")
             
@@ -256,7 +254,6 @@ else:
                     else: st.warning("Please provide feedback.")
         st.markdown("---")
     
-    # Video Generation Button & Display (same as previous)
     if st.session_state.story_treatment_scenes and any(p for p in st.session_state.generated_visual_paths if p is not None):
         if st.button("🎬 Assemble Narrated Cinematic Animatic", key="assemble_ultra_video_btn_v3", type="primary", use_container_width=True):
             with st.status("Assembling Ultra Animatic...", expanded=True) as status_vid: