id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
1989370230 | Fix tornado, anti, :buyitem, fpslocker, van, :slippery, convert deprecated/legacy items
Fix :BuyItem being broken due to legacy setting and a typo
Fixed anti cheat misdetecting if a player has a lag spike in which rendering doesn't happen for over minute. Now it is changed to 1.5 minutes. (A single frame should never take 1.5 minutes, if this is too low then it can be changed to 2.5 minutes/150 seconds)
coroutine.wrap 2 task.spawn (Fixes a part of tornado code not working)
.Velocity to .AssemblyLinearVelocity
Hat to Accessory
tick() to os.clock() or os.time
Removed ManualWeld studio joint artifacts generated by a weird Roblox feature from Van.rbxmx
Cleaned up some code
Fix :slippery & :unslippery
I've tested everything and it seems to work
seems to. hmmm
Actually don't merge this yet I'll remove the security capabilities things from the rbxmx
Ok now they are removed
Ah great
| gharchive/pull-request | 2023-11-12T11:54:26 | 2025-04-01T06:36:56.525439 | {
"authors": [
"Dimenpsyonal",
"ccuser44"
],
"repo": "Epix-Incorporated/Adonis",
"url": "https://github.com/Epix-Incorporated/Adonis/pull/1270",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2705519745 | Selki/ff3396 expiring bandit cache
Fixes: #issue
Motivation and Context
//: # We want to use an expiring cache for bandits to dedupe ones from the same session e.g., if a user rapidly refreshes or the assignment is used on multiple parts of a page. We think a 10-minute expiration will be a good starting point for this.
Description
//: # Used TLRU cache on init of EppoClient
How has this been tested?
//: # Unit tests
Yes, the underlaying implementation of cache is here. In this repo I just want to make sure that the tests are working
@rasendubi added with Write access to repo ✔️
| gharchive/pull-request | 2024-11-29T15:47:50 | 2025-04-01T06:36:56.533168 | {
"authors": [
"leoromanovsky",
"maya-the-mango"
],
"repo": "Eppo-exp/node-server-sdk",
"url": "https://github.com/Eppo-exp/node-server-sdk/pull/80",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1170381015 | model that refs a model that refs a seed - fails test
Here's an example of a model that fails if it depends on a model that depends on a seed. I'm trying to work out a fix, but if you know anything quick that would be great!
Compilation Error in test covid_19_stats_country_model_using_seed_test (tests/unit/product/covid_19_stats_country_model_using_seed_test.sql)
Source seed_test columns must be declared in sources.yml, or it must exist in database
> in macro fake_source_sql (macros/test_helpers.sql)
> called by macro build_model_complete_sql (macros/build_model_complete_sql.sql)
> called by macro mock_input (macros/tests.sql)
> called by macro mock_ref (macros/tests.sql)
> called by macro test (macros/tests.sql)
> called by test covid_19_stats_country_model_using_seed_test (tests/unit/product/covid_19_stats_country_model_using_seed_test.sql)
> called by test covid_19_stats_country_model_using_seed_test (tests/unit/product/covid_19_stats_country_model_using_seed_test.sql)
@psousa50 - After submitting this, I noticed you've been working on the same thing today in another branch. I added your changes here and my unit test is now passing!
That's great 👍 @gnilrets, thanks!
We are also experiencing this problem and working on a fix! But I am very glad I glanced and found this PR 😄
| gharchive/pull-request | 2022-03-16T00:00:23 | 2025-04-01T06:36:56.535454 | {
"authors": [
"gnilrets",
"psousa50",
"tnightengale"
],
"repo": "EqualExperts/dbt-unit-testing",
"url": "https://github.com/EqualExperts/dbt-unit-testing/pull/26",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
938828040 | [BUG] Server crash when being close to mobs
What happened?
When people are very near from some mobs, the server crash and it indicates that it's the mod's fault.
What should happen?
It should not crash
Steps to reproduce
Be close to a mob
Wait
Mod/Game Version
[ 2.1.1 ] 1.16
Platform
[ 36.1.32 ] Forge
Config:
(I changed the file extension so you can access it easier)
Discord-Integration-Config.txt
There were three crash reports:
https://hastebin.com/igusofeyar.rb
https://hastebin.com/nahigedeka.rb
https://hastebin.com/uqacevudow.rb
I hope the bug will be easy to fix ! Thanks for the awesome mod, and thanks for all the work you're putting in the mod.
Try the newer version, this bug might be already fixed there
Thank you, I'll try !
| gharchive/issue | 2021-07-07T12:13:38 | 2025-04-01T06:36:56.544294 | {
"authors": [
"ErdbeerbaerLP",
"Migmag789"
],
"repo": "ErdbeerbaerLP/DiscordIntegration-Forge",
"url": "https://github.com/ErdbeerbaerLP/DiscordIntegration-Forge/issues/291",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2325977998 | fix Expand-Archive to use correct library
Expand-Archive giving syntax error in PowerShell v5.1 (A parameter cannot be found that matches parameter name 'DestinationPath')
I've added Microsoft.PowerShell.Archive to use it from the correct library.
Using PowerShell 5.1 and Get-Host | Select-Object Version, I currently have version 5.1.17763.5696 installed.
Using PowerShell 7 and $PSVersionTable | Select-Object PSVersion, I currently have version 7.1.3 installed.
I tried this just now in both PowerShell 5.1 and 7 and did not see any errors relating to Expand-Archive. That being said, adding Microsoft.PowerShell.Archive/ didn't cause any issues either so 🤷
I have version 5.1.26040.1000 installed and have issue =
with 7.5.0-preview.2 works fine
| gharchive/pull-request | 2024-05-30T15:35:30 | 2025-04-01T06:36:56.548715 | {
"authors": [
"AndrewRathbun",
"jimdi"
],
"repo": "EricZimmerman/Get-ZimmermanTools",
"url": "https://github.com/EricZimmerman/Get-ZimmermanTools/pull/7",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1996842824 | Setting review status with file
Describe the bug
Not really a bug but possibly documentation lacking info:
According to setting-with-config-file, it is possible to set review status with external file, but there is no info how to do it.
Is this feature still available and by what command can this file be imported into parse/analyze?
This feature would be very helpful to batch disable things like magic number errors etc.
CodeChecker version
6.22.2
To Reproduce
Documentation issue.
Expected behaviour
Documentation issue.
Desktop (please complete the following information)
OS: N/A
Browser: N/A
Version: N/A
Additional context
Ok, found it.
For other dummies like me: this is not yet released as of 6.22.2, even though it is available in the doc. https://github.com/Ericsson/codechecker/releases/tag/v6.23.0-rc1 introduces it.
This is not yet released as of 6.22.2, even though it is available in the doc
This must be a mistake, as if I check the code for v6.22.2 (commit a3d35cfd509b995187288cd8631446415a334257), the linked part is not available.
The linked commit, 88af1ff15131644da34fff27fafcb661b485bda6, was first available in tag v6.23.0-rc2.
| gharchive/issue | 2023-11-16T13:19:19 | 2025-04-01T06:36:56.556520 | {
"authors": [
"m-luk",
"whisperity"
],
"repo": "Ericsson/codechecker",
"url": "https://github.com/Ericsson/codechecker/issues/4087",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2580817334 | LD_PRELOAD cannot be preloaded, possible regression with #4312
Describe the bug
On Ubuntu-24.04, when analyzing bitcoin v0.20.1, the logging phase fails.
CodeChecker version
master a6663b3349c54a5d00687bd3d3695ead19b8e060
To Reproduce
# Fresh build of CodeChecker on master
git clone https://github.com/Ericsson/codechecker.git
cd codechecker
make venv package
source venv
export PATH="$PWD/build/CodeChecker/bin:$PATH"
cd ..
# Clone and log bitcoin project
git clone https://github.com/bitcoin/bitcoin.git -b v0.20.1
cd bitcoin
./autogen.sh && ./configure --disable-wallet --disable-static --disable-tests --without-gui
CodeChecker log -b 'make -j' -o compile_commands.json
Results in this error for all TUs:
CXX lib/libunivalue_la-univalue_get.lo
ERROR: ld.so: object 'ldlogger.so' from LD_PRELOAD cannot be preloaded (cannot open shared object file): ignored.
Expected behaviour
I expect the log to produce a compilation database, but it is empty.
Desktop (please complete the following information)
OS: WSL Ubuntu-24.04
Browser: not relevant
Version: not relevant
Additional context
I see that the issue came up in #3858, and I suspect that the regression to this error happened #4312.
I think the change should not just be reverted, but instead, the machine architecture of the TU analyzed should be added to LD_LIBRARY_PATH env variable of the compiler invocation to be logged.
I have tested with the latest master version (already CMake-based) Bitcoin project, and there is no mention of it overriding the LD_LIBRARY_PATH. The issue still holds.
IMO we need this https://github.com/Ericsson/codechecker/pull/3919, but with the modification that ensures we also support a different-architecture binary than the host OS.
Right now, I see 2 ways of doing this:
we detect the architecture of the compiler we use for logging
blindly pass all the shared objects to the binary by adding all of them (maybe multiple absolute path entries for LD_PRELOAD, or just a relative path, and adding all the machine-specific directories to LD_PRELOAD_PATH)
The problem with the solution in #3919 (which was reverted and fixed in #4314) was that it put the absolute path of the ldlogger.so into to the LD_LIBRARY_PATH. The 32bits version of the ldlogger.so was used on a 32bits host, and the 64bits version on a 64 bits host. Unfortunately this is not correct, as not the architecture type of the host which matters, but the architecture type of the gcc compiler that we logged. So a user reported that logging was not working correctly when he was logging a 32bits gcc on a 64 bits machine as the 64 bits ldlogger was loaded which could not be dynamically linked with the 32bits gcc.
The currently implemented strategy as of #4314 is the following:
The ldlogger.so is placed in
/opt/CodeChecker/ld_logger/lib/i386/ldlogger.so #32 bits
/opt/CodeChecker/ld_logger/lib/x86_64/ldlogger.so #64 bits
We set the LD_LIBRARY_PATH to the directory containing containing dir and the LD_PRELOAD env var to relative ldlogger.so
LD_LIBRARY_PATH=/opt/CodeChecker/ld_logger/lib
LD_PRELOAD=ldlogger.so
then the linux will automatically select the ld_logger/lib/i386 and the ld_logger/lib/x86_64 subdirectories based on the architecture of the logged gcc.
Has this behaviour changed on the newest linux ubunut 24? The current implementation works fine (according to my tests) on ubuntu 20,22, rhel 8,9.
I have created a draft for option 2 since it seemed like the simpler solution.
I have also tested it on Ubuntu24, and the multiple .so files that are possibly reachable due to all of them being added are not an issue, the logger works as expected, and if I remove only the relevant ldlogger.so (x86_64 for my machine), but kept the others, the log command correctly detected that I meet neither the ld-logger nor the intercept-build requirement.
I have also left in the old path, which just includes the lib folder.
PR here: #4394
| gharchive/issue | 2024-10-11T08:48:06 | 2025-04-01T06:36:56.568417 | {
"authors": [
"dkrupp",
"gamesh411"
],
"repo": "Ericsson/codechecker",
"url": "https://github.com/Ericsson/codechecker/issues/4360",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
620105016 | [fix] Fix tidyargs file encoding
The content of tidyargs file is given to re.sub() function which doesn't
accept binary strings.
Here is an overview of what got changed by this pull request:
Issues
======
- Added 3
See the complete overview on Codacy
Here is an overview of what got changed by this pull request:
Issues
======
- Added 3
Clones added
============
- analyzer/tests/functional/analyze/test_analyze.py 2
See the complete overview on Codacy
| gharchive/pull-request | 2020-05-18T10:43:38 | 2025-04-01T06:36:56.571530 | {
"authors": [
"bruntib",
"gyorb"
],
"repo": "Ericsson/codechecker",
"url": "https://github.com/Ericsson/codechecker/pull/2746",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
173658600 | http://demo.openwebrtc.org/ not working in iOS
I tried a simple test, and opened bowser in my iPad (iOS version 9.3.5), and tried to access the room that I created at http://demo.openwebrtc.org/ from my Mac. It does not display my video in bowser. Is there any issues with the current bowser version?
Can confirm this, tried using bowser on iOS and chrome on mac.
Behaviour as follows: in chrome I could create a room and join. Browsing to the same room in bowser didn't allow joining, buttons disabled.
| gharchive/issue | 2016-08-28T17:54:47 | 2025-04-01T06:36:56.573675 | {
"authors": [
"shoreflyer",
"yasmagic"
],
"repo": "EricssonResearch/openwebrtc",
"url": "https://github.com/EricssonResearch/openwebrtc/issues/628",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
2554136623 | tests: update models to provider/model format
[!IMPORTANT]
Update model name in tests/test-integration.sh to openai/gpt-4-1106-preview.
Tests:
Update model name in tests/test-integration.sh from gpt-4-1106-preview to openai/gpt-4-1106-preview.
This description was created by for 171f996e58a45b80bf4300ac977569db6f2da102. It will automatically update as commits are pushed.
Nice catch!
Congrats on the first merged commit :)
| gharchive/pull-request | 2024-09-28T09:44:09 | 2025-04-01T06:36:56.576868 | {
"authors": [
"ErikBjare",
"brayo-pip"
],
"repo": "ErikBjare/gptme",
"url": "https://github.com/ErikBjare/gptme/pull/141",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
266354261 | Trampoline fails to run with JDK 9.0.1
./gradlew
FAILURE: Build failed with an exception.
What went wrong:
Could not determine java version from '9.0.1'.
Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Exception is:
java.lang.IllegalArgumentException: Could not determine java version from '9.0.1'.
at org.gradle.api.JavaVersion.toVersion(JavaVersion.java:70)
at org.gradle.api.JavaVersion.current(JavaVersion.java:80)
at org.gradle.internal.jvm.UnsupportedJavaRuntimeException.assertUsingVersion(UnsupportedJavaRuntimeException.java:29)
at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:32)
at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:24)
at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:33)
at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:22)
at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:247)
at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:182)
at org.gradle.launcher.Main.doAction(Main.java:33)
at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:60)
at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:37)
at org.gradle.launcher.GradleMain.main(GradleMain.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:31)
at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:108)
at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:61)
Hi @ggerard ,
At least on windows, having:
java -version
java version "9.0.1"
Java(TM) SE Runtime Environment (build 9.0.1+11)
Java HotSpot(TM) 64-Bit Server VM (build 9.0.1+11, mixed mode)
I could start Trampoline, as well as instances, using gradle wrapper or maven without changing anything.
Knowing that you are working on a unix system, I will give a look there.
| gharchive/issue | 2017-10-18T04:08:10 | 2025-04-01T06:36:56.621502 | {
"authors": [
"ErnestOrt",
"ggerard"
],
"repo": "ErnestOrt/Trampoline",
"url": "https://github.com/ErnestOrt/Trampoline/issues/33",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
2337516590 | Missing components
ArcGISViewStateLoggingComponent
ArcGISCameraControllerComponent
are missing from the package, and the name space "using Esri.ArcGISMapsSDK.Samples.Components" is not exsit
Navigate to the package manager, then click on the ArcGISMapsSDK for Unity, click on Samples, and then click install samples. This will import the samples and fix the issues you are having.
| gharchive/issue | 2024-06-06T07:16:36 | 2025-04-01T06:36:56.682528 | {
"authors": [
"mmgaw113",
"yuhe0925"
],
"repo": "Esri/arcgis-maps-sdk-unity-samples",
"url": "https://github.com/Esri/arcgis-maps-sdk-unity-samples/issues/122",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1883941985 | DSC 4.1.0 - Missing .NET Desktop Runtime 6.0 (x64) for ArcGIS Server 11.1 - SOE/SOI .NET support
Community Note
Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
Module Version
4.1.0
Affected Resource(s)
ArcGIS_Server
Configuration Files
# Copy-paste your DSC JSON configurations here - for large configs,
# please use a service like Dropbox and share a link to the ZIP file.
Expected Behavior
The current DSC module 4.1.0 supports ArCGIS 11.1 but one part is missing. If you would like to have Server Object Extensions or Server Object Interceptors (SOE and SOI) installed on your ArcGIS Server, you need to install .NET Dekstop 6.0 runtime support. It's mentioned here: https://developers.arcgis.com/enterprise-sdk/guide/net/net-6-support/ and here https://developers.arcgis.com/enterprise-sdk/guide/net/net-6-support/#deploy-net-6-soes-and-sois-to-arcgis-server
If this .NET Desktop runtime is installed, the optional feature ".NET extension support" for ArcGIS Server can be chosen to be installed. This .NET Desktop runtime configuration is currently missing. It is configurable for an ArcGIS Pro installation. See "DotnetDesktopRuntimeDownloadUrl " or "DotnetDesktopRuntimePath" from the variable reference page: https://github.com/Esri/arcgis-powershell-dsc/wiki/v4.1.0-Variables-reference-page-for-JSON-configuration-files
We would need the same for ArcGIS server as it is for ArcGIS Pro.
Actual Behavior
Not implemented
Steps to Reproduce
Completely missing
Important Factoids
References
Support has been added for downloading and installing Microsoft Dot Net Desktop Runtime for ArcGIS Server in DSC ArcGIS Module v4.4.0:
https://github.com/Esri/arcgis-powershell-dsc/releases/tag/v4.4.0
Sample Json:
"Server": {
"Installer": {
"Path": "C:\\Software\\Archives\\11.3\\ArcGIS_Server_Windows_113_190188.exe",
"VolumePaths": [
"C:\\Software\\Archives\\11.3\\ArcGIS_Server_Windows_113_190188.exe.001"
],
"InstallDir": "C:\\Program Files\\ArcGIS\\Server",
"EnableDotnetSupport": true,
"DotnetDesktopRuntimeDownloadUrl": "https://download.visualstudio.microsoft.com/download/pr/907765b0-2bf8-494e-93aa-5ef9553c5d68/a9308dc010617e6716c0e6abd53b05ce/windowsdesktop-runtime-8.0.8-win-x64.exe",
"DotnetDesktopRuntimePath": "C:\\Software\\Archives\\11.3\\windowsdesktop-runtime-8.0.8-win-x64.exe"
}
}
| gharchive/issue | 2023-09-06T12:46:06 | 2025-04-01T06:36:56.691159 | {
"authors": [
"cameronkroeker",
"lorenzmeyer77"
],
"repo": "Esri/arcgis-powershell-dsc",
"url": "https://github.com/Esri/arcgis-powershell-dsc/issues/494",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
796138502 | Exception for apikey more info link
https://github.com/Esri/arcgis-runtime-samples-dotnet/blob/7825b68abe113207b67a27cf02133af658a767d9/src/WPF/ArcGISRuntime.WPF.Viewer/ApiKeyPrompt.xaml.cs#L63
A fix has been merged. Thank you for reporting this 👍
A fix has been merged. Thank you for reporting this 👍
| gharchive/issue | 2021-01-28T16:02:32 | 2025-04-01T06:36:56.706217 | {
"authors": [
"ZackAllen",
"kirkktx"
],
"repo": "Esri/arcgis-runtime-samples-dotnet",
"url": "https://github.com/Esri/arcgis-runtime-samples-dotnet/issues/848",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
192639273 | webpack / typings / Arcgis 3.18 / Angular2
Our project relies on ClusterLayer. It was working when we were using SystemJS and Visual Studio. Now that we have separated the front end from the back end and use VS Code primarily as our front-end editor, ClusterLayer no longer works. We are also now using webpack. We are having a hard time getting ClusterLayer.js to work in 3.18 with our new configuation. After creating a typings file for it, tsc compiles and the site runs without error. However, for some reason no clusters are showing up. Can you offer any advice or do you know of anyone who has a similar setup to ours that we could use to help us along? Thanks,
Kai
@PivotalAnimal While not specific to ClusterLayer, I recommend taking a look at this blog post on using the ArcGIS JS API with webpack. There may be some tidbits in there that are helpful to your specific issues.
Issue solved. Thanks!
| gharchive/issue | 2016-11-30T18:13:24 | 2025-04-01T06:36:56.730991 | {
"authors": [
"PivotalAnimal",
"andygup"
],
"repo": "Esri/cluster-layer-js",
"url": "https://github.com/Esri/cluster-layer-js/issues/36",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
229816707 | Provide ability to format the Input coordinate (ArcMap)
Currently you can change the format of the Input, but you can not edit the notation in the way that you can use the Advanced options in the Add New Output Coordinate dialog. This is important, because the style of the Input box also controls the way coordinates in the "List" box are shown. In short. In short I want some control over how coordinates are formatted in the "List" box.
requested for ArcGIS Pro as well. #347
@dfoll agree with you completely. It is of huge value to have the Output List reflect the coordinate format and notation set by the user. I would be interested and open to talking through approaches to do so should this become a high priority item for a near future release.
this still needs to be done
After speaking with @saip tonight the input coordinate box will allow a user to format coordinates the same way that they are allowed to format coordinates in the output list. The only difference is input coordinate box has a selection called default map units, which is set by the map. The default map coordinates will not be able to be formatted. @dfoll @lfunkhouser
If it's only the default map units that cannot be formatted, I think that is acceptable
Recently rebuilt CC build 19 and MT build 122 to test
I found that the custom formatted input coordinates are inconsistently applied in ArcMap 10.6 with the latest CC build.
DMS seems to work correctly.
DDM sometimes works.
MGRS never works.
https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/532
Using MT build 126, I verified @BobBooth's comments
This issue needs to be sent back to @CTLocalGovTeam. Described functionality is not working. The buttons are in place to do this but the functionality does not exist.
Additional repro steps
On the Coordinate Conversion pane click the Edit Properties button next to the input text box.
Highlight MGRS and Custom
Expand Advanced if it is not already expanded
Format the MGRS coordinate with spaces in between each piece of the MGRS coordinate (this is a supported way of supporting coordinates for the output box)
This is what the Edit Properties window looks like after making changes
Click OK
Click some points in the map.
_Note that both the Input box and List retain old formatting.
Click the Edit Properties button next to the Input box again.
Note that the formatting that was set in step 4 is still applied in the Edit Properties window
@lfunkhouser this looks like an issue that was not delivered
@dfoll have you discussed this with @saip to provide guidance?
From #532, MGRS not working for ArcMap. Coordinate Conversion ArcMap custom formatting not applied to MGRS, partially applied DDM
The latest build of Coordinate Conversion supports customization of the format of Input Coordinates (and their display in the List view) if the coordinates are DMS notation.
For other notations the support is inconsistent.
For example, some coordinates in DDM are displayed with the added dashes, and others are not:
None of the customized coordinates are displayed correctly in MGRS:
ArcMap 10.6.0
Coordinate Conversion Add In 2.3.1.19 (10/30/18)
| gharchive/issue | 2017-05-18T21:58:58 | 2025-04-01T06:36:56.742966 | {
"authors": [
"BobBooth",
"dfoll",
"kgonzago",
"lfunkhouser",
"mcalamito",
"topowright"
],
"repo": "Esri/coordinate-conversion-addin-dotnet",
"url": "https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/348",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
352451631 | Update to latest & android compile fixes
Changes
By default don't use noexcept, it is varied across all different compilers and STLs so = default is good enough
Android GCC 4.9 doesn't support templated variables, use structs instead
Note: There was some git branch juggling that happened to avoid a massive amount of incompatible merge conflicts. The previous state has been kept in the runtimecore-old-2018... branch
@crezefire I don't see the lua file that we need to build this library?
Disregard my lua comment. I forgot that this was header only :)
| gharchive/pull-request | 2018-08-21T09:12:22 | 2025-04-01T06:36:56.747093 | {
"authors": [
"chri7325",
"crezefire"
],
"repo": "Esri/entt",
"url": "https://github.com/Esri/entt/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
111895210 | Initial commit for MultiEditor Widget
@jrweakland @conklinbd FYI
Deleting pull request. Multi Editor widget is still under development with new requirements.
| gharchive/pull-request | 2015-10-16T19:23:39 | 2025-04-01T06:36:56.755174 | {
"authors": [
"kgonzago"
],
"repo": "Esri/solutions-webappbuilder-widgets",
"url": "https://github.com/Esri/solutions-webappbuilder-widgets/pull/300",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
819820545 | Blank page after npm run start
Dear Jinnan Zhang,
First of all, many congratulations on your work. It is simply amazing as you can exploit all those data in the WaterBalance App.
I was trying to run it on my Windows machine:
I Cloned the repo
I installed all the dependencies with npm install.
I run npm run start
I have no error while compiling (in fact, the log is empty), but unfortunately, when I open the browser on the http://localhost:8080/, I got only a blank page without any console errors.
The problem seems to be in the loading of the content of the root div because, on my browser, it is empty and not populated as it is on your live demo.
Do you have any idea how to fix this problem?
Thank you in advance for your support.
Best regards,
Matteo
@matteorizziWT
Hi Matteo, thanks for reporting this issue, it seems for some reason the ReactDOM.render function from index.tsx didn't get called, that's why the root div is empty.
Did you happen to modify the entry point in the webpack config file? Because modifying that can cause the issue that you described.
Jinnan
Yes exactly, that function is not called.
Unfortunately I didn't modify the entry point in the webpack config...
@matteorizziWT Could you please clone the repo and run the commands again? We updated the app to use new GLDAS Imagery Services couple months ago and I forgot to do a pull request to merge those changes from my fork to this Esri repo.
Please let me know if that fixes the issue.
Jinnan
@vannizhang Thank you so much. Everything now is working fine.
@matteorizziWT You are welcome, thanks again for catching this issue. The app can only render the UI components once time extent info of GLDAS layers are ready (see this line here), since the old GLDAS services were retired, it won't be able to provide the time extent info either, which caused the issue you saw.
| gharchive/issue | 2021-03-02T09:22:17 | 2025-04-01T06:36:56.762563 | {
"authors": [
"matteorizziWT",
"vannizhang"
],
"repo": "Esri/water-balance-app",
"url": "https://github.com/Esri/water-balance-app/issues/9",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2557333766 | Create credential-verification-requirements.md
Here is a basic summary on what to do on verification. I'm a bit time-constraint right now, so I couldn't spend as much time on it as I wished. Feel free to extent
Some light edits
| gharchive/pull-request | 2024-09-30T18:04:28 | 2025-04-01T06:36:56.763988 | {
"authors": [
"bsandmann"
],
"repo": "Essbante/identus-dapps-wg",
"url": "https://github.com/Essbante/identus-dapps-wg/pull/2",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
854203474 | Created the officer-profile-list.svelte component and more.
I created the necessary officer-profile-list.svelte as well as the acm-select.svelte UI component to go with it.
This pull request is intended to close both issue #29 and #24 since the two efforts ended up relying on each other.
| gharchive/pull-request | 2021-04-09T06:20:11 | 2025-04-01T06:36:56.792619 | {
"authors": [
"EthanThatOneKid"
],
"repo": "EthanThatOneKid/acmcsuf.com",
"url": "https://github.com/EthanThatOneKid/acmcsuf.com/pull/43",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
865691587 | converters the probs into np array if its already not
smile_imbalance() funciton argument "probs" does not specify that it is required to be numpy array, but it does so i have added that data type in the argument letting the user know if he/she is to refer to the docs and i have also added a line np.array() which is an idempotent operation(if the array passed is already numpy array then it does nothing but if its not it changes the list into numpy array)
Suggestion
If possible can you guys consider adding "save_plot_path" method to each function, so that when this package is used in production (which i am and people considering Continuous model delivery would use) all these plots could be saved to a particular directory for data scientists to look at later since in production, code would be used in scripts running on EC2 or other cloud servers and not on jupyter notebooks
My use case is I am retraining the model every week and XAI allows me to generate a evaluation report allowing me to remotely decide weather to push this weeks mode into production
I considered adding it myself but i was not sure if this is the direction you guys wanted to take
Thank you
Thank you for the contribution @sai-krishna-msk - looks good. In regards to your suggestion, it seems inerseting, are you currently saving the charts manually or how do you achieve this?
Thank you for the contribution @sai-krishna-msk - looks good. In regards to your suggestion, it seems inerseting, are you currently saving the charts manually or how do you achieve this?
Hi @axsaucedo , yeah I'm using mlflow to log all the metrics and plots(so though the training happenes on a remote server I can view the results)
| gharchive/pull-request | 2021-04-23T02:51:06 | 2025-04-01T06:36:56.806892 | {
"authors": [
"axsaucedo",
"sai-krishna-msk"
],
"repo": "EthicalML/xai",
"url": "https://github.com/EthicalML/xai/pull/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1790127811 | Cleanup eventstoredb in each test
Hi,
Firstly, thanks for your useful library.
How can I clean up eventstoredb in each integration test?
Hey @mehdihadeli, I would advise you to run the database in in-memory mode in that case. You can achieve that by setting the env variable EVENTSTORE_IN_MEM to true or 1 when running the container.
Hi,
Thanks, Let me check.
| gharchive/issue | 2023-07-05T19:12:51 | 2025-04-01T06:36:56.833483 | {
"authors": [
"YoEight",
"mehdihadeli"
],
"repo": "EventStore/EventStore-Client-Go",
"url": "https://github.com/EventStore/EventStore-Client-Go/issues/142",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2254891431 | calling SetApiVersion before authentication gives permissions error
using the example script:
Unhandled exception. GbxRemoteNet.Exceptions.XmlRpcFaultException: (-1000) Permission denied.
at GbxRemoteNet.GbxRemoteClient.CallOrFaultAsync(String method, Object[] args)
at GbxRemoteNet.GbxRemoteClient.SetApiVersionAsync(String version)
at GbxRemoteNet.GbxRemoteClient.LoginAsync(String login, String password)
at Program.<Main>$(String[] args)
this is a problem because AFAIK you can't choose to send SetApiVersion after authenticating
I'm unable to reproduce this error, what server version are you running?
Was the latest (2024-03-18 from memory, just via evo docker image)
On a linux server
| gharchive/issue | 2024-04-21T04:09:54 | 2025-04-01T06:36:56.854533 | {
"authors": [
"XertroV",
"snixtho"
],
"repo": "EvoEsports/GbxRemote.Net",
"url": "https://github.com/EvoEsports/GbxRemote.Net/issues/88",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
500022261 | Report paging does not work in Microsoft Edge or IE?
When I create a HTML report using New-HTML and view it in Chrome everything looks good, the data tables show 15 records and have a pager for more data.
If the same report is open under MS Edge or IE it shows all the records on one page (there is no pager). This makes it very difficult to use because you end up with a huge page scroll without paging. This was tested on latest Windows 10 1903.
Is it possible to get the paging to work for Edge/IE or am I missing some parameter?
All the hard work is done by JavaScript. Not sure if IE will be able to handle advanced JS but that’s what you need to get it running. I use Edge Chromium myself. For standard Edge it could possibly work I guess but you need to make sure JavaScript for local files is allowed. Of course it’s possible that both products are so legacy some features of modern internet Won’t work.
In other words, what you did in Powershell is enough. The hard part is now verification whether IE or non-chromium Edge can be used with it.
I am using Edge with the default settings from a Windows 10 install (not domain joined so no group policy settings are being applied to harden it). This should be fairly easy to reproduce if you load a larger data table in Edge. I don't think there is any blocking going on. The report worked fine in ReportHTML but once I converted over to PSWriteHTML the bug is there in Edge.
I could always reproduce it. I just assumed this won't work on IE or Edge. But actually I can see that indeed it works if I open up: https://datatables.net/examples/advanced_init/complex_header.html
So maybe it's just my implementation that is struggling. I don't promise a fix this week as I'm on delegation to France, but if I'll get a chance I'll try to push some checks and see what may be causing this.
Sounds good, thanks for the quick replies.
https://datatables.net/download/compatibility
Actually, it seems to be working fine: https://evotec.xyz/wp-content/uploads/2019/05/DashboardActiveDirectory.html when hosted on the website. This mean it only doesn't work for local files. This seems more like an issue with IE/Edge with the way I'm including those scripts.
You are right, only seems to be when the file is open locally vs. hosted. That is super strange, I wonder what causes it to break locally.
Does it work locally with ReportHTML?
Could you give some simple reproduction steps? I can help diagnose what could be happening to the JS.
Just take an example - for example, Example04-TableAndTabs and see how the Table loads in Chrome/Firefox and how it acts in IE. Basically JS doesn't seem to load properly. Or
Get-Process | Out-HTMLView
And try the .html in diff browsers.
Potentially related: https://docs.microsoft.com/en-us/previous-versions/windows/internet-explorer/ie-developer/compatibility/ms537628(v=vs.85)?redirectedfrom=MSDN
https://blogs.msdn.microsoft.com/ieinternals/2011/03/23/understanding-local-machine-zone-lockdown/
https://blogs.msdn.microsoft.com/ieinternals/2012/06/19/enhanced-protected-mode-and-local-files/
But even thou I played with those settings it doesn't seem to work
I tried downloading all of the JS, and basically everything related to this issue and can't find a workaround. Seems that both IE and Edge just happen to suck.
Works fine in FireFox, Chrome, EdgeDev, and everything else one might use.
@c3rberus Do you know if ReportHTML reports happen to work on IE/Edge when run locally?
@1RedOne Ye, it's a bit of pity. IE is only available on servers for me.
No they do not work in IE/Edge when ran locally. We use Edge as default browser within the organization and everyone has Chrome installed as a secondary option. Edge plays nice with internal enterprise applications so we can't switch out the default quite yet. It would be great if we could make this work for IE/Edge. I wonder what is causing this, the datatables show being compatible and no errors are thrown when the html file is opened.
This is caused by Internet Explorer and Edge's behavior of not loading JavaScript files for items in the Intranet zone. I cannot find a workaround other than changing the setting in Internet Explorer.
Did you manage to find settings that work?
I was thinking I need to try this out https://stackoverflow.com/questions/8146926/why-does-ie-restrict-the-javascript-files-of-local-html-pages with crlf.
I tried fixing it, but I'm out of ideas. Leaving this open. maybe someone will manage to fix it. I even tried playing
https://social.technet.microsoft.com/Forums/ie/en-US/7f8e1bc1-f4be-4274-840c-73f1aab092b2/allow-blocked-content-javascript-on-local-html-files-ie11?forum=ieitprocurrentver
http://woshub.com/how-windows-determines-that-the-file-has-been-downloaded-from-the-internet/
But neither NTFS streams or comment made any impact.
I tried all of those options and some other things, like downloading all of
the JS scripts needed and referencing them locally. I could not got IE to
load the JS without changing zone info, which is almost always going to be
blocked by group policy and so of little use.
Better idea? Don't reference locally. Use the IIS ability of the report
and push the reports there.
On Wed, Oct 9, 2019 at 3:10 PM Przemysław Kłys notifications@github.com
wrote:
I tried fixing it, but I'm out of ideas. Leaving this open. maybe someone
will manage to fix it. I even tried playing
https://social.technet.microsoft.com/Forums/ie/en-US/7f8e1bc1-f4be-4274-840c-73f1aab092b2/allow-blocked-content-javascript-on-local-html-files-ie11?forum=ieitprocurrentver
http://woshub.com/how-windows-determines-that-the-file-has-been-downloaded-from-the-internet/
But neither NTFS streams or comment made any impact.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EvotecIT/PSWriteHTML/issues/49?email_source=notifications&email_token=AAJQTCVZFX5XZFBIHI77YW3QNYUDNA5CNFSM4I3VLIJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAY7VPA#issuecomment-540146364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJQTCTZHTV6BEJ5QIDO4CLQNYUDNANCNFSM4I3VLIJQ
.
No, even when I changed zone info using every possible trick, I could not get this to work.
I've tracked this to Datatables 1.10.12 working fine, where 1.10.13+ doesn't work. But it only doesn't work if used with my code.
This folder has 2 files: https://github.com/EvotecIT/PSWriteHTML/tree/master/Examples/Example-IE
Both should work in IE. One is mine with 1.10.12, one is using some random example where I've put a similar version.
This needs further debugging why it fails for higher versions.
I can confirm the TestIE-Works.html example works in IE and Edge.
Yes. As always. Testing few other things.
Sounds good, thanks for getting this working in IE/Edge!
Should be working in new release now. VIsNetwork still not fixed thou
| gharchive/issue | 2019-09-30T02:52:09 | 2025-04-01T06:36:56.893817 | {
"authors": [
"1RedOne",
"PrzemyslawKlys",
"c3rberus"
],
"repo": "EvotecIT/PSWriteHTML",
"url": "https://github.com/EvotecIT/PSWriteHTML/issues/49",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
420155524 | Configuration set up
Dear Team,
Please provide wiki or help document for how to implement or use this tool. This would be helpful for everyone.
Cheers
velan
We've added wiki to the project. We hope that it's enough to try Nostradamus.
| gharchive/issue | 2019-03-12T19:01:00 | 2025-04-01T06:36:57.061972 | {
"authors": [
"ASitnikov",
"velanbabu"
],
"repo": "Exactpro/nostradamus",
"url": "https://github.com/Exactpro/nostradamus/issues/6",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1147308816 | openmw-0.47.0
https://retropie.org.uk/forum/topic/27034/new-port-installer-openmw-morrowind/39?_=1645559365579
not going to bother
| gharchive/issue | 2022-02-22T19:53:27 | 2025-04-01T06:36:57.063020 | {
"authors": [
"Exarkuniv"
],
"repo": "Exarkuniv/RetroPie-Extra",
"url": "https://github.com/Exarkuniv/RetroPie-Extra/issues/38",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
443262427 | Liquid syntax error (line 129): Unknown tag 'image
Hello :)
$ jekyll serve
Configuration file: none
Source: /home/meow/testtesttestrepo.github.io/strange-case
Destination: /home/meow/testtesttestrepo.github.io/strange-case/_site
Incremental build: disabled. Enable with --incremental
Generating...
Liquid Warning: Liquid syntax error (line 667): Expected end_of_string but found id in "{{ range first 10 .Data.Pages }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 668): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 756): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 759): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 760): [:dot, "."] is not a valid expression in "{{ .Content }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 830): Expected end_of_string but found id in "{{ range first 10 .Data.Pages }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 831): [:dot, "."] is not a valid expression in "{{ .Permalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 831): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 948): Expected end_of_string but found id in "{{ range first 10 .Data.Pages }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 949): Expected end_of_string but found id in "{{ if eq .Type "post"}}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 950): [:dot, "."] is not a valid expression in "{{ .Permalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 950): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 956): Expected end_of_string but found id in "{{ if eq .Type "page" }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 957): [:dot, "."] is not a valid expression in "{{ .Permalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 957): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1004): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1020): Expected end_of_string but found string in "{{ template "theme/partials/header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1024): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1032): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1035): Expected end_of_string but found id in "{{ range first 10 .Data.Pages }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1036): Expected end_of_string but found id in "{{ if eq .Type "post"}}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1037): [:dot, "."] is not a valid expression in "{{ .Permalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1037): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1043): Expected end_of_string but found id in "{{ if or (eq .Type "page") (eq .Type "about") }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1044): [:dot, "."] is not a valid expression in "{{ .Permalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1044): [:dot, "."] is not a valid expression in "{{ .Type }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1044): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1044): [:dot, "."] is not a valid expression in "{{ .RelPermalink }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1048): Expected end_of_string but found string in "{{ partial "footer.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1058): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1060): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1061): [:dot, "."] is not a valid expression in "{{ .Content }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1063): Expected end_of_string but found string in "{{ partial "footer.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1078): [:dot, "."] is not a valid expression in "{{ .Date.Format "Mon, Jan 2, 2006" }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1085): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1087): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1088): [:dot, "."] is not a valid expression in "{{ .Date.Format "Mon, Jan 2, 2006" }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1089): [:dot, "."] is not a valid expression in "{{ .Content }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1091): Expected end_of_string but found string in "{{ partial "footer.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1108): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1110): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1111): [:dot, "."] is not a valid expression in "{{ .Content }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1113): Expected end_of_string but found string in "{{ partial "footer.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1121): Expected end_of_string but found string in "{{ partial "header.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1123): [:dot, "."] is not a valid expression in "{{ .Title }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1124): [:dot, "."] is not a valid expression in "{{ .Date.Format "Mon, Jan 2, 2006" }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1125): [:dot, "."] is not a valid expression in "{{ .Content }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Warning: Liquid syntax error (line 1127): Expected end_of_string but found string in "{{ partial "footer.html" . }}" in exampleSite/content/post/creating-a-new-theme.md
Liquid Exception: Liquid syntax error (line 129): Unknown tag 'image' in exampleSite/content/post/migrate-from-jekyll.md
jekyll 3.8.5 | Error: Liquid syntax error (line 129): Unknown tag 'image'
FAIL: 1
sorry, isn't jekyll template :)
No worries!
| gharchive/issue | 2019-05-13T08:13:32 | 2025-04-01T06:36:57.068892 | {
"authors": [
"bimmer44",
"soko1"
],
"repo": "ExchangeRate-API/strange-case",
"url": "https://github.com/ExchangeRate-API/strange-case/issues/12",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
1381562482 | Enforce sum(occ) == 1 in the output of qFit :bug:
Describe the bug
Since we are not enforcing CPLEX to have occ == 1, we need to create a function outside of CPLEX to make sure that sum(occ) of each protein residue equals one.
A function will need to be created in qfit.py and applied after qFit segment (for proteins) or qFit residue (for residue).
This has been fixed with #175
| gharchive/issue | 2022-09-21T22:05:01 | 2025-04-01T06:36:57.075652 | {
"authors": [
"stephaniewankowicz"
],
"repo": "ExcitedStates/qfit-3.0",
"url": "https://github.com/ExcitedStates/qfit-3.0/issues/261",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
130462009 | Broadcast changes in Node attributed data to consumers
Any changes in the attributes of a Node instance should trigger a broadcast via RabbitMQ.
Done
| gharchive/issue | 2016-02-01T19:43:25 | 2025-04-01T06:36:57.090508 | {
"authors": [
"wildlyadequate",
"williewheeler"
],
"repo": "ExpediaDotCom/seiso",
"url": "https://github.com/ExpediaDotCom/seiso/issues/195",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1427486187 | Implement attaching .txt file to send more than 15 K characters reported by @rushatgabhane
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Problem:
you can't send more than 15k chars.
Solution:
Attach a .txt file when a user pastes more than 15k chars.
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @rushatgabhane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666957808027799?thread_ts=1666892266.003079&cid=C01GTK53T8Q
View all open jobs on GitHub
Reproduced, unique labelling eng. I'm not sure if we should commit to the txt file without more eye on the issue and considering other options
I think this is indeed a feature request that needs consideration in a wider audience proposal.
| gharchive/issue | 2022-10-28T16:19:10 | 2025-04-01T06:36:57.094155 | {
"authors": [
"MitchExpensify",
"flodnv",
"kavimuru"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/12247",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1808089228 | Dev: Web - Magic code does not blur during sign in loading
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
. Go to login page, enter email and click Continue
2. Type quickly more than 6 digits in the magic code field
3. Once 6th digit is entered, signing in starts.
4. Then the magic input should blur till backend returns success or error.
5. See that while signing in started, the 7th digit onwards can still be typed into magic input.
Expected Result:
Magic input should blur on entering 6th digit till backend sends its response
Actual Result:
Describe what actually happened
Workaround:
Magic input is not blurred
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop
Version Number: Dev 1.3.41-2
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/28eb1d8c-a1a9-4597-8bd9-521b34ad72cf
**Expensify/Expensify Issue U@c3024
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689497435352449
View all open jobs on GitHub
Ah cool, thanks for that!
This is a dupe of https://github.com/Expensify/App/issues/21293 & https://github.com/Expensify/App/issues/23087. Closing!
Ah cool, fair. @garrettmknight want to pay out on the job linked to the issue that's open?
| gharchive/issue | 2023-07-17T16:00:41 | 2025-04-01T06:36:57.099786 | {
"authors": [
"kbecciv",
"trjExpensify"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/23009",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
935971291 | [Discussion] Add the ability to handle images in Onyx
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Problem
Right now, we have no way of saving images offline. We can't use Onyx as it has storage limitations on web with a 5MB limit. There's been a lot of discussion on how to handle this in this issue and in this slack thread.
Why is this important?
This is important to be able to handle offline functionality of images
Solution
Create an offline storage solution for Onyx so that even when the application is offline and closed, the attached images will persist and continue to upload
Expensify/Expensify Issue URL:
https://github.com/Expensify/Expensify/issues/169197
cc @thienlnam
View all open jobs on Upwork
Triggered auto assignment to @greg-schroeder (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
Create a JNI-based AsyncStorage for Onyx that works across all platforms
Sorry but this looks like a huge task to do. Maybe we did not mean to do so. Can anybody confirm what exactly is need to be built? I expect that we need to expand AsyncStorage in a wrapper so that it supports a method like AsyncStorage.setImages() or AsyncStorage.removeImages(). Please, this looks daunting to me.
@parasharrajat Yup this is a huge task, but basically is going to be summed up with what needs to happen from this slack tread happening now. I updated the solution a bit but I imagine that it will keep updating until we figure out what the most viable solution for this will be
Posted to https://www.upwork.com/jobs/~011fcd226e59956a18
I'm going to add a new Contributor Manager, I'm out of office next week. They can update the price if needed (sounds like @parasharrajat might want for $250 though :trollface: )
Triggered auto assignment to @SofiedeVreese (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
@mallenexpensify :jack_o_lantern:. Maybe I will find a solution that takes lesser effort.
@mallenexpensify I have applied on upwork by the name "Aditya Batra" on your JD.
Hey @aditya27dev can you a proposal with the technical explanation of the changes you will make in this GH here? thanks!
Hi @SofiedeVreese Sorry I can't share technical changes here publicly which is a inappropriate way of doing a job.
But I can work on this task, if you hire me.
Hey @aditya27dev per our contributing guidelines, we do require contributors to make a proposal for their solution and post it as a comment in the corresponding GitHub issue. The solution proposal should include a brief technical explanation of the changes proposed. We don't hire if the contributing guidelines aren't being followed.
Throwing a new title on this since discussion is still ongoing in the slack thread, to view or participate check it out here
Seems like the discussion is still fairly ongoing.
Clarifying with @thienlnam to see if there's some sort of resolution in the Slack thread.
Adding a planning label and changing to a weekly for now, per this comment. We're still discussing possible solutions so having this as a daily doesn't make sense for now.
I don't think we have any updates here. @thienlnam should we close this GH or is there still an ongoing discussion? I was assigned as part of the "external" label (= to push it to Upwork) but I'm not sure if my assignment is still relevant here.
Discussion has mainly halted - here is where we're at with the last comment from @kidroca
Neither Android or iOS are handling file/blob pasting in E.cash ATM
On web/desktop the clipboard provides a File object
The only time something happens from a blob is when html content is copied, then any image sources are fetched as blobs, and then an in memory File is constructed. The preview image uses the File.sourceURL
The File constructor is available only on web/desktop not on native
It might be possible to do the same on native, but would involve more hoops than simply using the FS
And I can't even find anything on the subject, besides converting the blob to a base64 string and feeding it as image source.uri
So you have to:
Read blob from SQL and keep it in memory (as less as possible)
convert it to something the Image can work with.
Feed it to the Image component
Compared to:
Have a URI string pointing to a file in FS
Give it to the Image
Before making this decision let's find an example that uses Blobs to display images and what it involves. E.g. if it have to store the blob on disc first, even temporary, it defeats the purpose
Going to be looking into this in the next couple of weeks but if someone else would like to dig into this feel free!
Been focused on a few other things at the moment so I haven't had time to look into this yet - the investigation can still be an external task
Hey, @kidroca, can you spend some time investigating this? You can do this on your existing contract
@arielgreen Yes, I've taken part of the discussion on slack and can research this further
The original plan was to keep image/files in the database. This is easy to achieve on web/desktop, but more complicated on native with the current storage library and model we use
AsyncStorage works only with strings ATM - converting files to base64 strings should be out of the question. But we can discuss it if you want to
MMKV is no better as it only supports simple types like number, boolean, or string
Trying to store images/files in the database would be tremendously difficult even if we switch to a richer database library
I've tried to explain it on slack.
The key point for storing everything in "local db" is simplicity and universal logic, but that won't be the case.
I'll propose a simpler and IMO more maintainable solution.
Onyx addresses the storage layer through a simple get/set/merge interface
We've already extracted this interface and were able to swap different underlying storage "drivers" that can be selected based on platform (e.g. MMKV for native and AsyncStorage for web/desktop)
iOS and Android
Let's say we have a storage/index.native.js
Onyx imports Storage from ./storage and uses it like Storage.get, Storage.set, etc...
Under the hood it delegates calls to AsyncStorage like we already do
While for the file related operations we'd use react-native-fs
We can either add getFile/setFile specific methods or overload the existing get, set methods to work with files based on input type
Storing files
A request to save a file would be very similar to existing storage calls - it will have a key and value
The key should be based on the remote url of the file (if such exists) and can be prefixed by a collection name
e.g. FILES_${key}
The value should be File metadata (this is provided by our file/image picker)
Using react-native-fs we store the file in our app documents (or cache) space with a file name that's based on the key e.g. FILES_${key}
The specific implementation can either move or copy the file there
As with regular storage, we should have eviction logic that cleans up files when storage is low or the OS complains
Storing files this way is very fast - we're working with a reference to the file and it never actually travels from JS to native
Moving/copying operations are handled by the OS and threaded separately
Reading files
Reading is based on the same concept
the Onyx API receives a key like FILES_${key} it's identified as a request to read a file
We know the location of the file because it's based on the key and the storage folder
Using react-native-fs we create a File reference to the file
Images and File preview components can use this to render the file
Accessing the file in this manner means
We're not reading the whole file from native to JS and then keep it in memory
The preview is loaded only when it has to and it's handled natively
You can checkout how the "storage provider" concept works in practice here: https://github.com/Expensify/react-native-onyx/pull/95
Web and Desktop
Let's say we have a storage/index.js
Onyx imports Storage from ./storage and uses it like Storage.get, Storage.set, etc...
Under the hood it delegates calls to AsyncStorage like we already do
But for the file related operations we'll implement a solution that stores Files in IndexedDb as Blobs
Storing files
The flow is very similar to the one for native.
We'll be using a key like FILES_${key} and File metadata
Then we'll convert the file to Blob and save it under the key in IndexedDB
Reading files
We receive a key which we evaluate as a File key
We use it to get a Blob from the database
When we retrieve the Blob we can convert it to File using the File constructor - our web/desktop implementations have similar logic for pasted images (see TextInputFocusable/index.js)
Images and File preview components can use the file to render
Using different Storage Provider for native and web allows us to implement the best storage handling for each platform.
Even though we're using Platform specific code, it's encapsulated and abstracted by Onyx so that Onyx user like Expensify/App don't have to
@kidroca This proposal looks great - I agree that we should be using the best storage handling for each platform and encapsulating it through Oynx. If possible, let's explore this with a POC and see how this would work within Oynx
Alright, I'll prepare a POC that stores and displays an image with Onyx
Submitted 2 PRs
Add file handling capabilities to Onyx: https://github.com/Expensify/react-native-onyx/pull/102
Small updates to Expensify/App to showcase offline file persistence: https://github.com/Expensify/App/pull/4908
You can also use the branch to build and run the POC: https://github.com/kidroca/Expensify.cash/tree/kidroca/file-handling-poc
Overview of the changes
The changes are based on the idea here (though not exactly): https://github.com/Expensify/App/issues/3867#issuecomment-902662445
It was easy to move existing web/desktop handling to happen through localforage, this allows us to save FIles in IndexedDB with almost no changes. Using localforage moves all key/value handling to IndexedDB which allows much more than 5MB for everything that we store in Onyx
On native we store a reference to a file, this is OK as everything working with native files supports this and expects this format. The only thing that we do is to move/copy the file to a place where we know it would not be removed by the user or the OS. This is the app/documents/onxy_files folder
There's still some work to be done if the POC is accepted (eviction, error cases), the POC tries to showcase this functionality:
Create an offline storage solution for Onyx so that even when the application is offline and closed, the attached images will persist and continue to upload
What needs to be done
File cleanup logic
Clean up works on web/desktop as removing the persisted request removes the File with it
But on mobile, the file is kept separately and we need to relay to Onyx that a file is no longer needed
Perhaps we can update the Network queue to call a function like Onyx.releaseFile(file) when a request containing a file
was completed.
A simpler solution might be to run a check during launch (or before exit) that removes files older than one week, assuming they were uploaded by our request retry logic
Eviction logic
Handle errors resulting from lack of space
There's functionality that lists the files created by "us". We can add filtering and remove the oldest ones
Cleanup and documentation
There are some "Todo" comments on possible enhancements or alterations
Some items would need to be better documented
Awesome, this is looking really good - going to loop in @marcaaron and @tgolen and see what their thoughts on the POC are
No update here yet - going to start pinging people for some thoughts / reviews on the POC
When you open the PR you see this
which might be scary 👻 but it's just the package-lock update
Pinged for reviews but n6 deadline is taking priority - going to ping about this again next week
Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.
We've made some changes in the Onyx PR: https://github.com/Expensify/react-native-onyx/pull/102
The file handling process for native is simplified a lot and it makes usage easier. There are notes in the description:
When an attachment is picked the AttahcmentPicker will persist it to App/cache folder. It is then available until cache is cleared
This lets us save only the reference to the File in our key/val storage
This reference is enough to work with the file - use it in an <Image /> or in a upload request
The PR is approved, but we might need to deal with an issue on mobile web ios first.
Discussions have been happening in the relevant PRs
Out of curiosity, when we add E2E encryption, how do we intend for this to work? I think we can maintain it unencrypted on disk such that it works in the <img> tag, but when we upload it will it be part of the regular message body as normal?
There's an issue on mobile-web due to us deleting persisted requests (and their files) as soon as they are added to the network queue: https://github.com/Expensify/App/pull/4908#issuecomment-967139238
The work in this ticket: https://github.com/Expensify/App/issues/5987 would also solve the problem here as it will only remove persisted data after the request is completed
Looks like PR is ready for review https://github.com/Expensify/App/issues/5987
Once that is merged, we can merge the other file handling PR https://github.com/Expensify/react-native-onyx/pull/102
Synced with main (1170 commits 🤯)
I've reverted the change to persist attachment requests to storage so that we can merge this as it was approved, and once #6556 is merged we can just enable persisting attachment requests
I understand the Onyx POC was just merged and that we want a follow-up to add some more tests. Is there an issue somewhere to bring these changes to life and implement offline-first images in the New Expensify app?
Yeah so this
PR: https://github.com/Expensify/App/pull/4908#event-5768021643 (I've been meaning to review) is so that we can handle images with onyx
After that, this issue (https://github.com/Expensify/App/issues/6527) is probably the next step for offline-first images
One thing I forgot to bring up
When #4908 it will switch web/desktop from using one storage medium - localStorage to another - IndexedDB
Meaning any logged in users would be logged out
Should we include a migration that tries to move any existing Onyx values in localStorage to IndexedDB before the app starts (along the rest of the migrations)?
ios and android aren't going to be affected since they continue to use the same medium - AsyncStorage
I guess yes, we should add that.
Yeah, I agree, let's try to migrate everything if we can.
Alright, I'm working on it
Added the migration: https://github.com/Expensify/App/pull/4908/files#diff-fc59a9d775dba3004d8ed5a4dec154bbd2487455e7c720afed29bc8003a5228f
PR was approved but we forgot to remove the HOLD label: https://github.com/Expensify/App/pull/4908#issuecomment-1010993484
We can enable file persistence after #6556 is merged
It deals with the issue of prematurely deleting persisted request (and the files to be uploaded)
After #6556 we'll be able to remove the comment here and set persist to true
https://github.com/Expensify/App/blob/c224cfe5ba9f9fc2214a2963d6c02d855dc1c96e/src/libs/actions/Report.js#L1170-L1173
Still waiting on #6556
#6556 was merged
Created a PR to enable attachment persistence: #7520
Found 2 problems around persisted attachments
No loading animation/preview
You can see it on most of the videos on the PR #7520 (see web or mobile web)
Be offline
Select an attachment to be uploaded (preferable larger so it takes more time to upload)
Quit the app
Open the app again
Open the chat where the attachment was uploaded
Observe it's not there, and there's no indication something is uploading
The attachment only appears after the upload is over
Problem:
The optimistic action that serves as a placeholder during the upload is removed
We seem to clear any optimistic actions at launch or when a chat is opened
The reason seem to be to prevent discrepancies between local and online state - any optimistic actions are removed - if real actions exist for the same they would be fetched shortly
https://github.com/Expensify/App/blob/425e718b9ed3ac485da1e86a11779941daa95ba5/src/libs/actions/Report.js#L451-L457
Solution
I think we should try to cross reference optimistic actions with requests in the network queue
This way when we clean up optimistic actions we keep the ones that still have pending request
We already put optimisticReportActionID on the request so we can distinct it
https://github.com/Expensify/App/blob/425e718b9ed3ac485da1e86a11779941daa95ba5/src/libs/actions/Report.js#L1169-L1175
We can make a lib or expose a function that return any pending Report_AddComment actions from network queue or persisted storage
Report.removeOptimisticActions would use that and skip removing optimistic actions that have pending Report_AddComment
2. We're only persisting a request if we're offline
NetworkRequestQueue.saveRetryableRequests is only called in the if(isOffline) block
https://github.com/Expensify/App/blob/425e718b9ed3ac485da1e86a11779941daa95ba5/src/libs/Network.js#L185-L206
Problem:
If we quit the app while an upload is still pending it will neither be upload or persisted
For a request to be persisted you have to be offline first and then to make the request
Recent changes alleviate this to some extent - when a request is persisted to storage it will only be removed after it's successfully performed - it'll be retried until eventually succeeding
But it would only get to be persisted if you were offline to begin with
Solution
Requests with the `persist` flag should be persisted regardless of being offline or not
If the user quits the app while the request isn't completed existing logic would retry it on next launch
Otherwise added logic would remove it from persistent storage when it succeeds
The following
https://github.com/Expensify/App/blob/425e718b9ed3ac485da1e86a11779941daa95ba5/src/libs/Network.js#L229-L230
becomes
if (queuedRequest.data.persist) {
NetworkRequestQueue.saveRetryableRequests([queuedRequest]);
}
processRequest(queuedRequest)
.then(response => {
onResponse(queuedRequest, response);
NetworkRequestQueue.removeRetryableRequest(queuedRequest);
})
We should be live with this already and can close this right? @kidroca
@thienlnam I think we have the bare minimum if that's enough I guess we can close
I've pointed out 2 problems using the feature the way it is right now
👍 Will keep this open until we resolve those issue
I'll create separate tickets for them for more visibility and then we can discuss the proposed solutions in those tickets
Closing now that we have other tickets for the existing problems
https://github.com/Expensify/App/issues/7934
https://github.com/Expensify/App/issues/7935
| gharchive/issue | 2021-07-02T18:09:09 | 2025-04-01T06:36:57.132942 | {
"authors": [
"MelvinBot",
"SofiedeVreese",
"aditya27dev",
"arielgreen",
"kadiealexander",
"kidroca",
"mallenexpensify",
"parasharrajat",
"quinthar",
"roryabraham",
"tgolen",
"thienlnam"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/3867",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2206820350 | Starting a chat with a new user show as a group chat in the header
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @youssef-lr
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1711087497811689
Action Performed:
Start a chat with a new user
Send a message
Expected result:
The chat header should display a single user
Actual result:
The chat header displays the header of a group chat, containing both participants emails
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/a6770edf-2660-4de3-ae59-0cd1838f2278
https://github.com/Expensify/App/assets/38435837/13a23730-2979-415d-9bb6-8346c77ecfb9
View all open jobs on GitHub
I think this is an artifact of the on-going group chat migration and implementation. @marcaaron Does that sound right?
Feel free to close if we already have an existing issue, or this will be resolved following implementation.
Yep, working on this here
| gharchive/issue | 2024-03-25T22:18:57 | 2025-04-01T06:36:57.139765 | {
"authors": [
"JmillsExpensify",
"m-natarajan",
"marcaaron"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/38965",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2218206348 | [$500] Android - BA - After tapping disconnect BA, in wallet section BA is not removed
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4466759
Issue reported by: Applause - Internal Team
Action Performed:
Login app
Add a bank account using chase ending 1111
Tap disconnect Bank account and delete bank account
Navigate to settings---- wallet
Note Bank account is shown and not deleted
Again navigate to connect BA page
Tap connect manually
Enter route number and account number
Tap next and then tap confirm
Expected Result:
After tapping disconnect BA, in wallet section BA must not be shown. The deleted bank account must not be shown when tap confirm (after entering details in connect manually page.)
Actual Result:
After tapping disconnect BA, in wallet section BA is not removed .The deleted bank account is shown when tap confirm (after entering details in connect manually page.)
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/273d0a7f-e6fd-49bc-add5-bd445ba17023
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01801c400ba36cbd72
Upwork Job ID: 1774830276732727296
Last Price Increase: 2024-04-08
@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
@GandalfGwaihir I still can't connect the bank account. Could you connect the bank account successfully? If yes, could you share a video?
Proposal
Please re-state the problem that we are trying to solve in this issue.
After tapping disconnect BA, in wallet section BA is not removed .The deleted bank account is shown when tap confirm (after entering details in connect manually page.)
What is the root cause of that problem?
https://github.com/Expensify/App/blob/2ce785c7c0831c9a6857f4a197cada6da28736e3/src/pages/workspace/WorkspaceResetBankAccountModal.tsx#L52
When clicking on "Disconnect bank account" we only reset achData from ONYX and we don't remove bankAccountID from bankAccountList. In the Wallet Page we are using bankAccountList to display bank account
What changes do you think we should make in order to solve the problem?
In here
https://github.com/Expensify/App/blob/2ce785c7c0831c9a6857f4a197cada6da28736e3/src/pages/workspace/WorkspaceResetBankAccountModal.tsx#L52
Besides, removing achData from ONYX, we also should update bankAccountList like this
onConfirm={() => {
BankAccounts.resetFreePlanBankAccount(bankAccountID, session, achData?.policyID ?? '', user)
if (bankAccountID) {
BankAccounts.deletePaymentBankAccount(bankAccountID)
}
}}
What alternative solutions did you explore? (Optional)
NA
@DylanDylann Please follow these step to add bank account. Make sure that you use the correct data is provided in this thread
@nkdengineer's proposal is clearer and easier to understand with the correct reference. But your idea is the same as @GandalfGwaihir's proposal. Thus, I suggest we should go with @GandalfGwaihir's proposal because his proposal is the first one
🎀 👀 🎀 C+ reviewed
Waiting for a review from @puneetlath
Wait, I realize I approved this proposal, but now that I'm reviewing the PR, I don't think this is actually a bug. Disconnecting a bank account from the workspace doesn't mean it should be removed from your wallet. It just means it should no longer be tied to that workspace. I'm going to close this out, but will still pay out since I approved the proposal and the work was done.
@GandalfGwaihir can you close your PR?
Paid, thanks for the bump.
| gharchive/issue | 2024-04-01T12:55:53 | 2025-04-01T06:36:57.148689 | {
"authors": [
"DylanDylann",
"lanitochka17",
"nkdengineer",
"puneetlath"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/39355",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2298684366 | [$250] Editing comment with image attachment fails to load the image when cache expires
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1715767781452439
Action Performed:
Type text and add an image attachment.
After sending the comment, inspect the tag for data-expensify attributes.
Edit the comment and make a trivial change to the text before the attachment.
Observe that the tag no longer has data-expensify attributes.
Disable cache in dev tools, or clear cache and reload the page.
Observe that the edited comment no longer loads the image.
LINK: https://staging.new.expensify.com/r/5708510475809890
Expected Result:
Editing a comment, clearing cache, and reloading the page should display the comment and the image attachment.
Actual Result:
Clearing cache and reloading shows the comment and a placeholder box instead of the image attachment.
More details here: https://github.com/Expensify/App/issues/41952#issuecomment-2112095398
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/d87424e2-9423-421c-8712-a71e4437c250
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~018082d3734c0fe3cf
Upwork Job ID: 1792320613124546560
Last Price Increase: 2024-06-10
Issue OwnerCurrent Issue Owner: @
@mallen tagging you as per this comment
@m-natarajan you've tagged the wrong person. cc @mallenexpensify
Labeled internally and added to #vip-vsb cuz it doesn't have to do with money. All yours JLi
Not overdue, waiting on an Engineer to pick this up.
Not overdue
internal. not overdue
🎀 👀 🎀 assign internal
Sorry, I don't have bandwidth to take this, unassigning!
🎀 👀 🎀 assign internal
I am going to make this external and look for proposals, not sure if this really cannot be solved externally
Proposal
Please re-state the problem that we are trying to solve in this issue.
Clearing cache and reloading shows the comment and a placeholder box instead of the image attachment.
More details here: #41952 (comment)
What is the root cause of that problem?
When we edit the comment with image attachment, the data-expensify- attributes were stripped. The data-expensify-source is one of them, so after reloading the authentication header from data-expensify-source no longer applies, therefore the image fails to load.
What changes do you think we should make in order to solve the problem?
Store the data-expensify- attributes in an object like a cache (or even in Onyx), then after editing, apply the attributes again to the image html data. This way we'll still preserve the important metadata of data-expensify- in the image tags.
What alternative solutions did you explore? (Optional)
Prevent the user from editing text with attachment.
@rushatgabhane what do you think of the proposal?
When we edit the comment with image attachment, the data-expensify- attributes were stripped.
@truph01 your suggestion is to store the attributes and apply them again before saving the comment.
But why does editing a comment strip the expensify attributes in the first place? Can we make it so that they don't get removed? Then we won't have this problem
@rushatgabhane This is what the markdown for "text with image" looks like
an image
As you can see, the markdown for image only contains the URL of the image and the image name (if any).
So editing the comment will strip the Expensify attributes because the Expensify attributes are not parts of the markdown syntax for images.
Can we make it so that they don't get removed?
This will mean we need to use another markdown syntax for images that contain the attributes
Like
Or another idea is to make the attributes the params of the image URL, like ?data-expensify-source=...&data-expensify-height=100
Either way, IMHO that will make the image markdown very lengthy and hard to edit to the user, and might not conform to any markdown standard
These attributes are added by the backend when an attachment is uploaded; they are not part of the original syntax. When the backend processes the attachment, it adds the necessary attributes.
I believe the fix should be on the backend. When editing a comment containing an attachment, the backend should apply the same logic and replace/insert the <img> HTML.
There's a related ticket addressing a similar problem with <video> attachments. @rushatgabhane, perhaps you can cross-reference how the team handled that issue and see if the same solution can be applied here.
https://github.com/Expensify/App/issues/41952
Working on the backend solution
@rushatgabhane I am not sure if I am doing something wrong but I cannot reproduce this
Same! I cannot reproduce this bug
https://github.com/Expensify/App/assets/29673073/c65f05c3-2b58-447b-ad31-97c62b6d34c5
@mountiny i can consistently reproduce this bug on staging, but not on production.
Staging - Reproducible
https://github.com/Expensify/App/assets/29673073/4f70fb63-b8f9-45f9-9df2-b2726f9edc11
Production - Not Reproducible
https://github.com/Expensify/App/assets/29673073/b08a2d43-b22c-4865-839d-0517f1984ebf
I can still recreate this bug on prod
Here's a short debug session where we can see the <img> in the updated comment lacks the data-expensify attribute. This is the reason we're getting the 302 redirects to an error page on old dot, because the request is meant to be made with an auth header, but isn't
https://github.com/Expensify/App/assets/12156624/d0b8271e-719e-440e-b31a-0c1d27b463ce
@kidroca that makes sense, after the auth for oldDot has expired the image won't load anymore.
@mountiny this is an internal bug
To reproduce this wait for auth token to expire on oldDot
I don't think auth token matters - it's not begin sent regardless of whether it's expired or not
The network requests are redirected to Old Dot, because of some internal server error handling
But the main issue is, the <img> html is getting re-written and some attributes are stripped upon editing the comment
Thanks, I will have to investigate more
No update right now, this is lower priority than other tasks
Issue not reproducible during KI retests. (First week)
lets keep this open until another retest but seems like this might have gotten fixed elsewhere
I was able to reproduce on the latest staging build, Desktop, Version 9.0.25-10
User A types message in DM with user B > adds image > clicks Send
User A edits text in message
User B views message, observes image doesn't show.
I am not able to prioritize this at the beginning of this week unfortunately.
Adding hot picks for this one as I am focusing on a fire fix in the foreseeable future and not able to prioritise this one right now
same
focusing on workspace feeds wave-collect
Not overdue
I was talking with @mjasikowski that he might be able to take this on later in the week
Not overdue
@mjasikowski will help out here 💪
Assigned!
FInally have time to dig into this.
was able to repro still
https://github.com/user-attachments/assets/79bfbfcc-7303-480b-836d-f09effc54ccb
Current findings:
Web-Expensify does strip extra attributes form img tags via sanitizeAndValidateComment
Unfortunately, Expensify-Common does this as well in ExpensiMark.ts, making the tags stripped before we even get to the UpdateComment API call
There's a draft expensify-common PR now adding attribute caching support to ExpensiMark.ts, I'll try to do a full test tomorrow.
It turns out that only expensify-common fix is enough, and that's ready in https://github.com/Expensify/expensify-common/pull/808
PR still under review
https://github.com/Expensify/Web-Expensify/pull/43698 was needed after all, submitted that too
Hi @mjasikowski - just a heads up to let you know I'll be OOO from the 3rd to 14th.
I'll prep a Payment Summary, I think this is all that's needed from me:
C+: @rushatgabhane $250 (New.Dot payment)
@m-natarajan the fix is now on both staging and production, can you re-test?
I just did a quick-test in the latest staging build on Desktop and, after editing a comment, the image still shows! Think we need to to still leave this open for a retest?
Payment Summary
C+: @rushatgabhane $3250 (owed via ND payments)
Ha, yeah I fat fingered that one - thanks @rushatgabhane!
$250 approved for @rushatgabhane
@truph01 can you provide more details plz? Ideally a bullet point list with links and time stamps? It'll make it easier to review for potential compensation. Thx
@mallenexpensify Sure, here's the timeline:
The issue was made external on June 10
I posted my proposal right after that on June 10, which has the Solution 2 of
Store the data-expensify- attributes in an object like a cache, with the image source as key, then after editing, apply the attributes again to the image html data. This way we'll still preserve the important metadata of data-expensify- in the image tags.
And some draft implementation details
On June 14, There was a suggestion to fix in back-end by @kidroca
@mountiny seems to agree with it and the issue is considered to be Internal and back-end fix was attempted from this point.
On Sep 23, @mountiny assigned @mjasikowski to work on the issue
On Sep 26, the PR was raised by @mjasikowski, which uses same approach as my proposal. No back-end fix is done.
This PR adds caching for additional attributes to the tags when converted to and back from Markdown.
As such, I think a compensation of 50% to me makes sense, because the issue was made Internal for attempted back-end fix but actually there's no back-end fix done and the solution that ends up being used is same as suggested in my proposal.
No back-end fix is done.
backend fix was done, you just do not have access to it https://github.com/Expensify/Web-Expensify/pull/43729
@mountiny Was it needed to fix this issue? As from my testing with my initial proposal, only the front-end fix is enough.
It was required as we were stripping the necessary tags in PHP layer too so not only the FE changes would be sufficient for all cases. @mjasikowski will be able to provide better explanation
The tags were being stripped in the PHP layer. Caching attributes was already implemented in App for videos and that needed to be adjusted to apply images as well, but the was only a small portion of the changes needed.
Thanks for your input, I've updated the timeline summary highlighting there's a back-end fix.
Looking forward to the final decision from @mountiny @mallenexpensify
Thanks in advance!
Sorry @truph01, I don't think we are going to issue a reward for this one as there were many pieces required to fix this, and it was handled by @mjasikowski regardless of your proposal.
We appreciate your contributions and hope you will continue fixing issues in our repo ahead.
| gharchive/issue | 2024-05-15T19:27:58 | 2025-04-01T06:36:57.189654 | {
"authors": [
"amyevans",
"garrettmknight",
"jliexpensify",
"kidroca",
"m-natarajan",
"mallenexpensify",
"mjasikowski",
"mountiny",
"mvtglobally",
"rushatgabhane",
"truph01"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/42206",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2437822650 | Cleanup: move ComposerRef to the ComposerWithSuggestion where its implemented
There is the ComposerRef type which is being used in ReportActionCompose. The ref however is implemented inComposerWithSuggestion and it would be more natural to have that close together, and then let ReportActionCompose import it.
Ref: https://github.com/Expensify/App/pull/46091#discussion_r1696891379
@hannojg are you planning on tackling this?
As I am going OOO tomorrow @kirillzyusko can you do this little cleanup please!
Sure, feel free to assign me on this ticket!
I think it can be closed because PR got merged 👀
Payment summary:
$250 - C+ - @Ollyws - to be paid via NewDot
$250 approved for @Ollyws
| gharchive/issue | 2024-07-30T13:17:47 | 2025-04-01T06:36:57.194193 | {
"authors": [
"garrettmknight",
"hannojg",
"kirillzyusko",
"puneetlath"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/46499",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
984498544 | Deploy Checklist: New Expensify 2021-09-01
Release Version: 1.0.90-3
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:
[ ] https://github.com/Expensify/App/pull/4803
[ ] https://github.com/Expensify/App/pull/4918
[ ] https://github.com/Expensify/App/pull/4919
[x] https://github.com/Expensify/App/pull/4925
[ ] https://github.com/Expensify/App/pull/4954
[x] https://github.com/Expensify/App/pull/4957
[ ] https://github.com/Expensify/App/pull/4960
[x] https://github.com/Expensify/App/pull/4961
[x] https://github.com/Expensify/App/pull/4967
cc @Expensify/applauseleads
@roryabraham Are we good to start QA here? Or will you add the lock label and let us know when it's ready?
@isagoico Feel free to begin QA when ready! All the deploy systems are fixed and we should be back to normal operation now. The only thing that's changed long-term is that a mobile-deployer will close the checklist to trigger the prod deploy
Starting QA!
| gharchive/issue | 2021-09-01T01:26:59 | 2025-04-01T06:36:57.200548 | {
"authors": [
"OSBotify",
"isagoico",
"roryabraham"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/4976",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2629582825 | [Workspace feeds] We're erroneously showing an export row when "vendor bill" is selected as the export option for QBO
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #quality
Action Performed:
Prerequisite:
Members and company cards added in workspace
Go to staging.new.expensify.com
Choose the workspace from settings
Click company cards >Card Details
Expected Result:
No export row if Vendor bill is selected as the export option for QBO
Actual Result:
Export row displayed for QBO option and clicking it results in No accounts found page
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[X] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.
BugZero Checklist:
[x] [Contributor] Classify the bug:
Bug classification
Source of bug:
[ ] 1a. Result of the original design (eg. a case wasn't considered)
[x] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:
Where bug was reported:
[ ] 2a. Reported on production
[x] 2b. Reported on staging (deploy blocker)
[ ] 2c. Reported on a PR
[ ] 2z. Other:
Who reported the bug:
[ ] 3a. Expensify user
[x] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:
[ ] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: I think we don't need to comment on the previous PR because @narefyev91 also be author of this feature
[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[ ] [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Prerequisite
Members and company cards added in workspace
Test:
Choose the workspace from settings
Click company cards >Card Details
Verify that default export account is presented in Export row
Go to Accounting > Export > Export company card expenses as > Export as. And update to Vendor Bill
Back to company cards >Card Details
Verify that export menu item row is not presented
Do we agree 👍 or 👎
@sakluger Could you help to assign me to this issue? Because I already reviewed the PR
Small note: PR was deployed to prod on 11/13
We will handle the regression testing with Joe as part of the project and payments will be all done together for the project so I think we can close this now
| gharchive/issue | 2024-11-01T17:58:04 | 2025-04-01T06:36:57.220252 | {
"authors": [
"DylanDylann",
"MelvinBot",
"m-natarajan",
"mountiny",
"narefyev91"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/51887",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1239193630 | Workspace - Reimburse expenses- "Fast reimbursements = happy members!" and "Unlock Next day" headings are switching after every refresh
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Precondition: Add VBA flow
Go to https://staging.enew.xpensify.com/
Make sure you added VBA
Go to Settings - Reimburse expenses
Refresh the page
Expected Result:
Either Fast reimbursements = happy members! or Unlock Next day should keep appearing after refresh the page
Actual Result:
Fast reimbursements = happy members! have been switched with Unlock Next day after refresh the page
Workaround:
Unknown
Platform:
Where is this issue occurring?
Web
Version Number: 1.1.62.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/168916137-20c14424-0797-435b-917a-8aa64f7400c2.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
Would like to hang onto this and fix internally
PR: https://github.com/Expensify/App/pull/9138 (Not sure why it didn't link itself?)
| gharchive/issue | 2022-05-17T21:52:27 | 2025-04-01T06:36:57.228460 | {
"authors": [
"amyevans",
"kavimuru"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/9057",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1463947598 | [Fix] unread indicator count is not reset after logout
Details
Fixed Issues
$ #11671
$ https://github.com/Expensify/App/issues/11671#issuecomment-1305630104
Tests / Offline tests / QA Steps
Open the app on web.
Login with any account that has some unread messages.
Now wait a couple seconds.
Observe there are unread message count on the Tab.
Skip . (Go Offline in this step for Online test)
Do not go to the chat that has unread messages.
Now Sign out.
Wait a couple seconds.
Title updated and unread count reseted .
Offline Test : Test with step 5
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for expected offline behavior are in the Offline steps section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] I verified that if a function's arguments changed that all usages have also been updated correctly
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Chrome HT Account
https://user-images.githubusercontent.com/36869046/203878695-fb8083d7-c386-4b9f-ad9a-235599d6316b.mov
Chrome Simple Account
https://user-images.githubusercontent.com/36869046/203878749-4cf55def-03b3-4f53-86d5-66e6032878a8.mov
Chrome Offline
https://user-images.githubusercontent.com/36869046/203879275-9216fcff-9064-4ad9-b164-bda2de7169b0.mov
Safari HT Account
https://user-images.githubusercontent.com/36869046/203878794-78c85db2-75df-4fdf-8510-9d2a9c23ccc3.mov
Safari Simple Account
https://user-images.githubusercontent.com/36869046/203878852-da37cf08-f5eb-464d-ba12-76b489d39576.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
https://user-images.githubusercontent.com/36869046/203880564-37a1614c-0f6f-4c1f-befa-e86b77d69f47.mov
Offline
https://user-images.githubusercontent.com/36869046/203880657-09251dea-b5ce-4572-ab1a-6131be7b1e82.mov
iOS
https://user-images.githubusercontent.com/36869046/203884074-5c71bdef-f9f5-439d-b6ba-8d5ebb330908.mov
Offline
https://user-images.githubusercontent.com/36869046/203884359-144688ce-d8e7-401a-bf6b-b7dba56f40fb.mov
Android
Sorry @fedirjh we do not allow PRs to be raised without a proposal. If you want to share diffs or code examples that's fine, but creating PRs causes too much confusion for our team. Thanks!
| gharchive/pull-request | 2022-11-25T02:00:23 | 2025-04-01T06:36:57.270983 | {
"authors": [
"fedirjh",
"marcaaron"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/13035",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1557450309 | Track Push Notification Opt-In Status
HOLD on https://github.com/Expensify/Web-Expensify/pull/36368
Note that a require cycle was recently added by a different PR unrelated to this one.
Details
This PR starts tracking whether a user is opted-in to push notifications on a per-device basis.
Relevant comment: https://github.com/urbanairship/react-native-airship/issues/427#issuecomment-1124469522
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/209233
Tests / QA Steps
Web
Run the web app, and search console logs for deviceID.
Verify that you see a log line like:
[info] Got new deviceID - "def9ade3-7e2c-ecfe-ccb2-8941203716b2"
Refresh the page. Verify that you see a log line like so (with a matching GUID):
[info] Found existing deviceID - "def9ade3-7e2c-ecfe-ccb2-8941203716b2"
Close the tab, then open it again. Verify that you see a log line like so:
[info] Found existing deviceID - "def9ade3-7e2c-ecfe-ccb2-8941203716b2"
Log out then refresh the page. Verify that you see a log line like so:
[info] Found existing deviceID - "def9ade3-7e2c-ecfe-ccb2-8941203716b2"
Desktop
Run the desktop app, and search console logs for deviceID. You can open the dev console in the desktop app with CMD + Option + I
Verify that you see a log line like:
[info] Got new deviceID - "18632275959b5bef058ee4aa7fc70069d4ba54604c30986c4f1e3c09e287b521"
Close the app and reopen it. Verify that you see a log line like:
[info] Found existing deviceID - "18632275959b5bef058ee4aa7fc70069d4ba54604c30986c4f1e3c09e287b521"
Log out, then close the app and reopen it. Verify that you see that same log line.
Completely uninstall and reinstall the app, then open the app. Verify that you see the same log line.
iOS
Sign into the app.
When prompted, accept push notifications.
Look at the value of the pushNotificationsEnabled NVP, either with a CQ:
SELECT value
FROM nameValuePairs nvp
INNER JOIN accounts a ON a.accountID = nvp.accountID
WHERE a.email = '<email_you_used_to_login>'
AND nvp.name = 'pushNotificationsEnabled';
Or by signing into the same account on https://staging.expensify.com, then running NVP.get('pushNotificationsEnabled') in the console.
Verify that the NVP shows that you opted in to push notifications for the current device. It should look like this:
{"iPhone15,2_90CD2827-B91E-45E5-A63E-76ADC67F47F0":[{"isEnabled":true,"timestamp":"2023-01-27 02:17:44"}]}
Where iPhone15,2_90CD2827-B91E-45E5-A63E-76ADC67F47F0 is the deviceID, the most recent value of the NVP is at the end of the array, and isEnabled should be true.
Sign out and sign back in with a different account, then accept notifications when prompted.
Look at the NVP again for the new account and verify that it shows the same deviceID w/ isEnabled: true.
Sign out and sign back in with the first account.
Look at the NVP again for the first account and verify that it hasn't changed.
Completely uninstall and reinstall the app.
Sign in to the same account and accept push notifications when prompted.
Look at the NVP again, and verify that it hasn't changed.
Completely uninstall and reinstall the app.
Sign in to the same account, but this time reject push notifications when prompted.
Look at the NVP again and verify that there's a new entry at the end of the array that shows isEnabled: false.
Now open settings, scroll down to New Expensify, and enable notifications. Then come back to the app.
Look at the NVP again and verify that there's a new entry at the end of the array that shows isEnabled: true.
Now open settings, scroll down to New Expensify, and disable notifications. Then come back to the app.
Look at the NVP again and verify that there's a new entry at the end of the array that shows isEnabled: false.
Android
Sign into the app on Android.
Look at the value of the pushNotificationsEnabled NVP , either with a CQ:
SELECT value
FROM nameValuePairs nvp
INNER JOIN accounts a ON a.accountID = nvp.accountID
WHERE a.email = '<email_you_used_to_login>'
AND nvp.name = 'pushNotificationsEnabled';
Or by signing into the same account on https://staging.expensify.com, then running NVP.get('pushNotificationsEnabled') in the console.
Verify that the NVP shows that you opted in to push notifications for the current device.
Sign out, then sign back in with a different account.
Look at the NVP again for the different account and verify that you see the same deviceID with isEnabled: true.
Sign out, then sign back in with the first account.
Look at the NVP again for the first account and verify that it hasn't changed.
Close the app and reopen it.
Look at the NVP again and verify that it hasn't changed.
Now go into settings and disable notifications for New Expensify, then open the app again.
Look at the NVP again and verify that there's a new entry showing isEnabled: false
Close the app and reopen it.
Look at the NVP again and verify that it hasn't changed.
Now go into settings and re-enable notifications for New Expensify, then open the app again.
Look at the NVP again and verify that there's a new entry showing isEnabled: true.
[x] Verify that no errors appear in the JS console
Offline tests
None.
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
No tests or QA for mobile web.
Mobile Web - Safari
No tests or QA for mobile web.
Desktop
iOS
https://www.youtube.com/watch?v=WAVT4B_ph9w
Android
https://user-images.githubusercontent.com/47436092/216537601-52cc474a-0d90-4a31-ae47-f278881968fb.mov
@Julesssss @arosiclair requesting your review here since you're tagged on the linked API issue and have lots of context on push notifications.
@roryabraham Is this still on hold to test?
@mollfpr yeah unfortunately you won't be able to test this until it's off HOLD, but @stitesExpensify @arosiclair @Julesssss all can test right away by checking out the branch from the linked API PR in their dev environment.
@mollfpr If you want to get a head-start, you can do the tests for web + desktop right away. That's really just testing the deviceID generation logic
@roryabraham Thanks, I'll try that 👍
Thanks for the thorough review @Julesssss. Updated!
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
API PR merged. Just waiting on it to be deployed to production before taking this off HOLD
Off HOLD, ready for final review + merge
I got the above error when trying to run the ios app.
I am only able to check the deviceID present on the Web and Desktop. I can't test for the native platforms since it needs to check the NVP result. Please unassign me if this needs QA internally.
Merge conflicts resolved (the only conflict was in a test)
Thanks @roryabraham I'll test it again this morning 🙏
@roryabraham I kept getting the airshipOptIn value false. I tried on different simulators iPhone 13 iOS 15.0, iPhone 14 iOS 16.2, and iPhone 14 Pro iOS 16.2, and I still got the same result. Any idea?
@mollfpr are you testing with an iOS simulator? Simulators can't receive push notifications so I wonder if that's the cause. Did you opt-in to push notifications when prompted?
@roryabraham Yes, I opted in when it prompted. I’ll try it on the physical device then.
@roryabraham I ask on Slack how to run the dev app on the iPhone physical device, but there's not possible for the contributors right now. Any suggestion?
@roryabraham I ask on Slack how to run the dev app on the iPhone physical device, but there's not possible for the contributors right now. Any suggestion?
Myself, @arosiclair, or @stitesExpensify can test iOS. I can't do this today, but should be able to find time tomorrow.
Conflicts resolved
Working on the checklist right now
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Thanks for taking this over the finish line @arosiclair 🚀
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.2.74-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@roryabraham, we are struggling with this PR.
On Web and Desktop logins, the Info is not displayed in console at all. I can only see if if I run the NVP.get('pushNotificationsEnabled') and login with mobile device.
When I login on few mobile devices, 2nd device shows as NULL
Let me know if this is expected or should be logged as a separate issue
Title:
[ND] PR 14579 - 2nd device is displayed as NULL
Action Performed:
Sign into the app.
When prompted, accept push notifications.
Look at the value of the pushNotificationsEnabled NVP, by signing into the same account on https://staging.expensify.com, then running NVP.get('pushNotificationsEnabled') in the console.
Verify that the NVP shows that you opted in to push notifications for the current device
Navigate to the same account on another device
Verify that the NVP shows that you opted in to push notifications for new current device
Expected Result:
User can see only original device
Actual Result:
User can see the 1st device, but 2nd device displayed as NULL array
Attachment
this is Desktop
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.2.74-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
| gharchive/pull-request | 2023-01-26T00:29:09 | 2025-04-01T06:36:57.363605 | {
"authors": [
"Julesssss",
"OSBotify",
"arosiclair",
"mollfpr",
"mvtglobally",
"roryabraham"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/14579",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1625979626 | Update Spanish translation for sign-in page's welcome text
Details
Update the Spanish translation for "Welcome to New Expensify! Enter your phone number or email to continue." on the sign-in page. The translation was discussed internally here.
Fixed Issues
$ https://github.com/Expensify/App/issues/15900
Tests
Open the app, sign out if you are signed in
Switch the app to Spanish
Make sure the text above the email/phone input reads ¡Bienvenido al Nuevo Expensify! Por favor, introduce tu número de teléfono o email para continuar.
[x] Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
Open the app, sign out if you are signed in
Switch the app to Spanish
Make sure the text above the email/phone input reads ¡Bienvenido al Nuevo Expensify! Por favor, introduce tu número de teléfono o email para continuar.
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
@parasharrajat @youssef-lr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.2.88-0 🚀
platform
result
🤖 android 🤖
failure ❌
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by https://github.com/youssef-lr in version: 1.2.88-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
| gharchive/pull-request | 2023-03-15T17:40:09 | 2025-04-01T06:36:57.430565 | {
"authors": [
"MelvinBot",
"OSBotify",
"francoisl",
"youssef-lr"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/16003",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1883638898 | [NoQA] Replace iOS provision profile to allow dev builds from XCode
@AndrewGable @neil-marcellini
Details
When I generated the Expensify Dev provisioning profile I selected AdHoc instead of development. This prevented us from building to physical devices from XCode.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/314417
Tests
MAKE SURE I DIDN"T UPLOAD A NON-GPG SIGNED FILE!!!
Pull the changes from this branch
Download the updated expensify_chat_dev prov profile
In XCode, select the NewDot scheme, then ensure you have Debug Development selected as the Capability [1]
Select the provisioning profile, then select import and locate the updated provisioning file you downloaded earlier [2]
The app should now build to a physical device (you may need to run 'Product > Clean Build Folder')
If so, you'll then need to reinstall pods with cd ios && pod install
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Only iOS is relevant here
Where is the encrypted profile used? I thought we just had to update this on Apple's backend.
Also IDK how to do the first test step
Where is the encrypted profile used? I thought we just had to update this on Apple's backend.
@AndrewGable oh interesting. I assumed all certs had to be committed, but that would make sense.
The app builds from main, so that seems to confirm things. I won't use this PR to delete the existing dev cert, as Rory's PR is going to do that anyway.
| gharchive/pull-request | 2023-09-06T09:40:56 | 2025-04-01T06:36:57.457767 | {
"authors": [
"AndrewGable",
"Julesssss",
"neil-marcellini"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/26860",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1920700873 | prevent thread report crash for a member when workspace is deleted by owner
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/28336
PROPOSAL: https://github.com/Expensify/App/issues/28336#issuecomment-1737838664
Tests
Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B
[x] Verify that no errors appear in the JS console
Offline tests
Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B
QA Steps
Create a workspace from user A
Invite user B to this workspace
From user B, send a message in #announce room
From user B, reply in thread for this message
From user A, delete the workspace
Verify that the thread screen is not crashed from user B
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
https://github.com/Expensify/App/assets/102477862/9c01a3b5-22a4-4f04-8e63-d24ed11b11b4
Mobile Web - Chrome
https://github.com/Expensify/App/assets/102477862/f8f58520-a0a1-41d4-956e-2b0c3b3be07b
Mobile Web - Safari
https://github.com/Expensify/App/assets/102477862/b4db931e-5a26-4e15-b2d2-c53e88faeacc
Desktop
https://github.com/Expensify/App/assets/102477862/820333c6-a526-4613-9e8a-c0bf0d1b2176
iOS
https://github.com/Expensify/App/assets/102477862/54fc889a-312f-4c93-ba29-8541acd6cec8
Android
https://github.com/Expensify/App/assets/102477862/c88b5c35-3a80-49fa-ba73-17d346cb2f96
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.77-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
QA mentioned this is still not fixed in desktop. Can you please double check @allroundexperts @c3024 thanks!
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
| gharchive/pull-request | 2023-10-01T10:52:51 | 2025-04-01T06:36:57.493490 | {
"authors": [
"OSBotify",
"c3024",
"mountiny"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/28559",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2195097117 | [NO QA] [TS migration] Migrate remaining Test files to TypeScript #38536
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/38536
PROPOSAL:
Tests
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.4.56-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
| gharchive/pull-request | 2024-03-19T14:14:27 | 2025-04-01T06:36:57.541244 | {
"authors": [
"OSBotify",
"getusha",
"pasyukevich"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/38589",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2307192068 | fix: Clicking on a very long parent child category
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41850
PROPOSAL: https://github.com/Expensify/App/issues/41850#issuecomment-2101972590
Tests
Pre-conditions:
Create a workspace
Create a category name with long parent child relationship (e.g: "A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done"
Open workspace chat
Click on Plus icon inside compose box > Submit expense > Manual > Enter amount > Click next
Open category list
Click somewhere down the long category list but do not use the mouse scroll wheel
Verify that: Nothing should happen
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
Pre-conditions:
Create a workspace
Create a category name with long parent child relationship (e.g: "A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done: A: Very: Long: Category: List: Done"
Open workspace chat
Click on Plus icon inside compose box > Submit expense > Manual > Enter amount > Click next
Open category list
Click somewhere down the long category list but do not use the mouse scroll wheel
Verify that: Nothing should happen
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/352f7516-a87b-49a0-ada6-c3675d4af93d
Android: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/730633a8-5ab7-43c9-9c52-15cc2ea72ef6
iOS: Native
https://github.com/Expensify/App/assets/161821005/01750527-afca-4ec1-bad8-95310affae26
iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/20c4da06-6972-415a-8c9b-ad75bc5538cd
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/1be5ffd6-fb7b-48bf-bc0f-fd3694b84049
MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/9322cc65-60a7-497b-afd0-f6c525f780d9
🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
| gharchive/pull-request | 2024-05-21T03:27:41 | 2025-04-01T06:36:57.574259 | {
"authors": [
"OSBotify",
"nkdengineer"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/42405",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2547938503 | fix scroll bar on IOS
Details
This pr migrates src/components/Form/FormProvider from withOnyx to useOnyx and thanks to that fixes issue with scroll bar on IOS.
Fixed Issues
$https://github.com/Expensify/App/issues/49456
PROPOSAL:
Tests
Open App
Navigate to search/filters
Open Date filter
Verify that scroll bar placement is correct
Verify that different filters work correctly
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
Open App
Navigate to search/filters
Open Date filter
Verify that scroll bar placement is correct
Verify that different filters work correctly
[x] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
https://github.com/user-attachments/assets/087fc527-7bab-4e98-8fc2-b5377f82bce9
Android: mWeb Chrome
https://github.com/user-attachments/assets/74823ce9-6657-4db5-aeb3-d09c804c1139
iOS: Native
https://github.com/user-attachments/assets/262825ba-6632-4882-9bb6-dde5069079cb
iOS: mWeb Safari
https://github.com/user-attachments/assets/e0376808-ea17-415a-a285-a4d933d66f0c
MacOS: Chrome / Safari
https://github.com/user-attachments/assets/062d0dd3-0c2c-428a-bf04-b815daa9a726
MacOS: Desktop
https://github.com/user-attachments/assets/ee3b9ae8-b9ef-4482-90b9-ba4e07810dc2
@ishpaul777 Done
| gharchive/pull-request | 2024-09-25T13:02:57 | 2025-04-01T06:36:57.600693 | {
"authors": [
"289Adam289"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/49700",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1011292207 | 🍒 Cherry pick PR #5584 to staging 🍒
🍒 Cherry pick https://github.com/Expensify/App/pull/5584 to staging 🍒
🚀 Cherry-picked to staging by @OSBotify in version: 1.1.3-1 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
failure ❌
🕸 web 🕸
success ✅
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to production by @timszot in version: 1.1.3-1 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
| gharchive/pull-request | 2021-09-29T18:07:43 | 2025-04-01T06:36:57.606682 | {
"authors": [
"OSBotify"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/5586",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1062608363 | fix: newline via updating the count first before marking the messages as read
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/6424
Tests | QA Steps
Go to staging.new.expensify.com on two devices (P & Q).
Login with accounts A and B respectively.
Go to any chat other than between A and B (1:1)
Send messages from A to B on device P.
Enter the! 1:1 conversation on device Q that has unread messages and verify there is a green line indicating the New Messages.
Tested On
[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android
Screenshots
Web
https://user-images.githubusercontent.com/24370807/143273471-78e1d489-8f3d-489e-8b24-ef4a9fab98b8.mp4
Mobile Web
Desktop
iOS
Android
....on the way
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Ops @johnmlee101 this needs to be CP'ed.
Running!
🚀 Cherry-picked to staging by @johnmlee101 in version: 1.1.16-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.
🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by @johnmlee101 in version: 1.1.16-11 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by @roryabraham in version: 1.1.17-7 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
| gharchive/pull-request | 2021-11-24T16:05:10 | 2025-04-01T06:36:57.621516 | {
"authors": [
"OSBotify",
"johnmlee101",
"parasharrajat"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/6459",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1088838540 | Make the current password field also submittable via Enter
Details
A very small UI change which makes the Current password field actionable via Enter.
On the form to change password, this change would enable user to submit the form using Enter key also when the Current password field would be focused. This is for scenario, when user enters both, current and new password, but realizes they entered the current password wrong, then they can submit the form while focusing the current password too.
If the New password is not filled in, validation does not pass.
Fixed Issues
$ https://github.com/Expensify/App/issues/6823
Tests
Go to the Change password page
Type in your Current password
Type in your New Password
Focus back to the Current password field and hit enter.
Make sure the form has been submitted
QA Steps
Go to the Change password page
Type in your Current password
Type in your New Password
Focus back to the Current password field and hit enter.
Make sure the form has been submitted
Tested On
[x] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android
Screenshots
Web
Mobile Web
Desktop
iOS
Android
Sorry @nickmurray47, this should have been draft PR at this point.
@nickmurray47 This is ready for a review. It is a simple change and it is same as on the other password field in the form: https://github.com/Expensify/App/pull/6904/files#diff-b4474bebdf5744f78c9eded74e6bd3e4d2723040f750e573f4ef4bddfe00481bL189. I have tested it the other day, but unfortunately I did not make screenshots or video, but I believe this is such a simple change it is not required.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by @nickmurray47 in version: 1.1.24-19 🚀
platform
result
🤖 android 🤖
failure ❌
🖥 desktop 🖥
failure ❌
🍎 iOS 🍎
failure ❌
🕸 web 🕸
failure ❌
🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀
platform
result
🤖 android 🤖
failure ❌
🖥 desktop 🖥
failure ❌
🍎 iOS 🍎
failure ❌
🕸 web 🕸
failure ❌
| gharchive/pull-request | 2021-12-26T20:18:30 | 2025-04-01T06:36:57.634525 | {
"authors": [
"OSBotify",
"mountiny"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/6904",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
924459629 | Randomly Logged Out of Desktop App
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Was idling. Got logged out.
Expected Result:
Stay logged in.
Actual Result:
Logged out.
Workaround:
Sign back in
Platform:
Desktop App
Version Number: Version 1.0.70-8 (1.0.70-8)
Logs:
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork
Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
Looks possibly related to the app trying to update itself.
Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
@NicMendonca melvin loves giving me assignments 5min before OOO 😅 reassigning thanks
Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
No update today!
@marcaaron Can this be replicated on dev version? I am using the Desktop app on my Mac and it has never signed off.
Sorry if it is clear and I am missing something here but do you have any hints, how to reproduce it locally? Thank you very much! :)
Nope. I can't reproduce it and it has only happened once.
@mountiny This looks related to https://github.com/electron/electron/issues/7476
Shouldn't happen on prod if our packager is signing the app, but if we don't want this to happen in dev we should sign node_modules/.../Electron.app in our scripts
To clarify, this was experienced in the release build of the app and not while on dev.
Since the issue seems non-reproducible at the moment and happened only once as far as we know, I will degrade its priority label to Monthly and we will see if this error occurs again in next month, potentially closing this issue later if no new occurrences happen.
Just happened to me, was in the middle of typing a message, logs below. Desktop Version 1.0.73-3 (1.0.73-3) (most recent production version).
size
Object
app-74d3ea1….bundle.js:143 Redirecting to Sign In because we failed to reauthenticate
Object
app-74d3ea1….bundle.js:143 [Pusher] Attempted to unsubscribe or unbind from a channel,
but Pusher-JS has no knowledge of it 0
Object
app-74d3ea1….bundle.js:143 [Pusher] Unable to reconnect since Pusher instance does not yet exist.
w_5e2c6fdc6944ad66e1…e661.png.1024.jpg:1 Failed to load resource: the server responded with a status of 500 ()
app-74d3ea1….bundle.js:143 Unable to fetch image to calculate size
Object
w_0faa3ead2911202b3f…e78a.png.1024.jpg:1 Failed to load resource: the server responded with a status of 500 ()
app-74d3ea1….bundle.js:143 Unable to fetch image to calculate size
Object
DevTools failed to load SourceMap: Could not parse content for app://-/app-74d3ea1….bundle.js.map: Unexpected end of JSON input
DevTools failed to load SourceMap: Could not parse content for app://-/pdf.worker.entry-b22bab8….bundle.worker.js.map: Unexpected end of JSON input
This might be actually related to Servers being down now.
Yeah. I faced it too. Server is down.
If the servers are down, is there a way that we can have e.cash default to offline mode so that it doesn't log users out?
@marcaaron do you think there should be separate issue for "When site is down, go into offline mode"? If so, I can create one
Kicking user out without any notification is very bad UX for me.
Created a separate internal issue to solely focus on 'site down > user logged out' https://github.com/Expensify/Expensify/issues/168965
@puneetlath Was able to reproduce this https://expensify.slack.com/archives/C01GTK53T8Q/p1625069032270200
just got signed out of Expensify.cash on mac desktop unexpectedly
I'm going to put this in planning while we wait to see if matt's internal issue resolves it
This happened to me again similar logs.
10:40:37.844 › Checking for update
10:40:38.303 › Update for version 1.0.79-1 is not available (latest version: 1.0.79-1, downgrade is disallowed).
11:40:37.722 › Checking for update
11:40:38.337 › Update for version 1.0.79-1 is not available (latest version: 1.0.79-1, downgrade is disallowed).
3app-ee639f401a1c0000b5d7.bundle.js:143 [LOCAL_NOTIFICATION] Creating notification
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Unsubscribing from channel true Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to subscribe to channel true Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Objectcommand: "Report_UpdateLastRead"doNotRetry: falseisQueuePaused: true__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 Redirecting to Sign In because we failed to reauthenticate Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempted to unsubscribe or unbind from a channel,
but Pusher-JS has no knowledge of it 0 Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 A request was made without an authToken Object
app-ee639f401a1c0000b5d7.bundle.js:143 Skipping request and re-queueing: Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 Redirecting to Sign In because we failed to reauthenticate Objectcommand: "Push_Authenticate"error: "passwordForm.error.unableToResetPassword"__proto__: Object
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Unable to reconnect since Pusher instance does not yet exist.
app-ee639f401a1c0000b5d7.bundle.js:143 [Pusher] Attempting to disconnect from Pusher before initialisation has occurred, ignoring.
app-ee639f401a1c0000b5d7.bundle.js:143 A request was made without an authToken Objectcommand: "Report_GetHistory"parameters: {}__proto__: Object
DevTools failed to load SourceMap: Could not parse content for app://-/app-ee639f401a1c0000b5d7.bundle.js.map: Unexpected end of JSON input
DevTools failed to load SourceMap: Could not parse content for app://-/pdf.worker.entry-b22bab8941f6233eb7c1.bundle.worker.js.map: Unexpected end of JSON input
@marcaaron, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
Still happening
https://expensify.slack.com/archives/C01GTK53T8Q/p1633027687314200
Maybe we can keep this closed.
| gharchive/issue | 2021-06-18T01:28:46 | 2025-04-01T06:36:57.659490 | {
"authors": [
"MelvinBot",
"isagoico",
"jboniface",
"laurenreidexpensify",
"mallenexpensify",
"marcaaron",
"mountiny",
"parasharrajat",
"rdjuric"
],
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/issues/3671",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
853002450 | [WIP] Use StackNavigator for ReportScreen to fix browser history
Details
Rough WIP / experiment that attempts to fix the issue of browser history not working correctly on web. we can't push new entries onto the browser history stack because we are navigating with replace and the screen we want to push is a drawer screen.
There has some problems still and ideally there is a better solution.
Fixed Issues
Fixes GH_LINK
Tests
QA Steps
Tested On
[ ] Web
[ ] Mobile Web
[ ] Desktop
[ ] iOS
[ ] Android
Screenshots
Web
Mobile Web
Desktop
iOS
Android
Closing this PR in favor of another idea here -> https://github.com/Expensify/Expensify.cash/pull/2404
| gharchive/pull-request | 2021-04-08T02:45:35 | 2025-04-01T06:36:57.664877 | {
"authors": [
"marcaaron"
],
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/2295",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2054868060 | Fix: Remove accidental change to package.json browser field
@neil-marcellini
Details
During https://github.com/Expensify/react-native-onyx/pull/437 i accidentally added a change to package.json, which was just for testing the PR locally. This PR reverts the change.
Related Issues
GH_LINK
Automated Tests
Manual Tests
Author Checklist
[x] I linked the correct issue in the ### Related Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
@neil-marcellini i think we can merge this right away?
Sorry for the unintended change :/
bump @neil-marcellini :)
| gharchive/pull-request | 2023-12-23T18:44:26 | 2025-04-01T06:36:57.683016 | {
"authors": [
"chrispader"
],
"repo": "Expensify/react-native-onyx",
"url": "https://github.com/Expensify/react-native-onyx/pull/441",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1355951515 | Update logback-classic to 1.4.0
Updates ch.qos.logback:logback-classic from 1.2.11 to 1.4.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!
Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.qos.logback", artifactId = "logback-classic" } ]
Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
pullRequests = { frequency = "@monthly" },
dependency = { groupId = "ch.qos.logback", artifactId = "logback-classic" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1
Superseded by #586.
| gharchive/pull-request | 2022-08-30T15:31:59 | 2025-04-01T06:36:57.687984 | {
"authors": [
"scala-steward"
],
"repo": "ExposuresProvider/cam-kp-api",
"url": "https://github.com/ExposuresProvider/cam-kp-api/pull/578",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
215404497 | Notification sound.
Any chance for other sounds of trade req? Also option for increase sound volume? I rly wanna hear notification sound when i am afk in other room.
will be done in future updates
| gharchive/issue | 2017-03-20T12:23:44 | 2025-04-01T06:36:57.703011 | {
"authors": [
"Exslims",
"Hiffix"
],
"repo": "Exslims/MercuryTrade",
"url": "https://github.com/Exslims/MercuryTrade/issues/43",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
154508280 | Support is needed for requests version < 2.9.1
@zancas
Issues:
Fixes #92
Problem:
We need to support older versions of requests (older than 2.9.1) to be
compliant with some Openstack clients that use older versions of
requests.
Analysis:
Inspecting the requests version and suppressing
requests.packages.urllib3.disable_warnings() call if the current version
of requests is less than 2.9.1.
Tests:
All unit tests and functional tests pass
Merging, as @zancas reviewed this offline.
| gharchive/pull-request | 2016-05-12T15:14:11 | 2025-04-01T06:36:57.740921 | {
"authors": [
"pjbreaux"
],
"repo": "F5Networks/f5-icontrol-rest-python",
"url": "https://github.com/F5Networks/f5-icontrol-rest-python/pull/93",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
189121446 | [DOC] liberty installation instructions
Hi
If I install liberty packages of LBaaS, in short installing the following packages
root@dc8-1f-66-b8-bd-ca:~ # ls -l *.rpm
-rw-r--r-- 1 root root 15528 Aug 3 14:50 f5-icontrol-rest-1.0.9-1.el7.noarch.rpm
-rw-r--r-- 1 root root 172680 Oct 10 14:49 f5-openstack-agent-8.1.0-1.el7.noarch.rpm
-rw-r--r-- 1 root root 47316 Oct 11 10:44 f5-openstack-lbaasv2-driver-8.1.0-1.el7.noarch.rpm
-rw-r--r-- 1 root root 168428 Sep 27 14:16 f5-sdk-1.5.0-1.el7.noarch.rpm
and then I try to install the Heat plugin using the liberty's instructions
pip install f5-openstack-heat-plugins
It does install the latest version rather than the supported version indicated in the web page:
http://f5-openstack-heat-plugins.readthedocs.io/en/liberty/
Indeed it does uninstall the previously f5-sdk package:
root@dc8-1f-66-b8-bd-ca:~ # pip install f5-openstack-heat-plugins
Downloading/unpacking f5-openstack-heat-plugins
Downloading f5-openstack-heat-plugins-9.0.2.tar.gz
Running setup.py egg_info for package f5-openstack-heat-plugins
Downloading/unpacking f5-sdk==1.0.0 (from f5-openstack-heat-plugins)
Downloading f5-sdk-1.0.0.tar.gz (62kB): 62kB downloaded
Running setup.py egg_info for package f5-sdk
warning: no files found matching 'README.md'
warning: no files found matching 'SUPPORT'
Requirement already satisfied (use --upgrade to upgrade): f5-icontrol-rest>=1.0.7 in /usr/lib/python2.7/site-packages (from f5-sdk==1.0.0->f5-openstack-heat-plugins)
Requirement already satisfied (use --upgrade to upgrade): requests>=2.5.0 in /usr/lib/python2.7/site-packages (from f5-icontrol-rest>=1.0.7->f5-sdk==1.0.0->f5-openstack-heat-plugins)
Installing collected packages: f5-openstack-heat-plugins, f5-sdk
Running setup.py install for f5-openstack-heat-plugins
Found existing installation: f5-sdk 1.5.0
Uninstalling f5-sdk:
Successfully uninstalled f5-sdk
Running setup.py install for f5-sdk
warning: no files found matching 'README.md'
warning: no files found matching 'SUPPORT'
Successfully installed f5-openstack-heat-plugins f5-sdk
Cleaning up...
I think it should be the following command but I get an error
root@dc8-1f-66-b8-bd-ca:~ # pip install git+https://github.com/F5Networks/f5-openstack-heat@liberty
Downloading/unpacking git+https://github.com/F5Networks/f5-openstack-heat@liberty
Cloning https://github.com/F5Networks/f5-openstack-heat (to liberty) to /tmp/pip-2c4NxQ-build
Running setup.py egg_info for package from git+https://github.com/F5Networks/f5-openstack-heat@liberty
Traceback (most recent call last):
File "<string>", line 16, in <module>
IOError: [Errno 2] No such file or directory: '/tmp/pip-2c4NxQ-build/setup.py'
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "<string>", line 16, in <module>
IOError: [Errno 2] No such file or directory: '/tmp/pip-2c4NxQ-build/setup.py'
----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /tmp/pip-2c4NxQ-build
Storing complete log in /root/.pip/pip.log
@alonsocamaro: You can do pip install f5-openstack-heat-plugins==8.0.3, which will give you the exact version of the liberty release. I get the same failure doing the pip install from github directly. This is a valid issue.
Yep, it did work but I find that it uninstalls the sdk version necessary for LBaaSv2
root@dc8-1f-66-b8-bd-ca:~ # pip install f5-openstack-heat-plugins==8.0.3
Downloading/unpacking f5-openstack-heat-plugins==8.0.3
Downloading f5-openstack-heat-plugins-8.0.3.tar.gz
Running setup.py egg_info for package f5-openstack-heat-plugins
Downloading/unpacking f5-sdk==1.0.0 (from f5-openstack-heat-plugins==8.0.3)
Downloading f5-sdk-1.0.0.tar.gz (62kB): 62kB downloaded
Running setup.py egg_info for package f5-sdk
warning: no files found matching 'README.md'
warning: no files found matching 'SUPPORT'
Requirement already satisfied (use --upgrade to upgrade): f5-icontrol-rest>=1.0.7 in /usr/lib/python2.7/site-packages (from f5-sdk==1.0.0->f5-openstack-heat-plugins==8.0.3)
Requirement already satisfied (use --upgrade to upgrade): requests>=2.5.0 in /usr/lib/python2.7/site-packages (from f5-icontrol-rest>=1.0.7->f5-sdk==1.0.0->f5-openstack-heat-plugins==8.0.3)
Installing collected packages: f5-openstack-heat-plugins, f5-sdk
Running setup.py install for f5-openstack-heat-plugins
Found existing installation: f5-sdk 1.5.0
Uninstalling f5-sdk:
Successfully uninstalled f5-sdk
Running setup.py install for f5-sdk
warning: no files found matching 'README.md'
warning: no files found matching 'SUPPORT'
Successfully installed f5-openstack-heat-plugins f5-sdk
Cleaning up...
Yes, we can't guarantee that they aren't mutually exclusive.
This is not good for the customers...
... and is 1.5.0 backwards compatible with 1.0.0? If it is compatible it would be just about adjusting the dependencies in the pip install
Yes 1.5 should be backwards compatible with 1.0.0. We'll talk about supporting this and see where we get.
Would you say that as a workaround the following is acceptable?
install f5-heat
pip uninstall f5-sdk
install lbaasv2 all components (which includes f5-sdk 1.5.0)
That is untested by us, but it looks sound.
Hi again Paul
Additionally... could this issue be also tagged as a documentation bug too?
I think that all pip install commands shown should explicitly indicate the version to install.
Otherwise users might unexpectedly install a different version (the latest). Could this be a policy in our installation instructions for any "pip install" ?
Thanks
| gharchive/issue | 2016-11-14T14:11:21 | 2025-04-01T06:36:57.749232 | {
"authors": [
"alonsocamaro",
"pjbreaux"
],
"repo": "F5Networks/f5-openstack-heat-plugins",
"url": "https://github.com/F5Networks/f5-openstack-heat-plugins/issues/114",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1428506058 | Display number of filtered out games
Closes #2832
Looks good, but it shows the number of still displayed games instead of the filtered out games. In your screenshot I would expect the text to read "3 of 11 items are filtered out"
I just tested it and it works.
I noticed to issues that are not directly related to the displaying of the game numbers though:
The clear button only works correctly for the live replays. In the custom games tab it only becomes active when filtering game mods and then it also only clears the game mod setting.
Only the filters not affected by the clear button survive a restart of the client.
I guess both things are related and the underlying cause is that the client stores these settings in the preferences.
It would be nice if the client stored the settings but the button still allowed you to clear all settings easily
I guess both things are related and the underlying cause is that the client stores these settings in the preferences.
That is right.
It would be nice if the client stored the settings but the button still allowed you to clear all settings easily
Done
| gharchive/pull-request | 2022-10-29T23:39:07 | 2025-04-01T06:36:57.756978 | {
"authors": [
"BlackYps",
"Marc-Spector"
],
"repo": "FAForever/downlords-faf-client",
"url": "https://github.com/FAForever/downlords-faf-client/pull/2833",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2364334165 | Setup pre commit hook for ruff
[x] Add pre-commit dep
[x] Add hook for ruff
[x] Add readme for pre-commit
Here you go @lukaspie @blueraft
| gharchive/pull-request | 2024-06-20T12:35:04 | 2025-04-01T06:36:57.761673 | {
"authors": [
"ka-sarthak"
],
"repo": "FAIRmat-NFDI/readers-xrd",
"url": "https://github.com/FAIRmat-NFDI/readers-xrd/pull/10",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1604631393 | 使用 config-node-expand-example.toml 文件扩容时没有生成node.pem文件
使用两台服务器部署了一个host模式的群组网络，按照官网教程用config-node-expand-example.toml这个文件対该群组进行了节点扩容 ，然后就直接报错了。说我没节点证书。经官方技术人员排查确有BUG存在，望修复。
这个问题预计会在周五之前修复，修复之后会在这里知会一下。
问题已经修复，分支在release-3.2.1，可以使用该分支的代码
https://github.com/FISCO-BCOS/FISCO-BCOS/tree/release-3.2.1
| gharchive/issue | 2023-03-01T09:52:30 | 2025-04-01T06:36:57.819955 | {
"authors": [
"xp007123",
"ywy2090"
],
"repo": "FISCO-BCOS/FISCO-BCOS",
"url": "https://github.com/FISCO-BCOS/FISCO-BCOS/issues/3427",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2412891490 | Design of a basic tracker of performance in your dedicated mini_core
Design a basic tracker to show the core performance in terms of IPC (Instructions Per Cycle):
The tracker will consist of two parts:
Counters:
Increment the clock cycle counter on each clock cycle.
Increment the valid instruction counter each time a valid instruction is executed.
IPC Calculation and Display:
Upon detecting an EBREAK instruction, divide the valid instruction counter by the clock cycle counter.
Display the resulting IPC value.
done. pushed to mini_core_trackers branch.
| gharchive/issue | 2024-07-17T07:36:52 | 2025-04-01T06:36:57.868651 | {
"authors": [
"erez-sh",
"roman012285"
],
"repo": "FPGA-MAFIA/fpga_mafia",
"url": "https://github.com/FPGA-MAFIA/fpga_mafia/issues/704",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
113214989 | pip install misaka setup error in ubuntu 15.10 64-bit
Collecting misaka
Using cached misaka-2.0.0.tar.gz
Complete output from command python setup.py egg_info:
gcc: error: i386: No such file or directory
gcc: error: x86_64: No such file or directory
gcc: error: unrecognized command line option ‘-arch’
gcc: error: unrecognized command line option ‘-arch’
gcc: error: unrecognized command line option ‘-Qunused-arguments’
gcc: error: i386: No such file or directory
gcc: error: x86_64: No such file or directory
gcc: error: unrecognized command line option ‘-arch’
gcc: error: unrecognized command line option ‘-arch’
gcc: error: unrecognized command line option ‘-Qunused-arguments’
No working compiler found, or bogus compiler options
passed to the compiler from Python's distutils module.
See the error messages above.
(If they are about -mno-fused-madd and you are on OS/X 10.8,
see http://stackoverflow.com/questions/22313407/ .)
Traceback (most recent call last):
File "<string>", line 20, in <module>
File "/tmp/pip-build-Ttx3lI/misaka/setup.py", line 68, in <module>
cffi_modules=['build_ffi.py:ffi'],
File "/usr/lib/python2.7/distutils/core.py", line 111, in setup
_setup_distribution = dist = klass(attrs)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 268, in __init__
self.fetch_build_eggs(attrs['setup_requires'])
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 313, in fetch_build_eggs
replace_conflicting=True,
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 836, in resolve
dist = best[req.key] = env.best_match(req, ws, installer)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1081, in best_match
return self.obtain(req, installer)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1093, in obtain
return installer(requirement)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/dist.py", line 380, in fetch_build_egg
return cmd.easy_install(req)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 638, in easy_install
return self.install_item(spec, dist.location, tmpdir, deps)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 668, in install_item
dists = self.install_eggs(spec, download, tmpdir)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 851, in install_eggs
return self.build_and_install(setup_script, setup_base)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1079, in build_and_install
self.run_setup(setup_script, setup_base, args)
File "/home/zeno/mostfun/june/venv/local/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 1067, in run_setup
raise DistutilsError("Setup script exited with %s" % (v.args[0],))
distutils.errors.DistutilsError: Setup script exited with 1
----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-Ttx3lI/misaka
i tried to use pip install misaka on debian, it's no problem. git clone source and build it on ubuntu 15.04, also done.
I see No working compiler found, or bogus compiler options. Did you install gcc on Ubuntu?
certainly... i'm confident that.
i have built it from source.
Is the path to the gcc executables also in the $PATH environment variable?
I'll setup an Ubuntu vm later today (I just woke up) and see if I can reproduce this issue.
path has no problem, i can use pip to install uwsgi by gcc.
Any update on this in order to solve it, @ethe ?
@ReneFroger Nope, you can try install misaka by building from source.
I just tested on Ubuntu and Xubuntu and everything works.
I had to install python-dev and libffi-dev.
I'm confident that I have installed python-dev and libffi-dev before, did you installed the latest version(15.10) of ubuntu in test?
A strange thing, I tried to use pip install miska just now in a clean virtualenv, it works no problem. But when I attempted install misaka in global, I got an error like this:
zeno@go:~$ sudo pip install misaka
The directory '/home/zeno/.cache/pip/http' or its parent directory is not owned by the current user and the cache has been disabled. Please check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
The directory '/home/zeno/.cache/pip' or its parent directory is not owned by the current user and caching wheels has been disabled. check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Collecting misaka
Downloading misaka-2.0.0.tar.gz (121kB)
100% |████████████████████████████████| 122kB 211kB/s
Requirement already satisfied (use --upgrade to upgrade): cffi>=1.0.0 in /usr/lib/pypy/lib_pypy (from misaka)
Installing collected packages: misaka
Running setup.py install for misaka
Complete output from command /usr/bin/pypy -c "import setuptools, tokenize;__file__='/tmp/pip-build-WOEXNs/misaka/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-VqVy4s-record/install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_py
creating build
creating build/lib.linux-x86_64-2.7
creating build/lib.linux-x86_64-2.7/misaka
copying misaka/callbacks.py -> build/lib.linux-x86_64-2.7/misaka
copying misaka/constants.py -> build/lib.linux-x86_64-2.7/misaka
copying misaka/utils.py -> build/lib.linux-x86_64-2.7/misaka
copying misaka/__init__.py -> build/lib.linux-x86_64-2.7/misaka
copying misaka/api.py -> build/lib.linux-x86_64-2.7/misaka
running build_ext
generating cffi module 'build/temp.linux-x86_64-2.7/misaka._hoedown.c'
creating build/temp.linux-x86_64-2.7
building 'misaka._hoedown' extension
creating build/temp.linux-x86_64-2.7/build
creating build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/misaka
creating build/temp.linux-x86_64-2.7/misaka/hoedown
cc -O2 -fPIC -Wimplicit -Imisaka -I/usr/lib/pypy/include -c build/temp.linux-x86_64-2.7/misaka._hoedown.c -o build/temp.linux-x86_64-2.7/build/temp.linux-x86_64-2.7/misaka._hoedown.o
build/temp.linux-x86_64-2.7/misaka._hoedown.c:2:20: fatal error: Python.h: No such file or directory
compilation terminated.
error: command 'cc' failed with exit status 1
----------------------------------------
Command "/usr/bin/pypy -c "import setuptools, tokenize;__file__='/tmp/pip-build-WOEXNs/misaka/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-VqVy4s-record/install-record.txt --single-version-externally-managed --compile" failed with error code 1 in /tmp/pip-build-WOEXNs/misaka
zeno@go:~$ cc
cc: fatal error: no input files
compilation terminated.
I tested it on the latest Ubuntu in Virtualbox. I can install everything without problems. Same for Xubuntu.
build/temp.linux-x86_64-2.7/misaka._hoedown.c:2:20: fatal error: Python.h: No such file or directory
That's the error you usually get when python-dev is not installed.
I'm sure I have already installed python-dev... If not, why could I bulit it from source?
I found what happend, sudo -H python /usr/local/bin/pip install misaka can install correctly. Because I installed pypy before and pypy's pip replace the alias pip from cpython. It's a so stupid issue, I'm sorry for wasting your time...
I watched this issue, but and my issue seems solved now.
Do you know what solved it for you?
Yes, I believe. Thanks to your comment, had to install python-dev and libffi-dev.
Hey Guys,
I'm really struggling to get misaka up and running, it keeps on telling me that module 'misaka' has no attribute 'html'.Please help out if you can
Thank You
| gharchive/issue | 2015-10-25T09:14:25 | 2025-04-01T06:36:58.817872 | {
"authors": [
"FSX",
"ReneFroger",
"ethe",
"mshava"
],
"repo": "FSX/misaka",
"url": "https://github.com/FSX/misaka/issues/47",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
1824833071 | Ghost admits do not work
See https://github.com/FStarLang/steel/blob/_nik_ghost_admit/share/steel/examples/pulse/bug-reports/GhostAdmit.fst
Fixed
| gharchive/issue | 2023-07-27T17:10:55 | 2025-04-01T06:36:58.819794 | {
"authors": [
"nikswamy"
],
"repo": "FStarLang/steel",
"url": "https://github.com/FStarLang/steel/issues/43",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1308803586 | Support wavy underlines (issue #1131)
Basic implementation of wavy underlines as described in #1131.
Adds two properties -- "wave" to control the radius of arc used to draw wavy lines, and "offset" to adjust the distance between text and underline, since it can be necessary to increase this for legibility when a wavy underline is in use. Probably better names are possible.
These are used in TextFlowExt#getUnderlineShape to modify the shape produced. If no radius is specified then a line is drawn as previously; otherwise a series of arcs is drawn, which replicates the appearance of the wavy underlines in common programs such as Microsoft Word.
I have only implemented the wavy-line shape in the Java 9+ version of the class because I can see there's an open question whether it's even worth supporting Java 8 any more (and my opinion FWIW is "no").
I haven't added any tests – if they're required then I would appreciate advice on how to test a purely visual change like this.
This is great, thanks a stack for this PR !
Okay, so I've played around with the code you've submitted and propose the following changes:
I noticed that there's a relationship between the wave radius and the offset, in that the offset needs to be increased as the radius gets larger. I think providing a reasonable default will help developers to not have to figure out another underline option if they don't need to. Suggested change to ParagraphText.UnderlineAttributes:
Number waveNumber = text.getUnderlineWave();
waveRadius = waveNumber == null ? 0 : waveNumber.doubleValue();
Number offsetNumber = text.getUnderlineOffset();
offset = offsetNumber == null ? waveRadius*0.5 : offsetNumber.doubleValue();
// The larger the radius the bigger the offset needs to be, so
// a reasonable default is provided if no offset is specified.
The range of useful wave radii is quite limited and with larger radii the underline is rather bumpy and not wavy. If however the X radius of the arcs is stretched out slightly then the range of useful radii increases and the underline is smoothed/stretched out as well. Suggested change to TextFlowExt.getUnderlineShape:
for ( int ele = 2; ele < shape.length; ele += 5 )
{
LineTo bl = (LineTo) shape[ele+1];
LineTo br = (LineTo) shape[ele];
double y = snapSizeY( br.getY() + offset - 2.5 );
double leftx = snapSizeX( bl.getX() );
if (waveRadius <= 0) {
result.add(new MoveTo( leftx, y ));
result.add(new LineTo( snapSizeX( br.getX() ), y ));
}
else {
// For larger wave radii increase the X radius to stretch out the wave.
double radiusX = waveRadius > 1 ? waveRadius * 1.25 : waveRadius;
double rightx = snapSizeX( br.getX() - radiusX ); // Prevent overshooting.
result.add(new MoveTo( leftx, y ));
boolean sweep = true;
while ( leftx < rightx ) {
leftx += waveRadius * 2;
// Note, had to remove code here otherwise underline ended in strange tail ?
result.add(new ArcTo( radiusX, waveRadius, 0.0, leftx, y, false, sweep ));
sweep = !sweep;
}
}
}
I would appreciate it if you could try out the above changes and see how it affects what you want.
If you have any concerns, differences, or recommendations please comment.
Thank you for giving it a try! I agree on both counts -- the shallower waves look much nicer! -- and have pushed an update accordingly.
The only difference is that I have restored a version of the endpoint computation code, fixed to remove the assumption that the arc is defined by a circle. I think it's necessary to clip the path this way, because otherwise larger radii will always either overflow or underflow. I appreciate the code is a bit dense, but I wasn't able to find a more idiomatic way to do the clipping (which surprised me a bit -- I was expecting JavaFX to have that kind of feature, did I miss something?)
| gharchive/pull-request | 2022-07-18T23:36:58 | 2025-04-01T06:36:58.890992 | {
"authors": [
"Jugen",
"shoaniki"
],
"repo": "FXMisc/RichTextFX",
"url": "https://github.com/FXMisc/RichTextFX/pull/1132",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
178591603 | Changed StyledTextAreaBehavior to not catch mnemonic combinations
Fix for https://github.com/TomasMikula/RichTextFX/issues/350
On Unix systems Alt Gr will trigger neither Alt nor Ctrl to be pressed, on Windows it triggers both. As you want to let Alt Gr be a captured by StyledTextArea on Windows I changed the condition for it to let Alt be passed through and Alt Gr be captured. Although I still think that Alt Gr should also not be caught on Windows as it is not used to print characters there.
PS.: this is the private account of @jakob-erdmann
Thanks, looks good! Although I don't see the Windows case (both Ctrl and Alt pressed) being tested by the test cases.
We should be able to test the behavior without instantiating a StyledTextArea. Creating StyledTextAreaBehavior should suffice.
Although I still think that Alt Gr should also not be caught on Windows as it is not used to print characters there.
My thinking is that since it produces a KEY_TYPED event, the corresponding KEY_PRESSED event should be consumed. Am I misunderstanding something?
We should be able to test the behavior without instantiating a StyledTextArea. Creating StyledTextAreaBehavior should suffice.
I think I had problems getting the event handled when only having the behavior. But I can double check and extend for Alt + Ctrl case.
My thinking is that since it produces a KEY_TYPED event, the corresponding KEY_PRESSED event should be consumed. Am I misunderstanding something?
I don't know if the KEY_PRESSED is automatically consumed, but yes a KEY_TYPED event is thrown with those modifiers. On Windows only a bunch of keys are able to create new characters (e.g. @) by this. I guess when matching the typed key with the text property of the event we should be able to identify if this was used for printing a key or not. But anyway there are key combinations like CTRL + ALT + S should be usable by some menu actions in my opinion. I will also check on this tomorrow.
I don't know if the KEY_PRESSED is automatically consumed
It is certainly not consumed automatically. That's why we are writing this code to consume it, and it is hard to determine when we should and when not.
Well basically you only want to consume the event when it is used to print a character. And from the event object you can take the text that would be printed. So if there is no text given it probably should not be consumed. Will check the exact behavior for Windows machines, on Linux I can confirm that the event holds this data.
Well basically you only want to consume the event when it is used to print a character.
Exactly, that's what we are trying to determine: Does this key press produce a character input?
And from the event object you can take the text that would be printed.
There are two methods, getCharacter() and getText(). getCharacter() is defined only for key typed events, getText() is only defined for key pressed and key released events. We are inspecting a KEY_PRESSED event, so we can use only the getText() method. However, the string returned from getText() is a
String describing the key code, such as "HOME", "F1" or "A"
A textual description of the key code has nothing to do with whether character input is produced by the key press. This is why it is so difficult.
Closing due to inactivity and otherwise unresolved questions.
| gharchive/pull-request | 2016-09-22T12:04:23 | 2025-04-01T06:36:58.900852 | {
"authors": [
"Deroin",
"JordanMartinez",
"TomasMikula",
"ghost"
],
"repo": "FXMisc/RichTextFX",
"url": "https://github.com/FXMisc/RichTextFX/pull/365",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
2250901507 | java.lang.RuntimeException: Could not execute entrypoint stage 'main'
Describe the Bug
After updating Create to the latest build the pack failed to launch
Reproduction Steps
See above
Expected Result
no crash on launch
Screenshots and Videos
No response
Crash Report or Log
https://pastebin.com/rbyfJJEF
Operating System
Linux Mint 21.3 Cinnamon
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
additionalentityattributes-1.7.3+1.20.0
animatica-0.6+1.20
appleskin-fabric-mc1.20.1-2.5.1
architectury-9.2.14-fabric
ArmorPoser-fabric-1.20.1-2.1.3
ArmorStatues-v8.0.6-1.20.1-Fabric
athena-fabric-1.20.1-3.1.2
backpacked-fabric-1.20.1-2.2.7
balm-fabric-1.20.1-7.2.2
better-end-sky-0.2.1+1.20
better-fabric-console-mc1.20.1-1.1.6
BetterCompatibilityChecker-fabric-4.0.1+mc1.20.1
BetterF3-7.0.2-Fabric-1.20.1
BetterThirdPerson-Fabric-1.20-1.9.0
BHMenu-Fabric-1.20.1-2.4.1
bigger_end_cities-1.20.1-1.0.4
bobby-5.0.1
Botania-1.20.1-443-FABRIC
BuildGuide-1.20-0.4.1
bwncr-fabric-1.20.1-3.17.0
carryon-fabric-1.20.1-2.1.2.7
Chipped-fabric-1.20.1-3.0.6
clienttweaks-fabric-1.20-11.1.0
cloth-config-11.1.118-fabric
Clumps-fabric-1.20.1-12.0.0.3
collective-1.20.1-7.40
completeconfig-2.5.0
connectivity-fabric-1.20.1-5.5
continuity-3.0.0-beta.4+1.20.1
Controlling-fabric-1.20.1-12.0.2
Copycats-fabric.1.20.1-1.2.6
craftingtweaks-fabric-1.20.1-18.2.3
create-fabric-0.5.1-f-build.1417+mc1.20.1
CullLessLeaves-1.3.0
cupboard-fabric-1.20.1-2.6
DisableCustomWorldsAdvice-4.1
DistractingTrims-Fabric-1.20.1-2.0.3
drippyloadingscreen_fabric_3.0.2_MC_1.20.1
easiercrafting-1.20-fabric0.83.0-1.7
easiervillagertrading-1.20-fabric0.83.0-1.5.4
EmeraldTools-Fabric-1.20.1-1.6.3
entitycount-2024.0128
entityculling-fabric-1.6.2-mc1.20.1
entityinformation-1.20.1-3.3
environmentalcreepers-fabric-1.20.1-1.6.0
EssentialGUI-1.9.4+1.20.1
extremesoundmuffler-3.41-fabric-1.20
eyespy-1.3.5+1.20.1
fabric-api-0.92.1+1.20.1
fabric-language-kotlin-1.10.19+kotlin.1.9.23
fancymenu_fabric_3.1.4_MC_1.20.1
farmers-delight-fabric-1.4.3
Fastload+1.18.2-1.20-3.4.0
ferritecore-6.0.1-fabric
fireworks-are-for-flying-1.20.1
ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric
FpsReducer2-fabric-1.20-2.5
framework-fabric-1.20.1-0.6.16
fullscreeNO-1.0.0
fusion-1.1.1-fabric-mc1.20.1
geckolib-fabric-1.20.1-4.4.4
IBEEditor-1.20-2.2.8-fabric
ImmediatelyFast-Fabric-1.2.11+1.20.4
immersive_paintings-0.6.7+1.20.1-fabric
improvedsigns-1.3.1
indium-1.0.30+mc1.20.4
individualkeepinv-1.0.3
InventorySorter-1.9.0-1.20
iris-mc1.20.1-1.6.17
kibe-1.10.1-BETA+1.20
konkrete_fabric_1.8.1_MC_1.20.1
kubejs-fabric-2001.6.5-build.7
lambdynamiclights-2.3.2+1.20.1
lazydfu-0.1.3
litematica-fabric-1.20.1-0.15.3
lithium-fabric-mc1.20.1-0.11.2
lootr-1.20-0.7.30.77
malilib-fabric-1.20.1-0.16.3
melody_fabric_1.0.4_MC_1.20.1-1.20.4
memoryleakfix-fabric-1.17+-1.1.5
minihud-fabric-1.20.1-0.27.0
modmenu-7.2.2
MouseTweaks-fabric-mc1.20-2.26
neruina-1.3.0-fabric+1.18.2-1.20.1
NoChatReports-FABRIC-1.20.1-v2.2.2
observable-4.4.1
OpenLoader-Fabric-1.20.1-19.0.3
owo-lib-0.11.2+1.20
paladin-furniture-mod-1.2.1-fabric-mc1.20.1
Patchouli-1.20.1-84-FABRIC
Pehkui-3.8.0+1.14.4-1.20.4
polymorph-fabric-0.49.3+1.20.1
PuzzlesLib-v8.1.18-1.20.1-Fabric
quick-menu-1.2.3-1.20.1
reacharound+1.20-1.1.2
reeses_sodium_options-1.7.2+mc1.20.1-build.101
replaymod-1.20.1-2.6.15
resourcefullib-fabric-1.20.1-2.1.24
rhino-fabric-2001.2.2-build.18
RoughlyEnoughItems-12.1.712-fabric
Searchables-fabric-1.20.1-1.0.2
server-essentials-1.2.0
servertick-mc1.20-1.8
shulkerboxtooltip-fabric-4.0.4+1.20.1
sliceanddice-fabric-3.2.1
sodium-extra-0.5.4+mc1.20.1-build.115
sodium-fabric-0.5.8+mc1.20.1
StackDeobfuscatorFabric-1.4.2+bf1fc22
starlight-1.1.2+fabric.dbc156f
status-fabric-1.20.1-1.0.6
swingthrough-1.0.4+1.19
templates-2.1.1+1.20.1
textile_backup-3.1.2-1.20
toms_storage_fabric-1.20-1.6.6
TravelersTitles-1.20-Fabric-4.0.2
trinkets-3.7.2
tweakeroo-fabric-1.20.1-0.17.1
voicechat-fabric-1.20.1-2.5.12
vt-downloader-2.0.8+1.20.1
waystones-fabric-1.20-14.1.3
WI-Zoom-1.5-MC1.20.1
WorldTools-fabric-1.2.4+1.20.1
Xaeros_Minimap_24.1.1_Fabric_1.20
XaerosWorldMap_1.38.4_Fabric_1.20
yet-another-config-lib-fabric-3.2.2+1.20
yosbr-0.1.2
youre-in-grave-danger-2.0.0-beta.11
YungsApi-1.20-Fabric-4.0.4
YungsBetterDesertTemples-1.20-Fabric-3.0.3
YungsBetterDungeons-1.20-Fabric-4.0.4
YungsBetterJungleTemples-1.20-Fabric-2.0.4
YungsBetterMineshafts-1.20-Fabric-4.0.4
YungsBetterNetherFortresses-1.20-Fabric-2.0.6
YungsBetterOceanMonuments-1.20-Fabric-3.0.4
YungsBetterStrongholds-1.20-Fabric-4.0.3
YungsBetterWitchHuts-1.20-Fabric-3.0.3
YungsBridges-1.20-Fabric-4.0.3
YungsExtras-1.20-Fabric-4.0.3
YungsMenuTweaks-1.20.1-Fabric-1.0.2
Additional Context
No response
sliceanddice is crashing because you are using the old farmers delight port, switch to farmers delight refabricated
the issue is caused by farmer's delight. farmer's delight fabric says it is deprecated.
lol. typing at teh same time
Thanks, that fixed it
| gharchive/issue | 2024-04-18T14:53:11 | 2025-04-01T06:36:58.952514 | {
"authors": [
"ClaudiusMinimus",
"IThundxr",
"drwoops"
],
"repo": "Fabricators-of-Create/Create",
"url": "https://github.com/Fabricators-of-Create/Create/issues/1452",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
990143757 | Additional translations (part 2)
Now with more editing and testing.
Uma profile blurbs could use a proofread as I'm not too familiar with most of them yet.
Also I'm not sure what the basis is for adding categories to the import script as I noticed not all of the csv files are listed there?
Also I'm not sure what the basis is for adding categories to the import script as I noticed not all of the csv files are listed there?
The ones that are listed in the import script should be or is more frequently updated; but you got a point — why not put them all in there? 🤔
| gharchive/pull-request | 2021-09-07T16:13:29 | 2025-04-01T06:36:58.954564 | {
"authors": [
"FabulousCupcake",
"noccu"
],
"repo": "FabulousCupcake/umamusume-db-translate",
"url": "https://github.com/FabulousCupcake/umamusume-db-translate/pull/91",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2713221271 | Fast IP Ping
CurseForge link
https://www.curseforge.com/minecraft/mc-mods/fast-ip-ping
CurseForge Mod Distribution
Allowed
Modrinth link
https://modrinth.com/mod/fast-ip-ping
Source/other link
https://github.com/Fallen-Breath/fast-ip-ping
Mod file size
10.3KB
License
(any other license)
What it does
Yeet the laggy reversed DNS lookup for literal IP server addresses
Extracted from the yeetServerIpReversedDnsLookup option in TweakerMore Mod
What & Why & How
For servers whose addresses are represented solely by a literal IP, e.g. 192.168.2.10:25565, disable reverse DNS lookups in the corresponding InetAddress object
Many non-loopback IPs lack associated domain names, which makes reverse lookups time-consuming
// java.net.InetAddress#getHostName(boolean)
String getHostName(boolean check) {
if (holder().getHostName() == null) { // It will be null if InetAddress.getByName() received a literal IP
holder().hostName = InetAddress.getHostFromNameService(this, check); // <-- takes forever
}
return holder().getHostName();
}
This option sets the domain of those servers directly to their IP, bypassing the reverse DNS check
This results in a 1s ~ 5s reduction in time for servers with literal IP address. Affects the following environments:
Pinging the server in the server list screen
Connecting to the server
Environment
Client-side only
Fabric / Forge / NeoForge mod loader. No extra requirement is needed
Why should it be in the modpack
It reduces the time it takes to check the status of LAN servers in the multiplayer menu.
Why shouldn't it be in the modpack
No response
Additional details
No response
I don't personally think it's worth it... Minimal to no change to real word ux
I don't personally think it's worth it... Minimal to no change to real word ux
It's only 10KB and it shaves off several seconds. Considering that the average JPEG weighs about 50KB, there's little to no "cost" to adding this mod.
Even if this only affects LAN servers, for only 10KB I think it's worth adding. There are a lot of people who wait until the server status loads before clicking join.
| gharchive/issue | 2024-12-02T20:03:16 | 2025-04-01T06:36:58.962357 | {
"authors": [
"ItsIgnacioPortal",
"TheBossMagnus"
],
"repo": "Fabulously-Optimized/fabulously-optimized",
"url": "https://github.com/Fabulously-Optimized/fabulously-optimized/issues/915",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
54504980 | Can't compile GUI
qt/qrcodedialog.cpp:21:22: fatal error: qrencode.h: No such file or directory
#include <qrencode.h>
^
compilation terminated.
make[1]: *** [qt/qt_libbitcoinqt_a-qrcodedialog.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/root/Downloads/fair-coin/src'
make: *** [all-recursive] Error 1
You need to install libqrencode development package.
If you are on ubuntu try:
sudo apt-get install libqrencode-dev
BTW, what exact configure command did you use?
| gharchive/issue | 2015-01-15T21:13:17 | 2025-04-01T06:36:58.984173 | {
"authors": [
"mistergibson",
"thokon00"
],
"repo": "FairCoinTeam/fair-coin",
"url": "https://github.com/FairCoinTeam/fair-coin/issues/7",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
2235456797 | fix #16 open falkordb instance in falkordb browser
fix #16
@coderabbitai review
@AviAvni or @gkorland Can you review and approve, please?
| gharchive/pull-request | 2024-04-10T12:15:18 | 2025-04-01T06:36:59.004416 | {
"authors": [
"dudizimber",
"gkorland"
],
"repo": "FalkorDB/saasbuilder",
"url": "https://github.com/FalkorDB/saasbuilder/pull/17",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1454538576 | Easycloudbooks Theme - Clients want to update service menu order & hide blog menu By kamlesh gehlot
Describe the bug
Clients want to change service menu order and also wants to hide blog menu from his website
menu sort order depends on Sort Order on website section of service
both of thing possible from design changes on theme
Blog Hide -
<ecbmodule type="visible" data-type="companyrelation" data-filter="{Field:'companyrelationblogany',Operator:'=',Value:'true'}"> <ecbtemplate> ---html---- </ecbtemplate> </ecbmodule>
| gharchive/issue | 2022-11-18T06:22:01 | 2025-04-01T06:36:59.007113 | {
"authors": [
"Avinash-ecb",
"mitulpanch"
],
"repo": "Fammeo/EasyCloudBooks",
"url": "https://github.com/Fammeo/EasyCloudBooks/issues/1788",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1427916046 | Rewrite DEX classes avoiding over use of std::shared_ptr
In order to improve performance avoid overuse of std::shared_ptr, keeping it only in very connected components (for example IRGraph and Graphs of basic blocks). In other cases, it is better to keep ownership in just one object (use of std::unique_ptr), there's no need to share ownership of many objects. A raw pointer can be returned in some cases when read access is needed.
Another interesting utility, whenever we use a vector of objects, we can do the next:
using object_t = std::vector<Object*>;
And from these we could try to return iterators in order to go over them in case a user wants to go over all the data structure.
All these improvements will also be helpful for creating the bindings for other languages, since it does not use many shared_ptr, and there's no need to keep counter for number of references, etc.
A new branch will be created for doing all these changes, so we will avoid having issues.
Current branch https://github.com/Fare9/KUNAI-static-analyzer/tree/refactoring includes many of the changes here proposed, also fix an important issue regarding performance. All these changes have been tested, and currently all these changes are being tested against Androguard with a benchmarking.
| gharchive/issue | 2022-10-28T22:30:11 | 2025-04-01T06:36:59.012689 | {
"authors": [
"Fare9"
],
"repo": "Fare9/KUNAI-static-analyzer",
"url": "https://github.com/Fare9/KUNAI-static-analyzer/issues/52",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2384451021 | Login failed, the terms and conditions might have been updated
After restarting HA today, this integration logs this:
Logger: seatconnect.connection
Bron: custom_components/seatconnect/__init__.py:796
integratie: Seat Connect ([documentatie](https://github.com/farfar/homeassistant-seatconnect/blob/main/README.md), [problemen](https://github.com/farfar/homeassistant-seatconnect/issues))
Eerst voorgekomen: 19:55:31 (11 gebeurtenissen)
Laatst gelogd: 20:05:10
Login failed, the terms and conditions might have been updated and need to be accepted. Login to https://my.seat/portal/ and accept the new terms before trying again
On the proposed website is stated:
Update notification
As of April 22nd 2022, the SEAT CONNECT portal is no longer available online.
Is it possible to make this integration working again?
The same issue happened to me yesterday. I logged into https://seatid.vwgroup.io with my credentials and accepted all questions. Went back to HA and everything seems to work as expected.
Can confirm this!
Confirmed aswell, thank you for your replies! Closed.
The same issue happened to me yesterday. I logged into https://seatid.vwgroup.io with my credentials and accepted all questions. Went back to HA and everything seems to work as expected.
I logged on to the https://seatid.vwgroup.io/ and did the walk-through. When that didn't change the outcome, I went to https://cupraid.vwgroup.io/ and did the same (with the same account).
Since it’s al marketing / commercial consent, I don’t think it matters whether you give consent or not, but does anyone know their given consent to specific parts?
I gave all, after reading them, but only on seatid.vwgroup.io, while getting data from a Cupra Leon Sportstourer.
I also restarted HA, just to be sure, and after that the integration was happy again.
I think it's a different issue than mine you solved by doing that.
Just have permissions, bit it still failed.
The main errors (in the other issue ticket):
Invalid credentials or invalid configuration. Make sure you have entered the correct credentials
Login failed with error: User appears unauthorized
Even though the credentials are correct and the plus service is bought.
Did you also fill in your s-pin in the configuration of HA?
I have configured S-pin and restarted HA but same thing. In another test HA, I have done integration again and logically until you log in with User and Psw doesn't let you put the S-pin so I can't configure it either.
Hmmm... Then I'm affraid I can't help you any further...
Did you also fill in your s-pin in the configuration of HA?
No, I do not cause I don’t know how. After I select the integration, I get the following setup screen.
The integration options can be changed after setup by clicking on the "CONFIGURE" text on the integration.
But I can’t get passed the setup.
You are right, it's in the Options for Seat Connect screen, as you wrote. Just curious what brand and model car are you trying to connect?
You are right, it's in the Options for Seat Connect screen, as you wrote. Just curious what brand and model car are you trying to connect?
In my case Cupra León ST
I have created a new user in My Cupra, accepted the terms and tried to add it in HA, but exactly the same thing happens. In the HA Log it says that you have to accept the terms, but I already have them accepted in both my user and the one I just created.
After gerting crazy for days (accessing anywhere you mentioned to accept anything...), have found a solution could help.
I logged in with Tor Browser (any otehr browser with incognito mode may work). I have changed my region to Germany (I am actually in Spain). New terms have appeared so I have accepted them. Then it has worked in HA!!!!
After gerting crazy for days (accessing anywhere you mentioned to accept anything...), have found a solution could help. I logged in with Tor Browser (any otehr browser with incognito mode may work). I have changed my region to Germany (I am actually in Spain). New terms have appeared so I have accepted them. Then it has worked in HA!!!!
Luego volviste a Español? Yo me estoy volviendo loco también. Cuando me contestes lo pruebo. Gracias!!
@trusky7 thats weird, I also connect to a Cupra Leon ST! I'm in the Netherlands, and saw the above suggestion to swap region... Maybe give it a try?
To do the above with other region, I created a new user yesterday (it looks to take a day to be validated), with an invite fron main user. Region is Germany but I keep Spanish language.
When accessing through official app it ramains in Spanish.
Prueba a cambiar la región! No te influirá en nada! No me atrevo a poner España como region de nuevo... Jeje
I have entered Seat Id, I have changed the region to Germany, it has made
me accept conditions, I have exited and entered again, it has made me
accept more conditions and then I have gone to HA but it tells me the same
thing. I have done this with the user that I created this morning to
test. Should I wait or something?
El mié, 3 jul 2024, 20:30, dacorde @.***> escribió:
To do the above with other region, I created a new user yesterday (it
looks to take a day to be validated), with an invite fron main user. Region
is Germany but I keep Spanish language.
When accessing through official app it remains in Spanish.
Prueba a cambiar la región! No te influirá en nada! No me atrevo a poner
España como region de nuevo... Jeje
—
Reply to this email directly, view it on GitHub
https://github.com/Farfar/homeassistant-seatconnect/issues/63#issuecomment-2206954908,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BH4USJ6VKE2HS2DTES6CVZ3ZKQ7M7AVCNFSM6AAAAABKGBWVV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWHE2TIOJQHA
.
You are receiving this because you were mentioned.Message ID:
@.***>
Wow now yes!!! In my principal user wotks fine. Thxx
I can confrm the solution... change region in the user to germany, logout, login, agree the terms and conditions and working again. Thanks¡¡
Me pasaba lo mismo. No podía logearme. He cambiado la región, aceptado todas las condiciones, reiniciado la aplicación y ahora funciona.
| gharchive/issue | 2024-07-01T18:12:25 | 2025-04-01T06:36:59.029607 | {
"authors": [
"M4RCCR4FT",
"Recte",
"christianschneider89",
"dacorde",
"egarijo",
"mookkari",
"pedestre",
"trusky7"
],
"repo": "Farfar/homeassistant-seatconnect",
"url": "https://github.com/Farfar/homeassistant-seatconnect/issues/63",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
510921306 | Calculate travel distance between group members
Idea here is to help users determine which sorting method is going to be the most efficient for their bot:
An embellishment on this idea would be to use the bot's X/Y speed and acceleration settings to calculate travel time, in addition to distance.
Some style suggestions to what's on staging:
Border and background color: #94d7da
Broder-radius: 5px
Increase margin between sort options to 0.5rem
| gharchive/issue | 2019-10-22T21:17:13 | 2025-04-01T06:36:59.046428 | {
"authors": [
"roryaronson"
],
"repo": "FarmBot/Farmbot-Web-App",
"url": "https://github.com/FarmBot/Farmbot-Web-App/issues/1514",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2100771817 | Validator not running in unit test
Hi,
Have you seen an issue with the Validator<> never calling in unit tests when using Factory.Create?
Code below:
public class TestValidator : Validator<TestRequest> { public TestValidator() { RuleFor(x => x.Id).GreaterThanOrEqualTo(0); //RuleFor(x => x.StartDateTime).LessThan(x => x.EndDateTime); } }
`public class TestEndpoint : Endpoint<TestRequest, IEnumerable>
{
public TestEndpoint(ITestManager tradeManager, AutoMapper.IMapper mapper)
{
_tradeManager = tradeManager;
_mapper = mapper;
}
private readonly ITradeManager _tradeManager;
private readonly AutoMapper.IMapper _mapper;
public override void Configure()
{
Verbs(Http.GET);
Routes("/trades");
Version(1);
Summary(s => {
s.Summary = "Trades";
s.Description = "Query trades";
});
AllowAnonymous();
}
public override async Task HandleAsync(TestRequest testRequest, CancellationToken cancellationToken)
{
var trades = _tradeManager
.TestData
.ProjectTo<TestResponse>(_mapper.ConfigurationProvider);
await SendAsync(trades, cancellation: cancellationToken);
}
}`
`using Microsoft.Extensions.DependencyInjection;
using FluentValidation;
namespace Adapter.Api.Tests.Trade;
[TestFixture]
public class TestEndpointTest
{
[SetUp]
public void Setup()
{
_fixture = new Fixture();
_fixture.Customize(new AutoMoqCustomization());
//Test contains legs of Tests which is an acceptable circular reference
_fixture.Behaviors.OfType<ThrowingRecursionBehavior>().ToList()
.ForEach(b => _fixture.Behaviors.Remove(b));
_fixture.Behaviors.Add(new OmitOnRecursionBehavior());
_Tests = _fixture.Build<Core.TestManager.Test>()
.CreateMany(20).ToList();
_TestManagerMock = _fixture.Freeze<Mock<ITestManager>>();
_TestManagerMock.Setup(x => x.Tests).Returns(_Tests.AsQueryable());
//_fixture.Inject(new TestValidator());
var TestValidator = new TestValidator();
var mappingConfig = new MapperConfiguration(cfg =>
cfg.AddProfile(new MappingProfile()));
var automapperMock = _fixture.Freeze<Mock<AutoMapper.IMapper>>();
automapperMock.Setup(x => x.ConfigurationProvider).Returns(mappingConfig.CreateMapper().ConfigurationProvider);
_TestEndpoint = Factory.Create<TestEndpoint>(
_TestManagerMock.Object,
automapperMock.Object);
_TestEndpoint.Configure();
}
[Test]
public async Task Test_Response_Is_Error_When_Negative_TestId()
{
var TestId = _Tests.First().Id;
var TestRequest = new TestRequest
{
Id = -1
};
_TestEndpoint!.Definition.Validator<TestValidator>();
await _TestEndpoint!.HandleAsync(TestRequest, default);
_TestEndpoint!.ValidationFailed.Should().BeTrue();
}
}`
validators are not meant to be executed during a "unit test". model binding, validation, pre/post processors, etc. are part of the pipeline and are not meant to be executed during a unit test. that's what an integration test is for.
the purpose of a unit test is simply to accept a fully populated (and already validated) request dto run the handler logic and return the response. nothing else.
examples of unit tests: https://github.com/FastEndpoints/FastEndpoints/blob/main/Tests/UnitTests/FastEndpoints/WebTests.cs
examples of integration tests: https://github.com/FastEndpoints/FastEndpoints/blob/main/Tests/IntegrationTests/FastEndpoints/WebTests/AdminTests.cs
Have you got any examples of integration tests with nunit?
sorry no. we only use xunit.
Have you got any unit test examples for validators?
Why is it that the tests in this test class fail validation if it doesn't call validators?
https://github.com/FastEndpoints/FastEndpoints/blob/main/Tests/UnitTests/FastEndpoints/WebTests.cs
Have you got any unit test examples for validators?
unit testing fluent validators can be done just like you would any other class.
unless your validator needs some service registrations as described here.
Thanks for your help.
| gharchive/issue | 2024-01-25T16:40:00 | 2025-04-01T06:36:59.057266 | {
"authors": [
"GChannonLondon",
"dj-nitehawk"
],
"repo": "FastEndpoints/FastEndpoints",
"url": "https://github.com/FastEndpoints/FastEndpoints/issues/581",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2761734775 | Game not properly added if DNS request is refused
If the connection request to the used Google DNS address gets refused for any reason, the game appears to not have been added to the library while still being added in the background. The same game can't be added twice while in this state as it already exists. Once faugus is restarted the game is visible and can be used normally.
Traceback (most recent call last):
File "/usr/bin/faugus-launcher", line 1759, in on_dialog_response
if not check_internet_connection() and add_game_dialog.combo_box_launcher.get_active() != 0:
~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/bin/faugus-launcher", line 1750, in check_internet_connection
socket.create_connection(("8.8.8.8", 53), timeout=5)
~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/socket.py", line 864, in create_connection
raise exceptions[0]
File "/usr/lib/python3.13/socket.py", line 849, in create_connection
sock.connect(sa)
~~~~~~~~~~~~^^^^
ConnectionRefusedError: [Errno 111] Connection refused
Thanks for reporting.
It should be fixed now.
Please update.
Oooh I see the problem now. You're trying to add a Linux native game, right?
It should only check the internet when installing a launcher (Battle.net, EA App, Epic Games...).
I'll have to fix that.
Done.
What distro are you running?
I just pushed an update and now it should not test the internet connection when adding a windows or linux game.
Please let me know if you're still facing this issue.
Thanks for reporting and testing.
Happy new year for you too!
Enjoy the app!
| gharchive/issue | 2024-12-28T14:04:31 | 2025-04-01T06:36:59.093672 | {
"authors": [
"0pac1ty",
"Faugus"
],
"repo": "Faugus/faugus-launcher",
"url": "https://github.com/Faugus/faugus-launcher/issues/56",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
333401205 | Dots in key name
Hi,
is it possible to have dot characters in the key name?
I need to have a key which is a domain name, like www.mysite.com. But it always creates JSON structure like this:
{
"www": {
"mysite": {
"com": { ... }
}
}
}
Instead of simply this:
{
"www.mysite.com": { ... }
}
I think you can try something like this, not sure if it's going to work.
- ghetto_json:
- !unsafe 'www.mysite.com': {{ value }}
| gharchive/issue | 2018-06-18T19:20:13 | 2025-04-01T06:36:59.103439 | {
"authors": [
"CrNix",
"madsalama"
],
"repo": "FauxFaux/ansible-ghetto-json",
"url": "https://github.com/FauxFaux/ansible-ghetto-json/issues/9",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
2125640086 | ⚠️ Roblox Devforum has degraded performance
In 6fa0b9b, Roblox Devforum (https://devforum.roblox.com) experienced degraded performance:
HTTP code: 200
Response time: 2397 ms
Resolved: Roblox Devforum performance has improved in a87bac5 after 20 minutes.
| gharchive/issue | 2024-02-08T16:51:09 | 2025-04-01T06:36:59.116132 | {
"authors": [
"FearedFusionX"
],
"repo": "FearedFusionX/Ro-Status",
"url": "https://github.com/FearedFusionX/Ro-Status/issues/820",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1732842943 | fix: enable table overflow-x
This PRs refactor's Box component to a Layout inside CollectionTable.js, so we can have proper overflow in the table, when we have multiple locales supported.
Before
After
Also removed redundant div, and replace with fragment.
Hey @konsalex,
thank you for your contribution. Looks good to me, gonna leave it up to @sargreal to merge ^^
| gharchive/pull-request | 2023-05-30T19:18:53 | 2025-04-01T06:36:59.147585 | {
"authors": [
"konsalex",
"layaxx"
],
"repo": "Fekide/strapi-plugin-translate",
"url": "https://github.com/Fekide/strapi-plugin-translate/pull/222",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1253613241 | Support $currentDate field update operator
Refs #622.
Except timestamp.
I invite you not to review but to discuss.
I need somehow to test data time values.
And all my ideas are overcomplicated.
Can we do it simply?
Do we have an agreed way on how to test it?
timestamp is extracted as more complex - probably there will be more and more changes.
timestamp is extracted as more complex - probably there will be more and more changes.
I've added it. Please see - there are some changes in types.
@Dmitry @rumyantseva PTAL, I've changed to time.Time
| gharchive/pull-request | 2022-05-31T09:46:08 | 2025-04-01T06:36:59.168205 | {
"authors": [
"seeforschauer"
],
"repo": "FerretDB/FerretDB",
"url": "https://github.com/FerretDB/FerretDB/pull/662",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
445053219 | Global/Default INI files?
Hi. Is there a way to set a global ini config so that new instances will always use those settings?
Thanks,
Chris
I am pretty new to the tool, but as far as I can tell, Server Tools does not manage your INI files at all.
If you use the same arkserverroot="/home/steam/ARK" location for all of your instances, then you would get the behavior you are asking for.
Just be careful to configure different ark_AltSaveDirectoryName="whatever" for each. Also, be aware that some settings configured in your instance.cfg files will be temporary saved to GameUserSettings.ini (this is done by ARK ,not Server Tools). You will want to ensure that any settings that different from instance to instance and specifically listed in instance.cfg (even if they are the default), otherwise another instance's settings my be leftover in GameUserSettings.ini.
| gharchive/issue | 2019-05-16T16:35:22 | 2025-04-01T06:36:59.177549 | {
"authors": [
"Chris230291",
"sphbecker"
],
"repo": "FezVrasta/ark-server-tools",
"url": "https://github.com/FezVrasta/ark-server-tools/issues/1019",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
175147862 | Question rather than an issue about updating multiple instances
Hi
I have two instances running at the moment. My question is with the update of the server and mods when they share the same staging directory, I believe that arkmanager has to download the mod before it can check to see if it has been updated.
If the two instances are also sharing the same mods or mostly the same mods does the update process download them twice to check for updates? Do I need to run an update for each instance separately?
The mods do not currently share a staging directory (apart from the SteamCMD workshop content directory). SteamCMD should check whether the mod is up-to-date and return fairly quickly if the latest version of the mod has already been downloaded.
If the instances are not sharing the same physical directory, then each instance must be updated separately. If the instances do share the same physical directory (which would require them to be part of the same cluster), then only one instance needs to be updated, but both instances need to be stopped before the update.
I didn't think I could share the directory? So I have a separate directory tree for each server including mod dirs and saved dirs. Basically they are duplicates except for the map and save files
When the -clusterid=clustername option is used, the ARK server likely uses inter-process communication to prevent conflicts.
arkmanager is not currently able to allow multiple server instances to run from the same directory. You would need to follow something like what ryan1161 wrote in https://github.com/FezVrasta/ark-server-tools/issues/578#issuecomment-244962370; I don't know if all game servers in the cluster need to have the same mods enabled.
v1.6 should now support having multiple instances in a cluster running from the same directory.
| gharchive/issue | 2016-09-06T02:26:23 | 2025-04-01T06:36:59.181285 | {
"authors": [
"klightspeed",
"rob-bb"
],
"repo": "FezVrasta/ark-server-tools",
"url": "https://github.com/FezVrasta/ark-server-tools/issues/591",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1350831604 | Stays forever in "Updating... Updated.... Updating...."
Describe the bug
Here it stopped working, it stays forever in "Updating... Updated.... Updating...."
To Reproduce
Version: ...
Steps to reproduce the behavior:
...
Expected behavior
...
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
...
Hi, it's supposed to do that.
After a few seconds it should fetch new data from inara for the least recently updated commodity. In this state it says updating.
When the commodity is updated in the local database, it changes to updated. After a few more seconds it does the same for the next least recently updated commodity.
I have experienced this same bug. After initial install and run, I have waited several hours and the screen continues to say:
Updating...
Storing EDDN information...
There is no additional information shown on the screen. It seems like it is stuck forever in loading and there is no way to determine progress or if there is an error.
How long should this updating take? I've left it to run overnight (8-9 hours) and it still just says "Updating..." and "Storing EDDN information..."
This bug was caused by the inara website that changed its layout. Since 2.0.0.0 this is fixed.
Is this bug back? I am running 2.2.0.0 let it run for hours and no additional information is shown.
The bug shouldn't be there anymore, but it might be caused by some connection problems.
Can you please attach your log-file? That way I should be able to pinpoint the problem.
Your Log should be located in C:\Users\USERNAME\AppData\Roaming\EDCT\Logs
I can confirm that in version 2.2.0.0 (downloaded and installed today and deleted the old database with all old files in my Windows10 profile) the updating (inara) keeps on spinning after 1 hour. Only 541 systems in the database, but NO distances, stations, commodities, export/import prices. If i use DB Browser for SQLite only the Systems table is filled with the stated 541 systems (all fields are filled with data). While the updating status is still running, each few seconds a new system is added to the table. But no other information in other tables are filled. What to do? Wait for a fix?
I restarted EDCT and it continues the same process by filling the Systems table with a new solar system every few seconds. Nothing else happens.
The bug shouldn't be there anymore, but it might be caused by some connection problems. Can you please attach your log-file? That way I should be able to pinpoint the problem. Your Log should be located in C:\Users\USERNAME\AppData\Roaming\EDCT\Logs
Currently this folder is empty. I will run the tool for a while today to see if I can get any logs generated. Thanks for taking the time to look into this for everyone!
My log was empty and my conbection as a hosting party is fine.Met vriendelijke groet,J. MenkemaOp 24 jan. 2023 om 16:28 heeft 534n5mith @.***> het volgende geschreven:
The bug shouldn't be there anymore, but it might be caused by some connection problems. Can you please attach your log-file? That way I should be able to pinpoint the problem. Your Log should be located in C:\Users\USERNAME\AppData\Roaming\EDCT\Logs
Currently this folder is empty. I will run the tool for a while today to see if I can get any logs generated. Thanks for taking the time to look into this for everyone!
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
Ok I think I know the source of the problem now. Inara updated the website layout again, which means that I have to adjust a few parts of my code.
I'll work on it as soon as possible.
Thank you all for bringing the issue to my attention!
In addition to the updated website-layout, inara now also checks for your browser-version. So I had to set one in the tool.
Fixed in version 2.2.0.1
| gharchive/issue | 2022-08-25T12:37:30 | 2025-04-01T06:36:59.194952 | {
"authors": [
"534n5mith",
"Fi0x",
"JEricEaton",
"Selpheed",
"kdog0598",
"rucomania"
],
"repo": "Fi0x/EDCT",
"url": "https://github.com/Fi0x/EDCT/issues/94",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
794534681 | Localisation - Fix font issue for Greek
As mentioned in #2166, we observed some font inconsistencies for Greek (different fonts seen on About Us and Help Board).
Example from About Us:
We had a similar problem in the past because we didn't have all the correct weights of the font downloaded. Please refer to this PR to see if we can solve the issue in a similar way, thanks!
Hey @emanuelquerty, did you want to work on this? We merged the other PR, so I opened this new ticket.
Hey @emanuelquerty, did you want to work on this? We merged the other PR, so I opened this new ticket.
Hey @doheekim93 yeah I did. Thanks for letting me know.
I fixed the problem and it was for a different reason than what we had in this PR. It was because the css rules for font-family was missing the default fallback font (font-family: "Poppins"; vs font-family: "Poppins", sans-serif;). I will open the PR now and push the fix.
Hey @doheekim93 yeah I did. Thanks for letting me know.
I fixed the problem and it was for a different reason than what we had in this PR. It was because the css rules for font-family was missing the default fallback font (font-family: "Poppins"; vs font-family: "Poppins", sans-serif;). I will open the PR now and push the fix.
@emanuelquerty Ooooh that's good to know! Thank you for figuring that out!!
@emanuelquerty Ooooh that's good to know! Thank you for figuring that out!!
| gharchive/issue | 2021-01-26T20:23:01 | 2025-04-01T06:36:59.203326 | {
"authors": [
"doheekim93",
"emanuelquerty"
],
"repo": "FightPandemics/FightPandemics",
"url": "https://github.com/FightPandemics/FightPandemics/issues/2181",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1977600914 | 🛑 logs.mmattbot.com is down
In 80f1a72, logs.mmattbot.com (https://logs.mmattbot.com/) was down:
HTTP code: 0
Response time: 0 ms
Resolved: logs.mmattbot.com is back up in 5bc20e1 after 15 minutes.
| gharchive/issue | 2023-11-05T02:38:30 | 2025-04-01T06:36:59.209971 | {
"authors": [
"Fijxu"
],
"repo": "Fijxu/justlog-instances-uptime",
"url": "https://github.com/Fijxu/justlog-instances-uptime/issues/1137",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
823629052 | How to reset error to null in base view model
hi, can somebody tell me how to reset the error object when using runBusyFuture() in success condition
source code in here https://github.com/FilledStacks/stacked/blob/master/packages/stacked/lib/src/state_management/base_view_models.dart#L75-L99
/// Sets the ViewModel to busy, runs the future and then sets it to not busy when complete.
///
/// rethrows [Exception] after setting busy to false for object or class
Future runBusyFuture(Future busyFuture,
{Object busyObject, bool throwException = false}) async {
_setBusyForModelOrObject(true, busyObject: busyObject);
try {
var value = await runErrorFuture(busyFuture,
key: busyObject, throwException: throwException);
_setBusyForModelOrObject(false, busyObject: busyObject);
return value;
} catch (e) {
_setBusyForModelOrObject(false, busyObject: busyObject);
if (throwException) rethrow;
}
}
Future runErrorFuture(Future future,
{Object key, bool throwException = false}) async {
try {
return await future;
} catch (e) {
---> _setErrorForModelOrObject(e, key: key);
onFutureError(e, key);
if (throwException) rethrow;
return Future.value();
}
}
when cache exception, will call _setErrorForModelOrObject(e: key: key),
but when i recall runBusyFuture(), if this time, no exception occurred, could we need to reset the error to null?
i did not found where to reset this error, can some body help me ?
Now, in my code now in below
static final String objectRefreshBook = 'refreshBook';
Future<void> refreshBook() async {
if (!hasBook) return;
if (busy(objectRefreshBook)) return;
--> setErrorForObject(objectRefreshBook, null);
await runBusyFuture(
Future(() async {
final newBook = await _bookService.fetchBook(_book);
await _bookService.updateBook(newBook);
_book = newBook;
}),
busyObject: objectRefreshBook,
);
if (error(objectRefreshBook) != null) {
_snackbarService.showSnackbar(message: error(objectRefreshBook).toString());
}
}
i need to call setErrorForObject(key, null); to reset error before runBusyFuture()
is this api designed using like so? or could we merge this reset error in base view model?
| gharchive/issue | 2021-03-06T11:45:46 | 2025-04-01T06:36:59.218192 | {
"authors": [
"githubmin"
],
"repo": "FilledStacks/stacked",
"url": "https://github.com/FilledStacks/stacked/issues/246",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
934425431 | get null when Pass argument
Hi,
I wondered that on [replaceWithTransition](https://github.com/FilledStacks/stacked/blob/master/packages/stacked_services/lib/src/navigation_service.dart) in NavigationService why you didn't add argument prop?
I changed it to this :
Future<dynamic> navigateWithTransition(Widget page,
{bool opaque,
@required String transition,
Duration duration,
bool popGesture,
int id,
dynamic arguments}) {
return Get.to(() => page,
transition: _getTransitionOrDefault(transition),
duration: duration ?? Get.defaultTransitionDuration,
popGesture: popGesture ?? Get.isPopGestureEnable,
opaque: opaque ?? Get.isOpaqueRouteDefault,
id: id,
arguments: arguments);
}
and when I pass a dummy string :
await _navigatorService.navigateWithTransition(
PersonalInfoDegreePage(
userProfileModel: userProfileModel,
),
transition: NavigationTransition.RightToLeft.name,
arguments: "dummy test",
);
In PersonalInfoDegreePage I got null ? print(getIt<NavigatorService>().currentArguments);
currentArguments are only stored when you use named routing since it goes through a router.
If you're using this view you can just pass the argument into the constructor of the View you're navigating too if you need it in that view.
currentArguments are only stored when you use named routing since it goes through a router.
If you're using this view you can just pass the argument into the constructor of the View you're navigating too if you need it in that view.
Thanks, but I changed your repository and I added arguments to your navigateWithTransition method , I could send argument.
Yes by constructor it is possible.
| gharchive/issue | 2021-07-01T05:50:30 | 2025-04-01T06:36:59.221758 | {
"authors": [
"FilledStacks",
"tazik561"
],
"repo": "FilledStacks/stacked",
"url": "https://github.com/FilledStacks/stacked/issues/434",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2083040133 | Add exhaustive tests for compress() and decompress()
This tests against vectors I generated here, using Python's Fraction module.
The good news is, the tests pass!
The bad news is, I don't know golang, so the quality of my code that implements the tests might suck. Let me know what you think heh.
Yours is also the first implementation I've tested these vectors against, aside from my own implementations, so you might want to wait for some additional confirmations.
Sweet, love to get some exhaustive tests.
Do you think you could replicate them with math/big.Rat inline rather than checking in the vectors?
Good idea, I converted the tests to use math/big.Rat.
I had some trouble deciding the best way to get a rounded integer result from the Rat, and I ended up with this:
strconv.ParseInt(precise.FloatString(0), 10, 64)
It's a bit of a hack, do you know if there's a better way?
Thank you too, for the comprehensive review!
@DavidBuchanan314, have you signed the Google Individual CLA (https://cla.developers.google.com/about/google-individual) and do I have your permission to submit this change under the terms of that CLA on your behalf as part of https://go.dev/cl/550215?
Signed just now, sounds good to me :)
Thank you!
| gharchive/pull-request | 2024-01-16T05:20:25 | 2025-04-01T06:36:59.226732 | {
"authors": [
"DavidBuchanan314",
"FiloSottile"
],
"repo": "FiloSottile/mlkem768",
"url": "https://github.com/FiloSottile/mlkem768/pull/4",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
174786301 | 3.12.0 release
We've pushed version 3.12.0-0 to QA and it has been published to NPM under the next label.
To install this package from NPM you can run npm i polyfill-service@next.
Click here for the full changelog.
Notable changes:
RUM reporting is now handled by our CDN provider Fastly, this helps ease the load of our servers. This work was done by @triblondon - #851
Added Number.isFinite(...) polyfill. This work was done by mudcube - #834
Iterator polyfills now target IE mobile and Samsung browser. This work was done by @wheresrhys - #848
Update to latest version of URL polyfill. This work was done by @triblondon - #800
Added the es6 alias to all es6 features we have polyfilled. This work was done by @JakeChampion - #847
No changes to the default set, so we have not introduced a new immutable default set label.
As usual, we'll hold this on QA for a week for testing. Please post any concerns here.
We've pushed a new version that adds more RUM improvements, 3.12.0-1. We don't expect any impact on the core service.
This is now live on https://polyfill.io
| gharchive/issue | 2016-09-02T15:28:03 | 2025-04-01T06:36:59.295904 | {
"authors": [
"JakeChampion",
"triblondon"
],
"repo": "Financial-Times/polyfill-service",
"url": "https://github.com/Financial-Times/polyfill-service/issues/858",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
393132149 | Add interface for accessing tenant options
The normal way to get options in ASP.NET Core -- IOptions<MyOptionType> etc. will provide the options for the current tenant only. If you look under-the-hood you will see that each tenants options are cached in way that makes it difficult to retrieve or clear the cached options for a specific tenant (ie other than the current tenant).
There should be a way to access or clear the cached options for a specific tenant without having to dig into the Finbuckle.MultiTenant and ASP.NET Core internals.
Partially, implemented with 3.0. Still cannot access options for a different tenant--but I am not sure that is a good idea anyway. Closing this story for now.
| gharchive/issue | 2018-12-20T17:00:05 | 2025-04-01T06:36:59.309358 | {
"authors": [
"achandlerwhite"
],
"repo": "Finbuckle/Finbuckle.MultiTenant",
"url": "https://github.com/Finbuckle/Finbuckle.MultiTenant/issues/102",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2353407811 | Cookies and Identity Server
Hi Andrew,
Having problems logging into identity server after a tenant identifier is updated by a user. I am hoping to get some guidance/assistance
When a new tenant is created an identifier is automatically created for them. I allow tenants to update their identifier. Once their identifier is updated the user can initiate a logout, which logs them out and redirects them to the start page with the updated identifier in the url.
e.g
user is logged in with this url
http://appurl/1B8E302B-B931-4CAE-B404-A42B7D1E8895/Dashboard/Settings/Identifier
user then updates their identifier to "ABC" and initiates a logout. The user is then redirected to this url
http://appurl/ABC
At this point the user then tries to log back in, but instead of logging into identity server with the new identifier
http://identityserver/abc
the user is redirected to identity server with the old url
http://identityserver/1B8E302B-B931-4CAE-B404-A42B7D1E8895
resulting in invalid redirect uri error in identity server since the urls dont match...."ABC" does not match "1B8E302B-B931-4CAE-B404-A42B7D1E8895"
I suspect it has to do with the identity server session created with the first login prior to updating the identifier?
My signout code in the application
public IActionResult OnGet()
{
var redirectUri = Url.Page("/", null, null, Request.Scheme);
return SignOut(new AuthenticationProperties()
{
RedirectUri = redirectUri
}, CookieAuthenticationDefaults.AuthenticationScheme,
OpenIdConnectDefaults.AuthenticationScheme);
}
Any help appreciated.
Hi friend. I haven’t forgotten you. I’m catching up on things and will take a look. Have you made any progress in the mean time?
Hi Andrew,
At this time no, but I currently have a work around.
Hm, it looks like the open id connect option for the tenant are not being refreshed. When they change tenant identifier you'll want to clear the already generated options as described here:
https://www.finbuckle.com/MultiTenant/Docs/Options#options-and-caching
I don't recall off the top of my head if you need to use the IOptionsMonitor approach as described or the other. Then next time it needs those options to drive logic, i.e. redirect, it should regenerate them.
That being said I find that redirecting based on tenant id might be better than identifier since in theory id should never change.
What sort of workaround did you come up with in your situation?
Hi Andrew,
Thx for getting back to me. I will look into your suggestions.
As a work around I created a friendly identifier column that is 4 to 8 characters long. The user can then look up their friendly identifier on a search screen. If their tenant is found, they are redirected to their portal with the "normal" identifier in the URL. If the tenant is not found, they are directed to a referral screen indicating their organization was not found. Portal admins can set their friendly identifier.
| gharchive/issue | 2024-06-14T13:37:34 | 2025-04-01T06:36:59.316032 | {
"authors": [
"AndrewTriesToCode",
"goforebroke"
],
"repo": "Finbuckle/Finbuckle.MultiTenant",
"url": "https://github.com/Finbuckle/Finbuckle.MultiTenant/issues/842",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
312748758 | How to upload video from fine Uploader.
Hello,
To upload video,Can we just use allowedExtension mp4 or there are some other criteria?
Thanks!
You don’t need to do anything to upload videos. But if you want to limit the allowed extensions, you can do so as you’ve described.
Hey @rnicholus,
Uploading videos says uploaded successfully but not stored in Server.Also can you help me with the onDeleteComplete events here is snippet of my code :
callbacks: {
onComplete: function(id, name, response) {
if (response.success) {
alert("UPLOAD SUCCESS");
}
else {
alert("Problem uploading stuff");
}
},
onSubmitDelete: function(id) {
alert("Are You Sure You Wantto delete the item");
},
onDeleteComplete: function(id, xhr, isError) {
if (success) {
alert("DELETE SUCCESS");
}
else {
alert("Problem deleting stuff");
}
}
}
am i doing it correctly ?
Uploading videos says uploaded successfully but not stored in Server
I can't help you with that - you'll need to look closer at your server code.
As for your onDeleteComplete event, you're referencing a variable that does not exist - success. All events are documented at https://docs.fineuploader.com/branch/master/api/events.html. Have a look for more details and examples.
| gharchive/issue | 2018-04-10T02:12:58 | 2025-04-01T06:36:59.323092 | {
"authors": [
"YashKharel19",
"rnicholus"
],
"repo": "FineUploader/react-fine-uploader",
"url": "https://github.com/FineUploader/react-fine-uploader/issues/184",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
541682507 | [firebase_ml_vision] Cloud text recognition does not return coordinates blocks, lines and elements
When using the cloud text recognizer, the coordinates of the recognized text do not come. However, text detection works fine.
The problem does not appear when using text recognition on both platforms on the device.
See attached screenshots.
Steps to reproduce the behavior:
Use FirebaseVision.instance.cloudTextRecognizer()
Progress image File
Look at coordinates
Supporting Code:
final FirebaseVisionImage visionImage =
FirebaseVisionImage.fromFile(imageFile);
final TextRecognizer textRecognizer =
FirebaseVision.instance.cloudTextRecognizer();
VisionText visionText;
textRecognizer.processImage(visionImage).then((vText) {
if (visionText != null && visionText.blocks.isNotEmpty)
visionText.blocks.forEach((block) {
block.lines.forEach((line) {
line.elements.forEach((element) {
print(element);
});
});
});
});
Additional context
Original Image:
The result in the debugger if you use FirebaseVision.instance.textRecognizer():
The result in the debugger if you use FirebaseVision.instance.cloudTextRecognizer():
As you can see in the photo, if you use cloudTextRecognizer (), then the text is recognized, but the empty result of the cornerPoints field for both platforms is returned
Logs
λ flutter doctor -v
[√] Flutter (Channel stable, v1.12.13+hotfix.5, on Microsoft Windows [Version 10.0.18362.535], locale en-US)
• Flutter version 1.12.13+hotfix.5 at D:\Android\flutter_sdk\flutter
• Framework revision 27321ebbad (12 days ago), 2019-12-10 18:15:01 -0800
• Engine revision 2994f7e1e6
• Dart version 2.7.0
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at D:\Android\Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[√] Android Studio (version 3.5)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[√] VS Code (version 1.41.1)
• VS Code at C:\Users\Arro\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.7.1
[√] Connected device (1 available)
• Redmi Note 4 • 192.168.100.15:5555 • android-arm64 • Android 7.0 (API 24)
• No issues found!
pubspec.yaml
firebase_ml_vision: ^0.9.3+5
Given the age of this issue and it's inactivity I'm going to go ahead and close it in favour of trying the latest versions of ML Vision which ships with newer on device models. Thanks
Hi Salakar,
I've stumbled across the exact same issue (I'm using the newest plugin version: firebase_ml_vision 0.12.0+1).
I was wondering, did you manage to find a solution to this issue?
| gharchive/issue | 2019-12-23T10:12:20 | 2025-04-01T06:36:59.359764 | {
"authors": [
"ArtRog",
"Salakar",
"Smux1demo"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/1701",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
715151646 | App receives different push notification structure (in onMessage) on Android and iOS, document ways o handle this in the app
I am sending push notification to iOS. When run-in gin emulator I receive push notification with notification object notification":{"body":"Test","title":"Test" }, however when app is built and deployed I receive same title in "app": {"alert": {"title": "test"} }
It is deployed on Apple 6 but iOS 13.
This behaviour looks similar to message["data"] ?? message however not mentioned anywhere in docs.
How should I behave? Should I add same check or it is a bug?
Also body property is missing
@vytautas-pranskunas-
Please provide flutter doctor -v and a minimal complete reproducible code sample.
Thanks.
class PushNotificationsService {
final FirebaseMessaging _firebaseMessaging = new FirebaseMessaging();
final _bgService = GetIt.instance<BackgroundNotificationsService>();
final _securityService = GetIt.instance<SecurityService>();
final _authService = GetIt.instance<AuthService>();
final _fgService = GetIt.instance<ForegroundNotificationsService>();
init() async {
if (Platform.isIOS) {
_firebaseMessaging
.requestNotificationPermissions(IosNotificationSettings());
}
_firebaseMessaging.configure(
onMessage: (Map<String, dynamic> message) async {
_fgService.handle(message['data'] ?? message); // If you look at message here you will see that structure when running on iPhone 6 with iOS 12
},
onBackgroundMessage: Platform.isIOS ? null : myBackgroundMessageHandler,
onLaunch: (Map<String, dynamic> message) async {
_bgService.handle(message['data'] ?? message, true);
},
onResume: (Map<String, dynamic> message) async {
_bgService.handle(message['data'] ?? message, false);
},
);
}
}
Hi @vytautas-pranskunas-
I think it is working as intended since both platforms have different notifications requirements but labelling the issue for documentation
I see your screenshots and i see that body is there but for it did not worked. I had this code:
_fgService.handle(message['data'] ?? message,
message['notification'] ?? message["aps"]["alert"]);
and inside handle function i was calling
notification['body']
my push notification structure sent from rst client was:
{
"notification": {
"title": "Test User",
"text": "Test message test message"
},
"data": {
"click_action": "FLUTTER_NOTIFICATION_CLICK",
},
"priority": "high",
"to": ..."
}
Hi @vytautas-pranskunas-
Using the official example with the following has no issue son latest packages with body
complete code sample
// Copyright 2019 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'package:firebase_core/firebase_core.dart';
import 'package:firebase_messaging/firebase_messaging.dart';
import 'package:flutter/material.dart';
Future<dynamic> myBackgroundMessageHandler(Map<String, dynamic> message) {
if (message.containsKey('data')) {
// Handle data message
final dynamic data = message['data'];
}
if (message.containsKey('notification')) {
// Handle notification message
final dynamic notification = message['notification'];
}
// Or do other work.
}
final Map<String, Item> _items = <String, Item>{};
Item _itemForMessage(Map<String, dynamic> message) {
final dynamic data = message['data'] ?? message;
final String itemId = data['id'];
final Item item = _items.putIfAbsent(itemId, () => Item(itemId: itemId))
..status = data['status'];
return item;
}
class Item {
Item({this.itemId});
final String itemId;
StreamController<Item> _controller = StreamController<Item>.broadcast();
Stream<Item> get onChanged => _controller.stream;
String _status;
String get status => _status;
set status(String value) {
_status = value;
_controller.add(this);
}
static final Map<String, Route<void>> routes = <String, Route<void>>{};
Route<void> get route {
final String routeName = '/detail/$itemId';
return routes.putIfAbsent(
routeName,
() => MaterialPageRoute<void>(
settings: RouteSettings(name: routeName),
builder: (BuildContext context) => DetailPage(itemId),
),
);
}
}
class DetailPage extends StatefulWidget {
DetailPage(this.itemId);
final String itemId;
@override
_DetailPageState createState() => _DetailPageState();
}
class _DetailPageState extends State<DetailPage> {
Item _item;
StreamSubscription<Item> _subscription;
@override
void initState() {
super.initState();
_item = _items[widget.itemId];
_subscription = _item.onChanged.listen((Item item) {
if (!mounted) {
_subscription.cancel();
} else {
setState(() {
_item = item;
});
}
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text("Item ${_item.itemId}"),
),
body: Material(
child: Center(child: Text("Item status: ${_item.status}")),
),
);
}
}
class PushMessagingExample extends StatefulWidget {
@override
_PushMessagingExampleState createState() => _PushMessagingExampleState();
}
class _PushMessagingExampleState extends State<PushMessagingExample> {
String _homeScreenText = "Waiting for token...";
bool _topicButtonsDisabled = false;
final FirebaseMessaging _firebaseMessaging = FirebaseMessaging();
final TextEditingController _topicController =
TextEditingController(text: 'topic');
Widget _buildDialog(BuildContext context, Item item) {
return AlertDialog(
content: Text("Item ${item.itemId} has been updated"),
actions: <Widget>[
FlatButton(
child: const Text('CLOSE'),
onPressed: () {
Navigator.pop(context, false);
},
),
FlatButton(
child: const Text('SHOW'),
onPressed: () {
Navigator.pop(context, true);
},
),
],
);
}
void _showItemDialog(Map<String, dynamic> message) {
showDialog<bool>(
context: context,
builder: (_) => _buildDialog(context, _itemForMessage(message)),
).then((bool shouldNavigate) {
if (shouldNavigate == true) {
_navigateToItemDetail(message);
}
});
}
void _navigateToItemDetail(Map<String, dynamic> message) {
final Item item = _itemForMessage(message);
// Clear away dialogs
Navigator.popUntil(context, (Route<dynamic> route) => route is PageRoute);
if (!item.route.isCurrent) {
Navigator.push(context, item.route);
}
}
@override
void initState() {
super.initState();
_firebaseMessaging.configure(
onMessage: (Map<String, dynamic> message) async {
print("onMessage: $message");
_showItemDialog(message);
},
onBackgroundMessage: myBackgroundMessageHandler,
onLaunch: (Map<String, dynamic> message) async {
print("onLaunch: $message");
_navigateToItemDetail(message);
},
onResume: (Map<String, dynamic> message) async {
print("onResume: $message");
_navigateToItemDetail(message);
},
);
_firebaseMessaging.requestNotificationPermissions(
const IosNotificationSettings(
sound: true, badge: true, alert: true, provisional: true));
_firebaseMessaging.onIosSettingsRegistered
.listen((IosNotificationSettings settings) {
print("Settings registered: $settings");
});
_firebaseMessaging.getToken().then((String token) {
assert(token != null);
setState(() {
_homeScreenText = "Push Messaging token: $token";
});
print(_homeScreenText);
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: const Text('Push Messaging Demo'),
),
// For testing -- simulate a message being received
floatingActionButton: FloatingActionButton(
onPressed: () => _showItemDialog(<String, dynamic>{
"data": <String, String>{
"id": "2",
"status": "out of stock",
},
}),
tooltip: 'Simulate Message',
child: const Icon(Icons.message),
),
body: Material(
child: Column(
children: <Widget>[
Center(
child: Text(_homeScreenText),
),
Row(children: <Widget>[
Expanded(
child: TextField(
controller: _topicController,
onChanged: (String v) {
setState(() {
_topicButtonsDisabled = v.isEmpty;
});
}),
),
FlatButton(
child: const Text("subscribe"),
onPressed: _topicButtonsDisabled
? null
: () {
_firebaseMessaging
.subscribeToTopic(_topicController.text);
_clearTopicText();
},
),
FlatButton(
child: const Text("unsubscribe"),
onPressed: _topicButtonsDisabled
? null
: () {
_firebaseMessaging
.unsubscribeFromTopic(_topicController.text);
_clearTopicText();
},
),
])
],
),
));
}
void _clearTopicText() {
setState(() {
_topicController.text = "";
_topicButtonsDisabled = true;
});
}
}
void main() async {
WidgetsFlutterBinding.ensureInitialized();
FirebaseApp app = await Firebase.initializeApp();
assert(app != null);
runApp(
MaterialApp(
home: PushMessagingExample(),
),
);
}
const functions = require('firebase-functions');
// // Create and Deploy Your First Cloud Functions
// // https://firebase.google.com/docs/functions/write-firebase-functions
//
// exports.helloWorld = functions.https.onRequest((request, response) => {
// response.send("Hello from Firebase!");
// });
const admin = require('firebase-admin');
admin.initializeApp(functions.config().firebase);
const payload = {
'notification': {
'title': 'this is a title',
'body': 'this is a body',
},
'data': {
'click_action': 'FLUTTER_NOTIFICATION_CLICK',
'id': '1',
'status': 'done'
}
};
exports.sendnotification = functions.https.onRequest((request, response) => {
const tokens = request.query.fcm || "Unknown"
response.send("Notification is sent to".concat(tokens));
return admin.messaging().sendToDevice(tokens, payload);
});
Closing in favour of using the latest packages, as mentioned above.
| gharchive/issue | 2020-10-05T20:48:10 | 2025-04-01T06:36:59.370596 | {
"authors": [
"Salakar",
"TahaTesser",
"darshankawar",
"vytautas-pranskunas-"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/3779",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
723221387 | 🐛 [firebase_storage 4.0.1] Can't upload image to firebase in flutter web version, is this possible today? Everything is fine on Android
Bug report
Describe the bug
Overflow on channel: plugins.flutter.io/firebase_storage. Messages on this channel are being discarded in FIFO fashion. The engine may not be running or you need to adjust the buffer size if of the channel.
Error: MissingPluginException(No implementation found for method StorageReference#putData on channel plugins.flutter.io/firebase_storage)
at Object.throw_ [as throw] (http://localhost:55439/dart_sdk.js:4328:11)
at MethodChannel._invokeMethod (http://localhost:55439/packages/flutter/src/services/system_channels.dart.lib.js:942:21)
at _invokeMethod.next (<anonymous>)
at http://localhost:55439/dart_sdk.js:37593:33
at _RootZone.runUnary (http://localhost:55439/dart_sdk.js:37447:58)
at _FutureListener.thenAwait.handleValue (http://localhost:55439/dart_sdk.js:32424:29)
at handleValueCallback (http://localhost:55439/dart_sdk.js:32971:49)
at Function._propagateToListeners (http://localhost:55439/dart_sdk.js:33009:17)
at _Future.new.[_completeWithValue] (http://localhost:55439/dart_sdk.js:32852:23)
at async._AsyncCallbackEntry.new.callback (http://localhost:55439/dart_sdk.js:32874:35)
at Object._microtaskLoop (http://localhost:55439/dart_sdk.js:37708:13)
at _startMicrotaskLoop (http://localhost:55439/dart_sdk.js:37714:13)
at http://localhost:55439/dart_sdk.js:33226:9
Steps to reproduce
mydependencies:
dependencies:
flutter:
sdk: flutter
cloud_firestore: ^0.14.1+2
firebase_core: ^0.5.0+1
cloud_functions: 0.7.0-dev.2
firebase_storage: ^4.0.1
firebase_auth: ^0.18.1+1
index.html:
<script src="https://www.gstatic.com/firebasejs/7.14.4/firebase-app.js"></script>
<script src="https://www.gstatic.com/firebasejs/7.14.4/firebase-firestore.js"></script>
<script src="https://www.gstatic.com/firebasejs/7.14.4/firebase-auth.js"></script>
<script src="https://www.gstatic.com/firebasejs/7.14.4/firebase-functions.js"></script>
<script src="https://www.gstatic.com/firebasejs/7.14.4/firebase-storage.js"></script>
my code:
class WebImagePicker implements ImagePickerUniversal {
Future<Map<String, dynamic>> pickImage() async {
Map<String, dynamic> data = {};
final html.FileUploadInputElement input = html.FileUploadInputElement();
input..accept = 'image/*';
input.click();
await input.onChange.first;
if (input.files.isEmpty) return null;
final reader = html.FileReader();
reader.readAsArrayBuffer(input.files[0]);
await reader.onLoad.first;
final encoded = reader.result as Uint8List;
final imageName = input.files?.first?.name;
data.addAll({'name': imageName, 'file': encoded, 'museumDir': 'Иванов'});
StorageRefere
Firebase Storage currently doesn't support Web functionality. I'd advise you to use Firebase Dart plugin for web. It has all the functionality you need.
Hi @Fitz1991
As stated above, there is no web yet in firebase_storage package
https://github.com/FirebaseExtended/flutterfire/issues/1972
Closing as duplicate
Thank you
| gharchive/issue | 2020-10-16T13:24:08 | 2025-04-01T06:36:59.375860 | {
"authors": [
"Fitz1991",
"TahaTesser",
"Tihan-Nico"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/3882",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
821830336 | 🐛 [firebase_analytics] Firebase analytics web dependency problem
Firebase analytics WEB dependency problem. Need to update WEB dependency from firebase to latest version
Firebase analytics WEB depends on firebase ^7.3.0 (latest is 9.0.0)
firebase ^7.3.0 depends on http >=0.11.3 <0.13.0
And I am using http 0.13.0
If someone can, please update version of firebase in analytics_web to latest (null safe) version. Thanks.
I don't use web version, if there is any way to exclude web version, please, let me know.
Same issue here.
@dukaric1991 please just add a 👍 instead of adding "same issue here" comments. This just sends unnecessary notifications to everyone subscribed to an issue. Thanks :)
Because every version of firebase_analytics_web depends on firebase ^7.3.0 which depends on http >=0.11.3 <0.13.0, every version of firebase_analytics_web requires http >=0.11.3 <0.13.0.
And because firebase_analytics >=7.1.0 depends on firebase_analytics_web ^0.2.0, firebase_analytics >=7.1.0 requires http >=0.11.3 <0.13.0.
Important issue.
any temporary solution for this?
Hi @Zeynal7
I see there's an open issue addressing the case you described https://github.com/FirebaseExtended/flutterfire/issues/5202.
Please follow up on that issue, I'm closing the current one as a duplicate.
If you disagree, please write in the comments and I will reopen it.
Thank you
| gharchive/issue | 2021-03-04T07:06:52 | 2025-04-01T06:36:59.381558 | {
"authors": [
"NebiSarigul",
"Zeynal7",
"bhagirath",
"cbenhagen",
"dsgriffin",
"dukaric1991",
"markusaksli-nc"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/5210",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
1681912840 | 🛑 Liga Ardyti is down
In 45fe7db, Liga Ardyti (https://ligaardyti.com.ar) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Liga Ardyti is back up in a8091f0.
| gharchive/issue | 2023-04-24T19:45:55 | 2025-04-01T06:36:59.392099 | {
"authors": [
"gorositopablo"
],
"repo": "FirenzeDigital/upptime",
"url": "https://github.com/FirenzeDigital/upptime/issues/93",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1507917610 | 🛑 Schools project is down
In d768c1a, Schools project (http://schools.fitzmuseum.cam.ac.uk) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Schools project is back up in 7349957.
| gharchive/issue | 2022-12-22T13:46:06 | 2025-04-01T06:36:59.394462 | {
"authors": [
"portableant"
],
"repo": "FitzwilliamMuseum/uptime",
"url": "https://github.com/FitzwilliamMuseum/uptime/issues/416",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1524346775 | Fact results inaccurate (distro module issue)?
Describe the bug
This could be a me issue (I am a neophyte to pyinfra). I have several "older Linux distributions" under my care. When running pyinfra inventory.py fact server.LinuxDistribution, the facts returned for these servers match the host I'm running pyinfra from, not the target. Although the files appear to be returned successfully, the distro module is unable to interpret correctly (see the following output):
$ pyinfra -vvv inventory.py fact server.LinuxDistribution
--> Loading config...
--> Loading inventory...
--> Connecting to hosts...
[server1] Connected
[server2] Connected
--> Gathering facts...
[server2] >>> sh -c 'cd /etc/ && for file in $(ls -pdL *-release | grep -v /); do echo "/etc/${file}"; cat "/etc/${file}"; echo ---; done'
[server1] >>> sh -c 'cd /etc/ && for file in $(ls -pdL *-release | grep -v /); do echo "/etc/${file}"; cat "/etc/${file}"; echo ---; done'
[server1] /etc/lsb-release
[server1] DISTRIB_ID=Ubuntu
[server1] DISTRIB_RELEASE=9.10
[server1] DISTRIB_CODENAME=karmic
[server1] DISTRIB_DESCRIPTION="Ubuntu 9.10"
[server1] ---
[server1] Loaded fact server.LinuxDistribution
[server2] /etc/centos-release
[server2] CentOS release 6.10 (Final)
[server2] ---
[server2] /etc/redhat-release
[server2] CentOS release 6.10 (Final)
[server2] ---
[server2] /etc/system-release
[server2] CentOS release 6.10 (Final)
[server2] ---
[server2] Loaded fact server.LinuxDistribution
--> Fact data for: server.LinuxDistribution
{
"server1": {
"name": "Debian",
"major": 11,
"minor": null,
"release_meta": {
"PRETTY_NAME": "Debian GNU/Linux 11 (bullseye)",
"NAME": "Debian GNU/Linux",
"VERSION_ID": "11",
"VERSION": "11 (bullseye)",
"VERSION_CODENAME": "bullseye",
"ID": "debian",
"HOME_URL": "https://www.debian.org/",
"SUPPORT_URL": "https://www.debian.org/support",
"BUG_REPORT_URL": "https://bugs.debian.org/",
"CODENAME": "bullseye"
}
},
"server2": {
"name": "Debian",
"major": 11,
"minor": null,
"release_meta": {
"PRETTY_NAME": "Debian GNU/Linux 11 (bullseye)",
"NAME": "Debian GNU/Linux",
"VERSION_ID": "11",
"VERSION": "11 (bullseye)",
"VERSION_CODENAME": "bullseye",
"ID": "debian",
"HOME_URL": "https://www.debian.org/",
"SUPPORT_URL": "https://www.debian.org/support",
"BUG_REPORT_URL": "https://bugs.debian.org/",
"CODENAME": "bullseye"
}
}
}
The result should definitely not be Debian 11 for a Centos 6 and Ubuntu 9.04 (I did say they were old) servers. While I'm not expecting facts to necessarily identify these older servers, defaulting to the underlying host's OS is unexpected behaviour.
To Reproduce
$ pyinfra inventory.py fact server.LinuxDistribution
(where inventory.py points to a couple of archaic distributions).
Host is an up to date Debian 11 laptop.
Expected behavior
Either undefined (if distro module was unable to find an appropriate match), or the appropriate response.
Meta
Include output of pyinfra --support.
--> Support information:
If you are having issues with pyinfra or wish to make feature requests, please
check out the GitHub issues at https://github.com/Fizzadar/pyinfra/issues .
When adding an issue, be sure to include the following:
System: Linux
Platform: Linux-5.10.0-20-amd64-x86_64-with-glibc2.31
Release: 5.10.0-20-amd64
Machine: x86_64
pyinfra: v2.6
Executable: /home/dt/Work/pyinfra/venv/bin/pyinfra
Python: 3.9.2 (CPython, GCC 10.2.1 20210110)
How was pyinfra installed (source/pip)?
Via pip in venv.
Consider including output with -vv and --debug.
As noted above
Additional info
Version of distro is v1.8.0. Output captured while debugging from distro's return result (note: showing os_release_file pointing inappropriately to the localhost's /usr/lib/os-release):
LinuxDistribution(os_release_file='/usr/lib/os-release', distro_release_file='/tmp/tmpis7_en3u/etc/centos-release', include_lsb=False, include_uname=False, include_oslevel=True, root_dir=None, _os_release_info={'pretty_name': 'Debian GNU/Linux 11 (bullseye)', 'name': 'Debian GNU/Linux', 'version_id': '11', 'version': '11 (bullseye)', 'version_codename': 'bullseye', 'id': 'debian', 'home_url': 'https://www.debian.org/', 'support_url': 'https://www.debian.org/support', 'bug_report_url': 'https://bugs.debian.org/', 'codename': 'bullseye', 'release_codename': 'bullseye'}, _lsb_release_info={}, _distro_release_info={'name': 'CentOS', 'version_id': '6.10', 'codename': 'Final', 'id': 'centos'}, _uname_info={}, _oslevel_info='')
Additional additional info
I am enjoying pyinfra much more than Ansible (irrespective of this issue :) )
So, poking at this further (as such is my wont), it appears that patching distro._UNIXCONFDIR as pyinfra currently does breaks the result of distro.LinuxDistribution() since at least distro v1.6.0 when the root_dir named parameter was introduced. With the attached test script, you can see the difference in the return result (using the files returned by Centos 6 fact retrieval) when using the patched distro._UNIXCONFDIR variable versus using the named root_dir parameter. The fix is relatively simple, but I'm not sure what (if anything) this would break. At a bare minimum, distro would need to be pinned >= 1.6.0 for the root_dir named parameter to work, but given that the distro package was moved subordinate to distro in v1.7.0 (i.e. from distro import distro) this would need to be done anyway.
new_rootdir_distro:
{'id': 'centos',
'major': 6,
'minor': 10,
'name': 'CentOS',
'release_meta': {}}
old_rootdir_distro:
{'id': 'debian',
'major': 11,
'minor': None,
'name': 'Debian '
'GNU/Linux',
'release_meta': {'BUG_REPORT_URL': 'https://bugs.debian.org/',
'CODENAME': 'bullseye',
'HOME_URL': 'https://www.debian.org/',
'ID': 'debian',
'NAME': 'Debian '
'GNU/Linux',
'PRETTY_NAME': 'Debian '
'GNU/Linux '
'11 '
'(bullseye)',
'SUPPORT_URL': 'https://www.debian.org/support',
'VERSION': '11 '
'(bullseye)',
'VERSION_CODENAME': 'bullseye',
'VERSION_ID': '11'}}
distro_test.py.txt
Thank you for digging into this @handcraftedcomputers - indeed it looks like there's another variable that needs patching to cover this, but I think it's a good time to bump the minimum version up to 1.6 and remove the patching hack entirely.
Made this change: https://github.com/Fizzadar/pyinfra/commit/06d61c9e9fb6980228afe02cec44a3f8cd815a1a.
Fix was released in 2.6.2!
| gharchive/issue | 2023-01-08T06:03:56 | 2025-04-01T06:36:59.408971 | {
"authors": [
"Fizzadar",
"handcraftedcomputers"
],
"repo": "Fizzadar/pyinfra",
"url": "https://github.com/Fizzadar/pyinfra/issues/939",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.