id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
1950715052
|
[$500] Update all selectors to use new format for selected participant
Follow up from https://github.com/Expensify/App/pull/29903
In https://github.com/Expensify/App/issues/29836, we updated the flow for the group chat / split bill flow to hide the selected participants when we are searching for a user. We'll need to update the flow for all selectors to use that same format
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01b5750587ffb7e229
Upwork Job ID: 1714778343126532096
Last Price Increase: 2023-11-08
Waiting to add external until the linked PR is merged
I can work on this asap
We're still looking for proposals in the standard format
@abdulrahuman5196, can review @dukenv0307 's proposal above plz?
Yup, please review the proposal and work with Duke to update if there are any issues with it and then we can move to PR
@dukenv0307 I think still we expect a formatted proposal as always even though you would get dibs here. We should still add some missing pieces in the proposal like below.
There're some that use canSelectMultiple that already work fine (does not use getOptions) like in WorkspaceMembersPage, we can evaluate them during the PR process.
We should provide information on this. This is not a straightforward forward change in my opinion.
Like do we make it to migrate to getOptions or like update existing functions in WorkspaceMembersPage to behave like the new selection mechanism?
Pass the includeSelectedOptions as true in the getOptions that gets the options for those places, similar to here
Only push the participants section if search term is empty, similar to here
And we should also provide information on what pages/code are these which needs to be updated?
Melvin we had just posted update before weekend and back from weekend
@dukenv0307 can you please address @abdulrahuman5196 's comments in their post above?
Will review update today
For this I mean in those places it's already working fine according to expected behavior, so no change needed. It's already filtering out the selected options if those do not match the search query. Only the pages that are using getOptions has the issue.
@dukenv0307 Workspace invite page doesn't behave the expected way. We might need to fix this in different way.
Being discussed above.
@dukenv0307 ? Any update on the question above?
@abdulrahuman5196 , what do we need in order to hire someone here?
Let me check on the latest response and update here
Hi, Will review again today, just back from weekend
Hi, I think this issue has been held long on discussions. Since @dukenv0307 already have dibs on assignment here with proposal here https://github.com/Expensify/App/issues/29916#issuecomment-1769762909. I think its fine to move to PR phase and clarify any questions there since I think only minor concerns are pending.
🎀 👀 🎀
C+ Reviewed
@thienlnam looks like you were already assigned, not sure why it assigned someone else. Leaving it to you 😁
Not overdue melvin, we just assigned the contributor
What's the update here @abdulrahuman5196?
Hi, Will be reviewing the PR again today.
Go to a room/WS and open the Memember page
Click Invite and choose some users
Verify that you see them at the top
Start searching for a user and verify only the participants matching the selection is shown in the list, whereas the selected participants matching the search is shown at top and the rest matching the search is followed
When there is no search, all the selected participants should show at the top and the rest following them.
@mallenexpensify
Contributor: @dukenv0307 paid $500 via Upwork
Contributor+: @abdulrahuman5196 paid $500 via Upwork
TestRail update steps GH created https://github.com/Expensify/Expensify/issues/359909
Thanks @abdulrahuman5196
|
gharchive/issue
| 2023-10-18T21:40:12 |
2025-04-01T04:55:03.706937
|
{
"authors": [
"abdulrahuman5196",
"abzokhattab",
"flodnv",
"mallenexpensify",
"thienlnam"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/29916",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2014594981
|
[$500] Unexpected Redirection to DM with Concierge Instead of #admins Chat When Selecting Setup Specialist Option
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.3-11
Reproducible in staging?: No
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): dcardoza@Expensify.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation: https://expensify.slack.com/archives/C03U7DCU4/p1700167866247689
Action Performed:
Created an Account davidexpensifytesting@gmail.com
Created a workspace
Selected the 'Setup Specialist' option in the LHN under Support.
Closed the NewDot application.
Navigated back to Expensify.com
Selected the 'Setup Specialist' option in the LHN under Support.
Redirected to a NewDot DM with Concierge.
Expected Result:
Expectation to be redirected to the #admins chat when selecting the option to chat with a Setup Specialist.
Actual Result:
Instead of being directed to the #admins chat, was placed into a Direct Message with Concierge.
Workaround:
Currently, no workaround is identified. The user's expectation to enter the #admins chat when selecting the Setup Specialist option is not met.
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~012157b2ec7d06ca6e
Upwork Job ID: 1729509966477643776
Last Price Increase: 2023-11-28
Is there a way to create fake Expensify card transactions so I can try to reproduce this bug?
No worries, @junsupark94! I've done that many many times 😅
Waiting for proposals.
@davidcardoza @johncschuster
could you please explain how to select 'Setup Specialist' option in the LHN under Support. please?
There is no video attached to the issue. Could you please add some so we could see exact steps to reproduce?
I think the implication that the first steps are in newDot might be incorrect, as there isn't any Setup Specialist option or a Support menu in the LHN on newDot.
Though I can't reproduce this specific issue of being redirected to concierge, I do get redirected to a not found page. Here's what I'm doing:
You need an account that has access to oldDot and that has at least one workspace created in newDot
Login to oldDot
Switch to a workspace that was created on newDot
Select the 'Setup Specialist' option in the LHN under Support
https://github.com/Expensify/App/assets/27287420/1890800d-cc9b-4f0d-bd6d-f35861aceb90
@jjcoffee I think this bug is not related to new dot. We should add internal label
Agreed, there's an exitTo param in the link that oldDot generates, that for me points to a report that I don't have access to. I guess the redirecting to concierge has a similar root cause. Let's make this internal @johncschuster.
@davidcardoza It looks like this might be an issue with OldDot. I'm OOO Monday, December 18 (today) through Tuesday, January 2, so I won't be able to push to advocate for this bug. Would you mind raising this up internally so we can get it fixed?
If this issue is open when I'm back from OOO, I'll take it back over. Thank you!
Issue not reproducible during KI retests. (First week)
Happily moving to be internal, not working on this for now since last tests were not reproducible
Same as ^
I can't seem to reproduce this again. I am going to go ahead and close.
|
gharchive/issue
| 2023-11-28T14:37:34 |
2025-04-01T04:55:03.722870
|
{
"authors": [
"Beamanator",
"DylanDylann",
"davidcardoza",
"jjcoffee",
"johncschuster",
"junsupark94",
"keisyrzk",
"mvtglobally"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/32128",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2053213177
|
[$500] IOU - Can't download receipt image
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.15.1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Navigate to https://staging.new.expensify.com/
Navigate to a workspace chat
Go offline
Do a scan IOU
Download the image
Expected Result:
I should be able to download it
Actual Result:
Can't download the receipt image
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/5d116036-7648-453d-952e-ce43cb0752e8
View all open jobs on GitHub
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can not download receipt when offline
What is the root cause of that problem?
When we offline the image doest not upload to S3 show the source file is local but we have isAuthTokenRequired is true, so the URL has a encryptedSourceUrl. That is wrong
We do not return the isLocalFile here so isAuthTokenRequired is true.
https://github.com/Expensify/App/blob/659f509b7e1093252d7c2ea14d0082ee78dd6503/src/libs/ReceiptUtils.ts#L45-L49
What changes do you think we should make in order to solve the problem?
We shouldupdate
const isLocalFile = path.startsWith('blob:') || path.startsWith('file:');
return {thumbnail: null, image: path, isLocalFile };
What alternative solutions did you explore? (Optional)
@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow
@shubham1206agra what do you think of @namhihi237's proposal? Is this a fairly simple change? I think it would be ideal for this to work, but this feels like a fairly unusual flow for someone to follow
Actually, it can be quite common for someone to follow this route. Example is what if I clicked the image of a receipt, and I just want a copy of the image in my local storage too. Then this flow can be followed
@namhihi237's proposal looks good to me.
🎀👀🎀 C+ reviewed
Sent offers via Upwork. @shubham1206agra could you please complete the BZ checklist?
@sakluger accepted
Thanks @namhihi237! I completed your payment.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30747/files#r1450354884
[x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required
[x] [@shubham1206agra] Determine if we should create a regression test for this bug. No as this is an edge case missed by ttps://github.com/Expensify/App/pull/30747
[x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
@sakluger Checklist done
Thank you! All paid out 👍
|
gharchive/issue
| 2023-12-22T00:35:58 |
2025-04-01T04:55:03.740434
|
{
"authors": [
"bfitzexpensify",
"lanitochka17",
"namhihi237",
"sakluger",
"shubham1206agra"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/33474",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2059341904
|
[$500] Task – Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:
Go to https://staging.new.expensify.com/
Log in with any account.
Create a task in the Room
Log is as another participant of the Room
Open the Task in the Room and canceled it
Navigate to the 1:1 DM with Task creator
Expected Result:
Deleted task in a Room disappears from 1:1 DM and Task name is not visible in LHN when Canceled Task as Room user
Actual Result:
Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN when Canceled Task as Room user
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/3610a08b-b53a-4fe7-b928-12afbd14cb64
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~015bc9d71fb41f159d
Upwork Job ID: 1740694664378986496
Last Price Increase: 2023-12-29
Proposal
Please re-state the problem that we are trying to solve in this issue.
Deleted task in a Room not disappears from 1:1 DM and Task name is visible in LHN.
What is the root cause of that problem?
We are currently setting the lastMessage to the last message of the parent report here
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L757-L758
What changes do you think we should make in order to solve the problem?
There is a backend job required but for the optimistic data. We should change lastMessage to task deleted task title
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L757-L758
to
lastMessageText: message
as we did here
https://github.com/Expensify/App/blob/7d1b0f8b99616c48aedb975dd73fc3086c9f20e3/src/libs/actions/Task.js#L748-L749
What alternative solutions did you explore? (Optional)
I just read your issue
I think this issue is very simple
If you click cancel button, this action dispatch the event that the status of task would changed as delected
And on frontend side, it doesn't display tasks that the status is delected, so, If you want to see the deleted tasks, you can change code so that shows delete tasks.
I think backend issue, we do not push delete the message in the reportAction.
Is this #vip-split worthy @GabiHExpensify ?
Friendly bump @GabiHExpensify 🙇
Closing as non-urgent and not clearly tied to a wave at this point
|
gharchive/issue
| 2023-12-29T11:22:00 |
2025-04-01T04:55:03.754138
|
{
"authors": [
"FitseTLT",
"MitchExpensify",
"izarutskaya",
"namhihi237",
"skydragon0324"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/33749",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2106705254
|
[$500] Bank account - On selecting "I accept expensify terms", error not displayed for "Account number"
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.33
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4251914
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Go to https://staging.new.expensify.com/
Tap profile icon
Tap workspaces--- Workspace
Tap Bank Account
Tap Connect manually
Select "I accept expensify terms"
Expected Result:
When user select "I accept expensify terms", error must be displayed for both "Routing number" & "Account number"
Actual Result:
Error displayed for "Routing number" but not shown for "Account number" when user select "I accept expensify terms".
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/cb3c8d6c-beb9-47e3-b651-e4d538f54300
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~019df4e12cd288976c
Upwork Job ID: 1752123886122000384
Last Price Increase: 2024-01-30
We only show errors for fields that are touched, since the first one is focused it's marked as touched.
The account number is never touched so it won't show the error yet.
Agreed. This is not a bug.
Hm, but if the user clicks out of the routing number field, we will still show an error there, no?
Hm, personally I think this is fine and not worth changing anything now.
Hm, but if the user clicks out of the routing number field, we will still show an error there, no?
@joekaufmanexpensify Yes, if the user proactively blurs the routing number field, it will still show an error and blur the routing number input.
But on native Android/iOS if we toggle the checkbox, the input won't be blurred and no error will show, I think that makes more sense (allowing the users to continue to type on the inputs right after the user toggles the checkbox, less manual action from user) and we should do the same for mWeb/web.
Based on what you shared I actually think native has a bug to not trigger the validation.
If they follow the order of the list as we present it to the user:
fill out account number
tap Routing, and account number gets validated
fill out routing number incorrectly
tap 'i accept term'
here it should validate the routing number
So that I can be informed of whether or not I can 'Continue'
I'm not sure I understand the report. If you follow the 4 steps you listed above we do throw an incorrect routing number error.
I'm not sure I understand the report. If you follow the 4 steps you listed above we do throw an incorrect routing number error.
The report is describing how I think it should be behaving, which is how web is handling!
However if you look at the video from https://github.com/Expensify/App/issues/35345#issuecomment-1917227581 they actually demonstrate this being broken in native. Since clicking I accept does not trigger validation.
|
gharchive/issue
| 2024-01-30T00:17:39 |
2025-04-01T04:55:03.768116
|
{
"authors": [
"jeremy-croff",
"joekaufmanexpensify",
"lanitochka17"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/35345",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2136516572
|
[HOLD for payment 2024-05-22] [HOLD for payment 2024-05-20] [HelpDot] Link this issue to auto assign Rushat for a review.
When creating a PR, link this issue so that I'm auto assigned for a review.
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@lschurr you may unassign to avoid pings
@maddylewis could you please assign me this issue
@JmillsExpensify I think payment happens in the separate payment issues and the automation is incorrect here.
Checking what's going on with this on in slack
@garrettmknight this is the issue for payment - https://github.com/Expensify/App/issues/32825
It has the necessary payment details
This issue is created only for the purpose of auto-assigning me for reviews.
Ok cool. I'm going to close this issue then.
I think I'm getting all PR reviews assigned me to because I am assigned on this GH 🤔. That isn't necessarily a problem, but I do think it'd be better to round-robin the reviews via PullerBear so I'm going to unassign.
@amyevans could you please reopen the issue
Why can't it rely on PullerBear? 😄
does it work on closed issues?
I think it will just assign a random internal engineer on the PR review (according to PullerBear logic, which is based on lowest number of reviews), but if it ends up not working we can reassess!
not a bug, no checklist needed.
Is this issue complete? It is not showing up in my K2; I just got an email about it to check in.
I think the Expensify Help stuff is still going on, right?
|
gharchive/issue
| 2024-02-15T13:24:54 |
2025-04-01T04:55:03.773806
|
{
"authors": [
"JmillsExpensify",
"amyevans",
"dangrous",
"garrettmknight",
"rushatgabhane"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/36581",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2308587128
|
[Payment card / Subscription] Implement - Integrate 3ds flow with Backend data
Design doc
Issue OwnerCurrent Issue Owner: @waterim
Hi, I'm Eugene from Callstack - an expert agency - and I would like to work on this issue.
Not yet ready for work
Reassigning to @blimpich since I'm headed out on extended leave after today
@waterim you're combining this issue with https://github.com/Expensify/App/issues/42432 right? Can you comment so we can assign you here to track.
Hello, yes, Im combining this issue with UI issue!
Add @Pujan92 as they are reviewing the PR
Shall we just close this issue, as we're building it in one PR and we can use this issue: https://github.com/Expensify/App/issues/42432
Yes, lets do that for sake of simplicity.
|
gharchive/issue
| 2024-05-21T15:38:08 |
2025-04-01T04:55:03.778018
|
{
"authors": [
"amyevans",
"blimpich",
"pasyukevich",
"trjExpensify",
"waterim"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/42433",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2319807933
|
[HOLD for payment 2024-07-10] Android & iOS - Tags - "Enabled" badge is not crossed out when tag is deleted offline
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.76-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4578912
Issue reported by: Applause - Internal Team
Action Performed:
Launch New Expensify app
Go to workspace settings
Go to Tags
Add a tag if there is no tag
Go offline
Delete the tag
Expected Result:
The "Enabled" badge will be crossed out when tag is deleted offline (web behavior)
Actual Result:
The "Enabled" badge is not crossed out when tag is deleted offline
This issue also applies to categories, distance rates and tax rates
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/dcd0e5b0-83c7-432e-8a93-9445718ef359
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @JmillsExpensify
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
Proposal
Please re-state the problem that we are trying to solve in this issue.
Enabled badge of the right component is not crossed out when deleting a tag while offline.
What is the root cause of that problem?
The crossed out style is applied from OfflineWithFeedback. OfflineWithFeedback will give the component a deleted style.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/OfflineWithFeedback.tsx#L116-L118
However, the Enabled badge component itself doesn't accept any style props.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L14
So, the deleted style is never applied to it.
What changes do you think we should make in order to solve the problem?
Add a style prop to ListItemRightCaretWithLabel and append it to the label text style here.
https://github.com/Expensify/App/blob/2514f2988eb26858d30fa501c0040b1f8fc2e239/src/components/SelectionList/ListItemRightCaretWithLabel.tsx#L20
Opening up to the community.
Still waiting for proposal review. cc @DylanDylann
This issue only reproduces on the native app. I think the RCA will be more complicated than the above proposals
However, the children recursive search logic will not work in case the Text is nested inside another custom component like the Badge here. In this case, when iterating here, the children of Badge element will be undefined, because children only works for elements directly exposed inside the children of OfflineWithFeedback.tsx. This leads to the Text (a child in Badge structure) not having the strike-through style applied.
@tienifr Thanks for this point. But it is still grey to me, I will need some time to dive deep into this problem. It would be great if you could detail more
Issue not reproducible during KI retests. (First week)
@mvtglobally I still reproduce on IOS
Update: I am still deep diving into @tienifr's proposal. This bug is specific to native device
@Krishna2323 @bernhardoj Your RCA isn't correct to me because we implement the recursive logic to apply strike-through to child components (read @tienifr's proposal for more detail)
@tienifr Thanks for your detail. But It is still grey to me. In TableListItem Component, we still TextWithTooltip (it is a custom component) but it still be greyed out
I would prefer @tienifr's proposal. Let's go with them
@tienifr mind filling out the BZ checklist? I confirm the $250 payment summary above is correct for both contributors.
@DylanDylann shall I create an Upwork job/contract for you?
@JmillsExpensify Yes please!
@DylanDylann offer sent!
Reminder on the Upwork contract!
@JmillsExpensify Sure thing, I accepted the offer, TY
All paid out! @tienifr I'm going to close this issue for now, though before you submit an expense via New Expensify, please make sure to complete the BZ checklist.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Go to workspace settings
Go to Tags
Add several tags if there is no tag
Go offline
Delete the tags
Verify the tag and "Enabled" badge will be crossed out when the tag is deleted offline
Go online
Verify the tags disappear
Do we agree 👍 or 👎
Ah thanks! I'll re-open this one.
@mallenexpensify would you mind double-confirming payment summary before I approve payment?
Contributor: @DylanDylann paid $250 via Upwork
Contributor+: @tienifr owed $250 via NewDot
$250 approved for @tienifr
|
gharchive/issue
| 2024-05-27T21:40:40 |
2025-04-01T04:55:03.800555
|
{
"authors": [
"DylanDylann",
"JmillsExpensify",
"bernhardoj",
"lanitochka17",
"mallenexpensify",
"mvtglobally"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/42673",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2344197033
|
[$250] Unable to load chats and continuous loading appears
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.81-1
Reproducible in staging?: need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @davidcardoza
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1718027588707529 and https://expensify.slack.com/archives/C05LX9D6E07/p1718026564489519
Action Performed:
Open the staging app from the TestFlight
Expected Result:
Chats should be loading
Actual Result:
infinite loading appears
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/Expensify/App/assets/38435837/a5974e1e-f9e0-4907-9e35-84861ee56a55
https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("8919b878fae44188-LHR")+AND+timestamp:[2024-06-10T12:31:14.825Z+TO+2024-06-10T14:31:14.825Z]&index=logs_expensify-028863
logs-2024-06-10 13_35_46.937 (1).txt
App_Info_1.4.79-11 (1).json
Profile_trace_for_1.4.79-11 (1).cpuprofile
https://github.com/Expensify/App/assets/38435837/55e0dde2-0083-45c8-8fa0-9ffdb9826f87
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~01b75a1eb219ec6562
Upwork Job ID: 1801371992691489778
Last Price Increase: 2024-06-13
Issue OwnerCurrent Issue Owner: @rojiphil
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
We are removing all AMs as admins from workspaces - I think that might be the fix. We'll test again once that is complete.
This has been spotty - let's see if it can get reproduced in the next couple of weeks.
moving to weekly to correspond with testing
I'm still not able to reproduce this - closing
|
gharchive/issue
| 2024-06-10T15:22:48 |
2025-04-01T04:55:03.813108
|
{
"authors": [
"MelvinBot",
"m-natarajan",
"slafortune"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/43387",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2497879313
|
[$250] Invoice - Default workspace avatar is displayed for invoice receiver when it has custom avatar
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.26-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4864174
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:
Precondition:
Workspace has custom avatar.
Go to staging.new.expensify.com
Go to FAB > Send invoice.
Enter amount. select user and send invoice.
As invoice receiver, go to invoice chat.
Expected Result:
Invoice receiver should be able to see the custom workspace avatar.
Actual Result:
Invoice receiver is unable to see the custom workspace avatar. It shows the default avatar instead.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/3c05b551-6bf5-4305-a2a9-38bc189d0262
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Upwork Job URL: https://www.upwork.com/jobs/~014c6b9826c08600f4
Upwork Job ID: 1830746639785190043
Last Price Increase: 2024-09-02
Issue OwnerCurrent Issue Owner: @Pujan92
We think this issue might be related to the #vip-bills
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
Unable to reproduce, throwing a retest on here
I tested on v9.0.26-6 and this issue was reported with Version Number: v9.0.26-5
@Nodebrute , can you outline your reproduction steps? Reckon one of us is doing something different than the other.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Default WS avatar is displayed in invoice room if the user isn't part of the workspace.
What is the root cause of that problem?
When user A sends an invoice to user B from a workspace that user B is not a member of, the policy data will be undefined. When we are trying to get the workspace icon,
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L2246-L2250
we already prioritize the avatar from report.policyAvatar. However, the icon is still wrong and it happens after we introduce the caching in https://github.com/Expensify/App/pull/46886.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1937-L1948
The caching somehow saves the default avatar for the workspace. Here is the logic to decide whether we can get the avatar from the cache or need to save it to the cache or not.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1925-L1934
The first condition is of course to make sure the cache exists. Second, it checks whether the cached image source and the policy avatar source are the same or not. We will focus on the second condition.
As mentioned above, if the user isn't part of the WS, then the policy data will be undefined, so, the avatarURL is undefined (because we don't use report.policyAvatar here) and the isSameAvatarURL condition is always false. This means, we never get the source from the cache and keep setting a new object to the cache, even though the final value is the same.
It still works fine until the report passed to the function (getWorkspaceIcon) has the same policyID (which means the same cache key) but missing policyAvatar.
If the policyAvatar is missing, a default WS avatar will be saved to the cache.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1939
And because it's a default avatar, we will return it from the cache.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1930-L1934
What changes do you think we should make in order to solve the problem?
First, we need to solve the issue where we never use the cache if the policy is undefined by using report?.policyAvatar when comparing the cache source. To do that, we can replace avatarURL with policyAvatarURL (we can even use policyExpenseChatAvatarSource so we can remove isDefaultWorkspaceAvatar condition too).
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/libs/ReportUtils.ts#L1927-L1937
Next, to avoid saving default avatar when policyAvatar is missing, we can return the cache if policyAvatar is undefined.
if (iconFromCache && (isSameAvatarURL || isDefaultWorkspaceAvatar || report?.policyAvatar === undefined) && !hasWorkSpaceNameChanged) {
return iconFromCache.icon;
}
Next, we need to replace getWorkspaceAvatar usage with getWokspaceIcon().source because getWorkspaceAvatar doesn't have the caching and doesn't prioritize report.policyAvatar.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/home/report/ReportActionItemSingle.tsx#L103
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/ReportAvatar.tsx#L27
Last, I notice that the avatar doesn't update immediately, so we need to update report action item memo to compare for report.policyAvatar too.
https://github.com/Expensify/App/blob/117b96112b4b2de8ead192c9c1da619edb9860fa/src/pages/home/report/ReportActionItem.tsx#L1010-L1014
@mallenexpensify I can reproduce it by sending an invoice from user A to B using a workspace that user B is not a member of.
@Pujan92 plz attempt reproduction, if you're able to, plz review the proposals above. thx
@Nodebrute's alternative solution of using the cached function only for ReportActionItemSingle won't solve the issue in ReportAvatar screen.
I am more inclined towards @bernhardoj's proposal because of the following reasons.
Get rid of the function getWorkspaceAvatar and use the cached function in all the places.
Fix in the caching logic when the policy is unavailable
🎀👀🎀 C+ reviewed
Looks good to me, thanks!
I keep getting this error when sending an invoice.
Are you in the latest main? Also when sending the company website set it to a real valid url
I was facing the same issue with the Control policy, while creating an invoice with Collect policy worked for me.
I'm still facing an error, but a different one. I'm on latest main and sending from a Collect policy.
Just sent one in a collect policy using https://expensify.com
Would you mind trying that?
Still failed.
Nevermind, it works now after I Clear cache and restart
It's very late here, I'll continue tomorrow!
PR is ready
cc: @Pujan92
Automation didn't work, this is in prod as of 3 days ago https://github.com/Expensify/App/pull/49145#issuecomment-2356867180
Contributor: @bernhardoj due $250 via NewDot
Contributor+: @Pujan92 due $250 via NewDot
@Pujan92 plz complete the BZ checklist.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Requested in ND.
$250 approved for @bernhardoj
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[X] [@Pujan92] The PR that introduced the bug has been identified. Link to the PR: No, we have had this util function getWorkspaceAvatar for a long and the invoice feature was added later. So there isn't any specific PR of causing this bug.
[X] [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[X] [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[X] [@Pujan92] Determine if we should create a regression test for this bug. - Yes
[X] [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Steps
Upload an avatar for workspace W if it is a default avatar currently
As user A, send an invoice to user B from workspace W(user B isn't a member of this workspace)
As user B, verify the custom avatar has been shown in the report details
I agree we should add the step to check the workspace avatar, that can be added to the testrail that caught this bug: https://expensify.testrail.io/index.php?/tests/view/4864174
Thanks @PauloGasparSv and @rlinoz
Test case created
https://github.com/Expensify/Expensify/issues/431500
$250 approved for @Pujan92
|
gharchive/issue
| 2024-08-30T17:44:25 |
2025-04-01T04:55:03.848620
|
{
"authors": [
"JmillsExpensify",
"MelvinBot",
"Pujan92",
"bernhardoj",
"garrettmknight",
"izarutskaya",
"mallenexpensify",
"rlinoz"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/48358",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2637614617
|
[HOLD for payment 2024-12-03] [hold] Web - Concierge - Take a 2-minute tour task not autocomplete after finishing tour
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.58.0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Issue was found when executing this PR: https://github.com/Expensify/App/pull/51153
Issue reported by: Applause Internal Team
Action Performed:
Go to https://staging.new.expensify.com/ and log in with a new account
On the onboarding modal select any option other than 'Something else"
Complete the onboarding flow
Navigate to the Concierge chat
Select the Take a 2-minute tour task
Click on the link and finish the tour
Expected Result:
The task is marked complete automatically upon finishing the tour like other Concierge tasks
Actual Result:
The "Take a 2-minute tour" task is not marked complete automatically
Workaround:
Unknown
Platforms:
[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
https://github.com/user-attachments/assets/a25c96b3-1f0b-47c7-9a02-aa39928ecc07
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @OfstadC
#51153 is related to this.
I do agree that it's not a blocker and that it should be handled on the backend for the reasons mentioned above by @c3024.
Waiting for your input @mountiny too
@c3024 @rushatgabhane should be assigned and we should mark this optimistically as completed and call the SelfTourViewed command and update the BE to mark the task as complete too
Didn't have time to focus on it internally as I'm focusing on a #stability issue.
@c3024 you can still raise a frontend PR to set this optimistically in the meantime (see @mountiny's comment above).
If you could do it today that'd be great @rushatgabhane
Raised a PR.
@rushatgabhane @c3024 Please complete thee BZ checklist by EOD so we can issue payment tomorrow
@c3024 Offer sent here
Ooop didn't mean to close this. Still need @c3024 to accept Upwork Offer
@c3024 Could you please accept the offer so we can close this GH out? 😃 Thanks so much!
@OfstadC , sorry for the delayed response. This is part of a project and payment is handled here. No payment in this issue. Thanks!
Ah okay! Thanks for letting me know. I will not issue payment here then 😃
|
gharchive/issue
| 2024-11-06T10:11:01 |
2025-04-01T04:55:03.862393
|
{
"authors": [
"IuliiaHerets",
"OfstadC",
"c3024",
"lakchote",
"mountiny"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/52098",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2750826229
|
List of card-level export accounts are not displayed when using Intacct and vendor bills
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): expense
Action Performed:
Prerequisite: User added a company card
Navigate to company card
Click the added cards to view the details page
Click on export options and select Intacct
Expected Result:
List of card-level export accounts when using Intacct and vendor bills
Actual Result:
List of card-level export accounts are not displayed when using Intacct and vendor bills
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Hi, I’m Nicolay from Callstack and I would like to investigate this issue.
@dukenv0307 can you please complete the checklist and then we can close this to handle the payments
|
gharchive/issue
| 2024-12-19T16:14:42 |
2025-04-01T04:55:03.871733
|
{
"authors": [
"m-natarajan",
"mountiny",
"narefyev91"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/54373",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1021263998
|
Workspace - Desktop - Blank page is displayed after click on the "Invite" button
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Launch App and login
Create a workspace
Navigate to the People
Click on the "Invite" button
Expected Result
Invite new members" page should be open.
Actual Result
The blank page is opened.
Workaround:
Unknown
Platform:
Where is this issue occurring?
Desktop App
Version Number: 1.1.7-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
|
gharchive/issue
| 2021-10-08T16:11:19 |
2025-04-01T04:55:03.878410
|
{
"authors": [
"MelvinBot",
"isagoico"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/5727",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1140907188
|
Feature Request: Add "Are you sure you want to Sign Out?" popup - reported by @dharmik
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Open app and login
Click on Settings > Sign out
Expected Result:
Popup should appear
Are you sure you want to Sign Out?
Yes Or No
Actual Result:
User signed out. Nothing appear
Workaround:
unknown
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: 1.1.39-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dharmik
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643910673108429
View all open jobs on GitHub
Triggered auto assignment to @jboniface (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Thanks for the suggestion! As it was discussed in this Slack thread yesterday, we're not going to proceed with this change at the moment.
I left the thread open for a bit to give a chance to everyone to chime in, and it seems like no one else has anything to say anymore, I'm going to close this.
|
gharchive/issue
| 2022-02-17T05:53:22 |
2025-04-01T04:55:03.887280
|
{
"authors": [
"MelvinBot",
"francoisl",
"mvtglobally"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/7794",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1162293328
|
$1000 - When you edit a comment, the composer stays hidden on other chats - reported by @thesahindia
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Open :expensify: on Mobile
Navigate to a chat
Edit a comment
Navigate to a different chat
Expected Result:
Composer should be visible on other chats or user shouldn't be able to navigate to different chat until he cancels/Save the changes
Actual Result:
Composer is hidden for every chat
Workaround:
unknown
Platform:
Where is this issue occurring?
iOS
Android
Mobile Web
Version Number: 1.1.41-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/157183657-c4c70cbf-047d-438e-9e82-7f90cc0dc139.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1645699620022559
View all open jobs on GitHub
Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.
@thesahindia I'm not sure I follow full here - what do you mean by "edit a comment". Do you mean editing a message that has already been sent?
Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Composer should be visible on other chats or user shouldn't be able to navigate to different chat until he cancels/Save the changes
Got it! So to clarify my understanding, what should be the proper behavior here?
At the moment, the composer stays open after switching to another chat and switching back. I don't see it as a major issue, but I do see three options to make it "better":
Automatically cancel the edit and hide the composer when switching a chat (Slack does this)
Composer should remain visible on other chats (this might be quite confusing)
Prompt the user to save/cancel the chat (e.g. highlight composer box in red and prevent user from switching, a dialog, etc.)
I see 1 as the path forward here- I'm open to any other thoughts!
I like the 2nd option. 1st option is good but there is a drawback. If the user is in the middle of editing and navigates to some other chat then the changes he made will get discarded.
Got it, that makes sense- it should mirror the behavior on the desktop version (which is working properly, just not on mobile). This is clear to me now, apologies for any initial confusion!
So, the report/proposal here is to address the issue where the composer disappears when switching to other chats on mobile 👍 Thanks again for the report- going to add the External label for the next step of the process.
Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.
Upwork Job
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)
Triggered auto assignment to @Beamanator (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Hmm unable to reproduce on mobile web (chrome), latest version - I'll try android
@Beamanator Able to reproduce in mWeb
https://user-images.githubusercontent.com/85645967/158416332-14777a7e-6080-41fb-a308-b6b3c6043e4c.MOV
@Santhosh-Sellavel thanks for the vid, what platform & version are you on?
I just tried on Android, in Chrome browser, v1.1.42-6 and still couldn't reproduce 😅
Waiting on proposals 👍
I guess the interesting thing is:
In web (and Desktop, I assume), when you edit a comment the ReportActionCompose is still showing
In mobile (and mobile web), when you edit a comment the ReportActionCompose disappears even for the chat you're editing
I am guessing this is due to a recent PR, let's see if we can nail that down
In web (and Desktop, I assume), when you edit a comment the ReportActionCompose is still showing
In mobile (and mobile web), when you edit a comment the ReportActionCompose disappears even for the chat you're editing
@Beamanator, I think this is expected, info about it is in https://github.com/Expensify/App/issues/7265
Aha thank you @thesahindia !
@parasharrajat could this issue be a regression of your PR https://github.com/Expensify/App/pull/7390?
Yeah, this is a side-effect from #7390. But I just enabled the flag which was missing from the code. This means this functionality wasn't developed correctly and it had this bug.
Let me check this issue quickly...
Proposal
In ReportScreen's componentWillUnmount call toggleReportActionComposeView(true, true). It will remount the Composer when user closes the report.
The best behavior would be option 1. Where we remount the composer on each report change.
If we do that, what if the user:
Starts editing a comment (so the ReportActionCompose is hidden in that chat)
Navigates to a new chat (now ReportActionCompose should show)
Navigates back to the original chat
In this case wouldn't ReportActionCompose be showing, along with the comment being edited?
Yeah. It will but as soon as the user clicks on the message edit box, the composer hides which is normally happening when you edit a message.
@parasharrajat do you mind testing it and throwing in a short vid to explain what you mean? If I'm understanding correctly the ReportActionCompose will still be showing (in step 3 above) but it will hide if the user clicks in the comment-edit box, which seems like it would result in a weird user experience, maybe I don't understand completely?
Your understanding is correct.
which seems like it would result in a weird user experience
If you feel so then we have to think about an alternative strategy. But I think it is the best fit. On Mobile, we don't focus anything when the report screens loads. There can be multiple draft messages.
Either we remove this feature completely.
Or find something else.
Ok so now I'm thinking this does actually make sense to keep around on mobile because:
When you originally click "Edit comment", you won't be sending a message so it makes sense to hide ReportActionCompose
When you cancel or save your edit, ReportActionCompose comes back (since now you'll be thinking about sending a message)
When you navigate away & come back, you may want to send a message or continue editing, so if you click back in the edit comment box we should hide the ReportActionCompose to make it consistent
I like the idea now, sorry for flip-flopping a bit. @parasharrajat Let's go with your proposal here
📣 @parasharrajat You have been assigned to this job by @Beamanator!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
No worries. I appreciate the clarifying questions. It is actually better to discuss it so we are on the same boat.
Invited to job @parasharrajat
@Beamanator question? What should happen when?
user was editing a message and the composer is hidden.
He goes back to LHN.
Then reopen the same report.
Should the composer be shown or not?
So far, I am only forcing the composer on report change.
Asked here https://expensify.slack.com/archives/C01GTK53T8Q/p1647881926785649
@parasharrajat I think we got the answers we need in Slack, do you have any questions before moving forward with a PR?
I will update the PR by monday.
Thanks ... I like that idea too, I agree it’s not necessary to keep the edit box open when navigating to LHN and back :thumbsup:
@Beamanator Do I need to add this as well?
@parasharrajat Yes we should include the decision made in Slack. Would you mind restating exactly what you plan to do before moving forward with this?
Ok, I found that if we want to close the edit box while going back to LHN, we have to lose the draft messages as well.
Edit box depends on the presence of draft message directly https://github.com/Expensify/App/blob/1ff6625a19f56f9d636edc09a1d2f76d5f7a893c/src/pages/home/report/ReportActionItem.js#L139
Ok, personally I think that's ok because it's just a draft edit
Ok, I will update the PR.
@Beamanator Ok, So there are two ways, I can think of.
I use withReportActionsDrafts HOC on ReportScreen to get all the reportActionsID with keys. Then use WithDrawerState to set those drafts off when the drawer is opened.
Secondly, I can directly use WithDrawerState on the ReportActionItem and reject the draft when the drawer is Opened.
Ok so just to make sure I'm following correctly:
this.props.draftMessage (in ReportActionItem.js) is where we're storing the draft of an edited message (not the draft of a new message)
You're thinking we can just kill a report's draft (probably using Report.saveReportActionDraft, storing null) when the LHN opens up
If this is correct, I'm thinking the second option may be more efficient since we only have to deal with 1 report's draft at a time, what do you think?
Yup, you are correct. But a report can have multiple drafts for actions.
Ok and that's why in your sample code you're looping through all drafts of a specific reportID, which I bet you'd have to do in either case, thanks for reminding me about that 👍
A few more questions related to this change we're thinking about making:
Now that we're planning to get rid of message-edits once a user navigates back to the LHN, do you think it even makes sense to store these in Onyx anymore? A.k.a. if we don't care about message-edit drafts when we switch to a new report, wouldn't we also not care about saving the drafts if the user closes the app, for example?
On large screen devices we won't "open the LHN" ever so to make behavior consistent would we want to kill message-edit drafts if the user changes reports? Or do we want to :donothing: for big screen devices? I'm leaning toward :donothing:
Yeah, good points.
I have a second thought about this change. We are basically removing the drafts feature from the app. Do you think we should take the opinion of a few more people? Let me know if this is the final decision, I will look into your questions as well.
Yeah I was thinking something similar 👍 I agree we should get more opinions, if you could continue the same chain as before but re-send to the channel & maybe tag contributor-management-engineering as well that would be very helpful
New Upwork Job (previous one closed)
Price doubled!
Ping'd CMEs in internal channel to try to get more eyes 👁️
We are basically removing the drafts feature from the app.
I don't think we should do this. If I start editing a message on a chat, and then I need to go reference something from another chat, I want to be able to come back to my draft and continue editing. If I have been editing a message and I go to another chat I should also be able to send messages there. That should be possible right? Is there another case I'm not thinking of?
If I have been editing a message and I go to another chat I should also be able to send messages there. That should be possible right?
Yeah, that is possible.
What should happen when?
user was editing a message and the composer is hidden.
He goes back to LHN.
Then reopen the same report.
Should the composer be shown or not?
If you do this on web / desktop then the composer will be shown, so I think it should match on mobile. In my opinion, we should let the user have the option to continue editing or to send another message. Again that behavior would match desktop. To make that happen I think we should allow the user to unfocus the composer (and dismiss the keyboard) if they click outside of it on mobile. Maybe that's a separate issue.
Left a big comment w/ multiple ideas & ping'd a few more people in Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1651495589126309?thread_ts=1647881926.785649&cid=C01GTK53T8Q
So sorry, I'm new to Expensify and I don't understand what the issue is here. Where in the attached video is something incorrect?
Doubled!
Ping'd the slack channel again to see if anyone can help come to a final decision :D
Bump! Any update?
I'm getting fewer and fewer responses to my posts in slack 😅 I don't feel comfortable moving forward till we have more feedback on the thought so I will tag CMEs and try to get more thoughts
@MitchExpensify I think you can hold off doubling this time please :D Since we don't have a solid way forward yet
Heads up I'm working on this internally in a duplicate issue here and found a pretty simple solution.
I think the correct behavior is that we should hide and show the "composer" only when the edit comment field is focused or blurred.
Has anyone been hired? If not, I think we can just close this one (and the Upwork job) and have @parasharrajat and @Beamanator test my PR linked to the duplicate issue.
@marcaaron I ended up hiring @parasharrajat here: https://github.com/Expensify/App/issues/8031#issuecomment-1073543793
After that, we've been discussing what to do in some other situations (see Slack thread: https://expensify.slack.com/archives/C01GTK53T8Q/p1652268683129369?thread_ts=1647881926.785649&cid=C01GTK53T8Q)
And this has been delayed due to lack of responses, which is why I just brought this to an internal slack channel as well
If you already have a PR up, maybe we can pay @parasharrajat to help test & review it? (I'll help as well)
What is decided here? Should I close my PR?
Yes, want to help us review this solution instead --> https://github.com/Expensify/App/pull/9060
Added you guys there.
Not overdue, PR testing and reviewing in progress
I believe this can be closed b/c the fix was implemented in this PR: https://github.com/Expensify/App/pull/9060
Agree!
Note: I was hired for this issue here and It was decided that this issue will be solve internally and I will review it as C+. Also, I closed my PR for the same.
Yeah, you are correct. Thanks.
@MitchExpensify, the reporting compensation is also pending.
Thanks for the heads up team! I have made a note to issue payment tomorrow as that will be 7 days since the fix was deployed here
Payments made and contract ended - Thanks @parasharrajat & @thesahindia!
|
gharchive/issue
| 2022-03-08T06:58:50 |
2025-04-01T04:55:03.934729
|
{
"authors": [
"Beamanator",
"MelvinBot",
"MitchExpensify",
"Santhosh-Sellavel",
"frenkield",
"laurenreidexpensify",
"marcaaron",
"mvtglobally",
"neil-marcellini",
"parasharrajat",
"robertjchen",
"thesahindia"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/issues/8031",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1822574574
|
Show comment/requests in report preview
Details
cc @JmillsExpensify, @trjExpensify
Fixed Issues
$ https://github.com/Expensify/App/issues/21178
Tests
Log into your account in newdot
Request money from someone else and add a comment while doing so
Confirm the comment immediately shows in the request:
Request money again from the same person.
Confirm that, instead of the comment, the number of requests show immediately:
[x] Verify that no errors appear in the JS console
Offline tests
Same as tests but offline
QA Steps
Same as tests
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android
Yes, this should be ready for review
@abdulrahuman5196 bump!
Sorry for the delay. Will review in couple of hours.
@Gonals
Request count is not updated in the preview if a request is deleted, the preview is only updated when the request is added. I assume it has to do with backend(not sure though). should that be a separate PR?
https://github.com/Expensify/App/assets/46707890/02e79bff-b3c9-41f2-98a4-35181bf43315
@Gonals Request count is not updated in the preview if a request is deleted, the preview is only updated when the request is added. I assume it has to do with backend(not sure though).
Screen.Recording.2023-08-02.at.9.35.02.PM.mov
Nice catch! it is 50-50.
@abdulrahuman5196 I have fixed the frontend here to optimistically update it, but the backend bug remains. Let's ignore it for this PR and I'll fix it in a different issue. Let's see if we can merge today, as I'm OOO staring tomorrow!
@Gonals Got it. I tested now. I think the optimistically updating data is also not complete and in cases I still seeing issues.
Like
Description is not updating in preview if we delete all requests and keep only one request with description
But I am fine with this, given we are planning to create separate bug to address the request count not getting updating on requests deletion/updation. I think it would be best to re-test the optimistic function and backend verification as well in that issue.
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Web
https://github.com/Expensify/App/assets/46707890/0b9b84e7-750d-45b3-ab3e-83f63a04005c
Mobile Web - Chrome
https://github.com/Expensify/App/assets/46707890/49d1eece-7f9f-45d6-95b6-85bf40f5aa34
Mobile Web - Safari
https://github.com/Expensify/App/assets/46707890/07f610be-0f53-4ffa-a4ef-d662161e50f2
Desktop
https://github.com/Expensify/App/assets/46707890/0ad3ee17-043f-4e6f-82cc-8491f481940a
iOS
https://github.com/Expensify/App/assets/46707890/10b951f0-b7a7-44c1-ac32-4309a23a27bf
Android
https://github.com/Expensify/App/assets/46707890/afd4c5f5-6a61-439d-adb0-f6a858aa3f4e
@Gonals Changes looks good. We have to create 2 issues
Request count/description is not properly updated on request deletion/updation
Request count/description is not updated on workspace chat money requests during addition for any pre-existing workspace. But working fine for new workspaces.
https://github.com/Expensify/App/assets/46707890/4a16b7a9-fa0b-4823-861e-27bd1f3928eb
Do we need to update this function usage to pass comment param https://github.com/Expensify/App/blame/2335cbaf854f236db28cbbc72fa0446a6584d78c/src/libs/actions/IOU.js#L1257
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.52-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
failure ❌
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.52-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
gharchive/pull-request
| 2023-07-26T14:40:42 |
2025-04-01T04:55:03.995217
|
{
"authors": [
"Gonals",
"MonilBhavsar",
"OSBotify",
"abdulrahuman5196"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/23651",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1972909780
|
Default to true to make type happy
Details
Fix type error on main
Fixed Issues
$ None, just slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1698864273831739
Tests
None needed, we default to true already in getDisplayNameForParticipant which is where we pass the param shouldFallbackToHidden
[ ] Verify that no errors appear in the JS console
Offline tests
None needed
QA Steps
None needed
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Reviewer Checklist
[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR
[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:
[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop
[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)
[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed
[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:
[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[ ] If any new file was added I verified that:
[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[ ] If a new CSS style is added I verified that:
[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.95-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.95-9 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.96-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀
platform
result
🤖 android 🤖
failure ❌
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
gharchive/pull-request
| 2023-11-01T18:46:53 |
2025-04-01T04:55:04.048862
|
{
"authors": [
"Beamanator",
"OSBotify",
"cristipaval"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/30731",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2134675801
|
Add the policy tax trackingEnabled
Details
This PR adds the policy.tax.trackingEnabled property so we copy what is in the db policy object
Fixed Issues
$ https://github.com/Expensify/App/issues/36176
Tests
Make sure Tax is enabled in Old Dot.
Add some tax policies in Old Dot.
Add a member to your workspace.
select a user from your workspace with enabled policies.
Click on request money as either manual or scan.
enter amount.
click on Show More and select tax rate.
Verify it worked fine
[ ] Verify that no errors appear in the JS console
Offline tests
N/A
QA Steps
Same as tests
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
simple change, works fine
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
@ishpaul777 ok please go ahead, I think you will need to have the Collect policy set up
yep that should be it, you need to invite in another user to the policy btw to get the workspace chat
@ishpaul777 thanks! updated!
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.42-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.42-5 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
gharchive/pull-request
| 2024-02-14T16:00:06 |
2025-04-01T04:55:04.077097
|
{
"authors": [
"OSBotify",
"mountiny"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/36521",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2140239200
|
Hide the double offline indicator in bank steps
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/36458
$ https://github.com/Expensify/App/issues/36458#issuecomment-1943002051
Tests
[X] Verify that no errors appear in the JS console
Pre-requisite: the user must be logged in and have created a workspace.
Go to Workspace > Bank account.
Initiate the add BA flow until you reach the Personal info double check page.
Disable the internet connection.
Validate that only one offline indicator is shown
Offline tests
Pre-requisite: the user must be logged in and have created a workspace.
Go to Workspace > Bank account.
Initiate the add BA flow until you reach the Personal info double check page.
Disable the internet connection.
Validate that only one offline indicator is shown
QA Steps
[x] Verify that no errors appear in the JS console
Pre-requisite: the user must be logged in and have created a workspace.
Go to Workspace > Bank account.
Initiate the add BA flow until you reach the Personal info double check page.
Disable the internet connection.
Validate that only one offline indicator is shown
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.43-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
gharchive/pull-request
| 2024-02-17T16:12:09 |
2025-04-01T04:55:04.129193
|
{
"authors": [
"OSBotify",
"abzokhattab",
"akinwale"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/36763",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2184742469
|
perf: improve chat switch performance - fixed
Details
Original PR got reverted because of issues with ghost draft comments, this PR brings backs the changes from the original PR, and fixes the related issues.
Please refer to original PR for more details.
Fixed Issues
$ https://github.com/Expensify/App/issues/32793
PROPOSAL: https://github.com/Expensify/App/pull/32336 (original PR)
Tests
[x] Verify that no errors appear in the JS console
Offline tests
QA Steps
[ ] Verify that no errors appear in the JS console
PR Author Checklist
[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR
[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/20626315/5abfabfb-4293-4513-9618-80c555bd342c
MacOS: Desktop
C+ Reviewer: please refer to 3 commits on top of original PR for easy review
as to why:
callback was removed because it was capturing function that changed way too often
reverted the else if condition in Composer as it's necessary to save clean comment as current state of composer in that report, as original author intended
Reviewer Checklist
[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR
[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:
[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop
[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)
[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed
[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:
[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
[x] If any new file was added I verified that:
[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
[x] If a new CSS style is added I verified that:
[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/30054992/a817e55b-e0c6-4a4f-aa20-0530bed5b04f
Android: mWeb Chrome
https://github.com/Expensify/App/assets/30054992/bc78ebec-accd-43df-b7e9-2572c06087e4
iOS: Native
https://github.com/Expensify/App/assets/30054992/3980c628-5124-4408-b679-8192c69f0f80
iOS: mWeb Safari
https://github.com/Expensify/App/assets/30054992/845525be-8b26-43ad-a4b3-2d6389c66081
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/30054992/8cd50ce6-9a96-4472-81c8-b7a95d6a9b91
MacOS: Desktop
https://github.com/Expensify/App/assets/30054992/5ac08f53-7141-4bf9-950c-2ad114d21e40
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.55-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
failure ❌
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.55-0 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
|
gharchive/pull-request
| 2024-03-13T19:28:42 |
2025-04-01T04:55:04.182868
|
{
"authors": [
"OSBotify",
"allroundexperts",
"jbroma"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/38255",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1287880424
|
[No QA] Make preDeploy continue if lint and test succeed
Details
Following-up on https://github.com/Expensify/App/pull/9611 to fix https://github.com/Expensify/App/actions/runs/2579056741.
Fixed Issues
$ n/a
Tests
Merge this PR
Verify that after lint and test succeed, the workflow proceeds.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by @roryabraham in version: 1.1.81-0 🚀
platform
result
🤖 android 🤖
failure ❌
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
failure ❌
|
gharchive/pull-request
| 2022-06-28T21:01:45 |
2025-04-01T04:55:04.187575
|
{
"authors": [
"OSBotify",
"roryabraham"
],
"repo": "Expensify/App",
"url": "https://github.com/Expensify/App/pull/9612",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
771410138
|
Add new sign in flow
NOTE
This is not hooked up to any APIs yet, it just walks through the form steps.
Things left to do:
[ ] Call GetAccountStatus to see if the user had an account already and if they have access to e.cash
[ ] Call SetGithubUsername to save the github username
[ ] Call CreateLogin if account already existed
[ ] Call CreateAccount if account didn't exist
[ ] See if the 2FA field can be hidden if it's not required (maybe add this to GetAccountStatus?)
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/148719
Fixes https://github.com/Expensify/Expensify/issues/148714
Fixes https://github.com/Expensify/Expensify/issues/148716
Tests
As you go through the testing, verify that form validation works (you can't submit an empty form)
Fill out the login form, verify you are taken to the github username form
Fill out the github username form, verify you are taken to the password form
Fill out the password form, verify you are taken to the resend validation link form
Clear out local storage according to this SO
Refresh the page and verify you are back at the first login form
Screenshots
||
||
cc @chiragsalian @stitesExpensify @shawnborton
Updated to fix conflicts and address comment. Still hard to tell if the logic is all correct until it can be tested. Once it can be fully tested then I'll bring this out of WIP.
FYI - Login isn't saved when I click "Change Expensify login" to go back, should it be?
FYI - Login isn't saved when I click "Change Expensify login" to go back, should it be?
I don't think it should be saved, no. It doesn't make sense that if you wanted to change your login that you would want the old value to be there (since you're explicitly trying to change it).
@marcaaron Thanks for the review! I've addressed some of those. Some of the NABs I'm not going to do in this PR and we can do later if we want. Some of your comments were on outdated code as well, so some of the confusion might have been cleared up already.
Is it intentional that the web version kinda looks like a mobile version?
Hm, ya ideally we'd have a more responsive design for desktop.
On Mon, Dec 21, 2020 at 8:12 PM Brandon Stites notifications@github.com
wrote:
Is it intentional that the web version kinda looks like a mobile version?
[image: 2020-12-21_21-12-23]
https://user-images.githubusercontent.com/42391420/102848104-39178280-43d1-11eb-8baf-e2e0d99dc3da.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Expensify/Expensify.cash/pull/1025#issuecomment-749327366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEMNUVRUACM7HPCU24577DSWAMDXANCNFSM4VCMYHKQ
.
That is sort of intentional... we can do better though. I'll have another PR to try and improve the desktop design.
This is all tested and ready to go, so finally removing WIP
I have read the CLA Document and I hereby sign the CLA
|
gharchive/pull-request
| 2020-12-19T16:25:19 |
2025-04-01T04:55:04.199669
|
{
"authors": [
"AndrewGable",
"quinthar",
"stitesExpensify",
"tgolen"
],
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/1025",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
864676482
|
Emoji Picker Menu Navigation
Details
Added the ability to navigate through the emoji picker menu with arrow keys, and to send the highlighted emoji with [Enter]. It should function the same as the emoji picker in Slack.
the highlighted emoji should never be cutoff by the window
the first emoji is highlighted upon searching emojis
hovering over an emoji with your cursor will also change the currently highlighted emoji
if no emoji is highlighted, pressing an arrow key will highlight the first emoji
the cursor in the search input is not affected by arrow key presses that change the highlighted emoji
Fixed Issues
Fixes https://github.com/Expensify/Expensify.cash/issues/2450
Tests
I tested this feature on Web and Desktop since those are the only two places it can actually be used, but I also tested it on Mobile Web to ensure that the touchscreen check works and that the Emoji Picker Menu doesn't crash.
Opened the emoji picker. Scroll down till you can see the end of on category and the start of another.
Use your mouse to hover over an emoji near this boundary.
Use the up/down arrow keys to move the highlight around this border. Verified that it skips over the header.
Move the highlight at the top and bottom edges of the window with the arrow keys. Verified that the menu scrolls to keep the highlighted emoji in the window.
Type in search terms to filter by. Verified that the first search result is highlighted. Verified that nothing breaks when you try to go out of bounds. Verified that you can move the cursor using the appropriate arrow keys when they would move the highlight out of bounds.
Pressed [Enter]. Verified that the highlighted emoji was inputted into the compose box.
Repeat steps 1-6 two more times to verify that event listeners are removed and added correctly.
QA Steps
Identical to the tests above. See videos for examples.
Tested On
[x] Web
[ ] Mobile Web
[x] Desktop
[ ] iOS
[ ] Android
Screenshots
Web
https://user-images.githubusercontent.com/31285285/115820241-0048f200-a433-11eb-9dd8-d6c274158365.mp4
Desktop
https://user-images.githubusercontent.com/31285285/115819992-8ca6e500-a432-11eb-9322-4cabf9f107f3.mp4
cc @stitesExpensify
@pecanoro @stitesExpensify Thanks for clarifying my questions! Should be good for another review.
Tested and it works great! Just some code organization comments and then we should be good to go!
Hey @stitesExpensify thanks so much for the review! I've addressed most of your concerns but have a few clarifications of my own. Let me know what you think!
@stitesExpensify Ready for another review, thanks for your feedback!
🚀 Deployed to staging in version: 1.0.35-2🚀
platform
result
🤖 android 🤖
success ✅
🖥 desktop 🖥
success ✅
🍎 iOS 🍎
success ✅
🕸 web 🕸
success ✅
Emoji Picker - Moving by arrow keys will eventually lose selection
Expected result
Focus isn't lost even after reaching the last emoji on the list.
Actual result
After reaching the last emoji on the list, the focus is not visible anymore.
Action Performed
Log in to expensify.cash
Navigate to a conversation
Click on the emoji icon
Use the arrow keys to reach the bottom of the list
Platform
Web ✔️
Build: 1.0.36-0
Notes/Images/Video
https://user-images.githubusercontent.com/44479856/116945606-15e5c500-ac46-11eb-9e65-ce28fcc1e469.mp4
@jasperhuangg Not sure if the issue above should be a deploy blocker, let me know if I should open as a separate issue.
No need for this to be a deploy blocker, @isagoico, can you create a separate issue and tag @jasperhuangg?
|
gharchive/pull-request
| 2021-04-22T08:17:59 |
2025-04-01T04:55:04.213544
|
{
"authors": [
"OSBotify",
"isagoico",
"jasperhuangg",
"roryabraham",
"stitesExpensify"
],
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/2532",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
901628615
|
Make easily noticeable temporary change
Details
This PR is being used to test the CP workflow. It is "PR A", referenced in Step 5 of the testing plan here. This change will be reverted soon
Fixed Issues
Part of testing https://github.com/Expensify/Expensify.cash/pull/2978
Tests
Merge this PR
Verify that it gets the ✋ This PR will not be deployed ... comment
Verify that a staging deploy does not occur.
Verify that the red FAB is not present on staging.
Later complete steps 10-12 of the testing plan
QA Steps
Verify that the FAB is not red 😂
Skipping tests/actions to test CP PR flow
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
Test steps 1-4 passed 👍
|
gharchive/pull-request
| 2021-05-26T02:03:03 |
2025-04-01T04:55:04.218596
|
{
"authors": [
"Jag96",
"OSBotify",
"roryabraham"
],
"repo": "Expensify/Expensify.cash",
"url": "https://github.com/Expensify/Expensify.cash/pull/3149",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2215394197
|
feat: remove emoji tag from data-code-raw in pre
Fixed Issues
$ GH_LINK
Tests
What unit/integration tests cover your change? What autoQA tests cover your change?
What tests did you perform that validates your changed worked?
QA
What does QA need to do to validate your changes?
What areas to they need to test for regressions?
I have read the CLA Document and I hereby sign the CLA
recheck
|
gharchive/pull-request
| 2024-03-29T13:43:44 |
2025-04-01T04:55:04.221072
|
{
"authors": [
"BartoszGrajdek"
],
"repo": "Expensify/expensify-common",
"url": "https://github.com/Expensify/expensify-common/pull/674",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
733058692
|
sound source
How do I change sound source?
Whan I change headset in POE, this doesn't copy to Mercury Trade.
Even after restarting the pc.
When I put the old headset in the pc, it works.
MercuryTrade here is discontinued. Feel free to try a community fork version here: https://github.com/Morph21/MercuryTrade-Community-Fork
It's possible to change sounds.
Also different headset is not an issue on POE or MT side, check your system settings for solving sound issues
MercuryTrade here is discontinued. Feel free to try a community fork version here: https://github.com/Morph21/MercuryTrade-Community-Fork
It's possible to change sounds.
Also different headset is not an issue on POE or MT side, check your system settings for solving sound issues
|
gharchive/issue
| 2020-10-30T10:25:53 |
2025-04-01T04:55:04.235043
|
{
"authors": [
"AlsoInteresting",
"Morph21"
],
"repo": "Exslims/MercuryTrade",
"url": "https://github.com/Exslims/MercuryTrade/issues/415",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
402596173
|
Example TwoWayRanging is not work.
Step 1: What do you want?
TwoWayRangingInitiator and TwoWayRangingResponder do not work. therefore I want them to work.
Step 2: Describe your environment
Arduino IDE version or Toolchain: Arduino IDE 1.8.7
Arduino device: Arduino Uno R3
Used adapter board: None
Step 3: Describe the problem
Affected file(s) or example(s):
TwoWayRangingResponder.ino
TwoWayRangingInitiator.ino
Observed Results:
It seems not to work!
Thus I tried Basic Connectivity Test.
I'm not sure it's correct output because I'm a beginner of Arduino and DWM1000.
But I don't think there is any noticeable problem.
And then I uploaded Basic Sender/Receiver to Arduino.
I still have no clue about this, but it seems to work fine.
EDIT: thotro/arduino-dw1000
I tried also thotro's library.
The device is removed immediately after it is added.
Why are BasicSender and Receiver working but TwoWayRanging not working?
Expected Results:
Jaja, I expected they work.
Wiring
Where did you put the 10K resistor ? I am having the same issue my Basic Receiver and Basic Sender is working but the Two Way Ranging example doesnt work
@lgr9603
Where did you put the 10K resistor ? I am having the same issue my Basic Receiver and Basic Sender is working but the Two Way Ranging example doesnt work
I think that the @tdh8316 's solution is relative to section 5.2.2 inside DWM1000 datasheet
@Leylan24 I'm a coworker of @tdh8316 .
Well, we put the 10K resistor on pin 2 to remove noises flowing through it.
And drop the voltage of digital pins from 5V to 3.3V. Dwm1000 can work between 2.4V and 3.75V. (Along to datasheet on decawaver.com)
As I said, arduino uno digital pins use 5V, bout DWM1000 sends output signals in 3.3V. So we should increase voltage of DWM1000 signal from 3.3V to 5V.
Thanks for you reply. I'm using the ESP8266 Nodemcu and get very inaccurate ranges no idea why
This is a bit of a stupid question.
But does the ranges only print when the IRQ pin gets pulled high?
This is a bit of a stupid question.
But does the ranges only print when the IRQ pin gets pulled high?
With this library, the IRQ pin is not required. There are two different init processes, with or without Interrupt pin.
|
gharchive/issue
| 2019-01-24T08:38:11 |
2025-04-01T04:55:04.324994
|
{
"authors": [
"Leylan24",
"Sonic0",
"lgr9603",
"tdh8316"
],
"repo": "F-Army/arduino-dw1000-ng",
"url": "https://github.com/F-Army/arduino-dw1000-ng/issues/139",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
716055084
|
Ability to create DNS_Logging_Profile from AS3
Is your feature request related to a problem? Please describe.
Feature Request
Describe the solution you'd like
AS3 has the ability to reference DNS_Logging_Profile as a pre-created item, we would like the ability to create it. I don't see an option in the schema to create one.
"description": "Reference to a DNS logging profile",
"type": "object",
"properties": {
"bigip": {
"description": "Pathname of existing BIG-IP DNS logging profile",
"type": "string",
"format": "f5bigip"
}
},
Describe alternatives you've considered
There isn't an Ansible module for this either, it would require imperative calls to create the object.
REST endpoint: /mgmt/tm/ltm/profile/dns-logging
Options:
appService:
description:
enableQueryLogging:
enableResponseLogging:
includeCompleteAnswer:
includeQueryId:
includeSource:
includeTimestamp:
includeView:
logPublisher:
name:
Additional context
Object in question:
Thank you for your feedback. Due to the age of this feature request, I would like to know if this is still something you need or are interested in.
|
gharchive/issue
| 2020-10-06T22:10:44 |
2025-04-01T04:55:04.331748
|
{
"authors": [
"dstokesf5",
"jmcalalang"
],
"repo": "F5Networks/f5-appsvcs-extension",
"url": "https://github.com/F5Networks/f5-appsvcs-extension/issues/357",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2061931002
|
Unable to compare SSL SNI/hostname against data group
Environment
Application Services Version: 3.48.0
BIG-IP Version: 17.1.0.2
Summary
When building a policy, I can compare the HTTP hostname against a data group, but I cannot compare the SSL SNI hostname against the same data group. I get the following error
Steps To Reproduce
Submit the following policy:
"http-redirect": {
"class": "Endpoint_Policy",
"strategy": "first-match",
"rules": [
{
"name": "permit",
"conditions": [{
"type": "httpHost",
"event": "request",
"host": {
"operand": "ends-with",
"datagroup": {
"use": "permitted-domains"
}
}
}]
}
]
}
It works fine.
Submit this policy instead:
"https-block": {
"class": "Endpoint_Policy",
"strategy": "first-match",
"rules": [
{
"name": "permit",
"conditions": [{
"type": "sslExtension",
"event": "ssl-client-hello",
"serverName": {
"operand": "ends-with",
"datagroup": {
"use": "permitted-domains"
}
}
}]
}
]
}
It fails to post, I get the following error:
{
"code": 422,
"message": "declaration failed",
"response": "01020036:3: The requested datagroup lookup failure: (use) was not found.",
"host": "localhost",
"tenant": "init-policy",
"runTime": 2365
},
it looks like two things are changing from your working and not working examples. If the permitted-domains data group is managed by AS3, can you try updating your failing example to use a use pointer instead of a bigip pointer?
Good observation. In all my testing, I copied/pasted the wrong example. The behavior is the same when with a use pointer. I updated my post above.
Add Jira AUTOTOOL-4132 to next sprint for prioritization discussion
|
gharchive/issue
| 2024-01-02T04:32:21 |
2025-04-01T04:55:04.336913
|
{
"authors": [
"dstokesf5",
"mdditt2000",
"normelton"
],
"repo": "F5Networks/f5-appsvcs-extension",
"url": "https://github.com/F5Networks/f5-appsvcs-extension/issues/790",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
978478155
|
Datadog: add customizable service field option
Is your feature request related to a problem? Please describe.
The service field option, used by Datadog logging, is not customizable but statically defined in the code.
const DATA_DOG_SERVICE_FIELD = 'f5-telemetry'
Describe the solution you'd like
Be able to set a custom value in the Datadog consumer declaration.
Thank you for your feedback. I have added your request to our internal product backlog as AUTOTOOL-2753.
I guess it had been fixed in v1.24.0?
This has been resolved in the 1.24.0 release.
|
gharchive/issue
| 2021-08-24T20:54:45 |
2025-04-01T04:55:04.341988
|
{
"authors": [
"amolari",
"dstokesf5"
],
"repo": "F5Networks/f5-telemetry-streaming",
"url": "https://github.com/F5Networks/f5-telemetry-streaming/issues/161",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1522479474
|
虚拟人对话一次后报错
错误如图所示，各位大佬有解决办法嘛？
@SZNero @wyxogo
错误如图所示，各位大佬有解决办法嘛？
请修改zsmeif_aispeech_config.json
感谢！已解决。
|
gharchive/issue
| 2023-01-06T12:06:49 |
2025-04-01T04:55:04.353198
|
{
"authors": [
"1059692261",
"wyxogo"
],
"repo": "FACEGOOD/FACEGOOD-Audio2Face",
"url": "https://github.com/FACEGOOD/FACEGOOD-Audio2Face/issues/58",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1892466057
|
Adds passing of objects to transmission reader
This adds the functionality of passing a dict to the transmission readers convert function.
@hampusnasstrom
So you pass Dict type objects and append them to the template? No other object types are accepted currently, right?
Pull Request Test Coverage Report for Build 6159995561
10 of 17 (58.82%) changed or added relevant lines in 3 files are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.005%) to 51.087%
Changes Missing Coverage
Covered Lines
Changed/Added Lines
%
pynxtools/dataconverter/readers/utils.py
6
13
46.15%
Files with Coverage Reduction
New Missed Lines
%
pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py
1
11.86%
pynxtools/nyaml2nxdl/nyaml2nxdl_forward_tools.py
1
79.42%
pynxtools/nexus/nxdl_utils.py
2
74.79%
Totals
Change from base Build 6086304081:
-0.005%
Covered Lines:
5993
Relevant Lines:
11731
💛 - Coveralls
So you pass Dict type objects and append them to the template? No other object types are accepted currently, right?
Exactly, I expect an iterable of dicts. Every other element is simply warned about and ignored
|
gharchive/pull-request
| 2023-09-12T12:56:42 |
2025-04-01T04:55:04.374534
|
{
"authors": [
"coveralls",
"domna",
"sherjeelshabih"
],
"repo": "FAIRmat-NFDI/pynxtools",
"url": "https://github.com/FAIRmat-NFDI/pynxtools/pull/157",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
596666078
|
Adding Statistic
This fix request #3 #26 and #27
|
gharchive/pull-request
| 2020-04-08T15:29:05 |
2025-04-01T04:55:04.392039
|
{
"authors": [
"FBoucher"
],
"repo": "FBoucher/AzUrlShortener",
"url": "https://github.com/FBoucher/AzUrlShortener/pull/28",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
890037975
|
caliper benchmark question
[caliper-flow] Error: TypeError: Cannot read property 'hasOwnProperty' of undefined
at ClientOrchestrator.init (/home/drtts1/benchmarks/node_modules/@hyperledger/caliper-core/lib/client/client-orchestrator.js:41:24)
at Object.module.exports.run (/home/drtts1/benchmarks/node_modules/@hyperledger/caliper-core/lib/caliper-flow.js:106:60)
at
at process._tickCallback (internal/process/next_tick.js:189:7)
请参考 #1248, 更详细的压测说明请参考文档
#1248
Duplicate of #1248
|
gharchive/issue
| 2021-05-12T12:34:22 |
2025-04-01T04:55:04.421195
|
{
"authors": [
"Xubin-source",
"cyjseagull"
],
"repo": "FISCO-BCOS/FISCO-BCOS",
"url": "https://github.com/FISCO-BCOS/FISCO-BCOS/issues/1935",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
519530317
|
Feature: Host Functions
This pull request/branch tracks the development of host functions.
Example documentation: https://gist.github.com/Robadob/081d04d2d515ce3b090bf389dc9195dc
This addresses many issues, as such the branch may be long running and merged incrementally:
PR #135
[x] #46 - Host functions init/step/exit bd5097c
[x] #54 - Exit early from step function bd5097c
[x] #47 - Host layer functions (step function in any layer) 7c0c204
[x] #53 - CUB reductions (min, max, sum, count) 046fa07
[x] #80 - Histogram reduction 09ac715
[x] #83 - Custom reduction functions (cub reduce, thrust transformReduce) ffa28c9
PR: #138
[x] #90 - Constant/Immutable Environmental variables
PR: #196
[x] #61 - Agent creation on the host
Misc/Low Priority
[ ] #162 - Large environment properties (held in global memory)
[ ] #51 - 'Access agent data on the host'????
TODO:
[x] Rename FLAMEGPU_API->FLAMEGPU_DEVICE_API
Host function definition
[x] Host Fn
[x] Host Condition
Add Host fn/condition to model
[x] Init
[x] Step
[x] Exit
[x] Layer
[x] ExitCondition
gpu/CUDAAgentModel (Controls execution of model)
step(): Update to support host functions
[x] Init
[x] Step
[x] Exit
[x] HostLayer
[x] ExitCondition
Environmental vars
[x] Define
[x] Read in device fn
Runtime/flamegpu_host_api.h
Environmental vars
[x] Read on host fn
[x] Write in host fn
[x] Wrapper for <random>
Reduction
[x] Sum
[x] Min
[x] Max
[x] Reduce (user defined template binary op a+b->c)
Others from thrust?
[x] Count
[x] TransformReduce
Message reductions?
Histogram
[x] Even
Custom bounds? (This would require having to cache their bounds on device somehow)
[x] Agent Creation
[x] Tests
[x] Example usage in model
TODO Monday:
Custom reduction fn
\<random> wrapper using runtime seed.
This PR has served it's purpose all parity tasks complete.
|
gharchive/pull-request
| 2019-11-07T21:43:25 |
2025-04-01T04:55:04.435840
|
{
"authors": [
"Robadob"
],
"repo": "FLAMEGPU/FLAMEGPU2_dev",
"url": "https://github.com/FLAMEGPU/FLAMEGPU2_dev/pull/130",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2198574482
|
Request: Option to toggle the "green styling"
It makes it very hard to read with darkmode on
As an "older gentleman" it kinda all blurs into one colour!
The main problem is the text color, which we will improve upon. But we have been working toward centralizing styling colors so it might be possible in the future (not yet) to have themes.
Baby steps...
... but for now we'll fix the text which is badly colored as you showed in your screenshots.
Thank you for giving feedback, some of those area haf not occured to me, so this is definitely helpful.
I'll address this if you want
Fixed.
|
gharchive/issue
| 2024-03-20T21:10:03 |
2025-04-01T04:55:04.441736
|
{
"authors": [
"FMaz008",
"crysallis",
"runew0lf"
],
"repo": "FMaz008/VineHelper",
"url": "https://github.com/FMaz008/VineHelper/issues/58",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
637888270
|
create robot control react element to show the current state of the robot
sensor data, motor output etc..., position...
I implemented this already. Will add a PR today
#46 has an extremely simple version of this, only contains the motor power for now, but ill close this issue.
|
gharchive/issue
| 2020-06-12T16:58:00 |
2025-04-01T04:55:04.557982
|
{
"authors": [
"JamesWP",
"eurocoinsalbum"
],
"repo": "FRUK-Simulator/Simulator",
"url": "https://github.com/FRUK-Simulator/Simulator/issues/37",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1251818321
|
Automatically download new SoundCloud tracks
The text in the followthatpage mails might be enough to automatically download new SoundCloud tracks from artists I follow with that tool. The hardest part of that might be reading the mail using Bash, but surely there's a tool for that.
Test cases would have to include tracks with the same name as something that that artist has already uploaded before, because then they get an attached "-2" or similar in the URL, but it might also be slightly different. Checking the upload date and comparing that to the mail should definitely be done. Maybe that's also enough and the actual content of the mail can be ignored, just knowing that someone uploaded and then downloading the last week of their tracks would be OK.
Filtering out false positives like in the mail macro would also be necessary for as long as that followthatpage bug exists.
Alternatively, there's something with RSS on SoundCloud, which would be a less hacky solution (RSS→dl instead of website→follow→mail→guess link→verify date→dl). But I never got any of those RSS feeds to work so far.
alternative: query pages myself, can also apply to more than SC
auto-download WL and temp_music
similar: webcomics, Lateral
|
gharchive/issue
| 2022-05-29T07:57:55 |
2025-04-01T04:55:04.635509
|
{
"authors": [
"Fabian42"
],
"repo": "Fabian42/bash_scripts",
"url": "https://github.com/Fabian42/bash_scripts/issues/44",
"license": "Unlicense",
"license_type": "permissive",
"license_source": "github-api"
}
|
2639676077
|
Recipe for smelting zinc from raw zinc ore is broken
Description
Recipe for smelting zinc from raw zinc ore is broken, also blasting and bulk blasting.
Game Log
https://mclo.gs/FXafl4x
Debug Information
Client Info
Create:
Mod Version: 0.5.1j
Fabric API Version: 0.92.2+1.20.1
Minecraft Version: 1.20.1
Graphics:
Flywheel Version: 0.6.11-4
Flywheel Backend: INSTANCING
OpenGL Renderer: AMD Radeon 780M Graphics
OpenGL Version: 3.2.0 Core Profile Context 24.10.1.241007
Graphics Mode: options.graphics.fancy
System Information:
Operating System: Windows 11 (amd64) version 10.0
Java Version: 17.0.12, Oracle Corporation
JVM Flags: 6 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M
Memory: 1113639984 bytes (1062 MiB) / 2248146944 bytes (2144 MiB) up to 8589934592 bytes (8192 MiB)
Total Memory: 19831197696 bytes (18904 MiB) / 33515835392 bytes (31950 MiB)
CPU: AMD Ryzen 9 7940HS w/ Radeon 780M Graphics @ 3.99 GHz; 8 cores / 16 threads on 1 socket(s)
Graphics card #0: AMD Radeon 780M Graphics (Advanced Micro Devices, Inc. (0x1002)); 512.00 MB of VRAM
Other Mods:
core: 3.6.6
toml: 3.6.6
jsr305: 3.0.2
Dripstone Fluid Lib: 3.0.2
EMI: 1.1.18+1.20.1+fabric
Extra Mod Integrations: 0.4.6+1.20.1
Fabric API Base: 0.4.31+1802ada577
Fabric API Lookup API (v1): 1.6.36+1802ada577
Fabric Biome API (v1): 13.0.13+1802ada577
Fabric Block API (v1): 1.0.11+1802ada577
Fabric BlockView API (v2): 1.0.1+1802ada577
Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577
Fabric Client Tags: 1.1.2+1802ada577
Fabric Command API (v1): 1.2.34+f71b366f77
Fabric Command API (v2): 2.2.13+1802ada577
Fabric Commands (v0): 0.2.51+df3654b377
Fabric Containers (v0): 0.1.64+df3654b377
Fabric Content Registries (v0): 4.0.11+1802ada577
Fabric Convention Tags: 1.5.5+1802ada577
Fabric Crash Report Info (v1): 0.2.19+1802ada577
Fabric Data Attachment API (v1): 1.0.0+de0fd6d177
Fabric Data Generation API (v1): 12.3.4+1802ada577
Fabric Dimensions API (v1): 2.1.54+1802ada577
Fabric Entity Events (v1): 1.6.0+1c78457f77
Fabric Events Interaction (v0): 0.6.2+1802ada577
Fabric Events Lifecycle (v0): 0.2.63+df3654b377
Fabric Game Rule API (v1): 1.0.40+1802ada577
Fabric Item API (v1): 2.1.28+1802ada577
Fabric Item Group API (v1): 4.0.12+1802ada577
Fabric Key Binding API (v1): 1.0.37+1802ada577
Fabric Key Bindings (v0): 0.2.35+df3654b377
Fabric Lifecycle Events (v1): 2.2.22+1802ada577
Fabric Loot API (v2): 1.2.1+1802ada577
Fabric Loot Tables (v1): 1.1.45+9e7660c677
Fabric Message API (v1): 5.1.9+1802ada577
Fabric Mining Level API (v1): 2.1.50+1802ada577
Fabric Model Loading API (v1): 1.0.3+1802ada577
Fabric Models (v0): 0.4.2+9386d8a777
Fabric Networking API (v1): 1.3.11+1802ada577
Fabric Networking (v0): 0.3.51+df3654b377
Fabric Object Builder API (v1): 11.1.3+1802ada577
Fabric Particles (v1): 1.1.2+1802ada577
Fabric Recipe API (v1): 1.0.21+1802ada577
Fabric Registry Sync (v0): 2.3.3+1802ada577
Fabric Renderer API (v1): 3.2.1+1802ada577
Fabric Renderer - Indigo: 1.5.2+85287f9f77
Fabric Renderer Registries (v1): 3.2.46+df3654b377
Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777
Fabric Rendering Fluids (v1): 3.0.28+1802ada577
Fabric Rendering (v0): 1.1.49+df3654b377
Fabric Rendering (v1): 3.0.8+1802ada577
Fabric Resource Conditions API (v1): 2.3.8+1802ada577
Fabric Resource Loader (v0): 0.11.10+1802ada577
Fabric Screen API (v1): 2.0.8+1802ada577
Fabric Screen Handler API (v1): 1.3.30+1802ada577
Fabric Sound API (v1): 1.0.13+1802ada577
Fabric Transfer API (v1): 3.3.5+8dd72ea377
Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577
Fabric Loader: 0.16.9
Forge Config API Port: 8.0.0
Java HotSpot(TM) 64-Bit Server VM: 17
Milk Lib: 1.2.60
MixinExtras: 0.4.1
Porting Lib Accessors: 2.3.5-beta.33+1.20.1
Porting Lib Attributes: 2.3.5-beta.33+1.20.1
Porting Lib Base: 2.3.5-beta.33+1.20.1
Porting Lib Brewing: 2.3.5-beta.33+1.20.1
Porting Lib Client Events: 2.3.5-beta.33+1.20.1
Porting Lib Common: 2.3.5-beta.33+1.20.1
Porting Lib Config: 2.3.5-beta.33+1.20.1
Porting Lib Core: 2.3.5-beta.33+1.20.1
Porting Lib Data: 2.1.1090+1.20
Porting Lib Entity: 2.3.5-beta.33+1.20.1
Porting Lib Extensions: 2.3.5-beta.33+1.20.1
Porting Lib Fluids: 2.3.5-beta.33+1.20.1
Porting Lib GameTest: 2.1.1090+1.20
Porting Lib Gui Utils: 2.3.5-beta.33+1.20.1
Porting Lib Lazy Register: 2.3.5-beta.33+1.20.1
Porting Lib Mixin Extensions: 2.3.5-beta.33+1.20.1
Porting Lib Model Generators: 2.1.1090+1.20
Porting Lib Model Loader: 2.3.5-beta.33+1.20.1
Porting Lib Model Materials: 2.1.1090+1.20
Porting Lib Models: 2.3.5-beta.33+1.20.1
Porting Lib Networking: 2.3.5-beta.33+1.20.1
Porting Lib Obj Loader: 2.3.5-beta.33+1.20.1
Porting Lib Tags: 3.0
Porting Lib Tool Actions: 2.3.5-beta.33+1.20.1
Porting Lib Transfer: 2.3.5-beta.33+1.20.1
Porting Lib Utility: 2.3.5-beta.33+1.20.1
Reach Entity Attributes: 2.4.0
Registrate for Fabric: 1.3.79-MC1.20.1
Server Info
Create:
Mod Version: 0.5.1j
Fabric API Version: 0.92.2+1.20.1
Minecraft Version: 1.20.1
System Information:
Operating System: Windows 11 (amd64) version 10.0
Java Version: 17.0.12, Oracle Corporation
JVM Flags: 6 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M
Memory: 1113639984 bytes (1062 MiB) / 2248146944 bytes (2144 MiB) up to 8589934592 bytes (8192 MiB)
Total Memory: 19831197696 bytes (18904 MiB) / 33515835392 bytes (31950 MiB)
CPU: AMD Ryzen 9 7940HS w/ Radeon 780M Graphics @ 3.99 GHz; 8 cores / 16 threads on 1 socket(s)
Graphics card #0: AMD Radeon 780M Graphics (Advanced Micro Devices, Inc. (0x1002)); 512.00 MB of VRAM
Other Mods:
core: 3.6.6
toml: 3.6.6
jsr305: 3.0.2
Dripstone Fluid Lib: 3.0.2
EMI: 1.1.18+1.20.1+fabric
Extra Mod Integrations: 0.4.6+1.20.1
Fabric API Base: 0.4.31+1802ada577
Fabric API Lookup API (v1): 1.6.36+1802ada577
Fabric Biome API (v1): 13.0.13+1802ada577
Fabric Block API (v1): 1.0.11+1802ada577
Fabric BlockView API (v2): 1.0.1+1802ada577
Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577
Fabric Client Tags: 1.1.2+1802ada577
Fabric Command API (v1): 1.2.34+f71b366f77
Fabric Command API (v2): 2.2.13+1802ada577
Fabric Commands (v0): 0.2.51+df3654b377
Fabric Containers (v0): 0.1.64+df3654b377
Fabric Content Registries (v0): 4.0.11+1802ada577
Fabric Convention Tags: 1.5.5+1802ada577
Fabric Crash Report Info (v1): 0.2.19+1802ada577
Fabric Data Attachment API (v1): 1.0.0+de0fd6d177
Fabric Data Generation API (v1): 12.3.4+1802ada577
Fabric Dimensions API (v1): 2.1.54+1802ada577
Fabric Entity Events (v1): 1.6.0+1c78457f77
Fabric Events Interaction (v0): 0.6.2+1802ada577
Fabric Events Lifecycle (v0): 0.2.63+df3654b377
Fabric Game Rule API (v1): 1.0.40+1802ada577
Fabric Item API (v1): 2.1.28+1802ada577
Fabric Item Group API (v1): 4.0.12+1802ada577
Fabric Key Binding API (v1): 1.0.37+1802ada577
Fabric Key Bindings (v0): 0.2.35+df3654b377
Fabric Lifecycle Events (v1): 2.2.22+1802ada577
Fabric Loot API (v2): 1.2.1+1802ada577
Fabric Loot Tables (v1): 1.1.45+9e7660c677
Fabric Message API (v1): 5.1.9+1802ada577
Fabric Mining Level API (v1): 2.1.50+1802ada577
Fabric Model Loading API (v1): 1.0.3+1802ada577
Fabric Models (v0): 0.4.2+9386d8a777
Fabric Networking API (v1): 1.3.11+1802ada577
Fabric Networking (v0): 0.3.51+df3654b377
Fabric Object Builder API (v1): 11.1.3+1802ada577
Fabric Particles (v1): 1.1.2+1802ada577
Fabric Recipe API (v1): 1.0.21+1802ada577
Fabric Registry Sync (v0): 2.3.3+1802ada577
Fabric Renderer API (v1): 3.2.1+1802ada577
Fabric Renderer - Indigo: 1.5.2+85287f9f77
Fabric Renderer Registries (v1): 3.2.46+df3654b377
Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777
Fabric Rendering Fluids (v1): 3.0.28+1802ada577
Fabric Rendering (v0): 1.1.49+df3654b377
Fabric Rendering (v1): 3.0.8+1802ada577
Fabric Resource Conditions API (v1): 2.3.8+1802ada577
Fabric Resource Loader (v0): 0.11.10+1802ada577
Fabric Screen API (v1): 2.0.8+1802ada577
Fabric Screen Handler API (v1): 1.3.30+1802ada577
Fabric Sound API (v1): 1.0.13+1802ada577
Fabric Transfer API (v1): 3.3.5+8dd72ea377
Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577
Fabric Loader: 0.16.9
Forge Config API Port: 8.0.0
Java HotSpot(TM) 64-Bit Server VM: 17
Milk Lib: 1.2.60
MixinExtras: 0.4.1
Porting Lib Accessors: 2.3.5-beta.33+1.20.1
Porting Lib Attributes: 2.3.5-beta.33+1.20.1
Porting Lib Base: 2.3.5-beta.33+1.20.1
Porting Lib Brewing: 2.3.5-beta.33+1.20.1
Porting Lib Client Events: 2.3.5-beta.33+1.20.1
Porting Lib Common: 2.3.5-beta.33+1.20.1
Porting Lib Config: 2.3.5-beta.33+1.20.1
Porting Lib Core: 2.3.5-beta.33+1.20.1
Porting Lib Data: 2.1.1090+1.20
Porting Lib Entity: 2.3.5-beta.33+1.20.1
Porting Lib Extensions: 2.3.5-beta.33+1.20.1
Porting Lib Fluids: 2.3.5-beta.33+1.20.1
Porting Lib GameTest: 2.1.1090+1.20
Porting Lib Gui Utils: 2.3.5-beta.33+1.20.1
Porting Lib Lazy Register: 2.3.5-beta.33+1.20.1
Porting Lib Mixin Extensions: 2.3.5-beta.33+1.20.1
Porting Lib Model Generators: 2.1.1090+1.20
Porting Lib Model Loader: 2.3.5-beta.33+1.20.1
Porting Lib Model Materials: 2.1.1090+1.20
Porting Lib Models: 2.3.5-beta.33+1.20.1
Porting Lib Networking: 2.3.5-beta.33+1.20.1
Porting Lib Obj Loader: 2.3.5-beta.33+1.20.1
Porting Lib Tags: 3.0
Porting Lib Tool Actions: 2.3.5-beta.33+1.20.1
Porting Lib Transfer: 2.3.5-beta.33+1.20.1
Porting Lib Utility: 2.3.5-beta.33+1.20.1
Reach Entity Attributes: 2.4.0
Registrate for Fabric: 1.3.79-MC1.20.1
Tag mismatch, the recipe is using https://github.com/Fabricators-of-Create/Create/blob/0f58b606f1301fc742367c8ed79d3fc080ee6610/src/generated/resources/data/create/recipes/smelting/zinc_ingot_from_raw_ore.json#L7 on all three dev branches.
This tag is only present on mc1.18/fabric/dev, the other two still assign raw zinc to c:raw_zinc_ores (ex: https://github.com/Fabricators-of-Create/Create/blob/mc1.20.1/fabric/dev/src/generated/resources/data/c/tags/items/raw_zinc_ores.json)
Imo a bit odd to have switched to the new shared loader tag format for these versions when Fabric itself doesn't seem to have backported them.
|
gharchive/issue
| 2024-11-07T02:41:11 |
2025-04-01T04:55:04.675858
|
{
"authors": [
"VoidLeech",
"oxideNeko233"
],
"repo": "Fabricators-of-Create/Create",
"url": "https://github.com/Fabricators-of-Create/Create/issues/1639",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1744981636
|
refactored dockerfiles to reduce image sizes
Update Ruby to 3.2.2;
Add redis and helper services to docker-compose;
Refactored dockerfile for client - use node:18-alpine and multi stage build to reduce image size
Refactored dockerfile for api - use ruby:3.2.2-slim-bullseye and update dependencies to reduce image size
Time to build ~ 122s
Image sizes: client reduced from 1.27GB to 309MB. rails api reduced from 1.07GB to 678MB
This addresses issue #172
Significantly reduced time to stop containers: from ~10+ seconds for client to 0.4s
|
gharchive/pull-request
| 2023-06-07T03:55:09 |
2025-04-01T04:55:04.777566
|
{
"authors": [
"chris-t-li"
],
"repo": "Fantasy-Fit/fantasy-fit-web",
"url": "https://github.com/Fantasy-Fit/fantasy-fit-web/pull/173",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
667053734
|
onChangeText is not working
<GoogleAutoCompleteAddress
onPress={(data, details = null) => {
this.fetchGoogleLocationDetails(details);
}}
textInputProps={{
value:lossAddress,
onChangeText:{_onChangeTextValue()}
}}
editable={true}
autoFocus={false} />
onChangeText is not working and showing syntax error
Please provide a reproducible example.
|
gharchive/issue
| 2020-07-28T13:00:52 |
2025-04-01T04:55:04.859085
|
{
"authors": [
"NareshNama",
"bell-steven"
],
"repo": "FaridSafi/react-native-google-places-autocomplete",
"url": "https://github.com/FaridSafi/react-native-google-places-autocomplete/issues/595",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
218989143
|
End stops don't work on after new release
my.farmbot.io
You disable endstops?
@Daniil145 sorry about that, they werent disabled, but there was a new version of teh Arduino Firmware released.
Could you try disabling and re enabling end stops?
@ConnorRigby I dont understand "disabling and re enabling end stops" on interface dont have toggle off and on Endpoints. What can I do to activate them? With the loss of the Internet (especially when I use mobile Internet) the system behaves unpredictably. Especially this is critical for the Z axis. To do this, I need limit switches.
Oh sorry i didnt realize they werent on the interface any more.
@RickCarlino any thoughts on this one?
@Daniil145 I've recently added endstop toggle buttons to the device panel. They will be available in the next production release (probably this week).
@Daniil145 We just did a production deploy. Please let us know if you find any issues.
|
gharchive/issue
| 2017-04-03T16:26:44 |
2025-04-01T04:55:04.862074
|
{
"authors": [
"ConnorRigby",
"Daniil145",
"RickCarlino"
],
"repo": "FarmBot/farmbot_os",
"url": "https://github.com/FarmBot/farmbot_os/issues/282",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
1611946418
|
FB-1895: Implement DateTimeFromParts
this uses the tiem.date() function
Well, I have to add limits to the time ranges. For example, dax expects the year range [0 , 9999]. I'll update the code and re request to review.
Looks good to me.
|
gharchive/pull-request
| 2023-03-06T17:59:35 |
2025-04-01T04:55:04.972977
|
{
"authors": [
"rachithrr",
"vkrishnanfb"
],
"repo": "FeatureBaseDB/featurebase",
"url": "https://github.com/FeatureBaseDB/featurebase/pull/2296",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2035482689
|
🛑 Foundry VTT 004 is down
In 68fdc25, Foundry VTT 004 ($FOUNDRY004) was down:
HTTP code: 502
Response time: 93 ms
Resolved: Foundry VTT 004 is back up in a67397c after 7 minutes.
|
gharchive/issue
| 2023-12-11T11:42:41 |
2025-04-01T04:55:04.995166
|
{
"authors": [
"FeistyViking"
],
"repo": "FeistyViking/crb_foundry-upptime",
"url": "https://github.com/FeistyViking/crb_foundry-upptime/issues/279",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1282777484
|
Error if nothing was selected
Open Command Center
Type some gibberish until the filtered list list empty
Hit <ENTER>
Alternatively, open Command Center without and bindings added and hit <ENTER>.
E5108: Error executing lua ...mand_center/lua/telescope/_extensions/command_center.lua:151: attempt to index local 'selection' (a nil value)
stack traceback:
...mand_center/lua/telescope/_extensions/command_center.lua:151: in function 'run_replace_or_original'
...ite/pack/paqs/opt/telescope/lua/telescope/actions/mt.lua:65: in function 'key_func'
.../site/pack/paqs/opt/telescope/lua/telescope/mappings.lua:242: in function 'execute_keymap'
[string ":lua"]:1: in main chunk
Telescope + CC config:
telescope.setup {
extensions = {
command_center = {
-- Change what to show on telescope prompt and in which order
-- Currently support the following three components
-- Components may repeat
components = {
command_center.component.DESCRIPTION,
command_center.component.KEYBINDINGS,
-- command_center.component.COMMAND,
},
-- Change the separator used to separate each component
separator = " ",
-- When set to false,
-- The description compoenent will be empty if it is not specified
auto_replace_desc_with_cmd = false,
}
}
}
-- Plug Command Center into Telescope
telescope.load_extension('command_center')
Fixed in e3b32c7a2b8ffbb92bd4b7158fcb44eb40ba5d20
|
gharchive/issue
| 2022-06-23T18:18:55 |
2025-04-01T04:55:04.997579
|
{
"authors": [
"FeiyouG",
"bugabinga"
],
"repo": "FeiyouG/command_center.nvim",
"url": "https://github.com/FeiyouG/command_center.nvim/issues/15",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2123516000
|
🛑 CloudIntegration Public is down
In fac0c13, CloudIntegration Public (https://cloudintegration.eu/) was down:
HTTP code: 0
Response time: 0 ms
Resolved: CloudIntegration Public is back up in 07ac218 after 1 hour, 57 minutes.
|
gharchive/issue
| 2024-02-07T17:21:00 |
2025-04-01T04:55:05.004585
|
{
"authors": [
"dajor"
],
"repo": "Fellow-Consulting-AG/upptime",
"url": "https://github.com/Fellow-Consulting-AG/upptime/issues/60",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2123626905
|
🛑 Extraction and Classifications API is down
In 27ee5ad, Extraction and Classifications API (https://fellowkv2.cloudintegration.eu/) was down:
HTTP code: 503
Response time: 499 ms
Resolved: Extraction and Classifications API is back up in 011424c after 8 minutes.
|
gharchive/issue
| 2024-02-07T18:26:30 |
2025-04-01T04:55:05.006974
|
{
"authors": [
"dajor"
],
"repo": "Fellow-Consulting-AG/upptime",
"url": "https://github.com/Fellow-Consulting-AG/upptime/issues/63",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
797044762
|
Adding a seperate line for admin in readme.md file and creating a Contributors table which updates automatically.
As of now , the Contributors table in the readme.md file is not up to date. Moreover one needs to update it manually each and every time. I wanna automate this by adding a new Contributors table which will update by itself.
Moreover , I wanna add a separate line to showcase the Project Admin if you want.
Can you please assign this to me ?
Thanks.
Can you please assign this to me ?
Thanks.
Great!
Hey @Femme-js , I've made a PR.
Please have a look,
|
gharchive/issue
| 2021-01-29T17:09:32 |
2025-04-01T04:55:05.009584
|
{
"authors": [
"Femme-js",
"Swastik1710"
],
"repo": "Femme-js/Hoaxify",
"url": "https://github.com/Femme-js/Hoaxify/issues/34",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1659810223
|
Основной сайт недоступен из-за CF
Это полностью исключает прямой доступ и усложняет проксирование до уровня, что нам лень думать как его настраивать.
это тоже всплывет снова? Многие веб-сайты сегодня активируют cloudflare, я не знаю, является ли это хаосом, который остановил многие экземпляры nhentai.
разрешилось само собой, кф убрали
|
gharchive/issue
| 2023-04-09T09:19:58 |
2025-04-01T04:55:05.011425
|
{
"authors": [
"Feodor0090",
"R0ci0-V3rd3al",
"shinovon"
],
"repo": "Feodor0090/njtai",
"url": "https://github.com/Feodor0090/njtai/issues/62",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2761313287
|
Considering a Environment Manager
@lesniakt Do you have any opinions/thoughts on our environment management strategy? Now would be a good time to switch rather then later.
I would like to stick with the anaconda environment and rename the environment so it doesn't overlap with the standard FINM environment used in classes and august review. This approach would be very familiar to new members coming from the FINM program. When we have tests we would build the package locally using pip install . -e and test would be run through a build instead of importing it from the folder over.
Using pipenv will make it easier to upgrade package versions. This allows you to run a command pipenv lock which upgrades all your package versions. We can also set this up so it automatically builds and installs the local package. I've worked with this a ton and is great. The downside being that the setup is different making it less friendly to new contributers in the FINM department.
If possible we should prioritize making ease of development for new contributers. I don't have a ton of experience upgrading an anaconda env so please add some thoughts if you have. I imagine we would simply reinstall the whole anaconda env (without version locks) and then update the requirements files.
I've personally not used pipenv. Typically for quick and dirty projects venv is sufficient, and for larger scale projects, especially production projects, I tend to see Conda used as usually there are non-python dependencies involved.
From the literature I've read, it seems like non-python dependencies is where pipenv would struggle. Numpy and scipy come to mind as potentially requiring non-python dependencies -- but again I haven't played with it. I would be curious how reproducible pipenv is with those, as this package will presumable use those dependencies,
I think the typical student in this program is just editing from requirements.txt files, so I share your concern on simplicity here.
My lean would be to just use the existing requirements.txt workflow until we have some level of code coverage. I think that is a reasonable prerequisite to have before changing environment management workflows, as we'll want reasonable certainty that the changes don't break workflows accidentally.
Regarding "ease of use" for upgrading packages, I would suggest looking at integration with RenovateBot. A quick looks says both conda/pipenv are supported. Again, we'd want code coverage in place before doing this.
|
gharchive/issue
| 2024-12-27T22:20:46 |
2025-04-01T04:55:05.026214
|
{
"authors": [
"lesniakt",
"smturro2"
],
"repo": "Fernando-Urbano/portfolio-management",
"url": "https://github.com/Fernando-Urbano/portfolio-management/issues/36",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1642758031
|
Projection with _id returns all fields
Versions
commit.txt: a06bd4bf1832bceed7189cff07d788cdb11e2155
version.txt: v0.9.4-1-ga06bd4bf
What did you do?
See repro in #2298.
What did you expect to see?
2 documents returned with just the _id field.
What did you see instead?
All fields.
Environment
- OS: Ubuntu
- Architecture: x86_64
- Version: 22.10
- Go: go version go1.20 linux/amd64
- Git: 2.37.2
- Deployment: Docker
- Deployment details: 23.0.1
See repro in https://github.com/FerretDB/FerretDB/pull/2298.
That PR should be re-opened and updated to check that this issue is indeed fixed
|
gharchive/issue
| 2023-03-27T20:20:35 |
2025-04-01T04:55:05.029201
|
{
"authors": [
"AlekSi",
"b1ron"
],
"repo": "FerretDB/FerretDB",
"url": "https://github.com/FerretDB/FerretDB/issues/2299",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1643459807
|
Use iterators for projections
After #2254.
Description
Closes #{issue_number}.
Readiness checklist
[ ] I added/updated unit tests.
[ ] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[ ] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[ ] I ensured that PR title is good enough for the changelog.
[ ] (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
[ ] I marked all done items in this checklist.
Merged into #2254.
|
gharchive/pull-request
| 2023-03-28T08:31:42 |
2025-04-01T04:55:05.033055
|
{
"authors": [
"AlekSi"
],
"repo": "FerretDB/FerretDB",
"url": "https://github.com/FerretDB/FerretDB/pull/2301",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1732279705
|
Make testFindAndModifyCompat work with compatTestCaseResultType
Description
Closes #2734.
Readiness checklist
[ ] I added/updated unit tests.
[x] I added/updated integration/compatibility tests.
[ ] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.
@w84thesun ah, thanks for checking! I haven't pushed the code 😅
|
gharchive/pull-request
| 2023-05-30T13:27:15 |
2025-04-01T04:55:05.036532
|
{
"authors": [
"rumyantseva"
],
"repo": "FerretDB/FerretDB",
"url": "https://github.com/FerretDB/FerretDB/pull/2739",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
639673110
|
Please ensure the server is running the latest version of all mod content
I get this issue whenever I try to join my server.
"Please ensure the server you are trying to join is running the latest version of all mod content"
Why?
~$ arkmanager checkmodupdate --updatemods @crystal
Running command 'checkmodupdate' for instance 'crystal'
All mods are up to date
EDIT
huh, now it works without anything changing. odd.
It could have been that the client hadn't finished updating its mods. Since mods do not have any inherent version, there is no way to tell whether the server or client has more up-to-date mods.
|
gharchive/issue
| 2020-06-16T13:38:23 |
2025-04-01T04:55:05.043431
|
{
"authors": [
"Sc0r",
"klightspeed"
],
"repo": "FezVrasta/ark-server-tools",
"url": "https://github.com/FezVrasta/ark-server-tools/issues/1112",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
390708050
|
Minor improvements
Just a bit of cleaning up.
Avoid doing the same job (loading the config) twice and move all the checks to top-level hooks.
I noticed that all the possible variable including the absolute path of the project where being added to the generated lambda so the last commit cleans that so only necessary variables are included.
|
gharchive/pull-request
| 2018-12-13T14:39:28 |
2025-04-01T04:55:05.045342
|
{
"authors": [
"juanjoDiaz"
],
"repo": "FidelLimited/serverless-plugin-warmup",
"url": "https://github.com/FidelLimited/serverless-plugin-warmup/pull/86",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
836877455
|
Implement log levels
Implement different log levels (Error, debug, info, etc).
Have log messages be able to be hidden or shown based on build environment variable or changed via a serial user interface
Implemented in a3bf35b2de76ca4b34aaf711bda04b4a4842dd4e
|
gharchive/issue
| 2021-03-20T18:11:39 |
2025-04-01T04:55:05.046372
|
{
"authors": [
"AlexLanzano"
],
"repo": "Field-Programmable-Smartwatch/firmware",
"url": "https://github.com/Field-Programmable-Smartwatch/firmware/issues/7",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
669317228
|
Refactor and remove OrgProfileComplete page, instead use the ProfileCompleted page
The call to action button should say View Help Board unless the unlogged in user clicked on Create a Post and went through the sign up process, in which case it should say Continue posting
Currently the pages look like this:
OrgProfileComplete
ProfileCompleted
@jyclam I'll take this on, but I wanted to clarify the ask here. It says "Refactor and remove OrgProfileComplete page". Am I refactoring OrgProfileComplete, or completely deleting it and just using "ProfileCompleted" where "OrgProfileComplete" is used?
Didn't mean to close. Let me know your thoughts on the above. I wanted to make sure I know what is wanted here before proceeding.
Also, how can i differentiate whether the user went through "Create Post" and then signed up, or whether they signed up the usual way.?
Hi @kterry1, from my understanding, there are 2 different pages (UI wise) that are trying to accomplish the same function. The main difference is the 2nd CTA changes depending on the path that you went through. With the ProfileCompleted page, we should be able to do everything that is needed.
There are 3 paths with the last CTA that changes.
1- if you click in register -> Check the Help Board
2- if you try to make a comment + like and you aren't signed in. -> Check the Post (the post that you were liking or commenting)
3- if you click on Create Post and you aren't signed in. -> Continue Posting
Let me know if there are other questions🙏🏽
Thanks @manualzuru! I'll dig into it today and see what I can do.
@jyclam @manualzuru So I did some testing with this. Since the Sign In, Create a post, and Join Now buttons all take you to '/auth/signup', I'm not seeing a way to conditionally render based on the path the user took to get to '/profile-completed' or '/create-organisation-complete' and have it all happen in one page. If the wording of that button is really important, then I'd say we could stick with multiple pages, otherwise, here is what I had so far, but I don't think it really accomplishes what is asked for: https://share.getcloudapp.com/OAuqOwG0
Maybe @joshmorel or @idjevm have an idea?
Side note: We need to change all instances of "organisation" in the codebase to "organization".
You can probably do a conditional sessionStorage like here https://github.com/FightPandemics/FightPandemics/blob/487e856300292dc7e754be23134b4025d3dfdb82/client/src/pages/PostPage.js#L162
https://developer.mozilla.org/en-US/docs/Web/API/Window/sessionStorage
I'll give that a try. Thanks!
The fix is based on jyclam's original post as it made the most sense.
@kterry1 @jyclam Sorry I didn't take a look at this early when you tagged me - since the PR is in.
I'm really apprehensive about using the same file/component for different routes. It can result in a hard to maintain situation as I see with our "Login.js" file - see #1164 (that one is more complex, so not exactly comparable but similar principle).
I think it would be better to have more re-usable components for similar pages but use one top-level file per route. You see this with a lot of filesystem based frameworks like vuex/next.js etc and I think it's a good approach.
With this PR #1328 - we need to fix the issues - but we should decide:
Make an exception here - and address the issues as described in my first comment in the PR
Or come up with a rule and stick to it - one file per route
Thoughts @robinv85 @idjevm ?
Also I did try to figure out what the design's flow is supposed to be after create org complete in Figma but it wasn't clear (https://www.figma.com/file/kT6SJLL4v3w06yFF2cGIun/FightPandemics-MVP?node-id=1852%3A8716). Is "View my profile" always supposed to go to MY profile as opposed to the recently created organisation's profile (current state). The latter makes more sense but the design doesn't indicate which. But also in such a case I'd expect the label to be different "View organisation" instead.
Maybe the design was incomplete after copy/paste from user profile? Any insight into this @manualzuru
|
gharchive/issue
| 2020-07-31T01:14:08 |
2025-04-01T04:55:05.058290
|
{
"authors": [
"joshmorel",
"jyclam",
"kterry1",
"manualzuru"
],
"repo": "FightPandemics/FightPandemics",
"url": "https://github.com/FightPandemics/FightPandemics/issues/1306",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
901390178
|
User Store 9.1-Unable to set the role for a member after accepting the applicant
Unable to set the role for a member after accepting the applicant.
please see the record on , near the end starting from 1:30
https://app.slack.com/client/T010BHVS3EF/C010BHVT1MZ/files/F022X4NME85
@adorapham Bug fix issued
@ChunPingYang @xJamesScott Looks like the issue is not fixed .
As an individual user even after i join the Org "Join Us" CTA button is not disabled .
Even when my application as an individual has been accepted "Join Us " CTA button is kept enabled. The individual name is listed as member in Members Tab.
As a owner of the account , unable to set the role permission.
The static data is populated in the Role description for Wiki editor and Administrator.
https://user-images.githubusercontent.com/51660881/120036342-01d77e00-bfce-11eb-88e5-8639e007f2f9.mp4
https://user-images.githubusercontent.com/51660881/120036352-04d26e80-bfce-11eb-946f-2ca737365fdf.mp4
https://user-images.githubusercontent.com/51660881/120036373-0c921300-bfce-11eb-8856-7310b676ecfc.mp4
https://user-images.githubusercontent.com/51660881/120036393-1287f400-bfce-11eb-9b03-2fa09c872adb.mp4
|
gharchive/issue
| 2021-05-25T21:27:46 |
2025-04-01T04:55:05.062251
|
{
"authors": [
"adorapham",
"hiran11",
"xJamesScott"
],
"repo": "FightPandemics/FightPandemics",
"url": "https://github.com/FightPandemics/FightPandemics/issues/2398",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
593642449
|
User Profile - Front End
[ ] frontend user profile
Here is the Requirements for Create Individual Profile UI
https://www.notion.so/fightpandemics/Create-Individual-Profile-UI-cf719e2292874303a2ce943c912bdbf3
Finished styling the user profile,
created edit-profile / edit-account routes and components
wip
styling on edit-profile and edit-account components
handle data flow for my activity in user profile
@CeesWang - any updates on this issue?
@indirabhowmick talking to T-Allen regarding further progress.
@CeesWang Thanks for the update. Please keep us posted on the progress of the issue
@CeesWang @T-Allen is this solved?
@manualzuru is this the same as issue #176 ?
It is the same mobile and desktop only styling changes depending on the device @T-Allen
I'm still confused, because going by what's on Zeplin, the pages seem quite different:
create-profile (desktop)
create-profile (mobile)
edit-profile (desktop)
edit-account-info (desktop)
@T-Allen by Mobile we meant mobile web not the native mobile app. Please reach out if there are any questions.
@indirabhowmick Right, I am working on the web app.
@T-Allen you are right. Those are 2 different screens, you are right. We need both for having profile.
Can we update this ticket or add another ticket and maybe tags to have a better view on the user profile status?
The user v2 data model is not implemented yet and I'm working on "create user" so I think both of these edit / view user aren't implemented with API yet?
No they are not implemented with API yet
On Tue, May 26, 2020 at 5:27 PM Robin Venneman notifications@github.com
wrote:
Can we update this ticket or add another ticket and maybe tags to have a
better view on the user profile status?
The user v2 data model is not implemented yet and I'm working on "create
user" so I think both of these edit / view user aren't implemented with API
yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/FightPandemics/FightPandemics/issues/50#issuecomment-634288870,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIAFWLSDD5OCCSNYDMC6JBLRTQX5DANCNFSM4L4OHU2Q
.
@CeesWang i'm working on this to finish some details and integrate with API
@robinv85 awesome let me know if theres anything I can do regarding this issue
|
gharchive/issue
| 2020-04-03T21:09:38 |
2025-04-01T04:55:05.071341
|
{
"authors": [
"CeesWang",
"MohamedEl1",
"T-Allen",
"indirabhowmick",
"manualzuru",
"robinv85"
],
"repo": "FightPandemics/FightPandemics",
"url": "https://github.com/FightPandemics/FightPandemics/issues/50",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
199443931
|
Should also export a viewing key
The Zcash protocol also has support for view keys. Views keys can determine if a tx has been received but not spend them.
I don't believe there is any support for view keys in the full node wallet yet but we could generate and export a view key that could immediately be imported by a user's full node.
Ah wonderful, I thought they didn't exist and wished they did.
Yep, let's add them, and add a mode to input the secret key instead of generating it, to get address/view key from a saved key.
|
gharchive/issue
| 2017-01-08T20:24:13 |
2025-04-01T04:55:05.079230
|
{
"authors": [
"FiloSottile",
"zmanian"
],
"repo": "FiloSottile/zcash-mini",
"url": "https://github.com/FiloSottile/zcash-mini/issues/1",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
2761624014
|
Fixed Grammar Issues and made it clearer and easier to read. Turkish
I hate Polite suffixes
Thank you! Merging now.
|
gharchive/pull-request
| 2024-12-28T08:10:41 |
2025-04-01T04:55:05.080272
|
{
"authors": [
"FinalForEach",
"scoundri"
],
"repo": "FinalForEach/Cosmic-Reach-Localization",
"url": "https://github.com/FinalForEach/Cosmic-Reach-Localization/pull/273",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
228009262
|
Element polyfill fails on UCBrowser Mini
The Element polyfill fails on UCBrowser Mini because
document node cannot have more than one child
The polyfill uses attachEvent. The event onpropertychange proprietary to IE. Irrespective of that, using addEventListener will prevent it from failing completely on other browsers that require Element polyfill.
createElement('*') is used, which is not valid.
Closing this as per https://github.com/Financial-Times/polyfill-service/pull/1201
|
gharchive/issue
| 2017-05-11T14:23:15 |
2025-04-01T04:55:05.097419
|
{
"authors": [
"JoyceBabu"
],
"repo": "Financial-Times/polyfill-service",
"url": "https://github.com/Financial-Times/polyfill-service/issues/1200",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2173126675
|
Revert "feat: apply the changes of Finschia v3.0.0-rc1"
Reverts Finschia/finschia-proxy#34
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.45%. Comparing base (2961479) to head (d2b5672).
Additional details and impacted files
@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 55.45% 55.45%
=======================================
Files 12 12
Lines 1502 1502
=======================================
Hits 833 833
Misses 616 616
Partials 53 53
Files
Coverage Δ
ante/ante.go
62.50% <ø> (ø)
ante/txfilter.go
85.93% <ø> (ø)
app/ante.go
0.00% <ø> (ø)
app/app.go
83.33% <ø> (ø)
app/encoding.go
100.00% <ø> (ø)
cmd/fnsad-proxy/cmd/root.go
34.20% <ø> (ø)
|
gharchive/pull-request
| 2024-03-07T07:09:08 |
2025-04-01T04:55:05.110659
|
{
"authors": [
"codecov-commenter",
"zemyblue"
],
"repo": "Finschia/finschia-proxy",
"url": "https://github.com/Finschia/finschia-proxy/pull/35",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1145457713
|
How can I get unify code from emoji?
How can I get unify code from emoji?
I click 'grinning face', its unified code is 1F600.
How can I get that value from emoji picker?
https://unicode.org/emoji/charts-13.0/full-emoji-list.html
Thank you very much
A emoji consists of runes. Simple emoji's like 'grinning face' only have 1 rune, if you add skin color etc they will have multiple runes. 1F600 is Hex which is nothing else like a number. So in dart the runes are from type Integer and you can easily format them to hex.
EmojiPicker(
onEmojiSelected: (Category category, Emoji emoji) {
emoji.emoji.runes.forEach((element) {
print(element.toRadixString(16));
});
}
...
)
I hope that helps you !
Thank you very much @Fintasys .
It is working
Thank you very much 🙏
When i select country flag..using emoji.emoji.runes.forEach((element) { print(element.toRadixString(16)); // 1F600 }); doesn't seem to work as country flag emoji unicode should be in this form (U+1F1E6-1F1EE)
|
gharchive/issue
| 2022-02-21T08:13:19 |
2025-04-01T04:55:05.114209
|
{
"authors": [
"EmmanyTaskWorld",
"Fintasys",
"tzthantzin"
],
"repo": "Fintasys/emoji_picker_flutter",
"url": "https://github.com/Fintasys/emoji_picker_flutter/issues/57",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
791858601
|
[firestore-scheduled-writes] Error logs appear even with successful writes
Expected Behavior
Logging should be successful and not contain error logs when a successful rite has been made.
Actual Behavior
An error log appears, stating the document cannot be found. The extensions appear to have worked as expected.
Steps to Reproduce the Problem
Follow standard directions for installation in README.
Run the example code snippet
const TEN_MINUTES_MS = 10 * 60 * 1000;
firebase
.firestore()
.collection("queued_writes")
.add({
state: "PENDING",
data: { message: "Hello from the future!" },
deliverTime: firebase.firestore.Timestamp.fromMillis(
Date.now() + TEN_MINUTES_MS
)
});
What happened? How can we make the problem occur?

Specifications
Extension name: firestore-schedule-writes
Version: 0.0.1
Is this being worked on?
If not I could issue a PR.
PR would be great! I didn't notice this issue until just now
On Fri, Jun 4, 2021, 6:43 AM YannicEl @.***> wrote:
Is this being worked on?
If not I could issue a PR.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/FirebaseExtended/experimental-extensions/issues/31#issuecomment-854733896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAH7S4CDQ365E2STOJ7E3TRDKANANCNFSM4WOHEFWA
.
the PR is ready
|
gharchive/issue
| 2021-01-22T09:47:59 |
2025-04-01T04:55:05.146857
|
{
"authors": [
"YannicEl",
"dackers86",
"mbleigh"
],
"repo": "FirebaseExtended/experimental-extensions",
"url": "https://github.com/FirebaseExtended/experimental-extensions/issues/31",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
588650509
|
[firebase_ml_vision] PDF417 reader is not working for DL
Trying to read a PDF417 barcode for a US DL using the new barcode library instead of the one from Google Mobile Vision but your lib is not properly reading and camera is unusable for Samsung S8 when resolution is set to ResolutionPreset.high.
Any ideas how can we use this feature from the new API?
I am testing with the example but I am not getting any good results.
Thank you
Hi @aantelov87
can you please provide your flutter doctor -v and flutter run --verbose?
Are you using official firebase_ml_vision example?
Thank you
Hi @TahaTesser
Yes, I am using the official firebase_ml_vision example but I just changed the following line
https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_ml_vision/example/lib/material_barcode_scanner.dart#L156
with
final ResolutionPreset preset = ResolutionPreset.high;
because with the resolution used in the official example, the detector is not able to detect PDF417 barcode for DL.
In the attachment flutter run --verbose when the resolution is set to high for PDF417 detection.
Please, let me know if you need anything else.
`flutter doctor -v
[✓] Flutter (Channel stable, v1.12.13+hotfix.8, on Mac OS X 10.15.3 19D76, locale en-US)
• Flutter version 1.12.13+hotfix.8 at /Users/aantelov/GPN/flutter
• Framework revision 0b8abb4724 (6 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/aantelov/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• ANDROID_HOME = /Users/aantelov/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS
✗ Xcode installation is incomplete; a full installation is necessary for iOS development.
Download at: https://developer.apple.com/xcode/download/
Or install Xcode via the App Store.
Once installed, run:
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
sudo xcodebuild -runFirstLaunch
• CocoaPods version 1.9.0
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[✓] Connected device (1 available)
• SM G950F • ce06182664a6821703 • android-arm64 • Android 9 (API 28)
`
output-modified.txt
Hello @TahaTesser
Have I added the issue in the correct project? because it looks like nobody is looking into this since 6 days ago.
|
gharchive/issue
| 2020-03-26T18:51:13 |
2025-04-01T04:55:05.156136
|
{
"authors": [
"TahaTesser",
"aantelov87"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/2242",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
724631310
|
🐛 [Firebase_Auth] PhoneAuthProvider.credential() returns AuthCredential instead of PhoneAuthCredential
Bug report
Calling PhoneAuthProvider.credential() returns AuthCredential instead of PhoneAuthCredential as stated in the docs
Steps to reproduce
Steps to reproduce the behavior:
Follow steps to set up phone verification as per the documentation: https://firebase.flutter.dev/docs/auth/phone/
Expected behavior
PhoneAuthProvider.credential() should return an PhoneAuthCredential when provided the verificationId and smsCode.
Additional context
The expected return type of PhoneAuthCredential will enable updating of the user phone number when calling FirebaseAuth.instance.currentUser.updatePhoneNumber(phoneCredential).
Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
[✓] Flutter (Channel stable, 1.22.1, on Microsoft Windows [Version 10.0.19041.508], locale en-US)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
✗ Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.50.1)
[✓] VS Code, 64-bit edition (version 1.50.1)
[✓] Connected device (1 available)
Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 2.10.1
Flutter SDK 1.22.1
manager 1.0.0+1
dependencies:
- after_layout 1.0.7+2 [flutter]
- auto_route 0.6.9 [flutter meta]
- cached_network_image 2.3.3 [flutter flutter_cache_manager octo_image]
- carousel_slider 2.3.1 [flutter]
- cloud_firestore 0.14.1+3 [flutter meta quiver firebase_core firebase_core_platform_interface cloud_firestore_platform_interface cloud_firestore_web]
- cloud_functions 0.6.0+1 [meta flutter firebase_core cloud_functions_platform_interface cloud_functions_web]
- connectivity 0.4.9+5 [flutter meta connectivity_platform_interface connectivity_macos connectivity_for_web]
- cupertino_icons 1.0.0
- firebase_analytics 6.0.2 [meta flutter firebase_core firebase_analytics_web firebase_analytics_platform_interface]- firebase_auth 0.18.1+2 [meta firebase_core firebase_core_platform_interface firebase_auth_platform_interface firebase_auth_web flutter]
- firebase_core 0.5.0+1 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- firebase_messaging 7.0.3 [meta flutter firebase_core]
- firebase_performance 0.4.0+2 [flutter firebase_core]
- firebase_storage 4.0.1 [flutter firebase_core]
- fl_chart 0.12.0 [flutter path_drawing equatable]
- flushbar 1.10.4 [flutter]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_dotenv 2.1.0 [flutter meta]
- flutter_image_compress 0.7.0 [flutter]
- flutter_picker 1.1.5 [flutter]
- flutter_riverpod 0.11.2 [flutter collection riverpod state_notifier meta]
- flutter_spinkit 4.1.2+1 [flutter]
- image_cropper 1.3.1 [flutter]
- image_picker 0.6.7+12 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- intl 0.16.1 [path]
- path_provider 1.6.21 [flutter path_provider_platform_interface path_provider_macos path_provider_linux path_provider_windows]
- permission_handler 5.0.1+1 [flutter meta permission_handler_platform_interface]
- photo_view 0.10.2 [flutter]
- rxdart 0.24.1
- shimmer 1.1.2 [flutter]
- tuple 1.0.3 [quiver]
- url_launcher 5.7.5 [flutter url_launcher_platform_interface url_launcher_web url_launcher_linux url_launcher_macos url_launcher_windows]
dev dependencies:
- auto_route_generator 0.6.10 [build source_gen analyzer path build_runner auto_route]
- build_runner 1.10.3 [args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style glob graphs http_multi_server io js logging meta mime path pedantic pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- lint 1.3.0
transitive dependencies:
- _fe_analyzer_shared 11.0.0 [meta]
- analyzer 0.40.4 [_fe_analyzer_shared args charcode cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- args 1.6.0
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- build 1.5.0 [analyzer async convert crypto logging meta path glob]
- build_config 0.4.2 [checked_yaml json_annotation meta path pubspec_parse yaml]
- build_daemon 2.1.4 [built_collection built_value http_multi_server logging pedantic path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 1.4.1 [analyzer build crypto graphs logging meta path package_config pool pub_semver]
- build_runner_core 6.0.3 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pedantic pool timing watcher yaml]
- built_collection 4.3.2 [collection quiver]
- built_value 7.1.0 [built_collection collection fixnum quiver]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- checked_yaml 1.0.2 [json_annotation source_span yaml]
- cli_util 0.2.0 [path]
- clock 1.1.0-nullsafety.1
- cloud_firestore_platform_interface 2.1.2 [flutter meta collection firebase_core plugin_platform_interface]
- cloud_firestore_web 0.2.0+4 [flutter flutter_web_plugins firebase http_parser meta firebase_core cloud_firestore_platform_interface js]
- cloud_functions_platform_interface 2.0.0 [flutter meta firebase_core plugin_platform_interface]
- cloud_functions_web 2.0.0 [cloud_functions_platform_interface flutter flutter_web_plugins firebase http_parser meta]
- code_builder 3.5.0 [built_collection built_value collection matcher meta]
- collection 1.15.0-nullsafety.3
- connectivity_for_web 0.3.1+2 [connectivity_platform_interface flutter_web_plugins flutter]
- connectivity_macos 0.1.0+5 [flutter]
- connectivity_platform_interface 1.0.6 [flutter meta plugin_platform_interface]
- convert 2.1.1 [charcode typed_data]
- crypto 2.1.5 [collection convert typed_data]
- dart_style 1.3.7 [analyzer args path source_span]
- equatable 1.2.5 [collection meta]
- fake_async 1.2.0-nullsafety.1 [clock collection]
- ffi 0.1.3
- file 5.2.1 [intl meta path]
- firebase 7.3.0 [http http_parser js]
- firebase_analytics_platform_interface 1.0.3 [flutter meta]
- firebase_analytics_web 0.1.1 [flutter flutter_web_plugins firebase firebase_analytics_platform_interface meta]
- firebase_auth_platform_interface 2.1.1 [flutter meta firebase_core plugin_platform_interface]
- firebase_auth_web 0.3.1+1 [flutter flutter_web_plugins firebase meta http_parser intl firebase_core firebase_auth_platform_interface js]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.0 [firebase firebase_core_platform_interface flutter flutter_web_plugins meta js]
- fixnum 0.10.11
- flutter_blurhash 0.5.0 [flutter meta]
- flutter_cache_manager 1.4.2 [flutter path_provider uuid http path sqflite pedantic clock file rxdart]
- flutter_plugin_android_lifecycle 1.0.11 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- freezed_annotation 0.12.0 [collection json_annotation meta]
- glob 1.2.0 [async collection node_io path pedantic string_scanner]
- graphs 0.2.0
- http 0.12.2 [http_parser path pedantic]
- http_multi_server 2.2.0 [async]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- image_picker_platform_interface 1.1.1 [flutter meta http plugin_platform_interface]
- io 0.3.4 [charcode meta path string_scanner]
- js 0.6.2
- json_annotation 3.1.0
- logging 0.11.4
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- mime 0.9.7
- node_interop 1.1.1 [js]
- node_io 1.1.1 [node_interop path]
- octo_image 0.3.0 [flutter flutter_blurhash]
- package_config 1.9.3 [path charcode]
- path 1.8.0-nullsafety.1
- path_drawing 0.4.1+1 [vector_math meta path_parsing flutter]
- path_parsing 0.1.4 [vector_math meta]
- path_provider_linux 0.0.1+2 [path xdg_directories path_provider_platform_interface flutter]
- path_provider_macos 0.0.4+4 [flutter]
- path_provider_platform_interface 1.0.3 [flutter meta platform plugin_platform_interface]
- path_provider_windows 0.0.4+1 [path_provider_platform_interface meta path flutter ffi win32]
- pedantic 1.9.2 [meta]
- permission_handler_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- platform 2.2.1
- plugin_platform_interface 1.0.3 [meta]
- pool 1.4.0 [async stack_trace]
- process 3.0.13 [file intl meta path platform]
- pub_semver 1.4.4 [collection]
- pubspec_parse 0.1.5 [checked_yaml json_annotation pub_semver yaml]
- quiver 2.1.3 [matcher meta]
- riverpod 0.11.2 [meta collection freezed_annotation state_notifier]
- shelf 0.7.9 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 0.2.3 [shelf web_socket_channel stream_channel]
- sky_engine 0.0.99
- source_gen 0.9.7+1 [analyzer async build dart_style glob meta path pedantic source_span]
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- sqflite 1.3.1+1 [flutter sqflite_common path]
- sqflite_common 1.0.2+1 [synchronized path meta]
- stack_trace 1.10.0-nullsafety.1 [path]
- state_notifier 0.6.0 [meta]
- stream_channel 2.1.0-nullsafety.1 [async]
- stream_transform 1.2.0
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- synchronized 2.2.0+2
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timing 0.1.1+2 [json_annotation]
- typed_data 1.3.0-nullsafety.3 [collection]
- url_launcher_linux 0.0.1+1 [flutter]
- url_launcher_macos 0.0.1+8 [flutter]
- url_launcher_platform_interface 1.0.8 [flutter meta plugin_platform_interface]
- url_launcher_web 0.1.4+1 [url_launcher_platform_interface flutter flutter_web_plugins meta]
- url_launcher_windows 0.0.1+1 [flutter]
- uuid 2.2.2 [crypto convert]
- vector_math 2.1.0-nullsafety.3
- watcher 0.9.7+15 [async path pedantic]
- web_socket_channel 1.1.0 [async crypto stream_channel]
- win32 1.7.3 [ffi]
- xdg_directories 0.1.2 [meta path process]
- yaml 2.2.1 [charcode collection string_scanner source_span]
In the new version, you should expect an AuthCredential response.
How then do I get the PhoneAuthCredential to update a user's phone number? It could be done in the older version with the value PhoneAuthProvider.credential() returned. The official docs also state that PhoneAuthCredential should be the return type. Kinda confused.
Please refer to this link: https://firebase.flutter.dev/docs/auth/phone. Please confirm what version of flutter_auth you are using.
firebase_auth: ^0.18.1+2
Docs:
FirebaseAuth auth = FirebaseAuth.instance;
await auth.verifyPhoneNumber(
phoneNumber: '+44 7123 123 456',
codeSent: (String verificationId, int resendToken) async {
// Update the UI - wait for the user to enter the SMS code
String smsCode = 'xxxx';
// Create a PhoneAuthCredential with the code
PhoneAuthCredential phoneAuthCredential = PhoneAuthProvider.credential(verificationId: verificationId, smsCode: smsCode);
// Sign the user in (or link) with the credential
await auth.signInWithCredential(phoneAuthCredential);
},
);
Please try replicating it to see what I mean.
There is an error with the documentation. Just do this:
FirebaseAuth auth = FirebaseAuth.instance;
await auth.verifyPhoneNumber(
phoneNumber: '+44 7123 123 456',
codeSent: (String verificationId, int resendToken) async {
// Update the UI - wait for the user to enter the SMS code
String smsCode = 'xxxx';
// Create a PhoneAuthCredential with the code
AuthCredential AuthCredential = PhoneAuthProvider.credential(verificationId: verificationId, smsCode: smsCode);
// Sign the user in (or link) with the credential
await auth.signInWithCredential(authCredential);
},
);
The documentation does seem incorrect.
Official example:
https://github.com/FirebaseExtended/flutterfire/blob/2273334b4d661850f5120b5b3c96bb617a964d05/packages/firebase_auth/firebase_auth/example/lib/signin_page.dart#L473-L476
Documentation
PhoneAuthCredential phoneAuthCredential = PhoneAuthProvider.credential(verificationId: verificationId, smsCode: smsCode);
How do I submit a PR for changing the documentation for this issue? @markusaksli-nc
@rish07 These links should get you started
https://github.com/FirebaseExtended/flutterfire/blob/master/CONTRIBUTING.md
https://github.com/FirebaseExtended/flutterfire/blob/master/website/README.md
https://github.com/FirebaseExtended/flutterfire/blob/master/docs/auth/phone.mdx
What is the right way to update the user's phone number?
|
gharchive/issue
| 2020-10-19T13:53:26 |
2025-04-01T04:55:05.168799
|
{
"authors": [
"PrincekO",
"heychirag",
"markusaksli-nc",
"ollerandres",
"rish07"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/3908",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
1115719920
|
🐛 [firebase_auth] Cannot handle quota-exceeded error on Android
Bug report
Describe the bug
We use the phone auth.
We've tried to authenticate multiple times with the spark(free) plan.
We were able to handle the quota-exceeded error on iOS, but we only got the too-many-requests error on Android.
However, when we changed to the blaze(paid) plan, we only got too-many-request errors on iOS as well.
Steps to reproduce
Send SMS multiple times
I called FirebaseAuth.instance.verifyPhoneNumber
Handle verificationFailed on Android and iOS
Expected behavior
Handle the quota-exceeded error on Android
Flutter doctor
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.8.0, on macOS 11.6.1 20G224 darwin-x64, locale ja-JP)
[!] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
✗ cmdline-tools component is missing
Run `path/to/sdkmanager --install "cmdline-tools;latest"`
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run `flutter doctor --android-licenses` to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] Android Studio (version 2020.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.2.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2021.1.2)
[✓] Connected device (3 available)
Flutter dependencies
Click To Expand
Dart SDK 2.15.0
Flutter SDK 2.8.0
m3pay 1.14.0+24
dependencies:
- cached_network_image 3.1.0+1 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- camera 0.9.4+6 [camera_platform_interface camera_web flutter pedantic quiver flutter_plugin_android_lifecycle]
- collection 1.15.0
- convex_bottom_bar 3.0.0 [flutter]
- device_info_plus 3.1.1 [flutter device_info_plus_platform_interface device_info_plus_linux device_info_plus_macos device_info_plus_web device_info_plus_windows]
- dio 4.0.4 [http_parser path]
- dotted_border 2.0.0+2 [flutter path_drawing]
- email_validator 2.0.1
- firebase_analytics 8.3.4 [firebase_analytics_platform_interface firebase_analytics_web firebase_core flutter meta]
- firebase_auth 3.2.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 1.10.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 2.3.0 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_dynamic_links 3.0.1 [firebase_core flutter]
- firebase_messaging 11.1.0 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]
- flutter_hooks 0.18.0 [flutter]
- flutter_inappwebview 5.3.2 [flutter]
- flutter_linkify 5.0.2 [flutter linkify]
- flutter_local_notifications 9.0.3 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection meta path typed_data vector_math]
- flutter_speed_dial 4.6.6 [flutter]
- flutter_stripe 2.0.2 [flutter stripe_android stripe_ios stripe_platform_interface]
- flutter_svg 1.0.0 [flutter meta path_drawing vector_math xml]
- freezed_annotation 1.0.0 [collection json_annotation meta]
- geolocator 7.7.1 [flutter geolocator_platform_interface geolocator_android geolocator_apple geolocator_web]
- git_info_plus 0.0.4 [flutter]
- google_maps_flutter 2.1.0 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface]
- hooks_riverpod 1.0.0 [collection flutter flutter_hooks flutter_riverpod riverpod state_notifier]
- image 3.0.8 [archive meta xml]
- intl_utils 2.5.1 [analyzer archive args dart_style http intl path petitparser yaml]
- json_annotation 4.3.0 [meta]
- kana_kit 2.0.0 [equatable]
- logger 1.1.0
- openapi 1.0.0 [dio built_value built_collection]
- package_info_plus 1.3.0 [flutter package_info_plus_platform_interface package_info_plus_linux package_info_plus_macos package_info_plus_windows package_info_plus_web]
- path_provider 2.0.6 [flutter path_provider_linux path_provider_macos path_provider_platform_interface path_provider_windows]
- permission_handler 8.2.6 [flutter meta permission_handler_platform_interface]
- phone_number 0.12.0+1 [flutter meta]
- qr_code_scanner 0.6.1 [js flutter flutter_web_plugins]
- shared_preferences 2.0.8 [flutter meta shared_preferences_linux shared_preferences_macos shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- shimmer 2.0.0 [flutter]
- sms_autofill 2.2.0 [pin_input_text_field flutter]
- time_machine 0.9.17 [meta collection]
- transparent_image 2.0.0
- tuple 2.0.0 [quiver]
- url_launcher 6.0.12 [flutter meta url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
dev dependencies:
- build_runner 2.1.5 [args async analyzer build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_launcher_icons 0.9.2 [args image path yaml]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]
- freezed 1.0.0 [analyzer build build_config collection meta source_gen freezed_annotation]
- json_serializable 6.0.1 [analyzer async build build_config collection json_annotation meta path pub_semver pubspec_parse source_gen source_helper]
- mockito 5.0.16 [analyzer build code_builder collection dart_style matcher meta path source_gen test_api]
dependency overrides:
- freezed_annotation 1.0.0 [collection json_annotation meta]
transitive dependencies:
- _fe_analyzer_shared 30.0.0 [meta]
- analyzer 2.7.0 [_fe_analyzer_shared cli_util collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- archive 3.1.2 [crypto path]
- args 2.3.0
- async 2.8.2 [collection meta]
- boolean_selector 2.1.0 [source_span string_scanner]
- build 2.1.1 [analyzer async convert crypto glob logging meta path]
- build_config 1.0.0 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 3.0.0 [built_collection built_value http_multi_server logging pedantic path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.0.4 [analyzer async build crypto graphs logging path package_config pool pub_semver stream_transform yaml]
- build_runner_core 7.2.2 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta path package_config pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.1.2 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 1.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.1 [flutter flutter_cache_manager cached_network_image_platform_interface]
- camera_platform_interface 2.1.1 [cross_file flutter meta plugin_platform_interface stream_transform]
- camera_web 0.2.1+1 [camera_platform_interface flutter flutter_web_plugins stream_transform]
- characters 1.2.0
- charcode 1.3.1
- checked_yaml 2.0.1 [json_annotation source_span yaml]
- cli_util 0.3.3 [meta path]
- clock 1.1.0
- code_builder 4.1.0 [built_collection built_value collection matcher meta]
- convert 3.0.1 [typed_data]
- cross_file 0.3.1+5 [flutter meta]
- crypto 3.0.1 [collection typed_data]
- dart_style 2.1.0 [analyzer args path pub_semver source_span]
- dbus 0.5.6 [args ffi meta pedantic xml]
- device_info_plus_linux 2.1.0 [device_info_plus_platform_interface file flutter meta]
- device_info_plus_macos 2.2.0 [device_info_plus_platform_interface flutter]
- device_info_plus_platform_interface 2.2.1 [flutter meta plugin_platform_interface]
- device_info_plus_web 2.1.0 [device_info_plus_platform_interface flutter_web_plugins flutter]
- device_info_plus_windows 2.1.0 [device_info_plus_platform_interface ffi flutter win32]
- equatable 2.0.3 [collection meta]
- fake_async 1.2.0 [clock collection]
- ffi 1.1.2
- file 6.1.2 [meta path]
- firebase 9.0.2 [http http_parser js]
- firebase_analytics_platform_interface 2.0.1 [flutter meta]
- firebase_analytics_web 0.3.0+1 [firebase firebase_analytics_platform_interface flutter flutter_web_plugins meta]
- firebase_auth_platform_interface 6.1.4 [firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 3.2.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser intl js meta]
- firebase_core_platform_interface 4.1.0 [collection flutter meta plugin_platform_interface]
- firebase_core_web 1.2.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.1.6 [collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 3.0.9 [firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 2.1.0 [firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.0.0
- flutter_blurhash 0.6.0 [flutter meta pedantic]
- flutter_cache_manager 3.1.2 [clock collection file flutter http path path_provider pedantic rxdart sqflite uuid]
- flutter_local_notifications_linux 0.3.0 [flutter flutter_local_notifications_platform_interface dbus path xdg_directories]
- flutter_local_notifications_platform_interface 5.0.0 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.3 [flutter]
- flutter_riverpod 1.0.0 [collection flutter meta riverpod state_notifier]
- flutter_web_plugins 0.0.0 [flutter js characters collection meta typed_data vector_math]
- frontend_server_client 2.1.2 [async path]
- geolocator_android 2.1.0 [flutter geolocator_platform_interface]
- geolocator_apple 1.2.0 [flutter geolocator_platform_interface]
- geolocator_platform_interface 2.3.5 [flutter plugin_platform_interface vector_math meta]
- geolocator_web 2.0.6 [flutter flutter_web_plugins geolocator_platform_interface]
- glob 2.0.1 [async collection file path pedantic string_scanner]
- google_maps_flutter_platform_interface 2.1.3 [collection flutter meta plugin_platform_interface stream_transform]
- graphs 2.1.0 [collection]
- http 0.13.3 [async http_parser meta path pedantic]
- http_multi_server 3.0.1 [async]
- http_parser 4.0.0 [charcode collection source_span string_scanner typed_data]
- intl 0.17.0 [clock path]
- io 1.0.3 [meta path string_scanner]
- js 0.6.3
- linkify 4.1.0
- logging 1.0.2
- matcher 0.12.11 [stack_trace]
- meta 1.7.0
- mime 1.0.0
- octo_image 1.0.0+1 [flutter flutter_blurhash]
- package_config 2.0.2 [path]
- package_info_plus_linux 1.0.3 [package_info_plus_platform_interface flutter path]
- package_info_plus_macos 1.3.0 [flutter]
- package_info_plus_platform_interface 1.0.2 [flutter meta plugin_platform_interface]
- package_info_plus_web 1.0.4 [flutter flutter_web_plugins http meta package_info_plus_platform_interface]
- package_info_plus_windows 1.0.4 [package_info_plus_platform_interface ffi flutter win32]
- path 1.8.0
- path_drawing 1.0.0 [vector_math meta path_parsing flutter]
- path_parsing 1.0.0 [vector_math meta]
- path_provider_linux 2.1.0 [flutter path path_provider_platform_interface xdg_directories]
- path_provider_macos 2.0.2 [flutter]
- path_provider_platform_interface 2.0.1 [flutter meta platform plugin_platform_interface]
- path_provider_windows 2.0.3 [ffi flutter meta path path_provider_platform_interface win32]
- pedantic 1.11.1
- permission_handler_platform_interface 3.7.0 [flutter meta plugin_platform_interface]
- petitparser 4.3.0 [meta]
- pin_input_text_field 4.1.1 [flutter]
- platform 3.0.2
- plugin_platform_interface 2.0.1 [meta]
- pool 1.5.0 [async stack_trace]
- process 4.2.3 [file path platform]
- pub_semver 2.1.0 [collection meta]
- pubspec_parse 1.0.0 [checked_yaml collection json_annotation pub_semver yaml]
- quiver 3.0.1 [matcher]
- riverpod 1.0.0 [collection meta state_notifier]
- rxdart 0.27.2
- shared_preferences_linux 2.0.2 [file meta flutter path path_provider_linux shared_preferences_platform_interface]
- shared_preferences_macos 2.0.2 [flutter shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.0.0 [flutter]
- shared_preferences_web 2.0.2 [flutter flutter_web_plugins meta shared_preferences_platform_interface]
- shared_preferences_windows 2.0.2 [flutter file meta path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.2.0 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.1 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.1.1 [analyzer async build dart_style glob meta path source_span yaml]
- source_helper 1.3.0 [analyzer collection source_gen]
- source_span 1.8.1 [collection path term_glyph]
- sqflite 2.0.0+4 [flutter sqflite_common path]
- sqflite_common 2.0.1+1 [synchronized path meta]
- stack_trace 1.10.0 [path]
- state_notifier 0.7.1 [meta]
- stream_channel 2.1.0 [async]
- stream_transform 2.0.0
- string_scanner 1.1.0 [charcode source_span]
- stripe_android 2.0.2 [flutter]
- stripe_ios 2.0.2 [flutter]
- stripe_platform_interface 2.0.2 [flutter freezed_annotation json_annotation meta plugin_platform_interface]
- synchronized 3.0.0
- term_glyph 1.2.0
- test_api 0.4.3 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- timezone 0.8.0 [path]
- timing 1.0.0 [json_annotation]
- typed_data 1.3.0 [collection]
- url_launcher_linux 2.0.2 [flutter]
- url_launcher_macos 2.0.2 [flutter]
- url_launcher_platform_interface 2.0.4 [flutter plugin_platform_interface]
- url_launcher_web 2.0.4 [flutter flutter_web_plugins meta url_launcher_platform_interface]
- url_launcher_windows 2.0.2 [flutter]
- uuid 3.0.4 [crypto]
- vector_math 2.1.1
- watcher 1.0.0 [async path pedantic]
- web_socket_channel 2.1.0 [async crypto stream_channel]
- win32 2.2.9 [ffi]
- xdg_directories 0.2.0 [meta path process]
- xml 5.3.0 [collection meta petitparser]
- yaml 3.1.0 [collection source_span string_scanner]
@AAkira
There's similar open issue describing your case, https://github.com/FirebaseExtended/flutterfire/issues/6687, so please follow-up in it for further updates.
Closing this as a duplicate. Also take a look at this related open PR: https://github.com/FirebaseExtended/flutterfire/pull/3402
|
gharchive/issue
| 2022-01-27T03:08:55 |
2025-04-01T04:55:05.177719
|
{
"authors": [
"AAkira",
"darshankawar"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/issues/7956",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
577642954
|
[firebase_auth plugin] README.md Updated
Description
I had just updated the README.md file. There isn't any deletion of any pre-existed info in README.md
Related Issues
There isn't any issue created for this, but I thought it would be very helpful to add some examples of doing Firebase Facebook and Firebase Twitter authentication.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.
[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the CLA.
[x] I am willing to follow-up on review comments in a timely manner.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.
@chinkysight Thanks for the PR, would you mind rebasing this so that the tests can pass and I'll be happy to review.
|
gharchive/pull-request
| 2020-03-09T03:55:22 |
2025-04-01T04:55:05.187488
|
{
"authors": [
"chinkysight",
"kroikie"
],
"repo": "FirebaseExtended/flutterfire",
"url": "https://github.com/FirebaseExtended/flutterfire/pull/2148",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
548627683
|
bug in apt.repo()?
I'm running into an issue using apt.repo().
Am I missing something?
$ cat mike.py
from pyinfra.modules import apt
SUDO = True
apt.repo(
{'Install VirtualBox repo'},
'deb https://download.virtualbox.org/virtualbox/debian bionic contrib',
)
$ rm pyinfra-debug.log
rm: pyinfra-debug.log: No such file or directory
$ pyinfra -vv --debug @docker/ubuntu:bionic mike.py
[pyinfra_cli.main] Checking potential directory:
[pyinfra_cli.main] Setting directory to:
--> Loading config...
--> Loading inventory...
[pyinfra_cli.inventory] Creating fake inventory...
[pyinfra.api.inventory] Expanding inventory connector: docker
The @docker connector is in Alpha!
[pyinfra_cli.inventory] Looking for group data in: group_data/all.py
[pyinfra_cli.inventory] Looking for group data in: group_data/bsd.py
[pyinfra.api.inventory] Expanding inventory connector: docker
--> Connecting to hosts...
localhost: >>> docker run -d ubuntu:bionic sleep 10000
localhost: a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05
[pyinfra.api.state] Activating host: ubuntu:bionic
--> Preparing operations...
Loading: mike.py
[pyinfra.api.operation] Adding operation, {'Install VirtualBox repo'}, called @ mike.py:7, opLines=(0, 7), opHash=97d8032458c50f8c46e458a4ca15c67a69be92b3
[pyinfra.api.facts] Getting fact: apt_sources (ensure_hosts: (ubuntu:bionic,))
[pyinfra.api.util] Building command (shell_executable: sh): docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "cat /etc/apt/sources.list /etc/apt/sources.list.d/*.list || true"
[pyinfra.api.connectors.local] --> Running command on localhost: sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "cat /etc/apt/sources.list /etc/apt/sources.list.d/*.list || true"'
[ubuntu:bionic] >>> sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "cat /etc/apt/sources.list /etc/apt/sources.list.d/*.list || true"'
[ubuntu:bionic] # See http://help.ubuntu.com/community/UpgradeNotes for how to upgrade to
[ubuntu:bionic] # newer versions of the distribution.
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic main restricted
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic main restricted
[ubuntu:bionic]
[ubuntu:bionic] ## Major bug fix updates produced after the final release of the
[ubuntu:bionic] ## distribution.
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic-updates main restricted
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic-updates main restricted
[ubuntu:bionic]
[ubuntu:bionic] ## N.B. software from this repository is ENTIRELY UNSUPPORTED by the Ubuntu
[ubuntu:bionic] ## team. Also, please note that software in universe WILL NOT receive any
[ubuntu:bionic] ## review or updates from the Ubuntu security team.
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic universe
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic universe
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic-updates universe
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic-updates universe
[ubuntu:bionic]
[ubuntu:bionic] ## N.B. software from this repository is ENTIRELY UNSUPPORTED by the Ubuntu
[ubuntu:bionic] ## team, and may not be under a free licence. Please satisfy yourself as to
[ubuntu:bionic] ## your rights to use the software. Also, please note that software in
[ubuntu:bionic] ## multiverse WILL NOT receive any review or updates from the Ubuntu
[ubuntu:bionic] ## security team.
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic multiverse
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic multiverse
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic-updates multiverse
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic-updates multiverse
[ubuntu:bionic]
[ubuntu:bionic] ## N.B. software from this repository may not have been tested as
[ubuntu:bionic] ## extensively as that contained in the main release, although it includes
[ubuntu:bionic] ## newer versions of some applications which may provide useful features.
[ubuntu:bionic] ## Also, please note that software in backports WILL NOT receive any review
[ubuntu:bionic] ## or updates from the Ubuntu security team.
[ubuntu:bionic] deb http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted universe multiverse
[ubuntu:bionic] # deb-src http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted universe multiverse
[ubuntu:bionic]
[ubuntu:bionic] ## Uncomment the following two lines to add software from Canonical's
[ubuntu:bionic] ## 'partner' repository.
[ubuntu:bionic] ## This software is not part of Ubuntu, but is offered by Canonical and the
[ubuntu:bionic] ## respective vendors as a service to Ubuntu users.
[ubuntu:bionic] # deb http://archive.canonical.com/ubuntu bionic partner
[ubuntu:bionic] # deb-src http://archive.canonical.com/ubuntu bionic partner
[ubuntu:bionic]
[ubuntu:bionic] deb http://security.ubuntu.com/ubuntu/ bionic-security main restricted
[ubuntu:bionic] # deb-src http://security.ubuntu.com/ubuntu/ bionic-security main restricted
[ubuntu:bionic] deb http://security.ubuntu.com/ubuntu/ bionic-security universe
[ubuntu:bionic] # deb-src http://security.ubuntu.com/ubuntu/ bionic-security universe
[ubuntu:bionic] deb http://security.ubuntu.com/ubuntu/ bionic-security multiverse
[ubuntu:bionic] # deb-src http://security.ubuntu.com/ubuntu/ bionic-security multiverse
[ubuntu:bionic] cat: '/etc/apt/sources.list.d/*.list': No such file or directory
[pyinfra.api.connectors.local] --> Waiting for exit status...
[pyinfra.api.connectors.local] --> Command exit status: 0
Loaded fact apt_sources
[pyinfra.api.facts] Getting fact: find_in_file (ensure_hosts: (ubuntu:bionic,))
[pyinfra.api.util] Building command (shell_executable: sh): docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" /etc/apt/sources.list || (find /etc/apt/sources.list -type f > /dev/null && echo "__pyinfra_exists_/etc/apt/sources.list")"
[pyinfra.api.connectors.local] --> Running command on localhost: sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" /etc/apt/sources.list || (find /etc/apt/sources.list -type f > /dev/null && echo "__pyinfra_exists_/etc/apt/sources.list")"'
[ubuntu:bionic] >>> sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" /etc/apt/sources.list || (find /etc/apt/sources.list -type f > /dev/null && echo "__pyinfra_exists_/etc/apt/sources.list")"'
| fact: find_in_file('/etc/apt/sources.list', '^.*deb https://download.virtualbox.org/virtualbox/debian bi / fact: find_in_file('/etc/apt/sources.list', '^.*deb https://download.virtualbox.org/virtualbox/debian bi - fact: find_in_file('/etc/apt/sources.list', '^.*deb https://download.virtualbox.org/virtualbox/debian bi \ fact: find_in_file('/etc/apt/sources.list', '^.*deb https://download.virtualbox.org/virtualbox/debian bi[pyinfra.api.connectors.local] --> Waiting for exit status...
[pyinfra.api.connectors.local] --> Command exit status: 1
Loaded fact find_in_file: ('/etc/apt/sources.list', '^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$')
[ubuntu:bionic] Ready: mike.py
--> Proposed changes:
Groups: @docker
[ubuntu:bionic] Operations: 1 Commands: 1
--> Beginning operation run...
--> Starting operation: Install VirtualBox repo
[pyinfra.api.operations] Starting operation Install VirtualBox repo on ubuntu:bionic
[pyinfra.api.util] Building command (shell_executable: sh): docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "# If the file now exists
if [ -f "/etc/apt/sources.list" ]; then
# Grep for the line, sed if matches
(grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" "/etc/apt/sources.list" && sed -i="" "s/^.*deb https:\/\/download.virtualbox.org\/virtualbox\/debian bionic contrib.*$//" /etc/apt/sources.list) || # Else echo
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
# No file, just echo
else
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
fi"
[pyinfra.api.connectors.local] --> Running command on localhost: sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "# If the file now exists
if [ -f "/etc/apt/sources.list" ]; then
# Grep for the line, sed if matches
(grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" "/etc/apt/sources.list" && sed -i="" "s/^.*deb https:\/\/download.virtualbox.org\/virtualbox\/debian bionic contrib.*$//" /etc/apt/sources.list) || # Else echo
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
# No file, just echo
else
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
fi"'
[ubuntu:bionic] >>> sh -c 'docker exec a426aa3919c74b6d09a5d839b4b89f5f1863114c67824842655044000cff3e05 sh -c "# If the file now exists
if [ -f "/etc/apt/sources.list" ]; then
# Grep for the line, sed if matches
(grep "^.*deb https://download.virtualbox.org/virtualbox/debian bionic contrib.*$" "/etc/apt/sources.list" && sed -i="" "s/^.*deb https:\/\/download.virtualbox.org\/virtualbox\/debian bionic contrib.*$//" /etc/apt/sources.list) || # Else echo
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
# No file, just echo
else
echo "deb https://download.virtualbox.org/virtualbox/debian bionic contrib" >> /etc/apt/sources.list
fi"'
[ubuntu:bionic] https://download.virtualbox.org/virtualbox/debian: 4: https://download.virtualbox.org/virtualbox/debian: Syntax error: end of file unexpected (expecting ")")
[pyinfra.api.connectors.local] --> Waiting for exit status...
[pyinfra.api.connectors.local] --> Command exit status: 2
[ubuntu:bionic] Error
[pyinfra.api.state] Failing hosts: ubuntu:bionic
localhost: >>> docker commit a426aa3919c7
localhost: sha256:db4497e361e507180b287c769f7777969102d1ffd5d009a6772ccfb9a4c218a6
localhost: >>> docker rm -f a426aa3919c7
localhost: a426aa3919c7
[ubuntu:bionic] docker build complete, image ID: db4497e361e5
--> pyinfra error: No hosts remaining!
$ ls pyinfra-debug.log
ls: pyinfra-debug.log: No such file or directory
$
Turns out this is an issue with Docker specifically - not quoting commands correctly; this should be resolved by https://github.com/Fizzadar/pyinfra/commit/0cc6433f6569d92596d5570423cba571208b7e0c.
|
gharchive/issue
| 2020-01-12T21:12:22 |
2025-04-01T04:55:05.223696
|
{
"authors": [
"Fizzadar",
"mkinney"
],
"repo": "Fizzadar/pyinfra",
"url": "https://github.com/Fizzadar/pyinfra/issues/229",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
254871365
|
Hackish: show "[sudo] password for user:" message when using @local
A naïve fix for letting sudo inform the user it waits for his password. Only tested with @local.
The following ticket details a more advanced take on the issue: https://github.com/Fizzadar/pyinfra/issues/40
@tobald sorry for never getting back to you on this one! I'm still not sure how or whether pyinfra should handle input. I'd like to do it as it makes the user experience far better; but the current plan in #40 is pretty involved and would make pyinfra lot more complicated :/
@tobald sorry for never getting back to you on this one! I'm still not
sure how or whether pyinfra should handle input. I'd like to do it as
it makes the user experience far better; but the current plan in #40
is pretty involved and would make pyinfra lot more complicated :/
No worries, I do not have a use for this feature anymore. Proper input
management is the way to go as stated in #40, and seems complicated.
Meanwhile we could detect/display something to the user, that was the
purpose of this commit.
|
gharchive/pull-request
| 2017-09-03T12:23:27 |
2025-04-01T04:55:05.227372
|
{
"authors": [
"Fizzadar",
"tobald"
],
"repo": "Fizzadar/pyinfra",
"url": "https://github.com/Fizzadar/pyinfra/pull/116",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
2405347452
|
MURDER IN MY MIND
Song Name
Murder In My Mind
Artist Name
KORDHELL
Source
Youtube
Youtube Link
https://youtu.be/w-sQRS-Lc9k?si=uLiUiokzLtwIM2mQ
Direct File Link
No response
Song ID
33333
Start Offset [ms]
0
Extra
Used in Level: Murder In My Mind - 87265181
reject
already in the mod
|
gharchive/issue
| 2024-07-12T11:21:31 |
2025-04-01T04:55:05.230132
|
{
"authors": [
"SpuckwasserDE",
"gab-sketch"
],
"repo": "FlafyDev/auto-nong-indexes",
"url": "https://github.com/FlafyDev/auto-nong-indexes/issues/1255",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2616438623
|
add F-777 - Sonic Blaster (DeCody remix) by DeCody
Song Name
F-777 - Sonic Blaster (DeCody remix)
Artist Name
DeCody
Source
Youtube
Youtube Link
9QV_T53XoEA
Direct File Link
No response
Song ID
574484
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 26681070
Downloaded: Yes
accept
вс, 27 окт. 2024 г., 12:09 auto-nong[bot] @.***>:
Thanks for contributing!
Someone will soon review your request.
Here is the JSON result for the reviewer:
{
"name": "F-777 - Sonic Blaster (DeCody remix)",
"artist": "DeCody",
"source": "youtube",
"startOffset": 0,
"yt-id": "9QV_T53XoEA",
"songs": [
574484
]
}
To accept the request, a reviewer needs to write "accept".
—
Reply to this email directly, view it on GitHub
https://github.com/FlafyDev/auto-nong-indexes/issues/5478#issuecomment-2439918167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMOTCG7SL5N6IC3ORUOC5GLZ5SUVVAVCNFSM6AAAAABQVUAT62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZZHEYTQMJWG4
.
You are receiving this because you authored the thread.Message ID:
@.***>
|
gharchive/issue
| 2024-10-27T09:09:14 |
2025-04-01T04:55:05.236585
|
{
"authors": [
"VERT1DAN"
],
"repo": "FlafyDev/auto-nong-indexes",
"url": "https://github.com/FlafyDev/auto-nong-indexes/issues/5478",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1734589387
|
Swagger is broken
Describe the bug
SwaggerGenerationError
your query_serializer contains fields that conflict with the filter_backend or paginator_class on the view - GET /api/v1/audit/
It's likely the type mismatch between filter params and the DRF serializer:
Filter:
{
description: '',
in: 'query',
name: 'is_system_event',
required: False,
> type: 'string' <
},
Serializer field:
{
in: 'query',
name: 'is_system_event',
required: False,
> type: 'boolean' <
},
The error is currently only reproducible for user id 14119.
Potentially related issue: https://github.com/axnsan12/drf-yasg/issues/514
To Reproduce
Steps to reproduce the behavior:
Login as user 14119.
Go to https://api.flagsmith.com/api/v1/docs/?format=openapi
Observe the HTTP 500 response.
Expected behavior
The server should render the OpenAPI schema.
A unit test should catch Swagger generation errors.
How are you running Flagsmith?
[ ] Self Hosted with Docker
[ ] Self Hosted with Kubernetes
[x] SaaS at flagsmith.com
[ ] Some other way
I have looked into this a bit further - I don't believe it is related to the error provided in the description since that was fixed here: https://github.com/Flagsmith/flagsmith/pull/2326.
It seems to only happen when users are logged in as a user that also has access to the django admin in the same browser session that they access the API docs.
The issue is still reproducible in prod. Tried logging out and in again to no avail.
Sorry, yes - it's still reproducible for sure, but I'm not convinced it's related to the exception in the description. It's definitely related to being logged in as a staff user though.
|
gharchive/issue
| 2023-05-31T16:28:42 |
2025-04-01T04:55:05.245203
|
{
"authors": [
"khvn26",
"matthewelwell"
],
"repo": "Flagsmith/flagsmith",
"url": "https://github.com/Flagsmith/flagsmith/issues/2256",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
477996991
|
Realtime streaming of test results via firebase function
Prototype how to get firebase function streaming data to Flank.
https://github.com/firebase/functions-samples/tree/master/quickstarts/test-complete
This might not be possible given the function will have to push ( post ) data to some place, and most CI systems don't allow incoming traffic.
We're building a comprehensive build and test analytics platform that integrates with Flank. 😄 This is a research ticket that will help prove out those efforts.
Data will likely be pushed to a Firebase database.
For test analytics, we'll parse the final JUnit XML artifact as attached to the CI job. In this approach, the firebase function doesn't add value.
|
gharchive/issue
| 2019-08-07T15:26:13 |
2025-04-01T04:55:05.256737
|
{
"authors": [
"bootstraponline",
"doodla"
],
"repo": "Flank/flank",
"url": "https://github.com/Flank/flank/issues/588",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
925416032
|
API
Helo ! Is there any API or something similar so I can try to develop a site with information about Flax?
Hey, our website is https://flaxnetwork.org/. This is a fork of https://github.com/Chia-Network/chia-blockchain. You can see there for more info, but there is currently no user-facing API.
|
gharchive/issue
| 2021-06-19T15:26:58 |
2025-04-01T04:55:05.293895
|
{
"authors": [
"MarceloWatson",
"flax-dev"
],
"repo": "Flax-Network/flax-blockchain",
"url": "https://github.com/Flax-Network/flax-blockchain/issues/2",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1307998159
|
ROS2 OCS does not launch behavior
I am experimenting with flexBE in ROS2 Galactic and I ran into an issue with launching a behavior from the OCS GUI to run on a remote machine.
What I did:
followed the Basic Tutorials to create a hello world behavior that waits a few seconds and then prints to the screen
launched the behavior from the GUI after running ros2 launch flexbe_app flexbe_full.launch.py and observed the expected behavior
Copied the tutorials_behaviors repo (created in the tutorials) to the computer on my robot and ran colcon build to set up the workspace
On remote, launched the OCS with ros2 launch flexbe_app flexbe_ocs.launch.py. On robot, launched the behavior engine with ros2 launch flexbe_onboard behavior_onboard.launch.py.
Results:
The OCS was able to connect to the behavior engine. After seeing --- Behavior Engine ready! --- on the robot the OCS indicated --- Behavior Mirror ready! ---. But after clicking Start Execution I get an error
Failed to retrieve behavior from library: [-]
787353483
Dropped behavior start request because preparation failed.
Also if I switch the launch order (engine on robot first, then OCS on remote), when I click Start Execution the OCS hangs on the Waiting For Behavior screen with the message Start command has been sent. Now waiting for confirmation from onboard behavior...
This is an annoyance and something we plan to look at this summer. Likely it will involve a script to copy behaviors from the install folder to the source. Suggestions are appreciated.
|
gharchive/issue
| 2022-07-18T13:53:59 |
2025-04-01T04:55:05.307400
|
{
"authors": [
"dcconner",
"drosen20"
],
"repo": "FlexBE/flexbe_app",
"url": "https://github.com/FlexBE/flexbe_app/issues/80",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
2568047891
|
🛑 Flingchat is down
In 7282dad, Flingchat (https://chat.glowberry.xyz) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Flingchat is back up in d873c83 after 5 minutes.
|
gharchive/issue
| 2024-10-05T13:27:44 |
2025-04-01T04:55:05.313134
|
{
"authors": [
"FlingisenFlong"
],
"repo": "FlingisenFlong/flingchat-uptime",
"url": "https://github.com/FlingisenFlong/flingchat-uptime/issues/138",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
285979756
|
If a GIF image has no Netscape 2.0 loop extension, it is meant to play once and then stop.
If a GIF image has no Netscape 2.0 loop extension, it is meant to play once and then stop.
Is there anyone else?
Is there anyone else?
yes
@LululuSir Is this the same as #102 ?
@LululuSir Is this the same as #102 ?
@LululuSir Is this the same as #102 ?
YES
This example GIF from this PR comment shows no Netscape 2.0 loop extension (when inspected with > gifsicle --extension-info) and thus shows each frame exactly once and then stops in Chrome/Safari and in FLAnimatedImage. This seems to be the correct behavior. Note that the definition of FLAnimatedImage's loopCount follows ImageIO's definition.
If you find a case where FLAnimatedImage behaves differently than Chrome/Safari, please provide the respective GIF file as an example. Then we can have a look at whether something would need to change in FLAnimatedImage.
|
gharchive/pull-request
| 2018-01-04T13:05:07 |
2025-04-01T04:55:05.317759
|
{
"authors": [
"LululuSir",
"raphaelschaad",
"reactxp"
],
"repo": "Flipboard/FLAnimatedImage",
"url": "https://github.com/Flipboard/FLAnimatedImage/pull/198",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
268958691
|
Rendering same rows repeatedly on ios
ReactEssentials is exactly what I need. But I faced with this interesting situation when I tested with real data. I have a long list. But all list rendering with the same items (first 13 item).
Working fine on android but I stuck on ios.
recyclerlistview: ^1.1.4
react-native: 0.49.3
class UserList extends Component {
constructor(props){
super(props);
let dataProvider = new DataProvider((r1, r2) => {
return r1 !== r2;
});
let { width } = Dimensions.get("window");
this._layoutProvider = new LayoutProvider(
index => {
return ''
},
(type, dim) => {
dim.width = width;
dim.height = 84;
}
);
this.renderRow = this.renderRow.bind(this);
this.state = {
dataProvider: dataProvider.cloneWithRows(props.rows)
};
}
componentWillReceiveProps(nextProps){
let dataProvider = new DataProvider((r1, r2) => {
return r1 !== r2;
});
this.setState({ dataProvider: dataProvider.cloneWithRows(nextProps.rows)});
}
renderRow(type, { node }) {
return (
<UserRow user={ node } selectedAccount={this.props.selectedAccount} />
);
}
render(){
const { listKey } = this.props;
return (
<Content>
<RecyclerListView key={listKey} style={{width: 400, height: 400 }} layoutProvider={this._layoutProvider} dataProvider={this.state.dataProvider} rowRenderer={this.renderRow} />
</Content>
)
}
}
export default UserList;
What was the issue here?
The UserRow component was connected redux. I unmounted redux and passed actions via prop. It's working nice, both ios and android.
Great :)
|
gharchive/issue
| 2017-10-27T01:12:36 |
2025-04-01T04:55:05.322000
|
{
"authors": [
"iLevye",
"naqvitalha"
],
"repo": "Flipkart/ReactEssentials",
"url": "https://github.com/Flipkart/ReactEssentials/issues/60",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1897321542
|
Local docs compiling
@sanguinariojoe do you have any idea what could be causing this error in compiling the documentation locally:
Patching output file 56/58
Patching output file 57/58
Patching output file 58/58
type lookup cache used 10518/65536 hits=122962 misses=10670
symbol lookup cache used 6206/65536 hits=83658 misses=6206
finished...
/Users/rdavies/Library/Python/3.9/lib/python/site-packages/urllib3/__init__.py:34: NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
warnings.warn(
/Users/rdavies/Library/Python/3.9/lib/python/site-packages/breathe/project.py:116: RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths as strings. Use "pathlib.Path" or "os.fspath" instead.
self._default_build_dir = os.path.dirname(app.doctreedir.rstrip(os.sep))
making output directory... done
Exception occurred:
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/re.py", line 210, in sub
return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object
The full traceback has been saved in /var/folders/46/4_pcs77x31j8w360rc7pfv6chrj_sl/T/sphinx-err-athjs7ze.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
make[2]: *** [docs/sphinx/index.html] Error 2
make[1]: *** [docs/CMakeFiles/Sphinx.dir/all] Error 2
make: *** [all] Error 2
The traceback that was saved shows the following:
# Platform: darwin; (macOS-13.5.2-x86_64-i386-64bit)
# Sphinx version: 7.2.6
# Python version: 3.9.6 (CPython)
# Docutils version: 0.18.1
# Jinja2 version: 3.1.2
# Pygments version: 2.15.1
# Last messages:
# Loaded extensions:
# Traceback:
Traceback (most recent call last):
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/cmd/build.py", line 293, in build_main
app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/application.py", line 272, in __init__
self._init_builder()
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/application.py", line 342, in _init_builder
self.builder.init()
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/builders/html/__init__.py", line 219, in init
self.init_templates()
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/builders/html/__init__.py", line 270, in init_templates
self.theme = theme_factory.create(themename)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py", line 227, in create
self.load_extra_theme(name)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py", line 181, in load_extra_theme
self.load_external_theme(name)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py", line 194, in load_external_theme
theme_entry_points = entry_points(group='sphinx.html_themes')
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/__init__.py", line 933, in entry_points
return EntryPoints(eps).select(**params)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/__init__.py", line 930, in <genexpr>
eps = itertools.chain.from_iterable(
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/_itertools.py", line 16, in unique_everseen
k = key(element)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/_py39compat.py", line 18, in normalized_name
return dist._normalized_name
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/__init__.py", line 855, in _normalized_name
or super()._normalized_name
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/__init__.py", line 473, in _normalized_name
return Prepared.normalize(self.name)
File "/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/__init__.py", line 773, in normalize
return re.sub(r"[-_.]+", "-", name).lower().replace('-', '_')
File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/re.py", line 210, in sub
return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object
Additionally early on in the process it says /bin/sh: sphinx-build: command not found
To get it to compile I am required to modify line 75 of build/docs/CMakeFiles/Sphinx.dir/build.make to remove the quotes around the path to python that are autogenerated.
This is confusing me because last week it was working fine and I was able to compile the docs locally without error. I havent changed any of the code other than .rst files, and made no modifications to my system as far as I can tell. I've tried uninstalling all the required packages and reinstalling them, as well as deleting the build folder and remaking it with cmake.
Pretty eclectic error, but it seems to me that you do not have the theme
installed:
sphinx_rtd_theme
As far as I remember it shall be installed with pip
On Thu, 14 Sept 2023, 23:19 RyanDavies19, @.***> wrote:
@sanguinariojoe https://github.com/sanguinariojoe do you have any idea
what could be causing this error in compiling the documentation locally:
`Patching output file 56/58
Patching output file 57/58
Patching output file 58/58
type lookup cache used 10518/65536 hits=122962 misses=10670
symbol lookup cache used 6206/65536 hits=83658 misses=6206
finished...
/Users/rdavies/Library/Python/3.9/lib/python/site-packages/urllib3/init.py:34:
NotOpenSSLWarning: urllib3 v2.0 only supports OpenSSL 1.1.1+, currently the
'ssl' module is compiled with 'LibreSSL 2.8.3'. See: urllib3/urllib3#3020
https://github.com/urllib3/urllib3/issues/3020
warnings.warn(
/Users/rdavies/Library/Python/3.9/lib/python/site-packages/breathe/project.py:116:
RemovedInSphinx80Warning: Sphinx 8 will drop support for representing paths
as strings. Use "pathlib.Path" or "os.fspath" instead.
self._default_build_dir = os.path.dirname(app.doctreedir.rstrip(os.sep))
making output directory... done
Exception occurred:
File
"/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/re.py",
line 210, in sub
return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object
The full traceback has been saved in
/var/folders/46/4_pcs77x31j8w360rc7pfv6chrj_sl/T/sphinx-err-athjs7ze.log,
if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error
message can be provided next time.
A bug report can be filed in the tracker at
https://github.com/sphinx-doc/sphinx/issues. Thanks!
make[2]: *** [docs/sphinx/index.html] Error 2
make[1]: *** [docs/CMakeFiles/Sphinx.dir/all] Error 2
make: *** [all] Error 2`
The traceback that was saved shows the following:
`# Platform: darwin; (macOS-13.5.2-x86_64-i386-64bit)
Sphinx version: 7.2.6 Python version: 3.9.6 (CPython) Docutils version:
0.18.1 Jinja2 version: 3.1.2 Pygments version: 2.15.1 Last messages: Loaded
extensions: Traceback:
Traceback (most recent call last):
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/cmd/build.py",
line 293, in build_main
app = Sphinx(args.sourcedir, args.confdir, args.outputdir,
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/application.py",
line 272, in init
self._init_builder()
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/application.py",
line 342, in _init_builder
self.builder.init()
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/builders/html/
init.py", line 219, in init
self.init_templates()
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/builders/html/
init.py", line 270, in init_templates
self.theme = theme_factory.create(themename)
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py",
line 227, in create
self.load_extra_theme(name)
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py",
line 181, in load_extra_theme
self.load_external_theme(name)
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/sphinx/theming.py",
line 194, in load_external_theme
theme_entry_points = entry_points(group='sphinx.html_themes')
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/
init.py", line 933, in entry_points
return EntryPoints(eps).select(**params)
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/
init.py", line 930, in
eps = itertools.chain.from_iterable(
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/_itertools.py",
line 16, in unique_everseen
k = key(element)
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/_py39compat.py",
line 18, in normalized_name
return dist._normalized_name
File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/
init.py", line 855, in _normalized_name
or super().
normalized_name File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/init.py",
line 473, in normalized_name return Prepared.normalize(self.name
http://self.name) File
"/Users/rdavies/Library/Python/3.9/lib/python/site-packages/importlib_metadata/init.py",
line 773, in normalize return re.sub(r"[-.]+", "-",
name).lower().replace('-', '')
File
"/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/re.py",
line 210, in sub
return _compile(pattern, flags).sub(repl, string, count)
TypeError: expected string or bytes-like object`
—
Reply to this email directly, view it on GitHub
https://github.com/FloatingArrayDesign/MoorDyn/issues/121, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMXKKES3RWPYV5DIBTM6BDX2NYGLANCNFSM6AAAAAA4Y4B574
.
You are receiving this because you were mentioned.Message ID:
@.***>
@sanguinariojoe thanks, I was curious if you had ideas. Turns out when I installed Xcode with admin rights for something else, it created a second python copy. I had to go in and delete all that but things are working well now.
|
gharchive/issue
| 2023-09-14T21:19:22 |
2025-04-01T04:55:05.345958
|
{
"authors": [
"RyanDavies19",
"sanguinariojoe"
],
"repo": "FloatingArrayDesign/MoorDyn",
"url": "https://github.com/FloatingArrayDesign/MoorDyn/issues/121",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
2112327493
|
Enhancing Node-RED Logging: Introducing Host Output Logging Capability
Description
At present, the logging mechanism for Node-RED projects directs all logs to the 'driver', which can be accessed through the FlowFuse Project logs interface. In environments where Kubernetes clusters are deployed and are integrated with monitoring solutions (such as log forwarding to OTEL/ FluentBit for pods, and then to traces/metrics/etc. to backends like Prometheus/Jaeger/, etc.), there is a valuable opportunity to streamline monitoring practices.
Enabling Node-RED projects to output their logs directly to the pod's console will facilitate a more unified approach to monitoring by leveraging existing log aggregation configurations.
https://github.com/FlowFuse/flowfuse/issues/3324
Thank you @hardillb - closing this one
|
gharchive/issue
| 2024-02-01T11:53:40 |
2025-04-01T04:55:05.394825
|
{
"authors": [
"elenaviter",
"hardillb"
],
"repo": "FlowFuse/nr-launcher",
"url": "https://github.com/FlowFuse/nr-launcher/issues/206",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1867268042
|
[BUG]yarn start not working
Describe the bug
Cloned the repo and followed the steps using yarn
To Reproduce
cloned and changed directory then=>
yarn install && yarn build && yarn start
install and build work fine with no error
when start is executed, error is encountered
Error
`
Tasks: 3 successful, 3 total
Cached: 0 cached, 3 total
Time: 2m25.321s
✨ Done in 146.13s.
yarn run v1.22.19
$ run-script-os
$ cd packages/server/bin && ./run start
(node:1212) [ERR_DLOPEN_FAILED] Error Plugin: flowise: dlopen(/Users/amzamani/Desktop/incoming/ai/Flowise/node_modules/canvas/build/Release/canvas.node, 1): Library not loaded: @loader_path/libpixman-1.0.42.2.dylib
Referenced from: /Users/amzamani/Desktop/incoming/ai/Flowise/node_modules/canvas/build/Release/canvas.node
Reason: no suitable image found. Did find:
/Users/amzamani/Desktop/incoming/ai/Flowise/node_modules/canvas/build/Release/libpixman-1.0.42.2.dylib: cannot load 'libpixman-1.0.42.2.dylib' (load command 0x80000034 is unknown)
/Users/amzamani/Desktop/incoming/ai/Flowise/node_modules/canvas/build/Release/libpixman-1.0.42.2.dylib: cannot load 'libpixman-1.0.42.2.dylib' (load command 0x80000034 is unknown)
module: @oclif/core@1.26.2
task: toCached
plugin: flowise
root: /Users/amzamani/Desktop/incoming/ai/Flowise/packages/server
See more details with DEBUG=*
(Use node --trace-warnings ... to show where the warning was created)
› Error: command start not found
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Abus-MacBook-Air:Flowise amzamani$
`
MacOS Mojave- Version 10.14.4
Node- Version v18.17.1
Hi @amzamani.
I believe your issue is related https://github.com/FlowiseAI/Flowise/issues/556
but do try sudo yarn from install to start
I guess it is related with node-canvas. I did not faced this problem but i may suggest to this path to solve it:
Take a look: https://github.com/Automattic/node-canvas#compiling
Install them:
brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman
then;
remove node_modules (remove build artifacts)
yarn install
yarn build
yarn dev
if it wont succeed i can also suggest to install this
npm install canvas --build-from-source
then reproduce steps starting with remove node_modules
|
gharchive/issue
| 2023-08-25T15:39:32 |
2025-04-01T04:55:05.405227
|
{
"authors": [
"amzamani",
"chungyau97",
"isikhi"
],
"repo": "FlowiseAI/Flowise",
"url": "https://github.com/FlowiseAI/Flowise/issues/832",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1944058658
|
Feature/PluginSystem
In this PR I propose a Plugin & hook system for Flowise
Plugins are packages, that currently live in /plugins - but they should also be installable via npm
It borrows ideas from the WordPress plugin and hook system. One of the most powerful forces why WordPress became such a popular OpenSource framework (despite a lot of not so likable things about WordPress code)
Within a plugin package we use package.json/main to point to the plugins main class which extends the FlowisePlugin class
It automatically loads components and credentials from the plugins directory by specifying nodesPath and credentialsPath
=> Check the components in the UI within a new "Custom" section
Under the hood it's using an event based hook system (based on EventEmitter) that adds the ability to collect and manipulate (filter) data, via emitting and listening to events (we call them hooks)
p.s.
Some changes where introduced by yarn lint-fix
p.p.s.
Sorry for the first broken commit/pr - pls ignore / delete
hey @matthias thanks a lot for the initiative! Am wondering whats the difference between plugin vs users creating their own node in packages/components/nodes?
hey @HenryHengZJ - thanks for looking into this.
I think it's the much cleaner separation than working directly in the same folder / code structure as the core project.
I thought about it since I'm working with Flowise. Coming from WordPress I was wondering why it's not more common to have a plugin/hook architecture in Node/JS projects. Then I investigated deeper into langchain recently - and discovered that they provide a mechanism to have custom nodes in a separate folder - which I liked very much. I elaborated this idea, because I could imagine that from a certain point you don't want to have 100th of nodes in the core / UI - but rather be able to install additional "packages" of functionality (not just nodes)
Currently it needs a very deep dive into the code until you know where to add what - and there is the constant need of updating and merging code bases. Adding own features by forking is possible, but I would rather not do it in the long run as it constantly requires to keep up with all the codebase (as you never know what could change) - and solve merging conflicts.
Actually adding / loading nodes from a plugin was just a demo use case of the hooks. They (hooks) are the important part, as they allow Flowise to add clear entry points how to add things. This could also be additional navigation points or more down the road.
Imagine other use cases, as adding / managing / observing sources. Adding alternative chat UIs. Adding api endpoints (routes).
Could be interesting for custom(er) projects based on Flowise. But could also be a mechanism to develop new features, before they become part of the core.
|
gharchive/pull-request
| 2023-10-15T21:09:55 |
2025-04-01T04:55:05.410262
|
{
"authors": [
"HenryHengZJ",
"matthias"
],
"repo": "FlowiseAI/Flowise",
"url": "https://github.com/FlowiseAI/Flowise/pull/1066",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1708355584
|
Bug bounty test - PLEASE DO NOT APPROVE. ijoech
Bug bounty test - PLEASE DO NOT APPROVE. ijoech
Spam pull request
|
gharchive/pull-request
| 2023-05-13T00:07:16 |
2025-04-01T04:55:05.546400
|
{
"authors": [
"corneliusyaovi",
"pastramahodu"
],
"repo": "Flutterwave/Angular",
"url": "https://github.com/Flutterwave/Angular/pull/21",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1666905740
|
Obsolete neuroepidermoblast
neuroepidermoblast is a subclass of neuroblast.
The term has no definition and is not used anywhere within FBbt. In FlyBase, it is used in one record (P{E(spl)m8-HLH-2.61}). The corresponding paper never uses the term neuroepidermoblast. It seems the term is intended to refer to cells of the proneural clusters of the neurectoderm – cells that have not yet committed to either the neuroblast or the epidermoblast fate.
The term does not seem used in the literature at all. PubMed returns zero result; Google returns a handful of results, which are all ultimately linked either to the FBbt term directly or to the equivalent term in CL (which is almost certainly a direct “copy” of the FBbt term).
I think the term should be obsoleted. In the one record where it has been used, it can probably be replaced by proneural cluster.
The term could also get a proper definition as “cell of a proneural cluster that will become either a neuroblast or an epidermoblast” or similar, rather than being obsoleted.
|
gharchive/issue
| 2023-04-13T18:11:50 |
2025-04-01T04:55:05.560494
|
{
"authors": [
"gouttegd"
],
"repo": "FlyBase/drosophila-anatomy-developmental-ontology",
"url": "https://github.com/FlyBase/drosophila-anatomy-developmental-ontology/issues/1621",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2082962200
|
设置大图视频不旋转
描述一下大概怎么回事
设置大图视频不旋转，即隐藏全屏按钮，有对应的api吗，还是需要自己自定义实现
需要你自定义实现，可参考这里的FriendsPlayerFragment，换掉播放器的UI，可直接将播放器布局中的全屏按钮删除即可
|
gharchive/issue
| 2024-01-16T03:37:47 |
2025-04-01T04:55:05.574234
|
{
"authors": [
"FlyJingFish",
"LazyIonEs"
],
"repo": "FlyJingFish/OpenImage",
"url": "https://github.com/FlyJingFish/OpenImage/issues/24",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1510126727
|
🛑 Autogestión Clientes is down
In 5bc4a04, Autogestión Clientes (https://sacautogestion.focasoftware.com/sac_cliente/index) was down:
HTTP code: 500
Response time: 692 ms
Resolved: Autogestión Clientes is back up in f397a0d.
|
gharchive/issue
| 2022-12-24T15:32:02 |
2025-04-01T04:55:05.593617
|
{
"authors": [
"ArielGQ"
],
"repo": "Foca-Software/status",
"url": "https://github.com/Foca-Software/status/issues/169",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2045193898
|
🛑 Autogestión Clientes is down
In fe8237f, Autogestión Clientes (https://sacautogestion.focasoftware.com/index) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Autogestión Clientes is back up in a33d0d7.
|
gharchive/issue
| 2023-12-17T12:10:33 |
2025-04-01T04:55:05.595976
|
{
"authors": [
"ArielGQ"
],
"repo": "Foca-Software/status",
"url": "https://github.com/Foca-Software/status/issues/829",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
294208224
|
java.lang.NullPointerException: Attempt to invoke virtual method 'fi.iki.elonen.NanoHTTPD$Response fi.iki.elonen.router.RouterNanoHTTPD$UriResource.process on a null object reference
hey everyone,
I m getting this type of exception in some of epub files.Please help me out
E/fi.iki.elonen.NanoHTTPD: Communication with the client broken, or an bug in the handler code
java.lang.NullPointerException: Attempt to invoke virtual method 'fi.iki.elonen.NanoHTTPD$Response fi.iki.elonen.router.RouterNanoHTTPD$UriResource.process(java.util.Map, fi.iki.elonen.NanoHTTPD$IHTTPSession)' on a null object reference
at fi.iki.elonen.router.RouterNanoHTTPD$UriRouter.process(RouterNanoHTTPD.java:596)
at fi.iki.elonen.router.RouterNanoHTTPD.serve(RouterNanoHTTPD.java:671)
at fi.iki.elonen.NanoHTTPD$HTTPSession.execute(NanoHTTPD.java:945)
at fi.iki.elonen.NanoHTTPD$ClientHandler.run(NanoHTTPD.java:192)
at java.lang.Thread.run(Thread.java:818)
02-04 21:33:30.182 20868-20922/world.ebook.com.ebookworld E/ManifestTask: ManifestTask failed
java.io.IOException: unexpected end of stream on Connection{127.0.0.1:8080, proxy=DIRECT@ hostAddress=127.0.0.1 cipherSuite=none protocol=http/1.1} (recycle count=0)
at com.android.okhttp.internal.http.HttpConnection.readResponse(HttpConnection.java:210)
at com.android.okhttp.internal.http.HttpTransport.readResponseHeaders(HttpTransport.java:80)
at com.android.okhttp.internal.http.HttpEngine.readNetworkResponse(HttpEngine.java:905)
at com.android.okhttp.internal.http.HttpEngine.readResponse(HttpEngine.java:789)
at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:443)
at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:388)
at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:231)
at com.folioreader.ui.base.ManifestTask.doInBackground(ManifestTask.java:43)
at com.folioreader.ui.base.ManifestTask.doInBackground(ManifestTask.java:26)
at android.os.AsyncTask$2.call(AsyncTask.java:295)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)
Caused by: java.io.EOFException: \n not found: size=0 content=...
at com.android.okhttp.okio.RealBufferedSource.readUtf8LineStrict(RealBufferedSource.java:200)
at com.android.okhttp.internal.http.HttpConnection.readResponse(HttpConnection.java:191)
I have same problem, on APIs lower than 24. Have you resolved this issue?
me also getting same is there any solutions avilable
I am facing the same issue, if any body has found any solution to this, please revert. I guess, it is because of httpurlconnection - as it uses apache...which is now deprecated(in api 23 and below). if this is so, best would be for mahavir155, to replace httpurlconnection with okhttp. I have had to do the same in my project.
|
gharchive/issue
| 2018-02-04T16:08:03 |
2025-04-01T04:55:05.632551
|
{
"authors": [
"HarshaYogesha",
"himanshuthakkar2781",
"maloznaal",
"vikasrairajput"
],
"repo": "FolioReader/FolioReader-Android",
"url": "https://github.com/FolioReader/FolioReader-Android/issues/169",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
242476859
|
FC001 should not alert on node.run_state[:foo]
Signed-off-by: Tim Smith tsmith@chef.io
Resolves https://github.com/Foodcritic/foodcritic/issues/652
|
gharchive/pull-request
| 2017-07-12T18:41:56 |
2025-04-01T04:55:05.637996
|
{
"authors": [
"tas50"
],
"repo": "Foodcritic/foodcritic",
"url": "https://github.com/Foodcritic/foodcritic/pull/653",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
2757371335
|
What does this line work for? Thanks.
https://github.com/FoundationVision/Infinity/blob/0ac8556fa2cc23c70c342785e53145c5d6b09d46/infinity/models/infinity.py#L433
This line is to quick jump to the implementation of [SelfAttnBlock.forward, CrossAttnBlock.forward]. It's for reference only and no other special usuage.
|
gharchive/issue
| 2024-12-24T07:59:21 |
2025-04-01T04:55:05.810401
|
{
"authors": [
"JeyesHan",
"JinYue2015"
],
"repo": "FoundationVision/Infinity",
"url": "https://github.com/FoundationVision/Infinity/issues/10",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2452193793
|
Question about the training dataset - tokenzier
Hi, I recently read your paper “Visual Autoregressive Modeling: Scalable Image Generation via Next-Scale Prediction” published in CVPR 2024. I am very interested in your method and have great respect for your contribution to the academic community.
We are currently doing some experiments and would like to ask you a question about the tokenizer part. Is the pre-training dataset you are using OpenImage V6 or another version? Current we are using OpenImage v6 to train tokenizer. So do you think it's fair to compare with VAR tokenizer?
Thank you again for your time and effort, and I look forward to your reply.
Hi, I recently read your paper “Visual Autoregressive Modeling: Scalable Image Generation via Next-Scale Prediction” published in CVPR 2024. I am very interested in your method and have great respect for your contribution to the academic community.
We are currently doing some experiments and would like to ask you a question about the tokenizer part. Is the pre-training dataset you are using OpenImage V6 or another version? Current we are using OpenImage v6 to train tokenizer. So do you think it's fair to compare with VAR tokenizer?
Thank you again for your time and effort, and I look forward to your reply.
Hi, I recently read your paper “Visual Autoregressive Modeling: Scalable Image Generation via Next-Scale Prediction” published in CVPR 2024. I am very interested in your method and have great respect for your contribution to the academic community.
We are currently doing some experiments and would like to ask you a question about the tokenizer part. Is the pre-training dataset you are using OpenImage V6 or another version? Current we are using OpenImage v6 to train tokenizer. So do you think it's fair to compare with VAR tokenizer?
Thank you again for your time and effort, and I look forward to your reply.
@Lucky-Light-Sun
Sorry for late reply.
The pre-training dataset we are using is OpenImage V6.
BTW, VAR is accepted as NeurIPS oral, not CVPR
|
gharchive/issue
| 2024-08-07T03:20:39 |
2025-04-01T04:55:05.817067
|
{
"authors": [
"Lucky-Light-Sun",
"iFighting"
],
"repo": "FoundationVision/VAR",
"url": "https://github.com/FoundationVision/VAR/issues/80",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1294536571
|
Call the browser printing function, and a blank page will appear in PDF.
When invoking the browser print function, garbled code will appear at first, and then it will be modified according to pull requests #130, and the text will be displayed normally, but there will be an extra blank page between pages. Does anyone encounter the same problem? How to solve it?
Hi, were you able to solve it?
|
gharchive/issue
| 2022-07-05T16:49:48 |
2025-04-01T04:55:05.861271
|
{
"authors": [
"Pedrome203",
"andyowli"
],
"repo": "FranckFreiburger/vue-pdf",
"url": "https://github.com/FranckFreiburger/vue-pdf/issues/375",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
403630238
|
subscribe when query is empty
I'm try to get an user profile with multiples nodes of a realtime database with this code:
public static void getUserProfile(String storeId, String userId, final Callback callback){
DatabaseReference userRef = RealtimeDatabase.getUserRef(userId);
DatabaseReference addressRef = RealtimeDatabase.getUserAddressRef(userId);
DatabaseReference contactRef = RealtimeDatabase.getUserContactRef(userId);
DatabaseReference storeUserRef = RealtimeDatabase.getStoreUserRef(storeId, userId);
DatabaseReference storeNameRef = RealtimeDatabase.getStoreRef(storeId).child(Store.PARAM_NAME);
RxFirebaseDatabase.observeSingleValueEvent(userRef, User.class)
.zipWith(RxFirebaseDatabase.observeSingleValueEvent(addressRef, Address.class), zipUserAddress)
.zipWith(RxFirebaseDatabase.observeSingleValueEvent(contactRef, UserContact.class), zipUserContact)
.zipWith(RxFirebaseDatabase.observeSingleValueEvent(storeUserRef, StoreUser.class), zipUserStore)
.zipWith(RxFirebaseDatabase.observeSingleValueEvent(storeNameRef, String.class), zipUserStoreName)
.subscribe(new Consumer<User>() {
@Override
public void accept(User user) {
callback.onSuccess(user);
}
}, new Consumer<Throwable>() {
@Override
public void accept(Throwable throwable) {
throwable.printStackTrace();
callback.onError(throwable);
}
});
}
This code works well to a complete profile, but when profile does not have address node or contact node, for example, the function in subscribe is never called and this is a problem for me now. Can you help me?
I am into the same issue, is there any update on this error?
I have created 3 flowable objects and then I called .zip to get the output of these 3 flowables. The issue is that it works well if all the 3 flowable returns value, if any of the query fails to find documents based on query .zip gets stuck and it never calls onNext or onComplete
@abdul-hasib Use Flowable.merge instead of Flowable.zip. The zip operator waits for all the observables to emit before it triggers onNext
@KryptKode is right. Merge instead of Zip should fix it.
Sorry for the delay on the response.
|
gharchive/issue
| 2019-01-28T02:42:30 |
2025-04-01T04:55:05.866425
|
{
"authors": [
"FrangSierra",
"KryptKode",
"abdul-hasib",
"gigiojr"
],
"repo": "FrangSierra/RxFirebase",
"url": "https://github.com/FrangSierra/RxFirebase/issues/76",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1063006629
|
wonderfull,
wonderfull,
Exactly what I'am looking for to translate JK-BMS rs485 protocole (or other BMS) to pylontech rs485 protocole , and then have my voltronic/mppsolar inverter talk to my DIY battery.
Thank you.
Thanks @demoze ! 😀
|
gharchive/issue
| 2021-11-24T23:53:06 |
2025-04-01T04:55:05.868964
|
{
"authors": [
"Frankkkkk",
"demoze"
],
"repo": "Frankkkkk/python-pylontech",
"url": "https://github.com/Frankkkkk/python-pylontech/issues/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2743659541
|
Adding contribution guidelines and code of conduct
Adding Unit test workflow to contribution guide
Moved contribution guidelines from README to .github/CONTRIBUTING.md.
|
gharchive/pull-request
| 2024-12-17T00:14:48 |
2025-04-01T04:55:05.889498
|
{
"authors": [
"sitapriyamoorthi",
"tefirman"
],
"repo": "FredHutch/wdl-unit-tests",
"url": "https://github.com/FredHutch/wdl-unit-tests/pull/24",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1673876502
|
messageHistory props not working
https://fredrikoseberg.github.io/react-chatbot-kit-docs/docs/advanced/chatbot-props/#messagehistory
attempting to use the messageHistory, however when I pass in an array I recieve a blank chat, seems to work when I place a string however no styling is given
<Chatbot
config={config}
actionProvider={ActionProvider}
messageParser={MessageParser}
messageHistory={['test 1','test 2']}
/>
attempted updating the messages array to such and still recieveing the problem
const messages = [
{ text: 'Hi there!', withAvatar: true },
{ text: 'How can I help you?', withAvatar: true },
];
const messageHistory = [
createChatBotMessage("Message 1", {
withAvatar: true,
}),
createChatBotMessage("Message 2", {
withAvatar: true}),
createChatBotMessage("Message 3", {
withAvatar: true}),
// add more messages to the history as needed
createClientMessage("User Message 1"),
]
|
gharchive/issue
| 2023-04-18T21:51:17 |
2025-04-01T04:55:05.894800
|
{
"authors": [
"pranav-manik"
],
"repo": "FredrikOseberg/react-chatbot-kit",
"url": "https://github.com/FredrikOseberg/react-chatbot-kit/issues/138",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2214256068
|
Fix request body file imports
Replace custom imports with the generic getImports() when writing request body files. I noticed that anything that referenced the DateFromISOString type was breaking.
Thank you @anulman for the recent PRs!
Unfortunately, I am not planning to maintain this library anymore, since I stopped using io-ts and fp-ts. I would like to rewrite the library for effectand@effect/schema`, but it is not going to happen soon.
That's all right! We've been maintaining our own fork at nmbrco/openapi-io-ts; was mostly trying to contrib back to your work in appreciation :)
Tbqh we were on zod before, but needed more out of generation than their ecosystem supported. Your work in comparison was much easier to hack on, even with the io-ts learning curve.
Thanks for publishing :)
|
gharchive/pull-request
| 2024-03-28T22:14:00 |
2025-04-01T04:55:05.898108
|
{
"authors": [
"Fredx87",
"anulman"
],
"repo": "Fredx87/openapi-io-ts",
"url": "https://github.com/Fredx87/openapi-io-ts/pull/27",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
188979378
|
help please
Challenge Name
Issue Description
Browser Information
cant get the my test to pass.
i have compared my code to others and ask for help in chat..
Browser Name, Version: firefox newest...
Operating System: win 10
Mobile, Desktop, or Tablet:
laptop
Your Code
<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">
<style>
.red-text {
color: red;
}
h2 {
font-family: Lobster, Monospace;
}
p {
font-size: 16px;
font-family: Monospace;
}
.smaller-image {
width: 100px;
}
</style>
<h2 class="red-text">CatPhotoApp</h2>
<img src="https://bit.ly/fcc-relaxing-cat" alt="A cute orange cat lying on its back. ">
<p class="red-text">Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</p>
<p class="red-text">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p>
Screenshot
@bstonesifer Your code is incomplete. At the very least, you haven't applied the smaller-image class to the img element, which is why your image isn't resizing.
Please visit the Help Room if you need assistance on this.
been to the help room.. its not helpful..
@bstonesifer Feel free to PM me on gitter if you're still stuck.
|
gharchive/issue
| 2016-11-13T16:32:58 |
2025-04-01T04:55:05.968328
|
{
"authors": [
"Manish-Giri",
"bstonesifer"
],
"repo": "FreeCodeCamp/FreeCodeCamp",
"url": "https://github.com/FreeCodeCamp/FreeCodeCamp/issues/11643",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.