id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
2754613733
|
[BUG] Rancher-Backups S3 Skip TLS verifications applied but backup object return https response
Rancher Server Setup
Rancher version: v2.10.0
Installation option Docker install
Proxy/Cert Details: none
Describe the bug
Rancher-Backups configured with insecure "Skip TLS Verifications" checkbox but yet error of: "server gave http response to https client"
Result
Expected Result
Accepting insecure http from the S3 bucket server. this case Minio
Hi, I see you set this solved/closed but want to answer for prosperity.
That way if any others come upon this they will see an explanation.
The rancher-backup tool is intended to require HTTPS between S3 buckets. There are a high chance that the backup data contains sensitive information so this protects the data in transit. The minimal expectation is that one would have a self-signed cert setup on their S3 service. In that scenario the Skip TLS Verifications option could save the effort of verifying the self-signed, or self-operated CA, origin certificate.
|
gharchive/issue
| 2024-12-22T11:34:03 |
2025-04-01T04:35:39.927658
|
{
"authors": [
"mallardduck",
"seab4ng"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/issues/48540",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
171920828
|
Rancher-UI new-select default value null
Rancher Version:
1.1.2
Docker Version:
1.12
OS and where are the hosts located? (cloud, bare metal, etc):
CentOS 7, Cloudstack/VMWare
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Single Node
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
Cattle
Steps to Reproduce:
Create a custom ui-driver based on https://github.com/rancher/ui-driver-skel and configure drop-down using new-select.
{{new-select classNames="form-control" content=var optionLabelPath='name' optionValuePath='id' value=model.%%DRIVERNAME%%Config.variable }}
Results:
If the desired value appears in the drop-down as the first option and you don't have to click and change it (onChange) the value will be set to null https://github.com/rancher/ui/blob/master/app/components/new-select/component.js#L96
Expected:
If the desired value appears in the drop-down as the first option it should be used without having to trigger a change event.
The workaround so far is to define a prompt that would trigger a change event.
@loganhz Can you verify if this is still the case (you can use something built-in, it has nothing to really do with machine drivers and custom UI), and if it is it should be easy to fix.
@vincent99
yes, it's still the case in master.
created a PR to fix it.
Not sure if my fix is a good solution. But it did work.
If the default value doesn't match any option, it will use the first option.
If the default value matches some option, it will use the desired option.
|
gharchive/issue
| 2016-08-18T14:52:38 |
2025-04-01T04:35:39.933349
|
{
"authors": [
"loganhz",
"radu-stefanache",
"vincent99"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/issues/5762",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
220205450
|
RancherOS ami-37b00f21 US-East-1 v0.9.1 doesn't work with anything other than T2-Micro instance.
Rancher Versions:
Server: v0.9.1 AWS US-East-1 ami-37b00f21
Docker Version:
Default for v0.9.1
OS and where are the hosts located? (cloud, bare metal, etc):
AWS
Setup Details: (single node rancher vs. HA rancher, internal DB vs. external DB)
AWS
AMI: ami-37b00f21
Instance: C4.4XL
Environment Type: (Cattle/Kubernetes/Swarm/Mesos)
AWS
Steps to Reproduce:
Attempting to create instance with any type other than T2-Micro will not allow ssh key to be used during creation.
Choose AMI ami-37b00f21 and any instance larger than T2-Micro and after that VM is running I am not able to ssh into the machine. I changed to version 0.9.0 and it worked so something is broken with the latest AMI (at least ami-37b00f21).
Results:
Duplicate of "Can't get into AWS M4 machines #1751"
|
gharchive/issue
| 2017-04-07T12:54:43 |
2025-04-01T04:35:39.937749
|
{
"authors": [
"MichaelWMerritt"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/issues/8440",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
478282499
|
Add ssl verify enable/disable in configure file
Problem:
Could not disable hostname verify for fluentd now
Solution:
Add ssl verify enable/disable in configure file
Issue:
https://github.com/rancher/rancher/issues/18438
LGTM
lgtm
whoops, forgot to click merge i guess
|
gharchive/pull-request
| 2019-08-08T06:46:38 |
2025-04-01T04:35:39.939742
|
{
"authors": [
"aiwantaozi",
"cjellick",
"loganhz"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/pull/22056",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
956230986
|
Update wrangler
Update to include https://github.com/rancher/wrangler/commit/5e75fca61cb249a217fb01d65cfe52367dba9261
rancher/rancher#33657
|
gharchive/pull-request
| 2021-07-29T21:48:19 |
2025-04-01T04:35:39.940827
|
{
"authors": [
"ibuildthecloud"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/pull/33833",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1284206801
|
[Do not merge] Adding support for Wins Agent upgrades for Windows using System upgrade controller
This adds the wins agent to the packaging and adds an upgrade plan for Windows.
https://github.com/rancher/windows/issues/181
Signed-off-by: Jamie Phillips jamie.phillips@suse.com
I need to have this PR merged first and rebase: https://github.com/rancher/rancher/pull/37941
|
gharchive/pull-request
| 2022-06-24T21:26:11 |
2025-04-01T04:35:39.942718
|
{
"authors": [
"phillipsj"
],
"repo": "rancher/rancher",
"url": "https://github.com/rancher/rancher/pull/38102",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
386419705
|
Pull latest EBS snapshot from tag instead of failing.
In many use cases it makes sense to have multiple snapshots under a tag. Rather than failing, Rancher EBS should pull the latest snapshot from the tag.
Tested this on Rancher v1.6.24
Closing this due to staleness. Feel free to reopen or open a new PR if there's still a relevant change to be made. Thanks!
|
gharchive/pull-request
| 2018-12-01T04:02:42 |
2025-04-01T04:35:39.969570
|
{
"authors": [
"cjellick",
"cranium"
],
"repo": "rancher/storage",
"url": "https://github.com/rancher/storage/pull/90",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2260285560
|
ci: remove useless build args
I copied this from Drone config before, but I realized it's not used in Dockerfile.
Because we changed it from ARG ARCH to ENV ARCH in Dockerfile due to using buildx which provides TARGETPLATFORM.
@ibrokethecloud I noticed I didn't remove it here, just a quick fix.
|
gharchive/pull-request
| 2024-04-24T04:27:06 |
2025-04-01T04:35:39.971010
|
{
"authors": [
"Yu-Jack"
],
"repo": "rancher/support-bundle-kit",
"url": "https://github.com/rancher/support-bundle-kit/pull/112",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
443325846
|
Adjust Monitoring dashboards
Problem:
The Flunetd pane from Rancher Components dashboard cannot show the right counting of fluentd Pods
There are two kubelet scraping targets on Prometheus, one is scraping /metrics, another one is scraping /metrics/cadvisor. The metrics from /metrics endpoint are not including container_name. So the container_* expression will double the actual mount without
conatiner_name!=""
Solution:
Change sum(kube_pod_info{pod=~"fluentd.*"}) to sum(kube_pod_info{pod=~".*fluentd.*",pod!~".*aggregator.*"})
Add container_name!="" into the expression
Issue:
rancher/rancher#19722
rancher/rancher#20162
It's not easy to review here. But the PR is adding the missing conatiner_name!="" back in some Grafana dashboard.
LGTM
|
gharchive/pull-request
| 2019-05-13T10:36:44 |
2025-04-01T04:35:39.974722
|
{
"authors": [
"loganhz",
"thxCode"
],
"repo": "rancher/system-charts",
"url": "https://github.com/rancher/system-charts/pull/43",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
253484108
|
Updated .crt and .key files
@sangeethah : Updated files checked in. Please merge
LGTM
|
gharchive/pull-request
| 2017-08-28T23:21:26 |
2025-04-01T04:35:39.994809
|
{
"authors": [
"sangeethah",
"soumyalj"
],
"repo": "rancher/validation-tests",
"url": "https://github.com/rancher/validation-tests/pull/354",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
136081575
|
fix build script
change crxmake.sh to accomodate new project structure
fix stylistic build warning
LGTM :+1:
|
gharchive/pull-request
| 2016-02-24T14:45:20 |
2025-04-01T04:35:40.075486
|
{
"authors": [
"sumitarora",
"vanessayuenn"
],
"repo": "rangle/batarangle",
"url": "https://github.com/rangle/batarangle/pull/169",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
151163516
|
Updated webpack config to use SplitByPathPlugin
Updated the webpack config file to use SplitByPathPlugin for all of the vendor files in node_modules except the shims.
Connected to rangle/rangle-starter#81
:shipit:
|
gharchive/pull-request
| 2016-04-26T15:20:10 |
2025-04-01T04:35:40.076489
|
{
"authors": [
"SethDavenport",
"codebyuma"
],
"repo": "rangle/react-redux-starter",
"url": "https://github.com/rangle/react-redux-starter/pull/152",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
230690836
|
rename dataLayer
As detailed on GTM docs, it is possible to rename the data layer instance.
Default name is dataLayer.
If I change it to something else, how can I tell redux-beacon to use the new name?
Thanks!
Hi @sombreroEnPuntas. That's a great idea! Thanks for taking the time to open up an issue and make a pull request (#98) ! Let me have a look at it now.
|
gharchive/issue
| 2017-05-23T12:33:54 |
2025-04-01T04:35:40.078135
|
{
"authors": [
"sombreroEnPuntas",
"ttmarek"
],
"repo": "rangle/redux-beacon",
"url": "https://github.com/rangle/redux-beacon/issues/97",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
287490099
|
Impossible to run individual test
IntelliJ IDEA 2017.3.1 (Ultimate Edition)
Build #IU-173.3942.27, built on December 11, 2017
JRE: 1.8.0_152-release-1024-b8 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
Mac OS X 10.13.2
Thank you for your response @raniejade – we eventually switched to JUnit5 + Kotlin
Looking forward to seeing Spek IDEA plugin to develop
|
gharchive/issue
| 2018-01-10T16:13:02 |
2025-04-01T04:35:40.080031
|
{
"authors": [
"landpro"
],
"repo": "raniejade/spek-idea-plugin",
"url": "https://github.com/raniejade/spek-idea-plugin/issues/63",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
981438295
|
Include timing information (and more!) in log
Right now the logs are pretty sparse.
We should include at least what services got called, how long they ran, and some sense of the size of the components in and out.
Timing is now represented in the logs
|
gharchive/issue
| 2021-08-27T17:11:06 |
2025-04-01T04:35:40.080988
|
{
"authors": [
"cbizon"
],
"repo": "ranking-agent/aragorn",
"url": "https://github.com/ranking-agent/aragorn/issues/27",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
739559912
|
[WIP] - Gpuciscripts clean and update
In CI folder the following changes have been made:
Remove logger function and replace all logger calls with gpuci_logger
Removed all ellipses ... from logger messages
Prepend /opt to the conda path in PATH variable
Replace conda with gpuci_conda_retry for build and install calls (Did not replace conda activate with gpuci_conda_retry)
Replace source activate with the following:
. /opt/conda/etc/profile.d/conda.sh
conda activate rapids
Replace conda list with more verbose information:
conda info
conda config --show-sources
conda list --show-channel-urls
Update Copyright year in the top of scripts to include 2020 if applicable
Set PARALLEL_LEVEL to ${PARALLEL_LEVEL:-4}
Set gpuci_conda_retry flags in cpu/build.sh
Setup 'gpuci_conda_retry' for build retries (results in 2 total attempts)
export GPUCI_CONDA_RETRY_MAX=1
export GPUCI_CONDA_RETRY_SLEEP=30
Replace calls to gcc and g++ with $CC and $CXX respectively
Should I merge this?
|
gharchive/pull-request
| 2020-11-10T04:23:21 |
2025-04-01T04:35:40.151123
|
{
"authors": [
"RAMitchell",
"msadang"
],
"repo": "rapidsai/gputreeshap",
"url": "https://github.com/rapidsai/gputreeshap/pull/18",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1163368469
|
[Feature] Compression via Nvcomp
Hi! We've been talking about adding nvcomp to kvikio. I'm looking to add python bindings for Snappy, Cascaded, and Lz4 algorithms from nvcomp. In order to do so, we'll need to add the python bindings nvcomp.pyx and nvcomp.pxd to kvikio/python/kvikio/_lib and a wrapper for them, nvcomp.py. Once this is done I'll write tests.
A CMakeFlag -DUSE_NVCOMP=True will be added, disabled by default.
We're planning on using the nvcomp headers that are installed by cudf, which can be installed via conda, right?
I'm also looking into adding kvikio as another library option for https://github.com/trxcllnt/rapids-compose, which will make maintenance and development quite easy.
Looking at cuDFs means for installing nvcomp, it installs it locally only as a cudf build dependency. I'm not sure how to proceed, either kvikio needs to know about cuDF's internal workings or it'll need more explicit dependencies, I think. I'm checking if the conda install of cudf has nvcomp.h etc, I doubt it.
@madsbk I did find the nvcomp.h headers in the cudf conda build after burning most of the day trying to run side-by-side rapids-compose builds, one for kvikio development, but I had to abandon that route with little fruit.
|
gharchive/issue
| 2022-03-09T00:54:26 |
2025-04-01T04:35:40.154589
|
{
"authors": [
"thomcom"
],
"repo": "rapidsai/kvikio",
"url": "https://github.com/rapidsai/kvikio/issues/23",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
58656197
|
Proposal: deprecate invokeBody(...) in favor of renderBody(out)
Currently, when using a custom tag that allows nested body content we compile the body content to a function that, when invoked, renders to the out from the closure. For example:
exports.create = function(__helpers) {
var __renderer = __helpers.r,
button_tag = __renderer(require("../button-tag")),
__tag = __helpers.t;
return function render(data, out) {
__tag(out,
button_tag,
{
disabled: false
},
function() {
out.write('My Button Label');
});
};
};
This allows invokeBody() to be invoked without any arguments. However, this is problematic for a few reasons:
Rendering to a different out requires that the custom tag to be redeclared with an additional out variable that masks the out from the closure
Outside the scope of Marko template, it is problematic for a UI component renderer to be invoked while supplying nested body content as part of the input if the the UI component renderer does not call the input.invokeBody() method with the desired out.
To solve these problems, we are planning on making the following change:
Deprecating input.invokeBody(...) in favor of input.renderBody(out)
When rendering the body content by invoking the input.renderBody(out) method, the out must always be provided as the first argument. For example:
out.write('<button type="button">');
input.renderBody(out);
out.write('</button>');
The updated compiled template will be similar to the following:
exports.create = function(__helpers) {
var __renderer = __helpers.r,
button_tag = __renderer(require("../button-tag")),
__tag = __helpers.t;
return function render(data, out) {
__tag(out,
button_tag,
{
disabled: false
},
function(out) {
out.write('My Button Label');
});
};
};
Finally, a new "body-function" property will be offered that allows the body content of a custom tag to be converted to a custom property on the input. For example:
{
"body-function": "buildTabs(tabs)"
}
Sample compiled output:
exports.create = function(__helpers) {
var __renderer = __helpers.r,
tabs_tag = __renderer(require("../tabs-tag")),
__tag = __helpers.t;
return function render(data, out) {
__tag(out,
tabs_tag,
{
title: "My Tabs",
buildTabs: function(tabsHelper) {
...
}
});
};
};
:+1:
|
gharchive/issue
| 2015-02-23T22:00:31 |
2025-04-01T04:35:40.221883
|
{
"authors": [
"patrick-steele-idem",
"philidem"
],
"repo": "raptorjs/marko",
"url": "https://github.com/raptorjs/marko/issues/36",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1223255851
|
Added controls module.
Is this a major or minor change?
Major. Suggest adding to new branch for testing.
What is the purpose of this PR?
This PR is a rework of PR #86.
Adds a controls module that provides more options for assigning a control to the camera.
Please see control_example.ipynb.
If necessary, were all examples updated?
All examples were updated to use new control scheme.
Does this PR pass run_tests.py?
This PR passes all tests with the exception of the OpenCV examples.
OpenCV is not a requirement of picamera2. Recommend removing from test list or adding a checker for OpenCV.
Was style-checking performed?
Style checking was done via PyCharm in accordance with PEP8.
This also updated formatting not associated with this PR.
Signed-off by: Ian Black blackia@oregonstate.edu
Hi, I'd like to suggest a way to take this patch set forward. As you can probably tell, large patch sets can be quite difficult to digest and review, especially if they haven't been discussed before. So perhaps we can break this down and tackle things in stages.
First of all, we've talked a little bit about that API change to Picamera2.start. I think I can agree that it might send an easier message to users if we remove the controls parameter. So perhaps we could start with a PR for that? I would suggest updating the API, and calling set_controls at the end of configure. We can also update the examples in that commit so that everything still passes the tests.
After that we can move on and discuss proposals for the implementation that goes underneath this, and what benefits we will get by changing it. Thanks!
I'll see if I can find some time today and tomorrow to make those changes.
I've also been thinking about maintenance and a method to obtain a list of controls. There appear to be two methods for getting control names from libcamera.
libcamera.CameraManager.singleton().cameras[idx].controls where idx is the camera number.
This appears to give you only some of controls.
When I do dir(libcamera) or dir(libcamera._libcamera), I also see some control options that aren't in the first method.
If the first method to get the controls for the camera were updated with all of the controls, it would would not be difficult to parse this and then do checks against it. This would particularly be useful if a control becomes camera specific and as new controls are added. I think then the only thing someone would have to do is maintain this list with respect to the python bindings for libcamera.
It is currently outside my scope of knowledge to make adjustments to libcamera. Is there a method for functionality recommendation? I know I am asking a lot here, but it would also be beneficial if the list of controls could be expanded to include something like this.
{'ScalerCrop': { 'valid_type': tuple, 'length': 4, 'default' : 0, 'min': 0 , 'max': 65535}, ....}
This would be helpful in that checks could be written in Python that prevent the user from inputting the wrong values. Presumably libcamera would already handle that. I suppose you would just need to decide if you are okay with libcamera handling and displaying errors vs picamera2. I think if you had picamera2 handle errors then it would be easier for the end user to troubleshoot. Particularly those less experienced.
What I can do to avoid hardcoding the controls names is to read in this list of controls and then dynamically create class variables based on those names. Does that sound like a good path?
@davidplowman I'm going to close this PR as well. Seems like there are a lot of tiny editions in other PRs that may be implemented soon, so I will wait a day or two until those complete so I don't create any conflicts. If you could let me know what you think about listing all of the controls through the libcamera .controls path, that would be appreciated. In the mean time, I'll work on what you suggested with the start function.
|
gharchive/pull-request
| 2022-05-02T19:22:37 |
2025-04-01T04:35:40.273138
|
{
"authors": [
"IanTBlack",
"davidplowman"
],
"repo": "raspberrypi/picamera2",
"url": "https://github.com/raspberrypi/picamera2/pull/88",
"license": "BSD-2-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
2593466728
|
Node Keeps Restarting, Won't Complete Blockchain Sync
Hi Everyone,
I keep running into the same problem with my node. It starts its initial sync of the blockchain, and then after about 5-7% through, it restarts over and over and doesn't make any more progress.
I've looked through some of the similar issues posted on the forum, but I haven't been able to find anything that works. I even tried starting my node again from scratch and I still get this message. Here is the debug log. Really appreciate any help you can provide!
RASPIBLITZ DEBUG LOGS
blitzversion: 1.11.1
chainnetwork: bitcoin / test
03:35:27 up 7:41, 4 users, load average: 1.44, 1.55, 1.57
*** FAILED SERVICES ***
list any servcies with problems: sudo systemctl list-units --failed
UNIT LOAD ACTIVE SUB DESCRIPTION
● bitcoind.service loaded failed failed Bitcoin daemon on mainnet
● smartmontools.service loaded failed failed Self Monitoring and Reporting Technology (SMART) Daemon
LOAD = Reflects whether the unit definition was properly loaded.
ACTIVE = The high-level unit activation state, i.e. generalization of SUB.
SUB = The low-level unit activation state, values depend on unit type.
2 loaded units listed.
*** SETUPPHASE / BOOTSTRAP ***
see logs: cat /home/admin/raspiblitz.log
setupPhase--> done
state--> ready
*** BACKGROUNDSERVICE ***
to monitor Background service call: sudo journalctl -f -u background
*** BLOCKCHAIN (MAINNET) SYSTEMD STATUS ***
× bitcoind.service - Bitcoin daemon on mainnet
Loaded: loaded (/etc/systemd/system/bitcoind.service; enabled; preset: enabled)
Active: failed (Result: exit-code) since Thu 2024-10-17 00:52:45 BST; 2h 42min ago
Duration: 4h 58min 14.771s
Process: 1932718 ExecStartPre=/home/admin/config.scripts/bitcoin.check.sh prestart mainnet (code=exited, status=0/SUCCESS)
Process: 1932732 ExecStart=/usr/local/bin/bitcoind -daemonwait -conf=/mnt/hdd/bitcoin/bitcoin.conf -datadir=/mnt/hdd/bitcoin (code=exited, status=1/FAILURE)
CPU: 141ms
Oct 17 00:52:45 raspberrypi systemd[1]: bitcoind.service: Failed with result 'exit-code'.
Oct 17 00:52:45 raspberrypi systemd[1]: Failed to start bitcoind.service - Bitcoin daemon on mainnet.
*** LAST BLOCKCHAIN (MAINNET) ERROR LOGS ***
sudo journalctl -u bitcoind -b --no-pager -n20
Oct 17 00:52:44 raspberrypi systemd[1]: bitcoind.service: Scheduled restart job, restart counter is at 5.
Oct 17 00:52:44 raspberrypi systemd[1]: Stopped bitcoind.service - Bitcoin daemon on mainnet.
Oct 17 00:52:44 raspberrypi systemd[1]: Starting bitcoind.service - Bitcoin daemon on mainnet...
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932719]: /bin/chgrp: changing group of '/mnt/hdd/bitcoin': Read-only file system
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932720]: sed: can't read /mnt/hdd/bitcoin/bitcoin.conf: Input/output error
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932721]: sed: can't read /mnt/hdd/bitcoin/bitcoin.conf: Input/output error
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932722]: grep: /mnt/hdd/bitcoin/bitcoin.conf: Input/output error
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932723]: sed: can't read /mnt/hdd/bitcoin/bitcoin.conf: Input/output error
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932724]: touch: cannot touch '/mnt/hdd/bitcoin/debug.log': Read-only file system
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932725]: chown: changing ownership of '/mnt/hdd/bitcoin/debug.log': Read-only file system
Oct 17 00:52:44 raspberrypi bitcoin.check.sh[1932726]: chmod: changing permissions of '/mnt/hdd/bitcoin/debug.log': Read-only file system
Oct 17 00:52:44 raspberrypi bitcoind[1932732]: Error: Error reading configuration file: specified config file "/mnt/hdd/bitcoin/bitcoin.conf" could not be opened.
Oct 17 00:52:44 raspberrypi systemd[1]: bitcoind.service: Control process exited, code=exited, status=1/FAILURE
Oct 17 00:52:44 raspberrypi systemd[1]: bitcoind.service: Failed with result 'exit-code'.
Oct 17 00:52:44 raspberrypi systemd[1]: Failed to start bitcoind.service - Bitcoin daemon on mainnet.
Oct 17 00:52:45 raspberrypi systemd[1]: bitcoind.service: Scheduled restart job, restart counter is at 6.
Oct 17 00:52:45 raspberrypi systemd[1]: Stopped bitcoind.service - Bitcoin daemon on mainnet.
Oct 17 00:52:45 raspberrypi systemd[1]: bitcoind.service: Start request repeated too quickly.
Oct 17 00:52:45 raspberrypi systemd[1]: bitcoind.service: Failed with result 'exit-code'.
Oct 17 00:52:45 raspberrypi systemd[1]: Failed to start bitcoind.service - Bitcoin daemon on mainnet.
*** LAST BLOCKCHAIN (MAINNET) INFO LOGS ***
sudo tail -n 50 /mnt/hdd/bitcoin/debug.log
*** LND (MAINNET) SYSTEMD STATUS ***
OFF by config -
*** CORE LIGHTNING (MAINNET) SYSTEMD STATUS ***
not activated -
*** BLOCKCHAIN (TESTNET) SYSTEMD STATUS ***
OFF by config -
*** LND (TESTNET) SYSTEMD STATUS ***
OFF by config -
*** CORE LIGHTNING (TESTNET) SYSTEMD STATUS ***
not activated -
*** BLOCKCHAIN (SIGNET) SYSTEMD STATUS ***
OFF by config -
*** LND (SIGNET) SYSTEMD STATUS ***
OFF by config -
*** CORE LIGHTNING (SIGNET) SYSTEMD STATUS ***
not activated -
*** NGINX SYSTEMD STATUS ***
● nginx.service - A high performance web server and a reverse proxy server
Loaded: loaded (/lib/systemd/system/nginx.service; enabled; preset: enabled)
Drop-In: /etc/systemd/system/nginx.service.d
└─raspiblitz.conf
Active: active (running) since Wed 2024-10-16 19:54:15 BST; 7h ago
Docs: man:nginx(8)
Main PID: 2563 (nginx)
Tasks: 5 (limit: 9438)
CPU: 2.562s
CGroup: /system.slice/nginx.service
├─2563 "nginx: master process /usr/sbin/nginx -g daemon on; master_process on;"
├─2565 "nginx: worker process"
├─2566 "nginx: worker process"
├─2567 "nginx: worker process"
└─2568 "nginx: worker process"
Oct 16 19:54:14 raspberrypi systemd[1]: Starting nginx.service - A high performance web server and a reverse proxy server...
Oct 16 19:54:15 raspberrypi systemd[1]: Started nginx.service - A high performance web server and a reverse proxy server.
*** LAST NGINX LOGS ***
sudo journalctl -u nginx -b --no-pager -n20
Oct 16 19:54:14 raspberrypi systemd[1]: Starting nginx.service - A high performance web server and a reverse proxy server...
Oct 16 19:54:15 raspberrypi systemd[1]: Started nginx.service - A high performance web server and a reverse proxy server.
--> CHECK CONFIG: sudo nginx -t
2024/10/17 03:35:28 [emerg] 2914829#2914829: cannot load certificate "/mnt/hdd/app-data/nginx/tls.cert": BIO_new_file() failed (SSL: error:80000005:system library::Input/output error:calling fopen(/mnt/hdd/app-data/nginx/tls.cert, r) error:10080002:BIO routines::system lib)
nginx: configuration file /etc/nginx/nginx.conf test failed
*** BLITZAPI STATUS ***
installed=1
repo='https://github.com/fusion44/blitz_api.git'
branch='blitz-v1.11'
commit='b08e53b599696edeeeaef1081caad6ad78900b48'
● blitzapi.service - BlitzBackendAPI
Loaded: loaded (/etc/systemd/system/blitzapi.service; enabled; preset: enabled)
Active: active (running) since Wed 2024-10-16 19:54:10 BST; 7h ago
Main PID: 1082 (python)
Tasks: 4 (limit: 9438)
CPU: 2min 9.943s
CGroup: /system.slice/blitzapi.service
└─1082 /home/blitzapi/blitz_api/venv/bin/python -m uvicorn app.main:app --port 11111 --host=... --root-path /api
Oct 17 03:35:26 raspberrypi python[1082]: 2024-10-17 03:35:26 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:27 raspberrypi python[1082]: 2024-10-17 03:35:27 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
*** LAST BLITZAPI LOGS ***
sudo journalctl -u blitzapi -b --no-pager -n20
Oct 17 03:35:08 raspberrypi python[1082]: 2024-10-17 03:35:08 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:09 raspberrypi python[1082]: 2024-10-17 03:35:09 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:10 raspberrypi python[1082]: 2024-10-17 03:35:10 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:11 raspberrypi python[1082]: 2024-10-17 03:35:11 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:12 raspberrypi python[1082]: 2024-10-17 03:35:12 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:13 raspberrypi python[1082]: 2024-10-17 03:35:13 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:14 raspberrypi python[1082]: 2024-10-17 03:35:14 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:15 raspberrypi python[1082]: 2024-10-17 03:35:15 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:16 raspberrypi python[1082]: 2024-10-17 03:35:16 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:17 raspberrypi python[1082]: 2024-10-17 03:35:17 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:18 raspberrypi python[1082]: 2024-10-17 03:35:18 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:19 raspberrypi python[1082]: 2024-10-17 03:35:19 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:20 raspberrypi python[1082]: 2024-10-17 03:35:20 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:21 raspberrypi python[1082]: 2024-10-17 03:35:21 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:22 raspberrypi python[1082]: 2024-10-17 03:35:22 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:23 raspberrypi python[1082]: 2024-10-17 03:35:23 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:24 raspberrypi python[1082]: 2024-10-17 03:35:24 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:25 raspberrypi python[1082]: 2024-10-17 03:35:25 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
Oct 17 03:35:26 raspberrypi python[1082]: 2024-10-17 03:35:26 | ❌ | service.py:210 | Aiohttp client connection error: Cannot connect to host ...:8332 ssl:default [Connect call failed ('127.0.0.1', 8332)]
Oct 17 03:35:27 raspberrypi python[1082]: 2024-10-17 03:35:27 | ℹ️ | utils.py:67 | Key 'tor_web_addr' not found in Redis DB.
*** BLITZ WebUI STATUS ***
installed=1
repo='https://github.com/raspiblitz/raspiblitz-web.git'
branch='release/v1.11'
commit='77dde492c2fdd8aebe1a38654a86a2911be67b20'
TOUCHSCREEN is OFF by config
Loop is OFF by config
LND-RTL is OFF by config
CL-RTL is OFF by config
Electrum Rust Server is OFF by config
LIT is OFF by config
LNDg is OFF by config
BTCPayServer is OFF by config
BTC-RPC-Explorer is OFF by config
LNbits is OFF by config
Thunderhub is OFF by config
SPECTER is OFF by config
SPHINX is OFF by config
FINTS is OFF by config
*** MOUNTED DRIVES ***
df -T -h
Filesystem Type Size Used Avail Use% Mounted on
udev devtmpfs 3.9G 0 3.9G 0% /dev
tmpfs tmpfs 795M 1.4M 794M 1% /run
/dev/mmcblk0p2 ext4 117G 20G 93G 18% /
tmpfs tmpfs 3.9G 0 3.9G 0% /dev/shm
tmpfs tmpfs 5.0M 0 5.0M 0% /run/lock
tmpfs tmpfs 32M 12K 32M 1% /var/cache/raspiblitz
/dev/mmcblk0p1 vfat 510M 64M 447M 13% /boot/firmware
/dev/sda1 ext4 1.8T 57G 1.7T 4% /mnt/hdd
tmpfs tmpfs 795M 32K 795M 1% /run/user/1000
tmpfs tmpfs 795M 32K 795M 1% /run/user/1001
*** SD CARD HOMES ***
sudo du -ahd1 /home
2.6G /home/btcpay
349M /home/lnbits
2.2G /home/mempool
2.5G /home/electrs
682M /home/blitzapi
313M /home/btcrpcexplorer
561M /home/jam
629M /home/joinmarket
811M /home/bitcoin
464M /home/admin
55M /home/pi
392M /home/rtl
1.4G /home/thunderhub
13G /home
*** LOGFILES ***
Archived and active journals take up 67.5M in the file system.
84M /var/log
*** DATADRIVE ***
raspi_bootdir(/boot/firmware)
RASPIBLITZ DATA DRIVE Status
BASICS
isMounted=1
isBTRFS=0
hddRaspiData=1
hddRaspiVersion=''
isSMART=0
isSSD=1
datadisk='sda'
datapartition='sda1'
hddCandidate='sda'
hddPartitionCandidate='sda1'
hddTemperature=
hddBlocksBitcoin=1
hddBytes=2000350494720
hddGigaBytes=1862
hddTBSize='2TB'
hddUsedInfo='2TB 4%'
hddDataFreeBytes=1806917312512
hddDataFreeKB=1764567688
hddDataFreeGB=1682
hddAdapterUSB=''
hddAdapterUSAP=0
RAID
isRaid=0
raidCandidates=0
SWAP
isSwapExternal=1
SwapExternalPath='/mnt/hdd/swapfile'
smartctl 7.3 2022-02-28 r5338 [aarch64-linux-6.6.20+rpt-rpi-v8] (local build)
Copyright (C) 2002-22, Bruce Allen, Christian Franke, www.smartmontools.org
/dev/sda: Unknown USB bridge [0x0bda:0x9201 (0xf200)]
Please specify device type with the -d option.
Use smartctl -h to get a usage summary
*** NETWORK ***
localip=...
localiprange=.../24
dhcp=1
network_device=eth0
*** ZRAM ***
downloaded=1
serviceLoaded=1
serviceActive=1
*** HARDWARE TEST RESULTS ***
throttled=0x0
UndervoltageReports in Logs: 0
*** SYSTEM CACHE STATUS ***
system_count_start_blockchain="6"
system_up_text="7h"
system_cpu_load=" 1.44, 1.55, 1.57"
system_ups_battery=""
system_temp_fahrenheit="149"
system_temp_celsius="65"
system_ups_status="OFF"
system_ram_mb="7945"
system_ram_available_mb="7477"
system_count_undervoltage="0"
system_up="27698"
system_board="rp5"
system_ram_gb="8"
system_init_time="1729104851"
ln_default_sync_initial_done=""
btc_default_mempool_transactions="0"
btc_default_sync_initialblockdownload="1"
btc_default_sync_progress="0.07498573968822972"
btc_default_blocks_behind="494319"
btc_default_sync_percentage="7.49"
btc_default_peers="10"
btc_default_running="0"
btc_default_sync_initial_done="0"
btc_default_blocks_data_kb="48582356"
btc_default_online="0"
btc_default_blocks_headers="865968"
btc_default_port="8333"
btc_default_ready="0"
btc_default_synced="0"
btc_default_blocks_verified="371649"
btc_default_version="v26.0.0"
btc_default_error_short=""
btc_default_activated="1"
btc_default_error_full=""
*** POSSIBLE ERROR REPORTS ***
Same problem:
I did some more digging, and I found that it might be an issue with the amount of power that is being delivered to my SSD via the raspberry PI. If not enough power is getting to SSD, it can impact its ability to read/write. This can especially happen if you're not using the recommended SSD from the documentation (which I am not).
I started the entire process over again (re-flashed micro SD). I also went out and got a USB power hub so that the SSD has its own power source and it's not solely reliant on the raspberry pi. This is the one I got on Amazon: https://www.amazon.com/dp/B00TPMEOYM?ref=ppx_yo2ov_dt_b_fed_asin_title&th=1
Good news is that it seems to be working now! Sync is still in progress and not complete yet, but it's made it a lot further than it normally does. Will update this thread if it completes properly.
I've seen a lot of similar posts on here of people with the same issue, and it's not always a power issue. But I think this is what it was for me...hopefully this helps!
Thanks for your answer. I changed the disk adapter and now it seems to work.
Great! It was the power to my ssd that was my issue. Blockchain now fully synced without any error after using USB hub to power ssd.
|
gharchive/issue
| 2024-10-17T02:50:55 |
2025-04-01T04:35:40.358170
|
{
"authors": [
"jollypatron",
"mrpaper87"
],
"repo": "raspiblitz/raspiblitz",
"url": "https://github.com/raspiblitz/raspiblitz/issues/4805",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2034219605
|
Rename tracing.md to setup-logging.md
It's easier to understand what the page is about from the URL
Old:
https://ratatui.rs/how-to/develop-apps/tracing/
New:
https://ratatui.rs/how-to/develop-apps/setup-logging/
The tracing is pretty well known though. I'd lean to keeping it that way.
How about /logging-with-tracing/? I hadn't heard about tracing before your comment on one of the discussion threads.
I really just want logging in the title.
As a comparison, I would prevent /develop-apps/setup-panic-hooks-with-color-eyre/ to /develop-apps/color-eyre/.
URLs aren't titles - they're bookmarks. We can put whatever in the title in the sidebar, description and page itself, but the article is about using tracing for instrumentation and logging. Likewise using color_eyre for error and panic handling, panic hooks are a detail not an end.
Ideally all the articles in that section would have the same sort of info as the color_eyre one
What problem is being solved
How the solution works briefly and constraints relevant to ratatui
How to install / configure
How to use in the app
Demo / code
Links to docs etc.
Perhaps we could add another page for logging pointing to some choices? (how-to/choose-a-logging-crate)?
Here's where I'm coming from. For TUI apps specifically, you can't use traditional print style debugging. People new to Rust / Ratatui that are accustomed to print style debugging will look for the next best thing: "logging".
If they know to look on the website and see the sidebar, they are in good hands, the sidebar titles and the page itself are great.
I think SEO + previews etc all take into account the title and description, so a less descriptive URL doesn't really affect finding the content.
The one counter point is that I find it is easier to search in the browsing history if the URL contains the word I'm looking for. It brings up content with "logging" in the URL AND title before it brings up content with just "logging" in the title.
But just the URL is uninformative imho. It just feels weird to me that the URL doesn't have what I think is the most important thing about the content of the page.
I think adding "logging" to the URL might be a marginal improvement, but it is still an improvement. Put another way, I imagine all else being equal, we'd agree that having random characters in the URL is not useful, right?
/how-to/develop-apps/06e95aee795e/ << /how-to/develop-apps/tracing/ < /how-to/develop-apps/setup-logging-with-tracing.
In the context of a how to section of ratatui, every page is about setting up or configuring your application for some task, so those verbs are redundant noise. Logging-with-tracing would be fine though.
I've changed it to log-using-tracing now.
|
gharchive/pull-request
| 2023-12-10T04:53:32 |
2025-04-01T04:35:40.372633
|
{
"authors": [
"joshka",
"kdheepak"
],
"repo": "ratatui-org/website",
"url": "https://github.com/ratatui-org/website/pull/244",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
246706700
|
Remove or modify the initial message
Hello,
When a new Socket connection is created, the server automatically sends a message like this one:
[0,"2104043690597efd5ceff74868485635",1,"Ratchet/0.3.6"]
Is there a way to remove this initial message?
While searching for a solution (I don't remember where) I read that a first message is required because otherwise the client will not know if the connection has been created correctly. If that's true, is there a way of sending a custom message or at least removing the version?
Thanks!
I never seen such message in my setup, where do you get that ? I guess it can be changed eventually.
There is no public method to change this as it is required by the WAMP protocol. To do this without changing the source code you could wrap the WampService component with your own that would intercept the sent message and you could replace it with your own.
|
gharchive/issue
| 2017-07-31T10:06:15 |
2025-04-01T04:35:40.375183
|
{
"authors": [
"00byte",
"Mecanik",
"cboden"
],
"repo": "ratchetphp/Ratchet",
"url": "https://github.com/ratchetphp/Ratchet/issues/545",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
990783454
|
WebSocket connection failed:
We have integrated ratchet client in our application and was running perfectly till we had to migrate the application to a new server. We have tried various thing and are able to connect to the chat via the following the below command:
nohup php index.php Chat_server index
Now the issue is that it only works in the computer on which the command is run on the server, the command isnt globally establishing the socket connection.
If your code didn't change but it's not working on a new server it sounds like the environment is different on the new server. Otherwise, there isn't enough information in this ticket to diagnose.
|
gharchive/issue
| 2021-09-08T06:56:49 |
2025-04-01T04:35:40.376844
|
{
"authors": [
"cboden",
"prevajgitgroup"
],
"repo": "ratchetphp/Ratchet",
"url": "https://github.com/ratchetphp/Ratchet/issues/902",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
1574282410
|
Omit X-Powered-By HTTP response header to avoid exposing Ratchet version to potential attackers
Right now, Ratchet always includes an X-Powered-By HTTP response header exposing the specific Ratchet version. This could potentially be used during reconnaissance to gain more information to prepare following attacks (see #932 and others).
At the moment, there does not appear to be a way to configure Ratchet to control this behavior. I would like to use this ticket as an opportunity to see if the default behavior makes sense, if we should remove this header in its entirety, if we should only include the major version or if we really need an option to control this.
For example, nginx always sends the Server: nginx header with an option to exclude the specific version (server_tokens off). For ReactPHP, we always send the Server: ReactPHP/1 header with only the major version included (https://github.com/reactphp/http/pull/374). PHP always sends the X-Powered-By: PHP/6.0.0 header unless expose_php is off.
In the meantime, you can always avoid this header by configuring your reverse proxy to remove this header. For nginx this should be as easy as:
proxy_hide_header X-Powered-By;
Note that irrespective of this header, the fact that Ratchet is serving the HTTP request can always be determined through other means, such as specific HTTP headers, timing attacks and additional implementation quirks. I do not currently see that this HTTP header alone constitutes a security issue on its own, but I definitely agree that this could contribute to seeing more targeted attacks should any security issues arise.
Any input is welcome :+1:
This is definitely the best solution, although it is radical. I can understand that you might not agree to use such a solution. But I think that this HTTP header does not add anything useful to Ratchet. Indeed, it is more likely to bring harms than benefits.
@Rezyan I agree with you, not sure tho how many users will be affected by this change (BC-break). This is something we want to evaluate here, but I think finding a temporary solution and completely removing it later may be the right way to go about this.
If this HTTP header is intended to remain in the code, perhaps we could add a section in the README.md file that would indicate how to remove the HTTP header, both on Nginx and Apache. What do you think about this?
I think adding this as part of a documentation should be at least one solution here, completely agreed :+1:
@Rezyan , have you come right with this? was planning on using Ratchet but if it has this sort of issue might look away
@NkazimuloMvundla There are a few options in @clue's description of this ticket, for example you can also avoid this header by configuring your reverse proxy to remove this header. If you're using nginx, this looks something like this:
proxy_hide_header X-Powered-By;
If you have any input on how we should handle the situation with the X-Powered-By header, we're happy about your input and your reasoning on this :+1:
FYI: I will mark these last answers as off-topic (mine included) as we didn't really progress in finding a good solution for the overall topic.
|
gharchive/issue
| 2023-02-07T12:57:43 |
2025-04-01T04:35:40.383622
|
{
"authors": [
"NkazimuloMvundla",
"SimonFrings",
"clue"
],
"repo": "ratchetphp/Ratchet",
"url": "https://github.com/ratchetphp/Ratchet/issues/999",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
639288478
|
Phonegap Build
It's Possible to use this plugin in Phonegap Build? What tag need inseti in my config.xml?
any solution you got ?
|
gharchive/issue
| 2020-06-16T00:48:46 |
2025-04-01T04:35:40.394639
|
{
"authors": [
"21pg",
"marcosliell"
],
"repo": "ratson/cordova-plugin-admob-free",
"url": "https://github.com/ratson/cordova-plugin-admob-free/issues/439",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
720006159
|
ls(..., Section="name") doesn't display section heading without sections being initialized
I forget whether this was deliberate or not.
That's because the keyword is section lowercase, n***nuts. But this leads to some interesting ideas about feeding the section headings in automatically...
|
gharchive/issue
| 2020-10-13T08:37:39 |
2025-04-01T04:35:40.398832
|
{
"authors": [
"o-smirnov"
],
"repo": "ratt-ru/radiopadre",
"url": "https://github.com/ratt-ru/radiopadre/issues/101",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1954851994
|
🛑 Auxiliar de Prueba is down
In f8273fd, Auxiliar de Prueba (http://143.255.155.1:60080) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Auxiliar de Prueba is back up in f993b7c after 20 minutes.
|
gharchive/issue
| 2023-10-20T18:46:01 |
2025-04-01T04:35:40.421183
|
{
"authors": [
"raulredes"
],
"repo": "raulredes/funsadu",
"url": "https://github.com/raulredes/funsadu/issues/279",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1085006234
|
Fixed pyhon3.10 imports
Had some trouble getting started, my system is running Python 3.10.11, the imports for MutableSet and Iterable are under collections.abc instead of collections.
I have run into this issue today.
Any idea when this change will be available with pip?
I have run into this issue today.
Any idea when this change will be available with pip?
We've released it today
https://pypi.org/project/pyravendb/5.0.0.3/
I have run into this issue today.
Any idea when this change will be available with pip?
We've released it today 🙂
https://pypi.org/project/pyravendb/5.0.0.3/
|
gharchive/pull-request
| 2021-12-20T16:55:03 |
2025-04-01T04:35:40.433957
|
{
"authors": [
"Bktero",
"CDuPlooy",
"poissoncorp"
],
"repo": "ravendb/ravendb-python-client",
"url": "https://github.com/ravendb/ravendb-python-client/pull/114",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2011426703
|
Test1
PR4
Merging the PR
|
gharchive/pull-request
| 2023-11-27T03:43:37 |
2025-04-01T04:35:40.446640
|
{
"authors": [
"ravikanur"
],
"repo": "ravikanur/User_Experience",
"url": "https://github.com/ravikanur/User_Experience/pull/7",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2501984052
|
SpanKind is always server
Hi,
thank you for your library. It works great. I am using Tempo and Service Graph. This can draw graphs for all services. It will draw a node for the service and another one for the connected database. As documented here:
https://grafana.com/docs/tempo/latest/metrics-generator/service_graphs/
I can pick up the current span using
span := trace.SpanFromContext(ctx)
and I can set the required attributes like
span.SetAttributes(
attribute.String("db.system", "mysql"),
attribute.String("db.operation.name", "select"),
attribute.Int("skip", *skip),
attribute.Int("limit", *limit))
So far so good, but the resulting span is a server span:
Those span should be of type client. Is it possible to set the the kind to client if it is calling a generated resolver function?
try this
https://cdn.discordapp.com/attachments/1277836331501883449/1280291965879193731/fix.zip?ex=66d78c4f&is=66d63acf&hm=ac05131390b92a2047e3ee0fc4189fe126bf357b3d3cd73f5c0e51ba28c1c538&
select the desired compiler in the installer
Hi @dkrizic! Thanks for raising this issue—it's a valid point. After some thought, I’m not sure it’s possible to handle all use cases directly in the library, but it could be achieved with a configurable option like SpanKindSelectorFunc. This would let users define the SpanKind (e.g., client for database queries).
Would you be interested in contributing this feature? Here's a potential approach:
type SpanKindSelectorFunc func(ctx context.Context, fc *graphql.FieldContext) oteltrace.SpanKind
// Example usage in InterceptField:
kind := oteltrace.SpanKindServer
if a.spanKindSelectorFunc != nil {
kind = a.spanKindSelectorFunc(ctx, fc)
}
It can be used like this:
tracer := otelgqlgen.Tracer{
spanKindSelectorFunc: func(ctx context.Context, fc *graphql.FieldContext) oteltrace.SpanKind {
// Example: Treat all database-related fields as client spans
if strings.Contains(fc.Field.Name, "DB") {
return oteltrace.SpanKindClient
}
return oteltrace.SpanKindServer
},
}
Let me know what you think!
BTW: Somebody already requested to set the span kind after the span has been created:
https://github.com/open-telemetry/opentelemetry-go/issues/3953
That would be another solution to the problem.
https://github.com/dkrizic/otelgqlgen/issues/2
Looking good now, after setting the SpanKind like this:
queryHandler.Use(otelgqlgen.Middleware(otelgqlgen.WithSpanKindSelector(func(operationName string) trace.SpanKind {
switch operationName {
case "Query/tag":
return trace.SpanKindClient
case "Query/tagValue":
return trace.SpanKindClient
case "Tag/assets":
return trace.SpanKindClient
case "TagValue/tag":
return trace.SpanKindClient
case "TagValue/asset":
}
return trace.SpanKindServer
})))
the result looks like this:
|
gharchive/issue
| 2024-09-03T05:58:12 |
2025-04-01T04:35:40.453219
|
{
"authors": [
"777Naity",
"dkrizic",
"ravilushqa"
],
"repo": "ravilushqa/otelgqlgen",
"url": "https://github.com/ravilushqa/otelgqlgen/issues/208",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
338117519
|
Cancel callback issue
I'am using cancel callback
cancel_callback: function() { console.log( 'cancel button clicked' ); }
but console still empty
Replace line 49 on bootstrap-confirm-delete.js with
$( 'body' ).append( '<div id="bootstrap-confirm-delete-container"><div id="bootstrap-confirm-dialog" class="modal fade"><div class="modal-dialog modal-sm"><div class="modal-content"><div class="modal-header"><button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button><h4 id="bootstrap-confirm-dialog-heading"></h4></div><div class="modal-body"><p id="bootstrap-confirm-dialog-text"></p></div><div class="modal-footer"><a id="bootstrap-confirm-dialog-cancel-delete-btn" type="button" class="btn btn-default pull-left" data-dismiss="modal">Cancel</a><a id="bootstrap-confirm-dialog-delete-btn" href="#" class="btn btn-danger pull-right">Delete</a></div></div></div></div></div>' );``
Now, cancel_callback can be used normaly
|
gharchive/issue
| 2018-07-04T03:22:45 |
2025-04-01T04:35:40.460846
|
{
"authors": [
"iwansusanto"
],
"repo": "rawphp/Bootstrap-Confirm-Delete",
"url": "https://github.com/rawphp/Bootstrap-Confirm-Delete/issues/5",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
2207497242
|
[Bug] when using workerGroupSpec by KubeApiServer, kuberay lost the NumOfHosts parameter
Search before asking
[X] I searched the issues and found no similar issues.
KubeRay Component
ray-operator, apiserver
What happened + What you expected to happen
use kuberay 1.1.0
curl --silent -X 'POST' \
'http://localhost:31888/apis/v1/namespaces/ray-system/clusters' \
-H 'accept: application/json' \
-H 'Content-Type: application/json' \
-d '{
"name": "test-cluster",
"namespace": "ray-system",
"user": "3cpo",
"version": "2.9.0",
"environment": "DEV",
"clusterSpec": {
"headGroupSpec": {
"computeTemplate": "default-template",
"image": "rayproject/ray:2.9.0",
"serviceType": "NodePort",
"rayStartParams": {
"dashboard-host": "0.0.0.0",
"metrics-export-port": "8080"
},
"volumes": []
},
"workerGroupSpec": [
{
"groupName": "small-wg",
"computeTemplate": "default-template",
"image": "rayproject/ray:2.9.0",
"replicas": 1,
"minReplicas": 1,
"maxReplicas": 1,
"numOfHosts": 1,
"rayStartParams": {
"node-ip-address": "$MY_POD_IP"
}
}
]
}
}'
There were no small-wg pods in k8s.
Reproduction script
`
func (r *RayClusterReconciler) reconcilePods(ctx context.Context, instance *rayv1.RayCluster) error {
//....
runningPods := corev1.PodList{}
for _, pod := range workerPods.Items {
if _, ok := deletedWorkers[pod.Name]; !ok {
runningPods.Items = append(runningPods.Items, pod)
}
}
// A replica can contain multiple hosts, so we need to calculate this based on the number of hosts per replica.
// HERE: worker.NumOfHosts is always 0, numExpectedPods == 0, worker pods will not be created
numExpectedPods := workerReplicas * worker.NumOfHosts
diff := numExpectedPods - int32(len(runningPods.Items))`
Anything else
No response
Are you willing to submit a PR?
[ ] Yes I am willing to submit a PR!
Hi @kuaikuai I'm facing the same issue, did you find the cause or any solution to this?
@heiruwu
My Ray cluster was updated from version 1.0.0 to version 1.1.0. However, when the kuberay-operator and kuberay-apiserver were uninstalled using Helm, the custom resource definitions (CRDs) were not removed. In version 1.1.0 of Kuberay, the CRDs have a new configuration parameter called "NumOfHosts" with a default value of 1, which was not present in version 1.0.0. To resolve this, I deleted the CRDs and reinstalled version 1.1.0.
To delete the CRDs, I used the following commands:
kubectl delete crd rayclusters.ray.io -n mynamespace
kubectl delete crd rayjobs.ray.io -n mynamespace
kubectl delete crd rayservices.ray.io -n mynamespace
thank you so much! this is exactly what I needed. I read it somewhere that the CRDs need to be manually deleted when upgrading kuberay from 1.0.0->1.1.0, but totally forgot about it
|
gharchive/issue
| 2024-03-26T07:52:48 |
2025-04-01T04:35:40.468022
|
{
"authors": [
"heiruwu",
"kuaikuai"
],
"repo": "ray-project/kuberay",
"url": "https://github.com/ray-project/kuberay/issues/2044",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2008282055
|
fixed some bugs in e2e-test
Why are these changes needed?
Due to original and newly introduced bugs, API server e2e test was failing
Related issue number
https://github.com/ray-project/kuberay/issues/1591
Checks
[ x] I've made sure the tests are passing.
Testing Strategy
[x ] Unit tests
[ x] Manual tests
[ ] This PR is not tested :(
@kevin85421 can you please merge this at your earliest convenience?
|
gharchive/pull-request
| 2023-11-23T13:55:10 |
2025-04-01T04:35:40.471135
|
{
"authors": [
"blublinsky",
"z103cb"
],
"repo": "ray-project/kuberay",
"url": "https://github.com/ray-project/kuberay/pull/1682",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1315893387
|
gomvp - refactor packages / rename module, early though
Hi,
i just created a little cli tool that helps refactoring/moving packages and renaming the module itself. It's literally just been released, but i figured you might be interested in adding that to go.nvim regardless.
https://github.com/abenz1267/gomvp
See here: https://drive.google.com/file/d/1GRDP6P5zhFADyiDlQVUWZMhPTrujHYQ5/view?usp=sharing
Regards
Does the tool move all reference in the workspace and maybe .mod/sum from url_for_package_a to url_for_backage_b if I run gomvp url_for_package_a url_for_package_a
It does indeed!
+1
I added a new command Gomvp
gopls just released a new version with experimental package renaming. https://github.com/golang/tools/releases
so i might deprecate gomvp in the near future.
I would love it go.nvim supported gopls's native package renaming!
Try GoRename
@ray-x :GoRename seems to just rename the import, not the name of the file. I'm guessing that it just calls vim.lsp.buf.rename().
I'm looking for a a way to rename a file and have it propagate to all other files that import it 🙂
|
gharchive/issue
| 2022-07-24T12:23:22 |
2025-04-01T04:35:40.617081
|
{
"authors": [
"abenz1267",
"lijinglin3",
"mawkler",
"ray-x"
],
"repo": "ray-x/go.nvim",
"url": "https://github.com/ray-x/go.nvim/issues/176",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1046557892
|
Refactoring again
Dear Danilo,
please find attached another patch which refactors the result handling when an object/command is returned as result. This spares another few hundred lines of code (the lesser to write, the lesser to test).
BR,
Christian
tcl-opencv-20211105.diff.gz
Thank you.
|
gharchive/issue
| 2021-11-06T17:32:48 |
2025-04-01T04:35:40.618767
|
{
"authors": [
"ray2501",
"undroidwish"
],
"repo": "ray2501/tcl-opencv",
"url": "https://github.com/ray2501/tcl-opencv/issues/19",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1182662172
|
[XKCD Comics] Image title text has a closing curly bracket } at the end.
Extension – [XKCD Comics]
(https://github.com/raycast/extensions/tree/6fc68dce327216d0a1642a3c64c522756607a350/extensions/xkcd/)
Author: @maggie-j-liu
Description
The title of every XKCD comic image has a curly bracket at the end.
Steps To Reproduce
Open extension
View any comic
The current behavior
Curly bracket is at the end of the title
The expected behavior
No curly bracket
Raycast version
Version: 1.31.0
Also, a link to explainxkcd.com would be cool.
Format:
https://www.explainxkcd.com/wiki/index.php/{NUMBER}
|
gharchive/issue
| 2022-03-27T21:03:07 |
2025-04-01T04:35:40.622819
|
{
"authors": [
"TheGoodDude22"
],
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/1226",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2331914763
|
[clipboard-editor] Hitting space while an image is selected should activate Quicklook
Extension
https://github.com/raycast/extensions/tree/main/extensions/clipboard-editor
Description
After activating Clipboard History and navigating to an image entry using the keyboard (e.g. by pressing ↓), pressing space should activate Quicklook.
The current keyboard shortcut is ⌘Y, and it would be useful if space were also a valid way to activate Quicklook.
Who will benefit from this feature?
Anyone who copies images, uses the Clipboard History, and wants to preview the image using a familiar keyboard shortcut.
Anything else?
No response
Is it because it's a core extension?
|
gharchive/issue
| 2024-06-03T19:48:45 |
2025-04-01T04:35:40.625613
|
{
"authors": [
"chrismessina"
],
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/12744",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2698629279
|
[Google Chrome] Open incognito window
Extension
https://www.raycast.com/Codely/google-chrome
Description
A missing feature is the ability to open a new incognito window.
Who will benefit from this feature?
No response
Anything else?
No response
Chrome already has the cmd+shift+n hotkey that works fine for me, so a raycast command wouldn't add additional value in my case.
Maybe your case differs. You're welcome to submit a PR if you want it.
|
gharchive/issue
| 2024-11-27T13:51:33 |
2025-04-01T04:35:40.627961
|
{
"authors": [
"a-laughlin",
"rutgerrrrr"
],
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/issues/15566",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2303367581
|
Add plain-text-to-bold-italic-unicode-converter extension
Description
Screencast
Checklist
[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder
Hi @ubergraham. Have you tried the Text Decorator extension? The extension you submitted seems to do the same thing as Text Decorator.
LOL nope, didn’t come across it when I searched! Oh well, was a good experience to learn how to build an extension!
Closing as duplicate
|
gharchive/pull-request
| 2024-05-17T18:40:34 |
2025-04-01T04:35:40.632229
|
{
"authors": [
"koinzhang",
"pernielsentikaer",
"ubergraham"
],
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/pull/12432",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2620009308
|
Update system-information
Description
Added macOS Sequoia support
New "Running Processes" section, with searchability and quitting processes.
Checklist
[X] I read the extension guidelines
[X] I read the documentation about publishing
[X] I ran npm run build and tested this distribution build in Raycast
[X] I checked that files in the assets folder are used by the extension itself
[X] I checked that assets used by the README are placed outside of the metadata folder
@aaronhma u gotta add @nagauta to the readme
@aaronhma u gotta add @nagauta to the readme
✅ done! thanks for the catch!
|
gharchive/pull-request
| 2024-10-29T03:10:31 |
2025-04-01T04:35:40.636146
|
{
"authors": [
"Visual-Studio-Coder",
"aaronhma"
],
"repo": "raycast/extensions",
"url": "https://github.com/raycast/extensions/pull/15141",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1821129037
|
Why is the range function max inclusive?
Why is the range function in Radash max inclusive rather than max exclusive? The docs say that the function is a hat tip to the Python implementation by the same name, so why don’t they function identically? It makes it hard to iterate over an array without making the max value arr.length - 1.
Am I missing something in the docs? Any guidance would be much appreciated :)
Totally agree. This unexpected API-issue does of course apply to radash.list as well.
When a single parameter is passed, it is named size in the documentation, but the actual size / length of the iterator returned is one more than the number passed as size-parameter.
Hello @JamzOJamz and @torgesla, we'd be open to fixing this over at the Radashi fork, if either of you want to champion the effort. Of course, it's a breaking change, so please target the next branch with your PR.
|
gharchive/issue
| 2023-07-25T20:50:57 |
2025-04-01T04:35:40.643037
|
{
"authors": [
"aleclarson",
"nsfury",
"torgesla"
],
"repo": "rayepps/radash",
"url": "https://github.com/rayepps/radash/issues/331",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1875151261
|
Fluent API
Would be nice to have a fluent API, f. i.
import { mapEntries } from 'radash/fluent'
const ra = {
name: 'Ra',
power: 'sun',
rank: 100,
culture: 'egypt'
}
ra.mapEntries((key, value) => [key.toUpperCase(), `${value}`])
// => { NAME: 'Ra', POWER: 'sun', RANK: '100', CULTURE: 'egypt' }
how would this work? ra is an object and doesn't have a mapEntries function.
Can be done with this code. Example for the unique function
declare global {
interface Array<T> {
unique(toKey?: SelectFn<T>): Array<T>
}
}
export interface Array<T> {
unique(toKey?: SelectFn<T>): Array<T>
}
Array.prototype.unique = function <T>(toKey?: SelectFn<T>) {
return unique(this, toKey)
}
The unique function can then be used like this:
const u = fish.unique(f => f.name)
Some people prefer this fluent type of API. It also aligns better with the built-in array functions.
|
gharchive/issue
| 2023-08-31T09:34:40 |
2025-04-01T04:35:40.645560
|
{
"authors": [
"osdiab",
"stefaanMLB",
"stefaanv"
],
"repo": "rayepps/radash",
"url": "https://github.com/rayepps/radash/issues/345",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
939749989
|
shopackify init -r does not create layout folder
After
$ shopackify init -r
$ shopackify build
Error, no layout folder in ./shop/src
For further investigation, code seems to be in place.
Still happening even as of release v2.1.0 will need to take a further look.
Patched in v2.1.1 - layout directory wasn't being created in the createDevDir function.
|
gharchive/issue
| 2021-07-08T11:15:35 |
2025-04-01T04:35:40.660761
|
{
"authors": [
"azamanaza",
"raylway"
],
"repo": "raylway/mango",
"url": "https://github.com/raylway/mango/issues/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2290490484
|
[rcore] ToggleFullscreen() not working as expected with HighDPI mode enabled
when enabling the highDPI flag in raylib (SetConfigFlags(FLAG_WINDOW_HIGHDPI);) and using ToggleFullscreen(); the fullscreen Window is twice the size it should be and you only see the top left quarter of your software. Toggling again will half the window size each time you toggle fullscreen until the window is gone.
steps to repdroduce:
SetConfigFlags(FLAG_WINDOW_HIGHDPI); on a high dpi monitor
call ToggleFullscreen();
I am using Windows 11
@fishbowlforever Thanks for reporting, could you reproduce this issue on Windows 10? It sounds like platform dependant...
In any case, I'm afraid I don't have a HighDPI monitor at the moment for testing on my side...
@fishbowlforever Thanks for reporting, could you reproduce this issue on Windows 10? It sounds like platform dependant...
In any case, I'm afraid I don't have a HighDPI monitor at the moment for testing on my side...
set display scaling to 125% enough
I am experiencing the same issue as well. I made a simple raylib cs project to test all of the following things.
When in windowed mode the render size is 2x the screen size, which is correct for retina/high dpi screens. (dpi value shows up as 2, 2 as well)
Setting the high dpi config flag has no effect on my system. I have tested it without setting it and with setting it before & after InitWindow.
There are 3 types of fullscreen mode:
Fullscreen (normal Fullscreen Mode)
Borderless Fullscreen (behaves like maximize window on macOS)
MacOS Fullscreen (clicking green button top left corner)
MacOS Fullscreen works almost correctly.
DPI value is 1, 1 instead of 2, 2 but everything looks correctly. I don’t know if this is correct behavior because the macOS scaling factor for retina/ high dpi is always 2!
Screen size and render size are the same (dpi factor of 1, 1) but it renders over the entire screen
Borderless fullscreen behaves almost correctly as well.
Render Size is 2x of the screen size and values are correct for the monitor I am using (dpi factor is 2, 2)
Window is cut off at the top even though numbers are correct (looks more like a maximized window)
Fullscreen is were things get complicated.
To have fullscreen mode work at all the window size must be set to the current monitor size before enabling fullscreen.
DPI value is suddenly 1, 1 instead of 2, 2 like with the macOS fullscreen mode but it looks wrong too.
It seems to only render a quarter of the screen
The screen size value is off, it should be the monitor size
Screen size and render size should be the same with a dpi factor of 1, 1 but screen size value is off (point 4)
Windowed Mode for comparison
The good news is that all the fullscreen modes work & behave the same no matter what resolution I set in the macOS display settings
Similar issues with fullscreen:
Borderless fullscreen & fullscreen behave differently on macOS vs windows. (Borderless Fullscreen works flawless on windows and is my preferred fullscreen mode on windows, but it is more like maximize window on macOS; Fullscreen almost works on macOS because of the above issue, but on windows it takes a up to 1-2 seconds to apply with flickering and black screens in between)
Borderless fullscreen remembers the previous window state and applies it correctly when exiting borderless fullscreen but normal fullscreen does not.
If I multiply the monitor size by 2 before entering fullscreen another weird thing happens...
var monitor = GetCurrentMonitor();
SetWindowSize(GetMonitorWidth(monitor) * 2, GetMonitorHeight(monitor) * 2);
ToggleFullscreen();
The monitor size should be 1920x1080 before entering fullscreen (my target resolution on a 4k monitor). If I multiply this by 2 I should get the 4k resolution and if I then set the window size to the 4k resolution and enter fullscreen (were the dpi value is suddenly 1) I expect those value:
ScreenSize 4k
RenderSize 4k (because dpi is 1)
MonitorSize 4k (because dpi is 1)
Why is only width affect and height suddenly not? :)
Windows
I have tested fullscreen & high dpi functionality on windows 11 with a 4k monitor as well. I have set the scaling to 200% in settings. I have also tested everything with the scaling set to 100%. If something is not clear or I did something wrong or missed a step, please feel free to correct me.
Windowed
Screen Size: 800x800
Render Size: 800x800
Monitor Size: 3840x2160
DPI: 2,2
Maximized
Screen Size: 3840x2019
Render Size: 3840x2019
Monitor Size: 3840x2160
DPI: 2,2
Borderless Fullscreen
Screen Size: 3840x2160
Render Size: 3840x2160
Monitor Size: 3840x2160
DPI: 2,2
Fullscreen
Screen Size: 3840x2119 !!!
Render Size: 3840x2160
Monitor Size: 3840x2160
DPI: 2,2
I have tested everything with a 100% scaling on a 4k monitor as well. Everything works but it reported the exact same values as with a scaling of 200%.
My findings:
On Windows the dpi value is always correct. No matter the window mode it always reports the scaling set in the settings. On macOS it reports the correct value except in fullscreen mode were it always reports 1, 1.
On windows the monitor size always reports the native resolution of the monitor independent of the system scaling. On macOS it DOES NOT behave this way. Most of the times it is the monitor resolution divided by the scaling or it something weird in the fullscreen modes.
On windows & macOS the high dpi config flag had no impact on anything as far as I can tell. I have tested it without setting it, with setting it before & after init window, and with clearing it before & after init window. If I did something wrong or missed something please correct me.
On windows the screen & render size are always the same even if there is dpi scaling. On macOS the render size is always multiplied by the dpi value.
On windows the size of the window always covers the same area with the same size. Example: On a 4k monitor with scaling of 200% a window of the size 1920x1080 covered 1/4 of the screen. On a 4k monitor with scaling of 100% a window if the size 1920x1080 covered 1/4 of the screen as well. In my opinion that dpi scaling makes sense the a 1920x1080 window should cover the entire screen on a 4k monitor with scaling set to 200%.
Screen Size, Render Size, Monitor Size
The following things are what I understand about screen size, monitor size, and render size. I do not know if I am correct at all. My main goal here is to figure out together what each of this numbers should represent independent of the the operating system.
Monitor Size should always report the native resolution of the monitor unaffected by any scaling ?
The dpi value should always report the dpi scaling of the system irregardless of the window mode. (windowed & fullscreen should report the same dpi value)?
The screen size should be the actual size of the window ? Does this mean it should be in native resolution or in scaled resolution? Should a window covering 1/4 of a 4k monitor with a dpi scale of 2 have a Screen Size of 1920x1080 or 960x540?
Should the render size always be the screen size x dpi factor? Or should they be the same? (which kinda makes no sense)
To me personally only Example A makes sense. (on all operating systems. I do not know how scaling works on windows but on macOS it can only be 1, 1 or 2, 2. There are other combinations possible as well not just the ones from example A & B but I didn’t want to write them all down ;)
Example A
4k monitor
Scaling Factor 200%
Windowed Mode
Screen Size 960x540 (covers 1/4 of the screen)
Render Size 1920x1080
Monitor Size 3840x2160
DPI 2, 2
Fullscreen Mode
Screen Size 1920x1080 (covers entire screen because it is fullscreen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
Scaling Factor 100%
Windowed Mode
Screen Size 1920x1080 (covers 1/4 of the screen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
Fullscreen Mode
Screen Size 3840x2160 (covers entire screen because it is fullscreen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
Example B
4k monitor
Scaling Factor 200%
Windowed Mode
Screen Size 1920x1080 (covers 1/4 of the screen)
Render Size 1920x1080
Monitor Size 3840x2160
DPI 2, 2
Fullscreen Mode
Screen Size 3840x2160 (covers entire screen because it is fullscreen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
Scaling Factor 100%
Windowed Mode
Screen Size 1920x1080 (covers 1/4 of the screen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
Fullscreen Mode
Screen Size 3840x2160 (covers entire screen because it is fullscreen)
Render Size 3840x2160
Monitor Size 3840x2160
DPI 2, 2
@raysan5 If you need anything else just tell me. As mentioned above I can also put all my comments in a seperate issue. If needed I can also put a zip file here with the minimal project I used to test this (all raylib cs btw).
@SoloByte : could you share a code example ?
@SuperUserNameMan Here you go :) I am very interested in your results :D
Minimal Reproduction Example
I used raylib cs 6.1.1 (should be easy to rewrite for c raylib)
tested it both on windows & macOS
minimal-reproduction-raylib-fullscreen.txt
using System.Numerics;
using Raylib_cs;
using static Raylib_cs.Raylib;
using Color = Raylib_cs.Color;
namespace FullscreenTest;
public static class Program
{
public static void Main(string[] args)
{
var bgColor = Raylib.ColorBrightness(Raylib_cs.Color.DarkBlue, -0.5f);
var test = new Test(800, 800, "Test", bgColor, 60);
test.Run();
}
}
public class FullscreenTest
{
private Font fontDefault;
public Color BackgroundColor;
public float DeltaTime { get; private set; } = 0f;
public Vector2 GetScreenSize() => new Vector2(GetScreenWidth(), GetScreenHeight());
public Vector2 GetRenderSize() => new Vector2(GetRenderWidth(), GetRenderHeight());
public Vector2 GetDPI() => GetWindowScaleDPI();
public Vector2 GetMonitorSize()
{
var monitor = GetCurrentMonitor();
return new Vector2(GetMonitorWidth(monitor), GetMonitorHeight(monitor));
}
private int prevFullscreenWidth = 0;
private int prevFullscreenHeight = 0;
private int prevFullscreenX = 0;
private int prevFullscreenY = 0;
public Test(int width, int height, string title, Color backgroundColor, int targetFramerate = 60)
{
Raylib.SetWindowState(ConfigFlags.Msaa4xHint);
Raylib.InitWindow(width, height, title);
Raylib.InitAudioDevice();
Raylib.ClearWindowState(ConfigFlags.VSyncHint);
Raylib.SetTargetFPS(targetFramerate);
Raylib.SetWindowState(ConfigFlags.ResizableWindow);
fontDefault = Raylib.GetFontDefault();
BackgroundColor = backgroundColor;
}
public void Run()
{
StartApplication();
//Main loop
while (!Raylib.WindowShouldClose())
{
//Update
var dt = Raylib.GetFrameTime();
DeltaTime = dt;
Update(dt);
//Drawing
Raylib.BeginDrawing();
Raylib.ClearBackground(BackgroundColor);
Draw();
Raylib.EndDrawing();
}
//End
CloseApplication();
Raylib.CloseAudioDevice();
Raylib.CloseWindow();
}
protected virtual void Update(float dt)
{
//I am not checking if fullscreen is already active when pressing borderless fullscreen and vice versa.
//Fullscreen
if (IsKeyPressed(KeyboardKey.F))
{
if (IsWindowFullscreen())
{
ToggleFullscreen();
SetWindowSize(prevFullscreenWidth, prevFullscreenHeight);
SetWindowPosition(prevFullscreenX, prevFullscreenY);
}
else
{
prevFullscreenWidth = GetScreenWidth();
prevFullscreenHeight = GetScreenHeight();
prevFullscreenX = (int)GetWindowPosition().X;
prevFullscreenY = (int)GetWindowPosition().Y;
var monitor = GetCurrentMonitor();
SetWindowSize(GetMonitorWidth(monitor), GetMonitorHeight(monitor));
ToggleFullscreen();
}
}
//Borderless Fullscreen
else if (IsKeyPressed(KeyboardKey.B))
{
ToggleBorderlessWindowed();
}
}
protected virtual void Draw()
{
var size = GetScreenSize();
var infoRect = new Rectangle(new(), size);
//draw the border of the screen
DrawRectangleLinesEx(infoRect, 4f, Color.Gray);
//draw the text in the center
DrawScreenInformation(infoRect, 50, Color.Lime);
}
protected virtual void StartApplication() { }
protected virtual void CloseApplication() { }
private void DrawScreenInformation(Rectangle rect, int fontSize, Color color)
{
var sw = GetScreenWidth();
var sh = GetScreenHeight();
var rw = GetRenderWidth();
var rh = GetRenderHeight();
var dpi = GetWindowScaleDPI();
var monitor = GetCurrentMonitor();
var mw = GetMonitorWidth(monitor);
var mh = GetMonitorHeight(monitor);
var text1 = $"Screen {sw}x{sh} | Render {rw}x{rh}";
var text2 = $"Monitor {mw}x{mh} | DPI {dpi}";
var textSize1 = MeasureTextEx(fontDefault, text1, fontSize, 1f);
var textSize2 = MeasureTextEx(fontDefault, text2, fontSize, 1f);
var width = rect.Size.X * 0.75f;
if (textSize1.X > textSize2.X)
{
if (textSize1.X > width)
{
var f = width / textSize1.X;
fontSize = (int)(fontSize * f);
textSize1 = MeasureTextEx(fontDefault, text1, fontSize, 1f);
textSize2 = MeasureTextEx(fontDefault, text2, fontSize, 1f);
}
}
else
{
if (textSize2.X > width)
{
var f = width / textSize2.X;
fontSize = (int)(fontSize * f);
textSize1 = MeasureTextEx(fontDefault, text1, fontSize, 1f);
textSize2 = MeasureTextEx(fontDefault, text2, fontSize, 1f);
}
}
var rectCenter = rect.Position + (rect.Size / 2);
var textPos1 = rectCenter - (textSize1 / 2);
var textPos2 = rectCenter - (textSize2 / 2);
DrawText(text1, (int)textPos1.X, (int)textPos1.Y, fontSize, color);
DrawText(text2, (int)textPos2.X, (int)(textPos2.Y + textSize1.Y), fontSize, color);
}
}
OMG ! Yuck ! C# ! I feel like someone barfed into my eyes X-(
I hope this is what you meant :
#include "raylib.h"
void update();
void draw();
int main( int argc , char **argv )
{
SetWindowState( FLAG_MSAA_4X_HINT );
InitWindow( 800 , 800 , "Test" );
ClearWindowState( FLAG_VSYNC_HINT );
SetTargetFPS( 60 );
SetWindowState( FLAG_WINDOW_RESIZABLE );
while( ! WindowShouldClose() )
{
update();
BeginDrawing();
{
ClearBackground( RAYWHITE );
draw();
}
EndDrawing();
}
CloseWindow();
}
void update()
{
// He said he does not check if fullscreen is already active
// when pressing borderless fullscreen and vice versa.
static int prevFullscreenWidth = 0;
static int prevFullscreenHeight = 0;
static int prevFullscreenX = 0;
static int prevFullscreenY = 0;
// Fullscreen :
if ( IsKeyPressed( KEY_F ) )
{
if ( IsWindowFullscreen() )
{
ToggleFullscreen();
SetWindowSize( prevFullscreenWidth , prevFullscreenHeight );
SetWindowPosition( prevFullscreenX , prevFullscreenY );
}
else
{
prevFullscreenWidth = GetScreenWidth();
prevFullscreenHeight = GetScreenHeight();
prevFullscreenX = (int)GetWindowPosition().x;
prevFullscreenY = (int)GetWindowPosition().y;
int monitor = GetCurrentMonitor();
SetWindowSize( GetMonitorWidth(monitor) , GetMonitorHeight(monitor) );
ToggleFullscreen();
}
}
else // Borderless Fullscreen :
if ( IsKeyPressed( KEY_B ) )
{
ToggleBorderlessWindowed();
}
}
void draw()
{
int sw = GetScreenWidth();
int sh = GetScreenHeight();
int rw = GetRenderWidth();
int rh = GetRenderHeight();
Vector2 dpi = GetWindowScaleDPI();
int monitor = GetCurrentMonitor();
int mw = GetMonitorWidth( monitor );
int mh = GetMonitorHeight( monitor );
Rectangle infoRect = { 0.0 , 0.0 , sw , sh };
// Draw the border of the screen :
DrawRectangleLinesEx( infoRect , 4.0f , RED );
// Draw the text NOT in the center :
DrawText( TextFormat( "Screen : %d x %d" , sw , sh ) , 10 , 10 , 30 , BROWN );
DrawText( TextFormat( "Render : %d x %d" , rw , rh ) , 10 , 40 , 30 , DARKGREEN );
DrawText( TextFormat( "Monitor : %d x %d" , mw , mh ) , 10 , 70 , 30 , DARKBLUE );
DrawText( TextFormat( "DPI : %f x %f" , dpi.x , dpi.y ) , 10 , 100 , 30 , BLACK );
}
I confirm there is ALSO multiple issues on Linux.
When SetConfigFlags( FLAG_WINDOW_HIGHDPI ) is enabled :
GetWindowScaleDPI() returns { 1.145833 , 1.145833 } despite my display scale is set to 100%.
when toggling fullscreen, GetRenderWidth() and GetRenderHeight() still return 1920x1080, despite the render surface extends beyond the screen with an actual dimension of 2268 x 1237.
Edit : ok, i'm currently proceeeding to various test on a mode simplified example, because there seems to be many other issues related to both ToggleFullscreen() and FLAG_WINDOW_HIGHDPI also on Linux. (using GLFW backend)
Ok so if I replicated @fishbowlforever issue correctly, and if @fishbowlforever uses the GLFW backend, i think the culprit is here :
https://github.com/raysan5/raylib/blob/9764fef26260e6fcf671ddffb230360cc1efa1f8/src/platforms/rcore_desktop_glfw.c#L1670-L1682
I think that it is not required to divide by windowScaleDPI because GLFW already handles that with glfwWindowHint(GLFW_SCALE_TO_MONITOR, GLFW_TRUE); set here :
https://github.com/raysan5/raylib/blob/9764fef26260e6fcf671ddffb230360cc1efa1f8/src/platforms/rcore_desktop_glfw.c#L1300-L1310
@fishbowlforever , can you recompile Raylib to test this fix on your Windows OS ?
In file raylib/src/platforms/rcore_desktop_glfw.c, you just have to replace line 1671 with a if (0) to disable the suspect branch.
// if ((CORE.Window.flags & FLAG_WINDOW_HIGHDPI) > 0)
if (0)
{
Vector2 windowScaleDPI = GetWindowScaleDPI();
CORE.Window.screen.width = (unsigned int)(width/windowScaleDPI.x);
CORE.Window.screen.height = (unsigned int)(height/windowScaleDPI.y);
}
else
{
CORE.Window.screen.width = width;
CORE.Window.screen.height = height;
}
@SuperUserNameMan thanks a lot for your suggestion and research
I compiled RL with your suggestion like this:
Fullscreen works like a charm now!
The only issue left is that, when disabling Fullscreen, the window only displays the top left quarter of the screen. This does not increment to 4x, 8x, 16x, etc. like it previously did though.
@fishbowlforever : Did you use the code example i provided ?
If not, could you please share a minimal code example of your own so i can see if there is something special that triggers this behavior ?
@SuperUserNameMan can confirm that disabling resizable flag before entering fullscreen helps & can´t test it on macOS because I am not set up for raylib development.
@raysan5 should I open new issues for the other problems I have found mention above?
@SoloByte : It change nothing for Macos. There should be no diff.
@SoloByte @SuperUserNameMan Thank you very much for the extensive review of this issue, full-screen and high-dpi are big concerns on raylib that despite being reviewed many many times, still have issues, mostly platform and OS dependant...
@raysan5 should I open new issues for the other problems I have found mention above?
@SoloByte Yes, please, I think it would be easier to track the issues separately (despite being highly dependant). If you want I can also reopen this issue for reference.
@SuperUserNameMan @fishbowlforever
I am currently investigating the fullscreen & borderless fullscreen issues. What I have found is that fullscreen mode sets the window size to the current screen size before entering fullscreen instead of setting it to the monitor size. (Borderless fullscreen sets the window size to the monitor size) Setting the window size calls the window resized callback and before fix #4143 it would then scale the current window size further down each time fullscreen is exited.
I think this loop may also causes the issue that is still there with the 1/4 of the screen in the topleft.
@raysan5 I will open a new issue for fullscreen / borderless fullscreen mode & 1 issue for the screen/render/monitor size confusion with the dpi scale ?
@SoloByte : if i deciphered your C# code example, it seems that you have enabled ResizableWindow.
On my Linux tests, i found that enabling resizable window at the same time as using ToggleFullscreen() create some unexpected behaviors.
Could you try disabling ResizableWindow before any call to ToggleFullscreen() and tell me if it improves things ?
Adding @JeffM2501 to the loop, I remember he had some ideas about ToggleFullscreen()/ToggleFullscreenBorderless().
@SoloByte I'm reopening to continue the dsicussion but feel free to open separate issues for related problems.
@SoloByte :
@SuperUserNameMan can confirm that disabling resizable flag before entering fullscreen helps & can´t test it on macOS because I am not set up for raylib development.
I've just noticed i misinterpreted your answer.
Yes, disabling resizable flag before toggling to fullscreen should help too, and might have an effect on Macos too.
However, did you recompile Raylib with the new patch #4143 that was merged a few minutes ago ?
@SuperUserNameMan I have not tested it with the new patch
@SuperUserNameMan I have not tested it with the new patch
ok then, let's start again from a fresh code base then.
@SuperUserNameMan @fishbowlforever
The window resize callback also calls SetupViewport which introdues dpi scale again. I don‘t know if that causes any problems though.
What I have found is that fullscreen mode sets the window size to the current screen size before entering fullscreen instead of setting it to the monitor size. (Borderless fullscreen sets the window size to the monitor size)
Setting the window size calls the window resized callback and before fix #4143 it would then scale the current window size further down each time fullscreen is exited.
@SuperUserNameMan I have not tested it with the new patch
ok then, let's start again from a fresh code base then.
I agree but just for clarification, I have tested it on macOS with the same project as above. The patch you did should not have affected macOS anyway, correct?
i don't know how far you are with everything and so on but i tested your provided code on win11 to the same results in case thats still useful:
Fullscreen (F) works fantastically, but when disabling fullscreen for the first time, same issue happens as with my code.
Do you still use FLAG_WINDOW_HIGHDPI at the same time as ToggleFullscreen() ?
If yes, they are currently incompatible.
You have to choose one or another, or replace ToggleFullscreen() with ToggleBorderlessWindowed().
Could you please test this PR #4151 ?
|
gharchive/issue
| 2024-05-10T22:35:55 |
2025-04-01T04:35:40.710053
|
{
"authors": [
"M1NGS",
"SoloByte",
"SuperUserNameMan",
"fishbowlforever",
"raysan5"
],
"repo": "raysan5/raylib",
"url": "https://github.com/raysan5/raylib/issues/3972",
"license": "Zlib",
"license_type": "permissive",
"license_source": "github-api"
}
|
808038805
|
Fixed problem related to IsKeyPressed function!
There was problem with using IsKeyPressed, In example code it uses char while IsKeyPressed takes an int.
However, This fixed!
@Rabios thanks!
|
gharchive/pull-request
| 2021-02-14T20:19:44 |
2025-04-01T04:35:40.713323
|
{
"authors": [
"Rabios",
"raysan5"
],
"repo": "raysan5/raylib",
"url": "https://github.com/raysan5/raylib/pull/1589",
"license": "Zlib",
"license_type": "permissive",
"license_source": "github-api"
}
|
1124080340
|
Added subscription count metrics
Added following metrics
Total count of subscriptions
Total subscriptions with filtering enabled
Total subscriptions with ordering enabled
Codecov Report
Merging #304 (7f145bd) into master (7898fdd) will decrease coverage by 2.13%.
The diff coverage is 18.75%.
@@ Coverage Diff @@
## master #304 +/- ##
==========================================
- Coverage 43.69% 41.56% -2.14%
==========================================
Files 120 120
Lines 6188 6203 +15
==========================================
- Hits 2704 2578 -126
- Misses 3282 3440 +158
+ Partials 202 185 -17
Flag
Coverage Δ
integration
?
unittests
41.56% <18.75%> (-0.06%)
:arrow_down:
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files
Coverage Δ
internal/subscription/core.go
13.43% <0.00%> (-0.56%)
:arrow_down:
internal/subscription/model.go
90.16% <0.00%> (-6.33%)
:arrow_down:
internal/subscription/metrics.go
100.00% <100.00%> (ø)
pkg/messagebroker/factory.go
33.33% <0.00%> (-33.34%)
:arrow_down:
pkg/messagebroker/kafka.go
10.48% <0.00%> (-30.00%)
:arrow_down:
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7898fdd...7f145bd. Read the comment docs.
|
gharchive/pull-request
| 2022-02-04T11:09:01 |
2025-04-01T04:35:40.726868
|
{
"authors": [
"codecov-commenter",
"rutul25"
],
"repo": "razorpay/metro",
"url": "https://github.com/razorpay/metro/pull/304",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2229454529
|
Remove spaces from computer name
Windows disallows spaces in computer names. This change should remove the space.
Thanks for this. Can you submit the PR against the 2404.1 branch? I'll merge it to main later this month. https://github.com/rbalsleyMSFT/FFU/tree/15-24041
Sorry, I didn't see your message. I will do this now.
|
gharchive/pull-request
| 2024-04-06T23:06:03 |
2025-04-01T04:35:40.748823
|
{
"authors": [
"JoeMama54",
"rbalsleyMSFT"
],
"repo": "rbalsleyMSFT/FFU",
"url": "https://github.com/rbalsleyMSFT/FFU/pull/19",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
273150332
|
Closing terminal does not unset version
Hey
Need to confirm if I close the terminal and later start a new session, does rbenv revert back to the globally set ruby version?
Recently I forget to unset the local version for a test run. I had closed my comp. But when I came back to my terminal and checked for some reason, it still showed the local version which I had set, that too in all terminal windows?
I had to unset from a specific folder (viewed from rbenv version) for it to get back to my global setting.
Is this the default behaviour? Should it not just like that revert to the global setting if a session is closed?
Globally it was set to use 2.3.3 and locally for a session as 2.2.3.
A "local" version setting (set by e.g. rbenv local 2.2.3) is not local to your terminal session, but to the current directory (usually the project root directory) by writing to a .ruby-version file in the current directory. That's why the value is persisted between terminal resets.
To set the version that only persists in the current shell session until you close it, see rbenv shell --help.
|
gharchive/issue
| 2017-11-11T14:47:33 |
2025-04-01T04:35:40.793858
|
{
"authors": [
"arjunmenon",
"mislav"
],
"repo": "rbenv/rbenv",
"url": "https://github.com/rbenv/rbenv/issues/1047",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1124762473
|
Norwegian translation
yep
chat_norwegian.txt
awesome, thank you!
|
gharchive/pull-request
| 2022-02-05T01:18:44 |
2025-04-01T04:35:40.801280
|
{
"authors": [
"TheWisehobgoblin",
"rbjaxter"
],
"repo": "rbjaxter/budhud",
"url": "https://github.com/rbjaxter/budhud/pull/417",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1023323636
|
fix: allow for lazy loading telescope with notify
Some users may only load telescope when require("telescope") is first executed (using packer's module key), so avoid doing this in notify setup otherwise loading notify will also load telescope.
Also recommend :Telescope notify notify rather than :Telescope notify since the former will work even if telescope is loaded after notify and require("telescope").load_extension("notify") hasn't been run.
Edit: Forgot to mention that g:loaded_telescope is defined here
https://github.com/nvim-telescope/telescope.nvim/blob/3f45d64e9c47ad9eef273ddab65790a84cced30b/plugin/telescope.vim#L6-L9
Perfect! Thanks again :grin:
|
gharchive/pull-request
| 2021-10-12T03:39:54 |
2025-04-01T04:35:40.810929
|
{
"authors": [
"brphilly",
"rcarriga"
],
"repo": "rcarriga/nvim-notify",
"url": "https://github.com/rcarriga/nvim-notify/pull/25",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
161944097
|
Add bashate linting
This commit adds the linting-bashate.sh script which is used to do
syntax checks on our scripts. Some important pieces of code are
scripts and previously our linting only checked YAML and Python
files. Upstream Openstack-Ansible also already includes bashate.
The linting-bashate.sh script itself searches recursively through
our files and runs bashate on files that have a (ba)sh shebang at
the top of the file. The script ignores the same bashate errors as
upstream OSA. The tox.ini was modified in order to add the
bashate script to the list of tests run. The .travis.yml file was
modified in order to add the bashate tox enviroment.
Addresses #454
This wont pass until https://github.com/rcbops/rpc-openstack/pull/1190 is merged.
👍
RPC-AIO-Liberty-PR: Pass
RPC-AIO-Ceph-Liberty-PR: Pass
RPC-AIO-Ceph-Liberty-PR: Pass
RPC-AIO-Liberty-PR: Pass
RPC-AIO-Ceph-Liberty-PR: Pass
RPC-AIO-Liberty-PR: Pass
recheck
RPC-AIO-Ceph-Liberty-PR: Pass
RPC-AIO-Liberty-PR: Pass
RPC-AIO-Ceph-Liberty-PR: Fail
RPC-AIO-Liberty-PR: Fail
recheck_all
RPC-AIO-Liberty-PR: Pass
RPC-AIO-Liberty-PR: Fail
RPC-AIO-Ceph-Liberty-PR: Pass
RPC-AIO-Liberty-PR: Pass
RPC-AIO-Ceph-Liberty-PR: Fail
RPC-AIO-Ceph-Liberty-PR: Fail
RPC-AIO-Liberty-PR: Fail
RPC-AIO-Ceph-Liberty-PR: Pass
|
gharchive/pull-request
| 2016-06-23T14:57:13 |
2025-04-01T04:35:40.822671
|
{
"authors": [
"Apsu",
"Frank-ZhangXin",
"ameserole",
"major"
],
"repo": "rcbops/rpc-openstack",
"url": "https://github.com/rcbops/rpc-openstack/pull/1189",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
164571268
|
Update guidelines for issue triage and workflow
This change updates the contributing guidelines to define the workflow
by which issues are managed. This includes detailing the steps that take
an issue from the backlog to being done as well as providing a more
complete picture of the process for triaging issues.
Outcome of team meeting was agreement to merge this pull request.
|
gharchive/pull-request
| 2016-07-08T16:48:40 |
2025-04-01T04:35:40.823992
|
{
"authors": [
"git-harry"
],
"repo": "rcbops/rpc-openstack",
"url": "https://github.com/rcbops/rpc-openstack/pull/1229",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
546541522
|
Add init command
This adds a new init command that initializes an empty CHANGELOG.md file.
Fixes #35.
Pull Request Test Coverage Report for Build 233
42 of 42 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+2.6%) to 74.674%
Totals
Change from base Build 229:
2.6%
Covered Lines:
401
Relevant Lines:
537
💛 - Coveralls
|
gharchive/pull-request
| 2020-01-07T22:27:30 |
2025-04-01T04:35:40.945923
|
{
"authors": [
"coveralls",
"rcmachado"
],
"repo": "rcmachado/changelog",
"url": "https://github.com/rcmachado/changelog/pull/48",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2292529640
|
Search for and implement an RDF literal datatype for user names
Adding a datatype for usernames with certain restrictions would be helpful. Restrictions that would make sense for the lexical form would be [a-z_][a-z0-9_\-]{0,29}[a-z0-9_] (max 31 chars to leave space for null-terminator in C systems with max 32 chars)
If such an datatype already exists, the specs of the existing datatype should be implemented. Otherwise, a new datatype should be implemented.
This is not supposed to be implemented via regex. I just provided one for reference
|
gharchive/issue
| 2024-05-13T11:20:58 |
2025-04-01T04:35:40.978250
|
{
"authors": [
"Clueliss"
],
"repo": "rdf4cpp/rdf4cpp",
"url": "https://github.com/rdf4cpp/rdf4cpp/issues/272",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1612352925
|
fix: update deployment order and add README
Description
Issue 1:
During the release process semantic-release needs run in this order to make sure the correct dependency versions are used. This process will need to be audited at a later date in favor of deferred versioning however, for now this should fix the issue.
Proposed solution:
Update action to call semantic release in the correct order instead of the default order of yarn workspace foreach
@lightningjs/ui-components-theme-base
@lightningjs/ui-components
@lightningjs/ui-components-test-utils
Issue 2:
Current package releases do not have a README when they are being viewed at NPM https://www.npmjs.com/package/@lightningjs/ui-components
Proposed solution:
Add README files
@lightningjs/ui-components-test-utils
@lightningjs/ui-components-theme-base
@lightningjs/ui-components (copy from project directory during release ci steps)
During the release action the README will be copied to ./packages/@lightningjs/ui-components to avoid duplication.
Testing
Run semantic release steps listed on line 36 of release.yml in dry run mode to ensure the proper versions are set for each package. As a more accurate test you may also update the patch for semantic-release-npm (locally only) and update line 43 with the pack command. This should allow you to inspect the contents of the final release from the tarball that is created for each package.
Checklist
[x] all commented code has been removed
[x] any new console issues have been resolved
[x] code linter and formatter has been run
[x] test coverage meets repo requirements
[x] PR name matches the expected semantic-commit syntax
:tada: This PR is included in version @lightningjs/ui-components-theme-base-v1.0.1 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
|
gharchive/pull-request
| 2023-03-06T22:51:20 |
2025-04-01T04:35:41.000518
|
{
"authors": [
"erautenberg",
"joshhowenstine"
],
"repo": "rdkcentral/Lightning-UI-Components",
"url": "https://github.com/rdkcentral/Lightning-UI-Components/pull/128",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2161656465
|
Fixes issue/527
Version 2.12.1 not including typescript types
Switched extension search in scripts/src-to-dist.cjs to use ".ts" and ".mts" so the types get added to the build.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
|
gharchive/pull-request
| 2024-02-29T16:34:01 |
2025-04-01T04:35:41.003041
|
{
"authors": [
"CLAassistant",
"adiffmike"
],
"repo": "rdkcentral/Lightning",
"url": "https://github.com/rdkcentral/Lightning/pull/528",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
2603110323
|
readUntil method has no timeout argument in console classes
Description:
Problem: Only the sshConsole type has a timeout argument in the console classes. Other console types will not accept the additional argument and will error out.
Steps to Reproduce: Pass a timeout argument to the console class when the rackConfig is not starting an ssh console.
Expected Behavior: All console classes should accept the timeout argument and process them as a timeout, exiting the method after the time has passed, rather than erroring out when the argument is passed to it.
has this started?
|
gharchive/issue
| 2024-10-21T16:39:58 |
2025-04-01T04:35:41.004882
|
{
"authors": [
"TB-1993",
"Ulrond"
],
"repo": "rdkcentral/python_raft",
"url": "https://github.com/rdkcentral/python_raft/issues/109",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
1192099899
|
RDKTV-14660: Remove ARC/eARC HPD signal dependency for audio routing
Reason for change:1) Added support for Audio Device Power
status API in Hdmicecsink & Displaysettings
2) Audio Device power status should be checked by TV once
any audio device connection is detected
3) Audio Routing to rely completely on ARC Initiation &
System audio mode events
4) Remove HPD ON handling from dsHdmiEventHandler and retain
HPD OFF handling
5) Initiate cec device ping immediately on HDMI ARC/eARC
Hotplug
Test Procedure: Refer Ticket
Risks: Medium
Signed-off-by: Deekshit Devadas deekshit.devadasy@sky.uk
@ddevad - Pls also update documentation in the json files.
|
gharchive/pull-request
| 2022-04-04T17:33:13 |
2025-04-01T04:35:41.007608
|
{
"authors": [
"anand-ky",
"ddevad"
],
"repo": "rdkcentral/rdkservices",
"url": "https://github.com/rdkcentral/rdkservices/pull/2427",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
475726779
|
Chem.rdFMCS.FindMCS hangs for certain ligand pairs
RDKit version: 2019.03.2
Platform: Python 3.7, Linux
We've been using RDKit to generate MCS mappings within BioSimSpace with great success. However, for certain ligand pairs the Chem.rdFMCS.FindMCS algorithm appears to hang indefinitely, completely ignoring the timeout. I can't even kill it with CTRL+C, having to manually terminate the process.
The following example illustrates the problem, using ligand1 and ligand2 as input. (These are Cathepsin PDB files from the D3R2018 challenge, where the extension has been changed to txt to allow upload.)
import rdkit.Chem as Chem
import rdkit.Chem.rdFMCS as rdFMCS
# Load the ligands.
mols = [Chem.MolFromPDBFile("ligand1.txt", False, False, 0),
Chem.MolFromPDBFile("ligand2.txt", False, False, 0)]
# Run a very short MCS. (One second)
mcs = rdFMCS.FindMCS(mols, atomCompare=rdFMCS.AtomCompare.CompareAny,
bondCompare=rdFMCS.BondCompare.CompareAny, completeRingsOnly=True,
ringMatchesRingOnly=True, matchChiralTag=False, matchValences=False,
maximizeBonds=False, timeout=1, verbose=True)
This returns the following before hanging. (There is no change in memory during the hang and my iPython session is using only 140 MiB.)
Query [H]C1C([H])C(C(SC([H])([H])C([H])([H])[N+]2([H])C([H])([H])C([H])([H])C([H])(C(F)(F)F)C([H])([H])C2([H])[H])C([H])C1C1NN(C2C1C([H])([H])N(C([H])([H])C2([H])[H])S(O)(O)C([H])([H])[H])C([H])([H])C([H])([H])C([H])([H])[N+]1([H])C([H])([H])C([H])([H])C([H])(N2C(O)C([H])([H])C([H])([H])C2([H])[H])C([H])([H])C1([H])[H])C(F)(F)F 99(99) atoms, 104(104) bonds
1 Seeds:105 MCS 5 atoms, 4 bonds for 0.0016 seconds. bond[0]=0
2 Seeds:106 MCS 10 atoms, 10 bonds for 0.0016 seconds. bond[0]=0
3 Seeds:107 MCS 21 atoms, 21 bonds for 0.0017 seconds. bond[0]=0
4 Seeds:108 MCS 31 atoms, 33 bonds for 0.0018 seconds. bond[0]=0
5 Seeds:109 MCS 41 atoms, 43 bonds for 0.0018 seconds. bond[0]=0
6 Seeds:110 MCS 53 atoms, 55 bonds for 0.0019 seconds. bond[0]=0
7 Seeds:111 MCS 62 atoms, 64 bonds for 0.0020 seconds. bond[0]=0
8 Seeds:112 MCS 70 atoms, 73 bonds for 0.0021 seconds. bond[0]=0
9 Seeds:113 MCS 78 atoms, 81 bonds for 0.0023 seconds. bond[0]=0
10 Seeds:114 MCS 85 atoms, 89 bonds for 0.0024 seconds. bond[0]=0
11 Seeds:115 MCS 92 atoms, 96 bonds for 0.0025 seconds. bond[0]=0
A 92 atom match for this system seems perfectly reasonable to me: ligand1 contains 99 atoms, and ligand2 has 102.
Here's the BioSimSpace issue where this is referenced.
Possibly related to this issue. In our own internal MCS code we would also experience cases where the search space was large. However, this doesn't explain why the timeout option is clearly ignored.
Looking at this part of MaximumCommonSubgraph.cpp:
// Find MCS -- SDF Seed growing OPTIMISATION (it works in 3 times faster)
while (!Seeds.empty()) {
if (getMaxNumberBonds() == QueryMoleculeMatchedBonds) // MCS == Query
break;
++steps;
#ifdef VERBOSE_STATISTICS_ON
VerboseStatistics.TotalSteps++;
#endif
auto si = Seeds.begin();
si->grow(*this);
{
const Seed& fs = Seeds.front();
// bigger substructure found
if (fs.CopyComplete) {
bool possibleMCS = false;
if ((!Parameters.MaximizeBonds &&
(fs.getNumAtoms() > getMaxNumberAtoms() ||
(fs.getNumAtoms() == getMaxNumberAtoms() &&
fs.getNumBonds() > getMaxNumberBonds())))) {
possibleMCS = true;
} else if (Parameters.MaximizeBonds &&
(fs.getNumBonds() > getMaxNumberBonds() ||
(fs.getNumBonds() == getMaxNumberBonds() &&
fs.getNumAtoms() > getMaxNumberAtoms()))) {
possibleMCS = true;
}
// #945: test here to see if the MCS actually has all rings closed
if (possibleMCS && Parameters.BondCompareParameters.CompleteRingsOnly) {
possibleMCS = checkIfRingsAreClosed(fs);
}
if (possibleMCS) {
mcsFound = true;
#ifdef VERBOSE_STATISTICS_ON
VerboseStatistics.MCSFoundStep = VerboseStatistics.TotalSteps;
VerboseStatistics.MCSFoundTime = nanoClock();
#endif
McsIdx.Atoms = fs.MoleculeFragment.Atoms;
McsIdx.Bonds = fs.MoleculeFragment.Bonds;
McsIdx.AtomsIdx = fs.MoleculeFragment.AtomsIdx;
McsIdx.BondsIdx = fs.MoleculeFragment.BondsIdx;
if (Parameters.Verbose) {
std::cout << VerboseStatistics.TotalSteps
<< " Seeds:" << Seeds.size() << " MCS "
<< McsIdx.Atoms.size() << " atoms, "
<< McsIdx.Bonds.size() << " bonds";
printf(" for %.4lf seconds. bond[0]=%u\n",
double(VerboseStatistics.MCSFoundTime - To) / 1000000.,
McsIdx.BondsIdx[0]);
}
}
}
}
if (NotSet == si->GrowingStage) // finished
Seeds.erase(si);
if (Parameters.ProgressCallback && (steps >= 377)) {
steps = 0;
Stat.NumAtoms = getMaxNumberAtoms();
Stat.NumBonds = getMaxNumberBonds();
if (!Parameters.ProgressCallback(Stat, Parameters,
Parameters.ProgressCallbackUserData)) {
canceled = true;
break;
}
}
}
It looks like either:
It has got stuch in the seed growing stage:
The timeout is never triggered because it hasn't reached the hard-coded lower limit of 377 steps.
Comparing with our internal MCS code, 92 atoms seems like a perfectly fine mapping for this ligand pair so it would be desirable to be able to trigger the timeout at an earlier stage.
Having built RDKit myself the issue is indeed the uncommented 377 lower bound on the number of steps. Is there any reason for this number? (Without any context it seems completely arbitrary.) If not, then I'll remove it and issue a pull request.
Thanks for identifying that and proposing a fix.
The origin of the steps >= 377 test can be safely considered as 'lost in antiquity'. I don't see any reason for it to be there and would be happy to merge a PR that removes it (assuming that it doesn't break any of the existing tests in an unexpected way)!
Thanks, @greglandrum. I assumed it was a long forgotten fix or debugging addition. (I was scratching my head trying to figure out why 377 was a magic number.)
Once the pull request is merged, do you have a rough idea for how long it'll be before it appears in an updated Conda package? For now I can generate manual mappings for the problem ligands using my own local RDKit fork, then share them with our users.
Given that this is a bug, it will show up in the next patch release after the PR is merged. I'm planning on doing the 2019.03.4 release next week.
|
gharchive/issue
| 2019-08-01T14:48:01 |
2025-04-01T04:35:41.022476
|
{
"authors": [
"greglandrum",
"lohedges"
],
"repo": "rdkit/rdkit",
"url": "https://github.com/rdkit/rdkit/issues/2581",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
200883555
|
Refactoring rdkit.Chem.UnitTestArom
This file was not executing correctly on Python3 due to the use of xreadline. This was not detected as the file is not included in test_list.py.
Fixed Python3 failure
Removed code duplication by moving the comparison into a separate method.
Fixed incorrect comment
Removed unused imports
Use namedtuple to pass test data
I think this isn't actually a particularly useful test, which is likely why it wasn't added to test_list.py. This is old enough that I don't even really remember why it actually exists... it may go back to the earliest days of when were developing the RDKit chemistry bits.
I think it probably makes sense to go ahead and remove the file entirely.
Unless you have an objection, I'll go ahead and close this PR without merging it and then just remove the file.
No problem with closing the PR and removing the file.
|
gharchive/pull-request
| 2017-01-15T18:00:13 |
2025-04-01T04:35:41.026177
|
{
"authors": [
"gedeck",
"greglandrum"
],
"repo": "rdkit/rdkit",
"url": "https://github.com/rdkit/rdkit/pull/1264",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
197733888
|
Rename Default theme to dark theme
It would be better to choose between dark and bright theme, not default and bright.
If wanted, I can make a PR
If the dark theme is the default (I am not sure about that, I think my phone runs the bright one even though I don't remember changing it) it still would be nice to indicate which one is the default.
In that case "dark theme (default)" might be better wording, just so people know how to get back to defaults.
Otherwise the only thing against it is that a lot of translations might not be updated for a long time, if ever.
But I guess that's kind of a silly argument, so I'll merge a PR if you create one.
If the dark theme is the default (I am not sure about that, I think my phone runs the bright one even though I don't remember changing it) it still would be nice to indicate which one is the default.
In that case "dark theme (default)" might be better wording, just so people know how to get back to defaults.
Otherwise the only thing against it is that a lot of translations might not be updated for a long time, if ever.
But I guess that's kind of a silly argument, so I'll merge a PR if you create one.
|
gharchive/issue
| 2016-12-27T17:27:55 |
2025-04-01T04:35:41.039480
|
{
"authors": [
"mueller-ma",
"rdoeffinger"
],
"repo": "rdoeffinger/Dictionary",
"url": "https://github.com/rdoeffinger/Dictionary/issues/58",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
254808311
|
yarn start gives error
Description
I installed CRNP using yarn global and then created a project. Then I tried to run the project using yarn start
Expected Behavior
yarn start should've started the project
Observed Behavior
yarn start gave an error
If there's an error message, please paste the full terminal output and error message in this code block:
paperman@paperland:~/code/nativeapp$ yarn start
yarn start v0.27.5
$ react-native-scripts start
/home/paperman/code/nativeapp/node_modules/react-native-scripts/build/util/packager.js:81
const watcherDetails = spawn
^
TypeError: Cannot read property 'toString' of null
at Object.run (/home/paperman/code/nativeapp/node_modules/react-native-scripts/build/util/packager.js:81:30)
at Object.<anonymous> (/home/paperman/code/nativeapp/node_modules/react-native-scripts/build/scripts/start.js:40:10)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:389:7)
at startup (bootstrap_node.js:149:9)
error Command failed with exit code 1.
Environment
Please run these commands in the project folder and fill in their results:
npm ls react-native-scripts:
react-native-scripts@1.3.0
npm ls react-native:
react-native@0.47.2
npm ls expo:
expo@20.1.2
UNMET PEER DEPENDENCY react@>=15.3.1
node -v:
v6.11.2
npm -v:
3.10.10
yarn --version:
0.27.5
watchman version:
Also specify:
Operating system: Debian Testing
Phone/emulator/simulator & version:
thanks for the report @mahdiG! can you run sysctl fs.inotify.max_user_watches in your terminal and let me know what the output is?
I pushed a new minor release, if you run create-react-native-app SomeAppName again, you shouldn't see this error. still curious about the result of the above, though.
fs.inotify.max_user_watches = 65536
|
gharchive/issue
| 2017-09-02T12:16:18 |
2025-04-01T04:35:41.069379
|
{
"authors": [
"brentvatne",
"mahdiG"
],
"repo": "react-community/create-react-native-app",
"url": "https://github.com/react-community/create-react-native-app/issues/391",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
310024844
|
Updated flowconfig in template
Guys, I made a very small changes, but I encountered a problems when was trying to use the template for flow.
First, I updated a flow version to 0.62
Second, "The unsafe.enable_getters_and_setters option was removed in 0.62.0; getters and setters are now enabled by default."
Thanks for the pull request. CRNA now uses Expo CLI to create the apps, using https://github.com/expo/new-project-template as the template.
|
gharchive/pull-request
| 2018-03-30T09:45:53 |
2025-04-01T04:35:41.071546
|
{
"authors": [
"fson",
"szholdiyarov"
],
"repo": "react-community/create-react-native-app",
"url": "https://github.com/react-community/create-react-native-app/pull/613",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
235130637
|
Tab Navigation is freezing, not able to switch between tabs.
Current Behavior
the following code is integrated with redux.
The problem is that the tab menu is not tappable on the screen, it seems that it has been disabled.
if I don't pass navigation to the <AppNavigator /> then the tab menu starts working.
I tried using it with both emulator and the phone, getting the same result.
I also noticed if I display a modal and after hiding it, everything in the previous screen will be untappable as well, please help.
// reducer.js
const initialNavState = AppNavigator.router.getStateForAction(
NavigationActions.init()
);
// Navigator.js
export const AppNavigator = TabNavigator({
Intro: {
screen: () => (<View><Text>intro</Text></View>),
navigationOptions: {
tabBarLabel: 'Home'
}
},
Profile: {
screen: () => (<View><Text>profile</Text></View>),
navigationOptions: {
tabBarLabel: 'Profile'
}
}
}, {
initialRouteName: 'Intro',
headerMode: 'screen',
swipEnabled: true,
});
const AppWithNavigationState = (props) => {
const dispatch = props.dispatch;
const nav = props.nav;
return (
<AppNavigator
// PROBLEM IS HERE :(
navigation={addNavigationHelpers({ dispatch, state: nav })}
screenProps={{ name: 'Some Name' }}
/>
);
};
const mapStateToProps = state => ({
profile: state.profile,
nav: state.nav
});
export default connect(mapStateToProps)(AppWithNavigationState);
Expected Behavior
Expect the tab menu to work, or if it ls locked get some errors with stack trace!
Your Environment
software
version
react-navigation
1.0.0-beta.11
react-native
0.44.0
node
v7.2.1
npm or yarn
yarn
solved the issue, I was missing the default case, where the navigator dispatches and action, that's why the state wasn't getting changed.
{type: "Navigation/NAVIGATE", routeName: "Intro", params: undefined, action: undefined}
function nav(state = initialNavState, action) {
let nextState;
console.log('action', action);
switch (action.type) {
//...
default:
nextState = AppNavigator.router.getStateForAction(action, state);
break;
}
// Simply return the original `state` if `nextState` is null or undefined.
return nextState || state;
}
|
gharchive/issue
| 2017-06-12T05:49:55 |
2025-04-01T04:35:41.076521
|
{
"authors": [
"skiral"
],
"repo": "react-community/react-navigation",
"url": "https://github.com/react-community/react-navigation/issues/1831",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
307538885
|
how to remove or cancel errors by setFields
i try to use setFields({
name: {errors: []},
}) or by setFields({
name: {errors: null}
}) or just setFields({
name: {value},
}) to cancel the errors but the component which i setFieds is still exist, only the error message gone; the border of the component is still in error color red, how can i resolve this
the border of the component is still in error color red, how can i resolve this
It is not an issue of rc-form, but an issue of your UI component
I really don't undertand; my UI component is just a Input component of antd; why it do not work with antd Form Component
It is an issue which should be file in antd, not rc-form.
|
gharchive/issue
| 2018-03-22T07:55:45 |
2025-04-01T04:35:41.084779
|
{
"authors": [
"benjycui",
"hanhanyaobiancheng"
],
"repo": "react-component/form",
"url": "https://github.com/react-component/form/issues/151",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1338946534
|
Why isn't inputClassName prop in the document?
https://github.com/react-component/input/blob/a53aa2ccb0cc1df7004f3b14962cbc19a47b10fc/src/Input.tsx#L144
Did you forget to add it? If it is, I can give a PR.
The relevant props have been refactored, please re-examine this issue.
|
gharchive/issue
| 2022-08-15T12:34:36 |
2025-04-01T04:35:41.086100
|
{
"authors": [
"dohooo",
"yoyo837"
],
"repo": "react-component/input",
"url": "https://github.com/react-component/input/issues/21",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
159816675
|
support tspan tags
added tspan!
Aww yeah! Thanks hideto0710!
|
gharchive/pull-request
| 2016-06-12T09:03:01 |
2025-04-01T04:35:41.109765
|
{
"authors": [
"danieljoonlee",
"hideto0710"
],
"repo": "react-d3-library/react-d3-library",
"url": "https://github.com/react-d3-library/react-d3-library/pull/43",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1155468587
|
DateRangePicker doesn't follow a correct focus path on key navigation
react-dates version
react-dates@^21.8.0
Describe the bug
When DateRangePicker is navigated through with Tab, it does it correctly until reaching input#endDate element, moment where the focus isn't passed to the just expanded calendar but to whatever follows after this input in the DOM tree, thus leaving the calendar expanded when navigating the rest of the web and not allowing users to access this calendar of course.
Source code (including props configuration)
You can navigate this same code snippet uploaded here in Storybook. I'd recommend to create a live expression with document.activeElement to see what is on focus.
Screenshots/Gifs
Desktop (please complete the following information):
OS: macOS
Browser: Chrome
Version: 98
Is the issue reproducible in Storybook?
Yes
Additional context
Add any other context about the problem here.
I've ran to this same issue. The SingleDatePicker works fine with tab navigation, but the DateRangePicker doesnt seem to close after end date.
|
gharchive/issue
| 2022-03-01T15:20:39 |
2025-04-01T04:35:41.114574
|
{
"authors": [
"Rhaxis",
"valerojasm"
],
"repo": "react-dates/react-dates",
"url": "https://github.com/react-dates/react-dates/issues/2186",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
299738241
|
Safari scroll bug on sortable example (on the actual react-dnd examples page)
BUG REPORT
Browser: Safari
Version: 11.0.2 (12604.4.7.1.6)
Steps to reproduce:
Go to https://react-dnd.github.io/react-dnd/examples-sortable-simple.html
Inspect elements and set the height of the following element to 3000px:
<p data-reactid="89" style="height: 3000px;">
<b data-reactid="90">
<a href="https://github.com/react-dnd/react-dnd/tree/master/examples/04%20Sortable/Simple" data-reactid="91">
Browse the Source
</a>
</b>
</p>
Scroll down and start dragging and dropping.
A drop will sometimes cause the page to scroll to almost the top of the page.
If it doesn't happen, refresh the page and try again. I haven't been able to figure out exactly what causes the behavior, it's very sporadic.
I haven't seen this exact behaviour, and I wasn't able to replicate the above scenario, however we had a similar problem on our product which I'll describe here in case it helps.
We have contenteditable elements inside draggable elements. In Safari if the contenteditable text was selected and then the draggable element was dragged it seems that the browser ended up in a confused state - appearing to drag the selected text while React DnD dragged the element.
From that point on the dragging behaviour was erroneous and often the drag would cause the screen to jump around, similar to what was mentioned above.
I didn't delve into the source to determine why this was happening as I found a workaround which avoided the problem.
By using window.getSelection().removeAllRanges(); on mousedown (before the drag start occurs) the browser would no longer end up in the confused state and dragging behaved as expected.
Hopefully this is helpful & related to the above issue, below is a screen-grab of our issue.
|
gharchive/issue
| 2018-02-23T14:57:26 |
2025-04-01T04:35:41.119266
|
{
"authors": [
"glenn-allen",
"preciselywilliam"
],
"repo": "react-dnd/react-dnd",
"url": "https://github.com/react-dnd/react-dnd/issues/978",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
389854908
|
Error before compiling
I get the following error
./node_modules/react-native-linear-gradient/index.android.js
Module parse failed: Unexpected token (8:36)
You may need an appropriate loader to handle this file type.
| import { processColor, StyleSheet, View } from 'react-native';
|
| import NativeLinearGradient, { type Props } from './common';
|
| const convertPoint = (name, point) => {
my package.json
"name": "test",
"version": "0.1.0",
"private": true,
"dependencies": {
"formik": "^1.3.2",
"keymirror": "^0.1.1",
"react": "^16.5.1",
"react-art": "^16.5.1",
"react-dom": "^16.5.1",
"react-native": "0.55.4",
"react-native-linear-gradient": "^2.5.3",
"react-native-web": "^0.9.0",
"react-navigation": "^2.17.0",
"react-redux": "^5.1.0",
"react-router-dom": "^4.3.1",
"react-router-modal": "^1.4.2",
"redux": "^4.0.1",
"redux-persist": "^5.10.0",
"redux-saga": "^0.16.2"
},
"devDependencies": {
"babel-jest": "^23.4.0",
"babel-preset-react-native": "^4.0.0",
"jest": "^23.4.1",
"react-scripts": "1.1.5",
"react-test-renderer": "^16.3.1",
"uuid": "^3.3.2"
},
"scripts": {
"start": "node node_modules/react-native/local-cli/cli.js start",
"test": "jest",
"start-ios": "react-native run-ios",
"start-web": "react-scripts start",
"build": "react-scripts build",
"test-web": "react-scripts test --env=jsdom",
"eject-web": "react-scripts eject"
},
"rnpm": {
"assets": [
"./assets/fonts/"
]
}
}
closing; let me know if issue persists on latest version
This is still not working
Hi, @radex this issue is still relevant with updated versions.
Version 2.5.4 react-native-linear-gradient
Version 1.0.5 react-native-web-linear-gradient
Exact same error and I have to get a production version of App up in a couple days. pls help
@thodwris did you find an answer? Seems to be no answers online
npm WARN react-native@0.55.4 requires a peer of react@16.3.1 but none is installed. You must install peer dependencies yourself.
Install react 16.3.1 then
npm WARN react-native-web@0.10.1 requires a peer of react@>=16.5.1 but none is installed. You must install peer dependencies yourself.
]
Hi @bitchurself
I just threw away the react-native-web because it will not be viable business wise.
So no error :D
|
gharchive/issue
| 2018-12-11T16:46:01 |
2025-04-01T04:35:41.228864
|
{
"authors": [
"bitchurself",
"radex",
"thodwris"
],
"repo": "react-native-community/react-native-linear-gradient",
"url": "https://github.com/react-native-community/react-native-linear-gradient/issues/377",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
466887580
|
ERROR: Project with path ':react-native-community-netinfo' could not be found in project ':app'.
react-native-netinfo: 3.2.1
react-native: 0.59.0
react: 16.8.4
When upgrading new react native 0.59.0, project having error in android.
Same error.
"@react-native-community/netinfo": "4.0.0"
"react": "16.8.6"
"react-native": "0.60.3"
Script '....../node_modules/@react-native-community/cli-platform-android/native_modules.gradle' line: 106
`A problem occurred evaluating project ':app'.
Project with path ':@react-native-community_netinfo' could not be found in project ':app'`
void addReactNativeModuleDependencies() { reactNativeModules.forEach { reactNativeModule -> def nameCleansed = reactNativeModule["nameCleansed"] project.dependencies { // TODO(salakar): are other dependency scope methods such as api required? implementation project(path: ":${nameCleansed}") //line 106 } } }
Same error.
"@react-native-community/netinfo": "4.0.0"
"react": "16.8.6"
"react-native": "0.60.3"
Script '....../node_modules/@react-native-community/cli-platform-android/native_modules.gradle' line: 106
A problem occurred evaluating project ':app'. Project with path ':@react-native-community_netinfo' could not be found in project ':app'
Solution:
react-native link @react-native-community/netinfo
Yes, this issue is most likely caused by not linking correctly. Please double check the instructions in the README.
I am still facing this issue have followed the steps given in manual link for android.
I am getting the following error:
Project with path ':@react-native-community_netinfo' could not be found in project ':app'
My react native version is : 0.60.3
react: 16.8.6
package version: 4.1.3
@rigbot01 Please open a new issues, following the template and also including the full contents of these files:
package.json
android/settings.gradle
android/build.gradle
android/gradle.properties
android/app/build.gradle
add
include ':@react-native-community_netinfo'
project(':@react-native-community_netinfo').projectDir = new File(rootProject.projectDir, '../node_modules/@react-native-community/netinfo/android')
in <YOUR_APP>/android/settings.gradle
|
gharchive/issue
| 2019-07-11T13:18:14 |
2025-04-01T04:35:41.236967
|
{
"authors": [
"ChandreshRana",
"fcostaprojects",
"madhudskumar",
"matt-oakes",
"rigbot01"
],
"repo": "react-native-community/react-native-netinfo",
"url": "https://github.com/react-native-community/react-native-netinfo/issues/136",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
598602222
|
A potential solution to the issue : "Invalid RNPermission X. Should be one of: ()"
I'm not respecting the template, but I wanted to make a suggestion for the issue : #434
Invalid RNPermission X. Should be one of: ()
In my case I’m using use_frameworks! and by adding only Permission-LocationAlways, I was still having the issue, but then I added RNPermissions too and then it worked
Here is the end of my Podfile :
$static_framework = [
'RNVectorIcons', 'RNFBAnalytics', 'RNFBApp', 'RNPermissions', 'Permission-LocationAlways'
]
pre_install do |installer|
installer.pod_targets.each do |pod|
if $static_framework.include?(pod.name)
def pod.build_type;
Pod::BuildType.static_library
end
end
end
end
use_native_modules!
end
Maybe try it with other permissions and update the README if it's working.
I was actually having this issue, but as it is in README.md, under ios, I had to put in Podfile
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse.podspec"
and it worked
@Daavidaviid This is totally identical to what's in already in the README, no? https://github.com/react-native-community/react-native-permissions#workaround-for-use_frameworks-issues (RNPermissions didn't need be statically linked)
I was actually having this issue, but as it is in README.md, under ios, I had to put in Podfile
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse.podspec"
and it worked
@LMestre14 The latest version has a more explicit error for this 🙂
@LMestre14 The latest version has a more explicit error for this 🙂
Sorry I wasn't very explicit. I added RNPermissions to static frameworks in Podfile.
And I just tested again and I can confirm that with version 2.0.9 on my machine, the iOS build fails if I don't add RNPermissions and only add Permission-LocationAlways to static frameworks.
@Daavidaviid what's your react-native version?
0.62
I'm using 0.61.5
In my Podfile I don't have $static_framework as you have on yours, because supposedly native components like react-native-permissions should only be installed (yarn or npm) and right after run command pod install in the projects ios folder.
I don't understand why you need $static_framework in the first place
@LMestre14 Because he uses use_frameworks! and currently Cocoapods don't provide a proper way to define a Podspec as a static library.
@Daavidaviid I just tried without RNPermissions linked as static framework and can confirm it's not needed (only needed for the permission handlers). It might be related to something else (Xcode cache stale data? Try to remove RNPermissions for $static_framework), nuke the Xcode DerivedData folder, your Pods folder and reinstall / rebuild everything.
Ok, I just cleaned the build in Xcode everytime. I’ll try with DerivedData folder later. Also, LocationAlways is the only permission I use, don’t know if it could be linked.
I upgraded to 2.1.0 today and now I get the error screen as in https://github.com/react-native-community/react-native-permissions/issues/441#issuecomment-612861024, even that it was working on 2.0.10. I don't use use_frameworks
@radko93 Please provide more informations (OS?, RN version? permission handlers linked? Xcode DerivedData / Gradle cache cleaned?)
React Native 0.62.2
iOS simulator 13.4
I cleaned all the folders and simulator.
my Podfile:
platform :ios, '11.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'
def add_flipper_pods!(versions = {})
versions['Flipper'] ||= '~> 0.33.1'
versions['DoubleConversion'] ||= '1.1.7'
versions['Flipper-Folly'] ||= '~> 2.1'
versions['Flipper-Glog'] ||= '0.3.6'
versions['Flipper-PeerTalk'] ||= '~> 0.0.4'
versions['Flipper-RSocket'] ||= '~> 1.0'
pod 'FlipperKit', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitLayoutPlugin', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/SKIOSNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitUserDefaultsPlugin', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitReactPlugin', versions['Flipper'], :configuration => 'Debug'
# List all transitive dependencies for FlipperKit pods
# to avoid them being linked in Release builds
pod 'Flipper', versions['Flipper'], :configuration => 'Debug'
pod 'Flipper-DoubleConversion', versions['DoubleConversion'], :configuration => 'Debug'
pod 'Flipper-Folly', versions['Flipper-Folly'], :configuration => 'Debug'
pod 'Flipper-Glog', versions['Flipper-Glog'], :configuration => 'Debug'
pod 'Flipper-PeerTalk', versions['Flipper-PeerTalk'], :configuration => 'Debug'
pod 'Flipper-RSocket', versions['Flipper-RSocket'], :configuration => 'Debug'
pod 'FlipperKit/Core', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/CppBridge', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FBCxxFollyDynamicConvert', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FBDefines', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FKPortForwarding', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitHighlightOverlay', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitLayoutTextSearchable', versions['Flipper'], :configuration => 'Debug'
pod 'FlipperKit/FlipperKitNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
end
# Post Install processing for Flipper
def flipper_post_install(installer)
installer.pods_project.targets.each do |target|
if target.name == 'YogaKit'
target.build_configurations.each do |config|
config.build_settings['SWIFT_VERSION'] = '4.1'
end
end
end
file_name = Dir.glob("*.xcodeproj")[0]
app_project = Xcodeproj::Project.open(file_name)
app_project.native_targets.each do |target|
target.build_configurations.each do |config|
cflags = config.build_settings['OTHER_CFLAGS'] || '$(inherited) '
unless cflags.include? '-DFB_SONARKIT_ENABLED=1'
puts 'Adding -DFB_SONARKIT_ENABLED=1 in OTHER_CFLAGS...'
cflags << '-DFB_SONARKIT_ENABLED=1'
end
config.build_settings['OTHER_CFLAGS'] = cflags
end
app_project.save
end
installer.pods_project.save
end
# Pods for Blossom
pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
pod 'React', :path => '../node_modules/react-native/'
pod 'React-Core', :path => '../node_modules/react-native/'
pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'
pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga', :modular_headers => true
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
# Permissions
permissions_path = '../node_modules/react-native-permissions/ios'
pod 'Permission-Notifications', :path => "#{permissions_path}/Notifications.podspec"
post_install do |installer|
flipper_post_install(installer)
end
target "App" do
use_native_modules!
add_flipper_pods!
end
target "App2" do
use_native_modules!
add_flipper_pods!
end
@radko93 Thanks, it helped a lot! I see what this is: you only use the notification permission handler which is a bit different from the others (for the specific functions checkNotifications / requestNotifications) and the header file check is missing in the new startup check (it's here, and I copied this list). I will add it and publish a new release.
@zoontek great will check it out once released.
@radko93 It has been published. Sorry for the inconvenience.
@zoontek You saved my life, thanks, now everything works as expected.
Erratum: Just tried it with a fresh new project, RNPermissions need effectively to be linked as a static library too. I added it to the README.
|
gharchive/issue
| 2020-04-13T00:20:01 |
2025-04-01T04:35:41.253198
|
{
"authors": [
"Daavidaviid",
"LMestre14",
"artemkhalygov",
"radko93",
"zoontek"
],
"repo": "react-native-community/react-native-permissions",
"url": "https://github.com/react-native-community/react-native-permissions/issues/441",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
192637346
|
How To: Horizontal swipes inside TabViewAnimated
Thank you for this component <3
Trying to solve one problem my guess it's very common without any luck. App has 3 screens, on two of them I'd like to be able to swipe horizontally without changing the screen. On isolation work,but when mixing it with TabViewAnimated both fail.
(Colored 'squares' at the bottom are inside a horizontal ListView)
(Each item list should reveal a button on swiping left)
Should I be looking at TabViewPagerPan ?
Current iteration https://gist.github.com/polmoneys/26cfc57287e9529e098b83e62eb2c93c
@polmoneys You probably just want to disable horizontal swiping on tabs? That'd work for you I think
https://github.com/react-native-community/react-native-tab-view/blob/master/example/src/NoAnimationExample.js#L132
You could probably conditionally set it like swipeEnabled={this.state.index === 2} (if you want swipe to be enabled only on second tab)
my hope was not to lose horizontal swiping to switch tabs, some sort of checking for the distance of the swipe and decide if 'greater than'.
thanks for swipeEnabled={this.state.index === 2} this might be the answer, let me try it and get back to you. GRACIAS !
@polmoneys
my hope was not to lose horizontal swiping to switch tabs, some sort of checking for the distance of the swipe and decide if 'greater than'.
TabViewPagerPan does accept a swipeDistanceThreshold prop, I'm not sure if it will work with another swipeable element, but worth a try. Though I think this behaviour might be a bit confusing for the user.
|
gharchive/issue
| 2016-11-30T18:04:42 |
2025-04-01T04:35:41.258794
|
{
"authors": [
"polmoneys",
"satya164"
],
"repo": "react-native-community/react-native-tab-view",
"url": "https://github.com/react-native-community/react-native-tab-view/issues/75",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
577271485
|
[ANDROID] Race condition of life cycles in Webview
Hello,
There seems to be a race condition within the life cycle of the webview (i.e. loadEnd, loadStart, loadProgress, etc...).
What happens is each lifecycle does not seem to be called correctly at the timing they are supposed to be when navigating to different pages. I.e. onProgress is called before onStart, onEnd being called at the start of navigation, etc. Sometimes, onLoadProgress is not even called(for cached pages maybe?)
ALso they are 'delayed' are is called upon next navigation page. E.g, part of onLoadProgress event of page A is called upon the start of navigation of page B, etc..
This does not happen in IOS.
I encountered this in #1099 (lots of head-scratching to read in there). The race condition seems to be problematic for hosted websites but less so – or not at all – for static HTML sources. I'm not familiar enough with Android WebView or its lifecycle to understand why it's so broken. But you're certainly not imagining things.
I'm also experiencing this.
I get onProgress called after onLoadEnd has been called
still searching for solutions
still searching for solutions
@safaiyeh The github-actions bot didn't take the hint; could you please re-open this? Thanks.
onLoadProgress do not work sometimes
|
gharchive/issue
| 2020-03-07T03:43:08 |
2025-04-01T04:35:41.262091
|
{
"authors": [
"KingAmo",
"nadav2051",
"panda0603",
"shirakaba"
],
"repo": "react-native-community/react-native-webview",
"url": "https://github.com/react-native-community/react-native-webview/issues/1250",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
407608481
|
Support fullscreen video on Android
Fixes https://github.com/react-native-community/react-native-webview/issues/294.
Let me know if we want to add anything as part of this.
@dvicory This works great! Wish I had seen it earlier this week before I did almost identical work on my own fork. Your implementation is much cleaner though, so going to use yours and hope it gets merged soon. Nice work!
I'll wait for updates from @dvicory to merge, but many thanks for testing @smathson
@Titozzz and @smathson sorry for the very late followup, but I've addressed the original issue of forcing orientation. Currently, I've made the best fullscreen experience only for KitKat or greater. I hope that's acceptable as getting it working well pre-KitKat turned out to be quite a challenge. Fullscreen video will still work there, just with the navigation and status bars.
Right now it uses sticky immersive mode (for KitKat and above), doesn't force orientation, and works well if a user locks the screen or backgrounds the app. Let me know if I can address anything further.
@dvicory Looks great to me. I won't have a chance to test this in our production app anytime soon but I'll try to run it through a test app tomorrow or early next week.
@dvicory Any change you can get a look at the conflicts? I merged quite a lot of stuff recently
@Titozzz Rebased and resolved conflicts. I've tested on the following devices we have:
Nexus 7 with Android 4.3
Nexus 5 with Android 6.0.1
Samsung S7 with Android 7.0
Samsung S9 with Android 8.0
Pixel 2 with Android 9.0
Couldn't find our phone with KitKat unfortunately.
Great, thanks
did you checked how embedded youtube works in fullscreen? I've tried your PR, but there was an issues:
Sometimes "fullscreen" button is not tapable on real device (Xiaomi Redmi 6A)
When button is tapable, video missing on fullscreen, only audio available.
@Strate I experienced the same problem on my Nexus 6P with a custom ROM (Pixel Experience), but attributed it to the custom ROM... Other Nexus, Samsung, and Pixel phones have no problems. I would appreciate any help in investigating what's going wrong here. I don't know that this should be a blocker to merging?
@Strate @dvicory please keep me updated if this is a blocker or not :)
@Titozzz actually, this happens with other webview components (I've tried https://github.com/teamairship/react-native-android-fullscreen-webview-video). Looks like this is a youtube-related problem, because Vimeo works great.
So you are saying we can merge this as is?
@Titozzz I can't say this, because actually I am not an android developer, I just tried to find out youtube fullscreen problem, found this PR and tested it )
Manually applied the changes to test this out. This is for youtube and vimeo embed in a website. (Huawei Nova 3)
For youtube embed, the fullscreen icon is not greyed out anymore. But when I tap on the icon, nothing happens. Seeing this mSecurityInputMethodService is null in logcat.
As for vimeo embed, when I tap on the fullscreen icon, the screen becomes white colour. But the video is actually already full screen and playing below the white screen.
Is there anything that I can do to help this PR to get merged?
I was thinking of creating a repo with this branch and try to reproduce the bug. Would it help?
I tested it on my Galaxy Tab S2 with Android 7.0 and in fullscreen, my screen gets black, but I can hear the sound and clicking on the video also works
If anyone can find the reasons for the last few bugs it would be great as it already looks like it's working on many devices
If anyone can find the reasons for the last few bugs it would be great as it already looks like it's working on many devices
can we ship this as experimental? would this break other features?
I could. I can always revert if something gets broken but I guess it should only affect people using full screen and since it's broken right now..
I could put this behind a JSX feature flag if people desire that, e.g. fullscreenVideoEnabled. Thoughts?
I haven't had time to jump into this more to see why some devices have issues with fullscreen video. 😞 It's probably something really nonsense...
I could put this behind a JSX feature flag if people desire that, e.g. fullscreenVideoEnabled. Thoughts?
I haven't had time to jump into this more to see why some devices have issues with fullscreen video. It's probably something really nonsense...
The flag fullscreenVideoEnabled sounds good to me.
I'm a Systems Analyst/Developer at a Brazilian University. Our app will run through many devices, at least 200 hundred thousand students will use it. We will put a log feature into entire app and if any user report errors with fullscreen or something like that, we will be able to retrieve some informations about OS, Brand, Android version, etc... I think is a good way to test on a large variety of devices.
What do you think about it?
let's ship behind a flag
I just added the flag in the latest commit: allowsFullscreenVideo. By default it's false. I've tested some corner cases on my Pixel 3 with switching this value at runtime, so far no bad effects. Welcome extra testing on this.
When I add this branch with "yarn add https://github.com/appfolio/react-native-webview.git#b41de3b", I get an Error because my lib folder doesn't exist in node_modules/react-native-webview. Is there another way to add that branch to my package.json?
@karvulf Since moving to TypeScript, the package has to be built. The way I locally developed with this branch is to have my branch locally checked out, yarn install, yarn build, then install react-native-webview by file reference in my example project.
I don't know of a good way to add my branch to your project right now that doesn't involve either publishing our fork or you adding postinstall scripts to handle the dependency specially (I don't recommend this). If you'd like I could create another branch for you that is installable.
That would be great and easier for me to test it! @dvicory
@karvulf Okay, I made a branch with the TypeScript buit.
You should be able to add it like so: yarn add "github:appfolio/react-native-webview#built-android-fullscreen-video". Please let me know how it works out for you.
Thank you very much! It works @dvicory
@sibelius @smathson Anything more I can do to help push this through?
Nope, you already rock 😍
@allcontributors[bot] please add @dvicory for code doc
Nice job fellows!
Like I said above, if any user reports some unexpected behaviour , I will stat you guys.
Thanks!
Any ideas about get notified when enter/exit fullscreen? I'm seeking for a way on Android to unlock the orientations when the webview enters fullscreen mode to enable auto-rotate feature, and lock it again when exits.
WKWebView handles this case well on iOS side, so it's a bit inconsistent on this. Temporarily my workaround is changing the Java code to emit exit and enter events. I don't know if it's a good idea to add another callback for Android : /.
@ouabing perhaps continue this discussion in #586.
Shows white screen when we disconnect internet in full-screen mode. Backbutton stops working.
|
gharchive/pull-request
| 2019-02-07T09:32:21 |
2025-04-01T04:35:41.280460
|
{
"authors": [
"Josephdias92",
"MalcolmScruggs",
"Strate",
"Titozzz",
"adrianchinghc",
"ambrosiora",
"dvicory",
"karvulf",
"miltoneiji",
"ouabing",
"sibelius",
"smathson"
],
"repo": "react-native-community/react-native-webview",
"url": "https://github.com/react-native-community/react-native-webview/pull/325",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1236735916
|
isHeadphoneConnected: Bluetooth headset is not recognized in Android
Summary
Version
8.7.1
Affected OS
android
OS Version
12
Current behavior
When I try to connect a Bluetooth headset, it is not recognized on Android. It works with wired headsets.
With the hook useIsHeadphonesConnected I only get the following back: { "loading": false, "result": false }
Expected behavior
When connecting with a headset it should look like this: { "loading": false, "result": true }
Probable error source
The isBluetoothA2dpOn function is used, but has been deprecated since API 26. Maybe you should change it to: https://stackoverflow.com/a/45629557
The isBluetoothA2dpOn function is used, but has been deprecated since API 26. Maybe you should change it to: https://stackoverflow.com/a/45629557
"you" :thinking: ? PRs happily accepted! :+1:
https://hackernoon.com/i-thought-i-understood-open-source-i-was-wrong-cf54999c097b
yes i know the principe of open source, but unfortunately i don't have the know how and time to fix this by myself.
No problem, I do understand that - unfortunately that means it'll sit until an interested party rolls up sleeves and tackles it. I will say, just as a possible motivator, I knew nothing of android mobile development (first) or react-native module development (second) until I just said "Oh what the heck, let's open up the docs and just play around and see if I can hack something up". It's possible to build the know-how by simply trying in other words - the code in react-native modules is typically very basic (thankfully!)
I'll take a crack at this.
up for this
|
gharchive/issue
| 2022-05-16T07:24:32 |
2025-04-01T04:35:41.286998
|
{
"authors": [
"Daveeeeeeeeee",
"TheShadowPlayer",
"mikehardy",
"schie"
],
"repo": "react-native-device-info/react-native-device-info",
"url": "https://github.com/react-native-device-info/react-native-device-info/issues/1415",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1467721693
|
Buidling for iOS Simulator, but linking in object file for iOS
Summary
Recently added the lib to my project and never manged to get it working in Simulator.
Whenever I run a debug build from Xcode I get
error build: Building for iOS Simulator, but linking in object file built for iOS, file '/Users/shashawa/Documents/projects/myapp/ios/Pods/GoogleMaps/Maps/Frameworks/GoogleMaps.framework/GoogleMaps' for architecture arm64
Reproducible sample code
no code involved
Steps to reproduce
Just follow the instructions to add the library to an iOS project, with the following setup
System:
OS: macOS 12.6
CPU: (8) arm64 Apple M1 Pro
Memory: 206.11 MB / 32.00 GB
Shell: 5.8.1 - /bin/zsh
Binaries:
Node: 18.6.0 - ~/.asdf/installs/nodejs/18.6.0/bin/node
Yarn: 1.22.19 - ~/.asdf/shims/yarn
npm: 9.1.1 - ~/.asdf/plugins/nodejs/shims/npm
Watchman: 2022.11.14.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.11.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
Android SDK:
API Levels: 23, 29, 30, 31, 33
Build Tools: 29.0.2, 29.0.3, 30.0.2, 30.0.3, 31.0.0, 33.0.0
System Images: android-29 | Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play ARM 64 v8a, android-29 | Google Play Intel x86 Atom, android-30 | Google APIs ARM 64 v8a, android-30 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2021.3 AI-213.7172.25.2113.9014738
Xcode: 14.0/14A309 - /usr/bin/xcodebuild
Languages:
Java: 11.0.13 - /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: ^0.69.0 => 0.69.7
react-native-macos: Not Found
npmGlobalPackages:
*react-native*: Not Found
```
### Expected result
I expect builds to succeed on Xcode for debug builds on Simulator
### Actual result
error build: Building for iOS Simulator, but linking in object file built for iOS, file '/Users/shashawa/Documents/projects/myapp/ios/Pods/GoogleMaps/Maps/Frameworks/GoogleMaps.framework/GoogleMaps' for architecture arm64
### React Native Maps Version
"react-native-maps": "^1.3.2",
### What platforms are you seeing the problem on?
iOS (Google Maps)
### React Native Version
0.69.7
### What version of Expo are you using?
Not using Expo
### Device(s)
Simulator
### Additional information
_No response_
me to
still experiencing this. Have read this , no dice.
Any ideas?
Hello 👋
arm64 is supported since v1.4.0! Make sure to check out the updated installation instructions! :)
|
gharchive/issue
| 2022-11-29T09:22:17 |
2025-04-01T04:35:41.314039
|
{
"authors": [
"Simon-TechForm",
"sanengineer",
"shawarmaz"
],
"repo": "react-native-maps/react-native-maps",
"url": "https://github.com/react-native-maps/react-native-maps/issues/4539",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
1139760983
|
Moniting document.title change?
Is your feature request related to a problem? If so, Please describe.
I need sync document.title to my React Navigation's title in real time, but injectedJavaScript="window.postMessage(document.title)" can only works one time
Describe the solutions you came up with
Add a callback that is called every time document.title changed
Additional context
On iOS, we can observe WKWebview.title to detect every time the title changes;
That's not a bad idea, looks like Android has a similar notification (PRs welcome :) ). In the meantime, I'm not sure if this would work, but possibly you could inject javascript that overrides the title property (similar to https://stackoverflow.com/a/35512224) and posts a message whenever the setter is called?
you can inject the script like this:
const nav = useNavigation()
const script = `
let _documentTitle = document.title;
window.ReactNativeWebView.postMessage(_documentTitle)
Object.defineProperty(document, 'title', {
set (val) {
_documentTitle = val
window.ReactNativeWebView.postMessage(_documentTitle)
},
get () {
return _documentTitle
}
});
`
const onPostMsg = ({ nativeEvent }: WebViewMessageEvent) => {
nav.setOptions({ title: nativeEvent.data })
}
return (
<WebView
injectedJavaScript={script}
source={{ uri: route.params.url }}
onMessage={onPostMsg}
/>
)
I found a another way to listen document.title:
const nav = useNavigation()
const script = `
const titleDom = document.getElementsByTagName('title')[0]
const observer = new MutationObserver(() => {
window.ReactNativeWebView.postMessage(document.title)
})
observer.observe(titleDom, {
childList: true
})
window.ReactNativeWebView.postMessage(document.title)
`
const onPostMsg = ({ nativeEvent }: WebViewMessageEvent) => {
// title can be used here
nav.setOptions({ title: nativeEvent.title })
// you can also use data
// nav.setOptions({ title: nativeEvent.data })
}
return (
<WebView
injectedJavaScript={script}
source={{ uri: route.params.url }}
onMessage={onPostMsg}
/>
)
see MutationObserver
|
gharchive/issue
| 2022-02-16T09:27:39 |
2025-04-01T04:35:41.331159
|
{
"authors": [
"HuPeng333",
"TheAlmightyBob",
"likeSo"
],
"repo": "react-native-webview/react-native-webview",
"url": "https://github.com/react-native-webview/react-native-webview/issues/2378",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
316177421
|
Few typos in documentation
I came across below typos in the documentation:
Missing word 'to' in react-navigation.github.io/docs/getting-started.md
It should be enough for you know how to build ...
Missing word 'in' in react-navigation.github.io/docs/headers.md
Conveniently, these are the colors we're using our running example...
Misspelt word 'an' in react-navigation.github.io/docs/contributing.md
Before submitting and issue...
I will be happy to fix these in a single or separate PRs as deemed appropriate.
closed through https://github.com/react-navigation/react-navigation.github.io/pull/144
|
gharchive/issue
| 2018-04-20T08:37:25 |
2025-04-01T04:35:41.334387
|
{
"authors": [
"karthikvrao",
"vonovak"
],
"repo": "react-navigation/react-navigation.github.io",
"url": "https://github.com/react-navigation/react-navigation.github.io/issues/138",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
860880328
|
Hardcoded zIndex on BottomDrawer Paper makes it unusable in Mui Dialogs. Consider exposing paper props on BottomToolbar
In line https://github.com/react-page/react-page/blob/70ed998b98e6c063e36892874d857cf2a1c4442f/packages/editor/src/ui/BottomToolbar/Drawer.tsx#L52-L54, there is no way to change the zIndex of the drawer's paper.
Currently we are using
<Editor
components={{
BottomToolbar: CustomToolbar,
}}
cellPlugins={cellPlugins}
value={value}
onChange={(value) => setValue(name, value)}
/>;
const useStyles = makeStyles({
drawer: {
"&, & > *": {
// Passed to MuiPaper
zIndex: `1200 !important`,
},
},
});
const CustomToolbar = memo<BottomToolbarProps>((props) => {
const classes = useStyles();
return <BottomToolbar {...props} className={classes.drawer} />;
});
as a workaround.
Perhapes exposing PaperProps, or even all other styling options would be more convenient to style the drawer
it needs to have a certain z-index. In which case did you have problem with it? Slate also uses dialogs and i did not observe a problem
MUI dialogs has zIndex 1400. If we use react-page inside a fullscreen dialog, the plugin selection drawer and bottom drawer would be completely covered by the dialog.
Still a problem, I'd rather not have to fork just to change a single zIndex prop.
Still a problem, I'd rather not have to override the entire toolbar just to change a single zIndex prop.
can you file a pull request?
|
gharchive/issue
| 2021-04-19T04:22:07 |
2025-04-01T04:35:41.343474
|
{
"authors": [
"hinsxd",
"macrozone",
"zarybnicky"
],
"repo": "react-page/react-page",
"url": "https://github.com/react-page/react-page/issues/970",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
628582895
|
[v9.0.0-rc.3] useTransition doesn't update "transform" when leaving
🐛 Bug Report
React-spring fails to update the transform property before unmounting if the unmount has been triggered after the mounting animation has finished (see this video). I'm not sure if there are other props affected by this, but as you can see opacity works just fine as expected.
Example
const Menu = ({ open }) => {
const t = useTransition(open, {
from: { opacity: 0, transform: 'translateX(100%)' },
enter: { opacity: 1, transform: 'translateX(0)' },
leave: { opacity: 0, transform: 'translateX(100%)' },
config: { duration: 250 },
});
return t(
(style, item) =>
item && (
<animated.aside
style={style}
className="...">
{ /* some content */ }
</animated.aside>
)
);
};
Link to repro (highly encouraged)
Could not reproduce it on CSB, occurs in my current project though.
Did not happen in v8 with the old useTransition signature.
Environment
react-spring v9.0.0-rc.3
react v16.13.1
Try changing translateX(0) to translateX(0%)
Indeed, the '%' was the culprit. It was working just fine in v8 that's why I did not suspect anything regarding the absence of the percent symbol. Thank you!
@aleclarson I have the same exact problem, percent symbol thing doesn't help:
https://codesandbox.io/s/react-spring-dialogs-mqukl
@selrond Probably not the same issue then. Try using v9, then open a new issue. Thanks 👍
|
gharchive/issue
| 2020-06-01T16:50:09 |
2025-04-01T04:35:41.351318
|
{
"authors": [
"abdullahsari",
"aleclarson",
"selrond"
],
"repo": "react-spring/react-spring",
"url": "https://github.com/react-spring/react-spring/issues/1035",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
571118273
|
Unexplained exception when changing third-party styles
Hello! I have tried to create slider-ticker: endless running line that is mouse-event driven. I use while to create infinite running like you do in documentation, but sometimes I get an exception.
In my IDE it says:
... and in console:
Uncaught (in promise) TypeError: Cannot read property 'replace' of null
at web.js:1851
at Array.map (<anonymous>)
at createStringInterpolator (web.js:1851)
at web.js:941
at Array.reduce (<anonymous>)
at Controller.diff (web.js:922)
at web.js:881
at new Promise (<anonymous>)
at props.to.finished (web.js:881)
at to$ (Ticker.js:78)
at tryCatch (runtime.js:45)
at Generator.invoke [as _invoke] (runtime.js:271)
at Generator.prototype.<computed> [as next] (runtime.js:97)
at tryCatch (runtime.js:45)
at invoke (runtime.js:135)
at runtime.js:145
So, handler go is source of problems. When is it happen? When there are any changes in the DOM. For example, page content becomes opacity: null; pointer-event: none; when my mobile menu opened; next, I close menu and touch my slider-ticker; exception!
I do not mount or unmount any components. Why does it happen? And, please, can you help me to fix it?
Not a problem with react-spring (though, the error message could be better).
You're passing startPosition: null after the menu is opened and then closed.
Can't help you more than that. Good luck
|
gharchive/issue
| 2020-02-26T07:17:52 |
2025-04-01T04:35:41.354818
|
{
"authors": [
"aleclarson",
"mikhailnetkachev-halolab"
],
"repo": "react-spring/react-spring",
"url": "https://github.com/react-spring/react-spring/issues/939",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
444143455
|
Undefined error in Block component
In your plant-app, while learning as soon as I import {Block} from components I get the following error on snack.expo project:
Device: (101:380) Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined.
This error is located at:
in App
in RCTView
in RCTView
https://snack.expo.io/@alibth/plants
@iloveyii Thanks for opening this issue. Usually this should work, but I double check this snack and probably the error is in the App setup, don't know exactly.
Try this: import Block from './components/Block';
Also please copy the theme.js because the Block component is using it.
|
gharchive/issue
| 2019-05-14T21:57:34 |
2025-04-01T04:35:41.357827
|
{
"authors": [
"hetmann",
"iloveyii"
],
"repo": "react-ui-kit/dribbble2react",
"url": "https://github.com/react-ui-kit/dribbble2react/issues/35",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
817774638
|
Update scala-library to 2.12.13
Updates org.scala-lang:scala-library from 2.12.5 to 2.12.13.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!
Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-lang", artifactId = "scala-library" } ]
labels: library-update, semver-patch
Superseded by #24.
|
gharchive/pull-request
| 2021-02-27T00:47:34 |
2025-04-01T04:35:41.365619
|
{
"authors": [
"scala-steward"
],
"repo": "reactific/sbt-reactific",
"url": "https://github.com/reactific/sbt-reactific/pull/15",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
406938157
|
Ensure help text
Make sure that all cli args and options have help text, that the help text is meaningful and free of typos
Closed by #178
|
gharchive/issue
| 2019-02-05T19:27:22 |
2025-04-01T04:35:41.389139
|
{
"authors": [
"ejether"
],
"repo": "reactiveops/pentagon",
"url": "https://github.com/reactiveops/pentagon/issues/175",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
976155872
|
[BUG] ReactiveCommand's IsExecuting is not set to true if it's executed again after throwing an exception
Describe the bug
If a command throws an exception and it gets executed again later, IsExecuting will remain false.
Steps To Reproduce
Basically added 2 lines of code to an existing test.
[Fact]
public async Task CommandIsExecutingTest()
{
var subj = new Subject<Unit>();
bool isExecuting = false;
Exception? fail = null;
var fixture = ReactiveCommand.CreateFromTask(async () =>
{
await subj.Take(1);
throw new Exception();
});
fixture.IsExecuting.Subscribe(x => isExecuting = x);
fixture.ThrownExceptions.Subscribe(ex => fail = ex);
Assert.False(isExecuting);
Assert.Null(fail);
fixture.Execute().Subscribe();
Assert.True(isExecuting);
Assert.Null(fail);
subj.OnNext(Unit.Default);
// Wait 1 ms to allow execution to complete
await Task.Delay(1).ConfigureAwait(false);
Assert.False(isExecuting);
Assert.NotNull(fail);
fixture.Execute().Subscribe();
Assert.True(isExecuting); // Fails here.
}
Expected behaviour
IsExecuting should be true when the command is executing.
Environment
OS: Windows 10, .NET SDK 5.0.206, Runtime 5.0.9
ReactiveUI Version: 15.1.1
We are trying to come up with a resolve for this but the root cause is in the System.Reactive code
https://github.com/dotnet/reactive/issues/1256
This issue has been outstanding for quite some time.
Closing this issue due to it being related to the Rx team not RxUI.
|
gharchive/issue
| 2021-08-21T15:01:42 |
2025-04-01T04:35:41.393260
|
{
"authors": [
"ChrisPulman",
"glennawatson",
"n-ski"
],
"repo": "reactiveui/ReactiveUI",
"url": "https://github.com/reactiveui/ReactiveUI/issues/2894",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
278169777
|
reducer goes into a loop when returning a new array created from state
I have a reducer containing the following code:
export default (state = [], action) => {
switch(action.type) {
case 'ADD_ENGAGEMENT':
let newArr = state.slice();
newArr.push(action.payload);
return newArr;
case 'UPDATE_ENGAGEMENT':
console.info('UPDATE_ENGAGEMENT')
return state.slice();
// return state;
default:
return state;
}
}
The issue occurs within the 'UPDATE_ENGAGEMENT' case -- the actual business logic has been removed and replaced with the simplest example to demonstrate the problem.
When a new array created from state via state.slice() is returned, a loop is triggered, causing the action to be dispatched until an 'Uncaught RangeError: Maximum call stack size exceeded' error is raised. Below is a screenshot of the browser console during the issue's occurrence.
When the original state is returned, the issue does not occur.
I am completely baffled by this behavior and cannot fathom how anything in my application could be causing it. Any insight would be immensely appreciated.
I forgot to mention that the version of react-redux is 5.0.6
The issue is not limited to 'slice()' and occurs whenever an array containing any element of state is returned e.g. return [state[0]]
This is a bug tracker, not a support system. For usage questions, please use Stack Overflow or Reactiflux where there are a lot more people ready to help you out - you'll probably get a better answer faster. Thanks!
That said, it's also very hard to understand what the issue is without seeing the rest of your code. My immediate guess is that you have a component that's dispatching the action in componentWillReceiveProps or something similar, thus causing the infinite loop.
@boris-layvant Did you found any solution?
|
gharchive/issue
| 2017-11-30T15:50:13 |
2025-04-01T04:35:41.403800
|
{
"authors": [
"anniewey",
"boris-layvant",
"markerikson"
],
"repo": "reactjs/react-redux",
"url": "https://github.com/reactjs/react-redux/issues/832",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
436850333
|
useEffect documentation and misunderstandings
In our application, we ran into a bug related to using a [] array as the second argument to useEffect, on the assumption that it would only run on mount and unmount. Unfortunately, this wasn't true and produced some chaos.
That bug was fixable, albeit not very cleanly, but it led me to notice a few things:
When exactly does React clean up an effect? React performs the cleanup when the component unmounts. However, as we learned earlier, effects run for every render and not just once. This is why React also cleans up effects from the previous render before running the effects next time. We’ll discuss why this helps avoid bugs and how to opt out of this behavior in case it creates performance issues later below.
This could be clearer by saying:
When exactly does React clean up an effect? React performs the cleanup when the component unmounts, and also between renders. As we learned earlier, effects run for every render and not just once. This is why React also cleans up effects from the previous render before running the effects next time. We’ll discuss why this helps avoid bugs and how to opt out of this behavior in case it creates performance issues later below.
This misunderstanding is fairly widespread: for example,
on useHooks.com, in each of its examples featuring useEffect, it has a comment Empty array ensures effect is only run on mount and unmount.
in React Hooks: Why and How, it states "Optionally the second parameter can also just be an empty array, in this case it will only execute on componentDidMount and componentWillUnmount and the effect won’t run on componentDidUpdate."
In Using the useEffect hook, it states "Let's say we only wanted the effect to run a single time... think of this as a replacement for componentDidMount. To do this, pass a [] as the 2nd argument to useEffect:"
Certainly a lot of this misunderstanding is just folks looking for equivalents of the React.Component API, and in this case there isn't a precise one. But I think by saying that there are two cases up-front, rather than saying one and then also the other, you'll help keep people on the right path.
Sorry that this slipped through the cracks. We've been heads down working on the next releases, and have deprioritized GitHub issue maintenance in the docs repo for now. We're also rewriting the docs because a lot of these problems are known (and aren't new), and we want to address them holistically.
I do want to note that this sounds inaccurate:
[] array as the second argument to useEffect, on the assumption that it would only run on mount and unmount [...] this wasn't true
In today's React, an empty [] argument does exactly correspond to mount/unmount. (Although we try not to advertise it as such because it gives you wrong assumptions about props and state — they will be the initially captured ones instead of continuously updated ones like this.props or this.state were inside componentDidMount.)
So your initial assumption was correct and the problem you've seen must have been something else. I don't know what, though, since there was no reproducing example.
|
gharchive/issue
| 2019-04-24T18:43:22 |
2025-04-01T04:35:41.410814
|
{
"authors": [
"gaearon",
"tmcw"
],
"repo": "reactjs/reactjs.org",
"url": "https://github.com/reactjs/reactjs.org/issues/1945",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
508763549
|
Updated URL with page section
@mvikrammenon thank you!
|
gharchive/pull-request
| 2019-10-17T23:02:24 |
2025-04-01T04:35:41.411932
|
{
"authors": [
"lex111",
"mvikrammenon"
],
"repo": "reactjs/reactjs.org",
"url": "https://github.com/reactjs/reactjs.org/pull/2446",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
227025222
|
clone selectors
In the case where you have a selector used by multiple component instances at once you need to change the selector file to account for this by wrapping the selector in a factory function.
This leads me to using factories for all of my selectors for consistency. What if, instead, reselect exposed a .cloneSelector() method on selectors it creates which give a copy?
This could also be used in an abstraction like this:
import {
normalFunctionSelector,
reselectSelector,
} from './selectors';
import makeMapState from 'make-map-state'; // hypothetical module
const mapState = makeMapState({
foo: normalFunctionSelector,
bar: reselectSelector,
});
export default connect(mapState)(C);
makeMapState would check if any of the selectors have a cloneSelector method, and if so, use that instead of the primary selector.
where you have a selector used by multiple component instances at once you need to change the selector file to account for this by wrapping the selector in a factory function.
Could you show an example of this? I'm not sure what you mean by this.
@jimbol see Sharing Selectors with Props Across Multiple Components.
Hi @brigand, avoiding selector factories is one of the reasons why a published re-reselect.
Re-reselect is a tiny reselect wrapper which implements a cached selector factory keeping the same interface of a normal selector.
This is how re-reselect would handle the "Sharing Selectors with Props Across Multiple Components" case.
Hope it helps to provide a further valuable solution to reselect ecosystem.
|
gharchive/issue
| 2017-05-08T12:06:20 |
2025-04-01T04:35:41.416081
|
{
"authors": [
"brigand",
"jimbol",
"toomuchdesign"
],
"repo": "reactjs/reselect",
"url": "https://github.com/reactjs/reselect/issues/252",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
1784689593
|
🛑 Bellshade Website is down
In 4f386e2, Bellshade Website (https://bellshade.org) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Bellshade Website is back up in 7fbb618.
|
gharchive/issue
| 2023-07-02T15:24:38 |
2025-04-01T04:35:41.418552
|
{
"authors": [
"reacto11mecha"
],
"repo": "reacto11mecha/uptime-status",
"url": "https://github.com/reacto11mecha/uptime-status/issues/353",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
4720394
|
Simple Method to GZIP Response
Right now there doesn't seem to be a simple way to automatically gzip responses and attach the appropriate content-encoding header. Right now you have to do something like this:
$app->get('/', function(React\Http\Request $request, React\Http\Response $response) use (&$i) {
$text = gzencode("A generic response with gzip.\n");
$headers = array('Content-Encoding' => 'gzip',
'Content-Type' => 'text/plain',
'Content-Length' => strlen($text));
$response->writeHead(200, $headers);
$response->end($text);
});
Which works but this gets tedious and I believe its a common enough (and expected) feature that even forcing people to implement an abstraction themselves isn't the best path.
See https://github.com/reactphp/http/issues/48 :+1:
|
gharchive/issue
| 2012-05-23T20:42:07 |
2025-04-01T04:35:41.484378
|
{
"authors": [
"Blackshawk",
"clue"
],
"repo": "reactphp/react",
"url": "https://github.com/reactphp/react/issues/25",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
193251888
|
Fixes rapid opening and closing of modal (Fade component fix) #166
Not sure if this is the entire fix. But this fixed the error related to this issue (https://github.com/facebook/react/issues/5240).
A similar issue fixed in React (https://github.com/facebook/react/pull/5391/files) & MaterialUI (https://github.com/callemall/material-ui/pull/3437) ( source)
Fixes: https://github.com/reactstrap/reactstrap/issues/166
When it will be in master branch?
Thanks @ajainarayanan!
|
gharchive/pull-request
| 2016-12-03T00:45:04 |
2025-04-01T04:35:41.487207
|
{
"authors": [
"ajainarayanan",
"eddywashere",
"intpp"
],
"repo": "reactstrap/reactstrap",
"url": "https://github.com/reactstrap/reactstrap/pull/247",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
481517638
|
popup dialogs, menus are not modal to screen readers
Although aria-modal="true" is used on the dialog itself (well, the div with the dialog role), this is not supported everywhere (for example, VoiceOver on MacOS continues to access the markup content beneath the modal layer). The aria-hidden attribute must not only be applied to the modal, but to the inert content beneath (visually), which is the main React root (structurally), separate from the app's React overlay div dedicated to modals.
https://github.com/readium/readium-desktop/blob/1263712b0ddab6ad43e3c95f45a9ed74c831960d/src/renderer/components/dialog/Dialog.tsx#L53-L54
See "Notes on aria-modal and aria-hidden" in https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
See also: https://developer.paciellogroup.com/blog/2018/06/the-current-state-of-modal-dialog-accessibility/
Also, I am pretty sure display: none should be used instead of CSS visibility: hidden:
https://github.com/readium/readium-desktop/blob/1263712b0ddab6ad43e3c95f45a9ed74c831960d/src/renderer/components/dialog/Dialog.tsx#L57
For popup menus:
https://github.com/readium/readium-desktop/blob/1263712b0ddab6ad43e3c95f45a9ed74c831960d/src/index_app.ejs#L8-L11
https://github.com/readium/readium-desktop/blob/1263712b0ddab6ad43e3c95f45a9ed74c831960d/src/renderer/components/utils/menu/MenuContent.tsx#L27-L61
Fixed via https://github.com/readium/readium-desktop/commit/5a235e99460f162c887c90840473dbc8558f1272
|
gharchive/issue
| 2019-08-16T09:11:26 |
2025-04-01T04:35:41.545196
|
{
"authors": [
"danielweck"
],
"repo": "readium/readium-desktop",
"url": "https://github.com/readium/readium-desktop/issues/605",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
1305117716
|
fix: add alt text option for images
Fix RM-4792
🧰 Changes
PR 1 of 2: the other part to this fix is in this PR in the main readme repo.
Previously, we've been setting images' alt tags using the image caption, but we want to provide the option for users to set distinct alt text for their images.
This PR ensures that if we have alt set, we'll use that for the image's caption. If not, we'll continue to use the caption.
🧬 QA & Testing
I think it will be a bit tricky to test this using PR apps, but if you checkout this branch and also the corresponding branch in the readme repo (editor/fix/add-alt-text-option-for-images), link the two repos and run locally, you'll be able to test.
Here's a screenshot of it working, too. I've inspected the rendered image and you can see the alt text used instead of the caption.
Broken on production.
Working in this PR app.
This PR was released!
🚀 Changes included in v6.46.1
|
gharchive/pull-request
| 2022-07-14T17:56:24 |
2025-04-01T04:35:41.550487
|
{
"authors": [
"ellierossuck",
"rafegoldberg"
],
"repo": "readmeio/markdown",
"url": "https://github.com/readmeio/markdown/pull/535",
"license": "ISC",
"license_type": "permissive",
"license_source": "github-api"
}
|
365180729
|
Error on inline math
There is an exception when processing markdown file containing inline math via Sphinx. The same markdown file previously worked.
Here is a Travis log.
The immediate error message is
Exception occurred:
File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/docutils/parsers/rst/roles.py", line 356, in math_role
text = rawtext.split('`')[1]
IndexError: list index out of range
I can also reproduce on my machine by adding an inline math expression
`$ a $`
to tests/sphinx_custom_md/index.markdown and running python3 -m unittest -q tests.test_sphinx.CustomExtensionTests. Here is the full output
Running Sphinx v1.7.9
making output directory...
loading pickled environment... not yet created
building [mo]: all of 0 po files
building [html]: all source files
updating environment: 1 added, 0 changed, 0 removed
reading sources... [100%] index
/usr/local/lib/python3.5/dist-packages/docutils/io.py:245: DeprecationWarning: 'U' mode is deprecated
self.source = open(source_path, mode, **kwargs)
======================================================================
ERROR: test_integration (tests.test_sphinx.CustomExtensionTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/code/recommonmark/tests/test_sphinx.py", line 66, in test_integration
['</table>']
File "/code/recommonmark/tests/test_sphinx.py", line 23, in _run_test
app.build(force_all=True)
File "/usr/local/lib/python3.5/dist-packages/sphinx/application.py", line 325, in build
self.builder.build_all()
File "/usr/local/lib/python3.5/dist-packages/sphinx/builders/__init__.py", line 299, in build_all
self.build(None, summary='all source files', method='all')
File "/usr/local/lib/python3.5/dist-packages/sphinx/builders/__init__.py", line 355, in build
updated_docnames = set(self.env.update(self.config, self.srcdir, self.doctreedir))
File "/usr/local/lib/python3.5/dist-packages/sphinx/environment/__init__.py", line 568, in update
self._read_serial(docnames, self.app)
File "/usr/local/lib/python3.5/dist-packages/sphinx/environment/__init__.py", line 587, in _read_serial
self.read_doc(docname, app)
File "/usr/local/lib/python3.5/dist-packages/sphinx/environment/__init__.py", line 662, in read_doc
doctree = read_doc(self.app, self, self.doc2path(docname))
File "/usr/local/lib/python3.5/dist-packages/sphinx/io.py", line 302, in read_doc
pub.publish()
File "/usr/local/lib/python3.5/dist-packages/docutils/core.py", line 218, in publish
self.apply_transforms()
File "/usr/local/lib/python3.5/dist-packages/docutils/core.py", line 199, in apply_transforms
self.document.transformer.apply_transforms()
File "/usr/local/lib/python3.5/dist-packages/sphinx/transforms/__init__.py", line 96, in apply_transforms
Transformer.apply_transforms(self)
File "/usr/local/lib/python3.5/dist-packages/docutils/transforms/__init__.py", line 171, in apply_transforms
transform.apply(**kwargs)
File "/code/recommonmark/recommonmark/transform.py", line 343, in apply
self.traverse(self.document)
File "/code/recommonmark/recommonmark/transform.py", line 313, in traverse
self.traverse(child)
File "/code/recommonmark/recommonmark/transform.py", line 313, in traverse
self.traverse(child)
File "/code/recommonmark/recommonmark/transform.py", line 303, in traverse
newnode = self.find_replace(c)
File "/code/recommonmark/recommonmark/transform.py", line 287, in find_replace
newnode = self.auto_inline_code(node)
File "/code/recommonmark/recommonmark/transform.py", line 214, in auto_inline_code
return self.state_machine.run_role('math', content=content)
File "/code/recommonmark/recommonmark/states.py", line 134, in run_role
content=content)
File "/usr/local/lib/python3.5/dist-packages/docutils/parsers/rst/roles.py", line 356, in math_role
text = rawtext.split('`')[1]
IndexError: list index out of range
Here is a Travis log from a few weeks ago where the same file is processed successfully. Unfortunately I can't tell what the relevant difference is. (Some version numbers have changed, but installing the older Sphinx on my own machine, for example, does not remove the problem.)
This caught me out too. Sphinx needs to have a math extension enabled.
I think this might actually be a minor bug in docutils as if you work around it there is a useful warning message.
WARNING: using "math" markup without a Sphinx math extension active, please use one of the math extensions descri bed at http://sphinx-doc.org/en/master/ext/math.html
Any more details on how to fix it? I did a PR that hacked it, but it would be useful if it's just a conf.py change. I see it's a Sphinx 1.8 issue.
I'm still getting the error on Sphinx 1.8.
In sphinx 1.7 it uses Sphinx's math role:
ipdb> inspect.getfile(role_fn)
'/Users/eric/.pyenv/versions/3.6.6/lib/python3.6/site-packages/sphinx/ext/mathbase.py'
In Sphinx 1.8 it uses the docutils one, which is where this error comes from:
ipdb> inspect.getfile(role_fn)
'/Users/eric/.pyenv/versions/3.6.6/lib/python3.6/site-packages/docutils/parsers/rst/roles.py'
Thanks @Anntoin, that explains why my modified unit test failed with all versions. However, the repo whose Travis log I linked already has sphinx.ext.mathjax.
Thanks @ericholscher, and sorry if I opened this in the wrong project. I now see the same thing as you: Sphinx 1.7.9: no error. Sphinx 1.8.0: error.
Can confirm the workaround to use Sphinx 1.7:
pip install sphinx==1.7
how do I force 1.7 on readthedocs?
the problem is that it runs:
conda install --yes --quiet --name latest mock pillow sphinx sphinx_rtd_theme
after installing the custom user environment and that forces sphinx to upgrade.
I even tried to install mock pillow sphinx=1.7 sphinx_rtd_theme in my user environment but still the command above upgrades to 1.8.
Encounter the same problem. sphinx version 2.0.1.
But OK with 1.7.9.
I'm also using 1.7.9, along with these dependencies (inside a Flask Application)
root@ac0b60dc58c3:/src/app# pip freeze | grep -iwE '(sphinx|recommonmark|docutils|websupport)'
docutils==0.14
recommonmark==0.5.0
Sphinx==1.7.9
sphinx-rtd-theme==0.4.3
sphinxcontrib-websupport==1.1.2 # adds WebSupport
And I'm running into this error
root@4e00e44b18a6:/src/app# python build_docs.py
Running Sphinx v1.7.9
loading translations [es]... done
loading pickled environment... not yet created
building [mo]: targets for 0 po files that are out of date
building [websupport]: targets for 9 source files that are out of date
updating environment: 9 added, 0 changed, 0 removed
/src/venv/lib/python3.6/site-packages/recommonmark/parser.py:65: UserWarning: Container node skipped: type=document
warn("Container node skipped: type={0}".format(mdnode.t))
Traceback (most recent call last):rs/ise
File "build_docs.py", line 27, in <module>
build_docs()
File "build_docs.py", line 23, in build_docs
support.build()
File "/src/venv/lib/python3.6/site-packages/sphinxcontrib/websupport/core.py", line 146, in build
app.build()
File "/src/venv/lib/python3.6/site-packages/sphinx/application.py", line 331, in build
self.builder.build_update()
File "/src/venv/lib/python3.6/site-packages/sphinx/builders/__init__.py", line 342, in build_update
'out of date' % len(to_build))
File "/src/venv/lib/python3.6/site-packages/sphinx/builders/__init__.py", line 355, in build
updated_docnames = set(self.env.update(self.config, self.srcdir, self.doctreedir))
File "/src/venv/lib/python3.6/site-packages/sphinx/environment/__init__.py", line 568, in update
self._read_serial(docnames, self.app)
File "/src/venv/lib/python3.6/site-packages/sphinx/environment/__init__.py", line 587, in _read_serial
self.read_doc(docname, app)
File "/src/venv/lib/python3.6/site-packages/sphinx/environment/__init__.py", line 662, in read_doc
doctree = read_doc(self.app, self, self.doc2path(docname))
File "/src/venv/lib/python3.6/site-packages/sphinx/io.py", line 302, in read_doc
pub.publish()
File "/src/venv/lib/python3.6/site-packages/docutils/core.py", line 218, in publish
self.apply_transforms()
File "/src/venv/lib/python3.6/site-packages/docutils/core.py", line 199, in apply_transforms
self.document.transformer.apply_transforms()
File "/src/venv/lib/python3.6/site-packages/sphinx/transforms/__init__.py", line 96, in apply_transforms
Transformer.apply_transforms(self)
File "/src/venv/lib/python3.6/site-packages/docutils/transforms/__init__.py", line 171, in apply_transforms
transform.apply(**kwargs)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 328, in apply
self.traverse(self.document)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 308, in traverse
self.traverse(child)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 308, in traverse
self.traverse(child)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 308, in traverse
self.traverse(child)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 298, in traverse
newnode = self.find_replace(c)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 282, in find_replace
newnode = self.auto_inline_code(node)
File "/src/venv/lib/python3.6/site-packages/recommonmark/transform.py", line 211, in auto_inline_code
return self.state_machine.run_role('math', content=content)
File "/src/venv/lib/python3.6/site-packages/recommonmark/states.py", line 133, in run_role
content=content)
File "/src/venv/lib/python3.6/site-packages/docutils/parsers/rst/roles.py", line 356, in math_role
text = rawtext.split('`')[1]
IndexError: list index out of range
While trying to debug this, I found out that if I downgrade sphinxcontribwebsupport to 1.1.0 the error dissapears.
Hope this helps someone.
It seems that there are multiple pull requests for this fix but none of them is merged.
There are simple workaround $` abc `$
Encounter the same problem. sphinx version 2.0.1.
Encounter the same problem. sphinx version 2.0.1.
But OK with 1.7.9.
try sphinx 1.7.9 or 1.6.9, failed
I encounter this issue as well with sphinx 3.2.1
|
gharchive/issue
| 2018-09-30T01:13:00 |
2025-04-01T04:35:41.573085
|
{
"authors": [
"Anntoin",
"CodingCattwo",
"Dylan-JW",
"ambiso",
"diegoquintanav",
"ericholscher",
"htleeab",
"leokoppel",
"talengu",
"zonca"
],
"repo": "readthedocs/recommonmark",
"url": "https://github.com/readthedocs/recommonmark/issues/120",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
442180649
|
Open a 0.4.x release tracking branch and start work on 0.5 in master branch
Problem
I have a suggestion...
Because there are lots of unmerged, stale PRs targeted for a future milestone 0.5 which hasn't started its life-cycle: It would be easier for maintainers to keep working on the 0.4.x series for bug fixing in a separate branch, suggesting releases/0.4.x as the branch.
PyPi supports releasing old version numbers, e.g. a 0.4.4 release, even though 0.5 is out. In the beginning stages, you can also release for instance 0.5a1 and people can install it with pip install sphinx_rtd_theme --pre.
Also, there's a bit of cleanup for other bug/feature branches in this main repo that would help the overview :)
Reproducible Project
n/a
Error Logs/Results
n/a
Expected Results
n/a
Environment Info
n/a
I don't think we're going to jump on any changes to our branching pattern, but we are aiming to release more often to pypi under alpha releases. Some big changes are going through, so this won't be immediate, but we're moving to streamline things a bit in #379. Feel free to follow along there.
|
gharchive/issue
| 2019-05-09T11:07:28 |
2025-04-01T04:35:41.577743
|
{
"authors": [
"agjohnson",
"benjaoming"
],
"repo": "readthedocs/sphinx_rtd_theme",
"url": "https://github.com/readthedocs/sphinx_rtd_theme/issues/759",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
285593430
|
XML parsing: illegal xml character
SQL Server 2016 Express
Msg 9420, Level 16, State 1, Procedure sp_generate_merge, Line 540 [Batch Start Line 0] XML parsing: line 1, character 210, illegal xml character
Unable to reproduce
I also get this error now. One of my columns contains this data
ਨਲ
<
dn
xyz{
|}
xyz
GHIJ
KL
GHI
ྠ
2
°
®¯
ª
ÈÒÜæ
ðú
ÈÒÜ
¾¿ÀÁ
Ä
ÂÃ
¾¿À
]
^
Z[
!
"
q
r
n
´µ¶·
º
¸¹
´µ¶
Ĭ
翿
QRST
UV
Q
£
¥
¤
¡¢
ஸ
()*+
It looks like it's this line ' !' causing the problem
|
gharchive/issue
| 2018-01-03T03:45:40 |
2025-04-01T04:35:41.594001
|
{
"authors": [
"TDK1964",
"baur",
"readyroll"
],
"repo": "readyroll/generate-sql-merge",
"url": "https://github.com/readyroll/generate-sql-merge/issues/28",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2525894820
|
#18 Rust organizer new design
https://github.com/readytotouch/readytotouch/issues/18
PRs:
[ ] https://github.com/readytotouch/readytotouch/pull/22
[ ] https://github.com/readytotouch/readytotouch/pull/24
Companies
Mozilla https://app.otta.com/jobs/x1nUGqRw
|
gharchive/pull-request
| 2024-09-14T00:33:06 |
2025-04-01T04:35:41.596776
|
{
"authors": [
"YaroslavPodorvanov"
],
"repo": "readytotouch/readytotouch",
"url": "https://github.com/readytotouch/readytotouch/pull/24",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
602263753
|
examples: modal with form
Add an example using a form in a modal.
It will increase the list of examples related to #626
@diegohaz Does it fit? 🤓
Sure! I will merge all your suggestions, rebase master and add 2 or 3 examples, in addition. Thanks for your feedback!
Nice! You can add one example per PR. It'll be easier to review.
|
gharchive/pull-request
| 2020-04-17T22:19:12 |
2025-04-01T04:35:41.601643
|
{
"authors": [
"diegohaz",
"frassinier"
],
"repo": "reakit/reakit",
"url": "https://github.com/reakit/reakit/pull/627",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.