id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
2378974306 | Add a new field subnets for machine pool
They can span across more than one subnet for multi-az cluster. This way it's backwards compatible until we are ready to migrate to this new field.
So this will not be useful as we remove the default machine pool which creates nodes in all subnets then create one machine pool designated for each AZ/subnet, and there is no way to provide more than one subnet ids when creating a machine pool through ROSA CLI and OCM API.
| gharchive/pull-request | 2024-06-27T19:48:36 | 2025-04-01T06:37:55.511625 | {
"authors": [
"OliviaHY"
],
"repo": "app-sre/qontract-schemas",
"url": "https://github.com/app-sre/qontract-schemas/pull/682",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
287560137 | React-Native: Add Documentation
[x] We need to create a version switcher for React Native. Using a different repo
[x] Getting Started Section
[x] Install and Quickstart
[x] Import Data
[x] ReactiveBase
[x] Components Overview
[x] Component References
One doc per component
[x] Advanced
[x] Add a snack snippet for the ReactiveComponent doc.
[x] Performance Tips @metagrover
[x] Creating Themes, Styles Unsupported in current version
[ ] Link innerStyle to all the components
[ ] Link innerProps to all the components
[ ] Update theme prop for ReactiveBase.
[ ] Add a doc on how to publish the app - With expo and as an ejected app.
| gharchive/issue | 2018-01-10T20:04:23 | 2025-04-01T06:37:55.516144 | {
"authors": [
"siddharthlatest"
],
"repo": "appbaseio/reactive-manual",
"url": "https://github.com/appbaseio/reactive-manual/issues/65",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
126885249 | New Zoom/Pinch implementation
After working with the zoom and pinch functionalities I made in my last PR we (myself and a colleague) came across some inconsistencies.
We figured that iOS and Android use very different approaches to these gestures, so we worked on a new implementation for these that works much more consistent.
do you want to take out the generic approach all together?
Well, the problem is that the Appium server needs different parameters for the different platforms. So the only alternative to this approach would be to define an interface with all of those parameters. But this way one implementation would just ignore a half of these parameters and the other implementation would ignore the other half. And I think this doesn't really add anything useful to the code.
Was there something wrong with the multi touch way of doing things instead
of running the script directly?
On Fri, Jan 15, 2016 at 1:30 PM, trbnb notifications@github.com wrote:
Well, the problem is that the Appium server needs different parameters for
the different platforms. So the only alternative to this approach would be
to define an interface with all of those parameters. But this way one
implementation would just ignore a half of these parameters and the
other implementation would ignore the other half. And I think this
doesn't really add anything useful to the code.
—
Reply to this email directly or view it on GitHub
https://github.com/appium/appium-dotnet-driver/pull/132#issuecomment-172097985
.
Yes, after observing it a bit we found it to be quite unreliable. Especially on iOS we sometimes struggled to make it work.
I'll review this. I've some remark...
Sorry for the late responce, I was busy
I have a a question to @Jonahss. Let him to take a look at your implementation. I have some question to the original code... If it is correct then it makes sense to port your code to Java client.
I'm not really sure how because the gestures don't change the size the view or something like this, just how the content is presented and I don't think that's something we can retrieve with Appium.
Any news on this?
Waiting for @Jonahss (I've told about this PR) because I think that this change could be ported to Java client too.
As I know current gestures were ported from Java client. I dont know why original code was designed the way as it is now. But it is most likely I'm Ok with your changes.
Ok, good to know.
And yes, these gestures were initially ported from the Java client, I made the pull request for that a few weeks/months ago.
@trbnb
i'm ok with your changes.
There are tons of work with appium node 1.5.x. I'm working on java client now. You fix is supposed to be included in 1.6.0.1. There will be many fixes related to node 1.5.x.
Alright, thanks for letting me know.
Just for your information. We (trbnb and myself) ported the new pinch and zoom behavior from the python appium driver. More information can be found here:
https://github.com/appium/python-client/blob/master/appium/webdriver/webdriver.py
Be careful. They are calling pinch and zoom in the code a little bit different. It is internally called pinchClose and pinchOpen. But it does the same.
It is a good idea to port our PR to the java bindings too. Pinch and Zoom is broken there too. We initialy ported the pinch and zoom command from the java bindings to the dotnet bindings without testing if it worked in the Java bindings. Seems that it did not work under iOS at all. So thats the reason we did it again. This time we ported it from the python bindings. And now it should work on Android and iOS.
Guys,
I'm going to play around with proposed changes. I think I'll propose a PR with your authorship if everything is ok.
However, I'm not sure that it is compatible with node server 1.5.x
Sorry.
I need to close it without merging. This functionality is not supported since Appium 1.5.0
https://github.com/appium/appium/blob/master/CHANGELOG.md#general-3
Server is throwing this exception now.
Method has not yet been implemented (WARNING: The server did not provide any stacktrace information)
See also:
https://github.com/appium/appium/issues/2234
Can we add docs for the new way of performing pinch and zoom?
@Jonahss It has to work the same way.
I and @ShrivanTarget are searching for something instead.
| gharchive/pull-request | 2016-01-15T14:41:48 | 2025-04-01T06:37:55.571091 | {
"authors": [
"Astro03",
"BaN4NaJ0e",
"Jonahss",
"TikhomirovSergey",
"trbnb"
],
"repo": "appium/appium-dotnet-driver",
"url": "https://github.com/appium/appium-dotnet-driver/pull/132",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
2630428568 | Warning for Documentation.docc: found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
Building a swift package that has swift-algorithms as dependency outputs warning in the terminal
Swift Algorithms version: 1.2.0
Swift version:
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-6.0.0.9.10 clang-1600.0.26.2)
Target: arm64-apple-macosx15.0
Checklist
[ ] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues
I see this issue is closed https://github.com/apple/swift-algorithms/pull/237 but I don't see the exclude argument in the main branch as suggested in that issue.
Steps to Reproduce
Build the Hummingbird template project https://github.com/hummingbird-project/template
Expected behavior
No warning for package documentation
Actual behavior
warning: 'swift-algorithms': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
/Users/atacan/Developer/Repositories/speech-router-hb/.build/checkouts/swift-algorithms/Sources/Algorithms/Documentation.docc
Just chiming in to say I also get this on everyone of my builds and was about to file an issue 😛
| gharchive/issue | 2024-11-02T12:21:39 | 2025-04-01T06:37:55.913634 | {
"authors": [
"atacan",
"dimitribouniol"
],
"repo": "apple/swift-algorithms",
"url": "https://github.com/apple/swift-algorithms/issues/245",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1391672037 | [OrderedSet] Tiny doc fixes for isSuperset.
OrderedSet's documentation mistakenly refers to the subset relation when explaining what isSuperset is doing.
Checklist
[X] I've read the Contribution Guidelines
[X] My contributions are licensed under the Swift license.
[X] I've followed the coding style of the rest of the project.
[ ] I've added tests covering all new code paths my change adds to the project (if appropriate).
[ ] I've added benchmarks covering new functionality (if appropriate).
[X] I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
[X] I've updated the documentation if necessary.
@swift-ci test
| gharchive/pull-request | 2022-09-30T00:59:07 | 2025-04-01T06:37:55.916823 | {
"authors": [
"lorentey"
],
"repo": "apple/swift-collections",
"url": "https://github.com/apple/swift-collections/pull/189",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
507500430 | [Windows] Search for Dlls in Bundles Properly
On Windows, dlls don't begin with "lib" so the tests should be searching
for "MyDLL.dll", not "libMyDLL.dll"
@swift-ci please test and merge
| gharchive/pull-request | 2019-10-15T21:48:08 | 2025-04-01T06:37:55.917924 | {
"authors": [
"gmittert"
],
"repo": "apple/swift-corelibs-foundation",
"url": "https://github.com/apple/swift-corelibs-foundation/pull/2538",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
536751915 | SR-11926: [FileHandle] Ensure the Darwin compatibility of Access Control of new methods.
From Swift 5.0, new APIs of FileHandle are introduced.
While they are defined as open in DarwinFoundation (as you know they are imported from objc), they are public in SwiftFoundation.
They should be defined as open also in SwiftFoundation to ensure compatibility (for example, making subclasses of FileHandle in other modules).
Resolves SR-11926.
Note that at least some of these changes are incorrect. e.g.: write(contentsOf:) is public, not open, on Darwin.
It seems to come to a conclusion.
Unfortunately, I'm going to close this PR.
| gharchive/pull-request | 2019-12-12T04:35:29 | 2025-04-01T06:37:55.920865 | {
"authors": [
"YOCKOW",
"millenomi"
],
"repo": "apple/swift-corelibs-foundation",
"url": "https://github.com/apple/swift-corelibs-foundation/pull/2585",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2021609510 | [Caching] Fix incremental cache build with bridging header
When planning a caching build with bridging header, the consumer of the pre-compiled bridging header needs to know the cache key for the bridging header in order to construct the correct build command, which requires visibility to the job that creates PCH.
Fix the incremental planning for bridging header users so those job can be correctly constructed even the bridging header job is skipped for the incremental build.
rdar://118143215
@swift-ci please test
| gharchive/pull-request | 2023-12-01T21:30:50 | 2025-04-01T06:37:55.922384 | {
"authors": [
"cachemeifyoucan"
],
"repo": "apple/swift-driver",
"url": "https://github.com/apple/swift-driver/pull/1498",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
369943413 | Improve libswiftReflection Linking on Linux
Using CMAKE_SYSTEM_PROCESSOR is a good first step, but for platforms where it maps to something different (say, armv7l to armv7), then you need more complete logic. Ideally, we would want Swift itself to tell us what to link against, but this change is still an improvement, although it is blatantly reusing similar logic from Swift's cmake scripts.
This is definitely better.
@swift-ci test and merge
| gharchive/pull-request | 2018-10-14T21:03:57 | 2025-04-01T06:37:55.923715 | {
"authors": [
"Kaiede",
"dcci"
],
"repo": "apple/swift-lldb",
"url": "https://github.com/apple/swift-lldb/pull/971",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
575428250 | fix macOS build & cleanup Thread
Motivation:
The macOS build was broken by #1424, also the Thread.swift file became
a bit of a mess with #if os(...)/#else everywhere.
Modifications:
fix macOS build
cleanup Thread by splitting it into ThreadPosix & ThreadWindows
Result:
build working again
cleaner code
@swift-nio-bot test this please
| gharchive/pull-request | 2020-03-04T14:06:14 | 2025-04-01T06:37:55.925843 | {
"authors": [
"weissi"
],
"repo": "apple/swift-nio",
"url": "https://github.com/apple/swift-nio/pull/1433",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
417902005 | ByteBuffer.viewBytes now returns an Optional
Motivation:
ByteBuffer.viewBytes would unconditionally return a ByteBufferView even
if the requested bytes were not readable.
Modifications:
make it return an Optional<ByteBufferView>
Result:
safer, better APIs
fixed #877
@swift-nio-bot test this please
| gharchive/pull-request | 2019-03-06T16:41:22 | 2025-04-01T06:37:55.927768 | {
"authors": [
"weissi"
],
"repo": "apple/swift-nio",
"url": "https://github.com/apple/swift-nio/pull/878",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1768335992 | Emit a descriptive error when running the generator on iOS, tvOS, or watchOS
The _OpenAPIGeneratorCore library and swift-openapi-generator executable are mostly an implementation detail of the OpenAPIGenerator plugin, all vended by the swift-openapi-generator package.
The generator runs at build time to generate code, but the _OpenAPIGeneratorCore library shouldn't actually be linked by adopters's target, which is documented correctly here (Step 7 of https://swiftpackageindex.com/apple/swift-openapi-generator/0.1.3/tutorials/swift-openapi-generator/clientxcode#Configuring-your-target-to-use-the-Swift-OpenAPI-Generator-plugin), but it's also easy to get it wrong and link it when adding the package in Xcode.
We should make it so that a clear, descriptive error is emitted when someone links the generator module itself to a non-macOS/Linux target.
One example question on the developer forums: https://developer.apple.com/forums/thread/732178
| gharchive/issue | 2023-06-21T19:28:56 | 2025-04-01T06:37:55.930976 | {
"authors": [
"czechboy0"
],
"repo": "apple/swift-openapi-generator",
"url": "https://github.com/apple/swift-openapi-generator/issues/86",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2034184238 | Tests Fail to link on Windows when macros are present, jeopardizing Swift's cross-platform support.
Description
Tests fail to link on Windows using swift 5.9.1-RELEASE when macros are present.
This is a trivial repo that reproduces the issue:
https://github.com/lynchsft/swift-windows-macro-testing
The locus of this problem is on Windows platform, but I conclude that it indirectly negatively affects the entire Swift community. As macros proliferate through common libraries, all swift-on-windows tools will either have to abandon testing or wholly abandon windows as a platform. Neither of these outcomes speaks well of the "swift is a cross platform language" story.
Particularly, I'm asserting that this is a rapidly worsening problem because library authors that don't usually concern themselves with Windows are eagerly adopting macros feature. Soon, the libraries that Windows projects currently rely on will be un-ingestiable, effectively locking our dependences at the last-macro-free version.
This in turn, is a security problem as code-currency (up-to-date dependencies) are a crucial topic for averting and responding to security threats.
@neonichu, @MaxDesiatov During construction of that ^^ trivial reproduction repo, I actually encountered a success case, where I WAS able to ingest a macro and use it on Windows. The linker error did not arise.
Including this state in case its a useful resource to have.
Branch: success_case
Repo: https://github.com/lynchsft/swift-windows-macro-testing
Expected behavior
The tests should link and run properly.
Actual behavior
The tests fail to link (compilation succeeds):
Building for debugging...
lld-link: error: duplicate symbol: main
>>> defined at C:\Users\lynchsft\swift-windows-macro-testing\.build\x86_64-unknown-windows-msvc\debug\PowerAssertPlugin.build\PowerAssertPlugin.swift.o
>>> defined at C:\Users\lynchsft\swift-windows-macro-testing\.build\x86_64-unknown-windows-msvc\debug\SwiftWindowsPackageTestingPackageTests.build\runner.swift.o
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[238/239] Linking C:\Users\lynchsft\swift-windows-macro-testing\.build\x86_64-unknown-windows-msvc\debug\SwiftWindowsPackageTestingPackageTests.xctest
error: fatalError
Steps to reproduce
swift --test
Swift Package Manager version/commit hash
5.9.1-RELEASE
Swift & OS version (output of swift --version ; uname -a)
Swift version 5.9.1 (swift-5.9.1-RELEASE)
Target: x86_64-unknown-windows-msvc
MSYS_NT-10.0-22631 lynchal-z01 3.4.6.x86_64 2023-05-18 20:39 UTC x86_64 Msys
Is this reproducible for you with latest development snapshots? (at the moment of writing it's https://download.swift.org/development/windows10/swift-DEVELOPMENT-SNAPSHOT-2023-11-27-a/swift-DEVELOPMENT-SNAPSHOT-2023-11-27-a-windows10.exe)
It is reproducible with the latest snapshot:
> swift --version
Swift version 5.11-dev (LLVM d50917983d84235, Swift 3f06b5efd0ebcfb)
Target: x86_64-unknown-windows-msvc
I have a slightly different example though:
https://github.com/tishin/MacroTestIssue
It has two targets - an empty macro implementation target with a @main attribute (which I believe causes this issue)
import SwiftCompilerPlugin
import SwiftSyntaxMacros
@main
struct MyMacroPlugin: CompilerPlugin {
let providingMacros: [Macro.Type] = [
]
}
And a trivial test target:
import XCTest
final class MyMacroTests: XCTestCase {
func testMacro() throws {
XCTAssertTrue(true)
}
}
Running swift test -v using the latest snapshot (as well as 5.9.2 release) fails with the duplication error:
lld-link: error: duplicate symbol: main
>>> defined at C:\Projects\MacroTestIssue\.build\x86_64-unknown-windows-msvc\debug\MyMacroMacros.build\MyMacroMacro.swift.o
>>> defined at C:\Projects\MacroTestIssue\.build\x86_64-unknown-windows-msvc\debug\MyMacroPackageTests.build\runner.swift.o
Thank you @tishin .
@MaxDesiatov, @neonichu Are you able to provide a read on the situation? Have I concluded wrongly that as time goes on this bug will strand Windows projects in the past?
| gharchive/issue | 2023-12-10T01:57:09 | 2025-04-01T06:37:55.939878 | {
"authors": [
"MaxDesiatov",
"lynchsft",
"tishin"
],
"repo": "apple/swift-package-manager",
"url": "https://github.com/apple/swift-package-manager/issues/7174",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
353957402 | [Workspace] Use topological sort when creating DependencyManifests
rdar://problem/43700179 isResolutionRequired is non-deterministic when a graph contains both revision and version based dependency requirements
Need to write a test for this
@swift-ci smoke test
| gharchive/pull-request | 2018-08-24T23:28:13 | 2025-04-01T06:37:55.941585 | {
"authors": [
"aciidb0mb3r"
],
"repo": "apple/swift-package-manager",
"url": "https://github.com/apple/swift-package-manager/pull/1760",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
138856224 | [bootstrap] Remove deprecated "--build-tests"
The "--build-tests" option is marked "deprecated" in the SwiftPM bootstrap script and is no longer used by the script. It is also no longer used by any systems calling the bootstrap script; its only usage in the Swift build script has been removed in https://github.com/apple/swift/pull/1547.
Remove the option to reduce confusion.
This is trivial and safe change so I'm going to merge it.
I've tested that ./Utilities/bootstrap test works as expected both on MacOS and Linux and we don't need "--build-tests"
Thanks, @kostiakoval! :bow:
| gharchive/pull-request | 2016-03-07T00:51:41 | 2025-04-01T06:37:55.943883 | {
"authors": [
"kostiakoval",
"modocache"
],
"repo": "apple/swift-package-manager",
"url": "https://github.com/apple/swift-package-manager/pull/178",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
548323051 | Binary targets workspace implementation
This implements the download and unarchiving implementation of the binary targets proposal.
I have several diagnostics in the PR reported using the emit(error: "description of error") instead of emit(.errorName(arguments)). I thought the second form was preferred, but I also saw a few instances of the first form using in Workspace. @aciidb0mb3r what do you think?
@hartbit The string variant is ok for one-off cases where we don't need to emit the same error from somewhere else but emit(.errorName(arguments)) is probably better/preferable.
@swift-ci smoke test self hosted
@swift-ci smoke test
| gharchive/pull-request | 2020-01-10T22:33:41 | 2025-04-01T06:37:55.946453 | {
"authors": [
"aciidb0mb3r",
"hartbit"
],
"repo": "apple/swift-package-manager",
"url": "https://github.com/apple/swift-package-manager/pull/2511",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1720788610 | Parser should emit a single diagnostic if both open and close quote are missing from string literal
Issue Kind
Bad Diagnostic Produced
Source Code
@_expose(Cxx, baz) func foo() {}
Description
From https://github.com/apple/swift-syntax/pull/1688/files#r1201105564
In the above example the parser produces two diagnostics: One for the missing opening " before baz and one for the missing closing " after baz. It should emit a single diagnostic instead that offers to add both.
Tracked in Apple’s issue tracker as rdar://109685043
Go for it @TTOzzi 🙌
Thank you! 😉
| gharchive/issue | 2023-05-22T23:16:23 | 2025-04-01T06:37:55.949352 | {
"authors": [
"TTOzzi",
"ahoppen",
"kimdv"
],
"repo": "apple/swift-syntax",
"url": "https://github.com/apple/swift-syntax/issues/1691",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
2439854085 | Complete WebAssembly/WASI Support
Motivation:
Trying to support WebAssembly/WASI before shipping swift-testing as a part of toolchain
Modifications:
Thanks to prior WASI compatibility efforts by @grynspan, most of the parts work as is now. Here are a few items I changed:
Remove SWT_NO_FILE_IO definition since wasi-libc provides all IO functionalities we need
Stop including signal.h
Fix metadata accessor function pointer representation on WASI to use absolute pointer instead of relative pointer
Define primitive lock type as Void for WASI
It's not the optimal representation but I couldn't find a better way 😓
Result:
Tested with DEVELOPMENT-SNAPSHOT-2024-07-15-a toolchain
$ swift sdk install https://github.com/swiftwasm/swift/releases/download/swift-wasm-DEVELOPMENT-SNAPSHOT-2024-07-16-a/swift-wasm-DEVELOPMENT-SNAPSHOT-2024-07-16-a-wasm32-unknown-wasi.artifactbundle.zip
$ swift package init --name Hello --enable-experimental-swift-testing
# Replace swit-testing dependency entry in Package.swift with:
# .package(url: "https://github.com/kateinoigakukun/swift-testing.git", branch: "yt/wasi-support"),
$ swift build --swift-sdk DEVELOPMENT-SNAPSHOT-2024-07-16-a-wasm32-unknown-wasi --build-tests --enable-experimental-swift-testing
$ wasmkit-cli run --dir . ./.build/debug/HelloPackageTests.wasm
◇ Test run started.
↳ Testing Library Version: 3702b3a53779ccca0f8205b7a76a6f5038197120
◇ Test example() started.
✔ Test example() passed after 0.041244319 seconds.
✔ Test run with 1 test passed after 0.081816901 seconds.
Checklist:
[x] Code and documentation should follow the style of the Style Guide.
[x] If public symbols are renamed or modified, DocC references should be updated.
@swift-ci test
Thanks for taking a look at all this! We really appreciate it. :)
@swift-ci test
One other thing! Can you modify the project readme to include this line in the supported OS table? 😁
| **Wasm** | | | Experimental |
@swift-ci please test
Ready to merge when you are.
⛵
| gharchive/pull-request | 2024-07-31T11:49:13 | 2025-04-01T06:37:55.954955 | {
"authors": [
"grynspan",
"kateinoigakukun"
],
"repo": "apple/swift-testing",
"url": "https://github.com/apple/swift-testing/pull/584",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
257179226 | Move build-script apply default arguments into separate module
Purpose
This PR moves the apply_default_arguments logic out of the main build-script code into the driver_arguments module in order to better stage for #11872 and eventually #11880. The diff will show that the move was not strictly a copy-paste, the chunk for determining if ninja ought be built requires the toolchain information which only exists in the BuildScriptInvocation class. I've opted instead to single out that single case and keep it where it was, everything else was moved verbatim.
rdar://problem/34336890
@swift-ci please smoke test
@swift-ci please smoke test
@swift-ci please smoke test
As soon as the builds for this branch pass I'll merge it, then onwards to #11872!
This broke the build-script on my machine. It can no longer find ninja in /usr/local/bin. What do you need to help debug this?
@davezarzycki I've made a PR to address the issue #11919. I'll have it merged tonight or in the morning, Sorry for the inconvenience.
Can you unsubscribe me from this email service cause I don’t want any
emails from git hub
On Thu, Sep 14, 2017 at 11:32 AM Ross Bayer notifications@github.com
wrote:
@davezarzycki https://github.com/davezarzycki I've made a PR to address
the issue #11919 https://github.com/apple/swift/pull/11919. I'll have
it merged tonight or in the morning, Sorry for the inconvenience.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apple/swift/pull/11882#issuecomment-329382112, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ86b_vQseMcea4728BLdWX66v9Jcs63ks5siMF0gaJpZM4PVPK6
.
@tishansteve You can change your email preferences in your Github account settings. I can't do anything about it.
| gharchive/pull-request | 2017-09-12T20:55:57 | 2025-04-01T06:37:55.961958 | {
"authors": [
"Rostepher",
"davezarzycki",
"tishansteve"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/11882",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
290191466 | Add useSnakeCasedKeys to JSONDecoder.KeyDecodingStrategy
Adds JSONDecoder.KeyDecodingStrategy.useSnakeCasedKeys.
This will make following code works.
import Foundation
struct S: Codable {
var myURLProperty: String
}
let encoder = JSONEncoder()
encoder.keyEncodingStrategy = .convertToSnakeCase
let data = try encoder.encode(S(myURLProperty: "property"))
let decoder = JSONDecoder()
decoder.keyDecodingStrategy = .useSnakeCasedKeys
let decoded = try decoder.decode(S.self, from: data)
/cc: @itaiferber
Resolves SR-6629.
@itaiferber For what's its worth, I tried using convertToSnakeCase/convertFromSnakeCase for the first time today and was really surprised that the behaviour was not what @norio-nomura is proposing. Converting the CodingKeys to snake_case instead of converting the JSON keys to camelCase seems like the only solution to avoid all those round-trip errors.
@hartbit @norio-nomura I forgot to update this PR (and the SR) with some additional discussion and notes for thought. Even if we decide to special-case convertToSnakeCase and convertFromSnakeCase here and perform the conversions in the "favorable" direction, there are still other cases which can't necessarily be fixed.
Consider KeyedDecodingContainer<Key>.allKeys, which maps the contents of what is in the payload to a list of Keys. This is done by iterating the keys in the payload and creating a Key with the value of every found key via CodingKey.init?(stringValue:).
Right now, we do this by having two conversions — Key-to-String (Key.stringValue → case conversion) and String-to-Key (case conversion → Key.init?(stringValue:)). If we "fix" the issue by only using Key-to-String conversions as suggested, there's no real way to map from something already in the payload to a Key. One way to do this could be to require all CodingKeys to be CaseIterable and on every request for allKeys, take Key, iterate every case, converts every key to a string, applies the case conversion, and then iterate all of the keys in the payload and try to look them up in the converted table. This is both expensive, and not necessarily possible as not all CodingKeys can be CaseIterable (think _DictionaryCodingKey and other dynamic keys).
We could decide to "fix" this but still leave allKeys as-is, but this is still bad because you can't rely on iterating through allKeys to really know what's in the payload.
And at that, this is a special case for convertToSnakeCase/convertFromSnakeCase; we could not apply this to strategies which are even more lossy (e.g. .custom, for which we really only have one direction of conversion). There's a balance here between doing the "right" (i.e. magic) thing for some API consumers and being consistent.
One thing to keep in mind, I think, is that these conversions are by nature lossy. There are always going to be edge cases where we've lost too much information to round-trip the keys. The question is where is the balance between preserving more cases and being consistent across the board. I currently favor being consistent here.
Seems like a loose-loose situation where there is not great solution.
One way to do this could be to require all CodingKeys to be CaseIterable and on every request for allKeys, take Key, iterate every case, converts every key to a string, applies the case conversion, and then iterate all of the keys in the payload and try to look them up in the converted table.
Couldn't KeyedDecodingContainer cache the converted keys?
How about special casing the snake_case to camelCase conversion to recognise common abbreviations often found in Swift code and uppercasing them as the naming conventions suggests? The obvious that come to mind are: HTTP, URL, UUID, XML, JSON
Yes, caching is possible, though unfortunately this doesn't solve the problem for keys which are not iterable.
Recognizing special words is certainly an option (and can be done transparently without updated API); the question is — what abbreviations are important enough to make it into that list? 🙂 All the ones you listed, I agree with. If we're doing HTTP, should we do HTTPS? (And what about other schemes?) It gets a bit hairier... What if people have other abbreviations they want that are not on our list? One option is to make an extensible list of known initialisms that anyone can extend in their process and just do that.
(I'm not trying to say that just because there isn't a "best" solution we shouldn't do anything; it's just about trying to figure out the best way going forward.)
Another solution is simply exposing JSONEncoder.KeyEncodingStrategy.toSnakeCase() and JSONDecoder.KeyDecodingStrategy.fromSnakeCase() and letting folks more easily do what they need to in .custom conversions.
I noticed another problem as a consequence of the current behaviour: resolving the round-trip issue in @norio-nomura's example requires giving the CondingKey a rawValue of myUrlProperty. I think this is very unintuitive and not easily discoverable as no domain (wether the Swift domain or JSON domain) ever declares a key with the value myUrlProperty: it feels outlandish to both domains.
The more I think about it the more I think that @norio-nomura's useSnakeCasedKeys has to be part of the solution, whatever the cost is of resolving KeyedDecodingContainer. By the way, isn't KeyedDecodingContainer.keys invisible to users to JSONEncoder and JSONDecoder? Can't we just return an empty array?
No, we can't do that, unfortunately. JSONDecoder.container(keyedBy:) returns a KeyedDecodingContainer, which exposes allKeys. That value has to be consumable for types which iterate through the possible keys in the payload in order to decide how to decode; we can't simply return an empty array for the benefit of making these edge cases work.
Perhaps we should take this to the Swift Forums for discussion on possible ways forward. At this point, we're not going to be able to introduce new API into Swift 4.2, but maybe there are other directions we can take this.
I started a thread on the Swift forums to discuss this in a more public setting. :)
Thx @itaiferber! Would it worth moving the discussion to Swift Evolution?
I think it would be good to gather feedback first about potential directions before suggesting API to Swift Evolution, but eventually, yes
Was any conclusion on the issue reached through the discussion?
There were three responses to the thread, all supportive of this approach; if we consider that to be enough signal to go ahead with this, we'll need to figure out how we want to review and schedule this API change. Given the amount of things going on at the moment, I'm not sure this will make the 4.2 release.
@parkera Any thoughts here?
Let's aim for 5.0. master is still the branch for that, but since we need time to do additional API review here, we will leave this open for a bit longer.
Hi there. I hope that it is ok that I bump this thread.
@parkera you mention that you hope to aim for 5.0. Now that we are nearing 5.0 do you think that there is any hope that this could make it?
Any updates on this? Could we merge this and cherry pick into 5.1 perhaps? Seems like there's a lot of support for this so it would be a shame if this gets abandoned.
Any changes made here would need to go through API review, which won't make it into Swift 5.1, unfortunately. We will try to push on this internally, given bandwidth.
Okay! I hope it makes into Swift 5.2 then :)
FYI, I opened https://github.com/jpsim/Yams/pull/200 as PoC that improved from this PR.
It's been a while, so let's get this moving again. Because this change is API and ABI breaking (not that I anticipate there are many clients switching over this enum), it requires a formal proposal to Swift evolution. During that process, it's possible you may hear from the core team that this change is OK to take without a formal review. Luckily, you've already done the heavy lifting by providing an implementation.
I'm going to tag this as pending evolution discussion.
@codafi Since JSONDecoder does not live in the standard library, this should not require full Swift evolution, but does require Foundation review. /CC @parkera to weigh in on changes here
I have checked, and I stand corrected. The overlays are Foundation’s and are not subject to evolution. Hopefully @parkera can get this reviewed in time.
cc @bendjones on this one
Can one of the admins verify this patch?
Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.
How to change the base branch: (Link)
More detail about the branch update: (Link)
Hi there,
Apologies for the bump, but unfortunately this PR was automatically closed - and I don't think it got the attention that it deserved.
The comments do mention internal reviews, so I am hoping that perhaps the issue is not yet off of the radar.
Otherwise: might I reopen a copy of the PR against main?
I am certain that the issue is very well understood, but I think that the current state causes a lot of confusion - even for experienced developers. The intention was to keep the key conversion in the encoder and decoder, but the current state is that this often 'leaks' into the CodingKey definition where you have to 'translate' something like imageURL to imageUrl for it to roundtrip to snake case correctly. I've seen quite a few bugs due to the misunderstanding that it would help to translate the key directly into snake case as:
case imageURL = "image_url"
As mentioned elsewhere, the big issue is that the 'imageUrl' representation belongs neither to the source or the destination domains but must be added for the sake of the key coding strategy.
@parkera , @CodaFi , @bendjones
| gharchive/pull-request | 2018-01-20T13:15:13 | 2025-04-01T06:37:55.986419 | {
"authors": [
"CodaFi",
"futurejones",
"hartbit",
"itaiferber",
"mortenbekditlevsen",
"norio-nomura",
"parkera",
"shahmishal",
"theblixguy"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/14039",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
325769018 | IRGen: adjust for LLVM API change
SVN r332881 introduced an additional parameter to emit a DWO file.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.
CC: @bob-wilson
| gharchive/pull-request | 2018-05-23T15:51:36 | 2025-04-01T06:37:55.989370 | {
"authors": [
"compnerd"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/16795",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
351838084 | [passmanager] Add the ability to verify before/after/around a specifi…
…c transform.
This helps speed up triaging failures caught by -sil-verify-all since this
allows one to trigger the -sil-verify-all verification around specific passes in
the pipeline rather than after every pass run. Was useful for me when tracking
down missing pass manager notification.
@swift-ci smoke test
Actually, I am going to centralize this logic a little bit before the review. Erik, I'll ping you again when I am ready.
I'm wondering what's the motivation for this. Is -sil-verify-all really too slow for debugging?
@eeckstein I found that the PassManagerNotificationVerificationAnalysis was too expensive to run with sil-verify-all since it has to run over all functions. I found an alternative solution (namely, verifyFull), but this seemed like generally useful functionality.
| gharchive/pull-request | 2018-08-18T17:38:44 | 2025-04-01T06:37:55.991891 | {
"authors": [
"eeckstein",
"gottesmm"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/18822",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
352330823 | Fix some edge cases when inlining coroutines
The current inlining strategy doesn't support inlining coroutines when there are multiple end_apply or abort_apply instructions in the caller, so refuse to inline such cases. Also, handle the case where there are no yield instructions in the callee, which can happen if e.g. the callee calls a no-return function.
I also simplified the code somewhat by removing the vestiges of the code that tried to unify control flow with switches.
As an unrelated fix, suppress function signature optimization for coroutines for now.
Build failed
Swift Test Linux Platform
Git Sha - 8613761487ed929b51267d0473aa8ab488cfea69
@swift-ci Please clean test Linux.
| gharchive/pull-request | 2018-08-20T23:24:13 | 2025-04-01T06:37:55.994430 | {
"authors": [
"rjmccall",
"swift-ci"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/18858",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
144509029 | [runtime] enhanced and refactored recently added Mutex abstraction
added read / write lock support
added non-fatal error support to allow use of mutex in fatal error reporting pathway
isolated pthread implementation to it own header/cpp file pair
expanded unit tests to cover new code as well as better test existing mutex
removed a layer of complexity that added no real value
added static allocation friendly versions of Mutex, ConditionVariable, and ReadWriteLock
Resolved bug number: (SR-946)
Before merging this pull request to apple/swift repository:
[ ] Test pull request on Swift continuous integration.
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please smoke test
OS X platform | @swift-ci Please smoke test OS X platform
Linux platform | @swift-ci Please smoke test Linux platform
Validation Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please test
OS X platform | @swift-ci Please test OS X platform
Linux platform | @swift-ci Please test Linux platform
Note: Only members of the Apple organization can trigger swift-ci.
Looking at conflict now.
Not a review, just triggering the CI.
@swift-ci Please test
Offline until morning (PST).
Looks like both Linux and Mac passed thanks for the early CI run.
Think I dealt with most comments with an open question or two for folks. If possible getting a CI and benchmark run would be helpful.
@swift-ci Please test
@swift-ci Please benchmark
@swift-ci Please test
!!! Couldn't read commit file !!!
In addition to CI, some should verify that this doesn't introduce any additional -Wglobal-constructors or -destructors warnings.
Looks like a lingering use of Condition instead of ConditionVariable not sure why my local benchmark run didn't flag it.
This is not a review of anything in this patch, but when writing tests for your synchronization primitives please bear in mind that 1) sleeping for XX ms is not sufficient to always have all your threads started and 2) gtest ASSERT_* macros won't force the test to stop running if they happen inside a thread, since they work by using 'return'.
I just fixed a race in the previous tests with fa77a7a.
Yeah that test has been reworked in this patch for that very reason. I had made a comment on the prior PR about that issue after it was reported to be seen on Linux.
I'm looking at Mutex::lockOrWait(). Its body is equivalent to below code, is it right?
template <typename CriticalSection>
void lockOrWait(ConditionVariable &condition,
CriticalSection criticalSection) {
lock([&] {
while (!criticalSection()) {
wait(condition);
}
});
}
lock();
while (!criticalSection()) {
ConditionPlatformHelper::wait(condition.Handle, Handle);
}
unlock();
According to their manuals, all three condition variable's wait function (pthread, <condition_variable>, Win32) release the associated lock. I think the second while loop will be running in unlocked.
Upon successful return, the mutex shall have been locked and shall be owned by the calling thread.
I believe the above is universal for condition wait behavior (quoted from http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_cond_timedwait.html). You must hold the lock before calling wait, then before waiting (blocking calling thread) the wait function drops the lock, and before wait returns (assuming no error / timeout) it must reacquire the lock.
So while looping the lock is held except when inside of the wait call.
Oh I understand. I was wrong about pthread, <condition_variable>, but Win32 SleepConditionVariableSRW() may differ.
I see the following community addition to the docs about SleepConditionVariableSRW(). I would be very surprised if it didn't acquire the lock before returning.
Even after the wait time expires, this function does not return until it acquires the lock again no matter how long it takes. This thread must always release the lock regardless of the return value. The return value indicates that the conditional variable was set (true) or wait timed out (false + ERROR_TIMEOUT).
Yes, I confirmed with test code. It locks again !. MSDN document was poor. Thanks for reference.
I wrote MutexWin32.cpp(.h) and they passed your test code unittests/runtime/Mutex.cpp. It was very simple. Thanks you.
I think this is finally good to go. It will need a CI & benchmark before any attempt to merge.
I have held off removing ReadWriteLock::readWriteLock([]{}, []{}) for the moment since unlock got separated into readUnlock and writeUnlock in support of Win32 version of this code. The abstraction helps avoid mistakes with calling the wrong unlock (granted likely easily detected in testing) and of course avoids duplication of code in typical fast path / slow path type usage of read write locks. I will remove it folks want.
@swift-ci Please test
@swift-ci Please benchmark
@swift-ci Please test
!!! Couldn't read commit file !!!
@shawnce There's some linker heartburn:
Undefined symbols for architecture x86_64:
"swift::Condition::notifyAll()", referenced from:
__swift_allocBox_ in libswiftRuntime.a(HeapObject.cpp.o)
_swift_getGenericMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getObjCClassMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getFunctionTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getTupleTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getExistentialMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
...
"swift::Condition::Condition()", referenced from:
swift::Lazy<swift::MetadataCache<(anonymous namespace)::BoxCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(HeapObject.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::ObjCClassCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::FunctionCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::TupleCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::MetatypeCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::GenericCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::WitnessTableCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
...
"swift::MutexImpl::lock()", referenced from:
__swift_allocBox_ in libswiftRuntime.a(HeapObject.cpp.o)
_swift_getGenericMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getObjCClassMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getFunctionTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getTupleTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getExistentialMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
...
"swift::MutexImpl::wait(swift::Condition&)", referenced from:
__swift_allocBox_ in libswiftRuntime.a(HeapObject.cpp.o)
_swift_getGenericMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getObjCClassMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getFunctionTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getTupleTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getExistentialMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
...
"swift::MutexImpl::unlock()", referenced from:
__swift_allocBox_ in libswiftRuntime.a(HeapObject.cpp.o)
_swift_getGenericMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getObjCClassMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getFunctionTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getTupleTypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
_swift_getExistentialMetatypeMetadata in libswiftRuntime.a(Metadata.cpp.o)
...
"swift::MutexImpl::MutexImpl(bool)", referenced from:
swift::Lazy<swift::MetadataCache<(anonymous namespace)::BoxCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(HeapObject.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::ObjCClassCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::FunctionCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::TupleCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::MetatypeCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<(anonymous namespace)::ForeignTypeState>::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
swift::Lazy<swift::MetadataCache<(anonymous namespace)::GenericCacheEntry> >::defaultInitCallback(void*) in libswiftRuntime.a(Metadata.cpp.o)
...
ld: symbol(s) not found for architecture x86_64
@jckarter I spotted that I can't explain why that is happening. Can a plain CI run be done to confirm what I am seeing on my end (I don't see any linker issues, etc.). I will rerun benchmarks locally to confirm I see no issues (didn't see any last time).
@swift-ci Please test
@jckarter the issue looks specific to what the benchmark operation is doing. I can build --benchmark locally without issues. I suspect somehow a reference branch is being made from some invalid merge point that is resulting in a mix of old and new code trying to be compiled.
Any place I can look to see how a given CI build is setup, to understand the command executed, etc.?
@shahmishal Any idea why the benchmark runner would fail with linker errors when the normal CI works?
I looked the failed benchmark consol output https://ci.swift.org/job/swift-PR-osx-perf/35/console. I think the problem is in the ci build process.
The commit a0452be removed stdlib/public/runtime/Mutex.cpp and added stdlib/public/runtime/MutexPThread.cpp, but the benchmark compiled both.
It seems it tested without MutexPThread.cpp, and older source set. There is no MutexImpl class in current commit, isn't it?
[505/949] Building CXX object stdlib/public/runtime/CMakeFiles/swiftRuntime-macosx-x86_64.dir/Mutex.cpp.o
.....
[30/167] Building CXX object stdlib/public/runtime/CMakeFiles/swiftRuntime-macosx-x86_64.dir/MutexPThread.cpp.o
.....
"swift::MutexImpl::lock()", referenced from:
@shahmishal @jckarter Do the build commands exist in git someplace for what the benchmark CI plan does? ..or does a lot of that live in Jenkins? Would a new pull request potentially side step some state that may have a hand in an incorrect merge being used?
@swift-ci Please benchmark
@shawnce Benchmark bot:
Checkout master branch (Targeted Branch)
run swift/utils/build-script -R --no-assertions --benchmark
Checkout origin/pr/1950/merge
run swift/utils/build-script -R --no-assertions --benchmark
Upload the results to GitHub pull request.
Build comment file:
Optimized (O)
Regression (1)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ClassArrayGetter
12
13
+8.3%
0.92x
Improvement (1)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeFromNSArrayAnyObjectToString
166404
155969
-6.3%
1.07x(?)
No Changes (113)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeToNSSet
16349
15737
-3.7%
1.04x(?)
DictionaryLiteral
3418
3277
-4.1%
1.04x
ObjectiveCBridgeFromNSDictionaryAnyObjectToString
190926
185476
-2.9%
1.03x
ObjectiveCBridgeStubFromArrayOfNSString
113176
109936
-2.9%
1.03x(?)
Array2D
2024
1981
-2.1%
1.02x(?)
StringInterpolation
10080
9920
-1.6%
1.02x
Walsh
311
306
-1.6%
1.02x
ObjectiveCBridgeToNSArray
29678
29149
-1.8%
1.02x(?)
ObjectiveCBridgeToNSDictionary
16343
16057
-1.8%
1.02x(?)
DictionaryRemove
4799
4718
-1.7%
1.02x(?)
NSStringConversion
616
606
-1.6%
1.02x
Chars
670
660
-1.5%
1.02x(?)
ArraySubscript
1338
1330
-0.6%
1.01x
ObjectiveCBridgeFromNSArrayAnyObjectForced
3654
3617
-1.0%
1.01x
ErrorHandling
2866
2829
-1.3%
1.01x(?)
ArrayLiteral
993
987
-0.6%
1.01x(?)
ProtocolDispatch2
163
162
-0.6%
1.01x
DictionarySwapOfObjects
7176
7116
-0.8%
1.01x(?)
StrComplexWalk
2808
2783
-0.9%
1.01x(?)
ArrayOfRef
3454
3434
-0.6%
1.01x(?)
ObjectiveCBridgeFromNSArrayAnyObject
63195
62477
-1.1%
1.01x(?)
NSDictionaryCastToSwift
8554
8436
-1.4%
1.01x(?)
HashTest
1807
1791
-0.9%
1.01x(?)
LinkedList
8997
8931
-0.7%
1.01x(?)
MonteCarloPi
42564
42587
+0.1%
1.00x
StackPromo
18991
18990
-0.0%
1.00x(?)
RecursiveOwnedParameter
1829
1829
+0.0%
1.00x
ObjectiveCBridgeStubToNSString
1373
1375
+0.1%
1.00x(?)
Histogram
652
652
+0.0%
1.00x
SortStrings
1753
1747
-0.3%
1.00x
DictionaryBridge
3528
3530
+0.1%
1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced
4550
4567
+0.4%
1.00x(?)
ArrayOfGenericPOD
207
208
+0.5%
1.00x
StringWithCString
81188
81245
+0.1%
1.00x(?)
ObjectiveCBridgeFromNSStringForced
2202
2194
-0.4%
1.00x(?)
Prims
729
730
+0.1%
1.00x(?)
SortLettersInPlace
1003
1001
-0.2%
1.00x
PopFrontArray
1228
1230
+0.2%
1.00x(?)
Dictionary3OfObjects
1184
1185
+0.1%
1.00x(?)
ByteSwap
1
1
+0.0%
1.00x
SuperChars
282895
283773
+0.3%
1.00x(?)
XorLoop
359
359
+0.0%
1.00x
ObjectiveCBridgeStubFromNSStringRef
327
327
+0.0%
1.00x
ProtocolDispatch
2879
2885
+0.2%
1.00x(?)
ObjectAllocation
141
141
+0.0%
1.00x
TypeFlood
0
0
+0.0%
1.00x
ObjectiveCBridgeFromNSSetAnyObject
93758
94213
+0.5%
1.00x(?)
Dictionary3
726
727
+0.1%
1.00x(?)
Dictionary2
2399
2400
+0.0%
1.00x(?)
SetIntersect_OfObjects
2728
2719
-0.3%
1.00x(?)
NSError
353
352
-0.3%
1.00x(?)
DictionaryOfObjects
2687
2693
+0.2%
1.00x(?)
PopFrontUnsafePointer
8506
8501
-0.1%
1.00x(?)
PolymorphicCalls
61
61
+0.0%
1.00x
114
2243449
2236732
-0.3%
1.00x
Hanoi
3431
3414
-0.5%
1.00x(?)
OpenClose
49
49
+0.0%
1.00x
DictionaryRemoveOfObjects
19410
19485
+0.4%
1.00x(?)
UTF8Decode
257
256
-0.4%
1.00x
SetIsSubsetOf
480
479
-0.2%
1.00x
NopDeinit
34609
34660
+0.1%
1.00x(?)
SetIntersect
1134
1133
-0.1%
1.00x(?)
RGBHistogramOfObjects
22346
22384
+0.2%
1.00x
StringBuilder
1369
1365
-0.3%
1.00x(?)
Phonebook
9288
9299
+0.1%
1.00x(?)
Sim2DArray
413
411
-0.5%
1.00x(?)
SetExclusiveOr_OfObjects
8855
8839
-0.2%
1.00x(?)
MonteCarloE
10048
10034
-0.1%
1.00x(?)
SetUnion_OfObjects
7013
7020
+0.1%
1.00x(?)
RC4
251
251
+0.0%
1.00x
SetIsSubsetOf_OfObjects
540
540
+0.0%
1.00x
ArrayAppend
730
728
-0.3%
1.00x(?)
RGBHistogram
3359
3352
-0.2%
1.00x(?)
ArrayValueProp4
5
5
+0.0%
1.00x
ArrayOfPOD
172
172
+0.0%
1.00x
SetUnion
3242
3234
-0.2%
1.00x
StrToInt
3622
3632
+0.3%
1.00x(?)
BitCount
1
1
+0.0%
1.00x
AngryPhonebook
3367
3358
-0.3%
1.00x(?)
SevenBoom
1267
1269
+0.2%
1.00x(?)
StringWalk
6438
6452
+0.2%
1.00x(?)
ArrayValueProp
5
5
+0.0%
1.00x
GlobalClass
0
0
+0.0%
1.00x
Memset
222
222
+0.0%
1.00x
ArrayAppendReserved
508
508
+0.0%
1.00x
ArrayValueProp2
5
5
+0.0%
1.00x
ArrayValueProp3
5
5
+0.0%
1.00x
ObjectiveCBridgeToNSString
1021
1028
+0.7%
0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject
184245
186150
+1.0%
0.99x(?)
DictionarySwap
757
762
+0.7%
0.99x(?)
Integrate
228
230
+0.9%
0.99x(?)
ObjectiveCBridgeStubFromNSString
697
701
+0.6%
0.99x(?)
Join
428
433
+1.2%
0.99x
PopFrontArrayGeneric
1255
1262
+0.6%
0.99x
CaptureProp
3752
3779
+0.7%
0.99x(?)
MapReduce
329
332
+0.9%
0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced
122660
124131
+1.2%
0.99x(?)
Dictionary
959
973
+1.5%
0.99x
ArrayInClass
82
83
+1.2%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectToStringForced
106501
107077
+0.5%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString
169579
171590
+1.2%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced
4023
4070
+1.2%
0.99x(?)
DeadArray
176
177
+0.6%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced
159423
160487
+0.7%
0.99x(?)
Dictionary2OfObjects
3969
4005
+0.9%
0.99x
TwoSum
1713
1727
+0.8%
0.99x
RangeAssignment
262
266
+1.5%
0.98x(?)
ObjectiveCBridgeStubToArrayOfNSString
29702
30248
+1.8%
0.98x(?)
SetExclusiveOr
3782
3844
+1.6%
0.98x
ArrayOfGenericRef
3475
3542
+1.9%
0.98x(?)
ObjectiveCBridgeFromNSString
1529
1553
+1.6%
0.98x(?)
StaticArray
2598
2672
+2.9%
0.97x(?)
Calculator
32
33
+3.1%
0.97x
**Unoptimized (Onone)**
Regression (1)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
TypeFlood
142
151
+6.3%
0.94x(?)
Improvement (0)
No Changes (114)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeFromNSSetAnyObjectToStringForced
121775
116408
-4.4%
1.05x(?)
OpenClose
451
433
-4.0%
1.04x(?)
DictionaryOfObjects
7282
7049
-3.2%
1.03x
StringWalk
42766
41327
-3.4%
1.03x(?)
StringInterpolation
13674
13419
-1.9%
1.02x(?)
StrComplexWalk
7871
7686
-2.4%
1.02x
PopFrontArrayGeneric
12442
12203
-1.9%
1.02x
CaptureProp
55130
54267
-1.6%
1.02x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced
127072
124314
-2.2%
1.02x
StackPromo
80945
80335
-0.8%
1.01x(?)
Histogram
13859
13768
-0.7%
1.01x(?)
PopFrontArray
12262
12107
-1.3%
1.01x(?)
ErrorHandling
7241
7181
-0.8%
1.01x(?)
ObjectiveCBridgeStubFromNSString
1138
1132
-0.5%
1.01x
ProtocolDispatch
5602
5568
-0.6%
1.01x(?)
MapReduce
45175
44618
-1.2%
1.01x(?)
Integrate
348
346
-0.6%
1.01x
UTF8Decode
39402
39202
-0.5%
1.01x(?)
Dictionary
4532
4500
-0.7%
1.01x
ObjectiveCBridgeStubToArrayOfNSString
30424
30172
-0.8%
1.01x(?)
StringBuilder
8268
8153
-1.4%
1.01x(?)
TwoSum
9273
9193
-0.9%
1.01x(?)
ArraySubscript
4450
4448
-0.0%
1.00x(?)
DictionarySwapOfObjects
25809
25767
-0.2%
1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject
192412
191679
-0.4%
1.00x(?)
RecursiveOwnedParameter
10283
10293
+0.1%
1.00x(?)
ObjectiveCBridgeStubToNSString
1672
1676
+0.2%
1.00x
ClassArrayGetter
1264
1264
+0.0%
1.00x
Array2D
697294
697454
+0.0%
1.00x(?)
SortStrings
5672
5652
-0.3%
1.00x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced
7074
7042
-0.5%
1.00x(?)
MonteCarloPi
50224
50226
+0.0%
1.00x(?)
StringWithCString
713012
712645
-0.1%
1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced
7029
7038
+0.1%
1.00x(?)
Prims
13669
13646
-0.2%
1.00x(?)
SortLettersInPlace
2319
2315
-0.2%
1.00x(?)
DictionarySwap
11593
11587
-0.1%
1.00x(?)
ByteSwap
9
9
+0.0%
1.00x
XorLoop
18434
18445
+0.1%
1.00x(?)
ObjectiveCBridgeStubFromNSStringRef
651
651
+0.0%
1.00x
StaticArray
17031
16984
-0.3%
1.00x(?)
ArrayLiteral
1033
1035
+0.2%
1.00x(?)
Walsh
12244
12243
-0.0%
1.00x(?)
Dictionary3
2099
2098
-0.1%
1.00x(?)
Dictionary2
5147
5143
-0.1%
1.00x(?)
SetIntersect_OfObjects
18893
18918
+0.1%
1.00x(?)
Join
1340
1334
-0.5%
1.00x
ArrayOfRef
9929
9908
-0.2%
1.00x(?)
PopFrontUnsafePointer
95350
95047
-0.3%
1.00x(?)
Calculator
932
931
-0.1%
1.00x
DictionaryRemoveOfObjects
60971
60879
-0.1%
1.00x(?)
SetIsSubsetOf
2952
2948
-0.1%
1.00x(?)
NopDeinit
53314
53273
-0.1%
1.00x(?)
SetIntersect
18837
18853
+0.1%
1.00x(?)
SetExclusiveOr
48566
48583
+0.0%
1.00x(?)
RGBHistogramOfObjects
97745
98173
+0.4%
1.00x(?)
ArrayInClass
3648
3647
-0.0%
1.00x
ArrayOfGenericRef
10569
10563
-0.1%
1.00x(?)
Phonebook
59729
59869
+0.2%
1.00x(?)
Sim2DArray
13143
13139
-0.0%
1.00x(?)
SetExclusiveOr_OfObjects
66912
66855
-0.1%
1.00x(?)
MonteCarloE
98538
98873
+0.3%
1.00x
SetUnion_OfObjects
51158
51146
-0.0%
1.00x(?)
GlobalClass
0
0
+0.0%
1.00x
HashTest
6016
6036
+0.3%
1.00x
SetIsSubsetOf_OfObjects
2835
2847
+0.4%
1.00x(?)
ArrayAppend
2874
2865
-0.3%
1.00x(?)
DictionaryRemove
30422
30428
+0.0%
1.00x(?)
LinkedList
26390
26358
-0.1%
1.00x
RGBHistogram
49481
49605
+0.2%
1.00x(?)
ArrayOfPOD
2335
2328
-0.3%
1.00x(?)
SetUnion
34827
34854
+0.1%
1.00x(?)
Chars
54412
54391
-0.0%
1.00x(?)
DeadArray
128681
128252
-0.3%
1.00x(?)
BitCount
77
77
+0.0%
1.00x
AngryPhonebook
5880
5887
+0.1%
1.00x(?)
SevenBoom
1417
1422
+0.3%
1.00x
ArrayValueProp
2225
2227
+0.1%
1.00x(?)
RC4
8737
8753
+0.2%
1.00x(?)
Memset
20655
20659
+0.0%
1.00x(?)
Dictionary2OfObjects
6936
6918
-0.3%
1.00x(?)
ArrayAppendReserved
2697
2688
-0.3%
1.00x(?)
ArrayValueProp2
18192
18189
-0.0%
1.00x(?)
ArrayValueProp3
2580
2574
-0.2%
1.00x(?)
ObjectiveCBridgeToNSString
1048
1056
+0.8%
0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString
193233
194649
+0.7%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToString
159865
160995
+0.7%
0.99x(?)
ObjectiveCBridgeFromNSStringForced
2566
2581
+0.6%
0.99x(?)
Dictionary3OfObjects
2725
2740
+0.6%
0.99x
RangeAssignment
15535
15615
+0.5%
0.99x
SuperChars
691413
694997
+0.5%
0.99x(?)
114
5537837
5570509
+0.6%
0.99x
ObjectAllocation
1292
1301
+0.7%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObject
99870
101059
+1.2%
0.99x
ProtocolDispatch2
421
424
+0.7%
0.99x
ObjectiveCBridgeToNSSet
16368
16559
+1.2%
0.99x(?)
ObjectiveCBridgeToNSArray
29459
29780
+1.1%
0.99x(?)
NSError
648
653
+0.8%
0.99x(?)
DictionaryLiteral
20071
20229
+0.8%
0.99x(?)
Hanoi
22703
22848
+0.6%
0.99x
ArrayOfGenericPOD
3426
3475
+1.4%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObject
66231
66937
+1.1%
0.99x(?)
NSDictionaryCastToSwift
9559
9662
+1.1%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString
189658
190659
+0.5%
0.99x(?)
NSStringConversion
2553
2570
+0.7%
0.99x(?)
ArrayValueProp4
2522
2535
+0.5%
0.99x(?)
DictionaryBridge
3534
3623
+2.5%
0.98x(?)
PolymorphicCalls
1133
1154
+1.9%
0.98x
StrToInt
18521
18920
+2.1%
0.98x
ObjectiveCBridgeFromNSString
4939
5036
+2.0%
0.98x(?)
ObjectiveCBridgeToNSDictionary
16261
16616
+2.2%
0.98x(?)
ObjectiveCBridgeStubFromArrayOfNSString
108740
111878
+2.9%
0.97x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced
7453
7790
+4.5%
0.96x
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced
158374
164849
+4.1%
0.96x(?)
**Hardware Overview**
Model Name: Mac mini
Model Identifier: Macmini7,1
Processor Name: Intel Core i7
Processor Speed: 3 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 4 MB
Memory: 16 GB
@nadavrot Do these regressions look OK to you? It looks potentially legitimate, since both of the affected benchmarks are type-metadata-access-heavy.
@jckarter I am seeing one improvement and one regression. The numbers we are seeing could be noise. In any case, we'll benchmark this change again with the internal setup of the performance benchmark. I think that this change can go in.
Also looking at the numbers it seems like some of the benchmarks result in low values that can cause what look like larger percentage changes. It seems like they should be enhanced to always achieve a threshold of say 100 if they are going to be measured in the way they are.
bump
Any remaining objections @gparker42 @nadavrot ?
I'm going to be out next week; @gparker42, if this looks good, do you mind merging?
I am building with your code on Cygwin. I found errors.
In file included from /cygdrive/c/Work/swift_msvc/swift/stdlib/public/runtime/Casting.cpp:25:
In file included from /cygdrive/c/Work/swift_msvc/swift/include/swift/Runtime/Mutex.h:24:
/cygdrive/c/Work/swift_msvc/swift/include/swift/Runtime/MutexPThread.h:49:32: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
static constexpr MutexHandle staticInit() {
^
/cygdrive/c/Work/swift_msvc/swift/include/swift/Runtime/MutexPThread.h:50:12: note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression
return PTHREAD_MUTEX_INITIALIZER;
^
/usr/include/pthread.h:52:35: note: expanded from macro 'PTHREAD_MUTEX_INITIALIZER'
#define PTHREAD_MUTEX_INITIALIZER PTHREAD_NORMAL_MUTEX_INITIALIZER_NP
^
/usr/include/pthread.h:50:45: note: expanded from macro 'PTHREAD_NORMAL_MUTEX_INITIALIZER_NP'
#define PTHREAD_NORMAL_MUTEX_INITIALIZER_NP (pthread_mutex_t)19
^
@tinysun212 Any suggestions to how to correct? I don't currently have a usable Windows install with Cygwin (it will take me a bit to get it going). I guess Cygwin doesn't support staticly allocated pthread mutex?
I extracted some definitions from pthread.h in Cygwin.
I think you can reproduce above compile error with temporarily changing #include <pthread.h> to #include "swift/Runtime/_pthread.h" in Mutex.h/MutexPThread.h.
typedef __uint32_t pthread_mutex_t; /* identify a mutex */
typedef __uint32_t pthread_cond_t; /* identify a condition variable */
typedef __uint32_t pthread_rwlock_t; /* POSIX RWLock Object */
#define PTHREAD_COND_INITIALIZER (pthread_cond_t)21
#define PTHREAD_MUTEX_INITIALIZER PTHREAD_NORMAL_MUTEX_INITIALIZER_NP
#define PTHREAD_NORMAL_MUTEX_INITIALIZER_NP (pthread_mutex_t)19
#define PTHREAD_RWLOCK_INITIALIZER (pthread_rwlock_t)22
int pthread_cond_broadcast (pthread_cond_t *);
int pthread_cond_destroy (pthread_cond_t *);
int pthread_cond_init (pthread_cond_t *, const pthread_condattr_t *);
int pthread_cond_signal (pthread_cond_t *);
int pthread_cond_wait (pthread_cond_t *, pthread_mutex_t *);
int pthread_mutexattr_init (pthread_mutexattr_t *);
int pthread_mutexattr_settype (pthread_mutexattr_t *, int);
int pthread_mutexattr_destroy (pthread_mutexattr_t *);
int pthread_mutex_destroy (pthread_mutex_t *);
int pthread_mutex_init (pthread_mutex_t *, const pthread_mutexattr_t *);
int pthread_mutex_lock (pthread_mutex_t *);
int pthread_mutex_trylock (pthread_mutex_t *);
int pthread_mutex_unlock (pthread_mutex_t *);
int pthread_rwlock_destroy (pthread_rwlock_t *rwlock);
int pthread_rwlock_init (pthread_rwlock_t *rwlock, const pthread_rwlockattr_t *attr);
int pthread_rwlock_rdlock (pthread_rwlock_t *rwlock);
int pthread_rwlock_tryrdlock (pthread_rwlock_t *rwlock);
int pthread_rwlock_trywrlock (pthread_rwlock_t *rwlock);
int pthread_rwlock_unlock (pthread_rwlock_t *rwlock);
int pthread_rwlock_wrlock (pthread_rwlock_t *rwlock);
I guess we will have to predicate the use of constexpr on not Cygwin. It won't make cygwin any worse then it apparently was (doesn't have a "true" static allocated mutex, etc.) while allowing other platforms to correctly honor static allocation (under C++).
Sorry, I captured wrong header. In include/cygwin/types.h, the typedef part is as follows,
typedef struct __pthread_condattr_t {char __dummy;} *pthread_condattr_t;
typedef struct __pthread_cond_t {char __dummy;} *pthread_cond_t;
typedef struct __pthread_rwlock_t {char __dummy;} *pthread_rwlock_t;
typedef struct __pthread_rwlockattr_t {char __dummy;} *pthread_rwlockattr_t;
I wrote simple source to test.
$ cat tt.cpp
typedef struct __pthread_cond_t {char __dummy;} *pthread_cond_t;
#define PTHREAD_COND_INITIALIZER (pthread_cond_t)21
typedef pthread_cond_t ConditionHandle;
static constexpr ConditionHandle staticInit() {
return PTHREAD_COND_INITIALIZER;
};
$ clang++ -c -std=c++11 tt.cpp
tt.cpp:7:34: error: constexpr function never produces a constant expression [-Winvalid-constexpr]
static constexpr ConditionHandle staticInit() {
^
tt.cpp:8:10: note: cast that performs the conversions of a reinterpret_cast is not allowed in a constant expression
return PTHREAD_COND_INITIALIZER;
^
tt.cpp:3:34: note: expanded from macro 'PTHREAD_COND_INITIALIZER'
#define PTHREAD_COND_INITIALIZER (pthread_cond_t)21
^
1 error generated.
Do you have any idea to keep constexpr?
@tinysun212 I just pushed a change that should deal with the issue you reported under Cygwin on Windows. If possible can you try it out to verify it works as expected?
It is successfully compiled without any warning or error. Thanks for your patch.
@tinysun212 cool, you will need to update your Win32 implementation have the following in its header.
#define CONDITION_SUPPORTS_CONSTEXPR 1
#define MUTEX_SUPPORTS_CONSTEXPR 1
#define READWRITELOCK_SUPPORTS_CONSTEXPR 1
@gparker42 @jckarter ok I think this ready to go after a CI
@swift-ci Please test
@swift-ci Please benchmark
Build comment file:
Optimized (O)
Regression (1)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeToNSDictionary
16422
17423
+6.1%
0.94x
Improvement (3)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeFromNSArrayAnyObjectToString
166571
157769
-5.3%
1.06x
Calculator
35
33
-5.7%
1.06x
StringHasSuffix
714
675
-5.5%
1.06x(?)
No Changes (117)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ObjectiveCBridgeToNSSet
16729
15967
-4.5%
1.05x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject
196894
189306
-3.9%
1.04x(?)
DictionaryOfObjects
2264
2204
-2.6%
1.03x
Dictionary
731
713
-2.5%
1.03x
SetExclusiveOr_OfObjects
8077
7816
-3.2%
1.03x
SetUnion_OfObjects
6748
6546
-3.0%
1.03x
SortStrings
1762
1730
-1.8%
1.02x
ObjectiveCBridgeStubToNSString
1415
1392
-1.6%
1.02x
AngryPhonebook
3389
3337
-1.5%
1.02x(?)
DictionaryRemove
5015
4907
-2.1%
1.02x(?)
ObjectiveCBridgeFromNSSetAnyObjectToString
166038
162739
-2.0%
1.02x(?)
ObjectiveCBridgeStubFromArrayOfNSString
109552
107570
-1.8%
1.02x
ObjectiveCBridgeToNSString
1062
1055
-0.7%
1.01x(?)
PopFrontArray
1060
1054
-0.6%
1.01x(?)
Array2D
2024
2012
-0.6%
1.01x(?)
DictionaryBridge
3636
3609
-0.7%
1.01x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced
4574
4544
-0.7%
1.01x(?)
Prims
714
710
-0.6%
1.01x
DictionarySwap
757
752
-0.7%
1.01x(?)
RangeAssignment
273
270
-1.1%
1.01x
StrComplexWalk
3023
2993
-1.0%
1.01x(?)
ObjectAllocation
143
142
-0.7%
1.01x(?)
Dictionary2
1918
1904
-0.7%
1.01x
ArrayOfRef
3451
3429
-0.6%
1.01x(?)
ObjectiveCBridgeStubToArrayOfNSString
30347
30111
-0.8%
1.01x(?)
Phonebook
7221
7130
-1.3%
1.01x
NSStringConversion
612
606
-1.0%
1.01x
Chars
618
609
-1.5%
1.01x(?)
StrToInt
4936
4866
-1.4%
1.01x
DeadArray
173
172
-0.6%
1.01x
120
2294275
2269762
-1.1%
1.01x
ArraySubscript
1325
1321
-0.3%
1.00x(?)
MonteCarloPi
42667
42668
+0.0%
1.00x(?)
StackPromo
18693
18709
+0.1%
1.00x(?)
RecursiveOwnedParameter
1826
1827
+0.1%
1.00x(?)
Integrate
233
232
-0.4%
1.00x
ClassArrayGetter
12
12
+0.0%
1.00x
Histogram
639
639
+0.0%
1.00x
StringWithCString
75595
75613
+0.0%
1.00x(?)
ObjectiveCBridgeFromNSStringForced
2187
2186
-0.1%
1.00x(?)
SortLettersInPlace
940
943
+0.3%
1.00x(?)
ArrayOfGenericPOD
207
208
+0.5%
1.00x
Dictionary3OfObjects
850
846
-0.5%
1.00x
ByteSwap
1
1
+0.0%
1.00x
SuperChars
276889
275774
-0.4%
1.00x
XorLoop
359
359
+0.0%
1.00x
ObjectiveCBridgeStubFromNSStringRef
327
327
+0.0%
1.00x
StaticArray
2648
2643
-0.2%
1.00x(?)
ProtocolDispatch
2892
2888
-0.1%
1.00x(?)
TypeFlood
0
0
+0.0%
1.00x
ProtocolDispatch2
151
151
+0.0%
1.00x
Dictionary3
497
498
+0.2%
1.00x(?)
StringHasPrefix
576
577
+0.2%
1.00x(?)
SetIntersect_OfObjects
2360
2358
-0.1%
1.00x(?)
ErrorHandling
2859
2845
-0.5%
1.00x(?)
ObjectiveCBridgeToNSArray
30182
30037
-0.5%
1.00x(?)
NSError
359
359
+0.0%
1.00x
PopFrontArrayGeneric
1049
1051
+0.2%
1.00x(?)
PopFrontUnsafePointer
8657
8655
-0.0%
1.00x(?)
CaptureProp
3741
3742
+0.0%
1.00x(?)
PolymorphicCalls
61
61
+0.0%
1.00x
RC4
250
250
+0.0%
1.00x
MapReduce
327
327
+0.0%
1.00x
Hanoi
3405
3405
+0.0%
1.00x
OpenClose
48
48
+0.0%
1.00x
DictionaryRemoveOfObjects
19503
19471
-0.2%
1.00x(?)
UTF8Decode
260
260
+0.0%
1.00x
SortStringsUnicode
8994
9013
+0.2%
1.00x(?)
SetIsSubsetOf
548
549
+0.2%
1.00x(?)
NopDeinit
34619
34609
-0.0%
1.00x
ObjectiveCBridgeFromNSArrayAnyObject
61546
61842
+0.5%
1.00x
SetIntersect
1300
1298
-0.1%
1.00x(?)
SetExclusiveOr
3830
3836
+0.2%
1.00x(?)
RGBHistogramOfObjects
21199
21271
+0.3%
1.00x(?)
StringBuilder
1389
1390
+0.1%
1.00x(?)
ArrayInClass
85
85
+0.0%
1.00x
ArrayOfGenericRef
3519
3524
+0.1%
1.00x(?)
Sim2DArray
410
412
+0.5%
1.00x
MonteCarloE
9996
10032
+0.4%
1.00x
StringHasSuffixUnicode
62311
62479
+0.3%
1.00x(?)
HashTest
1819
1816
-0.2%
1.00x(?)
SetIsSubsetOf_OfObjects
617
617
+0.0%
1.00x
ArrayAppend
730
728
-0.3%
1.00x(?)
StringHasPrefixUnicode
14981
15017
+0.2%
1.00x(?)
LinkedList
6847
6843
-0.1%
1.00x
RGBHistogram
3233
3238
+0.1%
1.00x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced
3981
3968
-0.3%
1.00x(?)
ArrayAppendReserved
507
507
+0.0%
1.00x
ArrayOfPOD
171
171
+0.0%
1.00x
SetUnion
3385
3398
+0.4%
1.00x(?)
BitCount
1
1
+0.0%
1.00x
ArrayLiteral
979
981
+0.2%
1.00x(?)
SevenBoom
1276
1274
-0.2%
1.00x
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced
159858
159122
-0.5%
1.00x(?)
StringWalk
6008
6014
+0.1%
1.00x(?)
ArrayValueProp
5
5
+0.0%
1.00x
GlobalClass
0
0
+0.0%
1.00x
Memset
222
223
+0.5%
1.00x
Dictionary2OfObjects
3293
3283
-0.3%
1.00x(?)
ArrayValueProp4
5
5
+0.0%
1.00x
TwoSum
1642
1643
+0.1%
1.00x(?)
ArrayValueProp2
5
5
+0.0%
1.00x
ArrayValueProp3
5
5
+0.0%
1.00x
DictionarySwapOfObjects
6606
6658
+0.8%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced
3609
3633
+0.7%
0.99x(?)
StringInterpolation
9999
10054
+0.6%
0.99x(?)
Join
439
445
+1.4%
0.99x(?)
ObjectiveCBridgeStubFromNSString
694
700
+0.9%
0.99x
StringEqualPointerComparison
7102
7160
+0.8%
0.99x
ObjectiveCBridgeFromNSString
1561
1572
+0.7%
0.99x
ObjectiveCBridgeFromNSSetAnyObjectToStringForced
101734
103174
+1.4%
0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToString
180143
182976
+1.6%
0.98x(?)
ObjectiveCBridgeFromNSSetAnyObject
95459
97047
+1.7%
0.98x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced
114004
116779
+2.4%
0.98x(?)
NSDictionaryCastToSwift
8281
8422
+1.7%
0.98x(?)
DictionaryLiteral
3006
3113
+3.6%
0.97x(?)
Walsh
317
329
+3.8%
0.96x
**Unoptimized (Onone)**
Regression (1)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
TypeFlood
145
156
+7.6%
0.93x(?)
Improvement (3)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
StringHasPrefix
1630
1516
-7.0%
1.08x
ByteSwap
10
9
-10.0%
1.11x
StringWalk
26926
23276
-13.6%
1.16x
No Changes (117)
TEST
OLD_MIN
NEW_MIN
DELTA (%)
SPEEDUP
ArrayOfPOD
2256
2152
-4.6%
1.05x
StringHasSuffix
1561
1487
-4.7%
1.05x
ObjectiveCBridgeToNSSet
16775
16073
-4.2%
1.04x(?)
NopDeinit
60929
59005
-3.2%
1.03x
ObjectiveCBridgeFromNSSetAnyObjectToString
184614
179171
-3.0%
1.03x(?)
OpenClose
452
442
-2.2%
1.02x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectToStringForced
122508
119650
-2.3%
1.02x(?)
StringHasPrefixUnicode
16769
16441
-2.0%
1.02x
ObjectiveCBridgeFromNSSetAnyObjectToStringForced
115560
113711
-1.6%
1.02x(?)
ArrayAppendReserved
2701
2659
-1.6%
1.02x(?)
Chars
53814
52725
-2.0%
1.02x(?)
PopFrontArray
11670
11546
-1.1%
1.01x
SortStrings
14096
13993
-0.7%
1.01x
SortLettersInPlace
4158
4134
-0.6%
1.01x(?)
ObjectiveCBridgeFromNSDictionaryAnyObject
199443
197410
-1.0%
1.01x(?)
Integrate
347
345
-0.6%
1.01x(?)
Join
1370
1363
-0.5%
1.01x(?)
ErrorHandling
7549
7464
-1.1%
1.01x(?)
PopFrontArrayGeneric
11885
11821
-0.5%
1.01x(?)
PopFrontUnsafePointer
96350
95260
-1.1%
1.01x(?)
StringEqualPointerComparison
9779
9645
-1.4%
1.01x
ArrayOfGenericPOD
3493
3449
-1.3%
1.01x(?)
DictionaryRemoveOfObjects
60808
60183
-1.0%
1.01x
UTF8Decode
38869
38347
-1.3%
1.01x
SortStringsUnicode
23042
22860
-0.8%
1.01x
StrToInt
19217
18965
-1.3%
1.01x(?)
ArrayAppend
3130
3112
-0.6%
1.01x(?)
LinkedList
26288
26108
-0.7%
1.01x(?)
StringBuilder
8351
8250
-1.2%
1.01x(?)
ObjectiveCBridgeStubFromArrayOfNSString
113665
112449
-1.1%
1.01x(?)
ArrayValueProp4
2484
2449
-1.4%
1.01x
ArraySubscript
5398
5380
-0.3%
1.00x(?)
ObjectiveCBridgeToNSString
1052
1052
+0.0%
1.00x
ObjectiveCBridgeStubToNSString
1663
1667
+0.2%
1.00x
ClassArrayGetter
1182
1183
+0.1%
1.00x(?)
Array2D
759861
760971
+0.1%
1.00x
Histogram
13495
13503
+0.1%
1.00x(?)
MonteCarloPi
50444
50489
+0.1%
1.00x(?)
StringWithCString
73856
73828
-0.0%
1.00x(?)
ObjectiveCBridgeFromNSStringForced
2605
2597
-0.3%
1.00x(?)
Prims
14107
14082
-0.2%
1.00x(?)
Dictionary3OfObjects
2653
2652
-0.0%
1.00x(?)
RangeAssignment
12817
12807
-0.1%
1.00x(?)
SuperChars
720170
720255
+0.0%
1.00x(?)
XorLoop
18026
18042
+0.1%
1.00x(?)
ObjectiveCBridgeStubFromNSStringRef
649
649
+0.0%
1.00x
StaticArray
17222
17296
+0.4%
1.00x(?)
ProtocolDispatch
5395
5398
+0.1%
1.00x(?)
ObjectAllocation
1282
1277
-0.4%
1.00x(?)
ArrayLiteral
1039
1038
-0.1%
1.00x(?)
HashTest
6172
6158
-0.2%
1.00x(?)
Dictionary3
2024
2023
-0.1%
1.00x(?)
Dictionary2
5100
5094
-0.1%
1.00x(?)
StrComplexWalk
8557
8558
+0.0%
1.00x(?)
SetIntersect_OfObjects
18947
18892
-0.3%
1.00x(?)
ArrayOfRef
8836
8796
-0.5%
1.00x
ObjectiveCBridgeToNSArray
30251
30255
+0.0%
1.00x(?)
DictionaryOfObjects
6904
6931
+0.4%
1.00x(?)
CaptureProp
52080
52161
+0.2%
1.00x(?)
RC4
8433
8430
-0.0%
1.00x(?)
MapReduce
41976
41773
-0.5%
1.00x
Hanoi
18879
18903
+0.1%
1.00x(?)
SetIsSubsetOf
3012
3002
-0.3%
1.00x
SetIntersect
18957
18953
-0.0%
1.00x(?)
SetExclusiveOr
48910
48885
-0.1%
1.00x(?)
RGBHistogramOfObjects
114910
114596
-0.3%
1.00x(?)
ArrayInClass
3562
3560
-0.1%
1.00x(?)
ArrayOfGenericRef
9464
9493
+0.3%
1.00x(?)
Sim2DArray
13160
13155
-0.0%
1.00x(?)
SetExclusiveOr_OfObjects
67180
67096
-0.1%
1.00x(?)
MonteCarloE
102055
102489
+0.4%
1.00x(?)
SetUnion_OfObjects
51266
51226
-0.1%
1.00x(?)
StringHasSuffixUnicode
64403
64445
+0.1%
1.00x(?)
Walsh
11993
11994
+0.0%
1.00x(?)
SetIsSubsetOf_OfObjects
2836
2840
+0.1%
1.00x
DictionaryRemove
30238
30204
-0.1%
1.00x(?)
NSStringConversion
2596
2608
+0.5%
1.00x(?)
RGBHistogram
65805
65844
+0.1%
1.00x(?)
SetUnion
35038
35061
+0.1%
1.00x(?)
BitCount
92
92
+0.0%
1.00x
AngryPhonebook
6087
6080
-0.1%
1.00x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToStringForced
159358
158771
-0.4%
1.00x(?)
ArrayValueProp
2176
2172
-0.2%
1.00x(?)
120
5250686
5254294
+0.1%
1.00x
GlobalClass
0
0
+0.0%
1.00x
Memset
18649
18643
-0.0%
1.00x(?)
ArrayValueProp2
17864
17913
+0.3%
1.00x
SevenBoom
1436
1430
-0.4%
1.00x(?)
StackPromo
161665
164036
+1.5%
0.99x
RecursiveOwnedParameter
7555
7607
+0.7%
0.99x
ObjectiveCBridgeFromNSDictionaryAnyObjectToString
195015
196489
+0.8%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectToString
156329
157882
+1.0%
0.99x(?)
ObjectiveCBridgeFromNSDictionaryAnyObjectForced
7059
7137
+1.1%
0.99x(?)
ObjectiveCBridgeFromNSArrayAnyObjectForced
6948
7012
+0.9%
0.99x(?)
DictionarySwap
11425
11532
+0.9%
0.99x(?)
StringInterpolation
15303
15419
+0.8%
0.99x(?)
ObjectiveCBridgeStubFromNSString
1122
1130
+0.7%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObject
103827
104526
+0.7%
0.99x(?)
ProtocolDispatch2
425
428
+0.7%
0.99x
NSError
634
639
+0.8%
0.99x(?)
PolymorphicCalls
1137
1151
+1.2%
0.99x(?)
Calculator
938
952
+1.5%
0.99x
DictionaryLiteral
20228
20461
+1.1%
0.99x(?)
ObjectiveCBridgeFromNSString
5072
5105
+0.7%
0.99x(?)
Phonebook
84595
85233
+0.8%
0.99x(?)
ObjectiveCBridgeFromNSSetAnyObjectForced
7430
7504
+1.0%
0.99x(?)
DeadArray
136053
137218
+0.9%
0.99x(?)
ArrayValueProp3
2503
2519
+0.6%
0.99x
Dictionary2OfObjects
6866
6903
+0.5%
0.99x(?)
TwoSum
9227
9288
+0.7%
0.99x(?)
DictionarySwapOfObjects
25014
25456
+1.8%
0.98x
DictionaryBridge
3669
3753
+2.3%
0.98x(?)
Dictionary
4130
4199
+1.7%
0.98x(?)
ObjectiveCBridgeFromNSArrayAnyObject
65215
66489
+1.9%
0.98x(?)
NSDictionaryCastToSwift
9712
9926
+2.2%
0.98x
ObjectiveCBridgeStubToArrayOfNSString
30388
31338
+3.1%
0.97x
ObjectiveCBridgeToNSDictionary
16430
16901
+2.9%
0.97x(?)
**Hardware Overview**
Model Name: Mac mini
Model Identifier: Macmini7,1
Processor Name: Intel Core i7
Processor Speed: 3 GHz
Number of Processors: 1
Total Number of Cores: 2
L2 Cache (per Core): 256 KB
L3 Cache: 4 MB
Memory: 16 GB
@swift-ci Please test
It looks like the Linux build issues continues to affect things?
ERROR: testREPL (TestREPLArray.REPLArrayTestCase)
@swift-ci Please test
I noted a few stylistic things that should be changed, but this is good enough to accept now and polish later.
@gparker42 I will work on the changes outlined and open a new pull request when ready. Thanks
| gharchive/pull-request | 2016-03-30T08:55:49 | 2025-04-01T06:37:56.359823 | {
"authors": [
"benlangmuir",
"gparker42",
"gribozavr",
"jckarter",
"nadavrot",
"shahmishal",
"shawnce",
"swift-ci",
"tinysun212"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/1950",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
435367887 | [stdlib] Fix return type of swift_{uint64,int64,float*}ToString
The return type of these functions are uint64_t in Stubs.cpp but UInt in the Swift code; this changes the Swift code to match the C++ return type.
Found when compiling the stdlib for WebAssembly, which requires that all return types match: UInt maps to i32 while uint64_t maps to i64, so functions calling these functions fail the validation.
CC: @airspeedswift
@airspeedswift would you be able to have a look please? Is there anyone who else who could be pinged about reviewing this PR?
@swift-ci please smoke test
Thanks @zhuowei. Sorry that we didn't see this earlier. FWIW, your best bet is to tag me or @tbkka for this stuff.
N.B. this was a "safe" return type mismatch because the actual implementation has a signature compatible with the signature used; the high 32b of the result were simply ignored by the caller on 32b targets, but they are semantically guaranteed to be zero anyway.
The return value here is the length of the formatted string, so a 32-bit value would be preferable to avoid overhead on 32-bit platforms. I believe this is all internal, so changing the type won't break the ABI.
Of course, that might mean touching more places to get the types to line up all the way down.
Does it mean that this PR needs any more changes to pass the review and be merged? I'm a co-maintainer of @swiftwasm, and as far as I'm aware @zhuowei is not actively maintaining it currently, but I have access to the PR branch and I'm ready to push it forward and to apply any changes if needed
I agree with @tbkka that it would be better if these just returned int32. But, the cpp functions are marked SWIFT_RUNTIME_STDLIB_API, so we formally can't modify them (they are API), and the difference in efficiency is minimal.
@MaxDesiatov since we know that the result is always in-range, can you replace the Int inits (line 172 and similar) with Int(truncatingIfNeeded: ...)? This will eliminate the check so that the only overhead on 32b platforms is zeroing out a register, which is sufficiently cheap to not worry about.
Actually, I'll just merge this and make the other change myself as a follow on. Thanks all!
| gharchive/pull-request | 2019-04-20T07:46:45 | 2025-04-01T06:37:56.368855 | {
"authors": [
"MaxDesiatov",
"compnerd",
"stephentyrone",
"tbkka",
"zhuowei"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/24181",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
158025619 | Fix off-by-one in @noescape fixit
What's in this pull request?
This
func noescapeD(@noescape f: () -> Bool) {}
used to become this
func noescapeD( f: @noescape() -> Bool) {}
It now becomes
func noescapeT(f: @noescape () -> Bool) {}
Moreover this
func autoclosureD(@autoclosure f: () -> Bool) {}
used to become this
func autoclosureD( f: @autoclosure@noescape() -> Bool) {}
It now becomes
func autoclosureD(f: @autoclosure @noescape () -> Bool) {}
Before merging this pull request to apple/swift repository:
[ ] Test pull request on Swift continuous integration.
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please smoke test
All supported platforms | @swift-ci Please smoke test and merge
OS X platform | @swift-ci Please smoke test OS X platform
Linux platform | @swift-ci Please smoke test Linux platform
Validation Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please test
All supported platforms | @swift-ci Please test and merge
OS X platform | @swift-ci Please test OS X platform
OS X platform | @swift-ci Please benchmark
Linux platform | @swift-ci Please test Linux platform
Lint Testing
Language | Comment
------------ | -------------
Python | @swift-ci Please Python lint
Note: Only members of the Apple organization can trigger swift-ci.
@swift-ci Please fix
@slavapestov I wish it worked that way...
@swift-ci please test
Oh man, this is not the first time I asked CI to 'please fix'. I guess I'm just begging our AI overlords to automate me out of a job...
The Linux failure is unrelated. @shahmishal?
Otherwise this LGTM.
| gharchive/pull-request | 2016-06-01T22:58:10 | 2025-04-01T06:37:56.375421 | {
"authors": [
"CodaFi",
"harlanhaskins",
"slavapestov"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/2828",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
650619834 | Update README for new target names
@swift-ci smoke test and merge
@swift-ci smoke test and merge
Hmm. Why did the smoke tests not run? 😕
@swift-ci please smoke test and merge
| gharchive/pull-request | 2020-07-03T14:06:56 | 2025-04-01T06:37:56.376995 | {
"authors": [
"CodaFi",
"Jumhyn",
"varungandhi-apple"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/32701",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
658748273 | [ast] Rename VarPattern -> BindingPattern.
VarPattern is today used to implement both 'let' and 'var' pattern bindings, so
today is already misleading. The reason why the name Var was chosen was done b/c
it is meant to represent a pattern that performs 'variable binding'. Given that
I am going to add a new 'inout' pattern binding to this, it makes sense to
give it now a better fitting name before I make things more confusing.
Its actually a NFC.
@swift-ci test
TSPL refers to it as “value-binding pattern”. Should it be reflected here (i.e. ValueBindingPattern) or should TSPL be updated? Or does it not matter at all?
I don't think it matters. And I am not sure the larger name helps. I am trying not to change things in a large way. Only what I need.
@theblixguy the bigger change here is that I am going to change how it represents lets/vars to use a true kind + exhaustive switches instead of isLet(). That will make it easier to update this later. This is just the first in a series of changes.
| gharchive/pull-request | 2020-07-17T01:56:31 | 2025-04-01T06:37:56.380210 | {
"authors": [
"gottesmm",
"theblixguy"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/32940",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
166942389 | id-as-Any support
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
[ ] Test pull request on Swift continuous integration.
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please smoke test
All supported platforms | @swift-ci Please smoke test and merge
OS X platform | @swift-ci Please smoke test OS X platform
Linux platform | @swift-ci Please smoke test Linux platform
A smoke test on macOS does the following:
Builds the compiler incrementally.
Builds the standard library only for macOS. Simulator standard libraries and
device standard libraries are not built.
lldb is not built.
The test and validation-test targets are run only for macOS. The optimized
version of these tests are not run.
A smoke test on Linux does the following:
Builds the compiler incrementally.
Builds the standard library incrementally.
lldb is built incrementally.
The swift test and validation-test targets are run. The optimized version of these
tests are not run.
lldb is tested.
Validation Testing
Platform | Comment
------------ | -------------
All supported platforms | @swift-ci Please test
All supported platforms | @swift-ci Please test and merge
OS X platform | @swift-ci Please test OS X platform
OS X platform | @swift-ci Please benchmark
Linux platform | @swift-ci Please test Linux platform
Lint Testing
Language | Comment
------------ | -------------
Python | @swift-ci Please Python lint
Note: Only members of the Apple organization can trigger swift-ci.
Apparently direct casting is all working now!
But indirect casting
(bouncing through Any) fails in really strange ways, without reaching
any known stdlib entry points.
@swift-ci Please test Linux platform
@swift-ci Please test and merge
@swift-ci Please test and merge
@swift-ci Please test and merge
@swift-ci Please test and merge
| gharchive/pull-request | 2016-07-21T23:44:59 | 2025-04-01T06:37:56.387989 | {
"authors": [
"dabrahams"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/3671",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
935106047 | [Reflection] Fix iterateAsyncTaskAllocations.
Fix the declaration of AsyncTask and add a test for iterateAsyncTaskAllocations. Reflection's declaration of AsyncTask had fallen out of sync with the real thing. The test that was supposed to catch this was never actually committed, oops.
While we're in there, switch out uses of Builtin.getCurrentAsyncTask for the less error prone _getCurrentAsyncTask.
rdar://80035307
@swift-ci please test
Build failed
Swift Test Linux Platform
Git Sha - f0e41d7414ae943e156e68664e08620cab74c723
Build failed
Swift Test OS X Platform
Git Sha - f0e41d7414ae943e156e68664e08620cab74c723
@swift-ci please test
@swift-ci please test
@swift-ci please test
| gharchive/pull-request | 2021-07-01T18:23:19 | 2025-04-01T06:37:56.391690 | {
"authors": [
"mikeash",
"swift-ci"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/38203",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1096296121 | AllocStackHoisting: fix the check for availability-checks
This is not a function call anymore, but a builtin
rdar://87090714
@swift-ci test
| gharchive/pull-request | 2022-01-07T12:58:59 | 2025-04-01T06:37:56.392832 | {
"authors": [
"eeckstein"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/40761",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1179973795 | sema: set locator properly when diagnosing constness mismatches
rdar://90210674
@swift-ci please smoke test
| gharchive/pull-request | 2022-03-24T19:48:47 | 2025-04-01T06:37:56.393915 | {
"authors": [
"nkcsgexi"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/42010",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
181056465 | Add descriptive doc comments to withMemoryRebound(to:capacity:_:) and…
… bindMemory(to:capacity:).
SR-2480: Improve documentation for withMemoryRebound(to:capacity:_:)
rdar://problem/28440528
––– CCC Information –––
• Explanation: Users migrating to Swift 3 often hit a compiler error with a diagnostic pointing them to this API. I have interacted with several developers who don't understand how to use the API. A more detailed description was necessary in the doc comments.
• Scope of Issue: Developers migrating to Swift 3 and using UnsafePointers.
• Origination: SE-0107 UnsafeRawPointer--terse doc comments.
• Risk: None whatsoever.
• Reviewed By: Dave Abrahams
• Testing: None needed.
• Directions for QE: None
@swift-ci test.
@swift-ci test OS X.
@swift-ci test OS X
Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 36f3921f65b3afb00582c4341800963bf0fb2c0e
Test requested by - @bob-wilson
This failed because it was merged before testing was completed.
| gharchive/pull-request | 2016-10-05T03:22:33 | 2025-04-01T06:37:56.398192 | {
"authors": [
"atrick",
"bob-wilson",
"shahmishal",
"swift-ci"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/5129",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1466984469 | Fix and re-enable test resilient_debug_value.sil
In non-asserts compiler we don't seem to get named llvm values.
rdar://102535969
@swift-ci test
| gharchive/pull-request | 2022-11-28T19:36:12 | 2025-04-01T06:37:56.399594 | {
"authors": [
"aschwaighofer"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/62280",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1570700483 | allow move-only types to conform to Sendable
Part of the reason why we do not want to
permit conformance to protocols for
move-only types is that they're
fundamentally wrong: all existing protocols
assume the type is copyable, so we'd be
allowing people to write conformances to
things that are not actually true.
The other aspect of it is that we may
need to change the runtime representation
for conformance descriptors of move-only
types. So we can't have these conformances
leaving residue at runtime. Luckily, that
means marker protocols would be OK,
since they leave no residue at runtime.
So for, now we're going to specifically
permit move-only types to conform to the
marker protocol Sendable since it's needed
for move-only types to work with concurrency.
All of the existing rules about mixing
move-only types with generics still apply.
That means you still can't turn it into the
existential any Sendable in any way at all,
despite it conforming. The purpose of the
conformance is purely to allow the concrete
instances to cross actor isolation boundaries
if it is actually Sendable.
resolves rdar://104987062
@swift-ci please smoke test and merge
@swift-ci please smoke test and merge
| gharchive/pull-request | 2023-02-04T01:50:46 | 2025-04-01T06:37:56.403847 | {
"authors": [
"kavon"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/63427",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1752428601 | [SILGen] Emit block after unreachable when emitting if/switch expressions
When emitting the underlying switch statement for a switch expression, we emit an unreachable if the subject is uninhabited. Statement emission code can handle this, but expression emission expects an RValue to handed back. To remedy this, emit an unreachable block that we can emit the rest of the expression emission code into. The SILOptimizer will then drop this unreachable block.
Resolves #66490
@swift-ci please test
@swift-ci please test Windows
| gharchive/pull-request | 2023-06-12T10:30:57 | 2025-04-01T06:37:56.405690 | {
"authors": [
"hamishknight"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/66551",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1933519623 | NFC: Remove ClangModuleLoader.h include from ExtInfo.h
This was unnecessarily pulling in a whole bunch of Clang headers when all was needed was a forward declaration.
@swift-ci please smoke test
@swift-ci please smoke test
@swift-ci please smoke test
| gharchive/pull-request | 2023-10-09T17:39:51 | 2025-04-01T06:37:56.407327 | {
"authors": [
"hamishknight"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/69074",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2017217045 | Frontend: Add -experimental-skip-non-inlinable-function-bodies-is-lazy
This option causes the -experimental-lazy-typecheck and -experimental-skip-non-exportable-decls options to be inferred from the presence of -experimental-skip-non-inlinable-function-bodies. This new option is meant to be a temporary testing aid that allows lazy typechecking to be tested on projects without full build system support for passing the other flags to the right jobs.
Also, ignore -experimental-lazy-typecheck during interface verification jobs, since the flag does not make sense during that action but the driver will pass the flag down regardless.
Resolves rdar://118938251
@swift-ci please smoke test
| gharchive/pull-request | 2023-11-29T18:53:41 | 2025-04-01T06:37:56.409210 | {
"authors": [
"tshortli"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/70095",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
205309496 | Handle implicit member references inside extensions of nested types
Within an extension, references to other members of the extended type are permitted without qualification. This is intended to work even when the extended type was a nested type, although members of the enclosing type are not visible in this case. In order to implement this, the type checker pre-checks to see if there are any members with this name and then rewrites the unqualified reference to a qualified one, based on an unresolved TypeExpr with the name of the enclosing type. Unfortunately, if the enclosing type is a nested type, that isn't going to work very well—we find the correct declaration, but fail to map it into context by virtue of not realizing where it came from. Fix this by explicitly checking for this case.
SR-3847
@swift-ci Please test
Oh I see, thanks.
Does that mean the fix makes sense? I admit I'm not very familiar with this part of name resolution.
Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ac5cb46c2c2e14201fc8fcb93bf74842c04da34b
Test requested by - @jrose-apple
Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ac5cb46c2c2e14201fc8fcb93bf74842c04da34b
Test requested by - @jrose-apple
@swift-ci Please test
Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - ac5cb46c2c2e14201fc8fcb93bf74842c04da34b
Test requested by - @jrose-apple
Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - ac5cb46c2c2e14201fc8fcb93bf74842c04da34b
Test requested by - @jrose-apple
mapTypeIntoContext() translates interface types to archetypes. Here, I think the code path is resolving an unbound generic reference, which implicitly gets generic parameters from context.
LGTM, by the way. Longer term, we should try to remove findDeclContextForType() altogether. It duplicates the DeclContext walk that's already done in AST/NameLookup.cpp, because we just throw out that information in UnqualifiedLookup. That's really stupid and it causes assertions because apparently the walk here is slightly different than the one name lookup does...
Test case added.
@swift-ci Please smoke test
Unrelated crash in serialization. @aciidb0mb3r, have you seen this before? Did you file it already?
3. While type-checking expression at [/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swiftpm/Sources/PackageGraph/PackageGraphLoader.swift:111:35 - line:111:118] RangeText="externalModuleDependencies.lazy.map({$0.name}).duplicates(modules.lazy.map{$0.name})"
4. While loading members for 'LazyMapRandomAccessCollection' in module 'Swift'
5. While deserializing 'init' (ConstructorDecl #11643)in 'Swift'
6. While deserializing 'transform' (ParamDecl #22123)in 'Swift'
@swift-ci Please smoke test Linux
@jrose-apple Haven't seen that one, seems new
Another failure.
swift: /home/buildnode/disk2/workspace/swift-PR-Linux-smoke-test/branch-master/swift/lib/AST/ArchetypeBuilder.cpp:2484: auto swift::ArchetypeBuilder::getGenericEnvironment(swift::GenericSignature *)::(anonymous class)::operator()(swift::ArchetypeBuilder::PotentialArchetype *) const: Assertion `(inContext->isEqual(repInContext) || inContext->hasError() || repInContext->hasError()) && "Potential archetype mapping differs from representative!"' failed.
@swift-ci Please smoke test Linux
| gharchive/pull-request | 2017-02-04T01:04:07 | 2025-04-01T06:37:56.420035 | {
"authors": [
"aciidb0mb3r",
"jrose-apple",
"slavapestov",
"swift-ci"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/7241",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2212888136 | [Demangler] Fix assertion failure.
It's illegal to call node->addChild() with a NULL child argument; it's possible to construct unexpected Node trees by passing invalid manglings, and in this case that was causing popTypeAndGetChild() to fail (because the top node was not a Type node), which then meant that the call to addChild had a NULL child argument.
The simplest fix is to use createWithChildren() to do the node construction, because that function checks its arguments for NULLs.
rdar://125350219
@swift-ci Please smoke test
| gharchive/pull-request | 2024-03-28T10:39:33 | 2025-04-01T06:37:56.422508 | {
"authors": [
"al45tair"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/72653",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2348105932 | [6.0][region-isolation] Dont crash when processing global actor isolated init accessors.
This just means that I stopped treating it like an actor instance isolated thing. This was fun to track down since ActorIsolation has a union in it that was being misinterpreted, leading to memory corruption... my favorite! = ).
rdar://129256560
(cherry picked from commit f035590784023f16136abd7b593151b3f0375829)
Going to add CCC in the morning
@swift-ci test
Original: https://github.com/apple/swift/pull/74321
| gharchive/pull-request | 2024-06-12T08:05:57 | 2025-04-01T06:37:56.424695 | {
"authors": [
"gottesmm"
],
"repo": "apple/swift",
"url": "https://github.com/apple/swift/pull/74326",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
246526055 | Fix HTTP client with incluster config
Remove inclusterconfig option https://github.com/appscode/searchlight/blob/master/docs/guides/cluster-alerts/json_path.md
Fixed
| gharchive/issue | 2017-07-29T14:57:16 | 2025-04-01T06:37:56.462041 | {
"authors": [
"tamalsaha"
],
"repo": "appscode/searchlight",
"url": "https://github.com/appscode/searchlight/issues/166",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1695858029 | [Docs]: Upgrade to Business Edition - Kubernetes
Is there an existing issue for this?
[X] I have searched the existing issues
Documentation Link
https://docs.appsmith.com/getting-started/setup/upgrade-to-business-edition/kubernetes
Discord/slack/intercom Link
No response
Describe the problem and improvement.
Rehaul the doc
fixed by https://github.com/appsmithorg/appsmith-docs/pull/1324
| gharchive/issue | 2023-05-04T11:52:21 | 2025-04-01T06:37:56.473380 | {
"authors": [
"danciaclara",
"jnikhila"
],
"repo": "appsmithorg/appsmith-docs",
"url": "https://github.com/appsmithorg/appsmith-docs/issues/1208",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2059122181 | Update disable-user-signup.md
Checklist
I have:
[x] run the content through Grammarly
[ ] linked to sample apps when relevant
[ ] added the meta description for each page in the PR
[x] minimized the callouts and added only when necessary
[ ] added the queryString parameter to the Tabs (if used)
[ ] masked PII in images. For example, login credentials, account details, and more
[ ] added images only when necessary
[ ] deleted the images that are no longer used for the updated pages in the PR
[ ] followed the image file naming convention while renaming or adding new images. (Use lowercase letters, dashes between words, and be as descriptive as possible)
[ ] used the <figure/> tag instead of a markdown representation for images
[ ] added the <figcaption/> tag to add a caption to the image
[ ] added the alt attribute in the <img/> tag
[ ] verified and updated the cross-references or created redirect rules for the changed or removed content
[x] reviewed and applied the style changes for UI formatting. For example, Bold the UI elements(Buttons on screen) used in the doc.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
| gharchive/pull-request | 2023-12-29T06:36:46 | 2025-04-01T06:37:56.479741 | {
"authors": [
"CLAassistant",
"DevDengChao"
],
"repo": "appsmithorg/appsmith-docs",
"url": "https://github.com/appsmithorg/appsmith-docs/pull/2016",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1176306880 | Test-event-driver docker command
Is there an existing issue for this?
[X] I have searched the existing issues
SubTasks
Docker commands for ted:
docker run --name appsmithted -d -p 2222:22 -p 5001:5001 -p 3306:3306 -p 28017:27017 -p 5432:5432 -p 25:25 -v `pwd`/git-server/keys:/git-server/keys -v `pwd`/git-server/repos:/git-server/repo --pull always appsmith/test-event-driver
Here's the repository link : https://github.com/appsmithorg/TestEventDriver
The issue here is that connecting to MySQL from the TED image doesn't work, and throws an SSL error sporadically. Disabling SSL also doesn't help.
Currently on-hold since MySQL doesn't seem to be coming up in the latest TED image which @Parthvi12 is looking into. Once that is running, I'll investigate the original issue again.
| gharchive/issue | 2022-03-22T06:03:56 | 2025-04-01T06:37:56.482577 | {
"authors": [
"Parthvi12",
"sharat87"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/issues/12063",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1725239694 | [Bug]: Auto-layout Jank issues
Is there an existing issue for this?
[X] I have searched the existing issues
Description
I have a few radio buttons in my app, and based on which radio button is selected a different input widget is shown - https://share.cleanshot.com/ZyXJsn86
If you see the GIF carefully, you will see that the input widget and date picker widget shifts a bit whenever the radio button selection is changed. This jank makes the UI look a bit bad. The logic to toggle between the input widget and date picker is very simple and is working perfectly.
I can confirm that this jank was not there before using auto layout. But after I started using auto layout, I am seeing this issue. Hopefully, this UI issue can be fixed.
Steps To Reproduce
Try a similar setup as described in the GIF here,
https://share.cleanshot.com/ZyXJsn86
Public Sample App
No response
Environment
Production
Issue video log
No response
Version
Cloud & Self - Hosted > 1.9.19
@narhzih Request you to correct the app version to Appsmith Community v1.9.20.4
@aswathkk I believe this is happening coz of row gap issue. Can you confirm?
Closing as we have a new layout builder
| gharchive/issue | 2023-05-25T07:21:11 | 2025-04-01T06:37:56.487274 | {
"authors": [
"Nikhil-Nandagopal",
"aritraroy",
"marks0351",
"narhzih"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/issues/23719",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1987271759 | [Task]: FE changes for Homepage experience - Search bar
Is there an existing issue for this?
[X] I have searched the existing issues
SubTasks
[ ] 1. Search bar UI
[ ] 2. API integration
[ ] 3. Real-time filtering to server side search with debounce
[ ] 4. Cypress
Reduced 0.5sp from this ticket as we are tracking cypress changes in this ticket https://github.com/appsmithorg/appsmith/issues/28980
fixed and merged in release. Hence closing the ticket
| gharchive/issue | 2023-11-10T09:43:41 | 2025-04-01T06:37:56.490364 | {
"authors": [
"ankitsrivas14",
"deepikaappsmith"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/issues/28788",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2118025381 | bug: adjust WDS caption text style
Currently it's bigger than body text, should be smaller than that (close or identical to footnote if we have range between that and body).
@ichik Is this issue ready to pick up? If yes, can you tell me the value we need for caption? I'll update it.
@jsartisan discussed on a call: just one (or two) steps smaller than body text.
| gharchive/issue | 2024-02-05T09:09:54 | 2025-04-01T06:37:56.491642 | {
"authors": [
"ichik",
"jsartisan"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/issues/30896",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
996687527 | [Task] Move the dataTree diff calculations back to worker
Diff calculation takes about 100ms and is directly proportional to data, so could be very high in some cases.
This was moved to main thread from worker to unblock a user. This was misdiagnosed as the diffs on workers being the reason.
Moving the diffs to main thread does effectively the same thing, there was no issue reported related to it in the last 30days.
@somangshu The data tree diff is taking 10-25 ms on the main thread (checked on multiple apps, depending on the size of the data tree). Moving this to worker thread should bring down time by the same.
Moving this to the icebox and out of the sprint, We do not plan to work on this right now.
| gharchive/issue | 2021-09-15T05:55:15 | 2025-04-01T06:37:56.493537 | {
"authors": [
"SatishGandham",
"ayushpahwa",
"somangshu"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/issues/7461",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1962052821 | test: Cypress | SetWidget property validations + CI Stabilize
Description
This PR added validations for SetWidget properties
Flaky fixes below:
/Widgets/Others/IconButton_2_spec.ts
Type of change
Script fix (non-breaking change which fixes an issue)
Testing
How Has This Been Tested?
[X] Cypress CI runs
Checklist:
QA activity:
[X] Added Test Plan Approved label after Cypress tests were reviewed
/ci-test-limit runId=6641552552
/ci-test-limit runId=6641552552
/ci-test-limit runId=6641552552
| gharchive/pull-request | 2023-10-25T19:07:58 | 2025-04-01T06:37:56.497122 | {
"authors": [
"Aishwarya-U-R"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/pull/28379",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1973710322 | chore: add analytics event for query failure post schema fetch pass
Description
Add event to capture scenario where the schema fetch succeeds but data fetch fails for schema preview page.
Fix a bug where the error message and error type values were interchanged before the Appsmith plugin exception was returned to client.
Fixes #28535 #28618
Media
Type of change
Bug fix (non-breaking change which fixes an issue)
Chore (housekeeping or task changes that don't impact user perception)
Testing
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant
[x] Manual
Not aware how to add automation test for this at the moment.
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag
QA activity:
[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed
/ok-to-test
/ok-to-test
| gharchive/pull-request | 2023-11-02T08:03:00 | 2025-04-01T06:37:56.506106 | {
"authors": [
"sumitsum"
],
"repo": "appsmithorg/appsmith",
"url": "https://github.com/appsmithorg/appsmith/pull/28574",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
495635089 | Adopt a volume-mounting Docker syntax that allows colons in path names
Is your feature request related to a problem? Please describe.
Please refer to https://github.com/appsody/appsody/issues/31
Describe the solution you'd like
Please refer to https://github.com/appsody/appsody/issues/31
Describe alternatives you've considered
Please refer to https://github.com/appsody/appsody/issues/31
Additional context
https://github.com/appsody/appsody/pull/338 is raised in appsody, a similar change in controller in this repo would compliment it
cc @kewegner
@gireeshpunathil why would the controller need this? The controller does not run docker commands.
The controller uses the APPSODY_MOUNTS environment variable in the case there are no APPSODY_WATCH_DIRS.
If we change the value of APPSODY_MOUNTS to have something other than ";" as a separator, the logic in the controller would have to change, because it splits on ";". See line 269 of main.go.
Ok, so to clarify, adopting the docker --mount syntax to allow colons does NOT need controller changes.
However if as a result we change the APPSODY_MOUNTS separator, then yes the controller needs to support this.
When this issue is done, we would also want to consider the separator for the APPSODY_WATCH_DIRs and the APPSODY_WATCH_IGNOREDIRS (PATHS). Since those are in a list using ';' as the separator.
We should address https://github.com/appsody/controller/issues/31 at the same time. Also the changes we made for single mount testing might be affected.
I have started to code this up and will work with @rykal-nate prior to Friday.
| gharchive/issue | 2019-09-19T07:57:02 | 2025-04-01T06:37:56.512396 | {
"authors": [
"gireeshpunathil",
"kewegner",
"kylegc"
],
"repo": "appsody/controller",
"url": "https://github.com/appsody/controller/issues/31",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
565402269 | Add ARG to allow appsody to pass docker-options for build-arg - WIP DO NOT MERGE
Checklist:
[ ] Read the Code of Conduct and Contributing Guidelines.
[ ] Followed the commit message guidelines.
[ ] Stack adheres to Appsody stack structure.
Modifying an existing stack:
[ ] Updated the stack version in stack.yaml
Contributing a new stack:
Describe how application dependencies are managed:
Explain how Appsody file watcher is utilized:
Describe other Appsody environment variables defined by the stack image:
Describe any limitations and known issues:
Related Issues:
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ragu Kattinakere seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.
@raguibm - Thanks for raising this. Please could you raise this as two separate PR's? (one for microprofile and one for open liberty)
| gharchive/pull-request | 2020-02-14T15:38:50 | 2025-04-01T06:37:56.519189 | {
"authors": [
"Kamran64",
"claassistantio",
"raguibm"
],
"repo": "appsody/stacks",
"url": "https://github.com/appsody/stacks/pull/673",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2242209936 | 🐛 Bug Report: Project creates two times
👟 Reproduction steps
Go to the console https://cloud.appwrite.io/console
Click "Create project"
Go trough the setup proccess
👍 Expected behavior
It should take me to the new project page right after clicking the button (of course with some delay because of some async stuff).
👎 Actual Behavior
At the end after clicking the "Create" button, nothing happens even after waiting a few seconds, but after I click it the second time, it takes me to the new project page. However now when I go to the console again, I can see two projects named the same, even tho I just wanted created one.
👀 Have you spent some time to check if this issue has been raised before?
[X] I checked and didn't find similar issue
🏢 Have you read the Code of Conduct?
[x] I have read the Code of Conduct
Also I apologise for accidentally creating the issue in the website repo, I had to move it here
Can reproduce this, probably a state management issue which re-enables the Create button before the setup is completed.
I proceeded to click the Create three times and 3 projects were created. Also note, if you provide a Project ID then the multiple projects will not be created and an error will be thrown.
Can reproduce this, probably a state management issue which re-enables the Create button before the setup is completed.
I proceeded to click the Create three times and 3 projects were created. Also note, if you provide a Project ID then the multiple projects will not be created and an error will be thrown.
Probable source -
https://github.com/appwrite/console/blob/737457c1446318c4f39fcc373024537af1bc09b6/src/lib/layout/wizard.svelte#L103-L105
Does the setTimeout() function have any purpose? Because I feel like this part of code doesn't make sense with the timeout there.
This is fixed in a recent release
| gharchive/issue | 2024-04-14T15:01:44 | 2025-04-01T06:37:56.578505 | {
"authors": [
"Honzoraptor31415",
"ItzNotABug",
"ernstmul"
],
"repo": "appwrite/console",
"url": "https://github.com/appwrite/console/issues/1033",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
576931848 | Ignore file or directory
(Translated) It would be interesting if there was a way to ignore files or directories within a main directory. Something like the git .gitignore file. Example: Ignore the project's .git directory.
(Original) Seria interessante se houvesse uma maneira de ignorar arquivos ou diretórios dentro de um diretório principal. Algo como o arquivo .gitignore do git. Exemplo: Ignorar o diretório .git do projeto.
@bomrafinha thanks for your advice! Currently this extension does not ignore any thing. However, I did considered to add configuration for users to specify ignore patterns, for example, node_modules and .git folders, etc. I'll do that as soon as I got some spare time 😺
emmm any news here?
I see the code load directoryIgnore in vscode.getConfiguration from config.ts
Could we load directoryIgnore from .gitignore default ?
should a .vscode/settings.json that has:
{
"asciiTreeGenerator.directoryIgnore": [
".git",
"node_modules",
"venv",
"__pycache__",
".vscode",
".idea",
".next",
".nuxt",
"dist",
"build",
"coverage"
]
}
for for line
directoryIgnore: vscode.workspace.getConfiguration().get<string[]>('asciiTreeGenerator.directoryIgnore'),
?
As this repository seems unmaintained, you might want to try another extension that has the feature you are asking for. It supports own ignore files, as well as using the .gitignore.
As this repository seems unmaintained, you might want to try another extension that has the feature you are asking for. It supports own ignore files, as well as using the .gitignore.
BTW:
Look this pr: https://github.com/aprilandjan/vscode-ascii-tree-generator/pull/20
It is have another future like fileTreeExtractor.showFileComment.
Maybe you can pick it to your repo.
| gharchive/issue | 2020-03-06T13:28:46 | 2025-04-01T06:37:56.592183 | {
"authors": [
"LennartCode",
"aprilandjan",
"bomrafinha",
"galer7",
"sz-p"
],
"repo": "aprilandjan/vscode-ascii-tree-generator",
"url": "https://github.com/aprilandjan/vscode-ascii-tree-generator/issues/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1681408537 | Testing Wolfi base image
Doing a test with Wolfi Alpine base.
Both curl and git cloning is failing due network related issues? Works fine locally, but in travis it is failing.
| gharchive/pull-request | 2023-04-24T14:27:59 | 2025-04-01T06:37:56.594828 | {
"authors": [
"turner-aptible"
],
"repo": "aptible/docker-alpine",
"url": "https://github.com/aptible/docker-alpine/pull/22",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
1680611386 | Vulnerabilities reported against "golang.org/x/sys/unix".
Context
In one of our projects we're using pact-broker docker image, which uses supersonic. We're re-packaging the pact-broker image to install some additional tooling (security / monitoring / etc) and harden the image. Then we scan that image with snyk.io.
The problem
snyk.io reports vulnerability in v0.0.0-20220615213510-4f61da869c0c version of golang.org/x/sys/unix which is a transitive vulnerability of supersonic. The detailed snyk report looks like this:
✗ Medium severity vulnerability found in golang.org/x/sys/unix
Description: Incorrect Privilege Assignment
Info: https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXSYSUNIX-3310442
Introduced through: golang.org/x/sys/unix@v0.0.0-20220615213510-4f61da869c0c
From: golang.org/x/sys/unix@v0.0.0-20220615213510-4f61da869c0c
Fixed in: 0.1.0
Organization: [REDACTED]
Package manager: gomodules
Target file: /usr/local/bin/supercronic-linux-amd64
Project name: github.com/aptible/supercronic
Docker image: [REDACTED].pact-broker
Licenses: enabled
Proposed solution
It seems that upgrading golang.org/x/sys/unix to 0.1.0 fixes the vulnerability.
v0.2.24
| gharchive/issue | 2023-04-24T07:16:45 | 2025-04-01T06:37:56.598216 | {
"authors": [
"UserNotFound",
"mkielar"
],
"repo": "aptible/supercronic",
"url": "https://github.com/aptible/supercronic/issues/126",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2693156919 | docs: Fix mage build command
Description
Replace mage build:all with mage build:binary.
Checklist
[ x ] I've read the guidelines for contributing to this repository.
[ ] I've added tests that prove my fix is effective or that my feature works.
[ x ] I've updated the documentation with the relevant information (if needed).
[ ] I've added usage information (if the PR introduces new options)
[ ] I've included a "before" and "after" example to the description (if the PR is a user interface change).
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
| gharchive/pull-request | 2024-11-26T05:23:16 | 2025-04-01T06:37:56.631727 | {
"authors": [
"CLAassistant",
"tom1299"
],
"repo": "aquasecurity/trivy-operator",
"url": "https://github.com/aquasecurity/trivy-operator/pull/2332",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2242049828 | Update Plugin Artifacts Links for v0.166.0
Automated changes by create-pull-request GitHub action
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
| gharchive/pull-request | 2024-04-14T08:49:15 | 2025-04-01T06:37:56.636456 | {
"authors": [
"CLAassistant",
"naortalmor1"
],
"repo": "aquasecurity/trivy-plugin-aqua",
"url": "https://github.com/aquasecurity/trivy-plugin-aqua/pull/780",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
605909839 | Shortcut Learning in Deep Neural Networks
一言でいうと
意図したものと違う要領で学習してしまう(形で区別してほしいのに位置を見てしまうなど)Shortcut learningに関する論文。画像、NLPなどタスクによらず一般的にそれらは存在する。通常はi.d.dを前提とした評価をする(ImageNetのtestセットなど)が、Out Of Distribution(ImageNetCなど)のデータでも評価しないと真の汎化性能は測れないとしている。
論文リンク
https://arxiv.org/abs/2004.07780
著者/所属機関
Robert Geirhos, Jörn-Henrik Jacobsen, Claudio Michaelis, Richard Zemel, Wieland Brendel, Matthias Bethge, Felix A. Wichmann
University of Tubingen, Germany
International Max Planck Research School for Intelligent Systems, Germany
University of Toronto, Vector Institute, Canada
投稿日付(yyyy/MM/dd)
2020/4/16
概要
新規性・差分
手法
結果
コメント
こちらの論文を題材にした記事
https://thegradient.pub/shortcuts-neural-networks-love-to-cheat/
| gharchive/issue | 2020-04-23T22:17:07 | 2025-04-01T06:37:56.684313 | {
"authors": [
"AkiraTOSEI",
"icoxfog417"
],
"repo": "arXivTimes/arXivTimes",
"url": "https://github.com/arXivTimes/arXivTimes/issues/1669",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
117068682 | Sending alerts when graphite server is not availible
Cabot sending tons of alerts when graphite server is unavailable or authentication has been failed.
It should send one information email and stop alerting per each check..
I agree that this can be annoying but it's difficult to know how big an issue no information is for you.
Do you have a proposal of what sort of notification you'd like to get? What about frequency? What if there's a general outage that kills your graphite machine as well as your whole infrastructure? Wouldn't you want to be notified?
Genuine question - for us this would be a critical issue and so we don't mind too many alerts (especially with the acknowledgement mechanism that recently landed) but would like to establish parameters around this.
I think that such alert emails should be sent to "administrator" but not to every single user which run graphite check ..
I think if the services Cabot is monitoring are mission-critical then a failure to be able to check if the services are working should itself be considered a critical failure... What you are describing wouldn't work for us, for example.
If you were to submit a PR for some ability to configure this I'd be happy to review and in theory to merge, but I don't think we should change this globally.
Closing this. The "official" workaround is to set up an HTTP check for graphite being up, and base your reaction on that. If you have a very specific solution I'd be happy to reopen.
| gharchive/issue | 2015-11-16T07:33:50 | 2025-04-01T06:37:56.692375 | {
"authors": [
"dbuxton",
"evgenyidf"
],
"repo": "arachnys/cabot",
"url": "https://github.com/arachnys/cabot/issues/287",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
445326317 | Enabled MiniGrid gyms.
Congratulations of this very very handy work making everyone happy. :->
Just want to start discussing this quick hack enabling to use MiniGrid gyms.
https://github.com/maximecb/gym-minigrid
but not limited to this.
Instead of hard-coding imports, I have provided a command-line option to dynamically import specified gym packages for train.py and enjoy.py.
Adaptation of observation space (Dict) is hard-coded.
I am not sure if this breaks others, while I tried to be careful not to.
Cheers,
Mich
Hello,
Thank you for your interest.
I like the idea. Please don't forget to update the readme with the new instructions ;)
The CI is failing because the docker image does not have minigrid installed... please add an exception in the test script so your trained models are not tested.
The CI is failing because the docker image does not have minigrid installed... please add an exception in the test script so your trained models are not tested.
Added --gym-packages gym_minigrid if "-MiniGrid-" in trained_model.
pip install gym-minigrid for docker scripts (cpu & gpu) as well.
Good, I'll test that on my local machine before pushing a new docker image (so the CI can pass)
I got qt segmentation fault on my machine trying to render the scene :/
Anyway, it seems ok otherwise.
I would also use the flat obs wrapper from minigrid: https://github.com/maximecb/gym-minigrid/blob/master/gym_minigrid/wrappers.py#L167
Better to exclude the cases from the test case for now?
Better to exclude the cases from the test case for now?
yep! (that was my first remark ;))
@tatsubori is that ok if I merge now and in another PR, you'll include a better support for minigrid? (using FlatObsWrapper for instance)
Yes, please proceed to merge. I have CNN impl with it at hand but it won’t converge. I am trying CNN+Lstm but it may take time.
Will continue enhancing it.
StableBaselines to support (not to fail) Dict is better to handle mission text, I believe, though.
StableBaselines to support (not to fail)
I agree, but the support is far from trivial ;) (however we would appreciate PR to solve that issue)
| gharchive/pull-request | 2019-05-17T08:31:33 | 2025-04-01T06:37:56.700087 | {
"authors": [
"araffin",
"tatsubori"
],
"repo": "araffin/rl-baselines-zoo",
"url": "https://github.com/araffin/rl-baselines-zoo/pull/22",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
395001865 | Add instructions to skip initialization on aragon dao install
If install command doesn't find initialization method, it won't
initialize the newly installed app, but this is not obvious from the
help instructions.
Although it's "dangerous", sometimes it's useful to install an app
without initializing. For instance, Token Manager: to initialize it
the token must be provided, and this token must have this new Token
Manager app as controller. Therefore token controller must be changed
in between creation and initialization of Token Manager app.
See https://github.com/aragon/aragon-cli/pull/312
I personally think it's fine for such a small PR like these one (and the one in aragon-cli) which doesn't even touch code. When I add 3 reviewers I'm not necessarily meaning "all of them" ("AND"), in this case it was more like "any of them" ("OR"). But not sure what the correct procedure is.
| gharchive/pull-request | 2018-12-31T16:18:39 | 2025-04-01T06:37:56.705256 | {
"authors": [
"bingen"
],
"repo": "aragon/hack",
"url": "https://github.com/aragon/hack/pull/73",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
498734467 | Arangosearch: PHRASE function combined with other filter not working
My Environment
ArangoDB Version: 3.5.0
Storage Engine: RocksDB
Deployment Mode: Single Server
Deployment Strategy: anual Start in Docker
Infrastructure: local
Total RAM in your machine: 16Gb
Disks in use: SSD
Used Package: Docker - official Docker library
Component, Query & Data
Affected feature: ArangoSearch
Search view:
{
"links": {
"my_collection": {
"analyzers": [
"identity"
],
"fields": {
"description": {
"analyzers": [
"text_en",
"identity"
]
},
"type": {},
"name": {
"analyzers": [
"text_en",
"identity"
]
}
},
"includeAllFields": false,
"storeValues": "none",
"trackListPositions": false
}
}
}
AQL query (if applicable):
FOR item IN my_view
SEARCH PHRASE(item.name, "foo bar", 'text_en') AND item.type == "my_type"
RETURN item
AQL explain (if applicable):
Execution plan:
Id NodeType Est. Comment
1 SingletonNode 1 * ROOT
2 EnumerateViewNode 1 - FOR item IN my_view SEARCH ((item.`type` == "my_type") && PHRASE(item.`name`, "foo bar", "text_en")) /* view query */
3 ReturnNode 1 - RETURN item
Indexes used:
none
Optimization rules applied:
Id RuleName
1 handle-arangosearch-views
Steps to reproduce
The query above returns no results and should return one.
The following queries all return the expected result:
Only one word in PHRASE search:
FOR item IN my_view
SEARCH PHRASE(item.name, "foo", 'text_en') AND item.type == "my_type"
RETURN item
No filter on type:
FOR item IN my_view
SEARCH PHRASE(item.name, "foo bar", 'text_en')
RETURN item
Using TOKEN instead of PHRASE:
FOR item IN objects_search_view
SEARCH ANALYZER(item.name in TOKENS("foo bar", 'text_en'), "text_en") AND item.type == "my_type"
RETURN item
Hi @darkheir,
Thank you for submitting the issue. Could you please share the dataset you use so we can reproduce the problem on our side?
I managed to reproduce the issue with this small set:
[
{
"_key":"identity--357447d7-9229-4ce1-b7fa-f1b83587048e",
"_id":"my_collection/identity--357447d7-9229-4ce1-b7fa-f1b83587048e",
"_rev":"_ZUy9LSS---",
"name":"SEKOIA",
"type":"identity"
},
{
"_key":"identity--1621d4d4-b67d-41e3-9670-f01faf20d111",
"_id":"my_collection/identity--1621d4d4-b67d-41e3-9670-f01faf20d111",
"_rev":"_ZUy9LSS--A",
"name":"Adversary Bravo",
"type":"identity"
}
]
I notice that the _rev fields look very similar. Could it be the issue ?
If you insert into the collection using this order, you get 0 results
doc1 => { "type": "person", "text": "foo" }
doc2 => { "type": "person", "text": "foo bar" }
Reversing insertion results, you get 1 result.
I agree with you @aveiros If I insert the documents in the opposite order then the search is working fine.
@Darkheir @aveiros thank you for your effort to reproducing this, we'll address the issue soon. I will keep you updated.
The fix will be available in the next minor release.
tested against docker 3.5 preview build and looks good :)
Hi @Darkheir and @aveiros,
Version 3.5.3, which includes a fix for this issue, has been released.
From the Changelog:
Fixed issue #10090: fix repeatable seek to the same document in
SEARCH operations for ArangoSearch views.
Please find the latest release in the download section.
Thank you for the release! We installed it and it fixes our issue :-)
| gharchive/issue | 2019-09-26T08:23:23 | 2025-04-01T06:37:56.727356 | {
"authors": [
"Darkheir",
"aveiros",
"gnusi",
"iurii-i-popov",
"maxkernbach"
],
"repo": "arangodb/arangodb",
"url": "https://github.com/arangodb/arangodb/issues/10090",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
220827499 | Admin UI design/Color palette and Typography
ArangoDB is a great idea. Market for NoSql database with relation/transaction support is wide open. ArangoDb has a potential to replace Mongodb as a mainstream database. I would like to suggest CSS design refresh for admin ui to give it more professional look. Color palette and typography also need improvements. Please consider using material design guidelines or check rethinkDB admin ui for a reference.
@hkernbach Semantic-Ui can also be used to create great looking ui. SUI also available for react.
Thanks for your comment. Optimizing look & feel and also updating the underlying JS technologies is on our roadmap. But currently it is not a top priority feature.
I would like to suggest CSS design refresh for admin ui to give it more professional look. Color palette and typography also need improvements.
Do you have examples for 'color palettes' and/or 'typography' ? What exactly do you dislike?
Please check Rethinkdb admin ui, Semantic-Ui and Material design. Are you using any front-end framework? VueJs is my personal favorite nowadays.
On 04/18/17 19:08, Zafar Ansari wrote:
Please check Rethinkdb admin ui https://www.rethinkdb.com/docs/,
Semantic-Ui https://semantic-ui.com and Material design
https://getmdl.io/components/index.html. Are you using any front-end
framework? VueJs is my personal favorite nowadays.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/arangodb/arangodb/issues/2420#issuecomment-294913204,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEx-Vbwtfer3xyQj30aQcjHLz2-J1igJks5rxO4PgaJpZM4M5kUt.
Hallo Claudius,
wie moechtest du denn mit dem Herren in diesem Punkt umgehen? Vielleicht
nimmst du dich dem besser an.
Gruss,
Willi
| gharchive/issue | 2017-04-11T03:13:18 | 2025-04-01T06:37:56.734887 | {
"authors": [
"ansarizafar",
"dothebart",
"hkernbach"
],
"repo": "arangodb/arangodb",
"url": "https://github.com/arangodb/arangodb/issues/2420",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
592031165 | Check MSVC_VERSION instead of CMAKE_GENERATOR
Backport of https://github.com/arangodb/arangodb/pull/11351.
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9261/
http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr-linux/10997/
http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr-linux/11001/
Tests blue.
| gharchive/pull-request | 2020-04-01T16:05:48 | 2025-04-01T06:37:56.737555 | {
"authors": [
"KVS85"
],
"repo": "arangodb/arangodb",
"url": "https://github.com/arangodb/arangodb/pull/11368",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
717998818 | always show documents for a collection in web interface
Scope & Purpose
Always show documents for a collection in web interface, regardless of what collection.count() says. This fixes a potential race between fetching the count and fetching the documents.
[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :hammer: Refactoring
[ ] :book: CHANGELOG entry made
[x] :muscle: The behavior in this PR was manually tested
[ ] :computer: The behavior change can be verified via automatic tests
Backports:
[ ] No backports required
[ ] Backports required for: (Please specify versions)
Testing & Verification
[x] This change is a trivial rework / code cleanup without any test coverage.
http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/12219/
Tests blue.
| gharchive/pull-request | 2020-10-09T09:30:49 | 2025-04-01T06:37:56.741980 | {
"authors": [
"KVS85",
"jsteemann"
],
"repo": "arangodb/arangodb",
"url": "https://github.com/arangodb/arangodb/pull/12813",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
1950250126 | Add Option to Break Harvest Block
Hi there! I hope it's fine to request a feature here.
I would like to have an option to have the plugin break the harvest block and drop the items to the ground in order to collect them instead of putting them straight into the inventory. It is very convenient the way the plugin works right now but it is feeling far less rewarding.
I don't think this option would defeat the purpose of the plugin since automatic replanting itself and being able to hold down right click is still a breeze for harvesting large fields. It should probably not be the default configuration though as most people probably like the current behavior best.
Hi there! I think I can fulfill your request 👌
Thank you so much for adding the option I've requested! Also it's amazing how quickly you acted on it. Thank you.
I've had a chance to test it out and I think it adds exactly what I've been missing in the original implementation. I have a few other suggestions to further improve upon it though. I hope it's fine to add my thoughts here:
Add Block Breaking Effect
I think it needs a bit more work to appear just like vanilla's block breaking. Firstly the particle animation is missing entirely and secondly the configured sound from the configuration still plays. Instead the block's breaking sound should play.
In order to help a bit with this change and not just ask I've researched a bit and I think this fuction adds at least the particles, maybe even the correct sound.
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/World.html#playEffect(org.bukkit.Location,org.bukkit.Effect,T)
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/Effect.html#STEP_SOUND
The block's Material can be accessed by calling getType on the Block and the Effect should probably be STEP_SOUND judging by the Enum's descriptions. The effect should be called on the world to make it visible to all players. This would override the custom sound which then probably only applies to dispensers. But since this might have the potential to cause some lag it would be best to make it configurable. Maybe by default the effect should be played only for the player themselves and optionally it's called on the world?
These are just some thoughts and possible implementation ideas. I've never written a server plugin before but seeing your commits helped me understand it all a bit better. I hope this is a help. Thank you again for your work!
| gharchive/issue | 2023-10-18T17:08:05 | 2025-04-01T06:37:56.747494 | {
"authors": [
"Tails32",
"aratakileo"
],
"repo": "aratakileo/quick-harvest-plugin",
"url": "https://github.com/aratakileo/quick-harvest-plugin/issues/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1192702813 | 🛑 Test loibra.moo.com is down
In 14b3367, Test loibra.moo.com (http://loibra.mooo.com/) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Test loibra.moo.com is back up in 5a299c6.
| gharchive/issue | 2022-04-05T06:55:07 | 2025-04-01T06:37:56.751465 | {
"authors": [
"aratan"
],
"repo": "aratan/Monitorizaci-n",
"url": "https://github.com/aratan/Monitorizaci-n/issues/383",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
638313133 | Pickling of _VariableFunctions not compatible with PyTorch 1.5.0
pickling of _VariableFunctions not compatible with PyTorch 1.5.0
It would thus be useful if the version of PyTorch can be specified in the env.yml
Thanks for bringing this up. It seems like a recent change in pytorch is causing the break. Will pin to a specific version for now and will switch to torch.save in upcoming releases.
| gharchive/issue | 2020-06-14T09:03:24 | 2025-04-01T06:37:56.754250 | {
"authors": [
"aravindr93",
"chinmay-singh"
],
"repo": "aravindr93/mjrl",
"url": "https://github.com/aravindr93/mjrl/issues/27",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
724743221 | Add a ray class and a test for ray-box intersection
The ray class is based on Damien's original commit.
A function is added for ray-box intersections.
A question not blocking the PR: is there a reason for us to normalize direction in the first place? Certainly, not in the intersects test, but where would you think it would be helpful?
| gharchive/pull-request | 2020-10-19T15:40:29 | 2025-04-01T06:37:56.763612 | {
"authors": [
"aprokop",
"wjge"
],
"repo": "arborx/ArborX",
"url": "https://github.com/arborx/ArborX/pull/414",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
1367776669 | [FEATURE] Dynamic damage on attacks
Is your feature request related to a problem? Please describe.
A lot of summons increases the damage to attacks when the spell is upcast. Currently it's not possible to increase the damage on attacks on an actor sheet through the summoning. (to my knowledge, but it might be possible with attributes?)
Describe the solution you'd like
An option to add damage to certain attacks based on level.
The summoning spell's roll data is made available to the summoned actor, so you can add @summoner.item.level into a damage formula to get the spell level that was used for the summoning. Check out the readme for more info.
| gharchive/issue | 2022-09-09T12:43:27 | 2025-04-01T06:37:56.765802 | {
"authors": [
"Ikabodo",
"arbron"
],
"repo": "arbron/fvtt-summoner",
"url": "https://github.com/arbron/fvtt-summoner/issues/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1014092099 | Bug in the navbar
Describe the bug
On clicking Adopt or About on the navbar, the bottom border does not shift (to the one that is clicked).
Hey, can I fix this as a part of Hacktoberfest 2021? @AnandDhakane01 @majjikishore007
Hey, can I fix this as a part of Hacktoberfest 2021? @AnandDhakane01 @majjikishore007
Hii, we are glad you are willing to contribute, we have actually decided to change the complete UI/UX of the site to a much better design and theme. You can check out the design here design. Let me know if you are willing to work on any of the unassigned pages.
Hey, can I fix this as a part of Hacktoberfest 2021? @AnandDhakane01 @majjikishore007
Hii, we are glad you are willing to contribute, we have actually decided to change the complete UI/UX of the site to a much better design and theme. You can check out the design here design. Let me know if you are willing to work on any of the unassigned pages.
Yup, sure!
We were thinking of assigning you the adopt us page. you can create the issue. Hop onto our discord server for a quick call. You will find the link in the readme file.
| gharchive/issue | 2021-10-02T15:59:56 | 2025-04-01T06:37:56.770178 | {
"authors": [
"AnandDhakane01",
"KarishmaVanwari"
],
"repo": "arc-pune/arc-front-end",
"url": "https://github.com/arc-pune/arc-front-end/issues/29",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2386936275 | Solved: Query Bar Overflow with Long Text Input
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Query-bar-overflow-issue solved
Before
After
Why was this change needed? (You can also link to an open issue here)
While typing long sentences the last typed word OR while pasting the text the last sentences were not visible.
Other information:
Hello @siiddhantt made all the changes you mentioned please review !!!
hi @sarthaklaptop you don't need to make changes to the lint rules
just do --no-verify for now while you make the commit. And please resolve the conflicts there are currently
Hello @siiddhantt made changes you mentioned
Sorry for late update.
Hey @sarthaklaptop you will have a conflict on merge, please sync with the main branch,
Thank you!
@dartpain please check.
| gharchive/pull-request | 2024-07-02T18:58:23 | 2025-04-01T06:37:56.775794 | {
"authors": [
"dartpain",
"sarthaklaptop",
"siiddhantt"
],
"repo": "arc53/DocsGPT",
"url": "https://github.com/arc53/DocsGPT/pull/1025",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1347706472 | Labeling in HTML Reports View Documentation
Feature Requirement:
As HTML report provides us with HTML / Markdown Render , it provides a great way to compliment the viewpoint with content.
However the HTML render from the view Documentation tag does not include any metadata from the model. Therefore there is no reuse of the model artefacts or the view properties within the html content.
Feature requirement is to use view's properties in the html setup similar to what we use in labels on the objects presentation.
A stretch target will be to use an object's properties in the view's render.
Architecture Decision Record Card
ID :${property:ADR_ID}
CRITICALITY : ${property:viewProperty}
DATE : 2022/08/20
STATUS : Green
Version of Archi
Archi Plug-ins
Operating System
Expected Behaviour
Actual Behaviour
All of the code for Label Expressions is designed only to render in the objects' text in a View, or nodes in the Models Tree. I think trying to implement this in the Documentation field so that the expressions rendered in an HTML report would require some serious effort. Perhaps something to think about one day.
Yes . Added a feature requirement to consider for the backlog. We are using the html render more and more to augment the diagrams with content , rather than just diagrams and go to other design tools for content. This feature will improve the usability of the html report as a more hoisting solution offering where we can bring in lists and matrixes to the repository managed by arch file with reusing the models artefacts in properties possibly. This extends the view's usage to explain something to a specific user community .
It turns out that an initial implementation of rendering label expressions in documentation fields in HTML and Jasper Reports was not so complicated:
https://github.com/archimatetool/archi/commit/f987970fbd0a4e9f221e053bad672f7a96665fa1
However:
Is this something that other people want?
Are there side-effects?
What is the impact of this change?
We need to think about this.
I use the html report allot and content to compliment the solution architecture viewpoints instead of running with separate pptx for stakeholders that need more information or different content mediums. Other architects recommended we move to C4Builder that gives you the combination of markdown files and plantuml for diagraming within one solution. I would rather stay with Archi.
It turns out that an initial implementation of rendering label expressions in documentation fields in HTML and Jasper Reports was not so complicated:
f987970
However:
* Is this something that other people want?
* Are there side-effects?
* What is the impact of this change?
We need feedback on this.
For my new assignment I used Archi again, after several years. I like the simplicity and the power. of the tool I think it could be a great advantage if we could harmonize and unify the documentation and properties parts with a Markdown render, for all the output and report forms.
For my previous assignment it was necessary to use BizzDesign and in my opinion BizzDesign has three advances over Archi:
The ability to format text.
The ability to use references (hyperlinks) to elements in the documentation field.
The ability to use vertical oriented text labels.
I use the HTML and Jasper reporting tools and jArchi scripts to produce out in the same look and feel as the documentation of the customer. Te lack of formatting text is annoying. As a first step, I think it it is a big plus if the documentation fields support Markdown. As a second step maybe it is possible to support internal linking to elements and maybe in the future vertical orientation for text labels.
There is probably one issue, Jasper Report support Markup formatting, and own implementation of of text fromating, beside html and rtf. For the use of Markdown in Jasper Report the Markdown needs to be converted to html , rtf or the native Markkup format.
See: https://jasperreports.sourceforge.net/sample.reference/markup/index.html#markup
It turns out that an initial implementation of rendering label expressions in documentation fields in HTML and Jasper Reports was not so complicated:
f987970
However:
* Is this something that other people want?
* Are there side-effects?
* What is the impact of this change?
We need feedback on this.
For my new assignment I used Archi again, after several years. I like the simplicity and the power. of the tool I think it could be a great advantage if we could harmonize and unify the documentation and properties parts with a Markdown render, for all the output and report forms.
For my previous assignment it was necessary to use BizzDesign and in my opinion BizzDesign has three advances over Archi:
The ability to format text.
The ability to use references (hyperlinks) to elements in the documentation field.
The ability to use vertical oriented text labels.
I use the HTML and Jasper reporting tools and jArchi scripts to produce output with the same look and feel as the documentation of the customer. The lack of formatting text is annoying. As a first step, I think it it is a big plus if the documentation fields support Markdown.
As a second step maybe it is possible to support internal linking to elements and maybe in the future vertical orientation for text labels.
There is probably one issue, Jasper Report support Markup formatting (the option styles). Markup is an own implementation of text formatting, beside html and rtf. For the use of Markdown in Jasper Report the Markdown needs to be converted to html , rtf or the native Markkup format. See: https://jasperreports.sourceforge.net/sample.reference/markup/index.html#markup
What about usage of reStructuredText for the report? See https://docutils.sourceforge.io/rst.html
Advantage would be ability to edit pages independently, even directly on the web, e.g. at GitHub. For that also would be good to include element name in the page name at the beginning of name (in addition to the id and element type, or instead of the element type)
| gharchive/issue | 2022-08-23T10:31:00 | 2025-04-01T06:37:56.828969 | {
"authors": [
"New-arch",
"Phillipus",
"bratgers",
"evlibra"
],
"repo": "archimatetool/archi",
"url": "https://github.com/archimatetool/archi/issues/864",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
708642922 | imagesMaxWidth not working
It does not work after changing the RN version from 0.60.3 to 0.63.2.
"react": "16.13.1",
"react-native": "0.63.2",
"react-native-render-html": "^4.2.3",
"react-native-webview": "^10.9.0"
RN
<HTML
html={detailData.content}
imagesMaxWidth={Dimensions.get('window').width}
imagesInitialDimensions={{ width: Dimensions.get('window').width, height: Dimensions.get('window').width }}
tagsStyles={{
p: { fontFamily: Layout.fsFontNsR, marginTop: 5, lineHeight: 20 },
div: { fontFamily: Layout.fsFontNsR, marginTop: 5, lineHeight: 20 },
img: { width: Dimensions.get('window').width }
}}
/>
HTML
<img id="se_object_1598178785239" src="https://blogfiles.pstatic.net/MjAyMDA4MjNfMjIy/MDAxNTk4MTc4Mzc0NzY3.lP4y6IgYLhsLj98qYypYb1TJCzHGHAArTBsjcafM5ckg.SyBbjTSKLfVT_Tve1bW55GsCgn4NZA74_ZqhxOPWPDYg.JPEG.0610studio/6-%ED%94%BD_01.jpg"
class="__se_object" s_type="attachment" s_subtype="photo"
style=" width:1080px; height:1084px; rwidth:1080px; rheight:1084px;" width="1080" height="1084" imgqe="true"
jsonvalue="%7B%7D" rwidth="1080px" rheight="1084px">
<img id="se_object_1598178852473" src="https://blogfiles.pstatic.net/MjAyMDA4MjNfMTE2/MDAxNTk4MTc4Mzc0OTkz.aTquUUjfOjIJHOIOQOmKl8EM5J2V8iks6Xjg2ngs7wEg.-qG--Ba8CK8u6LHxmUtn4ApJAyuZUiCykGUta2VRzykg.JPEG.0610studio/6-%ED%94%BD_02.jpg"
class="__se_object" s_type="attachment" s_subtype="photo"
style=" width:1080px; height:1076px; rwidth:1080px; rheight:1076px;" width="1080" height="1076" imgqe="true"
jsonvalue="%7B%7D" rwidth="1080px" rheight="1076px">
@KimJeonghun91 Are you sure it's the RN version changes which cause a different behavior? We have proposed a new RFC for image and moreover media width here. There is a pending PR #389 ready to ship for v5.x. I could merge that to master and publish an alpha for you to test this. Are you interested?
I am interested.
Would you please merge it and publish the alpha for me?
I will test it on my project.
@KimJeonghun91 See https://github.com/archriss/react-native-render-html/releases/tag/v5.0.0-alpha.1
@KimJeonghun91 I tried your code with the latest (alpha.2) and it works!
import * as React from 'react';
import {ScrollView, StyleSheet, useWindowDimensions} from 'react-native';
import HTML from 'react-native-render-html';
const html = `
<img id="se_object_1598178785239" src="https://blogfiles.pstatic.net/MjAyMDA4MjNfMjIy/MDAxNTk4MTc4Mzc0NzY3.lP4y6IgYLhsLj98qYypYb1TJCzHGHAArTBsjcafM5ckg.SyBbjTSKLfVT_Tve1bW55GsCgn4NZA74_ZqhxOPWPDYg.JPEG.0610studio/6-%ED%94%BD_01.jpg"
class="__se_object" s_type="attachment" s_subtype="photo"
style=" width:1080px; height:1084px; rwidth:1080px; rheight:1084px;" width="1080" height="1084" imgqe="true"
jsonvalue="%7B%7D" rwidth="1080px" rheight="1084px">
<img id="se_object_1598178852473" src="https://blogfiles.pstatic.net/MjAyMDA4MjNfMTE2/MDAxNTk4MTc4Mzc0OTkz.aTquUUjfOjIJHOIOQOmKl8EM5J2V8iks6Xjg2ngs7wEg.-qG--Ba8CK8u6LHxmUtn4ApJAyuZUiCykGUta2VRzykg.JPEG.0610studio/6-%ED%94%BD_02.jpg"
class="__se_object" s_type="attachment" s_subtype="photo"
style=" width:1080px; height:1076px; rwidth:1080px; rheight:1076px;" width="1080" height="1076" imgqe="true"
jsonvalue="%7B%7D" rwidth="1080px" rheight="1076px">
`;
export default function App() {
const {width} = useWindowDimensions();
return (
<ScrollView contentContainerStyle={styles.container}>
<HTML contentWidth={width} html={html} />
</ScrollView>
);
}
const styles = StyleSheet.create({
container: {
flexGrow: 1,
},
});
Notice that you don't need to set explicit width to your images anymore. The crucial step is to provide contentWidth prop. If you want to have images max width computed from content width, you'll need to use computeImagesMaxWidth prop. A great addition with using useWindowDimensions is that the image will handle screen rotations gracefully.
I'm closing now, but feel free to respond and / or add feedback.
| gharchive/issue | 2020-09-25T05:03:32 | 2025-04-01T06:37:56.886807 | {
"authors": [
"KimJeonghun91",
"jsamr"
],
"repo": "archriss/react-native-render-html",
"url": "https://github.com/archriss/react-native-render-html/issues/412",
"license": "BSD-2-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
335662725 | Clicking/Tapping image or Navigating leading to stop auto play
Is this a bug report or a feature request?
Bug report ( or need help , not sure if this is achievable through existing code )
Have you read the guidelines regarding bug report?
Yes
Have you read the documentation in its entirety?
Yes
Have you made sure that your issue hasn't already been reported/solved?
Yes.(Looked into old issues, didn't find anything with related keywords.)
Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
Yes, both platform.
Is the bug reproductible in a production environment (not a debug one)?
YES
Have you made sure that it wasn't a React Native bug?
Doesn't seems like to be React native bug.
<!-
Have you been able to reproduce the bug in the provided example?
Yes.(With slight modification, but should happen in example1 code as well)
Environment
Environment:
React Native - 0.50,
React - 16
react-native-snap-carousel: 3.6/3.7
Target Platform:
Android (8.1)
I have tried https://snack.expo.io/rJ1XQrJM7 and able to reproduce this issue. ( IN both IOS/Android)
Steps to Reproduce
Execute the example1(loop one ) from https://github.com/archriss/react-native-snap-carousel/blob/master/example/src/index.js or https://snack.expo.io/rJ1XQrJM7
2.Click on image, auto play stops(Same is happening in case of navigation (with TouchableOpacity) as well).
Expected Behavior
Auto play should continue after user clicks on image(or navigate).
Note : Auto play get restored when user swipes screen manually to next slides, but slides should have moved to next slides automatically without manual intervention.
Actual Behavior
Clicking/tapping on image(or navigating through TouchableOpacity) stops autoplay.
Reproducible Demo
https://snack.expo.io/rJ1XQrJM7
Additional questions:
If we swipe from one slide to another we can see white color margin b/w 2 images , Is it possible to minimize the margin(may be 0). Below one suggests to add margin,I have made that 0 but still see margin while slides to next image.
https://github.com/archriss/react-native-snap-carousel/blob/master/doc/TIPS_AND_TRICKS.md#margin-between-slides.
2.Also, currently we have req. to show image of size =( width = screenWidth, height = screenWidth/2), if I understand correctly https://github.com/archriss/react-native-snap-carousel/blob/master/doc/TIPS_AND_TRICKS.md#viewport-wide-slides--no-preview-effect
should we explore https://github.com/leecade/react-native-swiper#basic-usage as well?
I think , if we get solution to auto play issue then I am happy to use this carousel for our use case(as we might be interested in preview feature in future)
Thanks.
Hi @shamca0633 ,
This is not relevant to your problem, but I have a question in the above demo code you provided.
I am trying to call a function when I click on an Item, onPress of Touchable if I call any method it is giving an error saying not a function.
<TouchableOpacity onPress={this.onPress.bind(this)} >
Error is _this6.onPress is not a function.
I am able to directly alert on Touch like below
<TouchableWithoutFeedback onPress={()=>{ Alert.alert("onPress");}}>
How can I able to call a method onPress of any Item?
Hi @shamca0633,
Regarding your issue, this is a known bug that I haven't addressed yet. I'll take a look at it as soon as possible. FYI, the root of the matter lies here.
To answer your questions:
The "margin" is linked to the inactiveSlideScale prop. You can set it to 1 if needed, but you'll then lose the scale effect.
Yes, I confirm what I've written in the doc.
Thanks for you quick response.
I wanted to check few more things which is blocking us to move forward on this plug-in.
I am observing a delay in initial loading of images. We have small set of images(max 10) only still facing this issue. Also to compare we tested it with some simple code (without auto scroll/loop,etc) and can see images getting load faster.Is it this plug-in adding some delay due to additional feature, if yes what are the recommendation to minimize initial load time?it has anything to do with loopClonesPerSide , is it loading 3 copies and adding to delay?
https://medium.com/the-react-native-log/custom-scrolling-carousel-in-react-native-15ee129e7e68
2.Once images are initially loaded seems like it scrolls a bit(and appears like flicker). Is it known issue?
3.At certain slide( 4th one out of 6 , with SLIDER_1_FIRST_ITEM =1 and loopClonesPerSide={3}) always flicker and in every loop, rest is fine.Not able to get logic on why 4th one.
4.Also, when I swipe fast then it reaches to last slides and refuse to swipe further in same direction, but able to swipe in reverse direction. Also once auto play happens then user can further swipe to next slide.Is there any end of loop from where user can't swipe further ? Is there any parameters there to handle this?
Configuration:
<View>
<Carousel
ref={c => this._slider1Ref = c}
data={ENTRIES1}
renderItem={this._renderItem}
sliderWidth={sliderWidth}
itemWidth={itemWidth}
firstItem={SLIDER_1_FIRST_ITEM}
inactiveSlideScale={1}
activeSlideAlignment={'start'}
inactiveSlideOpacity={1}
inactiveSlideShift={0.6}
containerCustomStyle={styles.slider}
contentContainerCustomStyle={styles.sliderContentContainer}
loop={true}
loopClonesPerSide={3}
autoplay={true}
lockScrollWhileSnapping={true}
enableMomentum ={true}
autoplayDelay={3000}
autoplayInterval={2000}
onSnapToItem={(index) => this.setState({ slider1ActiveSlide: index})
}
/>
<Pagination
dotsLength={ENTRIES1.length}
activeDotIndex={slider1ActiveSlide}
containerStyle={styles.paginationContainer}
dotColor={'rgba(255, 255, 255, 0.92)'}
dotStyle={styles.paginationDot}
inactiveDotColor={colors.black}
inactiveDotOpacity={0.6}
inactiveDotScale={0.60}
carouselRef={this._slider1Ref}
tappableDots={!!this._slider1Ref}
/>
</View>
Note : I have tested above on Android Simulator (8.1) and on Android real device.
I have gone through some existing performance/flickers issues but was not able to relate it with my case( or may be you can point me to , if I missed)
Thanks.
Thanks, setting "inactiveSlideScale" to 1 solved the margin b/w slides issue.
@bd-arc any estimate to when can we excpect this fix?
Also thank you very much for this wonderful library
same issue
are there any updates on this?
same issue
same issue
,how to solve?
Fixed in 3.8.0.
Thanks for you quick response.
I wanted to check few more things which is blocking us to move forward on this plug-in.
I am observing a delay in initial loading of images. We have small set of images(max 10) only still facing this issue. Also to compare we tested it with some simple code (without auto scroll/loop,etc) and can see images getting load faster.Is it this plug-in adding some delay due to additional feature, if yes what are the recommendation to minimize initial load time?it has anything to do with loopClonesPerSide , is it loading 3 copies and adding to delay?
https://medium.com/the-react-native-log/custom-scrolling-carousel-in-react-native-15ee129e7e68
2.Once images are initially loaded seems like it scrolls a bit(and appears like flicker). Is it known issue?
3.At certain slide( 4th one out of 6 , with SLIDER_1_FIRST_ITEM =1 and loopClonesPerSide={3}) always flicker and in every loop, rest is fine.Not able to get logic on why 4th one.
4.Also, when I swipe fast then it reaches to last slides and refuse to swipe further in same direction, but able to swipe in reverse direction. Also once auto play happens then user can further swipe to next slide.Is there any end of loop from where user can't swipe further ? Is there any parameters there to handle this?
Configuration:
<View>
<Carousel
ref={c => this._slider1Ref = c}
data={ENTRIES1}
renderItem={this._renderItem}
sliderWidth={sliderWidth}
itemWidth={itemWidth}
firstItem={SLIDER_1_FIRST_ITEM}
inactiveSlideScale={1}
activeSlideAlignment={'start'}
inactiveSlideOpacity={1}
inactiveSlideShift={0.6}
containerCustomStyle={styles.slider}
contentContainerCustomStyle={styles.sliderContentContainer}
loop={true}
loopClonesPerSide={3}
autoplay={true}
lockScrollWhileSnapping={true}
enableMomentum ={true}
autoplayDelay={3000}
autoplayInterval={2000}
onSnapToItem={(index) => this.setState({ slider1ActiveSlide: index})
}
/>
<Pagination
dotsLength={ENTRIES1.length}
activeDotIndex={slider1ActiveSlide}
containerStyle={styles.paginationContainer}
dotColor={'rgba(255, 255, 255, 0.92)'}
dotStyle={styles.paginationDot}
inactiveDotColor={colors.black}
inactiveDotOpacity={0.6}
inactiveDotScale={0.60}
carouselRef={this._slider1Ref}
tappableDots={!!this._slider1Ref}
/>
</View>
Note : I have tested above on Android Simulator (8.1) and on Android real device.
I have gone through some existing performance/flickers issues but was not able to relate it with my case( or may be you can point me to , if I missed)
Thanks.
Thank you man, you just save my day.
This props:
inactiveSlideScale={1}
inactiveSlideOpacity={1}
inactiveSlideShift={0.6}
Solved the flicker/blink issue when reached to last item and jump into the first item without blinking
| gharchive/issue | 2018-06-26T05:18:38 | 2025-04-01T06:37:56.913367 | {
"authors": [
"Marcello168",
"StephentTom",
"anoopmm",
"bd-arc",
"dugginenisagar",
"haduy97",
"iyoucheng",
"shamca0633",
"shashank19909"
],
"repo": "archriss/react-native-snap-carousel",
"url": "https://github.com/archriss/react-native-snap-carousel/issues/342",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
2164839806 | Laravel 11.x Compatibility
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:
Checkout the l11-compatibility branch
Review all comments for additional changes
Thoroughly test your package
If you do find an issue, please report it by commenting on this PR to help improve future automation.
:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.
:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-pages.git"
}
]
}
Then update your dependency constraint to reference this branch:
{
"require": {
"archtechx/laravel-pages": "dev-l11-compatibility",
}
}
Finally, run: composer update
| gharchive/pull-request | 2024-03-02T14:44:31 | 2025-04-01T06:37:56.929815 | {
"authors": [
"laravel-shift"
],
"repo": "archtechx/laravel-pages",
"url": "https://github.com/archtechx/laravel-pages/pull/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1264119292 | 当select option value值 为空时，选项label不显示
[ ] I'm sure this does not appear in the issue list of the repository
Basic Info
Package Name And Version: @arco-design/web-vue@2.29.1
Browser: chrome102.0.5005.63
What is expected?
全部 选项选中时，显示 "全部"
Steps to reproduce
https://codesandbox.io/s/smoosh-currying-hswts0?file=/src/App.vue
@raythunder 目前的 select 是把 ''、null、undefined 当做没有选择的状态，并且 default-value = ''，这个修改会产生的 break change，影响到已经使用的用户，风险比较大，在目前的版本中应该不会再修改了。这里可以使用其他的值替代一下
| gharchive/issue | 2022-06-08T02:55:25 | 2025-04-01T06:37:56.934515 | {
"authors": [
"flsion",
"raythunder"
],
"repo": "arco-design/arco-design-vue",
"url": "https://github.com/arco-design/arco-design-vue/issues/1252",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1481319760 | config provider的全局配置问题
对于部分组件只穿透了部分参数，导致在modal这些组件中一些参数拿不到
详细描述一下吧，举个例子
通过Modal.confirm/info/error/warning 来调用的，是不能拿到context上的config的，arco把config放到一个全局的地方，弹窗时候去
但目前只把这三个配置放到了全局的地方，其他在modal下会拿不到
modal上的内容，只能拿到全局配置中的 local / prefixCls / rtl 三个配置项 像focusLock参数不生效
yangyuhan：提个issue，确实只透穿了 rtl, locale 和 prefixCls[泣不成声]
| gharchive/issue | 2022-12-07T08:24:41 | 2025-04-01T06:37:56.936017 | {
"authors": [
"ClayZth",
"PengJiyuan"
],
"repo": "arco-design/arco-design",
"url": "https://github.com/arco-design/arco-design/issues/1635",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
688235742 | Expose Top or Take
Looking to select example: 4 items from my specification. I've resorted to using Query.Paginate(0, 4).
@ardalis suggested raising an Issue here to see if it might be a trivial item to implement.
Hey @ovation22 ,
If I understood correctly, you want to expose Take in the specification? You want to use Query.Take(4), instead of Query.Paginate(0, 4) ?
What would be the benefit actually? Not writing the 0?
Implementation wise, not hard to add. But, we have to ensure that Paginate() and Take() won't be used within the same specification, since it will overwrite the values. And that might add to the confusion.
It's a good point about the two being exclusive of one another. @ovation22 and I were discussing this Friday and my first thought was that it would be more intuitive to offer a .Take directly rather than having to "page" to do it. Conceptually to me at least, I don't think about paging as a way to get "Top X Rows/Records". Under the covers I know paging uses Skip/Take but it still seems like a bit of a hack to have to go through the Paging abstraction just to take advantage of this fact.
It shouldn't be too hard for us to support Take or Paginate, and throw if both are used, right?
Not a problem to implement. I was just thinking how to provide a consistent API. Not a huge fan of overlapping functionalities :)
If we think twice, Paginate is just a dummy wrapper and made sense in the legacy API, but now that we have LINQ alike structure, we may be more verbose and expose Top and Skip directly. For now we can support both ways, and decorate the Paginate as obsolete. In the future we'll remove it completely. Makes sense?
But, I have a feeling we misunderstood @ovation22. He might want to get top records regardless of the specification (for any spec). If this is a case, this can be done in your repository implementation.
We provide RepositoryBase generic repository ready to use. It's an abstract one, so anyway you will have to derive from it. You could do something like this in your repo.
public interface IRepository<T> : IRepositoryBase<T> where T : class
{
Task<List<T>> GetTopAsync(ISpecification<T> specification, int take);
Task<List<TResult>> GetTopAsync<TResult>(ISpecification<T, TResult> specification, int take);
}
public class Repository<T> : RepositoryBase<T>, IRepository<T> where T : class
{
protected readonly TestDbContext dbContext;
public Repository(TestDbContext dbContext) : base(dbContext)
{
this.dbContext = dbContext;
}
public async Task<List<T>> GetTopAsync(ISpecification<T> specification, int take)
{
return await ApplySpecification(specification).Take(take).ToListAsync();
}
public async Task<List<TResult>> GetTopAsync<TResult>(ISpecification<T, TResult> specification, int take)
{
return await ApplySpecification(specification).Take(take).ToListAsync();
}
}
PS. I just noticed ApplySpecification is a private method. We'll make that protected, no harm of exposing it.
I was specifically referencing using Top/Take in a Specification, but I appreciate the option with the IRepository.
Giving it more thought over the weekend I was thinking along those lines same lines as you mention @fiseni if it would make sense to expose Take and Skip and deprecating Paginate. Makes sense to me.
One of the key benefits of the Specification pattern IMO is that it helps prevent the need for repository implementations to have tons of different methods. If we can avoid adding more methods to repository by allowing fewer methods to do the same thing using a specification, I think we should do that. I also don't want to require devs to have to use our base repository just because they want to use specifications (as that will hurt adoption).
So, I think your original idea works:
Not a problem to implement. I was just thinking how to provide a consistent API. Not a huge fan of overlapping functionalities :)
If we think twice, Paginate is just a dummy wrapper and made sense in the legacy API, but now that we have LINQ alike structure, we may be more verbose and expose Top and Skip directly. For now we can support both ways, and decorate the Paginate as obsolete. In the future we'll remove it completely. Makes sense?
I'm still not sure I want to drop Paginate, since I like the naming of it (it's a higher level abstraction that covers up the low level skip/take details) but I agree it's not great design to have 2 ways to do the same thing.
Giving it more thought over the weekend I was thinking along those lines same lines as you mention @fiseni if it would make sense to expose Take and Skip and deprecating Paginate. Makes sense to me.
Sounds like we all agree. Add Take/Skip to specification and mark Paginate obsolete.
I do share your opinion regarding the repositories. I didn't mean to provide the functionality through the repo, or enforce it in any way. It's just an example how users can implement such thing in their code base, in their repo (cos that's the only way you can get such general Top functionality).
I'm free for the next 30 mins, I'll do the changes now.
This is implemented. If no one has additional comments, we may close the issue.
Ok so all I need to do if it looks good is publish a new point release, yes?
Yes, I think so.
I don't think we have some breaking changes, but you might want to go through the history and cross check. There is a comment on the last commit too.
Other than that, tests should be refactored. It's in my backlog too, if I find time in the next period, I'll try to go through that.
| gharchive/issue | 2020-08-28T17:24:50 | 2025-04-01T06:37:56.974792 | {
"authors": [
"ardalis",
"fiseni",
"ovation22"
],
"repo": "ardalis/Specification",
"url": "https://github.com/ardalis/Specification/issues/47",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1451659416 | index pages have hardcoded version
consider getting the latest version from the version store
e.g. https://github.com/ardc-fair-checklist/ssg/blob/4f7d5cf8e056c538d92d351bd7a627b1596edff4/pages/software/v0.2/index.page.vue#L79
partly fixed by fda6670, still some references in BadgeSnippets:
https://github.com/ardc-fair-checklist/ssg/blob/fda66701d35e54ba2b08e5b80820224be1c5bccb/pages/software/v0.2/BadgeSnippets.vue#L41-L50
no more hardcoded version strings in code base, reactivity problems (#36) seem to have been solved by 49dee0d
| gharchive/issue | 2022-11-16T13:59:25 | 2025-04-01T06:37:56.978039 | {
"authors": [
"jspaaks"
],
"repo": "ardc-fair-checklist/ssg",
"url": "https://github.com/ardc-fair-checklist/ssg/issues/25",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1260539884 | Update repositories.txt
Added mini-ppm-info (2nd attempt)
I have a library.properties file already in the repository.
https://github.com/jaggzh/mini-ppm-info/blob/main/library.properties
@ArduinoBot, I incremented the version with some improvements.
| gharchive/pull-request | 2022-06-04T00:14:07 | 2025-04-01T06:37:57.071315 | {
"authors": [
"jaggzh"
],
"repo": "arduino/library-registry",
"url": "https://github.com/arduino/library-registry/pull/1464",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
963401231 | 🛑 Eigensolutions UK is down
In 7e3a83f, Eigensolutions UK (https://www.eigensolutions.co.uk) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Eigensolutions UK is back up in b3ed327.
| gharchive/issue | 2021-08-08T10:26:21 | 2025-04-01T06:37:57.073738 | {
"authors": [
"ardus-uk"
],
"repo": "ardus-uk/upptime",
"url": "https://github.com/ardus-uk/upptime/issues/7",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
480741792 | Add noindex and nofollow header to CMS pages
In instances where the same codebase serves the frontend as well
as the CMS, it's challenging to use a robots.txt file to block
search engine spiders from indexing admin pages. Adding this
header help to ensure that CMS pages done find their way into
search engines.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
| gharchive/pull-request | 2019-08-14T15:21:43 | 2025-04-01T06:37:57.078654 | {
"authors": [
"CLAassistant",
"nikhiltri"
],
"repo": "area17/twill",
"url": "https://github.com/area17/twill/pull/346",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
264044376 | Add title to comments screen
Closes #148
I didn't do this because adding comments feels really weird. Let's just merge it and deal with it later. I was hoping to do it with a count state, but really I think we need to just dispatch a title update (we can refactor the goofy title visibility toggle to do this)
By feels really weird I mean you expect the title to update when you add one, and it doesn't.
Ah right, good call. I'm fine to close this, was just trying to get some easy issues closed. Your call.
Lol
| gharchive/pull-request | 2017-10-09T22:26:53 | 2025-04-01T06:37:57.085834 | {
"authors": [
"broskoski",
"dzucconi"
],
"repo": "aredotna/case",
"url": "https://github.com/aredotna/case/pull/198",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
2293069240 | ADH-4390: [UI] FormField
https://tracker.yandex.ru/ADH-4390
Please, rebase on the master and run the following command to add license headers to the new source files. Otherwise, subsequent CI builds will fail.
| gharchive/pull-request | 2024-05-13T14:53:19 | 2025-04-01T06:37:57.089980 | {
"authors": [
"MrHalless",
"tigrulya-exe"
],
"repo": "arenadata/SSM",
"url": "https://github.com/arenadata/SSM/pull/38",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
825643821 | non-existent docker image referenced in manifest
Hi!
I tried to install the applicationset CRD into my cluster and found that the docker images for controller deployment doesn't exist.
manifests
docker pull argoprojlabs/
argocd-applicationset:latest
Error response from daemon: pull access denied for argoprojlabs/argocd-applicationset, repository does not exist or may require 'docker login': denied: requested access to the resource is denied
can you point me to the correct image if exists? makefile also points to this image.
@jgwest, why not publish a "latest" image on every commit to master?
@rumstead Working on it :smile:.
| gharchive/issue | 2021-03-09T09:55:53 | 2025-04-01T06:37:57.102918 | {
"authors": [
"jgwest",
"rumstead",
"sachincool"
],
"repo": "argoproj-labs/applicationset",
"url": "https://github.com/argoproj-labs/applicationset/issues/149",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1317301952 | Helm Image is Not Updated
Describe the bug
I'm not sure if this is a legitimate bug or if I'm missing a key piece of documentation/understanding, but I have a helm chart successfully deploying to my cluster via ArgoCD, and I'm trying to use the image updater to keep my image up to date based on the latest update strategy using git write-back and manual sync. When a new image is published to my repository, image-updater successfully updates my .argo-source-cmd-webapp.yaml file with the image tag, but on the ArgoCD end, it doesn't recognize that the image tag I have defined in my values.yaml file is different from the image tag in the argo source file and therefore does not update to my latest image update.
To Reproduce
My relevant charts:
deployment.yaml
kind: Deployment
metadata:
name: {{ include "cmd-webapp.fullname" . }}
labels:
{{- include "cmd-webapp.labels" . | nindent 4 }}
{{- with .Values.webappDeploymentAnnotations }}
annotations:
{{- toYaml . | nindent 4 }}
{{- end }}
namespace: {{ .Values.webapp.namespace }}
...
...
...
template:
...
...
spec:
containers:
- name: {{ .Chart.Name }}
image: {{ .Values.image.repository }}:{{ .Values.image.tag | default "latest" }}
imagePullPolicy: {{ .Values.image.pullPolicy }}
...
...
values.yaml
image:
repository: XXXXXXXX.amazonaws.com/webapp
pullPolicy: Always
tag: 42feaa43
...
...
.argocd-source-cmd-webapp.yaml
helm:
parameters:
- name: image.name
value: XXXXXXXX.amazonaws.com/webapp
forcestring: true
- name: image.tag
value: 0ca9d43f
forcestring: true
Application annotations
argocd-image-updater.argoproj.io/force-update: true
argocd-image-updater.argoproj.io/helm.image-name: image.repository
argocd-image-updater.argoproj.io/helm.image-tag: image.tag
argocd-image-updater.argoproj.io/ignore-tags: latest
argocd-image-updater.argoproj.io/image-list: XXXXXXXXX.amazonaws.com/webapp
argocd-image-updater.argoproj.io/update-strategy: latest
argocd-image-updater.argoproj.io/write-back-method: git
Expected behavior
I would think ArgoCD would recognize the change to the helm parameters and show the application is Out of Sync, but it doesn't register a change
Version
v0.12.0+aee153d
I did a little messing around and figured out that while argocd-image-updaer was writing to argocd-source-cmd-webapp.yaml, the helm override parameter will only kick in when the file is named argocd-source.yaml. I'm still not sure where it's configured that the git writeback writes to a file called argocd-source-cmd-webapp.yaml and continues to do so even though I've renamed the file to argocd-source.yaml
Notice argocd is writing only to argocd-source-cmd-webapp.yaml instead of argocd-source.yaml
I think this issue belongs in the argo-cd repository as argocd-image-updater seems to be doing it's part just fine. Closing this issue and opening adjacent issue in argo-cd: https://github.com/argoproj/argo-cd/issues/10177
| gharchive/issue | 2022-07-25T19:59:20 | 2025-04-01T06:37:57.109457 | {
"authors": [
"egkelly"
],
"repo": "argoproj-labs/argocd-image-updater",
"url": "https://github.com/argoproj-labs/argocd-image-updater/issues/461",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1132766221 | I would like a mentor
Summary
What change needs making?
Use Cases
When would you use this?
Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
I would like to work on #7814 and #7815
@cnu1812 the first issue is closed and the second one already has an interested person on the issue. Is there another issue you are interested in? Let me know if you want have a call or slack conversation to help get you started on an issue.
Have you read the mentoring guide? Please only submit this request for general mentoring (not GSoC).
Answer: Yes.
What is your background? Any experience with Go, Kubernetes, React, Typescript, etc.?
Answer: I have a bit experience with kubernetes and go.
Is there any particular issue you'd like to work on? You may want to check out the list of good first issues.
Answer:
Would like to work on #6924
@cnu1812 Sounds good, let me know if you would like to talk about it or look at a draft PR.
I added a comment in https://github.com/argoproj/argo-workflows/issues/6924#issuecomment-1048893567 since GitHub does not allow me to assign to you.
@cnu1812 Are you still working on that issue? If not, I will close this and unassign that issue from you.
I am working on this. give me some time
| gharchive/issue | 2022-02-11T15:37:43 | 2025-04-01T06:37:57.164908 | {
"authors": [
"blkperl",
"cnu1812",
"terrytangyuan"
],
"repo": "argoproj/argo-workflows",
"url": "https://github.com/argoproj/argo-workflows/issues/7857",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1402467618 | pod deleted error when running multiple workflows concurrently
Pre-requisites
[X] I have double-checked my configuration
[X] I can confirm the issues exists when I tested with :latest
[ ] I'd like to contribute the fix myself (see contributing guide)
What happened/what you expected to happen?
I wrote a workflow about biological data processing. This workflow may require a lot of cpu and memory during the running process, but I did not specify the amount of resources required by the template in the workflow. This workflow I run individually is It is 100% successful, but the pod deleted error will appear when running more than one at the same time, but because the pod has been deleted, I cannot see the logs of the init, wait, and main containers in the pod.
Version
v3.4.1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
none
Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep sky2-pipeline-jwtf8.feature-classify.feature-classify-1
time="2022-10-09T12:05:06.044Z" level=info msg="All of node sky2-pipeline-jwtf8.feature-classify.feature-classify-1 dependencies [] completed" namespace=argo workflow=sky2-pipeline-jwtf8
time="2022-10-09T12:05:06.054Z" level=info msg="Created pod: sky2-pipeline-jwtf8.feature-classify.feature-classify-1 (sky2-pipeline-jwtf8-qiime2-picrust2-2951325495)" namespace=argo workflow=sky2-pipeline-jwtf8
time="2022-10-09T12:08:32.500Z" level=info msg="Workflow pod is missing" namespace=argo nodeName=sky2-pipeline-jwtf8.feature-classify.feature-classify-1 nodePhase=Running recentlyStarted=false workflow=sky2-pipeline-jwtf8
Logs from in your workflow's wait container
none
I think pod deletion because of node auto scale or node rotation. You can prevent this with two options.
Add retry strategy for every step
Enable the PDB on workflow
Sent from my iPhone
On Oct 9, 2022, at 6:13 PM, sanqiuli @.***> wrote:
Pre-requisites
I have double-checked my configuration
I can confirm the issues exists when I tested with :latest
I'd like to contribute the fix myself (see contributing guide)
What happened/what you expected to happen?
I wrote a workflow about biological data processing. This workflow may require a lot of cpu and memory during the running process, but I did not specify the amount of resources required by the template in the workflow. This workflow I run individually is It is 100% successful, but the pod deleted error will appear when running more than one at the same time, but because the pod has been deleted, I cannot see the logs of the init, wait, and main containers in the pod.
Version
v3.4.1
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
none
Logs from the workflow controller
kubectl logs -n argo deploy/workflow-controller | grep sky2-pipeline-jwtf8.feature-classify.feature-classify-1
time="2022-10-09T12:05:06.044Z" level=info msg="All of node sky2-pipeline-jwtf8.feature-classify.feature-classify-1 dependencies [] completed" namespace=argo workflow=sky2-pipeline-jwtf8
time="2022-10-09T12:05:06.054Z" level=info msg="Created pod: sky2-pipeline-jwtf8.feature-classify.feature-classify-1 (sky2-pipeline-jwtf8-qiime2-picrust2-2951325495)" namespace=argo workflow=sky2-pipeline-jwtf8
time="2022-10-09T12:08:32.500Z" level=info msg="Workflow pod is missing" namespace=argo nodeName=sky2-pipeline-jwtf8.feature-classify.feature-classify-1 nodePhase=Running recentlyStarted=false workflow=sky2-pipeline-jwtf8
Logs from in your workflow's wait container
none
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
What is PDB? There are many steps in the workflow, and Add retry strategy for every step is very troublesome.
https://github.com/argoproj/argo-workflows/blob/master/examples/default-pdb-support.yaml
Sent from my iPhone
On Oct 9, 2022, at 6:36 PM, sanqiuli @.***> wrote:
What is PDB? There are many steps in the workflow, and Add retry strategy for every step is very troublesome.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
https://github.com/argoproj/argo-workflows/blob/master/examples/default-pdb-support.yaml
…
Sent from my iPhone
On Oct 9, 2022, at 6:36 PM, sanqiuli @.***> wrote: What is PDB? There are many steps in the workflow, and Add retry strategy for every step is very troublesome. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.
it didn't work
@sanqiuli can you provide the pod describe? Can you gett more details why the POD is getting deleted in kubernetes?
@sanqiuli can you provide the pod describe? Can you gett more details why the POD is getting deleted in kubernetes?
I didn't set argo's gc, but my pods are garbage collected
I only query the log of the pod being gc
~$ kubectl logs -n kube-system -f kube-controller-manager-picb2-master-1 | grep sky2-pipeline-ff5gq
I1010 11:16:53.226435 1 gc_controller.go:78] PodGC is force deleting Pod: argo/sky2-pipeline-ff5gq-script-2925226625
I1010 11:16:53.226680 1 gc_controller.go:78] PodGC is force deleting Pod: argo/sky2-pipeline-ff5gq-script-1056479775
I1010 11:17:53.271529 1 gc_controller.go:78] PodGC is force deleting Pod: argo/sky2-pipeline-ff5gq-script-3730124130
I1010 11:19:33.319019 1 gc_controller.go:78] PodGC is force deleting Pod: argo/sky2-pipeline-ff5gq-qiime2-picrust2-1605826948
```I didn't set argo's gc, but my pods are garbage collected
I only query the log of the pod being gc
I found an article that is somewhat familiar to my problem [link](https://blog.csdn.net/alex_yangchuansheng/article/details/119156912)
see #9058
I succeeded after adding both retry and pdb in yaml
见#9058
I found that when my pod is waiting to be scheduled, it is garbage collected, which is related to the --terminated-pod-gc-threshold (default 12500, I set it to 100) set by the kube-controller-manager of k8s. When the number of terminated pods exceeds When this value is used, a pod deleted error will occur
| gharchive/issue | 2022-10-10T01:12:53 | 2025-04-01T06:37:57.182866 | {
"authors": [
"alexec",
"sanqiuli",
"sarabala1979"
],
"repo": "argoproj/argo-workflows",
"url": "https://github.com/argoproj/argo-workflows/issues/9780",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1747485224 | fix: use only relevant files in build
This optimises the nix build time by depending on the required files, changing the docs for example shouldn't force a rebuild.
@terrytangyuan can you please approve this?
It fixes some directory related issues since the nix files are in /dev/nix.
Thanks.
| gharchive/pull-request | 2023-06-08T09:34:01 | 2025-04-01T06:37:57.184629 | {
"authors": [
"isubasinghe"
],
"repo": "argoproj/argo-workflows",
"url": "https://github.com/argoproj/argo-workflows/pull/11189",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1187489109 | fix: install.yaml missing crb subject ns
This PR fixes the issue with missing ns in crb subjects inside the install.yaml file, introduced in PR #8266
ref: https://github.com/argoproj/argo-workflows/issues/8250#issuecomment-1084046919
@gdsoumya Why exactly we are hardcoding the namespace for cluster install ? whoever refers the cluster install can mention the namespace in their own kustomization.yaml
@alexec @jessesuen
@gdsoumya Yes, Apologies for install.yaml bug I introduced, as it was showing diff when I was fixing kustomize. But isn't kustomize supposed to be for generic use instead of hard-coding a namespace.
Also with kustomize you can not override namespace if its hardcoded. There is a open ticket for the same. :
https://github.com/kubernetes-sigs/kustomize/issues/880
| gharchive/pull-request | 2022-03-31T04:41:19 | 2025-04-01T06:37:57.187466 | {
"authors": [
"gdsoumya",
"tiwarisanjay"
],
"repo": "argoproj/argo-workflows",
"url": "https://github.com/argoproj/argo-workflows/pull/8280",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
655990474 | Windows CLI is gone
Summary
What do you want to know about this project?
What happened to the Windows CLI app?
Motivation
Why do you need to know this, any examples or use cases you could include?
I have been going through some due diligence to test/adopt this project at T-Mobile, but right before we were about to deploy, the Windows CLI downloads seemed to disappear. This could potentially be a dealbreaker. If support for testing a Windows CLI is necessary, we may be able to assist.
The windows CLI is available in our latest release page:
https://github.com/argoproj/argo/releases/tag/v2.9.2
https://github.com/argoproj/argo/releases/download/v2.9.2/argo-windows-amd64
Am I missing something?
Sorry, forgive me, I'm not sure what I was thinking.
| gharchive/issue | 2020-07-13T16:41:17 | 2025-04-01T06:37:57.190884 | {
"authors": [
"saosebastiao",
"simster7"
],
"repo": "argoproj/argo",
"url": "https://github.com/argoproj/argo/issues/3463",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
295141232 | Valid BBAN is considered invalid
I have a valid BBAN but the method isValidBBAN returns false with it:
iban.toBBAN('CR25010200009074883572');
// '0102 00009074883572'
iban.isValidBBAN('0102 00009074883572');
// false
iban.isValidBBAN(iban.toBBAN('CR25010200009074883572'));
// false
Hello,
Sorry for the super late reply, going through the issues backlog.
The correct way to call isValidBBAN is by passing the country code as first parameter (which is not properly documented, I must say). So your code becomes:
iban.isValidBBAN('CR', iban.toBBAN('CR25010200009074883572'));
// true
Hi @LaurentVB! It's okay.
I wouldn't close this issue until the documentation is updated, since other people may face it.
Thanks!
| gharchive/issue | 2018-02-07T13:40:40 | 2025-04-01T06:37:57.193444 | {
"authors": [
"LaurentVB",
"abelosorio"
],
"repo": "arhs/iban.js",
"url": "https://github.com/arhs/iban.js/issues/48",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
713359780 | [BUG] ariaDownload gets first file blocked by JPL network URL-block service
Describe the bug
I ran a download of seven products, but the first one was blocked and the .nc contains only an error message. This is while connected to the JPL full tunnel VPN. I ran it a second time after deleting the bad file and got the same result for the first file. Rest of the files are downloaded correctly (or skipped on second try).
To Reproduce
Steps to reproduce the behavior:
Download
Command used
ariaDownload.py -b '32.8 33.2 -115.8 -115.2' --output download -s 20200301
Error Output
First run:
https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
> attempting to download https://urs.earthdata.nasa.gov/profile
> Could not validate old cookie Jar
No existing URS cookie found, please enter Earthdata username & password:
(Credentials will not be stored, saved or logged anywhere)
> attempting to download https://urs.earthdata.nasa.gov/profile
Username: EJFielding
Password (will not be displayed):
> attempting to download https://urs.earthdata.nasa.gov/profile
Using 1 threads for parallel downloads
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
> 'Temporary' Redirect download @ Remote archive:
> http://34.231.8.234:6080/php/urlblock.php?args=AAAAawAAABCCjw6LxwMDD0XFz2sNndb~AAAAECMSKEWn~kEQPYh2LihxyoAAAAA7AAAAO~p3kf18EXgRp~5E7Bc25Cb3p91yfIwFRPVW2HQK7Z0DHlPa_2qwelb9CkwUEdEUTmGOoOdal3~2cL95&url=http://34.231.8.234%2fdoor%2fdownload%2fS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
> Downloaded 2929 of 2929 bytes (100.00%)
Downloaded 2929b in 2.38secs, Average Rate: 0.00MB/sec
> 'Temporary' Redirect download @ Remote archive:
> https://dlz0dhr6g6ukw.cloudfront.net/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc?userid=ejfielding&Expires=1601608741&Signature=DCwkrT8g4OYj8SQyvjGjvFunpGi7~Xfd3giRHVJ1OcM~BvgLb6FVk4NzNVxHZRvlmitYESKwkev7Se2ZlwnoGC2x-g83d2f~Sr6WvjxLbLOZTYI5DhJNesqf2zU4xGSHR8Q74ESdSOyhi68GEq~FTgMkW4BQERAc9M7RP4WOpj0_&Key-Pair-Id=APKAINVNJF4BDB5SS5QQ
(2/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
> Downloaded 62309232 of 62309232 bytes (100.00%)
Downloaded 62309232b in 138.80secs, Average Rate: 0.43MB/sec
second run:
https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
Using 1 threads for parallel downloads
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
> 'Temporary' Redirect download @ Remote archive:
> http://35.169.211.218:6080/php/urlblock.php?args=AAAAawAAABDLlKSx~7KaNYP9TBQUf9moAAAAEGkl43OcAp4LLNXlGwliy3IAAAA7AAAAOzlF0zvgVhZ7GyMSdP~v0_uRKv2a3awjbxwSxZkGh1p3qnEhXbs1dP56CzfSU_LUJVq_pTPDcMoG8Cf1&url=http://35.169.211.218%2fdoor%2fdownload%2fS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
> Downloaded 2933 of 2933 bytes (100.00%)
Downloaded 2933b in 1.96secs, Average Rate: 0.00MB/sec
> Download file S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc.
Expected behavior
I expected all seven files to be downloaded correctly.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
ARIA-tools git tag: [e.g. git show --summary]
commit b787e827a799fecbf45d6aa267eeb95940148d83 (HEAD -> dev, origin/dev, origin/HEAD)
Author: BB bbuzz318@icloud.com
Date: Wed Sep 30 08:01:33 2020 -0700
fix file writing bug for KMZ dl (#228)
OS
MacOS 10.14.6, Conda installation
Additional context
The bad download file contains the attached error text:
blocked-download.txt
Not running behind the fire-wall works to download the file: https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc. Although, need to say i needed to run it twice as it reported at first some files reported errors. So seems some transient on the API client side and not something specific to ariaDownload program.
> attempting to download https://urs.earthdata.nasa.gov/profile
> 'Temporary' Redirect download @ Remote archive:
> https://dlz0dhr6g6ukw.cloudfront.net/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc?userid=dbekaert&Expires=1601657555&Signature=aAvOpnnnAooFwvDN~6Uv3o4DaQNLqWqeDfbckHxXd0~RnQzVwdDo2iPJfiUN8kw4I~ajfRsFOkxUG376Cmq3-p2O9fbbcUC3EAegAX0g56XK-OIEDwwwk~Yr9jc8M8yrTaahoOPna-l2GpltUfFG~w0XnfDCdRJX2DtQMJ5Fif4_&Key-Pair-Id=APKAINVNJF4BDB5SS5QQ
(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
> Downloaded 21905408 of 62552131 bytes (35.02%)
> There was an error reading data.
and the second attempt:
Download Summary
--------------------------------------------------------------------------------
Successes: 2 files, 125077866 bytes
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc 59.65MB
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc 59.63MB
Skipped: 5 files
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc
Average Rate: 8.19MB/sec
@EJFielding If this is specific to the JPL fire-wall, and the recent changes implemented with respect to url defense. Suggest you work with your IT admin as unrelated to ARIA-tools.
I verified that this does not happen from my home ISP without the JPL full tunnel VPN. It does happen running on a Linux machine inside the JPL network, so it must be some kind of strange interaction between the ASF API and the JPL firewall. This is the output from the JPL machine:
ariaDownload.py -b '32.8 33.2 -115.8 -115.2' --output download -s 20200301
https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
> attempting to download https://urs.earthdata.nasa.gov/profile
> Could not validate old cookie Jar
No existing URS cookie found, please enter Earthdata username & password:
(Credentials will not be stored, saved or logged anywhere)
> attempting to download https://urs.earthdata.nasa.gov/profile
Username: EJFielding
Password (will not be displayed):
> attempting to download https://urs.earthdata.nasa.gov/profile
Using 1 threads for parallel downloads
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
> 'Temporary' Redirect download @ Remote archive:
> http://34.231.8.234:6080/php/urlblock.php?args=AAAAdQAAABBwpAb7QQR4~szp0hI7hescAAAAED~TtODCx4FNxdBfaxdD0xAAAABFAAAARfnSPom0cnv1MFBgOWnEq64Zz9oVnwbZZW_v4zdETR0h7s9J3zCQbjVHLIBciBlXhEbykANQe4ooGANNdTqQb21PBj0H3A==&url=http://34.231.8.234%2fdoor%2fdownload%2fS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
> Downloaded 2945 of 2945 bytes (100.00%)
Downloaded 2945b in 1.54secs, Average Rate: 0.00MB/sec
> 'Temporary' Redirect download @ Remote archive:
> https://dlz0dhr6g6ukw.cloudfront.net/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc?userid=ejfielding&Expires=1601843075&Signature=TWL79xHFjRrMhOJe5~Lq-hl-rDBX-~wC-5qFanCMNUmodXgi4TjTmYvbtCBeKQ4pNPTYGoJzYZ-FCRQjp8AdPoom68ZVVnWjy5HFHxt3-SrEzdnwVkRYcXpd5DPahBYstgDNXznXBYEEELeQmmkUb04zspb53N~SYjTGlP9XpT8_&Key-Pair-Id=APKAINVNJF4BDB5SS5QQ
(2/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
> Downloaded 62309232 of 62309232 bytes (100.00%)
Downloaded 62309232b in 3.29secs, Average Rate: 18.04MB/sec
I understand now that this is not likely to be due to a bug in ARIA-tools, but it seems like ARIA-tools should do a better job of detecting that there was a download error. I tried running it a second time, and it correctly determined that the previous download was bad, removed it, and tried again, but then it puts the bad file in the "successful" part of the output list when it is still a bad file.
ariaDownload.py -b '32.8 33.2 -115.8 -115.2' --output download -s 20200301
https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
Using 1 threads for parallel downloads
> attempting to download https://urs.earthdata.nasa.gov/profile
> Re-using previous cookie jar.
> Found S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc but it wasn't fully downloaded. Removing file and downloading again.
> 'Temporary' Redirect download @ Remote archive:
> http://35.169.211.218:6080/php/urlblock.php?args=AAAAdQAAABBTiFBxhKo4j87OzC7baDDvAAAAEI3H9N2E7hHh59ydT~9cenUAAABFAAAARTD9SOe2fKSdJnx34~LmkIlnKfjA4WESmIery8u5hctUS2FNTHK1TwaCqM50KUc0Zxfln0phHSMmrEkL3J6M7H4KC_hLFQ==&url=http://35.169.211.218%2fdoor%2fdownload%2fS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
> Downloaded 2949 of 2949 bytes (100.00%)
Downloaded 2949b in 2.31secs, Average Rate: 0.00MB/sec
> Download file S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc.
> Download file S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc.
> Download file S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc.
> Download file S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc.
> Download file S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc.
> Download file S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc exists!
> Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc.
Download Summary
--------------------------------------------------------------------------------
Successes: 1 files, 2949 bytes
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc 0.00MB
Skipped: 6 files
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc
Average Rate: 0.00MB/sec
--------------------------------------------------------------------------------
ariaDownload.py merely wraps around the DAAC API to provide additional
functionality for subsetting. Checking if files are complete, checksums,
etc, the error download message are all passed through via the existing API
functionality to my knowledge. Suggest you open an issue ticket with ASF,
as all the underlying functionality is leverage from the DAAC API.
On Sun, 4 Oct 2020 at 13:34, Eric Fielding notifications@github.com wrote:
I verified that this does not happen from my home ISP without the JPL full
tunnel VPN. It does happen running on a Linux machine inside the JPL
network, so it must be some kind of strange interaction between the ASF API
and the JPL firewall. This is the output from the JPL machine:
ariaDownload.py -b '32.8 33.2 -115.8 -115.2' --output download -s 20200301https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
attempting to download https://urs.earthdata.nasa.gov/profile
Could not validate old cookie Jar
No existing URS cookie found, please enter Earthdata username & password:
(Credentials will not be stored, saved or logged anywhere)
attempting to download https://urs.earthdata.nasa.gov/profile
Username: EJFielding
Password (will not be displayed):
attempting to download https://urs.earthdata.nasa.gov/profile
Using 1 threads for parallel downloads
attempting to download https://urs.earthdata.nasa.gov/profile
Re-using previous cookie jar.
'Temporary' Redirect download @ Remote archive:
http://34.231.8.234:6080/php/urlblock.php?args=AAAAdQAAABBwpAb7QQR4~szp0hI7hescAAAAED~TtODCx4FNxdBfaxdD0xAAAABFAAAARfnSPom0cnv1MFBgOWnEq64Zz9oVnwbZZW_v4zdETR0h7s9J3zCQbjVHLIBciBlXhEbykANQe4ooGANNdTqQb21PBj0H3A==&url=http://34.231.8.234%2Fdoor%2Fdownload%2FS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7 http://34.231.8.234:6080/php/urlblock.php?args=AAAAdQAAABBwpAb7QQR4~szp0hI7hescAAAAED~TtODCx4FNxdBfaxdD0xAAAABFAAAARfnSPom0cnv1MFBgOWnEq64Zz9oVnwbZZW_v4zdETR0h7s9J3zCQbjVHLIBciBlXhEbykANQe4ooGANNdTqQb21PBj0H3A==&url=http://34.231.8.234%2Fdoor%2Fdownload%2FS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
Downloaded 2945 of 2945 bytes (100.00%)
Downloaded 2945b in 1.54secs, Average Rate: 0.00MB/sec
'Temporary' Redirect download @ Remote archive:
https://dlz0dhr6g6ukw.cloudfront.net/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc?userid=ejfielding&Expires=1601843075&Signature=TWL79xHFjRrMhOJe5~Lq-hl-rDBX-~wC-5qFanCMNUmodXgi4TjTmYvbtCBeKQ4pNPTYGoJzYZ-FCRQjp8AdPoom68ZVVnWjy5HFHxt3-SrEzdnwVkRYcXpd5DPahBYstgDNXznXBYEEELeQmmkUb04zspb53N~SYjTGlP9XpT8_&Key-Pair-Id=APKAINVNJF4BDB5SS5QQ
(2/7 https://dlz0dhr6g6ukw.cloudfront.net/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc?userid=ejfielding&Expires=1601843075&Signature=TWL79xHFjRrMhOJe5~Lq-hl-rDBX-~wC-5qFanCMNUmodXgi4TjTmYvbtCBeKQ4pNPTYGoJzYZ-FCRQjp8AdPoom68ZVVnWjy5HFHxt3-SrEzdnwVkRYcXpd5DPahBYstgDNXznXBYEEELeQmmkUb04zspb53N~SYjTGlP9XpT8_&Key-Pair-Id=APKAINVNJF4BDB5SS5QQ(2/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
Downloaded 62309232 of 62309232 bytes (100.00%)
Downloaded 62309232b in 3.29secs, Average Rate: 18.04MB/sec
I understand now that this is not likely to be due to a bug in ARIA-tools,
but it seems like ARIA-tools should do a better job of detecting that there
was a download error. I tried running it a second time, and it correctly
determined that the previous download was bad, removed it, and tried again,
but then it puts the bad file in the "successful" part of the output list
when it is still a bad file.
ariaDownload.py -b '32.8 33.2 -115.8 -115.2' --output download -s 20200301https://api.daac.asf.alaska.edu/services/search/param?asfplatform=Sentinel-1%20Interferogram%20(BETA)&processingLevel=GUNW_STD&output=JSON&bbox=-115.8,32.8,-115.2,33.2
Attempting to obtaining user/pass from .netrc
WARNING: Could not obtain credentials from existing .netrc
attempting to download https://urs.earthdata.nasa.gov/profile
Re-using previous cookie jar.
Using 1 threads for parallel downloads
attempting to download https://urs.earthdata.nasa.gov/profile
Re-using previous cookie jar.
Found S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc but it wasn't fully downloaded. Removing file and downloading again.
'Temporary' Redirect download @ Remote archive:
http://35.169.211.218:6080/php/urlblock.php?args=AAAAdQAAABBTiFBxhKo4j87OzC7baDDvAAAAEI3H9N2E7hHh59ydT~9cenUAAABFAAAARTD9SOe2fKSdJnx34~LmkIlnKfjA4WESmIery8u5hctUS2FNTHK1TwaCqM50KUc0Zxfln0phHSMmrEkL3J6M7H4KC_hLFQ==&url=http://35.169.211.218%2Fdoor%2Fdownload%2FS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
(1/7 http://35.169.211.218:6080/php/urlblock.php?args=AAAAdQAAABBTiFBxhKo4j87OzC7baDDvAAAAEI3H9N2E7hHh59ydT~9cenUAAABFAAAARTD9SOe2fKSdJnx34~LmkIlnKfjA4WESmIery8u5hctUS2FNTHK1TwaCqM50KUc0Zxfln0phHSMmrEkL3J6M7H4KC_hLFQ==&url=http://35.169.211.218%2Fdoor%2Fdownload%2FS1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc(1/7) Downloading https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc
Downloaded 2949 of 2949 bytes (100.00%)
Downloaded 2949b in 2.31secs, Average Rate: 0.00MB/sec
Download file S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc.
Download file S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc.
Download file S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc.
Download file S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc.
Download file S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc.
Download file S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc exists!
Skipping download of https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc.
Download Summary
Successes: 1 files, 2949 bytes
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc 0.00MB
Skipped: 6 files
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134413-33072N_31090N-PP-9984-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200301-134348-34565N_32585N-PP-2e23-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200313_20200307-134348-34565N_32585N-PP-5a99-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-A-R-166-tops-20200313_20200301-014119-34455N_32574N-PP-5234-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134455-33072N_31090N-PP-7fbd-v2_0_2.nc
- https://grfn.asf.alaska.edu/door/download/S1-GUNW-D-R-173-tops-20200307_20200301-134430-34565N_32585N-PP-9eba-v2_0_2.nc
Average Rate: 0.00MB/sec
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/aria-tools/ARIA-tools/issues/231#issuecomment-703312302,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AESZPSKSVIJYXQNXVYVYRBTSJDL6NANCNFSM4SBI6BNA
.
@emlundell Are you the one to ask about this ASF API problem where it is providing a bad redirect for one of the GRFN products (S1-GUNW-D-R-173-tops-20200313_20200301-134413-33072N_31090N-PP-7694-v2_0_2.nc) that then gets blocked by the JPL firewall?
@EJFielding @glshort is responsible for the ASF Search API up until the GRFN products are requested via grfn.asf.alaska.edu/door/download. After that point @asjohnston-asf is currently responsible. Any bugs or outstanding errors should be redirected to them since they know their systems the best.
I tried this download again from a machine on the JPL network, and it completed correctly, so it seems that whatever was causing the problem was fixed.
| gharchive/issue | 2020-10-02T05:36:08 | 2025-04-01T06:37:57.237044 | {
"authors": [
"EJFielding",
"dbekaert",
"emlundell"
],
"repo": "aria-tools/ARIA-tools",
"url": "https://github.com/aria-tools/ARIA-tools/issues/231",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
958662810 | sticker.js gini
[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Maksimal 10 detik!".] {
code: 'ERR_UNHANDLED_REJECTION'
} unhandledRejection
cek kembali
| gharchive/issue | 2021-08-03T02:41:00 | 2025-04-01T06:37:57.245388 | {
"authors": [
"Ftwrr",
"ariffb25"
],
"repo": "ariffb25/stikerinbot",
"url": "https://github.com/ariffb25/stikerinbot/issues/51",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
865899306 | Fix references to cvp dirs
Change Summary
Correct CI references to AVD directories instead of CVP.
Not needed
| gharchive/pull-request | 2021-04-23T08:52:02 | 2025-04-01T06:37:57.246280 | {
"authors": [
"ClausHolbechArista"
],
"repo": "aristanetworks/ansible-avd",
"url": "https://github.com/aristanetworks/ansible-avd/pull/891",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
328152985 | How long geofence will monitor?
How long geofence will monitor? (1 day, 1 month, forever or one time trigged)
Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)
[x] iOS
[x] Android
[x] UWP
[x] .NET Standard
Version of OS(s) listed above with issue
Version of Library
Expected Behaviour
Actual Behavior
If applicable, please include entire exception - type, message, stacktrace
Code of Conduct
No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
Please be respectful of my time. I put a lot of effort into my libraries. I try to support the issue requests within a day. I'm not psychic, so please take the time to fill out the above form as complete as possible
Until you stop monitoring it. Please take a look through the code yourself in the future. It isn’t that big
Thank you!
| gharchive/issue | 2018-05-31T14:05:45 | 2025-04-01T06:37:57.260103 | {
"authors": [
"aritchie",
"nguyenthanhliemfc"
],
"repo": "aritchie/geofences",
"url": "https://github.com/aritchie/geofences/issues/12",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
31946509 | Phantom continually crashing on .abort() or changing the location. (minidump included)
I have about 300 unit tests and about 10% of them are causing phantom to crash.
I minidumped all their .dmp file and they were ALL in the same stack trace (as below)
I removed the line to request.abort() in one of my onResourceRequested events and it immediately fell to about 2% ... so I just had 5-6 .dmp files a this point and these ALSO were crashing at the same didCancel() point.
... and I suspect this is because after the page is loading, some pages have pending resources. But I load about:blank to save memory and that causes the browser to crash since it aborts URLs being loaded (at least that's my theory).
So pretty sure this is a frequent crash issue for others a well.
Operating system: Linux
0.0.0 Linux 3.0.3 #1 SMP Thu Aug 25 19:42:36 UTC 2011 x86_64
CPU: amd64
family 6 model 26 stepping 5
16 CPUs
Crash reason: SIGSEGV
Crash address: 0x0
Thread 0 (crashed)
0 phantomjs!WebCore::ResourceLoader::didCancel [ResourceLoader.cpp : 366 + 0x0]
rbx = 0x00007f8ef239cb00 r12 = 0x00007f8ef2503978
r13 = 0x00007f8ef2399808 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x000000000088573a
rsp = 0x00007ffff7547e28 rbp = 0x00007ffff7547e50
Found by: given as instruction pointer in context
1 0x7f8ef25038ff
rbx = 0x0000000000872e00 r12 = 0x00007f8ef2503978
r13 = 0x00007f8ef2399808 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x00007f8ef2503900
rsp = 0x00007ffff7547e48 rbp = 0x00007f8ef239cb00
Found by: call frame info
2 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 381 + 0x7]
rip = 0x0000000000885527 rsp = 0x00007ffff7547e50
Found by: stack scanning
3 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 371 + 0x1]
rbx = 0x00007f8ef2399800 r12 = 0x00007f8ef2503900
rip = 0x0000000000884e69 rsp = 0x00007ffff7547ea0
rbp = 0x00007f8ef239cb00
Found by: call frame info
4 phantomjs!WebCore::DocumentLoader::stopLoading [DocumentLoader.cpp : 252 + 0x7]
rbx = 0x00007f8ef2399800 r12 = 0x00007f8ef2503900
rip = 0x0000000000843932 rsp = 0x00007ffff7547ef0
rbp = 0x00007f8ef239cb00
Found by: call frame info
5 phantomjs!WebCore::NavigationScheduler::schedule [NavigationScheduler.cpp : 405 + 0x4]
rbx = 0x00007f8ef2503c98 r12 = 0x0000000000000001
r13 = 0x00007f8ef31b1f50 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000882e86
rsp = 0x00007ffff7547fa0 rbp = 0x00007ffff7548080
Found by: call frame info
6 phantomjs!WebCore::NavigationScheduler::scheduleLocationChange [NavigationScheduler.cpp : 333 + 0x4]
rbx = 0x00007f8ef2503c98 r12 = 0x0000000000000001
r13 = 0x00007f8ef31b1f50 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000883fd9
rsp = 0x00007ffff7547fc0 rbp = 0x00007ffff7548180
Found by: call frame info
7 phantomjs!WebCore::SubframeLoader::loadOrRedirectSubframe [SubframeLoader.cpp : 238 + 0x19]
rbx = 0x0000000000000000 r12 = 0x00007ffff75480f0
r13 = 0x00007f8eec06b2a0 r14 = 0x0000000000000000
r15 = 0x00007f8ef2503900 rip = 0x000000000088e41f
rsp = 0x00007ffff75480e0 rbp = 0x00007f8f3aed9d10
Found by: call frame info
8 phantomjs!WebCore::SubframeLoader::requestFrame [SubframeLoader.cpp : 83 + 0x1d]
rbx = 0x0000000000000000 r12 = 0x0000000000000001
r13 = 0x00007f8f3aed9d10 r14 = 0x0000000000000000
r15 = 0x0000000000000000 rip = 0x000000000088efa8
rsp = 0x00007ffff7548160 rbp = 0x00007f8ef22e57e0
Found by: call frame info
9 phantomjs!WebCore::HTMLFrameElementBase::openURL [HTMLFrameElementBase.cpp : 108 + 0x23]
rbx = 0x0000000000000001 r12 = 0x00007f8eec06b210
r13 = 0x00007f8eec06b210 r14 = 0x00007f8eec06b298
r15 = 0x0000000000000000 rip = 0x000000000077b238
rsp = 0x00007ffff75482c0 rbp = 0x00007f8ef3591b60
Found by: call frame info
10 phantomjs!WebCore::HTMLFrameElementBase::parseMappedAttribute [HTMLFrameElementBase.cpp : 116 + 0x16]
rbx = 0x0000000000000001 r12 = 0x00007f8eec06b210
r13 = 0x00007f8eec06b210 r14 = 0x0000000000000000
r15 = 0x00007f8eec06b210 rip = 0x000000000077b5c7
rsp = 0x00007ffff7548320 rbp = 0x00007f8ef3591b60
Found by: call frame info
11 phantomjs!WebCore::HTMLIFrameElement::parseMappedAttribute [HTMLIFrameElement.cpp : 131 + 0x4]
rbx = 0x0000000000000001 r12 = 0x00007f8ef3591b60
r13 = 0x00007f8eec06b210 r14 = 0x0000000000000000
r15 = 0x00007f8eec06b210 rip = 0x00000000010e170f
rsp = 0x00007ffff75483b0 rbp = 0x00007f8ef3591b60
Found by: call frame info
12 phantomjs!WebCore::StyledElement::attributeChanged [StyledElement.cpp : 188 + 0xf]
rbx = 0x0000000000000001 r12 = 0x00007f8ef3591b60
r13 = 0x00007f8eec06b210 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x00000000010734a4
rsp = 0x00007ffff7548410 rbp = 0x0000000000000001
Found by: call frame info
13 phantomjs!WebCore::Element::setAttribute [Element.cpp : 692 + 0x15]
rbx = 0x00007f8ef3591b60 r12 = 0x0000000000000008
r13 = 0x00007f8ef2e9d1d8 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x0000000000634762
rsp = 0x00007ffff75484b0 rbp = 0x0000000000000000
Found by: call frame info
14 phantomjs!WebCore::jsElementPrototypeFunctionSetAttribute [JSElement.cpp : 1614 + 0x1a]
rbx = 0x000000000000000a r12 = 0x00007f8f3b7e11b8
r13 = 0x00007f8ef19117e0 r14 = 0x00007f8f3b9f5fd0
r15 = 0x0000000000000001 rip = 0x0000000000c2def4
rsp = 0x00007ffff7548550 rbp = 0x00007f8f3b9f5fe8
Found by: call frame info
15 0x7f8ef40001e7
rbx = 0x00007f8f3b606e60 r12 = 0x000000000327599a
r13 = 0x00007f8f3b9f5f58 r14 = 0xffff000000000000
r15 = 0xffff000000000002 rip = 0x00007f8ef40001e8
rsp = 0x00007ffff7548620 rbp = 0x00007ffff75486d0
Found by: call frame info
16 phantomjs!JSC::Interpreter::execute [JITCode.h : 77 + 0x7]
rip = 0x0000000000f2c1eb rsp = 0x00007ffff75486e0
Found by: stack scanning
17 phantomjs!JSC::evaluate [Completion.cpp : 64 + 0x1b]
rbx = 0x00007f8f3c62b868 r12 = 0x00007f8ef1aa1d50
r13 = 0x00007ffff75489a8 r14 = 0x00007f8f3efa8940
r15 = 0x00007f8f3b606e60 rip = 0x00000000004f9538
rsp = 0x00007ffff7548760 rbp = 0x00007f8f3efa8958
Found by: call frame info
18 phantomjs!WebCore::ScriptController::evaluateInWorld [JSMainThreadExecState.h : 54 + 0x4]
rbx = 0x0000000002a9ed10 r12 = 0x00007f8f3efa8958
r13 = 0x00007f8f3aed9f18 r14 = 0x00007f8f3aed9b00
r15 = 0x00007f8f3b5e25d0 rip = 0x00000000005291da
rsp = 0x00007ffff7548810 rbp = 0x00007f8f3efa8958
Found by: call frame info
19 phantomjs!WebCore::ScriptController::evaluate [ScriptController.cpp : 167 + 0x15]
rbx = 0x00007ffff75489a0 r12 = 0x00007f8f3aed9f18
r13 = 0x00007ffff7548920 r14 = 0x0000000000000001
r15 = 0x0000000000000001 rip = 0x00000000005294d2
rsp = 0x00007ffff7548900 rbp = 0x00007ffff7548a00
Found by: call frame info
20 phantomjs!WebCore::ScriptController::executeScript [ScriptControllerBase.cpp : 64 + 0xd]
rbx = 0x00007f8f3aed9f18 r12 = 0x00007ffff75489a0
r13 = 0x00007f8f3aed9b00 r14 = 0x0000000000000001
r15 = 0x0000000000000001 rip = 0x000000000051a475
rsp = 0x00007ffff7548920 rbp = 0x00007ffff7548a00
Found by: call frame info
21 phantomjs!QWebFrame::evaluateJavaScript [qwebframe.cpp : 1556 + 0x23]
rbx = 0x00007ffff75489a0 r12 = 0x0000000000000001
r13 = 0x00007f8ef1e22e10 r14 = 0x00007ffff7548aa0
r15 = 0x00007f8f3aed9f18 rip = 0x000000000047fb3c
rsp = 0x00007ffff7548980 rbp = 0x0000000000000001
Found by: call frame info
22 phantomjs!WebPage::evaluateJavaScript [webpage.cpp : 683 + 0x13]
rbx = 0x00007f8eec1e14f0 r12 = 0x00007f8eec1e1500
r13 = 0x00007ffff7548c00 r14 = 0x00007ffff7548ab0
r15 = 0x000000000401ec00 rip = 0x000000000041f1b9
rsp = 0x00007ffff7548aa0 rbp = 0x00007ffff7548b30
Found by: call frame info
23 phantomjs!WebPage::qt_static_metacall [moc_webpage.cpp : 224 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aa42
rsp = 0x00007ffff7548c00 rbp = 0x00007ffff75495c0
Found by: call frame info
24 phantomjs!WebPage::qt_metacall [moc_webpage.cpp : 338 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aebf
rsp = 0x00007ffff7548d30 rbp = 0x00007ffff75495c0
Found by: call frame info
25 phantomjs!JSC::Bindings::QtRuntimeMetaMethod::call [qt_runtime.cpp : 1455 + 0x17]
rbx = 0x00007ffff7549390 r12 = 0x00007ffff75495c0
r13 = 0x00007f8ef1a9cdd0 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x0000000000552f07
rsp = 0x00007ffff7548ec0 rbp = 0x0000000000000002
Found by: call frame info
26 phantomjs!JSC::cti_op_call_NotJSFunction [JITStubs.cpp : 2191 + 0x3]
rbx = 0x0000000000000000 r12 = 0x00007f8f3b9f5b80
r13 = 0x00007f8ef276d260 r14 = 0x00007ffff7549cc8
r15 = 0x00007f8f3b9f5b00 rip = 0x0000000000f5d075
rsp = 0x00007ffff7549c70 rbp = 0x00007ffff7549cd0
Found by: call frame info
27 0x7f8ef473b440
rbx = 0x00007f8f3efbcb10 r12 = 0x0000000000000178
r13 = 0x00007f8f3b9f5b00 r14 = 0xffff000000000000
r15 = 0xffff000000000002 rip = 0x00007f8ef473b441
rsp = 0x00007ffff7549cd0 rbp = 0x00007ffff7549d70
Found by: call frame info
28 libc-2.11.3.so + 0x76c6f
rip = 0x00007f8f3d9bbc70 rsp = 0x00007ffff7549d10
rbp = 0x00007ffff7549d70
Found by: stack scanning
29 phantomjs!JSC::Interpreter::executeCall [JITCode.h : 77 + 0x16]
rip = 0x0000000000f2e376 rsp = 0x00007ffff7549d80
Found by: stack scanning
30 phantomjs!JSC::call [CallData.cpp : 38 + 0x21]
rbx = 0x00007ffff7549fb0 r12 = 0x00007f8ef1f0c5b0
r13 = 0x00007f8f3b5c45d0 r14 = 0x00007f8f3efa8150
r15 = 0x00007f8f3c6168f0 rip = 0x0000000000f7291d
rsp = 0x00007ffff7549e50 rbp = 0x00007f8ef1bcd790
Found by: call frame info
31 phantomjs!JSC::Bindings::QtConnectionObject::execute [qt_runtime.cpp : 1863 + 0x17]
rbx = 0x00007ffff7549fb0 r12 = 0x00007f8ef1f0c5b0
r13 = 0x00007f8f3b5c45d0 r14 = 0x00007f8f3efa8150
r15 = 0x00007f8f3c6168f0 rip = 0x0000000000542ece
rsp = 0x00007ffff7549e60 rbp = 0x00007f8ef1bcd790
Found by: call frame info
32 phantomjs!JSC::Bindings::QtConnectionObject::qt_metacall [qt_runtime.cpp : 1807 + 0xa]
rbx = 0x0000000000000000 r12 = 0x00007ffff754a230
r13 = 0x000000000405f440 r14 = 0x0000000000000004
r15 = 0x0000000004079b10 rip = 0x000000000054390c
rsp = 0x00007ffff754a0e0 rbp = 0x0000000000000000
Found by: call frame info
33 phantomjs!QMetaObject::activate [qobject.cpp : 3555 + 0x1f]
rbx = 0x0000000000000004 r12 = 0x000000000401ec01
r13 = 0x0000000000000000 r14 = 0x0000000000000004
r15 = 0x0000000004079b10 rip = 0x0000000001cf7160
rsp = 0x00007ffff754a110 rbp = 0x000000000405f440
Found by: call frame info
34 phantomjs!WebPage::resourceError [moc_webpage.cpp : 470 + 0x4]
rbx = 0x0000000000000004 r12 = 0x000000000401ec00
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x000000000046a033
rsp = 0x00007ffff754a230 rbp = 0x00007ffff754a4a0
Found by: call frame info
35 phantomjs!WebPage::qt_static_metacall [moc_webpage.cpp : 215 + 0x8]
rbx = 0x0000000000000004 r12 = 0x000000000401ec00
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x000000000046aa69
rsp = 0x00007ffff754a250 rbp = 0x00007ffff754a4a0
Found by: call frame info
36 phantomjs!QMetaObject::activate [qobject.cpp : 3539 + 0x1e]
rbx = 0x0000000000000004 r12 = 0x00007ffff754a501
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x0000000001cf6ef8
rsp = 0x00007ffff754a380 rbp = 0x000000000401ec00
Found by: call frame info
37 phantomjs!NetworkAccessManager::resourceError [moc_networkaccessmanager.cpp : 278 + 0x4]
rbx = 0x00007ffff754a570 r12 = 0x00007ffff754a5b0
r13 = 0x00007ffff754a5a0 r14 = 0x00007ffff754a590
r15 = 0x00007ffff754a5c0 rip = 0x000000000046c483
rsp = 0x00007ffff754a4a0 rbp = 0x00007ffff754a560
Found by: call frame info
38 phantomjs!NetworkAccessManager::handleNetworkError [networkaccessmanager.cpp : 397 + 0x1f]
rbx = 0x00007ffff754a570 r12 = 0x00007ffff754a5b0
r13 = 0x00007ffff754a5a0 r14 = 0x00007ffff754a590
r15 = 0x00007ffff754a5c0 rip = 0x000000000042b903
rsp = 0x00007ffff754a4c0 rbp = 0x00007ffff754a560
Found by: call frame info
39 phantomjs!QMetaObject::activate [qobject.cpp : 3539 + 0x1e]
rbx = 0x000000000000000e r12 = 0x00007f8ef2504b01
r13 = 0x000000000046c540 r14 = 0x0000000000000008
r15 = 0x00000000043b12f0 rip = 0x0000000001cf6ef8
rsp = 0x00007ffff754a780 rbp = 0x00000000040211d0
Found by: call frame info
40 phantomjs!QNetworkReply::error [moc_qnetworkreply.cpp : 173 + 0x4]
rbx = 0x00000000043afb10 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000001ba74c1
rsp = 0x00007ffff754a8a0 rbp = 0x00000000043afd50
Found by: call frame info
41 phantomjs!QNetworkReplyImpl::abort [qnetworkreplyimpl.cpp : 882 + 0xf]
rbx = 0x00000000043afb10 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000001b32888
rsp = 0x00007ffff754a8d0 rbp = 0x00000000043afd50
Found by: call frame info
42 phantomjs!WebCore::QNetworkReplyHandler::abort [QNetworkReplyHandler.cpp : 416 + 0xb]
rbx = 0x00000000043afb10 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000ada4f2
rsp = 0x00007ffff754a900 rbp = 0x00000000043add60
Found by: call frame info
43 phantomjs!WebCore::ResourceHandle::cancel [ResourceHandleQt.cpp : 107 + 0x4]
rbx = 0x00007f8ef251a600 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000ad7f79
rsp = 0x00007ffff754a920 rbp = 0x00007ffff754a970
Found by: call frame info
44 phantomjs!WebCore::ResourceLoader::didCancel [ResourceLoader.cpp : 360 + 0x5]
rbx = 0x00007f8ef2538000 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x00000000008856c5
rsp = 0x00007ffff754a930 rbp = 0x00007ffff754a970
Found by: call frame info
45 phantomjs!WebCore::MainResourceLoader::didCancel [MainResourceLoader.cpp : 114 + 0xa]
rbx = 0x00007f8ef2538000 r12 = 0x00007f8ef2504b78
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000872e44
rsp = 0x00007ffff754a950 rbp = 0x00007ffff754a970
Found by: call frame info
46 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 381 + 0x7]
rbx = 0x0000000000872e00 r12 = 0x00007f8ef2504b00
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000885527
rsp = 0x00007ffff754a970 rbp = 0x00007f8ef2538000
Found by: call frame info
47 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 371 + 0x1]
rbx = 0x00007f8ef253d000 r12 = 0x00007f8ef2504b00
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000884e69
rsp = 0x00007ffff754a9c0 rbp = 0x00007f8ef2538000
Found by: call frame info
48 phantomjs!WebCore::DocumentLoader::stopLoading [DocumentLoader.cpp : 252 + 0x7]
rbx = 0x00007f8ef253d000 r12 = 0x00007f8ef2504b00
r13 = 0x00007f8ef253d008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000843932
rsp = 0x00007ffff754aa10 rbp = 0x00007f8ef2538000
Found by: call frame info
49 phantomjs!WebCore::NavigationScheduler::schedule [NavigationScheduler.cpp : 405 + 0x4]
rbx = 0x00007f8ef2504e98 r12 = 0x0000000000000001
r13 = 0x00007f8ef1ddaea8 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000882e86
rsp = 0x00007ffff754aac0 rbp = 0x00007ffff754aba0
Found by: call frame info
50 phantomjs!WebCore::NavigationScheduler::scheduleLocationChange [NavigationScheduler.cpp : 333 + 0x4]
rbx = 0x00007f8ef2504e98 r12 = 0x0000000000000001
r13 = 0x00007f8ef1ddaea8 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000883fd9
rsp = 0x00007ffff754aae0 rbp = 0x00007ffff754aca0
Found by: call frame info
51 phantomjs!WebCore::SubframeLoader::loadOrRedirectSubframe [SubframeLoader.cpp : 238 + 0x19]
rbx = 0x0000000000000000 r12 = 0x00007ffff754ac10
r13 = 0x00000000043a8370 r14 = 0x0000000000000000
r15 = 0x00007f8ef2504b00 rip = 0x000000000088e41f
rsp = 0x00007ffff754ac00 rbp = 0x00007f8f3aed9d10
Found by: call frame info
52 phantomjs!WebCore::SubframeLoader::requestFrame [SubframeLoader.cpp : 83 + 0x1d]
rbx = 0x0000000000000000 r12 = 0x0000000000000001
r13 = 0x00007f8f3aed9d10 r14 = 0x0000000000000000
r15 = 0x0000000000000000 rip = 0x000000000088efa8
rsp = 0x00007ffff754ac80 rbp = 0x00007f8ef22e57e0
Found by: call frame info
53 phantomjs!WebCore::HTMLFrameElementBase::openURL [HTMLFrameElementBase.cpp : 108 + 0x23]
rbx = 0x0000000000000001 r12 = 0x00000000043a82e0
r13 = 0x00000000043a82e0 r14 = 0x00000000043a8368
r15 = 0x0000000000000000 rip = 0x000000000077b238
rsp = 0x00007ffff754ade0 rbp = 0x00007f8ef33ab240
Found by: call frame info
54 phantomjs!WebCore::HTMLFrameElementBase::parseMappedAttribute [HTMLFrameElementBase.cpp : 116 + 0x16]
rbx = 0x0000000000000001 r12 = 0x00000000043a82e0
r13 = 0x00000000043a82e0 r14 = 0x0000000000000000
r15 = 0x00000000043a82e0 rip = 0x000000000077b5c7
rsp = 0x00007ffff754ae40 rbp = 0x00007f8ef33ab240
Found by: call frame info
55 phantomjs!WebCore::HTMLIFrameElement::parseMappedAttribute [HTMLIFrameElement.cpp : 131 + 0x4]
rbx = 0x0000000000000001 r12 = 0x00007f8ef33ab240
r13 = 0x00000000043a82e0 r14 = 0x0000000000000000
r15 = 0x00000000043a82e0 rip = 0x00000000010e170f
rsp = 0x00007ffff754aed0 rbp = 0x00007f8ef33ab240
Found by: call frame info
56 phantomjs!WebCore::StyledElement::attributeChanged [StyledElement.cpp : 188 + 0xf]
rbx = 0x0000000000000001 r12 = 0x00007f8ef33ab240
r13 = 0x00000000043a82e0 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x00000000010734a4
rsp = 0x00007ffff754af30 rbp = 0x0000000000000001
Found by: call frame info
57 phantomjs!WebCore::Element::setAttribute [Element.cpp : 692 + 0x15]
rbx = 0x00007f8ef33ab240 r12 = 0x0000000000000008
r13 = 0x00007f8f38325868 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x0000000000634762
rsp = 0x00007ffff754afd0 rbp = 0x0000000000000000
Found by: call frame info
58 phantomjs!WebCore::jsElementPrototypeFunctionSetAttribute [JSElement.cpp : 1614 + 0x1a]
rbx = 0x000000000000000a r12 = 0x00007f8f3b7e11b8
r13 = 0x00007f8ef1de0000 r14 = 0x00007f8f3b9f53b0
r15 = 0x0000000000000001 rip = 0x0000000000c2def4
rsp = 0x00007ffff754b070 rbp = 0x00007f8f3b9f53c8
Found by: call frame info
59 0x7f8ef40001e7
rbx = 0x00007f8f3b606e60 r12 = 0x0000000000283c53
r13 = 0x00007f8f3b9f5338 r14 = 0xffff000000000000
r15 = 0xffff000000000002 rip = 0x00007f8ef40001e8
rsp = 0x00007ffff754b140 rbp = 0x00007ffff754b1f0
Found by: call frame info
60 phantomjs!JSC::Interpreter::execute [JITCode.h : 77 + 0x7]
rip = 0x0000000000f2c1eb rsp = 0x00007ffff754b200
Found by: stack scanning
61 phantomjs!JSC::evaluate [Completion.cpp : 64 + 0x1b]
rbx = 0x00007f8f3c62b868 r12 = 0x00007f8ef1ee2250
r13 = 0x00007ffff754b4c8 r14 = 0x00007f8f3efa8940
r15 = 0x00007f8f3b606e60 rip = 0x00000000004f9538
rsp = 0x00007ffff754b280 rbp = 0x00007f8f3efa8958
Found by: call frame info
62 phantomjs!WebCore::ScriptController::evaluateInWorld [JSMainThreadExecState.h : 54 + 0x4]
rbx = 0x0000000002a9ed10 r12 = 0x00007f8f3efa8958
r13 = 0x00007f8f3aed9f18 r14 = 0x00007f8f3aed9b00
r15 = 0x00007f8f3b5e25d0 rip = 0x00000000005291da
rsp = 0x00007ffff754b330 rbp = 0x00007f8f3efa8958
Found by: call frame info
63 phantomjs!WebCore::ScriptController::evaluate [ScriptController.cpp : 167 + 0x15]
rbx = 0x00007ffff754b4c0 r12 = 0x00007f8f3aed9f18
r13 = 0x00007ffff754b440 r14 = 0x0000000000000001
r15 = 0x0000000000000001 rip = 0x00000000005294d2
rsp = 0x00007ffff754b420 rbp = 0x00007ffff754b520
Found by: call frame info
64 phantomjs!WebCore::ScriptController::executeScript [ScriptControllerBase.cpp : 64 + 0xd]
rbx = 0x00007f8f3aed9f18 r12 = 0x00007ffff754b4c0
r13 = 0x00007f8f3aed9b00 r14 = 0x0000000000000001
r15 = 0x0000000000000001 rip = 0x000000000051a475
rsp = 0x00007ffff754b440 rbp = 0x00007ffff754b520
Found by: call frame info
65 phantomjs!QWebFrame::evaluateJavaScript [qwebframe.cpp : 1556 + 0x23]
rbx = 0x00007ffff754b4c0 r12 = 0x0000000000000001
r13 = 0x00007f8ef1f61e50 r14 = 0x00007ffff754b5c0
r15 = 0x00007f8f3aed9f18 rip = 0x000000000047fb3c
rsp = 0x00007ffff754b4a0 rbp = 0x0000000000000001
Found by: call frame info
66 phantomjs!WebPage::evaluateJavaScript [webpage.cpp : 683 + 0x13]
rbx = 0x00007f8eec1b4c80 r12 = 0x00007f8eec1b4c90
r13 = 0x00007ffff754b720 r14 = 0x00007ffff754b5d0
r15 = 0x000000000401ec00 rip = 0x000000000041f1b9
rsp = 0x00007ffff754b5c0 rbp = 0x00007ffff754b650
Found by: call frame info
67 phantomjs!WebPage::qt_static_metacall [moc_webpage.cpp : 224 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aa42
rsp = 0x00007ffff754b720 rbp = 0x00007ffff754c0e0
Found by: call frame info
68 phantomjs!WebPage::qt_metacall [moc_webpage.cpp : 338 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aebf
rsp = 0x00007ffff754b850 rbp = 0x00007ffff754c0e0
Found by: call frame info
69 phantomjs!JSC::Bindings::QtRuntimeMetaMethod::call [qt_runtime.cpp : 1455 + 0x17]
rbx = 0x00007ffff754beb0 r12 = 0x00007ffff754c0e0
r13 = 0x00007f8ef1eebe10 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x0000000000552f07
rsp = 0x00007ffff754b9e0 rbp = 0x0000000000000002
Found by: call frame info
70 phantomjs!JSC::cti_op_call_NotJSFunction [JITStubs.cpp : 2191 + 0x3]
rbx = 0x0000000000000000 r12 = 0x00007f8f3b9f4f60
r13 = 0x00007f8ef276d260 r14 = 0x00007ffff754c7e8
r15 = 0x00007f8f3b9f4ee0 rip = 0x0000000000f5d075
rsp = 0x00007ffff754c790 rbp = 0x00007ffff754c7f0
Found by: call frame info
71 0x7f8ef473b440
rbx = 0x00007f8ef473b37b r12 = 0x0000000000000178
r13 = 0x00007f8f3b9f4ee0 r14 = 0xffff000000000000
r15 = 0xffff000000000002 rip = 0x00007f8ef473b441
rsp = 0x00007ffff754c7f0 rbp = 0x00007ffff754c890
Found by: call frame info
72 libc-2.11.3.so + 0x76c6f
rip = 0x00007f8f3d9bbc70 rsp = 0x00007ffff754c830
rbp = 0x00007ffff754c890
Found by: stack scanning
73 phantomjs!JSC::Interpreter::executeCall [JITCode.h : 77 + 0x16]
rip = 0x0000000000f2e376 rsp = 0x00007ffff754c8a0
Found by: stack scanning
74 phantomjs!JSC::call [CallData.cpp : 38 + 0x21]
rbx = 0x00007ffff754cad0 r12 = 0x00007f8f3b6061e8
r13 = 0x00007f8f3b5c45d0 r14 = 0x00007f8f3efa8150
r15 = 0x00007f8f3c6168f0 rip = 0x0000000000f7291d
rsp = 0x00007ffff754c970 rbp = 0x00007f8ef1f04790
Found by: call frame info
75 phantomjs!JSC::Bindings::QtConnectionObject::execute [qt_runtime.cpp : 1863 + 0x17]
rbx = 0x00007ffff754cad0 r12 = 0x00007f8f3b6061e8
r13 = 0x00007f8f3b5c45d0 r14 = 0x00007f8f3efa8150
r15 = 0x00007f8f3c6168f0 rip = 0x0000000000542ece
rsp = 0x00007ffff754c980 rbp = 0x00007f8ef1f04790
Found by: call frame info
76 phantomjs!JSC::Bindings::QtConnectionObject::qt_metacall [qt_runtime.cpp : 1807 + 0xa]
rbx = 0x0000000000000000 r12 = 0x00007ffff754cd50
r13 = 0x000000000405f440 r14 = 0x0000000000000004
r15 = 0x0000000004079b10 rip = 0x000000000054390c
rsp = 0x00007ffff754cc00 rbp = 0x0000000000000000
Found by: call frame info
77 phantomjs!QMetaObject::activate [qobject.cpp : 3555 + 0x1f]
rbx = 0x0000000000000004 r12 = 0x000000000401ec01
r13 = 0x0000000000000000 r14 = 0x0000000000000004
r15 = 0x0000000004079b10 rip = 0x0000000001cf7160
rsp = 0x00007ffff754cc30 rbp = 0x000000000405f440
Found by: call frame info
78 phantomjs!WebPage::resourceError [moc_webpage.cpp : 470 + 0x4]
rbx = 0x0000000000000004 r12 = 0x000000000401ec00
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x000000000046a033
rsp = 0x00007ffff754cd50 rbp = 0x00007ffff754cfc0
Found by: call frame info
79 phantomjs!WebPage::qt_static_metacall [moc_webpage.cpp : 215 + 0x8]
rbx = 0x0000000000000004 r12 = 0x000000000401ec00
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x000000000046aa69
rsp = 0x00007ffff754cd70 rbp = 0x00007ffff754cfc0
Found by: call frame info
80 phantomjs!QMetaObject::activate [qobject.cpp : 3539 + 0x1e]
rbx = 0x0000000000000004 r12 = 0x00007ffff754d001
r13 = 0x000000000046a210 r14 = 0x0000000000000008
r15 = 0x0000000004057dc0 rip = 0x0000000001cf6ef8
rsp = 0x00007ffff754cea0 rbp = 0x000000000401ec00
Found by: call frame info
81 phantomjs!NetworkAccessManager::resourceError [moc_networkaccessmanager.cpp : 278 + 0x4]
rbx = 0x00007ffff754d090 r12 = 0x00007ffff754d0d0
r13 = 0x00007ffff754d0c0 r14 = 0x00007ffff754d0b0
r15 = 0x00007ffff754d0e0 rip = 0x000000000046c483
rsp = 0x00007ffff754cfc0 rbp = 0x00007ffff754d080
Found by: call frame info
82 phantomjs!NetworkAccessManager::handleNetworkError [networkaccessmanager.cpp : 397 + 0x1f]
rbx = 0x00007ffff754d090 r12 = 0x00007ffff754d0d0
r13 = 0x00007ffff754d0c0 r14 = 0x00007ffff754d0b0
r15 = 0x00007ffff754d0e0 rip = 0x000000000042b903
rsp = 0x00007ffff754cfe0 rbp = 0x00007ffff754d080
Found by: call frame info
83 phantomjs!QMetaObject::activate [qobject.cpp : 3539 + 0x1e]
rbx = 0x000000000000000e r12 = 0x00007f8ef2d94001
r13 = 0x000000000046c540 r14 = 0x0000000000000008
r15 = 0x00007f8eec04df70 rip = 0x0000000001cf6ef8
rsp = 0x00007ffff754d2a0 rbp = 0x00000000040211d0
Found by: call frame info
84 phantomjs!QNetworkReply::error [moc_qnetworkreply.cpp : 173 + 0x4]
rbx = 0x00007f8eec04f7b0 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000001ba74c1
rsp = 0x00007ffff754d3c0 rbp = 0x00007f8eec0393d0
Found by: call frame info
85 phantomjs!QNetworkReplyImpl::abort [qnetworkreplyimpl.cpp : 882 + 0xf]
rbx = 0x00007f8eec04f7b0 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000001b32888
rsp = 0x00007ffff754d3f0 rbp = 0x00007f8eec0393d0
Found by: call frame info
86 phantomjs!WebCore::QNetworkReplyHandler::abort [QNetworkReplyHandler.cpp : 416 + 0xb]
rbx = 0x00007f8eec04f7b0 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000ada4f2
rsp = 0x00007ffff754d420 rbp = 0x00007f8eec07e230
Found by: call frame info
87 phantomjs!WebCore::ResourceHandle::cancel [ResourceHandleQt.cpp : 107 + 0x4]
rbx = 0x00007f8ef251a918 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000ad7f79
rsp = 0x00007ffff754d440 rbp = 0x00007ffff754d490
Found by: call frame info
88 phantomjs!WebCore::ResourceLoader::didCancel [ResourceLoader.cpp : 360 + 0x5]
rbx = 0x00007f8ef239b900 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x00000000008856c5
rsp = 0x00007ffff754d450 rbp = 0x00007ffff754d490
Found by: call frame info
89 phantomjs!WebCore::MainResourceLoader::didCancel [MainResourceLoader.cpp : 114 + 0xa]
rbx = 0x00007f8ef239b900 r12 = 0x00007f8ef2d94078
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000872e44
rsp = 0x00007ffff754d470 rbp = 0x00007ffff754d490
Found by: call frame info
90 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 381 + 0x7]
rbx = 0x0000000000872e00 r12 = 0x00007f8ef2d94000
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000885527
rsp = 0x00007ffff754d490 rbp = 0x00007f8ef239b900
Found by: call frame info
91 phantomjs!WebCore::ResourceLoader::cancel [ResourceLoader.cpp : 371 + 0x1]
rbx = 0x00007f8ef2399000 r12 = 0x00007f8ef2d94000
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000884e69
rsp = 0x00007ffff754d4e0 rbp = 0x00007f8ef239b900
Found by: call frame info
92 phantomjs!WebCore::DocumentLoader::stopLoading [DocumentLoader.cpp : 252 + 0x7]
rbx = 0x00007f8ef2399000 r12 = 0x00007f8ef2d94000
r13 = 0x00007f8ef2399008 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000843932
rsp = 0x00007ffff754d530 rbp = 0x00007f8ef239b900
Found by: call frame info
93 phantomjs!WebCore::NavigationScheduler::schedule [NavigationScheduler.cpp : 405 + 0x4]
rbx = 0x00007f8ef2d94398 r12 = 0x0000000000000001
r13 = 0x00007f8ef227e1c0 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000882e86
rsp = 0x00007ffff754d5e0 rbp = 0x00007ffff754d6c0
Found by: call frame info
94 phantomjs!WebCore::NavigationScheduler::scheduleLocationChange [NavigationScheduler.cpp : 333 + 0x4]
rbx = 0x00007f8ef2d94398 r12 = 0x0000000000000001
r13 = 0x00007f8ef227e1c0 r14 = 0x0000000000000001
r15 = 0x00007f8f3c6ab3f0 rip = 0x0000000000883fd9
rsp = 0x00007ffff754d600 rbp = 0x00007ffff754d7c0
Found by: call frame info
95 phantomjs!WebCore::SubframeLoader::loadOrRedirectSubframe [SubframeLoader.cpp : 238 + 0x19]
rbx = 0x0000000000000000 r12 = 0x00007ffff754d730
r13 = 0x0000000004280f20 r14 = 0x0000000000000000
r15 = 0x00007f8ef2d94000 rip = 0x000000000088e41f
rsp = 0x00007ffff754d720 rbp = 0x00007f8f3aed9d10
Found by: call frame info
96 phantomjs!WebCore::SubframeLoader::requestFrame [SubframeLoader.cpp : 83 + 0x1d]
rbx = 0x0000000000000000 r12 = 0x0000000000000001
r13 = 0x00007f8f3aed9d10 r14 = 0x0000000000000000
r15 = 0x0000000000000000 rip = 0x000000000088efa8
rsp = 0x00007ffff754d7a0 rbp = 0x00007f8ef22e57e0
Found by: call frame info
97 phantomjs!WebCore::HTMLFrameElementBase::openURL [HTMLFrameElementBase.cpp : 108 + 0x23]
rbx = 0x0000000000000001 r12 = 0x0000000004280e90
r13 = 0x0000000004280e90 r14 = 0x0000000004280f18
r15 = 0x0000000000000000 rip = 0x000000000077b238
rsp = 0x00007ffff754d900 rbp = 0x00007f8ef2ea3700
Found by: call frame info
98 phantomjs!WebCore::HTMLFrameElementBase::parseMappedAttribute [HTMLFrameElementBase.cpp : 116 + 0x16]
rbx = 0x0000000000000001 r12 = 0x0000000004280e90
r13 = 0x0000000004280e90 r14 = 0x0000000000000000
r15 = 0x0000000004280e90 rip = 0x000000000077b5c7
rsp = 0x00007ffff754d960 rbp = 0x00007f8ef2ea3700
Found by: call frame info
99 phantomjs!WebCore::HTMLIFrameElement::parseMappedAttribute [HTMLIFrameElement.cpp : 131 + 0x4]
rbx = 0x0000000000000001 r12 = 0x00007f8ef2ea3700
r13 = 0x0000000004280e90 r14 = 0x0000000000000000
r15 = 0x0000000004280e90 rip = 0x00000000010e170f
rsp = 0x00007ffff754d9f0 rbp = 0x00007f8ef2ea3700
Found by: call frame info
100 phantomjs!WebCore::StyledElement::attributeChanged [StyledElement.cpp : 188 + 0xf]
rbx = 0x0000000000000001 r12 = 0x00007f8ef2ea3700
r13 = 0x0000000004280e90 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x00000000010734a4
rsp = 0x00007ffff754da50 rbp = 0x0000000000000001
Found by: call frame info
101 phantomjs!WebCore::Element::setAttribute [Element.cpp : 692 + 0x15]
rbx = 0x00007f8ef2ea3700 r12 = 0x0000000000000005
r13 = 0x00007f8f3b42aad0 r14 = 0x0000000000000000
r15 = 0x0000000002a98e38 rip = 0x0000000000634762
rsp = 0x00007ffff754daf0 rbp = 0x0000000000000002
Found by: call frame info
102 phantomjs!WebCore::jsElementPrototypeFunctionSetAttribute [JSElement.cpp : 1614 + 0x1a]
rbx = 0x000000000000000a r12 = 0x00007f8f3b7e11b8
r13 = 0x00007f8ef22e57e0 r14 = 0x00007f8f3b9f4790
r15 = 0x0000000000000001 rip = 0x0000000000c2def4
rsp = 0x00007ffff754db90 rbp = 0x00007f8f3b9f47a8
Found by: call frame info
103 0x7f8ef40001e7
rbx = 0x00007f8ef29feed0 r12 = 0x0000000000019d40
r13 = 0x00007f8f3b9f4718 r14 = 0xffff000000000000
r15 = 0xffff000000000002 rip = 0x00007f8ef40001e8
rsp = 0x00007ffff754dc60 rbp = 0x00007ffff754dd10
Found by: call frame info
104 libstdc++.so.6.0.13 + 0xcb6bc
rip = 0x00007f8f3e20a6bd rsp = 0x00007ffff754dca0
rbp = 0x00007ffff754dd10
Found by: stack scanning
105 phantomjs!JSC::Interpreter::execute [JITCode.h : 77 + 0x7]
rip = 0x0000000000f2c1eb rsp = 0x00007ffff754dd20
Found by: stack scanning
106 phantomjs!JSC::evaluate [Completion.cpp : 64 + 0x1b]
rbx = 0x00007f8f3c62b868 r12 = 0x00007f8ef2a52650
r13 = 0x00007ffff754dfe8 r14 = 0x00007f8f3efa8940
r15 = 0x00007f8f3b606e60 rip = 0x00000000004f9538
rsp = 0x00007ffff754dda0 rbp = 0x00007f8f3efa8958
Found by: call frame info
107 phantomjs!WebCore::ScriptController::evaluateInWorld [JSMainThreadExecState.h : 54 + 0x4]
rbx = 0x0000000002a9ed10 r12 = 0x0000000000000000
r13 = 0x00007f8f3aed9f18 r14 = 0x00007f8f3aed9b00
r15 = 0x00007f8f3b5e25d0 rip = 0x00000000005291da
rsp = 0x00007ffff754de50 rbp = 0x00007f8f3efa8958
Found by: call frame info
108 phantomjs!WebCore::ScriptController::evaluate [ScriptController.cpp : 167 + 0x15]
rbx = 0x00007ffff754dfe0 r12 = 0x00007f8f3aed9f18
r13 = 0x00007ffff754df60 r14 = 0x0000000000000000
r15 = 0x0000000000000001 rip = 0x00000000005294d2
rsp = 0x00007ffff754df40 rbp = 0x00007ffff754e040
Found by: call frame info
109 phantomjs!WebCore::ScriptController::executeScript [ScriptControllerBase.cpp : 64 + 0xd]
rbx = 0x00007f8f3aed9f18 r12 = 0x00007ffff754dfe0
r13 = 0x00007f8f3aed9b00 r14 = 0x0000000000000000
r15 = 0x0000000000000001 rip = 0x000000000051a475
rsp = 0x00007ffff754df60 rbp = 0x00007ffff754e040
Found by: call frame info
110 phantomjs!QWebFrame::evaluateJavaScript [qwebframe.cpp : 1556 + 0x23]
rbx = 0x00007ffff754dfe0 r12 = 0x0000000000000001
r13 = 0x00007f8ef28348d0 r14 = 0x00007ffff754e0e0
r15 = 0x00007f8f3aed9f18 rip = 0x000000000047fb3c
rsp = 0x00007ffff754dfc0 rbp = 0x0000000000000001
Found by: call frame info
111 phantomjs!WebPage::evaluateJavaScript [webpage.cpp : 683 + 0x13]
rbx = 0x00007f8eec08f8c0 r12 = 0x00007f8eec08f8d0
r13 = 0x00007ffff754e240 r14 = 0x00007ffff754e0f0
r15 = 0x000000000401ec00 rip = 0x000000000041f1b9
rsp = 0x00007ffff754e0e0 rbp = 0x00007ffff754e170
Found by: call frame info
112 phantomjs!WebPage::qt_static_metacall [moc_webpage.cpp : 224 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aa42
rsp = 0x00007ffff754e240 rbp = 0x00007ffff754ec00
Found by: call frame info
113 phantomjs!WebPage::qt_metacall [moc_webpage.cpp : 338 + 0xe]
rbx = 0x0000000000000000 r12 = 0x000000000401ec00
r13 = 0x0000000000000011 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x000000000046aebf
rsp = 0x00007ffff754e370 rbp = 0x00007ffff754ec00
Found by: call frame info
114 phantomjs!JSC::Bindings::QtRuntimeMetaMethod::call [qt_runtime.cpp : 1455 + 0x17]
rbx = 0x00007ffff754e9d0 r12 = 0x00007ffff754ec00
r13 = 0x00007f8ef29b1390 r14 = 0x0000000000000001
r15 = 0x0000000001d5fd40 rip = 0x0000000000552f07
rsp = 0x00007ffff754e500 rbp = 0x0000000000000002
Found by: call frame info
115 phantomjs!WTF::fastMalloc [FastMalloc.cpp : 3063 + 0xa]
rip = 0x00000000004e0a40 rsp = 0x00007ffff754e5f0
Found by: stack scanning
Thread 1
0 libc-2.11.3.so + 0xa0c5d
rbx = 0x00007f8f3cf0cd80 r12 = 0x00000000ffffffff
r13 = 0x00007f8f3b5ec200 r14 = 0x0000000002a7e1a0
r15 = 0x0000000002a7e170 rip = 0x00007f8f3d9e5c5d
rsp = 0x00007f8f3cf0cc50 rbp = 0x00007f8f3cf0cd00
Found by: given as instruction pointer in context
1 libc-2.11.3.so + 0xa0acf
rip = 0x00007f8f3d9e5ad0 rsp = 0x00007f8f3cf0cc60
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
2 phantomjs + 0x18b5c6f
rip = 0x0000000001cb5c70 rsp = 0x00007f8f3cf0cc68
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
3 ld-2.11.3.so + 0x9009
rip = 0x00007f8f3ef4100a rsp = 0x00007f8f3cf0cca0
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
4 ld-2.11.3.so + 0x982b
rip = 0x00007f8f3ef4182c rsp = 0x00007f8f3cf0cce0
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
5 libpthread-2.11.3.so + 0xefef
rip = 0x00007f8f3e461ff0 rsp = 0x00007f8f3cf0ccf8
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
6 ld-2.11.3.so + 0x9af1
rip = 0x00007f8f3ef41af2 rsp = 0x00007f8f3cf0cd00
rbp = 0x00007f8f3cf0cd00
Found by: stack scanning
7 libc-2.11.3.so + 0xe217
rip = 0x00007f8f3d953218 rsp = 0x00007f8f3cf0cd48
Found by: stack scanning
8 phantomjs!WebCore::SerializedScriptValue::create [WTFThreadData.h : 153 + 0x6]
rip = 0x0000000000536632 rsp = 0x00007f8f3cf0ce10
Found by: stack scanning
9 libpthread-2.11.3.so + 0x10fbf
rbx = 0x00007f8f3e463fc0 r12 = 0x00000000000002d9
r13 = 0x00007f8f3cf0d700 r14 = 0x0000000000000000
r15 = 0x0000000000000000 rip = 0x00007f8f3e463fc0
rsp = 0x00007f8f3cf0cea0 rbp = 0x0000000000000000
Found by: call frame info
10 libpthread-2.11.3.so + 0x68c9
rip = 0x00007f8f3e4598ca rsp = 0x00007f8f3cf0ced0
Found by: stack scanning
11 libpthread-2.11.3.so + 0x10fbf
rip = 0x00007f8f3e463fc0 rsp = 0x00007f8f3cf0cf78
Found by: stack scanning
12 libc-2.11.3.so + 0xcfb6c
rip = 0x00007f8f3da14b6d rsp = 0x00007f8f3cf0cfe0
Found by: stack scanning
Thread 2
0 libc-2.11.3.so + 0xc93e3
rbx = 0x0000000000000000 r12 = 0x00007f8f3c5f3da0
r13 = 0x0000000000000008 r14 = 0x0000000003e886c8
r15 = 0x0000000003e88960 rip = 0x00007f8f3da0e3e3
rsp = 0x00007f8f3c5f3b70 rbp = 0x0000000003e88510
Found by: given as instruction pointer in context
1 phantomjs!qt_safe_select [qcore_unix.cpp : 83 + 0x15]
rip = 0x0000000001d06327 rsp = 0x00007f8f3c5f3b80
Found by: stack scanning
2 phantomjs!QEventDispatcherUNIXPrivate::doSelect [qeventdispatcher_unix.cpp : 223 + 0xd]
rbx = 0x0000000003e8e3f0 r12 = 0x00007f8f3c5f3da0
r13 = 0x0000000003e88510 r14 = 0x0000000000000000
r15 = 0x0000000003e88960 rip = 0x0000000001d075e7
rsp = 0x00007f8f3c5f3c10 rbp = 0x0000000003e88510
Found by: call frame info
3 phantomjs!QEventDispatcherUNIX::processEvents [qeventdispatcher_unix.cpp : 937 + 0x4]
rbx = 0x0000000003e8e3f0 r12 = 0x00007f8f3c5f3da0
r13 = 0x0000000003eafc90 r14 = 0x0000000000000001
r15 = 0x0000000004009178 rip = 0x0000000001d08092
rsp = 0x00007f8f3c5f3d50 rbp = 0x0000000003e88510
Found by: call frame info
4 phantomjs!QEventLoop::processEvents [qeventloop.cpp : 149 + 0x1]
rbx = 0x0000000003e8e3f0 r12 = 0x00007f8f3c5f3e30
r13 = 0x00007f8f3c5f3e40 r14 = 0x0000000003e47230
r15 = 0x0000000004009178 rip = 0x0000000001cdd4b5
rsp = 0x00007f8f3c5f3da0 rbp = 0x00007f8f3c5f3de0
Found by: call frame info
5 phantomjs!QEventLoop::exec [qeventloop.cpp : 200 + 0x4]
rbx = 0x0000000003e8e3f0 r12 = 0x00007f8f3c5f3e30
r13 = 0x00007f8f3c5f3e40 r14 = 0x0000000003e47230
r15 = 0x0000000004009178 rip = 0x0000000001cdd918
rsp = 0x00007f8f3c5f3dd0 rbp = 0x00007ffff7550390
Found by: call frame info
6 phantomjs!QThread::exec [qthread.cpp : 542 + 0xc]
rbx = 0x00000000040090f0 r12 = 0x0000000004009178
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001bdfdf6
rsp = 0x00007f8f3c5f3e30 rbp = 0x0000000004009178
Found by: call frame info
7 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x0000000004009178 r12 = 0x0000000003e8d190
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8f3c5f3e80 rbp = 0x0000000003ff0220
Found by: call frame info
8 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007ffff754f870
r13 = 0x00007f8f3c5f4700 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8f3c5f3ed0 rbp = 0x0000000000000000
Found by: call frame info
Thread 3
0 libc-2.11.3.so + 0xc93e3
rbx = 0x00007f8f3ad90d50 r12 = 0x0000000001b389ff
r13 = 0x0000000000000038 r14 = 0x00007f8f3400c6a8
r15 = 0x00007f8f3400c940 rip = 0x00007f8f3da0e3e3
rsp = 0x00007f8f3ad90b70 rbp = 0x0000000000013d14
Found by: given as instruction pointer in context
1 phantomjs!qt_safe_select [qcore_unix.cpp : 93 + 0x16]
rip = 0x0000000001d06228 rsp = 0x00007f8f3ad90b80
Found by: stack scanning
2 phantomjs!QEventDispatcherUNIXPrivate::doSelect [qeventdispatcher_unix.cpp : 223 + 0xd]
rbx = 0x00007f8f3400cec0 r12 = 0x00007f8f3ad90da0
r13 = 0x00007f8f3400c4f0 r14 = 0x00007f8f3ad90d50
r15 = 0x00007f8f3400c940 rip = 0x0000000001d075e7
rsp = 0x00007f8f3ad90c10 rbp = 0x00007f8f3400c4f0
Found by: call frame info
3 phantomjs!QEventDispatcherUNIX::processEvents [qeventdispatcher_unix.cpp : 937 + 0x4]
rbx = 0x00007f8f3400cec0 r12 = 0x00007f8f3ad90da0
r13 = 0x00007f8f3400c4d0 r14 = 0x0000000000000001
r15 = 0x0000000004062c28 rip = 0x0000000001d08092
rsp = 0x00007f8f3ad90d50 rbp = 0x00007f8f3400c4f0
Found by: call frame info
4 phantomjs!QEventLoop::processEvents [qeventloop.cpp : 149 + 0x1]
rbx = 0x00007f8f3400cec0 r12 = 0x00007f8f3ad90e30
r13 = 0x00007f8f3ad90e40 r14 = 0x0000000003e47230
r15 = 0x0000000004062c28 rip = 0x0000000001cdd4b5
rsp = 0x00007f8f3ad90da0 rbp = 0x00007f8f3ad90de0
Found by: call frame info
5 phantomjs!QEventLoop::exec [qeventloop.cpp : 200 + 0x4]
rbx = 0x00007f8f3400cec0 r12 = 0x00007f8f3ad90e30
r13 = 0x00007f8f3ad90e40 r14 = 0x0000000003e47230
r15 = 0x0000000004062c28 rip = 0x0000000001cdd918
rsp = 0x00007f8f3ad90dd0 rbp = 0x00007ffff7550390
Found by: call frame info
6 phantomjs!QThread::exec [qthread.cpp : 542 + 0xc]
rbx = 0x0000000004062ba0 r12 = 0x0000000004062c28
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001bdfdf6
rsp = 0x00007f8f3ad90e30 rbp = 0x0000000004062c28
Found by: call frame info
7 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x0000000004062c28 r12 = 0x0000000004062ce0
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8f3ad90e80 rbp = 0x0000000004062b80
Found by: call frame info
8 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007ffff754c020
r13 = 0x00007f8f3ad91700 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8f3ad90ed0 rbp = 0x0000000000000000
Found by: call frame info
Thread 4
0 libpthread-2.11.3.so + 0xb569
rbx = 0x00007f8f34013640 r12 = 0x0000000000000031
r13 = 0x00007f8f3a58fde0 r14 = 0x00007f8f34013668
r15 = 0x0000000000000000 rip = 0x00007f8f3e45e569
rsp = 0x00007f8f3a58fd68 rbp = 0x00007f8f34013970
Found by: given as instruction pointer in context
1 linux-gate.so + 0x7ac
rip = 0x00007ffff75ff7ad rsp = 0x00007f8f3a58fd90
Found by: stack scanning
2 phantomjs!QWaitCondition::wait [qwaitcondition_unix.cpp : 84 + 0x7]
rip = 0x0000000001be39d7 rsp = 0x00007f8f3a58fdc0
Found by: stack scanning
3 phantomjs!QThreadPoolThread::run [qthreadpool.cpp : 141 + 0x1d]
rbx = 0x00007f8f34013560 r12 = 0x00007f8f340135e9
r13 = 0x0000000000000002 r14 = 0x00007f8f34041000
r15 = 0x0000000000000003 rip = 0x0000000001bd783d
rsp = 0x00007f8f3a58fe40 rbp = 0x00007f8f34013970
Found by: call frame info
4 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x0000000004014c40 r12 = 0x00007f8f34013b10
r13 = 0x0000000000000001 r14 = 0x00007f8f34013cf0
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8f3a58fe80 rbp = 0x00007f8f34013970
Found by: call frame info
5 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007f8f3ad8f630
r13 = 0x00007f8f3a590700 r14 = 0x00007f8f34013cf0
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8f3a58fed0 rbp = 0x0000000000000000
Found by: call frame info
Thread 5
0 libpthread-2.11.3.so + 0xb569
rbx = 0x00007f8f34013640 r12 = 0x0000000000000033
r13 = 0x00007f8f39760de0 r14 = 0x00007f8f34013668
r15 = 0x0000000000000000 rip = 0x00007f8f3e45e569
rsp = 0x00007f8f39760d68 rbp = 0x00007f8eec010e20
Found by: given as instruction pointer in context
1 linux-gate.so + 0x7ac
rip = 0x00007ffff75ff7ad rsp = 0x00007f8f39760d90
Found by: stack scanning
2 phantomjs!QWaitCondition::wait [qwaitcondition_unix.cpp : 84 + 0x7]
rip = 0x0000000001be39d7 rsp = 0x00007f8f39760dc0
Found by: stack scanning
3 phantomjs!QThreadPoolThread::run [qthreadpool.cpp : 141 + 0x1d]
rbx = 0x00007f8f34013560 r12 = 0x00007f8f340135e9
r13 = 0x0000000000000002 r14 = 0x00007f8f34072f00
r15 = 0x0000000000000003 rip = 0x0000000001bd783d
rsp = 0x00007f8f39760e40 rbp = 0x00007f8eec010e20
Found by: call frame info
4 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x00000000040c48f0 r12 = 0x00007f8eec011120
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8f39760e80 rbp = 0x00007f8eec010e20
Found by: call frame info
5 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007f8f3ad8f5b0
r13 = 0x00007f8f39761700 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8f39760ed0 rbp = 0x0000000000000000
Found by: call frame info
Thread 6
0 libpthread-2.11.3.so + 0xb569
rbx = 0x00007f8f34013640 r12 = 0x0000000000000030
r13 = 0x00007f8f38f58de0 r14 = 0x00007f8f34013668
r15 = 0x0000000000000000 rip = 0x00007f8f3e45e569
rsp = 0x00007f8f38f58d68 rbp = 0x00007f8eec015f10
Found by: given as instruction pointer in context
1 linux-gate.so + 0x7ac
rip = 0x00007ffff75ff7ad rsp = 0x00007f8f38f58d90
Found by: stack scanning
2 phantomjs!QWaitCondition::wait [qwaitcondition_unix.cpp : 84 + 0x7]
rip = 0x0000000001be39d7 rsp = 0x00007f8f38f58dc0
Found by: stack scanning
3 phantomjs!QThreadPoolThread::run [qthreadpool.cpp : 141 + 0x1d]
rbx = 0x00007f8f34013560 r12 = 0x00007f8f340135e9
r13 = 0x0000000000000002 r14 = 0x00007f8f3405ea80
r15 = 0x0000000000000003 rip = 0x0000000001bd783d
rsp = 0x00007f8f38f58e40 rbp = 0x00007f8eec015f10
Found by: call frame info
4 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x00000000040c79f0 r12 = 0x00007f8eec016300
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8f38f58e80 rbp = 0x00007f8eec015f10
Found by: call frame info
5 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007f8f3ad8f5b0
r13 = 0x00007f8f38f59700 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8f38f58ed0 rbp = 0x0000000000000000
Found by: call frame info
Thread 7
0 libpthread-2.11.3.so + 0xb1fc
rbx = 0x000000000411a350 r12 = 0x004189374bc6a7ef
r13 = 0xffffffffffffffff r14 = 0x000000000411a378
r15 = 0x000000000411a190 rip = 0x00007f8f3e45e1fc
rsp = 0x00007f8ef3ffed38 rbp = 0x00007f8f3b211190
Found by: given as instruction pointer in context
1 phantomjs!QWaitCondition::wait [qwaitcondition_unix.cpp : 86 + 0xa]
rip = 0x0000000001be39f5 rsp = 0x00007f8ef3ffed60
rbp = 0x00007f8f3b211190
Found by: stack scanning
2 phantomjs!WTF::ThreadCondition::timedWait [ThreadingQt.cpp : 253 + 0x12]
rbx = 0x00007f8f3b211188 r12 = 0x0000000000000003
r13 = 0x00007f8f3b211188 r14 = 0x00007f8f3b211190
r15 = 0x00007f8ef3ffee40 rip = 0x00000000004e70ea
rsp = 0x00007f8ef3ffede0 rbp = 0x00007f8f3b211190
Found by: call frame info
3 phantomjs!WTF::MessageQueue<WebCore::LocalStorageTask>::waitForMessage [MessageQueue.h : 137 + 0x12]
rbx = 0x0000000000000003 r12 = 0x0000000000000003
r13 = 0x00007f8f3b211188 r14 = 0x00007f8f3b211190
r15 = 0x00007f8ef3ffee40 rip = 0x0000000001185269
rsp = 0x00007f8ef3ffee00 rbp = 0x00007f8f3b211198
Found by: call frame info
4 phantomjs!WebCore::LocalStorageThread::threadEntryPoint [LocalStorageThread.cpp : 68 + 0xa]
rbx = 0x00007f8ef2e28c80 r12 = 0x000000000411aeb0
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001185493
rsp = 0x00007f8ef3ffee40 rbp = 0x00007f8f3b211188
Found by: call frame info
5 phantomjs!WTF::ThreadPrivate::run [ThreadingQt.cpp : 66 + 0x6]
rbx = 0x000000000411a630 r12 = 0x000000000411aeb0
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00000000004e68fb
rsp = 0x00007f8ef3ffee70 rbp = 0x000000000411a630
Found by: call frame info
6 phantomjs!QThreadPrivate::start [qthread_unix.cpp : 338 + 0x9]
rbx = 0x000000000411adf8 r12 = 0x000000000411aeb0
r13 = 0x0000000000000001 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x0000000001be2cc2
rsp = 0x00007f8ef3ffee80 rbp = 0x000000000411a630
Found by: call frame info
7 libpthread-2.11.3.so + 0x68c9
rbx = 0x0000000000000000 r12 = 0x00007ffff754eb50
r13 = 0x00007f8ef3fff700 r14 = 0x00007f8f3f156040
r15 = 0x0000000000000003 rip = 0x00007f8f3e4598ca
rsp = 0x00007f8ef3ffeed0 rbp = 0x0000000000000000
Found by: call frame info
Loaded modules:
0x00400000 - 0x0268dfff phantomjs ??? (main)
0x7f8f380bf000 - 0x7f8f380cdfff VeraSe.ttf ???
0x7f8f381ea000 - 0x7f8f381f5fff VeraMoBd.ttf ???
0x7f8f3868f000 - 0x7f8f3869ffff Vera.ttf ???
0x7f8f386a0000 - 0x7f8f386aefff VeraBd.ttf ???
0x7f8f39762000 - 0x7f8f39967fff libnss_dns-2.11.3.so ???
0x7f8f39968000 - 0x7f8f39b74fff libnss_files-2.11.3.so ???
0x7f8f39b75000 - 0x7f8f39d88fff libresolv-2.11.3.so ???
0x7f8f3b5cf000 - 0x7f8f3b5dbfff VeraMono.ttf ???
0x7f8f3cf0e000 - 0x7f8f3d164fff libssl.so.0.9.8 ???
0x7f8f3d165000 - 0x7f8f3d501fff libcrypto.so.0.9.8 ???
0x7f8f3d506000 - 0x7f8f3d72dfff libexpat.so.1.5.2 ???
0x7f8f3d72e000 - 0x7f8f3d944fff libz.so.1.2.3.4 ???
0x7f8f3d945000 - 0x7f8f3dca1fff libc-2.11.3.so ???
0x7f8f3dca7000 - 0x7f8f3debcfff libgcc_s.so.1 ???
0x7f8f3debd000 - 0x7f8f3e13efff libm-2.11.3.so ???
0x7f8f3e13f000 - 0x7f8f3e43dfff libstdc++.so.6.0.13 ???
0x7f8f3e453000 - 0x7f8f3e66afff libpthread-2.11.3.so ???
0x7f8f3e66f000 - 0x7f8f3e876fff librt-2.11.3.so ???
0x7f8f3e877000 - 0x7f8f3ea7afff libdl-2.11.3.so ???
0x7f8f3ea7b000 - 0x7f8f3ecaffff libfontconfig.so.1.4.4 ???
0x7f8f3ecb0000 - 0x7f8f3ef37fff libfreetype.so.6.6.0 ???
0x7f8f3ef38000 - 0x7f8f3ef55fff ld-2.11.3.so ???
0x7f8f3efd2000 - 0x7f8f3f146fff locale-archive ???
0x7f8f3f150000 - 0x7f8f3f152fff de156ccd2eddbdc19d37a45b8b2aac9c-le64.cache-3 ???
0x7ffff75ff000 - 0x7ffff75fffff linux-gate.so ???
I'm building from source and will see if the patch applies and resolves the situation.
I expect that the patch did not resolve the situation. Am I right?
Fixed in 2.1.1
| gharchive/issue | 2014-04-22T05:30:14 | 2025-04-01T06:37:57.278533 | {
"authors": [
"Vitallium",
"elboletaire",
"phantomhappy101"
],
"repo": "ariya/phantomjs",
"url": "https://github.com/ariya/phantomjs/issues/12168",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.