idproject
int64 7.76k
28.8M
| issuekey
int64 675k
128M
| created
stringlengths 19
32
| title
stringlengths 4
226
| description
stringlengths 2
154k
⌀ | storypoints
float64 0
300
⌀ |
|---|---|---|---|---|---|
7,603,319 | 81,592,478 |
2021-03-24 20:50:58.624
|
Add Roadmap to handbook
|
https://gitlab.com/meltano/meta/-/issues/20
| 1 |
7,603,319 | 81,299,486 |
2021-03-19 16:25:28.270
|
Fix Zoom Recommendation
| null | 1 |
7,603,319 | 81,134,488 |
2021-03-17 20:48:24.306
|
Add Meltano Backgrounds
| null | 1 |
7,603,319 | 81,130,015 |
2021-03-17 19:22:48.882
|
Add Community Page
| null | 1 |
7,603,319 | 80,943,029 |
2021-03-15 15:13:01.061
|
Add documentation update to cross-link info between Getting Started and CLI reference
|
Cross link info on the excludes selection and how to remove. https://gitlab.com/meltano/meltano/-/issues/2638#note_528335663
| 1 |
7,603,319 | 80,941,096 |
2021-03-15 14:51:00.488
|
Write Vision Summary blog post
|
Follow-up from #2633
| 2 |
7,603,319 | 80,938,996 |
2021-03-15 14:28:38.719
|
Add CODEOWNERS
|
We should add a codeowners file so that @meltano/core-team can merge into the handbook but still require approval for the main app
| 1 |
7,603,319 | 80,515,191 |
2021-03-08 22:45:18.545
|
Meltano Vision Work
|
By Thursday:
* What could Meltano be in 5 years?
* What do we want it to be within the year?
* What's not part of the vision?
* What excites you about this space and your vision?
| 1 |
7,603,319 | 108,841,987 |
2022-05-20 01:37:56.829
|
Use latest Python 3.9 in CI
|
[We had to pin Python 3.9 to `3.9.6`](https://gitlab.com/meltano/meltano/-/issues/2913) in our test matrix due to problems with dbt in that version. That makes our `3.9` docker images come with Python `3.9.6`.
This was later fixed upstream in [dbt's `0.20.2` release](https://github.com/dbt-labs/dbt-core/releases/tag/v0.20.2). That means we can go back to using the latest, `3.9.13` at the time of writing.
| 2 |
7,603,319 | 108,836,039 |
2022-05-19 20:50:01.939
|
`tap-quickbooks` should have `properties` capability instead of `catalog`
|
- Came up recently in Slack: https://meltano.slack.com/archives/CMN8HELB0/p1652851641112949
- The tap uses `--properties`: https://github.com/hotgluexyz/tap-quickbooks/blob/9a9990601f02e91d9ef1357b91b69624eb9dab2b/tap_quickbooks/__init__.py#L272
- `discovery.yml` says it uses `--catalog`: https://gitlab.com/meltano/meltano/-/blob/6d96c9bc9ec5610d87dc01d568bbdb3b162210a4/src/meltano/core/bundle/discovery.yml#L1724
| 1 |
7,603,319 | 108,699,520 |
2022-05-17 18:33:12.801
|
Telemetry project counts inflated if using a custom project_id
|
@edgarrmondragon helpfully pointed me to this block in our [tap-gitlab conversation](https://github.com/MeltanoLabs/tap-gitlab/pull/77#discussion_r875020636):
https://gitlab.com/meltano/meltano/-/blob/4c8cbc0bdb4db0248a378017c3615d88e8cf1878/src/meltano/core/tracking/ga_tracker.py#L84-95
That block apparently fails initialization of project ID _and creates a new one_ if the project ID is not a valid UUID. In my experience, this was getting written back to my project file and then I would continually revert it and it would reset again, etc. In CI, this probably gets a distinct project ID on each run - meaning each run through CI (and each job) looks like a distinct project.
This is very likely creating a significant inflation of our total domain project IDs and I think we should address as ~"urgency::high". (The code was last touched 12+ months ago, or so, so I imaging this has been an issue for quite a while.)
cc @tayloramurphy, @pnadolny13, @edgarrmondragon, @DouweM
| 2 |
7,603,319 | 108,687,290 |
2022-05-17 14:16:41.037
|
Support a set operation on meltano job for updating tasks
|
It was determined to be out of scope to add a `set` operation in https://gitlab.com/meltano/meltano/-/issues/2924
We should review the UX and the data we get on this new command to see the utility of adding an update type command for `meltano job`.
| 2 |
7,603,319 | 108,479,541 |
2022-05-12 23:14:17.860
|
Use `settings_service.feature_flag` convention for lockfiles
|
The following discussion from !2596 should be addressed:
- [ ] @cjohnhanson started a [discussion](https://gitlab.com/meltano/meltano/-/merge_requests/2596#note_945226196):
> Optional follow-up: once !2643 is merged, update this to follow the new `settings_service.feature_flag` convention OR remove this flag parameter and use the feature flag within `ProjectAddService` instead.
| 4 |
7,603,319 | 108,398,946 |
2022-05-11 20:28:10.684
|
Add job support to schedules and to airflow
|
In https://gitlab.com/meltano/meltano/-/issues/2924 we're adding support for top level jobs concept in meltano.yaml along with adding support for jobs expansion to `meltano run`. We also want to add job support to the `meltano schedule` command, and likely also alter how airflow interacts with schedules ala https://gitlab.com/meltano/files-airflow/-/blob/master/bundle/orchestrate/dags/meltano.py.
## Some clarification on things that caused confusion in #2924.
1. We are NOT deprecating support `elt` schedules in favor of `run`, and `meltano schedule` including `meltano schedule run` will support both.
2. Airflow calls `meltano schedule run` [per schedule](https://gitlab.com/meltano/files-airflow/-/blob/master/bundle/orchestrate/dags/meltano.py#L99), it does NOT use `meltano elt` directly, `meltano schedule run` uses MeltanoInvoker to spawn a `meltano elt` subprocess.
- at a minimum `meltano schedule run` will need to support calling both `meltano elt` and `meltano run` based on the scheduled its being asked to run.
## Latest `meltano schedule` UX spec
(ala @tayloramurphy in https://gitlab.com/meltano/meltano/-/issues/2924#note_937990262)
```
meltano schedule <schedule_name> <job_name> <interval> # This is the default
meltano schedule job add <schedule_name> <job_name> <interval> # This is the same behavior as the above but [job] and [add] are default
meltano schedule elt <schedule_name> <extractor> <loader> <interval> [--transform={run,skip,only}] # new syntax for elt workflows Q: Does this break anything in the UI?
meltano schedule elt add <schedule_name> <extractor> <loader> <interval> [--transform={run,skip,only}] # same as above with the default add
meltano schedule <schedule_name> set <job_name> <interval> <environment>
meltano schedule <schedule_name> set name=<job_name> # this is different from the description b/c of the key (same for the next 2) - Q: Is the key required?
meltano schedule <schedule_name> set interval=<interval>
meltano schedule <schedule_name> set environment=<environment>
meltano schedule list [--format=json] Does this work with jobs that are scheduled via the job definition?
meltano schedule run <schedule_name>
```
| 8 |
7,603,319 | 108,025,823 |
2022-05-04 17:04:08.967
|
`meltano config airflow` fails for newly install Airflow plugin
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
When running `meltano config airflow` to print the current Airflow configuration, the command fails with the following error:
```bash
[Errno 2] No such file or directory: '/Users/kp/Projects/squared/data/.meltano/run/airflow/airflow.cfg'
```
Once `meltano invoke airflow webserver` has been run once, the missing file is created and the command succeeds in printing the current config.
### What is the expected *correct* behavior?
_What should be happening?_
`meltano config airflow` should be able to print the current Airflow configuration regardless of the existence of Meltano-managed files.
### Steps to reproduce
_How one can reproduce the issue?_
```bash
meltano init airflow_bug
meltano add orchestrator airflow
meltano install
meltano config airflow
```
I am somewhat surprised that `meltano install` is necessary as `meltano config airflow` is just supposed to print the current config 🤔
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
### Workaround
As a workaround, a user can run `meltano invoke airflow webserver`, which should fully initialize the airflow resources and prevent the error from triggering.
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 107,880,640 |
2022-05-02 15:47:40.563
|
Document and lint against type annotation standards
|
As we progressively type-annotate our codebase, we should document our type-related standards and expectations in our [Dev Standards](https://handbook.meltano.com/engineering/dev-standards).
If possible, we should also add a flake8 plugin to lint against these standards as part of pre-commit and CI.
This will help new engineers onboard faster and accelerate our progress towards being able to do static type checking as part of our dev and CI workflow.
Related to [this discussion on a recent MR](https://gitlab.com/meltano/meltano/-/merge_requests/2596#note_932443415).
CC @pandemicsyn @edgarrmondragon
| 8 |
7,603,319 | 107,430,881 |
2022-04-28 20:59:58.768
|
"move" and "copy" subcommands for "meltano state"
|
This is a follow-up from: https://gitlab.com/meltano/meltano/-/issues/2754
We need to add the following subcommands to `meltano state`:
1. `copy`
* `meltano state copy <JOB-ID-1> <JOB-ID-2>`
1. `move`
* `meltano state move <JOB-ID-1> <JOB-ID-2>` (or `meltano state rename`)
| 4 |
7,603,319 | 107,247,045 |
2022-04-26 22:10:26.516
|
Make setting-level `env:` declaration a one-way injection into the plugin execution context
|
Follows from #3431: We want the `env:` usage pattern to be fully unambiguous. The use case this exists for is so that plugins can receive injected environment variable values from Meltano.
1. The user sets the setting value in any supported way.
2. The plugin gets that setting value from the `env:`.
3. If an env var is already set by that name, its value will be replaced by the setting value.
For example: if the OS context has an env var set as `DEBUG_MODE=1` but my plugin has a setting with `env: DEBUG_MODE` and setting value of `0`, then the plugin when invoked will have `DEBUG_MODE=0`, which is the value that the plugin is intended to receive by the Meltano user. ~~Any other env vars from context will be ignored _unless_ they are referenced under `value:`, `env_aliases:`, or the `config:` entry.~~ Any other env vars from context will be ignored _**when initializing the plugins settings**_ _unless_ they are referenced under `value:`, `env_aliases:`, or the `config:` entry.
| 4 |
7,603,319 | 107,246,486 |
2022-04-26 21:47:20.962
|
dbt-snowflake fails with meltano run
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
dbt-snowflake fails to run commands defined in discovery.yml when using `meltano run`
### What is the expected *correct* behavior?
_What should be happening?_
`meltano run` should be able to execute dbt-snowflake commands as defined in discovery.yml.
### Steps to reproduce
_How one can reproduce the issue?_
```bash
meltano init test
cd test
meltano add transformer dbt-snowflake
meltano invoke dbt-snowflake:deps
# 21:39:53 Running with dbt=1.0.5
# 21:39:53 Warning: No packages were found in packages.yml
meltano run dbt-snowflake:deps
# error
```
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
```
2022-04-26T21:40:31.292906Z [info ] Environment 'dev' is active
2022-04-26T21:40:32.305402Z [info ] commands commands={0: 'deps'}
2022-04-26T21:40:34.292208Z [info ] usage: dbt [-h] [--version] [-r RECORD_TIMING_INFO] [-d] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.292637Z [info ] [--log-format {text,json,default}] [--no-write-json] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.292745Z [info ] [--use-colors | --no-use-colors] [--printer-width PRINTER_WIDTH] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.292895Z [info ] [--warn-error] [--no-version-check] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.293012Z [info ] [--partial-parse | --no-partial-parse] [--use-experimental-parser] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.293159Z [info ] [--no-static-parser] [--profiles-dir PROFILES_DIR] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.293346Z [info ] [--no-anonymous-usage-stats] [-x] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.293586Z [info ] [--event-buffer-size EVENT_BUFFER_SIZE] cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.293738Z [info ] {docs,source,init,clean,debug,deps,list,ls,build,snapshot,run,compile,parse,test,seed,run-operation} cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.294010Z [info ] ... cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.294178Z [info ] dbt: error: unrecognized arguments: None cmd_type=command name=dbt-snowflake stdio=stderr
2022-04-26T21:40:34.407488Z [error ] Block run completed. block_type=InvokerCommand err=RunnerError('`dbt-snowflake deps` failed with exit code: 2') exit_codes={} set_number=0 success=False
Run invocation could not be completed as block failed: `dbt-snowflake deps` failed with exit code: 2
```
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 2 |
7,603,319 | 107,234,777 |
2022-04-26 16:18:33.336
|
Clean up docs.meltano.com UI pages
|
- Take new screenshots of UI to replace outdated ones
- Check language to make sure it actually works still
- Streamline if possible
- Add explainers akin to the method definitions on the CLI page that tell users how to use the UI
| 4 |
7,603,319 | 107,078,338 |
2022-04-23 23:11:08.151
|
New paradigm for bundling plugin dependencies and `files` bundles
|
Today:
```yml
transformers:
- name: dbt
namespace: dbt
docs: https://docs.meltano.com/guide/transformation
repo: https://github.com/dbt-labs/dbt-core
pip_url: dbt-core~=1.0.0 dbt-postgres~=1.0.0 dbt-redshift~=1.0.0 dbt-snowflake~=1.0.0 dbt-bigquery~=1.0.0
settings:
# ...
orchestrators:
- name: airflow
namespace: airflow
docs: https://docs.meltano.com/guide/orchestration
repo: https://github.com/apache/airflow
pip_url: 'apache-airflow==2.1.2 --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.1.2/constraints-${MELTANO__PYTHON_VERSION}.txt'
settings:
# ...
# ...
files:
- name: airflow
namespace: airflow # << auto-installed with `dbt` due to matching `namespace`
repo: https://gitlab.com/meltano/files-airflow
pip_url: git+https://gitlab.com/meltano/files-airflow.git
update:
orchestrate/dags/meltano.py: true
- name: dbt
namespace: dbt # << auto-installed with `dbt` due to matching `namespace`
repo: https://gitlab.com/meltano/files-dbt
pip_url: git+https://gitlab.com/meltano/files-dbt.git@config-version-2
```
## The challenge
The number of collisions on namespace will potentially skyrocket one we complete #3283+. We can no longer reasonably scan all the plugins in the hub or in discovery.yml to identify matching namespaces and then have confidence that the matching plugins should be installed together. Instead, we need a more explicit mapping of files resources to the plugins that need those resources.
## Proposed refactor:
- The `namespace` field can be removed (optionally auto-calculated internally per #3374+).
- Files resources are now defined inline with the plugins themselves.
```yml
transformers:
- name: dbt
docs: https://docs.meltano.com/guide/transformation
repo: https://github.com/dbt-labs/dbt-core
pip_url: dbt-core~=1.0.0 dbt-postgres~=1.0.0 dbt-redshift~=1.0.0 dbt-snowflake~=1.0.0 dbt-bigquery~=1.0.0
bundle: # or `depends_on:`
files:
- name: files-dbt # Name might be optional, since the plugin has a name in its API definition.
# This is the API endpoint
ref: https://hub.meltano.com/meltano/api/v1/plugins/extractors/tap-zendesk--twilio-labs
orchestrators:
- name: airflow
docs: https://docs.meltano.com/guide/orchestration
repo: https://github.com/apache/airflow
pip_url: 'apache-airflow==2.1.2 --constraint https://raw.githubusercontent.com/apache/airflow/constraints-2.1.2/constraints-${MELTANO__PYTHON_VERSION}.txt'
bundle:
files:
- name: airflow-files
variant: meltanolabs
settings:
# ...
```
The files needed for the repo would then be self-contained within the plugin definition and are self-sufficient for installing the plugin, without needing external plugin to be installed.
## Moving to `copier`
Our current paradigm does not facilitate supporting changes over time to the files (the "day 2" problem). A related proposal would be to #3432+, but that can be delivered separately from this change.
## Standalone `files` plugins
We can still support standalone `files` plugins for use cases where it still makes sense to do so apart from auto-installed resources for a `utility`, `transformer`, or `orchestrator` plugin.
However, we would not post separate definitions to the hub for those `files` plugins which are best combined with their particular plugin.
| 8 |
7,603,319 | 106,754,807 |
2022-04-18 04:50:25.892
|
Fail adding `transform` plugin if no `transformer` is added
|
Discovered from my dogfooding project (https://gitlab.com/meltano/meta/-/issues/234+), we currently auto-add the `model`, `transform`, and `transformer` plugins when adding extractors.
When adding extractors, we should not auto-add any other plugins:
- `model` plugins are being deprecated.
- `transform` plugins are being deprecated.
- `transformer` plugin can not be inferred to be `dbt`, since we are opting for adapter-specific transformer plugins now.
| 4 |
7,603,319 | 106,752,184 |
2022-04-18 02:38:42.052
|
Allow `--custom` when adding transformers
|
I discovered in my dogfooding project (https://gitlab.com/meltano/meta/-/issues/234), that adding `--custom` transformers is explicitly disallowed as of now and this is problematic for the path we are going with #3298.
We should allow `transformer` plugins to be defined via `--custom` as we do today for `extractor` plugins and other types.
| 4 |
7,603,319 | 106,667,311 |
2022-04-14 20:18:50.938
|
metadata extra not honored by inherited plugin
|
### What is the current *bug* behavior?
If the metadata extra is defined in the base configuration of an inherited plugin it is not respected - the metadata from the base configuration of the parent plugin is used instead.
### What is the expected *correct* behavior?
The metadata extra from the inherited plugin definition should be used.
### Steps to reproduce
Using the attached [meltano.yml](/uploads/3ddeb9658b37693e2edfe65519e970c2/meltano.yml) run
`meltano --environment=prod run tap-mysql2 target-jsonl`
SomeTable2 will get replicated but with replication-method=LOG_BASED. If instead you run
`meltano --environment=dev run tap-mysql2 target-jsonl`
SomeTable2 will be replicated using replication-method=FULL_TABLE as expected. The point being that this appears to be a problem specifically with metadata defined on the base inherited plugin only.
Note also that if you change the metadata in the base parent plugin to not use a wildcard, i.e.
```
metadata:
SchemaName-SomeTable:
replication-method: LOG_BASED
```
The pipeline will fail with an error about the replication method not being defined for SomeTable2. I think that's relevant because it shows that the wildcard isn't overriding the inherited plugin configuration.
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 106,549,559 |
2022-04-12 21:13:27.595
|
meltano add transformer dbt - extra lines in meltano.yml
|
After running `meltano add transformer dbt` the `meltano.yml` related config looks like this
```yml
transformers:
- name: dbt
pip_url: 'dbt-core~=1.0.0 dbt-postgres~=1.0.0 dbt-redshift~=1.0.0 dbt-snowflake~=1.0.0
dbt-bigquery~=1.0.0
'
files:
- name: dbt
pip_url: git+https://gitlab.com/meltano/files-dbt.git@config-version-2
```
Note the 2/3 extra new lines
| 1 |
7,603,319 | 106,532,103 |
2022-04-12 14:24:44.233
|
Meltano UI pipelines tab broken since 1.99
|
Pipelines tab gets stuck in a loading loop erroring out with:
```
TypeError: Cannot read properties of undefined (reading 'includes')
at app.4c6077ae.js:1:181845
at Array.map (<anonymous>)
at i.cloneDeepPipelines (app.4c6077ae.js:1:181810)
at nr.get (chunk-vendors.43453e12.js:7:30685)
at nr.evaluate (chunk-vendors.43453e12.js:7:31686)
at i.cloneDeepPipelines (chunk-vendors.43453e12.js:7:33379)
at i.ys (app.4c6077ae.js:1:170909)
at i.e._render (chunk-vendors.43453e12.js:7:23734)
at i.r (chunk-vendors.43453e12.js:7:27825)
at nr.get (chunk-vendors.43453e12.js:7:30685)
at @ chunk-vendors.43453e12.js:7
3app.4c6077ae.js:1
```
Reason is this line here: https://gitlab.com/meltano/meltano/-/blob/master/src/webapp/src/views/Pipelines.vue#L44
We have schedules with unset `interval` keys, as we don't use Meltano as an orchestrator. Because that line tries to perform an `includes` check on an unset key, it causes a TypeError.
| 2 |
7,603,319 | 106,361,491 |
2022-04-08 20:23:21.434
|
meltano run , multiple dbt commands leads to wrong dbt commands running
|
To reproduce run this
1. `meltano run dbt:compile dbt:run`
Meltano will run `dbt:run` twice
My actual use case is
1. `meltano run dbt:drop_source_table tap-abc target-postgres dbt:run`
Noticed run was happening twice, was pretty hard to notice this was happening.
| 2 |
7,603,319 | 106,360,778 |
2022-04-08 19:56:50.795
|
meltano init not creating DB
|
This happens on windows, I'd assume not other OS's, the DB is not initting. `meltano, version 1.99.0` I'm not certain this is new behavior it could have been around all this time and I just missed putting an issue in (seems unlikely but it's possible)
1. Run `meltano init test`
1. See output below
```
PS C:\code> meltano --log-level=debug init test-issue
Created test
Creating project files...
test/
|-- meltano.yml
|-- README.md
|-- requirements.txt
|-- output\.gitignore
|-- .gitignore
|-- model\.gitkeep
|-- extract\.gitkeep
|-- load\.gitkeep
|-- transform\.gitkeep
|-- analyze\.gitkeep
|-- notebook\.gitkeep
|-- orchestrate\.gitkeep
Creating system database...2022-04-08T19:54:04.823778Z [info ] DB connection failed. Will retry after 5s. Attempt 1/3
2022-04-08T19:54:09.841274Z [info ] DB connection failed. Will retry after 5s. Attempt 2/3
2022-04-08T19:54:14.857067Z [info ] DB connection failed. Will retry after 5s. Attempt 3/3
2022-04-08T19:54:19.872743Z [error ] Could not connect to the Database. Max retries exceeded.
(sqlite3.OperationalError) unable to open database file
(Background on this error at: https://sqlalche.me/e/14/e3q8)
PS C:\code> meltano --version
meltano, version 1.99.0
```
| 2 |
7,603,319 | 106,291,221 |
2022-04-07 23:55:09.344
|
Docs: Document `env` usage in Environments
|
The [Environment page in the docs](https://docs.meltano.com/concepts/environments) is not currently doing a great work at explaining the effects of using the `env` mapping in an Environment.
| 1 |
7,603,319 | 106,264,545 |
2022-04-07 15:45:24.392
|
Incorrect `get` behaviour with default settings overriding environment-specific plugin settings
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
We have incorrect resolution order between default values at the plugin setting level (such as from `discovery.yml`) versus the settings specified in an environment.
If an environment setting is provided, that should take precedent over default values, which is not the case as of now.
This does affect plugin settings at the top-level `plugins` definitions (perhaps only in certain situations though?).
Using `set` to set the value of a plugin extra to a non-default value uses the `default_environment`, however using `set` to set the value _back_ to a default value (explicitly) does not remove the setting override from the default environment.
### What is the expected *correct* behavior?
_What should be happening?_
`set` should work exactly the same for default and non-default values.
### Steps to reproduce
_How one can reproduce the issue?_
As per the screenshot below:
```bash
# add file bundle
meltano add files airflow
# configure file bundle to disable updates
meltano config --plugin-type files airflow set _update "orchestrate/dags/meltano.py" false
# "Current value is still: True (from the default)
# This is the incorrect behavior - env-level plugin settings should take precedence over setting defaults.
# check meltano.yml
cat meltano.yml
# configure file bundle to re-enable updates (using `set`)
meltano config --plugin-type files airflow set _update "orchestrate/dags/meltano.py" true
# check meltano.yml again
cat meltano.yml
# key `orchestrate/dags/meltano.py` remains set to `false` in default environment.
```
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 106,200,554 |
2022-04-06 19:07:00.391
|
Add guard statements and feature flags for 2.0 release
|
In planning for #3292+, the total amount of work for deprecations will be significant and will touch many files. To minimize merge conflicts, we can first create guard statements to raise exceptions if any deprecated code paths are touched. Combined with feature flags and/or a version check statement, we can smartly turn off _and_ turn on features in 2.0 as appropriate.
We can optionally have a `MELTANO_EXPERIMENTAL` environment variable that selectively allows new 2.0 features to be tested from pre-2.0 releases.
A large benefit of this approach is that we'd have reduced git branching, and reduced cost of resolving/managing merge conflicts.
| 4 |
7,603,319 | 106,120,813 |
2022-04-05 16:48:58.970
|
Active Environment Name As Env Variable
|
## Proposal
Would expose `MELTANO_ENVIRONMENT` to child processes, even if environment is set via another method (`--environment` at the CLI or `default_environment` in `meltano.yml`.)
## Background
Based on this thread in slack https://meltano.slack.com/archives/C01TCRBBJD7/p1643919224929049
My original comment was:
> I'm looking for a way to detect the active environment using environment variables and I know you can set a meltano environment using --environment=prod or through a MELTANO_ENVIRONMENT. Its easy to solve if I use the second method but if I define it using the --environment argument there doesnt seem to be any environment variable set. Is there a way to consistently do this?
We also now have default environments so the environment can be set in the meltano.yml too.
For any down stream process that wants to call meltano commands like I do in the dbt airflow dag generator https://gitlab.com/pnadolny13/files-airflow-dbt/-/blob/master/bundle/orchestrate/dags/generator_cache_builder.py#L36 it would be helpful to have the meltano environment exposed in the environment variables context. If I call `meltano --environment=prod invoke airflow webserver` then the dag generator should be able to access `MELTANO_ENVIRONMENT`.
It might be an anti pattern but it gives more flexibility to users so we can customize more.
| 4 |
7,603,319 | 106,039,681 |
2022-04-04 14:33:52.931
|
Update dbt commands to use `--select` instead of `--models`
|
Since dbt v0.21 it's recommended to use the `--select` flag instead of `--models`. https://docs.getdbt.com/reference/node-selection/syntax
| 2 |
7,603,319 | 105,841,050 |
2022-03-31 19:33:54.773
|
Helpful --debug tips not listed
|
```
visch@visch-ubuntu:~/git/tap-googleads$ pipx upgrade meltano
meltano is already at latest version 1.98.1 (location: /home/visch/.local/pipx/venvs/meltano)
```
```visch@visch-ubuntu:~/git/tap-googleads$ meltano invoke tap-googleads
Catalog discovery failed: command ['/home/visch/git/tap-googleads/tap-googleads.sh', '--config', '/home/visch/git/tap-googleads/.meltano/run/tap-googleads/tap.c180fcd0-2467-4c37-bbfb-eb5e3a8b0ef7.config.json', '--discover'] returned 1
```
The cmd line response here should have the helpful `log-level=debug` tip, not sure why it doesn't for this case.
| 1 |
7,603,319 | 105,786,732 |
2022-03-30 22:39:52.896
|
Allow all plugins (utilities, custom plugins, etc.) to be configured in Meltano UI
|
The proposal here would be to expand the Meltano UI config experience to support interactive configuration of all plugin types.
Essentially the UI would operate the same way as today, except that _any_ plugin could be configured using the same interface.
| 8 |
7,603,319 | 105,710,071 |
2022-03-29 20:37:38.107
|
Mappers with custom names
|
I know this usage isn't documented here https://docs.meltano.com/concepts/plugins#mappers , but based on my use of Meltano thus far having different names for Extractors and Loaders hasn't been any consequence in the past. `transform-activedirectory` is a fork of https://github.com/MeltanoLabs/meltano-map-transform , with the only difference being that I am pointing to a custom SDK implementation due to https://gitlab.com/meltano/sdk/-/issues/355.
meltano.yml
```yaml
mappers:
- name: activedirectory-transformer
pip_url: git+ssh://git@gitlab.com/autoidm/transform-activedirectory.git
executable: meltano-map-transform
mappings:
- name: adhex-2-uuid
config:
stream_maps:
"space": {
"guid": "uuid(objectguid)"
}
```
Mapper 'mapper-activedirectory' is not known to Meltano
Custom mapper doesn't work
Logs
```
PS C:\code\bamboohr2ad> meltano --log-level=debug install
2022-03-29T19:18:14.047257Z [debug ] Creating engine <meltano.core.project.Project object at 0x000000B6955FABB0>@sqlite:///C:\code\bamboohr2ad/.meltano/meltano.db
2022-03-29T19:18:14.328268Z [debug ] Starting new HTTPS connection (1): discovery.meltano.com:443
2022-03-29T19:18:14.429270Z [debug ] https://discovery.meltano.com:443 "GET /discovery.yml?project_id=b48f8a89-62e6-44b3-aaf5-5aafc1a0f0be HTTP/1.1" 200 22844
2022-03-29T19:18:14.500270Z [debug ] Encoding detection: ascii is most likely the one.
2022-03-29T19:18:15.927249Z [debug ] Mapper 'mapper-activedirectory' is not known to Meltano
Traceback (most recent call last):
File "C:\Python39\lib\site-packages\meltano\core\utils\__init__.py", line 300, in find_named
return next(x for x in xs if x["name"] == name)
StopIteration
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Python39\lib\site-packages\meltano\core\plugin_discovery_service.py", line 247, in find_definition
return find_named(self.get_plugins_of_type(plugin_type), plugin_name)
File "C:\Python39\lib\site-packages\meltano\core\utils\__init__.py", line 302, in find_named
raise NotFound(name, obj_type) from stop
meltano.core.utils.NotFound: mapper-activedirectory was not found.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Python39\lib\site-packages\meltano\cli\__init__.py", line 47, in main
cli(obj={"project": None})
File "C:\Python39\lib\site-packages\click\core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "C:\Python39\lib\site-packages\click\core.py", line 782, in main
rv = self.invoke(ctx)
File "C:\Python39\lib\site-packages\click\core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "C:\Python39\lib\site-packages\click\core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "C:\Python39\lib\site-packages\click\core.py", line 610, in invoke
return callback(*args, **kwargs)
File "C:\Python39\lib\site-packages\meltano\cli\params.py", line 23, in decorate
return func(*args, **kwargs)
File "C:\Python39\lib\site-packages\meltano\cli\params.py", line 56, in decorate
func(project, *args, **kwargs)
File "C:\Python39\lib\site-packages\meltano\cli\install.py", line 45, in install
plugins = list(plugins_service.plugins())
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 285, in plugins
for _, plugins in self.plugins_by_type(ensure_parent=ensure_parent).items()
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 267, in plugins_by_type
return {
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 268, in <dictcomp>
plugin_type: self.get_plugins_of_type(
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 254, in get_plugins_of_type
self.ensure_parent(plugin)
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 377, in ensure_parent
plugin.parent = self.get_parent(plugin)
File "C:\Python39\lib\site-packages\meltano\core\project_plugins_service.py", line 360, in get_parent
return self.discovery_service.get_base_plugin(plugin)
File "C:\Python39\lib\site-packages\meltano\core\plugin_discovery_service.py", line 270, in get_base_plugin
plugin = project_plugin.custom_definition or self.find_definition(
File "C:\Python39\lib\site-packages\meltano\core\plugin_discovery_service.py", line 249, in find_definition
raise PluginNotFoundError(PluginRef(plugin_type, plugin_name)) from err
meltano.core.plugin.error.PluginNotFoundError: Mapper 'mapper-activedirectory' is not known to Meltano
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Python39\lib\site-packages\meltano\cli\__init__.py", line 55, in main
raise CliError(str(err)) from err
meltano.cli.utils.CliError: Mapper 'mapper-activedirectory' is not known to Meltano
Mapper 'mapper-activedirectory' is not known to Meltano
The above exception was the direct cause of the following exception:
```
To make this work I had to do this
```yaml
mappers:
- name: meltano-map-transformer
variant: meltano
pip_url: git+ssh://git@gitlab.com/autoidm/transform-activedirectory.git
executable: meltano-map-transform
mappings:
- name: adhex-2-uuid
config:
stream_maps:
"space": {
"guid": "uuid(objectguid)"
}
```
Which is fairly hacky :shrug:
| 2 |
7,603,319 | 105,652,933 |
2022-03-29 03:16:59.839
|
Improve Makefile behavior
|
Our Makefile doesn't have a help option AND defaults to executing a build if invoked without arguments. Makefile help/docs can be generated if you run `make explain_makefile` but you have to know that exists (or read the Makefile, in which case you no longer need the explainer).
With some very minor changes (essentially this bit from https://gitlab.com/pandemicsyn/llamalake/-/blob/main/Makefile#L7 + a few inline comments), we could provide a help option, and use that as the default target:
```
(melty-3.8) ➜ make
api build api
base_image builds meltano/base
build build the ui and api
bundle clean up static assets and rerun UI build
clean clean statically generated assets
docker_images build docker base_image and prod_image
docker_sdist
docs_image
explain_makefile launch a web server further explaining this makefile.
freeze_db
lint run python and eslint tasks
lint_eslint run eslint
lint_python run json/yaml validation and execute tox to perform python lint tasks
lock run poetry lock
prod_image builds meltano/meltano the AIO production image that includes static UI artifacts
release perform a release, should only be performed as part of the CI pipeline
show_lint show python and eslint ralated commands
test run tests
ui build the UI
```
And explicitly support `help` arg via
```
(melty-3.8) ➜ make help
api build api
base_image builds meltano/base
build build the ui and api
bundle clean up static assets and rerun UI build
clean clean statically generated assets
docker_images build docker base_image and prod_image
docker_sdist
docs_image
explain_makefile launch a web server further explaining this makefile.
freeze_db
lint run python and eslint tasks
lint_eslint run eslint
lint_python run json/yaml validation and execute tox to perform python lint tasks
lock run poetry lock
prod_image builds meltano/meltano the AIO production image that includes static UI artifacts
release perform a release, should only be performed as part of the CI pipeline
show_lint show python and eslint ralated commands
test run tests
ui build the UI
```
| 1 |
7,603,319 | 105,509,947 |
2022-03-25 16:27:39.165
|
Bug - Missing Anonymous Schedule Events
|
Related to: https://gitlab.com/meltano/meltano/-/issues/3333
| 1 |
7,603,319 | 105,354,716 |
2022-03-23 14:04:14.250
|
meltano run error: 'SubprocessStreamProtocol' object has no attribute '_closed'
|
### What is the current *bug* behavior?
> I’m trying out the new meltano run command and I’m getting this error:
'SubprocessStreamProtocol' object has no attribute '_closed'
I don’t have environments set up currently
I’m using target-postgres (pipelinewise) and tap-mysql (singer)
Works fine with etl FWIW.
I think it’s the target that’s failing but am not sure
via https://meltano.slack.com/archives/C01TCRBBJD7/p1647644988807389
### What is the expected *correct* behavior?
_What should be happening?_
### Steps to reproduce
_How one can reproduce the issue?_
### Relevant logs and/or screenshots
```
2022-03-23T03:54:22.383009Z [debug ] Deleted configuration at /opt/meltano/.meltano/run/tap-mysql/tap.f3cb2165-e227-4ffb-9276-524d205a263e.config.json
2022-03-23T03:54:22.383883Z [debug ] Deleted configuration at /opt/meltano/.meltano/run/target-postgres/target.4daa2906-118d-476b-a50d-562be5def8c3.config.json
2022-03-23T03:54:22.384867Z [debug ] 'SubprocessStreamProtocol' object has no attribute '_closed'
Traceback (most recent call last):
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/__init__.py", line 47, in main
cli(obj={"project": None})
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/params.py", line 23, in decorate
return func(*args, **kwargs)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/params.py", line 56, in decorate
func(project, *args, **kwargs)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/utils/__init__.py", line 71, in wrapper
return run_async(func(*args, **kwargs))
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/utils/__init__.py", line 50, in run_async
loop.run_until_complete(future)
File "/usr/local/lib/python3.7/asyncio/base_events.py", line 587, in run_until_complete
return future.result()
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/run.py", line 84, in run
await _run_blocks(parsed_blocks)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/run.py", line 93, in _run_blocks
await blk.run()
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/block/extract_load.py", line 406, in run
await self.execute()
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/block/extract_load.py", line 396, in execute
await manager.run()
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/block/extract_load.py", line 591, in run
await self._wait_for_process_completion(self.elb.head)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/block/extract_load.py", line 670, in _wait_for_process_completion
await self._handle_head_completed(current_head, start_idx)
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/core/block/extract_load.py", line 697, in _handle_head_completed
await next_head.stdin.wait_closed()
File "/usr/local/lib/python3.7/asyncio/streams.py", line 323, in wait_closed
await self._protocol._closed
AttributeError: 'SubprocessStreamProtocol' object has no attribute '_closed'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/analytics/.cache/pypoetry/virtualenvs/corsair-meltano-8vM4tV9J-py3.7/lib/python3.7/site-packages/meltano/cli/__init__.py", line 55, in main
raise CliError(str(err)) from err
meltano.cli.utils.CliError: 'SubprocessStreamProtocol' object has no attribute '_closed'
'SubprocessStreamProtocol' object has no attribute '_closed'
```
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 2 |
7,603,319 | 104,642,226 |
2022-03-11 20:07:51.129
|
Executable for `meltano-map-transformer` should be `meltano-map-transform`
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
Meltano is trying to call the wrong executable, `meltano-map-transformer`.
### What is the expected *correct* behavior?
Meltano should call `meltano-map-transform`, even though that's not the plugin name.
See in the repo: https://github.com/MeltanoLabs/meltano-map-transform/blob/134642804db3da800ed0cdc5fe9fee63584542ad/pyproject.toml#L61
### Steps to reproduce
1. try running the `meltano-map-transform` with any tap and target
### Relevant logs and/or screenshots
```
meltano --log-level debug run tap-mongodb filter-stream target-postgres
Run invocation could not be completed as block failed: Cannot start plugin meltano-map-transformer: Executable 'meltano-map-transformer' could not be found. Mapper 'meltano-map-transformer' may not havebeen installed yet using `meltano install mapper meltano-map-transformer`, or the executable name may be incorrect.
```
### Possible fixes
Change the `executable` in `discovery.yml`.
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 1 |
7,603,319 | 104,505,826 |
2022-03-09 20:07:13.575
|
Consider removing `asynctest.CoroutineMock` in favor of `mock.AsyncMock` in our tests
|
## Why?
- The last release of [`asynctest`](https://pypi.org/project/asynctest/) was on May 2019
- Since Python 3.8, [`AsyncMock`](https://docs.python.org/3/library/unittest.mock.html#unittest.mock.AsyncMock) is shipped with `unittest.mock`.
- For compatibility with Python 3.7, we can still use the third-party [`mock`](https://github.com/testing-cabal/mock/blob/master/CHANGELOG.rst) library.
## Considerations
- `CoroutineMock` is used in all of the following files
- [tests/meltano/core/test_plugins_test_service.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/test_plugins_test_service.py)
- [tests/meltano/core/runner/test_runner.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/runner/test_runner.py)
- [tests/meltano/core/plugin/test_airflow.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/plugin/test_airflow.py)
- [tests/meltano/core/plugin/singer/test_tap.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/plugin/singer/test_tap.py)
- [tests/meltano/core/block/test_extract_load.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/block/test_extract_load.py)
- [tests/meltano/core/block/test_singer.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/core/block/test_singer.py)
- [tests/meltano/cli/test_invoke.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/cli/test_invoke.py)
- [tests/meltano/cli/test_select.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/cli/test_select.py)
- [tests/meltano/cli/test_run.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/cli/test_run.py)
- [tests/meltano/cli/test_elt.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/cli/test_elt.py)
- [tests/meltano/cli/test_config.py](https://gitlab.com/meltano/meltano/-/blob/master/tests/meltano/cli/test_config.py)
which will have to be prettified in order for our linter checks to pass.
| 4 |
7,603,319 | 104,495,633 |
2022-03-09 16:53:21.991
|
When installing a custom extractor / loader, git repository URL points to Meltano gitlab namespace
|
This is a confusing user experience because users may try to install from a URL that does not exist. https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/cli/utils.py#L119 is where this is getting printed. As a short-term fix we should make this much more generic.
| 1 |
7,603,319 | 104,423,740 |
2022-03-08 21:05:12.598
|
Consider displaying test duration information in our CI
|
Some unit tests in our CI jobs seem to take significantly longer than the rest to complete, so it'd be useful to identify them.
This should be as easy as adding the `--durations=10 --durations-min=1.0` flags.
Ref: https://docs.pytest.org/en/6.2.x/usage.html?highlight=duration#profiling-test-execution-duration
| 2 |
7,603,319 | 104,422,465 |
2022-03-08 20:28:47.288
|
Consider using a `https` scheme in default Snowplow collector endpoint
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
Default Snowplow event emitter is created for an `http` endpoint when it should be `https`.
### What is the expected *correct* behavior?
_What should be happening?_
The default value of `snowplow.collector_endpoints` should contain an `https` endpoint.
Note that `http` may be OK if a redirect is added on the SnowcatCloud side.
### Steps to reproduce
_How one can reproduce the issue?_
NA
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
NA
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
Change the value in `src/meltano/core/bundle/settings.yml`
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 1 |
7,603,319 | 104,345,828 |
2022-03-07 23:30:58.085
|
Limit the Snowplow tracker logs
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
The snowplow tracker library is printing logs on every CLI invocation that is tracked. This is a bit distracting and not something we want users to see all the time.
### What is the expected *correct* behavior?
_What should be happening?_
Commands should not display tracking logs by default.
### Steps to reproduce
_How one can reproduce the issue?_
1. Run any CLI command that is currently tracked in GA
1. Don't use any custom `logging.yaml` so the the default logging config is used
1. Notice the log lines at the end re Snowplow tracking coming from the libray
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
Set the level of the `snowplow_tracker.emitters` logger in the default config to `ERROR`.
With that change, these lines can probably be removed:
- https://gitlab.com/meltano/meltano/-/blob/cli-init-experience/src/meltano/cli/initialize.py#L36 (see https://gitlab.com/meltano/meltano/-/merge_requests/2562)
- https://gitlab.com/meltano/meltano/-/blob/02a512b62ac5a8c63a0aff25763cde915fdeec12/tests/meltano/core/test_tracking.py#L44-45
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 2 |
7,603,319 | 103,992,260 |
2022-03-02 23:08:14.679
|
Plugin config in Environments requires a `config` value or `setting` definition in top level plugin declaration
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
From @pnadolny13 in https://gitlab.com/meltano/meltano/-/issues/3299#note_860273439
> So it seems like current behavior is that you cant introduce configs at the environment level unless they were already defined in the top level config or theres an explicit setting definition.
### What is the expected *correct* behavior?
_What should be happening?_
Config values defined _only_ in an Environment should work without requiring the same config to have a value or a `setting` to exist in the top-level plugin definition.
### Steps to reproduce
_How one can reproduce the issue?_
Add a config to a plugin _only_ in an Environment:
```shell
meltano --environment=dev config my-plugin set "my_config" "value"
```
Meltano fails to recognize and expose this config in the runtime plugin environment.
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
```shell
# This fails because 'SQLFLUFF_SF_USER' is referenced in my dbt but its not set
meltano invoke sqlfluff lint
# This fails because 'SQLFLUFF_SF_USER' is referenced in my dbt but its not set
meltano --environment=dev invoke sqlfluff lint
# This fails because 'SQLFLUFF_SF_USER' is referenced in my dbt but its not set
meltano --environment=prod invoke sqlfluff lint
```
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
### Work Around Solutions
Either add an explicit setting to your plugin as shown in https://gitlab.com/meltano/meltano/-/issues/3299#note_859299619.
Or add the config key to the top level (not in an environment) plugin configuration, then Meltano recognizes it and reads the environment specific config properly. As described in https://gitlab.com/meltano/meltano/-/issues/3299#note_860273439.
| 8 |
7,603,319 | 103,987,084 |
2022-03-02 20:29:44.326
|
Create a plan to bring REST API to parity with CLI
|
@pandemicsyn: based on a convo with @aaronsteers I'll focus on two topic areas:
1. What (if any) immediate deficits do we have in the API that should be address.
2. What would a v2 of the API look like, what decisions do we need to make, and how do we get there.
| 4 |
7,603,319 | 103,973,908 |
2022-03-02 15:55:11.870
|
Bug - API Install Error
|
I noticed in this slack thread https://meltano.slack.com/archives/C01TCRBBJD7/p1646191929223089 that looks like they had an issue installing via the API due to a typo https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/api/controllers/plugins.py#L124.
| 4 |
7,603,319 | 103,918,583 |
2022-03-01 21:12:44.476
|
Adapter specific versions of Postgres, Redshift, and Bigquery
|
Follows from #3105+
This issue is planned as a follow-up to the initial `dbt-snowflake` release.
To have parity, we likely need these three:
- `dbt-postgres`
- `dbt-redshift`
- `dbt-bigquery`
Possible:
- `dbt-spark[PyHive]
- `dbt-presto`
Full list of dbt Labs supported adapters https://docs.getdbt.com/docs/available-adapters
| 8 |
7,603,319 | 103,849,288 |
2022-02-28 18:11:47.803
|
Formally remove support for "Dashboards", "Explore", and "Models"
|
These three relate to BI-focused features where we (Meltano) are now suggesting open source 3rd party solutions. We can therefor deprecate these features and move faster towards BI/dashboard interop with less user confusion:
- Remove support "Models", which are BI metadata models in yaml.
- Remove support "Dashboards", which are Meltano-rendered BI reports.
- Remove support for "Explore", which is an interactive analysis/query experience.
Promoted alternatives:
- Lightdash (#2786) has a Yaml-based metadata model similar to our "Models" approach, but inline with dbt project definitions.
- Superset (#2605) is a popular open source BI platform, which rich dashboard support.
- mProve (#3224) is an open source reporting tool that is entirely text-based, meaning it works plays with DevOps, Git, CI/CD, and PR review processes.
Phased deprecation:
- In a prior Meltano release, we toggled the visibility of Dashboard/Explore features in Meltano UI, setting them to 'off' by default.
| 8 |
7,603,319 | 103,074,190 |
2022-02-25 22:21:55.794
|
In adswerve/target-bigquery, state objects are merged
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
`target-bigquery`, default variant `adswerve` merges state objects, causing partition state created by the SDK to be transformed into a format it can not parse.
### What is the expected *correct* behavior?
_What should be happening?_
The target should not manipulate state.
### Steps to reproduce
_How one can reproduce the issue?_
Use a tap with partitioned state (e.g. `MeltanoLabs/tap-github` with `adswerve/target-bigquery` and notice the transformed state object.
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
See: https://gitlab.com/meltano/sdk/-/issues/300+
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
Default the target's `merge_state_messages` setting to false.
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 1 |
7,603,319 | 102,959,619 |
2022-02-23 23:01:08.045
|
Support `meltano add` directly from Hub
|
(Probably) blocked by #3031.
We'd like users to be able to add MeltanoHub plugins directly from the `meltano add` command.
Once this is working, the Hub can be updated with the install instructions on each detail page.
For instance, similar to the `choco install ...` CLI guidance on Chocolatey detail pages:
<details><summary>Click to expand</summary>
</details>
... we'd have the text:
> Install with Meltano:
>
> ```console
> meltano add extractor tap-gitlab --variant=MeltanoLabs
> ```
... or with an http ref:
> Install with Meltano:
>
> ```console
> meltano add extractor tap-gitlab --from_ref=https://hub.meltano.com/singer/taps/tap-gitlab--meltanolabs.yml
> ```
We'll likely need to first build #3031+, since this is the issue which decouples us from `discovery.yml`. We could go in another order, but then the inference is that the entire plugin definition would need to live in their `meltano.yml` file, which is parity with `--custom` but doesn't give a similar experience versus `discovery.yml`.
| 8 |
7,603,319 | 102,950,448 |
2022-02-23 19:07:44.114
|
--debug-level=True help function didn't help a new Meltano user
|
Was just debugging meltano with a new Meltano user. They hit an exception with tap-csv, had the standard "failed while in discovery" which pointing to logs (which they found), and then they tried to run with --log-level=DEBUG but it wasn't clear where to put --log-level=DEBUG so they did something like this
`meltano elt tap-csv target-jsonl --job-id=abc --log-level=DEBUG`
Easy fix is to probably just extend the message a bit to give an example of where to put --log-level? Easy MR to make but not sure if you'll agree!
| 1 |
7,603,319 | 102,939,378 |
2022-02-23 15:58:26.834
|
Bring down existing Snowplow Infra
|
Since infra was successfully created for https://gitlab.com/meltano/meltano/-/issues/3016+, we should bring it down now that we're committed to https://gitlab.com/meltano/meltano/-/issues/3243+
cc @aaronsteers @tayloramurphy
| 1 |
7,603,319 | 102,835,472 |
2022-02-22 05:29:58.241
|
Flake8 --diff not working as expected from forks
|
Following from the latest on community-contributed MR !2540, it seems the default branch targeting implemented in !2543 is not working as expected from a fork. Rather than compare `upstream/master` with `forkname/branchname`, the pipeline seems to be comparing `forkname/master` with `forkname/branchname`.
```
$ git fetch origin $CI_DEFAULT_BRANCH; # collapsed multi-line command
From https://gitlab.com/vischous/meltano
* branch master -> FETCH_HEAD
Comparing to master
$ declare FILES=$(git diff --name-only ${CI_COMMIT_SHA} $REF | grep "\.py$")
$ if [ -n "${FILES}" ]; then # collapsed multi-line command
Changed files are\nsrc/meltano/__init__.py
src/meltano/api/app.py
src/meltano/api/controllers/orchestrations.py
src/meltano/api/security/forms.py
src/meltano/cli/__init__.py
src/meltano/cli/add.py
src/meltano/cli/cli.py
...
```
To resolve this, we probably need to somehow explicitly compare with `upstream/master` or a similar reference, and to do so in a way that also works on the main `meltano` repo, which would not have an `upstream` reference.
Cc @edgarrmondragon, @pandemicsyn
| 2 |
7,603,319 | 102,823,769 |
2022-02-21 22:31:34.822
|
Review all docs links in code to ensure they point to docs.meltano.com
|
Based on https://gitlab.com/meltano/meltano/-/merge_requests/2540
| 1 |
7,603,319 | 102,818,215 |
2022-02-21 19:09:14.377
|
Freeze Gitlab docker images as stable, rather than continually updating
|
Blocks https://gitlab.com/meltano/meltano/-/merge_requests/2542
Before we can direct users to leverage our Gitlab-hosted docker images, we need to resolve a potential issue where `latest*` and `v1.xx.0*` images are apparently being constantly updated on every build to `master`.
Probably the solution is to have a more clear delineation between which images are "dev/test" images needed by later CI steps, and which images are "published/stable" images that can be relied upon by users with production workloads.
Notes:
- We can _optionally_ keep `latest` and `latest*` images linked to master CI builds, with the proper caveat/disclaimer to users that they are non-stable releases for the purposes of previewing unreleased features. (Not for production workloads.)
- Versioned images `*v1.xx.0*` should definitely not be updated continually with new `master` updates. The timestamp on those images reflects them being continually updated as of now.
| 4 |
7,603,319 | 102,816,963 |
2022-02-21 18:32:52.189
|
Full check for broken links in Python text, especially links to docs.meltano.com
|
As per #3263, it seems we may have a number of undetected 404 errors and/or broken links - especially in Python code which doesn't have any kind of auto-404 detection. A one-time regex or code search audit is probably warranted, as suggested by Derek in the related MR.
~"urgency::higher"
| 2 |
7,603,319 | 102,631,385 |
2022-02-17 15:47:55.356
|
Update the Getting Started guide in the docs now that environments are created for you
|
Once !2526 ships, users will no longer need to create their own environments, as documented in the [Getting Started guide](https://docs.meltano.com/getting-started#add-an-environment). This should be updated to just `list` functions, to introduce users to the created environments.
Thanks @pnadolny13 for spotting this 👏
| 2 |
7,603,319 | 102,463,633 |
2022-02-15 09:06:57.843
|
Nested values in array settings don't have environment variables expanded
|
Related to #2366
### What is the current *bug* behavior?
I was having trouble using environment variables in the `meltano.yml` file, and it seems they are only supported for top-level configuration options.
If I define `SOME_ENV_VAR=SOME_VALUE` in the `.env` file and I write this configuration yaml:
```yaml
plugins:
extractors:
- name: tap-spreadsheets-anywhere
variant: ets
pip_url: git+https://github.com/ets/tap-spreadsheets-anywhere.git
config:
test: $SOME_ENV_VAR
tables:
- path: $SOME_ENV_VAR
name: my_table
```
Then this is the actual configuration used by meltano:
```
$ meltano config tap-spreadsheets-anywhere
{
"tables": [
{
"path": "$SOME_ENV_VAR",
"name": "my_table"
}
],
"test": "SOME_VALUE"
}
```
And the `tables.path` variable is not set.
### What is the expected *correct* behavior?
The environment variable `SOME_ENV_VAR` should expend to `SOME_VALUE` in the `tables` array as well, and we should have:
```
$ meltano config tap-spreadsheets-anywhere
{
"tables": [
{
"path": "SOME_VALUE",
"name": "my_table"
}
],
"test": "SOME_VALUE"
}
```
### Steps to reproduce
- add the configuration above in `meltano.yml`
- add the line `SOME_ENV_VAR=SOME_VALUE` to your `.env` file
- see the result with `meltano config tap-spreadsheets-anywhere`
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 102,292,357 |
2022-02-11 19:38:48.785
|
Improve plugin command error message to clarify usage syntax
|
Related to https://gitlab.com/meltano/meltano/-/issues/3237#note_840251651 where @kgpayne said:
>Due to our custom syntax for commands, using the executable name is going to be equally jarring when users get to executing `meltano invoke great_expectations:checkpoint`, which is not functionality of the `great_expectations` executable.
I had a recent experience that I could see tripping people up. I wanted to use `dbt docs generate` and `dbt docs serve` which are not supported as `dbt:x` syntax because its not listed in the [discovery.yml](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/bundle/discovery.yml#L3073). This does not work:
```
meltano invoke dbt:docs generate
```
So I was thinking about adding an extra command to the plugin config like `docs_generate` that runs `docs generate` under the hood but then I realized that this works:
```
meltano invoke dbt docs generate
```
I'm not sure this is a problem but with such a minor difference in syntax I could see it becoming confusing whether your running a meltano command or raw command directly to the package. On one hand its great to allow commands to pass through so all the functionality is preserved but on the other its not clear in what context the command is being run. Maybe just having a warning that a "pass through" command is being used would be helpful, idk but wanted to call it out.
| 2 |
7,603,319 | 102,287,699 |
2022-02-11 17:36:08.176
|
Meltano UI tracking consent "learn more" link not found
|
The link to "learn more" in our tracking consent popup actually references a link that no longer exists. While it doesn't directly result in a 404 (we redirect to the docs), the link just takes you to the main page. We link to https://docs.meltano.com/reference/settings#send_anonymous_usage_stats
Ref: https://gitlab.com/meltano/meltano/-/blob/master/src/webapp/src/utils/setupToasted.js#L54
| 1 |
7,603,319 | 102,233,218 |
2022-02-10 21:04:24.292
|
`meltano test` erroring because unrelated Airflow isnt installed
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
When running my great_expectation tests using the `meltano test` command I get an error saying that Airflow isn't installed:
```
Executable 'airflow' could not be found. Orchestrator 'airflow' may not have been installed yet using `meltano install orchestrator airflow`, or the executable name may be incorrect.
```
Its correct, Airflow is not installed which is on purpose because I'm not using it. It almost looks like its trying to run Airflow instead of great expectations. If I use `meltano invoke` instead of `meltano test` it works properly.
### What is the expected *correct* behavior?
_What should be happening?_
The test command shouldnt require anything thats not used.
### Steps to reproduce
_How one can reproduce the issue?_
meltano, version 1.94.0
The meltano.yml is in the [squared repo](https://gitlab.com/meltano/squared/-/blob/master/data/meltano.yml#L314).
```bash
meltano install utility great_expectations
meltano test great_expectations:test_ga_raw
```
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
```
meltano --log-level=debug --environment=prod test great_expectations:test_ga_raw
2022-02-10T20:56:27.053642Z [info ] Environment 'prod' is active
2022-02-10T20:56:27.118585Z [debug ] Creating engine <meltano.core.project.Project object at 0x108105340>@sqlite:////Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/meltano.db
2022-02-10T20:56:30.498011Z [debug ] Starting new HTTPS connection (1): www.meltano.com:443
2022-02-10T20:56:30.740590Z [debug ] https://www.meltano.com:443 "GET /discovery.yml HTTP/1.1" 301 162
2022-02-10T20:56:30.746774Z [debug ] Starting new HTTPS connection (1): meltano.com:443
2022-02-10T20:56:30.925250Z [debug ] https://meltano.com:443 "GET /discovery.yml HTTP/1.1" 200 150378
2022-02-10T20:56:33.280922Z [debug ] Using selector: KqueueSelector
2022-02-10T20:56:33.544037Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-slack/tap.6f331ecc-78d8-457f-9cd7-da3407b40502.config.json
2022-02-10T20:56:33.544399Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-slack/tap.properties.json, skipping.
2022-02-10T20:56:33.544767Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-slack/tap.properties.cache_key, skipping.
2022-02-10T20:56:33.545172Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-slack/state.json, skipping.
2022-02-10T20:56:33.545688Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-slack/tap.6f331ecc-78d8-457f-9cd7-da3407b40502.config.json
2022-02-10T20:56:33.687214Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-google-analytics/tap.d8453ec6-bfd5-4e47-94fb-39ea5582f544.config.json
2022-02-10T20:56:33.687515Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-google-analytics/tap.properties.json, skipping.
2022-02-10T20:56:33.687929Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-google-analytics/tap.properties.cache_key, skipping.
2022-02-10T20:56:33.688462Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-google-analytics/state.json, skipping.
2022-02-10T20:56:33.688938Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-google-analytics/tap.d8453ec6-bfd5-4e47-94fb-39ea5582f544.config.json
2022-02-10T20:56:33.903914Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:33.904343Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena/tap.properties.json, skipping.
2022-02-10T20:56:33.904788Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena/tap.properties.cache_key, skipping.
2022-02-10T20:56:33.905197Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena/state.json, skipping.
2022-02-10T20:56:33.905749Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:34.604627Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena-metrics/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:34.604922Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-metrics/tap.properties.json, skipping.
2022-02-10T20:56:34.605316Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-metrics/tap.properties.cache_key, skipping.
2022-02-10T20:56:34.605739Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-metrics/state.json, skipping.
2022-02-10T20:56:34.606120Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena-metrics/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:35.287970Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena-audit/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:35.288635Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-audit/tap.properties.json, skipping.
2022-02-10T20:56:35.289147Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-audit/tap.properties.cache_key, skipping.
2022-02-10T20:56:35.289577Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-athena-audit/state.json, skipping.
2022-02-10T20:56:35.290027Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-athena-audit/tap.445100d9-f2d1-4844-917d-9a9c532e746d.config.json
2022-02-10T20:56:35.538957Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-gitlab/tap.ee5fe64e-82ba-46f6-91bf-4702651b3f56.config.json
2022-02-10T20:56:35.539424Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-gitlab/tap.properties.json, skipping.
2022-02-10T20:56:35.539939Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-gitlab/tap.properties.cache_key, skipping.
2022-02-10T20:56:35.540434Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-gitlab/state.json, skipping.
2022-02-10T20:56:35.540914Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-gitlab/tap.ee5fe64e-82ba-46f6-91bf-4702651b3f56.config.json
2022-02-10T20:56:35.728993Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-github/tap.967c975f-5d17-4b2f-8ebb-1e190f09dd51.config.json
2022-02-10T20:56:35.729744Z [debug ] Could not find tap.properties.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-github/tap.properties.json, skipping.
2022-02-10T20:56:35.730428Z [debug ] Could not find tap.properties.cache_key in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-github/tap.properties.cache_key, skipping.
2022-02-10T20:56:35.730804Z [debug ] Could not find state.json in /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/extractors/tap-github/state.json, skipping.
2022-02-10T20:56:35.731299Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/tap-github/tap.967c975f-5d17-4b2f-8ebb-1e190f09dd51.config.json
2022-02-10T20:56:35.814594Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:35.872057Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:35.872957Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:35.873424Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:36.185910Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:36.303360Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:36.304557Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-slack/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:36.304999Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-slack/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:36.649319Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:36.801696Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:36.803103Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-gitlab/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:36.803507Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-gitlab/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:37.132393Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.255502Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.256656Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-github/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:37.257158Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-athena-github/target.c7c90a13-b895-4dbe-a230-a92621dfce59.config.json
2022-02-10T20:56:37.305616Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.339673Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.340456Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.340977Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.563369Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.635584Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.636865Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml-metrics/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.637378Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml-metrics/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.855876Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.927241Z [debug ] Variable '$MELTANO_LOAD_SCHEMA' is missing from the environment.
2022-02-10T20:56:37.928092Z [debug ] Created configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml-audit/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.928589Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/target-yaml-audit/target.5fd05845-2e24-4ca1-9150-60a62a033fd7.config.json
2022-02-10T20:56:37.963193Z [debug ] Invoking: ['/Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/orchestrators/airflow/venv/bin/airflow', '--help']
2022-02-10T20:56:37.963398Z [debug ] Env: {"REMOVED"}
2022-02-10T20:56:37.972430Z [debug ] Deleted configuration at /Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/run/airflow/airflow.cfg
2022-02-10T20:56:37.974237Z [debug ] Executable 'airflow' could not be found. Orchestrator 'airflow' may not have been installed yet using `meltano install orchestrator airflow`, or the executable name may be incorrect.
Traceback (most recent call last):
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 270, in _invoke
yield (popen_args, popen_options, popen_env)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 282, in invoke_async
return await asyncio.create_subprocess_exec(
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/subprocess.py", line 236, in create_subprocess_exec
transport, protocol = await loop.subprocess_exec(
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/base_events.py", line 1630, in subprocess_exec
transport = await self._make_subprocess_transport(
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/unix_events.py", line 197, in _make_subprocess_transport
transp = _UnixSubprocessTransport(self, protocol, args, shell,
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/base_subprocess.py", line 36, in __init__
self._start(args=args, shell=shell, stdin=stdin, stdout=stdout,
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/unix_events.py", line 789, in _start
self._proc = subprocess.Popen(
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/subprocess.py", line 858, in __init__
self._execute_child(args, executable, preexec_fn, close_fds,
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/subprocess.py", line 1704, in _execute_child
raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: '/Users/pnadolny/Documents/Git/GitLab/squared/data/.meltano/orchestrators/airflow/venv/bin/airflow'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/__init__.py", line 47, in main
cli(obj={"project": None})
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/params.py", line 23, in decorate
return func(*args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/params.py", line 56, in decorate
func(project, *args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/validate.py", line 101, in test
exit_codes = run_async(_run_plugin_tests(session, collected.values()))
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/utils/__init__.py", line 50, in run_async
loop.run_until_complete(future)
File "/Users/pnadolny/.pyenv/versions/3.8.12/lib/python3.8/asyncio/base_events.py", line 616, in run_until_complete
return future.result()
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/validate.py", line 117, in _run_plugin_tests
return {runner.plugin_name: await runner.run_all(session) for runner in runners}
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/validate.py", line 117, in <dictcomp>
return {runner.plugin_name: await runner.run_all(session) for runner in runners}
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/validation_service.py", line 82, in run_all
async with self.invoker.prepared(session):
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/async_generator/_util.py", line 34, in __aenter__
return await self._agen.asend(None)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 176, in prepared
await self.prepare(session)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 158, in prepare
async with self.plugin.trigger_hooks("configure", self, session):
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/async_generator/_util.py", line 34, in __aenter__
return await self._agen.asend(None)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/behavior/hookable.py", line 87, in trigger_hooks
await self.__class__.trigger(self, f"before_{hook_name}", *args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/behavior/hookable.py", line 115, in trigger
raise err
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/behavior/hookable.py", line 107, in trigger
await hook_func(target, *args, **kwargs)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin/airflow.py", line 72, in before_configure
handle = await invoker.invoke_async(
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 282, in invoke_async
return await asyncio.create_subprocess_exec(
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/async_generator/_util.py", line 53, in __aexit__
await self._agen.athrow(type, value, traceback)
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/core/plugin_invoker.py", line 272, in _invoke
raise ExecutableNotFoundError(
meltano.core.plugin_invoker.ExecutableNotFoundError: Executable 'airflow' could not be found. Orchestrator 'airflow' may not have been installed yet using `meltano install orchestrator airflow`, or the executable name may be incorrect.
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/Users/pnadolny/.virtualenvs/squred/lib/python3.8/site-packages/meltano/cli/__init__.py", line 55, in main
raise CliError(str(err)) from err
meltano.cli.utils.CliError: Executable 'airflow' could not be found. Orchestrator 'airflow' may not have been installed yet using `meltano install orchestrator airflow`, or the executable name may be incorrect.
Executable 'airflow' could not be found. Orchestrator 'airflow' may not have been installed yet using `meltano install orchestrator airflow`, or the executable name may be incorrect.
```
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 102,170,275 |
2022-02-09 21:01:33.149
|
Add `--interactive --all` CLI flags in `meltano config set`
|
Based on recent discussions around the difficulties in knowing _which_ settings to configure when adding a new plugin, we should add an interactive mode for setting all setting for a plugin, or any specific settings value.
Something like...
```console
> meltano config dbt-snowflake set --interactive --all
You are now configuring the "dbt-snowflake" transformer plugin.
For help, please refer to plugin documentation: https://...
We will now step through each setting. Leave any entry blank to skip,
or enter a new value. Password values will automatically be hidden
from display for any settings of type 'password'.
Press Ctrl+C to cancel at any time.
Setting #1: project_dir
Description: The root dbt path.
Type: string
Default value: $MELTANO_PROJECT_ROOT/transform
Current value: (none)
New Value: _
(skipped)
....
Setting #7: snowflake_user
Description: The username to use in Snowflake authentication.
Type: string
Default value: (none)
Current value: (none)
New Value: snowflake_prod_user
Value saved successfully to meltano.yml!
Setting #8: snowflake_password
Description: The password to use in Snowflake authentication.
Type: password
Default value: $MELTANO_PROJECT_ROOT/transform
Current value: (none)
New Value: **********
Value saved successfully to Meltano System DB!
```
## Spec Details
- Interactive behavior is triggered bia the `--interactive` flag in `meltano config ... set`.
- Interactive behavior can be triggered for a single setting or with `--all` to set all settings associated with the given plugin.
- The `--all` option _requires_ the `--interactive` flag. If `--all` is specified without `--interactive`, Meltano should fail.
- After each setting is set, Meltano should respond with `Value saved successfully to _<store>_!`
- The store could be `.env`, the SystemDB, or to Meltano.yml.
- Confirming and saving after each setting is set gives real-time feedback to the user about changes they have applied, and allows the remaining operation to be canceled without loss of any setting values already saved.
- Individual settings should be skippable.
- Password fields should either print asterisks or simply not echo anything while users are typing.
- The new setting value should not be provided inline at the command line if `--interactive` is set. So, passing the setting value and also passing `--interactive` should cause Meltano to fail.
## Ability to "skip" settings
Skipping a setting may not be intuitive if done inline with the setting value input.
```
Setting #1: project_dir
Description: The root dbt path.
Type: string
Default value: $MELTANO_PROJECT_ROOT/transform
Current value: (none)
Would you like to set a new value? [Y/n]: n
Skipped.
Setting #2: snowflake_user
Description: The username to use in Snowflake authentication.
Type: string
Default value: (none)
Current value: (none)
Would you like to set a new value? [Y/n]: Y
New Value? []: snowflake_prod_user
Value saved successfully to meltano.yml!
...
```
Without a separate prompt to skip or set the value, the user would generally have to type something like an empty string or `s` for skip, or similar. However, those are potentially valid answers to the new value prompt.
## Phases
- The initial merge should at minimum provide `--all --interactive` support.
- Optionally, setting only one value (`--interactive` without `--all`) can be included in initial scope or added in a subsequent iteration.
- When setting only a single value, presumably we do not need to allow the "skip" option described above, since the user can simply abort (`ctrl+c`) to cancel if they do not want the value set.
- Not required in this first iteration, but a future iteration should require users to first define a setting's type if the type is not yet set. Would be a path for resolving #2768+. For example, if the user runs `meltano config tap-snowflake set --interactive snowflake_password`, that should require the user to _first_ define the setting `kind` (kind is `password` in this case), which then drives correct parsing and storage of the provided value.
| 8 |
7,603,319 | 102,165,182 |
2022-02-09 18:41:53.274
|
Support `--store=keyring` in `meltano config`
|
As proposed by Derek [in Slack](https://meltano.slack.com/archives/CFG3C3D1Q/p1644431033442989), we could use the [keyring](https://pypi.org/project/keyring/) Python library to store secrets in native OS-level keyrings.
Would add this option alongside others listed in https://docs.meltano.com/reference/command-line-interface#config:
```console
meltano config <plugin> set --store=keyring <name> <value>
```
| 4 |
7,603,319 | 102,018,671 |
2022-02-07 19:16:19.025
|
Perform API endpoint inventory/discovery
|
The meltano web API is a bit of an unknown/dark territory for a lot of us. There are quite a few API endpoints that the UI leverages, but they're really not documented at all. There are no API docs, sample requests/responses, expected status codes, etc. We should run a research spike and inventory what API endpoints are available to us so we gain a better understanding of the current state of the API is today.
Objectives for this research spike would be to produce:
- [ ] List of API endpoints/paths roughly documented in this issue for folks to review.
- [ ] Basic summary of what the endpoints do or support (producing a small docstring update MR to add basic method descriptions might be nice).
- [ ] Document any obvious API deficits, or quick wins you may come across.
- [ ] Document any large unknowns in this issue.
- [ ] Document any other "at first glance" or "next steps" recommendations that might arise.
- [ ] Recommendation for a path forward for auto-generating API docs.
Note from AJ:
Given the short turnaround for our meeting on the 16th (See @tayloramurphy's comment in thread), this probably should to be timeboxed as a `2` (max a few hours investment) for the first iteration.
| 2 |
7,603,319 | 101,916,274 |
2022-02-04 22:27:42.503
|
[Contributed MR]: Allow user to configure Sendgrid asm_group_id
|
Attached Community-Contributed MR: !2520+
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
### What is the expected *correct* behavior?
_What should be happening?_
### Steps to reproduce
_How one can reproduce the issue?_
Meltano the org appears to have hardcoded their own Sendgrid account's unsubscribe group, which causes header errors when using Subscriptions with a different Sendgrid account
### Relevant logs and/or screenshots
https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/api/mail.py#L14
### Possible fixes
Allow the use of an environmental variable like `mail_unsubscribe_group`, `asm_group_id` (sendgrid's name for it), `sendgrid_group_id`, etc.
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 2 |
7,603,319 | 101,905,837 |
2022-02-04 18:38:30.274
|
Release v1.95.0
|
[//]: # (NOTE: This Release template is for Admin-Use only. If you've reached this template in error, please select another template from the list.)
## Evergreen Releases - Prep Steps:
An `Evergreen` release process means we are _always_ releasing. We open a new release ticket as soon as we've completed the prior release. (It's therefore the final step in this checklist.)
## "Evergreen Prep" Checklist
- [x] Open this Issue
- [x] Indicate the version to be released here in the issue's title `Release vX.Y.Z`
- If the release number changes (from minor to major or patch, for instance), update the version here and in the issue description.
### Readiness Checklist:
`Engineering` team, to get ready for the upcoming release:
1. [x] Ensure any [already-merged commits](https://gitlab.com/meltano/meltano/-/commits/master) since the last release have [Changelog](https://gitlab.com/meltano/meltano/-/blob/master/CHANGELOG.md) entries (excepting non-user-impacting commits, such as docs fixes).
2. [x] Create a comment in the `#engineering-team` slack channel with pending-but-not-merged MRs, potentially shipping. (Aka, the "burndown" list.)
- Otherwise a comment that all known merge candidates are already merged.
3. [x] Create or link to a summary of MRs merged and/or expected in the `#marketing` Slack channel, with an `@channel` mention.
### Release Checklist
Rotating `assignee`, on the morning of the release:
1. [x] Changelog updates and version bump:
1. [x] Check the [pending MRs](https://gitlab.com/meltano/meltano/-/merge_requests?sort=updated_desc) to make sure nothing expected is still waiting to be merged.
2. [x] Create a [new branch](https://gitlab.com/meltano/meltano/-/branches/new) named `release/vX.Y.Z` and a corresponding MR with the `Release` MR template.
3. An automated pipeline (linked to the branch prefix `release/v*`) will
immediately and automatically bump the version and flush the changelog.
- [x] Check this box to confirm the automated changelog flush and version bump are correct.
- You _do not_ need to wait for the CI pipeline. (An identical CI pipeline is already included in the below.)
2. [x] [Cut a release tag](https://gitlab.com/meltano/meltano/-/tags/new) from your `release/vX.Y.Z` branch _(not from `main`)_ named `vX.Y.Z` with Message=`Release vX.Y.Z`
1. In response to new tag creation, these steps are performed automatically in Gitlab pipelines:
1. Abort if tag `vX.Y.Z` does not match output from `poetry version --short`
2. Test _everything_.
3. Publish to PyPi <!-- Meltano-only: and Docker -->.
2. Validate publish once the pipeline finishes. (While the process is running, you can continue with next steps, such as changelog grooming.)
1. [x] Check this box when the tag's [pipeline](https://gitlab.com/meltano/meltano/-/pipelines) has completed (eta 40-60 minutes).
2. [x] Check this box when [PyPi publish](https://pypi.org/project/meltano/#history) is confirmed.
<!-- Meltano-only: 5. [ ] Check this box when [Docker publish]() is confirmed. -->
3. Groom the changelog:
1. [x] Compare the [Changelog](https://gitlab.com/meltano/meltano/-/blob/master/CHANGELOG.md) against the `main` branch [commit history](https://gitlab.com/meltano/meltano/-/commits/master) and add any significant user-impacting updates (excluding docs and website updates, for instance).
3. [x] Review the Changelog for readability and typoes, committing fixes or updates if needed.
2. [ ] Final changelog review:
- Open the Changelog in preview mode, mouse over each link and ensure tooltip descriptions match the resolved issue.
- Check contributor profile links to make sure they are correct.
3. [x] Merge the resulting MR to `main` with the merge commit message `Release vX.Y.Z`
4. [x] [Open the next `Release` issue](https://gitlab.com/meltano/meltano/-/issues/new?issue) using the `Release` template.
### Announcements, Marketing, and Promotion
`Marketing` or `Product` team:
1. [ ] Post-release announcement steps:
1. [x] Post announcement to Meltano slack: `#announcements`
<!-- SDK only: 2. [ ] Cross-post (share) to `#sdk` -->
3. Copy-paste to:
- [x] `Singer` slack: `#meltano` <!-- SDK only: `#singer-sdk` -->
- [x] `dbt` slack: `#tools-meltano`
4. [ ] Blog post
5. [ ] Tweet the blog post
----------------
| 2 |
7,603,319 | 101,808,386 |
2022-02-03 12:04:44.695
|
Resolve ambiguity in current supported ways to set environment variables inside the plugin env via meltano.yml
|
# Meltano Configuration
Configuration management is a central part of the value provided to users of Meltano. Intention:
> Meltano is responsible for managing the configuration of all of a project's plugins. It knows what settings are supported by each plugin, and how and when different types of plugins expect to be fed that configuration.
## Use Cases
### Discovery
Discovery is how Meltano "knows what settings are supported by each plugin, and how and when different types of plugins expect to be fed that configuration". This is done by:
- Defining the settings available/expected to be configured for a given plugin.
- Defining the environment variables available/expected to be configured for a given plugin via the `env` settings [key](https://gitlab.com/meltano/meltano/-/blob/master/schema/discovery.schema.json#L653).
- Defining default values for settings via the `value` [key](https://gitlab.com/meltano/meltano/-/blob/master/schema/discovery.schema.json#L598). Note, default values can contain templated string references to environment variables (e.g. `$MELTANO_PROJECT_ROOT/utilities/great_expectations`).
- Which environment is `MELTANO_PROJECT_ROOT` expected to be in? The Meltano runtime or the plugin runtime? 🤯
- Defining env var maps to predictable names via the `env_aliases` [key](https://gitlab.com/meltano/meltano/-/blob/master/schema/discovery.schema.json#L661) for reuse across types of plugins (now marked as deprecated 🤦♂️). (e.g. `TAP_POSTGRESS_HOST` > `PG_ADDRESS`).
- Defining settings aliases via the `aliases` [key](https://gitlab.com/meltano/meltano/-/blob/master/schema/discovery.schema.json#L581) as alternative names by which the setting can be configured in `meltano.yml` and the CLI. This is often done to 'prettify' or make uniform with other plugin variants (e.g. `postgres_host` > `host`). **Note:* Meltano does not currently look for env vars of the form `<plugin name>_<alias name>` by default (though sunch env vars can be specified as `env_aliases` manually), nor does it appear to check or warn of clashes as the result of settings referenced in multiple ways (by its `name`, `aliases` or `env_aliases`).
In addition to the behaviours implemented as part of discovery, Meltano has 2 other builtin mechanisms for handling/discovering settings:
- [Pipeline environment variables](https://docs.meltano.com/guide/integration#pipeline-environment-variables) define settings that are passed from the environment of one plugin to the next in a pipeline (e.g. `extractor>loader>transformer`).
- [Plugin extras](https://docs.meltano.com/guide/configuration#plugin-extras) define settings used to configure the behaviour of specific plugin types _before_ and _after_ 3rd party code is invoked. This works by passing `plugin_extra` settings for use by all subclasses of [`BasePlugin`](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/plugin/base.py#L246) (e.g. extras available to the [`SingerTap`](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/plugin/singer/tap.py#L104) allow users to [override](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/plugin/singer/tap.py#L302) the `catalog.json` path used during Tap invocation).
### Configuration
Configuration is how end-users populate discovered settings with their own values. Config is done by:
- Using the `meltano config ...` CLI and `meltano.yml` to configure the above settings by name.
- Using environment variables in the Meltano runtime to configure the above settings via a `<PLUGIN NAME>_<SETTING_NAME>` env var naming convention. Environment variables can either be `export`'d into the Meltano runtime or coded in a `.env` file automatically discovered by Meltano.
- Using values stored in the Meltano [system database](https://docs.meltano.com/concepts/project#system-database) to configure settings by name (also available through the UI).
- Using the `env:` key of the [environments](https://docs.meltano.com/concepts/environments) feature to inject arbitrary environment variables into a plugins environment. These env vars will also be passed to subsequent stages in a pipeline according to the [pipeline environment variables](https://docs.meltano.com/guide/integration#pipeline-environment-variables) feature.
- How are duplicates/clashes handled?
- Setting env vars in the Meltano runtime environment matching names specified in setting `env:` and `env_aliases:` discovery keys (that do not have to conform to the `<PLUGIN NAME>_<SETTING_NAME>` conventions) to inject values into the plugins environment. **Note:** this is now an undesired behaviour, as per [#2984](https://gitlab.com/meltano/meltano/-/issues/2984).
- Referencing provided [pipeline environment variables](https://docs.meltano.com/guide/integration#pipeline-environment-variables) in plugin tools code (e.g. the [provided profiles.yml](https://gitlab.com/meltano/files-dbt/-/blob/master/bundle/transform/profile/profiles.yml))
- Using `plugin_extras` to configure the pre and post invocation behaviours of plugins.
- Mapping a setting to an environment variable by adding a `my_setting: ${MY_ENV_VAR}` mapping under the `config:` block in `meltano.yml` or via the CLI using `meltano config <plugin> set my_setting "${MY_ENV_VAR}"`.
- Which environment is `MY_ENV_VAR` expected to be in? The Meltano runtime or the plugin runtime? 🤯
## FAQ's
- What is the difference between `config` and `settings`?
Settings are specified as part of plugin definitions for the purposes of discovery. Config is the mechanism by which the fields described as settings are populated with values.
Whilst `settings` usually only appear in `discovery.yml`, custom plugins added in `meltano.yml` places `settings` and `config` in the same view, which is completely baffling.
- How does `config` specified in `meltano.yml` arrive in files inside a plugins runtime? e.g. Singers' `config.json` or dbts' `profiles.yml`?
For Singer the `SingerPlugin` class `src/meltano/core/plugin/singer/base.py` has a method (decorated as a `before_configure` Hook) for [writing a valid config.json file]() and another for [removing the file after](). Config arrives via an instance of the `PluginSettingsService` instantiated with both project and plugin.
For dbt (specifically `profiles.yml` the approach is slightly different. dbt supports the retrieval of env vars within its config files (using jinja templating syntax). Therefore we need only match the env vars specified in the [provided profiles.yml](https://gitlab.com/meltano/files-dbt/-/blob/master/bundle/transform/profile/profiles.yml) to those available inside the Transformers environment. To smooth over this injection of env vars, Meltano makes available all the env vars provided to the Loader available to the Transformer as well, as part of the [pipeline environment feature](https://docs.meltano.com/guide/integration#pipeline-environment-variables). Currently we prescribe env vars of the form `PG_*` in the file bundle, but any matching env var name could be used (e.g. `TARGET_POSTGRES_*` to match the Loader env var convention).
- How do we determine what `settings`, specified in discovery, should be environment variables vs. which should be injected into files?
This is implemented using the `env:` and `env_aliases:` keys in `discovery.yml`. Details as per Douwes comment [here]:
> The behaviour around `env` and `env_aliases` is implemented in [`SettingsService.setting_env_vars`](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/plugin/settings_service.py#L63), which takes a `for_writing` boolean (which is `False` by default). Writing here means writing into the plugin's execution env, not-writing means reading from Meltano's execution env to populate a setting (that may then be written into the plugin execution env later). That `for_writing` flag is passed to [`SettingDefinition.env_vars`](https://gitlab.com/meltano/meltano/-/blob/master/src/meltano/core/setting_definition.py#L174) as `include_custom`. Following the logic there shows that when reading from the env, only the auto generated `<prefix>_<name>` is checked, and when writing into the env, env and env_aliases are used as well. I think the logic is that we want Meltano users to always use `<prefix>_<name>` consistently, but the plugin itself may expect a different env var.
This description does not appear to explain the case described by [#2984](https://gitlab.com/meltano/meltano/-/issues/2984), which sparked our efforts to deprecate `env:` and `env_aliases:` in the first place 🤷♂️
## Proposed Next Steps
- To resolve [#2984](https://gitlab.com/meltano/meltano/-/issues/2984) I believe we should remove the ability of the `SettingsService` to retrieve for injection any env vars _other than_ those matching the `<plugin name>_<setting name>` convention from the Meltano runtime environment. This meets Douwes intent that:
> we want Meltano users to always use `<prefix>_<name>` consistently, but the plugin itself may expect a different env var."
- Implement a check to determine if any arbitrary env vars configured in `environments.[].env` do not clash with `env:` and `env_aliases:` defined in discovery. Warn or error if clashes are found.
- Provide guidance/docs on the usage on `env:` and `env_aliases:` keys in discovery. AJ suggests:
> General plugins vs Singer plugins: General plugins must get some of there config from env vars; Singer plugins should not need env vars - but some do. Following from this:
> - It's a healthy pattern for General plugins to declare `env:` entries to pass along settings to the plugin context (but probably not `env_aliases:`).
> - It's a discouraged pattern for Singer plugins to declare `env:` entries. (We'll support if needed, but we should keep an eye on them and this should be the exception rather than the rule.)
> - To avoid confusion around which env entries are needed for Singer plugins to function - versus which are convenient aliases, I think we should remove `env_alias:` entries from Singer plugins, replacing them with env: entries and an explanatory comment with issue link perhaps.
### Description V1
Quick summary of recent findings:
1. `env_aliases` / `env` - These are the same functionally. (New info to everyone!) - these fit the description as recently added in the JSON Schema for `env:`:
- > `An environment variable that will be initialized with the setting's value whenever the plugin is invoked. This is used to inject environment variables into the plugin's execution context. If the named environment variable is already defined at runtime, Meltano will use the passed value from context instead of the configured value.`
- Essentially a two-way read and write to/from the env variable.
2. The `env_alias` and `env` entries also have a special role in seeding `dbt_profiles.yml`. Specifically `PG_ADDRESS`, etc. I think (to confirm?) this is part of the reason dbt cannot be run on its own: because if the target wasn't invoked, those settings don't exist.
3. Settings aliases - newly discovered! Similar to `env_aliases` but at the setting level.
- To be confirmed: if these are compatible with env injection in the form `<PLUGIN_NAME>_<SETTING_ALIAS>`. More in #3209.
4. `config` vs `settings`: `settings` are the plugin definition (optionally with default values) and `config` is one project's settings values.
5. When a user wants to map a setting to an environment variable, the recommended way of doing so is probably to add a `my_setting: ${MY_ENV_VAR}` mapping under the `config:` block.
6. General plugins vs Singer plugins: General plugins _must_ get some of there config from env vars; Singer plugins should not need env vars - but some do. Following from this:
- It's a healthy pattern for General plugins to declare `env:` entries to pass along settings to the plugin context (but probably not `env_aliases:`).
- It's a discouraged pattern for Singer plugins to declare `env:` entries. (We'll support if needed, but we should keep an eye on them and this should be the exception rather than the rule.)
- To avoid confusion around which env entries are needed for Singer plugins to function - versus which are convenient aliases, I think we should remove `env_alias:` entries from Singer plugins, replacing them with `env:` entries and an explanatory comment with issue link perhaps.
------------------------
As per office hours 2022/02/02, the current mechanism of declaring an environment variable to be populated within plugin `settings` using `env:` and `env_alias:` causes confusion to even experienced Meltano users.
From the jsonschema:
```json
"env": {
"type": "string",
"description": "An environment variable that will be initialized with the setting's value whenever the plugin is invoked. This is used to inject environment variables into the plugin's execution context. If the named environment variable is already defined at runtime, Meltano will use the passed value from context instead of the configured value.",
"examples": [
"DBT_PROFILES_DIR",
"GE_HOME"
]
}
"env_aliases": {
"type": "array",
"description": "Deprecated. Use to delegate alternative environment variables for overriding this setting's value",
"examples": [
"TAP_ACCOUNT_ID",
"TAP_ACCOUNT_IDENTIFIER"
],
"items": {
"type": "string"
}
}
```
Specifically, from `env`,:
> If the named environment variable is already defined at runtime, Meltano will use the passed value from context instead of the configured value.
This causes unexpected behaviours for users not aware of this dual behaviour. We propose that, in stead of relying on `env:` for both purposes (sourcing values to inject _and_ determining the target env var name to inject into), we simply remove the sourcing behaviour. This would mean Meltano would no longer search its runtime environment for matching env var names to retrieve values, effectively making any settings with `env:` specified an "environment variable type setting" (as suggested by @tayloramurphy [here](https://gitlab.com/meltano/meltano/-/merge_requests/2505#note_829519083)). Sourcing of values would only be possible via the standard mechanisms; explicit `config:` or env vars in the Meltano runtime of the form `<plugin name>_<setting name>`.
`env_aliases` might be kept to allow one setting to be mapped to multiple env vars. E.g.
```yaml
settings:
- name: aws_profile
env: AWS_PROFILE
env_aliases: [AWS_DEFUALT_PROFILE]
```
or both could be replaced with an array-type `env_vars:` e.g.:
```yaml
settings:
- name: aws_profile
env_vars: [AWS_PROFILE, AWS_DEFUALT_PROFILE]
```
It is also worth considering if these settings should be injected as keys in config files either. Not doing so would further increase the specificity of the settings function as "an environment variable created from a Meltano setting".
### Possible Challenges
- Users can also set environment variables directly using the `env:` key in the `--environment` feature. This produces two ways to achieve the same outcome, and may cause conflicts and confusion to users. This can be handled with a resolution order (preferring settings above environment variables) and/or by warning/erroring if the same env var is specified by the two methods.
| 4 |
7,603,319 | 101,800,409 |
2022-02-03 10:42:29.871
|
Restore heading anchor links adjacent to headings in the Meltano docs
|
Looks like the Meltano doc heading anchors are gone/hidden in the new docs site 🤔 They are still available at `<h1>` level by copying links for the table of contents, but it would be great to add anchors next to headings (and subheadings - all of the `<h*>` tags) for linking to specific sections of the docs.
| 4 |
7,603,319 | 101,669,858 |
2022-02-01 15:43:24.301
|
Adopt `pip-licenses` in place of LicenceFinder for tracking python dependency licenses in the Meltano project
|
Blocked by #3198
| 8 |
7,603,319 | 101,669,811 |
2022-02-01 15:42:13.643
|
Contribute `GitLabLicenseComplianceReportTable` to `pip-licenses`
|
This issue is to track contribution of a `GitLabLicenseComplianceReportTable` class to the `pip-licenses` codebase, to allow direct interchangeability between `pip-licenses` and GitLabs `licence_management` tool.
As per [this discussion](https://gitlab.com/meltano/meltano/-/merge_requests/2500#note_820960272), LicenseFinder and the wrapper (called `license_management`) provided by GitLab i) do not support poetry natively and ii) only detect 2/3rds of our total licenses. A brief evaluation of `pip-licenses` detected all but 1 of our dependencies licenses, and supports poetry (by virtue of running within a python virtualenv). However, to adopt `pip-licenses` and still use the License Compliance UI and MR features in GitLab, we need to format the results produced by `pip-licenses` in the same format as the report outputted by the `license_management` wrapper. This can be done by contributing a new report class to `pip-licenses` for optionally outputting the required GitLab artefact.
| 8 |
7,603,319 | 101,487,305 |
2022-01-28 19:28:42.416
|
Meltano Test bug with files bundles
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
This is based on [this slack thread](https://meltano.slack.com/archives/C013EKWA2Q1/p1643388924407829).
### What is the current *bug* behavior?
_What is happening now?_
When I try to use the `test` feature with dbt I get a message saying:
`Command 'test_publish_hub' could not be found. File bundle 'dbt' does not define any commands.`. It looks like its iterating my plugins by name and getting to my file bundle named `dbt` before it gets to my transformer named `dbt`. If I remove the files bundle, my tests work. If I rename my files bundle I get errors.
```
transformers:
- name: dbt
pip_url: git+https://github.com/Tomme/dbt-athena.git@c8e0458f85aaa8f9b693f99903ba95c41b90573b
config:
target: athena
commands:
test_publish_hub: test --models marts.publish.meltano_hub.*
files:
- name: dbt
pip_url: git+https://gitlab.com/meltano/files-dbt.git@config-version-2
```
### What is the expected *correct* behavior?
_What should be happening?_
The test feature shouldnt consider tests in the files plugin section. Maybe larger than that it might need to accept a plugin.plugin_name combo (i.e. meltano test transformer.dbt:test_123) if a project has multiple plugins with the same name.
### Steps to reproduce
_How one can reproduce the issue?_
Install dbt then add a command starting with the test prefix and run `meltano test dbt:test_name`.
### Relevant logs and/or screenshots
_Please use code blocks (\`\`\`) to format console output_
### Possible fixes
_If you can, link to the line of code that might be responsible for the problem or suggest a fix_
### Further regression test
_Ensure we automatically catch similar issues in the future_
- [ ] Write additional adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
| 4 |
7,603,319 | 101,474,780 |
2022-01-28 15:08:35.507
|
Improve documentation around what a namespace is and does
|
Reading through the documentation, we don't do a good job of explaining what `namespace` does or means. There's no mental model we're trying to build for the user. When searching for namespace we show the user:
* https://docs.meltano.com/tutorials/postgres-with-postgres#run-meltano-elt
* https://docs.meltano.com/guide/transformation#adding-a-transform-to-your-meltano-project
* https://docs.meltano.com/concepts/project#custom-plugin-definitions
* https://docs.meltano.com/the-project/contributor-guide#plugin-definitions
* https://docs.meltano.com/concepts/plugins#package_name-extra
* https://docs.meltano.com/guide/containerization#gitlab-cicd
But none of those explains what it's doing or why one needs it!
| 2 |
7,603,319 | 101,419,508 |
2022-01-27 21:48:24.198
|
Improve Documentation on Configuring Settings for Custom Plugins
|
https://docs.meltano.com/guide/configuration#:~:text=If%20we%E2%80%99re%20dealing%20with%20a%20custom%20plugin%20instead
When configuring a custom plugin, the documentation is not clear that the settings configuration needs to be added for Meltano to pick up Environment Variable values for plugin settings. If settings configuration is not added, then plugin config values need to be added directly to meltano.yml to work.
Documentation should clarify that plugin settings need to be configured for Meltano to pickup environmental variables.
| 1 |
7,603,319 | 101,390,898 |
2022-01-27 14:22:28.205
|
Upgrade PIP added to docs
|
A user of Meltano follows a new path to get started. While I haven't worked with folks who have used the new path from the new website, I have seen folks who are new to Python fail at the `pip install meltano` stage due to pip not being up to date (Every user I've worked with without fail who isn't from Python fails here, and needs my help, had 4 people fail here 1 of which being a dev with>10 year experiance, all of these devs were not python devs) , the error received when this happens is not very clear as it's normally due to some dependency resolution issue that's fixed in newer versions of pip.
1. https://docs.meltano.com/getting-started
1. https://docs.meltano.com/guide/installation
And anywhere else a new venv is created we should direct people to update their pip version. Thoughts? Easy to update but wanted to be sure you're all onboard
Related to !2480
| 1 |
7,603,319 | 101,340,106 |
2022-01-26 23:09:13.832
|
Support for disabling elt.log creation
|
The `meltano elt` command will naively write out a log file on every invocation, even in the presence of a logging.yaml config. The elt.log has no built-in support for log rotation/max size/etc and users may not even always be aware of its existence. In situations where disk space is limited, this could cause issues.
Since we support custom log configs via logging.yaml now, we could give users an option to explicitly disable elt.log generation.
| 4 |
7,603,319 | 101,322,585 |
2022-01-26 18:04:26.911
|
discovery.yml missing from meltano.com
|
With the update to the new meltano.com marketing we're no longer pushing a discovery.yml and requests return a 404:
```
(melty-3.8) ➜ run-dev2 curl -I https://meltano.com/discovery.yml
HTTP/2 404
server: nginx
date: Wed, 26 Jan 2022 18:03:39 GMT
content-type: text/html; charset=UTF-8
content-length: 71557
vary: Accept-Encoding
vary: Accept-Encoding
expires: Wed, 11 Jan 1984 05:00:00 GMT
link: <https://meltano.com/wp-json/>; rel="https://api.w.org/"
x-powered-by: WP Engine
x-cacheable: non200
cache-control: max-age=600, must-revalidate
x-cache: HIT: 48
x-cache-group: normal
```
| 4 |
7,603,319 | 101,260,718 |
2022-01-26 04:45:57.345
|
Missing output folder
|
<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label and verify the issue you're about to submit isn't a duplicate.
If you are submitting an issue with a tap, please include:
- account details
- target details
- entities selected with meltano select (if you have selected any entities), as the bug may be related to a specific entity
- the full elt command you are running
- full output of the meltano elt command. Logs can get pretty long, so you can add the full log as a snippet in the Meltano project and add a link in the issue.
--->
### What is the current *bug* behavior?
_What is happening now?_
when use the command `meltano init` output folder is not created and when try to use target-jsonl the process fail for that reason
### What is the expected *correct* behavior?
Meltano init command should create the folder
### Steps to reproduce
```bash
$ meltano init example
$ meltano add extract tap-shopify
$ meltano add loader target-jsonl
$ meltano run tap-shopify target-jsonl
```
### Possible fixes
Just create output folder into the init command
### Further regression test
- [ ] Add output folder creation with init command
| 1 |
7,603,319 | 101,047,911 |
2022-01-21 14:37:59.216
|
Problem with `env` key names at the plugin level
|
Based on a thread from https://gitlab.com/meltano/meltano/-/issues/3173#note_817409586 and from https://gitlab.com/meltano/meltano/-/merge_requests/2489#note_808785679, it would be ideal to be able to set `env` keys at the plugin level vs the current state where it can only be done at the environment level.
The `env` key does seem to work at the plugin level but it prefixes the key in a way that makes it not useful (i.e. `TAP_SLACK__ENV_*`).
Ideally in combination with https://gitlab.com/meltano/meltano/-/issues/3173#note_817409586 we will be able to override environment variables in descending order, where the plugin `env` key is the lowest level and takes precedence. An environment plugin `env` takes precedence over a top level plugin `env`.
@aaronsteers wdyt?
| 4 |
7,603,319 | 101,006,476 |
2022-01-20 22:18:18.278
|
Support dbt v1.0
| null | 4 |
7,603,319 | 101,006,028 |
2022-01-20 22:00:03.714
|
Can CI (securely) auto-deploy sample of the latest Meltano UI?
|
Opening this issue to discuss if/how we could setup a PR-specific deployment endpoint that would allow quick preview and testing of Meltano UI updates.
Currently, I think we need to either share screenshots or build and deploy locally on our own workstations.
| 8 |
7,603,319 | 101,004,612 |
2022-01-20 21:09:05.275
|
Change instructions to recommend pipx instead of manually-created virtual environments
|
Before joining Meltano, I'd created !1960+ to recommend installations with pipx instead of pip and manually-generated virtual environments. This came up again today and (now that !2496+ is fixed), I'd like to revisit/resurrect the pipx-based install guidance.
## Why this matters
I think we lose people when we ask them to create their own virtual environments. Also - then anything installed into that virtual environment is unavailable until the environment is manually activated, which requires memorizing the path to the activation script, and the whole process is just more cumbersome than I'd like.
Pipx was directly created to solve this problem:
- Virtual environments are created automatically.
- Shims are installed automatically to PATH, so you never need to manually activate the environments.
- The syntax is the same to install and upgrade, except one character: `pip3 install meltano` -> `pipx install meltano`.
Cc @edgarrmondragon
| 4 |
7,603,319 | 101,001,505 |
2022-01-20 19:40:37.477
|
Formalize rules that govern environment variable inheritance and precedence
|
I've had a couple use cases where I'd like to set different environment variables at different levels. For sensitive credentials I set them in the .env while non-sensitive environment specific settings (like schema_name) get set at the meltano.yml environment level.
The functionality I want is to be able to combine both sensitive and non-sensitive variables for use in a plugin as an environment variable. A use case is in the squared repo where we have an Athena connection string used in Great Expectations and Superset:
`awsathena+rest://[YOUR_AWS_KEY]:[YOUR_AWS_SECRET]@athena.us-east-2.amazonaws.com/[YOUR_SCHEMA_NAME]?s3_staging_dir=s3://[YOUR_S3_PATH]`
I want to be able to set the secret keys in my .env and the path and schema in my meltano.yml environment. Right now templating is supported in meltano.yml for config values using environment variables but for some plugins, especially utilities, configs arent useful and we need to be building environment variables that the utility can access. Templating doesnt seem to be supported at the `env` level underneath the `environment` key. So right now I can set secrets in the .env and non-sensitive variables at the `environment.env` level in meltano.yml but I have no way of blending the two to pass along to a plugin, so I end up building the connection string multiple times in the plugins vs defining it once.
Ideas: Add an `env` key to plugin configs that allows you to use templating to build a new environment variable at the plugin/environment level. Or...allow templating at the current `env` key level based on whats in your .env file.
## Update (2022-05-05)
Scope of this issue is now to:
* Write tests based on the spec in the [Miro Board](https://miro.com/app/board/uXjVO3j_ADw=/)
* Fix anything that fails tests
* Update documentation to clarify inheritance
## Update (2022-05-03)
**Relevant [Miro Board](https://miro.com/app/board/uXjVO3j_ADw=/) where we're whiteboarding all of this**
## Spec Update (2022-04-08)
Note: this updated spec follows from my comment here: https://gitlab.com/meltano/meltano/-/issues/3173#note_817409586
### Problem statement:
Currently, env variables at different levels of the code cannot necessarily rely on each other or build upon each other.
### Proposed solution:
We would define environment variable inheritance to be valid across these layers, in this strict order:
- Level 1: terminal context (inherited either via `.env` or via shell env vars)
- Level 2: top-level `env:` declarations within `meltano.yml`
- Level 3: environment-level `env:` declarations.
- Level 4: `env:` declarations within top-level plugin definitions.
- Level 5: `env:` declarations within environment-scoped plugin definitions.
### Example
This shows how inheritance would be expected to function across the 5 named levels. (Could be a unit test during development.)
`.env`
```sh
# Level 1: terminal context
# Inherits from none
LEVEL_NUM="1"
STACKED="1"
```
```yml
env:
# Level 2: top-level `env:`
# Inherits from terminal context
LEVEL_NUM: "2" # '2'
STACKED: "${STACKED}2" # '12'
plugins:
extractors:
tap-foobar:
env:
# Level 4: plugin-level `env:`
# Inherits from a environment-level `env:` if an environment is active
# Inherits directly from top-level `env:` if no environment is active
LEVEL_NUM: "4" # '4'
STACKED: "${STACKED}4" # '1234'
environments:
prod:
env:
# Level 3: environment-level `env:`
# Inherits from top-level `env:`
LEVEL_NUM: "3" # '3'
STACKED: "${STACKED}3" # '123'
plugins:
extractors:
tap-foobar:
env:
# Level 5: environment-level plugin `env:`
# Inherits from (global) plugin-level `env:`
LEVEL_NUM: "5" # '5'
STACKED: "${STACKED}5" # '12345'
```
## FAQ
**Q. Why does the global plugin level config (level 4) inherit from the environment-level config?**
A: This is counterintuitive at first but actually quite necessary.
Imagining that the plugin settings globally include a call to `$SNOWFLAKE_USERNAME` and imagine that each environment has its own value for `SNOWFLAKE_USERNAME: ___` in the respective `env:`. We don't want each environment to have to redundantly declare the plugin properties but we _do_ want to use the `$SNOWFLAKE_USERNAME` value that is most appropriate from the given execution context. Hence, the global-level plugin can be defined once to leverage whatever value is in `$SNOWFLAKE_USERNAME` and the plugin's configuration will still be seeded properly according to which environment is active.
## Providing level info for research/debugging
Perhaps in the `dry-run` proposal in #3146, it would be good to print where each environment variables are sourced. We will need to do this without exposing sensitive values.
So, if the example above were real, we might get debug info such as:
```
meltano run --dry tap-foobar target-snowflake
Printing debug info in response to `--dry` CLI argument. No actions will be executed.
The plugin `tap-foobar` was declared with the following context:
- env:LEVEL_NUM - derived from the following, in order of precedence:
- environments[prod].plugins[tap-foobar].env[LEVEL_NUM]
- plugins[tap-foobar].env[LEVEL_NUM]
- environments[prod].env[LEVEL_NUM]
- env[LEVEL_NUM]
- shell.env[LEVEL_NUM]
...
```
Or perhaps a more realistic example:
```
meltano run --dry tap-foobar target-snowflake
Printing debug info in response to `--dry` CLI argument. No actions will be executed.
The plugin `tap-foobar` was declared with the following context:
- 'tap-foobar.config[username]' was derived from the following, in order of precedence:
- environments[prod].env[FOOBAR_USERNAME]
- env[FOOBAR_USERNAME]
...
```
In the above example, the 'prod' declaration of `FOOBAR_USERNAME` clobbers the global one. The user can infer from this printout that their `prod`-level config is working correctly, and if they were to remove the prod-level config, they'd get the value of the top-level `env:` declaration.
## Related Topics
More discussion on this can and probably should be moved to a follow on issue, but for completeness:
### Further detail and settings-level `env:` declarations (`level 6`)
Not listed above, but a plugin setting may have `env:` declared, which operates differently from the other layers. This `plugin.settings[].env:` declaration simply accepts a string as env variable name, and the specified setting value will get injected and sent _into_ the plugin's subprocess.
- This functionality is required in order to have plugins behave as expected. Non-singer plugins don't receive a `config.json` so the env variable injection is the substitute.
- I think the `env:` function at the setting layer should _always_ be a pure child process injection (clobbering any existing env var but not reading from it).
- We should probably stop this layer 6 from _also_ sourcing data from layers 1-5, and instead make it a pure one-way injection into the plugin context. As described in #3447+
- I do not know if the current status quo for an existing `env` variable value will clobber an explicitly defined config value, or if the config value would clobber the env variable value, essentially replacing the env var value within the plugin's child process.
| 8 |
7,603,319 | 100,981,585 |
2022-01-20 14:00:40.215
|
Legacy python 3.6 compatibility code
|
With the dropping of python 3.6 support in #2991, I also had a very quick search through the codebase to find comments that referenced 3.6 compatibility hacks:
```
(melty-3.8) ➜ meltano git:(2991-python-3-6-eol) ✗ grep "3\.6" * -r | egrep -v "\.js|.vue|.lock|\.svg|.node_modules|\.log|Binary file|CHANGELOG"
src/meltano/core/plugin_install_service.py: # TODO: use dataclasses.dataclass for this when 3.6 support is dropped
tests/meltano/cli/test_run.py: # or is hack to work around python 3.6 failures
tests/meltano/cli/test_run.py: # or is hack to work around python 3.6 failures
tests/meltano/cli/test_run.py: # or is hack to work around python 3.6 failures
tests/meltano/cli/test_run.py: # or is hack to work around python 3.6 failures
tests/meltano/cli/test_run.py: # or is hack to work around python 3.6 failures
# and heres some other code paths that reference 3.7
src/meltano/core/block/extract_load.py: with suppress(AttributeError): # `wait_closed` is Python 3.7+
src/meltano/core/logging/utils.py: with suppress(AttributeError): # `wait_closed` is Python 3.7+
src/meltano/core/runner/singer.py: with suppress(AttributeError): # `wait_closed` is Python 3.7+
src/meltano/core/utils/__init__.py: # and inspired by Python 3.7's `asyncio.run`
```
There's probably a few more here and there, but these are the most obvious ones that pop'd up in my quick searches.
| 4 |
7,603,319 | 100,664,094 |
2022-01-14 17:32:22.739
|
Update vuepress to support netlify deployment
|
Related to #3147 (confidential due to some provision/security related topics). We're migrating our docs site to netlify and will be serving docs from a new subdomain of https://docs.netlify.com.
Since we've long been using Netlify for doc previews on pull requests, Netlify is actually already configured to build on MR's, and deploy on merges to master - so we're already good to go as far as build/deploy goes.
The only real update required is to our vuepress structure and potentially some redirects on the netlify side.
| 4 |
7,603,319 | 100,613,872 |
2022-01-13 21:43:26.052
|
Follow-up from #2716: clickable urls in --help
|
The following discussion from !2492 should be addressed:
- [ ] @edgarrmondragon started a [discussion](https://gitlab.com/meltano/meltano/-/merge_requests/2492#note_809858053): (+3 comments)
> My only nit with these links is that `click` seems to like wrapping them and so clicking them doesn't work:
>
> ```console
> $ meltano environment --help
> Usage: meltano environment [OPTIONS] COMMAND [ARGS]...
>
> Manage Environments.
>
> Read more at https://meltano.com/docs/command-line-
> interface.html#environment
>
> Options:
> --database-uri TEXT System database URI.
> --help Show this message and exit.
>
> Commands:
> add Add a new environment.
> list List available environments.
> remove Remove an environment.
> ```
| 1 |
7,603,319 | 100,613,862 |
2022-01-13 21:42:09.876
|
Consider removing the `--verbose` option from the CLI since it's not used
|
The following discussion from !2492 should be addressed:
- [ ] @edgarrmondragon started a [discussion](https://gitlab.com/meltano/meltano/-/merge_requests/2492#note_809836105): (+2 comments)
> Should we remove this if it's not used?
| 1 |
7,603,319 | 100,612,090 |
2022-01-13 20:45:31.531
|
Documented environment alias `MELTANO_LOG_LEVEL` setting for cli.log_level is not used
|
The [documented alias `MELTANO_LOG_LEVEL`](https://meltano.com/docs/settings.html#cli-log-level) for log level is ignored by Meltano:
```console
$ meltano --version
meltano, version 1.90.1
$ MELTANO_LOG_LEVEL meltano invoke tap-gitlab
<no effect, same output>
$ MELTANO_CLI_LOG_LEVEL meltano invoke tap-gitlab
<debug output 👍>
```
The fix might be as simple as adding the `env_aliases` entry in [`setting.yml`](https://gitlab.com/meltano/meltano/-/blob/567b33a561b50863a2071dee913b810e04134f38/src/meltano/core/bundle/settings.yml#L29).
| 1 |
7,603,319 | 100,267,931 |
2022-01-07 17:54:54.909
|
Add support in `meltano run` for --dry
|
Undocumented, but supported, by elt is the ability to trigger a dry run to show what would happen if it were a real run.
* `meltano run --dry tap-gitlab...`
See https://gitlab.com/groups/meltano/-/epics/135#note_803736558 for more context
| 2 |
7,603,319 | 100,264,929 |
2022-01-07 16:44:05.351
|
Google Analytics Tracking For `meltano run`
|
It doesn't look like we have tracking set up for the new `meltano run` command. I'd be interested in seeing the initial usage there and what people are doing with it.
I assumed that any new CLI commands should have tracking so I'm labeling as a bug but I dont know if thats a fair assumptions.
| 2 |
7,603,319 | 100,114,167 |
2022-01-04 22:31:32.990
|
Setting config value with $ in the value fails due to Bash Expansion
|
Steps to reproduce
1. `meltano config target-snowflake set password "@$a"`
env file contains
`TARGET_SNOWFLAKE_PASSWORD="@"`
Should be set to `@$a`
--
Two reasons to do this in my opinion
1. Security - bash history shouldn't have your passwords inside of them
2. To prevent bash from expanding the values
I think we could do something like wait for STDIN data to come through to fix this (just like what happens if you run `cat` )
| 1 |
7,603,319 | 100,098,041 |
2022-01-04 18:56:33.989
|
Enable environment ENVARs to be set from command line
|
The following discussion from !2478 should be addressed:
- [ ] @pnadolny13 started a [discussion](https://gitlab.com/meltano/meltano/-/merge_requests/2478#note_801189369): (+2 comments)
> @aaronsteers @edgarrmondragon @pandemicsyn do any of you know if theres a way for me to do this with CLI commands? The [dbt bundle accesses](https://gitlab.com/meltano/files-dbt/-/blob/master/bundle/transform/profile/profiles.yml#L20) these settings as environment variables and the only way I could find to set these was to introduce the environments features and add the `env` key with local settings but I didnt see a CLI command for this so had to instruct users to manually update the yaml.
| 4 |
7,603,319 | 99,327,575 |
2021-12-18 07:08:26.555
|
Broken link in Environments page
|
The link pointing to the CLI reference is broken: https://meltano.com/docs/environments.html#commands-with-support-for-environment
| 1 |
7,603,319 | 99,302,641 |
2021-12-17 23:30:05.860
|
Bump pyhumps to v3.0.x
|
This should help a contributor address a bug they're seeing: https://gitlab.com/meltano/meltano/-/merge_requests/2406#note_729844878:
> this seems to be a bug in the old version of pyhumps that we're using:
>
> **pyhumps==1.2.2** (what he have)
>
> ```python
> >>> humps.decamelize("SOME_ENV_VALUE")
> 'som_e__en_v__valu_e'
> ```
>
> **pyhumps==3.0.2** (latest)
>
> ```python
> >>> humps.decamelize("SOME_ENV_VALUE")
> 'SOME_ENV_VALUE'
> ```
>
> So changing the version constraint in `pyproject` to `pyhumps = "^3.0.0"` should and running `poetry lock` should do it.
>
> We could also do it on our end by merging this change from a different MR and rebasing this one.
| 2 |
7,603,319 | 99,298,476 |
2021-12-17 22:43:20.299
|
Add Kubernetes Helm Chart to Documentation
|
Related to #2149.
| 2 |
7,603,319 | 99,283,509 |
2021-12-17 19:43:52.964
|
Support incremental jobs for `meltano run`
|
Spun out from #3094.
This items are necessary for incremental jobs.
1. Job ID support via `--job-id-prefix` xor `--job-id-name-pattern`
- May be sourced based on the environment name - or via a CLI flag for invocations which do not have `--environment` set. (https://gitlab.com/meltano/meltano/-/issues/2301#note_750941505)
1. Top-level `--no-state-update` to not save state. (https://gitlab.com/meltano/meltano/-/merge_requests/2432#note_757893658)
1. Top-level `--full-refresh` to ignore saved state (which forces a full refresh). (https://gitlab.com/meltano/meltano/-/merge_requests/2432#note_757893658)
Of these three, I think the first is highest priority, while the second and third could optionally be delayed. In special circumstances where advanced control over state is needed, users can still fall back to `meltano elt` to get those functions.
Proposed syntax:
Job ID:
Set it at the front of a run or automatically get one based on the tasks run.
* `meltano run --job-id=<id> tap-gitlab...`
State:
We _could_ set state requirements right after `run`. For many tools (dbt included) there is a concept of incremental vs full-refresh runs. Those commands could propagate down to the specific plugins. Default is an incremental run.
* `meltano run --no-state-update tap-gitab ...`
* `meltano run --full-refresh tap-gitlab ...`
| 8 |
7,603,319 | 99,179,624 |
2021-12-16 16:33:33.922
|
Inadvertent ELBContextBuilder use in meltano run, results in exception when tap run_discover is called
|
When running a tap that performs discovery with debug mode enabled, an exception is triggered because discovery mode in the plugin is looking for a debug logger but the base_output_logger isn't accessible:
```
Traceback (most recent call last):
File "/Users/fhines/projects/meltano/src/meltano/core/block/singer.py", line 261, in start
self.process_handle = await self.invoker.invoke_async(
File "/Users/fhines/projects/meltano/src/meltano/core/plugin_invoker.py", line 277, in invoke_async
async with self._invoke(*args, **kwargs) as (
File "/Users/fhines/.pyenv/versions/3.8.12/envs/melty-3.8.12/lib/python3.8/site-packages/async_generator/_util.py", line 34, in __aenter__
return await self._agen.asend(None)
File "/Users/fhines/projects/meltano/src/meltano/core/plugin_invoker.py", line 262, in _invoke
async with self.plugin.trigger_hooks("invoke", self, args):
File "/Users/fhines/.pyenv/versions/3.8.12/envs/melty-3.8.12/lib/python3.8/site-packages/async_generator/_util.py", line 34, in __aenter__
return await self._agen.asend(None)
File "/Users/fhines/projects/meltano/src/meltano/core/behavior/hookable.py", line 87, in trigger_hooks
await self.__class__.trigger(self, f"before_{hook_name}", *args, **kwargs)
File "/Users/fhines/projects/meltano/src/meltano/core/behavior/hookable.py", line 115, in trigger
raise err
File "/Users/fhines/projects/meltano/src/meltano/core/behavior/hookable.py", line 107, in trigger
await hook_func(target, *args, **kwargs)
File "/Users/fhines/projects/meltano/src/meltano/core/plugin/singer/tap.py", line 270, in discover_catalog_hook
await self.discover_catalog(plugin_invoker)
File "/Users/fhines/projects/meltano/src/meltano/core/plugin/singer/tap.py", line 315, in discover_catalog
await self.run_discovery(plugin_invoker, catalog_path)
File "/Users/fhines/projects/meltano/src/meltano/core/plugin/singer/tap.py", line 363, in run_discovery
_debug_logging_handler(self.name, plugin_invoker, handle.stderr)
File "/Users/fhines/projects/meltano/src/meltano/core/plugin/singer/tap.py", line 52, in _debug_logging_handler
if not plugin_invoker.context or not plugin_invoker.context.base_output_logger:
AttributeError: 'ELBContextBuilder' object has no attribute 'base_output_logger'
```
| 2 |
7,603,319 | 99,111,820 |
2021-12-15 21:27:47.594
|
Discuss: what to call "inline transformers" aka "stream maps" aka "map transforms"
|
In preparation for #2299 (and/or the similar #2300), we should discuss what to call these things. We especially should consider how the naming decisions will impact (1) the new user experience and (2) possibly overlap or confusion regarding other existing plugins and interactions.
## Background Context
### History of "Stream Maps" naming within the SDK
When developing the Stream Maps feature in the SDK, one very important paradigm which allowed that effort to move forward was the concept of the "Map" process of a "Map-Reduce" paradigm. While the word "tranformation" can mean anything in the set of operations {Map/Reduce/Lookup/Filter/etc.}, we are limited in an inline capacity to basically these two: Map and Filter. (Lookups are possible in an inline capacity but they are very different than lookups which occur in SQL, and as such they are extremely expensive and require a robust caching strategy that is far beyond our scope.)
So, "Stream Maps" naming or "Map Transforms" naming was intended to highlight the focus on operations which can be performed scalably in an _inline_ capacity. **Unlike "true" transform tools like dbt, we do not have all of the data available before we execute; we have only one record at a time and we must be able to treat each record in isolation before passing it downstream (or not).**
Legacy ETL tools tried to do any and all type of "big T" transform functions `{Map/Reduce/Lookup/Filter/etc.}` before passing data downstream to the target, which although more rare now is still a problem in the industry using existing tools like Informatica, SSIS, Alteryx, Azure Data Factory, etc. This "traditional/legacy ETL" approach is an anti-pattern for very good reason and we should be very clear we are _not_ supporting it.
### Why not just call them "transformations" or "transforms"
If applying a little "m" for a lightweight inline map transform, `ELT` becomes `EmLT`. Note the little `m` and the big `T` are entirely different capabilities, with different performance constraints and resource availability. We _do not_ want to confuse users by saying this is okay: `ETLT` - this would be a huge step backwards in terms of DataOps best practices, and would cause detrimental confusion to end users if they think there's no difference between "transform" in the middle of EL and the "transform" in the SQL/dbt layer.
When we speak of these conversationally, we use the word "transformations" often. However, the name collision with dbt (the *true* "T" in "ELT" pipeline, is extremely problematic - the `m` and `T` perform very different functions, with different physics constraints, latency expectations, and host server hardware profiles. They also have very different risk profiles for data loss in case of code errors or other unexpected failure.
## Option A: `mappers` are a new plugin type, with associated `mappings` entries in `meltano.yml`
Similar to as written up in #2299:
```shell
meltano add mapper meltano-map-transform
meltano add mapper pipelinewise-transform-field
```
```yml
# meltano.yml
mappers:
- name: meltano-map-transform
pip_url: meltano-map-transform
config: # Optionally, a default config.
# ...
- name: pipelinewise-transform-field
pip_url: pipelinewise-transform-field
extractors:
- name: tap-gitlab
# ...
mappings:
- name: pii-hasher # The name of the map transform to apply.
mapper: meltano-map-transform # The mapper plugin to use.
config: # What will be sent to the transformer in a config.json file.
stream_maps:
customers:
id_hashed: md5(record['id'])
id: None
```
Option B: Transformers are of a `type`: `streaming` or `build`
Another (admittedly less preferred) option would be to allow `mappers` into the family of `transformer` utilities but with the addition of a new `type` attribute which specifically distinguishes them from other transformation types.
The `dbt` transformer would be something to indicate it has all data landed in the target upfront, such as `build` or `post-load`.
The `mapper` transformers would have some `type` value indicating their place as map-transforms and not full fledge data build/transform/aggregation tools. Possible values for `type` could be: `streaming`, `inline`, `mapper`, or `stream_map`.
cc @tayloramurphy, @edgarrmondragon, @pandemicsyn, @kgpayne
| 4 |
7,603,319 | 99,104,978 |
2021-12-15 18:28:30.924
|
Add a default Environment when `meltano init` is invoked
|
### Problem to solve
Increase awareness and use of the [`Environments` feature](https://gitlab.com/meltano/meltano/-/issues/2869) by including a default `environments: ...` entry in `meltano.yml` for new projects.
### Target audience
Users starting fresh new Meltano projects.
### Further details
(Include use cases, benefits, and/or goals)
- New projects get the benefits of having at least one declared environment in `meltano.yml`.
### Proposal
An initial set of environments that might be sensible is:
```yaml
environments:
- name: dev
config:
plugins: {}
env: {}
- name: prod
config:
plugins: {}
env: {}
```
### What does success look like, and how can we measure that?
We should see an increased use of `environments` for new projects.
### Regression test
(Ensure the feature doesn't cause any regressions)
- [ ] Write adequate test cases and submit test results
- [ ] Test results should be reviewed by a person from the team
### Links / references
| 2 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.