handle_queue) {\\n h = uv__queue_data(q, uv_handle_t, handle_queue);\\n \\n@@ -1054,11 +1049,3 @@ uint64_t uv_metrics_idle_time(uv_loop_t* loop) {\\n idle_time += uv_hrtime() - entry_time;\\n return idle_time;\\n }\\n-\\n-/* OS390 needs a different implementation, already provided in os390.c. */\\n-#ifndef __MVS__\\n-void uv_free_interface_addresses(uv_interface_address_t* addresses,\\n- int count) {\\n- uv__free(addresses);\\n-}\\n-#endif /* !__MVS__ */\",\n \"additions\": 3,\n \"deletions\": 16\n },\n {\n \"filename\": \"deps/uv/src/uv-common.h\",\n \"patch\": \"@@ -90,6 +90,7 @@ enum {\\n UV_HANDLE_LISTENING = 0x00000040,\\n UV_HANDLE_CONNECTION = 0x00000080,\\n UV_HANDLE_SHUT = 0x00000200,\\n+ UV_HANDLE_READ_PARTIAL = 0x00000400,\\n UV_HANDLE_READ_EOF = 0x00000800,\\n \\n /* Used by streams and UDP handles. */\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/src/win/async.c\",\n \"patch\": \"@@ -23,28 +23,10 @@\\n \\n #include \\\"uv.h\\\"\\n #include \\\"internal.h\\\"\\n+#include \\\"atomicops-inl.h\\\"\\n #include \\\"handle-inl.h\\\"\\n #include \\\"req-inl.h\\\"\\n \\n-#ifdef _MSC_VER /* MSVC */\\n-\\n-/* _InterlockedOr8 is supported by MSVC on x32 and x64. It is slightly less\\n- * efficient than InterlockedExchange, but InterlockedExchange8 does not exist,\\n- * and interlocked operations on larger targets might require the target to be\\n- * aligned. */\\n-#pragma intrinsic(_InterlockedOr8)\\n-\\n-static char uv__atomic_exchange_set(char volatile* target) {\\n- return _InterlockedOr8(target, 1);\\n-}\\n-\\n-#else /* GCC, Clang in mingw mode */\\n-\\n-static char uv__atomic_exchange_set(char volatile* target) {\\n- return __sync_fetch_and_or(target, 1);\\n-}\\n-\\n-#endif /* _MSC_VER */\\n \\n void uv__async_endgame(uv_loop_t* loop, uv_async_t* handle) {\\n if (handle->flags & UV_HANDLE_CLOSING &&\",\n \"additions\": 1,\n \"deletions\": 19\n },\n {\n \"filename\": \"deps/uv/src/win/atomicops-inl.h\",\n \"patch\": \"@@ -0,0 +1,61 @@\\n+/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.\\n+ *\\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\\n+ * of this software and associated documentation files (the \\\"Software\\\"), to\\n+ * deal in the Software without restriction, including without limitation the\\n+ * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or\\n+ * sell copies of the Software, and to permit persons to whom the Software is\\n+ * furnished to do so, subject to the following conditions:\\n+ *\\n+ * The above copyright notice and this permission notice shall be included in\\n+ * all copies or substantial portions of the Software.\\n+ *\\n+ * THE SOFTWARE IS PROVIDED \\\"AS IS\\\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING\\n+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS\\n+ * IN THE SOFTWARE.\\n+ */\\n+\\n+#ifndef UV_WIN_ATOMICOPS_INL_H_\\n+#define UV_WIN_ATOMICOPS_INL_H_\\n+\\n+#include \\\"uv.h\\\"\\n+#include \\\"internal.h\\\"\\n+\\n+\\n+/* Atomic set operation on char */\\n+#ifdef _MSC_VER /* MSVC */\\n+\\n+/* _InterlockedOr8 is supported by MSVC on x32 and x64. It is slightly less\\n+ * efficient than InterlockedExchange, but InterlockedExchange8 does not exist,\\n+ * and interlocked operations on larger targets might require the target to be\\n+ * aligned. */\\n+#pragma intrinsic(_InterlockedOr8)\\n+\\n+static char INLINE uv__atomic_exchange_set(char volatile* target) {\\n+ return _InterlockedOr8(target, 1);\\n+}\\n+\\n+#else /* GCC, Clang in mingw mode */\\n+\\n+static inline char uv__atomic_exchange_set(char volatile* target) {\\n+#if defined(__i386__) || defined(__x86_64__)\\n+ /* Mingw-32 version, hopefully this works for 64-bit gcc as well. */\\n+ const char one = 1;\\n+ char old_value;\\n+ __asm__ __volatile__ (\\\"lock xchgb %0, %1\\\\n\\\\t\\\"\\n+ : \\\"=r\\\"(old_value), \\\"=m\\\"(*target)\\n+ : \\\"0\\\"(one), \\\"m\\\"(*target)\\n+ : \\\"memory\\\");\\n+ return old_value;\\n+#else\\n+ return __sync_fetch_and_or(target, 1);\\n+#endif\\n+}\\n+\\n+#endif\\n+\\n+#endif /* UV_WIN_ATOMICOPS_INL_H_ */\",\n \"additions\": 61,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/src/win/core.c\",\n \"patch\": \"@@ -428,7 +428,6 @@ static void uv__poll(uv_loop_t* loop, DWORD timeout) {\\n BOOL success;\\n uv_req_t* req;\\n OVERLAPPED_ENTRY overlappeds[128];\\n- OVERLAPPED* overlapped;\\n ULONG count;\\n ULONG i;\\n int repeat;\\n@@ -492,8 +491,7 @@ static void uv__poll(uv_loop_t* loop, DWORD timeout) {\\n if (actual_timeout == 0)\\n uv__metrics_inc_events_waiting(loop, 1);\\n \\n- overlapped = overlappeds[i].lpOverlapped;\\n- req = container_of(overlapped, uv_req_t, u.io.overlapped);\\n+ req = uv__overlapped_to_req(overlappeds[i].lpOverlapped);\\n uv__insert_pending_req(loop, req);\\n }\\n }\\n@@ -527,177 +525,6 @@ static void uv__poll(uv_loop_t* loop, DWORD timeout) {\\n }\\n \\n \\n-#define DELEGATE_STREAM_REQ(loop, req, method, handle_at) \\\\\\n- do { \\\\\\n- switch (((uv_handle_t*) (req)->handle_at)->type) { \\\\\\n- case UV_TCP: \\\\\\n- uv__process_tcp_##method##_req(loop, \\\\\\n- (uv_tcp_t*) ((req)->handle_at), \\\\\\n- req); \\\\\\n- break; \\\\\\n- \\\\\\n- case UV_NAMED_PIPE: \\\\\\n- uv__process_pipe_##method##_req(loop, \\\\\\n- (uv_pipe_t*) ((req)->handle_at), \\\\\\n- req); \\\\\\n- break; \\\\\\n- \\\\\\n- case UV_TTY: \\\\\\n- uv__process_tty_##method##_req(loop, \\\\\\n- (uv_tty_t*) ((req)->handle_at), \\\\\\n- req); \\\\\\n- break; \\\\\\n- \\\\\\n- default: \\\\\\n- assert(0); \\\\\\n- } \\\\\\n- } while (0)\\n-\\n-\\n-static void uv__process_reqs(uv_loop_t* loop) {\\n- uv_req_t* req;\\n- uv_req_t* first;\\n- uv_req_t* next;\\n-\\n- if (loop->pending_reqs_tail == NULL)\\n- return;\\n-\\n- first = loop->pending_reqs_tail->next_req;\\n- next = first;\\n- loop->pending_reqs_tail = NULL;\\n-\\n- while (next != NULL) {\\n- req = next;\\n- next = req->next_req != first ? req->next_req : NULL;\\n-\\n- switch (req->type) {\\n- case UV_READ:\\n- DELEGATE_STREAM_REQ(loop, req, read, data);\\n- break;\\n-\\n- case UV_WRITE:\\n- DELEGATE_STREAM_REQ(loop, (uv_write_t*) req, write, handle);\\n- break;\\n-\\n- case UV_ACCEPT:\\n- DELEGATE_STREAM_REQ(loop, req, accept, data);\\n- break;\\n-\\n- case UV_CONNECT:\\n- DELEGATE_STREAM_REQ(loop, (uv_connect_t*) req, connect, handle);\\n- break;\\n-\\n- case UV_SHUTDOWN:\\n- DELEGATE_STREAM_REQ(loop, (uv_shutdown_t*) req, shutdown, handle);\\n- break;\\n-\\n- case UV_UDP_RECV:\\n- uv__process_udp_recv_req(loop, (uv_udp_t*) req->data, req);\\n- break;\\n-\\n- case UV_UDP_SEND:\\n- uv__process_udp_send_req(loop,\\n- ((uv_udp_send_t*) req)->handle,\\n- (uv_udp_send_t*) req);\\n- break;\\n-\\n- case UV_WAKEUP:\\n- uv__process_async_wakeup_req(loop, (uv_async_t*) req->data, req);\\n- break;\\n-\\n- case UV_SIGNAL_REQ:\\n- uv__process_signal_req(loop, (uv_signal_t*) req->data, req);\\n- break;\\n-\\n- case UV_POLL_REQ:\\n- uv__process_poll_req(loop, (uv_poll_t*) req->data, req);\\n- break;\\n-\\n- case UV_PROCESS_EXIT:\\n- uv__process_proc_exit(loop, (uv_process_t*) req->data);\\n- break;\\n-\\n- case UV_FS_EVENT_REQ:\\n- uv__process_fs_event_req(loop, req, (uv_fs_event_t*) req->data);\\n- break;\\n-\\n- default:\\n- assert(0);\\n- }\\n- }\\n-}\\n-\\n-#undef DELEGATE_STREAM_REQ\\n-\\n-static void uv__process_endgames(uv_loop_t* loop) {\\n- uv_handle_t* handle;\\n-\\n- while (loop->endgame_handles) {\\n- handle = loop->endgame_handles;\\n- loop->endgame_handles = handle->endgame_next;\\n-\\n- handle->flags &= ~UV_HANDLE_ENDGAME_QUEUED;\\n-\\n- switch (handle->type) {\\n- case UV_TCP:\\n- uv__tcp_endgame(loop, (uv_tcp_t*) handle);\\n- break;\\n-\\n- case UV_NAMED_PIPE:\\n- uv__pipe_endgame(loop, (uv_pipe_t*) handle);\\n- break;\\n-\\n- case UV_TTY:\\n- uv__tty_endgame(loop, (uv_tty_t*) handle);\\n- break;\\n-\\n- case UV_UDP:\\n- uv__udp_endgame(loop, (uv_udp_t*) handle);\\n- break;\\n-\\n- case UV_POLL:\\n- uv__poll_endgame(loop, (uv_poll_t*) handle);\\n- break;\\n-\\n- case UV_TIMER:\\n- uv__timer_close((uv_timer_t*) handle);\\n- uv__handle_close(handle);\\n- break;\\n-\\n- case UV_PREPARE:\\n- case UV_CHECK:\\n- case UV_IDLE:\\n- uv__loop_watcher_endgame(loop, handle);\\n- break;\\n-\\n- case UV_ASYNC:\\n- uv__async_endgame(loop, (uv_async_t*) handle);\\n- break;\\n-\\n- case UV_SIGNAL:\\n- uv__signal_endgame(loop, (uv_signal_t*) handle);\\n- break;\\n-\\n- case UV_PROCESS:\\n- uv__process_endgame(loop, (uv_process_t*) handle);\\n- break;\\n-\\n- case UV_FS_EVENT:\\n- uv__fs_event_endgame(loop, (uv_fs_event_t*) handle);\\n- break;\\n-\\n- case UV_FS_POLL:\\n- uv__fs_poll_endgame(loop, (uv_fs_poll_t*) handle);\\n- break;\\n-\\n- default:\\n- assert(0);\\n- break;\\n- }\\n- }\\n-}\\n-\\n-\\n int uv_run(uv_loop_t *loop, uv_run_mode mode) {\\n DWORD timeout;\\n int r;\\n@@ -854,26 +681,3 @@ int uv__getsockpeername(const uv_handle_t* handle,\\n \\n return 0;\\n }\\n-\\n-void uv__insert_pending_req(uv_loop_t* loop, uv_req_t* req) {\\n- req->next_req = NULL;\\n- if (loop->pending_reqs_tail) {\\n-#ifdef _DEBUG\\n- /* Ensure the request is not already in the queue, or the queue\\n- * will get corrupted.\\n- */\\n- uv_req_t* current = loop->pending_reqs_tail;\\n- do {\\n- assert(req != current);\\n- current = current->next_req;\\n- } while (current != loop->pending_reqs_tail);\\n-#endif\\n-\\n- req->next_req = loop->pending_reqs_tail->next_req;\\n- loop->pending_reqs_tail->next_req = req;\\n- loop->pending_reqs_tail = req;\\n- } else {\\n- req->next_req = req;\\n- loop->pending_reqs_tail = req;\\n- }\\n-}\",\n \"additions\": 1,\n \"deletions\": 197\n },\n {\n \"filename\": \"deps/uv/src/win/fs-event.c\",\n \"patch\": \"@@ -158,14 +158,14 @@ int uv_fs_event_start(uv_fs_event_t* handle,\\n const char* path,\\n unsigned int flags) {\\n int is_path_dir;\\n- DWORD last_error;\\n- WCHAR* dir, *pathw = NULL;\\n+ size_t size;\\n+ DWORD attr, last_error;\\n+ WCHAR* dir = NULL, *dir_to_watch, *pathw = NULL;\\n DWORD short_path_buffer_len;\\n WCHAR *short_path_buffer;\\n- WCHAR* short_path = NULL;\\n- HANDLE file_handle = INVALID_HANDLE_VALUE;\\n- BY_HANDLE_FILE_INFORMATION info;\\n+ WCHAR* short_path, *long_path;\\n \\n+ short_path = NULL;\\n if (uv__is_active(handle))\\n return UV_EINVAL;\\n \\n@@ -181,26 +181,43 @@ int uv_fs_event_start(uv_fs_event_t* handle,\\n if (last_error)\\n goto error_uv;\\n \\n- file_handle = CreateFileW(pathw,\\n- FILE_LIST_DIRECTORY,\\n- FILE_SHARE_READ|FILE_SHARE_DELETE|FILE_SHARE_WRITE,\\n- NULL,\\n- OPEN_EXISTING,\\n- FILE_FLAG_BACKUP_SEMANTICS|FILE_FLAG_OVERLAPPED,\\n- NULL);\\n- if (file_handle == INVALID_HANDLE_VALUE) {\\n+ /* Determine whether path is a file or a directory. */\\n+ attr = GetFileAttributesW(pathw);\\n+ if (attr == INVALID_FILE_ATTRIBUTES) {\\n last_error = GetLastError();\\n goto error;\\n }\\n \\n- if (!GetFileInformationByHandle(file_handle, &info)) {\\n- last_error = GetLastError();\\n- goto error;\\n- }\\n+ is_path_dir = (attr & FILE_ATTRIBUTE_DIRECTORY) ? 1 : 0;\\n+\\n+ if (is_path_dir) {\\n+ /* path is a directory, so that's the directory that we will watch. */\\n \\n- is_path_dir = (info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) ? 1 : 0;\\n+ /* Convert to long path. */\\n+ size = GetLongPathNameW(pathw, NULL, 0);\\n \\n- if (!is_path_dir) {\\n+ if (size) {\\n+ long_path = (WCHAR*)uv__malloc(size * sizeof(WCHAR));\\n+ if (!long_path) {\\n+ uv_fatal_error(ERROR_OUTOFMEMORY, \\\"uv__malloc\\\");\\n+ }\\n+\\n+ size = GetLongPathNameW(pathw, long_path, size);\\n+ if (size) {\\n+ long_path[size] = '\\\\0';\\n+ } else {\\n+ uv__free(long_path);\\n+ long_path = NULL;\\n+ }\\n+\\n+ if (long_path) {\\n+ uv__free(pathw);\\n+ pathw = long_path;\\n+ }\\n+ }\\n+\\n+ dir_to_watch = pathw;\\n+ } else {\\n /*\\n * path is a file. So we split path into dir & file parts, and\\n * watch the dir directory.\\n@@ -235,50 +252,28 @@ int uv_fs_event_start(uv_fs_event_t* handle,\\n goto error;\\n }\\n \\n+ dir_to_watch = dir;\\n uv__free(short_path);\\n short_path = NULL;\\n uv__free(pathw);\\n pathw = NULL;\\n+ }\\n \\n- /* Open the containing directory and watch that instead. Events for\\n- * other files are filtered out in uv__process_fs_event_req().\\n- * Not super efficient but c'est ça.\\n- */\\n- CloseHandle(file_handle);\\n- file_handle = CreateFileW(dir,\\n- FILE_LIST_DIRECTORY,\\n- FILE_SHARE_READ|FILE_SHARE_DELETE|FILE_SHARE_WRITE,\\n- NULL,\\n- OPEN_EXISTING,\\n- FILE_FLAG_BACKUP_SEMANTICS|FILE_FLAG_OVERLAPPED,\\n- NULL);\\n+ handle->dir_handle = CreateFileW(dir_to_watch,\\n+ FILE_LIST_DIRECTORY,\\n+ FILE_SHARE_READ | FILE_SHARE_DELETE |\\n+ FILE_SHARE_WRITE,\\n+ NULL,\\n+ OPEN_EXISTING,\\n+ FILE_FLAG_BACKUP_SEMANTICS |\\n+ FILE_FLAG_OVERLAPPED,\\n+ NULL);\\n+\\n+ if (dir) {\\n uv__free(dir);\\n dir = NULL;\\n- if (file_handle == INVALID_HANDLE_VALUE) {\\n- last_error = GetLastError();\\n- goto error;\\n- }\\n-\\n- if (!GetFileInformationByHandle(file_handle, &info)) {\\n- last_error = GetLastError();\\n- goto error;\\n- }\\n-\\n- /* Race with another process: directory foo in foo/bar was replaced\\n- * with a file. Bail out with an error, we're not recursing upwards.\\n- */\\n- if (!(info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {\\n- /* TODO(bnoordhuis) ERROR_DIRECTORY is translated to UV_ENOENT,\\n- * there's currently nothing that maps to UV_ENOTDIR.\\n- */\\n- last_error = ERROR_DIRECTORY;\\n- goto error;\\n- }\\n }\\n \\n- handle->dir_handle = file_handle;\\n- file_handle = INVALID_HANDLE_VALUE;\\n-\\n if (handle->dir_handle == INVALID_HANDLE_VALUE) {\\n last_error = GetLastError();\\n goto error;\\n@@ -330,11 +325,6 @@ int uv_fs_event_start(uv_fs_event_t* handle,\\n last_error = uv_translate_sys_error(last_error);\\n \\n error_uv:\\n- if (file_handle != INVALID_HANDLE_VALUE) {\\n- CloseHandle(file_handle);\\n- file_handle = INVALID_HANDLE_VALUE;\\n- }\\n-\\n if (handle->path) {\\n uv__free(handle->path);\\n handle->path = NULL;\",\n \"additions\": 49,\n \"deletions\": 59\n },\n {\n \"filename\": \"deps/uv/src/win/fs-fd-hash-inl.h\",\n \"patch\": \"@@ -69,11 +69,11 @@ struct uv__fd_hash_bucket_s {\\n static uv_mutex_t uv__fd_hash_mutex;\\n \\n static struct uv__fd_hash_entry_group_s\\n- uv__fd_hash_entry_initial[UV__FD_HASH_SIZE];\\n+ uv__fd_hash_entry_initial[UV__FD_HASH_SIZE * UV__FD_HASH_GROUP_SIZE];\\n static struct uv__fd_hash_bucket_s uv__fd_hash[UV__FD_HASH_SIZE];\\n \\n \\n-static void uv__fd_hash_init(void) {\\n+INLINE static void uv__fd_hash_init(void) {\\n size_t i;\\n int err;\\n \\n@@ -82,9 +82,10 @@ static void uv__fd_hash_init(void) {\\n uv_fatal_error(err, \\\"uv_mutex_init\\\");\\n }\\n \\n- for (i = 0; i < ARRAY_SIZE(uv__fd_hash); i++) {\\n+ for (i = 0; i < ARRAY_SIZE(uv__fd_hash); ++i) {\\n uv__fd_hash[i].size = 0;\\n- uv__fd_hash[i].data = &uv__fd_hash_entry_initial[i];\\n+ uv__fd_hash[i].data =\\n+ uv__fd_hash_entry_initial + i * UV__FD_HASH_GROUP_SIZE;\\n }\\n }\\n \\n@@ -118,7 +119,7 @@ static void uv__fd_hash_init(void) {\\n FIND_IN_GROUP_PTR(UV__FD_HASH_GROUP_SIZE); \\\\\\n } while (0)\\n \\n-static int uv__fd_hash_get(int fd, struct uv__fd_info_s* info) {\\n+INLINE static int uv__fd_hash_get(int fd, struct uv__fd_info_s* info) {\\n FIND_COMMON_VARIABLES\\n \\n uv_mutex_lock(&uv__fd_hash_mutex);\\n@@ -133,7 +134,7 @@ static int uv__fd_hash_get(int fd, struct uv__fd_info_s* info) {\\n return entry_ptr != NULL;\\n }\\n \\n-static void uv__fd_hash_add(int fd, struct uv__fd_info_s* info) {\\n+INLINE static void uv__fd_hash_add(int fd, struct uv__fd_info_s* info) {\\n FIND_COMMON_VARIABLES\\n \\n uv_mutex_lock(&uv__fd_hash_mutex);\\n@@ -163,7 +164,7 @@ static void uv__fd_hash_add(int fd, struct uv__fd_info_s* info) {\\n uv_mutex_unlock(&uv__fd_hash_mutex);\\n }\\n \\n-static int uv__fd_hash_remove(int fd, struct uv__fd_info_s* info) {\\n+INLINE static int uv__fd_hash_remove(int fd, struct uv__fd_info_s* info) {\\n FIND_COMMON_VARIABLES\\n \\n uv_mutex_lock(&uv__fd_hash_mutex);\",\n \"additions\": 8,\n \"deletions\": 7\n },\n {\n \"filename\": \"deps/uv/src/win/fs.c\",\n \"patch\": \"@@ -167,10 +167,9 @@ typedef enum {\\n FS__STAT_PATH_TRY_SLOW\\n } fs__stat_path_return_t;\\n \\n-static void fs__stat_assign_statbuf_null(uv_stat_t* statbuf);\\n-static void fs__stat_assign_statbuf(uv_stat_t* statbuf,\\n- FILE_STAT_BASIC_INFORMATION stat_info,\\n- int do_lstat);\\n+INLINE static void fs__stat_assign_statbuf_null(uv_stat_t* statbuf);\\n+INLINE static void fs__stat_assign_statbuf(uv_stat_t* statbuf,\\n+ FILE_STAT_BASIC_INFORMATION stat_info, int do_lstat);\\n \\n \\n void uv__fs_init(void) {\\n@@ -183,9 +182,9 @@ void uv__fs_init(void) {\\n }\\n \\n \\n-static int fs__readlink_handle(HANDLE handle,\\n- char** target_ptr,\\n- size_t* target_len_ptr) {\\n+INLINE static int fs__readlink_handle(HANDLE handle,\\n+ char** target_ptr,\\n+ size_t* target_len_ptr) {\\n char buffer[MAXIMUM_REPARSE_DATA_BUFFER_SIZE];\\n REPARSE_DATA_BUFFER* reparse_data = (REPARSE_DATA_BUFFER*) buffer;\\n WCHAR* w_target;\\n@@ -247,32 +246,6 @@ static int fs__readlink_handle(HANDLE handle,\\n }\\n }\\n \\n- } else if (reparse_data->ReparseTag == IO_REPARSE_TAG_LX_SYMLINK) {\\n- /* Real (Linux) symlink */\\n- char* buffer;\\n- char* target;\\n- size_t target_len;\\n-\\n- target_len = (reparse_data->ReparseDataLength -\\n- sizeof(ULONG)); /* Version field */\\n- buffer = (char*) reparse_data->LinuxSymbolicLinkReparseBuffer.PathBuffer;\\n-\\n- if (target_len_ptr != NULL) {\\n- *target_len_ptr = target_len;\\n- }\\n-\\n- if (target_ptr != NULL) {\\n- assert(*target_ptr == NULL);\\n- target = uv__malloc(target_len + 1);\\n- if (target == NULL) {\\n- return UV_ENOMEM;\\n- }\\n- memcpy(target, buffer, target_len);\\n- target[target_len] = '\\\\0';\\n- *target_ptr = target;\\n- }\\n- return 0;\\n-\\n } else if (reparse_data->ReparseTag == IO_REPARSE_TAG_MOUNT_POINT) {\\n /* Junction. */\\n w_target = reparse_data->MountPointReparseBuffer.PathBuffer +\\n@@ -346,10 +319,8 @@ static int fs__readlink_handle(HANDLE handle,\\n }\\n \\n \\n-static int fs__capture_path(uv_fs_t* req,\\n- const char* path,\\n- const char* new_path,\\n- const int copy_path) {\\n+INLINE static int fs__capture_path(uv_fs_t* req, const char* path,\\n+ const char* new_path, const int copy_path) {\\n WCHAR* buf;\\n WCHAR* pos;\\n size_t buf_sz = 0;\\n@@ -423,10 +394,8 @@ static int fs__capture_path(uv_fs_t* req,\\n }\\n \\n \\n-static void uv__fs_req_init(uv_loop_t* loop,\\n- uv_fs_t* req,\\n- uv_fs_type fs_type,\\n- const uv_fs_cb cb) {\\n+INLINE static void uv__fs_req_init(uv_loop_t* loop, uv_fs_t* req,\\n+ uv_fs_type fs_type, const uv_fs_cb cb) {\\n uv__once_init();\\n UV_REQ_INIT(req, UV_FS);\\n req->loop = loop;\\n@@ -1130,15 +1099,15 @@ void fs__write(uv_fs_t* req) {\\n static void fs__unlink_rmdir(uv_fs_t* req, BOOL isrmdir) {\\n const WCHAR* pathw = req->file.pathw;\\n HANDLE handle;\\n- FILE_BASIC_INFO info;\\n+ BY_HANDLE_FILE_INFORMATION info;\\n FILE_DISPOSITION_INFORMATION disposition;\\n FILE_DISPOSITION_INFORMATION_EX disposition_ex;\\n IO_STATUS_BLOCK iosb;\\n NTSTATUS status;\\n DWORD error;\\n \\n handle = CreateFileW(pathw,\\n- FILE_READ_ATTRIBUTES | DELETE,\\n+ FILE_READ_ATTRIBUTES | FILE_WRITE_ATTRIBUTES | DELETE,\\n FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,\\n NULL,\\n OPEN_EXISTING,\\n@@ -1150,27 +1119,27 @@ static void fs__unlink_rmdir(uv_fs_t* req, BOOL isrmdir) {\\n return;\\n }\\n \\n- if (!GetFileInformationByHandleEx(handle, FileBasicInfo, &info, sizeof info)) {\\n+ if (!GetFileInformationByHandle(handle, &info)) {\\n SET_REQ_WIN32_ERROR(req, GetLastError());\\n CloseHandle(handle);\\n return;\\n }\\n \\n- if (isrmdir && !(info.FileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {\\n+ if (isrmdir && !(info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {\\n /* Error if we're in rmdir mode but it is not a dir.\\n * TODO: change it to UV_NOTDIR in v2. */\\n SET_REQ_UV_ERROR(req, UV_ENOENT, ERROR_DIRECTORY);\\n CloseHandle(handle);\\n return;\\n }\\n \\n- if (!isrmdir && (info.FileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {\\n+ if (!isrmdir && (info.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY)) {\\n /* If not explicitly allowed, do not allow deletion of directories, unless\\n * it is a symlink. When the path refers to a non-symlink directory, report\\n * EPERM as mandated by POSIX.1. */\\n \\n /* Check if it is a reparse point. If it's not, it's a normal directory. */\\n- if (!(info.FileAttributes & FILE_ATTRIBUTE_REPARSE_POINT)) {\\n+ if (!(info.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT)) {\\n SET_REQ_WIN32_ERROR(req, ERROR_ACCESS_DENIED);\\n CloseHandle(handle);\\n return;\\n@@ -1209,37 +1178,18 @@ static void fs__unlink_rmdir(uv_fs_t* req, BOOL isrmdir) {\\n error == ERROR_INVALID_PARAMETER /* pre Windows 10 error */ ||\\n error == ERROR_INVALID_FUNCTION /* pre Windows 10 1607 error */) {\\n /* posix delete not supported so try fallback */\\n- if (info.FileAttributes & FILE_ATTRIBUTE_READONLY) {\\n+ if (info.dwFileAttributes & FILE_ATTRIBUTE_READONLY) {\\n /* Remove read-only attribute */\\n FILE_BASIC_INFORMATION basic = { 0 };\\n \\n- /* We opened the handle above without FILE_WRITE_ATTRIBUTES access, which\\n- * is not required in the happy path. On windows, it would probably\\n- * be ok to ask for them anyway, but Wine has a bug that causes such calls\\n- * to fail (https://bugs.winehq.org/show_bug.cgi?id=50771). To work around\\n- * this bug, we re-open the handle here */\\n- HANDLE write_attributes_handle;\\n-\\n- basic.FileAttributes = (info.FileAttributes & ~FILE_ATTRIBUTE_READONLY) |\\n+ basic.FileAttributes = (info.dwFileAttributes & ~FILE_ATTRIBUTE_READONLY) |\\n FILE_ATTRIBUTE_ARCHIVE;\\n \\n- write_attributes_handle = ReOpenFile(handle, FILE_WRITE_ATTRIBUTES,\\n- FILE_SHARE_READ | FILE_SHARE_WRITE |\\n- FILE_SHARE_DELETE,\\n- FILE_FLAG_OPEN_REPARSE_POINT |\\n- FILE_FLAG_BACKUP_SEMANTICS);\\n- if (write_attributes_handle == INVALID_HANDLE_VALUE) {\\n- SET_REQ_WIN32_ERROR(req, GetLastError());\\n- CloseHandle(handle);\\n- return;\\n- }\\n-\\n- status = pNtSetInformationFile(write_attributes_handle,\\n+ status = pNtSetInformationFile(handle,\\n &iosb,\\n &basic,\\n sizeof basic,\\n FileBasicInformation);\\n- CloseHandle(write_attributes_handle);\\n if (!NT_SUCCESS(status)) {\\n SET_REQ_WIN32_ERROR(req, pRtlNtStatusToDosError(status));\\n CloseHandle(handle);\\n@@ -1314,7 +1264,7 @@ void fs__mktemp(uv_fs_t* req, uv__fs_mktemp_func func) {\\n \\n tries = TMP_MAX;\\n do {\\n- if (uv__random_winrandom(&v, sizeof(v)) < 0) {\\n+ if (uv__random_rtlgenrandom((void *)&v, sizeof(v)) < 0) {\\n SET_REQ_UV_ERROR(req, UV_EIO, ERROR_IO_DEVICE);\\n goto clobber;\\n }\\n@@ -1688,21 +1638,6 @@ void fs__readdir(uv_fs_t* req) {\\n dir = req->ptr;\\n dirents = dir->dirents;\\n memset(dirents, 0, dir->nentries * sizeof(*dir->dirents));\\n-\\n- /* Initial FindFirstFile can fail with ERROR_FILE_NOT_FOUND, meaning\\n- * no matches, which leaves dir_handle set to INVALID_HANDLE_VALUE,\\n- * see fs__opendir(). Not an actual error, just means no results.\\n- *\\n- * sshfs-win apparently works that way but reading an empty directory\\n- * on a regular drive doesn't trigger that particular code path.\\n- *\\n- * See https://github.com/libuv/libuv/issues/4952\\n- */\\n- if (dir->dir_handle == INVALID_HANDLE_VALUE) {\\n- SET_REQ_RESULT(req, 0);\\n- return;\\n- }\\n-\\n find_data = &dir->find_data;\\n dirent_idx = 0;\\n \\n@@ -1763,9 +1698,8 @@ void fs__closedir(uv_fs_t* req) {\\n SET_REQ_RESULT(req, 0);\\n }\\n \\n-static fs__stat_path_return_t fs__stat_path(WCHAR* path,\\n- uv_stat_t* statbuf,\\n- int do_lstat) {\\n+INLINE static fs__stat_path_return_t fs__stat_path(WCHAR* path,\\n+ uv_stat_t* statbuf, int do_lstat) {\\n FILE_STAT_BASIC_INFORMATION stat_info;\\n \\n /* Check if the new fast API is available. */\\n@@ -1801,7 +1735,8 @@ static fs__stat_path_return_t fs__stat_path(WCHAR* path,\\n return FS__STAT_PATH_SUCCESS;\\n }\\n \\n-static int fs__stat_handle(HANDLE handle, uv_stat_t* statbuf, int do_lstat) {\\n+INLINE static int fs__stat_handle(HANDLE handle, uv_stat_t* statbuf,\\n+ int do_lstat) {\\n size_t target_length = 0;\\n FILE_FS_DEVICE_INFORMATION device_info;\\n FILE_ALL_INFORMATION file_info;\\n@@ -1892,7 +1827,7 @@ static int fs__stat_handle(HANDLE handle, uv_stat_t* statbuf, int do_lstat) {\\n return 0;\\n }\\n \\n-static void fs__stat_assign_statbuf_null(uv_stat_t* statbuf) {\\n+INLINE static void fs__stat_assign_statbuf_null(uv_stat_t* statbuf) {\\n memset(statbuf, 0, sizeof(uv_stat_t));\\n statbuf->st_mode = _S_IFCHR;\\n statbuf->st_mode |= (_S_IREAD | _S_IWRITE) | ((_S_IREAD | _S_IWRITE) >> 3) |\\n@@ -1902,9 +1837,8 @@ static void fs__stat_assign_statbuf_null(uv_stat_t* statbuf) {\\n statbuf->st_rdev = FILE_DEVICE_NULL << 16;\\n }\\n \\n-static void fs__stat_assign_statbuf(uv_stat_t* statbuf,\\n- FILE_STAT_BASIC_INFORMATION stat_info,\\n- int do_lstat) {\\n+INLINE static void fs__stat_assign_statbuf(uv_stat_t* statbuf,\\n+ FILE_STAT_BASIC_INFORMATION stat_info, int do_lstat) {\\n statbuf->st_dev = stat_info.VolumeSerialNumber.LowPart;\\n \\n /* Todo: st_mode should probably always be 0666 for everyone. We might also\\n@@ -2009,19 +1943,18 @@ static void fs__stat_assign_statbuf(uv_stat_t* statbuf,\\n }\\n \\n \\n-static void fs__stat_prepare_path(WCHAR* pathw) {\\n+INLINE static void fs__stat_prepare_path(WCHAR* pathw) {\\n size_t len = wcslen(pathw);\\n \\n+ /* TODO: ignore namespaced paths. */\\n if (len > 1 && pathw[len - 2] != L':' &&\\n (pathw[len - 1] == L'\\\\\\\\' || pathw[len - 1] == L'/')) {\\n pathw[len - 1] = '\\\\0';\\n }\\n }\\n \\n-static DWORD fs__stat_directory(WCHAR* path,\\n- uv_stat_t* statbuf,\\n- int do_lstat,\\n- DWORD ret_error) {\\n+INLINE static DWORD fs__stat_directory(WCHAR* path, uv_stat_t* statbuf,\\n+ int do_lstat, DWORD ret_error) {\\n HANDLE handle = INVALID_HANDLE_VALUE;\\n FILE_STAT_BASIC_INFORMATION stat_info;\\n FILE_ID_FULL_DIR_INFORMATION dir_info;\\n@@ -2194,9 +2127,9 @@ static DWORD fs__stat_directory(WCHAR* path,\\n return ret_error;\\n }\\n \\n-static DWORD fs__stat_impl_from_path(WCHAR* path,\\n- int do_lstat,\\n- uv_stat_t* statbuf) {\\n+INLINE static DWORD fs__stat_impl_from_path(WCHAR* path,\\n+ int do_lstat,\\n+ uv_stat_t* statbuf) {\\n HANDLE handle;\\n DWORD flags;\\n DWORD ret;\\n@@ -2241,7 +2174,7 @@ static DWORD fs__stat_impl_from_path(WCHAR* path,\\n }\\n \\n \\n-static void fs__stat_impl(uv_fs_t* req, int do_lstat) {\\n+INLINE static void fs__stat_impl(uv_fs_t* req, int do_lstat) {\\n DWORD error;\\n \\n error = fs__stat_impl_from_path(req->file.pathw, do_lstat, &req->statbuf);\\n@@ -2264,7 +2197,7 @@ static void fs__stat_impl(uv_fs_t* req, int do_lstat) {\\n }\\n \\n \\n-static int fs__fstat_handle(int fd, HANDLE handle, uv_stat_t* statbuf) {\\n+INLINE static int fs__fstat_handle(int fd, HANDLE handle, uv_stat_t* statbuf) {\\n DWORD file_type;\\n \\n /* Each file type is processed differently. */\\n@@ -2340,7 +2273,7 @@ static void fs__rename(uv_fs_t* req) {\\n }\\n \\n \\n-static void fs__sync_impl(uv_fs_t* req) {\\n+INLINE static void fs__sync_impl(uv_fs_t* req) {\\n int fd = req->file.fd;\\n int result;\\n \\n@@ -2646,7 +2579,7 @@ static void fs__fchmod(uv_fs_t* req) {\\n }\\n \\n \\n-static int fs__utime_handle(HANDLE handle, double atime, double mtime) {\\n+INLINE static int fs__utime_handle(HANDLE handle, double atime, double mtime) {\\n FILETIME filetime_as, *filetime_a = &filetime_as;\\n FILETIME filetime_ms, *filetime_m = &filetime_ms;\\n FILETIME now;\\n@@ -2674,10 +2607,10 @@ static int fs__utime_handle(HANDLE handle, double atime, double mtime) {\\n return 0;\\n }\\n \\n-static DWORD fs__utime_impl_from_path(WCHAR* path,\\n- double atime,\\n- double mtime,\\n- int do_lutime) {\\n+INLINE static DWORD fs__utime_impl_from_path(WCHAR* path,\\n+ double atime,\\n+ double mtime,\\n+ int do_lutime) {\\n HANDLE handle;\\n DWORD flags;\\n DWORD ret;\\n@@ -2707,7 +2640,7 @@ static DWORD fs__utime_impl_from_path(WCHAR* path,\\n return ret;\\n }\\n \\n-static void fs__utime_impl(uv_fs_t* req, int do_lutime) {\\n+INLINE static void fs__utime_impl(uv_fs_t* req, int do_lutime) {\\n DWORD error;\\n \\n error = fs__utime_impl_from_path(req->file.pathw,\\n@@ -3109,35 +3042,67 @@ static void fs__lchown(uv_fs_t* req) {\\n \\n \\n static void fs__statfs(uv_fs_t* req) {\\n- FILE_FS_FULL_SIZE_INFORMATION info;\\n- IO_STATUS_BLOCK io_status;\\n uv_statfs_t* stat_fs;\\n- NTSTATUS nt_status;\\n- HANDLE handle;\\n+ DWORD sectors_per_cluster;\\n+ DWORD bytes_per_sector;\\n+ DWORD free_clusters;\\n+ DWORD total_clusters;\\n+ WCHAR* pathw;\\n \\n- handle = CreateFileW(req->file.pathw,\\n- FILE_READ_ATTRIBUTES,\\n- FILE_SHARE_READ | FILE_SHARE_WRITE | FILE_SHARE_DELETE,\\n- NULL,\\n- OPEN_EXISTING,\\n- FILE_FLAG_BACKUP_SEMANTICS,\\n- NULL);\\n+ pathw = req->file.pathw;\\n+retry_get_disk_free_space:\\n+ if (0 == GetDiskFreeSpaceW(pathw,\\n+ §ors_per_cluster,\\n+ &bytes_per_sector,\\n+ &free_clusters,\\n+ &total_clusters)) {\\n+ DWORD err;\\n+ WCHAR* fpart;\\n+ size_t len;\\n+ DWORD ret;\\n+ BOOL is_second;\\n+\\n+ err = GetLastError();\\n+ is_second = pathw != req->file.pathw;\\n+ if (err != ERROR_DIRECTORY || is_second) {\\n+ if (is_second)\\n+ uv__free(pathw);\\n \\n- if (handle == INVALID_HANDLE_VALUE) {\\n- SET_REQ_WIN32_ERROR(req, GetLastError());\\n- return;\\n- }\\n+ SET_REQ_WIN32_ERROR(req, err);\\n+ return;\\n+ }\\n \\n- nt_status = pNtQueryVolumeInformationFile(handle,\\n- &io_status,\\n- &info,\\n- sizeof info,\\n- FileFsFullSizeInformation);\\n- CloseHandle(handle);\\n+ len = MAX_PATH + 1;\\n+ pathw = uv__malloc(len * sizeof(*pathw));\\n+ if (pathw == NULL) {\\n+ SET_REQ_UV_ERROR(req, UV_ENOMEM, ERROR_OUTOFMEMORY);\\n+ return;\\n+ }\\n+retry_get_full_path_name:\\n+ ret = GetFullPathNameW(req->file.pathw,\\n+ len,\\n+ pathw,\\n+ &fpart);\\n+ if (ret == 0) {\\n+ uv__free(pathw);\\n+ SET_REQ_WIN32_ERROR(req, err);\\n+ return;\\n+ } else if (ret > len) {\\n+ len = ret;\\n+ pathw = uv__reallocf(pathw, len * sizeof(*pathw));\\n+ if (pathw == NULL) {\\n+ SET_REQ_UV_ERROR(req, UV_ENOMEM, ERROR_OUTOFMEMORY);\\n+ return;\\n+ }\\n+ goto retry_get_full_path_name;\\n+ }\\n+ if (fpart != 0)\\n+ *fpart = L'\\\\0';\\n \\n- if (NT_ERROR(nt_status)) {\\n- SET_REQ_WIN32_ERROR(req, pRtlNtStatusToDosError(nt_status));\\n- return;\\n+ goto retry_get_disk_free_space;\\n+ }\\n+ if (pathw != req->file.pathw) {\\n+ uv__free(pathw);\\n }\\n \\n stat_fs = uv__malloc(sizeof(*stat_fs));\\n@@ -3147,12 +3112,10 @@ static void fs__statfs(uv_fs_t* req) {\\n }\\n \\n stat_fs->f_type = 0;\\n- stat_fs->f_bsize = (uint64_t)info.SectorsPerAllocationUnit *\\n- info.BytesPerSector;\\n- stat_fs->f_frsize = stat_fs->f_bsize;\\n- stat_fs->f_blocks = info.TotalAllocationUnits.QuadPart;\\n- stat_fs->f_bfree = info.ActualAvailableAllocationUnits.QuadPart;\\n- stat_fs->f_bavail = info.CallerAvailableAllocationUnits.QuadPart;\\n+ stat_fs->f_bsize = bytes_per_sector * sectors_per_cluster;\\n+ stat_fs->f_blocks = total_clusters;\\n+ stat_fs->f_bfree = free_clusters;\\n+ stat_fs->f_bavail = free_clusters;\\n stat_fs->f_files = 0;\\n stat_fs->f_ffree = 0;\\n req->ptr = stat_fs;\",\n \"additions\": 103,\n \"deletions\": 140\n },\n {\n \"filename\": \"deps/uv/src/win/getaddrinfo.c\",\n \"patch\": \"@@ -208,8 +208,7 @@ static void uv__getaddrinfo_done(struct uv__work* w, int status) {\\n }\\n \\n complete:\\n- if (req->loop != NULL)\\n- uv__req_unregister(req->loop);\\n+ uv__req_unregister(req->loop);\\n \\n /* finally do callback with converted result */\\n if (req->getaddrinfo_cb)\\n@@ -240,7 +239,7 @@ void uv_freeaddrinfo(struct addrinfo* ai) {\\n */\\n int uv_getaddrinfo(uv_loop_t* loop,\\n uv_getaddrinfo_t* req,\\n- uv_getaddrinfo_cb cb,\\n+ uv_getaddrinfo_cb getaddrinfo_cb,\\n const char* node,\\n const char* service,\\n const struct addrinfo* hints) {\\n@@ -253,15 +252,12 @@ int uv_getaddrinfo(uv_loop_t* loop,\\n size_t hintoff = 0;\\n ssize_t rc;\\n \\n- if (req == NULL || (node == NULL && service == NULL))\\n+ if (req == NULL || (node == NULL && service == NULL)) {\\n return UV_EINVAL;\\n- if (loop == NULL && cb != NULL)\\n- return UV_EINVAL;\\n-\\n- uv__once_init();\\n+ }\\n \\n UV_REQ_INIT(req, UV_GETADDRINFO);\\n- req->getaddrinfo_cb = cb;\\n+ req->getaddrinfo_cb = getaddrinfo_cb;\\n req->addrinfo = NULL;\\n req->loop = loop;\\n req->retcode = 0;\\n@@ -334,10 +330,9 @@ int uv_getaddrinfo(uv_loop_t* loop,\\n req->addrinfow = NULL;\\n }\\n \\n- if (loop != NULL)\\n- uv__req_register(loop);\\n+ uv__req_register(loop);\\n \\n- if (cb) {\\n+ if (getaddrinfo_cb) {\\n uv__work_submit(loop,\\n &req->work_req,\\n UV__WORK_SLOW_IO,\",\n \"additions\": 7,\n \"deletions\": 12\n },\n {\n \"filename\": \"deps/uv/src/win/handle-inl.h\",\n \"patch\": \"@@ -95,6 +95,74 @@ INLINE static void uv__want_endgame(uv_loop_t* loop, uv_handle_t* handle) {\\n }\\n \\n \\n+INLINE static void uv__process_endgames(uv_loop_t* loop) {\\n+ uv_handle_t* handle;\\n+\\n+ while (loop->endgame_handles) {\\n+ handle = loop->endgame_handles;\\n+ loop->endgame_handles = handle->endgame_next;\\n+\\n+ handle->flags &= ~UV_HANDLE_ENDGAME_QUEUED;\\n+\\n+ switch (handle->type) {\\n+ case UV_TCP:\\n+ uv__tcp_endgame(loop, (uv_tcp_t*) handle);\\n+ break;\\n+\\n+ case UV_NAMED_PIPE:\\n+ uv__pipe_endgame(loop, (uv_pipe_t*) handle);\\n+ break;\\n+\\n+ case UV_TTY:\\n+ uv__tty_endgame(loop, (uv_tty_t*) handle);\\n+ break;\\n+\\n+ case UV_UDP:\\n+ uv__udp_endgame(loop, (uv_udp_t*) handle);\\n+ break;\\n+\\n+ case UV_POLL:\\n+ uv__poll_endgame(loop, (uv_poll_t*) handle);\\n+ break;\\n+\\n+ case UV_TIMER:\\n+ uv__timer_close((uv_timer_t*) handle);\\n+ uv__handle_close(handle);\\n+ break;\\n+\\n+ case UV_PREPARE:\\n+ case UV_CHECK:\\n+ case UV_IDLE:\\n+ uv__loop_watcher_endgame(loop, handle);\\n+ break;\\n+\\n+ case UV_ASYNC:\\n+ uv__async_endgame(loop, (uv_async_t*) handle);\\n+ break;\\n+\\n+ case UV_SIGNAL:\\n+ uv__signal_endgame(loop, (uv_signal_t*) handle);\\n+ break;\\n+\\n+ case UV_PROCESS:\\n+ uv__process_endgame(loop, (uv_process_t*) handle);\\n+ break;\\n+\\n+ case UV_FS_EVENT:\\n+ uv__fs_event_endgame(loop, (uv_fs_event_t*) handle);\\n+ break;\\n+\\n+ case UV_FS_POLL:\\n+ uv__fs_poll_endgame(loop, (uv_fs_poll_t*) handle);\\n+ break;\\n+\\n+ default:\\n+ assert(0);\\n+ break;\\n+ }\\n+ }\\n+}\\n+\\n INLINE static HANDLE uv__get_osfhandle(int fd)\\n {\\n /* _get_osfhandle() raises an assert in debug builds if the FD is invalid.\",\n \"additions\": 68,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/src/win/internal.h\",\n \"patch\": \"@@ -269,7 +269,7 @@ int uv__getsockpeername(const uv_handle_t* handle,\\n int* namelen,\\n int delayed_error);\\n \\n-int uv__random_winrandom(void* buf, size_t buflen);\\n+int uv__random_rtlgenrandom(void* buf, size_t buflen);\\n \\n \\n /*\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/src/win/pipe.c\",\n \"patch\": \"@@ -2149,8 +2149,7 @@ void uv__process_pipe_read_req(uv_loop_t* loop,\\n } else {\\n /* The zero-read completed without error, indicating there is data\\n * available in the kernel buffer. */\\n- while (handle->flags & UV_HANDLE_READING &&\\n- !(handle->flags & UV_HANDLE_READ_PENDING)) {\\n+ while (handle->flags & UV_HANDLE_READING) {\\n bytes_requested = 65536;\\n /* Depending on the type of pipe, read either IPC frames or raw data. */\\n if (handle->ipc)\",\n \"additions\": 1,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/src/win/poll.c\",\n \"patch\": \"@@ -211,11 +211,15 @@ static SOCKET uv__fast_poll_create_peer_socket(HANDLE iocp,\\n protocol_info->iProtocol,\\n protocol_info,\\n 0,\\n- WSA_FLAG_OVERLAPPED | WSA_FLAG_NO_HANDLE_INHERIT);\\n+ WSA_FLAG_OVERLAPPED);\\n if (sock == INVALID_SOCKET) {\\n return INVALID_SOCKET;\\n }\\n \\n+ if (!SetHandleInformation((HANDLE) sock, HANDLE_FLAG_INHERIT, 0)) {\\n+ goto error;\\n+ };\\n+\\n if (CreateIoCompletionPort((HANDLE) sock,\\n iocp,\\n (ULONG_PTR) sock,\",\n \"additions\": 5,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/src/win/process.c\",\n \"patch\": \"@@ -1220,7 +1220,7 @@ static int uv__kill(HANDLE process_handle, int signum) {\\n NULL,\\n &localappdata);\\n _snwprintf_s(dump_folder,\\n- ARRAY_SIZE(dump_folder),\\n+ sizeof(dump_folder),\\n _TRUNCATE,\\n L\\\"%ls\\\\\\\\CrashDumps\\\",\\n localappdata);\\n@@ -1233,7 +1233,7 @@ static int uv__kill(HANDLE process_handle, int signum) {\\n \\n /* Construct dump filename from process name and PID. */\\n _snwprintf_s(dump_name,\\n- ARRAY_SIZE(dump_name),\\n+ sizeof(dump_name),\\n _TRUNCATE,\\n L\\\"%ls\\\\\\\\%ls.%d.dmp\\\",\\n dump_folder,\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/src/win/req-inl.h\",\n \"patch\": \"@@ -81,6 +81,134 @@\\n uv_fatal_error(GetLastError(), \\\"PostQueuedCompletionStatus\\\"); \\\\\\n }\\n \\n-void uv__insert_pending_req(uv_loop_t* loop, uv_req_t* req);\\n+\\n+INLINE static uv_req_t* uv__overlapped_to_req(OVERLAPPED* overlapped) {\\n+ return container_of(overlapped, uv_req_t, u.io.overlapped);\\n+}\\n+\\n+\\n+INLINE static void uv__insert_pending_req(uv_loop_t* loop, uv_req_t* req) {\\n+ req->next_req = NULL;\\n+ if (loop->pending_reqs_tail) {\\n+#ifdef _DEBUG\\n+ /* Ensure the request is not already in the queue, or the queue\\n+ * will get corrupted.\\n+ */\\n+ uv_req_t* current = loop->pending_reqs_tail;\\n+ do {\\n+ assert(req != current);\\n+ current = current->next_req;\\n+ } while(current != loop->pending_reqs_tail);\\n+#endif\\n+\\n+ req->next_req = loop->pending_reqs_tail->next_req;\\n+ loop->pending_reqs_tail->next_req = req;\\n+ loop->pending_reqs_tail = req;\\n+ } else {\\n+ req->next_req = req;\\n+ loop->pending_reqs_tail = req;\\n+ }\\n+}\\n+\\n+\\n+#define DELEGATE_STREAM_REQ(loop, req, method, handle_at) \\\\\\n+ do { \\\\\\n+ switch (((uv_handle_t*) (req)->handle_at)->type) { \\\\\\n+ case UV_TCP: \\\\\\n+ uv__process_tcp_##method##_req(loop, \\\\\\n+ (uv_tcp_t*) ((req)->handle_at), \\\\\\n+ req); \\\\\\n+ break; \\\\\\n+ \\\\\\n+ case UV_NAMED_PIPE: \\\\\\n+ uv__process_pipe_##method##_req(loop, \\\\\\n+ (uv_pipe_t*) ((req)->handle_at), \\\\\\n+ req); \\\\\\n+ break; \\\\\\n+ \\\\\\n+ case UV_TTY: \\\\\\n+ uv__process_tty_##method##_req(loop, \\\\\\n+ (uv_tty_t*) ((req)->handle_at), \\\\\\n+ req); \\\\\\n+ break; \\\\\\n+ \\\\\\n+ default: \\\\\\n+ assert(0); \\\\\\n+ } \\\\\\n+ } while (0)\\n+\\n+\\n+INLINE static void uv__process_reqs(uv_loop_t* loop) {\\n+ uv_req_t* req;\\n+ uv_req_t* first;\\n+ uv_req_t* next;\\n+\\n+ if (loop->pending_reqs_tail == NULL)\\n+ return;\\n+\\n+ first = loop->pending_reqs_tail->next_req;\\n+ next = first;\\n+ loop->pending_reqs_tail = NULL;\\n+\\n+ while (next != NULL) {\\n+ req = next;\\n+ next = req->next_req != first ? req->next_req : NULL;\\n+\\n+ switch (req->type) {\\n+ case UV_READ:\\n+ DELEGATE_STREAM_REQ(loop, req, read, data);\\n+ break;\\n+\\n+ case UV_WRITE:\\n+ DELEGATE_STREAM_REQ(loop, (uv_write_t*) req, write, handle);\\n+ break;\\n+\\n+ case UV_ACCEPT:\\n+ DELEGATE_STREAM_REQ(loop, req, accept, data);\\n+ break;\\n+\\n+ case UV_CONNECT:\\n+ DELEGATE_STREAM_REQ(loop, (uv_connect_t*) req, connect, handle);\\n+ break;\\n+\\n+ case UV_SHUTDOWN:\\n+ DELEGATE_STREAM_REQ(loop, (uv_shutdown_t*) req, shutdown, handle);\\n+ break;\\n+\\n+ case UV_UDP_RECV:\\n+ uv__process_udp_recv_req(loop, (uv_udp_t*) req->data, req);\\n+ break;\\n+\\n+ case UV_UDP_SEND:\\n+ uv__process_udp_send_req(loop,\\n+ ((uv_udp_send_t*) req)->handle,\\n+ (uv_udp_send_t*) req);\\n+ break;\\n+\\n+ case UV_WAKEUP:\\n+ uv__process_async_wakeup_req(loop, (uv_async_t*) req->data, req);\\n+ break;\\n+\\n+ case UV_SIGNAL_REQ:\\n+ uv__process_signal_req(loop, (uv_signal_t*) req->data, req);\\n+ break;\\n+\\n+ case UV_POLL_REQ:\\n+ uv__process_poll_req(loop, (uv_poll_t*) req->data, req);\\n+ break;\\n+\\n+ case UV_PROCESS_EXIT:\\n+ uv__process_proc_exit(loop, (uv_process_t*) req->data);\\n+ break;\\n+\\n+ case UV_FS_EVENT_REQ:\\n+ uv__process_fs_event_req(loop, req, (uv_fs_event_t*) req->data);\\n+ break;\\n+\\n+ default:\\n+ assert(0);\\n+ }\\n+ }\\n+}\\n \\n #endif /* UV_WIN_REQ_INL_H_ */\",\n \"additions\": 129,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/src/win/stream.c\",\n \"patch\": \"@@ -111,23 +111,6 @@ int uv_read_stop(uv_stream_t* handle) {\\n }\\n \\n \\n-static int uv__check_before_write(uv_stream_t* handle, unsigned int nbufs) {\\n- /* We're not beholden to IOV_MAX but limit the buffer count to catch sign\\n- * conversion bugs where a caller passes in a signed negative number that\\n- * then gets converted to a really large unsigned number.\\n- */\\n- if (nbufs < 1 || nbufs > 1024*1024) {\\n- return UV_EINVAL;\\n- }\\n-\\n- if (!(handle->flags & UV_HANDLE_WRITABLE)) {\\n- return UV_EPIPE;\\n- }\\n-\\n- return 0;\\n-}\\n-\\n-\\n int uv_write(uv_write_t* req,\\n uv_stream_t* handle,\\n const uv_buf_t bufs[],\\n@@ -136,9 +119,8 @@ int uv_write(uv_write_t* req,\\n uv_loop_t* loop = handle->loop;\\n int err;\\n \\n- err = uv__check_before_write(handle, nbufs);\\n- if (err != 0) {\\n- return err;\\n+ if (!(handle->flags & UV_HANDLE_WRITABLE)) {\\n+ return UV_EPIPE;\\n }\\n \\n err = ERROR_INVALID_PARAMETER;\\n@@ -174,13 +156,10 @@ int uv_write2(uv_write_t* req,\\n return uv_write(req, handle, bufs, nbufs, cb);\\n }\\n \\n- err = uv__check_before_write(handle, nbufs);\\n- if (err != 0) {\\n- return err;\\n- }\\n-\\n if (handle->type != UV_NAMED_PIPE || !((uv_pipe_t*) handle)->ipc) {\\n return UV_EINVAL;\\n+ } else if (!(handle->flags & UV_HANDLE_WRITABLE)) {\\n+ return UV_EPIPE;\\n }\\n \\n err = uv__pipe_write(\\n@@ -192,15 +171,10 @@ int uv_write2(uv_write_t* req,\\n int uv_try_write(uv_stream_t* stream,\\n const uv_buf_t bufs[],\\n unsigned int nbufs) {\\n- int err;\\n-\\n- err = uv__check_before_write(stream, nbufs);\\n- if (err != 0) {\\n- return err;\\n- }\\n-\\n if (stream->flags & UV_HANDLE_CLOSING)\\n return UV_EBADF;\\n+ if (!(stream->flags & UV_HANDLE_WRITABLE))\\n+ return UV_EPIPE;\\n \\n switch (stream->type) {\\n case UV_TCP:\",\n \"additions\": 6,\n \"deletions\": 32\n },\n {\n \"filename\": \"deps/uv/src/win/tcp.c\",\n \"patch\": \"@@ -49,98 +49,28 @@ static int uv__tcp_nodelay(uv_tcp_t* handle, SOCKET socket, int enable) {\\n }\\n \\n \\n-/*\\n- * Check if Windows version is 10.0.16299 (Windows 10, version 1709) or later.\\n- */\\n-static int uv__windows10_version1709(void) {\\n- OSVERSIONINFOW os_info;\\n- if (!pRtlGetVersion)\\n- return 0;\\n- pRtlGetVersion(&os_info);\\n- if (os_info.dwMajorVersion < 10)\\n- return 0;\\n- if (os_info.dwMajorVersion > 10)\\n- return 1;\\n- if (os_info.dwMinorVersion > 0)\\n- return 1;\\n- return os_info.dwBuildNumber >= 16299;\\n-}\\n-\\n-\\n-static int uv__tcp_keepalive(uv_tcp_t* handle,\\n- SOCKET socket,\\n- int on,\\n- unsigned int idle,\\n- unsigned int intvl,\\n- unsigned int cnt) {\\n+static int uv__tcp_keepalive(uv_tcp_t* handle, SOCKET socket, int enable, unsigned int delay) {\\n if (setsockopt(socket,\\n SOL_SOCKET,\\n SO_KEEPALIVE,\\n- (const char*)&on,\\n- sizeof on) == -1) {\\n+ (const char*)&enable,\\n+ sizeof enable) == -1) {\\n return WSAGetLastError();\\n }\\n \\n- if (!on)\\n+ if (!enable)\\n return 0;\\n \\n- if (idle < 1 || intvl < 1 || cnt < 1)\\n+ if (delay < 1)\\n return UV_EINVAL;\\n \\n- /* Windows 10, version 1709 (build 10.0.16299) and later require second units\\n- * for TCP keepalive options. */\\n- if (uv__windows10_version1709()) {\\n- if (setsockopt(socket,\\n- IPPROTO_TCP,\\n- TCP_KEEPIDLE,\\n- (const char*)&idle,\\n- sizeof idle) == -1) {\\n- return WSAGetLastError();\\n- }\\n-\\n- if (setsockopt(socket,\\n- IPPROTO_TCP,\\n- TCP_KEEPINTVL,\\n- (const char*)&intvl,\\n- sizeof intvl) == -1) {\\n- return WSAGetLastError();\\n- }\\n-\\n- if (setsockopt(socket,\\n- IPPROTO_TCP,\\n- TCP_KEEPCNT,\\n- (const char*)&cnt,\\n- sizeof cnt) == -1) {\\n- return WSAGetLastError();\\n- }\\n-\\n- return 0;\\n- }\\n-\\n- /* For those versions prior to Windows 10 version 1709,\\n- * we fall back to SIO_KEEPALIVE_VALS that expects millisecond units.\\n- * The SIO_KEEPALIVE_VALS IOCTL is supported on Windows 2000\\n- * and later versions of the operating system. */\\n- struct tcp_keepalive keepalive;\\n- keepalive.onoff = on;\\n- keepalive.keepalivetime = idle * 1000;\\n- keepalive.keepaliveinterval = intvl * 1000;\\n- /* On Windows Vista and later, the number of keep-alive probes\\n- * (data retransmissions) is set to 10 and cannot be changed.\\n- * On Windows Server 2003, Windows XP, and Windows 2000, the default setting\\n- * for number of keep-alive probes is 5 and cannot be changed programmatically.\\n- */\\n- DWORD dummy;\\n- if (WSAIoctl(socket,\\n- SIO_KEEPALIVE_VALS,\\n- (LPVOID) &keepalive,\\n- sizeof keepalive,\\n- NULL,\\n- 0,\\n- &dummy,\\n- NULL,\\n- NULL) == -1)\\n+ if (setsockopt(socket,\\n+ IPPROTO_TCP,\\n+ TCP_KEEPALIVE,\\n+ (const char*)&delay,\\n+ sizeof delay) == -1) {\\n return WSAGetLastError();\\n+ }\\n \\n return 0;\\n }\\n@@ -202,7 +132,7 @@ static int uv__tcp_set_socket(uv_loop_t* loop,\\n \\n /* TODO: Use stored delay. */\\n if (handle->flags & UV_HANDLE_TCP_KEEPALIVE) {\\n- err = uv__tcp_keepalive(handle, socket, 1, 60, 1, 10);\\n+ err = uv__tcp_keepalive(handle, socket, 1, 60);\\n if (err)\\n return err;\\n }\\n@@ -819,6 +749,20 @@ static int uv__is_loopback(const struct sockaddr_storage* storage) {\\n return 0;\\n }\\n \\n+// Check if Windows version is 10.0.16299 or later\\n+static int uv__is_fast_loopback_fail_supported(void) {\\n+ OSVERSIONINFOW os_info;\\n+ if (!pRtlGetVersion)\\n+ return 0;\\n+ pRtlGetVersion(&os_info);\\n+ if (os_info.dwMajorVersion < 10)\\n+ return 0;\\n+ if (os_info.dwMajorVersion > 10)\\n+ return 1;\\n+ if (os_info.dwMinorVersion > 0)\\n+ return 1;\\n+ return os_info.dwBuildNumber >= 16299;\\n+}\\n \\n static int uv__tcp_try_connect(uv_connect_t* req,\\n uv_tcp_t* handle,\\n@@ -865,7 +809,7 @@ static int uv__tcp_try_connect(uv_connect_t* req,\\n * is not reachable, instead of waiting for 2s. We do not care if this fails.\\n * This only works on Windows version 10.0.16299 and later.\\n */\\n- if (uv__windows10_version1709() && uv__is_loopback(&converted)) {\\n+ if (uv__is_fast_loopback_fail_supported() && uv__is_loopback(&converted)) {\\n memset(&retransmit_ioctl, 0, sizeof(retransmit_ioctl));\\n retransmit_ioctl.Rtt = TCP_INITIAL_RTO_NO_SYN_RETRANSMISSIONS;\\n retransmit_ioctl.MaxSynRetransmissions = TCP_INITIAL_RTO_NO_SYN_RETRANSMISSIONS;\\n@@ -1391,30 +1335,22 @@ int uv_tcp_nodelay(uv_tcp_t* handle, int enable) {\\n }\\n \\n \\n-int uv_tcp_keepalive(uv_tcp_t* handle, int on, unsigned int idle) {\\n- return uv_tcp_keepalive_ex(handle, on, idle, 1, 10);\\n-}\\n-\\n-int uv_tcp_keepalive_ex(uv_tcp_t* handle,\\n- int on,\\n- unsigned int idle,\\n- unsigned int intvl,\\n- unsigned int cnt) {\\n+int uv_tcp_keepalive(uv_tcp_t* handle, int enable, unsigned int delay) {\\n int err;\\n \\n if (handle->socket != INVALID_SOCKET) {\\n- err = uv__tcp_keepalive(handle, handle->socket, on, idle, intvl, cnt);\\n+ err = uv__tcp_keepalive(handle, handle->socket, enable, delay);\\n if (err)\\n return uv_translate_sys_error(err);\\n }\\n \\n- if (on) {\\n+ if (enable) {\\n handle->flags |= UV_HANDLE_TCP_KEEPALIVE;\\n } else {\\n handle->flags &= ~UV_HANDLE_TCP_KEEPALIVE;\\n }\\n \\n- /* TODO: Store idle if handle->socket isn't created yet. */\\n+ /* TODO: Store delay if handle->socket isn't created yet. */\\n \\n return 0;\\n }\",\n \"additions\": 31,\n \"deletions\": 95\n },\n {\n \"filename\": \"deps/uv/src/win/thread.c\",\n \"patch\": \"@@ -284,7 +284,7 @@ int uv_thread_equal(const uv_thread_t* t1, const uv_thread_t* t2) {\\n static void uv__thread_name_init_once(void) {\\n HMODULE m;\\n \\n- m = GetModuleHandleW(L\\\"api-ms-win-core-processthreads-l1-1-3.dll\\\");\\n+ m = GetModuleHandleA(\\\"api-ms-win-core-processthreads-l1-1-3.dll\\\");\\n if (m != NULL) {\\n pGetThreadDescription = (void*) GetProcAddress(m, \\\"GetThreadDescription\\\");\\n pSetThreadDescription = (void*) GetProcAddress(m, \\\"SetThreadDescription\\\");\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/src/win/udp.c\",\n \"patch\": \"@@ -204,7 +204,7 @@ static int uv__udp_maybe_bind(uv_udp_t* handle,\\n * so we just return an error directly when UV_UDP_REUSEPORT is requested\\n * for binding the socket. */\\n if (flags & UV_UDP_REUSEPORT)\\n- return UV_ENOTSUP;\\n+ return ERROR_NOT_SUPPORTED;\\n \\n if ((flags & UV_UDP_IPV6ONLY) && addr->sa_family != AF_INET6) {\\n /* UV_UDP_IPV6ONLY is supported only for IPV6 sockets */\\n@@ -908,15 +908,11 @@ int uv__udp_is_bound(uv_udp_t* handle) {\\n }\\n \\n \\n-int uv_udp_open_ex(uv_udp_t* handle, uv_os_sock_t sock, unsigned int flags) {\\n+int uv_udp_open(uv_udp_t* handle, uv_os_sock_t sock) {\\n WSAPROTOCOL_INFOW protocol_info;\\n int opt_len;\\n int err;\\n \\n- /* Check for bad flags. */\\n- if (flags & ~(UV_UDP_REUSEADDR | UV_UDP_REUSEPORT))\\n- return UV_EINVAL;\\n-\\n /* Detect the address family of the socket. */\\n opt_len = (int) sizeof protocol_info;\\n if (getsockopt(sock,\\n@@ -934,25 +930,6 @@ int uv_udp_open_ex(uv_udp_t* handle, uv_os_sock_t sock, unsigned int flags) {\\n if (err)\\n return uv_translate_sys_error(err);\\n \\n- /* There is no SO_REUSEPORT on Windows, Windows only knows SO_REUSEADDR.\\n- * so we just return an error directly when UV_UDP_REUSEPORT is requested\\n- * for binding the socket. */\\n- if (flags & UV_UDP_REUSEPORT)\\n- return UV_ENOTSUP;\\n-\\n- if (flags & UV_UDP_REUSEADDR) {\\n- DWORD yes = 1;\\n- /* Set SO_REUSEADDR on the socket. */\\n- if (setsockopt(handle->socket,\\n- SOL_SOCKET,\\n- SO_REUSEADDR,\\n- (char*) &yes,\\n- sizeof yes) == SOCKET_ERROR) {\\n- err = WSAGetLastError();\\n- return uv_translate_sys_error(err);\\n- }\\n- }\\n-\\n if (uv__udp_is_bound(handle))\\n handle->flags |= UV_HANDLE_BOUND;\\n \\n@@ -963,11 +940,6 @@ int uv_udp_open_ex(uv_udp_t* handle, uv_os_sock_t sock, unsigned int flags) {\\n }\\n \\n \\n-int uv_udp_open(uv_udp_t* handle, uv_os_sock_t sock) {\\n- return uv_udp_open_ex(handle, sock, 0);\\n-}\\n-\\n-\\n #define SOCKOPT_SETTER(name, option4, option6, validate) \\\\\\n int uv_udp_set_##name(uv_udp_t* handle, int value) { \\\\\\n DWORD optval = (DWORD) value; \\\\\\n@@ -1177,16 +1149,13 @@ int uv__udp_try_send2(uv_udp_t* handle,\\n uv_buf_t* bufs[/*count*/],\\n unsigned int nbufs[/*count*/],\\n struct sockaddr* addrs[/*count*/]) {\\n- int i;\\n+ unsigned int i;\\n int r;\\n \\n- if (count > INT_MAX)\\n- return UV_EINVAL;\\n-\\n- for (i = 0; i < (int) count; i++) {\\n+ for (i = 0; i < count; i++) {\\n r = uv_udp_try_send(handle, bufs[i], nbufs[i], addrs[i]);\\n if (r < 0)\\n- return i > 0 ? i : (int) r; /* Error if first packet, else send count. */\\n+ return i > 0 ? i : r; /* Error if first packet, else send count. */\\n }\\n \\n return i;\",\n \"additions\": 5,\n \"deletions\": 36\n },\n {\n \"filename\": \"deps/uv/src/win/util.c\",\n \"patch\": \"@@ -376,10 +376,10 @@ int uv_set_process_title(const char* title) {\\n \\n \\n static int uv__get_process_title(void) {\\n- WCHAR title_w[MAX_PATH];\\n+ WCHAR title_w[MAX_TITLE_LENGTH];\\n DWORD wlen;\\n \\n- wlen = GetModuleFileNameW(NULL, title_w, MAX_PATH);\\n+ wlen = GetConsoleTitleW(title_w, sizeof(title_w) / sizeof(WCHAR));\\n if (wlen == 0)\\n return uv_translate_sys_error(GetLastError());\\n \\n@@ -508,15 +508,15 @@ int uv_uptime(double* uptime) {\\n unsigned int uv_available_parallelism(void) {\\n DWORD_PTR procmask;\\n DWORD_PTR sysmask;\\n- unsigned count;\\n- unsigned i;\\n+ int count;\\n+ int i;\\n \\n /* TODO(bnoordhuis) Use GetLogicalProcessorInformationEx() to support systems\\n * with > 64 CPUs? See https://github.com/libuv/libuv/pull/3458\\n */\\n count = 0;\\n if (GetProcessAffinityMask(GetCurrentProcess(), &procmask, &sysmask))\\n- for (i = 0; i < 8u * sizeof(procmask); i++)\\n+ for (i = 0; i < 8 * sizeof(procmask); i++)\\n count += 1 & (procmask >> i);\\n \\n if (count > 0)\\n@@ -867,6 +867,12 @@ int uv_interface_addresses(uv_interface_address_t** addresses_ptr,\\n }\\n \\n \\n+void uv_free_interface_addresses(uv_interface_address_t* addresses,\\n+ int count) {\\n+ uv__free(addresses);\\n+}\\n+\\n+\\n int uv_getrusage(uv_rusage_t *uv_rusage) {\\n FILETIME create_time, exit_time, kernel_time, user_time;\\n SYSTEMTIME kernel_system_time, user_system_time;\\n@@ -1275,7 +1281,7 @@ int uv_os_environ(uv_env_item_t** envitems, int* count) {\\n FreeEnvironmentStringsW(env);\\n \\n for (i = 0; i < cnt; i++) {\\n- envitem = &(*envitems)[i];\\n+ envitem = &(*envitems)[cnt];\\n uv__free(envitem->name);\\n }\\n uv__free(*envitems);\\n@@ -1513,26 +1519,20 @@ int uv_os_setpriority(uv_pid_t pid, int priority) {\\n }\\n \\n int uv_thread_getpriority(uv_thread_t tid, int* priority) {\\n- DWORD err;\\n int r;\\n \\n if (priority == NULL)\\n return UV_EINVAL;\\n \\n r = GetThreadPriority(tid);\\n- if (r == THREAD_PRIORITY_ERROR_RETURN) {\\n- err = GetLastError();\\n- if (err == ERROR_INVALID_HANDLE)\\n- return UV_ESRCH;\\n- return uv_translate_sys_error(err);\\n- }\\n+ if (r == THREAD_PRIORITY_ERROR_RETURN)\\n+ return uv_translate_sys_error(GetLastError());\\n \\n *priority = r;\\n return 0;\\n }\\n \\n int uv_thread_setpriority(uv_thread_t tid, int priority) {\\n- DWORD err;\\n int r;\\n \\n switch (priority) {\\n@@ -1555,12 +1555,8 @@ int uv_thread_setpriority(uv_thread_t tid, int priority) {\\n return 0;\\n }\\n \\n- if (r == 0) {\\n- err = GetLastError();\\n- if (err == ERROR_INVALID_HANDLE)\\n- return UV_ESRCH;\\n- return uv_translate_sys_error(err);\\n- }\\n+ if (r == 0)\\n+ return uv_translate_sys_error(GetLastError());\\n \\n return 0;\\n }\\n@@ -1707,9 +1703,6 @@ int uv_os_uname(uv_utsname_t* buffer) {\\n case PROCESSOR_ARCHITECTURE_ARM:\\n uv__strscpy(buffer->machine, \\\"arm\\\", sizeof(buffer->machine));\\n break;\\n- case PROCESSOR_ARCHITECTURE_ARM64:\\n- uv__strscpy(buffer->machine, \\\"arm64\\\", sizeof(buffer->machine));\\n- break;\\n default:\\n uv__strscpy(buffer->machine, \\\"unknown\\\", sizeof(buffer->machine));\\n break;\\n@@ -1742,13 +1735,10 @@ int uv_gettimeofday(uv_timeval64_t* tv) {\\n return 0;\\n }\\n \\n-int uv__random_winrandom(void* buf, size_t buflen) {\\n+int uv__random_rtlgenrandom(void* buf, size_t buflen) {\\n if (buflen == 0)\\n return 0;\\n \\n- if (pProcessPrng != NULL && pProcessPrng(buf, buflen))\\n- return 0;\\n-\\n if (SystemFunction036(buf, buflen) == FALSE)\\n return UV_EIO;\\n \",\n \"additions\": 17,\n \"deletions\": 27\n },\n {\n \"filename\": \"deps/uv/src/win/winapi.c\",\n \"patch\": \"@@ -39,9 +39,6 @@ sNtQueryInformationProcess pNtQueryInformationProcess;\\n /* Powrprof.dll function pointer */\\n sPowerRegisterSuspendResumeNotification pPowerRegisterSuspendResumeNotification;\\n \\n-/* bcryptprimitives.dll function pointer */\\n-sProcessPrng pProcessPrng;\\n-\\n /* User32.dll function pointer */\\n sSetWinEventHook pSetWinEventHook;\\n \\n@@ -56,118 +53,92 @@ void uv__winapi_init(void) {\\n HMODULE powrprof_module;\\n HMODULE user32_module;\\n HMODULE ws2_32_module;\\n- HMODULE bcryptprimitives_module;\\n HMODULE api_win_core_file_module;\\n \\n- union {\\n- FARPROC proc;\\n- sRtlGetVersion pRtlGetVersion;\\n- sRtlNtStatusToDosError pRtlNtStatusToDosError;\\n- sNtDeviceIoControlFile pNtDeviceIoControlFile;\\n- sNtQueryInformationFile pNtQueryInformationFile;\\n- sNtSetInformationFile pNtSetInformationFile;\\n- sNtQueryVolumeInformationFile pNtQueryVolumeInformationFile;\\n- sNtQueryDirectoryFile pNtQueryDirectoryFile;\\n- sNtQuerySystemInformation pNtQuerySystemInformation;\\n- sNtQueryInformationProcess pNtQueryInformationProcess;\\n- sPowerRegisterSuspendResumeNotification pPowerRegisterSuspendResumeNotification;\\n- sProcessPrng pProcessPrng;\\n- sSetWinEventHook pSetWinEventHook;\\n- uv_sGetHostNameW pGetHostNameW;\\n- sGetFileInformationByName pGetFileInformationByName;\\n- } u;\\n-\\n- ntdll_module = GetModuleHandleW(L\\\"ntdll.dll\\\");\\n+ ntdll_module = GetModuleHandleA(\\\"ntdll.dll\\\");\\n if (ntdll_module == NULL) {\\n- uv_fatal_error(GetLastError(), \\\"GetModuleHandleW\\\");\\n+ uv_fatal_error(GetLastError(), \\\"GetModuleHandleA\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"RtlGetVersion\\\");\\n- pRtlGetVersion = u.pRtlGetVersion;\\n+ pRtlGetVersion = (sRtlGetVersion) GetProcAddress(ntdll_module,\\n+ \\\"RtlGetVersion\\\");\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"RtlNtStatusToDosError\\\");\\n- pRtlNtStatusToDosError = u.pRtlNtStatusToDosError;\\n+ pRtlNtStatusToDosError = (sRtlNtStatusToDosError) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"RtlNtStatusToDosError\\\");\\n if (pRtlNtStatusToDosError == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtDeviceIoControlFile\\\");\\n- pNtDeviceIoControlFile = u.pNtDeviceIoControlFile;\\n+ pNtDeviceIoControlFile = (sNtDeviceIoControlFile) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"NtDeviceIoControlFile\\\");\\n if (pNtDeviceIoControlFile == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtQueryInformationFile\\\");\\n- pNtQueryInformationFile = u.pNtQueryInformationFile;\\n+ pNtQueryInformationFile = (sNtQueryInformationFile) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"NtQueryInformationFile\\\");\\n if (pNtQueryInformationFile == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtSetInformationFile\\\");\\n- pNtSetInformationFile = u.pNtSetInformationFile;\\n+ pNtSetInformationFile = (sNtSetInformationFile) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"NtSetInformationFile\\\");\\n if (pNtSetInformationFile == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtQueryVolumeInformationFile\\\");\\n- pNtQueryVolumeInformationFile = u.pNtQueryVolumeInformationFile;\\n+ pNtQueryVolumeInformationFile = (sNtQueryVolumeInformationFile)\\n+ GetProcAddress(ntdll_module, \\\"NtQueryVolumeInformationFile\\\");\\n if (pNtQueryVolumeInformationFile == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtQueryDirectoryFile\\\");\\n- pNtQueryDirectoryFile = u.pNtQueryDirectoryFile;\\n+ pNtQueryDirectoryFile = (sNtQueryDirectoryFile)\\n+ GetProcAddress(ntdll_module, \\\"NtQueryDirectoryFile\\\");\\n if (pNtQueryDirectoryFile == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtQuerySystemInformation\\\");\\n- pNtQuerySystemInformation = u.pNtQuerySystemInformation;\\n+ pNtQuerySystemInformation = (sNtQuerySystemInformation) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"NtQuerySystemInformation\\\");\\n if (pNtQuerySystemInformation == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- u.proc = GetProcAddress(ntdll_module, \\\"NtQueryInformationProcess\\\");\\n- pNtQueryInformationProcess = u.pNtQueryInformationProcess;\\n+ pNtQueryInformationProcess = (sNtQueryInformationProcess) GetProcAddress(\\n+ ntdll_module,\\n+ \\\"NtQueryInformationProcess\\\");\\n if (pNtQueryInformationProcess == NULL) {\\n uv_fatal_error(GetLastError(), \\\"GetProcAddress\\\");\\n }\\n \\n- powrprof_module = LoadLibraryExA(\\\"powrprof.dll\\\",\\n- NULL,\\n- LOAD_LIBRARY_SEARCH_SYSTEM32);\\n+ powrprof_module = LoadLibraryExA(\\\"powrprof.dll\\\", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32);\\n if (powrprof_module != NULL) {\\n- u.proc = GetProcAddress(powrprof_module,\\n- \\\"PowerRegisterSuspendResumeNotification\\\");\\n- pPowerRegisterSuspendResumeNotification =\\n- u.pPowerRegisterSuspendResumeNotification;\\n- }\\n-\\n- bcryptprimitives_module = LoadLibraryExA(\\\"bcryptprimitives.dll\\\",\\n- NULL,\\n- LOAD_LIBRARY_SEARCH_SYSTEM32);\\n- if (bcryptprimitives_module != NULL) {\\n- u.proc = GetProcAddress(bcryptprimitives_module, \\\"ProcessPrng\\\");\\n- pProcessPrng = u.pProcessPrng;\\n+ pPowerRegisterSuspendResumeNotification = (sPowerRegisterSuspendResumeNotification)\\n+ GetProcAddress(powrprof_module, \\\"PowerRegisterSuspendResumeNotification\\\");\\n }\\n \\n- user32_module = GetModuleHandleW(L\\\"user32.dll\\\");\\n+ user32_module = GetModuleHandleA(\\\"user32.dll\\\");\\n if (user32_module != NULL) {\\n- u.proc = GetProcAddress(user32_module, \\\"SetWinEventHook\\\");\\n- pSetWinEventHook = u.pSetWinEventHook;\\n+ pSetWinEventHook = (sSetWinEventHook)\\n+ GetProcAddress(user32_module, \\\"SetWinEventHook\\\");\\n }\\n \\n- ws2_32_module = GetModuleHandleW(L\\\"ws2_32.dll\\\");\\n+ ws2_32_module = GetModuleHandleA(\\\"ws2_32.dll\\\");\\n if (ws2_32_module != NULL) {\\n- u.proc = GetProcAddress(ws2_32_module, \\\"GetHostNameW\\\");\\n- pGetHostNameW = u.pGetHostNameW;\\n+ pGetHostNameW = (uv_sGetHostNameW) GetProcAddress(\\n+ ws2_32_module,\\n+ \\\"GetHostNameW\\\");\\n }\\n \\n- api_win_core_file_module =\\n- GetModuleHandleW(L\\\"api-ms-win-core-file-l2-1-4.dll\\\");\\n+ api_win_core_file_module = GetModuleHandleA(\\\"api-ms-win-core-file-l2-1-4.dll\\\");\\n if (api_win_core_file_module != NULL) {\\n- u.proc = GetProcAddress(api_win_core_file_module,\\n- \\\"GetFileInformationByName\\\");\\n- pGetFileInformationByName = u.pGetFileInformationByName;\\n+ pGetFileInformationByName = (sGetFileInformationByName)GetProcAddress(\\n+ api_win_core_file_module, \\\"GetFileInformationByName\\\");\\n }\\n }\",\n \"additions\": 39,\n \"deletions\": 68\n },\n {\n \"filename\": \"deps/uv/src/win/winapi.h\",\n \"patch\": \"@@ -4163,10 +4163,6 @@ typedef struct _REPARSE_DATA_BUFFER {\\n ULONG Flags;\\n WCHAR PathBuffer[1];\\n } SymbolicLinkReparseBuffer;\\n- struct {\\n- ULONG Version;\\n- UCHAR PathBuffer[1];\\n- } LinuxSymbolicLinkReparseBuffer;\\n struct {\\n USHORT SubstituteNameOffset;\\n USHORT SubstituteNameLength;\\n@@ -4586,9 +4582,6 @@ typedef struct _SYSTEM_PROCESSOR_PERFORMANCE_INFORMATION {\\n #ifndef IO_REPARSE_TAG_SYMLINK\\n # define IO_REPARSE_TAG_SYMLINK (0xA000000CL)\\n #endif\\n-#ifndef IO_REPARSE_TAG_LX_SYMLINK\\n-# define IO_REPARSE_TAG_LX_SYMLINK (0xA000001DL)\\n-#endif\\n #ifndef IO_REPARSE_TAG_APPEXECLINK\\n # define IO_REPARSE_TAG_APPEXECLINK (0x8000001BL)\\n #endif\\n@@ -4758,8 +4751,6 @@ typedef DWORD (WINAPI *sPowerRegisterSuspendResumeNotification)\\n HANDLE Recipient,\\n _PHPOWERNOTIFY RegistrationHandle);\\n \\n-typedef BOOL (WINAPI *sProcessPrng)(/*_Out_*/PBYTE pbData, SIZE_T cbData);\\n-\\n /* from Winuser.h */\\n typedef VOID (CALLBACK* WINEVENTPROC)\\n (HWINEVENTHOOK hWinEventHook,\\n@@ -4824,9 +4815,6 @@ extern sNtQueryInformationProcess pNtQueryInformationProcess;\\n /* Powrprof.dll function pointer */\\n extern sPowerRegisterSuspendResumeNotification pPowerRegisterSuspendResumeNotification;\\n \\n-/* bcryptprimitives.dll function pointer */\\n-extern sProcessPrng pProcessPrng;\\n-\\n /* User32.dll function pointer */\\n extern sSetWinEventHook pSetWinEventHook;\\n \",\n \"additions\": 0,\n \"deletions\": 12\n },\n {\n \"filename\": \"deps/uv/src/win/winsock.h\",\n \"patch\": \"@@ -38,6 +38,10 @@\\n # define SO_UPDATE_CONNECT_CONTEXT 0x7010\\n #endif\\n \\n+#ifndef TCP_KEEPALIVE\\n+# define TCP_KEEPALIVE 3\\n+#endif\\n+\\n #ifndef IPV6_V6ONLY\\n # define IPV6_V6ONLY 27\\n #endif\\n@@ -58,30 +62,6 @@\\n # define MCAST_LEAVE_SOURCE_GROUP 46\\n #endif\\n \\n-#ifndef SIO_KEEPALIVE_VALS\\n-#define SIO_KEEPALIVE_VALS _WSAIOW(IOC_VENDOR,4)\\n-struct tcp_keepalive {\\n- u_long onoff;\\n- u_long keepalivetime;\\n- u_long keepaliveinterval;\\n-};\\n-#endif\\n-\\n-/*\\n- * TCP keepalive definitions on MinGW are located in <netinet/tcp.h>.\\n- */\\n-#ifndef TCP_KEEPIDLE\\n-#define TCP_KEEPIDLE 0x03 /* start keepalives after this period */\\n-#endif\\n-\\n-#ifndef TCP_KEEPINTVL\\n-#define TCP_KEEPINTVL 0x11 /* interval between keepalives */\\n-#endif\\n-\\n-#ifndef TCP_KEEPCNT\\n-#define TCP_KEEPCNT 0x10 /* number of keepalives before death */\\n-#endif\\n-\\n /*\\n * TDI defines that are only in the DDK.\\n * We only need receive flags so far.\",\n \"additions\": 4,\n \"deletions\": 24\n },\n {\n \"filename\": \"deps/uv/test/run-benchmarks.c\",\n \"patch\": \"@@ -31,7 +31,7 @@\\n #ifdef __MVS__\\n #include \\\"zos-base.h\\\"\\n /* Initialize environment and zoslib */\\n-__attribute__((constructor)) void init(void) {\\n+__attribute__((constructor)) void init() {\\n zoslib_config_t config;\\n init_zoslib_config(&config);\\n init_zoslib(config);\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/test/run-tests.c\",\n \"patch\": \"@@ -40,7 +40,7 @@\\n #ifdef __MVS__\\n #include \\\"zos-base.h\\\"\\n /* Initialize environment and zoslib */\\n-__attribute__((constructor)) void init(void) {\\n+__attribute__((constructor)) void init() {\\n zoslib_config_t config;\\n init_zoslib_config(&config);\\n init_zoslib(config);\\n@@ -214,10 +214,7 @@ static int maybe_run_test(int argc, char **argv) {\\n #ifdef _WIN32\\n DWORD flags;\\n HMODULE kernelbase_module;\\n- union {\\n- FARPROC proc;\\n- sCompareObjectHandles pCompareObjectHandles; /* Windows >= 10 */\\n- } u;\\n+ sCompareObjectHandles pCompareObjectHandles; /* function introduced in Windows 10 */\\n #endif\\n notify_parent_process();\\n ASSERT_EQ(sizeof(closed_fd), read(0, &closed_fd, sizeof(closed_fd)));\\n@@ -226,10 +223,11 @@ static int maybe_run_test(int argc, char **argv) {\\n ASSERT_GT((intptr_t) closed_fd, 0);\\n ASSERT_GT((intptr_t) open_fd, 0);\\n ASSERT_NE(0, GetHandleInformation(open_fd, &flags));\\n- kernelbase_module = GetModuleHandleW(L\\\"kernelbase.dll\\\");\\n- u.proc = GetProcAddress(kernelbase_module, \\\"CompareObjectHandles\\\");\\n- if (u.pCompareObjectHandles != NULL)\\n- ASSERT_EQ(FALSE, u.pCompareObjectHandles(open_fd, closed_fd));\\n+ kernelbase_module = GetModuleHandleA(\\\"kernelbase.dll\\\");\\n+ pCompareObjectHandles = (sCompareObjectHandles)\\n+ GetProcAddress(kernelbase_module, \\\"CompareObjectHandles\\\");\\n+ ASSERT_NE(pCompareObjectHandles == NULL || \\\\\\n+ !pCompareObjectHandles(open_fd, closed_fd), 0);\\n #else\\n ASSERT_GT(open_fd, 2);\\n ASSERT_GT(closed_fd, 2);\",\n \"additions\": 7,\n \"deletions\": 9\n },\n {\n \"filename\": \"deps/uv/test/runner-win.c\",\n \"patch\": \"@@ -340,7 +340,7 @@ static int clear_line(void) {\\n }\\n \\n \\n-void rewind_cursor(void) {\\n+void rewind_cursor() {\\n if (clear_line() == -1) {\\n /* If clear_line fails (stdout is not a console), print a newline. */\\n fprintf(stderr, \\\"\\\\n\\\");\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/test/runner.h\",\n \"patch\": \"@@ -22,6 +22,7 @@\\n #ifndef RUNNER_H_\\n #define RUNNER_H_\\n \\n+#include <limits.h> /* PATH_MAX */\\n #include <stdio.h> /* FILE */\\n \\n \\n@@ -56,7 +57,7 @@ typedef struct {\\n task_entry_t TASKS[] = {\\n \\n #define TASK_LIST_END \\\\\\n- { 0, 0, 0, 0, 0, 0 } \\\\\\n+ { 0, 0, 0, 0, 0, 0 } \\\\\\n };\\n \\n #define TEST_DECLARE(name) \\\\\\n@@ -68,23 +69,6 @@ typedef struct {\\n #define TEST_ENTRY_CUSTOM(name, is_helper, show_output, timeout) \\\\\\n { #name, #name, &run_test_##name, is_helper, show_output, timeout },\\n \\n-/*\\n- * Macros for fs tests that, on linux, generate both normal and io_uring\\n- * versions.\\n- */\\n-#ifdef __linux__\\n-#define TEST_FS_DECLARE(name) \\\\\\n- TEST_DECLARE(name) \\\\\\n- TEST_DECLARE(name##_iouring)\\n-\\n-#define TEST_FS_ENTRY(name) \\\\\\n- TEST_ENTRY(name) \\\\\\n- TEST_ENTRY(name##_iouring)\\n-#else\\n-#define TEST_FS_DECLARE(name) TEST_DECLARE(name)\\n-#define TEST_FS_ENTRY(name) TEST_ENTRY(name)\\n-#endif\\n-\\n #define BENCHMARK_DECLARE(name) \\\\\\n int run_benchmark_##name(void);\\n \",\n \"additions\": 2,\n \"deletions\": 18\n },\n {\n \"filename\": \"deps/uv/test/task.h\",\n \"patch\": \"@@ -53,10 +53,14 @@\\n # define TEST_PIPENAME \\\"\\\\\\\\\\\\\\\\.\\\\\\\\pipe\\\\\\\\uv-test\\\"\\n # define TEST_PIPENAME_2 \\\"\\\\\\\\\\\\\\\\.\\\\\\\\pipe\\\\\\\\uv-test2\\\"\\n # define TEST_PIPENAME_3 \\\"\\\\\\\\\\\\\\\\.\\\\\\\\pipe\\\\\\\\uv-test3\\\"\\n+#elif __ANDROID__\\n+# define TEST_PIPENAME \\\"/data/local/tmp/uv-test-sock\\\"\\n+# define TEST_PIPENAME_2 \\\"/data/local/tmp/uv-test-sock2\\\"\\n+# define TEST_PIPENAME_3 \\\"/data/local/tmp/uv-test-sock3\\\"\\n #else\\n-# define TEST_PIPENAME \\\"uv-test-sock\\\"\\n-# define TEST_PIPENAME_2 \\\"uv-test-sock2\\\"\\n-# define TEST_PIPENAME_3 \\\"uv-test-sock3\\\"\\n+# define TEST_PIPENAME \\\"/tmp/uv-test-sock\\\"\\n+# define TEST_PIPENAME_2 \\\"/tmp/uv-test-sock2\\\"\\n+# define TEST_PIPENAME_3 \\\"/tmp/uv-test-sock3\\\"\\n #endif\\n \\n #ifdef _WIN32\\n@@ -109,8 +113,8 @@ typedef enum {\\n \\n #define ASSERT_BASE(a, operator, b, type, conv) \\\\\\n do { \\\\\\n- type const eval_a = (a); \\\\\\n- type const eval_b = (b); \\\\\\n+ volatile type eval_a = (type) (a); \\\\\\n+ volatile type eval_b = (type) (b); \\\\\\n if (!(eval_a operator eval_b)) { \\\\\\n fprintf(stderr, \\\\\\n \\\"Assertion failed in %s on line %d: `%s %s %s` \\\" \\\\\\n@@ -127,21 +131,6 @@ typedef enum {\\n } \\\\\\n } while (0)\\n \\n-#define ASSERT_OK(a) \\\\\\n- do { \\\\\\n- int64_t const eval_a = (a); \\\\\\n- if (eval_a) { \\\\\\n- fprintf(stderr, \\\\\\n- \\\"Assertion failed in %s on line %d: `%s` okay \\\" \\\\\\n- \\\"(error: %\\\"PRId64\\\")\\\\n\\\", \\\\\\n- __FILE__, \\\\\\n- __LINE__, \\\\\\n- #a, \\\\\\n- eval_a); \\\\\\n- abort(); \\\\\\n- } \\\\\\n- } while (0)\\n-\\n #define ASSERT_BASE_STR(expr, a, operator, b, type, conv) \\\\\\n do { \\\\\\n if (!(expr)) { \\\\\\n@@ -184,8 +173,8 @@ typedef enum {\\n do { \\\\\\n if (!(expr)) { \\\\\\n int i; \\\\\\n- const unsigned char* a_ = (a); \\\\\\n- const unsigned char* b_ = (b); \\\\\\n+ unsigned char* a_ = (unsigned char*)a; \\\\\\n+ unsigned char* b_ = (unsigned char*)b; \\\\\\n fprintf(stderr, \\\\\\n \\\"Assertion failed in %s on line %d: `%s %s %s` (\\\", \\\\\\n __FILE__, \\\\\\n@@ -213,6 +202,7 @@ typedef enum {\\n #define ASSERT_LE(a, b) ASSERT_BASE(a, <=, b, int64_t, PRId64)\\n #define ASSERT_LT(a, b) ASSERT_BASE(a, <, b, int64_t, PRId64)\\n #define ASSERT_NE(a, b) ASSERT_BASE(a, !=, b, int64_t, PRId64)\\n+#define ASSERT_OK(a) ASSERT_BASE(a, ==, 0, int64_t, PRId64)\\n \\n #define ASSERT_UINT64_EQ(a, b) ASSERT_BASE(a, ==, b, uint64_t, PRIu64)\\n #define ASSERT_UINT64_GE(a, b) ASSERT_BASE(a, >=, b, uint64_t, PRIu64)\\n@@ -221,12 +211,12 @@ typedef enum {\\n #define ASSERT_UINT64_LT(a, b) ASSERT_BASE(a, <, b, uint64_t, PRIu64)\\n #define ASSERT_UINT64_NE(a, b) ASSERT_BASE(a, !=, b, uint64_t, PRIu64)\\n \\n-#define ASSERT_DOUBLE_EQ(a, b) ASSERT_BASE(a, ==, b, volatile double, \\\"f\\\")\\n-#define ASSERT_DOUBLE_GE(a, b) ASSERT_BASE(a, >=, b, volatile double, \\\"f\\\")\\n-#define ASSERT_DOUBLE_GT(a, b) ASSERT_BASE(a, >, b, volatile double, \\\"f\\\")\\n-#define ASSERT_DOUBLE_LE(a, b) ASSERT_BASE(a, <=, b, volatile double, \\\"f\\\")\\n-#define ASSERT_DOUBLE_LT(a, b) ASSERT_BASE(a, <, b, volatile double, \\\"f\\\")\\n-#define ASSERT_DOUBLE_NE(a, b) ASSERT_BASE(a, !=, b, volatile double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_EQ(a, b) ASSERT_BASE(a, ==, b, double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_GE(a, b) ASSERT_BASE(a, >=, b, double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_GT(a, b) ASSERT_BASE(a, >, b, double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_LE(a, b) ASSERT_BASE(a, <=, b, double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_LT(a, b) ASSERT_BASE(a, <, b, double, \\\"f\\\")\\n+#define ASSERT_DOUBLE_NE(a, b) ASSERT_BASE(a, !=, b, double, \\\"f\\\")\\n \\n #define ASSERT_STR_EQ(a, b) \\\\\\n ASSERT_BASE_STR(strcmp(a, b) == 0, a, == , b, char*, \\\"s\\\")\\n@@ -247,23 +237,19 @@ typedef enum {\\n ASSERT_BASE_HEX(memcmp(a, b, size) != 0, a, !=, b, size)\\n \\n #define ASSERT_NULL(a) \\\\\\n- ASSERT_BASE(a, ==, NULL, const void*, \\\"p\\\")\\n+ ASSERT_BASE(a, ==, NULL, void*, \\\"p\\\")\\n \\n #define ASSERT_NOT_NULL(a) \\\\\\n- ASSERT_BASE(a, !=, NULL, const void*, \\\"p\\\")\\n+ ASSERT_BASE(a, !=, NULL, void*, \\\"p\\\")\\n \\n #define ASSERT_PTR_EQ(a, b) \\\\\\n- ASSERT_BASE(a, ==, b, const void*, \\\"p\\\")\\n+ ASSERT_BASE(a, ==, b, void*, \\\"p\\\")\\n \\n #define ASSERT_PTR_NE(a, b) \\\\\\n- ASSERT_BASE(a, !=, b, const void*, \\\"p\\\")\\n+ ASSERT_BASE(a, !=, b, void*, \\\"p\\\")\\n \\n #define ASSERT_PTR_LT(a, b) \\\\\\n- ASSERT_BASE(a, <, b, const void*, \\\"p\\\")\\n-#define ASSERT_PTR_LE(a, b) \\\\\\n- ASSERT_BASE(a, <=, b, const void*, \\\"p\\\")\\n-#define ASSERT_PTR_GE(a, b) \\\\\\n- ASSERT_BASE(a, >=, b, const void*, \\\"p\\\")\\n+ ASSERT_BASE(a, <, b, void*, \\\"p\\\")\\n \\n /* This macro cleans up the event loop. This is used to avoid valgrind\\n * warnings about memory being \\\"leaked\\\" by the event loop.\\n@@ -284,19 +270,6 @@ typedef enum {\\n int run_benchmark_##name(void); \\\\\\n int run_benchmark_##name(void)\\n \\n-#ifdef __linux__\\n-#define TEST_FS_IMPL(name) \\\\\\n- int run_test_##name(void); \\\\\\n- int run_test_##name##_iouring(void) { \\\\\\n- uv_os_setenv(\\\"UV_USE_IO_URING\\\", \\\"1\\\"); \\\\\\n- uv_loop_configure(uv_default_loop(), UV_LOOP_USE_IO_URING_SQPOLL); \\\\\\n- return run_test_##name(); \\\\\\n- } \\\\\\n- int run_test_##name(void)\\n-#else\\n-#define TEST_FS_IMPL(name) TEST_IMPL(name)\\n-#endif\\n-\\n #define HELPER_IMPL(name) \\\\\\n int run_helper_##name(void); \\\\\\n int run_helper_##name(void)\\n@@ -385,7 +358,7 @@ UNUSED static int can_ipv6(void) {\\n return supported;\\n }\\n \\n-#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__) || defined(__QNX__)\\n+#if defined(__CYGWIN__) || defined(__MSYS__) || defined(__PASE__)\\n # define NO_FS_EVENTS \\\"Filesystem watching not supported on this platform.\\\"\\n #endif\\n \",\n \"additions\": 24,\n \"deletions\": 51\n },\n {\n \"filename\": \"deps/uv/test/test-embed.c\",\n \"patch\": \"@@ -25,7 +25,7 @@\\n #include <stdlib.h>\\n #include <errno.h>\\n \\n-#if !defined(_WIN32) && !defined(_AIX) && !defined(__QNX__)\\n+#if !defined(_WIN32) && !defined(_AIX)\\n #include <poll.h>\\n #endif\\n \\n@@ -56,7 +56,7 @@ TEST_IMPL(embed) {\\n ASSERT_LE(0, uv_barrier_wait(&barrier));\\n \\n while (uv_loop_alive(loop)) {\\n-#if defined(_WIN32) || defined(_AIX) || defined(__QNX__)\\n+#if defined(_WIN32) || defined(_AIX)\\n ASSERT_LE(0, uv_run(loop, UV_RUN_ONCE));\\n #else\\n int rc;\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/test/test-fs-copyfile.c\",\n \"patch\": \"@@ -102,7 +102,7 @@ static void touch_file(const char* name, unsigned int size) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_copyfile) {\\n+TEST_IMPL(fs_copyfile) {\\n const char src[] = \\\"test_file_src\\\";\\n uv_loop_t* loop;\\n uv_fs_t req;\\n@@ -220,13 +220,8 @@ TEST_FS_IMPL(fs_copyfile) {\\n r = uv_fs_copyfile(NULL, &req, fixture, dst, 0, NULL);\\n /* On IBMi PASE, qsecofr users can overwrite read-only files */\\n # ifndef __PASE__\\n- if (0 == getuid()) { /* If root. */\\n- ASSERT_EQ(req.result, 0);\\n- ASSERT_EQ(r, 0);\\n- } else {\\n- ASSERT_EQ(req.result, UV_EACCES);\\n- ASSERT_EQ(r, UV_EACCES);\\n- }\\n+ ASSERT_EQ(req.result, UV_EACCES);\\n+ ASSERT_EQ(r, UV_EACCES);\\n # endif\\n uv_fs_req_cleanup(&req);\\n #endif\",\n \"additions\": 3,\n \"deletions\": 8\n },\n {\n \"filename\": \"deps/uv/test/test-fs-fd-hash.c\",\n \"patch\": \"@@ -66,25 +66,17 @@ void assert_removal(int fd) {\\n /* Run a function for a set of values up to a very high number */\\n #define RUN_HASH(function) \\\\\\n do { \\\\\\n- uint64_t before = uv_hrtime(); \\\\\\n for (fd = 0; fd < HASH_MAX; fd += HASH_INC) { \\\\\\n function(fd); \\\\\\n } \\\\\\n- uint64_t after = uv_hrtime(); \\\\\\n- double seconds = (after - before) / 1e9; \\\\\\n- printf(\\\"%.5f hash %s\\\\n\\\", seconds, #function); \\\\\\n } while (0)\\n \\n /* Run a function for a set of values that will cause many collisions */\\n #define RUN_COLLISIONS(function) \\\\\\n do { \\\\\\n- uint64_t before = uv_hrtime(); \\\\\\n for (fd = 1; fd < BUCKET_MAX; fd += BUCKET_INC) { \\\\\\n function(fd); \\\\\\n } \\\\\\n- uint64_t after = uv_hrtime(); \\\\\\n- double seconds = (after - before) / 1e9; \\\\\\n- printf(\\\"%.5f coll %s\\\\n\\\", seconds, #function); \\\\\\n } while (0)\\n \\n \",\n \"additions\": 0,\n \"deletions\": 8\n },\n {\n \"filename\": \"deps/uv/test/test-fs-readdir.c\",\n \"patch\": \"@@ -96,7 +96,7 @@ static void empty_opendir_cb(uv_fs_t* req) {\\n * of the uv_fs_opendir() -> uv_fs_readdir() -> uv_fs_closedir() sequence work\\n * as expected when processing an empty directory.\\n */\\n-TEST_FS_IMPL(fs_readdir_empty_dir) {\\n+TEST_IMPL(fs_readdir_empty_dir) {\\n const char* path;\\n uv_fs_t mkdir_req;\\n uv_fs_t rmdir_req;\\n@@ -178,7 +178,7 @@ static void non_existing_opendir_cb(uv_fs_t* req) {\\n ++non_existing_opendir_cb_count;\\n }\\n \\n-TEST_FS_IMPL(fs_readdir_non_existing_dir) {\\n+TEST_IMPL(fs_readdir_non_existing_dir) {\\n const char* path;\\n int r;\\n \\n@@ -230,7 +230,7 @@ static void file_opendir_cb(uv_fs_t* req) {\\n ++file_opendir_cb_count;\\n }\\n \\n-TEST_FS_IMPL(fs_readdir_file) {\\n+TEST_IMPL(fs_readdir_file) {\\n const char* path;\\n int r;\\n \\n@@ -342,7 +342,7 @@ static void non_empty_opendir_cb(uv_fs_t* req) {\\n ++non_empty_opendir_cb_count;\\n }\\n \\n-TEST_FS_IMPL(fs_readdir_non_empty_dir) {\\n+TEST_IMPL(fs_readdir_non_empty_dir) {\\n size_t entries_count;\\n uv_fs_t mkdir_req;\\n uv_fs_t rmdir_req;\\n@@ -518,7 +518,7 @@ static void cleanup_symlink_test_files(void) {\\n uv_fs_req_cleanup(&req);\\n }\\n \\n-TEST_FS_IMPL(fs_readdir_symlink) {\\n+TEST_IMPL(fs_readdir_symlink) {\\n \\n uv_fs_t mkdir_req;\\n uv_fs_t symlink_req;\",\n \"additions\": 5,\n \"deletions\": 5\n },\n {\n \"filename\": \"deps/uv/test/test-fs.c\",\n \"patch\": \"@@ -23,7 +23,6 @@\\n #include \\\"task.h\\\"\\n \\n #include <errno.h>\\n-#include <stddef.h> /* offsetof */\\n #include <string.h> /* memset */\\n #include <fcntl.h>\\n #include <sys/stat.h>\\n@@ -38,13 +37,6 @@\\n # ifndef ERROR_SYMLINK_NOT_SUPPORTED\\n # define ERROR_SYMLINK_NOT_SUPPORTED 1464\\n # endif\\n-# ifndef REPARSE_DATA_BUFFER_HEADER_SIZE\\n-# define REPARSE_DATA_BUFFER_HEADER_SIZE \\\\\\n- offsetof(REPARSE_DATA_BUFFER, GenericReparseBuffer)\\n-# endif\\n-# ifndef IO_REPARSE_TAG_LX_SYMLINK\\n-# define IO_REPARSE_TAG_LX_SYMLINK (0xA000001DL)\\n-# endif\\n # ifndef S_IFIFO\\n # define S_IFIFO _S_IFIFO\\n # endif\\n@@ -73,30 +65,18 @@ static const int is_win32 = 1;\\n static const int is_win32 = 0;\\n #endif\\n \\n+#if defined(__APPLE__) || defined(__SUNPRO_C)\\n+static const int is_apple_or_sunpro_c = 1;\\n+#else\\n+static const int is_apple_or_sunpro_c = 0;\\n+#endif\\n+\\n typedef struct {\\n const char* path;\\n double atime;\\n double mtime;\\n } utime_check_t;\\n \\n-#ifdef _WIN32\\n-# ifndef REPARSE_DATA_BUFFER\\n-typedef struct _REPARSE_DATA_BUFFER {\\n- ULONG ReparseTag;\\n- USHORT ReparseDataLength;\\n- USHORT Reserved;\\n- union {\\n- struct {\\n- ULONG Version;\\n- UCHAR PathBuffer[1];\\n- } LinuxSymbolicLinkReparseBuffer;\\n- struct {\\n- UCHAR DataBuffer[1];\\n- } GenericReparseBuffer;\\n- } DUMMYUNIONNAME;\\n-} REPARSE_DATA_BUFFER, *PREPARSE_DATA_BUFFER;\\n-# endif\\n-#endif\\n \\n static int dummy_cb_count;\\n static int close_cb_count;\\n@@ -172,7 +152,7 @@ int uv_test_getiovmax(void) {\\n int uv_test_getiovmax(void) {\\n #if defined(IOV_MAX)\\n return IOV_MAX;\\n-#elif defined(_SC_IOV_MAX) && !defined(__QNX__)\\n+#elif defined(_SC_IOV_MAX)\\n static int iovmax = -1;\\n if (iovmax == -1) {\\n iovmax = sysconf(_SC_IOV_MAX);\\n@@ -376,14 +356,13 @@ static void statfs_cb(uv_fs_t* req) {\\n stats = req->ptr;\\n \\n #if defined(_WIN32) || defined(__sun) || defined(_AIX) || defined(__MVS__) || \\\\\\n- defined(__OpenBSD__) || defined(__NetBSD__) || defined(__QNX__)\\n+ defined(__OpenBSD__) || defined(__NetBSD__)\\n ASSERT_OK(stats->f_type);\\n #else\\n ASSERT_UINT64_GT(stats->f_type, 0);\\n #endif\\n \\n ASSERT_GT(stats->f_bsize, 0);\\n- ASSERT_GT(stats->f_frsize, 0);\\n ASSERT_GT(stats->f_blocks, 0);\\n ASSERT_LE(stats->f_bfree, stats->f_blocks);\\n ASSERT_LE(stats->f_bavail, stats->f_bfree);\\n@@ -749,7 +728,7 @@ static void open_loop_cb(uv_fs_t* req) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_file_noent) {\\n+TEST_IMPL(fs_file_noent) {\\n uv_fs_t req;\\n int r;\\n \\n@@ -774,7 +753,7 @@ TEST_FS_IMPL(fs_file_noent) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_file_nametoolong) {\\n+TEST_IMPL(fs_file_nametoolong) {\\n uv_fs_t req;\\n int r;\\n char name[TOO_LONG_NAME_LENGTH + 1];\\n@@ -800,7 +779,7 @@ TEST_FS_IMPL(fs_file_nametoolong) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_file_loop) {\\n+TEST_IMPL(fs_file_loop) {\\n uv_fs_t req;\\n int r;\\n \\n@@ -876,10 +855,9 @@ static void check_utime(const char* path,\\n ASSERT_LE(s->st_atim.tv_sec, (long) atime);\\n } else {\\n double st_atim;\\n-#ifndef __APPLE__\\n /* TODO(vtjnash): would it be better to normalize this? */\\n- ASSERT_DOUBLE_GE(s->st_atim.tv_nsec, 0);\\n-#endif\\n+ if (!is_apple_or_sunpro_c)\\n+ ASSERT_DOUBLE_GE(s->st_atim.tv_nsec, 0);\\n st_atim = s->st_atim.tv_sec + s->st_atim.tv_nsec / 1e9;\\n /* Linux does not allow reading reliably the atime of a symlink\\n * since readlink() can update it\\n@@ -912,10 +890,9 @@ static void check_utime(const char* path,\\n ASSERT_LE(s->st_mtim.tv_sec, (long) mtime);\\n } else {\\n double st_mtim;\\n-#ifndef __APPLE__\\n /* TODO(vtjnash): would it be better to normalize this? */\\n- ASSERT_DOUBLE_GE(s->st_mtim.tv_nsec, 0);\\n-#endif\\n+ if (!is_apple_or_sunpro_c)\\n+ ASSERT_DOUBLE_GE(s->st_mtim.tv_nsec, 0);\\n st_mtim = s->st_mtim.tv_sec + s->st_mtim.tv_nsec / 1e9;\\n ASSERT_DOUBLE_EQ(st_mtim, mtime);\\n }\\n@@ -976,7 +953,7 @@ static void lutime_cb(uv_fs_t* req) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_file_async) {\\n+TEST_IMPL(fs_file_async) {\\n int r;\\n \\n /* Setup. */\\n@@ -1122,15 +1099,15 @@ static void fs_file_sync(int add_flags) {\\n unlink(\\\"test_file\\\");\\n unlink(\\\"test_file2\\\");\\n }\\n-TEST_FS_IMPL(fs_file_sync) {\\n+TEST_IMPL(fs_file_sync) {\\n fs_file_sync(0);\\n fs_file_sync(UV_FS_O_FILEMAP);\\n \\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_posix_delete) {\\n+TEST_IMPL(fs_posix_delete) {\\n int r;\\n \\n /* Setup. */\\n@@ -1203,7 +1180,7 @@ static void fs_file_write_null_buffer(int add_flags) {\\n \\n unlink(\\\"test_file\\\");\\n }\\n-TEST_FS_IMPL(fs_file_write_null_buffer) {\\n+TEST_IMPL(fs_file_write_null_buffer) {\\n fs_file_write_null_buffer(0);\\n fs_file_write_null_buffer(UV_FS_O_FILEMAP);\\n \\n@@ -1212,7 +1189,7 @@ TEST_FS_IMPL(fs_file_write_null_buffer) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_async_dir) {\\n+TEST_IMPL(fs_async_dir) {\\n int r;\\n uv_dirent_t dent;\\n \\n@@ -1396,17 +1373,17 @@ static void sendfile_setup(int f) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_async_sendfile) {\\n+TEST_IMPL(fs_async_sendfile) {\\n return test_sendfile(sendfile_setup, sendfile_cb, 65545);\\n }\\n \\n \\n-TEST_FS_IMPL(fs_async_sendfile_nodata) {\\n+TEST_IMPL(fs_async_sendfile_nodata) {\\n return test_sendfile(NULL, sendfile_nodata_cb, 0);\\n }\\n \\n \\n-TEST_FS_IMPL(fs_mkdtemp) {\\n+TEST_IMPL(fs_mkdtemp) {\\n int r;\\n const char* path_template = \\\"test_dir_XXXXXX\\\";\\n \\n@@ -1437,7 +1414,7 @@ TEST_FS_IMPL(fs_mkdtemp) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_mkstemp) {\\n+TEST_IMPL(fs_mkstemp) {\\n int r;\\n int fd;\\n const char path_template[] = \\\"test_file_XXXXXX\\\";\\n@@ -1505,7 +1482,7 @@ TEST_FS_IMPL(fs_mkstemp) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_fstat) {\\n+TEST_IMPL(fs_fstat) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -1669,7 +1646,7 @@ TEST_FS_IMPL(fs_fstat) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_fstat_st_dev) {\\n+TEST_IMPL(fs_fstat_st_dev) {\\n uv_fs_t req;\\n uv_fs_t req_link;\\n uv_loop_t* loop = uv_default_loop();\\n@@ -1713,7 +1690,7 @@ TEST_FS_IMPL(fs_fstat_st_dev) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_fstat_stdio) {\\n+TEST_IMPL(fs_fstat_stdio) {\\n int fd;\\n int res;\\n uv_fs_t req;\\n@@ -1752,7 +1729,7 @@ TEST_FS_IMPL(fs_fstat_stdio) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_access) {\\n+TEST_IMPL(fs_access) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -1828,7 +1805,7 @@ TEST_FS_IMPL(fs_access) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_chmod) {\\n+TEST_IMPL(fs_chmod) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -1926,7 +1903,7 @@ TEST_FS_IMPL(fs_chmod) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_unlink_readonly) {\\n+TEST_IMPL(fs_unlink_readonly) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -1983,7 +1960,7 @@ TEST_FS_IMPL(fs_unlink_readonly) {\\n }\\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_unlink_archive_readonly) {\\n+TEST_IMPL(fs_unlink_archive_readonly) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -2039,7 +2016,7 @@ TEST_FS_IMPL(fs_unlink_archive_readonly) {\\n }\\n #endif\\n \\n-TEST_FS_IMPL(fs_chown) {\\n+TEST_IMPL(fs_chown) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -2132,7 +2109,7 @@ TEST_FS_IMPL(fs_chown) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_link) {\\n+TEST_IMPL(fs_link) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -2218,7 +2195,7 @@ TEST_FS_IMPL(fs_link) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_readlink) {\\n+TEST_IMPL(fs_readlink) {\\n /* Must return UV_ENOENT on an inexistent file */\\n {\\n uv_fs_t req;\\n@@ -2272,7 +2249,7 @@ TEST_FS_IMPL(fs_readlink) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_realpath) {\\n+TEST_IMPL(fs_realpath) {\\n uv_fs_t req;\\n \\n loop = uv_default_loop();\\n@@ -2293,7 +2270,7 @@ TEST_FS_IMPL(fs_realpath) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_symlink) {\\n+TEST_IMPL(fs_symlink) {\\n int r;\\n uv_fs_t req;\\n uv_file file;\\n@@ -2607,16 +2584,16 @@ int test_symlink_dir_impl(int type) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_symlink_dir) {\\n+TEST_IMPL(fs_symlink_dir) {\\n return test_symlink_dir_impl(UV_FS_SYMLINK_DIR);\\n }\\n \\n-TEST_FS_IMPL(fs_symlink_junction) {\\n+TEST_IMPL(fs_symlink_junction) {\\n return test_symlink_dir_impl(UV_FS_SYMLINK_JUNCTION);\\n }\\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_non_symlink_reparse_point) {\\n+TEST_IMPL(fs_non_symlink_reparse_point) {\\n uv_fs_t req;\\n int r;\\n HANDLE file_handle;\\n@@ -2716,81 +2693,7 @@ TEST_FS_IMPL(fs_non_symlink_reparse_point) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_readlink_lx_symlink) {\\n- uv_fs_t req;\\n- int r;\\n- HANDLE file_handle;\\n- REPARSE_DATA_BUFFER* reparse_buffer;\\n- DWORD bytes_returned;\\n- const char* target_path = \\\"target_file\\\";\\n- size_t target_len = strlen(target_path);\\n- size_t buffer_size;\\n-\\n- /* set-up */\\n- unlink(\\\"test_dir/lx_symlink\\\");\\n- rmdir(\\\"test_dir\\\");\\n-\\n- loop = uv_default_loop();\\n-\\n- uv_fs_mkdir(NULL, &req, \\\"test_dir\\\", 0777, NULL);\\n- uv_fs_req_cleanup(&req);\\n-\\n- file_handle = CreateFile(\\\"test_dir/lx_symlink\\\",\\n- GENERIC_WRITE | FILE_WRITE_ATTRIBUTES,\\n- 0,\\n- NULL,\\n- CREATE_ALWAYS,\\n- FILE_FLAG_OPEN_REPARSE_POINT |\\n- FILE_FLAG_BACKUP_SEMANTICS,\\n- NULL);\\n- ASSERT_PTR_NE(file_handle, INVALID_HANDLE_VALUE);\\n-\\n- /* Allocate buffer for reparse data */\\n- buffer_size = REPARSE_DATA_BUFFER_HEADER_SIZE +\\n- sizeof(ULONG) + /* Version field */\\n- target_len;\\n- reparse_buffer = malloc(buffer_size);\\n- ASSERT_NOT_NULL(reparse_buffer);\\n-\\n- /* Set up Linux symlink reparse buffer */\\n- memset(reparse_buffer, 0, buffer_size);\\n- reparse_buffer->ReparseTag = IO_REPARSE_TAG_LX_SYMLINK;\\n- reparse_buffer->ReparseDataLength = sizeof(ULONG) + target_len;\\n- reparse_buffer->Reserved = 0;\\n- reparse_buffer->LinuxSymbolicLinkReparseBuffer.Version = 2;\\n- memcpy(reparse_buffer->LinuxSymbolicLinkReparseBuffer.PathBuffer,\\n- target_path,\\n- target_len);\\n-\\n- r = DeviceIoControl(file_handle,\\n- FSCTL_SET_REPARSE_POINT,\\n- reparse_buffer,\\n- buffer_size,\\n- NULL,\\n- 0,\\n- &bytes_returned,\\n- NULL);\\n- ASSERT(r);\\n-\\n- CloseHandle(file_handle);\\n-\\n- /* Test that readlink works on the Linux symlink */\\n- r = uv_fs_readlink(NULL, &req, \\\"test_dir/lx_symlink\\\", NULL);\\n- ASSERT_OK(r);\\n- ASSERT_NOT_NULL(req.ptr);\\n- ASSERT_OK(strcmp(req.ptr, target_path));\\n- uv_fs_req_cleanup(&req);\\n-\\n- /* clean-up */\\n- free(reparse_buffer);\\n- unlink(\\\"test_dir/lx_symlink\\\");\\n- rmdir(\\\"test_dir\\\");\\n-\\n- MAKE_VALGRIND_HAPPY(loop);\\n- return 0;\\n-}\\n-\\n-TEST_FS_IMPL(fs_lstat_windows_store_apps) {\\n+TEST_IMPL(fs_lstat_windows_store_apps) {\\n uv_loop_t* loop;\\n char localappdata[MAX_PATH];\\n char windowsapps_path[MAX_PATH];\\n@@ -2843,7 +2746,7 @@ TEST_FS_IMPL(fs_lstat_windows_store_apps) {\\n #endif\\n \\n \\n-TEST_FS_IMPL(fs_utime) {\\n+TEST_IMPL(fs_utime) {\\n utime_check_t checkme;\\n const char* path = \\\"test_file\\\";\\n double atime;\\n@@ -2924,15 +2827,13 @@ TEST_FS_IMPL(fs_utime) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_utime_round) {\\n+TEST_IMPL(fs_utime_round) {\\n const char path[] = \\\"test_file\\\";\\n double atime;\\n double mtime;\\n uv_fs_t req;\\n int r;\\n-#if defined(__QNX__)\\n- RETURN_SKIP(\\\"Setting time to a negative value is unsupported on QNX\\\");\\n-#endif\\n+\\n loop = uv_default_loop();\\n unlink(path);\\n r = uv_fs_open(NULL, &req, path, UV_FS_O_RDWR | UV_FS_O_CREAT,\\n@@ -2968,7 +2869,7 @@ TEST_FS_IMPL(fs_utime_round) {\\n \\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_stat_root) {\\n+TEST_IMPL(fs_stat_root) {\\n int r;\\n \\n r = uv_fs_stat(NULL, &stat_req, \\\"\\\\\\\\\\\", NULL);\\n@@ -2999,7 +2900,7 @@ TEST_FS_IMPL(fs_stat_root) {\\n #endif\\n \\n \\n-TEST_FS_IMPL(fs_futime) {\\n+TEST_IMPL(fs_futime) {\\n utime_check_t checkme;\\n const char* path = \\\"test_file\\\";\\n double atime;\\n@@ -3097,7 +2998,7 @@ TEST_FS_IMPL(fs_futime) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_lutime) {\\n+TEST_IMPL(fs_lutime) {\\n utime_check_t checkme;\\n const char* path = \\\"test_file\\\";\\n const char* symlink_path = \\\"test_file_symlink\\\";\\n@@ -3204,7 +3105,7 @@ TEST_FS_IMPL(fs_lutime) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_stat_missing_path) {\\n+TEST_IMPL(fs_stat_missing_path) {\\n uv_fs_t req;\\n int r;\\n \\n@@ -3220,7 +3121,7 @@ TEST_FS_IMPL(fs_stat_missing_path) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_scandir_empty_dir) {\\n+TEST_IMPL(fs_scandir_empty_dir) {\\n const char* path;\\n uv_fs_t req;\\n uv_dirent_t dent;\\n@@ -3257,7 +3158,7 @@ TEST_FS_IMPL(fs_scandir_empty_dir) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_scandir_non_existent_dir) {\\n+TEST_IMPL(fs_scandir_non_existent_dir) {\\n const char* path;\\n uv_fs_t req;\\n uv_dirent_t dent;\\n@@ -3290,7 +3191,7 @@ TEST_FS_IMPL(fs_scandir_non_existent_dir) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_scandir_file) {\\n+TEST_IMPL(fs_scandir_file) {\\n const char* path;\\n int r;\\n \\n@@ -3314,7 +3215,7 @@ TEST_FS_IMPL(fs_scandir_file) {\\n \\n \\n /* Run in Valgrind. Should not leak when the iterator isn't exhausted. */\\n-TEST_FS_IMPL(fs_scandir_early_exit) {\\n+TEST_IMPL(fs_scandir_early_exit) {\\n uv_dirent_t d;\\n uv_fs_t req;\\n \\n@@ -3331,7 +3232,7 @@ TEST_FS_IMPL(fs_scandir_early_exit) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_open_dir) {\\n+TEST_IMPL(fs_open_dir) {\\n const char* path;\\n uv_fs_t req;\\n int r, file;\\n@@ -3428,7 +3329,7 @@ static void fs_file_open_append(int add_flags) {\\n /* Cleanup */\\n unlink(\\\"test_file\\\");\\n }\\n-TEST_FS_IMPL(fs_file_open_append) {\\n+TEST_IMPL(fs_file_open_append) {\\n fs_file_open_append(0);\\n fs_file_open_append(UV_FS_O_FILEMAP);\\n \\n@@ -3437,7 +3338,7 @@ TEST_FS_IMPL(fs_file_open_append) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_rename_to_existing_file) {\\n+TEST_IMPL(fs_rename_to_existing_file) {\\n int r;\\n \\n /* Setup. */\\n@@ -3555,7 +3456,7 @@ static void fs_read_bufs(int add_flags) {\\n ASSERT_OK(close_req.result);\\n uv_fs_req_cleanup(&close_req);\\n }\\n-TEST_FS_IMPL(fs_read_bufs) {\\n+TEST_IMPL(fs_read_bufs) {\\n fs_read_bufs(0);\\n fs_read_bufs(UV_FS_O_FILEMAP);\\n \\n@@ -3622,7 +3523,7 @@ static void fs_read_file_eof(int add_flags) {\\n /* Cleanup */\\n unlink(\\\"test_file\\\");\\n }\\n-TEST_FS_IMPL(fs_read_file_eof) {\\n+TEST_IMPL(fs_read_file_eof) {\\n fs_read_file_eof(0);\\n fs_read_file_eof(UV_FS_O_FILEMAP);\\n \\n@@ -3717,7 +3618,7 @@ static void fs_write_multiple_bufs(int add_flags) {\\n /* Cleanup */\\n unlink(\\\"test_file\\\");\\n }\\n-TEST_FS_IMPL(fs_write_multiple_bufs) {\\n+TEST_IMPL(fs_write_multiple_bufs) {\\n fs_write_multiple_bufs(0);\\n fs_write_multiple_bufs(UV_FS_O_FILEMAP);\\n \\n@@ -3825,7 +3726,7 @@ static void fs_write_alotof_bufs(int add_flags) {\\n unlink(\\\"test_file\\\");\\n free(iovs);\\n }\\n-TEST_FS_IMPL(fs_write_alotof_bufs) {\\n+TEST_IMPL(fs_write_alotof_bufs) {\\n fs_write_alotof_bufs(0);\\n fs_write_alotof_bufs(UV_FS_O_FILEMAP);\\n \\n@@ -3941,15 +3842,15 @@ static void fs_write_alotof_bufs_with_offset(int add_flags) {\\n unlink(\\\"test_file\\\");\\n free(iovs);\\n }\\n-TEST_FS_IMPL(fs_write_alotof_bufs_with_offset) {\\n+TEST_IMPL(fs_write_alotof_bufs_with_offset) {\\n fs_write_alotof_bufs_with_offset(0);\\n fs_write_alotof_bufs_with_offset(UV_FS_O_FILEMAP);\\n \\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_read_dir) {\\n+TEST_IMPL(fs_read_dir) {\\n int r;\\n char buf[2];\\n loop = uv_default_loop();\\n@@ -3988,12 +3889,6 @@ TEST_FS_IMPL(fs_read_dir) {\\n * created on. That is why this assertion is a bit lenient.\\n */\\n ASSERT((r >= 0) || (r == UV_EISDIR));\\n-#elif defined(__QNX__)\\n- /*\\n- * If UV_FS_O_DIRECTORY is supplied, QNX returns ENOSYS. Otherwise\\n- * UV_EISDIR is returned. Here we are lenient and accept both.\\n- */\\n- ASSERT((r == UV_ENOSYS) || (r == UV_EISDIR));\\n #else\\n ASSERT_EQ(r, UV_EISDIR);\\n #endif\\n@@ -4012,11 +3907,11 @@ TEST_FS_IMPL(fs_read_dir) {\\n \\n #ifdef _WIN32\\n \\n-TEST_FS_IMPL(fs_partial_read) {\\n+TEST_IMPL(fs_partial_read) {\\n RETURN_SKIP(\\\"Test not implemented on Windows.\\\");\\n }\\n \\n-TEST_FS_IMPL(fs_partial_write) {\\n+TEST_IMPL(fs_partial_write) {\\n RETURN_SKIP(\\\"Test not implemented on Windows.\\\");\\n }\\n \\n@@ -4168,19 +4063,19 @@ static void test_fs_partial(int doread) {\\n MAKE_VALGRIND_HAPPY(loop);\\n }\\n \\n-TEST_FS_IMPL(fs_partial_read) {\\n+TEST_IMPL(fs_partial_read) {\\n test_fs_partial(1);\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_partial_write) {\\n+TEST_IMPL(fs_partial_write) {\\n test_fs_partial(0);\\n return 0;\\n }\\n \\n #endif/* _WIN32 */\\n \\n-TEST_FS_IMPL(fs_read_write_null_arguments) {\\n+TEST_IMPL(fs_read_write_null_arguments) {\\n int r;\\n \\n r = uv_fs_read(NULL, &read_req, 0, NULL, 0, -1, NULL);\\n@@ -4243,7 +4138,7 @@ TEST_FS_IMPL(fs_read_write_null_arguments) {\\n }\\n \\n \\n-TEST_FS_IMPL(get_osfhandle_valid_handle) {\\n+TEST_IMPL(get_osfhandle_valid_handle) {\\n int r;\\n uv_os_fd_t fd;\\n \\n@@ -4279,7 +4174,7 @@ TEST_FS_IMPL(get_osfhandle_valid_handle) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(open_osfhandle_valid_handle) {\\n+TEST_IMPL(open_osfhandle_valid_handle) {\\n int r;\\n uv_os_fd_t handle;\\n int fd;\\n@@ -4325,7 +4220,7 @@ TEST_FS_IMPL(open_osfhandle_valid_handle) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_file_pos_after_op_with_offset) {\\n+TEST_IMPL(fs_file_pos_after_op_with_offset) {\\n int r;\\n \\n /* Setup. */\\n@@ -4454,7 +4349,7 @@ static void fs_file_pos_write(int add_flags) {\\n \\n fs_file_pos_close_check(\\\"aecd\\\", 4);\\n }\\n-TEST_FS_IMPL(fs_file_pos_write) {\\n+TEST_IMPL(fs_file_pos_write) {\\n fs_file_pos_write(0);\\n fs_file_pos_write(UV_FS_O_FILEMAP);\\n \\n@@ -4494,7 +4389,7 @@ static void fs_file_pos_append(int add_flags) {\\n \\n fs_file_pos_close_check(\\\"abcde\\\", 5);\\n }\\n-TEST_FS_IMPL(fs_file_pos_append) {\\n+TEST_IMPL(fs_file_pos_append) {\\n fs_file_pos_append(0);\\n fs_file_pos_append(UV_FS_O_FILEMAP);\\n \\n@@ -4503,7 +4398,7 @@ TEST_FS_IMPL(fs_file_pos_append) {\\n }\\n #endif\\n \\n-TEST_FS_IMPL(fs_null_req) {\\n+TEST_IMPL(fs_null_req) {\\n /* Verify that all fs functions return UV_EINVAL when the request is NULL. */\\n int r;\\n \\n@@ -4607,7 +4502,7 @@ TEST_FS_IMPL(fs_null_req) {\\n }\\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_exclusive_sharing_mode) {\\n+TEST_IMPL(fs_exclusive_sharing_mode) {\\n int r;\\n \\n /* Setup. */\\n@@ -4662,7 +4557,7 @@ TEST_FS_IMPL(fs_exclusive_sharing_mode) {\\n #endif\\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_file_flag_no_buffering) {\\n+TEST_IMPL(fs_file_flag_no_buffering) {\\n int r;\\n \\n /* Setup. */\\n@@ -4719,7 +4614,7 @@ int call_icacls(const char* command, ...) {\\n return system(icacls_command);\\n }\\n \\n-TEST_FS_IMPL(fs_open_readonly_acl) {\\n+TEST_IMPL(fs_open_readonly_acl) {\\n uv_passwd_t pwd;\\n uv_fs_t req;\\n int r;\\n@@ -4794,7 +4689,7 @@ TEST_FS_IMPL(fs_open_readonly_acl) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_stat_no_permission) {\\n+TEST_IMPL(fs_stat_no_permission) {\\n uv_passwd_t pwd;\\n uv_fs_t req;\\n int r;\\n@@ -4850,7 +4745,7 @@ TEST_FS_IMPL(fs_stat_no_permission) {\\n #endif\\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_fchmod_archive_readonly) {\\n+TEST_IMPL(fs_fchmod_archive_readonly) {\\n uv_fs_t req;\\n uv_file file;\\n int r;\\n@@ -4895,7 +4790,7 @@ TEST_FS_IMPL(fs_fchmod_archive_readonly) {\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_invalid_mkdir_name) {\\n+TEST_IMPL(fs_invalid_mkdir_name) {\\n uv_loop_t* loop;\\n uv_fs_t req;\\n int r;\\n@@ -4909,49 +4804,29 @@ TEST_FS_IMPL(fs_invalid_mkdir_name) {\\n }\\n #endif\\n \\n-TEST_FS_IMPL(fs_statfs) {\\n+TEST_IMPL(fs_statfs) {\\n uv_fs_t req;\\n- uv_fs_t req1;\\n int r;\\n \\n- /* Setup. */\\n- unlink(\\\"test_file\\\");\\n-\\n- r = uv_fs_open(NULL, &req, \\\"test_file\\\", UV_FS_O_WRONLY | UV_FS_O_CREAT,\\n- S_IRUSR | S_IWUSR, NULL);\\n- ASSERT_GT(r, 0);\\n-\\n- uv_fs_req_cleanup(&req);\\n-\\n- r = uv_fs_close(NULL, &req, req.result, NULL);\\n- ASSERT_OK(r);\\n-\\n- uv_fs_req_cleanup(&req);\\n-\\n loop = uv_default_loop();\\n \\n- /* Test the synchronous version for both a directory and a file. */\\n+ /* Test the synchronous version. */\\n r = uv_fs_statfs(NULL, &req, \\\".\\\", NULL);\\n ASSERT_OK(r);\\n statfs_cb(&req);\\n- r = uv_fs_statfs(NULL, &req, \\\"test_file\\\", NULL);\\n- ASSERT_OK(r);\\n- statfs_cb(&req);\\n- ASSERT_EQ(2, statfs_cb_count);\\n+ ASSERT_EQ(1, statfs_cb_count);\\n \\n- /* Test the asynchronous version too. */\\n+ /* Test the asynchronous version. */\\n r = uv_fs_statfs(loop, &req, \\\".\\\", statfs_cb);\\n ASSERT_OK(r);\\n- r = uv_fs_statfs(loop, &req1, \\\"test_file\\\", statfs_cb);\\n- ASSERT_OK(r);\\n uv_run(loop, UV_RUN_DEFAULT);\\n- ASSERT_EQ(4, statfs_cb_count);\\n+ ASSERT_EQ(2, statfs_cb_count);\\n \\n MAKE_VALGRIND_HAPPY(loop);\\n return 0;\\n }\\n \\n-TEST_FS_IMPL(fs_get_system_error) {\\n+TEST_IMPL(fs_get_system_error) {\\n uv_fs_t req;\\n int r;\\n int system_error;\\n@@ -4970,7 +4845,7 @@ TEST_FS_IMPL(fs_get_system_error) {\\n }\\n \\n \\n-TEST_FS_IMPL(fs_stat_batch_multiple) {\\n+TEST_IMPL(fs_stat_batch_multiple) {\\n uv_fs_t req[300];\\n int r;\\n int i;\\n@@ -4996,7 +4871,7 @@ TEST_FS_IMPL(fs_stat_batch_multiple) {\\n \\n \\n #ifdef _WIN32\\n-TEST_FS_IMPL(fs_wtf) {\\n+TEST_IMPL(fs_wtf) {\\n int r;\\n HANDLE file_handle;\\n uv_dirent_t dent;\",\n \"additions\": 85,\n \"deletions\": 210\n },\n {\n \"filename\": \"deps/uv/test/test-get-currentexe.c\",\n \"patch\": \"@@ -35,6 +35,9 @@ TEST_IMPL(get_currentexe) {\\n #if defined(__QEMU__)\\n RETURN_SKIP(\\\"Test does not currently work in QEMU\\\");\\n #endif\\n+#if defined(__OpenBSD__)\\n+ RETURN_SKIP(\\\"Test does not currently work in OpenBSD\\\");\\n+#endif\\n \\n char buffer[PATHMAX];\\n char path[PATHMAX];\",\n \"additions\": 3,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/test/test-getaddrinfo.c\",\n \"patch\": \"@@ -119,7 +119,7 @@ TEST_IMPL(getaddrinfo_fail_sync) {\\n uv_getaddrinfo_t req;\\n \\n /* Use a FQDN by ending in a period */\\n- ASSERT_GT(0, uv_getaddrinfo(NULL,\\n+ ASSERT_GT(0, uv_getaddrinfo(uv_default_loop(),\\n &req,\\n NULL,\\n \\\"example.invalid.\\\",\\n@@ -165,13 +165,15 @@ TEST_IMPL(getaddrinfo_basic_sync) {\\n #endif\\n uv_getaddrinfo_t req;\\n \\n- ASSERT_OK(uv_getaddrinfo(NULL,\\n+ ASSERT_OK(uv_getaddrinfo(uv_default_loop(),\\n &req,\\n NULL,\\n name,\\n NULL,\\n NULL));\\n uv_freeaddrinfo(req.addrinfo);\\n+\\n+ MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n }\\n \",\n \"additions\": 4,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/test/test-idna.c\",\n \"patch\": \"@@ -19,14 +19,6 @@\\n * IN THE SOFTWARE.\\n */\\n \\n-/* This blank UV_EXTERN squelches \\\"‘uv_wtf8_to_utf16’ redeclared without\\n- * dllimport attribute: previous dllimport ignored\\\" warnings. We neither want\\n- * or need dllimport or dllexport, we just include the source file verbatim.\\n- * It's kind of sloppy because we end up with duplicate symbols, one in\\n- * libuv.dll and one in this translation unit, but it works out fine in\\n- * the end.\\n- */\\n-#define UV_EXTERN\\n #include \\\"task.h\\\"\\n #define uv__malloc malloc\\n #include \\\"../src/idna.c\\\"\\n@@ -236,13 +228,5 @@ TEST_IMPL(wtf8) {\\n ASSERT_GT(len, 0);\\n ASSERT_LT(len, ARRAY_SIZE(buf));\\n uv_wtf8_to_utf16(input, buf, len);\\n-\\n- /* Test 0x10FFFF, max unicode character */\\n- static const char input_max[] = \\\"\\\\xF4\\\\x8F\\\\xBF\\\\xBF\\\";\\n-\\n- len = uv_wtf8_length_as_utf16(input_max);\\n- ASSERT_GT(len, 0);\\n- ASSERT_LT(len, ARRAY_SIZE(buf));\\n- uv_wtf8_to_utf16(input_max, buf, len);\\n return 0;\\n }\",\n \"additions\": 0,\n \"deletions\": 16\n },\n {\n \"filename\": \"deps/uv/test/test-list.h\",\n \"patch\": \"@@ -77,7 +77,6 @@ TEST_DECLARE (tty_escape_sequence_processing)\\n #endif\\n TEST_DECLARE (tty_file)\\n TEST_DECLARE (tty_pty)\\n-TEST_DECLARE (tty_pty_partial)\\n TEST_DECLARE (stdio_over_pipes)\\n TEST_DECLARE (stdio_emulate_iocp)\\n TEST_DECLARE (ip6_pton)\\n@@ -176,10 +175,6 @@ TEST_DECLARE (udp_send_and_recv)\\n TEST_DECLARE (udp_send_hang_loop)\\n TEST_DECLARE (udp_send_immediate)\\n TEST_DECLARE (udp_send_unreachable)\\n-TEST_DECLARE (udp_recv_cb_close_pollerr)\\n-TEST_DECLARE (udp_recvmsg_unreachable_error)\\n-TEST_DECLARE (udp_recvmsg_unreachable_error6)\\n-TEST_DECLARE (udp_send_pollerr_no_recv)\\n TEST_DECLARE (udp_mmsg)\\n TEST_DECLARE (udp_multicast_join)\\n TEST_DECLARE (udp_multicast_join6)\\n@@ -357,54 +352,53 @@ TEST_DECLARE (fs_poll_close_request_multi_stop_start)\\n TEST_DECLARE (fs_poll_close_request_stop_when_active)\\n TEST_DECLARE (kill)\\n TEST_DECLARE (kill_invalid_signum)\\n-TEST_FS_DECLARE (fs_file_noent)\\n-TEST_FS_DECLARE (fs_file_nametoolong)\\n-TEST_FS_DECLARE (fs_file_loop)\\n-TEST_FS_DECLARE (fs_file_async)\\n-TEST_FS_DECLARE (fs_file_sync)\\n-TEST_FS_DECLARE (fs_posix_delete)\\n-TEST_FS_DECLARE (fs_file_write_null_buffer)\\n-TEST_FS_DECLARE (fs_async_dir)\\n-TEST_FS_DECLARE (fs_async_sendfile)\\n-TEST_FS_DECLARE (fs_async_sendfile_nodata)\\n-TEST_FS_DECLARE (fs_mkdtemp)\\n-TEST_FS_DECLARE (fs_mkstemp)\\n-TEST_FS_DECLARE (fs_fstat)\\n-TEST_FS_DECLARE (fs_fstat_stdio)\\n-TEST_FS_DECLARE (fs_fstat_st_dev)\\n-TEST_FS_DECLARE (fs_access)\\n-TEST_FS_DECLARE (fs_chmod)\\n-TEST_FS_DECLARE (fs_copyfile)\\n-TEST_FS_DECLARE (fs_unlink_readonly)\\n+TEST_DECLARE (fs_file_noent)\\n+TEST_DECLARE (fs_file_nametoolong)\\n+TEST_DECLARE (fs_file_loop)\\n+TEST_DECLARE (fs_file_async)\\n+TEST_DECLARE (fs_file_sync)\\n+TEST_DECLARE (fs_posix_delete)\\n+TEST_DECLARE (fs_file_write_null_buffer)\\n+TEST_DECLARE (fs_async_dir)\\n+TEST_DECLARE (fs_async_sendfile)\\n+TEST_DECLARE (fs_async_sendfile_nodata)\\n+TEST_DECLARE (fs_mkdtemp)\\n+TEST_DECLARE (fs_mkstemp)\\n+TEST_DECLARE (fs_fstat)\\n+TEST_DECLARE (fs_fstat_stdio)\\n+TEST_DECLARE (fs_fstat_st_dev)\\n+TEST_DECLARE (fs_access)\\n+TEST_DECLARE (fs_chmod)\\n+TEST_DECLARE (fs_copyfile)\\n+TEST_DECLARE (fs_unlink_readonly)\\n #ifdef _WIN32\\n-TEST_FS_DECLARE (fs_unlink_archive_readonly)\\n+TEST_DECLARE (fs_unlink_archive_readonly)\\n #endif\\n-TEST_FS_DECLARE (fs_chown)\\n-TEST_FS_DECLARE (fs_link)\\n-TEST_FS_DECLARE (fs_readlink)\\n-TEST_FS_DECLARE (fs_realpath)\\n-TEST_FS_DECLARE (fs_symlink)\\n-TEST_FS_DECLARE (fs_symlink_dir)\\n+TEST_DECLARE (fs_chown)\\n+TEST_DECLARE (fs_link)\\n+TEST_DECLARE (fs_readlink)\\n+TEST_DECLARE (fs_realpath)\\n+TEST_DECLARE (fs_symlink)\\n+TEST_DECLARE (fs_symlink_dir)\\n #ifdef _WIN32\\n-TEST_FS_DECLARE (fs_symlink_junction)\\n-TEST_FS_DECLARE (fs_non_symlink_reparse_point)\\n-TEST_FS_DECLARE (fs_readlink_lx_symlink)\\n-TEST_FS_DECLARE (fs_lstat_windows_store_apps)\\n-TEST_FS_DECLARE (fs_open_flags)\\n+TEST_DECLARE (fs_symlink_junction)\\n+TEST_DECLARE (fs_non_symlink_reparse_point)\\n+TEST_DECLARE (fs_lstat_windows_store_apps)\\n+TEST_DECLARE (fs_open_flags)\\n #endif\\n #if defined(_WIN32) && !defined(USING_UV_SHARED)\\n-TEST_FS_DECLARE (fs_fd_hash)\\n+TEST_DECLARE (fs_fd_hash)\\n #endif\\n-TEST_FS_DECLARE (fs_utime)\\n-TEST_FS_DECLARE (fs_utime_round)\\n-TEST_FS_DECLARE (fs_futime)\\n-TEST_FS_DECLARE (fs_lutime)\\n-TEST_FS_DECLARE (fs_file_open_append)\\n-TEST_FS_DECLARE (fs_statfs)\\n-TEST_FS_DECLARE (fs_stat_batch_multiple)\\n-TEST_FS_DECLARE (fs_stat_missing_path)\\n-TEST_FS_DECLARE (fs_read_bufs)\\n-TEST_FS_DECLARE (fs_read_file_eof)\\n+TEST_DECLARE (fs_utime)\\n+TEST_DECLARE (fs_utime_round)\\n+TEST_DECLARE (fs_futime)\\n+TEST_DECLARE (fs_lutime)\\n+TEST_DECLARE (fs_file_open_append)\\n+TEST_DECLARE (fs_statfs)\\n+TEST_DECLARE (fs_stat_batch_multiple)\\n+TEST_DECLARE (fs_stat_missing_path)\\n+TEST_DECLARE (fs_read_bufs)\\n+TEST_DECLARE (fs_read_file_eof)\\n TEST_DECLARE (fs_event_watch_dir)\\n TEST_DECLARE (fs_event_watch_delete_dir)\\n TEST_DECLARE (fs_event_watch_dir_recursive)\\n@@ -428,41 +422,41 @@ TEST_DECLARE (fs_event_close_in_callback)\\n TEST_DECLARE (fs_event_start_and_close)\\n TEST_DECLARE (fs_event_getpath)\\n TEST_DECLARE (fs_event_stop_in_cb)\\n-TEST_FS_DECLARE (fs_scandir_empty_dir)\\n-TEST_FS_DECLARE (fs_scandir_non_existent_dir)\\n-TEST_FS_DECLARE (fs_scandir_file)\\n-TEST_FS_DECLARE (fs_scandir_early_exit)\\n-TEST_FS_DECLARE (fs_open_dir)\\n-TEST_FS_DECLARE (fs_readdir_empty_dir)\\n-TEST_FS_DECLARE (fs_readdir_file)\\n-TEST_FS_DECLARE (fs_readdir_non_empty_dir)\\n-TEST_FS_DECLARE (fs_readdir_non_existing_dir)\\n+TEST_DECLARE (fs_scandir_empty_dir)\\n+TEST_DECLARE (fs_scandir_non_existent_dir)\\n+TEST_DECLARE (fs_scandir_file)\\n+TEST_DECLARE (fs_scandir_early_exit)\\n+TEST_DECLARE (fs_open_dir)\\n+TEST_DECLARE (fs_readdir_empty_dir)\\n+TEST_DECLARE (fs_readdir_file)\\n+TEST_DECLARE (fs_readdir_non_empty_dir)\\n+TEST_DECLARE (fs_readdir_non_existing_dir)\\n #ifdef _WIN32\\n-TEST_FS_DECLARE (fs_readdir_symlink)\\n+TEST_DECLARE (fs_readdir_symlink)\\n #endif\\n-TEST_FS_DECLARE (fs_rename_to_existing_file)\\n-TEST_FS_DECLARE (fs_write_multiple_bufs)\\n-TEST_FS_DECLARE (fs_read_write_null_arguments)\\n+TEST_DECLARE (fs_rename_to_existing_file)\\n+TEST_DECLARE (fs_write_multiple_bufs)\\n+TEST_DECLARE (fs_read_write_null_arguments)\\n TEST_DECLARE (get_osfhandle_valid_handle)\\n TEST_DECLARE (open_osfhandle_valid_handle)\\n-TEST_FS_DECLARE (fs_write_alotof_bufs)\\n-TEST_FS_DECLARE (fs_write_alotof_bufs_with_offset)\\n-TEST_FS_DECLARE (fs_partial_read)\\n-TEST_FS_DECLARE (fs_partial_write)\\n-TEST_FS_DECLARE (fs_file_pos_after_op_with_offset)\\n-TEST_FS_DECLARE (fs_null_req)\\n-TEST_FS_DECLARE (fs_read_dir)\\n+TEST_DECLARE (fs_write_alotof_bufs)\\n+TEST_DECLARE (fs_write_alotof_bufs_with_offset)\\n+TEST_DECLARE (fs_partial_read)\\n+TEST_DECLARE (fs_partial_write)\\n+TEST_DECLARE (fs_file_pos_after_op_with_offset)\\n+TEST_DECLARE (fs_null_req)\\n+TEST_DECLARE (fs_read_dir)\\n #ifdef _WIN32\\n-TEST_FS_DECLARE (fs_file_pos_write)\\n-TEST_FS_DECLARE (fs_file_pos_append)\\n-TEST_FS_DECLARE (fs_exclusive_sharing_mode)\\n-TEST_FS_DECLARE (fs_file_flag_no_buffering)\\n-TEST_FS_DECLARE (fs_open_readonly_acl)\\n-TEST_FS_DECLARE (fs_fchmod_archive_readonly)\\n-TEST_FS_DECLARE (fs_invalid_mkdir_name)\\n-TEST_FS_DECLARE (fs_wtf)\\n+TEST_DECLARE (fs_file_pos_write)\\n+TEST_DECLARE (fs_file_pos_append)\\n+TEST_DECLARE (fs_exclusive_sharing_mode)\\n+TEST_DECLARE (fs_file_flag_no_buffering)\\n+TEST_DECLARE (fs_open_readonly_acl)\\n+TEST_DECLARE (fs_fchmod_archive_readonly)\\n+TEST_DECLARE (fs_invalid_mkdir_name)\\n+TEST_DECLARE (fs_wtf)\\n #endif\\n-TEST_FS_DECLARE (fs_get_system_error)\\n+TEST_DECLARE (fs_get_system_error)\\n TEST_DECLARE (strscpy)\\n TEST_DECLARE (strtok)\\n TEST_DECLARE (threadpool_queue_work_simple)\\n@@ -472,7 +466,7 @@ TEST_DECLARE (threadpool_cancel_getaddrinfo)\\n TEST_DECLARE (threadpool_cancel_getnameinfo)\\n TEST_DECLARE (threadpool_cancel_random)\\n TEST_DECLARE (threadpool_cancel_work)\\n-TEST_FS_DECLARE (threadpool_cancel_fs)\\n+TEST_DECLARE (threadpool_cancel_fs)\\n TEST_DECLARE (threadpool_cancel_single)\\n TEST_DECLARE (threadpool_cancel_when_busy)\\n TEST_DECLARE (thread_detach)\\n@@ -523,8 +517,8 @@ TEST_DECLARE (environment_creation)\\n #endif\\n TEST_DECLARE (listen_with_simultaneous_accepts)\\n TEST_DECLARE (listen_no_simultaneous_accepts)\\n-TEST_FS_DECLARE (fs_stat_root)\\n-TEST_FS_DECLARE (fs_stat_no_permission)\\n+TEST_DECLARE (fs_stat_root)\\n+TEST_DECLARE (fs_stat_no_permission)\\n TEST_DECLARE (spawn_with_an_odd_path)\\n TEST_DECLARE (spawn_no_path)\\n TEST_DECLARE (spawn_no_ext)\\n@@ -668,7 +662,6 @@ TASK_LIST_START\\n #endif\\n TEST_ENTRY (tty_file)\\n TEST_ENTRY (tty_pty)\\n- TEST_ENTRY (tty_pty_partial)\\n TEST_ENTRY (stdio_over_pipes)\\n TEST_ENTRY (stdio_emulate_iocp)\\n TEST_ENTRY (ip6_pton)\\n@@ -812,10 +805,6 @@ TASK_LIST_START\\n TEST_ENTRY (udp_send_hang_loop)\\n TEST_ENTRY (udp_send_immediate)\\n TEST_ENTRY (udp_send_unreachable)\\n- TEST_ENTRY (udp_recv_cb_close_pollerr)\\n- TEST_ENTRY (udp_recvmsg_unreachable_error)\\n- TEST_ENTRY (udp_recvmsg_unreachable_error6)\\n- TEST_ENTRY (udp_send_pollerr_no_recv)\\n TEST_ENTRY (udp_dgram_too_big)\\n TEST_ENTRY (udp_dual_stack)\\n TEST_ENTRY (udp_ipv6_only)\\n@@ -1060,8 +1049,8 @@ TASK_LIST_START\\n # endif\\n TEST_ENTRY (listen_with_simultaneous_accepts)\\n TEST_ENTRY (listen_no_simultaneous_accepts)\\n- TEST_FS_ENTRY (fs_stat_root)\\n- TEST_FS_ENTRY (fs_stat_no_permission)\\n+ TEST_ENTRY (fs_stat_root)\\n+ TEST_ENTRY (fs_stat_no_permission)\\n TEST_ENTRY (spawn_with_an_odd_path)\\n TEST_ENTRY (spawn_no_path)\\n TEST_ENTRY (spawn_no_ext)\\n@@ -1085,54 +1074,53 @@ TASK_LIST_START\\n TEST_ENTRY (osx_select_many_fds)\\n #endif\\n \\n- TEST_FS_ENTRY (fs_file_noent)\\n- TEST_FS_ENTRY (fs_file_nametoolong)\\n- TEST_FS_ENTRY (fs_file_loop)\\n- TEST_FS_ENTRY(fs_file_async)\\n- TEST_FS_ENTRY (fs_file_sync)\\n- TEST_FS_ENTRY (fs_posix_delete)\\n- TEST_FS_ENTRY (fs_file_write_null_buffer)\\n- TEST_FS_ENTRY (fs_async_dir)\\n- TEST_FS_ENTRY (fs_async_sendfile)\\n- TEST_FS_ENTRY (fs_async_sendfile_nodata)\\n- TEST_FS_ENTRY (fs_mkdtemp)\\n- TEST_FS_ENTRY (fs_mkstemp)\\n- TEST_FS_ENTRY (fs_fstat)\\n- TEST_FS_ENTRY (fs_fstat_stdio)\\n- TEST_FS_ENTRY (fs_fstat_st_dev)\\n- TEST_FS_ENTRY (fs_access)\\n- TEST_FS_ENTRY (fs_chmod)\\n- TEST_FS_ENTRY (fs_copyfile)\\n- TEST_FS_ENTRY (fs_unlink_readonly)\\n+ TEST_ENTRY (fs_file_noent)\\n+ TEST_ENTRY (fs_file_nametoolong)\\n+ TEST_ENTRY (fs_file_loop)\\n+ TEST_ENTRY (fs_file_async)\\n+ TEST_ENTRY (fs_file_sync)\\n+ TEST_ENTRY (fs_posix_delete)\\n+ TEST_ENTRY (fs_file_write_null_buffer)\\n+ TEST_ENTRY (fs_async_dir)\\n+ TEST_ENTRY (fs_async_sendfile)\\n+ TEST_ENTRY (fs_async_sendfile_nodata)\\n+ TEST_ENTRY (fs_mkdtemp)\\n+ TEST_ENTRY (fs_mkstemp)\\n+ TEST_ENTRY (fs_fstat)\\n+ TEST_ENTRY (fs_fstat_stdio)\\n+ TEST_ENTRY (fs_fstat_st_dev)\\n+ TEST_ENTRY (fs_access)\\n+ TEST_ENTRY (fs_chmod)\\n+ TEST_ENTRY (fs_copyfile)\\n+ TEST_ENTRY (fs_unlink_readonly)\\n #ifdef _WIN32\\n- TEST_FS_ENTRY (fs_unlink_archive_readonly)\\n+ TEST_ENTRY (fs_unlink_archive_readonly)\\n #endif\\n- TEST_FS_ENTRY (fs_chown)\\n- TEST_FS_ENTRY (fs_link)\\n- TEST_FS_ENTRY (fs_utime)\\n- TEST_FS_ENTRY (fs_utime_round)\\n- TEST_FS_ENTRY (fs_futime)\\n- TEST_FS_ENTRY (fs_lutime)\\n- TEST_FS_ENTRY (fs_readlink)\\n- TEST_FS_ENTRY (fs_realpath)\\n- TEST_FS_ENTRY (fs_symlink)\\n- TEST_FS_ENTRY (fs_symlink_dir)\\n+ TEST_ENTRY (fs_chown)\\n+ TEST_ENTRY (fs_link)\\n+ TEST_ENTRY (fs_utime)\\n+ TEST_ENTRY (fs_utime_round)\\n+ TEST_ENTRY (fs_futime)\\n+ TEST_ENTRY (fs_lutime)\\n+ TEST_ENTRY (fs_readlink)\\n+ TEST_ENTRY (fs_realpath)\\n+ TEST_ENTRY (fs_symlink)\\n+ TEST_ENTRY (fs_symlink_dir)\\n #ifdef _WIN32\\n- TEST_FS_ENTRY (fs_symlink_junction)\\n- TEST_FS_ENTRY (fs_non_symlink_reparse_point)\\n- TEST_FS_ENTRY (fs_readlink_lx_symlink)\\n- TEST_FS_ENTRY (fs_lstat_windows_store_apps)\\n- TEST_FS_ENTRY (fs_open_flags)\\n+ TEST_ENTRY (fs_symlink_junction)\\n+ TEST_ENTRY (fs_non_symlink_reparse_point)\\n+ TEST_ENTRY (fs_lstat_windows_store_apps)\\n+ TEST_ENTRY (fs_open_flags)\\n #endif\\n #if defined(_WIN32) && !defined(USING_UV_SHARED)\\n- TEST_FS_ENTRY (fs_fd_hash)\\n+ TEST_ENTRY (fs_fd_hash)\\n #endif\\n- TEST_FS_ENTRY (fs_statfs)\\n- TEST_FS_ENTRY (fs_stat_batch_multiple)\\n- TEST_FS_ENTRY (fs_stat_missing_path)\\n- TEST_FS_ENTRY (fs_read_bufs)\\n- TEST_FS_ENTRY (fs_read_file_eof)\\n- TEST_FS_ENTRY (fs_file_open_append)\\n+ TEST_ENTRY (fs_statfs)\\n+ TEST_ENTRY (fs_stat_batch_multiple)\\n+ TEST_ENTRY (fs_stat_missing_path)\\n+ TEST_ENTRY (fs_read_bufs)\\n+ TEST_ENTRY (fs_read_file_eof)\\n+ TEST_ENTRY (fs_file_open_append)\\n TEST_ENTRY (fs_event_watch_dir)\\n TEST_ENTRY (fs_event_watch_delete_dir)\\n TEST_ENTRY (fs_event_watch_dir_recursive)\\n@@ -1156,39 +1144,39 @@ TASK_LIST_START\\n TEST_ENTRY (fs_event_start_and_close)\\n TEST_ENTRY (fs_event_getpath)\\n TEST_ENTRY (fs_event_stop_in_cb)\\n- TEST_FS_ENTRY (fs_scandir_empty_dir)\\n- TEST_FS_ENTRY (fs_scandir_non_existent_dir)\\n- TEST_FS_ENTRY (fs_scandir_file)\\n- TEST_FS_ENTRY (fs_scandir_early_exit)\\n- TEST_FS_ENTRY (fs_open_dir)\\n- TEST_FS_ENTRY (fs_readdir_empty_dir)\\n- TEST_FS_ENTRY (fs_readdir_file)\\n- TEST_FS_ENTRY (fs_readdir_non_empty_dir)\\n- TEST_FS_ENTRY (fs_readdir_non_existing_dir)\\n+ TEST_ENTRY (fs_scandir_empty_dir)\\n+ TEST_ENTRY (fs_scandir_non_existent_dir)\\n+ TEST_ENTRY (fs_scandir_file)\\n+ TEST_ENTRY (fs_scandir_early_exit)\\n+ TEST_ENTRY (fs_open_dir)\\n+ TEST_ENTRY (fs_readdir_empty_dir)\\n+ TEST_ENTRY (fs_readdir_file)\\n+ TEST_ENTRY (fs_readdir_non_empty_dir)\\n+ TEST_ENTRY (fs_readdir_non_existing_dir)\\n #ifdef _WIN32\\n- TEST_FS_ENTRY (fs_readdir_symlink)\\n+ TEST_ENTRY (fs_readdir_symlink)\\n #endif\\n- TEST_FS_ENTRY (fs_rename_to_existing_file)\\n- TEST_FS_ENTRY (fs_write_multiple_bufs)\\n- TEST_FS_ENTRY (fs_write_alotof_bufs)\\n- TEST_FS_ENTRY (fs_write_alotof_bufs_with_offset)\\n- TEST_FS_ENTRY (fs_partial_read)\\n- TEST_FS_ENTRY (fs_partial_write)\\n- TEST_FS_ENTRY (fs_read_write_null_arguments)\\n- TEST_FS_ENTRY (fs_file_pos_after_op_with_offset)\\n- TEST_FS_ENTRY (fs_null_req)\\n- TEST_FS_ENTRY (fs_read_dir)\\n+ TEST_ENTRY (fs_rename_to_existing_file)\\n+ TEST_ENTRY (fs_write_multiple_bufs)\\n+ TEST_ENTRY (fs_write_alotof_bufs)\\n+ TEST_ENTRY (fs_write_alotof_bufs_with_offset)\\n+ TEST_ENTRY (fs_partial_read)\\n+ TEST_ENTRY (fs_partial_write)\\n+ TEST_ENTRY (fs_read_write_null_arguments)\\n+ TEST_ENTRY (fs_file_pos_after_op_with_offset)\\n+ TEST_ENTRY (fs_null_req)\\n+ TEST_ENTRY (fs_read_dir)\\n #ifdef _WIN32\\n- TEST_FS_ENTRY (fs_file_pos_write)\\n- TEST_FS_ENTRY (fs_file_pos_append)\\n- TEST_FS_ENTRY (fs_exclusive_sharing_mode)\\n- TEST_FS_ENTRY (fs_file_flag_no_buffering)\\n- TEST_FS_ENTRY (fs_open_readonly_acl)\\n- TEST_FS_ENTRY (fs_fchmod_archive_readonly)\\n- TEST_FS_ENTRY (fs_invalid_mkdir_name)\\n- TEST_FS_ENTRY (fs_wtf)\\n+ TEST_ENTRY (fs_file_pos_write)\\n+ TEST_ENTRY (fs_file_pos_append)\\n+ TEST_ENTRY (fs_exclusive_sharing_mode)\\n+ TEST_ENTRY (fs_file_flag_no_buffering)\\n+ TEST_ENTRY (fs_open_readonly_acl)\\n+ TEST_ENTRY (fs_fchmod_archive_readonly)\\n+ TEST_ENTRY (fs_invalid_mkdir_name)\\n+ TEST_ENTRY (fs_wtf)\\n #endif\\n- TEST_FS_ENTRY (fs_get_system_error)\\n+ TEST_ENTRY (fs_get_system_error)\\n TEST_ENTRY (get_osfhandle_valid_handle)\\n TEST_ENTRY (open_osfhandle_valid_handle)\\n TEST_ENTRY (strscpy)\\n@@ -1200,7 +1188,7 @@ TASK_LIST_START\\n TEST_ENTRY (threadpool_cancel_getnameinfo)\\n TEST_ENTRY (threadpool_cancel_random)\\n TEST_ENTRY (threadpool_cancel_work)\\n- TEST_FS_ENTRY (threadpool_cancel_fs)\\n+ TEST_ENTRY (threadpool_cancel_fs)\\n TEST_ENTRY (threadpool_cancel_single)\\n TEST_ENTRY (threadpool_cancel_when_busy)\\n TEST_ENTRY (thread_detach)\",\n \"additions\": 146,\n \"deletions\": 158\n },\n {\n \"filename\": \"deps/uv/test/test-poll-oob.c\",\n \"patch\": \"@@ -91,8 +91,8 @@ static void poll_cb(uv_poll_t* handle, int status, int events) {\\n while (n == -1 && errno == EINTR);\\n ASSERT(n >= 0 || errno != EINVAL);\\n if (cli_rd_check == 1) {\\n- ASSERT_EQ(5, n);\\n ASSERT_OK(strncmp(buffer, \\\"world\\\", n));\\n+ ASSERT_EQ(5, n);\\n cli_rd_check = 2;\\n }\\n if (cli_rd_check == 0) {\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/test/test-poll.c\",\n \"patch\": \"@@ -83,9 +83,9 @@ static int closed_connections = 0;\\n static int valid_writable_wakeups = 0;\\n static int spurious_writable_wakeups = 0;\\n \\n-#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__) && !defined(__QNX__)\\n+#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__)\\n static int disconnects = 0;\\n-#endif /* !__sun && !_AIX && !__MVS__ && !__QNX__*/\\n+#endif /* !__sun && !_AIX && !__MVS__ */\\n \\n static int got_eagain(void) {\\n #ifdef _WIN32\\n@@ -409,17 +409,17 @@ static void connection_poll_cb(uv_poll_t* handle, int status, int events) {\\n new_events &= ~UV_WRITABLE;\\n }\\n }\\n-#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__) && !defined(__QNX__)\\n+#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__)\\n if (events & UV_DISCONNECT) {\\n context->got_disconnect = 1;\\n ++disconnects;\\n new_events &= ~UV_DISCONNECT;\\n }\\n \\n if (context->got_fin && context->sent_fin && context->got_disconnect) {\\n-#else /* __sun && _AIX && __MVS__ && __QNX__*/\\n+#else /* __sun && _AIX && __MVS__ */\\n if (context->got_fin && context->sent_fin) {\\n-#endif /* !__sun && !_AIX && !__MVS__ && !__QNX__ */\\n+#endif /* !__sun && !_AIX && !__MVS__ */\\n /* Sent and received FIN. Close and destroy context. */\\n close_socket(context->sock);\\n destroy_connection_context(context);\\n@@ -587,7 +587,7 @@ static void start_poll_test(void) {\\n spurious_writable_wakeups > 20, 0);\\n \\n ASSERT_EQ(closed_connections, NUM_CLIENTS * 2);\\n-#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__) && !defined(__QNX__)\\n+#if !defined(__sun) && !defined(_AIX) && !defined(__MVS__)\\n ASSERT_EQ(disconnects, NUM_CLIENTS * 2);\\n #endif\\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n@@ -633,12 +633,12 @@ TEST_IMPL(poll_unidirectional) {\\n * In addition to regular files, we also disallow FIFOs on Darwin.\\n */\\n #ifdef __APPLE__\\n-#define TEST_POLL_FIFO_PATH \\\"uv-test-poll-fifo\\\"\\n+#define TEST_POLL_FIFO_PATH \\\"/tmp/uv-test-poll-fifo\\\"\\n #endif\\n TEST_IMPL(poll_bad_fdtype) {\\n #if !defined(__sun) && \\\\\\n !defined(_AIX) && !defined(__MVS__) && \\\\\\n- !defined(__CYGWIN__) && !defined(__MSYS__) && !defined(__QNX__)\\n+ !defined(__CYGWIN__) && !defined(__MSYS__)\\n uv_poll_t poll_handle;\\n int fd[2];\\n \",\n \"additions\": 8,\n \"deletions\": 8\n },\n {\n \"filename\": \"deps/uv/test/test-process-priority.c\",\n \"patch\": \"@@ -28,9 +28,9 @@ TEST_IMPL(process_priority) {\\n int r;\\n int i;\\n \\n-#if defined(__MVS__) || defined(__QNX__)\\n+#if defined(__MVS__)\\n if (uv_os_setpriority(0, 0) == UV_ENOSYS)\\n- RETURN_SKIP(\\\"functionality not supported on zOS and QNX\\\");\\n+ RETURN_SKIP(\\\"functionality not supported on zOS\\\");\\n #endif\\n \\n /* Verify that passing a NULL pointer returns UV_EINVAL. */\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/test/test-process-title-threadsafe.c\",\n \"patch\": \"@@ -85,18 +85,10 @@ TEST_IMPL(process_title_threadsafe) {\\n int i;\\n \\n #if defined(__sun) || defined(__CYGWIN__) || defined(__MSYS__) || \\\\\\n- defined(__MVS__) || defined(__PASE__) || defined(__QNX__)\\n+ defined(__MVS__) || defined(__PASE__)\\n RETURN_SKIP(\\\"uv_(get|set)_process_title is not implemented.\\\");\\n #endif\\n \\n-#if defined(__ASAN__) && defined(__APPLE__)\\n- /* uv_set_process_title loads and unloads a bunch of dynamic libraries,\\n- * and that's quite slow and prone to time out when running concurrently\\n- * under AddressSanitizer.\\n- */\\n- RETURN_SKIP(\\\"too slow under ASAN\\\");\\n-#endif\\n-\\n ASSERT_OK(uv_set_process_title(titles[0]));\\n \\n ASSERT_OK(uv_sem_init(&getter_sem, 0));\",\n \"additions\": 1,\n \"deletions\": 9\n },\n {\n \"filename\": \"deps/uv/test/test-process-title.c\",\n \"patch\": \"@@ -61,7 +61,7 @@ static void uv_get_process_title_edge_cases(void) {\\n \\n TEST_IMPL(process_title) {\\n #if defined(__sun) || defined(__CYGWIN__) || defined(__MSYS__) || \\\\\\n- defined(__PASE__) || defined(__QNX__)\\n+ defined(__PASE__)\\n RETURN_SKIP(\\\"uv_(get|set)_process_title is not implemented.\\\");\\n #endif\\n \",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"deps/uv/test/test-spawn.c\",\n \"patch\": \"@@ -1678,10 +1678,7 @@ TEST_IMPL(spawn_fs_open) {\\n #ifdef _WIN32\\n const char dev_null[] = \\\"NUL\\\";\\n HMODULE kernelbase_module;\\n- union {\\n- FARPROC proc;\\n- sCompareObjectHandles pCompareObjectHandles; /* Windows >= 10 */\\n- } u;\\n+ sCompareObjectHandles pCompareObjectHandles; /* function introduced in Windows 10 */\\n #else\\n const char dev_null[] = \\\"/dev/null\\\";\\n #endif\\n@@ -1704,10 +1701,12 @@ TEST_IMPL(spawn_fs_open) {\\n #ifdef _WIN32\\n ASSERT_NE(0, DuplicateHandle(GetCurrentProcess(), fd, GetCurrentProcess(), &dup_fd,\\n 0, /* inherit */ TRUE, DUPLICATE_SAME_ACCESS));\\n- kernelbase_module = GetModuleHandleW(L\\\"kernelbase.dll\\\");\\n- u.proc = GetProcAddress(kernelbase_module, \\\"CompareObjectHandles\\\");\\n- if (u.pCompareObjectHandles != NULL)\\n- ASSERT_EQ(TRUE, u.pCompareObjectHandles(fd, dup_fd));\\n+ kernelbase_module = GetModuleHandleA(\\\"kernelbase.dll\\\");\\n+ pCompareObjectHandles = (sCompareObjectHandles)\\n+ GetProcAddress(kernelbase_module, \\\"CompareObjectHandles\\\");\\n+ ASSERT_NE(pCompareObjectHandles == NULL ||\\n+ pCompareObjectHandles(fd, dup_fd),\\n+ 0);\\n #else\\n dup_fd = dup(fd);\\n #endif\",\n \"additions\": 7,\n \"deletions\": 8\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-close-accept.c\",\n \"patch\": \"@@ -69,8 +69,8 @@ static void connect_cb(uv_connect_t* req, int status) {\\n }\\n \\n ASSERT_OK(status);\\n- ASSERT_PTR_LE(connect_reqs, req);\\n- ASSERT_PTR_LE(req, connect_reqs + ARRAY_SIZE(connect_reqs));\\n+ ASSERT_LE(connect_reqs, req);\\n+ ASSERT_LE(req, connect_reqs + ARRAY_SIZE(connect_reqs));\\n i = req - connect_reqs;\\n \\n buf = uv_buf_init(\\\"x\\\", 1);\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-connect-error-after-write.c\",\n \"patch\": \"@@ -26,17 +26,6 @@\\n #include <stdlib.h>\\n #include <string.h>\\n \\n-#ifdef _WIN32\\n-/*\\n- * Try to connect to an address on which nothing listens, get ECONNREFUSED\\n- * (uv errno 12) and get connect_cb() called once with status != 0.\\n- * Related issue: https://github.com/joyent/libuv/issues/443\\n- */\\n-TEST_IMPL(tcp_connect_error_after_write) {\\n- RETURN_SKIP(\\\"This test is disabled on Windows. \\\"\\n- \\\"See https://github.com/joyent/libuv/issues/444\\\\n\\\");\\n-}\\n-#else /* !_WIN32 */\\n static int connect_cb_called;\\n static int write_cb_called;\\n static int close_cb_called;\\n@@ -66,6 +55,11 @@ static void write_cb(uv_write_t* req, int status) {\\n * Related issue: https://github.com/joyent/libuv/issues/443\\n */\\n TEST_IMPL(tcp_connect_error_after_write) {\\n+#ifdef _WIN32\\n+ RETURN_SKIP(\\\"This test is disabled on Windows for now. \\\"\\n+ \\\"See https://github.com/joyent/libuv/issues/444\\\\n\\\");\\n+#else\\n+\\n uv_connect_t connect_req;\\n struct sockaddr_in addr;\\n uv_write_t write_req;\\n@@ -100,5 +94,5 @@ TEST_IMPL(tcp_connect_error_after_write) {\\n \\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n+#endif\\n }\\n-#endif /* !_WIN32 */\",\n \"additions\": 6,\n \"deletions\": 12\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-flags.c\",\n \"patch\": \"@@ -49,21 +49,6 @@ TEST_IMPL(tcp_flags) {\\n r = uv_tcp_keepalive(&handle, 1, 0);\\n ASSERT_EQ(r, UV_EINVAL);\\n \\n- r = uv_tcp_keepalive_ex(&handle, 1, 60, 60, 60);\\n- ASSERT_OK(r);\\n-\\n- r = uv_tcp_keepalive_ex(&handle, 0, 0, 0, 0);\\n- ASSERT_OK(r);\\n-\\n- r = uv_tcp_keepalive_ex(&handle, 1, 0, 10, 10);\\n- ASSERT_EQ(r, UV_EINVAL);\\n-\\n- r = uv_tcp_keepalive_ex(&handle, 1, 10, 0, 10);\\n- ASSERT_EQ(r, UV_EINVAL);\\n-\\n- r = uv_tcp_keepalive_ex(&handle, 1, 10, 10, 0);\\n- ASSERT_EQ(r, UV_EINVAL);\\n-\\n uv_close((uv_handle_t*)&handle, NULL);\\n \\n r = uv_run(loop, UV_RUN_DEFAULT);\",\n \"additions\": 0,\n \"deletions\": 15\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-reuseport.c\",\n \"patch\": \"@@ -178,17 +178,6 @@ TEST_IMPL(tcp_reuseport) {\\n int r;\\n int i;\\n \\n-#if defined(__QEMU__)\\n- /* QEMU's user-mode emulator sometimes runs threads in sequence\\n- * instead of in parallel and that throws off the test.\\n- * See https://github.com/libuv/libuv/issues/4777.\\n- */\\n- RETURN_SKIP(\\\"Unreliable under QEMU\\\");\\n-#endif /* defined(__QEMU__) */\\n-\\n- if (uv_available_parallelism() < 2)\\n- RETURN_SKIP(\\\"Unreliable without thread parallelism\\\");\\n-\\n r = uv_mutex_init(&mutex);\\n ASSERT_OK(r);\\n \",\n \"additions\": 0,\n \"deletions\": 11\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-rst.c\",\n \"patch\": \"@@ -22,11 +22,6 @@\\n #include \\\"uv.h\\\"\\n #include \\\"task.h\\\"\\n \\n-#ifdef _WIN32\\n-TEST_IMPL(tcp_rst) {\\n- RETURN_SKIP(\\\"Unix only test\\\");\\n-}\\n-#else /* !_WIN32 */\\n static uv_tcp_t tcp;\\n static uv_connect_t connect_req;\\n static uv_buf_t qbuf;\\n@@ -81,12 +76,12 @@ static void connect_cb(uv_connect_t *req, int status) {\\n * RST. Test checks that uv_guess_handle still works on a reset TCP handle.\\n */\\n TEST_IMPL(tcp_rst) {\\n- struct sockaddr_in server_addr;\\n- int r;\\n-\\n #if defined(__OpenBSD__)\\n RETURN_SKIP(\\\"Test does not currently work in OpenBSD\\\");\\n #endif\\n+#ifndef _WIN32\\n+ struct sockaddr_in server_addr;\\n+ int r;\\n \\n qbuf.base = \\\"QSH\\\";\\n qbuf.len = 3;\\n@@ -109,5 +104,7 @@ TEST_IMPL(tcp_rst) {\\n \\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n+#else\\n+ RETURN_SKIP(\\\"Unix only test\\\");\\n+#endif\\n }\\n-#endif /* !_WIN32 */\",\n \"additions\": 6,\n \"deletions\": 9\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-write-fail.c\",\n \"patch\": \"@@ -91,28 +91,13 @@ static void connect_cb(uv_connect_t* req, int status) {\\n TEST_IMPL(tcp_write_fail) {\\n struct sockaddr_in addr;\\n uv_tcp_t client;\\n- uv_buf_t buf;\\n int r;\\n \\n ASSERT_OK(uv_ip4_addr(\\\"127.0.0.1\\\", TEST_PORT, &addr));\\n \\n r = uv_tcp_init(uv_default_loop(), &client);\\n ASSERT_OK(r);\\n \\n- r = uv_write(&write_req,\\n- (uv_stream_t*) &client,\\n- &buf,\\n- 0, /* Illegal. Worse, senseless. */\\n- write_cb);\\n- ASSERT_EQ(UV_EINVAL, r);\\n-\\n- r = uv_write(&write_req,\\n- (uv_stream_t*) &client,\\n- &buf,\\n- -42, /* Undergoes sign conversion. */\\n- write_cb);\\n- ASSERT_EQ(UV_EINVAL, r);\\n-\\n r = uv_tcp_connect(&connect_req,\\n &client,\\n (const struct sockaddr*) &addr,\",\n \"additions\": 0,\n \"deletions\": 15\n },\n {\n \"filename\": \"deps/uv/test/test-tcp-write-in-a-row.c\",\n \"patch\": \"@@ -112,14 +112,13 @@ static void start_server(void) {\\n }\\n \\n TEST_IMPL(tcp_write_in_a_row) {\\n- uv_connect_t connect_req;\\n- struct sockaddr_in addr;\\n-\\n #if defined(_WIN32)\\n RETURN_SKIP(\\\"tcp_write_in_a_row does not work on Windows\\\");\\n #elif defined(__PASE__)\\n RETURN_SKIP(\\\"tcp_write_in_a_row does not work on IBM i PASE\\\");\\n-#endif\\n+#else\\n+ uv_connect_t connect_req;\\n+ struct sockaddr_in addr;\\n \\n start_server();\\n \\n@@ -140,4 +139,5 @@ TEST_IMPL(tcp_write_in_a_row) {\\n \\n MAKE_VALGRIND_HAPPY(uv_default_loop());\\n return 0;\\n+#endif\\n }\",\n \"additions\": 4,\n \"deletions\": 4\n },\n {\n \"filename\": \"deps/uv/test/test-thread-affinity.c\",\n \"patch\": \"@@ -56,7 +56,12 @@ TEST_IMPL(thread_affinity) {\\n int i;\\n uv_thread_t threads[3];\\n \\n+#ifdef _WIN32\\n+ /* uv_thread_self isn't defined for the main thread on Windows */\\n+ threads[0] = GetCurrentThread();\\n+#else\\n threads[0] = uv_thread_self();\\n+#endif\\n cpumasksize = uv_cpumask_size();\\n ASSERT_GT(cpumasksize, 0);\\n \",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/test/test-thread-name.c\",\n \"patch\": \"@@ -38,7 +38,12 @@ static void thread_run(void* arg) {\\n \\n sem = arg;\\n \\n+#ifdef _WIN32\\n+ /* uv_thread_self isn't defined for the main thread on Windows. */\\n+ thread = GetCurrentThread();\\n+#else\\n thread = uv_thread_self();\\n+#endif\\n \\n r = uv_thread_setname(\\\"worker-thread\\\");\\n ASSERT_OK(r);\\n@@ -77,7 +82,12 @@ TEST_IMPL(thread_name) {\\n memset(long_thread_name, 'a', sizeof(long_thread_name) - 1);\\n long_thread_name[sizeof(long_thread_name) - 1] = '\\\\0';\\n \\n+#ifdef _WIN32\\n+ /* uv_thread_self isn't defined for the main thread on Windows. */\\n+ threads[0] = GetCurrentThread();\\n+#else\\n threads[0] = uv_thread_self();\\n+#endif\\n \\n r = uv_thread_getname(&threads[0], tn, sizeof(tn));\\n ASSERT_OK(r);\",\n \"additions\": 10,\n \"deletions\": 0\n },\n {\n \"filename\": \"deps/uv/test/test-thread-priority.c\",\n \"patch\": \"@@ -88,6 +88,8 @@ TEST_IMPL(thread_priority) {\\n * test set nice value for the calling thread with default schedule policy\\n */\\n #ifdef __linux__\\n+ ASSERT_OK(uv_thread_getpriority(pthread_self(), &priority));\\n+ ASSERT_EQ(priority, 0);\\n ASSERT_OK(uv_thread_setpriority(pthread_self(), UV_THREAD_PRIORITY_LOWEST));\\n ASSERT_OK(uv_thread_getpriority(pthread_self(), &priority));\\n ASSERT_EQ(priority, (0 - UV_THREAD_PRIORITY_LOWEST * 2));\\n@@ -99,11 +101,5 @@ TEST_IMPL(thread_priority) {\\n \\n uv_sem_destroy(&sem);\\n \\n- /* Now that the thread no longer exists, verify that the relevant error is returned */\\n-#if !defined(__ANDROID__)\\n- ASSERT_EQ(UV_ESRCH, uv_thread_getpriority(task_id, &priority));\\n- ASSERT_EQ(UV_ESRCH, uv_thread_setpriority(task_id, UV_THREAD_PRIORITY_LOWEST));\\n-#endif\\n-\\n return 0;\\n-}\\n+}\\n\\\\ No newline at end of file\",\n \"additions\": 3,\n \"deletions\": 7\n },\n {\n \"filename\": \"deps/uv/test/test-threadpool-cancel.c\",\n \"patch\": \"@@ -21,7 +21,6 @@\\n \\n #include \\\"uv.h\\\"\\n #include \\\"task.h\\\"\\n-#include <string.h>\\n \\n #ifdef _WIN32\\n # define putenv _putenv\\n@@ -103,7 +102,6 @@ static int known_broken(uv_req_t* req) {\\n case UV_FS_FDATASYNC:\\n case UV_FS_FSTAT:\\n case UV_FS_FSYNC:\\n- case UV_FS_FTRUNCATE:\\n case UV_FS_LINK:\\n case UV_FS_LSTAT:\\n case UV_FS_MKDIR:\\n@@ -219,7 +217,6 @@ TEST_IMPL(threadpool_cancel_getaddrinfo) {\\n r = uv_getaddrinfo(loop, reqs + 2, getaddrinfo_cb, \\\"fail\\\", \\\"fail\\\", NULL);\\n ASSERT_OK(r);\\n \\n- memset(&hints, 0, sizeof(hints));\\n r = uv_getaddrinfo(loop, reqs + 3, getaddrinfo_cb, \\\"fail\\\", NULL, &hints);\\n ASSERT_OK(r);\\n \\n@@ -316,7 +313,7 @@ TEST_IMPL(threadpool_cancel_work) {\\n }\\n \\n \\n-TEST_FS_IMPL(threadpool_cancel_fs) {\\n+TEST_IMPL(threadpool_cancel_fs) {\\n struct cancel_info ci;\\n uv_fs_t reqs[26];\\n uv_loop_t* loop;\",\n \"additions\": 1,\n \"deletions\": 4\n },\n {\n \"filename\": \"deps/uv/test/test-tty.c\",\n \"patch\": \"@@ -421,21 +421,27 @@ TEST_IMPL(tty_pty) {\\n #if defined(__QEMU__)\\n RETURN_SKIP(\\\"Test does not currently work in QEMU\\\");\\n #endif\\n+#if defined(__ASAN__)\\n+ RETURN_SKIP(\\\"Test does not currently work in ASAN\\\");\\n+#endif\\n+\\n #if defined(__APPLE__) || \\\\\\n defined(__DragonFly__) || \\\\\\n defined(__FreeBSD__) || \\\\\\n (defined(__linux__) && !defined(__ANDROID__)) || \\\\\\n defined(__NetBSD__) || \\\\\\n defined(__OpenBSD__)\\n int master_fd, slave_fd, r;\\n+ struct winsize w;\\n uv_loop_t loop;\\n uv_tty_t master_tty, slave_tty;\\n \\n- r = openpty(&master_fd, &slave_fd, NULL, NULL, NULL);\\n+ ASSERT_OK(uv_loop_init(&loop));\\n+\\n+ r = openpty(&master_fd, &slave_fd, NULL, NULL, &w);\\n if (r != 0)\\n RETURN_SKIP(\\\"No pty available, skipping.\\\");\\n \\n- ASSERT_OK(uv_loop_init(&loop));\\n ASSERT_OK(uv_tty_init(&loop, &slave_tty, slave_fd, 0));\\n ASSERT_OK(uv_tty_init(&loop, &master_tty, master_fd, 0));\\n ASSERT(uv_is_readable((uv_stream_t*) &slave_tty));\\n@@ -460,79 +466,3 @@ TEST_IMPL(tty_pty) {\\n #endif\\n return 0;\\n }\\n-\\n-#if !defined(__ANDROID__) && !defined(_WIN32)\\n-static int tty_pty_partial_read_count;\\n-\\n-static void tty_pty_partial_feeder(void *arg) {\\n- static char buf[1<<13];\\n- ssize_t n;\\n- ssize_t r;\\n- int fd;\\n- int i;\\n-\\n- fd = *(int *)arg;\\n- memset(buf, 'x', sizeof(buf));\\n- for (i = 0; i < 8; i++) {\\n- for (n = 0; n < (int) sizeof(buf); n += r) {\\n- do\\n- r = write(fd, &buf[n], sizeof(buf) - n);\\n- while (r == -1 && errno == EINTR);\\n- ASSERT_GT(r, 0);\\n- }\\n- }\\n- ASSERT_OK(close(fd));\\n-}\\n-\\n-static void tty_pty_partial_alloc_cb(uv_handle_t* handle,\\n- size_t suggested_size,\\n- uv_buf_t *buf) {\\n- static char slab[1<<16];\\n- *buf = uv_buf_init(slab, sizeof(slab));\\n-}\\n-\\n-static void tty_pty_partial_read_cb(uv_stream_t* stream,\\n- ssize_t nread,\\n- const uv_buf_t *buf) {\\n- if (nread > 0)\\n- tty_pty_partial_read_count += nread;\\n- else\\n- uv_close((uv_handle_t*) stream, NULL);\\n-}\\n-#endif /* !defined(__ANDROID__) && !defined(_WIN32) */\\n-\\n-TEST_IMPL(tty_pty_partial) {\\n-#if !defined(_AIX) && \\\\\\n- !defined(__ANDROID__) && \\\\\\n- !defined(__MVS__) && \\\\\\n- !defined(_WIN32)\\n- int master_fd, slave_fd;\\n- uv_tty_t master_tty;\\n- uv_thread_t tid;\\n- uv_loop_t loop;\\n- int i;\\n-\\n- /* This test is not 100% deterministic. If the bug it is testing for is\\n- * present, then it fails about 1 in 3 times, that's why it runs in a loop.\\n- */\\n- for (i = 0; i < 10; i++) {\\n- if (openpty(&master_fd, &slave_fd, NULL, NULL, NULL))\\n- RETURN_SKIP(\\\"No pty available, skipping.\\\");\\n-\\n- tty_pty_partial_read_count = 0;\\n- ASSERT_OK(uv_loop_init(&loop));\\n- ASSERT_OK(uv_tty_init(&loop, &master_tty, master_fd, 0));\\n- ASSERT_OK(uv_read_start((uv_stream_t*) &master_tty,\\n- tty_pty_partial_alloc_cb,\\n- tty_pty_partial_read_cb));\\n- ASSERT(uv_is_readable((uv_stream_t*) &master_tty));\\n- ASSERT(uv_is_writable((uv_stream_t*) &master_tty));\\n- ASSERT_OK(uv_thread_create(&tid, tty_pty_partial_feeder, &slave_fd));\\n- ASSERT_OK(uv_run(&loop, UV_RUN_DEFAULT));\\n- ASSERT_OK(uv_thread_join(&tid));\\n- ASSERT_EQ(tty_pty_partial_read_count, 65536);\\n- MAKE_VALGRIND_HAPPY(&loop);\\n- }\\n-#endif\\n- return 0;\\n-}\",\n \"additions\": 8,\n \"deletions\": 78\n },\n {\n \"filename\": \"deps/uv/test/test-udp-ipv6.c\",\n \"patch\": \"@@ -26,7 +26,7 @@\\n #include <stdlib.h>\\n #include <string.h>\\n \\n-#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__QNX__)\\n+#if defined(__FreeBSD__) || defined(__NetBSD__)\\n #include <sys/sysctl.h>\\n #endif\\n \\n@@ -49,7 +49,7 @@ static int recv_cb_called;\\n static int close_cb_called;\\n static uint16_t client_port;\\n \\n-#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__QNX__)\\n+#if defined(__FreeBSD__) || defined(__NetBSD__)\\n static int can_ipv6_ipv4_dual(void) {\\n int v6only;\\n size_t size = sizeof(int);\\n@@ -228,7 +228,7 @@ TEST_IMPL(udp_dual_stack) {\\n if (!can_ipv6())\\n RETURN_SKIP(\\\"IPv6 not supported\\\");\\n \\n-#if defined(__FreeBSD__) || defined(__NetBSD__) || defined(__QNX__)\\n+#if defined(__FreeBSD__) || defined(__NetBSD__)\\n if (!can_ipv6_ipv4_dual())\\n RETURN_SKIP(\\\"IPv6-IPv4 dual stack not supported\\\");\\n #elif defined(__OpenBSD__)\",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"deps/uv/test/test-udp-multicast-join.c\",\n \"patch\": \"@@ -144,8 +144,8 @@ static void cl_recv_cb(uv_udp_t* handle,\\n \\n \\n TEST_IMPL(udp_multicast_join) {\\n-#if defined(__OpenBSD__) || defined(QNX_IOPKT)\\n- RETURN_SKIP(\\\"Test does not currently work in OpenBSD or QNX\\\");\\n+#if defined(__OpenBSD__)\\n+ RETURN_SKIP(\\\"Test does not currently work in OpenBSD\\\");\\n #endif\\n int r;\\n struct sockaddr_in addr;\\n@@ -168,8 +168,6 @@ TEST_IMPL(udp_multicast_join) {\\n RETURN_SKIP(\\\"No multicast support.\\\");\\n if (r == UV_ENOEXEC)\\n RETURN_SKIP(\\\"No multicast support (likely a firewall issue).\\\");\\n- if (r == UV_ENOSYS)\\n- RETURN_SKIP(\\\"No multicast support (likely a platform issue).\\\");\\n ASSERT_OK(r);\\n #if defined(__ANDROID__)\\n /* It returns an ENOSYS error */\",\n \"additions\": 2,\n \"deletions\": 4\n },\n {\n \"filename\": \"deps/uv/test/test-udp-multicast-join6.c\",\n \"patch\": \"@@ -35,8 +35,7 @@\\n defined(__MVS__) || \\\\\\n defined(__FreeBSD__) || \\\\\\n defined(__NetBSD__) || \\\\\\n- defined(__OpenBSD__) || \\\\\\n- defined(__QNX__)\\n+ defined(__OpenBSD__)\\n #define MULTICAST_ADDR \\\"ff02::1%lo0\\\"\\n #define INTERFACE_ADDR \\\"::1%lo0\\\"\\n #else\\n@@ -168,9 +167,6 @@ static int can_ipv6_external(void) {\\n \\n \\n TEST_IMPL(udp_multicast_join6) {\\n-#if defined(QNX_IOPKT)\\n- RETURN_SKIP(\\\"Test does not currently work in QNX\\\");\\n-#endif\\n int r;\\n struct sockaddr_in6 addr;\\n \",\n \"additions\": 1,\n \"deletions\": 5\n },\n {\n \"filename\": \"deps/uv/test/test-udp-recv-cb-close-pollerr.c\",\n \"patch\": \"@@ -1,112 +0,0 @@\\n-/* Copyright libuv contributors. All rights reserved.\\n- *\\n- * Permission is hereby granted, free of charge, to any person obtaining a copy\\n- * of this software and associated documentation files (the \\\"Software\\\"), to\\n- * deal in the Software without restriction, including without limitation the\\n- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or\\n- * sell copies of the Software, and to permit persons to whom the Software is\\n- * furnished to do so, subject to the following conditions:\\n- *\\n- * The above copyright notice and this permission notice shall be included in\\n- * all copies or substantial portions of the Software.\\n- *\\n- * THE SOFTWARE IS PROVIDED \\\"AS IS\\\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\\n- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\\n- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\\n- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\\n- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING\\n- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS\\n- * IN THE SOFTWARE.\\n- */\\n-#include \\\"uv.h\\\"\\n-#include \\\"task.h\\\"\\n-\\n-static uv_udp_send_t send_req;\\n-static uv_udp_t client;\\n-static int alloc_cb_called;\\n-static int recv_cb_called;\\n-static int send_cb_called;\\n-\\n-static void alloc_cb(uv_handle_t* handle, size_t sz, uv_buf_t* buf) {\\n- alloc_cb_called++;\\n- buf->base = \\\"uv\\\";\\n- buf->len = 2;\\n-}\\n-\\n-static void recv_cb(uv_udp_t* handle, ssize_t nread, const uv_buf_t* buf,\\n- const struct sockaddr* addr, unsigned flags) {\\n- recv_cb_called++;\\n- /* Stop receiving and unset recv_cb and alloc_cb */\\n- uv_close((uv_handle_t*) handle, NULL);\\n-}\\n-\\n-static void send_cb(uv_udp_send_t* req, int status) {\\n- send_cb_called++;\\n- /* The send completed; now just close the handle and let the loop drain.\\n- * If a POLLERR arrives before the close completes, uv__udp_io must not\\n- * crash when no recv callback is installed. */\\n- uv_close((uv_handle_t*) req->handle, NULL);\\n-}\\n-\\n-/* Refs: https://github.com/libuv/libuv/issues/5030 */\\n-TEST_IMPL(udp_recv_cb_close_pollerr) {\\n-#ifndef __linux__\\n- RETURN_SKIP(\\\"ICMP error handling is Linux-specific\\\");\\n-#endif\\n- struct sockaddr_in any_addr;\\n- struct sockaddr_in addr;\\n- uv_buf_t buf;\\n-\\n- ASSERT_OK(uv_udp_init(uv_default_loop(), &client));\\n-\\n- ASSERT_OK(uv_ip4_addr(\\\"0.0.0.0\\\", 0, &any_addr));\\n- ASSERT_OK(uv_udp_bind(&client, (const struct sockaddr*) &any_addr,\\n- UV_UDP_LINUX_RECVERR));\\n-\\n- ASSERT_OK(uv_ip4_addr(\\\"127.0.0.1\\\", 9999, &addr));\\n- ASSERT_OK(uv_udp_connect(&client, (const struct sockaddr*) &addr));\\n-\\n- ASSERT_OK(uv_udp_recv_start(&client, alloc_cb, recv_cb));\\n-\\n- buf = uv_buf_init(\\\"PING\\\", 4);\\n- ASSERT_GT(uv_udp_try_send(&client, &buf, 1, NULL), 0);\\n-\\n- uv_run(uv_default_loop(), UV_RUN_DEFAULT);\\n-\\n- ASSERT_EQ(1, alloc_cb_called);\\n- ASSERT_EQ(1, recv_cb_called);\\n-\\n- MAKE_VALGRIND_HAPPY(uv_default_loop());\\n- return 0;\\n-}\\n-\\n-/* Same as above but WITHOUT uv_udp_recv_start.\\n- * The ICMP POLLERR still fires on the fd; uv__udp_io must not crash when\\n- * no recv/alloc callback is installed. */\\n-TEST_IMPL(udp_send_pollerr_no_recv) {\\n-#ifndef __linux__\\n- RETURN_SKIP(\\\"ICMP error handling is Linux-specific\\\");\\n-#endif\\n- struct sockaddr_in any_addr;\\n- struct sockaddr_in addr;\\n- uv_buf_t buf;\\n-\\n- ASSERT_OK(uv_udp_init(uv_default_loop(), &client));\\n-\\n- ASSERT_OK(uv_ip4_addr(\\\"0.0.0.0\\\", 0, &any_addr));\\n- ASSERT_OK(uv_udp_bind(&client, (const struct sockaddr*) &any_addr,\\n- UV_UDP_LINUX_RECVERR));\\n-\\n- ASSERT_OK(uv_ip4_addr(\\\"127.0.0.1\\\", 9999, &addr));\\n- ASSERT_OK(uv_udp_connect(&client, (const struct sockaddr*) &addr));\\n-\\n- buf = uv_buf_init(\\\"PING\\\", 4);\\n- ASSERT_OK(uv_udp_send(&send_req, &client, &buf, 1, NULL, send_cb));\\n-\\n- uv_run(uv_default_loop(), UV_RUN_DEFAULT);\\n-\\n- ASSERT_EQ(1, send_cb_called);\\n-\\n- MAKE_VALGRIND_HAPPY(uv_default_loop());\\n- return 0;\\n-}\\n\\\\ No newline at end of file\",\n \"additions\": 0,\n \"deletions\": 112\n },\n {\n \"filename\": \"deps/uv/test/test-udp-recvmsg-unreachable-error.c\",\n \"patch\": \"@@ -1,125 +0,0 @@\\n-/* Copyright libuv project and contributors. All rights reserved.\\n- *\\n- * Permission is hereby granted, free of charge, to any person obtaining a copy\\n- * of this software and associated documentation files (the \\\"Software\\\"), to\\n- * deal in the Software without restriction, including without limitation the\\n- * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or\\n- * sell copies of the Software, and to permit persons to whom the Software is\\n- * furnished to do so, subject to the following conditions:\\n- *\\n- * The above copyright notice and this permission notice shall be included in\\n- * all copies or substantial portions of the Software.\\n- *\\n- * THE SOFTWARE IS PROVIDED \\\"AS IS\\\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\\n- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\\n- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\\n- * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\\n- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING\\n- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS\\n- * IN THE SOFTWARE.\\n- */\\n-\\n-#include \\\"uv.h\\\"\\n-#include \\\"task.h\\\"\\n-\\n-#include <stdio.h>\\n-#include <stdlib.h>\\n-\\n-#define CLIENT_TEST_PORT 9123\\n-#define SERVER_TEST_PORT 9124\\n-#define RECV_CB_MAX_CALL 3 /* ECONNREFUSED, EAGAIN/EWOULDBLOCK, ICMP delivery */\\n-\\n-static int recv_cb_called = 0;\\n-\\n-static void udp_send_cb(uv_udp_send_t* req, int status) {\\n- ASSERT_EQ(status, 0);\\n-}\\n-\\n-static void alloc_cb(uv_handle_t* handle,\\n- size_t suggested_size,\\n- uv_buf_t* buf) {\\n- static char storage[4]; /* \\\"PING\\\" */\\n- buf->base = storage;\\n- buf->len = sizeof(storage);\\n-}\\n-\\n-static void read_cb(uv_udp_t* handle,\\n- ssize_t nread,\\n- const uv_buf_t* buf,\\n- const struct sockaddr* addr,\\n- unsigned flags) {\\n- ASSERT(flags == 0 || (flags & UV_UDP_LINUX_RECVERR));\\n- recv_cb_called++;\\n-}\\n-\\n-static void timer_cb(uv_timer_t* handle) {\\n- uv_udp_t* udp = handle->data;\\n- uv_close((uv_handle_t*) udp, NULL);\\n-}\\n-\\n-TEST_IMPL(udp_recvmsg_unreachable_error) {\\n-#if !defined(__linux__)\\n- RETURN_SKIP(\\\"This test is Linux-specific\\\");\\n-#endif\\n- struct sockaddr_in server_addr, client_addr;\\n- uv_udp_t client;\\n- uv_timer_t timer;\\n- uv_udp_send_t send_req;\\n- uv_buf_t buf = uv_buf_init(\\\"PING\\\", 4);\\n- ASSERT_OK(uv_ip4_addr(\\\"127.0.0.1\\\", CLIENT_TEST_PORT, &client_addr));\\n- ASSERT_OK(uv_ip4_addr(\\\"127.0.0.1\\\", SERVER_TEST_PORT, &server_addr));\\n- ASSERT_OK(uv_udp_init(uv_default_loop(), &client));\\n- ASSERT_OK(uv_timer_init(uv_default_loop(), &timer));\\n- ASSERT_OK(uv_udp_bind(&client,\\n- (const struct sockaddr*) &client_addr,\\n- UV_UDP_LINUX_RECVERR));\\n- ASSERT_OK(uv_udp_recv_start(&client, alloc_cb, read_cb));\\n- timer.data = &client;\\n- ASSERT_OK(uv_timer_start(&timer, timer_cb, 3000, 0));\\n- ASSERT_OK(uv_udp_send(&send_req,\\n- &client,\\n- &buf,\\n- 1,\\n- (const struct sockaddr*) &server_addr,\\n- udp_send_cb));\\n- uv_run(uv_default_loop(), UV_RUN_DEFAULT);\\n- ASSERT_EQ(recv_cb_called, RECV_CB_MAX_CALL);\\n- return 0;\\n-}\\n-\\n-TEST_IMPL(udp_recvmsg_unreachable_error6) {\\n-#if !defined(__linux__)\\n- RETURN_SKIP(\\\"This test is Linux-specific\\\");\\n-#endif\\n- struct sockaddr_in6 server_addr, client_addr;\\n- uv_udp_t client;\\n- uv_timer_t timer;\\n- uv_udp_send_t send_req;\\n- uv_buf_t buf = uv_buf_init(\\\"PING\\\", 4);\\n-\\n- ASSERT_OK(uv_ip6_addr(\\\"::1\\\", CLIENT_TEST_PORT, &client_addr));\\n- ASSERT_OK(uv_ip6_addr(\\\"::1\\\", SERVER_TEST_PORT, &server_addr));\\n-\\n- ASSERT_OK(uv_udp_init(uv_default_loop(), &client));\\n- ASSERT_OK(uv_timer_init(uv_default_loop(), &timer));\\n-\\n- ASSERT_OK(uv_udp_bind(&client,\\n- (const struct sockaddr*) &client_addr,\\n- UV_UDP_LINUX_RECVERR));\\n- ASSERT_OK(uv_udp_recv_start(&client, alloc_cb, read_cb));\\n-\\n- timer.data = &client;\\n- ASSERT_OK(uv_timer_start(&timer, timer_cb, 3000, 0));\\n-\\n- ASSERT_OK(uv_udp_send(&send_req,\\n- &client,\\n- &buf,\\n- 1,\\n- (const struct sockaddr*) &server_addr,\\n- udp_send_cb));\\n-\\n- uv_run(uv_default_loop(), UV_RUN_DEFAULT);\\n-\\n- ASSERT_EQ(recv_cb_called, RECV_CB_MAX_CALL);\\n- return 0;\\n-}\",\n \"additions\": 0,\n \"deletions\": 125\n },\n {\n \"filename\": \"deps/uv/test/test-udp-reuseport.c\",\n \"patch\": \"@@ -215,17 +215,6 @@ TEST_IMPL(udp_reuseport) {\\n int r;\\n int i;\\n \\n-#if defined(__QEMU__)\\n- /* QEMU's user-mode emulator sometimes runs threads in sequence\\n- * instead of in parallel and that throws off the test.\\n- * See https://github.com/libuv/libuv/issues/4777.\\n- */\\n- RETURN_SKIP(\\\"Unreliable under QEMU\\\");\\n-#endif /* defined(__QEMU__) */\\n-\\n- if (uv_available_parallelism() < 2)\\n- RETURN_SKIP(\\\"Unreliable without thread parallelism\\\");\\n-\\n r = uv_mutex_init(&mutex);\\n ASSERT_OK(r);\\n \",\n \"additions\": 0,\n \"deletions\": 11\n },\n {\n \"filename\": \"deps/uv/test/test-udp-send-unreachable.c\",\n \"patch\": \"@@ -83,10 +83,7 @@ static void recv_cb(uv_udp_t* handle,\\n recv_cb_called++;\\n \\n if (nread < 0) {\\n- if (flags && can_recverr)\\n- ASSERT(flags & UV_UDP_LINUX_RECVERR);\\n- else\\n- ASSERT(0 && \\\"unexpected error\\\");\\n+ ASSERT(0 && \\\"unexpected error\\\");\\n } else if (nread == 0) {\\n /* Returning unused buffer */\\n ASSERT_NULL(addr);\",\n \"additions\": 1,\n \"deletions\": 4\n },\n {\n \"filename\": \"test/parallel/test-net-socket-write-after-close.js\",\n \"patch\": \"@@ -12,7 +12,7 @@ const net = require('net');\\n client.on('error', common.mustCall((err) => {\\n server.close();\\n assert.strictEqual(err.constructor, Error);\\n- assert.strictEqual(err.message, `write ${common.isWindows ? 'EPIPE' : 'EBADF'}`);\\n+ assert.strictEqual(err.message, 'write EBADF');\\n }));\\n client._handle.close();\\n client.write('foo');\",\n \"additions\": 1,\n \"deletions\": 1\n }\n]","isConversational":false}}},{"rowIdx":294,"cells":{"repo":{"kind":"string","value":"golang/go"},"issue_number":{"kind":"number","value":77683,"string":"77,683"},"issue_title":{"kind":"string","value":"cmd/fix: clarify -any analyzer behavior in documentation"},"issue_body":{"kind":"string","value":"This change clarifies the documentation for the any analyzer used by go fix.\r\n\r\nIt adds a note explaining that the -any flag enables only the any analyzer\r\nand does not affect other analyzers in the fix suite. This makes the behavior\r\nof the flag explicit and helps avoid confusion when reading the documentation.\r\n\r\nThis is a documentation-only change and does not modify analyzer behavior.\r\n\r\nfixes: #77679 "},"commit_sha":{"kind":"string","value":"f9e337d1e857c0ba66f6723b4147c9c08f93208a"},"files":{"kind":"list like","value":[{"filename":"api/next/73450.txt","patch":"@@ -0,0 +1 @@\n+pkg net/url, method (*URL) Clone() *URL #73450","additions":1,"deletions":0},{"filename":"doc/next/6-stdlib/99-minor/net/url/73450.md","patch":"@@ -0,0 +1 @@\n+The new [URL.Clone] method creates a deep copy of a URL.","additions":1,"deletions":0},{"filename":"src/cmd/asm/internal/asm/testdata/arm64.s","patch":"@@ -698,6 +698,12 @@ TEXT\tfoo(SB), DUPOK|NOSPLIT, $-8\n \tFMOVD\tF4, (R2)(R6) // 446826fc\n \tFMOVD\tF4, (R2)(R6<<3) // 447826fc\n \n+// global address\n+\tFMOVQ\tF5, x+8(SB)\n+\tFMOVQ\tF5, x(SB)\n+\tFMOVQ\tx+8(SB), F5\n+\tFMOVQ\tx(SB), F5\n+\n // vmov\n \tVMOV\tV8.S[1], R1 // 013d0c0e\n \tVMOV\tV0.D[0], R11 // 0b3c084e","additions":6,"deletions":0},{"filename":"src/cmd/cgo/internal/test/cgo_test.go","patch":"@@ -78,6 +78,7 @@ func TestBoolAlign(t *testing.T) { testBoolAlign(t) }\n func TestCallGoWithString(t *testing.T) { testCallGoWithString(t) }\n func TestCallback(t *testing.T) { testCallback(t) }\n func TestCallbackCallers(t *testing.T) { testCallbackCallers(t) }\n+func TestCallbackInInit(t *testing.T) { testCallbackInInit(t) }\n func TestCallbackGC(t *testing.T) { testCallbackGC(t) }\n func TestCallbackPanic(t *testing.T) { testCallbackPanic(t) }\n func TestCallbackPanicLocked(t *testing.T) { testCallbackPanicLocked(t) }","additions":1,"deletions":0},{"filename":"src/cmd/cgo/internal/test/cthread_unix.c","patch":"@@ -56,3 +56,18 @@ callGoInCThread(int max)\n \n \treturn max;\n }\n+\n+static void*\n+callbackInInitCThread(void* unused)\n+{\n+\tcallbackInInit();\n+\treturn NULL;\n+}\n+\n+void\n+callbackInInitC(void)\n+{\n+\tpthread_t thread;\n+\n+\tpthread_create(&thread, NULL, callbackInInitCThread, NULL);\n+}","additions":15,"deletions":0},{"filename":"src/cmd/cgo/internal/test/cthread_windows.c","patch":"@@ -57,3 +57,19 @@ callGoInCThread(int max)\n \tCloseHandle((HANDLE)thread_id);\n \treturn max;\n }\n+\n+__stdcall\n+static unsigned int\n+callbackInInitCThread(void* unused)\n+{\n+\tcallbackInInit();\n+\treturn 0;\n+}\n+\n+void\n+callbackInInitC(void)\n+{\n+\tuintptr_t thread_id;\n+\tthread_id = _beginthreadex(0, 0, callbackInInitCThread, NULL, 0, 0);\n+\tCloseHandle((HANDLE)thread_id);\n+}","additions":16,"deletions":0},{"filename":"src/cmd/cgo/internal/test/testx.go","patch":"@@ -26,6 +26,7 @@ import (\n // threads\n extern void doAdd(int, int);\n extern int callGoInCThread(int);\n+extern void callbackInInitC(void);\n \n // issue 1328\n void IntoC(void);\n@@ -622,3 +623,28 @@ func ditCallback() uint8 {\n \t}\n \treturn 0\n }\n+\n+// Test C calling back into Go before init is done.\n+// In particular, this does not trigger false race\n+// (the fix is in CL 746581).\n+\n+var callbackInInitVar int\n+\n+func init() {\n+\tC.callbackInInitC()\n+\tcallbackInInitVar = 123\n+}\n+\n+var callbackInInitChan = make(chan int)\n+\n+//export callbackInInit\n+func callbackInInit() {\n+\tif callbackInInitVar != 123 {\n+\t\tpanic(\"callbackInInitVar not initialized to 123\")\n+\t}\n+\tcallbackInInitChan <- 1\n+}\n+\n+func testCallbackInInit(t *testing.T) {\n+\t<-callbackInInitChan // make sure callbackInInit runs\n+}","additions":26,"deletions":0},{"filename":"src/cmd/compile/internal/base/flag.go","patch":"@@ -78,6 +78,7 @@ type CmdFlags struct {\n \tLowerR CountFlag \"help:\\\"debug generated wrappers\\\"\"\n \tLowerT bool \"help:\\\"enable tracing for debugging the compiler\\\"\"\n \tLowerW CountFlag \"help:\\\"debug type checking\\\"\"\n+\tLowerU CountFlag \"help:\\\"emit unsorted warnings/errors\\\"\"\n \tLowerV *bool \"help:\\\"increase debug verbosity\\\"\"\n \n \t// Special characters","additions":1,"deletions":0},{"filename":"src/cmd/compile/internal/base/print.go","patch":"@@ -83,7 +83,9 @@ func FlushErrors() {\n \tif len(errorMsgs) == 0 {\n \t\treturn\n \t}\n-\tsort.Stable(byPos(errorMsgs))\n+\tif Flag.LowerU == 0 {\n+\t\tsort.Stable(byPos(errorMsgs))\n+\t}\n \tfor i, err := range errorMsgs {\n \t\tif i == 0 || err.msg != errorMsgs[i-1].msg {\n \t\t\tfmt.Print(err.msg)","additions":3,"deletions":1},{"filename":"src/cmd/compile/internal/ssa/decompose.go","patch":"@@ -363,20 +363,20 @@ func decomposeUserPhi(v *Value) {\n func decomposeStructPhi(v *Value) {\n \tt := v.Type\n \tn := t.NumFields()\n-\tvar fields [MaxStruct]*Value\n+\tfields := make([]*Value, 0, MaxStruct)\n \tfor i := 0; i < n; i++ {\n-\t\tfields[i] = v.Block.NewValue0(v.Pos, OpPhi, t.FieldType(i))\n+\t\tfields = append(fields, v.Block.NewValue0(v.Pos, OpPhi, t.FieldType(i)))\n \t}\n \tfor _, a := range v.Args {\n \t\tfor i := 0; i < n; i++ {\n \t\t\tfields[i].AddArg(a.Block.NewValue1I(v.Pos, OpStructSelect, t.FieldType(i), int64(i), a))\n \t\t}\n \t}\n \tv.reset(OpStructMake)\n-\tv.AddArgs(fields[:n]...)\n+\tv.AddArgs(fields...)\n \n \t// Recursively decompose phis for each field.\n-\tfor _, f := range fields[:n] {\n+\tfor _, f := range fields {\n \t\tdecomposeUserPhi(f)\n \t}\n }","additions":4,"deletions":4},{"filename":"src/cmd/compile/internal/ssa/expand_calls.go","patch":"@@ -566,7 +566,7 @@ func (x *expandState) rewriteSelectOrArg(pos src.XPos, b *Block, container, a, m\n \t\t\taddArg(e)\n \t\t\tpos = pos.WithNotStmt()\n \t\t}\n-\t\tif at.NumFields() > 4 {\n+\t\tif at.NumFields() > MaxStruct && !types.IsDirectIface(at) {\n \t\t\tpanic(fmt.Errorf(\"Too many fields (%d, %d bytes), container=%s\", at.NumFields(), at.Size(), container.LongString()))\n \t\t}\n \t\ta = makeOf(a, OpStructMake, args)","additions":1,"deletions":1},{"filename":"src/cmd/compile/internal/ssa/value.go","patch":"@@ -635,6 +635,10 @@ func CanSSA(t *types.Type) bool {\n \t\t}\n \t\treturn false\n \tcase types.TSTRUCT:\n+\t\tif types.IsDirectIface(t) {\n+\t\t\t// Note: even if t.NumFields()>MaxStruct! See issue 77534.\n+\t\t\treturn true\n+\t\t}\n \t\tif t.NumFields() > MaxStruct {\n \t\t\treturn false\n \t\t}","additions":4,"deletions":0},{"filename":"src/cmd/compile/internal/syntax/parser.go","patch":"@@ -797,9 +797,9 @@ func (p *parser) funcDeclOrNil() *FuncDecl {\n \tf.pos = p.pos()\n \tf.Pragma = p.takePragma()\n \n-\tvar context string\n+\thasRecv := false\n \tif p.got(_Lparen) {\n-\t\tcontext = \"method\"\n+\t\thasRecv = true\n \t\trcvr := p.paramList(nil, nil, _Rparen, false, false)\n \t\tswitch len(rcvr) {\n \t\tcase 0:\n@@ -814,13 +814,13 @@ func (p *parser) funcDeclOrNil() *FuncDecl {\n \n \tif p.tok == _Name {\n \t\tf.Name = p.name()\n-\t\tf.TParamList, f.Type = p.funcType(context)\n+\t\tf.TParamList, f.Type = p.funcType(\"\")\n \t} else {\n \t\tf.Name = NewName(p.pos(), \"_\")\n \t\tf.Type = new(FuncType)\n \t\tf.Type.pos = p.pos()\n \t\tmsg := \"expected name or (\"\n-\t\tif context != \"\" {\n+\t\tif hasRecv {\n \t\t\tmsg = \"expected name\"\n \t\t}\n \t\tp.syntaxError(msg)","additions":4,"deletions":4},{"filename":"src/cmd/compile/internal/syntax/testdata/smoketest.go","patch":"@@ -71,3 +71,33 @@ type _ interface {\n \tT[P]\n \tT[P1, P2]\n }\n+\n+// generic method\n+type List[E any] []E\n+\n+func (l List[E]) Map[F any](m func(E) F) (r List[F]) {\n+\tfor _, x := range l {\n+\t\tr = append(r, m(x))\n+\t}\n+\treturn\n+}\n+\n+func _() {\n+\tl := List[string]{\"foo\", \"foobar\", \"42\"}\n+\tr := l.Map(func(s string) int { return len(s)})\n+\t_ = r\n+}\n+\n+func _[E, F any](l List[E]) List[F] {\n+\tvar f func(List[E], func(E) F) List[F] = List[E].Map // method expression & type inference\n+\treturn f(l, func(E) F { var f F; return f })\n+}\n+\n+// disallowed type parameters\n+\n+type _ func /* ERROR function type must have no type parameters */ [P any](P)\n+type _ interface {\n+\tm /* ERROR interface method must have no type parameters */ [P any](P)\n+}\n+\n+var _ = func /* ERROR function type must have no type parameters */ [P any](P) {}","additions":30,"deletions":0},{"filename":"src/cmd/compile/internal/types2/resolver.go","patch":"@@ -452,6 +452,11 @@ func (check *Checker) collectObjects() {\n \t\t\t\t\tif recv, _ := base.(*syntax.Name); recv != nil && name != \"_\" {\n \t\t\t\t\t\tmethods = append(methods, methodInfo{obj, ptr, recv})\n \t\t\t\t\t}\n+\t\t\t\t\t// methods cannot have type parameters for now\n+\t\t\t\t\tif len(s.TParamList) != 0 {\n+\t\t\t\t\t\tcheck.softErrorf(s.TParamList[0], InvalidMethodTypeParams, \"method %s must have no type parameters\", name)\n+\t\t\t\t\t\thasTParamError = true\n+\t\t\t\t\t}\n \t\t\t\t\tcheck.recordDef(s.Name, obj)\n \t\t\t\t}\n \t\t\t\t_ = len(s.TParamList) != 0 && !hasTParamError && check.verifyVersionf(s.TParamList[0], go1_18, \"type parameter\")","additions":5,"deletions":0},{"filename":"src/cmd/compile/internal/types2/signature.go","patch":"@@ -155,7 +155,6 @@ func (check *Checker) funcType(sig *Signature, recvPar *syntax.Field, tparams []\n \n \t// collect and declare function type parameters\n \tif tparams != nil {\n-\t\t// The parser will complain about invalid type parameters for methods.\n \t\tcheck.collectTypeParams(&sig.tparams, tparams)\n \t}\n ","additions":0,"deletions":1},{"filename":"src/cmd/dist/test.go","patch":"@@ -728,7 +728,7 @@ func (t *tester) registerTests() {\n \n \t\t// Test that earlier FIPS snapshots build.\n \t\t// In long mode, test that they work too.\n-\t\tfor _, version := range fipsVersions(t.short) {\n+\t\tfor _, version := range fipsVersions() {\n \t\t\tsuffix := \" # (build and vet only)\"\n \t\t\trun := \"^$\" // only ensure they compile\n \t\t\tif !t.short {\n@@ -1291,11 +1291,12 @@ func (t *tester) registerCgoTests(heading string) {\n \t\t\t// This isn't actually a Go buildmode, just a convenient way to tell\n \t\t\t// cgoTest we want static linking.\n \t\t\tgt.buildmode = \"\"\n-\t\t\tif linkmode == \"external\" {\n+\t\t\tswitch linkmode {\n+\t\t\tcase \"external\":\n \t\t\t\tldflags = append(ldflags, `-extldflags \"-static -pthread\"`)\n-\t\t\t} else if linkmode == \"auto\" {\n+\t\t\tcase \"auto\":\n \t\t\t\tgt.env = append(gt.env, \"CGO_LDFLAGS=-static -pthread\")\n-\t\t\t} else {\n+\t\t\tdefault:\n \t\t\t\tpanic(\"unknown linkmode with static build: \" + linkmode)\n \t\t\t}\n \t\t\tgt.tags = append(gt.tags, \"static\")\n@@ -1320,8 +1321,8 @@ func (t *tester) registerCgoTests(heading string) {\n \n \tos := gohostos\n \tp := gohostos + \"/\" + goarch\n-\tswitch {\n-\tcase os == \"darwin\", os == \"windows\":\n+\tswitch os {\n+\tcase \"darwin\", \"windows\":\n \t\tif !t.extLink() {\n \t\t\tbreak\n \t\t}\n@@ -1338,7 +1339,7 @@ func (t *tester) registerCgoTests(heading string) {\n \t\t\t}\n \t\t}\n \n-\tcase os == \"aix\", os == \"android\", os == \"dragonfly\", os == \"freebsd\", os == \"linux\", os == \"netbsd\", os == \"openbsd\":\n+\tcase \"aix\", \"android\", \"dragonfly\", \"freebsd\", \"linux\", \"netbsd\", \"openbsd\":\n \t\tgt := cgoTest(\"external-g0\", \"test\", \"external\", \"\")\n \t\tgt.env = append(gt.env, \"CGO_CFLAGS=-g0 -fdiagnostics-color\")\n \n@@ -1526,14 +1527,6 @@ func (t *tester) runPending(nextTest *distTest) {\n \t}\n }\n \n-func (t *tester) hasBash() bool {\n-\tswitch gohostos {\n-\tcase \"windows\", \"plan9\":\n-\t\treturn false\n-\t}\n-\treturn true\n-}\n-\n // hasParallelism is a copy of the function\n // internal/testenv.HasParallelism, which can't be used here\n // because cmd/dist can not import internal packages during bootstrap.\n@@ -1881,7 +1874,7 @@ func (t *tester) fipsSupported() bool {\n }\n \n // fipsVersions returns the list of versions available in lib/fips140.\n-func fipsVersions(short bool) []string {\n+func fipsVersions() []string {\n \tvar versions []string\n \tzips, err := filepath.Glob(filepath.Join(goroot, \"lib/fips140/*.zip\"))\n \tif err != nil {","additions":9,"deletions":16},{"filename":"src/cmd/internal/obj/arm64/asm7.go","patch":"@@ -484,6 +484,8 @@ var optab = []Optab{\n \t{AFMOVS, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\n \t{AFMOVD, C_FREG, C_NONE, C_NONE, C_ADDR, C_NONE, 64, 12, 0, 0, 0},\n \t{AFMOVD, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\n+\t{AFMOVQ, C_FREG, C_NONE, C_NONE, C_ADDR, C_NONE, 64, 12, 0, 0, 0},\n+\t{AFMOVQ, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\n \t{AFMOVS, C_FCON, C_NONE, C_NONE, C_FREG, C_NONE, 55, 4, 0, 0, 0},\n \t{AFMOVS, C_FREG, C_NONE, C_NONE, C_FREG, C_NONE, 54, 4, 0, 0, 0},\n \t{AFMOVD, C_FCON, C_NONE, C_NONE, C_FREG, C_NONE, 55, 4, 0, 0, 0},","additions":2,"deletions":0},{"filename":"src/cmd/link/dwarf_test.go","patch":"@@ -426,7 +426,7 @@ func TestFlagW(t *testing.T) {\n \t\t{\"-s\", false}, // -s implies -w\n \t\t{\"-s -w=0\", true}, // -w=0 negates the implied -w\n \t}\n-\tif testenv.HasCGO() && runtime.GOOS != \"solaris\" { // Solaris linker doesn't support the -S flag\n+\tif testenv.HasCGO() && runtime.GOOS != \"solaris\" && runtime.GOOS != \"illumos\" { // Solaris linker doesn't support the -S flag\n \t\ttests = append(tests,\n \t\t\ttestCase{\"-w -linkmode=external\", false},\n \t\t\ttestCase{\"-s -linkmode=external\", false},","additions":1,"deletions":1},{"filename":"src/cmd/link/internal/ld/lib.go","patch":"@@ -1700,22 +1700,48 @@ func (ctxt *Link) hostlink() {\n \t\t}\n \n \t\tif ctxt.Arch.InFamily(sys.ARM64) && buildcfg.GOOS == \"linux\" {\n-\t\t\t// On ARM64, the GNU linker will fail with\n-\t\t\t// -znocopyreloc if it thinks a COPY relocation is\n-\t\t\t// required. Switch to gold.\n+\t\t\t// On ARM64, the GNU linker had issues with -znocopyreloc\n+\t\t\t// and COPY relocations. This was fixed in GNU ld 2.36+.\n \t\t\t// https://sourceware.org/bugzilla/show_bug.cgi?id=19962\n \t\t\t// https://go.dev/issue/22040\n-\t\t\taltLinker = \"gold\"\n+\t\t\t// And newer gold is deprecated, may lack new features/flags, or even missing\n \n-\t\t\t// If gold is not installed, gcc will silently switch\n-\t\t\t// back to ld.bfd. So we parse the version information\n-\t\t\t// and provide a useful error if gold is missing.\n+\t\t\t// If the default linker is GNU ld 2.35 or older, use gold\n+\t\t\tuseGold := false\n \t\t\tname, args := flagExtld[0], flagExtld[1:]\n-\t\t\targs = append(args, \"-fuse-ld=gold\", \"-Wl,--version\")\n+\t\t\targs = append(args, \"-Wl,--version\")\n \t\t\tcmd := exec.Command(name, args...)\n \t\t\tif out, err := cmd.CombinedOutput(); err == nil {\n-\t\t\t\tif !bytes.Contains(out, []byte(\"GNU gold\")) {\n-\t\t\t\t\tlog.Fatalf(\"ARM64 external linker must be gold (issue #15696, 22040), but is not: %s\", out)\n+\t\t\t\t// Parse version from output like \"GNU ld (GNU Binutils for Distro) 2.36.1\"\n+\t\t\t\tfor line := range strings.Lines(string(out)) {\n+\t\t\t\t\tif !strings.HasPrefix(line, \"GNU ld \") {\n+\t\t\t\t\t\tcontinue\n+\t\t\t\t\t}\n+\t\t\t\t\tfields := strings.Fields(line[len(\"GNU ld \"):])\n+\t\t\t\t\tvar major, minor int\n+\t\t\t\t\tif ret, err := fmt.Sscanf(fields[len(fields)-1], \"%d.%d\", &major, &minor); ret == 2 && err == nil {\n+\t\t\t\t\t\tif major == 2 && minor <= 35 {\n+\t\t\t\t\t\t\tuseGold = true\n+\t\t\t\t\t\t}\n+\t\t\t\t\t\tbreak\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t}\n+\n+\t\t\tif useGold {\n+\t\t\t\t// Use gold for older linkers\n+\t\t\t\taltLinker = \"gold\"\n+\n+\t\t\t\t// If gold is not installed, gcc will silently switch\n+\t\t\t\t// back to ld.bfd. So we parse the version information\n+\t\t\t\t// and provide a useful error if gold is missing.\n+\t\t\t\targs = flagExtld[1:]\n+\t\t\t\targs = append(args, \"-fuse-ld=gold\", \"-Wl,--version\")\n+\t\t\t\tcmd = exec.Command(name, args...)\n+\t\t\t\tif out, err := cmd.CombinedOutput(); err == nil {\n+\t\t\t\t\tif !bytes.Contains(out, []byte(\"GNU gold\")) {\n+\t\t\t\t\t\tlog.Fatalf(\"ARM64 external linker must be ld>=2.36 or gold (issue #15696, 22040), but is not: %s\", out)\n+\t\t\t\t\t}\n \t\t\t\t}\n \t\t\t}\n \t\t}","additions":36,"deletions":10},{"filename":"src/go/parser/parser.go","patch":"@@ -2794,12 +2794,6 @@ func (p *parser) parseFuncDecl() *ast.FuncDecl {\n \tvar tparams *ast.FieldList\n \tif p.tok == token.LBRACK {\n \t\ttparams = p.parseTypeParameters()\n-\t\tif recv != nil && tparams != nil {\n-\t\t\t// Method declarations do not have type parameters. We parse them for a\n-\t\t\t// better error message and improved error recovery.\n-\t\t\tp.error(tparams.Opening, \"method must have no type parameters\")\n-\t\t\ttparams = nil\n-\t\t}\n \t}\n \tparams := p.parseParameters(false)\n \tresults := p.parseParameters(true)","additions":0,"deletions":6},{"filename":"src/go/parser/short_test.go","patch":"@@ -207,9 +207,9 @@ var invalids = []string{\n \n \t`package p; func _[type /* ERROR \"found 'type'\" */ P, *Q interface{}]()`,\n \n-\t`package p; func (T) _[ /* ERROR \"must have no type parameters\" */ A, B any](a A) B`,\n-\t`package p; func (T) _[ /* ERROR \"must have no type parameters\" */ A, B C](a A) B`,\n-\t`package p; func (T) _[ /* ERROR \"must have no type parameters\" */ A, B C[A, B]](a A) B`,\n+\t`package p; func (T) _[A, B any](a A) B`,\n+\t`package p; func (T) _[A, B C](a A) B`,\n+\t`package p; func (T) _[A, B C[A, B]](a A) B`,\n \n \t`package p; func(*T[e, e /* ERROR \"e redeclared\" */ ]) _()`,\n ","additions":3,"deletions":3},{"filename":"src/go/parser/testdata/issue50427.go2","patch":"@@ -12,7 +12,7 @@ func _(t T) {\n \n type S struct{}\n \n-func (S) m[ /* ERROR \"must have no type parameters\" */ P any]() {}\n+func (S) m[P any]() {}\n \n func _(s S) {\n \tvar _ interface{ m[ /* ERROR \"must have no type parameters\" */ P any](); n() } = s","additions":1,"deletions":1},{"filename":"src/go/types/interface.go","patch":"@@ -188,13 +188,13 @@ func (check *Checker) interfaceType(ityp *Interface, iface *ast.InterfaceType, d\n \t\t\tcontinue // ignore\n \t\t}\n \n-\t\t// The go/parser doesn't accept method type parameters but an ast.FuncType may have them.\n+\t\t// The go/parser doesn't accept interface method type parameters but an ast.FuncType may have them.\n \t\tif sig.tparams != nil {\n \t\t\tvar at positioner = f.Type\n \t\t\tif ftyp, _ := f.Type.(*ast.FuncType); ftyp != nil && ftyp.TypeParams != nil {\n \t\t\t\tat = ftyp.TypeParams\n \t\t\t}\n-\t\t\tcheck.error(at, InvalidSyntaxTree, \"methods cannot have type parameters\")\n+\t\t\tcheck.error(at, InvalidSyntaxTree, \"interface methods cannot have type parameters\")\n \t\t}\n \n \t\t// use named receiver type if available (for better error messages)","additions":2,"deletions":2},{"filename":"src/go/types/resolver.go","patch":"@@ -446,6 +446,11 @@ func (check *Checker) collectObjects() {\n \t\t\t\t\tif recv, _ := base.(*ast.Ident); recv != nil && name != \"_\" {\n \t\t\t\t\t\tmethods = append(methods, methodInfo{obj, ptr, recv})\n \t\t\t\t\t}\n+\t\t\t\t\t// methods cannot have type parameters for now\n+\t\t\t\t\tif d.decl.Type.TypeParams.NumFields() != 0 {\n+\t\t\t\t\t\tcheck.softErrorf(d.decl.Type.TypeParams.List[0], InvalidMethodTypeParams, \"method %s must have no type parameters\", name)\n+\t\t\t\t\t\thasTParamError = true\n+\t\t\t\t\t}\n \t\t\t\t\tcheck.recordDef(d.decl.Name, obj)\n \t\t\t\t}\n \t\t\t\t_ = d.decl.Type.TypeParams.NumFields() != 0 && !hasTParamError && check.verifyVersionf(d.decl.Type.TypeParams.List[0], go1_18, \"type parameter\")","additions":5,"deletions":0},{"filename":"src/go/types/signature.go","patch":"@@ -173,12 +173,6 @@ func (check *Checker) funcType(sig *Signature, recvPar *ast.FieldList, ftyp *ast\n \n \t// collect and declare function type parameters\n \tif ftyp.TypeParams != nil {\n-\t\t// Always type-check method type parameters but complain that they are not allowed.\n-\t\t// (A separate check is needed when type-checking interface method signatures because\n-\t\t// they don't have a receiver specification.)\n-\t\tif recvPar != nil {\n-\t\t\tcheck.error(ftyp.TypeParams, InvalidMethodTypeParams, \"methods cannot have type parameters\")\n-\t\t}\n \t\tcheck.collectTypeParams(&sig.tparams, ftyp.TypeParams)\n \t}\n ","additions":0,"deletions":6},{"filename":"src/internal/runtime/gc/scan/scan_amd64.go","patch":"@@ -38,4 +38,5 @@ var avx512ScanPackedReqsMet = cpu.X86.HasAVX512VL &&\n \tcpu.X86.HasAVX512BW &&\n \tcpu.X86.HasGFNI &&\n \tcpu.X86.HasAVX512BITALG &&\n-\tcpu.X86.HasAVX512VBMI\n+\tcpu.X86.HasAVX512VBMI &&\n+\tcpu.X86.HasPOPCNT","additions":2,"deletions":1},{"filename":"src/internal/syscall/windows/at_windows.go","patch":"@@ -355,7 +355,7 @@ func deleteatFallback(h syscall.Handle) error {\n \t\th,\n \t\tFileDispositionInfo,\n \t\tunsafe.Pointer(&FILE_DISPOSITION_INFO{\n-\t\t\tDeleteFile: true,\n+\t\t\tDeleteFile: 1,\n \t\t}),\n \t\tuint32(unsafe.Sizeof(FILE_DISPOSITION_INFO{})),\n \t)\n@@ -416,7 +416,7 @@ func Renameat(olddirfd syscall.Handle, oldpath string, newdirfd syscall.Handle,\n \t//\n \t// Try again.\n \trenameInfo := FILE_RENAME_INFORMATION{\n-\t\tReplaceIfExists: true,\n+\t\tReplaceIfExists: 1,\n \t\tRootDirectory: newdirfd,\n \t}\n \tcopy(renameInfo.FileName[:], p16)\n@@ -602,7 +602,7 @@ func symlinkat(oldname string, newdirfd syscall.Handle, newname string, flags Sy\n \t\t\th,\n \t\t\t&IO_STATUS_BLOCK{},\n \t\t\tunsafe.Pointer(&FILE_DISPOSITION_INFORMATION{\n-\t\t\t\tDeleteFile: true,\n+\t\t\t\tDeleteFile: 1,\n \t\t\t}),\n \t\t\tuint32(unsafe.Sizeof(FILE_DISPOSITION_INFORMATION{})),\n \t\t\tFileDispositionInformation,","additions":3,"deletions":3},{"filename":"src/internal/syscall/windows/types_windows.go","patch":"@@ -219,12 +219,12 @@ const (\n \n // https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_disposition_info\n type FILE_DISPOSITION_INFO struct {\n-\tDeleteFile bool\n+\tDeleteFile byte\n }\n \n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntddk/ns-ntddk-_file_disposition_information\n type FILE_DISPOSITION_INFORMATION struct {\n-\tDeleteFile bool\n+\tDeleteFile byte\n }\n \n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntddk/ns-ntddk-_file_disposition_information_ex\n@@ -250,7 +250,7 @@ const (\n \n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_file_rename_information\n type FILE_RENAME_INFORMATION struct {\n-\tReplaceIfExists bool\n+\tReplaceIfExists byte\n \tRootDirectory syscall.Handle\n \tFileNameLength uint32\n \tFileName [syscall.MAX_PATH]uint16\n@@ -266,7 +266,7 @@ type FILE_RENAME_INFORMATION_EX struct {\n \n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_file_link_information\n type FILE_LINK_INFORMATION struct {\n-\tReplaceIfExists bool\n+\tReplaceIfExists byte\n \tRootDirectory syscall.Handle\n \tFileNameLength uint32\n \tFileName [syscall.MAX_PATH]uint16","additions":4,"deletions":4},{"filename":"src/internal/types/testdata/check/typeparams.go","patch":"@@ -329,8 +329,8 @@ func init[P /* ERROR \"func init must have no type parameters\" */ any]() {}\n type T struct {}\n \n func (T) m1() {}\n-func (T) m2[ /* ERROR \"method must have no type parameters\" */ _ any]() {}\n-func (T) m3[ /* ERROR \"method must have no type parameters\" */ P any]() {}\n+func (T) m2[_ /* ERROR \"method m2 must have no type parameters\" */ any]() {}\n+func (T) m3[P /* ERROR \"method m3 must have no type parameters\" */ any]() {}\n \n // type inference across parameterized types\n ","additions":2,"deletions":2},{"filename":"src/internal/types/testdata/fixedbugs/issue50427.go","patch":"@@ -15,7 +15,7 @@ func _(t T) {\n \n type S struct{}\n \n-func (S) m[ /* ERROR \"must have no type parameters\" */ P any]() {}\n+func (S) m[P /* ERROR \"must have no type parameters\" */ any]() {}\n \n func _(s S) {\n \tvar _ interface{ m[ /* ERROR \"must have no type parameters\" */ P any](); n() } = s /* ERROR \"does not implement\" */","additions":1,"deletions":1},{"filename":"src/mime/type.go","patch":"@@ -115,7 +115,8 @@ var builtinTypesLower = map[string]string{\n \t\".vtt\": \"text/vtt; charset=utf-8\",\n \t\".wasm\": \"application/wasm\",\n \t\".wav\": \"audio/wav\",\n-\t\".webm\": \"audio/webm\",\n+\t\".weba\": \"audio/webm\",\n+\t\".webm\": \"video/webm\",\n \t\".webp\": \"image/webp\",\n \t\".xbl\": \"text/xml; charset=utf-8\",\n \t\".xbm\": \"image/x-xbitmap\",","additions":2,"deletions":1},{"filename":"src/mime/type_test.go","patch":"@@ -245,7 +245,8 @@ func TestExtensionsByType2(t *testing.T) {\n \t\t{typ: \"text/vtt; charset=utf-8\", want: []string{\".vtt\"}},\n \t\t{typ: \"application/wasm\", want: []string{\".wasm\"}},\n \t\t{typ: \"audio/wav\", want: []string{\".wav\"}},\n-\t\t{typ: \"audio/webm\", want: []string{\".webm\"}},\n+\t\t{typ: \"audio/webm\", want: []string{\".weba\"}},\n+\t\t{typ: \"video/webm\", want: []string{\".webm\"}},\n \t\t{typ: \"image/webp\", want: []string{\".webp\"}},\n \t\t{typ: \"text/xml; charset=utf-8\", want: []string{\".xbl\", \".xml\", \".xsl\"}},\n \t\t{typ: \"image/x-xbitmap\", want: []string{\".xbm\"}},","additions":2,"deletions":1},{"filename":"src/net/http/clone.go","patch":"@@ -39,16 +39,7 @@ func cloneURLValues(v url.Values) url.Values {\n //\n //go:linkname cloneURL\n func cloneURL(u *url.URL) *url.URL {\n-\tif u == nil {\n-\t\treturn nil\n-\t}\n-\tu2 := new(url.URL)\n-\t*u2 = *u\n-\tif u.User != nil {\n-\t\tu2.User = new(url.Userinfo)\n-\t\t*u2.User = *u.User\n-\t}\n-\treturn u2\n+\treturn u.Clone()\n }\n \n // cloneMultipartForm should be an internal detail,","additions":1,"deletions":10},{"filename":"src/net/ipsock_posix.go","patch":"@@ -158,7 +158,7 @@ func favoriteAddrFamily(network string, laddr, raddr sockaddr, mode string) (fam\n \n func internetSocket(ctx context.Context, net string, laddr, raddr sockaddr, sotype, proto int, mode string, ctrlCtxFn func(context.Context, string, string, syscall.RawConn) error) (fd *netFD, err error) {\n \tswitch runtime.GOOS {\n-\tcase \"aix\", \"windows\", \"openbsd\", \"js\", \"wasip1\":\n+\tcase \"aix\", \"freebsd\", \"windows\", \"openbsd\", \"js\", \"wasip1\":\n \t\tif mode == \"dial\" && raddr.isWildcard() {\n \t\t\traddr = raddr.toLocal(net)\n \t\t}","additions":1,"deletions":1},{"filename":"src/net/url/url.go","patch":"@@ -1322,3 +1322,16 @@ func JoinPath(base string, elem ...string) (result string, err error) {\n \t}\n \treturn res.String(), nil\n }\n+\n+// Clone creates a deep copy of the fields of the subject [URL].\n+func (u *URL) Clone() *URL {\n+\tif u == nil {\n+\t\treturn nil\n+\t}\n+\n+\tuc := new(*u)\n+\tif u.User != nil {\n+\t\tuc.User = new(*u.User)\n+\t}\n+\treturn uc\n+}","additions":13,"deletions":0},{"filename":"src/net/url/url_test.go","patch":"@@ -10,6 +10,7 @@ import (\n \t\"encoding/gob\"\n \t\"encoding/json\"\n \t\"fmt\"\n+\t\"internal/diff\"\n \t\"io\"\n \t\"net\"\n \t\"reflect\"\n@@ -2361,3 +2362,78 @@ func TestParseStrictIpv6(t *testing.T) {\n \t}\n \n }\n+\n+func TestURLClone(t *testing.T) {\n+\ttests := []struct {\n+\t\tname string\n+\t\tin *URL\n+\t}{\n+\t\t{\"nil\", nil},\n+\t\t{\"zero value\", &URL{}},\n+\t\t{\n+\t\t\t\"Populated but nil .User\",\n+\t\t\t&URL{\n+\t\t\t\tUser: nil,\n+\t\t\t\tHost: \"foo\",\n+\t\t\t\tPath: \"/path\",\n+\t\t\t\tRawQuery: \"a=b\",\n+\t\t\t},\n+\t\t},\n+\t\t{\n+\t\t\t\"non-nil .User\",\n+\t\t\t&URL{\n+\t\t\t\tUser: User(\"user\"),\n+\t\t\t\tHost: \"foo\",\n+\t\t\t\tPath: \"/path\",\n+\t\t\t\tRawQuery: \"a=b\",\n+\t\t\t},\n+\t\t},\n+\t\t{\n+\t\t\t\"non-nil .User: user and password set\",\n+\t\t\t&URL{\n+\t\t\t\tUser: UserPassword(\"user\", \"password\"),\n+\t\t\t\tHost: \"foo\",\n+\t\t\t\tPath: \"/path\",\n+\t\t\t\tRawQuery: \"a=b\",\n+\t\t\t},\n+\t\t},\n+\t}\n+\n+\tfor _, tt := range tests {\n+\t\tt.Run(tt.name, func(t *testing.T) {\n+\t\t\t// 1. The cloned URL must always deep equal the input, but never the same pointer.\n+\t\t\tcloned := tt.in.Clone()\n+\t\t\tif !reflect.DeepEqual(tt.in, cloned) {\n+\t\t\t\tt.Fatalf(\"Differing values\\n%s\",\n+\t\t\t\t\tdiff.Diff(\"original\", []byte(tt.in.String()), \"cloned\", []byte(cloned.String())))\n+\t\t\t}\n+\t\t\tif tt.in == nil {\n+\t\t\t\treturn\n+\t\t\t}\n+\n+\t\t\t// Ensure that their pointer values are not the same.\n+\t\t\tif tt.in == cloned {\n+\t\t\t\tt.Fatalf(\"URL: same pointer returned: %p\", cloned)\n+\t\t\t}\n+\n+\t\t\t// 2. Test out malleability of URL fields.\n+\t\t\tcloned.Scheme = \"https\"\n+\t\t\tif cloned.Scheme == tt.in.Scheme {\n+\t\t\t\tt.Error(\"Inconsistent state: cloned.scheme changed and reflected in the input's scheme\")\n+\t\t\t}\n+\t\t\tif reflect.DeepEqual(tt.in, cloned) {\n+\t\t\t\tt.Fatal(\"Inconsistent state: cloned and input are somehow the same\")\n+\t\t\t}\n+\n+\t\t\t// 3. Ensure that the .User object deep equals but not the same pointer.\n+\t\t\tif !reflect.DeepEqual(tt.in.User, cloned.User) {\n+\t\t\t\tt.Fatalf(\"Differing .User\\n%s\",\n+\t\t\t\t\tdiff.Diff(\"original\", []byte(tt.in.String()), \"cloned\", []byte(cloned.String())))\n+\t\t\t}\n+\t\t\tbothNil := tt.in.User == nil && cloned.User == nil\n+\t\t\tif !bothNil && tt.in.User == cloned.User {\n+\t\t\t\tt.Fatalf(\".User: same pointer returned: %p\", cloned.User)\n+\t\t\t}\n+\t\t})\n+\t}\n+}","additions":76,"deletions":0},{"filename":"src/runtime/asm_ppc64x.s","patch":"@@ -197,9 +197,9 @@ TEXT runtime·breakpoint(SB),NOSPLIT|NOFRAME,$0-0\n TEXT runtime·asminit(SB),NOSPLIT|NOFRAME,$0-0\n \tRET\n \n-// Any changes must be reflected to runtime/cgo/gcc_aix_ppc64.S:.crosscall_ppc64\n+// Any changes must be reflected to runtime/cgo/gcc_aix_ppc64.S:.crosscall1\n TEXT _cgo_reginit(SB),NOSPLIT|NOFRAME,$0-0\n-\t// crosscall_ppc64 and crosscall2 need to reginit, but can't\n+\t// crosscall1 and crosscall2 need to reginit, but can't\n \t// get at the 'runtime.reginit' symbol.\n \tBR\truntime·reginit(SB)\n ","additions":2,"deletions":2},{"filename":"src/runtime/cgo/gcc_aix_ppc64.S","patch":"@@ -5,23 +5,24 @@\n .file \"gcc_aix_ppc64.S\"\n \n /*\n- * void crosscall_ppc64(void (*fn)(void), void *g)\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\n *\n * Calling into the gc tool chain, where all registers are caller save.\n * Called from standard ppc64 C ABI, where r2, r14-r31, f14-f31 are\n * callee-save, so they must be saved explicitly.\n * AIX has a special assembly syntax and keywords that can be mixed with\n * Linux assembly.\n+ * ABI: r3=fn, r4=setg_gcc, r5=g\n */\n .toc\n .csect .text[PR]\n- .globl crosscall_ppc64\n- .globl .crosscall_ppc64\n- .csect crosscall_ppc64[DS]\n-crosscall_ppc64:\n- .llong .crosscall_ppc64, TOC[tc0], 0\n+ .globl crosscall1\n+ .globl .crosscall1\n+ .csect crosscall1[DS]\n+crosscall1:\n+ .llong .crosscall1, TOC[tc0], 0\n .csect .text[PR]\n-.crosscall_ppc64:\n+.crosscall1:\n \t// Start with standard C stack frame layout and linkage\n \tmflr\t0\n \tstd\t0, 16(1)\t// Save LR in caller's frame\n@@ -33,11 +34,19 @@ crosscall_ppc64:\n \t// Must match _cgo_reginit in runtime package.\n \txor 0, 0, 0\n \n+\t// Save fn in r14 (callee-save) so we can reuse r3 for setg_gcc call\n+\tmr\t14, 3\n \t// Restore g pointer (r30 in Go ABI, which may have been clobbered by C)\n-\tmr\t30, 4\n+\tmr\t30, 5\n+\n+\t// Call setg_gcc(g)\n+\tmr\t3, 5 // arg g\n+\tmr\t12, 4 // setg_gcc\n+\tmtctr\t12\n+\tbctrl\n \n \t// Call fn\n-\tmr\t12, 3\n+\tmr\t12, 14\n \tmtctr\t12\n \tbctrl\n ","additions":18,"deletions":9},{"filename":"src/runtime/cgo/gcc_android.c","patch":"@@ -2,36 +2,10 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n-#include <stdarg.h>\n-#include <android/log.h>\n #include <pthread.h>\n #include <dlfcn.h>\n #include \"libcgo.h\"\n \n-void\n-fatalf(const char* format, ...)\n-{\n-\tva_list ap;\n-\n-\t// Write to both stderr and logcat.\n-\t//\n-\t// When running from an .apk, /dev/stderr and /dev/stdout\n-\t// redirect to /dev/null. And when running a test binary\n-\t// via adb shell, it's easy to miss logcat.\n-\n-\tfprintf(stderr, \"runtime/cgo: \");\n-\tva_start(ap, format);\n-\tvfprintf(stderr, format, ap);\n-\tva_end(ap);\n-\tfprintf(stderr, \"\\n\");\n-\n-\tva_start(ap, format);\n-\t__android_log_vprint(ANDROID_LOG_FATAL, \"runtime/cgo\", format, ap);\n-\tva_end(ap);\n-\n-\tabort();\n-}\n-\n // Truncated to a different magic value on 32-bit; that's ok.\n #define magic1 (0x23581321345589ULL)\n ","additions":0,"deletions":26},{"filename":"src/runtime/cgo/gcc_fatalf.c","patch":"@@ -2,11 +2,12 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n-//go:build unix && !android\n+//go:build unix\n \n #include <stdarg.h>\n-#include <stdio.h>\n-#include <stdlib.h>\n+#ifdef __ANDROID__\n+#include <android/log.h>\n+#endif\n #include \"libcgo.h\"\n \n void\n@@ -19,5 +20,15 @@ fatalf(const char* format, ...)\n \tvfprintf(stderr, format, ap);\n \tva_end(ap);\n \tfprintf(stderr, \"\\n\");\n+\n+#ifdef __ANDROID__\n+\t// When running from an Android .apk, /dev/stderr and /dev/stdout\n+\t// redirect to /dev/null. And when running a test binary\n+\t// via adb shell, it's easy to miss logcat. So write to both.\n+\tva_start(ap, format);\n+\t__android_log_vprint(ANDROID_LOG_FATAL, \"runtime/cgo\", format, ap);\n+\tva_end(ap);\n+#endif\n+\n \tabort();\n }","additions":14,"deletions":3},{"filename":"src/runtime/cgo/gcc_freebsd.c","patch":"@@ -1,16 +0,0 @@\n-// Copyright 2009 The Go Authors. All rights reserved.\n-// Use of this source code is governed by a BSD-style\n-// license that can be found in the LICENSE file.\n-\n-//go:build freebsd\n-\n-#include <machine/sysarch.h>\n-\n-#ifdef ARM_TP_ADDRESS\n-// ARM_TP_ADDRESS is (ARM_VECTORS_HIGH + 0x1000) or 0xffff1000\n-// and is known to runtime.read_tls_fallback. Verify it with\n-// cpp.\n-#if ARM_TP_ADDRESS != 0xffff1000\n-#error Wrong ARM_TP_ADDRESS!\n-#endif\n-#endif","additions":0,"deletions":16},{"filename":"src/runtime/cgo/gcc_linux_ppc64x.S","patch":"@@ -38,14 +38,15 @@\n .endm\n \n /*\n- * void crosscall_ppc64(void (*fn)(void), void *g)\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\n *\n * Calling into the gc tool chain, where all registers are caller save.\n * Called from standard ppc64 C ABI, where r2, r14-r31, f14-f31 are\n * callee-save, so they must be saved explicitly.\n+ * ABI: r3=fn, r4=setg_gcc, r5=g on entry.\n */\n-.globl crosscall_ppc64\n-crosscall_ppc64:\n+.globl crosscall1\n+crosscall1:\n \t// Start with standard C stack frame layout and linkage\n \tmflr\t%r0\n \tstd\t%r0, 16(%r1)\t// Save LR in caller's frame\n@@ -61,12 +62,20 @@ crosscall_ppc64:\n \t// Set up Go ABI constant registers\n \tli\t%r0, 0\n \n+\t// Save fn in r14 (callee-save) while we call setg_gcc\n+\tmr\t%r14, %r3\n \t// Restore g pointer (r30 in Go ABI, which may have been clobbered by C)\n-\tmr\t%r30, %r4\n+\tmr\t%r30, %r5\n \n-\t// Call fn\n-\tmr\t%r12, %r3\n-\tmtctr\t%r3\n+\t// Call setg_gcc(g)\n+\tmr\t%r3, %r5 /* arg: g */\n+\tmr\t%r12, %r4 /* setg_gcc */\n+\tmtctr\t%r12\n+\tbctrl\n+\n+\t// Call fn()\n+\tmr\t%r12, %r14\n+\tmtctr\t%r12\n \tbctrl\n \n \tFOR_EACH_GPR ld","additions":16,"deletions":7},{"filename":"src/runtime/cgo/gcc_s390x.S","patch":"@@ -5,14 +5,15 @@\n .file \"gcc_s390x.S\"\n \n /*\n- * void crosscall_s390x(void (*fn)(void), void *g)\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\n *\n * Calling into the go tool chain, where all registers are caller save.\n * Called from standard s390x C ABI, where r6-r13, r15, and f8-f15 are\n * callee-save, so they must be saved explicitly.\n+ * ABI: r2=fn, r3=setg_gcc, r4=g.\n */\n-.globl crosscall_s390x\n-crosscall_s390x:\n+.globl crosscall1\n+crosscall1:\n \t/* save r6-r15 in the register save area of the calling function */\n \tstmg %r6, %r15, 48(%r15)\n \n@@ -29,10 +30,18 @@ crosscall_s390x:\n \tstd %f14, 48(%r15)\n \tstd %f15, 56(%r15)\n \n+\t/* save fn pointer in r6 (already saved to stack) */\n+\tlgr %r6, %r2\n \t/* restore g pointer */\n-\tlgr %r13, %r3\n+\tlgr %r13, %r4\n+\n+\t/* prepare arg for setg_gcc: first argument in r2 */\n+\tlgr %r2, %r4 /* r2 = g */\n+\t/* call setg_gcc(g) using function pointer in r3 */\n+\tbasr %r14, %r3\n \n \t/* call fn */\n+\tlgr %r2, %r6\n \tbasr %r14, %r2\n \n \t/* restore floating point registers */","additions":13,"deletions":4},{"filename":"src/runtime/cgo/gcc_solaris_amd64.c","patch":"@@ -1,46 +0,0 @@\n-// Copyright 2015 The Go Authors. All rights reserved.\n-// Use of this source code is governed by a BSD-style\n-// license that can be found in the LICENSE file.\n-\n-#include <string.h>\n-#include <ucontext.h>\n-#include \"libcgo.h\"\n-#include \"libcgo_unix.h\"\n-\n-static void (*setg_gcc)(void*);\n-\n-void\n-x_cgo_init(G *g, void (*setg)(void*))\n-{\n-\tucontext_t ctx;\n-\n-\tsetg_gcc = setg;\n-\tif (getcontext(&ctx) != 0)\n-\t\tperror(\"runtime/cgo: getcontext failed\");\n-\tg->stacklo = (uintptr_t)ctx.uc_stack.ss_sp;\n-\n-\t// Solaris processes report a tiny stack when run with \"ulimit -s unlimited\".\n-\t// Correct that as best we can: assume it's at least 1 MB.\n-\t// See golang.org/issue/12210.\n-\tif(ctx.uc_stack.ss_size < 1024*1024)\n-\t\tg->stacklo -= 1024*1024 - ctx.uc_stack.ss_size;\n-\n-\t// Sanity check the results now, rather than getting a\n-\t// morestack on g0 crash.\n-\tif (g->stacklo >= g->stackhi) {\n-\t\tfatalf(\"bad stack bounds: lo=%p hi=%p\", (void*)(g->stacklo), (void*)(g->stackhi));\n-\t}\n-}\n-\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n-void*\n-threadentry(void *v)\n-{\n-\tThreadStart ts;\n-\n-\tts = *(ThreadStart*)v;\n-\tfree(v);\n-\n-\tcrosscall1(ts.fn, setg_gcc, (void*)ts.g);\n-\treturn nil;\n-}","additions":0,"deletions":46},{"filename":"src/runtime/cgo/gcc_unix.c","patch":"@@ -2,7 +2,7 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n-//go:build unix && !solaris\n+//go:build unix\n \n #include \"libcgo.h\"\n #include \"libcgo_unix.h\"\n@@ -48,16 +48,6 @@ x_cgo_init(G *g, void (*setg)(void*), void **tlsg, void **tlsbase)\n \t}\n }\n \n-// TODO: change crosscall_ppc64 and crosscall_s390x so that it matches crosscall1\n-// signature and behavior.\n-#if defined(__powerpc64__)\n-extern void crosscall_ppc64(void (*fn)(void), void *g);\n-#elif defined(__s390x__)\n-extern void crosscall_s390x(void (*fn)(void), void *g);\n-#else\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n-#endif\n-\n void*\n threadentry(void *v)\n {\n@@ -72,16 +62,6 @@ threadentry(void *v)\n \t\tx_cgo_threadentry_platform();\n \t}\n \n-#if defined(__powerpc64__)\n-\t// Save g for this thread in C TLS\n-\tsetg_gcc((void*)ts.g);\n-\tcrosscall_ppc64(ts.fn, (void*)ts.g);\n-#elif defined(__s390x__)\n-\t// Save g for this thread in C TLS\n-\tsetg_gcc((void*)ts.g);\n-\tcrosscall_s390x(ts.fn, (void*)ts.g);\n-#else\n \tcrosscall1(ts.fn, setg_gcc, ts.g);\n-#endif\n \treturn NULL;\n }","additions":1,"deletions":21},{"filename":"src/runtime/cgo/gcc_windows_386.c","patch":"@@ -28,7 +28,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\n \t_cgo_beginthread(threadentry, ts);\n }\n \n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n static unsigned long\n __stdcall\n threadentry(void *v)","additions":0,"deletions":1},{"filename":"src/runtime/cgo/gcc_windows_amd64.c","patch":"@@ -29,7 +29,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\n \t_cgo_beginthread(threadentry, ts);\n }\n \n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n static unsigned long\n __stdcall\n threadentry(void *v)","additions":0,"deletions":1},{"filename":"src/runtime/cgo/gcc_windows_arm64.c","patch":"@@ -26,7 +26,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\n \t_cgo_beginthread(threadentry, ts);\n }\n \n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n \n static unsigned long\n __stdcall","additions":0,"deletions":1},{"filename":"src/runtime/cgo/libcgo.h","patch":"@@ -73,6 +73,13 @@ uintptr_t _cgo_wait_runtime_init_done(void);\n */\n void x_cgo_getstackbound(uintptr bounds[2]);\n \n+/*\n+ * Calls into the Go tool chain, where all registers are caller save.\n+ * Called from C, it saves all callee-save registers and calls\n+ * setg_gcc to set g before calling fn.\n+ */\n+void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\n+\n /*\n * Prints error then calls abort. For linux and android.\n */","additions":7,"deletions":0},{"filename":"src/runtime/cgo_ppc64x.go","patch":"@@ -6,7 +6,7 @@\n \n package runtime\n \n-// crosscall_ppc64 calls into the runtime to set up the registers the\n+// crosscall1 calls into the runtime to set up the registers the\n // Go runtime expects and so the symbol it calls needs to be exported\n // for external linking to work.\n //","additions":1,"deletions":1},{"filename":"src/runtime/cgocall.go","patch":"@@ -428,7 +428,10 @@ func cgocallbackg1(fn, frame unsafe.Pointer, ctxt uintptr) {\n \t\t//\n \t\t// We check a bool first for speed, and wait on a channel\n \t\t// if it's not ready.\n-\t\tif !mainInitDone.Load() {\n+\t\t//\n+\t\t// In race mode, skip the optimization and always use the\n+\t\t// channel, which has the race instrumentation.\n+\t\tif raceenabled || !mainInitDone.Load() {\n \t\t\t<-mainInitDoneChan\n \t\t}\n \t}","additions":4,"deletions":1},{"filename":"src/runtime/runtime2.go","patch":"@@ -301,8 +301,6 @@ func setMNoWB(mp **m, new *m) {\n }\n \n type gobuf struct {\n-\t// The offsets of sp, pc, and g are known to (hard-coded in) libmach.\n-\t//\n \t// ctxt is unusual with respect to GC: it may be a\n \t// heap-allocated funcval, so GC needs to track it, but it\n \t// needs to be set and cleared from assembly, where it's\n@@ -479,12 +477,12 @@ type g struct {\n \t// It is stack.lo+StackGuard on g0 and gsignal stacks.\n \t// It is ~0 on other goroutine stacks, to trigger a call to morestackc (and crash).\n \tstack stack // offset known to runtime/cgo\n-\tstackguard0 uintptr // offset known to liblink\n-\tstackguard1 uintptr // offset known to liblink\n+\tstackguard0 uintptr // offset known to cmd/internal/obj/*\n+\tstackguard1 uintptr // offset known to cmd/internal/obj/*\n \n-\t_panic *_panic // innermost panic - offset known to liblink\n+\t_panic *_panic // innermost panic\n \t_defer *_defer // innermost defer\n-\tm *m // current m; offset known to arm liblink\n+\tm *m // current m\n \tsched gobuf\n \tsyscallsp uintptr // if status==Gsyscall, syscallsp = sched.sp to use during gc\n \tsyscallpc uintptr // if status==Gsyscall, syscallpc = sched.pc to use during gc","additions":4,"deletions":6},{"filename":"src/runtime/secret/crash_test.go","patch":"@@ -10,6 +10,9 @@ import (\n \t\"bytes\"\n \t\"debug/elf\"\n \t\"fmt\"\n+\t\"internal/asan\"\n+\t\"internal/msan\"\n+\t\"internal/race\"\n \t\"internal/testenv\"\n \t\"io\"\n \t\"os\"\n@@ -120,7 +123,18 @@ func TestCore(t *testing.T) {\n \t\tt.Fatalf(\"error initing module %v\\n%s\", err, out)\n \t}\n \n-\tcmd = exec.Command(testenv.GoToolPath(t), \"build\", \"-o\", filepath.Join(tmpDir, \"a.exe\"))\n+\t// Pass through the flags for any of the memory validating modes\n+\targs := []string{\"build\", \"-o\", filepath.Join(tmpDir, \"a.exe\")}\n+\tif msan.Enabled {\n+\t\targs = append(args, \"-msan\")\n+\t}\n+\tif asan.Enabled {\n+\t\targs = append(args, \"-asan\")\n+\t}\n+\tif race.Enabled {\n+\t\targs = append(args, \"-race\")\n+\t}\n+\tcmd = exec.Command(testenv.GoToolPath(t), args...)\n \tcmd.Dir = tmpDir\n \tout, err = testenv.CleanCmdEnv(cmd).CombinedOutput()\n \tif err != nil {","additions":15,"deletions":1},{"filename":"test/fixedbugs/issue77534.go","patch":"@@ -0,0 +1,36 @@\n+// compile\n+\n+// Copyright 2026 The Go Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style\n+// license that can be found in the LICENSE file.\n+\n+// Issue 77534: compiler crash when >4 fields, but only one nonempty pointer field.\n+\n+package p\n+\n+type T struct {\n+\ta, b, c, d struct{}\n+\te *byte\n+}\n+\n+func f1(p *any, t T) {\n+\t*p = t\n+}\n+\n+func f2(p *any, t *T) {\n+\t*p = *t\n+}\n+\n+func f3(p, x, y *T, b bool) {\n+\tvar z T\n+\tif b {\n+\t\tz = *x\n+\t} else {\n+\t\tz = *y\n+\t}\n+\t*p = z\n+}\n+\n+func f4(i any) T {\n+\treturn i.(T)\n+}","additions":36,"deletions":0},{"filename":"test/typeparam/issue50317.go","patch":"@@ -8,8 +8,8 @@ package p\n \n type S struct{}\n \n-func (S) _[_ any]() {} // ERROR \"method must have no type parameters\"\n+func (S) _[_ any]() {} // ERROR \"method _ must have no type parameters\"\n \n type _ interface {\n-\tm[_ any]() // ERROR \"method must have no type parameters\"\n+\tm[_ any]() // ERROR \"interface method must have no type parameters\"\n }","additions":2,"deletions":2}],"string":"[\n {\n \"filename\": \"api/next/73450.txt\",\n \"patch\": \"@@ -0,0 +1 @@\\n+pkg net/url, method (*URL) Clone() *URL #73450\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"doc/next/6-stdlib/99-minor/net/url/73450.md\",\n \"patch\": \"@@ -0,0 +1 @@\\n+The new [URL.Clone] method creates a deep copy of a URL.\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/asm/internal/asm/testdata/arm64.s\",\n \"patch\": \"@@ -698,6 +698,12 @@ TEXT\\tfoo(SB), DUPOK|NOSPLIT, $-8\\n \\tFMOVD\\tF4, (R2)(R6) // 446826fc\\n \\tFMOVD\\tF4, (R2)(R6<<3) // 447826fc\\n \\n+// global address\\n+\\tFMOVQ\\tF5, x+8(SB)\\n+\\tFMOVQ\\tF5, x(SB)\\n+\\tFMOVQ\\tx+8(SB), F5\\n+\\tFMOVQ\\tx(SB), F5\\n+\\n // vmov\\n \\tVMOV\\tV8.S[1], R1 // 013d0c0e\\n \\tVMOV\\tV0.D[0], R11 // 0b3c084e\",\n \"additions\": 6,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/cgo/internal/test/cgo_test.go\",\n \"patch\": \"@@ -78,6 +78,7 @@ func TestBoolAlign(t *testing.T) { testBoolAlign(t) }\\n func TestCallGoWithString(t *testing.T) { testCallGoWithString(t) }\\n func TestCallback(t *testing.T) { testCallback(t) }\\n func TestCallbackCallers(t *testing.T) { testCallbackCallers(t) }\\n+func TestCallbackInInit(t *testing.T) { testCallbackInInit(t) }\\n func TestCallbackGC(t *testing.T) { testCallbackGC(t) }\\n func TestCallbackPanic(t *testing.T) { testCallbackPanic(t) }\\n func TestCallbackPanicLocked(t *testing.T) { testCallbackPanicLocked(t) }\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/cgo/internal/test/cthread_unix.c\",\n \"patch\": \"@@ -56,3 +56,18 @@ callGoInCThread(int max)\\n \\n \\treturn max;\\n }\\n+\\n+static void*\\n+callbackInInitCThread(void* unused)\\n+{\\n+\\tcallbackInInit();\\n+\\treturn NULL;\\n+}\\n+\\n+void\\n+callbackInInitC(void)\\n+{\\n+\\tpthread_t thread;\\n+\\n+\\tpthread_create(&thread, NULL, callbackInInitCThread, NULL);\\n+}\",\n \"additions\": 15,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/cgo/internal/test/cthread_windows.c\",\n \"patch\": \"@@ -57,3 +57,19 @@ callGoInCThread(int max)\\n \\tCloseHandle((HANDLE)thread_id);\\n \\treturn max;\\n }\\n+\\n+__stdcall\\n+static unsigned int\\n+callbackInInitCThread(void* unused)\\n+{\\n+\\tcallbackInInit();\\n+\\treturn 0;\\n+}\\n+\\n+void\\n+callbackInInitC(void)\\n+{\\n+\\tuintptr_t thread_id;\\n+\\tthread_id = _beginthreadex(0, 0, callbackInInitCThread, NULL, 0, 0);\\n+\\tCloseHandle((HANDLE)thread_id);\\n+}\",\n \"additions\": 16,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/cgo/internal/test/testx.go\",\n \"patch\": \"@@ -26,6 +26,7 @@ import (\\n // threads\\n extern void doAdd(int, int);\\n extern int callGoInCThread(int);\\n+extern void callbackInInitC(void);\\n \\n // issue 1328\\n void IntoC(void);\\n@@ -622,3 +623,28 @@ func ditCallback() uint8 {\\n \\t}\\n \\treturn 0\\n }\\n+\\n+// Test C calling back into Go before init is done.\\n+// In particular, this does not trigger false race\\n+// (the fix is in CL 746581).\\n+\\n+var callbackInInitVar int\\n+\\n+func init() {\\n+\\tC.callbackInInitC()\\n+\\tcallbackInInitVar = 123\\n+}\\n+\\n+var callbackInInitChan = make(chan int)\\n+\\n+//export callbackInInit\\n+func callbackInInit() {\\n+\\tif callbackInInitVar != 123 {\\n+\\t\\tpanic(\\\"callbackInInitVar not initialized to 123\\\")\\n+\\t}\\n+\\tcallbackInInitChan <- 1\\n+}\\n+\\n+func testCallbackInInit(t *testing.T) {\\n+\\t<-callbackInInitChan // make sure callbackInInit runs\\n+}\",\n \"additions\": 26,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/compile/internal/base/flag.go\",\n \"patch\": \"@@ -78,6 +78,7 @@ type CmdFlags struct {\\n \\tLowerR CountFlag \\\"help:\\\\\\\"debug generated wrappers\\\\\\\"\\\"\\n \\tLowerT bool \\\"help:\\\\\\\"enable tracing for debugging the compiler\\\\\\\"\\\"\\n \\tLowerW CountFlag \\\"help:\\\\\\\"debug type checking\\\\\\\"\\\"\\n+\\tLowerU CountFlag \\\"help:\\\\\\\"emit unsorted warnings/errors\\\\\\\"\\\"\\n \\tLowerV *bool \\\"help:\\\\\\\"increase debug verbosity\\\\\\\"\\\"\\n \\n \\t// Special characters\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/compile/internal/base/print.go\",\n \"patch\": \"@@ -83,7 +83,9 @@ func FlushErrors() {\\n \\tif len(errorMsgs) == 0 {\\n \\t\\treturn\\n \\t}\\n-\\tsort.Stable(byPos(errorMsgs))\\n+\\tif Flag.LowerU == 0 {\\n+\\t\\tsort.Stable(byPos(errorMsgs))\\n+\\t}\\n \\tfor i, err := range errorMsgs {\\n \\t\\tif i == 0 || err.msg != errorMsgs[i-1].msg {\\n \\t\\t\\tfmt.Print(err.msg)\",\n \"additions\": 3,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/cmd/compile/internal/ssa/decompose.go\",\n \"patch\": \"@@ -363,20 +363,20 @@ func decomposeUserPhi(v *Value) {\\n func decomposeStructPhi(v *Value) {\\n \\tt := v.Type\\n \\tn := t.NumFields()\\n-\\tvar fields [MaxStruct]*Value\\n+\\tfields := make([]*Value, 0, MaxStruct)\\n \\tfor i := 0; i < n; i++ {\\n-\\t\\tfields[i] = v.Block.NewValue0(v.Pos, OpPhi, t.FieldType(i))\\n+\\t\\tfields = append(fields, v.Block.NewValue0(v.Pos, OpPhi, t.FieldType(i)))\\n \\t}\\n \\tfor _, a := range v.Args {\\n \\t\\tfor i := 0; i < n; i++ {\\n \\t\\t\\tfields[i].AddArg(a.Block.NewValue1I(v.Pos, OpStructSelect, t.FieldType(i), int64(i), a))\\n \\t\\t}\\n \\t}\\n \\tv.reset(OpStructMake)\\n-\\tv.AddArgs(fields[:n]...)\\n+\\tv.AddArgs(fields...)\\n \\n \\t// Recursively decompose phis for each field.\\n-\\tfor _, f := range fields[:n] {\\n+\\tfor _, f := range fields {\\n \\t\\tdecomposeUserPhi(f)\\n \\t}\\n }\",\n \"additions\": 4,\n \"deletions\": 4\n },\n {\n \"filename\": \"src/cmd/compile/internal/ssa/expand_calls.go\",\n \"patch\": \"@@ -566,7 +566,7 @@ func (x *expandState) rewriteSelectOrArg(pos src.XPos, b *Block, container, a, m\\n \\t\\t\\taddArg(e)\\n \\t\\t\\tpos = pos.WithNotStmt()\\n \\t\\t}\\n-\\t\\tif at.NumFields() > 4 {\\n+\\t\\tif at.NumFields() > MaxStruct && !types.IsDirectIface(at) {\\n \\t\\t\\tpanic(fmt.Errorf(\\\"Too many fields (%d, %d bytes), container=%s\\\", at.NumFields(), at.Size(), container.LongString()))\\n \\t\\t}\\n \\t\\ta = makeOf(a, OpStructMake, args)\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/cmd/compile/internal/ssa/value.go\",\n \"patch\": \"@@ -635,6 +635,10 @@ func CanSSA(t *types.Type) bool {\\n \\t\\t}\\n \\t\\treturn false\\n \\tcase types.TSTRUCT:\\n+\\t\\tif types.IsDirectIface(t) {\\n+\\t\\t\\t// Note: even if t.NumFields()>MaxStruct! See issue 77534.\\n+\\t\\t\\treturn true\\n+\\t\\t}\\n \\t\\tif t.NumFields() > MaxStruct {\\n \\t\\t\\treturn false\\n \\t\\t}\",\n \"additions\": 4,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/compile/internal/syntax/parser.go\",\n \"patch\": \"@@ -797,9 +797,9 @@ func (p *parser) funcDeclOrNil() *FuncDecl {\\n \\tf.pos = p.pos()\\n \\tf.Pragma = p.takePragma()\\n \\n-\\tvar context string\\n+\\thasRecv := false\\n \\tif p.got(_Lparen) {\\n-\\t\\tcontext = \\\"method\\\"\\n+\\t\\thasRecv = true\\n \\t\\trcvr := p.paramList(nil, nil, _Rparen, false, false)\\n \\t\\tswitch len(rcvr) {\\n \\t\\tcase 0:\\n@@ -814,13 +814,13 @@ func (p *parser) funcDeclOrNil() *FuncDecl {\\n \\n \\tif p.tok == _Name {\\n \\t\\tf.Name = p.name()\\n-\\t\\tf.TParamList, f.Type = p.funcType(context)\\n+\\t\\tf.TParamList, f.Type = p.funcType(\\\"\\\")\\n \\t} else {\\n \\t\\tf.Name = NewName(p.pos(), \\\"_\\\")\\n \\t\\tf.Type = new(FuncType)\\n \\t\\tf.Type.pos = p.pos()\\n \\t\\tmsg := \\\"expected name or (\\\"\\n-\\t\\tif context != \\\"\\\" {\\n+\\t\\tif hasRecv {\\n \\t\\t\\tmsg = \\\"expected name\\\"\\n \\t\\t}\\n \\t\\tp.syntaxError(msg)\",\n \"additions\": 4,\n \"deletions\": 4\n },\n {\n \"filename\": \"src/cmd/compile/internal/syntax/testdata/smoketest.go\",\n \"patch\": \"@@ -71,3 +71,33 @@ type _ interface {\\n \\tT[P]\\n \\tT[P1, P2]\\n }\\n+\\n+// generic method\\n+type List[E any] []E\\n+\\n+func (l List[E]) Map[F any](m func(E) F) (r List[F]) {\\n+\\tfor _, x := range l {\\n+\\t\\tr = append(r, m(x))\\n+\\t}\\n+\\treturn\\n+}\\n+\\n+func _() {\\n+\\tl := List[string]{\\\"foo\\\", \\\"foobar\\\", \\\"42\\\"}\\n+\\tr := l.Map(func(s string) int { return len(s)})\\n+\\t_ = r\\n+}\\n+\\n+func _[E, F any](l List[E]) List[F] {\\n+\\tvar f func(List[E], func(E) F) List[F] = List[E].Map // method expression & type inference\\n+\\treturn f(l, func(E) F { var f F; return f })\\n+}\\n+\\n+// disallowed type parameters\\n+\\n+type _ func /* ERROR function type must have no type parameters */ [P any](P)\\n+type _ interface {\\n+\\tm /* ERROR interface method must have no type parameters */ [P any](P)\\n+}\\n+\\n+var _ = func /* ERROR function type must have no type parameters */ [P any](P) {}\",\n \"additions\": 30,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/compile/internal/types2/resolver.go\",\n \"patch\": \"@@ -452,6 +452,11 @@ func (check *Checker) collectObjects() {\\n \\t\\t\\t\\t\\tif recv, _ := base.(*syntax.Name); recv != nil && name != \\\"_\\\" {\\n \\t\\t\\t\\t\\t\\tmethods = append(methods, methodInfo{obj, ptr, recv})\\n \\t\\t\\t\\t\\t}\\n+\\t\\t\\t\\t\\t// methods cannot have type parameters for now\\n+\\t\\t\\t\\t\\tif len(s.TParamList) != 0 {\\n+\\t\\t\\t\\t\\t\\tcheck.softErrorf(s.TParamList[0], InvalidMethodTypeParams, \\\"method %s must have no type parameters\\\", name)\\n+\\t\\t\\t\\t\\t\\thasTParamError = true\\n+\\t\\t\\t\\t\\t}\\n \\t\\t\\t\\t\\tcheck.recordDef(s.Name, obj)\\n \\t\\t\\t\\t}\\n \\t\\t\\t\\t_ = len(s.TParamList) != 0 && !hasTParamError && check.verifyVersionf(s.TParamList[0], go1_18, \\\"type parameter\\\")\",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/compile/internal/types2/signature.go\",\n \"patch\": \"@@ -155,7 +155,6 @@ func (check *Checker) funcType(sig *Signature, recvPar *syntax.Field, tparams []\\n \\n \\t// collect and declare function type parameters\\n \\tif tparams != nil {\\n-\\t\\t// The parser will complain about invalid type parameters for methods.\\n \\t\\tcheck.collectTypeParams(&sig.tparams, tparams)\\n \\t}\\n \",\n \"additions\": 0,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/cmd/dist/test.go\",\n \"patch\": \"@@ -728,7 +728,7 @@ func (t *tester) registerTests() {\\n \\n \\t\\t// Test that earlier FIPS snapshots build.\\n \\t\\t// In long mode, test that they work too.\\n-\\t\\tfor _, version := range fipsVersions(t.short) {\\n+\\t\\tfor _, version := range fipsVersions() {\\n \\t\\t\\tsuffix := \\\" # (build and vet only)\\\"\\n \\t\\t\\trun := \\\"^$\\\" // only ensure they compile\\n \\t\\t\\tif !t.short {\\n@@ -1291,11 +1291,12 @@ func (t *tester) registerCgoTests(heading string) {\\n \\t\\t\\t// This isn't actually a Go buildmode, just a convenient way to tell\\n \\t\\t\\t// cgoTest we want static linking.\\n \\t\\t\\tgt.buildmode = \\\"\\\"\\n-\\t\\t\\tif linkmode == \\\"external\\\" {\\n+\\t\\t\\tswitch linkmode {\\n+\\t\\t\\tcase \\\"external\\\":\\n \\t\\t\\t\\tldflags = append(ldflags, `-extldflags \\\"-static -pthread\\\"`)\\n-\\t\\t\\t} else if linkmode == \\\"auto\\\" {\\n+\\t\\t\\tcase \\\"auto\\\":\\n \\t\\t\\t\\tgt.env = append(gt.env, \\\"CGO_LDFLAGS=-static -pthread\\\")\\n-\\t\\t\\t} else {\\n+\\t\\t\\tdefault:\\n \\t\\t\\t\\tpanic(\\\"unknown linkmode with static build: \\\" + linkmode)\\n \\t\\t\\t}\\n \\t\\t\\tgt.tags = append(gt.tags, \\\"static\\\")\\n@@ -1320,8 +1321,8 @@ func (t *tester) registerCgoTests(heading string) {\\n \\n \\tos := gohostos\\n \\tp := gohostos + \\\"/\\\" + goarch\\n-\\tswitch {\\n-\\tcase os == \\\"darwin\\\", os == \\\"windows\\\":\\n+\\tswitch os {\\n+\\tcase \\\"darwin\\\", \\\"windows\\\":\\n \\t\\tif !t.extLink() {\\n \\t\\t\\tbreak\\n \\t\\t}\\n@@ -1338,7 +1339,7 @@ func (t *tester) registerCgoTests(heading string) {\\n \\t\\t\\t}\\n \\t\\t}\\n \\n-\\tcase os == \\\"aix\\\", os == \\\"android\\\", os == \\\"dragonfly\\\", os == \\\"freebsd\\\", os == \\\"linux\\\", os == \\\"netbsd\\\", os == \\\"openbsd\\\":\\n+\\tcase \\\"aix\\\", \\\"android\\\", \\\"dragonfly\\\", \\\"freebsd\\\", \\\"linux\\\", \\\"netbsd\\\", \\\"openbsd\\\":\\n \\t\\tgt := cgoTest(\\\"external-g0\\\", \\\"test\\\", \\\"external\\\", \\\"\\\")\\n \\t\\tgt.env = append(gt.env, \\\"CGO_CFLAGS=-g0 -fdiagnostics-color\\\")\\n \\n@@ -1526,14 +1527,6 @@ func (t *tester) runPending(nextTest *distTest) {\\n \\t}\\n }\\n \\n-func (t *tester) hasBash() bool {\\n-\\tswitch gohostos {\\n-\\tcase \\\"windows\\\", \\\"plan9\\\":\\n-\\t\\treturn false\\n-\\t}\\n-\\treturn true\\n-}\\n-\\n // hasParallelism is a copy of the function\\n // internal/testenv.HasParallelism, which can't be used here\\n // because cmd/dist can not import internal packages during bootstrap.\\n@@ -1881,7 +1874,7 @@ func (t *tester) fipsSupported() bool {\\n }\\n \\n // fipsVersions returns the list of versions available in lib/fips140.\\n-func fipsVersions(short bool) []string {\\n+func fipsVersions() []string {\\n \\tvar versions []string\\n \\tzips, err := filepath.Glob(filepath.Join(goroot, \\\"lib/fips140/*.zip\\\"))\\n \\tif err != nil {\",\n \"additions\": 9,\n \"deletions\": 16\n },\n {\n \"filename\": \"src/cmd/internal/obj/arm64/asm7.go\",\n \"patch\": \"@@ -484,6 +484,8 @@ var optab = []Optab{\\n \\t{AFMOVS, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\\n \\t{AFMOVD, C_FREG, C_NONE, C_NONE, C_ADDR, C_NONE, 64, 12, 0, 0, 0},\\n \\t{AFMOVD, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\\n+\\t{AFMOVQ, C_FREG, C_NONE, C_NONE, C_ADDR, C_NONE, 64, 12, 0, 0, 0},\\n+\\t{AFMOVQ, C_ADDR, C_NONE, C_NONE, C_FREG, C_NONE, 65, 12, 0, 0, 0},\\n \\t{AFMOVS, C_FCON, C_NONE, C_NONE, C_FREG, C_NONE, 55, 4, 0, 0, 0},\\n \\t{AFMOVS, C_FREG, C_NONE, C_NONE, C_FREG, C_NONE, 54, 4, 0, 0, 0},\\n \\t{AFMOVD, C_FCON, C_NONE, C_NONE, C_FREG, C_NONE, 55, 4, 0, 0, 0},\",\n \"additions\": 2,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/cmd/link/dwarf_test.go\",\n \"patch\": \"@@ -426,7 +426,7 @@ func TestFlagW(t *testing.T) {\\n \\t\\t{\\\"-s\\\", false}, // -s implies -w\\n \\t\\t{\\\"-s -w=0\\\", true}, // -w=0 negates the implied -w\\n \\t}\\n-\\tif testenv.HasCGO() && runtime.GOOS != \\\"solaris\\\" { // Solaris linker doesn't support the -S flag\\n+\\tif testenv.HasCGO() && runtime.GOOS != \\\"solaris\\\" && runtime.GOOS != \\\"illumos\\\" { // Solaris linker doesn't support the -S flag\\n \\t\\ttests = append(tests,\\n \\t\\t\\ttestCase{\\\"-w -linkmode=external\\\", false},\\n \\t\\t\\ttestCase{\\\"-s -linkmode=external\\\", false},\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/cmd/link/internal/ld/lib.go\",\n \"patch\": \"@@ -1700,22 +1700,48 @@ func (ctxt *Link) hostlink() {\\n \\t\\t}\\n \\n \\t\\tif ctxt.Arch.InFamily(sys.ARM64) && buildcfg.GOOS == \\\"linux\\\" {\\n-\\t\\t\\t// On ARM64, the GNU linker will fail with\\n-\\t\\t\\t// -znocopyreloc if it thinks a COPY relocation is\\n-\\t\\t\\t// required. Switch to gold.\\n+\\t\\t\\t// On ARM64, the GNU linker had issues with -znocopyreloc\\n+\\t\\t\\t// and COPY relocations. This was fixed in GNU ld 2.36+.\\n \\t\\t\\t// https://sourceware.org/bugzilla/show_bug.cgi?id=19962\\n \\t\\t\\t// https://go.dev/issue/22040\\n-\\t\\t\\taltLinker = \\\"gold\\\"\\n+\\t\\t\\t// And newer gold is deprecated, may lack new features/flags, or even missing\\n \\n-\\t\\t\\t// If gold is not installed, gcc will silently switch\\n-\\t\\t\\t// back to ld.bfd. So we parse the version information\\n-\\t\\t\\t// and provide a useful error if gold is missing.\\n+\\t\\t\\t// If the default linker is GNU ld 2.35 or older, use gold\\n+\\t\\t\\tuseGold := false\\n \\t\\t\\tname, args := flagExtld[0], flagExtld[1:]\\n-\\t\\t\\targs = append(args, \\\"-fuse-ld=gold\\\", \\\"-Wl,--version\\\")\\n+\\t\\t\\targs = append(args, \\\"-Wl,--version\\\")\\n \\t\\t\\tcmd := exec.Command(name, args...)\\n \\t\\t\\tif out, err := cmd.CombinedOutput(); err == nil {\\n-\\t\\t\\t\\tif !bytes.Contains(out, []byte(\\\"GNU gold\\\")) {\\n-\\t\\t\\t\\t\\tlog.Fatalf(\\\"ARM64 external linker must be gold (issue #15696, 22040), but is not: %s\\\", out)\\n+\\t\\t\\t\\t// Parse version from output like \\\"GNU ld (GNU Binutils for Distro) 2.36.1\\\"\\n+\\t\\t\\t\\tfor line := range strings.Lines(string(out)) {\\n+\\t\\t\\t\\t\\tif !strings.HasPrefix(line, \\\"GNU ld \\\") {\\n+\\t\\t\\t\\t\\t\\tcontinue\\n+\\t\\t\\t\\t\\t}\\n+\\t\\t\\t\\t\\tfields := strings.Fields(line[len(\\\"GNU ld \\\"):])\\n+\\t\\t\\t\\t\\tvar major, minor int\\n+\\t\\t\\t\\t\\tif ret, err := fmt.Sscanf(fields[len(fields)-1], \\\"%d.%d\\\", &major, &minor); ret == 2 && err == nil {\\n+\\t\\t\\t\\t\\t\\tif major == 2 && minor <= 35 {\\n+\\t\\t\\t\\t\\t\\t\\tuseGold = true\\n+\\t\\t\\t\\t\\t\\t}\\n+\\t\\t\\t\\t\\t\\tbreak\\n+\\t\\t\\t\\t\\t}\\n+\\t\\t\\t\\t}\\n+\\t\\t\\t}\\n+\\n+\\t\\t\\tif useGold {\\n+\\t\\t\\t\\t// Use gold for older linkers\\n+\\t\\t\\t\\taltLinker = \\\"gold\\\"\\n+\\n+\\t\\t\\t\\t// If gold is not installed, gcc will silently switch\\n+\\t\\t\\t\\t// back to ld.bfd. So we parse the version information\\n+\\t\\t\\t\\t// and provide a useful error if gold is missing.\\n+\\t\\t\\t\\targs = flagExtld[1:]\\n+\\t\\t\\t\\targs = append(args, \\\"-fuse-ld=gold\\\", \\\"-Wl,--version\\\")\\n+\\t\\t\\t\\tcmd = exec.Command(name, args...)\\n+\\t\\t\\t\\tif out, err := cmd.CombinedOutput(); err == nil {\\n+\\t\\t\\t\\t\\tif !bytes.Contains(out, []byte(\\\"GNU gold\\\")) {\\n+\\t\\t\\t\\t\\t\\tlog.Fatalf(\\\"ARM64 external linker must be ld>=2.36 or gold (issue #15696, 22040), but is not: %s\\\", out)\\n+\\t\\t\\t\\t\\t}\\n \\t\\t\\t\\t}\\n \\t\\t\\t}\\n \\t\\t}\",\n \"additions\": 36,\n \"deletions\": 10\n },\n {\n \"filename\": \"src/go/parser/parser.go\",\n \"patch\": \"@@ -2794,12 +2794,6 @@ func (p *parser) parseFuncDecl() *ast.FuncDecl {\\n \\tvar tparams *ast.FieldList\\n \\tif p.tok == token.LBRACK {\\n \\t\\ttparams = p.parseTypeParameters()\\n-\\t\\tif recv != nil && tparams != nil {\\n-\\t\\t\\t// Method declarations do not have type parameters. We parse them for a\\n-\\t\\t\\t// better error message and improved error recovery.\\n-\\t\\t\\tp.error(tparams.Opening, \\\"method must have no type parameters\\\")\\n-\\t\\t\\ttparams = nil\\n-\\t\\t}\\n \\t}\\n \\tparams := p.parseParameters(false)\\n \\tresults := p.parseParameters(true)\",\n \"additions\": 0,\n \"deletions\": 6\n },\n {\n \"filename\": \"src/go/parser/short_test.go\",\n \"patch\": \"@@ -207,9 +207,9 @@ var invalids = []string{\\n \\n \\t`package p; func _[type /* ERROR \\\"found 'type'\\\" */ P, *Q interface{}]()`,\\n \\n-\\t`package p; func (T) _[ /* ERROR \\\"must have no type parameters\\\" */ A, B any](a A) B`,\\n-\\t`package p; func (T) _[ /* ERROR \\\"must have no type parameters\\\" */ A, B C](a A) B`,\\n-\\t`package p; func (T) _[ /* ERROR \\\"must have no type parameters\\\" */ A, B C[A, B]](a A) B`,\\n+\\t`package p; func (T) _[A, B any](a A) B`,\\n+\\t`package p; func (T) _[A, B C](a A) B`,\\n+\\t`package p; func (T) _[A, B C[A, B]](a A) B`,\\n \\n \\t`package p; func(*T[e, e /* ERROR \\\"e redeclared\\\" */ ]) _()`,\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/go/parser/testdata/issue50427.go2\",\n \"patch\": \"@@ -12,7 +12,7 @@ func _(t T) {\\n \\n type S struct{}\\n \\n-func (S) m[ /* ERROR \\\"must have no type parameters\\\" */ P any]() {}\\n+func (S) m[P any]() {}\\n \\n func _(s S) {\\n \\tvar _ interface{ m[ /* ERROR \\\"must have no type parameters\\\" */ P any](); n() } = s\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/go/types/interface.go\",\n \"patch\": \"@@ -188,13 +188,13 @@ func (check *Checker) interfaceType(ityp *Interface, iface *ast.InterfaceType, d\\n \\t\\t\\tcontinue // ignore\\n \\t\\t}\\n \\n-\\t\\t// The go/parser doesn't accept method type parameters but an ast.FuncType may have them.\\n+\\t\\t// The go/parser doesn't accept interface method type parameters but an ast.FuncType may have them.\\n \\t\\tif sig.tparams != nil {\\n \\t\\t\\tvar at positioner = f.Type\\n \\t\\t\\tif ftyp, _ := f.Type.(*ast.FuncType); ftyp != nil && ftyp.TypeParams != nil {\\n \\t\\t\\t\\tat = ftyp.TypeParams\\n \\t\\t\\t}\\n-\\t\\t\\tcheck.error(at, InvalidSyntaxTree, \\\"methods cannot have type parameters\\\")\\n+\\t\\t\\tcheck.error(at, InvalidSyntaxTree, \\\"interface methods cannot have type parameters\\\")\\n \\t\\t}\\n \\n \\t\\t// use named receiver type if available (for better error messages)\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/go/types/resolver.go\",\n \"patch\": \"@@ -446,6 +446,11 @@ func (check *Checker) collectObjects() {\\n \\t\\t\\t\\t\\tif recv, _ := base.(*ast.Ident); recv != nil && name != \\\"_\\\" {\\n \\t\\t\\t\\t\\t\\tmethods = append(methods, methodInfo{obj, ptr, recv})\\n \\t\\t\\t\\t\\t}\\n+\\t\\t\\t\\t\\t// methods cannot have type parameters for now\\n+\\t\\t\\t\\t\\tif d.decl.Type.TypeParams.NumFields() != 0 {\\n+\\t\\t\\t\\t\\t\\tcheck.softErrorf(d.decl.Type.TypeParams.List[0], InvalidMethodTypeParams, \\\"method %s must have no type parameters\\\", name)\\n+\\t\\t\\t\\t\\t\\thasTParamError = true\\n+\\t\\t\\t\\t\\t}\\n \\t\\t\\t\\t\\tcheck.recordDef(d.decl.Name, obj)\\n \\t\\t\\t\\t}\\n \\t\\t\\t\\t_ = d.decl.Type.TypeParams.NumFields() != 0 && !hasTParamError && check.verifyVersionf(d.decl.Type.TypeParams.List[0], go1_18, \\\"type parameter\\\")\",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/go/types/signature.go\",\n \"patch\": \"@@ -173,12 +173,6 @@ func (check *Checker) funcType(sig *Signature, recvPar *ast.FieldList, ftyp *ast\\n \\n \\t// collect and declare function type parameters\\n \\tif ftyp.TypeParams != nil {\\n-\\t\\t// Always type-check method type parameters but complain that they are not allowed.\\n-\\t\\t// (A separate check is needed when type-checking interface method signatures because\\n-\\t\\t// they don't have a receiver specification.)\\n-\\t\\tif recvPar != nil {\\n-\\t\\t\\tcheck.error(ftyp.TypeParams, InvalidMethodTypeParams, \\\"methods cannot have type parameters\\\")\\n-\\t\\t}\\n \\t\\tcheck.collectTypeParams(&sig.tparams, ftyp.TypeParams)\\n \\t}\\n \",\n \"additions\": 0,\n \"deletions\": 6\n },\n {\n \"filename\": \"src/internal/runtime/gc/scan/scan_amd64.go\",\n \"patch\": \"@@ -38,4 +38,5 @@ var avx512ScanPackedReqsMet = cpu.X86.HasAVX512VL &&\\n \\tcpu.X86.HasAVX512BW &&\\n \\tcpu.X86.HasGFNI &&\\n \\tcpu.X86.HasAVX512BITALG &&\\n-\\tcpu.X86.HasAVX512VBMI\\n+\\tcpu.X86.HasAVX512VBMI &&\\n+\\tcpu.X86.HasPOPCNT\",\n \"additions\": 2,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/internal/syscall/windows/at_windows.go\",\n \"patch\": \"@@ -355,7 +355,7 @@ func deleteatFallback(h syscall.Handle) error {\\n \\t\\th,\\n \\t\\tFileDispositionInfo,\\n \\t\\tunsafe.Pointer(&FILE_DISPOSITION_INFO{\\n-\\t\\t\\tDeleteFile: true,\\n+\\t\\t\\tDeleteFile: 1,\\n \\t\\t}),\\n \\t\\tuint32(unsafe.Sizeof(FILE_DISPOSITION_INFO{})),\\n \\t)\\n@@ -416,7 +416,7 @@ func Renameat(olddirfd syscall.Handle, oldpath string, newdirfd syscall.Handle,\\n \\t//\\n \\t// Try again.\\n \\trenameInfo := FILE_RENAME_INFORMATION{\\n-\\t\\tReplaceIfExists: true,\\n+\\t\\tReplaceIfExists: 1,\\n \\t\\tRootDirectory: newdirfd,\\n \\t}\\n \\tcopy(renameInfo.FileName[:], p16)\\n@@ -602,7 +602,7 @@ func symlinkat(oldname string, newdirfd syscall.Handle, newname string, flags Sy\\n \\t\\t\\th,\\n \\t\\t\\t&IO_STATUS_BLOCK{},\\n \\t\\t\\tunsafe.Pointer(&FILE_DISPOSITION_INFORMATION{\\n-\\t\\t\\t\\tDeleteFile: true,\\n+\\t\\t\\t\\tDeleteFile: 1,\\n \\t\\t\\t}),\\n \\t\\t\\tuint32(unsafe.Sizeof(FILE_DISPOSITION_INFORMATION{})),\\n \\t\\t\\tFileDispositionInformation,\",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/internal/syscall/windows/types_windows.go\",\n \"patch\": \"@@ -219,12 +219,12 @@ const (\\n \\n // https://learn.microsoft.com/en-us/windows/win32/api/winbase/ns-winbase-file_disposition_info\\n type FILE_DISPOSITION_INFO struct {\\n-\\tDeleteFile bool\\n+\\tDeleteFile byte\\n }\\n \\n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntddk/ns-ntddk-_file_disposition_information\\n type FILE_DISPOSITION_INFORMATION struct {\\n-\\tDeleteFile bool\\n+\\tDeleteFile byte\\n }\\n \\n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntddk/ns-ntddk-_file_disposition_information_ex\\n@@ -250,7 +250,7 @@ const (\\n \\n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_file_rename_information\\n type FILE_RENAME_INFORMATION struct {\\n-\\tReplaceIfExists bool\\n+\\tReplaceIfExists byte\\n \\tRootDirectory syscall.Handle\\n \\tFileNameLength uint32\\n \\tFileName [syscall.MAX_PATH]uint16\\n@@ -266,7 +266,7 @@ type FILE_RENAME_INFORMATION_EX struct {\\n \\n // https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/ntifs/ns-ntifs-_file_link_information\\n type FILE_LINK_INFORMATION struct {\\n-\\tReplaceIfExists bool\\n+\\tReplaceIfExists byte\\n \\tRootDirectory syscall.Handle\\n \\tFileNameLength uint32\\n \\tFileName [syscall.MAX_PATH]uint16\",\n \"additions\": 4,\n \"deletions\": 4\n },\n {\n \"filename\": \"src/internal/types/testdata/check/typeparams.go\",\n \"patch\": \"@@ -329,8 +329,8 @@ func init[P /* ERROR \\\"func init must have no type parameters\\\" */ any]() {}\\n type T struct {}\\n \\n func (T) m1() {}\\n-func (T) m2[ /* ERROR \\\"method must have no type parameters\\\" */ _ any]() {}\\n-func (T) m3[ /* ERROR \\\"method must have no type parameters\\\" */ P any]() {}\\n+func (T) m2[_ /* ERROR \\\"method m2 must have no type parameters\\\" */ any]() {}\\n+func (T) m3[P /* ERROR \\\"method m3 must have no type parameters\\\" */ any]() {}\\n \\n // type inference across parameterized types\\n \",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/internal/types/testdata/fixedbugs/issue50427.go\",\n \"patch\": \"@@ -15,7 +15,7 @@ func _(t T) {\\n \\n type S struct{}\\n \\n-func (S) m[ /* ERROR \\\"must have no type parameters\\\" */ P any]() {}\\n+func (S) m[P /* ERROR \\\"must have no type parameters\\\" */ any]() {}\\n \\n func _(s S) {\\n \\tvar _ interface{ m[ /* ERROR \\\"must have no type parameters\\\" */ P any](); n() } = s /* ERROR \\\"does not implement\\\" */\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/mime/type.go\",\n \"patch\": \"@@ -115,7 +115,8 @@ var builtinTypesLower = map[string]string{\\n \\t\\\".vtt\\\": \\\"text/vtt; charset=utf-8\\\",\\n \\t\\\".wasm\\\": \\\"application/wasm\\\",\\n \\t\\\".wav\\\": \\\"audio/wav\\\",\\n-\\t\\\".webm\\\": \\\"audio/webm\\\",\\n+\\t\\\".weba\\\": \\\"audio/webm\\\",\\n+\\t\\\".webm\\\": \\\"video/webm\\\",\\n \\t\\\".webp\\\": \\\"image/webp\\\",\\n \\t\\\".xbl\\\": \\\"text/xml; charset=utf-8\\\",\\n \\t\\\".xbm\\\": \\\"image/x-xbitmap\\\",\",\n \"additions\": 2,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/mime/type_test.go\",\n \"patch\": \"@@ -245,7 +245,8 @@ func TestExtensionsByType2(t *testing.T) {\\n \\t\\t{typ: \\\"text/vtt; charset=utf-8\\\", want: []string{\\\".vtt\\\"}},\\n \\t\\t{typ: \\\"application/wasm\\\", want: []string{\\\".wasm\\\"}},\\n \\t\\t{typ: \\\"audio/wav\\\", want: []string{\\\".wav\\\"}},\\n-\\t\\t{typ: \\\"audio/webm\\\", want: []string{\\\".webm\\\"}},\\n+\\t\\t{typ: \\\"audio/webm\\\", want: []string{\\\".weba\\\"}},\\n+\\t\\t{typ: \\\"video/webm\\\", want: []string{\\\".webm\\\"}},\\n \\t\\t{typ: \\\"image/webp\\\", want: []string{\\\".webp\\\"}},\\n \\t\\t{typ: \\\"text/xml; charset=utf-8\\\", want: []string{\\\".xbl\\\", \\\".xml\\\", \\\".xsl\\\"}},\\n \\t\\t{typ: \\\"image/x-xbitmap\\\", want: []string{\\\".xbm\\\"}},\",\n \"additions\": 2,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/net/http/clone.go\",\n \"patch\": \"@@ -39,16 +39,7 @@ func cloneURLValues(v url.Values) url.Values {\\n //\\n //go:linkname cloneURL\\n func cloneURL(u *url.URL) *url.URL {\\n-\\tif u == nil {\\n-\\t\\treturn nil\\n-\\t}\\n-\\tu2 := new(url.URL)\\n-\\t*u2 = *u\\n-\\tif u.User != nil {\\n-\\t\\tu2.User = new(url.Userinfo)\\n-\\t\\t*u2.User = *u.User\\n-\\t}\\n-\\treturn u2\\n+\\treturn u.Clone()\\n }\\n \\n // cloneMultipartForm should be an internal detail,\",\n \"additions\": 1,\n \"deletions\": 10\n },\n {\n \"filename\": \"src/net/ipsock_posix.go\",\n \"patch\": \"@@ -158,7 +158,7 @@ func favoriteAddrFamily(network string, laddr, raddr sockaddr, mode string) (fam\\n \\n func internetSocket(ctx context.Context, net string, laddr, raddr sockaddr, sotype, proto int, mode string, ctrlCtxFn func(context.Context, string, string, syscall.RawConn) error) (fd *netFD, err error) {\\n \\tswitch runtime.GOOS {\\n-\\tcase \\\"aix\\\", \\\"windows\\\", \\\"openbsd\\\", \\\"js\\\", \\\"wasip1\\\":\\n+\\tcase \\\"aix\\\", \\\"freebsd\\\", \\\"windows\\\", \\\"openbsd\\\", \\\"js\\\", \\\"wasip1\\\":\\n \\t\\tif mode == \\\"dial\\\" && raddr.isWildcard() {\\n \\t\\t\\traddr = raddr.toLocal(net)\\n \\t\\t}\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/net/url/url.go\",\n \"patch\": \"@@ -1322,3 +1322,16 @@ func JoinPath(base string, elem ...string) (result string, err error) {\\n \\t}\\n \\treturn res.String(), nil\\n }\\n+\\n+// Clone creates a deep copy of the fields of the subject [URL].\\n+func (u *URL) Clone() *URL {\\n+\\tif u == nil {\\n+\\t\\treturn nil\\n+\\t}\\n+\\n+\\tuc := new(*u)\\n+\\tif u.User != nil {\\n+\\t\\tuc.User = new(*u.User)\\n+\\t}\\n+\\treturn uc\\n+}\",\n \"additions\": 13,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/net/url/url_test.go\",\n \"patch\": \"@@ -10,6 +10,7 @@ import (\\n \\t\\\"encoding/gob\\\"\\n \\t\\\"encoding/json\\\"\\n \\t\\\"fmt\\\"\\n+\\t\\\"internal/diff\\\"\\n \\t\\\"io\\\"\\n \\t\\\"net\\\"\\n \\t\\\"reflect\\\"\\n@@ -2361,3 +2362,78 @@ func TestParseStrictIpv6(t *testing.T) {\\n \\t}\\n \\n }\\n+\\n+func TestURLClone(t *testing.T) {\\n+\\ttests := []struct {\\n+\\t\\tname string\\n+\\t\\tin *URL\\n+\\t}{\\n+\\t\\t{\\\"nil\\\", nil},\\n+\\t\\t{\\\"zero value\\\", &URL{}},\\n+\\t\\t{\\n+\\t\\t\\t\\\"Populated but nil .User\\\",\\n+\\t\\t\\t&URL{\\n+\\t\\t\\t\\tUser: nil,\\n+\\t\\t\\t\\tHost: \\\"foo\\\",\\n+\\t\\t\\t\\tPath: \\\"/path\\\",\\n+\\t\\t\\t\\tRawQuery: \\\"a=b\\\",\\n+\\t\\t\\t},\\n+\\t\\t},\\n+\\t\\t{\\n+\\t\\t\\t\\\"non-nil .User\\\",\\n+\\t\\t\\t&URL{\\n+\\t\\t\\t\\tUser: User(\\\"user\\\"),\\n+\\t\\t\\t\\tHost: \\\"foo\\\",\\n+\\t\\t\\t\\tPath: \\\"/path\\\",\\n+\\t\\t\\t\\tRawQuery: \\\"a=b\\\",\\n+\\t\\t\\t},\\n+\\t\\t},\\n+\\t\\t{\\n+\\t\\t\\t\\\"non-nil .User: user and password set\\\",\\n+\\t\\t\\t&URL{\\n+\\t\\t\\t\\tUser: UserPassword(\\\"user\\\", \\\"password\\\"),\\n+\\t\\t\\t\\tHost: \\\"foo\\\",\\n+\\t\\t\\t\\tPath: \\\"/path\\\",\\n+\\t\\t\\t\\tRawQuery: \\\"a=b\\\",\\n+\\t\\t\\t},\\n+\\t\\t},\\n+\\t}\\n+\\n+\\tfor _, tt := range tests {\\n+\\t\\tt.Run(tt.name, func(t *testing.T) {\\n+\\t\\t\\t// 1. The cloned URL must always deep equal the input, but never the same pointer.\\n+\\t\\t\\tcloned := tt.in.Clone()\\n+\\t\\t\\tif !reflect.DeepEqual(tt.in, cloned) {\\n+\\t\\t\\t\\tt.Fatalf(\\\"Differing values\\\\n%s\\\",\\n+\\t\\t\\t\\t\\tdiff.Diff(\\\"original\\\", []byte(tt.in.String()), \\\"cloned\\\", []byte(cloned.String())))\\n+\\t\\t\\t}\\n+\\t\\t\\tif tt.in == nil {\\n+\\t\\t\\t\\treturn\\n+\\t\\t\\t}\\n+\\n+\\t\\t\\t// Ensure that their pointer values are not the same.\\n+\\t\\t\\tif tt.in == cloned {\\n+\\t\\t\\t\\tt.Fatalf(\\\"URL: same pointer returned: %p\\\", cloned)\\n+\\t\\t\\t}\\n+\\n+\\t\\t\\t// 2. Test out malleability of URL fields.\\n+\\t\\t\\tcloned.Scheme = \\\"https\\\"\\n+\\t\\t\\tif cloned.Scheme == tt.in.Scheme {\\n+\\t\\t\\t\\tt.Error(\\\"Inconsistent state: cloned.scheme changed and reflected in the input's scheme\\\")\\n+\\t\\t\\t}\\n+\\t\\t\\tif reflect.DeepEqual(tt.in, cloned) {\\n+\\t\\t\\t\\tt.Fatal(\\\"Inconsistent state: cloned and input are somehow the same\\\")\\n+\\t\\t\\t}\\n+\\n+\\t\\t\\t// 3. Ensure that the .User object deep equals but not the same pointer.\\n+\\t\\t\\tif !reflect.DeepEqual(tt.in.User, cloned.User) {\\n+\\t\\t\\t\\tt.Fatalf(\\\"Differing .User\\\\n%s\\\",\\n+\\t\\t\\t\\t\\tdiff.Diff(\\\"original\\\", []byte(tt.in.String()), \\\"cloned\\\", []byte(cloned.String())))\\n+\\t\\t\\t}\\n+\\t\\t\\tbothNil := tt.in.User == nil && cloned.User == nil\\n+\\t\\t\\tif !bothNil && tt.in.User == cloned.User {\\n+\\t\\t\\t\\tt.Fatalf(\\\".User: same pointer returned: %p\\\", cloned.User)\\n+\\t\\t\\t}\\n+\\t\\t})\\n+\\t}\\n+}\",\n \"additions\": 76,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/runtime/asm_ppc64x.s\",\n \"patch\": \"@@ -197,9 +197,9 @@ TEXT runtime·breakpoint(SB),NOSPLIT|NOFRAME,$0-0\\n TEXT runtime·asminit(SB),NOSPLIT|NOFRAME,$0-0\\n \\tRET\\n \\n-// Any changes must be reflected to runtime/cgo/gcc_aix_ppc64.S:.crosscall_ppc64\\n+// Any changes must be reflected to runtime/cgo/gcc_aix_ppc64.S:.crosscall1\\n TEXT _cgo_reginit(SB),NOSPLIT|NOFRAME,$0-0\\n-\\t// crosscall_ppc64 and crosscall2 need to reginit, but can't\\n+\\t// crosscall1 and crosscall2 need to reginit, but can't\\n \\t// get at the 'runtime.reginit' symbol.\\n \\tBR\\truntime·reginit(SB)\\n \",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_aix_ppc64.S\",\n \"patch\": \"@@ -5,23 +5,24 @@\\n .file \\\"gcc_aix_ppc64.S\\\"\\n \\n /*\\n- * void crosscall_ppc64(void (*fn)(void), void *g)\\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\\n *\\n * Calling into the gc tool chain, where all registers are caller save.\\n * Called from standard ppc64 C ABI, where r2, r14-r31, f14-f31 are\\n * callee-save, so they must be saved explicitly.\\n * AIX has a special assembly syntax and keywords that can be mixed with\\n * Linux assembly.\\n+ * ABI: r3=fn, r4=setg_gcc, r5=g\\n */\\n .toc\\n .csect .text[PR]\\n- .globl crosscall_ppc64\\n- .globl .crosscall_ppc64\\n- .csect crosscall_ppc64[DS]\\n-crosscall_ppc64:\\n- .llong .crosscall_ppc64, TOC[tc0], 0\\n+ .globl crosscall1\\n+ .globl .crosscall1\\n+ .csect crosscall1[DS]\\n+crosscall1:\\n+ .llong .crosscall1, TOC[tc0], 0\\n .csect .text[PR]\\n-.crosscall_ppc64:\\n+.crosscall1:\\n \\t// Start with standard C stack frame layout and linkage\\n \\tmflr\\t0\\n \\tstd\\t0, 16(1)\\t// Save LR in caller's frame\\n@@ -33,11 +34,19 @@ crosscall_ppc64:\\n \\t// Must match _cgo_reginit in runtime package.\\n \\txor 0, 0, 0\\n \\n+\\t// Save fn in r14 (callee-save) so we can reuse r3 for setg_gcc call\\n+\\tmr\\t14, 3\\n \\t// Restore g pointer (r30 in Go ABI, which may have been clobbered by C)\\n-\\tmr\\t30, 4\\n+\\tmr\\t30, 5\\n+\\n+\\t// Call setg_gcc(g)\\n+\\tmr\\t3, 5 // arg g\\n+\\tmr\\t12, 4 // setg_gcc\\n+\\tmtctr\\t12\\n+\\tbctrl\\n \\n \\t// Call fn\\n-\\tmr\\t12, 3\\n+\\tmr\\t12, 14\\n \\tmtctr\\t12\\n \\tbctrl\\n \",\n \"additions\": 18,\n \"deletions\": 9\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_android.c\",\n \"patch\": \"@@ -2,36 +2,10 @@\\n // Use of this source code is governed by a BSD-style\\n // license that can be found in the LICENSE file.\\n \\n-#include <stdarg.h>\\n-#include <android/log.h>\\n #include <pthread.h>\\n #include <dlfcn.h>\\n #include \\\"libcgo.h\\\"\\n \\n-void\\n-fatalf(const char* format, ...)\\n-{\\n-\\tva_list ap;\\n-\\n-\\t// Write to both stderr and logcat.\\n-\\t//\\n-\\t// When running from an .apk, /dev/stderr and /dev/stdout\\n-\\t// redirect to /dev/null. And when running a test binary\\n-\\t// via adb shell, it's easy to miss logcat.\\n-\\n-\\tfprintf(stderr, \\\"runtime/cgo: \\\");\\n-\\tva_start(ap, format);\\n-\\tvfprintf(stderr, format, ap);\\n-\\tva_end(ap);\\n-\\tfprintf(stderr, \\\"\\\\n\\\");\\n-\\n-\\tva_start(ap, format);\\n-\\t__android_log_vprint(ANDROID_LOG_FATAL, \\\"runtime/cgo\\\", format, ap);\\n-\\tva_end(ap);\\n-\\n-\\tabort();\\n-}\\n-\\n // Truncated to a different magic value on 32-bit; that's ok.\\n #define magic1 (0x23581321345589ULL)\\n \",\n \"additions\": 0,\n \"deletions\": 26\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_fatalf.c\",\n \"patch\": \"@@ -2,11 +2,12 @@\\n // Use of this source code is governed by a BSD-style\\n // license that can be found in the LICENSE file.\\n \\n-//go:build unix && !android\\n+//go:build unix\\n \\n #include <stdarg.h>\\n-#include <stdio.h>\\n-#include <stdlib.h>\\n+#ifdef __ANDROID__\\n+#include <android/log.h>\\n+#endif\\n #include \\\"libcgo.h\\\"\\n \\n void\\n@@ -19,5 +20,15 @@ fatalf(const char* format, ...)\\n \\tvfprintf(stderr, format, ap);\\n \\tva_end(ap);\\n \\tfprintf(stderr, \\\"\\\\n\\\");\\n+\\n+#ifdef __ANDROID__\\n+\\t// When running from an Android .apk, /dev/stderr and /dev/stdout\\n+\\t// redirect to /dev/null. And when running a test binary\\n+\\t// via adb shell, it's easy to miss logcat. So write to both.\\n+\\tva_start(ap, format);\\n+\\t__android_log_vprint(ANDROID_LOG_FATAL, \\\"runtime/cgo\\\", format, ap);\\n+\\tva_end(ap);\\n+#endif\\n+\\n \\tabort();\\n }\",\n \"additions\": 14,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_freebsd.c\",\n \"patch\": \"@@ -1,16 +0,0 @@\\n-// Copyright 2009 The Go Authors. All rights reserved.\\n-// Use of this source code is governed by a BSD-style\\n-// license that can be found in the LICENSE file.\\n-\\n-//go:build freebsd\\n-\\n-#include <machine/sysarch.h>\\n-\\n-#ifdef ARM_TP_ADDRESS\\n-// ARM_TP_ADDRESS is (ARM_VECTORS_HIGH + 0x1000) or 0xffff1000\\n-// and is known to runtime.read_tls_fallback. Verify it with\\n-// cpp.\\n-#if ARM_TP_ADDRESS != 0xffff1000\\n-#error Wrong ARM_TP_ADDRESS!\\n-#endif\\n-#endif\",\n \"additions\": 0,\n \"deletions\": 16\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_linux_ppc64x.S\",\n \"patch\": \"@@ -38,14 +38,15 @@\\n .endm\\n \\n /*\\n- * void crosscall_ppc64(void (*fn)(void), void *g)\\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\\n *\\n * Calling into the gc tool chain, where all registers are caller save.\\n * Called from standard ppc64 C ABI, where r2, r14-r31, f14-f31 are\\n * callee-save, so they must be saved explicitly.\\n+ * ABI: r3=fn, r4=setg_gcc, r5=g on entry.\\n */\\n-.globl crosscall_ppc64\\n-crosscall_ppc64:\\n+.globl crosscall1\\n+crosscall1:\\n \\t// Start with standard C stack frame layout and linkage\\n \\tmflr\\t%r0\\n \\tstd\\t%r0, 16(%r1)\\t// Save LR in caller's frame\\n@@ -61,12 +62,20 @@ crosscall_ppc64:\\n \\t// Set up Go ABI constant registers\\n \\tli\\t%r0, 0\\n \\n+\\t// Save fn in r14 (callee-save) while we call setg_gcc\\n+\\tmr\\t%r14, %r3\\n \\t// Restore g pointer (r30 in Go ABI, which may have been clobbered by C)\\n-\\tmr\\t%r30, %r4\\n+\\tmr\\t%r30, %r5\\n \\n-\\t// Call fn\\n-\\tmr\\t%r12, %r3\\n-\\tmtctr\\t%r3\\n+\\t// Call setg_gcc(g)\\n+\\tmr\\t%r3, %r5 /* arg: g */\\n+\\tmr\\t%r12, %r4 /* setg_gcc */\\n+\\tmtctr\\t%r12\\n+\\tbctrl\\n+\\n+\\t// Call fn()\\n+\\tmr\\t%r12, %r14\\n+\\tmtctr\\t%r12\\n \\tbctrl\\n \\n \\tFOR_EACH_GPR ld\",\n \"additions\": 16,\n \"deletions\": 7\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_s390x.S\",\n \"patch\": \"@@ -5,14 +5,15 @@\\n .file \\\"gcc_s390x.S\\\"\\n \\n /*\\n- * void crosscall_s390x(void (*fn)(void), void *g)\\n+ * void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g)\\n *\\n * Calling into the go tool chain, where all registers are caller save.\\n * Called from standard s390x C ABI, where r6-r13, r15, and f8-f15 are\\n * callee-save, so they must be saved explicitly.\\n+ * ABI: r2=fn, r3=setg_gcc, r4=g.\\n */\\n-.globl crosscall_s390x\\n-crosscall_s390x:\\n+.globl crosscall1\\n+crosscall1:\\n \\t/* save r6-r15 in the register save area of the calling function */\\n \\tstmg %r6, %r15, 48(%r15)\\n \\n@@ -29,10 +30,18 @@ crosscall_s390x:\\n \\tstd %f14, 48(%r15)\\n \\tstd %f15, 56(%r15)\\n \\n+\\t/* save fn pointer in r6 (already saved to stack) */\\n+\\tlgr %r6, %r2\\n \\t/* restore g pointer */\\n-\\tlgr %r13, %r3\\n+\\tlgr %r13, %r4\\n+\\n+\\t/* prepare arg for setg_gcc: first argument in r2 */\\n+\\tlgr %r2, %r4 /* r2 = g */\\n+\\t/* call setg_gcc(g) using function pointer in r3 */\\n+\\tbasr %r14, %r3\\n \\n \\t/* call fn */\\n+\\tlgr %r2, %r6\\n \\tbasr %r14, %r2\\n \\n \\t/* restore floating point registers */\",\n \"additions\": 13,\n \"deletions\": 4\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_solaris_amd64.c\",\n \"patch\": \"@@ -1,46 +0,0 @@\\n-// Copyright 2015 The Go Authors. All rights reserved.\\n-// Use of this source code is governed by a BSD-style\\n-// license that can be found in the LICENSE file.\\n-\\n-#include <string.h>\\n-#include <ucontext.h>\\n-#include \\\"libcgo.h\\\"\\n-#include \\\"libcgo_unix.h\\\"\\n-\\n-static void (*setg_gcc)(void*);\\n-\\n-void\\n-x_cgo_init(G *g, void (*setg)(void*))\\n-{\\n-\\tucontext_t ctx;\\n-\\n-\\tsetg_gcc = setg;\\n-\\tif (getcontext(&ctx) != 0)\\n-\\t\\tperror(\\\"runtime/cgo: getcontext failed\\\");\\n-\\tg->stacklo = (uintptr_t)ctx.uc_stack.ss_sp;\\n-\\n-\\t// Solaris processes report a tiny stack when run with \\\"ulimit -s unlimited\\\".\\n-\\t// Correct that as best we can: assume it's at least 1 MB.\\n-\\t// See golang.org/issue/12210.\\n-\\tif(ctx.uc_stack.ss_size < 1024*1024)\\n-\\t\\tg->stacklo -= 1024*1024 - ctx.uc_stack.ss_size;\\n-\\n-\\t// Sanity check the results now, rather than getting a\\n-\\t// morestack on g0 crash.\\n-\\tif (g->stacklo >= g->stackhi) {\\n-\\t\\tfatalf(\\\"bad stack bounds: lo=%p hi=%p\\\", (void*)(g->stacklo), (void*)(g->stackhi));\\n-\\t}\\n-}\\n-\\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n-void*\\n-threadentry(void *v)\\n-{\\n-\\tThreadStart ts;\\n-\\n-\\tts = *(ThreadStart*)v;\\n-\\tfree(v);\\n-\\n-\\tcrosscall1(ts.fn, setg_gcc, (void*)ts.g);\\n-\\treturn nil;\\n-}\",\n \"additions\": 0,\n \"deletions\": 46\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_unix.c\",\n \"patch\": \"@@ -2,7 +2,7 @@\\n // Use of this source code is governed by a BSD-style\\n // license that can be found in the LICENSE file.\\n \\n-//go:build unix && !solaris\\n+//go:build unix\\n \\n #include \\\"libcgo.h\\\"\\n #include \\\"libcgo_unix.h\\\"\\n@@ -48,16 +48,6 @@ x_cgo_init(G *g, void (*setg)(void*), void **tlsg, void **tlsbase)\\n \\t}\\n }\\n \\n-// TODO: change crosscall_ppc64 and crosscall_s390x so that it matches crosscall1\\n-// signature and behavior.\\n-#if defined(__powerpc64__)\\n-extern void crosscall_ppc64(void (*fn)(void), void *g);\\n-#elif defined(__s390x__)\\n-extern void crosscall_s390x(void (*fn)(void), void *g);\\n-#else\\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n-#endif\\n-\\n void*\\n threadentry(void *v)\\n {\\n@@ -72,16 +62,6 @@ threadentry(void *v)\\n \\t\\tx_cgo_threadentry_platform();\\n \\t}\\n \\n-#if defined(__powerpc64__)\\n-\\t// Save g for this thread in C TLS\\n-\\tsetg_gcc((void*)ts.g);\\n-\\tcrosscall_ppc64(ts.fn, (void*)ts.g);\\n-#elif defined(__s390x__)\\n-\\t// Save g for this thread in C TLS\\n-\\tsetg_gcc((void*)ts.g);\\n-\\tcrosscall_s390x(ts.fn, (void*)ts.g);\\n-#else\\n \\tcrosscall1(ts.fn, setg_gcc, ts.g);\\n-#endif\\n \\treturn NULL;\\n }\",\n \"additions\": 1,\n \"deletions\": 21\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_windows_386.c\",\n \"patch\": \"@@ -28,7 +28,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\\n \\t_cgo_beginthread(threadentry, ts);\\n }\\n \\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n static unsigned long\\n __stdcall\\n threadentry(void *v)\",\n \"additions\": 0,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_windows_amd64.c\",\n \"patch\": \"@@ -29,7 +29,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\\n \\t_cgo_beginthread(threadentry, ts);\\n }\\n \\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n static unsigned long\\n __stdcall\\n threadentry(void *v)\",\n \"additions\": 0,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/runtime/cgo/gcc_windows_arm64.c\",\n \"patch\": \"@@ -26,7 +26,6 @@ _cgo_sys_thread_start(ThreadStart *ts)\\n \\t_cgo_beginthread(threadentry, ts);\\n }\\n \\n-extern void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n \\n static unsigned long\\n __stdcall\",\n \"additions\": 0,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/runtime/cgo/libcgo.h\",\n \"patch\": \"@@ -73,6 +73,13 @@ uintptr_t _cgo_wait_runtime_init_done(void);\\n */\\n void x_cgo_getstackbound(uintptr bounds[2]);\\n \\n+/*\\n+ * Calls into the Go tool chain, where all registers are caller save.\\n+ * Called from C, it saves all callee-save registers and calls\\n+ * setg_gcc to set g before calling fn.\\n+ */\\n+void crosscall1(void (*fn)(void), void (*setg_gcc)(void*), void *g);\\n+\\n /*\\n * Prints error then calls abort. For linux and android.\\n */\",\n \"additions\": 7,\n \"deletions\": 0\n },\n {\n \"filename\": \"src/runtime/cgo_ppc64x.go\",\n \"patch\": \"@@ -6,7 +6,7 @@\\n \\n package runtime\\n \\n-// crosscall_ppc64 calls into the runtime to set up the registers the\\n+// crosscall1 calls into the runtime to set up the registers the\\n // Go runtime expects and so the symbol it calls needs to be exported\\n // for external linking to work.\\n //\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/runtime/cgocall.go\",\n \"patch\": \"@@ -428,7 +428,10 @@ func cgocallbackg1(fn, frame unsafe.Pointer, ctxt uintptr) {\\n \\t\\t//\\n \\t\\t// We check a bool first for speed, and wait on a channel\\n \\t\\t// if it's not ready.\\n-\\t\\tif !mainInitDone.Load() {\\n+\\t\\t//\\n+\\t\\t// In race mode, skip the optimization and always use the\\n+\\t\\t// channel, which has the race instrumentation.\\n+\\t\\tif raceenabled || !mainInitDone.Load() {\\n \\t\\t\\t<-mainInitDoneChan\\n \\t\\t}\\n \\t}\",\n \"additions\": 4,\n \"deletions\": 1\n },\n {\n \"filename\": \"src/runtime/runtime2.go\",\n \"patch\": \"@@ -301,8 +301,6 @@ func setMNoWB(mp **m, new *m) {\\n }\\n \\n type gobuf struct {\\n-\\t// The offsets of sp, pc, and g are known to (hard-coded in) libmach.\\n-\\t//\\n \\t// ctxt is unusual with respect to GC: it may be a\\n \\t// heap-allocated funcval, so GC needs to track it, but it\\n \\t// needs to be set and cleared from assembly, where it's\\n@@ -479,12 +477,12 @@ type g struct {\\n \\t// It is stack.lo+StackGuard on g0 and gsignal stacks.\\n \\t// It is ~0 on other goroutine stacks, to trigger a call to morestackc (and crash).\\n \\tstack stack // offset known to runtime/cgo\\n-\\tstackguard0 uintptr // offset known to liblink\\n-\\tstackguard1 uintptr // offset known to liblink\\n+\\tstackguard0 uintptr // offset known to cmd/internal/obj/*\\n+\\tstackguard1 uintptr // offset known to cmd/internal/obj/*\\n \\n-\\t_panic *_panic // innermost panic - offset known to liblink\\n+\\t_panic *_panic // innermost panic\\n \\t_defer *_defer // innermost defer\\n-\\tm *m // current m; offset known to arm liblink\\n+\\tm *m // current m\\n \\tsched gobuf\\n \\tsyscallsp uintptr // if status==Gsyscall, syscallsp = sched.sp to use during gc\\n \\tsyscallpc uintptr // if status==Gsyscall, syscallpc = sched.pc to use during gc\",\n \"additions\": 4,\n \"deletions\": 6\n },\n {\n \"filename\": \"src/runtime/secret/crash_test.go\",\n \"patch\": \"@@ -10,6 +10,9 @@ import (\\n \\t\\\"bytes\\\"\\n \\t\\\"debug/elf\\\"\\n \\t\\\"fmt\\\"\\n+\\t\\\"internal/asan\\\"\\n+\\t\\\"internal/msan\\\"\\n+\\t\\\"internal/race\\\"\\n \\t\\\"internal/testenv\\\"\\n \\t\\\"io\\\"\\n \\t\\\"os\\\"\\n@@ -120,7 +123,18 @@ func TestCore(t *testing.T) {\\n \\t\\tt.Fatalf(\\\"error initing module %v\\\\n%s\\\", err, out)\\n \\t}\\n \\n-\\tcmd = exec.Command(testenv.GoToolPath(t), \\\"build\\\", \\\"-o\\\", filepath.Join(tmpDir, \\\"a.exe\\\"))\\n+\\t// Pass through the flags for any of the memory validating modes\\n+\\targs := []string{\\\"build\\\", \\\"-o\\\", filepath.Join(tmpDir, \\\"a.exe\\\")}\\n+\\tif msan.Enabled {\\n+\\t\\targs = append(args, \\\"-msan\\\")\\n+\\t}\\n+\\tif asan.Enabled {\\n+\\t\\targs = append(args, \\\"-asan\\\")\\n+\\t}\\n+\\tif race.Enabled {\\n+\\t\\targs = append(args, \\\"-race\\\")\\n+\\t}\\n+\\tcmd = exec.Command(testenv.GoToolPath(t), args...)\\n \\tcmd.Dir = tmpDir\\n \\tout, err = testenv.CleanCmdEnv(cmd).CombinedOutput()\\n \\tif err != nil {\",\n \"additions\": 15,\n \"deletions\": 1\n },\n {\n \"filename\": \"test/fixedbugs/issue77534.go\",\n \"patch\": \"@@ -0,0 +1,36 @@\\n+// compile\\n+\\n+// Copyright 2026 The Go Authors. All rights reserved.\\n+// Use of this source code is governed by a BSD-style\\n+// license that can be found in the LICENSE file.\\n+\\n+// Issue 77534: compiler crash when >4 fields, but only one nonempty pointer field.\\n+\\n+package p\\n+\\n+type T struct {\\n+\\ta, b, c, d struct{}\\n+\\te *byte\\n+}\\n+\\n+func f1(p *any, t T) {\\n+\\t*p = t\\n+}\\n+\\n+func f2(p *any, t *T) {\\n+\\t*p = *t\\n+}\\n+\\n+func f3(p, x, y *T, b bool) {\\n+\\tvar z T\\n+\\tif b {\\n+\\t\\tz = *x\\n+\\t} else {\\n+\\t\\tz = *y\\n+\\t}\\n+\\t*p = z\\n+}\\n+\\n+func f4(i any) T {\\n+\\treturn i.(T)\\n+}\",\n \"additions\": 36,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/typeparam/issue50317.go\",\n \"patch\": \"@@ -8,8 +8,8 @@ package p\\n \\n type S struct{}\\n \\n-func (S) _[_ any]() {} // ERROR \\\"method must have no type parameters\\\"\\n+func (S) _[_ any]() {} // ERROR \\\"method _ must have no type parameters\\\"\\n \\n type _ interface {\\n-\\tm[_ any]() // ERROR \\\"method must have no type parameters\\\"\\n+\\tm[_ any]() // ERROR \\\"interface method must have no type parameters\\\"\\n }\",\n \"additions\": 2,\n \"deletions\": 2\n }\n]","isConversational":false}}},{"rowIdx":295,"cells":{"repo":{"kind":"string","value":"rust-lang/rust"},"issue_number":{"kind":"number","value":154716,"string":"154,716"},"issue_title":{"kind":"string","value":"Rollup of 21 pull requests"},"issue_body":{"kind":"string","value":"Successful merges:\n\n - rust-lang/rust#153105 (Compute the result of a projection type with region errors)\n - rust-lang/rust#153286 (various fixes for scalable vectors)\n - rust-lang/rust#153532 (Attributes containing rustc)\n - rust-lang/rust#153960 (Make `layout_of` cycles fatal errors)\n - rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)\n - rust-lang/rust#154666 (Remove `StableHashContext` impls)\n - rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`)\n - rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args)\n - rust-lang/rust#154712 (Revert \"`-Znext-solver` Remove the forced ambiguity hack from search graph\")\n - rust-lang/rust#154713 (Stop compiling when we get resolving crate failure)\n - rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message)\n - rust-lang/rust#154425 (Migrate transmute tests)\n - rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)\n - rust-lang/rust#154469 (mGCA: Lower spans for literal const args)\n - rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)\n - rust-lang/rust#154615 (Moving issues)\n - rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar)\n - rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns)\n - rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)\n - rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)\n - rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)\n\n<!-- homu-ignore:start -->\nr? @ghost\n\n[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=153105,153286,153532,153960,154527,154666,154669,154710,154712,154713,154213,154425,154442,154469,154578,154615,154644,154660,154671,154680,154709)\n<!-- homu-ignore:end -->\n\n"},"commit_sha":{"kind":"string","value":"f3ba2c41e63ac58ae8aafbe7725db6b5e6021d00"},"files":{"kind":"list like","value":[{"filename":"src/librustdoc/clean/inline.rs","patch":"@@ -137,7 +137,7 @@ pub(crate) fn try_inline(\n })\n }\n Res::Def(DefKind::Macro(kinds), did) => {\n- let mac = build_macro(cx, did, name, kinds);\n+ let mac = build_macro(cx.tcx, did, name, kinds);\n \n // FIXME: handle attributes and derives that aren't proc macros, and macros with\n // multiple kinds\n@@ -769,17 +769,17 @@ fn build_static(cx: &mut DocContext<'_>, did: DefId, mutable: bool) -> clean::St\n }\n \n fn build_macro(\n- cx: &mut DocContext<'_>,\n+ tcx: TyCtxt<'_>,\n def_id: DefId,\n name: Symbol,\n macro_kinds: MacroKinds,\n ) -> clean::ItemKind {\n- match CStore::from_tcx(cx.tcx).load_macro_untracked(cx.tcx, def_id) {\n+ match CStore::from_tcx(tcx).load_macro_untracked(tcx, def_id) {\n // FIXME: handle attributes and derives that aren't proc macros, and macros with multiple\n // kinds\n LoadedMacro::MacroDef { def, .. } => match macro_kinds {\n MacroKinds::BANG => clean::MacroItem(clean::Macro {\n- source: utils::display_macro_source(cx.tcx, name, &def),\n+ source: utils::display_macro_source(tcx, name, &def),\n macro_rules: def.macro_rules,\n }),\n MacroKinds::DERIVE => clean::ProcMacroItem(clean::ProcMacro {","additions":4,"deletions":4}],"string":"[\n {\n \"filename\": \"src/librustdoc/clean/inline.rs\",\n \"patch\": \"@@ -137,7 +137,7 @@ pub(crate) fn try_inline(\\n })\\n }\\n Res::Def(DefKind::Macro(kinds), did) => {\\n- let mac = build_macro(cx, did, name, kinds);\\n+ let mac = build_macro(cx.tcx, did, name, kinds);\\n \\n // FIXME: handle attributes and derives that aren't proc macros, and macros with\\n // multiple kinds\\n@@ -769,17 +769,17 @@ fn build_static(cx: &mut DocContext<'_>, did: DefId, mutable: bool) -> clean::St\\n }\\n \\n fn build_macro(\\n- cx: &mut DocContext<'_>,\\n+ tcx: TyCtxt<'_>,\\n def_id: DefId,\\n name: Symbol,\\n macro_kinds: MacroKinds,\\n ) -> clean::ItemKind {\\n- match CStore::from_tcx(cx.tcx).load_macro_untracked(cx.tcx, def_id) {\\n+ match CStore::from_tcx(tcx).load_macro_untracked(tcx, def_id) {\\n // FIXME: handle attributes and derives that aren't proc macros, and macros with multiple\\n // kinds\\n LoadedMacro::MacroDef { def, .. } => match macro_kinds {\\n MacroKinds::BANG => clean::MacroItem(clean::Macro {\\n- source: utils::display_macro_source(cx.tcx, name, &def),\\n+ source: utils::display_macro_source(tcx, name, &def),\\n macro_rules: def.macro_rules,\\n }),\\n MacroKinds::DERIVE => clean::ProcMacroItem(clean::ProcMacro {\",\n \"additions\": 4,\n \"deletions\": 4\n }\n]","isConversational":false}}},{"rowIdx":296,"cells":{"repo":{"kind":"string","value":"electron/electron"},"issue_number":{"kind":"number","value":50608,"string":"50,608"},"issue_title":{"kind":"string","value":"fix: remove menu update debug log"},"issue_body":{"kind":"string","value":"#### Description of Change\r\n\r\nRemoves a diagnostic log:\r\n\r\n```\r\nrepresentedObject is not a WeakPtrToElectronMenuModelAsNSObject\r\n```\r\n\r\nThis log was introduced alongside a guard in macOS menu refresh. The guard is part of the system's expected behavior, preventing us from processing menu items we don't own. In other words, the guard itself is benign. Keep the guard, remove the log.\r\n\r\nFixes #50389\r\n\r\n#### Checklist\r\n- [x] PR description included\r\n- [x] I have built and tested this PR\r\n- [x] `npm test` passes\r\n- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).\r\n\r\n#### Release Notes\r\n\r\nNotes: Removed \"representedObject is not a WeakPtrToElectronMenuModelAsNSObject\" logging when interacting with macOS menus.\r\n"},"commit_sha":{"kind":"string","value":"5689abff4d2a9a292b57bf2fe6c72e308fd2afc2"},"files":{"kind":"list like","value":[{"filename":"shell/browser/ui/cocoa/electron_menu_controller.mm","patch":"@@ -478,7 +478,6 @@ - (void)applyStateToMenuItem:(NSMenuItem*)item {\n \n if (![represented\n isKindOfClass:[WeakPtrToElectronMenuModelAsNSObject class]]) {\n- NSLog(@\"representedObject is not a WeakPtrToElectronMenuModelAsNSObject\");\n return;\n }\n ","additions":0,"deletions":1}],"string":"[\n {\n \"filename\": \"shell/browser/ui/cocoa/electron_menu_controller.mm\",\n \"patch\": \"@@ -478,7 +478,6 @@ - (void)applyStateToMenuItem:(NSMenuItem*)item {\\n \\n if (![represented\\n isKindOfClass:[WeakPtrToElectronMenuModelAsNSObject class]]) {\\n- NSLog(@\\\"representedObject is not a WeakPtrToElectronMenuModelAsNSObject\\\");\\n return;\\n }\\n \",\n \"additions\": 0,\n \"deletions\": 1\n }\n]","isConversational":false}}},{"rowIdx":297,"cells":{"repo":{"kind":"string","value":"vercel/next.js"},"issue_number":{"kind":"number","value":92165,"string":"92,165"},"issue_title":{"kind":"string","value":"#64441 bug: fix not scrolling top issue"},"issue_body":{"kind":"string","value":"# Fix scroll restoration on route change with sticky headers\r\n\r\n**Actual problem:**\r\nThe scroll restoration currently runs before layout is fully applied. In cases involving sticky elements and short pages, this results in no visible scroll change.\r\n\r\n**Tests:**\r\nI added an integration test under `test/integration/scroll-restoration-on-navigation` to cover this scenario.\r\nDue to local environment limitations (Playwright dependencies on my OS), I wasn’t able to run it locally, but the behavior has been verified manually in a real browser and it is **working as expected** now.\r\n\r\nHappy to adjust the test if CI surfaces any issues or if there’s a preferred testing approach.\r\n\r\nCovers the behavior described in Next.js GitHub Issue #64441"},"commit_sha":{"kind":"string","value":"f8a22e0c4fb7d084306dbbfa1718a468d366ac6d"},"files":{"kind":"list like","value":[{"filename":".config/eslintignore.mjs","patch":"@@ -47,6 +47,7 @@ export default globalIgnores([\n 'examples/with-typescript-graphql/lib/gql/',\n 'test/development/basic/hmr/components/parse-error.js',\n 'test/development/mcp-server/fixtures/default-template/app/build-error/page.tsx',\n+ 'test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx',\n 'test/production/debug-build-path/fixtures/with-compile-error/app/broken/page.tsx',\n 'packages/next-swc/native/index.d.ts',\n 'packages/next-swc/docs/assets/**/*',","additions":1,"deletions":0},{"filename":".prettierignore","patch":"@@ -59,6 +59,7 @@ test/e2e/app-dir/server-source-maps/fixtures/default/internal-pkg/ignored.js\n test/e2e/app-dir/server-source-maps/fixtures/default/internal-pkg/sourcemapped.js\n test/e2e/app-dir/server-source-maps/fixtures/default/external-pkg/sourcemapped.js\n test/development/mcp-server/fixtures/default-template/app/build-error/page.tsx\n+test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx\n # Tested against auto-generated content that isn't formatted\n test/integration/typescript-app-type-declarations/next-env.strictRouteTypes.d.ts\n ","additions":1,"deletions":0},{"filename":"Cargo.lock","patch":"@@ -3638,9 +3638,9 @@ dependencies = [\n \n [[package]]\n name = \"js-sys\"\n-version = \"0.3.77\"\n+version = \"0.3.91\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"1cfaf33c695fc6e08064efbc1f72ec937429614f25eef83af942d0e227c3a28f\"\n+checksum = \"b49715b7073f385ba4bc528e5747d02e66cb39c6146efb66b781f131f0fb399c\"\n dependencies = [\n \"once_cell\",\n \"wasm-bindgen\",\n@@ -9487,13 +9487,17 @@ dependencies = [\n \"bincode 2.0.1\",\n \"bytes-str\",\n \"codspeed-criterion-compat\",\n+ \"inventory\",\n \"napi\",\n \"new_debug_unreachable\",\n \"rustc-hash 2.1.1\",\n \"serde\",\n \"shrink-to-fit\",\n+ \"smallvec\",\n \"triomphe 0.1.12\",\n+ \"turbo-bincode\",\n \"turbo-tasks-hash\",\n+ \"unty\",\n ]\n \n [[package]]\n@@ -11010,37 +11014,25 @@ dependencies = [\n \n [[package]]\n name = \"wasm-bindgen\"\n-version = \"0.2.100\"\n+version = \"0.2.114\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"1edc8929d7499fc4e8f0be2262a241556cfc54a0bea223790e71446f2aab1ef5\"\n+checksum = \"6532f9a5c1ece3798cb1c2cfdba640b9b3ba884f5db45973a6f442510a87d38e\"\n dependencies = [\n \"cfg-if\",\n \"once_cell\",\n \"rustversion\",\n \"wasm-bindgen-macro\",\n-]\n-\n-[[package]]\n-name = \"wasm-bindgen-backend\"\n-version = \"0.2.100\"\n-source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"2f0a0651a5c2bc21487bde11ee802ccaf4c51935d0d3d42a6101f98161700bc6\"\n-dependencies = [\n- \"bumpalo\",\n- \"log\",\n- \"proc-macro2\",\n- \"quote\",\n- \"syn 2.0.104\",\n \"wasm-bindgen-shared\",\n ]\n \n [[package]]\n name = \"wasm-bindgen-futures\"\n-version = \"0.4.50\"\n+version = \"0.4.64\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"555d470ec0bc3bb57890405e5d4322cc9ea83cebb085523ced7be4144dac1e61\"\n+checksum = \"e9c5522b3a28661442748e09d40924dfb9ca614b21c00d3fd135720e48b67db8\"\n dependencies = [\n \"cfg-if\",\n+ \"futures-util\",\n \"js-sys\",\n \"once_cell\",\n \"wasm-bindgen\",\n@@ -11049,32 +11041,32 @@ dependencies = [\n \n [[package]]\n name = \"wasm-bindgen-macro\"\n-version = \"0.2.100\"\n+version = \"0.2.114\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"7fe63fc6d09ed3792bd0897b314f53de8e16568c2b3f7982f468c0bf9bd0b407\"\n+checksum = \"18a2d50fcf105fb33bb15f00e7a77b772945a2ee45dcf454961fd843e74c18e6\"\n dependencies = [\n \"quote\",\n \"wasm-bindgen-macro-support\",\n ]\n \n [[package]]\n name = \"wasm-bindgen-macro-support\"\n-version = \"0.2.100\"\n+version = \"0.2.114\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"8ae87ea40c9f689fc23f209965b6fb8a99ad69aeeb0231408be24920604395de\"\n+checksum = \"03ce4caeaac547cdf713d280eda22a730824dd11e6b8c3ca9e42247b25c631e3\"\n dependencies = [\n+ \"bumpalo\",\n \"proc-macro2\",\n \"quote\",\n \"syn 2.0.104\",\n- \"wasm-bindgen-backend\",\n \"wasm-bindgen-shared\",\n ]\n \n [[package]]\n name = \"wasm-bindgen-shared\"\n-version = \"0.2.100\"\n+version = \"0.2.114\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"1a05d73b933a847d6cccdda8f838a22ff101ad9bf93e33684f39c1f5f0eece3d\"\n+checksum = \"75a326b8c223ee17883a4251907455a2431acc2791c98c26279376490c378c16\"\n dependencies = [\n \"unicode-ident\",\n ]\n@@ -11494,9 +11486,9 @@ dependencies = [\n \n [[package]]\n name = \"web-sys\"\n-version = \"0.3.77\"\n+version = \"0.3.91\"\n source = \"registry+https://github.com/rust-lang/crates.io-index\"\n-checksum = \"33b6dd2ef9186f1f2072e409e99cd22a975331a6b3591b12c764e0e55c60d5d2\"\n+checksum = \"854ba17bb104abfb26ba36da9729addc7ce7f06f5c0f90f3c391f8461cca21f9\"\n dependencies = [\n \"js-sys\",\n \"wasm-bindgen\",","additions":20,"deletions":28},{"filename":"crates/next-napi-bindings/src/next_api/project.rs","patch":"@@ -2508,6 +2508,74 @@ pub async fn project_write_analyze_data(\n })\n }\n \n+#[turbo_tasks::function(operation)]\n+async fn get_all_compilation_issues_inner_operation(\n+ container: ResolvedVc<ProjectContainer>,\n+) -> Result<Vc<()>> {\n+ let project = container.project();\n+ // Build the module graph for every endpoint without chunking, code gen, or disk emission.\n+ // We iterate endpoints rather than calling project.whole_app_module_graphs() because the\n+ // latter calls drop_issues() in development mode (to avoid duplicate per-route HMR noise).\n+ // Per-endpoint module_graphs() calls are not subject to that suppression, so issues like\n+ // missing modules and transform errors are properly collected as collectables here.\n+ let endpoint_groups = project.get_all_endpoint_groups(false).await?;\n+ endpoint_groups\n+ .iter()\n+ .map(|(_, endpoint_group)| async move {\n+ endpoint_group.module_graphs().as_side_effect().await\n+ })\n+ .try_join()\n+ .await?;\n+ Ok(Vc::cell(()))\n+}\n+\n+#[turbo_tasks::function(operation)]\n+async fn get_all_compilation_issues_operation(\n+ container: ResolvedVc<ProjectContainer>,\n+) -> Result<Vc<OperationResult>> {\n+ let inner_op = get_all_compilation_issues_inner_operation(container);\n+ let filter = issue_filter_from_container(container);\n+ let (_, issues, diagnostics, effects) =\n+ strongly_consistent_catch_collectables(inner_op, filter).await?;\n+ Ok(OperationResult {\n+ issues,\n+ diagnostics,\n+ effects,\n+ }\n+ .cell())\n+}\n+\n+#[tracing::instrument(level = \"info\", name = \"get all compilation issues\", skip_all)]\n+#[napi]\n+pub async fn project_get_all_compilation_issues(\n+ #[napi(ts_arg_type = \"{ __napiType: \\\"Project\\\" }\")] project: External<ProjectInstance>,\n+) -> napi::Result<TurbopackResult<()>> {\n+ let container = project.container;\n+ let (issues, diagnostics) = project\n+ .turbopack_ctx\n+ .turbo_tasks()\n+ .run_once(async move {\n+ let op = get_all_compilation_issues_operation(container);\n+ let OperationResult {\n+ issues,\n+ diagnostics,\n+ effects: _,\n+ } = &*op.read_strongly_consistent().await?;\n+ Ok((issues.clone(), diagnostics.clone()))\n+ })\n+ .await\n+ .map_err(|e| napi::Error::from_reason(PrettyPrintError(&e).to_string()))?;\n+\n+ Ok(TurbopackResult {\n+ result: (),\n+ issues: issues.iter().map(|i| NapiIssue::from(&**i)).collect(),\n+ diagnostics: diagnostics\n+ .iter()\n+ .map(|d| NapiDiagnostic::from(d))\n+ .collect(),\n+ })\n+}\n+\n /// Opens the Turbopack persistent cache database at the given path and performs a full compaction.\n ///\n /// The `path` should point to the `<distDir>/cache/turbopack` directory.","additions":68,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/EVAL.ts","patch":"@@ -0,0 +1,131 @@\n+/**\n+ * View Transitions\n+ *\n+ * Tests whether the agent correctly adds React View Transitions to a Next.js\n+ * product gallery app covering shared element morphs, directional navigation,\n+ * Suspense reveal animations, and accessibility.\n+ *\n+ * Tricky because agents may:\n+ * - Not know about the experimental.viewTransition flag in next.config\n+ * - Try to call document.startViewTransition manually instead of using\n+ * React's <ViewTransition> component\n+ * - Import ViewTransition from a third-party library instead of 'react'\n+ * - Not know about the transitionTypes prop on next/link\n+ * - Forget default=\"none\" causing every transition to cross-fade everything\n+ * - Skip prefers-reduced-motion (React does NOT disable animations automatically)\n+ */\n+\n+import { expect, test } from 'vitest'\n+import { readFileSync, existsSync, readdirSync } from 'fs'\n+import { join } from 'path'\n+\n+const IGNORE_DIRS = new Set([\n+ 'node_modules',\n+ '.next',\n+ '.git',\n+ 'dist',\n+ 'build',\n+ 'coverage',\n+])\n+\n+function findFiles(dir: string, ext: string): string[] {\n+ const results: string[] = []\n+ const base = join(process.cwd(), dir)\n+ if (!existsSync(base)) return results\n+\n+ function walk(d: string) {\n+ for (const entry of readdirSync(d, { withFileTypes: true })) {\n+ if (IGNORE_DIRS.has(entry.name)) continue\n+ const full = join(d, entry.name)\n+ if (entry.isDirectory()) walk(full)\n+ else if (entry.name.endsWith(ext)) results.push(full)\n+ }\n+ }\n+ walk(base)\n+ return results\n+}\n+\n+function stripComments(source: string): string {\n+ return source.replace(/\\/\\*[\\s\\S]*?\\*\\//g, '').replace(/\\/\\/[^\\r\\n]*/g, '')\n+}\n+\n+const SOURCE_EXTS = ['.tsx', '.ts', '.jsx', '.js']\n+const SOURCE_DIRS = ['app', 'lib', 'components', 'src']\n+\n+function readAllSourceFiles(): string {\n+ const files = SOURCE_DIRS.flatMap((dir) =>\n+ SOURCE_EXTS.flatMap((ext) => findFiles(dir, ext))\n+ )\n+ return files\n+ .map((f) => stripComments(readFileSync(f, 'utf-8')))\n+ .join('\\n---FILE---\\n')\n+}\n+\n+function readAllCssFiles(): string {\n+ const files = [\n+ ...findFiles('app', '.css'),\n+ ...findFiles('src', '.css'),\n+ ...findFiles('.', '.css').filter(\n+ (f) => !f.includes('node_modules') && !f.includes('.next')\n+ ),\n+ ]\n+ const unique = [...new Set(files)]\n+ return unique.map((f) => readFileSync(f, 'utf-8')).join('\\n')\n+}\n+\n+test('next.config enables viewTransition', () => {\n+ const configPath = existsSync(join(process.cwd(), 'next.config.ts'))\n+ ? 'next.config.ts'\n+ : 'next.config.js'\n+ const content = stripComments(\n+ readFileSync(join(process.cwd(), configPath), 'utf-8')\n+ )\n+\n+ expect(content).toMatch(/viewTransition\\s*:\\s*true/)\n+})\n+\n+test('ViewTransition is imported from react', () => {\n+ const allSource = readAllSourceFiles()\n+\n+ expect(allSource).toMatch(\n+ /import\\s+\\{[^}]*ViewTransition[^}]*\\}\\s+from\\s+['\"]react['\"]/\n+ )\n+})\n+\n+test('Shared element transitions use named ViewTransition', () => {\n+ const allSource = readAllSourceFiles()\n+\n+ const nameMatches = allSource.match(/<ViewTransition[^>]*\\bname\\s*=/g)\n+ expect(nameMatches).not.toBeNull()\n+ expect(nameMatches!.length).toBeGreaterThanOrEqual(2)\n+})\n+\n+test('Link uses transitionTypes for directional navigation', () => {\n+ const allSource = readAllSourceFiles()\n+\n+ expect(allSource).toMatch(/transitionTypes/)\n+})\n+\n+test('Suspense content uses ViewTransition with enter or exit', () => {\n+ const allSource = readAllSourceFiles()\n+\n+ expect(allSource).toMatch(/<ViewTransition[^>]*\\b(enter|exit)\\s*=/)\n+})\n+\n+test('default=\"none\" prevents unintended animations', () => {\n+ const allSource = readAllSourceFiles()\n+\n+ expect(allSource).toMatch(/default\\s*=\\s*[\"']none[\"']/)\n+})\n+\n+test('CSS handles prefers-reduced-motion', () => {\n+ const allCss = readAllCssFiles()\n+\n+ expect(allCss).toMatch(/prefers-reduced-motion/)\n+})\n+\n+test('CSS defines view transition animations', () => {\n+ const allCss = readAllCssFiles()\n+\n+ expect(allCss).toMatch(/::view-transition-(old|new|group)/)\n+})","additions":131,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/PROMPT.md","patch":"@@ -0,0 +1 @@\n+Add view transitions to this product gallery app. When navigating from the grid to a product detail page, the product image should smoothly morph between the thumbnail and the large detail image using a shared element transition. Page navigations should slide directionally. Suspense loading states should transition smoothly from skeleton to content. All animations must respect the user's prefers-reduced-motion preference.","additions":1,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/ProductGrid.tsx","patch":"@@ -0,0 +1,23 @@\n+import Link from 'next/link'\n+import { products } from '@/lib/products'\n+\n+export function ProductGrid() {\n+ return (\n+ <div className=\"product-grid\">\n+ {products.map((product) => (\n+ <Link\n+ key={product.slug}\n+ href={`/product/${product.slug}`}\n+ className=\"product-card\"\n+ >\n+ <div\n+ className=\"product-image\"\n+ style={{ backgroundColor: product.color }}\n+ />\n+ <h2>{product.name}</h2>\n+ <p>${product.price}</p>\n+ </Link>\n+ ))}\n+ </div>\n+ )\n+}","additions":23,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/ProductSkeleton.tsx","patch":"@@ -0,0 +1,13 @@\n+export function ProductGridSkeleton() {\n+ return (\n+ <div className=\"product-grid\">\n+ {Array.from({ length: 4 }).map((_, i) => (\n+ <div key={i} className=\"product-card\">\n+ <div className=\"product-image skeleton-image\" />\n+ <div className=\"skeleton-text\" />\n+ <div className=\"skeleton-text short\" />\n+ </div>\n+ ))}\n+ </div>\n+ )\n+}","additions":13,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/globals.css","patch":"@@ -0,0 +1,121 @@\n+* {\n+ margin: 0;\n+ padding: 0;\n+ box-sizing: border-box;\n+}\n+\n+body {\n+ font-family:\n+ system-ui,\n+ -apple-system,\n+ sans-serif;\n+ color: #111;\n+ background: #fafafa;\n+}\n+\n+main {\n+ max-width: 1200px;\n+ margin: 0 auto;\n+ padding: 2rem;\n+}\n+\n+h1 {\n+ margin-bottom: 1.5rem;\n+}\n+\n+.product-grid {\n+ display: grid;\n+ grid-template-columns: repeat(auto-fill, minmax(250px, 1fr));\n+ gap: 1.5rem;\n+}\n+\n+.product-card {\n+ border-radius: 12px;\n+ overflow: hidden;\n+ background: white;\n+ box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);\n+ text-decoration: none;\n+ color: inherit;\n+}\n+\n+.product-card h2 {\n+ padding: 0.75rem 1rem 0;\n+ font-size: 1rem;\n+}\n+\n+.product-card p {\n+ padding: 0.25rem 1rem 1rem;\n+ color: #666;\n+}\n+\n+.product-image {\n+ width: 100%;\n+ aspect-ratio: 4 / 3;\n+}\n+\n+.product-detail {\n+ display: grid;\n+ grid-template-columns: 1fr 1fr;\n+ gap: 2rem;\n+ align-items: start;\n+}\n+\n+.product-hero {\n+ width: 100%;\n+ aspect-ratio: 1;\n+ border-radius: 12px;\n+}\n+\n+.product-info h1 {\n+ font-size: 2rem;\n+}\n+\n+.product-price {\n+ font-size: 1.5rem;\n+ font-weight: 600;\n+ margin: 0.5rem 0;\n+}\n+\n+.product-description {\n+ color: #666;\n+ line-height: 1.6;\n+}\n+\n+.back-link {\n+ display: inline-block;\n+ margin-bottom: 1.5rem;\n+ color: #666;\n+ text-decoration: none;\n+}\n+\n+.skeleton-image {\n+ background: #e5e5e5;\n+ animation: pulse 1.5s ease-in-out infinite;\n+}\n+\n+.skeleton-text {\n+ height: 1rem;\n+ background: #e5e5e5;\n+ border-radius: 4px;\n+ margin: 0.5rem 1rem;\n+ animation: pulse 1.5s ease-in-out infinite;\n+}\n+\n+.skeleton-text.short {\n+ width: 60%;\n+}\n+\n+.skeleton-text.large {\n+ height: 2rem;\n+ width: 70%;\n+}\n+\n+@keyframes pulse {\n+ 0%,\n+ 100% {\n+ opacity: 1;\n+ }\n+ 50% {\n+ opacity: 0.5;\n+ }\n+}","additions":121,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/layout.tsx","patch":"@@ -0,0 +1,19 @@\n+import type { Metadata } from 'next'\n+import './globals.css'\n+\n+export const metadata: Metadata = {\n+ title: 'Product Gallery',\n+ description: 'A simple product gallery',\n+}\n+\n+export default function RootLayout({\n+ children,\n+}: Readonly<{\n+ children: React.ReactNode\n+}>) {\n+ return (\n+ <html lang=\"en\">\n+ <body>{children}</body>\n+ </html>\n+ )\n+}","additions":19,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/page.tsx","patch":"@@ -0,0 +1,14 @@\n+import { Suspense } from 'react'\n+import { ProductGrid } from './ProductGrid'\n+import { ProductGridSkeleton } from './ProductSkeleton'\n+\n+export default function Home() {\n+ return (\n+ <main>\n+ <h1>Products</h1>\n+ <Suspense fallback={<ProductGridSkeleton />}>\n+ <ProductGrid />\n+ </Suspense>\n+ </main>\n+ )\n+}","additions":14,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/app/product/[slug]/page.tsx","patch":"@@ -0,0 +1,55 @@\n+import { Suspense } from 'react'\n+import Link from 'next/link'\n+import { getProduct, products } from '@/lib/products'\n+import { notFound } from 'next/navigation'\n+\n+async function ProductDetails({ slug }: { slug: string }) {\n+ await new Promise((resolve) => setTimeout(resolve, 100))\n+ const product = getProduct(slug)\n+ if (!product) notFound()\n+\n+ return (\n+ <div className=\"product-info\">\n+ <h1>{product.name}</h1>\n+ <p className=\"product-price\">${product.price}</p>\n+ <p className=\"product-description\">{product.description}</p>\n+ </div>\n+ )\n+}\n+\n+function DetailsSkeleton() {\n+ return (\n+ <div className=\"product-info\">\n+ <div className=\"skeleton-text large\" />\n+ <div className=\"skeleton-text short\" />\n+ <div className=\"skeleton-text\" />\n+ </div>\n+ )\n+}\n+\n+export default async function ProductPage({\n+ params,\n+}: {\n+ params: Promise<{ slug: string }>\n+}) {\n+ const { slug } = await params\n+ const product = products.find((p) => p.slug === slug)\n+ if (!product) notFound()\n+\n+ return (\n+ <div>\n+ <Link href=\"/\" className=\"back-link\">\n+ ← Back to products\n+ </Link>\n+ <div className=\"product-detail\">\n+ <div\n+ className=\"product-hero\"\n+ style={{ backgroundColor: product.color }}\n+ />\n+ <Suspense fallback={<DetailsSkeleton />}>\n+ <ProductDetails slug={slug} />\n+ </Suspense>\n+ </div>\n+ </div>\n+ )\n+}","additions":55,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/lib/products.ts","patch":"@@ -0,0 +1,42 @@\n+export type Product = {\n+ slug: string\n+ name: string\n+ description: string\n+ price: number\n+ color: string\n+}\n+\n+export const products: Product[] = [\n+ {\n+ slug: 'classic-sneakers',\n+ name: 'Classic Sneakers',\n+ description: 'Timeless design meets everyday comfort.',\n+ price: 89,\n+ color: '#4F46E5',\n+ },\n+ {\n+ slug: 'leather-backpack',\n+ name: 'Leather Backpack',\n+ description: 'Handcrafted from premium full-grain leather.',\n+ price: 129,\n+ color: '#059669',\n+ },\n+ {\n+ slug: 'wireless-headphones',\n+ name: 'Wireless Headphones',\n+ description: 'Crystal-clear audio with active noise cancellation.',\n+ price: 199,\n+ color: '#DC2626',\n+ },\n+ {\n+ slug: 'cotton-hoodie',\n+ name: 'Cotton Hoodie',\n+ description: 'Ultra-soft organic cotton blend for all-day wear.',\n+ price: 65,\n+ color: '#D97706',\n+ },\n+]\n+\n+export function getProduct(slug: string): Product | undefined {\n+ return products.find((p) => p.slug === slug)\n+}","additions":42,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/next.config.ts","patch":"@@ -0,0 +1,5 @@\n+import type { NextConfig } from 'next'\n+\n+const nextConfig: NextConfig = {}\n+\n+export default nextConfig","additions":5,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/package.json","patch":"@@ -0,0 +1,23 @@\n+{\n+ \"private\": true,\n+ \"type\": \"module\",\n+ \"scripts\": {\n+ \"dev\": \"next dev\",\n+ \"build\": \"next build\",\n+ \"start\": \"next start\"\n+ },\n+ \"dependencies\": {\n+ \"next\": \"^16\",\n+ \"react\": \"19.1.0\",\n+ \"react-dom\": \"19.1.0\"\n+ },\n+ \"devDependencies\": {\n+ \"@types/node\": \"^20\",\n+ \"@types/react\": \"^19\",\n+ \"@types/react-dom\": \"^19\",\n+ \"typescript\": \"^5\",\n+ \"vitest\": \"^3.1.3\",\n+ \"@vitejs/plugin-react\": \"^4.4.1\",\n+ \"vite-tsconfig-paths\": \"^5.1.4\"\n+ }\n+}","additions":23,"deletions":0},{"filename":"evals/evals/agent-043-view-transitions/tsconfig.json","patch":"@@ -0,0 +1,27 @@\n+{\n+ \"compilerOptions\": {\n+ \"target\": \"ES2017\",\n+ \"lib\": [\"dom\", \"dom.iterable\", \"esnext\"],\n+ \"allowJs\": true,\n+ \"skipLibCheck\": true,\n+ \"strict\": true,\n+ \"noEmit\": true,\n+ \"esModuleInterop\": true,\n+ \"module\": \"esnext\",\n+ \"moduleResolution\": \"bundler\",\n+ \"resolveJsonModule\": true,\n+ \"isolatedModules\": true,\n+ \"jsx\": \"react-jsx\",\n+ \"incremental\": true,\n+ \"plugins\": [\n+ {\n+ \"name\": \"next\"\n+ }\n+ ],\n+ \"paths\": {\n+ \"@/*\": [\"./*\"]\n+ }\n+ },\n+ \"include\": [\"next-env.d.ts\", \"**/*.ts\", \"**/*.tsx\", \".next/types/**/*.ts\"],\n+ \"exclude\": [\"node_modules\"]\n+}","additions":27,"deletions":0},{"filename":"lerna.json","patch":"@@ -15,5 +15,5 @@\n \"registry\": \"https://registry.npmjs.org/\"\n }\n },\n- \"version\": \"16.2.1-canary.17\"\n+ \"version\": \"16.2.1-canary.18\"\n }\n\\ No newline at end of file","additions":1,"deletions":1},{"filename":"packages/create-next-app/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"create-next-app\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"keywords\": [\n \"react\",\n \"next\",","additions":1,"deletions":1},{"filename":"packages/eslint-config-next/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"eslint-config-next\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"ESLint configuration used by Next.js.\",\n \"license\": \"MIT\",\n \"repository\": {\n@@ -12,7 +12,7 @@\n \"dist\"\n ],\n \"dependencies\": {\n- \"@next/eslint-plugin-next\": \"16.2.1-canary.17\",\n+ \"@next/eslint-plugin-next\": \"16.2.1-canary.18\",\n \"eslint-import-resolver-node\": \"^0.3.6\",\n \"eslint-import-resolver-typescript\": \"^3.5.2\",\n \"eslint-plugin-import\": \"^2.32.0\",","additions":2,"deletions":2},{"filename":"packages/eslint-plugin-internal/package.json","patch":"@@ -1,7 +1,7 @@\n {\n \"name\": \"@next/eslint-plugin-internal\",\n \"private\": true,\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"ESLint plugin for working on Next.js.\",\n \"exports\": {\n \".\": \"./src/eslint-plugin-internal.js\"","additions":1,"deletions":1},{"filename":"packages/eslint-plugin-next/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/eslint-plugin-next\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"ESLint plugin for Next.js.\",\n \"main\": \"dist/index.js\",\n \"types\": \"dist/index.d.ts\",","additions":1,"deletions":1},{"filename":"packages/font/package.json","patch":"@@ -1,7 +1,7 @@\n {\n \"name\": \"@next/font\",\n \"private\": true,\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"repository\": {\n \"url\": \"vercel/next.js\",\n \"directory\": \"packages/font\"","additions":1,"deletions":1},{"filename":"packages/next-bundle-analyzer/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/bundle-analyzer\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"main\": \"index.js\",\n \"types\": \"index.d.ts\",\n \"license\": \"MIT\",","additions":1,"deletions":1},{"filename":"packages/next-codemod/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/codemod\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"license\": \"MIT\",\n \"repository\": {\n \"type\": \"git\",","additions":1,"deletions":1},{"filename":"packages/next-env/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/env\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"keywords\": [\n \"react\",\n \"next\",","additions":1,"deletions":1},{"filename":"packages/next-mdx/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/mdx\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"main\": \"index.js\",\n \"license\": \"MIT\",\n \"repository\": {","additions":1,"deletions":1},{"filename":"packages/next-playwright/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/playwright\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"repository\": {\n \"url\": \"vercel/next.js\",\n \"directory\": \"packages/next-playwright\"","additions":1,"deletions":1},{"filename":"packages/next-plugin-storybook/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/plugin-storybook\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"repository\": {\n \"url\": \"vercel/next.js\",\n \"directory\": \"packages/next-plugin-storybook\"","additions":1,"deletions":1},{"filename":"packages/next-polyfill-module/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/polyfill-module\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"A standard library polyfill for ES Modules supporting browsers (Edge 16+, Firefox 60+, Chrome 61+, Safari 10.1+)\",\n \"main\": \"dist/polyfill-module.js\",\n \"license\": \"MIT\",","additions":1,"deletions":1},{"filename":"packages/next-polyfill-nomodule/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/polyfill-nomodule\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"A polyfill for non-dead, nomodule browsers.\",\n \"main\": \"dist/polyfill-nomodule.js\",\n \"license\": \"MIT\",","additions":1,"deletions":1},{"filename":"packages/next-routing/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/routing\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"keywords\": [\n \"react\",\n \"next\",","additions":1,"deletions":1},{"filename":"packages/next-rspack/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"next-rspack\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"repository\": {\n \"url\": \"vercel/next.js\",\n \"directory\": \"packages/next-rspack\"","additions":1,"deletions":1},{"filename":"packages/next-swc/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/swc\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"private\": true,\n \"files\": [\n \"native/\"","additions":1,"deletions":1},{"filename":"packages/next/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"next\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"The React Framework\",\n \"main\": \"./dist/server/next.js\",\n \"license\": \"MIT\",\n@@ -99,7 +99,7 @@\n ]\n },\n \"dependencies\": {\n- \"@next/env\": \"16.2.1-canary.17\",\n+ \"@next/env\": \"16.2.1-canary.18\",\n \"@swc/helpers\": \"0.5.15\",\n \"baseline-browser-mapping\": \"^2.9.19\",\n \"caniuse-lite\": \"^1.0.30001579\",\n@@ -163,11 +163,11 @@\n \"@modelcontextprotocol/sdk\": \"1.18.1\",\n \"@mswjs/interceptors\": \"0.23.0\",\n \"@napi-rs/triples\": \"1.2.0\",\n- \"@next/font\": \"16.2.1-canary.17\",\n- \"@next/polyfill-module\": \"16.2.1-canary.17\",\n- \"@next/polyfill-nomodule\": \"16.2.1-canary.17\",\n- \"@next/react-refresh-utils\": \"16.2.1-canary.17\",\n- \"@next/swc\": \"16.2.1-canary.17\",\n+ \"@next/font\": \"16.2.1-canary.18\",\n+ \"@next/polyfill-module\": \"16.2.1-canary.18\",\n+ \"@next/polyfill-nomodule\": \"16.2.1-canary.18\",\n+ \"@next/react-refresh-utils\": \"16.2.1-canary.18\",\n+ \"@next/swc\": \"16.2.1-canary.18\",\n \"@opentelemetry/api\": \"1.6.0\",\n \"@playwright/test\": \"1.58.2\",\n \"@rspack/core\": \"1.6.7\",","additions":7,"deletions":7},{"filename":"packages/next/src/build/swc/generated-native.d.ts","patch":"@@ -491,6 +491,9 @@ export declare function projectWriteAnalyzeData(\n project: { __napiType: 'Project' },\n appDirOnly: boolean\n ): Promise<TurbopackResult>\n+export declare function projectGetAllCompilationIssues(project: {\n+ __napiType: 'Project'\n+}): Promise<TurbopackResult>\n /**\n * Opens the Turbopack persistent cache database at the given path and performs a full compaction.\n *","additions":3,"deletions":0},{"filename":"packages/next/src/build/swc/index.ts","patch":"@@ -708,6 +708,13 @@ function bindingToApi(\n return napiResult\n }\n \n+ async getAllCompilationIssues(): Promise<TurbopackResult<void>> {\n+ const napiResult = (await binding.projectGetAllCompilationIssues(\n+ this._nativeProject\n+ )) as TurbopackResult<void>\n+ return napiResult\n+ }\n+\n async writeAllEntrypointsToDisk(\n appDirOnly: boolean\n ): Promise<TurbopackResult<Partial<RawEntrypoints>>> {","additions":7,"deletions":0},{"filename":"packages/next/src/build/swc/types.ts","patch":"@@ -290,6 +290,8 @@ export interface Project {\n \n writeAnalyzeData(appDirOnly: boolean): Promise<TurbopackResult<void>>\n \n+ getAllCompilationIssues(): Promise<TurbopackResult<void>>\n+\n writeAllEntrypointsToDisk(\n appDirOnly: boolean\n ): Promise<TurbopackResult<Partial<RawEntrypoints>>>","additions":2,"deletions":0},{"filename":"packages/next/src/build/templates/app-page.ts","patch":"@@ -995,214 +995,317 @@ export async function handler(\n const isProduction = routeModule.isDev === false\n const didRespond = hasResolved || res.writableEnded\n \n- // skip on-demand revalidate if cache is not present and\n- // revalidate-if-generated is set\n- if (\n- isOnDemandRevalidate &&\n- revalidateOnlyGenerated &&\n- !previousIncrementalCacheEntry &&\n- !isMinimalMode\n- ) {\n- if (routerServerContext?.render404) {\n- await routerServerContext.render404(req, res)\n- } else {\n- res.statusCode = 404\n- res.end('This page could not be found')\n+ try {\n+ // skip on-demand revalidate if cache is not present and\n+ // revalidate-if-generated is set\n+ if (\n+ isOnDemandRevalidate &&\n+ revalidateOnlyGenerated &&\n+ !previousIncrementalCacheEntry &&\n+ !isMinimalMode\n+ ) {\n+ if (routerServerContext?.render404) {\n+ await routerServerContext.render404(req, res)\n+ } else {\n+ res.statusCode = 404\n+ res.end('This page could not be found')\n+ }\n+ return null\n }\n- return null\n- }\n \n- let fallbackMode: FallbackMode | undefined\n+ let fallbackMode: FallbackMode | undefined\n \n- if (prerenderInfo) {\n- fallbackMode = parseFallbackField(prerenderInfo.fallback)\n- }\n-\n- if (\n- nextConfig.experimental.partialFallbacks === true &&\n- prerenderInfo?.fallback === null &&\n- !hasUnresolvedRootFallbackParams &&\n- remainingPrerenderableParams.length > 0\n- ) {\n- // Generic source shells without unresolved root params don't have a\n- // concrete fallback file of their own, so they're marked as blocking.\n- // When we can complete the shell into a more specific\n- // prerendered shell for this request, treat it like a prerender\n- // fallback so we can serve that shell instead of blocking on the full\n- // route. Root-param shells stay blocking, since unknown root branches\n- // should not inherit a shell from another generated branch.\n- fallbackMode = FallbackMode.PRERENDER\n- }\n+ if (prerenderInfo) {\n+ fallbackMode = parseFallbackField(prerenderInfo.fallback)\n+ }\n \n- // When serving a HTML bot request, we want to serve a blocking render and\n- // not the prerendered page. This ensures that the correct content is served\n- // to the bot in the head.\n- if (fallbackMode === FallbackMode.PRERENDER && isBot(userAgent)) {\n- if (!isRoutePPREnabled || isHtmlBot) {\n- fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\n+ if (\n+ nextConfig.experimental.partialFallbacks === true &&\n+ prerenderInfo?.fallback === null &&\n+ !hasUnresolvedRootFallbackParams &&\n+ remainingPrerenderableParams.length > 0\n+ ) {\n+ // Generic source shells without unresolved root params don't have a\n+ // concrete fallback file of their own, so they're marked as blocking.\n+ // When we can complete the shell into a more specific\n+ // prerendered shell for this request, treat it like a prerender\n+ // fallback so we can serve that shell instead of blocking on the full\n+ // route. Root-param shells stay blocking, since unknown root branches\n+ // should not inherit a shell from another generated branch.\n+ fallbackMode = FallbackMode.PRERENDER\n }\n- }\n \n- if (previousIncrementalCacheEntry?.isStale === -1) {\n- isOnDemandRevalidate = true\n- }\n+ // When serving a HTML bot request, we want to serve a blocking render and\n+ // not the prerendered page. This ensures that the correct content is served\n+ // to the bot in the head.\n+ if (fallbackMode === FallbackMode.PRERENDER && isBot(userAgent)) {\n+ if (!isRoutePPREnabled || isHtmlBot) {\n+ fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\n+ }\n+ }\n \n- // TODO: adapt for PPR\n- // only allow on-demand revalidate for fallback: true/blocking\n- // or for prerendered fallback: false paths\n- if (\n- isOnDemandRevalidate &&\n- (fallbackMode !== FallbackMode.NOT_FOUND ||\n- previousIncrementalCacheEntry)\n- ) {\n- fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\n- }\n+ if (previousIncrementalCacheEntry?.isStale === -1) {\n+ isOnDemandRevalidate = true\n+ }\n \n- if (\n- !isMinimalMode &&\n- fallbackMode !== FallbackMode.BLOCKING_STATIC_RENDER &&\n- staticPathKey &&\n- !didRespond &&\n- !isDraftMode &&\n- pageIsDynamic &&\n- (isProduction || !isPrerendered)\n- ) {\n- // if the page has dynamicParams: false and this pathname wasn't\n- // prerendered trigger the no fallback handling\n+ // TODO: adapt for PPR\n+ // only allow on-demand revalidate for fallback: true/blocking\n+ // or for prerendered fallback: false paths\n if (\n- // In development, fall through to render to handle missing\n- // getStaticPaths.\n- (isProduction || prerenderInfo) &&\n- // When fallback isn't present, abort this render so we 404\n- fallbackMode === FallbackMode.NOT_FOUND\n+ isOnDemandRevalidate &&\n+ (fallbackMode !== FallbackMode.NOT_FOUND ||\n+ previousIncrementalCacheEntry)\n ) {\n- if (nextConfig.adapterPath) {\n- return await render404()\n- }\n- throw new NoFallbackError()\n+ fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\n }\n \n- // When cacheComponents is enabled, we can use the fallback\n- // response if the request is not a dynamic RSC request because the\n- // RSC data when this feature flag is enabled does not contain any\n- // param references. Without this feature flag enabled, the RSC data\n- // contains param references, and therefore we can't use the fallback.\n if (\n- isRoutePPREnabled &&\n- (nextConfig.cacheComponents ? !isDynamicRSCRequest : !isRSCRequest)\n+ !isMinimalMode &&\n+ fallbackMode !== FallbackMode.BLOCKING_STATIC_RENDER &&\n+ staticPathKey &&\n+ !didRespond &&\n+ !isDraftMode &&\n+ pageIsDynamic &&\n+ (isProduction || !isPrerendered)\n ) {\n- const cacheKey =\n- isProduction && typeof prerenderInfo?.fallback === 'string'\n- ? prerenderInfo.fallback\n- : normalizedSrcPage\n-\n- const fallbackRouteParams =\n- // In production or when debugging the static shell (e.g. instant\n- // navigation testing), use the prerender manifest's fallback\n- // route params which correctly identifies which params are\n- // unknown. Note: in dev, this block is only entered for\n- // non-prerendered URLs (guarded by the outer condition).\n- (isProduction || isDebugStaticShell) &&\n- prerenderInfo?.fallbackRouteParams\n- ? createOpaqueFallbackRouteParams(\n- prerenderInfo.fallbackRouteParams\n- )\n- : // When debugging the fallback shell, treat all params as\n- // fallback (simulating the worst-case shell).\n- isDebugFallbackShell\n- ? getFallbackRouteParams(normalizedSrcPage, routeModule)\n- : null\n+ // if the page has dynamicParams: false and this pathname wasn't\n+ // prerendered trigger the no fallback handling\n+ if (\n+ // In development, fall through to render to handle missing\n+ // getStaticPaths.\n+ (isProduction || prerenderInfo) &&\n+ // When fallback isn't present, abort this render so we 404\n+ fallbackMode === FallbackMode.NOT_FOUND\n+ ) {\n+ if (nextConfig.adapterPath) {\n+ return await render404()\n+ }\n+ throw new NoFallbackError()\n+ }\n+\n+ // When cacheComponents is enabled, we can use the fallback\n+ // response if the request is not a dynamic RSC request because the\n+ // RSC data when this feature flag is enabled does not contain any\n+ // param references. Without this feature flag enabled, the RSC data\n+ // contains param references, and therefore we can't use the fallback.\n+ if (\n+ isRoutePPREnabled &&\n+ (nextConfig.cacheComponents ? !isDynamicRSCRequest : !isRSCRequest)\n+ ) {\n+ const cacheKey =\n+ isProduction && typeof prerenderInfo?.fallback === 'string'\n+ ? prerenderInfo.fallback\n+ : normalizedSrcPage\n+\n+ const fallbackRouteParams =\n+ // In production or when debugging the static shell (e.g. instant\n+ // navigation testing), use the prerender manifest's fallback\n+ // route params which correctly identifies which params are\n+ // unknown. Note: in dev, this block is only entered for\n+ // non-prerendered URLs (guarded by the outer condition).\n+ (isProduction || isDebugStaticShell) &&\n+ prerenderInfo?.fallbackRouteParams\n+ ? createOpaqueFallbackRouteParams(\n+ prerenderInfo.fallbackRouteParams\n+ )\n+ : // When debugging the fallback shell, treat all params as\n+ // fallback (simulating the worst-case shell).\n+ isDebugFallbackShell\n+ ? getFallbackRouteParams(normalizedSrcPage, routeModule)\n+ : null\n+\n+ // When rendering a debug static shell, override the fallback\n+ // params on the request so that the staged rendering correctly\n+ // defers params that are not statically known.\n+ if (isDebugStaticShell && fallbackRouteParams) {\n+ addRequestMeta(req, 'fallbackParams', fallbackRouteParams)\n+ }\n \n- // When rendering a debug static shell, override the fallback\n- // params on the request so that the staged rendering correctly\n- // defers params that are not statically known.\n- if (isDebugStaticShell && fallbackRouteParams) {\n- addRequestMeta(req, 'fallbackParams', fallbackRouteParams)\n+ // We use the response cache here to handle the revalidation and\n+ // management of the fallback shell.\n+ const fallbackResponse = await routeModule.handleResponse({\n+ cacheKey,\n+ req,\n+ nextConfig,\n+ routeKind: RouteKind.APP_PAGE,\n+ isFallback: true,\n+ prerenderManifest,\n+ isRoutePPREnabled,\n+ responseGenerator: async () =>\n+ doRender({\n+ span,\n+ // We pass `undefined` as rendering a fallback isn't resumed\n+ // here.\n+ postponed: undefined,\n+ // Always serve the shell that matched this request\n+ // immediately. If there are still prerenderable params left,\n+ // the background path below will complete the shell into a\n+ // more specific cache entry for later requests.\n+ fallbackRouteParams,\n+ forceStaticRender: true,\n+ }),\n+ waitUntil: ctx.waitUntil,\n+ isMinimalMode,\n+ })\n+\n+ // If the fallback response was set to null, then we should return null.\n+ if (fallbackResponse === null) return null\n+\n+ // Otherwise, if we did get a fallback response, we should return it.\n+ if (fallbackResponse) {\n+ if (\n+ !isMinimalMode &&\n+ isRoutePPREnabled &&\n+ // Match the build-time contract: only fallback shells that can\n+ // still be completed with prerenderable params should upgrade.\n+ remainingPrerenderableParams.length > 0 &&\n+ nextConfig.experimental.partialFallbacks === true &&\n+ ssgCacheKey &&\n+ incrementalCache &&\n+ !isOnDemandRevalidate &&\n+ !isDebugFallbackShell &&\n+ // The testing API relies on deterministic shell behavior, so\n+ // don't upgrade fallback shells in the background when it's\n+ // exposed.\n+ !exposeTestingApi &&\n+ // Instant Navigation Testing API requests intentionally keep\n+ // the route in shell mode; don't upgrade these in background.\n+ !isInstantNavigationTest &&\n+ // Avoid background revalidate during prefetches; this can trigger\n+ // static prerender errors that surface as 500s for the prefetch\n+ // request itself.\n+ !isPrefetchRSCRequest\n+ ) {\n+ scheduleOnNextTick(async () => {\n+ const responseCache = routeModule.getResponseCache(req)\n+\n+ try {\n+ // Only the params that were just specialized should be\n+ // removed from the fallback render. Any remaining fallback\n+ // params stay deferred so the revalidated result is a more\n+ // specific shell (e.g. `/prefix/c/[two]`), not a fully\n+ // concrete route (`/prefix/c/foo`).\n+ await responseCache.revalidate(\n+ ssgCacheKey,\n+ incrementalCache,\n+ isRoutePPREnabled,\n+ false,\n+ (c) => {\n+ return doRender({\n+ span: c.span,\n+ postponed: undefined,\n+ fallbackRouteParams:\n+ remainingFallbackRouteParams.length > 0\n+ ? createOpaqueFallbackRouteParams(\n+ remainingFallbackRouteParams\n+ )\n+ : null,\n+ forceStaticRender: true,\n+ })\n+ },\n+ // We don't have a prior entry for this param-specific shell.\n+ null,\n+ hasResolved,\n+ ctx.waitUntil\n+ )\n+ } catch (err) {\n+ console.error(\n+ 'Error revalidating the page in the background',\n+ err\n+ )\n+ }\n+ })\n+ }\n+\n+ // Remove the cache control from the response to prevent it from being\n+ // used in the surrounding cache.\n+ delete fallbackResponse.cacheControl\n+\n+ return fallbackResponse\n+ }\n }\n+ }\n \n- // We use the response cache here to handle the revalidation and\n- // management of the fallback shell.\n- const fallbackResponse = await routeModule.handleResponse({\n- cacheKey,\n- req,\n- nextConfig,\n- routeKind: RouteKind.APP_PAGE,\n- isFallback: true,\n- prerenderManifest,\n- isRoutePPREnabled,\n- responseGenerator: async () =>\n- doRender({\n- span,\n- // We pass `undefined` as rendering a fallback isn't resumed\n- // here.\n- postponed: undefined,\n- // Always serve the shell that matched this request\n- // immediately. If there are still prerenderable params left,\n- // the background path below will complete the shell into a\n- // more specific cache entry for later requests.\n- fallbackRouteParams,\n- forceStaticRender: true,\n- }),\n- waitUntil: ctx.waitUntil,\n- isMinimalMode,\n- })\n+ // Only requests that aren't revalidating can be resumed. If we have the\n+ // minimal postponed data, then we should resume the render with it.\n+ let postponed =\n+ !isOnDemandRevalidate && !isRevalidating && minimalPostponed\n+ ? minimalPostponed\n+ : undefined\n+\n+ if (\n+ // If this is a dynamic RSC request or a server action request, we should\n+ // use the postponed data from the static render (if available). This\n+ // ensures that we can utilize the resume data cache (RDC) from the static\n+ // render to ensure that the data is consistent between the static and\n+ // dynamic renders (for navigations) or when re-rendering after a server\n+ // action.\n+ // Only enable RDC for Navigations if the feature is enabled.\n+ supportsRDCForNavigations &&\n+ process.env.NEXT_RUNTIME !== 'edge' &&\n+ !isMinimalMode &&\n+ incrementalCache &&\n+ // Include both dynamic RSC requests (navigations) and server actions\n+ (isDynamicRSCRequest || isPossibleServerAction) &&\n+ // We don't typically trigger an on-demand revalidation for dynamic RSC\n+ // requests, as we're typically revalidating the page in the background\n+ // instead. However, if the cache entry is stale, we should trigger a\n+ // background revalidation on dynamic RSC requests. This prevents us\n+ // from entering an infinite loop of revalidations.\n+ !forceStaticRender\n+ ) {\n+ const incrementalCacheEntry = await incrementalCache.get(\n+ resolvedPathname,\n+ {\n+ kind: IncrementalCacheKind.APP_PAGE,\n+ isRoutePPREnabled: true,\n+ isFallback: false,\n+ }\n+ )\n \n- // If the fallback response was set to null, then we should return null.\n- if (fallbackResponse === null) return null\n+ // If the cache entry is found, we should use the postponed data from\n+ // the cache.\n+ if (\n+ incrementalCacheEntry &&\n+ incrementalCacheEntry.value &&\n+ incrementalCacheEntry.value.kind === CachedRouteKind.APP_PAGE\n+ ) {\n+ // CRITICAL: we're assigning the postponed data from the cache entry\n+ // here as we're using the RDC to resume the render.\n+ postponed = incrementalCacheEntry.value.postponed\n \n- // Otherwise, if we did get a fallback response, we should return it.\n- if (fallbackResponse) {\n+ // If the cache entry is stale, we should trigger a background\n+ // revalidation so that subsequent requests will get a fresh response.\n if (\n- !isMinimalMode &&\n- isRoutePPREnabled &&\n- // Match the build-time contract: only fallback shells that can\n- // still be completed with prerenderable params should upgrade.\n- remainingPrerenderableParams.length > 0 &&\n- nextConfig.experimental.partialFallbacks === true &&\n- ssgCacheKey &&\n- incrementalCache &&\n- !isOnDemandRevalidate &&\n- !isDebugFallbackShell &&\n- // The testing API relies on deterministic shell behavior, so\n- // don't upgrade fallback shells in the background when it's\n- // exposed.\n- !exposeTestingApi &&\n- // Instant Navigation Testing API requests intentionally keep\n- // the route in shell mode; don't upgrade these in background.\n- !isInstantNavigationTest &&\n- // Avoid background revalidate during prefetches; this can trigger\n- // static prerender errors that surface as 500s for the prefetch\n- // request itself.\n- !isPrefetchRSCRequest\n+ incrementalCacheEntry &&\n+ // We want to trigger this flow if the cache entry is stale and if\n+ // the requested revalidation flow is either foreground or\n+ // background.\n+ (incrementalCacheEntry.isStale === -1 ||\n+ incrementalCacheEntry.isStale === true)\n ) {\n+ // We want to schedule this on the next tick to ensure that the\n+ // render is not blocked on it.\n scheduleOnNextTick(async () => {\n const responseCache = routeModule.getResponseCache(req)\n \n try {\n- // Only the params that were just specialized should be\n- // removed from the fallback render. Any remaining fallback\n- // params stay deferred so the revalidated result is a more\n- // specific shell (e.g. `/prefix/c/[two]`), not a fully\n- // concrete route (`/prefix/c/foo`).\n await responseCache.revalidate(\n- ssgCacheKey,\n+ resolvedPathname,\n incrementalCache,\n isRoutePPREnabled,\n false,\n- (c) => {\n- return doRender({\n- span: c.span,\n- postponed: undefined,\n- fallbackRouteParams:\n- remainingFallbackRouteParams.length > 0\n- ? createOpaqueFallbackRouteParams(\n- remainingFallbackRouteParams\n- )\n- : null,\n+ (c) =>\n+ responseGenerator({\n+ ...c,\n+ // CRITICAL: we need to set this to true as we're\n+ // revalidating in the background and typically this dynamic\n+ // RSC request is not treated as static.\n forceStaticRender: true,\n- })\n- },\n- // We don't have a prior entry for this param-specific shell.\n+ }),\n+ // CRITICAL: we need to pass null here because passing the\n+ // previous cache entry here (which is stale) will switch on\n+ // isOnDemandRevalidate and break the prerendering.\n null,\n hasResolved,\n ctx.waitUntil\n@@ -1215,191 +1318,112 @@ export async function handler(\n }\n })\n }\n-\n- // Remove the cache control from the response to prevent it from being\n- // used in the surrounding cache.\n- delete fallbackResponse.cacheControl\n-\n- return fallbackResponse\n }\n }\n- }\n-\n- // Only requests that aren't revalidating can be resumed. If we have the\n- // minimal postponed data, then we should resume the render with it.\n- let postponed =\n- !isOnDemandRevalidate && !isRevalidating && minimalPostponed\n- ? minimalPostponed\n- : undefined\n \n- // If this is a dynamic RSC request or a server action request, we should\n- // use the postponed data from the static render (if available). This\n- // ensures that we can utilize the resume data cache (RDC) from the static\n- // render to ensure that the data is consistent between the static and\n- // dynamic renders (for navigations) or when re-rendering after a server\n- // action.\n- if (\n- // Only enable RDC for Navigations if the feature is enabled.\n- supportsRDCForNavigations &&\n- process.env.NEXT_RUNTIME !== 'edge' &&\n- !isMinimalMode &&\n- incrementalCache &&\n- // Include both dynamic RSC requests (navigations) and server actions\n- (isDynamicRSCRequest || isPossibleServerAction) &&\n- // We don't typically trigger an on-demand revalidation for dynamic RSC\n- // requests, as we're typically revalidating the page in the background\n- // instead. However, if the cache entry is stale, we should trigger a\n- // background revalidation on dynamic RSC requests. This prevents us\n- // from entering an infinite loop of revalidations.\n- !forceStaticRender\n- ) {\n- const incrementalCacheEntry = await incrementalCache.get(\n- resolvedPathname,\n- {\n- kind: IncrementalCacheKind.APP_PAGE,\n- isRoutePPREnabled: true,\n- isFallback: false,\n- }\n- )\n-\n- // If the cache entry is found, we should use the postponed data from\n- // the cache.\n+ // When we're in minimal mode, if we're trying to debug the static shell,\n+ // we should just return nothing instead of resuming the dynamic render.\n if (\n- incrementalCacheEntry &&\n- incrementalCacheEntry.value &&\n- incrementalCacheEntry.value.kind === CachedRouteKind.APP_PAGE\n+ (isDebugStaticShell || isDebugDynamicAccesses) &&\n+ typeof postponed !== 'undefined'\n ) {\n- // CRITICAL: we're assigning the postponed data from the cache entry\n- // here as we're using the RDC to resume the render.\n- postponed = incrementalCacheEntry.value.postponed\n-\n- // If the cache entry is stale, we should trigger a background\n- // revalidation so that subsequent requests will get a fresh response.\n- if (\n- incrementalCacheEntry &&\n- // We want to trigger this flow if the cache entry is stale and if\n- // the requested revalidation flow is either foreground or\n- // background.\n- (incrementalCacheEntry.isStale === -1 ||\n- incrementalCacheEntry.isStale === true)\n- ) {\n- // We want to schedule this on the next tick to ensure that the\n- // render is not blocked on it.\n- scheduleOnNextTick(async () => {\n- const responseCache = routeModule.getResponseCache(req)\n-\n- try {\n- await responseCache.revalidate(\n- resolvedPathname,\n- incrementalCache,\n- isRoutePPREnabled,\n- false,\n- (c) =>\n- responseGenerator({\n- ...c,\n- // CRITICAL: we need to set this to true as we're\n- // revalidating in the background and typically this dynamic\n- // RSC request is not treated as static.\n- forceStaticRender: true,\n- }),\n- // CRITICAL: we need to pass null here because passing the\n- // previous cache entry here (which is stale) will switch on\n- // isOnDemandRevalidate and break the prerendering.\n- null,\n- hasResolved,\n- ctx.waitUntil\n- )\n- } catch (err) {\n- console.error(\n- 'Error revalidating the page in the background',\n- err\n- )\n- }\n- })\n+ return {\n+ cacheControl: { revalidate: 1, expire: undefined },\n+ value: {\n+ kind: CachedRouteKind.PAGES,\n+ html: RenderResult.EMPTY,\n+ pageData: {},\n+ headers: undefined,\n+ status: undefined,\n+ } satisfies CachedPageValue,\n }\n }\n- }\n \n- // When we're in minimal mode, if we're trying to debug the static shell,\n- // we should just return nothing instead of resuming the dynamic render.\n- if (\n- (isDebugStaticShell || isDebugDynamicAccesses) &&\n- typeof postponed !== 'undefined'\n- ) {\n- return {\n- cacheControl: { revalidate: 1, expire: undefined },\n- value: {\n- kind: CachedRouteKind.PAGES,\n- html: RenderResult.EMPTY,\n- pageData: {},\n- headers: undefined,\n- status: undefined,\n- } satisfies CachedPageValue,\n+ // When route-module.ts resolved partial nxtP* params during\n+ // background revalidation, filter fallbackRouteParams to only the\n+ // params that are still unresolved. This lets doRender produce an\n+ // intermediate PPR shell that suspends only for those params.\n+ let effectiveFallbackRouteParams: FallbackRouteParam[] | null = null\n+ if (nextConfig.cacheComponents && prerenderInfo?.fallbackRouteParams) {\n+ const resolvedKeys = getRequestMeta(req, 'resolvedRouteParamKeys')\n+ if (resolvedKeys && resolvedKeys.size > 0) {\n+ effectiveFallbackRouteParams =\n+ prerenderInfo.fallbackRouteParams.filter(\n+ (param) => !resolvedKeys.has(param.paramName)\n+ )\n+ }\n }\n- }\n \n- // When route-module.ts resolved partial nxtP* params during\n- // background revalidation, filter fallbackRouteParams to only the\n- // params that are still unresolved. This lets doRender produce an\n- // intermediate PPR shell that suspends only for those params.\n- let effectiveFallbackRouteParams: FallbackRouteParam[] | null = null\n- if (nextConfig.cacheComponents && prerenderInfo?.fallbackRouteParams) {\n- const resolvedKeys = getRequestMeta(req, 'resolvedRouteParamKeys')\n- if (resolvedKeys && resolvedKeys.size > 0) {\n- effectiveFallbackRouteParams =\n- prerenderInfo.fallbackRouteParams.filter(\n- (param) => !resolvedKeys.has(param.paramName)\n- )\n- }\n- }\n+ const fallbackRouteParams =\n+ // In production or when debugging the static shell for a\n+ // non-prerendered URL, use the prerender manifest's fallback route\n+ // params which correctly identifies which params are unknown.\n+ ((isProduction && getRequestMeta(req, 'renderFallbackShell')) ||\n+ (isDebugStaticShell && !isPrerendered)) &&\n+ prerenderInfo?.fallbackRouteParams\n+ ? createOpaqueFallbackRouteParams(prerenderInfo.fallbackRouteParams)\n+ : // For intermediate shells where some params are resolved and\n+ // others still have placeholders, use the filtered subset so the\n+ // prerender suspends only for the unresolved params.\n+ effectiveFallbackRouteParams &&\n+ effectiveFallbackRouteParams.length > 0 &&\n+ effectiveFallbackRouteParams.length <\n+ (prerenderInfo?.fallbackRouteParams?.length ?? 0)\n+ ? createOpaqueFallbackRouteParams(effectiveFallbackRouteParams)\n+ : isDebugFallbackShell\n+ ? getFallbackRouteParams(normalizedSrcPage, routeModule)\n+ : null\n \n- const fallbackRouteParams =\n- // In production or when debugging the static shell for a\n- // non-prerendered URL, use the prerender manifest's fallback route\n- // params which correctly identifies which params are unknown.\n- ((isProduction && getRequestMeta(req, 'renderFallbackShell')) ||\n- (isDebugStaticShell && !isPrerendered)) &&\n- prerenderInfo?.fallbackRouteParams\n- ? createOpaqueFallbackRouteParams(prerenderInfo.fallbackRouteParams)\n- : // For intermediate shells where some params are resolved and\n- // others still have placeholders, use the filtered subset so the\n- // prerender suspends only for the unresolved params.\n- effectiveFallbackRouteParams &&\n- effectiveFallbackRouteParams.length > 0 &&\n- effectiveFallbackRouteParams.length <\n- (prerenderInfo?.fallbackRouteParams?.length ?? 0)\n- ? createOpaqueFallbackRouteParams(effectiveFallbackRouteParams)\n- : isDebugFallbackShell\n- ? getFallbackRouteParams(normalizedSrcPage, routeModule)\n- : null\n-\n- // For staged dynamic rendering (Cached Navigations) and debug static\n- // shell rendering, pass the fallback params via request meta so the\n- // RequestStore knows which params to defer. We don't pass them as\n- // fallbackRouteParams because that would replace actual param values\n- // with opaque placeholders during segment resolution.\n- if (\n- (isProduction || isDebugStaticShell) &&\n- nextConfig.cacheComponents &&\n- !isPrerendered &&\n- prerenderInfo?.fallbackRouteParams\n- ) {\n- const fallbackParams = createOpaqueFallbackRouteParams(\n- prerenderInfo.fallbackRouteParams\n- )\n+ // For staged dynamic rendering (Cached Navigations) and debug static\n+ // shell rendering, pass the fallback params via request meta so the\n+ // RequestStore knows which params to defer. We don't pass them as\n+ // fallbackRouteParams because that would replace actual param values\n+ // with opaque placeholders during segment resolution.\n+ if (\n+ (isProduction || isDebugStaticShell) &&\n+ nextConfig.cacheComponents &&\n+ !isPrerendered &&\n+ prerenderInfo?.fallbackRouteParams\n+ ) {\n+ const fallbackParams = createOpaqueFallbackRouteParams(\n+ prerenderInfo.fallbackRouteParams\n+ )\n \n- if (fallbackParams) {\n- addRequestMeta(req, 'fallbackParams', fallbackParams)\n+ if (fallbackParams) {\n+ addRequestMeta(req, 'fallbackParams', fallbackParams)\n+ }\n }\n- }\n \n- // Perform the render.\n- return doRender({\n- span,\n- postponed,\n- fallbackRouteParams,\n- forceStaticRender,\n- })\n+ // Perform the render.\n+ return doRender({\n+ span,\n+ postponed,\n+ fallbackRouteParams,\n+ forceStaticRender,\n+ })\n+ } catch (err) {\n+ // if this is a background revalidate we need to report\n+ // the request error here as it won't be bubbled\n+ if (previousIncrementalCacheEntry?.isStale) {\n+ const silenceLog = false\n+ await routeModule.onRequestError(\n+ req,\n+ err,\n+ {\n+ routerKind: 'App Router',\n+ routePath: srcPage,\n+ routeType: 'render',\n+ revalidateReason: getRevalidateReason({\n+ isStaticGeneration: isSSG,\n+ isOnDemandRevalidate,\n+ }),\n+ },\n+ silenceLog,\n+ routerServerContext\n+ )\n+ }\n+ throw err\n+ }\n }\n \n const handleResponse = async (span?: Span): Promise<null | void> => {","additions":373,"deletions":349},{"filename":"packages/next/src/server/app-render/stream-ops.node.ts","patch":"@@ -357,16 +357,6 @@ export async function streamToBuffer(stream: AnyStream): Promise<Buffer> {\n return webStreamToBuffer(nodeReadableToWebReadableStream(stream))\n }\n \n-export async function streamToUint8Array(\n- stream: AnyStream\n-): Promise<Uint8Array> {\n- const chunks: Buffer[] = []\n- for await (const chunk of webToReadable(stream)) {\n- chunks.push(typeof chunk === 'string' ? Buffer.from(chunk) : chunk)\n- }\n- return Buffer.concat(chunks)\n-}\n-\n export async function streamToString(stream: AnyStream): Promise<string> {\n return webStreamToString(nodeReadableToWebReadableStream(stream))\n }","additions":0,"deletions":10},{"filename":"packages/next/src/server/app-render/stream-ops.ts","patch":"@@ -46,7 +46,6 @@ export const createOnHeadersCallback = _m.createOnHeadersCallback\n export const resumeAndAbort = _m.resumeAndAbort\n export const renderToFlightStream = _m.renderToFlightStream\n export const streamToString = _m.streamToString\n-export const streamToUint8Array = _m.streamToUint8Array\n export const renderToFizzStream = _m.renderToFizzStream\n export const resumeToFizzStream = _m.resumeToFizzStream\n export const getServerPrerender = _m.getServerPrerender","additions":0,"deletions":1},{"filename":"packages/next/src/server/app-render/stream-ops.web.ts","patch":"@@ -20,7 +20,6 @@ import {\n continueStaticFallbackPrerender as webContinueStaticFallbackPrerender,\n continueDynamicHTMLResume as webContinueDynamicHTMLResume,\n streamToBuffer as webStreamToBuffer,\n- streamToUint8Array as webStreamToUint8Array,\n chainStreams as webChainStreams,\n createDocumentClosingStream as webCreateDocumentClosingStream,\n } from '../stream-utils/node-web-streams-helper'\n@@ -159,12 +158,6 @@ export async function streamToBuffer(stream: AnyStream): Promise<Buffer> {\n return webStreamToBuffer(stream as ReadableStream<Uint8Array>)\n }\n \n-export async function streamToUint8Array(\n- stream: AnyStream\n-): Promise<Uint8Array> {\n- return webStreamToUint8Array(stream as ReadableStream<Uint8Array>)\n-}\n-\n export function chainStreams(...streams: AnyStream[]): AnyStream {\n return webChainStreams(...(streams as ReadableStream<Uint8Array>[]))\n }","additions":0,"deletions":7},{"filename":"packages/next/src/server/dev/hot-reloader-turbopack.ts","patch":"@@ -1049,6 +1049,7 @@ export async function createHotReloaderTurbopack(\n getActiveConnectionCount: () =>\n clientsWithoutHtmlRequestId.size + clientsByHtmlRequestId.size,\n getDevServerUrl: () => process.env.__NEXT_PRIVATE_ORIGIN,\n+ getTurbopackProject: () => project,\n }),\n ]\n : []),","additions":1,"deletions":0},{"filename":"packages/next/src/server/dev/serialized-errors.ts","patch":"@@ -3,7 +3,7 @@ import {\n type HmrMessageSentToBrowser,\n } from './hot-reloader-types'\n import type { AnyStream } from '../app-render/stream-ops'\n-import { streamToUint8Array } from '../app-render/stream-ops'\n+import { streamToUint8Array } from '../stream-utils/node-web-streams-helper'\n \n const errorsRscStreamsByHtmlRequestId = new Map<string, AnyStream>()\n ","additions":1,"deletions":1},{"filename":"packages/next/src/server/mcp/get-or-create-mcp-server.ts","patch":"@@ -5,8 +5,10 @@ import { registerGetPageMetadataTool } from './tools/get-page-metadata'\n import { registerGetLogsTool } from './tools/get-logs'\n import { registerGetActionByIdTool } from './tools/get-server-action-by-id'\n import { registerGetRoutesTool } from './tools/get-routes'\n+import { registerGetCompilationIssuesTool } from './tools/get-compilation-issues'\n import type { HmrMessageSentToBrowser } from '../dev/hot-reloader-types'\n import type { NextConfigComplete } from '../config-shared'\n+import type { Project } from '../../build/swc/types'\n \n export interface McpServerOptions {\n projectPath: string\n@@ -17,6 +19,7 @@ export interface McpServerOptions {\n sendHmrMessage: (message: HmrMessageSentToBrowser) => void\n getActiveConnectionCount: () => number\n getDevServerUrl: () => string | undefined\n+ getTurbopackProject?: () => Project | undefined\n }\n \n let mcpServer: McpServer | undefined\n@@ -55,5 +58,9 @@ export const getOrCreateMcpServer = (options: McpServerOptions) => {\n appDir: options.appDir,\n })\n \n+ if (options.getTurbopackProject) {\n+ registerGetCompilationIssuesTool(mcpServer, options.getTurbopackProject)\n+ }\n+\n return mcpServer\n }","additions":7,"deletions":0},{"filename":"packages/next/src/server/mcp/tools/get-compilation-issues.ts","patch":"@@ -0,0 +1,70 @@\n+/**\n+ * MCP tool for getting compilation issues from all routes via Turbopack.\n+ *\n+ * Unlike get_errors (which requires a browser session and reflects the runtime\n+ * error overlay), this tool builds the module graph for every endpoint and\n+ * collects Turbopack issues directly — no browser needed. Covers\n+ * module-not-found, syntax errors, and other transform failures across all\n+ * routes.\n+ */\n+import type { McpServer } from 'next/dist/compiled/@modelcontextprotocol/sdk/server/mcp'\n+import type { Project } from '../../../build/swc/types'\n+import { mcpTelemetryTracker } from '../mcp-telemetry-tracker'\n+import { formatCompilationIssues } from './utils/format-compilation-issues'\n+\n+export function registerGetCompilationIssuesTool(\n+ server: McpServer,\n+ getProject: () => Project | undefined\n+) {\n+ server.registerTool(\n+ 'get_compilation_issues',\n+ {\n+ description:\n+ 'Build the module graph for all routes and return all compilation issues (resolve errors, missing modules, transform errors, etc.). Does not require a browser session. Covers all routes proactively.',\n+ inputSchema: {},\n+ },\n+ async () => {\n+ mcpTelemetryTracker.recordToolCall('mcp/get_compilation_issues')\n+\n+ try {\n+ const project = getProject()\n+ if (!project) {\n+ return {\n+ content: [\n+ {\n+ type: 'text',\n+ text: JSON.stringify({\n+ error:\n+ 'Turbopack project is not available. This tool requires the Turbopack bundler.',\n+ }),\n+ },\n+ ],\n+ }\n+ }\n+\n+ const { issues } = await project.getAllCompilationIssues()\n+ const formattedIssues = formatCompilationIssues(issues)\n+\n+ return {\n+ content: [\n+ {\n+ type: 'text',\n+ text: JSON.stringify({ issues: formattedIssues }),\n+ },\n+ ],\n+ }\n+ } catch (error) {\n+ return {\n+ content: [\n+ {\n+ type: 'text',\n+ text: JSON.stringify({\n+ error: error instanceof Error ? error.message : String(error),\n+ }),\n+ },\n+ ],\n+ }\n+ }\n+ }\n+ )\n+}","additions":70,"deletions":0},{"filename":"packages/next/src/server/mcp/tools/utils/format-compilation-issues.ts","patch":"@@ -0,0 +1,93 @@\n+import type { Issue, StyledString } from '../../../../build/swc/types'\n+import stripAnsi from 'next/dist/compiled/strip-ansi'\n+\n+/** Convert a StyledString tree to Markdown. */\n+function styledStringToMarkdown(s: StyledString): string {\n+ switch (s.type) {\n+ case 'text':\n+ return s.value\n+ case 'code':\n+ return `\\`${s.value}\\``\n+ case 'strong':\n+ return `**${s.value}**`\n+ case 'line':\n+ return s.value.map(styledStringToMarkdown).join('')\n+ case 'stack':\n+ return s.value.map(styledStringToMarkdown).join('\\n')\n+ default:\n+ return ''\n+ }\n+}\n+\n+export interface FormattedIssue {\n+ severity: string\n+ filePath: string\n+ title: string\n+ description?: string\n+ detail?: string\n+ source?: {\n+ filePath: string\n+ range?: {\n+ /** 1-indexed */\n+ start: { line: number; column: number }\n+ /** 1-indexed */\n+ end: { line: number; column: number }\n+ }\n+ }\n+ /** Code frame with ANSI codes stripped */\n+ codeFrame?: string\n+}\n+\n+/**\n+ * Transform raw Turbopack issues into a clean format for MCP consumers:\n+ * - Converts StyledString trees (title/description/detail) to Markdown\n+ * - Strips ANSI codes from code frames\n+ * - Converts 0-indexed source positions to 1-indexed\n+ * - Deduplicates issues (same error can surface from multiple endpoints)\n+ */\n+export function formatCompilationIssues(issues: Issue[]): FormattedIssue[] {\n+ const seen = new Set<string>()\n+ const formattedIssues: FormattedIssue[] = []\n+\n+ for (const issue of issues) {\n+ const title = styledStringToMarkdown(issue.title)\n+ // Include source position in the key so two distinct errors in the same\n+ // file with the same message are not collapsed into one.\n+ const startLine = issue.source?.range?.start.line ?? ''\n+ const startCol = issue.source?.range?.start.column ?? ''\n+ const key = `${issue.severity}|${issue.filePath}|${title}|${startLine}:${startCol}`\n+ if (seen.has(key)) continue\n+ seen.add(key)\n+\n+ const { range } = issue.source ?? {}\n+ formattedIssues.push({\n+ severity: issue.severity,\n+ filePath: issue.filePath,\n+ title,\n+ description: issue.description\n+ ? styledStringToMarkdown(issue.description)\n+ : undefined,\n+ detail: issue.detail ? styledStringToMarkdown(issue.detail) : undefined,\n+ source: issue.source\n+ ? {\n+ filePath: issue.source.source.filePath,\n+ range: range\n+ ? {\n+ start: {\n+ line: range.start.line + 1,\n+ column: range.start.column + 1,\n+ },\n+ end: {\n+ line: range.end.line + 1,\n+ column: range.end.column + 1,\n+ },\n+ }\n+ : undefined,\n+ }\n+ : undefined,\n+ codeFrame: issue.codeFrame ? stripAnsi(issue.codeFrame) : undefined,\n+ })\n+ }\n+\n+ return formattedIssues\n+}","additions":93,"deletions":0},{"filename":"packages/next/src/server/stream-utils/node-web-streams-helper.ts","patch":"@@ -22,6 +22,7 @@ import {\n NEXT_INSTANT_PREFETCH_HEADER,\n } from '../../client/components/app-router-headers'\n import { computeCacheBustingSearchParam } from '../../shared/lib/router/utils/cache-busting-search-param'\n+import type { AnyStream } from '../app-render/stream-ops'\n \n function voidCatch() {\n // this catcher is designed to be used with pipeTo where we expect the underlying\n@@ -125,12 +126,58 @@ function concatUint8Arrays(chunks: Array<Uint8Array>): Uint8Array {\n return result\n }\n \n-export async function streamToUint8Array(\n+export async function webstreamToUint8Array(\n stream: ReadableStream<Uint8Array>\n ): Promise<Uint8Array> {\n return concatUint8Arrays(await streamToChunks(stream))\n }\n \n+function webToReadable(\n+ stream: ReadableStream<Uint8Array> | import('node:stream').Readable\n+): import('node:stream').Readable {\n+ let Readable: typeof import('node:stream').Readable\n+ if (process.env.TURBOPACK) {\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\n+ } else if (process.env.__NEXT_BUNDLER === 'Webpack') {\n+ Readable = (\n+ __non_webpack_require__('node:stream') as typeof import('node:stream')\n+ ).Readable\n+ } else {\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\n+ }\n+ if (stream instanceof Readable) {\n+ return stream\n+ }\n+ return Readable.fromWeb(stream as import('stream/web').ReadableStream)\n+}\n+\n+export async function nodestreamToUint8Array(\n+ stream: AnyStream\n+): Promise<Uint8Array> {\n+ const chunks: Buffer[] = []\n+ for await (const chunk of webToReadable(stream)) {\n+ chunks.push(typeof chunk === 'string' ? Buffer.from(chunk) : chunk)\n+ }\n+ return Buffer.concat(chunks)\n+}\n+\n+export async function streamToUint8Array(stream: AnyStream) {\n+ let Readable: typeof import('node:stream').Readable\n+ if (process.env.TURBOPACK) {\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\n+ } else if (process.env.__NEXT_BUNDLER === 'Webpack') {\n+ Readable = (\n+ __non_webpack_require__('node:stream') as typeof import('node:stream')\n+ ).Readable\n+ } else {\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\n+ }\n+ if (stream instanceof Readable) {\n+ return nodestreamToUint8Array(stream)\n+ }\n+ return webstreamToUint8Array(stream)\n+}\n+\n export async function streamToBuffer(\n stream: ReadableStream<Uint8Array>\n ): Promise<Buffer> {","additions":48,"deletions":1},{"filename":"packages/next/src/telemetry/events/build.ts","patch":"@@ -259,6 +259,7 @@ export type McpToolName =\n | 'mcp/get_project_metadata'\n | 'mcp/get_routes'\n | 'mcp/get_server_action_by_id'\n+ | 'mcp/get_compilation_issues'\n \n export type EventMcpToolUsage = {\n toolName: McpToolName","additions":1,"deletions":0},{"filename":"packages/react-refresh-utils/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/react-refresh-utils\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"description\": \"An experimental package providing utilities for React Refresh.\",\n \"repository\": {\n \"url\": \"vercel/next.js\",","additions":1,"deletions":1},{"filename":"packages/third-parties/package.json","patch":"@@ -1,6 +1,6 @@\n {\n \"name\": \"@next/third-parties\",\n- \"version\": \"16.2.1-canary.17\",\n+ \"version\": \"16.2.1-canary.18\",\n \"repository\": {\n \"url\": \"vercel/next.js\",\n \"directory\": \"packages/third-parties\"\n@@ -26,7 +26,7 @@\n \"third-party-capital\": \"1.0.20\"\n },\n \"devDependencies\": {\n- \"next\": \"16.2.1-canary.17\",\n+ \"next\": \"16.2.1-canary.18\",\n \"outdent\": \"0.8.0\",\n \"prettier\": \"2.5.1\",\n \"typescript\": \"5.9.2\"","additions":2,"deletions":2},{"filename":"pnpm-lock.yaml","patch":"@@ -1017,7 +1017,7 @@ importers:\n packages/eslint-config-next:\n dependencies:\n '@next/eslint-plugin-next':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../eslint-plugin-next\n eslint:\n specifier: '>=9.0.0'\n@@ -1094,7 +1094,7 @@ importers:\n packages/next:\n dependencies:\n '@next/env':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../next-env\n '@swc/helpers':\n specifier: 0.5.15\n@@ -1219,19 +1219,19 @@ importers:\n specifier: 1.2.0\n version: 1.2.0\n '@next/font':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../font\n '@next/polyfill-module':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../next-polyfill-module\n '@next/polyfill-nomodule':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../next-polyfill-nomodule\n '@next/react-refresh-utils':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../react-refresh-utils\n '@next/swc':\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../next-swc\n '@opentelemetry/api':\n specifier: 1.6.0\n@@ -1955,7 +1955,7 @@ importers:\n version: 1.0.20\n devDependencies:\n next:\n- specifier: 16.2.1-canary.17\n+ specifier: 16.2.1-canary.18\n version: link:../next\n outdent:\n specifier: 0.8.0","additions":8,"deletions":8},{"filename":"test/development/mcp-server/fixtures/compilation-errors-app/app/layout.tsx","patch":"@@ -0,0 +1,11 @@\n+export default function RootLayout({\n+ children,\n+}: {\n+ children: React.ReactNode\n+}) {\n+ return (\n+ <html lang=\"en\">\n+ <body>{children}</body>\n+ </html>\n+ )\n+}","additions":11,"deletions":0},{"filename":"test/development/mcp-server/fixtures/compilation-errors-app/app/missing-module/page.tsx","patch":"@@ -0,0 +1,5 @@\n+import { something } from './non-existent-module'\n+\n+export default function MissingModulePage() {\n+ return <div>{something}</div>\n+}","additions":5,"deletions":0},{"filename":"test/development/mcp-server/fixtures/compilation-errors-app/app/page.tsx","patch":"@@ -0,0 +1,3 @@\n+export default function HomePage() {\n+ return <div>Home Page - No Errors</div>\n+}","additions":3,"deletions":0},{"filename":"test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx","patch":"@@ -0,0 +1,3 @@\n+export default function SyntaxErrorPage() {\n+ return <div>Broken JSX\n+}","additions":3,"deletions":0},{"filename":"test/development/mcp-server/fixtures/compilation-errors-app/next.config.js","patch":"@@ -0,0 +1,5 @@\n+module.exports = {\n+ experimental: {\n+ mcpServer: true,\n+ },\n+}","additions":5,"deletions":0},{"filename":"test/development/mcp-server/mcp-server-get-compilation-issues.test.ts","patch":"@@ -0,0 +1,92 @@\n+import path from 'path'\n+import { nextTestSetup } from 'e2e-utils'\n+\n+// get_compilation_issues is a Turbopack-only feature (requires NAPI project handle)\n+;(process.env.IS_TURBOPACK_TEST ? describe : describe.skip)(\n+ 'mcp-server get_compilation_issues tool',\n+ () => {\n+ const { next, skipped } = nextTestSetup({\n+ files: path.join(__dirname, 'fixtures', 'compilation-errors-app'),\n+ skipDeployment: true,\n+ })\n+\n+ if (skipped) {\n+ return\n+ }\n+\n+ async function callMcpTool() {\n+ const response = await fetch(`${next.url}/_next/mcp`, {\n+ method: 'POST',\n+ headers: {\n+ 'Content-Type': 'application/json',\n+ Accept: 'application/json, text/event-stream',\n+ },\n+ body: JSON.stringify({\n+ jsonrpc: '2.0',\n+ id: 'get-compilation-issues',\n+ method: 'tools/call',\n+ params: { name: 'get_compilation_issues', arguments: {} },\n+ }),\n+ })\n+\n+ const text = await response.text()\n+ const match = text.match(/data: ({.*})/s)\n+ expect(match).toBeTruthy()\n+ const result = JSON.parse(match![1])\n+ return JSON.parse(result.result?.content?.[0]?.text)\n+ }\n+\n+ type Issue = { severity: string; filePath: string; title: string }\n+\n+ let compilationResult: { issues: Issue[] }\n+\n+ beforeAll(async () => {\n+ compilationResult = await callMcpTool()\n+ })\n+\n+ function errorIssues() {\n+ return compilationResult.issues.filter(\n+ (issue) => issue.severity === 'error' || issue.severity === 'fatal'\n+ )\n+ }\n+\n+ it('should return compilation issues without requiring a browser session', () => {\n+ expect(compilationResult).toHaveProperty('issues')\n+ expect(Array.isArray(compilationResult.issues)).toBe(true)\n+ })\n+\n+ it('should detect module-not-found errors', () => {\n+ const errors = errorIssues()\n+ expect(errors.length).toBeGreaterThan(0)\n+\n+ const moduleNotFoundIssue = errors.find(\n+ (issue) =>\n+ issue.filePath.includes('missing-module') ||\n+ issue.title.includes('non-existent-module')\n+ )\n+ expect(moduleNotFoundIssue).toBeDefined()\n+ })\n+\n+ it('should detect syntax errors', () => {\n+ const errors = errorIssues()\n+ const syntaxErrorIssue = errors.find((issue) =>\n+ issue.filePath.includes('syntax-error')\n+ )\n+ expect(syntaxErrorIssue).toBeDefined()\n+ })\n+\n+ it('should include issue metadata fields', () => {\n+ const errors = errorIssues()\n+ expect(errors.length).toBeGreaterThan(0)\n+\n+ const issue = errors[0]\n+ expect(issue).toHaveProperty('severity')\n+ expect(issue).toHaveProperty('filePath')\n+ expect(issue).toHaveProperty('title')\n+ expect(typeof issue.severity).toBe('string')\n+ expect(typeof issue.filePath).toBe('string')\n+ // title must be a plain string, not a StyledString object\n+ expect(typeof issue.title).toBe('string')\n+ })\n+ }\n+)","additions":92,"deletions":0},{"filename":"turbopack/crates/turbo-rcstr/Cargo.toml","patch":"@@ -18,6 +18,10 @@ new_debug_unreachable = \"1.0.6\"\n shrink-to-fit = { workspace = true }\n rustc-hash = { workspace = true }\n bytes-str = { workspace = true }\n+inventory = { workspace = true }\n+smallvec = { workspace = true }\n+turbo-bincode = { workspace = true }\n+unty = { workspace = true }\n \n [target.'cfg(not(target_family = \"wasm\"))'.dependencies]\n napi = { workspace = true, optional = true }","additions":4,"deletions":0},{"filename":"turbopack/crates/turbo-rcstr/src/dynamic.rs","patch":"@@ -70,10 +70,16 @@ pub(crate) fn new_atom<T: AsRef<str> + Into<String>>(text: T) -> RcStr {\n \n let hash = hash_bytes(text.as_ref().as_bytes());\n \n- let entry: Arc<PrehashedString> = Arc::new(PrehashedString {\n+ let prehashed = PrehashedString {\n value: Payload::String(text.into()),\n hash,\n- });\n+ };\n+ new_atom_from_prehashed(prehashed)\n+}\n+\n+/// Construct a new dynamic RcStr from a PrehashedString\n+pub(crate) fn new_atom_from_prehashed(prehashed: PrehashedString) -> RcStr {\n+ let entry: Arc<PrehashedString> = Arc::new(prehashed);\n let entry = Arc::into_raw(entry);\n \n let ptr: NonNull<PrehashedString> = unsafe {","additions":8,"deletions":2},{"filename":"turbopack/crates/turbo-rcstr/src/lib.rs","patch":"@@ -1,30 +1,34 @@\n use std::{\n borrow::{Borrow, Cow},\n+ collections::HashMap,\n ffi::OsStr,\n fmt::{Debug, Display},\n hash::{Hash, Hasher},\n mem::{ManuallyDrop, forget},\n num::NonZeroU8,\n ops::Deref,\n path::{Path, PathBuf},\n+ sync::LazyLock,\n };\n \n use bincode::{\n Decode, Encode,\n- de::Decoder,\n+ de::{Decoder, read::Reader},\n enc::Encoder,\n error::{DecodeError, EncodeError},\n impl_borrow_decode,\n };\n use bytes_str::BytesStr;\n use debug_unreachable::debug_unreachable;\n+use rustc_hash::FxBuildHasher;\n use serde::{Deserialize, Deserializer, Serialize, Serializer};\n use shrink_to_fit::ShrinkToFit;\n+use smallvec::SmallVec;\n use triomphe::Arc;\n use turbo_tasks_hash::{DeterministicHash, DeterministicHasher};\n \n use crate::{\n- dynamic::{deref_from, hash_bytes, new_atom},\n+ dynamic::{deref_from, hash_bytes, new_atom, new_atom_from_prehashed, new_static_atom},\n tagged_value::TaggedValue,\n };\n \n@@ -159,6 +163,32 @@ impl RcStr {\n pub fn map(self, f: impl FnOnce(String) -> String) -> Self {\n RcStr::from(Cow::Owned(f(self.into_owned())))\n }\n+\n+ /// Create an RcStr from a deserialized string, checking the static constant\n+ /// table first. If the string matches an `rcstr!` constant, returns a\n+ /// zero-cost static copy instead of allocating a new Arc.\n+ ///\n+ /// Accepts `&str` so that borrow-decode paths can avoid heap allocation\n+ /// entirely for inline strings (≤6 bytes) and static table hits.\n+ fn from_deserialized(s: &str) -> Self {\n+ let len = s.len();\n+ if len >= tagged_value::MAX_INLINE_LEN {\n+ let hash = hash_bytes(s.as_bytes());\n+ // Check the static table\n+ if let Some(entries) = STATIC_TABLE.get(&hash)\n+ && let Some(static_phs) = entries.iter().find(|phs| phs.value.as_str() == s)\n+ {\n+ new_static_atom(static_phs)\n+ } else {\n+ new_atom_from_prehashed(PrehashedString {\n+ hash,\n+ value: dynamic::Payload::String(s.into()),\n+ })\n+ }\n+ } else {\n+ inline_atom(s).unwrap()\n+ }\n+ }\n }\n \n impl DeterministicHash for RcStr {\n@@ -377,8 +407,25 @@ impl Serialize for RcStr {\n \n impl<'de> Deserialize<'de> for RcStr {\n fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {\n- let s = String::deserialize(deserializer)?;\n- Ok(RcStr::from(s))\n+ struct RcStrVisitor;\n+\n+ impl serde::de::Visitor<'_> for RcStrVisitor {\n+ type Value = RcStr;\n+\n+ fn expecting(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {\n+ f.write_str(\"a string\")\n+ }\n+\n+ fn visit_str<E: serde::de::Error>(self, v: &str) -> Result<RcStr, E> {\n+ Ok(RcStr::from_deserialized(v))\n+ }\n+\n+ fn visit_string<E: serde::de::Error>(self, v: String) -> Result<RcStr, E> {\n+ Ok(RcStr::from_deserialized(&v))\n+ }\n+ }\n+\n+ deserializer.deserialize_str(RcStrVisitor)\n }\n }\n \n@@ -390,7 +437,29 @@ impl Encode for RcStr {\n \n impl<Context> Decode<Context> for RcStr {\n fn decode<D: Decoder<Context = Context>>(decoder: &mut D) -> Result<Self, DecodeError> {\n- Ok(RcStr::from(String::decode(decoder)?))\n+ // Decode the length prefix\n+ let len = u64::decode(decoder)?;\n+ let len: usize = len\n+ .try_into()\n+ .map_err(|_| DecodeError::OutsideUsizeRange(len))?;\n+\n+ if unty::type_equal::<D::R, turbo_bincode::TurboBincodeReader>() {\n+ // We know the reader is a TurboBincodeReader backed by &[u8], so peek_read\n+ // returning None means data corruption (not enough bytes), not \"unsupported\".\n+ let bytes = decoder\n+ .reader()\n+ .peek_read(len)\n+ .ok_or(DecodeError::UnexpectedEnd { additional: len })?;\n+ let s = core::str::from_utf8(bytes).map_err(|inner| DecodeError::Utf8 { inner })?;\n+ let rcstr = RcStr::from_deserialized(s);\n+ decoder.reader().consume(len);\n+ Ok(rcstr)\n+ } else {\n+ unreachable!(\n+ \"RcStr::decode expected TurboBincodeReader, but was called with a {} reader\",\n+ std::any::type_name::<D::R>(),\n+ )\n+ }\n }\n }\n \n@@ -433,8 +502,46 @@ pub const fn make_const_prehashed_string(text: &'static str) -> PrehashedString\n }\n }\n \n+// Re-export inventory so the rcstr! macro can reference it via $crate::inventory\n+#[doc(hidden)]\n+pub use inventory;\n+\n+/// Wrapper for collecting `rcstr!` static constants via `inventory`.\n+#[doc(hidden)]\n+pub struct StaticRcStr(pub &'static PrehashedString);\n+\n+inventory::collect!(StaticRcStr);\n+\n+/// Read-only lookup table mapping precomputed hash -> static PrehashedString.\n+/// Built once on first access from all `rcstr!` constants collected by `inventory`.\n+///\n+/// Multiple `rcstr!` calls with the same string content will each submit to\n+/// inventory, but we deduplicate by content here so only one entry per unique\n+/// string is stored.\n+static STATIC_TABLE: LazyLock<\n+ HashMap<u64, SmallVec<[&'static PrehashedString; 1]>, FxBuildHasher>,\n+> = LazyLock::new(|| {\n+ let mut map: HashMap<u64, SmallVec<[&'static PrehashedString; 1]>, FxBuildHasher> =\n+ HashMap::with_hasher(FxBuildHasher);\n+ for StaticRcStr(phs) in inventory::iter::<StaticRcStr> {\n+ let entries = map.entry(phs.hash).or_default();\n+ // Deduplicate: skip if an entry with the same string content exists\n+ // Mostly linkers will merge static strings but this isn't guaranteed so we cannot just rely\n+ // on pointer equality.\n+ if !entries\n+ .iter()\n+ .any(|e| e.value.as_str() == phs.value.as_str())\n+ {\n+ entries.push(phs);\n+ }\n+ }\n+ map.shrink_to_fit(); // this map will never change again\n+ map\n+});\n+\n /// Create an rcstr from a string literal.\n-/// allocates the RcStr inline when possible otherwise uses a `LazyLock` to manage the allocation.\n+/// Allocates the RcStr inline when possible, otherwise uses a static `PrehashedString`. In either\n+/// case this is a compile time constant\n #[macro_export]\n macro_rules! rcstr {\n ($s:expr) => {{\n@@ -447,6 +554,8 @@ macro_rules! rcstr {\n // Allocate static storage for the PrehashedString\n static RCSTR_STORAGE: $crate::PrehashedString =\n $crate::make_const_prehashed_string($s);\n+ // Register with inventory so deserialization can find this static\n+ $crate::inventory::submit!($crate::StaticRcStr(&RCSTR_STORAGE));\n // This basically just tags a bit onto the raw pointer and wraps it in an RcStr\n // should be fast enough to do every time.\n $crate::from_static(&RCSTR_STORAGE)\n@@ -624,4 +733,33 @@ mod tests {\n }\n }\n }\n+\n+ #[test]\n+ fn test_bincode_roundtrip() {\n+ use turbo_bincode::{turbo_bincode_decode, turbo_bincode_encode};\n+\n+ // Test inline string\n+ let short = RcStr::from(\"hi\");\n+ let encoded = turbo_bincode_encode(&short).unwrap();\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\n+ assert_eq!(decoded, short);\n+ assert_eq!(decoded.tag(), INLINE_TAG);\n+\n+ // Test dynamic string (no static match)\n+ let long = RcStr::from(\"bincode_roundtrip: no matching rcstr constant\");\n+ let encoded = turbo_bincode_encode(&long).unwrap();\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\n+ assert_eq!(decoded, long);\n+ assert_eq!(decoded.tag(), DYNAMIC_TAG);\n+\n+ // Test static dedup via decode\n+ const STATIC_STR: &str = \"bincode_roundtrip: a static constant for testing\";\n+ let _register = rcstr!(STATIC_STR);\n+ let original = RcStr::from(STATIC_STR); // DYNAMIC since from() doesn't check\n+ let encoded = turbo_bincode_encode(&original).unwrap();\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\n+ assert_eq!(decoded.as_str(), STATIC_STR);\n+ // Decoded via peek_read path should find the static constant\n+ assert_eq!(decoded.tag(), STATIC_TAG);\n+ }\n }","additions":144,"deletions":6},{"filename":"turbopack/crates/turbo-tasks-backend/src/backend/mod.rs","patch":"@@ -55,10 +55,10 @@ use crate::{\n backend::{\n operation::{\n AggregationUpdateJob, AggregationUpdateQueue, ChildExecuteContext,\n- CleanupOldEdgesOperation, ComputeDirtyAndCleanUpdate, ConnectChildOperation,\n- ExecuteContext, ExecuteContextImpl, LeafDistanceUpdateQueue, Operation, OutdatedEdge,\n- TaskGuard, TaskType, connect_children, get_aggregation_number, get_uppers,\n- is_root_node, make_task_dirty_internal, prepare_new_children,\n+ CleanupOldEdgesOperation, ConnectChildOperation, ExecuteContext, ExecuteContextImpl,\n+ LeafDistanceUpdateQueue, Operation, OutdatedEdge, TaskGuard, TaskType,\n+ connect_children, get_aggregation_number, get_uppers, is_root_node,\n+ make_task_dirty_internal, prepare_new_children,\n },\n storage::Storage,\n storage_schema::{TaskStorage, TaskStorageAccessors},\n@@ -955,7 +955,13 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n }\n \n // Cell should exist, but data was dropped or is not serializable. We need to recompute the\n- // task the get the cell content.\n+ // task to get the cell content.\n+\n+ // Bail early if the task was cancelled — no point in registering a listener\n+ // on a task that won't execute again.\n+ if is_cancelled {\n+ bail!(\"{} was canceled\", task.get_task_description());\n+ }\n \n // Listen to the cell and potentially schedule the task\n let (listener, new_listener) = self.listen_to_cell(&mut task, task_id, &reader_task, cell);\n@@ -971,11 +977,6 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n )\n .entered();\n \n- // Schedule the task, if not already scheduled\n- if is_cancelled {\n- bail!(\"{} was canceled\", task.get_task_description());\n- }\n-\n let _ = task.add_scheduled(\n TaskExecutionReason::CellNotAvailable,\n EventDescription::new(|| task.get_task_desc_fn()),\n@@ -1857,7 +1858,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n turbo_tasks: &dyn TurboTasksBackendApi<TurboTasksBackend<B>>,\n ) {\n let mut ctx = self.execute_context(turbo_tasks);\n- let mut task = ctx.task(task_id, TaskDataCategory::Data);\n+ let mut task = ctx.task(task_id, TaskDataCategory::All);\n if let Some(in_progress) = task.take_in_progress() {\n match in_progress {\n InProgressState::Scheduled {\n@@ -1870,8 +1871,35 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n InProgressState::Canceled => {}\n }\n }\n+ // Notify any readers waiting on in-progress cells so their listeners\n+ // resolve and foreground jobs can finish (prevents stop_and_wait hang).\n+ let in_progress_cells = task.take_in_progress_cells();\n+ if let Some(ref cells) = in_progress_cells {\n+ for state in cells.values() {\n+ state.event.notify(usize::MAX);\n+ }\n+ }\n+\n+ // Mark the cancelled task as session-dependent dirty so it will be re-executed\n+ // in the next session. Without this, any reader that encounters the cancelled task\n+ // records an error in its output. That error is persisted and would poison\n+ // subsequent builds. By marking the task session-dependent dirty, the next build\n+ // re-executes it, which invalidates dependents and corrects the stale errors.\n+ let data_update = if self.should_track_dependencies() && !task_id.is_transient() {\n+ task.update_dirty_state(Some(Dirtyness::SessionDependent))\n+ } else {\n+ None\n+ };\n+\n let old = task.set_in_progress(InProgressState::Canceled);\n debug_assert!(old.is_none(), \"InProgress already exists\");\n+ drop(task);\n+\n+ if let Some(data_update) = data_update {\n+ AggregationUpdateQueue::run(data_update, &mut ctx);\n+ }\n+\n+ drop(in_progress_cells);\n }\n \n fn try_start_task_execution(\n@@ -2188,23 +2216,33 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n }\n \n // handle cell counters: update max index and remove cells that are no longer used\n- let old_counters: FxHashMap<_, _> = task\n- .iter_cell_type_max_index()\n- .map(|(&k, &v)| (k, v))\n- .collect();\n- let mut counters_to_remove = old_counters.clone();\n-\n- for (&cell_type, &max_index) in cell_counters.iter() {\n- if let Some(old_max_index) = counters_to_remove.remove(&cell_type) {\n- if old_max_index != max_index {\n+ // On error, skip this update: the task may have failed before creating all cells it\n+ // normally creates, so cell_counters is incomplete. Clearing cell_type_max_index entries\n+ // based on partial counters would cause \"cell no longer exists\" errors for tasks that\n+ // still hold dependencies on those cells. The old cell data is preserved on error\n+ // (see task_execution_completed_cleanup), so keeping cell_type_max_index consistent with\n+ // that data is correct.\n+ // NOTE: This must stay in sync with task_execution_completed_cleanup, which similarly\n+ // skips cell data removal on error.\n+ if result.is_ok() {\n+ let old_counters: FxHashMap<_, _> = task\n+ .iter_cell_type_max_index()\n+ .map(|(&k, &v)| (k, v))\n+ .collect();\n+ let mut counters_to_remove = old_counters.clone();\n+\n+ for (&cell_type, &max_index) in cell_counters.iter() {\n+ if let Some(old_max_index) = counters_to_remove.remove(&cell_type) {\n+ if old_max_index != max_index {\n+ task.insert_cell_type_max_index(cell_type, max_index);\n+ }\n+ } else {\n task.insert_cell_type_max_index(cell_type, max_index);\n }\n- } else {\n- task.insert_cell_type_max_index(cell_type, max_index);\n }\n- }\n- for (cell_type, _) in counters_to_remove {\n- task.remove_cell_type_max_index(&cell_type);\n+ for (cell_type, _) in counters_to_remove {\n+ task.remove_cell_type_max_index(&cell_type);\n+ }\n }\n \n let mut queue = AggregationUpdateQueue::new();\n@@ -2605,83 +2643,16 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n }\n }\n \n- // Grab the old dirty state\n- let old_dirtyness = task.get_dirty().cloned();\n- let (old_self_dirty, old_current_session_self_clean) = match old_dirtyness {\n- None => (false, false),\n- Some(Dirtyness::Dirty(_)) => (true, false),\n- Some(Dirtyness::SessionDependent) => {\n- let clean_in_current_session = task.current_session_clean();\n- (true, clean_in_current_session)\n- }\n- };\n-\n- // Compute the new dirty state\n+ // Compute and apply the new dirty state, propagating to aggregating ancestors\n let session_dependent = task.is_session_dependent();\n- let (new_dirtyness, new_self_dirty, new_current_session_self_clean) = if session_dependent {\n- (Some(Dirtyness::SessionDependent), true, true)\n- } else {\n- (None, false, false)\n- };\n-\n- // Update the dirty state\n- let dirty_changed = old_dirtyness != new_dirtyness;\n- if dirty_changed {\n- if let Some(value) = new_dirtyness {\n- task.set_dirty(value);\n- } else if old_dirtyness.is_some() {\n- task.take_dirty();\n- }\n- }\n- if old_current_session_self_clean != new_current_session_self_clean {\n- if new_current_session_self_clean {\n- task.set_current_session_clean(true);\n- } else if old_current_session_self_clean {\n- task.set_current_session_clean(false);\n- }\n- }\n-\n- // Propagate dirtyness changes\n- let data_update = if old_self_dirty != new_self_dirty\n- || old_current_session_self_clean != new_current_session_self_clean\n- {\n- let dirty_container_count = task\n- .get_aggregated_dirty_container_count()\n- .cloned()\n- .unwrap_or_default();\n- let current_session_clean_container_count = task\n- .get_aggregated_current_session_clean_container_count()\n- .copied()\n- .unwrap_or_default();\n- let result = ComputeDirtyAndCleanUpdate {\n- old_dirty_container_count: dirty_container_count,\n- new_dirty_container_count: dirty_container_count,\n- old_current_session_clean_container_count: current_session_clean_container_count,\n- new_current_session_clean_container_count: current_session_clean_container_count,\n- old_self_dirty,\n- new_self_dirty,\n- old_current_session_self_clean,\n- new_current_session_self_clean,\n- }\n- .compute();\n- if result.dirty_count_update - result.current_session_clean_update < 0 {\n- // The task is clean now\n- if let Some(activeness_state) = task.get_activeness_mut() {\n- activeness_state.all_clean_event.notify(usize::MAX);\n- activeness_state.unset_active_until_clean();\n- if activeness_state.is_empty() {\n- task.take_activeness();\n- }\n- }\n- }\n- result\n- .aggregated_update(task_id)\n- .and_then(|aggregated_update| {\n- AggregationUpdateJob::data_update(&mut task, aggregated_update)\n- })\n+ let new_dirtyness = if session_dependent {\n+ Some(Dirtyness::SessionDependent)\n } else {\n None\n };\n+ #[cfg(feature = \"verify_determinism\")]\n+ let dirty_changed = task.get_dirty().cloned() != new_dirtyness;\n+ let data_update = task.update_dirty_state(new_dirtyness);\n \n #[cfg(feature = \"verify_determinism\")]\n let reschedule =\n@@ -2724,6 +2695,8 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n // An error is potentially caused by a eventual consistency, so we avoid updating cells\n // after an error as it is likely transient and we want to keep the dependent tasks\n // clean to avoid re-executions.\n+ // NOTE: This must stay in sync with task_execution_completed_prepare, which similarly\n+ // skips cell_type_max_index updates on error.\n if !is_error {\n // Remove no longer existing cells and\n // find all outdated data items (removed cells, outdated edges)","additions":71,"deletions":98},{"filename":"turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs","patch":"@@ -18,6 +18,7 @@ use turbo_tasks::{\n TurboTasksCallApi, TypedSharedReference, backend::CachedTaskType,\n };\n \n+use self::aggregation_update::ComputeDirtyAndCleanUpdate;\n use crate::{\n backend::{\n EventDescription, OperationGuard, TaskDataCategory, TurboTasksBackend,\n@@ -757,6 +758,77 @@ pub trait TaskGuard: Debug + TaskStorageAccessors {\n Some(Dirtyness::SessionDependent) => (true, self.current_session_clean()),\n }\n }\n+ /// Update the task's dirty state to `new_dirtyness`, applying the change to stored fields,\n+ /// computing the aggregated propagation update, and firing the `all_clean_event` if the task\n+ /// transitioned to clean.\n+ ///\n+ /// Returns an optional `AggregationUpdateJob` that the caller must run via\n+ /// `AggregationUpdateQueue::run` to propagate the change to aggregating ancestors.\n+ fn update_dirty_state(\n+ &mut self,\n+ new_dirtyness: Option<Dirtyness>,\n+ ) -> Option<AggregationUpdateJob>\n+ where\n+ Self: Sized,\n+ {\n+ let task_id = self.id();\n+ let old_dirtyness = self.get_dirty().cloned();\n+ let (old_self_dirty, old_current_session_self_clean) = self.dirty_state();\n+ let (new_self_dirty, new_current_session_self_clean) = match new_dirtyness {\n+ None => (false, false),\n+ Some(Dirtyness::Dirty(_)) => (true, false),\n+ Some(Dirtyness::SessionDependent) => (true, true),\n+ };\n+ if old_dirtyness != new_dirtyness {\n+ if let Some(value) = new_dirtyness {\n+ self.set_dirty(value);\n+ } else {\n+ self.take_dirty();\n+ }\n+ }\n+ if old_current_session_self_clean != new_current_session_self_clean {\n+ self.set_current_session_clean(new_current_session_self_clean);\n+ }\n+ if old_self_dirty == new_self_dirty\n+ && old_current_session_self_clean == new_current_session_self_clean\n+ {\n+ return None;\n+ }\n+ let dirty_container_count = self\n+ .get_aggregated_dirty_container_count()\n+ .cloned()\n+ .unwrap_or_default();\n+ let current_session_clean_container_count = self\n+ .get_aggregated_current_session_clean_container_count()\n+ .copied()\n+ .unwrap_or_default();\n+ let result = ComputeDirtyAndCleanUpdate {\n+ old_dirty_container_count: dirty_container_count,\n+ new_dirty_container_count: dirty_container_count,\n+ old_current_session_clean_container_count: current_session_clean_container_count,\n+ new_current_session_clean_container_count: current_session_clean_container_count,\n+ old_self_dirty,\n+ new_self_dirty,\n+ old_current_session_self_clean,\n+ new_current_session_self_clean,\n+ }\n+ .compute();\n+ // Fire the all_clean_event if the task transitioned to clean\n+ if result.dirty_count_update - result.current_session_clean_update < 0\n+ && let Some(activeness_state) = self.get_activeness_mut()\n+ {\n+ activeness_state.all_clean_event.notify(usize::MAX);\n+ activeness_state.unset_active_until_clean();\n+ if activeness_state.is_empty() {\n+ self.take_activeness();\n+ }\n+ }\n+ result\n+ .aggregated_update(task_id)\n+ .and_then(|aggregated_update| {\n+ AggregationUpdateJob::data_update(self, aggregated_update)\n+ })\n+ }\n fn dirty_containers(&self) -> impl Iterator<Item = TaskId> {\n self.dirty_containers_with_count()\n .map(|(task_id, _)| task_id)\n@@ -1102,8 +1174,8 @@ impl_operation!(LeafDistanceUpdate leaf_distance_update::LeafDistanceUpdateQueue\n pub use self::invalidate::TaskDirtyCause;\n pub use self::{\n aggregation_update::{\n- AggregatedDataUpdate, AggregationUpdateJob, ComputeDirtyAndCleanUpdate,\n- get_aggregation_number, get_uppers, is_aggregating_node, is_root_node,\n+ AggregatedDataUpdate, AggregationUpdateJob, get_aggregation_number, get_uppers,\n+ is_aggregating_node, is_root_node,\n },\n cleanup_old_edges::OutdatedEdge,\n connect_children::connect_children,","additions":74,"deletions":2}],"string":"[\n {\n \"filename\": \".config/eslintignore.mjs\",\n \"patch\": \"@@ -47,6 +47,7 @@ export default globalIgnores([\\n 'examples/with-typescript-graphql/lib/gql/',\\n 'test/development/basic/hmr/components/parse-error.js',\\n 'test/development/mcp-server/fixtures/default-template/app/build-error/page.tsx',\\n+ 'test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx',\\n 'test/production/debug-build-path/fixtures/with-compile-error/app/broken/page.tsx',\\n 'packages/next-swc/native/index.d.ts',\\n 'packages/next-swc/docs/assets/**/*',\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \".prettierignore\",\n \"patch\": \"@@ -59,6 +59,7 @@ test/e2e/app-dir/server-source-maps/fixtures/default/internal-pkg/ignored.js\\n test/e2e/app-dir/server-source-maps/fixtures/default/internal-pkg/sourcemapped.js\\n test/e2e/app-dir/server-source-maps/fixtures/default/external-pkg/sourcemapped.js\\n test/development/mcp-server/fixtures/default-template/app/build-error/page.tsx\\n+test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx\\n # Tested against auto-generated content that isn't formatted\\n test/integration/typescript-app-type-declarations/next-env.strictRouteTypes.d.ts\\n \",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"Cargo.lock\",\n \"patch\": \"@@ -3638,9 +3638,9 @@ dependencies = [\\n \\n [[package]]\\n name = \\\"js-sys\\\"\\n-version = \\\"0.3.77\\\"\\n+version = \\\"0.3.91\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"1cfaf33c695fc6e08064efbc1f72ec937429614f25eef83af942d0e227c3a28f\\\"\\n+checksum = \\\"b49715b7073f385ba4bc528e5747d02e66cb39c6146efb66b781f131f0fb399c\\\"\\n dependencies = [\\n \\\"once_cell\\\",\\n \\\"wasm-bindgen\\\",\\n@@ -9487,13 +9487,17 @@ dependencies = [\\n \\\"bincode 2.0.1\\\",\\n \\\"bytes-str\\\",\\n \\\"codspeed-criterion-compat\\\",\\n+ \\\"inventory\\\",\\n \\\"napi\\\",\\n \\\"new_debug_unreachable\\\",\\n \\\"rustc-hash 2.1.1\\\",\\n \\\"serde\\\",\\n \\\"shrink-to-fit\\\",\\n+ \\\"smallvec\\\",\\n \\\"triomphe 0.1.12\\\",\\n+ \\\"turbo-bincode\\\",\\n \\\"turbo-tasks-hash\\\",\\n+ \\\"unty\\\",\\n ]\\n \\n [[package]]\\n@@ -11010,37 +11014,25 @@ dependencies = [\\n \\n [[package]]\\n name = \\\"wasm-bindgen\\\"\\n-version = \\\"0.2.100\\\"\\n+version = \\\"0.2.114\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"1edc8929d7499fc4e8f0be2262a241556cfc54a0bea223790e71446f2aab1ef5\\\"\\n+checksum = \\\"6532f9a5c1ece3798cb1c2cfdba640b9b3ba884f5db45973a6f442510a87d38e\\\"\\n dependencies = [\\n \\\"cfg-if\\\",\\n \\\"once_cell\\\",\\n \\\"rustversion\\\",\\n \\\"wasm-bindgen-macro\\\",\\n-]\\n-\\n-[[package]]\\n-name = \\\"wasm-bindgen-backend\\\"\\n-version = \\\"0.2.100\\\"\\n-source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"2f0a0651a5c2bc21487bde11ee802ccaf4c51935d0d3d42a6101f98161700bc6\\\"\\n-dependencies = [\\n- \\\"bumpalo\\\",\\n- \\\"log\\\",\\n- \\\"proc-macro2\\\",\\n- \\\"quote\\\",\\n- \\\"syn 2.0.104\\\",\\n \\\"wasm-bindgen-shared\\\",\\n ]\\n \\n [[package]]\\n name = \\\"wasm-bindgen-futures\\\"\\n-version = \\\"0.4.50\\\"\\n+version = \\\"0.4.64\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"555d470ec0bc3bb57890405e5d4322cc9ea83cebb085523ced7be4144dac1e61\\\"\\n+checksum = \\\"e9c5522b3a28661442748e09d40924dfb9ca614b21c00d3fd135720e48b67db8\\\"\\n dependencies = [\\n \\\"cfg-if\\\",\\n+ \\\"futures-util\\\",\\n \\\"js-sys\\\",\\n \\\"once_cell\\\",\\n \\\"wasm-bindgen\\\",\\n@@ -11049,32 +11041,32 @@ dependencies = [\\n \\n [[package]]\\n name = \\\"wasm-bindgen-macro\\\"\\n-version = \\\"0.2.100\\\"\\n+version = \\\"0.2.114\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"7fe63fc6d09ed3792bd0897b314f53de8e16568c2b3f7982f468c0bf9bd0b407\\\"\\n+checksum = \\\"18a2d50fcf105fb33bb15f00e7a77b772945a2ee45dcf454961fd843e74c18e6\\\"\\n dependencies = [\\n \\\"quote\\\",\\n \\\"wasm-bindgen-macro-support\\\",\\n ]\\n \\n [[package]]\\n name = \\\"wasm-bindgen-macro-support\\\"\\n-version = \\\"0.2.100\\\"\\n+version = \\\"0.2.114\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"8ae87ea40c9f689fc23f209965b6fb8a99ad69aeeb0231408be24920604395de\\\"\\n+checksum = \\\"03ce4caeaac547cdf713d280eda22a730824dd11e6b8c3ca9e42247b25c631e3\\\"\\n dependencies = [\\n+ \\\"bumpalo\\\",\\n \\\"proc-macro2\\\",\\n \\\"quote\\\",\\n \\\"syn 2.0.104\\\",\\n- \\\"wasm-bindgen-backend\\\",\\n \\\"wasm-bindgen-shared\\\",\\n ]\\n \\n [[package]]\\n name = \\\"wasm-bindgen-shared\\\"\\n-version = \\\"0.2.100\\\"\\n+version = \\\"0.2.114\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"1a05d73b933a847d6cccdda8f838a22ff101ad9bf93e33684f39c1f5f0eece3d\\\"\\n+checksum = \\\"75a326b8c223ee17883a4251907455a2431acc2791c98c26279376490c378c16\\\"\\n dependencies = [\\n \\\"unicode-ident\\\",\\n ]\\n@@ -11494,9 +11486,9 @@ dependencies = [\\n \\n [[package]]\\n name = \\\"web-sys\\\"\\n-version = \\\"0.3.77\\\"\\n+version = \\\"0.3.91\\\"\\n source = \\\"registry+https://github.com/rust-lang/crates.io-index\\\"\\n-checksum = \\\"33b6dd2ef9186f1f2072e409e99cd22a975331a6b3591b12c764e0e55c60d5d2\\\"\\n+checksum = \\\"854ba17bb104abfb26ba36da9729addc7ce7f06f5c0f90f3c391f8461cca21f9\\\"\\n dependencies = [\\n \\\"js-sys\\\",\\n \\\"wasm-bindgen\\\",\",\n \"additions\": 20,\n \"deletions\": 28\n },\n {\n \"filename\": \"crates/next-napi-bindings/src/next_api/project.rs\",\n \"patch\": \"@@ -2508,6 +2508,74 @@ pub async fn project_write_analyze_data(\\n })\\n }\\n \\n+#[turbo_tasks::function(operation)]\\n+async fn get_all_compilation_issues_inner_operation(\\n+ container: ResolvedVc<ProjectContainer>,\\n+) -> Result<Vc<()>> {\\n+ let project = container.project();\\n+ // Build the module graph for every endpoint without chunking, code gen, or disk emission.\\n+ // We iterate endpoints rather than calling project.whole_app_module_graphs() because the\\n+ // latter calls drop_issues() in development mode (to avoid duplicate per-route HMR noise).\\n+ // Per-endpoint module_graphs() calls are not subject to that suppression, so issues like\\n+ // missing modules and transform errors are properly collected as collectables here.\\n+ let endpoint_groups = project.get_all_endpoint_groups(false).await?;\\n+ endpoint_groups\\n+ .iter()\\n+ .map(|(_, endpoint_group)| async move {\\n+ endpoint_group.module_graphs().as_side_effect().await\\n+ })\\n+ .try_join()\\n+ .await?;\\n+ Ok(Vc::cell(()))\\n+}\\n+\\n+#[turbo_tasks::function(operation)]\\n+async fn get_all_compilation_issues_operation(\\n+ container: ResolvedVc<ProjectContainer>,\\n+) -> Result<Vc<OperationResult>> {\\n+ let inner_op = get_all_compilation_issues_inner_operation(container);\\n+ let filter = issue_filter_from_container(container);\\n+ let (_, issues, diagnostics, effects) =\\n+ strongly_consistent_catch_collectables(inner_op, filter).await?;\\n+ Ok(OperationResult {\\n+ issues,\\n+ diagnostics,\\n+ effects,\\n+ }\\n+ .cell())\\n+}\\n+\\n+#[tracing::instrument(level = \\\"info\\\", name = \\\"get all compilation issues\\\", skip_all)]\\n+#[napi]\\n+pub async fn project_get_all_compilation_issues(\\n+ #[napi(ts_arg_type = \\\"{ __napiType: \\\\\\\"Project\\\\\\\" }\\\")] project: External<ProjectInstance>,\\n+) -> napi::Result<TurbopackResult<()>> {\\n+ let container = project.container;\\n+ let (issues, diagnostics) = project\\n+ .turbopack_ctx\\n+ .turbo_tasks()\\n+ .run_once(async move {\\n+ let op = get_all_compilation_issues_operation(container);\\n+ let OperationResult {\\n+ issues,\\n+ diagnostics,\\n+ effects: _,\\n+ } = &*op.read_strongly_consistent().await?;\\n+ Ok((issues.clone(), diagnostics.clone()))\\n+ })\\n+ .await\\n+ .map_err(|e| napi::Error::from_reason(PrettyPrintError(&e).to_string()))?;\\n+\\n+ Ok(TurbopackResult {\\n+ result: (),\\n+ issues: issues.iter().map(|i| NapiIssue::from(&**i)).collect(),\\n+ diagnostics: diagnostics\\n+ .iter()\\n+ .map(|d| NapiDiagnostic::from(d))\\n+ .collect(),\\n+ })\\n+}\\n+\\n /// Opens the Turbopack persistent cache database at the given path and performs a full compaction.\\n ///\\n /// The `path` should point to the `<distDir>/cache/turbopack` directory.\",\n \"additions\": 68,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/EVAL.ts\",\n \"patch\": \"@@ -0,0 +1,131 @@\\n+/**\\n+ * View Transitions\\n+ *\\n+ * Tests whether the agent correctly adds React View Transitions to a Next.js\\n+ * product gallery app covering shared element morphs, directional navigation,\\n+ * Suspense reveal animations, and accessibility.\\n+ *\\n+ * Tricky because agents may:\\n+ * - Not know about the experimental.viewTransition flag in next.config\\n+ * - Try to call document.startViewTransition manually instead of using\\n+ * React's <ViewTransition> component\\n+ * - Import ViewTransition from a third-party library instead of 'react'\\n+ * - Not know about the transitionTypes prop on next/link\\n+ * - Forget default=\\\"none\\\" causing every transition to cross-fade everything\\n+ * - Skip prefers-reduced-motion (React does NOT disable animations automatically)\\n+ */\\n+\\n+import { expect, test } from 'vitest'\\n+import { readFileSync, existsSync, readdirSync } from 'fs'\\n+import { join } from 'path'\\n+\\n+const IGNORE_DIRS = new Set([\\n+ 'node_modules',\\n+ '.next',\\n+ '.git',\\n+ 'dist',\\n+ 'build',\\n+ 'coverage',\\n+])\\n+\\n+function findFiles(dir: string, ext: string): string[] {\\n+ const results: string[] = []\\n+ const base = join(process.cwd(), dir)\\n+ if (!existsSync(base)) return results\\n+\\n+ function walk(d: string) {\\n+ for (const entry of readdirSync(d, { withFileTypes: true })) {\\n+ if (IGNORE_DIRS.has(entry.name)) continue\\n+ const full = join(d, entry.name)\\n+ if (entry.isDirectory()) walk(full)\\n+ else if (entry.name.endsWith(ext)) results.push(full)\\n+ }\\n+ }\\n+ walk(base)\\n+ return results\\n+}\\n+\\n+function stripComments(source: string): string {\\n+ return source.replace(/\\\\/\\\\*[\\\\s\\\\S]*?\\\\*\\\\//g, '').replace(/\\\\/\\\\/[^\\\\r\\\\n]*/g, '')\\n+}\\n+\\n+const SOURCE_EXTS = ['.tsx', '.ts', '.jsx', '.js']\\n+const SOURCE_DIRS = ['app', 'lib', 'components', 'src']\\n+\\n+function readAllSourceFiles(): string {\\n+ const files = SOURCE_DIRS.flatMap((dir) =>\\n+ SOURCE_EXTS.flatMap((ext) => findFiles(dir, ext))\\n+ )\\n+ return files\\n+ .map((f) => stripComments(readFileSync(f, 'utf-8')))\\n+ .join('\\\\n---FILE---\\\\n')\\n+}\\n+\\n+function readAllCssFiles(): string {\\n+ const files = [\\n+ ...findFiles('app', '.css'),\\n+ ...findFiles('src', '.css'),\\n+ ...findFiles('.', '.css').filter(\\n+ (f) => !f.includes('node_modules') && !f.includes('.next')\\n+ ),\\n+ ]\\n+ const unique = [...new Set(files)]\\n+ return unique.map((f) => readFileSync(f, 'utf-8')).join('\\\\n')\\n+}\\n+\\n+test('next.config enables viewTransition', () => {\\n+ const configPath = existsSync(join(process.cwd(), 'next.config.ts'))\\n+ ? 'next.config.ts'\\n+ : 'next.config.js'\\n+ const content = stripComments(\\n+ readFileSync(join(process.cwd(), configPath), 'utf-8')\\n+ )\\n+\\n+ expect(content).toMatch(/viewTransition\\\\s*:\\\\s*true/)\\n+})\\n+\\n+test('ViewTransition is imported from react', () => {\\n+ const allSource = readAllSourceFiles()\\n+\\n+ expect(allSource).toMatch(\\n+ /import\\\\s+\\\\{[^}]*ViewTransition[^}]*\\\\}\\\\s+from\\\\s+['\\\"]react['\\\"]/\\n+ )\\n+})\\n+\\n+test('Shared element transitions use named ViewTransition', () => {\\n+ const allSource = readAllSourceFiles()\\n+\\n+ const nameMatches = allSource.match(/<ViewTransition[^>]*\\\\bname\\\\s*=/g)\\n+ expect(nameMatches).not.toBeNull()\\n+ expect(nameMatches!.length).toBeGreaterThanOrEqual(2)\\n+})\\n+\\n+test('Link uses transitionTypes for directional navigation', () => {\\n+ const allSource = readAllSourceFiles()\\n+\\n+ expect(allSource).toMatch(/transitionTypes/)\\n+})\\n+\\n+test('Suspense content uses ViewTransition with enter or exit', () => {\\n+ const allSource = readAllSourceFiles()\\n+\\n+ expect(allSource).toMatch(/<ViewTransition[^>]*\\\\b(enter|exit)\\\\s*=/)\\n+})\\n+\\n+test('default=\\\"none\\\" prevents unintended animations', () => {\\n+ const allSource = readAllSourceFiles()\\n+\\n+ expect(allSource).toMatch(/default\\\\s*=\\\\s*[\\\"']none[\\\"']/)\\n+})\\n+\\n+test('CSS handles prefers-reduced-motion', () => {\\n+ const allCss = readAllCssFiles()\\n+\\n+ expect(allCss).toMatch(/prefers-reduced-motion/)\\n+})\\n+\\n+test('CSS defines view transition animations', () => {\\n+ const allCss = readAllCssFiles()\\n+\\n+ expect(allCss).toMatch(/::view-transition-(old|new|group)/)\\n+})\",\n \"additions\": 131,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/PROMPT.md\",\n \"patch\": \"@@ -0,0 +1 @@\\n+Add view transitions to this product gallery app. When navigating from the grid to a product detail page, the product image should smoothly morph between the thumbnail and the large detail image using a shared element transition. Page navigations should slide directionally. Suspense loading states should transition smoothly from skeleton to content. All animations must respect the user's prefers-reduced-motion preference.\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/ProductGrid.tsx\",\n \"patch\": \"@@ -0,0 +1,23 @@\\n+import Link from 'next/link'\\n+import { products } from '@/lib/products'\\n+\\n+export function ProductGrid() {\\n+ return (\\n+ <div className=\\\"product-grid\\\">\\n+ {products.map((product) => (\\n+ <Link\\n+ key={product.slug}\\n+ href={`/product/${product.slug}`}\\n+ className=\\\"product-card\\\"\\n+ >\\n+ <div\\n+ className=\\\"product-image\\\"\\n+ style={{ backgroundColor: product.color }}\\n+ />\\n+ <h2>{product.name}</h2>\\n+ <p>${product.price}</p>\\n+ </Link>\\n+ ))}\\n+ </div>\\n+ )\\n+}\",\n \"additions\": 23,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/ProductSkeleton.tsx\",\n \"patch\": \"@@ -0,0 +1,13 @@\\n+export function ProductGridSkeleton() {\\n+ return (\\n+ <div className=\\\"product-grid\\\">\\n+ {Array.from({ length: 4 }).map((_, i) => (\\n+ <div key={i} className=\\\"product-card\\\">\\n+ <div className=\\\"product-image skeleton-image\\\" />\\n+ <div className=\\\"skeleton-text\\\" />\\n+ <div className=\\\"skeleton-text short\\\" />\\n+ </div>\\n+ ))}\\n+ </div>\\n+ )\\n+}\",\n \"additions\": 13,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/globals.css\",\n \"patch\": \"@@ -0,0 +1,121 @@\\n+* {\\n+ margin: 0;\\n+ padding: 0;\\n+ box-sizing: border-box;\\n+}\\n+\\n+body {\\n+ font-family:\\n+ system-ui,\\n+ -apple-system,\\n+ sans-serif;\\n+ color: #111;\\n+ background: #fafafa;\\n+}\\n+\\n+main {\\n+ max-width: 1200px;\\n+ margin: 0 auto;\\n+ padding: 2rem;\\n+}\\n+\\n+h1 {\\n+ margin-bottom: 1.5rem;\\n+}\\n+\\n+.product-grid {\\n+ display: grid;\\n+ grid-template-columns: repeat(auto-fill, minmax(250px, 1fr));\\n+ gap: 1.5rem;\\n+}\\n+\\n+.product-card {\\n+ border-radius: 12px;\\n+ overflow: hidden;\\n+ background: white;\\n+ box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);\\n+ text-decoration: none;\\n+ color: inherit;\\n+}\\n+\\n+.product-card h2 {\\n+ padding: 0.75rem 1rem 0;\\n+ font-size: 1rem;\\n+}\\n+\\n+.product-card p {\\n+ padding: 0.25rem 1rem 1rem;\\n+ color: #666;\\n+}\\n+\\n+.product-image {\\n+ width: 100%;\\n+ aspect-ratio: 4 / 3;\\n+}\\n+\\n+.product-detail {\\n+ display: grid;\\n+ grid-template-columns: 1fr 1fr;\\n+ gap: 2rem;\\n+ align-items: start;\\n+}\\n+\\n+.product-hero {\\n+ width: 100%;\\n+ aspect-ratio: 1;\\n+ border-radius: 12px;\\n+}\\n+\\n+.product-info h1 {\\n+ font-size: 2rem;\\n+}\\n+\\n+.product-price {\\n+ font-size: 1.5rem;\\n+ font-weight: 600;\\n+ margin: 0.5rem 0;\\n+}\\n+\\n+.product-description {\\n+ color: #666;\\n+ line-height: 1.6;\\n+}\\n+\\n+.back-link {\\n+ display: inline-block;\\n+ margin-bottom: 1.5rem;\\n+ color: #666;\\n+ text-decoration: none;\\n+}\\n+\\n+.skeleton-image {\\n+ background: #e5e5e5;\\n+ animation: pulse 1.5s ease-in-out infinite;\\n+}\\n+\\n+.skeleton-text {\\n+ height: 1rem;\\n+ background: #e5e5e5;\\n+ border-radius: 4px;\\n+ margin: 0.5rem 1rem;\\n+ animation: pulse 1.5s ease-in-out infinite;\\n+}\\n+\\n+.skeleton-text.short {\\n+ width: 60%;\\n+}\\n+\\n+.skeleton-text.large {\\n+ height: 2rem;\\n+ width: 70%;\\n+}\\n+\\n+@keyframes pulse {\\n+ 0%,\\n+ 100% {\\n+ opacity: 1;\\n+ }\\n+ 50% {\\n+ opacity: 0.5;\\n+ }\\n+}\",\n \"additions\": 121,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/layout.tsx\",\n \"patch\": \"@@ -0,0 +1,19 @@\\n+import type { Metadata } from 'next'\\n+import './globals.css'\\n+\\n+export const metadata: Metadata = {\\n+ title: 'Product Gallery',\\n+ description: 'A simple product gallery',\\n+}\\n+\\n+export default function RootLayout({\\n+ children,\\n+}: Readonly<{\\n+ children: React.ReactNode\\n+}>) {\\n+ return (\\n+ <html lang=\\\"en\\\">\\n+ <body>{children}</body>\\n+ </html>\\n+ )\\n+}\",\n \"additions\": 19,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/page.tsx\",\n \"patch\": \"@@ -0,0 +1,14 @@\\n+import { Suspense } from 'react'\\n+import { ProductGrid } from './ProductGrid'\\n+import { ProductGridSkeleton } from './ProductSkeleton'\\n+\\n+export default function Home() {\\n+ return (\\n+ <main>\\n+ <h1>Products</h1>\\n+ <Suspense fallback={<ProductGridSkeleton />}>\\n+ <ProductGrid />\\n+ </Suspense>\\n+ </main>\\n+ )\\n+}\",\n \"additions\": 14,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/app/product/[slug]/page.tsx\",\n \"patch\": \"@@ -0,0 +1,55 @@\\n+import { Suspense } from 'react'\\n+import Link from 'next/link'\\n+import { getProduct, products } from '@/lib/products'\\n+import { notFound } from 'next/navigation'\\n+\\n+async function ProductDetails({ slug }: { slug: string }) {\\n+ await new Promise((resolve) => setTimeout(resolve, 100))\\n+ const product = getProduct(slug)\\n+ if (!product) notFound()\\n+\\n+ return (\\n+ <div className=\\\"product-info\\\">\\n+ <h1>{product.name}</h1>\\n+ <p className=\\\"product-price\\\">${product.price}</p>\\n+ <p className=\\\"product-description\\\">{product.description}</p>\\n+ </div>\\n+ )\\n+}\\n+\\n+function DetailsSkeleton() {\\n+ return (\\n+ <div className=\\\"product-info\\\">\\n+ <div className=\\\"skeleton-text large\\\" />\\n+ <div className=\\\"skeleton-text short\\\" />\\n+ <div className=\\\"skeleton-text\\\" />\\n+ </div>\\n+ )\\n+}\\n+\\n+export default async function ProductPage({\\n+ params,\\n+}: {\\n+ params: Promise<{ slug: string }>\\n+}) {\\n+ const { slug } = await params\\n+ const product = products.find((p) => p.slug === slug)\\n+ if (!product) notFound()\\n+\\n+ return (\\n+ <div>\\n+ <Link href=\\\"/\\\" className=\\\"back-link\\\">\\n+ ← Back to products\\n+ </Link>\\n+ <div className=\\\"product-detail\\\">\\n+ <div\\n+ className=\\\"product-hero\\\"\\n+ style={{ backgroundColor: product.color }}\\n+ />\\n+ <Suspense fallback={<DetailsSkeleton />}>\\n+ <ProductDetails slug={slug} />\\n+ </Suspense>\\n+ </div>\\n+ </div>\\n+ )\\n+}\",\n \"additions\": 55,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/lib/products.ts\",\n \"patch\": \"@@ -0,0 +1,42 @@\\n+export type Product = {\\n+ slug: string\\n+ name: string\\n+ description: string\\n+ price: number\\n+ color: string\\n+}\\n+\\n+export const products: Product[] = [\\n+ {\\n+ slug: 'classic-sneakers',\\n+ name: 'Classic Sneakers',\\n+ description: 'Timeless design meets everyday comfort.',\\n+ price: 89,\\n+ color: '#4F46E5',\\n+ },\\n+ {\\n+ slug: 'leather-backpack',\\n+ name: 'Leather Backpack',\\n+ description: 'Handcrafted from premium full-grain leather.',\\n+ price: 129,\\n+ color: '#059669',\\n+ },\\n+ {\\n+ slug: 'wireless-headphones',\\n+ name: 'Wireless Headphones',\\n+ description: 'Crystal-clear audio with active noise cancellation.',\\n+ price: 199,\\n+ color: '#DC2626',\\n+ },\\n+ {\\n+ slug: 'cotton-hoodie',\\n+ name: 'Cotton Hoodie',\\n+ description: 'Ultra-soft organic cotton blend for all-day wear.',\\n+ price: 65,\\n+ color: '#D97706',\\n+ },\\n+]\\n+\\n+export function getProduct(slug: string): Product | undefined {\\n+ return products.find((p) => p.slug === slug)\\n+}\",\n \"additions\": 42,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/next.config.ts\",\n \"patch\": \"@@ -0,0 +1,5 @@\\n+import type { NextConfig } from 'next'\\n+\\n+const nextConfig: NextConfig = {}\\n+\\n+export default nextConfig\",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/package.json\",\n \"patch\": \"@@ -0,0 +1,23 @@\\n+{\\n+ \\\"private\\\": true,\\n+ \\\"type\\\": \\\"module\\\",\\n+ \\\"scripts\\\": {\\n+ \\\"dev\\\": \\\"next dev\\\",\\n+ \\\"build\\\": \\\"next build\\\",\\n+ \\\"start\\\": \\\"next start\\\"\\n+ },\\n+ \\\"dependencies\\\": {\\n+ \\\"next\\\": \\\"^16\\\",\\n+ \\\"react\\\": \\\"19.1.0\\\",\\n+ \\\"react-dom\\\": \\\"19.1.0\\\"\\n+ },\\n+ \\\"devDependencies\\\": {\\n+ \\\"@types/node\\\": \\\"^20\\\",\\n+ \\\"@types/react\\\": \\\"^19\\\",\\n+ \\\"@types/react-dom\\\": \\\"^19\\\",\\n+ \\\"typescript\\\": \\\"^5\\\",\\n+ \\\"vitest\\\": \\\"^3.1.3\\\",\\n+ \\\"@vitejs/plugin-react\\\": \\\"^4.4.1\\\",\\n+ \\\"vite-tsconfig-paths\\\": \\\"^5.1.4\\\"\\n+ }\\n+}\",\n \"additions\": 23,\n \"deletions\": 0\n },\n {\n \"filename\": \"evals/evals/agent-043-view-transitions/tsconfig.json\",\n \"patch\": \"@@ -0,0 +1,27 @@\\n+{\\n+ \\\"compilerOptions\\\": {\\n+ \\\"target\\\": \\\"ES2017\\\",\\n+ \\\"lib\\\": [\\\"dom\\\", \\\"dom.iterable\\\", \\\"esnext\\\"],\\n+ \\\"allowJs\\\": true,\\n+ \\\"skipLibCheck\\\": true,\\n+ \\\"strict\\\": true,\\n+ \\\"noEmit\\\": true,\\n+ \\\"esModuleInterop\\\": true,\\n+ \\\"module\\\": \\\"esnext\\\",\\n+ \\\"moduleResolution\\\": \\\"bundler\\\",\\n+ \\\"resolveJsonModule\\\": true,\\n+ \\\"isolatedModules\\\": true,\\n+ \\\"jsx\\\": \\\"react-jsx\\\",\\n+ \\\"incremental\\\": true,\\n+ \\\"plugins\\\": [\\n+ {\\n+ \\\"name\\\": \\\"next\\\"\\n+ }\\n+ ],\\n+ \\\"paths\\\": {\\n+ \\\"@/*\\\": [\\\"./*\\\"]\\n+ }\\n+ },\\n+ \\\"include\\\": [\\\"next-env.d.ts\\\", \\\"**/*.ts\\\", \\\"**/*.tsx\\\", \\\".next/types/**/*.ts\\\"],\\n+ \\\"exclude\\\": [\\\"node_modules\\\"]\\n+}\",\n \"additions\": 27,\n \"deletions\": 0\n },\n {\n \"filename\": \"lerna.json\",\n \"patch\": \"@@ -15,5 +15,5 @@\\n \\\"registry\\\": \\\"https://registry.npmjs.org/\\\"\\n }\\n },\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\"\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\"\\n }\\n\\\\ No newline at end of file\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/create-next-app/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"create-next-app\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"keywords\\\": [\\n \\\"react\\\",\\n \\\"next\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/eslint-config-next/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"eslint-config-next\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"ESLint configuration used by Next.js.\\\",\\n \\\"license\\\": \\\"MIT\\\",\\n \\\"repository\\\": {\\n@@ -12,7 +12,7 @@\\n \\\"dist\\\"\\n ],\\n \\\"dependencies\\\": {\\n- \\\"@next/eslint-plugin-next\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"@next/eslint-plugin-next\\\": \\\"16.2.1-canary.18\\\",\\n \\\"eslint-import-resolver-node\\\": \\\"^0.3.6\\\",\\n \\\"eslint-import-resolver-typescript\\\": \\\"^3.5.2\\\",\\n \\\"eslint-plugin-import\\\": \\\"^2.32.0\\\",\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"packages/eslint-plugin-internal/package.json\",\n \"patch\": \"@@ -1,7 +1,7 @@\\n {\\n \\\"name\\\": \\\"@next/eslint-plugin-internal\\\",\\n \\\"private\\\": true,\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"ESLint plugin for working on Next.js.\\\",\\n \\\"exports\\\": {\\n \\\".\\\": \\\"./src/eslint-plugin-internal.js\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/eslint-plugin-next/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/eslint-plugin-next\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"ESLint plugin for Next.js.\\\",\\n \\\"main\\\": \\\"dist/index.js\\\",\\n \\\"types\\\": \\\"dist/index.d.ts\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/font/package.json\",\n \"patch\": \"@@ -1,7 +1,7 @@\\n {\\n \\\"name\\\": \\\"@next/font\\\",\\n \\\"private\\\": true,\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\\n \\\"directory\\\": \\\"packages/font\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-bundle-analyzer/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/bundle-analyzer\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"main\\\": \\\"index.js\\\",\\n \\\"types\\\": \\\"index.d.ts\\\",\\n \\\"license\\\": \\\"MIT\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-codemod/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/codemod\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"license\\\": \\\"MIT\\\",\\n \\\"repository\\\": {\\n \\\"type\\\": \\\"git\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-env/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/env\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"keywords\\\": [\\n \\\"react\\\",\\n \\\"next\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-mdx/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/mdx\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"main\\\": \\\"index.js\\\",\\n \\\"license\\\": \\\"MIT\\\",\\n \\\"repository\\\": {\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-playwright/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/playwright\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\\n \\\"directory\\\": \\\"packages/next-playwright\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-plugin-storybook/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/plugin-storybook\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\\n \\\"directory\\\": \\\"packages/next-plugin-storybook\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-polyfill-module/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/polyfill-module\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"A standard library polyfill for ES Modules supporting browsers (Edge 16+, Firefox 60+, Chrome 61+, Safari 10.1+)\\\",\\n \\\"main\\\": \\\"dist/polyfill-module.js\\\",\\n \\\"license\\\": \\\"MIT\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-polyfill-nomodule/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/polyfill-nomodule\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"A polyfill for non-dead, nomodule browsers.\\\",\\n \\\"main\\\": \\\"dist/polyfill-nomodule.js\\\",\\n \\\"license\\\": \\\"MIT\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-routing/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/routing\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"keywords\\\": [\\n \\\"react\\\",\\n \\\"next\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-rspack/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"next-rspack\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\\n \\\"directory\\\": \\\"packages/next-rspack\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next-swc/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/swc\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"private\\\": true,\\n \\\"files\\\": [\\n \\\"native/\\\"\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"next\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"The React Framework\\\",\\n \\\"main\\\": \\\"./dist/server/next.js\\\",\\n \\\"license\\\": \\\"MIT\\\",\\n@@ -99,7 +99,7 @@\\n ]\\n },\\n \\\"dependencies\\\": {\\n- \\\"@next/env\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"@next/env\\\": \\\"16.2.1-canary.18\\\",\\n \\\"@swc/helpers\\\": \\\"0.5.15\\\",\\n \\\"baseline-browser-mapping\\\": \\\"^2.9.19\\\",\\n \\\"caniuse-lite\\\": \\\"^1.0.30001579\\\",\\n@@ -163,11 +163,11 @@\\n \\\"@modelcontextprotocol/sdk\\\": \\\"1.18.1\\\",\\n \\\"@mswjs/interceptors\\\": \\\"0.23.0\\\",\\n \\\"@napi-rs/triples\\\": \\\"1.2.0\\\",\\n- \\\"@next/font\\\": \\\"16.2.1-canary.17\\\",\\n- \\\"@next/polyfill-module\\\": \\\"16.2.1-canary.17\\\",\\n- \\\"@next/polyfill-nomodule\\\": \\\"16.2.1-canary.17\\\",\\n- \\\"@next/react-refresh-utils\\\": \\\"16.2.1-canary.17\\\",\\n- \\\"@next/swc\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"@next/font\\\": \\\"16.2.1-canary.18\\\",\\n+ \\\"@next/polyfill-module\\\": \\\"16.2.1-canary.18\\\",\\n+ \\\"@next/polyfill-nomodule\\\": \\\"16.2.1-canary.18\\\",\\n+ \\\"@next/react-refresh-utils\\\": \\\"16.2.1-canary.18\\\",\\n+ \\\"@next/swc\\\": \\\"16.2.1-canary.18\\\",\\n \\\"@opentelemetry/api\\\": \\\"1.6.0\\\",\\n \\\"@playwright/test\\\": \\\"1.58.2\\\",\\n \\\"@rspack/core\\\": \\\"1.6.7\\\",\",\n \"additions\": 7,\n \"deletions\": 7\n },\n {\n \"filename\": \"packages/next/src/build/swc/generated-native.d.ts\",\n \"patch\": \"@@ -491,6 +491,9 @@ export declare function projectWriteAnalyzeData(\\n project: { __napiType: 'Project' },\\n appDirOnly: boolean\\n ): Promise<TurbopackResult>\\n+export declare function projectGetAllCompilationIssues(project: {\\n+ __napiType: 'Project'\\n+}): Promise<TurbopackResult>\\n /**\\n * Opens the Turbopack persistent cache database at the given path and performs a full compaction.\\n *\",\n \"additions\": 3,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/build/swc/index.ts\",\n \"patch\": \"@@ -708,6 +708,13 @@ function bindingToApi(\\n return napiResult\\n }\\n \\n+ async getAllCompilationIssues(): Promise<TurbopackResult<void>> {\\n+ const napiResult = (await binding.projectGetAllCompilationIssues(\\n+ this._nativeProject\\n+ )) as TurbopackResult<void>\\n+ return napiResult\\n+ }\\n+\\n async writeAllEntrypointsToDisk(\\n appDirOnly: boolean\\n ): Promise<TurbopackResult<Partial<RawEntrypoints>>> {\",\n \"additions\": 7,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/build/swc/types.ts\",\n \"patch\": \"@@ -290,6 +290,8 @@ export interface Project {\\n \\n writeAnalyzeData(appDirOnly: boolean): Promise<TurbopackResult<void>>\\n \\n+ getAllCompilationIssues(): Promise<TurbopackResult<void>>\\n+\\n writeAllEntrypointsToDisk(\\n appDirOnly: boolean\\n ): Promise<TurbopackResult<Partial<RawEntrypoints>>>\",\n \"additions\": 2,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/build/templates/app-page.ts\",\n \"patch\": \"@@ -995,214 +995,317 @@ export async function handler(\\n const isProduction = routeModule.isDev === false\\n const didRespond = hasResolved || res.writableEnded\\n \\n- // skip on-demand revalidate if cache is not present and\\n- // revalidate-if-generated is set\\n- if (\\n- isOnDemandRevalidate &&\\n- revalidateOnlyGenerated &&\\n- !previousIncrementalCacheEntry &&\\n- !isMinimalMode\\n- ) {\\n- if (routerServerContext?.render404) {\\n- await routerServerContext.render404(req, res)\\n- } else {\\n- res.statusCode = 404\\n- res.end('This page could not be found')\\n+ try {\\n+ // skip on-demand revalidate if cache is not present and\\n+ // revalidate-if-generated is set\\n+ if (\\n+ isOnDemandRevalidate &&\\n+ revalidateOnlyGenerated &&\\n+ !previousIncrementalCacheEntry &&\\n+ !isMinimalMode\\n+ ) {\\n+ if (routerServerContext?.render404) {\\n+ await routerServerContext.render404(req, res)\\n+ } else {\\n+ res.statusCode = 404\\n+ res.end('This page could not be found')\\n+ }\\n+ return null\\n }\\n- return null\\n- }\\n \\n- let fallbackMode: FallbackMode | undefined\\n+ let fallbackMode: FallbackMode | undefined\\n \\n- if (prerenderInfo) {\\n- fallbackMode = parseFallbackField(prerenderInfo.fallback)\\n- }\\n-\\n- if (\\n- nextConfig.experimental.partialFallbacks === true &&\\n- prerenderInfo?.fallback === null &&\\n- !hasUnresolvedRootFallbackParams &&\\n- remainingPrerenderableParams.length > 0\\n- ) {\\n- // Generic source shells without unresolved root params don't have a\\n- // concrete fallback file of their own, so they're marked as blocking.\\n- // When we can complete the shell into a more specific\\n- // prerendered shell for this request, treat it like a prerender\\n- // fallback so we can serve that shell instead of blocking on the full\\n- // route. Root-param shells stay blocking, since unknown root branches\\n- // should not inherit a shell from another generated branch.\\n- fallbackMode = FallbackMode.PRERENDER\\n- }\\n+ if (prerenderInfo) {\\n+ fallbackMode = parseFallbackField(prerenderInfo.fallback)\\n+ }\\n \\n- // When serving a HTML bot request, we want to serve a blocking render and\\n- // not the prerendered page. This ensures that the correct content is served\\n- // to the bot in the head.\\n- if (fallbackMode === FallbackMode.PRERENDER && isBot(userAgent)) {\\n- if (!isRoutePPREnabled || isHtmlBot) {\\n- fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\\n+ if (\\n+ nextConfig.experimental.partialFallbacks === true &&\\n+ prerenderInfo?.fallback === null &&\\n+ !hasUnresolvedRootFallbackParams &&\\n+ remainingPrerenderableParams.length > 0\\n+ ) {\\n+ // Generic source shells without unresolved root params don't have a\\n+ // concrete fallback file of their own, so they're marked as blocking.\\n+ // When we can complete the shell into a more specific\\n+ // prerendered shell for this request, treat it like a prerender\\n+ // fallback so we can serve that shell instead of blocking on the full\\n+ // route. Root-param shells stay blocking, since unknown root branches\\n+ // should not inherit a shell from another generated branch.\\n+ fallbackMode = FallbackMode.PRERENDER\\n }\\n- }\\n \\n- if (previousIncrementalCacheEntry?.isStale === -1) {\\n- isOnDemandRevalidate = true\\n- }\\n+ // When serving a HTML bot request, we want to serve a blocking render and\\n+ // not the prerendered page. This ensures that the correct content is served\\n+ // to the bot in the head.\\n+ if (fallbackMode === FallbackMode.PRERENDER && isBot(userAgent)) {\\n+ if (!isRoutePPREnabled || isHtmlBot) {\\n+ fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\\n+ }\\n+ }\\n \\n- // TODO: adapt for PPR\\n- // only allow on-demand revalidate for fallback: true/blocking\\n- // or for prerendered fallback: false paths\\n- if (\\n- isOnDemandRevalidate &&\\n- (fallbackMode !== FallbackMode.NOT_FOUND ||\\n- previousIncrementalCacheEntry)\\n- ) {\\n- fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\\n- }\\n+ if (previousIncrementalCacheEntry?.isStale === -1) {\\n+ isOnDemandRevalidate = true\\n+ }\\n \\n- if (\\n- !isMinimalMode &&\\n- fallbackMode !== FallbackMode.BLOCKING_STATIC_RENDER &&\\n- staticPathKey &&\\n- !didRespond &&\\n- !isDraftMode &&\\n- pageIsDynamic &&\\n- (isProduction || !isPrerendered)\\n- ) {\\n- // if the page has dynamicParams: false and this pathname wasn't\\n- // prerendered trigger the no fallback handling\\n+ // TODO: adapt for PPR\\n+ // only allow on-demand revalidate for fallback: true/blocking\\n+ // or for prerendered fallback: false paths\\n if (\\n- // In development, fall through to render to handle missing\\n- // getStaticPaths.\\n- (isProduction || prerenderInfo) &&\\n- // When fallback isn't present, abort this render so we 404\\n- fallbackMode === FallbackMode.NOT_FOUND\\n+ isOnDemandRevalidate &&\\n+ (fallbackMode !== FallbackMode.NOT_FOUND ||\\n+ previousIncrementalCacheEntry)\\n ) {\\n- if (nextConfig.adapterPath) {\\n- return await render404()\\n- }\\n- throw new NoFallbackError()\\n+ fallbackMode = FallbackMode.BLOCKING_STATIC_RENDER\\n }\\n \\n- // When cacheComponents is enabled, we can use the fallback\\n- // response if the request is not a dynamic RSC request because the\\n- // RSC data when this feature flag is enabled does not contain any\\n- // param references. Without this feature flag enabled, the RSC data\\n- // contains param references, and therefore we can't use the fallback.\\n if (\\n- isRoutePPREnabled &&\\n- (nextConfig.cacheComponents ? !isDynamicRSCRequest : !isRSCRequest)\\n+ !isMinimalMode &&\\n+ fallbackMode !== FallbackMode.BLOCKING_STATIC_RENDER &&\\n+ staticPathKey &&\\n+ !didRespond &&\\n+ !isDraftMode &&\\n+ pageIsDynamic &&\\n+ (isProduction || !isPrerendered)\\n ) {\\n- const cacheKey =\\n- isProduction && typeof prerenderInfo?.fallback === 'string'\\n- ? prerenderInfo.fallback\\n- : normalizedSrcPage\\n-\\n- const fallbackRouteParams =\\n- // In production or when debugging the static shell (e.g. instant\\n- // navigation testing), use the prerender manifest's fallback\\n- // route params which correctly identifies which params are\\n- // unknown. Note: in dev, this block is only entered for\\n- // non-prerendered URLs (guarded by the outer condition).\\n- (isProduction || isDebugStaticShell) &&\\n- prerenderInfo?.fallbackRouteParams\\n- ? createOpaqueFallbackRouteParams(\\n- prerenderInfo.fallbackRouteParams\\n- )\\n- : // When debugging the fallback shell, treat all params as\\n- // fallback (simulating the worst-case shell).\\n- isDebugFallbackShell\\n- ? getFallbackRouteParams(normalizedSrcPage, routeModule)\\n- : null\\n+ // if the page has dynamicParams: false and this pathname wasn't\\n+ // prerendered trigger the no fallback handling\\n+ if (\\n+ // In development, fall through to render to handle missing\\n+ // getStaticPaths.\\n+ (isProduction || prerenderInfo) &&\\n+ // When fallback isn't present, abort this render so we 404\\n+ fallbackMode === FallbackMode.NOT_FOUND\\n+ ) {\\n+ if (nextConfig.adapterPath) {\\n+ return await render404()\\n+ }\\n+ throw new NoFallbackError()\\n+ }\\n+\\n+ // When cacheComponents is enabled, we can use the fallback\\n+ // response if the request is not a dynamic RSC request because the\\n+ // RSC data when this feature flag is enabled does not contain any\\n+ // param references. Without this feature flag enabled, the RSC data\\n+ // contains param references, and therefore we can't use the fallback.\\n+ if (\\n+ isRoutePPREnabled &&\\n+ (nextConfig.cacheComponents ? !isDynamicRSCRequest : !isRSCRequest)\\n+ ) {\\n+ const cacheKey =\\n+ isProduction && typeof prerenderInfo?.fallback === 'string'\\n+ ? prerenderInfo.fallback\\n+ : normalizedSrcPage\\n+\\n+ const fallbackRouteParams =\\n+ // In production or when debugging the static shell (e.g. instant\\n+ // navigation testing), use the prerender manifest's fallback\\n+ // route params which correctly identifies which params are\\n+ // unknown. Note: in dev, this block is only entered for\\n+ // non-prerendered URLs (guarded by the outer condition).\\n+ (isProduction || isDebugStaticShell) &&\\n+ prerenderInfo?.fallbackRouteParams\\n+ ? createOpaqueFallbackRouteParams(\\n+ prerenderInfo.fallbackRouteParams\\n+ )\\n+ : // When debugging the fallback shell, treat all params as\\n+ // fallback (simulating the worst-case shell).\\n+ isDebugFallbackShell\\n+ ? getFallbackRouteParams(normalizedSrcPage, routeModule)\\n+ : null\\n+\\n+ // When rendering a debug static shell, override the fallback\\n+ // params on the request so that the staged rendering correctly\\n+ // defers params that are not statically known.\\n+ if (isDebugStaticShell && fallbackRouteParams) {\\n+ addRequestMeta(req, 'fallbackParams', fallbackRouteParams)\\n+ }\\n \\n- // When rendering a debug static shell, override the fallback\\n- // params on the request so that the staged rendering correctly\\n- // defers params that are not statically known.\\n- if (isDebugStaticShell && fallbackRouteParams) {\\n- addRequestMeta(req, 'fallbackParams', fallbackRouteParams)\\n+ // We use the response cache here to handle the revalidation and\\n+ // management of the fallback shell.\\n+ const fallbackResponse = await routeModule.handleResponse({\\n+ cacheKey,\\n+ req,\\n+ nextConfig,\\n+ routeKind: RouteKind.APP_PAGE,\\n+ isFallback: true,\\n+ prerenderManifest,\\n+ isRoutePPREnabled,\\n+ responseGenerator: async () =>\\n+ doRender({\\n+ span,\\n+ // We pass `undefined` as rendering a fallback isn't resumed\\n+ // here.\\n+ postponed: undefined,\\n+ // Always serve the shell that matched this request\\n+ // immediately. If there are still prerenderable params left,\\n+ // the background path below will complete the shell into a\\n+ // more specific cache entry for later requests.\\n+ fallbackRouteParams,\\n+ forceStaticRender: true,\\n+ }),\\n+ waitUntil: ctx.waitUntil,\\n+ isMinimalMode,\\n+ })\\n+\\n+ // If the fallback response was set to null, then we should return null.\\n+ if (fallbackResponse === null) return null\\n+\\n+ // Otherwise, if we did get a fallback response, we should return it.\\n+ if (fallbackResponse) {\\n+ if (\\n+ !isMinimalMode &&\\n+ isRoutePPREnabled &&\\n+ // Match the build-time contract: only fallback shells that can\\n+ // still be completed with prerenderable params should upgrade.\\n+ remainingPrerenderableParams.length > 0 &&\\n+ nextConfig.experimental.partialFallbacks === true &&\\n+ ssgCacheKey &&\\n+ incrementalCache &&\\n+ !isOnDemandRevalidate &&\\n+ !isDebugFallbackShell &&\\n+ // The testing API relies on deterministic shell behavior, so\\n+ // don't upgrade fallback shells in the background when it's\\n+ // exposed.\\n+ !exposeTestingApi &&\\n+ // Instant Navigation Testing API requests intentionally keep\\n+ // the route in shell mode; don't upgrade these in background.\\n+ !isInstantNavigationTest &&\\n+ // Avoid background revalidate during prefetches; this can trigger\\n+ // static prerender errors that surface as 500s for the prefetch\\n+ // request itself.\\n+ !isPrefetchRSCRequest\\n+ ) {\\n+ scheduleOnNextTick(async () => {\\n+ const responseCache = routeModule.getResponseCache(req)\\n+\\n+ try {\\n+ // Only the params that were just specialized should be\\n+ // removed from the fallback render. Any remaining fallback\\n+ // params stay deferred so the revalidated result is a more\\n+ // specific shell (e.g. `/prefix/c/[two]`), not a fully\\n+ // concrete route (`/prefix/c/foo`).\\n+ await responseCache.revalidate(\\n+ ssgCacheKey,\\n+ incrementalCache,\\n+ isRoutePPREnabled,\\n+ false,\\n+ (c) => {\\n+ return doRender({\\n+ span: c.span,\\n+ postponed: undefined,\\n+ fallbackRouteParams:\\n+ remainingFallbackRouteParams.length > 0\\n+ ? createOpaqueFallbackRouteParams(\\n+ remainingFallbackRouteParams\\n+ )\\n+ : null,\\n+ forceStaticRender: true,\\n+ })\\n+ },\\n+ // We don't have a prior entry for this param-specific shell.\\n+ null,\\n+ hasResolved,\\n+ ctx.waitUntil\\n+ )\\n+ } catch (err) {\\n+ console.error(\\n+ 'Error revalidating the page in the background',\\n+ err\\n+ )\\n+ }\\n+ })\\n+ }\\n+\\n+ // Remove the cache control from the response to prevent it from being\\n+ // used in the surrounding cache.\\n+ delete fallbackResponse.cacheControl\\n+\\n+ return fallbackResponse\\n+ }\\n }\\n+ }\\n \\n- // We use the response cache here to handle the revalidation and\\n- // management of the fallback shell.\\n- const fallbackResponse = await routeModule.handleResponse({\\n- cacheKey,\\n- req,\\n- nextConfig,\\n- routeKind: RouteKind.APP_PAGE,\\n- isFallback: true,\\n- prerenderManifest,\\n- isRoutePPREnabled,\\n- responseGenerator: async () =>\\n- doRender({\\n- span,\\n- // We pass `undefined` as rendering a fallback isn't resumed\\n- // here.\\n- postponed: undefined,\\n- // Always serve the shell that matched this request\\n- // immediately. If there are still prerenderable params left,\\n- // the background path below will complete the shell into a\\n- // more specific cache entry for later requests.\\n- fallbackRouteParams,\\n- forceStaticRender: true,\\n- }),\\n- waitUntil: ctx.waitUntil,\\n- isMinimalMode,\\n- })\\n+ // Only requests that aren't revalidating can be resumed. If we have the\\n+ // minimal postponed data, then we should resume the render with it.\\n+ let postponed =\\n+ !isOnDemandRevalidate && !isRevalidating && minimalPostponed\\n+ ? minimalPostponed\\n+ : undefined\\n+\\n+ if (\\n+ // If this is a dynamic RSC request or a server action request, we should\\n+ // use the postponed data from the static render (if available). This\\n+ // ensures that we can utilize the resume data cache (RDC) from the static\\n+ // render to ensure that the data is consistent between the static and\\n+ // dynamic renders (for navigations) or when re-rendering after a server\\n+ // action.\\n+ // Only enable RDC for Navigations if the feature is enabled.\\n+ supportsRDCForNavigations &&\\n+ process.env.NEXT_RUNTIME !== 'edge' &&\\n+ !isMinimalMode &&\\n+ incrementalCache &&\\n+ // Include both dynamic RSC requests (navigations) and server actions\\n+ (isDynamicRSCRequest || isPossibleServerAction) &&\\n+ // We don't typically trigger an on-demand revalidation for dynamic RSC\\n+ // requests, as we're typically revalidating the page in the background\\n+ // instead. However, if the cache entry is stale, we should trigger a\\n+ // background revalidation on dynamic RSC requests. This prevents us\\n+ // from entering an infinite loop of revalidations.\\n+ !forceStaticRender\\n+ ) {\\n+ const incrementalCacheEntry = await incrementalCache.get(\\n+ resolvedPathname,\\n+ {\\n+ kind: IncrementalCacheKind.APP_PAGE,\\n+ isRoutePPREnabled: true,\\n+ isFallback: false,\\n+ }\\n+ )\\n \\n- // If the fallback response was set to null, then we should return null.\\n- if (fallbackResponse === null) return null\\n+ // If the cache entry is found, we should use the postponed data from\\n+ // the cache.\\n+ if (\\n+ incrementalCacheEntry &&\\n+ incrementalCacheEntry.value &&\\n+ incrementalCacheEntry.value.kind === CachedRouteKind.APP_PAGE\\n+ ) {\\n+ // CRITICAL: we're assigning the postponed data from the cache entry\\n+ // here as we're using the RDC to resume the render.\\n+ postponed = incrementalCacheEntry.value.postponed\\n \\n- // Otherwise, if we did get a fallback response, we should return it.\\n- if (fallbackResponse) {\\n+ // If the cache entry is stale, we should trigger a background\\n+ // revalidation so that subsequent requests will get a fresh response.\\n if (\\n- !isMinimalMode &&\\n- isRoutePPREnabled &&\\n- // Match the build-time contract: only fallback shells that can\\n- // still be completed with prerenderable params should upgrade.\\n- remainingPrerenderableParams.length > 0 &&\\n- nextConfig.experimental.partialFallbacks === true &&\\n- ssgCacheKey &&\\n- incrementalCache &&\\n- !isOnDemandRevalidate &&\\n- !isDebugFallbackShell &&\\n- // The testing API relies on deterministic shell behavior, so\\n- // don't upgrade fallback shells in the background when it's\\n- // exposed.\\n- !exposeTestingApi &&\\n- // Instant Navigation Testing API requests intentionally keep\\n- // the route in shell mode; don't upgrade these in background.\\n- !isInstantNavigationTest &&\\n- // Avoid background revalidate during prefetches; this can trigger\\n- // static prerender errors that surface as 500s for the prefetch\\n- // request itself.\\n- !isPrefetchRSCRequest\\n+ incrementalCacheEntry &&\\n+ // We want to trigger this flow if the cache entry is stale and if\\n+ // the requested revalidation flow is either foreground or\\n+ // background.\\n+ (incrementalCacheEntry.isStale === -1 ||\\n+ incrementalCacheEntry.isStale === true)\\n ) {\\n+ // We want to schedule this on the next tick to ensure that the\\n+ // render is not blocked on it.\\n scheduleOnNextTick(async () => {\\n const responseCache = routeModule.getResponseCache(req)\\n \\n try {\\n- // Only the params that were just specialized should be\\n- // removed from the fallback render. Any remaining fallback\\n- // params stay deferred so the revalidated result is a more\\n- // specific shell (e.g. `/prefix/c/[two]`), not a fully\\n- // concrete route (`/prefix/c/foo`).\\n await responseCache.revalidate(\\n- ssgCacheKey,\\n+ resolvedPathname,\\n incrementalCache,\\n isRoutePPREnabled,\\n false,\\n- (c) => {\\n- return doRender({\\n- span: c.span,\\n- postponed: undefined,\\n- fallbackRouteParams:\\n- remainingFallbackRouteParams.length > 0\\n- ? createOpaqueFallbackRouteParams(\\n- remainingFallbackRouteParams\\n- )\\n- : null,\\n+ (c) =>\\n+ responseGenerator({\\n+ ...c,\\n+ // CRITICAL: we need to set this to true as we're\\n+ // revalidating in the background and typically this dynamic\\n+ // RSC request is not treated as static.\\n forceStaticRender: true,\\n- })\\n- },\\n- // We don't have a prior entry for this param-specific shell.\\n+ }),\\n+ // CRITICAL: we need to pass null here because passing the\\n+ // previous cache entry here (which is stale) will switch on\\n+ // isOnDemandRevalidate and break the prerendering.\\n null,\\n hasResolved,\\n ctx.waitUntil\\n@@ -1215,191 +1318,112 @@ export async function handler(\\n }\\n })\\n }\\n-\\n- // Remove the cache control from the response to prevent it from being\\n- // used in the surrounding cache.\\n- delete fallbackResponse.cacheControl\\n-\\n- return fallbackResponse\\n }\\n }\\n- }\\n-\\n- // Only requests that aren't revalidating can be resumed. If we have the\\n- // minimal postponed data, then we should resume the render with it.\\n- let postponed =\\n- !isOnDemandRevalidate && !isRevalidating && minimalPostponed\\n- ? minimalPostponed\\n- : undefined\\n \\n- // If this is a dynamic RSC request or a server action request, we should\\n- // use the postponed data from the static render (if available). This\\n- // ensures that we can utilize the resume data cache (RDC) from the static\\n- // render to ensure that the data is consistent between the static and\\n- // dynamic renders (for navigations) or when re-rendering after a server\\n- // action.\\n- if (\\n- // Only enable RDC for Navigations if the feature is enabled.\\n- supportsRDCForNavigations &&\\n- process.env.NEXT_RUNTIME !== 'edge' &&\\n- !isMinimalMode &&\\n- incrementalCache &&\\n- // Include both dynamic RSC requests (navigations) and server actions\\n- (isDynamicRSCRequest || isPossibleServerAction) &&\\n- // We don't typically trigger an on-demand revalidation for dynamic RSC\\n- // requests, as we're typically revalidating the page in the background\\n- // instead. However, if the cache entry is stale, we should trigger a\\n- // background revalidation on dynamic RSC requests. This prevents us\\n- // from entering an infinite loop of revalidations.\\n- !forceStaticRender\\n- ) {\\n- const incrementalCacheEntry = await incrementalCache.get(\\n- resolvedPathname,\\n- {\\n- kind: IncrementalCacheKind.APP_PAGE,\\n- isRoutePPREnabled: true,\\n- isFallback: false,\\n- }\\n- )\\n-\\n- // If the cache entry is found, we should use the postponed data from\\n- // the cache.\\n+ // When we're in minimal mode, if we're trying to debug the static shell,\\n+ // we should just return nothing instead of resuming the dynamic render.\\n if (\\n- incrementalCacheEntry &&\\n- incrementalCacheEntry.value &&\\n- incrementalCacheEntry.value.kind === CachedRouteKind.APP_PAGE\\n+ (isDebugStaticShell || isDebugDynamicAccesses) &&\\n+ typeof postponed !== 'undefined'\\n ) {\\n- // CRITICAL: we're assigning the postponed data from the cache entry\\n- // here as we're using the RDC to resume the render.\\n- postponed = incrementalCacheEntry.value.postponed\\n-\\n- // If the cache entry is stale, we should trigger a background\\n- // revalidation so that subsequent requests will get a fresh response.\\n- if (\\n- incrementalCacheEntry &&\\n- // We want to trigger this flow if the cache entry is stale and if\\n- // the requested revalidation flow is either foreground or\\n- // background.\\n- (incrementalCacheEntry.isStale === -1 ||\\n- incrementalCacheEntry.isStale === true)\\n- ) {\\n- // We want to schedule this on the next tick to ensure that the\\n- // render is not blocked on it.\\n- scheduleOnNextTick(async () => {\\n- const responseCache = routeModule.getResponseCache(req)\\n-\\n- try {\\n- await responseCache.revalidate(\\n- resolvedPathname,\\n- incrementalCache,\\n- isRoutePPREnabled,\\n- false,\\n- (c) =>\\n- responseGenerator({\\n- ...c,\\n- // CRITICAL: we need to set this to true as we're\\n- // revalidating in the background and typically this dynamic\\n- // RSC request is not treated as static.\\n- forceStaticRender: true,\\n- }),\\n- // CRITICAL: we need to pass null here because passing the\\n- // previous cache entry here (which is stale) will switch on\\n- // isOnDemandRevalidate and break the prerendering.\\n- null,\\n- hasResolved,\\n- ctx.waitUntil\\n- )\\n- } catch (err) {\\n- console.error(\\n- 'Error revalidating the page in the background',\\n- err\\n- )\\n- }\\n- })\\n+ return {\\n+ cacheControl: { revalidate: 1, expire: undefined },\\n+ value: {\\n+ kind: CachedRouteKind.PAGES,\\n+ html: RenderResult.EMPTY,\\n+ pageData: {},\\n+ headers: undefined,\\n+ status: undefined,\\n+ } satisfies CachedPageValue,\\n }\\n }\\n- }\\n \\n- // When we're in minimal mode, if we're trying to debug the static shell,\\n- // we should just return nothing instead of resuming the dynamic render.\\n- if (\\n- (isDebugStaticShell || isDebugDynamicAccesses) &&\\n- typeof postponed !== 'undefined'\\n- ) {\\n- return {\\n- cacheControl: { revalidate: 1, expire: undefined },\\n- value: {\\n- kind: CachedRouteKind.PAGES,\\n- html: RenderResult.EMPTY,\\n- pageData: {},\\n- headers: undefined,\\n- status: undefined,\\n- } satisfies CachedPageValue,\\n+ // When route-module.ts resolved partial nxtP* params during\\n+ // background revalidation, filter fallbackRouteParams to only the\\n+ // params that are still unresolved. This lets doRender produce an\\n+ // intermediate PPR shell that suspends only for those params.\\n+ let effectiveFallbackRouteParams: FallbackRouteParam[] | null = null\\n+ if (nextConfig.cacheComponents && prerenderInfo?.fallbackRouteParams) {\\n+ const resolvedKeys = getRequestMeta(req, 'resolvedRouteParamKeys')\\n+ if (resolvedKeys && resolvedKeys.size > 0) {\\n+ effectiveFallbackRouteParams =\\n+ prerenderInfo.fallbackRouteParams.filter(\\n+ (param) => !resolvedKeys.has(param.paramName)\\n+ )\\n+ }\\n }\\n- }\\n \\n- // When route-module.ts resolved partial nxtP* params during\\n- // background revalidation, filter fallbackRouteParams to only the\\n- // params that are still unresolved. This lets doRender produce an\\n- // intermediate PPR shell that suspends only for those params.\\n- let effectiveFallbackRouteParams: FallbackRouteParam[] | null = null\\n- if (nextConfig.cacheComponents && prerenderInfo?.fallbackRouteParams) {\\n- const resolvedKeys = getRequestMeta(req, 'resolvedRouteParamKeys')\\n- if (resolvedKeys && resolvedKeys.size > 0) {\\n- effectiveFallbackRouteParams =\\n- prerenderInfo.fallbackRouteParams.filter(\\n- (param) => !resolvedKeys.has(param.paramName)\\n- )\\n- }\\n- }\\n+ const fallbackRouteParams =\\n+ // In production or when debugging the static shell for a\\n+ // non-prerendered URL, use the prerender manifest's fallback route\\n+ // params which correctly identifies which params are unknown.\\n+ ((isProduction && getRequestMeta(req, 'renderFallbackShell')) ||\\n+ (isDebugStaticShell && !isPrerendered)) &&\\n+ prerenderInfo?.fallbackRouteParams\\n+ ? createOpaqueFallbackRouteParams(prerenderInfo.fallbackRouteParams)\\n+ : // For intermediate shells where some params are resolved and\\n+ // others still have placeholders, use the filtered subset so the\\n+ // prerender suspends only for the unresolved params.\\n+ effectiveFallbackRouteParams &&\\n+ effectiveFallbackRouteParams.length > 0 &&\\n+ effectiveFallbackRouteParams.length <\\n+ (prerenderInfo?.fallbackRouteParams?.length ?? 0)\\n+ ? createOpaqueFallbackRouteParams(effectiveFallbackRouteParams)\\n+ : isDebugFallbackShell\\n+ ? getFallbackRouteParams(normalizedSrcPage, routeModule)\\n+ : null\\n \\n- const fallbackRouteParams =\\n- // In production or when debugging the static shell for a\\n- // non-prerendered URL, use the prerender manifest's fallback route\\n- // params which correctly identifies which params are unknown.\\n- ((isProduction && getRequestMeta(req, 'renderFallbackShell')) ||\\n- (isDebugStaticShell && !isPrerendered)) &&\\n- prerenderInfo?.fallbackRouteParams\\n- ? createOpaqueFallbackRouteParams(prerenderInfo.fallbackRouteParams)\\n- : // For intermediate shells where some params are resolved and\\n- // others still have placeholders, use the filtered subset so the\\n- // prerender suspends only for the unresolved params.\\n- effectiveFallbackRouteParams &&\\n- effectiveFallbackRouteParams.length > 0 &&\\n- effectiveFallbackRouteParams.length <\\n- (prerenderInfo?.fallbackRouteParams?.length ?? 0)\\n- ? createOpaqueFallbackRouteParams(effectiveFallbackRouteParams)\\n- : isDebugFallbackShell\\n- ? getFallbackRouteParams(normalizedSrcPage, routeModule)\\n- : null\\n-\\n- // For staged dynamic rendering (Cached Navigations) and debug static\\n- // shell rendering, pass the fallback params via request meta so the\\n- // RequestStore knows which params to defer. We don't pass them as\\n- // fallbackRouteParams because that would replace actual param values\\n- // with opaque placeholders during segment resolution.\\n- if (\\n- (isProduction || isDebugStaticShell) &&\\n- nextConfig.cacheComponents &&\\n- !isPrerendered &&\\n- prerenderInfo?.fallbackRouteParams\\n- ) {\\n- const fallbackParams = createOpaqueFallbackRouteParams(\\n- prerenderInfo.fallbackRouteParams\\n- )\\n+ // For staged dynamic rendering (Cached Navigations) and debug static\\n+ // shell rendering, pass the fallback params via request meta so the\\n+ // RequestStore knows which params to defer. We don't pass them as\\n+ // fallbackRouteParams because that would replace actual param values\\n+ // with opaque placeholders during segment resolution.\\n+ if (\\n+ (isProduction || isDebugStaticShell) &&\\n+ nextConfig.cacheComponents &&\\n+ !isPrerendered &&\\n+ prerenderInfo?.fallbackRouteParams\\n+ ) {\\n+ const fallbackParams = createOpaqueFallbackRouteParams(\\n+ prerenderInfo.fallbackRouteParams\\n+ )\\n \\n- if (fallbackParams) {\\n- addRequestMeta(req, 'fallbackParams', fallbackParams)\\n+ if (fallbackParams) {\\n+ addRequestMeta(req, 'fallbackParams', fallbackParams)\\n+ }\\n }\\n- }\\n \\n- // Perform the render.\\n- return doRender({\\n- span,\\n- postponed,\\n- fallbackRouteParams,\\n- forceStaticRender,\\n- })\\n+ // Perform the render.\\n+ return doRender({\\n+ span,\\n+ postponed,\\n+ fallbackRouteParams,\\n+ forceStaticRender,\\n+ })\\n+ } catch (err) {\\n+ // if this is a background revalidate we need to report\\n+ // the request error here as it won't be bubbled\\n+ if (previousIncrementalCacheEntry?.isStale) {\\n+ const silenceLog = false\\n+ await routeModule.onRequestError(\\n+ req,\\n+ err,\\n+ {\\n+ routerKind: 'App Router',\\n+ routePath: srcPage,\\n+ routeType: 'render',\\n+ revalidateReason: getRevalidateReason({\\n+ isStaticGeneration: isSSG,\\n+ isOnDemandRevalidate,\\n+ }),\\n+ },\\n+ silenceLog,\\n+ routerServerContext\\n+ )\\n+ }\\n+ throw err\\n+ }\\n }\\n \\n const handleResponse = async (span?: Span): Promise<null | void> => {\",\n \"additions\": 373,\n \"deletions\": 349\n },\n {\n \"filename\": \"packages/next/src/server/app-render/stream-ops.node.ts\",\n \"patch\": \"@@ -357,16 +357,6 @@ export async function streamToBuffer(stream: AnyStream): Promise<Buffer> {\\n return webStreamToBuffer(nodeReadableToWebReadableStream(stream))\\n }\\n \\n-export async function streamToUint8Array(\\n- stream: AnyStream\\n-): Promise<Uint8Array> {\\n- const chunks: Buffer[] = []\\n- for await (const chunk of webToReadable(stream)) {\\n- chunks.push(typeof chunk === 'string' ? Buffer.from(chunk) : chunk)\\n- }\\n- return Buffer.concat(chunks)\\n-}\\n-\\n export async function streamToString(stream: AnyStream): Promise<string> {\\n return webStreamToString(nodeReadableToWebReadableStream(stream))\\n }\",\n \"additions\": 0,\n \"deletions\": 10\n },\n {\n \"filename\": \"packages/next/src/server/app-render/stream-ops.ts\",\n \"patch\": \"@@ -46,7 +46,6 @@ export const createOnHeadersCallback = _m.createOnHeadersCallback\\n export const resumeAndAbort = _m.resumeAndAbort\\n export const renderToFlightStream = _m.renderToFlightStream\\n export const streamToString = _m.streamToString\\n-export const streamToUint8Array = _m.streamToUint8Array\\n export const renderToFizzStream = _m.renderToFizzStream\\n export const resumeToFizzStream = _m.resumeToFizzStream\\n export const getServerPrerender = _m.getServerPrerender\",\n \"additions\": 0,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next/src/server/app-render/stream-ops.web.ts\",\n \"patch\": \"@@ -20,7 +20,6 @@ import {\\n continueStaticFallbackPrerender as webContinueStaticFallbackPrerender,\\n continueDynamicHTMLResume as webContinueDynamicHTMLResume,\\n streamToBuffer as webStreamToBuffer,\\n- streamToUint8Array as webStreamToUint8Array,\\n chainStreams as webChainStreams,\\n createDocumentClosingStream as webCreateDocumentClosingStream,\\n } from '../stream-utils/node-web-streams-helper'\\n@@ -159,12 +158,6 @@ export async function streamToBuffer(stream: AnyStream): Promise<Buffer> {\\n return webStreamToBuffer(stream as ReadableStream<Uint8Array>)\\n }\\n \\n-export async function streamToUint8Array(\\n- stream: AnyStream\\n-): Promise<Uint8Array> {\\n- return webStreamToUint8Array(stream as ReadableStream<Uint8Array>)\\n-}\\n-\\n export function chainStreams(...streams: AnyStream[]): AnyStream {\\n return webChainStreams(...(streams as ReadableStream<Uint8Array>[]))\\n }\",\n \"additions\": 0,\n \"deletions\": 7\n },\n {\n \"filename\": \"packages/next/src/server/dev/hot-reloader-turbopack.ts\",\n \"patch\": \"@@ -1049,6 +1049,7 @@ export async function createHotReloaderTurbopack(\\n getActiveConnectionCount: () =>\\n clientsWithoutHtmlRequestId.size + clientsByHtmlRequestId.size,\\n getDevServerUrl: () => process.env.__NEXT_PRIVATE_ORIGIN,\\n+ getTurbopackProject: () => project,\\n }),\\n ]\\n : []),\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/server/dev/serialized-errors.ts\",\n \"patch\": \"@@ -3,7 +3,7 @@ import {\\n type HmrMessageSentToBrowser,\\n } from './hot-reloader-types'\\n import type { AnyStream } from '../app-render/stream-ops'\\n-import { streamToUint8Array } from '../app-render/stream-ops'\\n+import { streamToUint8Array } from '../stream-utils/node-web-streams-helper'\\n \\n const errorsRscStreamsByHtmlRequestId = new Map<string, AnyStream>()\\n \",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next/src/server/mcp/get-or-create-mcp-server.ts\",\n \"patch\": \"@@ -5,8 +5,10 @@ import { registerGetPageMetadataTool } from './tools/get-page-metadata'\\n import { registerGetLogsTool } from './tools/get-logs'\\n import { registerGetActionByIdTool } from './tools/get-server-action-by-id'\\n import { registerGetRoutesTool } from './tools/get-routes'\\n+import { registerGetCompilationIssuesTool } from './tools/get-compilation-issues'\\n import type { HmrMessageSentToBrowser } from '../dev/hot-reloader-types'\\n import type { NextConfigComplete } from '../config-shared'\\n+import type { Project } from '../../build/swc/types'\\n \\n export interface McpServerOptions {\\n projectPath: string\\n@@ -17,6 +19,7 @@ export interface McpServerOptions {\\n sendHmrMessage: (message: HmrMessageSentToBrowser) => void\\n getActiveConnectionCount: () => number\\n getDevServerUrl: () => string | undefined\\n+ getTurbopackProject?: () => Project | undefined\\n }\\n \\n let mcpServer: McpServer | undefined\\n@@ -55,5 +58,9 @@ export const getOrCreateMcpServer = (options: McpServerOptions) => {\\n appDir: options.appDir,\\n })\\n \\n+ if (options.getTurbopackProject) {\\n+ registerGetCompilationIssuesTool(mcpServer, options.getTurbopackProject)\\n+ }\\n+\\n return mcpServer\\n }\",\n \"additions\": 7,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/server/mcp/tools/get-compilation-issues.ts\",\n \"patch\": \"@@ -0,0 +1,70 @@\\n+/**\\n+ * MCP tool for getting compilation issues from all routes via Turbopack.\\n+ *\\n+ * Unlike get_errors (which requires a browser session and reflects the runtime\\n+ * error overlay), this tool builds the module graph for every endpoint and\\n+ * collects Turbopack issues directly — no browser needed. Covers\\n+ * module-not-found, syntax errors, and other transform failures across all\\n+ * routes.\\n+ */\\n+import type { McpServer } from 'next/dist/compiled/@modelcontextprotocol/sdk/server/mcp'\\n+import type { Project } from '../../../build/swc/types'\\n+import { mcpTelemetryTracker } from '../mcp-telemetry-tracker'\\n+import { formatCompilationIssues } from './utils/format-compilation-issues'\\n+\\n+export function registerGetCompilationIssuesTool(\\n+ server: McpServer,\\n+ getProject: () => Project | undefined\\n+) {\\n+ server.registerTool(\\n+ 'get_compilation_issues',\\n+ {\\n+ description:\\n+ 'Build the module graph for all routes and return all compilation issues (resolve errors, missing modules, transform errors, etc.). Does not require a browser session. Covers all routes proactively.',\\n+ inputSchema: {},\\n+ },\\n+ async () => {\\n+ mcpTelemetryTracker.recordToolCall('mcp/get_compilation_issues')\\n+\\n+ try {\\n+ const project = getProject()\\n+ if (!project) {\\n+ return {\\n+ content: [\\n+ {\\n+ type: 'text',\\n+ text: JSON.stringify({\\n+ error:\\n+ 'Turbopack project is not available. This tool requires the Turbopack bundler.',\\n+ }),\\n+ },\\n+ ],\\n+ }\\n+ }\\n+\\n+ const { issues } = await project.getAllCompilationIssues()\\n+ const formattedIssues = formatCompilationIssues(issues)\\n+\\n+ return {\\n+ content: [\\n+ {\\n+ type: 'text',\\n+ text: JSON.stringify({ issues: formattedIssues }),\\n+ },\\n+ ],\\n+ }\\n+ } catch (error) {\\n+ return {\\n+ content: [\\n+ {\\n+ type: 'text',\\n+ text: JSON.stringify({\\n+ error: error instanceof Error ? error.message : String(error),\\n+ }),\\n+ },\\n+ ],\\n+ }\\n+ }\\n+ }\\n+ )\\n+}\",\n \"additions\": 70,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/server/mcp/tools/utils/format-compilation-issues.ts\",\n \"patch\": \"@@ -0,0 +1,93 @@\\n+import type { Issue, StyledString } from '../../../../build/swc/types'\\n+import stripAnsi from 'next/dist/compiled/strip-ansi'\\n+\\n+/** Convert a StyledString tree to Markdown. */\\n+function styledStringToMarkdown(s: StyledString): string {\\n+ switch (s.type) {\\n+ case 'text':\\n+ return s.value\\n+ case 'code':\\n+ return `\\\\`${s.value}\\\\``\\n+ case 'strong':\\n+ return `**${s.value}**`\\n+ case 'line':\\n+ return s.value.map(styledStringToMarkdown).join('')\\n+ case 'stack':\\n+ return s.value.map(styledStringToMarkdown).join('\\\\n')\\n+ default:\\n+ return ''\\n+ }\\n+}\\n+\\n+export interface FormattedIssue {\\n+ severity: string\\n+ filePath: string\\n+ title: string\\n+ description?: string\\n+ detail?: string\\n+ source?: {\\n+ filePath: string\\n+ range?: {\\n+ /** 1-indexed */\\n+ start: { line: number; column: number }\\n+ /** 1-indexed */\\n+ end: { line: number; column: number }\\n+ }\\n+ }\\n+ /** Code frame with ANSI codes stripped */\\n+ codeFrame?: string\\n+}\\n+\\n+/**\\n+ * Transform raw Turbopack issues into a clean format for MCP consumers:\\n+ * - Converts StyledString trees (title/description/detail) to Markdown\\n+ * - Strips ANSI codes from code frames\\n+ * - Converts 0-indexed source positions to 1-indexed\\n+ * - Deduplicates issues (same error can surface from multiple endpoints)\\n+ */\\n+export function formatCompilationIssues(issues: Issue[]): FormattedIssue[] {\\n+ const seen = new Set<string>()\\n+ const formattedIssues: FormattedIssue[] = []\\n+\\n+ for (const issue of issues) {\\n+ const title = styledStringToMarkdown(issue.title)\\n+ // Include source position in the key so two distinct errors in the same\\n+ // file with the same message are not collapsed into one.\\n+ const startLine = issue.source?.range?.start.line ?? ''\\n+ const startCol = issue.source?.range?.start.column ?? ''\\n+ const key = `${issue.severity}|${issue.filePath}|${title}|${startLine}:${startCol}`\\n+ if (seen.has(key)) continue\\n+ seen.add(key)\\n+\\n+ const { range } = issue.source ?? {}\\n+ formattedIssues.push({\\n+ severity: issue.severity,\\n+ filePath: issue.filePath,\\n+ title,\\n+ description: issue.description\\n+ ? styledStringToMarkdown(issue.description)\\n+ : undefined,\\n+ detail: issue.detail ? styledStringToMarkdown(issue.detail) : undefined,\\n+ source: issue.source\\n+ ? {\\n+ filePath: issue.source.source.filePath,\\n+ range: range\\n+ ? {\\n+ start: {\\n+ line: range.start.line + 1,\\n+ column: range.start.column + 1,\\n+ },\\n+ end: {\\n+ line: range.end.line + 1,\\n+ column: range.end.column + 1,\\n+ },\\n+ }\\n+ : undefined,\\n+ }\\n+ : undefined,\\n+ codeFrame: issue.codeFrame ? stripAnsi(issue.codeFrame) : undefined,\\n+ })\\n+ }\\n+\\n+ return formattedIssues\\n+}\",\n \"additions\": 93,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/next/src/server/stream-utils/node-web-streams-helper.ts\",\n \"patch\": \"@@ -22,6 +22,7 @@ import {\\n NEXT_INSTANT_PREFETCH_HEADER,\\n } from '../../client/components/app-router-headers'\\n import { computeCacheBustingSearchParam } from '../../shared/lib/router/utils/cache-busting-search-param'\\n+import type { AnyStream } from '../app-render/stream-ops'\\n \\n function voidCatch() {\\n // this catcher is designed to be used with pipeTo where we expect the underlying\\n@@ -125,12 +126,58 @@ function concatUint8Arrays(chunks: Array<Uint8Array>): Uint8Array {\\n return result\\n }\\n \\n-export async function streamToUint8Array(\\n+export async function webstreamToUint8Array(\\n stream: ReadableStream<Uint8Array>\\n ): Promise<Uint8Array> {\\n return concatUint8Arrays(await streamToChunks(stream))\\n }\\n \\n+function webToReadable(\\n+ stream: ReadableStream<Uint8Array> | import('node:stream').Readable\\n+): import('node:stream').Readable {\\n+ let Readable: typeof import('node:stream').Readable\\n+ if (process.env.TURBOPACK) {\\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\\n+ } else if (process.env.__NEXT_BUNDLER === 'Webpack') {\\n+ Readable = (\\n+ __non_webpack_require__('node:stream') as typeof import('node:stream')\\n+ ).Readable\\n+ } else {\\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\\n+ }\\n+ if (stream instanceof Readable) {\\n+ return stream\\n+ }\\n+ return Readable.fromWeb(stream as import('stream/web').ReadableStream)\\n+}\\n+\\n+export async function nodestreamToUint8Array(\\n+ stream: AnyStream\\n+): Promise<Uint8Array> {\\n+ const chunks: Buffer[] = []\\n+ for await (const chunk of webToReadable(stream)) {\\n+ chunks.push(typeof chunk === 'string' ? Buffer.from(chunk) : chunk)\\n+ }\\n+ return Buffer.concat(chunks)\\n+}\\n+\\n+export async function streamToUint8Array(stream: AnyStream) {\\n+ let Readable: typeof import('node:stream').Readable\\n+ if (process.env.TURBOPACK) {\\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\\n+ } else if (process.env.__NEXT_BUNDLER === 'Webpack') {\\n+ Readable = (\\n+ __non_webpack_require__('node:stream') as typeof import('node:stream')\\n+ ).Readable\\n+ } else {\\n+ Readable = (require('node:stream') as typeof import('node:stream')).Readable\\n+ }\\n+ if (stream instanceof Readable) {\\n+ return nodestreamToUint8Array(stream)\\n+ }\\n+ return webstreamToUint8Array(stream)\\n+}\\n+\\n export async function streamToBuffer(\\n stream: ReadableStream<Uint8Array>\\n ): Promise<Buffer> {\",\n \"additions\": 48,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/next/src/telemetry/events/build.ts\",\n \"patch\": \"@@ -259,6 +259,7 @@ export type McpToolName =\\n | 'mcp/get_project_metadata'\\n | 'mcp/get_routes'\\n | 'mcp/get_server_action_by_id'\\n+ | 'mcp/get_compilation_issues'\\n \\n export type EventMcpToolUsage = {\\n toolName: McpToolName\",\n \"additions\": 1,\n \"deletions\": 0\n },\n {\n \"filename\": \"packages/react-refresh-utils/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/react-refresh-utils\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"description\\\": \\\"An experimental package providing utilities for React Refresh.\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\",\n \"additions\": 1,\n \"deletions\": 1\n },\n {\n \"filename\": \"packages/third-parties/package.json\",\n \"patch\": \"@@ -1,6 +1,6 @@\\n {\\n \\\"name\\\": \\\"@next/third-parties\\\",\\n- \\\"version\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"version\\\": \\\"16.2.1-canary.18\\\",\\n \\\"repository\\\": {\\n \\\"url\\\": \\\"vercel/next.js\\\",\\n \\\"directory\\\": \\\"packages/third-parties\\\"\\n@@ -26,7 +26,7 @@\\n \\\"third-party-capital\\\": \\\"1.0.20\\\"\\n },\\n \\\"devDependencies\\\": {\\n- \\\"next\\\": \\\"16.2.1-canary.17\\\",\\n+ \\\"next\\\": \\\"16.2.1-canary.18\\\",\\n \\\"outdent\\\": \\\"0.8.0\\\",\\n \\\"prettier\\\": \\\"2.5.1\\\",\\n \\\"typescript\\\": \\\"5.9.2\\\"\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"pnpm-lock.yaml\",\n \"patch\": \"@@ -1017,7 +1017,7 @@ importers:\\n packages/eslint-config-next:\\n dependencies:\\n '@next/eslint-plugin-next':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../eslint-plugin-next\\n eslint:\\n specifier: '>=9.0.0'\\n@@ -1094,7 +1094,7 @@ importers:\\n packages/next:\\n dependencies:\\n '@next/env':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../next-env\\n '@swc/helpers':\\n specifier: 0.5.15\\n@@ -1219,19 +1219,19 @@ importers:\\n specifier: 1.2.0\\n version: 1.2.0\\n '@next/font':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../font\\n '@next/polyfill-module':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../next-polyfill-module\\n '@next/polyfill-nomodule':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../next-polyfill-nomodule\\n '@next/react-refresh-utils':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../react-refresh-utils\\n '@next/swc':\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../next-swc\\n '@opentelemetry/api':\\n specifier: 1.6.0\\n@@ -1955,7 +1955,7 @@ importers:\\n version: 1.0.20\\n devDependencies:\\n next:\\n- specifier: 16.2.1-canary.17\\n+ specifier: 16.2.1-canary.18\\n version: link:../next\\n outdent:\\n specifier: 0.8.0\",\n \"additions\": 8,\n \"deletions\": 8\n },\n {\n \"filename\": \"test/development/mcp-server/fixtures/compilation-errors-app/app/layout.tsx\",\n \"patch\": \"@@ -0,0 +1,11 @@\\n+export default function RootLayout({\\n+ children,\\n+}: {\\n+ children: React.ReactNode\\n+}) {\\n+ return (\\n+ <html lang=\\\"en\\\">\\n+ <body>{children}</body>\\n+ </html>\\n+ )\\n+}\",\n \"additions\": 11,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/development/mcp-server/fixtures/compilation-errors-app/app/missing-module/page.tsx\",\n \"patch\": \"@@ -0,0 +1,5 @@\\n+import { something } from './non-existent-module'\\n+\\n+export default function MissingModulePage() {\\n+ return <div>{something}</div>\\n+}\",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/development/mcp-server/fixtures/compilation-errors-app/app/page.tsx\",\n \"patch\": \"@@ -0,0 +1,3 @@\\n+export default function HomePage() {\\n+ return <div>Home Page - No Errors</div>\\n+}\",\n \"additions\": 3,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/development/mcp-server/fixtures/compilation-errors-app/app/syntax-error/page.tsx\",\n \"patch\": \"@@ -0,0 +1,3 @@\\n+export default function SyntaxErrorPage() {\\n+ return <div>Broken JSX\\n+}\",\n \"additions\": 3,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/development/mcp-server/fixtures/compilation-errors-app/next.config.js\",\n \"patch\": \"@@ -0,0 +1,5 @@\\n+module.exports = {\\n+ experimental: {\\n+ mcpServer: true,\\n+ },\\n+}\",\n \"additions\": 5,\n \"deletions\": 0\n },\n {\n \"filename\": \"test/development/mcp-server/mcp-server-get-compilation-issues.test.ts\",\n \"patch\": \"@@ -0,0 +1,92 @@\\n+import path from 'path'\\n+import { nextTestSetup } from 'e2e-utils'\\n+\\n+// get_compilation_issues is a Turbopack-only feature (requires NAPI project handle)\\n+;(process.env.IS_TURBOPACK_TEST ? describe : describe.skip)(\\n+ 'mcp-server get_compilation_issues tool',\\n+ () => {\\n+ const { next, skipped } = nextTestSetup({\\n+ files: path.join(__dirname, 'fixtures', 'compilation-errors-app'),\\n+ skipDeployment: true,\\n+ })\\n+\\n+ if (skipped) {\\n+ return\\n+ }\\n+\\n+ async function callMcpTool() {\\n+ const response = await fetch(`${next.url}/_next/mcp`, {\\n+ method: 'POST',\\n+ headers: {\\n+ 'Content-Type': 'application/json',\\n+ Accept: 'application/json, text/event-stream',\\n+ },\\n+ body: JSON.stringify({\\n+ jsonrpc: '2.0',\\n+ id: 'get-compilation-issues',\\n+ method: 'tools/call',\\n+ params: { name: 'get_compilation_issues', arguments: {} },\\n+ }),\\n+ })\\n+\\n+ const text = await response.text()\\n+ const match = text.match(/data: ({.*})/s)\\n+ expect(match).toBeTruthy()\\n+ const result = JSON.parse(match![1])\\n+ return JSON.parse(result.result?.content?.[0]?.text)\\n+ }\\n+\\n+ type Issue = { severity: string; filePath: string; title: string }\\n+\\n+ let compilationResult: { issues: Issue[] }\\n+\\n+ beforeAll(async () => {\\n+ compilationResult = await callMcpTool()\\n+ })\\n+\\n+ function errorIssues() {\\n+ return compilationResult.issues.filter(\\n+ (issue) => issue.severity === 'error' || issue.severity === 'fatal'\\n+ )\\n+ }\\n+\\n+ it('should return compilation issues without requiring a browser session', () => {\\n+ expect(compilationResult).toHaveProperty('issues')\\n+ expect(Array.isArray(compilationResult.issues)).toBe(true)\\n+ })\\n+\\n+ it('should detect module-not-found errors', () => {\\n+ const errors = errorIssues()\\n+ expect(errors.length).toBeGreaterThan(0)\\n+\\n+ const moduleNotFoundIssue = errors.find(\\n+ (issue) =>\\n+ issue.filePath.includes('missing-module') ||\\n+ issue.title.includes('non-existent-module')\\n+ )\\n+ expect(moduleNotFoundIssue).toBeDefined()\\n+ })\\n+\\n+ it('should detect syntax errors', () => {\\n+ const errors = errorIssues()\\n+ const syntaxErrorIssue = errors.find((issue) =>\\n+ issue.filePath.includes('syntax-error')\\n+ )\\n+ expect(syntaxErrorIssue).toBeDefined()\\n+ })\\n+\\n+ it('should include issue metadata fields', () => {\\n+ const errors = errorIssues()\\n+ expect(errors.length).toBeGreaterThan(0)\\n+\\n+ const issue = errors[0]\\n+ expect(issue).toHaveProperty('severity')\\n+ expect(issue).toHaveProperty('filePath')\\n+ expect(issue).toHaveProperty('title')\\n+ expect(typeof issue.severity).toBe('string')\\n+ expect(typeof issue.filePath).toBe('string')\\n+ // title must be a plain string, not a StyledString object\\n+ expect(typeof issue.title).toBe('string')\\n+ })\\n+ }\\n+)\",\n \"additions\": 92,\n \"deletions\": 0\n },\n {\n \"filename\": \"turbopack/crates/turbo-rcstr/Cargo.toml\",\n \"patch\": \"@@ -18,6 +18,10 @@ new_debug_unreachable = \\\"1.0.6\\\"\\n shrink-to-fit = { workspace = true }\\n rustc-hash = { workspace = true }\\n bytes-str = { workspace = true }\\n+inventory = { workspace = true }\\n+smallvec = { workspace = true }\\n+turbo-bincode = { workspace = true }\\n+unty = { workspace = true }\\n \\n [target.'cfg(not(target_family = \\\"wasm\\\"))'.dependencies]\\n napi = { workspace = true, optional = true }\",\n \"additions\": 4,\n \"deletions\": 0\n },\n {\n \"filename\": \"turbopack/crates/turbo-rcstr/src/dynamic.rs\",\n \"patch\": \"@@ -70,10 +70,16 @@ pub(crate) fn new_atom<T: AsRef<str> + Into<String>>(text: T) -> RcStr {\\n \\n let hash = hash_bytes(text.as_ref().as_bytes());\\n \\n- let entry: Arc<PrehashedString> = Arc::new(PrehashedString {\\n+ let prehashed = PrehashedString {\\n value: Payload::String(text.into()),\\n hash,\\n- });\\n+ };\\n+ new_atom_from_prehashed(prehashed)\\n+}\\n+\\n+/// Construct a new dynamic RcStr from a PrehashedString\\n+pub(crate) fn new_atom_from_prehashed(prehashed: PrehashedString) -> RcStr {\\n+ let entry: Arc<PrehashedString> = Arc::new(prehashed);\\n let entry = Arc::into_raw(entry);\\n \\n let ptr: NonNull<PrehashedString> = unsafe {\",\n \"additions\": 8,\n \"deletions\": 2\n },\n {\n \"filename\": \"turbopack/crates/turbo-rcstr/src/lib.rs\",\n \"patch\": \"@@ -1,30 +1,34 @@\\n use std::{\\n borrow::{Borrow, Cow},\\n+ collections::HashMap,\\n ffi::OsStr,\\n fmt::{Debug, Display},\\n hash::{Hash, Hasher},\\n mem::{ManuallyDrop, forget},\\n num::NonZeroU8,\\n ops::Deref,\\n path::{Path, PathBuf},\\n+ sync::LazyLock,\\n };\\n \\n use bincode::{\\n Decode, Encode,\\n- de::Decoder,\\n+ de::{Decoder, read::Reader},\\n enc::Encoder,\\n error::{DecodeError, EncodeError},\\n impl_borrow_decode,\\n };\\n use bytes_str::BytesStr;\\n use debug_unreachable::debug_unreachable;\\n+use rustc_hash::FxBuildHasher;\\n use serde::{Deserialize, Deserializer, Serialize, Serializer};\\n use shrink_to_fit::ShrinkToFit;\\n+use smallvec::SmallVec;\\n use triomphe::Arc;\\n use turbo_tasks_hash::{DeterministicHash, DeterministicHasher};\\n \\n use crate::{\\n- dynamic::{deref_from, hash_bytes, new_atom},\\n+ dynamic::{deref_from, hash_bytes, new_atom, new_atom_from_prehashed, new_static_atom},\\n tagged_value::TaggedValue,\\n };\\n \\n@@ -159,6 +163,32 @@ impl RcStr {\\n pub fn map(self, f: impl FnOnce(String) -> String) -> Self {\\n RcStr::from(Cow::Owned(f(self.into_owned())))\\n }\\n+\\n+ /// Create an RcStr from a deserialized string, checking the static constant\\n+ /// table first. If the string matches an `rcstr!` constant, returns a\\n+ /// zero-cost static copy instead of allocating a new Arc.\\n+ ///\\n+ /// Accepts `&str` so that borrow-decode paths can avoid heap allocation\\n+ /// entirely for inline strings (≤6 bytes) and static table hits.\\n+ fn from_deserialized(s: &str) -> Self {\\n+ let len = s.len();\\n+ if len >= tagged_value::MAX_INLINE_LEN {\\n+ let hash = hash_bytes(s.as_bytes());\\n+ // Check the static table\\n+ if let Some(entries) = STATIC_TABLE.get(&hash)\\n+ && let Some(static_phs) = entries.iter().find(|phs| phs.value.as_str() == s)\\n+ {\\n+ new_static_atom(static_phs)\\n+ } else {\\n+ new_atom_from_prehashed(PrehashedString {\\n+ hash,\\n+ value: dynamic::Payload::String(s.into()),\\n+ })\\n+ }\\n+ } else {\\n+ inline_atom(s).unwrap()\\n+ }\\n+ }\\n }\\n \\n impl DeterministicHash for RcStr {\\n@@ -377,8 +407,25 @@ impl Serialize for RcStr {\\n \\n impl<'de> Deserialize<'de> for RcStr {\\n fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> {\\n- let s = String::deserialize(deserializer)?;\\n- Ok(RcStr::from(s))\\n+ struct RcStrVisitor;\\n+\\n+ impl serde::de::Visitor<'_> for RcStrVisitor {\\n+ type Value = RcStr;\\n+\\n+ fn expecting(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {\\n+ f.write_str(\\\"a string\\\")\\n+ }\\n+\\n+ fn visit_str<E: serde::de::Error>(self, v: &str) -> Result<RcStr, E> {\\n+ Ok(RcStr::from_deserialized(v))\\n+ }\\n+\\n+ fn visit_string<E: serde::de::Error>(self, v: String) -> Result<RcStr, E> {\\n+ Ok(RcStr::from_deserialized(&v))\\n+ }\\n+ }\\n+\\n+ deserializer.deserialize_str(RcStrVisitor)\\n }\\n }\\n \\n@@ -390,7 +437,29 @@ impl Encode for RcStr {\\n \\n impl<Context> Decode<Context> for RcStr {\\n fn decode<D: Decoder<Context = Context>>(decoder: &mut D) -> Result<Self, DecodeError> {\\n- Ok(RcStr::from(String::decode(decoder)?))\\n+ // Decode the length prefix\\n+ let len = u64::decode(decoder)?;\\n+ let len: usize = len\\n+ .try_into()\\n+ .map_err(|_| DecodeError::OutsideUsizeRange(len))?;\\n+\\n+ if unty::type_equal::<D::R, turbo_bincode::TurboBincodeReader>() {\\n+ // We know the reader is a TurboBincodeReader backed by &[u8], so peek_read\\n+ // returning None means data corruption (not enough bytes), not \\\"unsupported\\\".\\n+ let bytes = decoder\\n+ .reader()\\n+ .peek_read(len)\\n+ .ok_or(DecodeError::UnexpectedEnd { additional: len })?;\\n+ let s = core::str::from_utf8(bytes).map_err(|inner| DecodeError::Utf8 { inner })?;\\n+ let rcstr = RcStr::from_deserialized(s);\\n+ decoder.reader().consume(len);\\n+ Ok(rcstr)\\n+ } else {\\n+ unreachable!(\\n+ \\\"RcStr::decode expected TurboBincodeReader, but was called with a {} reader\\\",\\n+ std::any::type_name::<D::R>(),\\n+ )\\n+ }\\n }\\n }\\n \\n@@ -433,8 +502,46 @@ pub const fn make_const_prehashed_string(text: &'static str) -> PrehashedString\\n }\\n }\\n \\n+// Re-export inventory so the rcstr! macro can reference it via $crate::inventory\\n+#[doc(hidden)]\\n+pub use inventory;\\n+\\n+/// Wrapper for collecting `rcstr!` static constants via `inventory`.\\n+#[doc(hidden)]\\n+pub struct StaticRcStr(pub &'static PrehashedString);\\n+\\n+inventory::collect!(StaticRcStr);\\n+\\n+/// Read-only lookup table mapping precomputed hash -> static PrehashedString.\\n+/// Built once on first access from all `rcstr!` constants collected by `inventory`.\\n+///\\n+/// Multiple `rcstr!` calls with the same string content will each submit to\\n+/// inventory, but we deduplicate by content here so only one entry per unique\\n+/// string is stored.\\n+static STATIC_TABLE: LazyLock<\\n+ HashMap<u64, SmallVec<[&'static PrehashedString; 1]>, FxBuildHasher>,\\n+> = LazyLock::new(|| {\\n+ let mut map: HashMap<u64, SmallVec<[&'static PrehashedString; 1]>, FxBuildHasher> =\\n+ HashMap::with_hasher(FxBuildHasher);\\n+ for StaticRcStr(phs) in inventory::iter::<StaticRcStr> {\\n+ let entries = map.entry(phs.hash).or_default();\\n+ // Deduplicate: skip if an entry with the same string content exists\\n+ // Mostly linkers will merge static strings but this isn't guaranteed so we cannot just rely\\n+ // on pointer equality.\\n+ if !entries\\n+ .iter()\\n+ .any(|e| e.value.as_str() == phs.value.as_str())\\n+ {\\n+ entries.push(phs);\\n+ }\\n+ }\\n+ map.shrink_to_fit(); // this map will never change again\\n+ map\\n+});\\n+\\n /// Create an rcstr from a string literal.\\n-/// allocates the RcStr inline when possible otherwise uses a `LazyLock` to manage the allocation.\\n+/// Allocates the RcStr inline when possible, otherwise uses a static `PrehashedString`. In either\\n+/// case this is a compile time constant\\n #[macro_export]\\n macro_rules! rcstr {\\n ($s:expr) => {{\\n@@ -447,6 +554,8 @@ macro_rules! rcstr {\\n // Allocate static storage for the PrehashedString\\n static RCSTR_STORAGE: $crate::PrehashedString =\\n $crate::make_const_prehashed_string($s);\\n+ // Register with inventory so deserialization can find this static\\n+ $crate::inventory::submit!($crate::StaticRcStr(&RCSTR_STORAGE));\\n // This basically just tags a bit onto the raw pointer and wraps it in an RcStr\\n // should be fast enough to do every time.\\n $crate::from_static(&RCSTR_STORAGE)\\n@@ -624,4 +733,33 @@ mod tests {\\n }\\n }\\n }\\n+\\n+ #[test]\\n+ fn test_bincode_roundtrip() {\\n+ use turbo_bincode::{turbo_bincode_decode, turbo_bincode_encode};\\n+\\n+ // Test inline string\\n+ let short = RcStr::from(\\\"hi\\\");\\n+ let encoded = turbo_bincode_encode(&short).unwrap();\\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\\n+ assert_eq!(decoded, short);\\n+ assert_eq!(decoded.tag(), INLINE_TAG);\\n+\\n+ // Test dynamic string (no static match)\\n+ let long = RcStr::from(\\\"bincode_roundtrip: no matching rcstr constant\\\");\\n+ let encoded = turbo_bincode_encode(&long).unwrap();\\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\\n+ assert_eq!(decoded, long);\\n+ assert_eq!(decoded.tag(), DYNAMIC_TAG);\\n+\\n+ // Test static dedup via decode\\n+ const STATIC_STR: &str = \\\"bincode_roundtrip: a static constant for testing\\\";\\n+ let _register = rcstr!(STATIC_STR);\\n+ let original = RcStr::from(STATIC_STR); // DYNAMIC since from() doesn't check\\n+ let encoded = turbo_bincode_encode(&original).unwrap();\\n+ let decoded: RcStr = turbo_bincode_decode(&encoded).unwrap();\\n+ assert_eq!(decoded.as_str(), STATIC_STR);\\n+ // Decoded via peek_read path should find the static constant\\n+ assert_eq!(decoded.tag(), STATIC_TAG);\\n+ }\\n }\",\n \"additions\": 144,\n \"deletions\": 6\n },\n {\n \"filename\": \"turbopack/crates/turbo-tasks-backend/src/backend/mod.rs\",\n \"patch\": \"@@ -55,10 +55,10 @@ use crate::{\\n backend::{\\n operation::{\\n AggregationUpdateJob, AggregationUpdateQueue, ChildExecuteContext,\\n- CleanupOldEdgesOperation, ComputeDirtyAndCleanUpdate, ConnectChildOperation,\\n- ExecuteContext, ExecuteContextImpl, LeafDistanceUpdateQueue, Operation, OutdatedEdge,\\n- TaskGuard, TaskType, connect_children, get_aggregation_number, get_uppers,\\n- is_root_node, make_task_dirty_internal, prepare_new_children,\\n+ CleanupOldEdgesOperation, ConnectChildOperation, ExecuteContext, ExecuteContextImpl,\\n+ LeafDistanceUpdateQueue, Operation, OutdatedEdge, TaskGuard, TaskType,\\n+ connect_children, get_aggregation_number, get_uppers, is_root_node,\\n+ make_task_dirty_internal, prepare_new_children,\\n },\\n storage::Storage,\\n storage_schema::{TaskStorage, TaskStorageAccessors},\\n@@ -955,7 +955,13 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n }\\n \\n // Cell should exist, but data was dropped or is not serializable. We need to recompute the\\n- // task the get the cell content.\\n+ // task to get the cell content.\\n+\\n+ // Bail early if the task was cancelled — no point in registering a listener\\n+ // on a task that won't execute again.\\n+ if is_cancelled {\\n+ bail!(\\\"{} was canceled\\\", task.get_task_description());\\n+ }\\n \\n // Listen to the cell and potentially schedule the task\\n let (listener, new_listener) = self.listen_to_cell(&mut task, task_id, &reader_task, cell);\\n@@ -971,11 +977,6 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n )\\n .entered();\\n \\n- // Schedule the task, if not already scheduled\\n- if is_cancelled {\\n- bail!(\\\"{} was canceled\\\", task.get_task_description());\\n- }\\n-\\n let _ = task.add_scheduled(\\n TaskExecutionReason::CellNotAvailable,\\n EventDescription::new(|| task.get_task_desc_fn()),\\n@@ -1857,7 +1858,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n turbo_tasks: &dyn TurboTasksBackendApi<TurboTasksBackend<B>>,\\n ) {\\n let mut ctx = self.execute_context(turbo_tasks);\\n- let mut task = ctx.task(task_id, TaskDataCategory::Data);\\n+ let mut task = ctx.task(task_id, TaskDataCategory::All);\\n if let Some(in_progress) = task.take_in_progress() {\\n match in_progress {\\n InProgressState::Scheduled {\\n@@ -1870,8 +1871,35 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n InProgressState::Canceled => {}\\n }\\n }\\n+ // Notify any readers waiting on in-progress cells so their listeners\\n+ // resolve and foreground jobs can finish (prevents stop_and_wait hang).\\n+ let in_progress_cells = task.take_in_progress_cells();\\n+ if let Some(ref cells) = in_progress_cells {\\n+ for state in cells.values() {\\n+ state.event.notify(usize::MAX);\\n+ }\\n+ }\\n+\\n+ // Mark the cancelled task as session-dependent dirty so it will be re-executed\\n+ // in the next session. Without this, any reader that encounters the cancelled task\\n+ // records an error in its output. That error is persisted and would poison\\n+ // subsequent builds. By marking the task session-dependent dirty, the next build\\n+ // re-executes it, which invalidates dependents and corrects the stale errors.\\n+ let data_update = if self.should_track_dependencies() && !task_id.is_transient() {\\n+ task.update_dirty_state(Some(Dirtyness::SessionDependent))\\n+ } else {\\n+ None\\n+ };\\n+\\n let old = task.set_in_progress(InProgressState::Canceled);\\n debug_assert!(old.is_none(), \\\"InProgress already exists\\\");\\n+ drop(task);\\n+\\n+ if let Some(data_update) = data_update {\\n+ AggregationUpdateQueue::run(data_update, &mut ctx);\\n+ }\\n+\\n+ drop(in_progress_cells);\\n }\\n \\n fn try_start_task_execution(\\n@@ -2188,23 +2216,33 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n }\\n \\n // handle cell counters: update max index and remove cells that are no longer used\\n- let old_counters: FxHashMap<_, _> = task\\n- .iter_cell_type_max_index()\\n- .map(|(&k, &v)| (k, v))\\n- .collect();\\n- let mut counters_to_remove = old_counters.clone();\\n-\\n- for (&cell_type, &max_index) in cell_counters.iter() {\\n- if let Some(old_max_index) = counters_to_remove.remove(&cell_type) {\\n- if old_max_index != max_index {\\n+ // On error, skip this update: the task may have failed before creating all cells it\\n+ // normally creates, so cell_counters is incomplete. Clearing cell_type_max_index entries\\n+ // based on partial counters would cause \\\"cell no longer exists\\\" errors for tasks that\\n+ // still hold dependencies on those cells. The old cell data is preserved on error\\n+ // (see task_execution_completed_cleanup), so keeping cell_type_max_index consistent with\\n+ // that data is correct.\\n+ // NOTE: This must stay in sync with task_execution_completed_cleanup, which similarly\\n+ // skips cell data removal on error.\\n+ if result.is_ok() {\\n+ let old_counters: FxHashMap<_, _> = task\\n+ .iter_cell_type_max_index()\\n+ .map(|(&k, &v)| (k, v))\\n+ .collect();\\n+ let mut counters_to_remove = old_counters.clone();\\n+\\n+ for (&cell_type, &max_index) in cell_counters.iter() {\\n+ if let Some(old_max_index) = counters_to_remove.remove(&cell_type) {\\n+ if old_max_index != max_index {\\n+ task.insert_cell_type_max_index(cell_type, max_index);\\n+ }\\n+ } else {\\n task.insert_cell_type_max_index(cell_type, max_index);\\n }\\n- } else {\\n- task.insert_cell_type_max_index(cell_type, max_index);\\n }\\n- }\\n- for (cell_type, _) in counters_to_remove {\\n- task.remove_cell_type_max_index(&cell_type);\\n+ for (cell_type, _) in counters_to_remove {\\n+ task.remove_cell_type_max_index(&cell_type);\\n+ }\\n }\\n \\n let mut queue = AggregationUpdateQueue::new();\\n@@ -2605,83 +2643,16 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n }\\n }\\n \\n- // Grab the old dirty state\\n- let old_dirtyness = task.get_dirty().cloned();\\n- let (old_self_dirty, old_current_session_self_clean) = match old_dirtyness {\\n- None => (false, false),\\n- Some(Dirtyness::Dirty(_)) => (true, false),\\n- Some(Dirtyness::SessionDependent) => {\\n- let clean_in_current_session = task.current_session_clean();\\n- (true, clean_in_current_session)\\n- }\\n- };\\n-\\n- // Compute the new dirty state\\n+ // Compute and apply the new dirty state, propagating to aggregating ancestors\\n let session_dependent = task.is_session_dependent();\\n- let (new_dirtyness, new_self_dirty, new_current_session_self_clean) = if session_dependent {\\n- (Some(Dirtyness::SessionDependent), true, true)\\n- } else {\\n- (None, false, false)\\n- };\\n-\\n- // Update the dirty state\\n- let dirty_changed = old_dirtyness != new_dirtyness;\\n- if dirty_changed {\\n- if let Some(value) = new_dirtyness {\\n- task.set_dirty(value);\\n- } else if old_dirtyness.is_some() {\\n- task.take_dirty();\\n- }\\n- }\\n- if old_current_session_self_clean != new_current_session_self_clean {\\n- if new_current_session_self_clean {\\n- task.set_current_session_clean(true);\\n- } else if old_current_session_self_clean {\\n- task.set_current_session_clean(false);\\n- }\\n- }\\n-\\n- // Propagate dirtyness changes\\n- let data_update = if old_self_dirty != new_self_dirty\\n- || old_current_session_self_clean != new_current_session_self_clean\\n- {\\n- let dirty_container_count = task\\n- .get_aggregated_dirty_container_count()\\n- .cloned()\\n- .unwrap_or_default();\\n- let current_session_clean_container_count = task\\n- .get_aggregated_current_session_clean_container_count()\\n- .copied()\\n- .unwrap_or_default();\\n- let result = ComputeDirtyAndCleanUpdate {\\n- old_dirty_container_count: dirty_container_count,\\n- new_dirty_container_count: dirty_container_count,\\n- old_current_session_clean_container_count: current_session_clean_container_count,\\n- new_current_session_clean_container_count: current_session_clean_container_count,\\n- old_self_dirty,\\n- new_self_dirty,\\n- old_current_session_self_clean,\\n- new_current_session_self_clean,\\n- }\\n- .compute();\\n- if result.dirty_count_update - result.current_session_clean_update < 0 {\\n- // The task is clean now\\n- if let Some(activeness_state) = task.get_activeness_mut() {\\n- activeness_state.all_clean_event.notify(usize::MAX);\\n- activeness_state.unset_active_until_clean();\\n- if activeness_state.is_empty() {\\n- task.take_activeness();\\n- }\\n- }\\n- }\\n- result\\n- .aggregated_update(task_id)\\n- .and_then(|aggregated_update| {\\n- AggregationUpdateJob::data_update(&mut task, aggregated_update)\\n- })\\n+ let new_dirtyness = if session_dependent {\\n+ Some(Dirtyness::SessionDependent)\\n } else {\\n None\\n };\\n+ #[cfg(feature = \\\"verify_determinism\\\")]\\n+ let dirty_changed = task.get_dirty().cloned() != new_dirtyness;\\n+ let data_update = task.update_dirty_state(new_dirtyness);\\n \\n #[cfg(feature = \\\"verify_determinism\\\")]\\n let reschedule =\\n@@ -2724,6 +2695,8 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\\n // An error is potentially caused by a eventual consistency, so we avoid updating cells\\n // after an error as it is likely transient and we want to keep the dependent tasks\\n // clean to avoid re-executions.\\n+ // NOTE: This must stay in sync with task_execution_completed_prepare, which similarly\\n+ // skips cell_type_max_index updates on error.\\n if !is_error {\\n // Remove no longer existing cells and\\n // find all outdated data items (removed cells, outdated edges)\",\n \"additions\": 71,\n \"deletions\": 98\n },\n {\n \"filename\": \"turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs\",\n \"patch\": \"@@ -18,6 +18,7 @@ use turbo_tasks::{\\n TurboTasksCallApi, TypedSharedReference, backend::CachedTaskType,\\n };\\n \\n+use self::aggregation_update::ComputeDirtyAndCleanUpdate;\\n use crate::{\\n backend::{\\n EventDescription, OperationGuard, TaskDataCategory, TurboTasksBackend,\\n@@ -757,6 +758,77 @@ pub trait TaskGuard: Debug + TaskStorageAccessors {\\n Some(Dirtyness::SessionDependent) => (true, self.current_session_clean()),\\n }\\n }\\n+ /// Update the task's dirty state to `new_dirtyness`, applying the change to stored fields,\\n+ /// computing the aggregated propagation update, and firing the `all_clean_event` if the task\\n+ /// transitioned to clean.\\n+ ///\\n+ /// Returns an optional `AggregationUpdateJob` that the caller must run via\\n+ /// `AggregationUpdateQueue::run` to propagate the change to aggregating ancestors.\\n+ fn update_dirty_state(\\n+ &mut self,\\n+ new_dirtyness: Option<Dirtyness>,\\n+ ) -> Option<AggregationUpdateJob>\\n+ where\\n+ Self: Sized,\\n+ {\\n+ let task_id = self.id();\\n+ let old_dirtyness = self.get_dirty().cloned();\\n+ let (old_self_dirty, old_current_session_self_clean) = self.dirty_state();\\n+ let (new_self_dirty, new_current_session_self_clean) = match new_dirtyness {\\n+ None => (false, false),\\n+ Some(Dirtyness::Dirty(_)) => (true, false),\\n+ Some(Dirtyness::SessionDependent) => (true, true),\\n+ };\\n+ if old_dirtyness != new_dirtyness {\\n+ if let Some(value) = new_dirtyness {\\n+ self.set_dirty(value);\\n+ } else {\\n+ self.take_dirty();\\n+ }\\n+ }\\n+ if old_current_session_self_clean != new_current_session_self_clean {\\n+ self.set_current_session_clean(new_current_session_self_clean);\\n+ }\\n+ if old_self_dirty == new_self_dirty\\n+ && old_current_session_self_clean == new_current_session_self_clean\\n+ {\\n+ return None;\\n+ }\\n+ let dirty_container_count = self\\n+ .get_aggregated_dirty_container_count()\\n+ .cloned()\\n+ .unwrap_or_default();\\n+ let current_session_clean_container_count = self\\n+ .get_aggregated_current_session_clean_container_count()\\n+ .copied()\\n+ .unwrap_or_default();\\n+ let result = ComputeDirtyAndCleanUpdate {\\n+ old_dirty_container_count: dirty_container_count,\\n+ new_dirty_container_count: dirty_container_count,\\n+ old_current_session_clean_container_count: current_session_clean_container_count,\\n+ new_current_session_clean_container_count: current_session_clean_container_count,\\n+ old_self_dirty,\\n+ new_self_dirty,\\n+ old_current_session_self_clean,\\n+ new_current_session_self_clean,\\n+ }\\n+ .compute();\\n+ // Fire the all_clean_event if the task transitioned to clean\\n+ if result.dirty_count_update - result.current_session_clean_update < 0\\n+ && let Some(activeness_state) = self.get_activeness_mut()\\n+ {\\n+ activeness_state.all_clean_event.notify(usize::MAX);\\n+ activeness_state.unset_active_until_clean();\\n+ if activeness_state.is_empty() {\\n+ self.take_activeness();\\n+ }\\n+ }\\n+ result\\n+ .aggregated_update(task_id)\\n+ .and_then(|aggregated_update| {\\n+ AggregationUpdateJob::data_update(self, aggregated_update)\\n+ })\\n+ }\\n fn dirty_containers(&self) -> impl Iterator<Item = TaskId> {\\n self.dirty_containers_with_count()\\n .map(|(task_id, _)| task_id)\\n@@ -1102,8 +1174,8 @@ impl_operation!(LeafDistanceUpdate leaf_distance_update::LeafDistanceUpdateQueue\\n pub use self::invalidate::TaskDirtyCause;\\n pub use self::{\\n aggregation_update::{\\n- AggregatedDataUpdate, AggregationUpdateJob, ComputeDirtyAndCleanUpdate,\\n- get_aggregation_number, get_uppers, is_aggregating_node, is_root_node,\\n+ AggregatedDataUpdate, AggregationUpdateJob, get_aggregation_number, get_uppers,\\n+ is_aggregating_node, is_root_node,\\n },\\n cleanup_old_edges::OutdatedEdge,\\n connect_children::connect_children,\",\n \"additions\": 74,\n \"deletions\": 2\n }\n]","isConversational":false}}},{"rowIdx":298,"cells":{"repo":{"kind":"string","value":"facebook/react"},"issue_number":{"kind":"number","value":36023,"string":"36,023"},"issue_title":{"kind":"string","value":"Create index.html"},"issue_body":{"kind":"string","value":"<!--\r\n Thanks for submitting a pull request!\r\n We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.\r\n\r\n Before submitting a pull request, please make sure the following is done:\r\n\r\n 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.\r\n 2. Run `yarn` in the repository root.\r\n 3. If you've fixed a bug or added code that should be tested, add tests!\r\n 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.\r\n 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.\r\n 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press \"Inspect\".\r\n 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).\r\n 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.\r\n 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).\r\n 10. If you haven't already, complete the CLA.\r\n\r\n Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html\r\n-->\r\n\r\n## Summary\r\n\r\n<!--\r\n Explain the **motivation** for making this change. What existing problem does the pull request solve?\r\n-->\r\n\r\n## How did you test this change?\r\n\r\n<!--\r\n Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.\r\n How exactly did you verify that your PR solves the issue you wanted to solve?\r\n If you leave this empty, your PR will very likely be closed.\r\n-->\r\n"},"commit_sha":{"kind":"string","value":"abb92660d683958c5e76604fb77f26be5aa305dd"},"files":{"kind":"list like","value":[{"filename":"examples/todo-list/index.html","patch":"@@ -0,0 +1,414 @@\n+<!DOCTYPE html>\n+<html lang=\"zh-CN\">\n+<head>\n+ <meta charset=\"UTF-8\" />\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\" />\n+ <title>React Todo List Example</title>\n+ <style>\n+ * {\n+ box-sizing: border-box;\n+ }\n+\n+ body {\n+ margin: 0;\n+ font-family: Arial, sans-serif;\n+ background: #f5f7fb;\n+ color: #222;\n+ }\n+\n+ .container {\n+ max-width: 760px;\n+ margin: 40px auto;\n+ background: #fff;\n+ border-radius: 12px;\n+ padding: 24px;\n+ box-shadow: 0 8px 24px rgba(0, 0, 0, 0.08);\n+ }\n+\n+ h1 {\n+ margin-top: 0;\n+ font-size: 28px;\n+ }\n+\n+ .desc {\n+ color: #666;\n+ margin-bottom: 20px;\n+ line-height: 1.6;\n+ }\n+\n+ .toolbar {\n+ display: flex;\n+ gap: 12px;\n+ flex-wrap: wrap;\n+ margin-bottom: 16px;\n+ }\n+\n+ .toolbar input {\n+ flex: 1;\n+ min-width: 220px;\n+ padding: 10px 12px;\n+ border: 1px solid #d0d7de;\n+ border-radius: 8px;\n+ font-size: 14px;\n+ }\n+\n+ .toolbar button,\n+ .filters button,\n+ .todo-actions button {\n+ padding: 10px 14px;\n+ border: none;\n+ border-radius: 8px;\n+ cursor: pointer;\n+ font-size: 14px;\n+ }\n+\n+ .toolbar button {\n+ background: #1677ff;\n+ color: #fff;\n+ }\n+\n+ .filters {\n+ display: flex;\n+ gap: 8px;\n+ margin-bottom: 18px;\n+ flex-wrap: wrap;\n+ }\n+\n+ .filters .secondary,\n+ .todo-actions button {\n+ background: #eef2f6;\n+ color: #222;\n+ }\n+\n+ .filters .active {\n+ background: #1677ff;\n+ color: #fff;\n+ }\n+\n+ .todo-list {\n+ list-style: none;\n+ padding: 0;\n+ margin: 0;\n+ }\n+\n+ .todo-item {\n+ display: flex;\n+ align-items: center;\n+ justify-content: space-between;\n+ gap: 12px;\n+ padding: 12px 14px;\n+ border: 1px solid #e5e7eb;\n+ border-radius: 10px;\n+ margin-bottom: 10px;\n+ background: #fafafa;\n+ }\n+\n+ .todo-left {\n+ display: flex;\n+ align-items: center;\n+ gap: 10px;\n+ flex: 1;\n+ min-width: 0;\n+ }\n+\n+ .todo-text {\n+ word-break: break-word;\n+ }\n+\n+ .completed {\n+ text-decoration: line-through;\n+ color: #999;\n+ }\n+\n+ .todo-actions {\n+ display: flex;\n+ gap: 8px;\n+ }\n+\n+ .todo-actions .danger {\n+ background: #ff4d4f;\n+ color: #fff;\n+ }\n+\n+ .stats {\n+ margin-top: 18px;\n+ color: #555;\n+ font-size: 14px;\n+ }\n+\n+ .empty {\n+ padding: 20px;\n+ text-align: center;\n+ color: #888;\n+ border: 1px dashed #d0d7de;\n+ border-radius: 10px;\n+ background: #fcfcfc;\n+ }\n+\n+ .footer-note {\n+ margin-top: 20px;\n+ font-size: 13px;\n+ color: #777;\n+ line-height: 1.6;\n+ }\n+ </style>\n+</head>\n+<body>\n+ <div id=\"root\"></div>\n+\n+ <script crossorigin src=\"https://unpkg.com/react@18/umd/react.development.js\"></script>\n+ <script crossorigin src=\"https://unpkg.com/react-dom@18/umd/react-dom.development.js\"></script>\n+ <script src=\"https://unpkg.com/@babel/standalone/babel.min.js\"></script>\n+\n+ <script type=\"text/babel\">\n+ const {\n+ useState,\n+ useMemo,\n+ useCallback,\n+ useEffect,\n+ createContext,\n+ useContext\n+ } = React;\n+\n+ const TodoContext = createContext(null);\n+\n+ function TodoProvider({ children }) {\n+ const [todos, setTodos] = useState(() => {\n+ const saved = localStorage.getItem(\"react-todo-list\");\n+ if (saved) {\n+ try {\n+ return JSON.parse(saved);\n+ } catch (error) {\n+ console.error(\"Failed to parse local todos:\", error);\n+ }\n+ }\n+\n+ return [\n+ { id: 1, text: \"阅读 React Fiber 架构\", completed: false },\n+ { id: 2, text: \"理解 Hooks 链表存储机制\", completed: true },\n+ { id: 3, text: \"分析 Scheduler 调度流程\", completed: false }\n+ ];\n+ });\n+\n+ const [filter, setFilter] = useState(\"all\");\n+\n+ useEffect(() => {\n+ localStorage.setItem(\"react-todo-list\", JSON.stringify(todos));\n+ }, [todos]);\n+\n+ const addTodo = useCallback((text) => {\n+ const value = String(text).trim();\n+ if (!value) return;\n+\n+ setTodos((prev) => {\n+ const newTodo = {\n+ id: Date.now(),\n+ text: value,\n+ completed: false\n+ };\n+ return [...prev, newTodo];\n+ });\n+ }, []);\n+\n+ const toggleTodo = useCallback((id) => {\n+ setTodos((prev) =>\n+ prev.map((todo) =>\n+ todo.id === id\n+ ? { ...todo, completed: !todo.completed }\n+ : todo\n+ )\n+ );\n+ }, []);\n+\n+ const removeTodo = useCallback((id) => {\n+ setTodos((prev) => prev.filter((todo) => todo.id !== id));\n+ }, []);\n+\n+ const clearCompleted = useCallback(() => {\n+ setTodos((prev) => prev.filter((todo) => !todo.completed));\n+ }, []);\n+\n+ const filteredTodos = useMemo(() => {\n+ if (filter === \"active\") {\n+ return todos.filter((todo) => !todo.completed);\n+ }\n+ if (filter === \"completed\") {\n+ return todos.filter((todo) => todo.completed);\n+ }\n+ return todos;\n+ }, [todos, filter]);\n+\n+ const value = useMemo(() => {\n+ return {\n+ todos,\n+ filter,\n+ setFilter,\n+ addTodo,\n+ toggleTodo,\n+ removeTodo,\n+ clearCompleted,\n+ filteredTodos\n+ };\n+ }, [\n+ todos,\n+ filter,\n+ addTodo,\n+ toggleTodo,\n+ removeTodo,\n+ clearCompleted,\n+ filteredTodos\n+ ]);\n+\n+ return (\n+ <TodoContext.Provider value={value}>\n+ {children}\n+ </TodoContext.Provider>\n+ );\n+ }\n+\n+ function useTodo() {\n+ const context = useContext(TodoContext);\n+ if (!context) {\n+ throw new Error(\"useTodo must be used inside TodoProvider\");\n+ }\n+ return context;\n+ }\n+\n+ function AddTodoForm() {\n+ const [input, setInput] = useState(\"\");\n+ const { addTodo } = useTodo();\n+\n+ const handleSubmit = useCallback((event) => {\n+ event.preventDefault();\n+ addTodo(input);\n+ setInput(\"\");\n+ }, [addTodo, input]);\n+\n+ return (\n+ <form className=\"toolbar\" onSubmit={handleSubmit}>\n+ <input\n+ type=\"text\"\n+ placeholder=\"请输入待办事项\"\n+ value={input}\n+ onChange={(e) => setInput(e.target.value)}\n+ />\n+ <button type=\"submit\">添加任务</button>\n+ </form>\n+ );\n+ }\n+\n+ function FilterBar() {\n+ const { filter, setFilter, clearCompleted } = useTodo();\n+\n+ const filters = [\n+ { key: \"all\", label: \"全部\" },\n+ { key: \"active\", label: \"进行中\" },\n+ { key: \"completed\", label: \"已完成\" }\n+ ];\n+\n+ return (\n+ <div className=\"filters\">\n+ {filters.map((item) => (\n+ <button\n+ key={item.key}\n+ type=\"button\"\n+ className={filter === item.key ? \"active\" : \"secondary\"}\n+ onClick={() => setFilter(item.key)}\n+ >\n+ {item.label}\n+ </button>\n+ ))}\n+ <button type=\"button\" className=\"secondary\" onClick={clearCompleted}>\n+ 清除已完成\n+ </button>\n+ </div>\n+ );\n+ }\n+\n+ function TodoItem({ todo }) {\n+ const { toggleTodo, removeTodo } = useTodo();\n+\n+ return (\n+ <li className=\"todo-item\">\n+ <div className=\"todo-left\">\n+ <input\n+ type=\"checkbox\"\n+ checked={todo.completed}\n+ onChange={() => toggleTodo(todo.id)}\n+ />\n+ <span className={\"todo-text \" + (todo.completed ? \"completed\" : \"\")}>\n+ {todo.text}\n+ </span>\n+ </div>\n+ <div className=\"todo-actions\">\n+ <button type=\"button\" onClick={() => toggleTodo(todo.id)}>\n+ {todo.completed ? \"恢复\" : \"完成\"}\n+ </button>\n+ <button\n+ type=\"button\"\n+ className=\"danger\"\n+ onClick={() => removeTodo(todo.id)}\n+ >\n+ 删除\n+ </button>\n+ </div>\n+ </li>\n+ );\n+ }\n+\n+ function TodoList() {\n+ const { filteredTodos } = useTodo();\n+\n+ if (filteredTodos.length === 0) {\n+ return <div className=\"empty\">当前没有符合条件的任务</div>;\n+ }\n+\n+ return (\n+ <ul className=\"todo-list\">\n+ {filteredTodos.map((todo) => (\n+ <TodoItem key={todo.id} todo={todo} />\n+ ))}\n+ </ul>\n+ );\n+ }\n+\n+ function Stats() {\n+ const { todos } = useTodo();\n+\n+ const total = todos.length;\n+ const completed = todos.filter((todo) => todo.completed).length;\n+ const active = total - completed;\n+\n+ return (\n+ <div className=\"stats\">\n+ 总数：{total}，进行中：{active}，已完成：{completed}\n+ </div>\n+ );\n+ }\n+\n+ function App() {\n+ return (\n+ <TodoProvider>\n+ <div className=\"container\">\n+ <h1>React Todo List 示例</h1>\n+ <p className=\"desc\">\n+ 该示例用于展示 React 的组件化开发、Hooks、Context、\n+ 列表渲染和状态驱动更新机制。\n+ </p>\n+ <AddTodoForm />\n+ <FilterBar />\n+ <TodoList />\n+ <Stats />\n+ <div className=\"footer-note\">\n+ 涉及特性：useState、useEffect、useMemo、useCallback、createContext、useContext\n+ </div>\n+ </div>\n+ </TodoProvider>\n+ );\n+ }\n+\n+ const root = ReactDOM.createRoot(document.getElementById(\"root\"));\n+ root.render(<App />);\n+ </script>\n+</body>\n+</html>","additions":414,"deletions":0}],"string":"[\n {\n \"filename\": \"examples/todo-list/index.html\",\n \"patch\": \"@@ -0,0 +1,414 @@\\n+<!DOCTYPE html>\\n+<html lang=\\\"zh-CN\\\">\\n+<head>\\n+ <meta charset=\\\"UTF-8\\\" />\\n+ <meta name=\\\"viewport\\\" content=\\\"width=device-width, initial-scale=1.0\\\" />\\n+ <title>React Todo List Example</title>\\n+ <style>\\n+ * {\\n+ box-sizing: border-box;\\n+ }\\n+\\n+ body {\\n+ margin: 0;\\n+ font-family: Arial, sans-serif;\\n+ background: #f5f7fb;\\n+ color: #222;\\n+ }\\n+\\n+ .container {\\n+ max-width: 760px;\\n+ margin: 40px auto;\\n+ background: #fff;\\n+ border-radius: 12px;\\n+ padding: 24px;\\n+ box-shadow: 0 8px 24px rgba(0, 0, 0, 0.08);\\n+ }\\n+\\n+ h1 {\\n+ margin-top: 0;\\n+ font-size: 28px;\\n+ }\\n+\\n+ .desc {\\n+ color: #666;\\n+ margin-bottom: 20px;\\n+ line-height: 1.6;\\n+ }\\n+\\n+ .toolbar {\\n+ display: flex;\\n+ gap: 12px;\\n+ flex-wrap: wrap;\\n+ margin-bottom: 16px;\\n+ }\\n+\\n+ .toolbar input {\\n+ flex: 1;\\n+ min-width: 220px;\\n+ padding: 10px 12px;\\n+ border: 1px solid #d0d7de;\\n+ border-radius: 8px;\\n+ font-size: 14px;\\n+ }\\n+\\n+ .toolbar button,\\n+ .filters button,\\n+ .todo-actions button {\\n+ padding: 10px 14px;\\n+ border: none;\\n+ border-radius: 8px;\\n+ cursor: pointer;\\n+ font-size: 14px;\\n+ }\\n+\\n+ .toolbar button {\\n+ background: #1677ff;\\n+ color: #fff;\\n+ }\\n+\\n+ .filters {\\n+ display: flex;\\n+ gap: 8px;\\n+ margin-bottom: 18px;\\n+ flex-wrap: wrap;\\n+ }\\n+\\n+ .filters .secondary,\\n+ .todo-actions button {\\n+ background: #eef2f6;\\n+ color: #222;\\n+ }\\n+\\n+ .filters .active {\\n+ background: #1677ff;\\n+ color: #fff;\\n+ }\\n+\\n+ .todo-list {\\n+ list-style: none;\\n+ padding: 0;\\n+ margin: 0;\\n+ }\\n+\\n+ .todo-item {\\n+ display: flex;\\n+ align-items: center;\\n+ justify-content: space-between;\\n+ gap: 12px;\\n+ padding: 12px 14px;\\n+ border: 1px solid #e5e7eb;\\n+ border-radius: 10px;\\n+ margin-bottom: 10px;\\n+ background: #fafafa;\\n+ }\\n+\\n+ .todo-left {\\n+ display: flex;\\n+ align-items: center;\\n+ gap: 10px;\\n+ flex: 1;\\n+ min-width: 0;\\n+ }\\n+\\n+ .todo-text {\\n+ word-break: break-word;\\n+ }\\n+\\n+ .completed {\\n+ text-decoration: line-through;\\n+ color: #999;\\n+ }\\n+\\n+ .todo-actions {\\n+ display: flex;\\n+ gap: 8px;\\n+ }\\n+\\n+ .todo-actions .danger {\\n+ background: #ff4d4f;\\n+ color: #fff;\\n+ }\\n+\\n+ .stats {\\n+ margin-top: 18px;\\n+ color: #555;\\n+ font-size: 14px;\\n+ }\\n+\\n+ .empty {\\n+ padding: 20px;\\n+ text-align: center;\\n+ color: #888;\\n+ border: 1px dashed #d0d7de;\\n+ border-radius: 10px;\\n+ background: #fcfcfc;\\n+ }\\n+\\n+ .footer-note {\\n+ margin-top: 20px;\\n+ font-size: 13px;\\n+ color: #777;\\n+ line-height: 1.6;\\n+ }\\n+ </style>\\n+</head>\\n+<body>\\n+ <div id=\\\"root\\\"></div>\\n+\\n+ <script crossorigin src=\\\"https://unpkg.com/react@18/umd/react.development.js\\\"></script>\\n+ <script crossorigin src=\\\"https://unpkg.com/react-dom@18/umd/react-dom.development.js\\\"></script>\\n+ <script src=\\\"https://unpkg.com/@babel/standalone/babel.min.js\\\"></script>\\n+\\n+ <script type=\\\"text/babel\\\">\\n+ const {\\n+ useState,\\n+ useMemo,\\n+ useCallback,\\n+ useEffect,\\n+ createContext,\\n+ useContext\\n+ } = React;\\n+\\n+ const TodoContext = createContext(null);\\n+\\n+ function TodoProvider({ children }) {\\n+ const [todos, setTodos] = useState(() => {\\n+ const saved = localStorage.getItem(\\\"react-todo-list\\\");\\n+ if (saved) {\\n+ try {\\n+ return JSON.parse(saved);\\n+ } catch (error) {\\n+ console.error(\\\"Failed to parse local todos:\\\", error);\\n+ }\\n+ }\\n+\\n+ return [\\n+ { id: 1, text: \\\"阅读 React Fiber 架构\\\", completed: false },\\n+ { id: 2, text: \\\"理解 Hooks 链表存储机制\\\", completed: true },\\n+ { id: 3, text: \\\"分析 Scheduler 调度流程\\\", completed: false }\\n+ ];\\n+ });\\n+\\n+ const [filter, setFilter] = useState(\\\"all\\\");\\n+\\n+ useEffect(() => {\\n+ localStorage.setItem(\\\"react-todo-list\\\", JSON.stringify(todos));\\n+ }, [todos]);\\n+\\n+ const addTodo = useCallback((text) => {\\n+ const value = String(text).trim();\\n+ if (!value) return;\\n+\\n+ setTodos((prev) => {\\n+ const newTodo = {\\n+ id: Date.now(),\\n+ text: value,\\n+ completed: false\\n+ };\\n+ return [...prev, newTodo];\\n+ });\\n+ }, []);\\n+\\n+ const toggleTodo = useCallback((id) => {\\n+ setTodos((prev) =>\\n+ prev.map((todo) =>\\n+ todo.id === id\\n+ ? { ...todo, completed: !todo.completed }\\n+ : todo\\n+ )\\n+ );\\n+ }, []);\\n+\\n+ const removeTodo = useCallback((id) => {\\n+ setTodos((prev) => prev.filter((todo) => todo.id !== id));\\n+ }, []);\\n+\\n+ const clearCompleted = useCallback(() => {\\n+ setTodos((prev) => prev.filter((todo) => !todo.completed));\\n+ }, []);\\n+\\n+ const filteredTodos = useMemo(() => {\\n+ if (filter === \\\"active\\\") {\\n+ return todos.filter((todo) => !todo.completed);\\n+ }\\n+ if (filter === \\\"completed\\\") {\\n+ return todos.filter((todo) => todo.completed);\\n+ }\\n+ return todos;\\n+ }, [todos, filter]);\\n+\\n+ const value = useMemo(() => {\\n+ return {\\n+ todos,\\n+ filter,\\n+ setFilter,\\n+ addTodo,\\n+ toggleTodo,\\n+ removeTodo,\\n+ clearCompleted,\\n+ filteredTodos\\n+ };\\n+ }, [\\n+ todos,\\n+ filter,\\n+ addTodo,\\n+ toggleTodo,\\n+ removeTodo,\\n+ clearCompleted,\\n+ filteredTodos\\n+ ]);\\n+\\n+ return (\\n+ <TodoContext.Provider value={value}>\\n+ {children}\\n+ </TodoContext.Provider>\\n+ );\\n+ }\\n+\\n+ function useTodo() {\\n+ const context = useContext(TodoContext);\\n+ if (!context) {\\n+ throw new Error(\\\"useTodo must be used inside TodoProvider\\\");\\n+ }\\n+ return context;\\n+ }\\n+\\n+ function AddTodoForm() {\\n+ const [input, setInput] = useState(\\\"\\\");\\n+ const { addTodo } = useTodo();\\n+\\n+ const handleSubmit = useCallback((event) => {\\n+ event.preventDefault();\\n+ addTodo(input);\\n+ setInput(\\\"\\\");\\n+ }, [addTodo, input]);\\n+\\n+ return (\\n+ <form className=\\\"toolbar\\\" onSubmit={handleSubmit}>\\n+ <input\\n+ type=\\\"text\\\"\\n+ placeholder=\\\"请输入待办事项\\\"\\n+ value={input}\\n+ onChange={(e) => setInput(e.target.value)}\\n+ />\\n+ <button type=\\\"submit\\\">添加任务</button>\\n+ </form>\\n+ );\\n+ }\\n+\\n+ function FilterBar() {\\n+ const { filter, setFilter, clearCompleted } = useTodo();\\n+\\n+ const filters = [\\n+ { key: \\\"all\\\", label: \\\"全部\\\" },\\n+ { key: \\\"active\\\", label: \\\"进行中\\\" },\\n+ { key: \\\"completed\\\", label: \\\"已完成\\\" }\\n+ ];\\n+\\n+ return (\\n+ <div className=\\\"filters\\\">\\n+ {filters.map((item) => (\\n+ <button\\n+ key={item.key}\\n+ type=\\\"button\\\"\\n+ className={filter === item.key ? \\\"active\\\" : \\\"secondary\\\"}\\n+ onClick={() => setFilter(item.key)}\\n+ >\\n+ {item.label}\\n+ </button>\\n+ ))}\\n+ <button type=\\\"button\\\" className=\\\"secondary\\\" onClick={clearCompleted}>\\n+ 清除已完成\\n+ </button>\\n+ </div>\\n+ );\\n+ }\\n+\\n+ function TodoItem({ todo }) {\\n+ const { toggleTodo, removeTodo } = useTodo();\\n+\\n+ return (\\n+ <li className=\\\"todo-item\\\">\\n+ <div className=\\\"todo-left\\\">\\n+ <input\\n+ type=\\\"checkbox\\\"\\n+ checked={todo.completed}\\n+ onChange={() => toggleTodo(todo.id)}\\n+ />\\n+ <span className={\\\"todo-text \\\" + (todo.completed ? \\\"completed\\\" : \\\"\\\")}>\\n+ {todo.text}\\n+ </span>\\n+ </div>\\n+ <div className=\\\"todo-actions\\\">\\n+ <button type=\\\"button\\\" onClick={() => toggleTodo(todo.id)}>\\n+ {todo.completed ? \\\"恢复\\\" : \\\"完成\\\"}\\n+ </button>\\n+ <button\\n+ type=\\\"button\\\"\\n+ className=\\\"danger\\\"\\n+ onClick={() => removeTodo(todo.id)}\\n+ >\\n+ 删除\\n+ </button>\\n+ </div>\\n+ </li>\\n+ );\\n+ }\\n+\\n+ function TodoList() {\\n+ const { filteredTodos } = useTodo();\\n+\\n+ if (filteredTodos.length === 0) {\\n+ return <div className=\\\"empty\\\">当前没有符合条件的任务</div>;\\n+ }\\n+\\n+ return (\\n+ <ul className=\\\"todo-list\\\">\\n+ {filteredTodos.map((todo) => (\\n+ <TodoItem key={todo.id} todo={todo} />\\n+ ))}\\n+ </ul>\\n+ );\\n+ }\\n+\\n+ function Stats() {\\n+ const { todos } = useTodo();\\n+\\n+ const total = todos.length;\\n+ const completed = todos.filter((todo) => todo.completed).length;\\n+ const active = total - completed;\\n+\\n+ return (\\n+ <div className=\\\"stats\\\">\\n+ 总数：{total}，进行中：{active}，已完成：{completed}\\n+ </div>\\n+ );\\n+ }\\n+\\n+ function App() {\\n+ return (\\n+ <TodoProvider>\\n+ <div className=\\\"container\\\">\\n+ <h1>React Todo List 示例</h1>\\n+ <p className=\\\"desc\\\">\\n+ 该示例用于展示 React 的组件化开发、Hooks、Context、\\n+ 列表渲染和状态驱动更新机制。\\n+ </p>\\n+ <AddTodoForm />\\n+ <FilterBar />\\n+ <TodoList />\\n+ <Stats />\\n+ <div className=\\\"footer-note\\\">\\n+ 涉及特性：useState、useEffect、useMemo、useCallback、createContext、useContext\\n+ </div>\\n+ </div>\\n+ </TodoProvider>\\n+ );\\n+ }\\n+\\n+ const root = ReactDOM.createRoot(document.getElementById(\\\"root\\\"));\\n+ root.render(<App />);\\n+ </script>\\n+</body>\\n+</html>\",\n \"additions\": 414,\n \"deletions\": 0\n }\n]","isConversational":false}}},{"rowIdx":299,"cells":{"repo":{"kind":"string","value":"huggingface/transformers"},"issue_number":{"kind":"number","value":45111,"string":"45,111"},"issue_title":{"kind":"string","value":"Fix double softmax in MoE router load-balancing loss"},"issue_body":{"kind":"string","value":"## Summary\n- Several MoE routers applied softmax inside `forward()` but returned the result as `router_logits`. The `load_balancing_loss_func` then applied softmax **again**, computing the aux loss on `softmax(softmax(logits))` which flattens the distribution toward uniform, rendering the load-balancing loss ineffective.\n- Fix: use a separate `router_probs` variable for the softmaxed values used in top-k routing, keeping `router_logits` as raw logits so the loss function's single softmax is correct.\n\n### Source modular files fixed (3):\n- `mixtral/modular_mixtral.py` — `MixtralTopKRouter`\n- `qwen2_moe/modular_qwen2_moe.py` — `Qwen2MoeTopKRouter`\n- `qwen3_vl_moe/modular_qwen3_vl_moe.py` — `Qwen3VLMoeTextTopKRouter`\n\n### Downstream models regenerated by `make fix-repo` (10):\nmixtral, minimax, qwen2_moe, olmoe, flex_olmo, qwen3_moe, qwen3_next, qwen3_omni_moe, qwen3_vl_moe, qwen3_5_moe\n\n## Test plan\n- [x] Verified with debug script that `router_logits` now returns raw logits (row sums ≠ 1.0) instead of probabilities\n- [x] Confirmed `load_balancing_loss_func` applies softmax exactly once\n- [ ] Run MoE model tests: `pytest tests/models/mixtral/ tests/models/qwen2_moe/ tests/models/qwen3_vl_moe/ -v`\n\n🤖 Generated with [Claude Code](https://claude.com/claude-code)"},"commit_sha":{"kind":"string","value":"fb4d936ca1782d8b4311a1a1d1dba0489ae8f7d5"},"files":{"kind":"list like","value":[{"filename":"src/transformers/models/flex_olmo/modeling_flex_olmo.py","patch":"@@ -300,11 +300,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/minimax/modeling_minimax.py","patch":"@@ -464,8 +464,8 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices","additions":2,"deletions":2},{"filename":"src/transformers/models/mixtral/modeling_mixtral.py","patch":"@@ -109,8 +109,8 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices","additions":2,"deletions":2},{"filename":"src/transformers/models/mixtral/modular_mixtral.py","patch":"@@ -183,8 +183,8 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices","additions":2,"deletions":2},{"filename":"src/transformers/models/olmoe/modeling_olmoe.py","patch":"@@ -350,11 +350,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen2_moe/modeling_qwen2_moe.py","patch":"@@ -343,11 +343,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen2_moe/modular_qwen2_moe.py","patch":"@@ -99,11 +99,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen3_5_moe/modeling_qwen3_5_moe.py","patch":"@@ -849,10 +849,10 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen3_moe/modeling_qwen3_moe.py","patch":"@@ -263,11 +263,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen3_next/modeling_qwen3_next.py","patch":"@@ -858,11 +858,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen3_omni_moe/modeling_qwen3_omni_moe.py","patch":"@@ -967,10 +967,10 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n \n@@ -1400,11 +1400,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n \n@@ -2773,11 +2773,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n if self.norm_topk_prob:\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":9,"deletions":9},{"filename":"src/transformers/models/qwen3_vl_moe/modeling_qwen3_vl_moe.py","patch":"@@ -122,10 +122,10 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3},{"filename":"src/transformers/models/qwen3_vl_moe/modular_qwen3_vl_moe.py","patch":"@@ -170,10 +170,10 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\n- router_top_value = router_top_value.to(router_logits.dtype)\n+ router_top_value = router_top_value.to(router_probs.dtype)\n router_scores = router_top_value\n return router_logits, router_scores, router_indices\n ","additions":3,"deletions":3}],"string":"[\n {\n \"filename\": \"src/transformers/models/flex_olmo/modeling_flex_olmo.py\",\n \"patch\": \"@@ -300,11 +300,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/minimax/modeling_minimax.py\",\n \"patch\": \"@@ -464,8 +464,8 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/transformers/models/mixtral/modeling_mixtral.py\",\n \"patch\": \"@@ -109,8 +109,8 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/transformers/models/mixtral/modular_mixtral.py\",\n \"patch\": \"@@ -183,8 +183,8 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits.float(), dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\",\n \"additions\": 2,\n \"deletions\": 2\n },\n {\n \"filename\": \"src/transformers/models/olmoe/modeling_olmoe.py\",\n \"patch\": \"@@ -350,11 +350,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen2_moe/modeling_qwen2_moe.py\",\n \"patch\": \"@@ -343,11 +343,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen2_moe/modular_qwen2_moe.py\",\n \"patch\": \"@@ -99,11 +99,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen3_5_moe/modeling_qwen3_5_moe.py\",\n \"patch\": \"@@ -849,10 +849,10 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen3_moe/modeling_qwen3_moe.py\",\n \"patch\": \"@@ -263,11 +263,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen3_next/modeling_qwen3_next.py\",\n \"patch\": \"@@ -858,11 +858,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen3_omni_moe/modeling_qwen3_omni_moe.py\",\n \"patch\": \"@@ -967,10 +967,10 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \\n@@ -1400,11 +1400,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \\n@@ -2773,11 +2773,11 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n if self.norm_topk_prob:\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 9,\n \"deletions\": 9\n },\n {\n \"filename\": \"src/transformers/models/qwen3_vl_moe/modeling_qwen3_vl_moe.py\",\n \"patch\": \"@@ -122,10 +122,10 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n },\n {\n \"filename\": \"src/transformers/models/qwen3_vl_moe/modular_qwen3_vl_moe.py\",\n \"patch\": \"@@ -170,10 +170,10 @@ def __init__(self, config):\\n def forward(self, hidden_states):\\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\\n router_logits = F.linear(hidden_states, self.weight) # (seq_len, num_experts)\\n- router_logits = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n- router_top_value, router_indices = torch.topk(router_logits, self.top_k, dim=-1) # (seq_len, top_k)\\n+ router_probs = torch.nn.functional.softmax(router_logits, dtype=torch.float, dim=-1)\\n+ router_top_value, router_indices = torch.topk(router_probs, self.top_k, dim=-1) # (seq_len, top_k)\\n router_top_value /= router_top_value.sum(dim=-1, keepdim=True)\\n- router_top_value = router_top_value.to(router_logits.dtype)\\n+ router_top_value = router_top_value.to(router_probs.dtype)\\n router_scores = router_top_value\\n return router_logits, router_scores, router_indices\\n \",\n \"additions\": 3,\n \"deletions\": 3\n }\n]","isConversational":false}}}],"truncated":false,"partial":false},"paginationData":{"pageIndex":2,"numItemsPerPage":100,"numTotalItems":4000,"offset":200,"length":100}},"jwt":"eyJhbGciOiJFZERTQSJ9.eyJyZWFkIjp0cnVlLCJwZXJtaXNzaW9ucyI6eyJyZXBvLmNvbnRlbnQucmVhZCI6dHJ1ZX0sImlhdCI6MTc3NTQ3MjY0OSwic3ViIjoiL2RhdGFzZXRzL2hlbGxvYWRoYXZhbi9naXRodWJfaXNzdWVzIiwiZXhwIjoxNzc1NDc2MjQ5LCJpc3MiOiJodHRwczovL2h1Z2dpbmdmYWNlLmNvIn0.xpddsj7ATbpbq2UfwPLZi53nUdt0P1ZHxiSHxip38ntq33WBaBpxv13OVqa7UqpFLx75QxhL4vXMaLDQwE-tDw","displayUrls":true,"splitSizeSummaries":[{"config":"default","split":"split1","numRows":4000,"numBytesParquet":36047562},{"config":"default","split":"split2","numRows":4000,"numBytesParquet":38333219},{"config":"default","split":"split3","numRows":4000,"numBytesParquet":37420486},{"config":"default","split":"split4","numRows":2402,"numBytesParquet":25518033}]},"discussionsStats":{"closed":0,"open":1,"total":1},"fullWidth":true,"hasGatedAccess":true,"hasFullAccess":true,"isEmbedded":false,"savedQueries":{"community":[],"user":[]}}">
repo stringclasses 8
values | issue_number int64 13k 155k | issue_title stringlengths 3 139 | issue_body stringlengths 4 68.4k ⌀ | commit_sha stringlengths 40 40 | files listlengths 1 300 |
|---|---|---|---|---|---|
facebook/react | 36,054 | [eslint-plugin-react-hooks] Fix typescript typing | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| 0043ffbd1a015ddc799dbc9df5b6a93631b9942d | [
{
"filename": "packages/eslint-plugin-react-hooks/src/index.ts",
"patch": "@@ -58,7 +58,7 @@ const recommendedLatestRuleConfigs: Linter.RulesRecord = {\n const plugins = ['react-hooks'];\n \n type ReactHooksFlatConfig = {\n- plugins: {react: any};\n+ plugins: {'react-hooks': any};\n rules: Linter.RulesR... |
vercel/next.js | 92,210 | Fix DashMap read-write self-deadlock in task_cache causing hangs | ### What?
Fixes a deadlock in the Turbopack backend's `task_cache` DashMap that causes `next` to hang during incremental builds with persistent caching.
### Why?
In `get_or_create_persistent_task` and `get_or_create_transient_task`, `self.task_cache.get(&task_type)` returns a `dashmap::Ref` that holds a **read lock** on a DashMap shard. Although the `TaskId` was copied out with `let task_id = *task_id`, the original `Ref` was not dropped until the end of the `if let` block — which includes the call to `ConnectChildOperation::run`.
`ConnectChildOperation::run` can trigger `AggregationUpdateQueue::process` → `for_each_task_all` → `prepare_tasks_with_callback`, which calls `task_cache.entry(task_type).or_insert(task_id)` — requiring a **write lock** on a `task_cache` shard. When this targets the same shard that the current thread already holds a read lock on, the thread self-deadlocks because dashmap's `RawRwLock` is not reentrant.
Once one thread self-deadlocks, all other tokio worker threads needing that shard pile up behind it, eventually causing a complete system hang where every worker is stuck in `dashmap::lock::RawRwLock::lock_exclusive_slow`.
This was observed as a hang during the 7th incremental build with persistent caching of a large application, with a macOS `sample` trace showing all tokio-runtime-worker threads blocked on `_pthread_cond_wait` inside `lock_exclusive_slow` on the `DashMap<Arc<CachedTaskType>, TaskId>`.
### How?
Use `.map(|r| *r)` to copy the `TaskId` out and drop the `Ref` (releasing the read lock) before calling `ConnectChildOperation::run`:
```rust
// Before: Ref lives until end of `if let` block
if let Some(task_id) = self.task_cache.get(&task_type) {
let task_id = *task_id;
ConnectChildOperation::run(...); // read lock still held!
}
// After: Ref dropped by .map(), read lock released
if let Some(task_id) = self.task_cache.get(&task_type).map(|r| *r) {
ConnectChildOperation::run(...); // no lock held
}
```
Applied to both `get_or_create_persistent_task` and `get_or_create_transient_task`.
| 36f2ee17a4303c3b4bce98c42206d3f71aea8068 | [
{
"filename": "turbopack/crates/turbo-tasks-backend/src/backend/mod.rs",
"patch": "@@ -1532,8 +1532,9 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {\n // Create a single ExecuteContext for both lookup and connect_child\n let mut ctx = self.execute_context(turbo_tasks);\n // F... |
nodejs/node | 62,510 | meta: require DCO signoff in commit message guidelines | Refs: https://github.com/nodejs/core-validate-commit/pull/141 | 804006bfda8f127fe504a6632f9192dedc81e2b7 | [
{
"filename": "doc/contributing/pull-requests.md",
"patch": "@@ -204,6 +204,8 @@ A good commit message should describe what changed and why.\n Bot generated commits are exempt from this requirement. If a commit has\n multiple authors, the `Signed-off-by` line should be added for each author;\n and ... |
electron/electron | 50,645 | fix: glitchy rendering and maximize behavior with different GTK themes | Backport of #50550
See that PR for details.
Notes: Fixed the appearance of maximized windows on GNOME in Wayland, especially when non-default GTK themes like Breeze are set.
| 9b737636cb21922a17f48334b09135cec2dca2a8 | [
{
"filename": "shell/browser/ui/views/client_frame_view_linux.cc",
"patch": "@@ -163,7 +163,7 @@ int ClientFrameViewLinux::ResizingBorderHitTest(const gfx::Point& point) {\n gfx::Rect ClientFrameViewLinux::GetBoundsForClientView() const {\n gfx::Rect client_bounds = bounds();\n if (!frame_->IsFullscreen... |
huggingface/transformers | 45,138 | CI] Small T5 expectations updated | This is a small T5 expectations update.
It is the same for both AMD and NVIDIA A10 GPUs. | 7944af60ca6adb740f36cc909f89321a60dfe4c9 | [
{
"filename": "tests/models/t5/test_modeling_t5.py",
"patch": "@@ -1058,7 +1058,7 @@ def test_small_v1_1_integration_test(self):\n loss = model(input_ids.to(torch_device), labels=labels.to(torch_device)).loss\n mtf_score = -(labels.shape[-1] * loss.item())\n \n- EXPECTED_SCORE = -40.1... |
golang/go | 77,841 | runtime: unified the calculate for max objects per span | the freemark is used for mark the status for one span's slots.
the size can be simplify by directly use the predefined constant
of gc.MaxObjsPerSpan
| d36aa731754912a697d8ca3d82079a067e64acf8 | [
{
"filename": "src/runtime/heapdump.go",
"patch": "@@ -480,7 +480,7 @@ func dumproots() {\n \n // Bit vector of free marks.\n // Needs to be as big as the largest number of objects per span.\n-var freemark [pageSize / 8]bool\n+var freemark [gc.MaxObjsPerSpan]bool\n \n func dumpobjs() {\n \t// To protect mhe... |
ollama/ollama | 15,104 | server: preserve raw manifest bytes during pull | pullModelManifest unmarshals the registry response into a Go struct then re-marshals with json.Marshal before writing to disk. When the registry's JSON formatting or field ordering differs from Go's output, the local SHA256 won't match the registry's Ollama-Content-Digest header, causing false "out of date" warnings.
Preserve the raw bytes from the registry response and write them directly to disk so the local manifest is byte-for-byte identical to what the registry serves. | 6f7b1d9d23f48cd85cfb36b86da2658ebf679fc0 | [
{
"filename": "server/images.go",
"patch": "@@ -578,7 +578,7 @@ func PullModel(ctx context.Context, name string, regOpts *registryOptions, fn fu\n \n \tfn(api.ProgressResponse{Status: \"pulling manifest\"})\n \n-\tmf, err := pullModelManifest(ctx, n, regOpts)\n+\tmf, manifestData, err := pullModelManifest(c... |
rust-lang/rust | 154,743 | Remove an unused `StableHash` impl. | r? @TaKO8Ki | c3d9f996c462b99ad29f20ff064eb49a622d755c | [
{
"filename": "compiler/rustc_middle/src/ich/impls_syntax.rs",
"patch": "@@ -4,7 +4,7 @@\n use rustc_ast as ast;\n use rustc_data_structures::stable_hasher::{HashStable, StableHasher};\n use rustc_hir as hir;\n-use rustc_span::{SourceFile, Symbol, sym};\n+use rustc_span::{Symbol, sym};\n use smallvec::Small... |
vercel/next.js | 92,209 | turbopack: avoid duplicate matches for slash-ambiguous patterns | ### What?
- Deduplicate identical `PatternMatch` entries returned by `read_matches`
- Preserve the earliest match position when collapsing duplicates so result ordering stays stable
- Add a regression test for slash-ambiguous `path.join(...)`-style patterns
### Why?
`path.join(...)` can produce multiple slash/no-slash pattern alternatives that resolve to the same real file. `read_matches` was returning each of those alternatives separately, which inflated the "matches N files" warning.
In the reported case from #92201, 1,000 real files could be reported as 16,000 matches.
### How?
- Make `PatternMatch` hashable
- Collect `read_matches` output into a dedupe map keyed by the final match
- Keep the lowest alternative index for stable sorting after deduplication
- Extend `test_read_matches` to assert the slash-ambiguous pattern only returns unique files
Closes NEXT-
Fixes #92201
| c3e78d6cfe0517256b3ceb10df3c10b644160af4 | [
{
"filename": "turbopack/crates/turbopack-core/src/resolve/pattern.rs",
"patch": "@@ -1,17 +1,17 @@\n use std::{\n- collections::{VecDeque, hash_map::Entry},\n+ collections::{hash_map::Entry, VecDeque},\n mem::take,\n sync::LazyLock,\n };\n \n-use anyhow::{Result, bail};\n+use anyhow::{bail, R... |
electron/electron | 50,644 | fix: glitchy rendering and maximize behavior with different GTK themes | Backport of #50550
See that PR for details.
Notes: Fixed the appearance of maximized windows on GNOME in Wayland, especially when non-default GTK themes like Breeze are set.
| 7590363230fddfe768aa460e5367d0ae20369168 | [
{
"filename": "shell/browser/ui/views/client_frame_view_linux.cc",
"patch": "@@ -163,7 +163,7 @@ int ClientFrameViewLinux::ResizingBorderHitTest(const gfx::Point& point) {\n gfx::Rect ClientFrameViewLinux::GetBoundsForClientView() const {\n gfx::Rect client_bounds = bounds();\n if (!frame_->IsFullscreen... |
nodejs/node | 62,505 | meta: expand memory leak DoS criteria to all DoS | We have dedicated requirements about memory leaks when triaging DoS. These applies in generall to all types of DoS, and many recent reports about DoS attack vectors fail to meet them, resulting in a lot of extra back-and-forth in triaging. Clarify in the threat model by expanding these requirements to all DoS.
Drive-by: clarify criteria of documented JavaScript behavior is that they are included in ECMA262. Also use "Node.js application developer" instead of "user" the refer to the party being vulnerable to avoid confusion.
<!--
Before submitting a pull request, please read:
- the CONTRIBUTING guide at https://github.com/nodejs/node/blob/HEAD/CONTRIBUTING.md
- the commit message formatting guidelines at
https://github.com/nodejs/node/blob/HEAD/doc/contributing/pull-requests.md#commit-message-guidelines
For code changes:
1. Include tests for any bug fixes or new features.
2. Update documentation if relevant.
3. Ensure that `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes.
If you believe this PR should be highlighted in the Node.js CHANGELOG
please add the `notable-change` label.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
-->
| a51256b9d8995c821f468f835c51aec8bede427b | [
{
"filename": "SECURITY.md",
"patch": "@@ -152,28 +152,33 @@ does not trust is considered a vulnerability:\n the correct use of Node.js APIs.\n * The unavailability of the runtime, including the unbounded degradation of its\n performance.\n-* Memory leaks qualify as vulnerabilities when all of the follo... |
ollama/ollama | 15,102 | launch: skip context length warning for MLX models and show model name | We currently just check server context length to do warnings. With the MLX change we should skip that since max context length gets allocated automatically. | 442bff6a5a1750ac996648801d885b139e1272ed | [
{
"filename": "cmd/launch/launch_test.go",
"patch": "@@ -1506,6 +1506,7 @@ func TestConfirmLowContextLength(t *testing.T) {\n \t\tstatusBody string\n \t\tstatusCode int\n \t\tshowParams string // Parameters field returned by /api/show\n+\t\tshowBody string // full JSON body for /api/show (over... |
golang/go | 77,816 | cmd/go: fix toolchain escape via PATH in covermode | When a user has a local Go installation of 1.25.5 but their go.mod
specifies 1.26.0, running a test command with coverage flags like
go test -covermode=count -coverpkg=./... ./... triggers the
GOTOOLCHAIN auto-switch mechanism to use the newer toolchain.
However, b.CovData uses the hardcoded 'go' command to invoke the
builtin tool covdata. Because GOTOOLCHAIN does not modify the system
PATH, exec.LookPath resolves this hardcoded 'go' to the host's older
Go version (e.g., 1.25.5).
Since covdata is a builtin tool built and run dynamically by the go
command, invoking the older go binary to handle the new toolchain's
files causes a fatal mismatch. The build fails with an error like:
compile: version "go1.26.0" does not match go tool version "go1.25.5..."
This CL fixes the issue by replacing the hardcoded 'go' with the
absolute path to the current toolchain's go executable, ensuring the
correct toolchain context is maintained and preventing PATH escape. | 3f679a5196c396643619cf6d29a805e62f75417c | [
{
"filename": "src/cmd/go/internal/work/cover.go",
"patch": "@@ -24,7 +24,8 @@ import (\n func (b *Builder) CovData(a *Action, cmdargs ...any) ([]byte, error) {\n \tcmdline := str.StringList(cmdargs...)\n \targs := append([]string{}, cfg.BuildToolexec...)\n-\targs = append(args, \"go\", \"tool\", \"covdata\... |
huggingface/transformers | 45,136 | Fix #45127: Auto-fix diverged tie_word_embeddings config on save to prevent silent weight corruption | # What does this PR do?
This PR fixes a bug in `PreTrainedModel.save_pretrained()` where `config.tie_word_embeddings` can be inconsistent with the actual weight state, leading to silent model corruption for downstream consumers.
### Problem
After PEFT `merge_and_unload()` (typical scenario: Qwen, Llama, Mistral, etc.), `embed_tokens` and [lm_head](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#2859-2987) weights are separated in memory with different values, but `config.tie_word_embeddings` remains `True`. Currently, [save_pretrained()](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#3168-3452) performs **no validation** of `tie_word_embeddings` against the actual weight state — the incorrect config is written to `config.json` as-is.
This causes two issues:
1. **Reloading via [from_pretrained](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#3726-4219)**: The load-side safety check ([modeling_utils.py:2535-2547](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#L2535-L2547)) detects the inconsistency and refuses to tie, emitting a warning each time — but the config is still semantically wrong.
2. **Downstream tool consumption** (GGUF converters, quantization scripts, etc.): These tools trust `tie_word_embeddings: true` in `config.json` directly, potentially causing **silent weight corruption** — one tensor overwrites the other, producing completely degraded outputs.
### Fix
In [save_pretrained()](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#3168-3452), before writing the config to disk, we detect whether the input/output embeddings have diverged. If so, we automatically set `config.tie_word_embeddings = False` and emit a warning.
**Key safety considerations:**
- **Only triggers when the output embedding key** (e.g., `lm_head.weight`) **is explicitly declared** in the model's [_tied_weights_keys](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#2394-2507) mapping as tied to the input embedding. This prevents false positives on models like Pop2Piano, which uses `tie_word_embeddings=True` for decoder output scaling but does not declare `lm_head.weight` in its [_tied_weights_keys](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#2394-2507) (it only ties `encoder.embed_tokens` and `decoder.embed_tokens` to [shared](file:///d:/transformers/transformers/tests/utils/test_modeling_utils.py#487-506)).
- **Cross-device scenarios** (model parallelism / offloading) are skipped entirely to avoid false positives and potential OOM from implicit device copies.
- **T5 family safety analysis:**
- **T5**: Scaling is decoupled to an independent `scale_decoder_outputs` field (`configuration_t5.py:82-83`) and `tie_word_embeddings` is forced to `True`. Not affected.
- **UMT5**: Config init forcibly overrides `tie_word_embeddings = True` — even if saved as `False`, it's restored on load. Not affected.
- **LongT5, Pop2Piano, SwitchTransformers**: Still read `tie_word_embeddings` for scaling in forward, but these are guarded by the [_tied_weights_keys](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#2394-2507) check described above.
### Changes
**[modeling_utils.py](file:///d:/transformers/transformers/tests/utils/test_modeling_utils.py):**
- Added weight divergence detection + auto-fix logic before config saving in [save_pretrained()](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#3168-3452)
- [_tied_weights_keys](file:///d:/transformers/transformers/src/transformers/modeling_utils.py#2394-2507) guard to only auto-fix when the output embedding is declared as tied to the input embedding
- Cross-device: skip check (avoid false positives and potential OOM)
- `NotImplementedError`: silently ignored (expected for vision/speech backbones)
- Other exceptions: logged via `logger.debug`
**[test_modeling_utils.py](file:///d:/transformers/transformers/tests/utils/test_modeling_utils.py):**
- Added [test_save_pretrained_auto_fixes_diverged_tied_embeddings](file:///d:/transformers/transformers/tests/utils/test_modeling_utils.py#1605-1639): constructs a tied Llama model → simulates weight divergence (PEFT merge) → verifies saved config is corrected + warning is emitted + reloaded weights are preserved correctly
<!-- Remove if not applicable -->
Fixes # #45127
## Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
**we ask that new users do not submit pure code agent PRs** at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read [`CONTRIBUTING.md`](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md).
- [x] I confirm that this is not a pure code agent PR.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
[documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
[here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [x] Did you write any new necessary tests?
## Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @
@CyrilVallez @BenjaminBossan
Models:
- text models: @ArthurZucker @Cyrilvallez
- vision models: @yonigozlan @molbap
- audio models: @eustlb @ebezzam @vasqu
- multimodal models: @zucchini-nlp
- graph models: @clefourrier
Library:
- generate: @zucchini-nlp (visual-language models) or @gante (all others)
- continuous batching: @remi-or @ArthurZucker @McPatate
- pipelines: @Rocketknight1
- tokenizers: @ArthurZucker and @itazap
- trainer: @SunMarc
- attention: @vasqu @ArthurZucker @CyrilVallez
- model loading (from pretrained, etc): @CyrilVallez
- distributed: @3outeille @ArthurZucker
- CIs: @ydshieh
Integrations:
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization: @SunMarc
- kernels: @drbh
- peft: @BenjaminBossan @githubnemo
Devices/Backends:
- AMD ROCm: @ivarflakstad
- Intel XPU: @IlyasMoutawwakil
- Ascend NPU: @ivarflakstad
Documentation: @stevhliu
Research projects are not maintained and should be taken as is.
-->
| 75609b5c47f09ceea94d13cd9fda767c2dbd35f2 | [
{
"filename": "docs/source/en/_toctree.yml",
"patch": "@@ -89,6 +89,8 @@\n title: Experts backends\n - local: continuous_batching\n title: Continuous batching\n+ - local: continuous_batching_architecture\n+ title: Continuous batching architecture\n - local: paged_attention\n ... |
rust-lang/rust | 154,741 | Enforce `#![warn(unreachable_pub)]` in compiletest source | The actual public API surface of compiletest is restricted to two specific modules, `cli` and `rustdoc_gui_test`.
Other items have no reason to be `pub`.
There should be no change to compiletest behaviour. | 14c7788a167723fe95dd3bf1080508db0e250140 | [
{
"filename": "src/tools/compiletest/src/common.rs",
"patch": "@@ -14,7 +14,7 @@ use crate::util::{Utf8PathBufExt, add_dylib_path, string_enum};\n \n string_enum! {\n #[derive(Clone, Copy, PartialEq, Debug)]\n- pub enum TestMode {\n+ pub(crate) enum TestMode {\n Pretty => \"pretty\",\n ... |
vercel/next.js | 92,205 | Fix pr-status.js: retry on API errors and report timed-out jobs | ### What?
Fixes two bugs in `scripts/pr-status.js` that caused the script to silently report zero failures when there were actual CI failures.
### Why?
When running `node scripts/pr-status.js 92080`, the script reported "No failed jobs found" despite the PR having real failures. Two root causes:
1. **Transient API errors silently swallowed.** `getAllJobs()` had a bare `catch { break }` that returned an empty array on any GitHub API error (e.g., HTTP 502). Since the GitHub Actions jobs API for large runs frequently returns transient 502s, this caused false "no failures" reports.
2. **`timed_out` and `startup_failure` jobs were invisible.** The script only checked for `conclusion === 'failure'`, but GitHub uses distinct conclusion values like `timed_out` (job exceeded timeout) and `startup_failure` (runner failed to start). These jobs fell through all filters and were silently omitted from reports.
### How?
**Retry logic in `getAllJobs()`:**
- Retries each paginated API call up to 3 times with 2s/4s backoff
- If all retries fail on the first page, throws an error (no silent empty results)
- If later pages fail after partial data is collected, warns and returns what was fetched
**Broader failure detection with `FAILED_CONCLUSIONS`:**
- Added a shared `FAILED_CONCLUSIONS` set: `{'failure', 'timed_out', 'startup_failure'}`
- Used in `getFailedJobs()`, `categorizeJobs()`, and flaky test detection
- Jobs with non-`failure` conclusions are annotated in the report table (e.g., "(timed_out)")
- `getFailedJobs()` now also returns the `conclusion` field so downstream code can distinguish failure types | 2a642671d724bf697835bb43341d9426ac897bbb | [
{
"filename": "scripts/pr-status.js",
"patch": "@@ -216,15 +216,17 @@ function getRunMetadata(runId) {\n )\n }\n \n+const FAILED_CONCLUSIONS = new Set(['failure', 'timed_out', 'startup_failure'])\n+\n function getFailedJobs(runId) {\n // Fetch all jobs first, then filter for failures in JS.\n // We ca... |
electron/electron | 50,643 | fix: prefill native print dialog options on macOS with OOP printing | Backport of #50600
See that PR for details.
Notes: Fixed an issue where custom options in `webContents.print()` did not prefill the print dialog on macOS. | d191cac698e434a29f171e847e7fc5f6857daa08 | [
{
"filename": "patches/chromium/printing.patch",
"patch": "@@ -68,7 +68,7 @@ index f91857eb0b6ad385721b8224100de26dfdd7dd8d..45e8766fcb8d46d8edc3bf8d21d3f826\n : PdfRenderSettings::Mode::POSTSCRIPT_LEVEL3;\n }\n diff --git a/chrome/browser/printing/print_view_manager_base.cc b/chrome/brow... |
nodejs/node | 62,504 | test_runner: add passed, attempt, and diagnostic to SuiteContext | null | 3a1675c81569ccbda0445b4f316ef9ae63b4d889 | [
{
"filename": "doc/api/test.md",
"patch": "@@ -3875,7 +3875,9 @@ added: v25.0.0\n \n * Type: {number}\n \n-Number of times the test has been attempted.\n+The attempt number of the test. This value is zero-based, so the first attempt is `0`,\n+the second attempt is `1`, and so on. This property is useful in ... |
ollama/ollama | 15,101 | app: fix false "out of date" model warnings | file on disk) against the registry's Ollama-Content-Digest header.
These never matched because PullModel re-serializes the manifest JSON
before writing, producing different bytes than the registry's original.
The fallback comparison (local modified_at vs upstream push time) was
also broken: the generated TypeScript Time class discards the actual
timestamp value, so Date parsing always produced NaN.
Fix by moving the staleness comparison server-side where we have
reliable access to both the local manifest file mtime and the upstream
push time. The /api/v1/model/upstream endpoint now returns a simple
`stale` boolean instead of raw digests for the frontend to compare.
Also adds User-Agent to the CORS allowed headers for dev mode. | c2aa0bdb7470e3bd31444c71044db46511ebad12 | [
{
"filename": "app/ui/app/codegen/gotypes.gen.ts",
"patch": "@@ -550,14 +550,12 @@ export class Error {\n }\n }\n export class ModelUpstreamResponse {\n- digest?: string;\n- pushTime: number;\n+ stale: boolean;\n error?: string;\n \n constructor(source: any = {}) {\n if ('string... |
golang/go | 77,778 | testing: fix construction of the testing artifacts path | The existing implementation had a few problems:
- It constructs a path which starts with a forward slash, which is
then immediately rejected by filepath.Localize() as invalid.
- It did not correctly remove the module path from the import path if
the test was in the root package of the module: it would do the
equivalent of strings.TrimPrefix("example.com/jdoe/loader",
"example.com/jdoe/loader/"), which trims nothing, and leaves the full
module name in the base.
- Tests didn't check for any behaviors related to which artifact path
was selected.
Removed leading slash, handle tests in the root package by omitting the
<pkg> component from the artifact dir path, and add tests.
Fixes #77763
| 9c39392a691a81cef48adde88ab45dc40ed81105 | [
{
"filename": "src/testing/testing.go",
"patch": "@@ -1363,6 +1363,21 @@ func (c *common) makeArtifactDir() (string, error) {\n \t\treturn c.makeTempDir()\n \t}\n \n+\tartifactBase := filepath.Join(artifactDir, c.relativeArtifactBase())\n+\tif err := os.MkdirAll(artifactBase, 0o777); err != nil {\n+\t\tretu... |
facebook/react | 36,052 | Snyk fix 7437f92a28cf1a13f2aafbbf2f46141e | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| 351e7c4bb23eb60ead7b1d91f6e93763893e5217 | [
{
"filename": ".claude/instructions.md",
"patch": "@@ -0,0 +1,46 @@\n+# React\n+\n+**Scope**: All code EXCEPT `/compiler/` (compiler has its own instructions).\n+\n+## Project Structure\n+\n+| Directory | Purpose |\n+|-----------|---------|\n+| `/packages/` | Publishable packages (react, react-dom, schedule... |
electron/electron | 50,642 | ci: add Datadog metrics to clean-src-cache job | #### Description of Change
Enhanced the `clean-src-cache` workflow to capture and report disk space metrics to Datadog. The workflow now:
1. Captures disk space metrics before cleanup (free space and total capacity for both cache volumes)
2. Performs the existing cleanup of files older than 15 days
3. Captures disk space metrics after cleanup
4. Sends all metrics to Datadog via the API, including:
- Free space before/after cleanup
- Space freed during cleanup
- Total capacity
- Tagged by volume (cross-instance-cache, win-cache) for easy filtering
This enables monitoring of cache cleanup effectiveness and disk usage trends over time.
#### Checklist
- [x] PR description included
- [x] I have built and tested this PR
- [ ] `npm test` passes (N/A - workflow configuration change)
- [ ] tests are changed or added (N/A - workflow configuration change)
- [ ] relevant API documentation is updated (N/A - workflow configuration change)
#### Release Notes
Notes: none
https://claude.ai/code/session_013bpDsZLrFDpWMiARNFH4z9 | 0e987bb67a30e5f18ed4bd967a961fd4ed2188fb | [
{
"filename": ".github/workflows/clean-src-cache.yml",
"patch": "@@ -16,6 +16,8 @@ jobs:\n runs-on: electron-arc-centralus-linux-amd64-32core\n permissions:\n contents: read\n+ env:\n+ DD_API_KEY: ${{ secrets.DD_API_KEY }}\n container:\n image: ghcr.io/electron/build:bc2f48b2... |
vercel/next.js | 92,204 | [test] Reduce `elementByCssInstant` timeout to 1ms | Just checking if it's possible. Opus 4.6 claims that the timeout is racing PW's IPC channel. That would be a bug imo. But if it still passes with 1ms timeout, it's less likely a race. | 74c4886d8d9ac76f23fd7ceb879ccad6ba8aeb75 | [
{
"filename": "test/lib/browsers/playwright.ts",
"patch": "@@ -437,7 +437,7 @@ export class Playwright<TCurrent = undefined> {\n /** A replacement for the default `browser.elementByCss` that doesn't wait for the page to fire \"load\". */\n elementByCssInstant(selector: string, opts?: ElementByCssOpts) {... |
nodejs/node | 62,501 | test_runner: add `getTestContext()` public API | Exposes `getTestContext()` function to access test context information from within tests and async operations.
My use case was exposing a pino logger that writes to test diagnostics, but there can be many other usecases:
```mjs
import { prettyFactory } from 'pino-pretty';
const pretty = prettyFactory({ colorize: true });
const asyncId = executionAsyncId();
const t = testResources.get(asyncId);
t.diagnostic(pretty(obj).replace(/\n$/, ''));
``` | 28d1af603354e88bc022d4edf059ebd2f5a9b50a | [
{
"filename": "doc/api/test.md",
"patch": "@@ -3563,6 +3563,44 @@ Emitted when no more tests are queued for execution in watch mode.\n \n Emitted when one or more tests are restarted due to a file change in watch mode.\n \n+## `getTestContext()`\n+\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n+* Returns: {TestC... |
rust-lang/rust | 154,740 | Rollup of 6 pull requests | Successful merges:
- rust-lang/rust#154444 (rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones)
- rust-lang/rust#154590 (Make #[cfg] suggest any or all on #[cfg(a, b)])
- rust-lang/rust#154691 (core: Update the feature gate on `TryFrom<integer> for bool`)
- rust-lang/rust#154697 (rustdoc: fix href of extern crates in search results)
- rust-lang/rust#154728 (rustdoc: Improve internal function name)
- rust-lang/rust#154732 (fix(std): avoid AT_MINSIGSTKSZ on uclibc targets)
Failed merges:
- rust-lang/rust#154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
<!-- homu-ignore:start -->
r? @ghost
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=154444,154590,154691,154697,154722,154728,154732)
<!-- homu-ignore:end -->
| 53af5aba8ff98338c0747ff3169fe780e6c2ef09 | [
{
"filename": "library/std/src/sys/pal/unix/stack_overflow.rs",
"patch": "@@ -305,7 +305,7 @@ mod imp {\n }\n \n /// Modern kernels on modern hardware can have dynamic signal stack sizes.\n- #[cfg(any(target_os = \"linux\", target_os = \"android\"))]\n+ #[cfg(all(any(target_os = \"linux\", tar... |
ollama/ollama | 15,100 | anthropic: fix KV cache reuse degraded by tool call argument reordering | Use typed structs for tool call arguments instead of map[string]any to preserve JSON key order, which Go maps do not guarantee. | 95311f607e180f5781a608343db6d94816ce989a | [
{
"filename": "anthropic/anthropic.go",
"patch": "@@ -68,7 +68,7 @@ type MessagesRequest struct {\n \tModel string `json:\"model\"`\n \tMaxTokens int `json:\"max_tokens\"`\n \tMessages []MessageParam `json:\"messages\"`\n-\tSystem any `json:\"system,... |
facebook/react | 36,050 | fix(compiler): preserve HTML entities in JSX text by correctly detecting non-empty lines | null | 8d7d13a5f123c80ccc4967532d9edba7992176b1 | [
{
"filename": "compiler/packages/babel-plugin-react-compiler/src/HIR/BuildHIR.ts",
"patch": "@@ -3563,7 +3563,7 @@ function trimJsxText(original: string): string | null {\n let lastNonEmptyLine = 0;\n \n for (let i = 0; i < lines.length; i++) {\n- if (lines[i].match(/[^ \\t]/)) {\n+ if (lines[i].t... |
electron/electron | 50,641 | fix: extension service workers not starting beyond first app launch | Backport of #50611
See that PR for details.
Notes: Fixed certain DevTools extension panels not showing without a page reload.
| e7e9b9781505cde074609e3002ee351a98004688 | [
{
"filename": "shell/browser/extensions/electron_extension_loader.cc",
"patch": "@@ -28,6 +28,7 @@\n #include \"extensions/common/error_utils.h\"\n #include \"extensions/common/file_util.h\"\n #include \"extensions/common/manifest_constants.h\"\n+#include \"extensions/common/manifest_handlers/background_inf... |
huggingface/transformers | 45,135 | Fix model saving corruption for dynamically untied embeddings | # What does this PR do?
Fixes an issue where PEFT adapters applied independently to tied embeddings (`embed_tokens` and [lm_head](cci:1://file:///d:/transformers/transformers/src/transformers/modeling_utils.py:2858:4-2985:26)) cause silent model corruption upon reloading via `AutoModelForCausalLM.from_pretrained()`.
**Root Cause:**
When embeddings are untied dynamically during runtime (e.g., vocabulary resizing and independent PEFT merging), their tensor memory storage diverges. `PreTrainedModel.save_pretrained()` correctly saves both parameter tensors because [remove_tied_weights_from_state_dict()](cci:1://file:///d:/transformers/transformers/src/transformers/modeling_utils.py:391:0-468:21) sees they don't share identical storage. However, the model configuration saves `tie_word_embeddings = True`. Upon reloading, [from_pretrained()](cci:1://file:///d:/transformers/transformers/src/transformers/modeling_utils.py:3696:4-4188:20) sees `tie_word_embeddings=True` and aggressively re-ties the two embeddings by overwriting one parameter with the other, effectively destroying the independent delta weights.
**Fix:**
Included a check in [save_pretrained()](cci:1://file:///d:/transformers/transformers/src/transformers/modeling_utils.py:3167:4-3469:13): if `config.tie_word_embeddings` is `True` but `input_embeddings.weight.data_ptr() != output_embeddings.weight.data_ptr()`, it automatically flips `model.config.tie_word_embeddings` to `False` before saving the configuration mapping, preventing silent destruction on loading.
<!-- Remove if not applicable -->
Fixes # #45127
## Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
**we ask that new users do not submit pure code agent PRs** at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read [`CONTRIBUTING.md`](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md).
- [x] I confirm that this is not a pure code agent PR.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
[documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
[here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?
*(Note: A minimal reproduction script is provided below to easily test and validate the fix, as it requires mocking PEFT adaptation)*
Reproduction Script
<details><summary>Click to view minimal repro (repro.py)</summary>
```python
import torch
import gc
from transformers import AutoModelForCausalLM, AutoConfig
def main():
# Make a tiny dummy model with tied embeddings
config = AutoConfig.from_pretrained("Qwen/Qwen1.5-0.5B", trust_remote_code=True)
config.hidden_size = 32
config.intermediate_size = 64
config.num_hidden_layers = 2
config.num_attention_heads = 4
config.num_key_value_heads = 4
config.vocab_size = 1000
config.tie_word_embeddings = True
# Needs to be small to fit in memory
model = AutoModelForCausalLM.from_config(config)
print("Initial tie config:", model.config.tie_word_embeddings)
print("Are weights tied initially?", id(model.get_input_embeddings().weight) == id(model.get_output_embeddings().weight))
# Suppose PEFT does something and they are no longer tied
model.get_output_embeddings().weight = torch.nn.Parameter(model.get_output_embeddings().weight.clone())
model.get_output_embeddings().weight.data += 1.0 # Modify to make them different
print("Are weights tied after fake PEFT?", id(model.get_input_embeddings().weight) == id(model.get_output_embeddings().weight))
model.save_pretrained("./test_tied_model")
# Reload
model_reloaded = AutoModelForCausalLM.from_pretrained("./test_tied_model")
print("Reloaded tie config:", model_reloaded.config.tie_word_embeddings)
print("Are weights tied after reload?", id(model_reloaded.get_input_embeddings().weight) == id(model_reloaded.get_output_embeddings().weight))
# Check if the output embeddings weight is equal to input embeddings
print("Is the modified output weight preserved?", not torch.allclose(model_reloaded.get_output_embeddings().weight, model_reloaded.get_input_embeddings().weight))
if __name__ == "__main__":
main()
```
</details>
## Who can review?
@BenjaminBossan @githubnemo
<!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @
If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**.
Please tag fewer than 3 people.
Models:
- text models: @ArthurZucker @Cyrilvallez
- vision models: @yonigozlan @molbap
- audio models: @eustlb @ebezzam @vasqu
- multimodal models: @zucchini-nlp
- graph models: @clefourrier
Library:
- generate: @zucchini-nlp (visual-language models) or @gante (all others)
- continuous batching: @remi-or @ArthurZucker @McPatate
- pipelines: @Rocketknight1
- tokenizers: @ArthurZucker and @itazap
- trainer: @SunMarc
- attention: @vasqu @ArthurZucker @CyrilVallez
- model loading (from pretrained, etc): @CyrilVallez
- distributed: @3outeille @ArthurZucker
- CIs: @ydshieh
Integrations:
- ray/raytune: @richardliaw, @amogkam
- Big Model Inference: @SunMarc
- quantization: @SunMarc
- kernels: @drbh
- peft: @BenjaminBossan @githubnemo
Devices/Backends:
- AMD ROCm: @ivarflakstad
- Intel XPU: @IlyasMoutawwakil
- Ascend NPU: @ivarflakstad
Documentation: @stevhliu
Research projects are not maintained and should be taken as is.
-->
| 458cc1339ca623d962c236c276151ca0c46b17b5 | [
{
"filename": "docs/source/en/_toctree.yml",
"patch": "@@ -89,6 +89,8 @@\n title: Experts backends\n - local: continuous_batching\n title: Continuous batching\n+ - local: continuous_batching_architecture\n+ title: Continuous batching architecture\n - local: paged_attention\n ... |
rust-lang/rust | 154,739 | ci: update upload-artifact action to v7 | Closes https://github.com/rust-lang/rust/issues/154738 | 8798ba69439d71c4a84635d5dc891e748dec9e4f | [
{
"filename": ".github/workflows/ci.yml",
"patch": "@@ -254,7 +254,7 @@ jobs:\n df -h\n \n - name: upload artifacts to github\n- uses: actions/upload-artifact@v4\n+ uses: actions/upload-artifact@v7\n with:\n # name is set in previous step\n name: ${{... |
vercel/next.js | 92,202 | Update .gitignore | <!-- Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below.
Choose the right checklist for the change(s) that you're making:
## For Contributors
### Improving Documentation
- Run `pnpm prettier-fix` to fix formatting issues before opening the PR.
- Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide
### Fixing a bug
- Related issues linked using `fixes #number`
- Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md
### Adding a feature
- Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas)
- Related issues/discussions are linked using `fixes #number`
- e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs)
- Documentation added
- Telemetry added. In case of a feature if it's used or not.
- Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md
## For Maintainers
- Minimal description (aim for explaining to someone not on the team to understand the PR)
- When linking to a Slack thread, you might want to share details of the conclusion
- Link both the Linear (Fixes NEXT-xxx) and the GitHub issues
- Add review comments if necessary to explain to the reviewer the logic behind a change
### What?
### Why?
### How?
Closes NEXT-
Fixes #
-->
| 8a60957224f18cc15ca2d173f6730430b45ad129 | [
{
"filename": ".gitignore",
"patch": "@@ -1,3 +1,4 @@\n+#test-harsh-ht\n # build output\n dist\n !.github/actions/*/dist",
"additions": 1,
"deletions": 0
}
] |
ollama/ollama | 15,098 | parsers: qwen3.5 streaming tool-call parsing and add regression test | null | ae874abfd03be7829d418312db9a035fea3799f8 | [
{
"filename": "model/parsers/qwen35_test.go",
"patch": "@@ -220,6 +220,71 @@ SF\n \t}\n }\n \n+func TestQwen35ParserFakeoutPartialToolCallThenThinkCloseAcrossChunks(t *testing.T) {\n+\tparser := ParserForName(\"qwen3.5\")\n+\tif parser == nil {\n+\t\tt.Fatal(\"expected qwen3.5 parser\")\n+\t}\n+\n+\ttools :... |
golang/go | 77,749 | cmd/go: document -p flag in go help testflag | The -p flag controls the number of packages that can be
tested in parallel by `go test`.
Although the flag is documented in `go help build`,
it is not explicitly documented in `go help testflag`.
This change adds documentation for -p to improve
discoverability and consistency with other test flags.
Fixes #77746. | 72c53c51ae3c631433ce81a0488ddfa6e8712399 | [
{
"filename": "src/cmd/go/internal/test/test.go",
"patch": "@@ -310,6 +310,11 @@ control the execution of any test:\n \t in parallel as well, according to the setting of the -p flag\n \t (see 'go help build').\n \n+\t-p n\n+\t\tThe number of packages that can be run in parallel.\n+\t\tThe default is G... |
electron/electron | 50,640 | fix: extension service workers not starting beyond first app launch | Backport of #50611
See that PR for details.
Notes: Fixed certain DevTools extension panels not showing without a page reload.
| 0b954156b2a2ed21f746967562c689b503c711d8 | [
{
"filename": "shell/browser/extensions/electron_extension_loader.cc",
"patch": "@@ -28,6 +28,7 @@\n #include \"extensions/common/error_utils.h\"\n #include \"extensions/common/file_util.h\"\n #include \"extensions/common/manifest_constants.h\"\n+#include \"extensions/common/manifest_handlers/background_inf... |
huggingface/transformers | 45,132 | Fix: Remove double softmax in MoE router load-balancing loss (Mixtral, Qwen2MoE, Qwen3VLMoE) | ## Summary
This PR fixes GitHub issue #45120: "Double softmax in MoE router load-balancing loss". MoE routers in Mixtral, Qwen2MoE, and Qwen3VLMoE were applying softmax inside forward(), then the load_balancing_loss_func applied softmax AGAIN, resulting in softmax(softmax(logits)) which flattened routing probabilities.
## Root Cause
Three routers reassigned `router_logits` with softmaxed values, then returned them to load_balancing_loss_func which expected raw logits.
## Solution
Separated concepts: keep raw logits in `router_logits`, use `router_probs` for softmaxed values during routing.
## Changes
- MixtralTopKRouter: Renamed softmax reassignment to router_probs
- Qwen2MoeTopKRouter: Renamed softmax reassignment to router_probs
- Qwen3VLMoeTextTopKRouter: Renamed softmax reassignment to router_probs
- Added comprehensive unit tests verifying router_logits are raw logits
## Impact
- Fine-tuning: Load-balancing loss now receives correct raw logits
- Inference: No changes
- Backward compatible: Only internal computation affected
Fixes #45120 | 6ed3ada4236e70631ad2d309dac3c2b7c93ae696 | [
{
"filename": "tests/models/mixtral/test_modeling_mixtral.py",
"patch": "@@ -203,16 +203,6 @@ def test_small_model_aux_loss(self):\n \n # This is to mimic torch.testing.assert_not_close\n self.assertNotAlmostEqual(include_padding_result.aux_loss.item(), result.aux_loss.item())\n- # fm... |
vercel/next.js | 92,199 | [test] Skip flaky `cached-navigations` tests | Skips all [`@test.source.file:test/e2e/app-dir/segment-cache/cached-navigations/cached-navigations.test.ts @git.branch:canary -@test.status:skip @ci.pipeline.url:*/attempts/1 @test.is_known_flaky:true `](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40test.source.file%3Atest%2Fe2e%2Fapp-dir%2Fsegment-cache%2Fcached-navigations%2Fcached-navigations.test.ts%20%40git.branch%3Acanary%20-%40test.status%3Askip%20%40ci.pipeline.url%3A%2A%2Fattempts%2F1%20%40test.is_known_flaky%3Atrue&agg_m=count&agg_m_source=base&agg_q=%40test.name&agg_q_source=base&agg_t=count&citest_explorer_sort=timestamp%2Cdesc&cols=%40test.status%2Ctimestamp%2C%40duration%2C%40test.type%2C%40test.name%3A619%2C%40test_session.name¤tTab=overview&eventStack=&fromUser=false&index=citest&top_n=15&top_o=top&viz=toplist&x_missing=true&start=1774438780635&end=1775043580635&paused=true) | 39d95b131a6139323f46e340119bb5dc3ae3cc73 | [
{
"filename": "test/e2e/app-dir/segment-cache/cached-navigations/cached-navigations.test.ts",
"patch": "@@ -13,7 +13,8 @@ describe('cached navigations', () => {\n return\n }\n \n- it('serves cached static segments instantly on the second navigation', async () => {\n+ // TODO: flaky\n+ it.skip('serv... |
rust-lang/rust | 154,736 | Add a regression test for the duplicated `crate` keyword in path suggestions | The issue has (long) been fixed, but needs a test.
Closes rust-lang/rust#115858. | e2461cf2add278e00aa30bb0c5935906a5da638b | [
{
"filename": "tests/ui/resolve/path-suggestion-duplicated-crate-keyword.rs",
"patch": "@@ -0,0 +1,20 @@\n+//! Regression test for <https://github.com/rust-lang/rust/issues/115858>.\n+//!\n+//! The compiler used to suggest `crate::crate::unix::linux::system::Y`\n+//! (duplicating the `crate` keyword) instea... |
ollama/ollama | 15,093 | ci: harden cuda include path handling | On windows we can get multiple include dirs, so find where the headers are then copy from that location. | 07625ea633be5fc959d90a5bb01d562339f70da1 | [
{
"filename": "CMakeLists.txt",
"patch": "@@ -284,41 +284,54 @@ if(MLX_ENGINE)\n # The Go mlxrunner sets CUDA_PATH to OLLAMA_INSTALL_DIR so MLX finds them at\n # $CUDA_PATH/include/*.h via NVRTC --include-path.\n if(CUDAToolkit_FOUND)\n- set(_cuda_inc \"${CUDAToolkit_INCLUDE_DIRS}\")\n- ... |
facebook/react | 36,043 | Bump flatted from 3.2.7 to 3.4.1 | Bumps [flatted](https://github.com/WebReflection/flatted) from 3.2.7 to 3.4.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/WebReflection/flatted/commit/2a02dce7c641dec31194c67663f9b0b12e62da20"><code>2a02dce</code></a> 3.4.1</li>
<li><a href="https://github.com/WebReflection/flatted/commit/fba4e8f2e113665da275b19cd0f695f3d98e9416"><code>fba4e8f</code></a> Merge pull request <a href="https://redirect.github.com/WebReflection/flatted/issues/89">#89</a> from WebReflection/python-fix</li>
<li><a href="https://github.com/WebReflection/flatted/commit/5fe86485e6df7f7f34a07a2a85498bd3e17384e7"><code>5fe8648</code></a> added "when in Rome" also a test for PHP</li>
<li><a href="https://github.com/WebReflection/flatted/commit/53517adbefe724fe472b2f9ebcdb01910d0ae3f0"><code>53517ad</code></a> some minor improvement</li>
<li><a href="https://github.com/WebReflection/flatted/commit/b3e2a0c387bf446435fec45ad7f05299f012346f"><code>b3e2a0c</code></a> Fixing recursion issue in Python too</li>
<li><a href="https://github.com/WebReflection/flatted/commit/c4b46dbcbf782326e54ea1b65d3ebb1dc7a23fad"><code>c4b46db</code></a> Add SECURITY.md for security policy and reporting</li>
<li><a href="https://github.com/WebReflection/flatted/commit/f86d071e0f70de5a7d8200198824a3f07fc9c988"><code>f86d071</code></a> Create dependabot.yml for version updates</li>
<li><a href="https://github.com/WebReflection/flatted/commit/d3418c718160eae69dbc0405dce75f7849019e1e"><code>d3418c7</code></a> 3.4.0</li>
<li><a href="https://github.com/WebReflection/flatted/commit/7eb65d857e1a40de11c47461cdbc8541449f0606"><code>7eb65d8</code></a> Merge pull request <a href="https://redirect.github.com/WebReflection/flatted/issues/88">#88</a> from WebReflection/avoid-recusrion</li>
<li><a href="https://github.com/WebReflection/flatted/commit/7774aae45d3775c842abe9d071fd009171a5fc0c"><code>7774aae</code></a> Avoid recursion on parse due possible shenanigans</li>
<li>Additional commits viewable in <a href="https://github.com/WebReflection/flatted/compare/v3.2.7...v3.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | 6f06f2bf3403e194b0fb781e225f57d1ac211b28 | [
{
"filename": "yarn.lock",
"patch": "@@ -9229,15 +9229,10 @@ flat-cache@^4.0.0:\n flatted \"^3.2.9\"\n keyv \"^4.5.4\"\n \n-flatted@^3.1.0:\n- version \"3.2.7\"\n- resolved \"https://registry.yarnpkg.com/flatted/-/flatted-3.2.7.tgz#609f39207cb614b89d0765b477cb2d437fbf9787\"\n- integrity sha512-5n... |
huggingface/transformers | 45,129 | fix(config): annotate PreTrainedConfig.dtype as Any to fix pydantic schema generation (#45070) | ## Problem
Fixes #45070. `PreTrainedConfig.dtype` was annotated as `Union[str, "torch.dtype"] | None`. Since `torch` is only imported under `TYPE_CHECKING`, pydantic's schema builder encounters the `"torch.dtype"` forward reference at runtime and fails with:
```
PydanticUndefinedAnnotation: name 'torch' is not defined
```
This breaks any user code that includes `PreTrainedConfig` as a field in a pydantic model (e.g. vLLM speculator configs, config validators).
The repro from the issue:
```python
from pydantic import BaseModel, ConfigDict, Field
from transformers import PretrainedConfig
class MyModelConfig(BaseModel):
model_config = ConfigDict(arbitrary_types_allowed=True)
sub_config: PretrainedConfig = Field(...)
MyModelConfig.model_rebuild(force=True) # PydanticUndefinedAnnotation
```
## Fix
Change `dtype: Union[str, "torch.dtype"] | None = None` to `dtype: Any = None` as suggested by @zucchini-nlp in the issue.
`Any` is semantically correct for pydantic's purposes — the field accepts string or `torch.dtype` values at runtime. The forward reference is now only needed for static type checkers (which still see the correct type through `TYPE_CHECKING`-gated imports in user code). The runtime behaviour is unchanged.
## Test Plan
- [ ] `MyModelConfig.model_rebuild(force=True)` no longer raises `PydanticUndefinedAnnotation`
- [ ] `PreTrainedConfig` can be used as a pydantic field with `arbitrary_types_allowed=True`
- [ ] Existing dtype handling in `__post_init__` still works (assigns `torch.dtype` objects at runtime)
- [ ] Existing model loading tests pass
🤖 Generated with [Claude Code](https://claude.com/claude-code) | e7dfc6f782b516453b5e9a978292409b93d5d777 | [
{
"filename": "src/transformers/configuration_utils.py",
"patch": "@@ -224,7 +224,11 @@ class PreTrainedConfig(PushToHubMixin, RotaryEmbeddingConfigMixin):\n # Common attributes for all models\n output_hidden_states: bool | None = False\n return_dict: bool | None = True\n- dtype: Union[str, \... |
golang/go | 77,745 | doc/go1.26: document ServeMux trailing slash redirect status change | This CL documents a behavior change in net/http ServeMux
introduced in Go 1.26.
In Go 1.25, trailing slash redirects returned HTTP 301.
In Go 1.26, they now return HTTP 307.
This change is not currently mentioned in the Go 1.26
release notes under net/http.
Verified behavior:
go version go1.25.7 windows/amd64
→ trailing slash redirect returns 301
go version go1.26.0 windows/amd64
→ trailing slash redirect returns 307
Fixes #77741 | f4a642f14c42416974105d14241143dcbff7f789 | [
{
"filename": "src/cmd/vendor/golang.org/x/tools/go/analysis/passes/modernize/doc.go",
"patch": "@@ -91,8 +91,6 @@ The any analyzer suggests replacing uses of the empty interface type,\n `interface{}`, with the `any` alias, which was introduced in Go 1.18.\n This is a purely stylistic change that makes code... |
vercel/next.js | 92,198 | [test] Skip flaky `prefetch-layout-sharing` suite | 1 out of 9 tests fails: [`@test.source.file:test/e2e/app-dir/segment-cache/prefetch-layout-sharing/prefetch-layout-sharing.test.ts @git.branch:canary -@test_session.name:*development* -@test.status:skip @ci.pipeline.url:*/attempts/1 `](https://app.datadoghq.com/ci/test/runs?query=test_level%3Atest%20%40test.source.file%3Atest%2Fe2e%2Fapp-dir%2Fsegment-cache%2Fprefetch-layout-sharing%2Fprefetch-layout-sharing.test.ts%20%40git.branch%3Acanary%20-%40test_session.name%3A%2Adevelopment%2A%20-%40test.status%3Askip%20%40ci.pipeline.url%3A%2A%2Fattempts%2F1&agg_m=count&agg_m_source=base&agg_q=%40test.name&agg_q_source=base&agg_t=count&citest_explorer_sort=timestamp%2Cdesc&cols=%40test.status%2Ctimestamp%2C%40duration%2C%40test.type%2C%40test.name%3A619%2C%40test_session.name¤tTab=overview&eventStack=&fromUser=true&index=citest&top_n=10&top_o=top&viz=stream&x_missing=true&start=1774438780635&end=1775043580635&paused=true) | 4cc947a18a789489654a6479f60dead272781a02 | [
{
"filename": "test/e2e/app-dir/segment-cache/prefetch-layout-sharing/prefetch-layout-sharing.test.ts",
"patch": "@@ -3,7 +3,8 @@ import { Playwright as NextBrowser } from '../../../../lib/next-webdriver'\n import type * as Playwright from 'playwright'\n import { createRouterAct } from 'router-act'\n \n-des... |
electron/electron | 50,639 | fix: extension service workers not starting beyond first app launch | Backport of #50611
See that PR for details.
Notes: Fixed certain DevTools extension panels not showing without a page reload.
| 0e6ff205fd6fa9ca2c07083b44082d82267da5a9 | [
{
"filename": "shell/browser/extensions/electron_extension_loader.cc",
"patch": "@@ -28,6 +28,7 @@\n #include \"extensions/common/error_utils.h\"\n #include \"extensions/common/file_util.h\"\n #include \"extensions/common/manifest_constants.h\"\n+#include \"extensions/common/manifest_handlers/background_inf... |
rust-lang/rust | 154,735 | Use interior mutability for `StableHashingContext::caching_source_map`. | This lets a lot of `&mut hcx` parameters change to `&hcx`, for symmetry with `to_hash_stable_key`, and avoids some unnecessary cloning of `StableHashingContext`. Details in individual commits. | 79b99e682951737086a811a8a725c520c2ccceaa | [
{
"filename": "compiler/rustc_middle/src/ich/hcx.rs",
"patch": "@@ -11,7 +11,6 @@ use rustc_span::{BytePos, CachingSourceMapView, DUMMY_SP, Pos, SourceFile, Span,\n \n // Very often, we are hashing something that does not need the `CachingSourceMapView`, so we\n // initialize it lazily.\n-#[derive(Clone)]\n... |
ollama/ollama | 15,083 | ci: include mlx jit headers on linux | null | 17882660010331a615abc38855985f24fc461abf | [
{
"filename": "CMakeLists.txt",
"patch": "@@ -246,13 +246,21 @@ if(MLX_ENGINE)\n COMPONENT MLX)\n endif()\n \n- # Install CCCL headers for NVRTC JIT compilation at runtime.\n+ # Install headers for NVRTC JIT compilation at runtime.\n # MLX's own install rules use the default compon... |
huggingface/transformers | 45,124 | [Qwen3.5 MoE] Add _tp_plan to ForConditionalGeneration | # What does this PR do?
Adds `_tp_plan = {"lm_head": "colwise_gather_output"}` to `Qwen3_5MoeForConditionalGeneration` (the VL wrapper class).
The text-only `Qwen3_5MoeForCausalLM` already had `_tp_plan`, but the VL variant was missing it. This meant that when using `tp_plan="auto"`, the `lm_head` on the VL model was not sharded — each GPU held a full copy and the all-gather behavior (`colwise_gather_output`) was not applied, which could produce incorrect logits under tensor parallelism.
**Change:** Applied in `modular_qwen3_5_moe.py` (source of truth) and regenerated `modeling_qwen3_5_moe.py`.
**Already in place (no changes needed):**
- `base_model_tp_plan` on `Qwen3_5MoeTextConfig` covers full attention (q/k/v/o_proj, q/k_norm), MoE experts, and shared experts.
**Out of scope (future work):**
- Linear attention (GatedDeltaNet) TP — blocked on `causal_conv1d` DTensor support.
- Vision block TP — pending path resolution investigation.
Fixes #45125
## Code Agent Policy
- [x] I confirm that this is not a pure code agent PR.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
- [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request),
Pull Request section?
- [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link
to it if that's the case.
- [ ] Did you make sure to update the documentation with your changes? Here are the
[documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and
[here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).
- [ ] Did you write any new necessary tests?
## Who can review?
@3outeille @ArthurZucker (distributed / model loading) | c26c592264962ed54f9d525661f3f55d85c61425 | [
{
"filename": "src/transformers/models/qwen3_5_moe/modeling_qwen3_5_moe.py",
"patch": "@@ -2088,6 +2088,7 @@ class Qwen3_5MoeForConditionalGeneration(Qwen3_5MoePreTrainedModel, GenerationMi\n # Reference: fix gemma3 grad acc #37208\n accepts_loss_kwargs = False\n config: Qwen3_5MoeConfig\n+ _... |
facebook/react | 36,041 | Bump undici from 6.23.0 to 6.24.0 in /compiler | Bumps [undici](https://github.com/nodejs/undici) from 6.23.0 to 6.24.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/nodejs/undici/releases">undici's releases</a>.</em></p>
<blockquote>
<h2>v6.24.0</h2>
<h1>Undici v6.24.0 Security Release Notes (LTS)</h1>
<p>This release backports fixes for security vulnerabilities affecting the v6 line.</p>
<h2>Upgrade guidance</h2>
<p>All users on v6 should upgrade to <strong>v6.24.0</strong> or later.</p>
<h2>Fixed advisories</h2>
<ul>
<li>
<p><a href="https://github.com/nodejs/undici/security/advisories/GHSA-2mjp-6q6p-2qxm">GHSA-2mjp-6q6p-2qxm</a> / CVE-2026-1525 (Medium)<br />
Inconsistent interpretation of HTTP requests (request/response smuggling class issue).</p>
</li>
<li>
<p><a href="https://github.com/nodejs/undici/security/advisories/GHSA-f269-vfmq-vjvj">GHSA-f269-vfmq-vjvj</a> / CVE-2026-1528 (High)<br />
Malicious WebSocket 64-bit frame length handling could crash the client.</p>
</li>
<li>
<p><a href="https://github.com/nodejs/undici/security/advisories/GHSA-4992-7rv2-5pvq">GHSA-4992-7rv2-5pvq</a> / CVE-2026-1527 (Medium)<br />
CRLF injection via the <code>upgrade</code> option.</p>
</li>
<li>
<p><a href="https://github.com/nodejs/undici/security/advisories/GHSA-v9p9-hfj2-hcw8">GHSA-v9p9-hfj2-hcw8</a> / CVE-2026-2229 (High)<br />
Unhandled exception from invalid <code>server_max_window_bits</code> in WebSocket permessage-deflate negotiation.</p>
</li>
<li>
<p><a href="https://github.com/nodejs/undici/security/advisories/GHSA-vrm6-8vpv-qv8q">GHSA-vrm6-8vpv-qv8q</a> / CVE-2026-1526 (High)<br />
Unbounded memory consumption in WebSocket permessage-deflate decompression.</p>
</li>
</ul>
<h2>Not applicable to v6</h2>
<ul>
<li><a href="https://github.com/nodejs/undici/security/advisories/GHSA-phc3-fgpg-7m6h">GHSA-phc3-fgpg-7m6h</a> / CVE-2026-2581 affects <code>>= 7.17.0 < 7.24.0</code> only.</li>
</ul>
<h2>Affected and patched ranges (v6)</h2>
<ul>
<li>CVE-2026-1525: affected <code>< 6.24.0</code>, patched <code>6.24.0</code></li>
<li>CVE-2026-1528: affected <code>>= 6.0.0 < 6.24.0</code>, patched <code>6.24.0</code></li>
<li>CVE-2026-1527: affected <code>< 6.24.0</code>, patched <code>6.24.0</code></li>
<li>CVE-2026-2229: affected <code>< 6.24.0</code>, patched <code>6.24.0</code></li>
<li>CVE-2026-1526: affected <code>< 6.24.0</code>, patched <code>6.24.0</code></li>
</ul>
<h2>References</h2>
<ul>
<li>GitHub Security Advisories: <a href="https://github.com/nodejs/undici/security/advisories">https://github.com/nodejs/undici/security/advisories</a></li>
<li>NVD CVE-2026-1525: <a href="https://nvd.nist.gov/vuln/detail/CVE-2026-1525">https://nvd.nist.gov/vuln/detail/CVE-2026-1525</a></li>
<li>NVD CVE-2026-1528: <a href="https://nvd.nist.gov/vuln/detail/CVE-2026-1528">https://nvd.nist.gov/vuln/detail/CVE-2026-1528</a></li>
<li>NVD CVE-2026-1527: <a href="https://nvd.nist.gov/vuln/detail/CVE-2026-1527">https://nvd.nist.gov/vuln/detail/CVE-2026-1527</a></li>
<li>NVD CVE-2026-2229: <a href="https://nvd.nist.gov/vuln/detail/CVE-2026-2229">https://nvd.nist.gov/vuln/detail/CVE-2026-2229</a></li>
<li>NVD CVE-2026-1526: <a href="https://nvd.nist.gov/vuln/detail/CVE-2026-1526">https://nvd.nist.gov/vuln/detail/CVE-2026-1526</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/nodejs/undici/commit/8873c947271faf1ebc455bdc6158ecbc022ecfa9"><code>8873c94</code></a> Bumped v6.24.0</li>
<li><a href="https://github.com/nodejs/undici/commit/411bd01a42e7917009bbf686f7628b99d67bbce9"><code>411bd01</code></a> test(websocket): use node:assert for Node 18 compatibility</li>
<li><a href="https://github.com/nodejs/undici/commit/844bf59699d778944f78a24ae819c0e8f295766e"><code>844bf59</code></a> test: fix http2 lint regressions in backport</li>
<li><a href="https://github.com/nodejs/undici/commit/a444e4f13e8958b4e1ac42bc0d53ace7fba0a9c1"><code>a444e4f</code></a> test: stabilize h2 and tls-cert-leak under current test runner</li>
<li><a href="https://github.com/nodejs/undici/commit/dc032a1050d5489b8ce9b4c22aafba98a942f87b"><code>dc032a1</code></a> fix: h2 CI (<a href="https://redirect.github.com/nodejs/undici/issues/4395">#4395</a>)</li>
<li><a href="https://github.com/nodejs/undici/commit/4cd3f4b3a2ef910ba728c47ae78294d956410450"><code>4cd3f4b</code></a> test: increase bitness in <code>test/fixtures/*.pem</code> (<a href="https://redirect.github.com/nodejs/undici/issues/3659">#3659</a>)</li>
<li><a href="https://github.com/nodejs/undici/commit/7df6442194b7a54e9ac734335e6e0a56a9bc6666"><code>7df6442</code></a> fix: adapt websocket frame-limit handling for v6 parser</li>
<li><a href="https://github.com/nodejs/undici/commit/4e0179ae643e6f4380f24cc3683c1b1ca2afb094"><code>4e0179a</code></a> fix: reject duplicate content-length and host headers</li>
<li><a href="https://github.com/nodejs/undici/commit/5a97f0893b53ba7d1d5549d3df7e55d9c2673f89"><code>5a97f08</code></a> Fix websocket 64-bit length overflow</li>
<li><a href="https://github.com/nodejs/undici/commit/e43e898603dd5e0c14a75b08b83257598d664a39"><code>e43e898</code></a> fix: validate upgrade header to prevent CRLF injection</li>
<li>Additional commits viewable in <a href="https://github.com/nodejs/undici/compare/v6.23.0...v6.24.0">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | 6b6d43eaa67710f24ec257a84ff8b58342e42770 | [
{
"filename": "compiler/yarn.lock",
"patch": "@@ -11080,9 +11080,9 @@ undici-types@~6.19.2:\n integrity sha512-ve2KP6f/JnbPBFyobGHuerC9g1FYGn/F8n1LWTwNxCEzd6IfqTwUQcNXgEtmmQ6DlRrC1hrSrBnCZPokRrDHjw==\n \n undici@^6.19.5:\n- version \"6.23.0\"\n- resolved \"https://registry.yarnpkg.com/undici/-/undici-6.... |
golang/go | 77,714 | crypto/tls: support RA-TLS challenge extension in ClientHello | ### ⚠️ Not ready
This PR should only be considered once the real IANA value is assigned for the RA-TLS extension. See the TODO comment on `extensionRATLS` in `src/crypto/tls/common.go`
I open it so that early adopters of RA-TLS can look at / use the fork in the mean time.
### Summary
This adds server-side support for the Remote Attestation TLS (RA-TLS) challenge extension, as defined in the [RFC-9334](https://www.rfc-editor.org/rfc/rfc9334.html).
When a TLS client includes the RA-TLS extension in its ClientHello, the server can read the challenge bytes and use them to generate a platform-specific attestation evidence (e.g. an Intel TDX) that is bound to the TLS handshake.
### Changes
| File | Change |
|------|--------|
| `src/crypto/tls/common.go` | Added `extensionRATLS` constant (`0xffbb`) and `RATLSChallenge []byte` field to `ClientHelloInfo` |
| `src/crypto/tls/handshake_messages.go` | Added `raTLSChallenge` field to `clientHelloMsg` and unmarshal logic with 8–64 byte length validation |
| `src/crypto/tls/handshake_server.go` | Propagated `raTLSChallenge` from `clientHelloMsg` into `ClientHelloInfo` |
| `src/crypto/tls/handshake_messages_test.go` | Added `TestRATLSChallengeExtension` (8 subtests) |
### Design decisions
- **Server-side only (unmarshal, no marshal):** The Go TLS client does not
need to send this extension; it is consumed by the server to produce
attestation evidence via `GetConfigForClient` or `GetCertificate` callbacks.
- **Length validation:** The challenge must be 8–64 bytes. Empty or
out-of-range payloads are rejected during unmarshal (handshake fails).
- **Extension code `0xffbb`:** Temporary private-use value. Will be
replaced with the IANA-assigned code once the draft is finalized.
- **Optional:** When the extension is absent, `ClientHelloInfo.RATLSChallenge`
is `nil` and the handshake proceeds normally.
### Test coverage
`TestRATLSChallengeExtension` covers:
- Valid challenges at boundary sizes (8, 32, 64 bytes)
- Rejection of undersized (0, 7 bytes) and oversized (65 bytes) payloads
- ClientHello with no RA-TLS extension (field stays nil)
- End-to-end propagation into `ClientHelloInfo.RATLSChallenge`
### References
- RFC: https://www.rfc-editor.org/rfc/rfc9334.html
- Consumer module: https://github.com/Privasys/caddy-ra-tls-module | 5c01c40bdda1fa2b644819be3784956aca3d14d5 | [
{
"filename": ".github/workflows/build.yml",
"patch": "@@ -0,0 +1,62 @@\n+name: Build & Test RA-TLS Go Fork\r\n+\r\n+on:\r\n+ push:\r\n+ branches: [ratls]\r\n+ tags: ['privasys-*']\r\n+ pull_request:\r\n+ branches: [ratls]\r\n+\r\n+permissions:\r\n+ contents: write\r\n+\r\n+jobs:\r\n+ build:\r\... |
vercel/next.js | 92,177 | disable bmi2 in qfilter | Fixes #91708
set the legacy_x86_64_support feature on qfilter to support older intel cpus | 95eb4d22639417110c736d0d17a35ac7a3e69821 | [
{
"filename": "turbopack/crates/turbo-persistence/Cargo.toml",
"patch": "@@ -26,7 +26,8 @@ memmap2 = \"0.9.5\"\n nohash-hasher = { workspace = true }\n parking_lot = { workspace = true }\n pot = \"3.0.0\"\n-qfilter = { version = \"0.3.0-alpha.2\", features = [\"serde\"] }\n+# See https://github.com/vercel/n... |
electron/electron | 50,638 | build: allow clearing src & cross mnt cache via dispatch | #### Description of Change
As in title.
Once-a-day seems to work fine but we're running into issues on occasion even in light of that and it'd be nice to do it on demand.
#### Release Notes
Notes: none | a98f1ff5307700efc19827b5b3463cc80cedd64e | [
{
"filename": ".github/workflows/clean-src-cache.yml",
"patch": "@@ -7,6 +7,7 @@ name: Clean Source Cache\n on:\n schedule:\n - cron: \"0 0 * * *\"\n+ workflow_dispatch:\n \n permissions: {}\n ",
"additions": 1,
"deletions": 0
}
] |
rust-lang/rust | 154,732 | fix(std): avoid AT_MINSIGSTKSZ on uclibc targets | Closes https://github.com/rust-lang/rust/issues/154679
`AT_MINSIGSTKSZ` is not defined on uclibc.
r? @tgross35 | b0c4b6ef461ea4c7c75ac8f7c259247f24b4b5c7 | [
{
"filename": "library/std/src/sys/pal/unix/stack_overflow.rs",
"patch": "@@ -305,7 +305,7 @@ mod imp {\n }\n \n /// Modern kernels on modern hardware can have dynamic signal stack sizes.\n- #[cfg(any(target_os = \"linux\", target_os = \"android\"))]\n+ #[cfg(all(any(target_os = \"linux\", tar... |
ollama/ollama | 15,082 | tui: update chat title | <img width="1006" height="796" alt="CleanShot 2026-03-26 at 15 56 17@2x" src="https://github.com/user-attachments/assets/68d374ad-b35e-485e-989f-81864cbbcac8" /> | 870a24283616c1173acb7e598520fb0c5bf18539 | [
{
"filename": "cmd/tui/tui_test.go",
"patch": "@@ -56,7 +56,7 @@ func launcherTestState() *launch.LauncherState {\n \n func TestMenuRendersPinnedItemsAndMore(t *testing.T) {\n \tview := newModel(launcherTestState()).View()\n-\tfor _, want := range []string{\"Run a model\", \"Launch Claude Code\", \"Launch C... |
huggingface/transformers | 45,123 | Fix PP test_ocr_queries | The `test_ocr_queries` assertion value was wrong, even at the initial commit! I'm not sure how tests passed at the time but they're failing now in the CI. This PR fixes the target value! | 05bc1ef89f0600ab91e6e2655c9ab20b57940f28 | [
{
"filename": "tests/models/pp_chart2table/test_processing_pp_chart2table.py",
"patch": "@@ -40,7 +40,7 @@ def test_ocr_queries(self):\n add_generation_prompt=True,\n )\n inputs = processor(images=image_input, text=inputs, return_tensors=\"pt\")\n- self.assertEqual(inputs[... |
facebook/react | 36,035 | Bump flatted from 3.2.7 to 3.4.1 in /compiler | Bumps [flatted](https://github.com/WebReflection/flatted) from 3.2.7 to 3.4.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/WebReflection/flatted/commit/2a02dce7c641dec31194c67663f9b0b12e62da20"><code>2a02dce</code></a> 3.4.1</li>
<li><a href="https://github.com/WebReflection/flatted/commit/fba4e8f2e113665da275b19cd0f695f3d98e9416"><code>fba4e8f</code></a> Merge pull request <a href="https://redirect.github.com/WebReflection/flatted/issues/89">#89</a> from WebReflection/python-fix</li>
<li><a href="https://github.com/WebReflection/flatted/commit/5fe86485e6df7f7f34a07a2a85498bd3e17384e7"><code>5fe8648</code></a> added "when in Rome" also a test for PHP</li>
<li><a href="https://github.com/WebReflection/flatted/commit/53517adbefe724fe472b2f9ebcdb01910d0ae3f0"><code>53517ad</code></a> some minor improvement</li>
<li><a href="https://github.com/WebReflection/flatted/commit/b3e2a0c387bf446435fec45ad7f05299f012346f"><code>b3e2a0c</code></a> Fixing recursion issue in Python too</li>
<li><a href="https://github.com/WebReflection/flatted/commit/c4b46dbcbf782326e54ea1b65d3ebb1dc7a23fad"><code>c4b46db</code></a> Add SECURITY.md for security policy and reporting</li>
<li><a href="https://github.com/WebReflection/flatted/commit/f86d071e0f70de5a7d8200198824a3f07fc9c988"><code>f86d071</code></a> Create dependabot.yml for version updates</li>
<li><a href="https://github.com/WebReflection/flatted/commit/d3418c718160eae69dbc0405dce75f7849019e1e"><code>d3418c7</code></a> 3.4.0</li>
<li><a href="https://github.com/WebReflection/flatted/commit/7eb65d857e1a40de11c47461cdbc8541449f0606"><code>7eb65d8</code></a> Merge pull request <a href="https://redirect.github.com/WebReflection/flatted/issues/88">#88</a> from WebReflection/avoid-recusrion</li>
<li><a href="https://github.com/WebReflection/flatted/commit/7774aae45d3775c842abe9d071fd009171a5fc0c"><code>7774aae</code></a> Avoid recursion on parse due possible shenanigans</li>
<li>Additional commits viewable in <a href="https://github.com/WebReflection/flatted/compare/v3.2.7...v3.4.1">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/facebook/react/network/alerts).
</details> | 80560961df021a5515337eb62340567672080a27 | [
{
"filename": "compiler/yarn.lock",
"patch": "@@ -5970,15 +5970,10 @@ flat@^5.0.2:\n resolved \"https://registry.npmjs.org/flat/-/flat-5.0.2.tgz\"\n integrity sha512-b6suED+5/3rTpUBdG1gupIl8MPFCAMA0QXwmljLhvCUKcUvdE4gWky9zpuGCcXHOsz4J9wPGNWq6OKpmIzz3hQ==\n \n-flatted@^3.1.0:\n- version \"3.2.7\"\n- re... |
golang/go | 77,705 | cmd/compile: fix typo in comment (nor->not) | Fix typo: change "nor" to "not" in comment in call.go
Fixes #77668 | bf2889c967e770032361dd64f0798a5632931cd2 | [
{
"filename": "src/cmd/compile/internal/types2/call.go",
"patch": "@@ -388,7 +388,7 @@ func (check *Checker) genericExprList(elist []syntax.Expr) (resList []*operand,\n \t}\n \n \t// Before Go 1.21, uninstantiated or partially instantiated argument functions are\n-\t// nor permitted. Checker.funcInst must i... |
rust-lang/rust | 154,731 | llvm: Fix array ABI test to not check equality implementation | LLVM has moved memcmp expansion in the pipeline, resulting in the bcmp call being expanded into loads and register comparisons, which breaks the test.
See llvm/llvm-project#77370
Based on history, I believe the test actually intended validate that these arrays were being passed as pointer arguments, which can be done more directly.
r? @durin42
cc @scottmcm (author of the test being modified)
@rustbot label llvm-main | d6be991fb4da0acac3d9fb2938f9ad00db999c4f | [
{
"filename": "tests/codegen-llvm/array-equality.rs",
"patch": "@@ -1,3 +1,6 @@\n+//@ revisions: llvm-current llvm-next\n+//@[llvm-current] ignore-llvm-version: 23-99\n+//@[llvm-next] min-llvm-version: 23\n //@ compile-flags: -Copt-level=3 -Z merge-functions=disabled\n //@ only-x86_64\n #![crate_type = \"li... |
vercel/next.js | 92,176 | Improve revalidateTag JSDoc to include guidance about required second parameter | ### What?
Improved the JSDoc comment on `revalidateTag` to explain the required second `profile` parameter, linking to `cacheLife` profile docs and mentioning `updateTag` as an alternative for immediate expiration.
### Why?
The TypeScript error "Expected 2 arguments, but got 1" at `revalidateTag` call sites gives no actionable guidance. When users hover over the function in their IDE, the existing JSDoc only says "purge cached data on-demand" — nothing about what the second argument should be or what alternatives exist.
### How?
Added a prose paragraph to the JSDoc describing the `profile` parameter (a `cacheLife` profile like `"max"` or a `{ expire }` object) and pointing users to `updateTag` for immediate expiration in Server Actions. Follows the established JSDoc conventions in the file (no `@param`, `@example`, or `@see` tags).
## PR checklist (Fixing a bug)
- Errors have a helpful link attached: links to `cacheLife` reference, `updateTag` docs, and `revalidateTag` docs | 8481df518bb6730a2b62ea6724c7ccb719530aa6 | [
{
"filename": "test/rspack-dev-tests-manifest.json",
"patch": "@@ -1193,11 +1193,14 @@\n },\n \"test/development/app-dir/server-hmr/server-hmr.test.ts\": {\n \"passed\": [\n+ \"server-hmr CLI/config conflict warning should warn when CLI flag conflicts with config\",\n+ \"server-hmr metadat... |
electron/electron | 50,635 | ci: fix pulling previous object checksums | #### Description of Change
<!--
Thank you for your Pull Request. Please provide a description above and review
the requirements below.
Contributors guide: https://github.com/electron/electron/blob/main/CONTRIBUTING.md
NOTE: PRS submitted without this template will be automatically closed.
-->
Follow-up to #50390. There are two issues that this is fixing:
* When `archive: false` is used for `actions/upload-artifact`, the name of the artifact ends up being the filename, not the name supplied in the `name` input, so it needs to be looked up using that name.
* The parent commit is not guaranteed to have the artifact we're looking for:
* Docs only PRs don't trigger a build and won't upload the artifact
* On release branches we limit concurrency so a given commit may not get a full build run if another PR is merged shortly after it
Removes `dawidd6/action-download-artifact` which in hindsight I shouldn't have added, and it can't handle the non-archived artifacts.
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] PR description included
#### Release Notes
Notes: none <!-- Please add a one-line description for app developers to read in the release notes, or 'none' if no notes relevant to app developers. Examples and help on special cases: https://github.com/electron/clerk/blob/main/README.md#examples -->
| 707ae177998cee2d670440cc4894443c4dc61d22 | [
{
"filename": ".github/actions/build-electron/action.yml",
"patch": "@@ -51,25 +51,12 @@ runs:\n shell: bash\n if: ${{ (github.event_name == 'push' || github.event_name == 'pull_request') && inputs.is-asan != 'true' }}\n env:\n- GH_TOKEN: ${{ github.token }}\n+ GITHUB_TOKEN: ... |
ollama/ollama | 15,080 | launch: hide cline integration | Hide Cline integration for now due to changes of default running methods | f33a8ec9a37357e9cc1f5fc106bdb629387d285e | [
{
"filename": "cmd/launch/registry.go",
"patch": "@@ -33,7 +33,7 @@ type IntegrationInfo struct {\n \tDescription string\n }\n \n-var launcherIntegrationOrder = []string{\"opencode\", \"droid\", \"pi\", \"cline\"}\n+var launcherIntegrationOrder = []string{\"opencode\", \"droid\", \"pi\"}\n \n var integratio... |
golang/go | 77,702 | path/filepath: clarify Dir documentation for Windows | Clarify that on Windows Dir C: returns C:. Fixes #77696 | 3760e7225e90b121d7305beeb7614588c042d523 | [
{
"filename": "src/path/filepath/path.go",
"patch": "@@ -463,6 +463,8 @@ func Base(path string) string {\n // If the path is empty, Dir returns \".\".\n // If the path consists entirely of separators, Dir returns a single separator.\n // The returned path does not end in a separator unless it is the root di... |
vercel/next.js | 92,174 | [backport] Fix CSS HMR on Safari | ## Summary
- Backport of #92123 to `next-16-2` release branch
- Cherry-picked the CSS HMR Safari fix and regenerated turbopack-tests snapshot goldens for the release branch
## Test plan
- [x] `UPDATE=1 cargo nextest r -p turbopack-tests` — all 297 tests pass
- [x] `pnpm build-all` — clean build, no issues with `generated-native.d.ts` | 83064d31b0c75bdd2ff6b12b0b5ceac6a1bc46be | [
{
"filename": "packages/next/src/build/swc/generated-native.d.ts",
"patch": "@@ -153,8 +153,8 @@ export declare function minify(\n export declare function minifySync(input: Buffer, opts: Buffer): TransformOutput\n export interface NapiEndpointConfig {}\n export interface NapiAssetPath {\n- path: RcStr\n- ... |
electron/electron | 50,632 | ci: correct contributing link and add link to ai tool policy | #### Description of Change
This PR fixes the link to our contributing guidelines and adds the link to our ai tool policy that came out since the label was created.
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] PR description included
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).
#### Release Notes
Notes: none
| a551f5483a47c58ddf1d1543f790058ba097db82 | [
{
"filename": ".github/workflows/pull-request-labeled.yml",
"patch": "@@ -72,7 +72,7 @@ jobs:\n \n Hello @${{ github.event.pull_request.user.login }}. Due to the high amount of AI spam PRs we receive, if a PR is detected to be majority AI-generated without disclosure and untested, we will automati... |
rust-lang/rust | 154,728 | rustdoc: Improve internal function name | This functions name totally contradicted what it did. And the only places it was used immediatly `!`ed it. Push the `!` into the function, and rename it to make sense.
Should hopefully result in less head-scratching next time someone looks at this.
r? @GuillaumeGomez
| e469da4f842d71f1d80155676f9f1913d8a9ccd8 | [
{
"filename": "src/librustdoc/clean/cfg.rs",
"patch": "@@ -41,15 +41,15 @@ fn is_simple_cfg(cfg: &CfgEntry) -> bool {\n }\n }\n \n-/// Returns `false` if is `Any`, otherwise returns `true`.\n-fn is_all_cfg(cfg: &CfgEntry) -> bool {\n+/// Returns `true` if is [`CfgEntry::Any`], otherwise returns `false`.... |
facebook/react | 36,034 | Fix: use Object.is for dependency comparison to handle NaN correctly | ## Summary
Previously, the React Compiler generated code using \!==\ for dependency comparison, which doesn't match React's \Object.is\ semantics. This caused NaN in dependency arrays to always trigger re-evaluation since \NaN !== NaN\ is true, but \Object.is(NaN, NaN)\ is true.
## Problem
When a dependency value is NaN, the compiled code would incorrectly detect a change on every render:
\\\js
// Generated code (before fix):
if ($[0] !== nanValue) { // Always true because NaN !== NaN
// Re-computes every time
}
\\\
## Solution
Changed the generated code to use \!Object.is()\ for dependency comparison:
\\\js
// Generated code (after fix):
if (!Object.is($[0], nanValue)) { // Correctly returns false when both are NaN
// Only re-computes when value actually changes
}
\\\
## Test Plan
- Existing compiler tests should pass
- This matches React's documented equality semantics
- Manual verification with the playground repro from #35854
Fixes #35854 | bbad60d0dc35be1026b883395567602fd8feea00 | [
{
"filename": "compiler/packages/babel-plugin-react-compiler/src/ReactiveScopes/CodegenReactiveFunction.ts",
"patch": "@@ -574,14 +574,22 @@ function codegenReactiveScope(\n \n for (const dep of [...scope.dependencies].sort(compareScopeDependency)) {\n const index = cx.nextCacheIndex;\n- const comp... |
huggingface/transformers | 45,122 | :rotating_light: [`LightGlue`] Remove remote code execution | Native model integration should never have anything related to remote code execution: That just means that we would need to add that model natively, not via remote - it can and will not be maintained by us.
Additionally added a new linter rule to check for simple usage of this via `trust_remote_code=...`
NOTE: The breaking part that we effectively deprecate a subset of the lightglue models (which should not have been added this way); see [lightglue_disk](https://huggingface.co/ETH-CVG/lightglue_disk) and this [hub PR](https://huggingface.co/ETH-CVG/lightglue_disk/discussions/2) | fd7d1f56d289f98345d7000833b270ce06132e23 | [
{
"filename": "Makefile",
"patch": "@@ -33,6 +33,7 @@ check-code-quality:\n check-repository-consistency:\n \t@python utils/checkers.py \\\n \t\timports,\\\n+\t\timport_complexity,\\\n \t\tcopies,\\\n \t\tmodular_conversion,\\\n \t\tdoc_toc,\\\n@@ -58,6 +59,7 @@ check-repo:\n \t\tinit_isort,\\\n \t\tauto_ma... |
ollama/ollama | 15,076 | launch: hide vs code | Hide VS Code integration for now while leaving it accessible through `ollama launch vscode` | 8cc7a88e1e9fbccab22a26fa78ff9f73a95f8df9 | [
{
"filename": "cmd/launch/registry.go",
"patch": "@@ -33,7 +33,7 @@ type IntegrationInfo struct {\n \tDescription string\n }\n \n-var launcherIntegrationOrder = []string{\"vscode\", \"opencode\", \"droid\", \"pi\", \"cline\"}\n+var launcherIntegrationOrder = []string{\"opencode\", \"droid\", \"pi\", \"cline... |
golang/go | 77,700 | os: update examples to use errors.Is instead of os.IsExist/IsNotExist | ## Summary
Updated two example functions in `src/os/example_test.go` to use the modern `errors.Is(err, fs.ErrExist)` and `errors.Is(err, fs.ErrNotExist)` instead of the deprecated `os.IsExist(err)` and `os.IsNotExist(err)`.
## Changes
- `ExampleMkdir()`: Changed `!os.IsExist(err)` to `!errors.Is(err, fs.ErrExist)`
- `ExampleUserConfigDir()`: Changed `!os.IsNotExist(err)` to `!errors.Is(err, fs.ErrNotExist)`
The `errors` and `io/fs` packages were already imported in the file.
Fixes #77643 | 9818fc0402d3e3f988588a986c7ea776b4f52e21 | [
{
"filename": "src/os/example_test.go",
"patch": "@@ -246,7 +246,7 @@ func ExampleWriteFile() {\n \n func ExampleMkdir() {\n \terr := os.Mkdir(\"testdir\", 0750)\n-\tif err != nil && !os.IsExist(err) {\n+\tif err != nil && !errors.Is(err, fs.ErrExist) {\n \t\tlog.Fatal(err)\n \t}\n \terr = os.WriteFile(\"te... |
electron/electron | 50,630 | test: add tests for `navigationHistory.goToIndex()` | Backport of #50607
See that PR for details.
Notes: none. | b2cf6aad7f437193dac83b44f7f21bfaef452644 | [
{
"filename": "spec/api-web-contents-spec.ts",
"patch": "@@ -802,6 +802,65 @@ describe('webContents module', () => {\n });\n });\n \n+ describe('navigationHistory.goToIndex(index) API', () => {\n+ beforeEach(async () => {\n+ await w.loadURL(urlPage1);\n+ await w.loadURL(urlPa... |
rust-lang/rust | 154,727 | Rollup of 20 pull requests | Successful merges:
- rust-lang/rust#153105 (Compute the result of a projection type with region errors)
- rust-lang/rust#153532 (Attributes containing rustc)
- rust-lang/rust#153960 (Make `layout_of` cycles fatal errors)
- rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
- rust-lang/rust#154666 (Remove `StableHashContext` impls)
- rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`)
- rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args)
- rust-lang/rust#154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
- rust-lang/rust#153614 (`FindParamInClause` handle edge-cases)
- rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message)
- rust-lang/rust#154425 (Migrate transmute tests)
- rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
- rust-lang/rust#154469 (mGCA: Lower spans for literal const args)
- rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
- rust-lang/rust#154615 (Moving issues)
- rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar)
- rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns)
- rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
- rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
- rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)
<!-- homu-ignore:start -->
r? @ghost
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=153105,153532,153960,154527,154666,154669,154710,154712,153614,154213,154425,154442,154469,154578,154615,154644,154660,154671,154680,154709)
<!-- homu-ignore:end -->
| f3ba2c41e63ac58ae8aafbe7725db6b5e6021d00 | [
{
"filename": "src/librustdoc/clean/inline.rs",
"patch": "@@ -137,7 +137,7 @@ pub(crate) fn try_inline(\n })\n }\n Res::Def(DefKind::Macro(kinds), did) => {\n- let mac = build_macro(cx, did, name, kinds);\n+ let mac = build_macro(cx.tcx, did, name, kinds);\n... |
huggingface/transformers | 45,121 | fix: remove unsafe exec() in serve.py | ## Summary
Fix critical severity security issue in `src/transformers/cli/serve.py`.
## Vulnerability
| Field | Value |
|-------|-------|
| **ID** | V-007 |
| **Severity** | CRITICAL |
| **Scanner** | multi_agent_ai |
| **Rule** | `V-007` |
| **File** | `src/transformers/cli/serve.py:754` |
**Description**: The /load_model endpoint allows loading arbitrary models without authentication or validation. Attackers can load malicious pickle files containing arbitrary Python code that executes during deseri...
## Changes
- `src/transformers/cli/serve.py`
## Verification
- [x] Build passes
- [x] Scanner re-scan confirms fix
- [x] Code review passed
---
*Automated security fix by [OrbisAI Security](https://orbisappsec.com)*
| 6a6f77ec341c1a698232b5ee1b03ea9d8d32e8d1 | [
{
"filename": "src/transformers/cli/serve.py",
"patch": "@@ -728,14 +728,48 @@ def responses(request: dict):\n async def audio_transcriptions(request: Request):\n # Parses the multipart/form-data request into the request format used by other endpoints\n async with request.for... |
ollama/ollama | 15,073 | launch/vscode: prefer known vs code paths over `code` on PATH | When launching VS Code, findBinary() previously checked for code on PATH first. This could silently launch
Cursor or another VS Code fork if their CLI was registered as code.
This PR flips the lookup order and adds validation:
1. Check platform-specific paths first — `/Applications/Visual Studio Code.app` on macOS, `Microsoft VS
Code\bin\code.cmd` on Windows, `/usr/bin/code` or `/snap/bin/code` on Linux
2. Fall back to `code` on PATH only if it's actually vscode — resolve the symlink and check that the real path points to a vscode installation (e.g. contains `Visual Studio Code` or `Microsoft VS Code`)
3. Handle wrapper scripts — if `code` is a small shell script (not a symlink), read its content and check for vscode references | 07baff1ce3590ebfc7e0e2a913ebc90203776aca | [
{
"filename": "cmd/launch/vscode.go",
"patch": "@@ -25,9 +25,7 @@ type VSCode struct{}\n func (v *VSCode) String() string { return \"Visual Studio Code\" }\n \n // findBinary returns the path/command to launch VS Code, or \"\" if not found.\n-// It checks platform-specific locations first, then falls back t... |
golang/go | 77,696 | path/filepath: clarify Dir and Clean documentation for Windows | Fixes #77314
Updates documentation. The current documentation is misleading because it suggests that "C:" would return "C:\" but it actually returns "C:." | 1dd401c925ef52fb618659cc3215325f9b448e4d | [
{
"filename": "src/path/filepath/path.go",
"patch": "@@ -466,6 +466,7 @@ func Base(path string) string {\n // If the path consists entirely of separators, Dir returns a single separator.\n // The returned path does not end in a separator unless it is the root directory,\n // except for Windows volume paths ... |
electron/electron | 50,615 | fix: don't force kFitToPrintableArea scaling when custom margins are set | #### Description of Change
Fixes https://github.com/electron/electron/issues/50481
When silent printing with non-default margins (custom, no margins, or printable area margins), the kFitToPrintableArea scaling option causes double-marginalization: the custom margins define the content area, then the scaling additionally fits content to the printer's printable area.
Only apply kFitToPrintableArea when using default margins in silent mode. For non-default margins, use the same scaling as non-silent prints.
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] PR description included
- [x] I have built and tested this PR
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).
#### Release Notes
Notes: Fixed an issue where margins did not look as expected when printing in silent mode. | b695415f52150c8084373ca4684749e15f6a9d6e | [
{
"filename": "patches/chromium/printing.patch",
"patch": "@@ -675,7 +675,7 @@ index ac2f719be566020d9f41364560c12e6d6d0fe3d8..16d758a6936f66148a196761cfb875f6\n PrintingFailed(int32 cookie, PrintFailureReason reason);\n \n diff --git a/components/printing/renderer/print_render_frame_helper.cc b/compone... |
facebook/react | 36,026 | Enable Fragment Ref flags across builds | null | 5673298c62799488040bdb48cebadd579d252bd8 | [
{
"filename": "packages/shared/ReactFeatureFlags.js",
"patch": "@@ -145,7 +145,7 @@ export const enableInfiniteRenderLoopDetection: boolean = false;\n \n export const enableFragmentRefs: boolean = true;\n export const enableFragmentRefsScrollIntoView: boolean = true;\n-export const enableFragmentRefsInstanc... |
ollama/ollama | 15,068 | fix: pin 10 unpinned action(s),extract 1 unsafe expression(s) to env vars | ## Fix: CI/CD Security Vulnerabilities in GitHub Actions
Hi! [Runner Guard](https://github.com/Vigilant-LLC/runner-guard), an open-source
CI/CD security scanner by [Vigilant Cyber Security](https://www.vigilantdefense.com),
identified security vulnerabilities in this repository's GitHub Actions workflows.
This PR applies automated fixes where possible and reports additional findings
for your review.
### Fixes applied (in this PR)
| Rule | Severity | File | Description |
|------|----------|------|-------------|
| RGS-007 | high | `.github/workflows/latest.yaml` | Pinned 1 third-party action(s) to commit SHA |
| RGS-007 | high | `.github/workflows/release.yaml` | Pinned 8 third-party action(s) to commit SHA |
| RGS-007 | high | `.github/workflows/test.yaml` | Pinned 1 third-party action(s) to commit SHA |
| RGS-002 | high | `.github/workflows/test.yaml` | Extracted 1 unsafe expression(s) to env vars |
### Advisory: additional findings (manual review recommended)
| Rule | Severity | File | Description |
| RGS-003 | high | `.github/workflows/release.yaml` | Filename Injection via Git Diff or File Listing |
### Why this matters
GitHub Actions workflows that use untrusted input in `run:` blocks, expose
secrets inline, or use unpinned third-party actions are vulnerable to
code injection, credential theft, and supply chain attacks. These are the same
vulnerability classes exploited in the [tj-actions/changed-files incident](https://www.vigilantdefense.com/resources/runner-guard)
and subsequent supply chain attacks, which compromised CI secrets across
thousands of repositories.
### How to verify
Review the diff — each change is mechanical and preserves workflow behavior:
- **Expression extraction** (RGS-002/008/014): Moves `${{ }}` expressions from
`run:` blocks into `env:` mappings, preventing shell injection
- **SHA pinning** (RGS-007): Pins third-party actions to immutable commit SHAs
(original version tag preserved as comment)
- **Debug env removal** (RGS-015): Removes `ACTIONS_RUNNER_DEBUG`/`ACTIONS_STEP_DEBUG`
which leak secrets in workflow logs
Run `brew install Vigilant-LLC/tap/runner-guard && runner-guard scan .` or install from the
[repo](https://github.com/Vigilant-LLC/runner-guard) to verify.
---
Found by [Runner Guard](https://github.com/Vigilant-LLC/runner-guard) | Built by [Vigilant Cyber Security](https://www.vigilantdefense.com) | [Learn more](https://www.vigilantdefense.com/resources/runner-guard)
If this PR is not welcome, just close it -- we won't send another. | 410f0894e320c2804d979d7ef7cd9bd360e4b261 | [
{
"filename": ".github/workflows/latest.yaml",
"patch": "@@ -11,7 +11,7 @@ jobs:\n steps:\n - uses: actions/checkout@v4\n - name: Login to Docker Hub\n- uses: docker/login-action@v3\n+ uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3\n with:\n ... |
huggingface/transformers | 45,119 | Fix: Preserve PreTrainedConfig __init__ signatures for type checkers (fixes #45071) | ## Summary
This PR fixes GitHub issue #45071: "v5.4.0 breaks PretrainedConfig type checking". The regression prevents type checkers (mypy, pyright) from validating `PretrainedConfig` subclass instantiation with valid parameters.
## Root Cause
PR #44953 ("Config kwargs") introduced `wrap_init_to_accept_kwargs()` to accept extra kwargs for backward compatibility. However, the wrapper replaced the dataclass-generated `__init__` signature with a generic `(*args, **kwargs: Any)` signature. Type checkers rely on function signatures to validate parameters, so they lost information about actual config parameters.
## Solution
This PR uses Python's standard `__signature__` attribute technique (documented in PEP 362) to preserve the original `__init__` signature on the wrapped function. This allows:
- Type checkers to see and validate the original parameters
- Runtime to continue accepting extra kwargs for backward compatibility
- Zero breaking changes to existing code
This technique is used in production Python libraries including Pydantic, Click, and FastAPI.
## Changes
### Modified: `src/transformers/configuration_utils.py`
- Line 18: Added `import inspect`
- Line 78: Capture original signature before wrapping
- Lines 112-113: Restore signature on wrapped function
### Added: `tests/utils/test_configuration_utils.py`
- New test `test_pretrained_config_signature_preserved()` validates signature preservation, parameter validation, backward compatibility, and prevents generic signatures
## Testing
All tests pass with real `BertConfig` class - backward compatibility with extra kwargs verified.
## Impact
- **Type Checking**: mypy, pyright, and other type checkers can now properly validate `PretrainedConfig` subclass instantiation
- **Runtime**: No changes - extra kwargs still accepted for backward compatibility
- **Performance**: Negligible - only affects type checker introspection
- **Breaking Changes**: None - fully backward compatible
Fixes #45071 | d802749d1ac8e416b423a6c59a200697c0622d6c | [
{
"filename": "src/transformers/configuration_utils.py",
"patch": "@@ -15,6 +15,7 @@\n \"\"\"Configuration base class and utilities.\"\"\"\n \n import copy\n+import inspect\n import json\n import math\n import os\n@@ -74,6 +75,7 @@\n # copied from huggingface_hub.dataclasses.strict when `accept_kwargs=True`... |
rust-lang/rust | 154,726 | Rollup of 4 pull requests | Successful merges:
- rust-lang/rust#154444 (rustdoc ICE fix: When collecting `Deref` impls with their targets, skip the negative ones)
- rust-lang/rust#154590 (Make #[cfg] suggest any or all on #[cfg(a, b)])
- rust-lang/rust#154691 (core: Update the feature gate on `TryFrom<integer> for bool`)
- rust-lang/rust#154697 (rustdoc: fix href of extern crates in search results)
Failed merges:
- rust-lang/rust#154722 (fix(lints): Improve `ill_formed_attribute_input` with better help message)
<!-- homu-ignore:start -->
r? @ghost
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=154444,154590,154691,154697,154722)
<!-- homu-ignore:end -->
| 8c76d2b0de818017d6b3f7a7dd609cb593ec2bed | [
{
"filename": "src/librustdoc/html/render/search_index.rs",
"patch": "@@ -13,6 +13,7 @@ use ::serde::{Deserialize, Serialize};\n use rustc_ast::join_path_syms;\n use rustc_data_structures::fx::{FxHashMap, FxHashSet, FxIndexMap};\n use rustc_data_structures::thin_vec::ThinVec;\n+use rustc_hir::def_id::LOCAL_... |
nodejs/node | 62,500 | buffer: fix 32-bit truncation in SlowCopy for buffers larger than 4 GiB | ## Summary
`SlowCopy` in `src/node_buffer.cc` extracted `targetStart`, `sourceStart`,
and `to_copy` via `.As<Uint32>()->Value()`, silently truncating values that
exceed `2^32 - 1` (4 GiB). This caused `Buffer.prototype.copy()` to copy
the wrong number of bytes or write to the wrong position when dealing with
buffers larger than 4 GiB.
Root cause was introduced in #54087 ("buffer: use native copy impl"), which
replaced the original `ParseArrayIndex`-based extraction (using `size_t`) with
`Uint32Value` (32-bit).
## Changes
- `src/node_buffer.cc`: Use `IntegerValue()` (returns `int64_t`) in `SlowCopy`
instead of `.As<Uint32>()->Value()`, and widen `CopyImpl`'s parameter types
from `uint32_t` to `size_t`.
- `FastCopy` is left unchanged — V8's Fast API guarantees it is only invoked
when all arguments fit in `uint32_t`; for larger values V8 falls back to
`SlowCopy` automatically.
- `test/parallel/test-buffer-copy-large.js`: New test that allocates a buffer
slightly larger than 4 GiB and verifies `Buffer.prototype.copy()` copies all
bytes correctly. The test skips gracefully on systems with insufficient memory.
## Test
```js
// Before fix: only 5 bytes were copied (2^32 + 5 mod 2^32 = 5).
// After fix: all FOUR_GB + 5 bytes are copied correctly.
const src = Buffer.alloc(2 ** 32 + 5, 0xbb);
const dst = Buffer.alloc(src.length, 0xaa);
src.copy(dst);
assert.strictEqual(dst[dst.length - 1], 0xbb);
```
Fixes #55422 | 4ce7086b2433ba48ca1f843f334754246e056245 | [
{
"filename": ".clang-format",
"patch": "@@ -0,0 +1,111 @@\n+---\n+Language: Cpp\n+# BasedOnStyle: Google\n+AccessModifierOffset: -1\n+AlignAfterOpenBracket: Align\n+AlignConsecutiveAssignments: false\n+AlignConsecutiveDeclarations: false\n+AlignEscapedNewlines: Right\n+AlignOperands: true\n+Align... |
electron/electron | 50,614 | fix: remove menu update debug log | Backport of #50608
See that PR for details.
Notes: Removed "representedObject is not a WeakPtrToElectronMenuModelAsNSObject" logging when interacting with macOS menus.
| 22fb426acf923e1dd4d080ae795350c6759c0868 | [
{
"filename": "shell/browser/ui/cocoa/electron_menu_controller.mm",
"patch": "@@ -478,7 +478,6 @@ - (void)applyStateToMenuItem:(NSMenuItem*)item {\n \n if (![represented\n isKindOfClass:[WeakPtrToElectronMenuModelAsNSObject class]]) {\n- NSLog(@\"representedObject is not a WeakPtrToElectronMe... |
golang/go | 77,694 | all: test: remove unneeded loop variables | This CL follows from the abandoned CL 722961.
Alan Donovan asked if modernize would catch these changes; it does in part.
Here is how modernize was used:
1. Build the Go compiler from latest master
2. Clone x/tools and build modernize with the newest compiler
3. Then, do:
PATH=PATH_TO_BIN:$PATH go list ./... | xargs env PATH=PATH_TO_BIN:$PATH GOMOD=off MODERNIZE -forvar -fix -test -debug fpstv
4. For assurance, move into a package directory (i.e, cmd), and redo Step 3.
From the obtained result, it seems modernize did not remove the loop variable when:
- the range notation was not used
- the loop variable was not directly under the for directive.
Which does happens here:
# git ls-files | xargs -I {} perl -nE 'print "$ARGV:$.:$_" if /\s+(\w+) := \1$/' {} | grep _test
[...]
cmd/compile/internal/types2/api_test.go:2423: i := i
md/go/internal/modload/query_test.go:182: tt := tt
md/go/internal/web/url_test.go:17: tc := tc
cmd/go/internal/web/url_test.go:49: tc := tc
cmd/internal/par/queue_test.go:54: i := i
runtime/syscall_windows_test.go:781: arglen := arglen
Link: https://go-review.googlesource.com/c/go/+/722961/comments/e8d47866_fc399fa1
Co-authored-by: Plamerdi Makela <plamerdi447@gmail.com>
Fixes #76411 | 77c3e11fc21a4ede70b733b567a1690edb944dc1 | [
{
"filename": "src/cmd/api/api_test.go",
"patch": "@@ -232,7 +232,6 @@ var warmupCache = sync.OnceFunc(func() {\n \t// Warm up the import cache in parallel.\n \tvar wg sync.WaitGroup\n \tfor _, context := range contexts {\n-\t\tcontext := context\n \t\twg.Add(1)\n \t\tgo func() {\n \t\t\tdefer wg.Done()",
... |
ollama/ollama | 15,065 | mlx: fix KV cache snapshot memory leak | mlx.Copy shares the backing buffer with its source (via copy_shared_buffer) rather than allocating independent storage. When used to snapshot a slice of the KV cache, the snapshot array holds the entire original cache buffer alive through the shared data pointer — even after eval detaches the computation graph.
Replace Copy with Contiguous in Snapshot and Split. Contiguous allocates a compact buffer when the source buffer is significantly larger than the logical slice (Contiguous::eval checks buffer_size > nbytes + 16384), which is always the case for KV cache slices. | d432aabe6953f7345bbd73f97f1b9f260b6953e1 | [
{
"filename": "x/mlxrunner/cache/cache.go",
"patch": "@@ -109,8 +109,8 @@ func (c *KVCache) Snapshot(fromOffset int) Snapshot {\n \n \tkSlice := c.keys.Slice(mlx.Slice(), mlx.Slice(), mlx.Slice(from, to), mlx.Slice())\n \tvSlice := c.values.Slice(mlx.Slice(), mlx.Slice(), mlx.Slice(from, to), mlx.Slice())\n... |
rust-lang/rust | 154,725 | [beta] backports | - stdarch subtree update rust-lang/rust#153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test rust-lang/rust#154094
- don't drop arguments' temporaries in `dbg!` rust-lang/rust#154074
- Init self_decl with a correct vis rust-lang/rust#154313
- Update LLVM to 22.1.2 rust-lang/rust#154344
- [perf] Revert FastISel patch rust-lang/rust#154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` rust-lang/rust#154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" rust-lang/rust#154700
- core: Update the feature gate on `TryFrom<integer> for bool` rust-lang/rust#154691
r? cuviper
| 940fc4d3b3c42525450bb180a71149aba78c7940 | [
{
"filename": "library/core/src/convert/num.rs",
"patch": "@@ -332,7 +332,7 @@ macro_rules! impl_try_from_both_bounded {\n /// Implement `TryFrom<integer>` for `bool`\n macro_rules! impl_try_from_integer_for_bool {\n ($($int:ty)+) => {$(\n- #[stable(feature = \"try_from\", since = \"1.34.0\")]\n+... |
vercel/next.js | 92,169 | fix: propagate scroll={false} through server-patch retries | ## Summary
`scroll={false}` on `<Link>` is ignored when middleware rewrites to a deeper internal path and `prefetch={false}` is set. The page scrolls to top on every search-param navigation.
## Root Cause
When a navigation with `scroll={false}` uses an optimistic route match, `spawnDynamicRequests` fetches dynamic data from the server. If the server response creates a tree mismatch (the page segment key includes search params that differ from the optimistic tree), `dispatchRetryDueToTreeMismatch` dispatches a `SERVER_PATCH` action.
The server-patch reducer hardcodes `ScrollBehavior.Default` ([source](https://github.com/vercel/next.js/blob/canary/packages/next/src/client/components/router-reducer/reducers/server-patch-reducer.ts#L45)), dropping the original `scroll={false}`. The retry creates new cache nodes with `scrollRef = { current: true }` that are never neutralized, causing `handlePotentialScroll` to scroll to top.
## Fix
Thread `scrollBehavior` from the original navigation through `spawnDynamicRequests` -> `finishNavigationTask` -> `dispatchRetryDueToTreeMismatch` -> `ServerPatchAction`, and use `action.scrollBehavior` in the server-patch reducer instead of the hardcoded default.
## Reproduction
**Repo:** https://github.com/damusnet/next-middleware-rewrite-scroll-bug
| | Commit | Deployment | Scroll behavior |
|---|---|---|---|
| **Bug** | [`7f483d0`](https://github.com/damusnet/next-middleware-rewrite-scroll-bug/commit/7f483d0) | [Preview](https://next-scroll-repro-2k8ta88n7-damien-varrons-projects.vercel.app/) | Scrolls to top :x: |
| **Fix** | [`fa2b386`](https://github.com/damusnet/next-middleware-rewrite-scroll-bug/commit/fa2b386) | [Production](https://next-scroll-repro.vercel.app/) | Scroll preserved :white_check_mark: |
Both deployments include console logging (`[scroll-debug]`) showing RSC fetches and scroll resets.
### Conditions required to trigger:
1. Middleware rewrites a short URL to a deeper internal path (common in i18n/multi-tenant apps)
2. `<Link scroll={false} prefetch={false} href="?param=value">`
3. Deployed on Vercel (ISR) — does not reproduce on local `next start`
## Changes
| File | Change |
|---|---|
| `router-reducer-types.ts` | Add `scrollBehavior` to `ServerPatchAction` |
| `ppr-navigations.ts` | Thread `scrollBehavior` through `spawnDynamicRequests` -> `finishNavigationTask` -> `dispatchRetryDueToTreeMismatch` |
| `server-patch-reducer.ts` | Use `action.scrollBehavior` instead of `ScrollBehavior.Default` |
| `navigation.ts` | Pass `scrollBehavior` to `spawnDynamicRequests` |
| `restore-reducer.ts` | Pass `ScrollBehavior.Default` for history traversals |
| cb52f4ea239f2582382788d2dfdc43d444eb5373 | [
{
"filename": ".agents/skills/README.md",
"patch": "@@ -0,0 +1,115 @@\n+# Skills Authoring Guide\n+\n+Skills are on-demand context files that Claude loads when relevant. They extend `AGENTS.md` with deep-dive workflows, code templates, and verification steps.\n+\n+## When to Create a Skill\n+\n+Create a ski... |
nodejs/node | 62,499 | crypto: unify asymmetric key import through KeyObjectHandle::Init | Consolidate all asymmetric key import paths (DER/PEM, JWK, raw) into a single KeyObjectHandle::Init() entry point with a uniform signature.
Remove the per-type C++ init methods (InitECRaw, InitEDRaw, InitPqcRaw, InitJwk, InitECPrivateRaw) and their JS-side callers, replacing them with shared C++ and JS helpers.
createPublicKey, createPrivateKey, sign, verify, and other operations that accept key material now handle JWK and raw formats directly in C++, removing redundant JS-to-C++ key handle round-trips.
This also makes JWK import error for keys when their private and public components don't match, this aligns with the behaviour present in other runtimes, most notably browser webcrypto APIs. It was already present in our WebCryptoAPI for some keys but not all, this makes it all as well as `node:crypto`, this behaviour was useful for bypassing the inability to import "raw" private keys but that affordance is also coming with 26.x through its own recognized key format (#62455). | e8621565734120a74dde5e909105c23a69598d29 | [
{
"filename": "lib/internal/crypto/aes.js",
"patch": "@@ -10,6 +10,8 @@ const {\n AESCipherJob,\n KeyObjectHandle,\n kCryptoJobAsync,\n+ kKeyFormatJWK,\n+ kKeyTypeSecret,\n kKeyVariantAES_CTR_128,\n kKeyVariantAES_CBC_128,\n kKeyVariantAES_GCM_128,\n@@ -30,7 +32,6 @@ const {\n const {\n hasA... |
electron/electron | 50,613 | fix: remove menu update debug log | Backport of #50608
See that PR for details.
Notes: Removed "representedObject is not a WeakPtrToElectronMenuModelAsNSObject" logging when interacting with macOS menus.
| 411eeb3dc1edc579379a84d5d864bb092b934008 | [
{
"filename": "shell/browser/ui/cocoa/electron_menu_controller.mm",
"patch": "@@ -478,7 +478,6 @@ - (void)applyStateToMenuItem:(NSMenuItem*)item {\n \n if (![represented\n isKindOfClass:[WeakPtrToElectronMenuModelAsNSObject class]]) {\n- NSLog(@\"representedObject is not a WeakPtrToElectronMe... |
huggingface/transformers | 45,116 | Add full GGUF loading support for GPT‑OSS (fixes #43366) | # What does this PR do?
This PR adds full GGUF loading support for GPT‑OSS models (20B/120B). It allows Transformers (and consequently vLLM) to directly load GPT‑OSS GGUF files without falling back to a wrong architecture. The changes include:
- Architecture registration in GGUF mappings.
- A custom `GptOssTensorProcessor` to handle MoE expert splitting and gate/up interleaving.
- Reconstruction of nested `rope_scaling` (YaRN) from flat GGUF metadata.
- Tests: fast registration test + slow integration test using a real 20B GGUF file.
Fixes #43366, supersedes #43757.
Related vLLM issue: https://github.com/vllm-project/vllm/issues/22353
## Code Agent Policy
- [x] I confirm that this is not a pure code agent PR.
## Before submitting
- [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). – *Not applicable, it adds a feature.*
- [x] Did you read the contributor guideline, Pull Request section? – Yes.
- [x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case. – Issue #43366, discussion in comments.
- [x] Did you make sure to update the documentation with your changes? – Yes!
- [x] Did you write any new necessary tests? – Yes, `GptOssGgufLoadingTest` in `tests/models/gpt_oss/test_modeling_gpt_oss.py`.
## Who can review?
Anyone in the community is free to review the PR once the tests have passed. Tagging:
- @SunMarc (original issue tagger, quantization)
- @CyrilVallez (model loading)
- @ArthurZucker (tokenizers, model structure) | 6e2e655db30a7a68a101b0256b4d5a2fb22f8733 | [
{
"filename": "src/transformers/image_processing_backends.py",
"patch": "@@ -529,7 +529,7 @@ def resize(\n self,\n image: np.ndarray,\n size: SizeDict,\n- resample: Union[\"PILImageResampling\", \"tvF.InterpolationMode\", int] | None = None,\n+ resample: \"PILImageResam... |
golang/go | 77,686 | builtin: update new documentation for Go 1.26 expression syntax | The built-in new function now accepts an expression as its
operand, not just a type. Update the doc comment to reflect this
change introduced in Go 1.26.
The documentation now describes both behaviors:
new(T) allocates a zero value of type T
new(expr) allocates with the expression value as initial value
Fixes #77584 | df66c79ea8c8d91c2d2d4e951b87b8b7c3022757 | [
{
"filename": "src/builtin/builtin.go",
"patch": "@@ -122,6 +122,10 @@ type Type int\n // invocation.\n type Type1 int\n \n+// TypeOrExpr is here for the purposes of documentation only. It is a stand-in\n+// for either a Go type or an expression.\n+type TypeOrExpr int\n+\n // IntegerType is here for the pur... |
ollama/ollama | 15,064 | doc: update vscode doc | null | be04444b5c93458d8cb3bc66e32fc1929b4e7c0d | [
{
"filename": "docs/integrations/vscode.mdx",
"patch": "@@ -8,24 +8,34 @@ VS Code includes built-in AI chat through GitHub Copilot Chat. Ollama models can\n \n \n \n+## Prerequisites\n \n-## Install\n+- Ollama v0.18.3+\n+- [VS Code 1.113+](https://code.visualstudio.... |
vercel/next.js | 92,167 | Add rust-fingerprint task and SCCACHE passthrough env | ## What
Replace duplicated Rust input globs across every turbo task with a single rust-fingerprint task that computes a TURBO_HASH stamp file. All Rust build/check tasks now depend on this stamp instead of repeating the full glob list.
Also add `SCCACHE_*` to `globalPassThroughEnv` so `sccache` env vars are available to turbo tasks.
## Why
`SCCACHE_*` and `RUSTC_WRAPPER` env vars are required to build under sccache, but do not affect the build in a material way.
This simplifies the repeated constructs that are unfortunately difficult to factor out, but is provably the same as listing all the files each time (the rust-fingerprint file's content is its `TURBO_HASH`). | 28e0e0ccab008f732e0872349962d5b746b455ce | [
{
"filename": "packages/next-swc/package.json",
"patch": "@@ -15,6 +15,7 @@\n \"build-native-no-plugin-release\": \"napi build --platform -p next-napi-bindings --cargo-cwd ../../ --cargo-name next_napi_bindings --release --features image-webp,tracing/release_max_level_trace --js false native\",\n \"... |
rust-lang/rust | 154,718 | Rollup of 21 pull requests | Successful merges:
- rust-lang/rust#153105 (Compute the result of a projection type with region errors)
- rust-lang/rust#153286 (various fixes for scalable vectors)
- rust-lang/rust#153532 (Attributes containing rustc)
- rust-lang/rust#153960 (Make `layout_of` cycles fatal errors)
- rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
- rust-lang/rust#154666 (Remove `StableHashContext` impls)
- rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`)
- rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args)
- rust-lang/rust#154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
- rust-lang/rust#153614 (`FindParamInClause` handle edge-cases)
- rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message)
- rust-lang/rust#154425 (Migrate transmute tests)
- rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
- rust-lang/rust#154469 (mGCA: Lower spans for literal const args)
- rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
- rust-lang/rust#154615 (Moving issues)
- rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar)
- rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns)
- rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
- rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
- rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)
<!-- homu-ignore:start -->
r? @ghost
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=153105,153286,153532,153960,154527,154666,154669,154710,154712,153614,154213,154425,154442,154469,154578,154615,154644,154660,154671,154680,154709)
<!-- homu-ignore:end -->
| f3ba2c41e63ac58ae8aafbe7725db6b5e6021d00 | [
{
"filename": "src/librustdoc/clean/inline.rs",
"patch": "@@ -137,7 +137,7 @@ pub(crate) fn try_inline(\n })\n }\n Res::Def(DefKind::Macro(kinds), did) => {\n- let mac = build_macro(cx, did, name, kinds);\n+ let mac = build_macro(cx.tcx, did, name, kinds);\n... |
electron/electron | 50,611 | fix: extension service workers not starting beyond first app launch | #### Description of Change
Fixes https://github.com/electron/electron/issues/41613
##### Before this patch
When an extension was loaded into an app for the very first time, its service worker would start.
When the same extension was loaded on subsequent app launches, the service worker would no longer start.
##### With this patch
This PR makes it so that extension service workers are also started on subsequent app launches.
#### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
- [x] PR description included
- [x] I have built and tested this PR
- [x] `npm test` passes
- [x] tests are [changed or added](https://github.com/electron/electron/blob/main/docs/development/testing.md)
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).
#### Release Notes
Notes: Fixed certain DevTools extension panels not showing without a page reload.
| 4a58f1b634d8855f83959e350955a59c92dab369 | [
{
"filename": "shell/browser/extensions/electron_extension_loader.cc",
"patch": "@@ -28,6 +28,7 @@\n #include \"extensions/common/error_utils.h\"\n #include \"extensions/common/file_util.h\"\n #include \"extensions/common/manifest_constants.h\"\n+#include \"extensions/common/manifest_handlers/background_inf... |
facebook/react | 36,024 | [Flight] Clear chunk reason after successful module initialization | When `requireModule` triggers a reentrant `readChunk` on the same module chunk, the reentrant call can fail and set `chunk.reason` to an error. After the outer `requireModule` succeeds, the chunk transitions to initialized but retains the stale error as `reason`.
When the Flight response stream later closes, it iterates all chunks and expects `reason` on initialized chunks to be a `FlightStreamController`. Since the stale `reason` is an `Error` object instead, calling `chunk.reason.error()` crashes with `TypeError: chunk.reason.error is not a function`.
The reentrancy can occur when module evaluation synchronously triggers `readChunk` on the same chunk — for example, when code called during evaluation tries to resolve the client reference for the module that is currently being initialized. In Fizz SSR, `captureOwnerStack()` can trigger this because it constructs component stacks that resolve lazy client references via `readChunk`. The reentrant `requireModule` call returns the module's namespace object, but since the module is still being evaluated, accessing the export binding throws a TDZ (Temporal Dead Zone) `ReferenceError`. This sets the chunk to the errored state, and the `ReferenceError` becomes the stale `chunk.reason` after the outer call succeeds.
This scenario is triggered in Next.js when a client module calls an instrumented API like `Math.random()` in module scope, which synchronously invokes `captureOwnerStack()`. | b43ee2a3d98863a2ea6dcf63d1b66e0b93a59cd2 | [
{
"filename": "packages/react-client/src/ReactFlightClient.js",
"patch": "@@ -1040,6 +1040,8 @@ function initializeModelChunk<T>(chunk: ResolvedModelChunk<T>): void {\n // Initialize any debug info and block the initializing chunk on any\n // unresolved entries.\n initializeDebugChunk(response, ... |
huggingface/transformers | 45,112 | [CB] Add warmup feature | This PR adds a warmup phase before generation starts, turned on by default.
It allows for better diagnostics and a more representative user experience than without warmup, where the cost of wamup is payed during the first request rather than in a phase before generation starts.
Warmup is skipped if cuda graphs and compile are both turned off. | f29aca3f70b14ce9dd6ded52dfb8af0e89efff15 | [
{
"filename": "docs/source/en/_toctree.yml",
"patch": "@@ -89,6 +89,8 @@\n title: Experts backends\n - local: continuous_batching\n title: Continuous batching\n+ - local: continuous_batching_architecture\n+ title: Continuous batching architecture\n - local: paged_attention\n ... |
nodejs/node | 62,497 | Revert "deps: update libuv to 1.52.1" | This reverts commit 5bebd7eaea287ccf187b02c8d6afa863cf326a58.
The update appears to be causing persistent flakiness in test-http(s), test-net-*, and test-tls-* tests on Windows. The flakiness manifests as an abort apparently caused by a race condition introduced in connection cleanup on process teardown. Root cause still needs to be fully determined. Reverting the update will hopefully get us back to a stable state while the underlying issue is investigated and resolved.
| 8d72d50b13c5e67b716a0f9ee5ef7fce5369b3fe | [
{
"filename": "deps/uv/.clang-tidy",
"patch": "@@ -1,47 +0,0 @@\n----\n-# Configuration file for clang-tidy\n-# This configuration is tailored for the libuv C library project\n-\n-# Use default checks with minimal necessary disables\n-Checks:\n- # don't suggest reordering struct definitions\n- - -clang-an... |
golang/go | 77,683 | cmd/fix: clarify -any analyzer behavior in documentation | This change clarifies the documentation for the any analyzer used by go fix.
It adds a note explaining that the -any flag enables only the any analyzer
and does not affect other analyzers in the fix suite. This makes the behavior
of the flag explicit and helps avoid confusion when reading the documentation.
This is a documentation-only change and does not modify analyzer behavior.
fixes: #77679 | f9e337d1e857c0ba66f6723b4147c9c08f93208a | [
{
"filename": "api/next/73450.txt",
"patch": "@@ -0,0 +1 @@\n+pkg net/url, method (*URL) Clone() *URL #73450",
"additions": 1,
"deletions": 0
},
{
"filename": "doc/next/6-stdlib/99-minor/net/url/73450.md",
"patch": "@@ -0,0 +1 @@\n+The new [URL.Clone] method creates a deep copy of a URL.... |
rust-lang/rust | 154,716 | Rollup of 21 pull requests | Successful merges:
- rust-lang/rust#153105 (Compute the result of a projection type with region errors)
- rust-lang/rust#153286 (various fixes for scalable vectors)
- rust-lang/rust#153532 (Attributes containing rustc)
- rust-lang/rust#153960 (Make `layout_of` cycles fatal errors)
- rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
- rust-lang/rust#154666 (Remove `StableHashContext` impls)
- rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`)
- rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args)
- rust-lang/rust#154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
- rust-lang/rust#154713 (Stop compiling when we get resolving crate failure)
- rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message)
- rust-lang/rust#154425 (Migrate transmute tests)
- rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
- rust-lang/rust#154469 (mGCA: Lower spans for literal const args)
- rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
- rust-lang/rust#154615 (Moving issues)
- rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar)
- rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns)
- rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
- rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
- rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)
<!-- homu-ignore:start -->
r? @ghost
[Create a similar rollup](https://bors.rust-lang.org/queue/rust?prs=153105,153286,153532,153960,154527,154666,154669,154710,154712,154713,154213,154425,154442,154469,154578,154615,154644,154660,154671,154680,154709)
<!-- homu-ignore:end -->
| f3ba2c41e63ac58ae8aafbe7725db6b5e6021d00 | [
{
"filename": "src/librustdoc/clean/inline.rs",
"patch": "@@ -137,7 +137,7 @@ pub(crate) fn try_inline(\n })\n }\n Res::Def(DefKind::Macro(kinds), did) => {\n- let mac = build_macro(cx, did, name, kinds);\n+ let mac = build_macro(cx.tcx, did, name, kinds);\n... |
electron/electron | 50,608 | fix: remove menu update debug log | #### Description of Change
Removes a diagnostic log:
```
representedObject is not a WeakPtrToElectronMenuModelAsNSObject
```
This log was introduced alongside a guard in macOS menu refresh. The guard is part of the system's expected behavior, preventing us from processing menu items we don't own. In other words, the guard itself is benign. Keep the guard, remove the log.
Fixes #50389
#### Checklist
- [x] PR description included
- [x] I have built and tested this PR
- [x] `npm test` passes
- [x] [PR release notes](https://github.com/electron/clerk/blob/main/README.md) describe the change in a way relevant to app developers, and are [capitalized, punctuated, and past tense](https://github.com/electron/clerk/blob/main/README.md#examples).
#### Release Notes
Notes: Removed "representedObject is not a WeakPtrToElectronMenuModelAsNSObject" logging when interacting with macOS menus.
| 5689abff4d2a9a292b57bf2fe6c72e308fd2afc2 | [
{
"filename": "shell/browser/ui/cocoa/electron_menu_controller.mm",
"patch": "@@ -478,7 +478,6 @@ - (void)applyStateToMenuItem:(NSMenuItem*)item {\n \n if (![represented\n isKindOfClass:[WeakPtrToElectronMenuModelAsNSObject class]]) {\n- NSLog(@\"representedObject is not a WeakPtrToElectronMe... |
vercel/next.js | 92,165 | #64441 bug: fix not scrolling top issue | # Fix scroll restoration on route change with sticky headers
**Actual problem:**
The scroll restoration currently runs before layout is fully applied. In cases involving sticky elements and short pages, this results in no visible scroll change.
**Tests:**
I added an integration test under `test/integration/scroll-restoration-on-navigation` to cover this scenario.
Due to local environment limitations (Playwright dependencies on my OS), I wasn’t able to run it locally, but the behavior has been verified manually in a real browser and it is **working as expected** now.
Happy to adjust the test if CI surfaces any issues or if there’s a preferred testing approach.
Covers the behavior described in Next.js GitHub Issue #64441 | f8a22e0c4fb7d084306dbbfa1718a468d366ac6d | [
{
"filename": ".config/eslintignore.mjs",
"patch": "@@ -47,6 +47,7 @@ export default globalIgnores([\n 'examples/with-typescript-graphql/lib/gql/',\n 'test/development/basic/hmr/components/parse-error.js',\n 'test/development/mcp-server/fixtures/default-template/app/build-error/page.tsx',\n+ 'test/de... |
facebook/react | 36,023 | Create index.html | <!--
Thanks for submitting a pull request!
We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory.
Before submitting a pull request, please make sure the following is done:
1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`.
2. Run `yarn` in the repository root.
3. If you've fixed a bug or added code that should be tested, add tests!
4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development.
5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`.
6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect".
7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`).
8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files.
9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`).
10. If you haven't already, complete the CLA.
Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html
-->
## Summary
<!--
Explain the **motivation** for making this change. What existing problem does the pull request solve?
-->
## How did you test this change?
<!--
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface.
How exactly did you verify that your PR solves the issue you wanted to solve?
If you leave this empty, your PR will very likely be closed.
-->
| abb92660d683958c5e76604fb77f26be5aa305dd | [
{
"filename": "examples/todo-list/index.html",
"patch": "@@ -0,0 +1,414 @@\n+<!DOCTYPE html>\n+<html lang=\"zh-CN\">\n+<head>\n+ <meta charset=\"UTF-8\" />\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\" />\n+ <title>React Todo List Example</title>\n+ <style>\n+ * {\n+ ... |
huggingface/transformers | 45,111 | Fix double softmax in MoE router load-balancing loss | ## Summary
- Several MoE routers applied softmax inside `forward()` but returned the result as `router_logits`. The `load_balancing_loss_func` then applied softmax **again**, computing the aux loss on `softmax(softmax(logits))` which flattens the distribution toward uniform, rendering the load-balancing loss ineffective.
- Fix: use a separate `router_probs` variable for the softmaxed values used in top-k routing, keeping `router_logits` as raw logits so the loss function's single softmax is correct.
### Source modular files fixed (3):
- `mixtral/modular_mixtral.py` — `MixtralTopKRouter`
- `qwen2_moe/modular_qwen2_moe.py` — `Qwen2MoeTopKRouter`
- `qwen3_vl_moe/modular_qwen3_vl_moe.py` — `Qwen3VLMoeTextTopKRouter`
### Downstream models regenerated by `make fix-repo` (10):
mixtral, minimax, qwen2_moe, olmoe, flex_olmo, qwen3_moe, qwen3_next, qwen3_omni_moe, qwen3_vl_moe, qwen3_5_moe
## Test plan
- [x] Verified with debug script that `router_logits` now returns raw logits (row sums ≠ 1.0) instead of probabilities
- [x] Confirmed `load_balancing_loss_func` applies softmax exactly once
- [ ] Run MoE model tests: `pytest tests/models/mixtral/ tests/models/qwen2_moe/ tests/models/qwen3_vl_moe/ -v`
🤖 Generated with [Claude Code](https://claude.com/claude-code) | fb4d936ca1782d8b4311a1a1d1dba0489ae8f7d5 | [
{
"filename": "src/transformers/models/flex_olmo/modeling_flex_olmo.py",
"patch": "@@ -300,11 +300,11 @@ def __init__(self, config):\n def forward(self, hidden_states):\n hidden_states = hidden_states.reshape(-1, self.hidden_dim)\n router_logits = F.linear(hidden_states, self.weight) # ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.