diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/cms_lab_publications/admin.py b/cms_lab_publications/admin.py index <HASH>..<HASH> 100644 --- a/cms_lab_publications/admin.py +++ b/cms_lab_publications/admin.py @@ -261,6 +261,7 @@ class PublicationSetAdmin(admin.ModelAdmin): 'number_of_publications', 'pagination', 'searchable', + 'is_bulk_pubmed_query_ok', ) list_filter = ( BulkPubMedQueryStatusFilter, @@ -273,6 +274,11 @@ class PublicationSetAdmin(admin.ModelAdmin): 'description', ) + def is_bulk_pubmed_query_ok(self, obj): + return obj.bulk_pubmed_query == '' + is_bulk_pubmed_query_ok.boolean = True + is_bulk_pubmed_query_ok.short_description = 'Query OK?' + def queryset(self, request): queryset = super().queryset(request) queryset = queryset.annotate(pub_count=Count('publications'))
Display whether a Publication Set's Bulk PubMed Query status is OK
diff --git a/tests/bootstrap.php b/tests/bootstrap.php index <HASH>..<HASH> 100644 --- a/tests/bootstrap.php +++ b/tests/bootstrap.php @@ -10,6 +10,7 @@ error_reporting(E_ALL & ~E_USER_NOTICE | E_STRICT); +require_once dirname(__FILE__) . "/../vendor/autoload.php"; require_once dirname(__FILE__) . "/../lib/steam-condenser.php"; function getFixture($fileName) {
Load Composer dependencies during tests
diff --git a/tests/spec/output_spec.rb b/tests/spec/output_spec.rb index <HASH>..<HASH> 100644 --- a/tests/spec/output_spec.rb +++ b/tests/spec/output_spec.rb @@ -105,6 +105,4 @@ describe WinRM::Output do end end end - - pending 'parse CLIXML errors and convert to Strings and/or Exceptions' end
remove pending test regarding exception deserializing. we do that now and cover in integration tests. will add unit tests soon
diff --git a/test/routing_test.rb b/test/routing_test.rb index <HASH>..<HASH> 100755 --- a/test/routing_test.rb +++ b/test/routing_test.rb @@ -473,7 +473,7 @@ class TranslateRoutesTest < ActionController::TestCase end end - test_case = klass.new(nil) + test_case = klass.new(:respond_to?) # Not localized assert test_case.respond_to?(:people_path)
Fix tests on default urls for Ruby <I>
diff --git a/probes/src/test/java/com/hazelcast/simulator/probes/ProbeTestUtils.java b/probes/src/test/java/com/hazelcast/simulator/probes/ProbeTestUtils.java index <HASH>..<HASH> 100644 --- a/probes/src/test/java/com/hazelcast/simulator/probes/ProbeTestUtils.java +++ b/probes/src/test/java/com/hazelcast/simulator/probes/ProbeTestUtils.java @@ -24,7 +24,7 @@ public final class ProbeTestUtils { private static final int HISTOGRAM_RECORD_COUNT = 5000; private static final int MAX_LATENCY = 30000; - private static final int TOLERANCE_MILLIS = 500; + private static final int TOLERANCE_MILLIS = 1000; private static final Random RANDOM = new Random(); private static File resultFile = new File("tmpProbeResult.xml");
Increased TOLERANCE_MILLIS to one second in ProbeTestUtils.
diff --git a/testsuite/domain/src/test/java/org/jboss/as/test/integration/respawn/RespawnTestCase.java b/testsuite/domain/src/test/java/org/jboss/as/test/integration/respawn/RespawnTestCase.java index <HASH>..<HASH> 100644 --- a/testsuite/domain/src/test/java/org/jboss/as/test/integration/respawn/RespawnTestCase.java +++ b/testsuite/domain/src/test/java/org/jboss/as/test/integration/respawn/RespawnTestCase.java @@ -396,7 +396,7 @@ public class RespawnTestCase { @Override String getKillCommand(RunningProcess process) { - return "taskkill /pid " + process.getProcessId(); + return "taskkill /f /pid " + process.getProcessId(); } }
Add /f option to taskkill command on Windows. Stops respawn test from failing.
diff --git a/concrete/src/Permission/Key/WorkflowKey.php b/concrete/src/Permission/Key/WorkflowKey.php index <HASH>..<HASH> 100644 --- a/concrete/src/Permission/Key/WorkflowKey.php +++ b/concrete/src/Permission/Key/WorkflowKey.php @@ -27,7 +27,7 @@ abstract class WorkflowKey extends Key foreach ($excluded as $inc) { $pae = $inc->getAccessEntityObject(); - $usersExcluded = array_merge($usersExcluded, $pae->getAccessEntityUsers()); + $usersExcluded = array_merge($usersExcluded, $pae->getAccessEntityUsers($paa)); } $users = array_diff($users, $usersExcluded);
WorkflowKey::getCurrentlyActiveUsers() doesn't pass all args to getAccessEntityUsers() Came about this bug when using the MSW extension.
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -367,8 +367,8 @@ workfly.prototype.resume = function() //Resume the workflow this._paused = false; - //Check if workflow is aborted - if(this._aborted === true ){ return; } + //Check if workflow is aborted or completed + if(this._aborted === true || this._completed === true ){ return; } //Check if workflow running if(this._running === true){ return; }
index.js: check if workflow is completed before resume it
diff --git a/core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java b/core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java +++ b/core/src/main/java/org/bitcoinj/core/TransactionBroadcast.java @@ -103,7 +103,7 @@ public class TransactionBroadcast { List<Peer> peers = peerGroup.getConnectedPeers(); // snapshots // We intern the tx here so we are using a canonical version of the object (as it's unfortunately mutable). // TODO: Once confidence state is moved out of Transaction we can kill off this step. - pinnedTx = context != null ? context.getConfidenceTable().intern(tx) : pinnedTx; + pinnedTx = context != null ? context.getConfidenceTable().intern(tx) : tx; // Prepare to send the transaction by adding a listener that'll be called when confidence changes. // Only bother with this if we might actually hear back: if (minConnections > 1)
NPE when invoking `PeerGroup.broadcastTransaction()` on peer group with no block chain. The modified line here seems to have been assuming that `pinnedTx` was being initialized elsewhere, but it wasn't.
diff --git a/alerta/server/database.py b/alerta/server/database.py index <HASH>..<HASH> 100644 --- a/alerta/server/database.py +++ b/alerta/server/database.py @@ -18,10 +18,17 @@ class Mongo(object): # Connect to MongoDB try: - self.conn = pymongo.MongoClient(CONF.mongo_host, CONF.mongo_port) + self.conn = pymongo.MongoClient(CONF.mongo_host, CONF.mongo_port) # version >= 2.4 + except AttributeError: + self.conn = pymongo.Connection(CONF.mongo_host, CONF.mongo_port) # version < 2.4 + except Exception, e: + LOG.error('MongoDB Client connection error : %s', e) + sys.exit(1) + + try: self.db = self.conn.monitoring # TODO(nsatterl): make 'monitoring' a SYSTEM DEFAULT except Exception, e: - LOG.error('MongoDB Client error : %s', e) + LOG.error('MongoDB database error : %s', e) sys.exit(1) if self.conn.alive():
support pymongo < <I>
diff --git a/flake8_respect_noqa.py b/flake8_respect_noqa.py index <HASH>..<HASH> 100644 --- a/flake8_respect_noqa.py +++ b/flake8_respect_noqa.py @@ -4,13 +4,17 @@ Always ignore lines with '# noqa' """ __version__ = 0.2 -import pep8 +try: + from pep8 import StandardReport, noqa +except ImportError: + # Try the new (as of 2016-June) pycodestyle package. + from pycodestyle import StandardReport, noqa -class RespectNoqaReport(pep8.StandardReport): +class RespectNoqaReport(StandardReport): def error(self, line_number, offset, text, check): - if len(self.lines) > line_number - 1 and pep8.noqa(self.lines[line_number - 1]): + if len(self.lines) > line_number - 1 and noqa(self.lines[line_number - 1]): return else: return super(RespectNoqaReport, self).error(line_number, offset,
Adjust for pep8 package rename. Closes #1
diff --git a/mocpy/moc.py b/mocpy/moc.py index <HASH>..<HASH> 100644 --- a/mocpy/moc.py +++ b/mocpy/moc.py @@ -371,7 +371,7 @@ class MOC(AbstractMoc): tmp_moc = tempfile.NamedTemporaryFile(delete=False) - self.write(tmp_moc.name) + self.write(tmp_moc.name, write_to_file=True) r = requests.post('http://cdsxmatch.u-strasbg.fr/QueryCat/QueryCat', data={'mode': 'mocfile', 'catName': resource_id,
fix _query MOC.write prototype has changed over time and _query was using a past version of it.
diff --git a/lib/jsduck/lint.rb b/lib/jsduck/lint.rb index <HASH>..<HASH> 100644 --- a/lib/jsduck/lint.rb +++ b/lib/jsduck/lint.rb @@ -100,7 +100,7 @@ module JsDuck def warn_singleton_statics @relations.each do |cls| if cls[:singleton] - cls.find_members({:static => true}).each do |m| + cls.find_members({:local => true, :static => true}).each do |m| warn(:sing_static, "Static members don't make sense in singleton class #{@doc[:name]}", m) end end
Use the :local option in statics in singleton check. We don't care about static members inherited from parents and mixins - they could be completely valid in those other classes - it's the concrete singleton who's statics interest us.
diff --git a/src/Artisaninweb/SoapWrapper/Service.php b/src/Artisaninweb/SoapWrapper/Service.php index <HASH>..<HASH> 100755 --- a/src/Artisaninweb/SoapWrapper/Service.php +++ b/src/Artisaninweb/SoapWrapper/Service.php @@ -336,7 +336,8 @@ class Service { */ public function header($namespace,$name,$data=null,$mustUnderstand=false,$actor=null) { - $this->headers[] = new SoapHeader($namespace,$name,$data,$mustUnderstand,$actor); + if($actor) $this->headers[] = new SoapHeader($namespace,$name,$data,$mustUnderstand,$actor); + else $this->headers[] = new SoapHeader($namespace,$name,$data,$mustUnderstand); return $this; }
Update add header function [ErrorException] SoapHeader::SoapHeader(): Invalid actor This is the error i get when i don't set the actor.
diff --git a/actions/class.TestRunner.php b/actions/class.TestRunner.php index <HASH>..<HASH> 100644 --- a/actions/class.TestRunner.php +++ b/actions/class.TestRunner.php @@ -282,6 +282,7 @@ class taoQtiTest_actions_TestRunner extends tao_actions_ServiceModule { } $this->setData('client_config_url', $this->getClientConfigUrl()); + $this->setData('client_timeout', $this->getClientTimeout()); $this->setView('test_runner.tpl'); $this->afterAction(false); @@ -580,4 +581,4 @@ class taoQtiTest_actions_TestRunner extends tao_actions_ServiceModule { break; } } -} \ No newline at end of file +}
add timeout to the test runner
diff --git a/salt/_compat.py b/salt/_compat.py index <HASH>..<HASH> 100644 --- a/salt/_compat.py +++ b/salt/_compat.py @@ -177,8 +177,19 @@ else: if PY3: from io import StringIO + from io import BytesIO as cStringIO else: from StringIO import StringIO + from cStringIO import StringIO as cStringIO + +def string_io(data=None): # cStringIO can't handle unicode + ''' + Pass data through to stringIO module and return result + ''' + try: + return cStringIO(bytes(data)) + except (UnicodeEncodeError, TypeError): + return StringIO(data) if PY3: import queue as Queue
add more stringio support to compat
diff --git a/salt/modules/win_file.py b/salt/modules/win_file.py index <HASH>..<HASH> 100644 --- a/salt/modules/win_file.py +++ b/salt/modules/win_file.py @@ -167,11 +167,13 @@ def _resolve_symlink(path, max_depth=64): return path -def _change_privilege(privilege_name, enable): +def _change_privilege_state(privilege_name, enable): ''' - Change, either enable or disable, the named privilege for this process. + Change the state, either enable or disable, of the named privilege for this + process. - If the change did not occur, an exception will be raised. + If the change fails, an exception will be raised. If successful, it returns + True. ''' log.debug( '%s the privilege %s for this process.', @@ -236,14 +238,14 @@ def _enable_privilege(privilege_name): ''' Enables the named privilege for this process. ''' - return _change_privilege(privilege_name, True) + return _change_privilege_state(privilege_name, True) def _disable_privilege(privilege_name): ''' Disables the named privilege for this process. ''' - return _change_privilege(privilege_name, False) + return _change_privilege_state(privilege_name, False) def gid_to_group(gid):
Renamed method to better reflect what it does.
diff --git a/example_form.php b/example_form.php index <HASH>..<HASH> 100644 --- a/example_form.php +++ b/example_form.php @@ -44,7 +44,7 @@ if (isset($_SESSION['ctform']['error']) && $_SESSION['ctform']['error'] == true <span class="success">The captcha was correct and the message has been sent!</span><br /><br /> <?php endif; ?> -<form method="post" action="<?php echo $_SERVER['REQUEST_URI'] . $_SERVER['QUERY_STRING'] ?>" id="contact_form"> +<form method="post" action="<?php echo htmlspecialchars($_SERVER['REQUEST_URI'] . $_SERVER['QUERY_STRING']) ?>" id="contact_form"> <input type="hidden" name="do" value="contact" /> <p>
Fix potential XSS in example form.
diff --git a/bees/ircbee/ircbee.go b/bees/ircbee/ircbee.go index <HASH>..<HASH> 100644 --- a/bees/ircbee/ircbee.go +++ b/bees/ircbee/ircbee.go @@ -219,10 +219,9 @@ func (mod *IrcBee) Run(eventChan chan bees.Event) { } default: + time.Sleep(1 * time.Second) } } } - - time.Sleep(5 * time.Second) } }
Sleep in the inner-most ircbee loop.
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -35,7 +35,7 @@ module.exports = { target.options = target.options || {}; // Build all paths - var bulmaPath = path.join(target.bowerDirectory, 'bulma'); + var bulmaPath = path.join(target.bowerDirectory || '', 'bulma'); target.options.sassOptions = target.options.sassOptions || {}; target.options.sassOptions.includePaths = target.options.sassOptions.includePaths || [];
Fallback to empty string for undefined bowerDirectory From what I can tell, nested addons don't have access to the `bowerDirectory` property defined by Ember CLI. Rather than get an error for passing `undefined` to `Path.join`, this attempts to continue without `target.bowerDirectory`.
diff --git a/src/Entity/MetadataCollection.php b/src/Entity/MetadataCollection.php index <HASH>..<HASH> 100644 --- a/src/Entity/MetadataCollection.php +++ b/src/Entity/MetadataCollection.php @@ -108,7 +108,9 @@ class MetadataCollection { $cacheKey = self::$cachePrefix . 'metadata_entities_list'; $isCacheEnabled = $this->getClient()->isCacheEnabled(); - if ( !count( $this->cachedEntitiesList ) && $isCacheEnabled + if ( count( $this->cachedEntitiesList ) ) { + return $this->cachedEntitiesList; + } elseif ( !count( $this->cachedEntitiesList ) && $isCacheEnabled && $this->getCache()->exists( $cacheKey ) ) { // entities list exists $this->cachedEntitiesList = $this->getCache()->get( $cacheKey ); } else { // entities list is not loaded
Entities metadata cache would be regenerated repeatedly If MetadataCollection::getEntitiesList() is invoked the second time, it would regenerate metadata cache despite entity metadata cache being in memory already.
diff --git a/zipline/test/test_perf_tracking.py b/zipline/test/test_perf_tracking.py index <HASH>..<HASH> 100644 --- a/zipline/test/test_perf_tracking.py +++ b/zipline/test/test_perf_tracking.py @@ -23,7 +23,7 @@ class PerformanceTestCase(unittest.TestCase): len(self.treasury_curves) ) self.dt = self.treasury_curves.keys()[random_index] - self.end_dt = self.dt + datetime.timedelta(days=365+2) + self.end_dt = self.dt + datetime.timedelta(days=365) self.trading_environment = TradingEnvironment( self.benchmark_returns, self.treasury_curves,
dropped the extra days in trading range...
diff --git a/pages.go b/pages.go index <HASH>..<HASH> 100644 --- a/pages.go +++ b/pages.go @@ -6,13 +6,15 @@ import ( "bytes" "encoding/binary" "fmt" - "github.com/golang/protobuf/proto" - "github.com/sajari/sajari-convert/iWork" - "github.com/sajari/sajari-convert/snappy" "io" "io/ioutil" "log" "strings" + + "github.com/golang/protobuf/proto" + + "github.com/sajari/docconv/iWork" + "github.com/sajari/docconv/snappy" ) // Convert PAGES to text
Fix and reorder imports.
diff --git a/coursera/utils.py b/coursera/utils.py index <HASH>..<HASH> 100644 --- a/coursera/utils.py +++ b/coursera/utils.py @@ -65,7 +65,7 @@ def clean_filename(s, minimal_change=False): h = html_parser.HTMLParser() s = h.unescape(s) - # strip paren portions which contain trailing time length (...) + # Strip forbidden characters s = ( s.replace(':', '-') .replace('/', '-')
coursera/utils: Update outdated comment.
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -13,7 +13,7 @@ with open(path.join(here, 'README.rst'), encoding='utf-8') as f: setup( name='tortilla', - version='0.1.0.dev2', + version='0.1.0.dev3', description='A tiny library for creating wrappers around external APIs', long_description=long_description, url='https://github.com/redodo/tortilla',
New dev release: <I>.dev3
diff --git a/visidata/undo.py b/visidata/undo.py index <HASH>..<HASH> 100644 --- a/visidata/undo.py +++ b/visidata/undo.py @@ -29,8 +29,10 @@ def undo(vd, sheet): undofunc(*args, **kwargs) sheet.undone.append(cmdlogrow) sheet.cmdlog_sheet.rows.remove(cmdlogrow) + + vd.clearCaches() # undofunc can invalidate the drawcache + vd.moveToReplayContext(cmdlogrow) - vd.clearCaches() vd.status("%s undone" % cmdlogrow.longname) return
[undo-] clear drawcache before moving to pre-undo context Per 6a4e<I>c<I>c<I>e<I>d<I>d<I>e5ed1, upon undo, VisiData tries to move cursor to row/col of undone command. If drawcaches are not cleared, VisiData could fail to find that pre-undo context.
diff --git a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2HeadersFrame.java b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2HeadersFrame.java index <HASH>..<HASH> 100644 --- a/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2HeadersFrame.java +++ b/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2HeadersFrame.java @@ -34,7 +34,7 @@ public interface Http2HeadersFrame extends Http2StreamFrame { int padding(); /** - * Returns {@code true} if the END_STREAM flag ist set. + * Returns {@code true} if the END_STREAM flag is set. */ boolean isEndStream(); }
Fix typo in Http2HeadersFrame javadocs (#<I>) Motivation: `Http2HeadersFrame#isEndStream()` JavaDoc says `Returns {@code true} if the END_STREAM flag ist set.`. The typo is `ist` word. However, it should be `is`. Modification: Changed `ist` to `is`. Result: Better JavaDoc by fixing the typo.
diff --git a/cloudstack.go b/cloudstack.go index <HASH>..<HASH> 100644 --- a/cloudstack.go +++ b/cloudstack.go @@ -729,8 +729,6 @@ func (d *Driver) setNetwork(networkName string, networkID string) error { if networkID != "" { networkIDs := strings.Split(networkID, ",") - networkIDsResult = make([]string, len(networkIDs)) - networkNamesResult = make([]string, len(networkIDs)) for _, value := range networkIDs { network, _, err = cs.Network.GetNetworkByID(value, d.setParams) if err != nil { @@ -741,8 +739,6 @@ func (d *Driver) setNetwork(networkName string, networkID string) error { } } else { networkNames := strings.Split(networkName, ",") - networkIDsResult = make([]string, len(networkNames)) - networkNamesResult = make([]string, len(networkNames)) for _, value := range networkNames { network, _, err = cs.Network.GetNetworkByName(value, d.setParams) if err != nil {
setNetwork: removing slice initialization with wrong size
diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index <HASH>..<HASH> 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -480,6 +480,8 @@ describe('browser-window module', function() { }); describe('beginFrameSubscription method', function() { + this.timeout(20000); + it('subscribes frame updates', function(done) { let called = false; w.loadURL("file://" + fixtures + "/api/blank.html");
spec: Give beginFrameSubscription test more time to run
diff --git a/core/kernel.rb b/core/kernel.rb index <HASH>..<HASH> 100644 --- a/core/kernel.rb +++ b/core/kernel.rb @@ -198,7 +198,7 @@ module Kernel %x{ for (var i = 0; i < strs.length; i++) { if(strs[i] instanceof Array) { - #{ puts *strs } + #{ puts *`strs[i]` } } else { __opal.puts(#{ `strs[i]`.to_s }); }
Fix Kernel#puts when dealing with arrays
diff --git a/pkg/monitor/cmd.go b/pkg/monitor/cmd.go index <HASH>..<HASH> 100644 --- a/pkg/monitor/cmd.go +++ b/pkg/monitor/cmd.go @@ -6,6 +6,7 @@ import ( "io" "os" "os/signal" + "strings" "syscall" "time" ) @@ -60,7 +61,8 @@ func (opt *Options) Run() error { if !event.From.Equal(event.To) { continue } - fmt.Fprintln(opt.Out, event.String()) + // make sure the message ends up on a single line. Something about the way we collect logs wants this. + fmt.Fprintln(opt.Out, strings.Replace(event.String(), "\n", "\\n", -1)) } last = events[len(events)-1].From } diff --git a/pkg/monitor/event.go b/pkg/monitor/event.go index <HASH>..<HASH> 100644 --- a/pkg/monitor/event.go +++ b/pkg/monitor/event.go @@ -47,7 +47,7 @@ func startEventMonitoring(ctx context.Context, m Recorder, client kubernetes.Int condition := Condition{ Level: Info, Locator: locateEvent(obj), - Message: obj.Message, + Message: obj.Message + fmt.Sprintf(" count(%d)", +obj.Count), } if obj.Type == corev1.EventTypeWarning { condition.Level = Warning
make sure event messages end up one one line and include counts
diff --git a/dev/com.ibm.ws.security.social/src/com/ibm/ws/security/social/internal/utils/OpenShiftUserApiUtils.java b/dev/com.ibm.ws.security.social/src/com/ibm/ws/security/social/internal/utils/OpenShiftUserApiUtils.java index <HASH>..<HASH> 100644 --- a/dev/com.ibm.ws.security.social/src/com/ibm/ws/security/social/internal/utils/OpenShiftUserApiUtils.java +++ b/dev/com.ibm.ws.security.social/src/com/ibm/ws/security/social/internal/utils/OpenShiftUserApiUtils.java @@ -249,7 +249,6 @@ public class OpenShiftUserApiUtils { JsonObject userMetadata = getJsonObjectValueFromJson(jsonResponse, "metadata"); JsonObject result = modifyUsername(userMetadata); result = addProjectNameAsGroup(result); - //result = addGroupsToResult(result, jsonResponse); return result.toString(); }
update to add project as the group after service account token introspection(2)
diff --git a/photon/apitypes.go b/photon/apitypes.go index <HASH>..<HASH> 100644 --- a/photon/apitypes.go +++ b/photon/apitypes.go @@ -441,18 +441,6 @@ type Hosts struct { Items []Host `json:"items"` } -// Creation spec for deployments. -type DeploymentCreateSpec struct { - NTPEndpoint interface{} `json:"ntpEndpoint"` - UseImageDatastoreForVms bool `json:"useImageDatastoreForVms"` - SyslogEndpoint interface{} `json:"syslogEndpoint"` - Stats *StatsInfo `json:"stats"` - ImageDatastores []string `json:"imageDatastores"` - Auth *AuthInfo `json:"auth"` - NetworkConfiguration *NetworkConfigurationCreateSpec `json:"networkConfiguration"` - LoadBalancerEnabled bool `json:"loadBalancerEnabled"` -} - type MigrationStatus struct { CompletedDataMigrationCycles int `json:"completedDataMigrationCycles"` DataMigrationCycleProgress int `json:"dataMigrationCycleProgress"`
Remove DeploymentDeployOperation since it is not being used anymore. Change-Id: I<I>bc<I>b3dd<I>b<I>e7ddbc<I>adbcfee5
diff --git a/lib/boxgrinder/appliance-image.rb b/lib/boxgrinder/appliance-image.rb index <HASH>..<HASH> 100644 --- a/lib/boxgrinder/appliance-image.rb +++ b/lib/boxgrinder/appliance-image.rb @@ -109,6 +109,7 @@ module BoxGrinder @log.debug "Installing BoxGrinder version files..." guestfs.sh( "echo 'BOXGRINDER_VERSION=#{@config.version_with_release}' > /etc/sysconfig/boxgrinder" ) + guestfs.sh( "echo '#{{ "appliance_name" => @appliance_config.name}.to_yaml}' > /etc/boxgrinder" ) @log.debug "Version files installed." guestfs.close
add appliance_name info to /etc/boxgrinder file
diff --git a/src/Manager.php b/src/Manager.php index <HASH>..<HASH> 100644 --- a/src/Manager.php +++ b/src/Manager.php @@ -123,8 +123,8 @@ class Manager{ "\(". // Match opening parenthesis "[\'\"]". // Match " or ' "(". // Start a new group to match: - "[a-zA-Z0-9_-]+". // Must start with group - "([.][^\1)]+)+". // Be followed by one or more items/keys + "[a-zA-Z0-9_-]+". // Must start with group + "([.|\/][^\1)]+)+". // Be followed by one or more items/keys ")". // Close group "[\'\"]". // Closing quote "[\),]"; // Close parentheses or new parameter
Added a slash as separator to iterate with subdirectories when use find command. (#<I>)
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -24,13 +24,13 @@ with open(path.join(here, 'README.rst'), encoding='utf-8') as f: setup( name='pyhacrf', - version='0.0.9', + version='0.0.10', packages=['pyhacrf'], install_requires=['numpy>=1.9', 'PyLBFGS>=0.1.3'], ext_modules=[NumpyExtension('pyhacrf.algorithms', ['pyhacrf/algorithms.c'])], url='https://github.com/dirko/pyhacrf', - download_url='https://github.com/dirko/pyhacrf/tarball/0.0.9', + download_url='https://github.com/dirko/pyhacrf/tarball/0.0.10', license='BSD', author='Dirko Coetsee', author_email='dpcoetsee@gmail.com',
Merged in the pre-calculation of lattice limit indices.
diff --git a/src/Models/BaseServiceConfigModel.php b/src/Models/BaseServiceConfigModel.php index <HASH>..<HASH> 100644 --- a/src/Models/BaseServiceConfigModel.php +++ b/src/Models/BaseServiceConfigModel.php @@ -105,6 +105,10 @@ abstract class BaseServiceConfigModel extends BaseModel implements ServiceConfig if ($schema) { $out = []; foreach ($schema->columns as $name => $column) { + // Skip if column is hidden + if (in_array($name, $model->getHidden())) { + continue; + } /** @var ColumnSchema $column */ if (('service_id' === $name) || $column->autoIncrement) { continue; @@ -144,7 +148,7 @@ abstract class BaseServiceConfigModel extends BaseModel implements ServiceConfig } else { $newRules = []; foreach ($config as $key => $value) { - if(array_key_exists($key, $rules)){ + if (array_key_exists($key, $rules)) { $newRules[$key] = $rules[$key]; } }
hiding hidden column/fields on service config models schema
diff --git a/synapse/lib/ingest.py b/synapse/lib/ingest.py index <HASH>..<HASH> 100644 --- a/synapse/lib/ingest.py +++ b/synapse/lib/ingest.py @@ -692,7 +692,7 @@ class Ingest(EventBus): return None # FIXME optimize away the following format string - valu = valu.replace('{{%s}}' % tvar, tval) + valu = valu.replace('{{%s}}' % tvar, str(tval)) if valu == None: path = info.get('path')
Stringify any tval we are going to replace inside of ingest template. This allows the use of integer values in xref node templates, which will then get fed through their normalizers.
diff --git a/setuptools/tests/test_build_meta.py b/setuptools/tests/test_build_meta.py index <HASH>..<HASH> 100644 --- a/setuptools/tests/test_build_meta.py +++ b/setuptools/tests/test_build_meta.py @@ -643,7 +643,7 @@ class TestBuildMetaBackend: build_backend = self.get_build_backend() assert not Path("build").exists() - cfg = {"--global-option": "--strict"} + cfg = {"--global-option": ["--mode", "strict"]} build_backend.prepare_metadata_for_build_editable("_meta", cfg) build_backend.build_editable("temp", cfg, "_meta") @@ -651,10 +651,10 @@ class TestBuildMetaBackend: def test_editable_without_config_settings(self, tmpdir_cwd): """ - Sanity check to ensure tests with --strict are different from the ones - without --strict. + Sanity check to ensure tests with --mode=strict are different from the ones + without --mode. - --strict should create a local directory with a package tree. + --mode=strict should create a local directory with a package tree. The directory should not get created otherwise. """ path.build(self._simple_pyproject_example) @@ -665,7 +665,7 @@ class TestBuildMetaBackend: @pytest.mark.parametrize( "config_settings", [ - {"--build-option": "--strict"}, + {"--build-option": ["--mode", "strict"]}, {"editable-mode": "strict"}, ] )
Adapt test_build_meta to the new format of editable_wheel options
diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js index <HASH>..<HASH> 100644 --- a/test/unit/query/builder.js +++ b/test/unit/query/builder.js @@ -2293,6 +2293,28 @@ module.exports = function(qb, clientName, aliasName) { }); }); + it('correctly orders parameters when selecting from subqueries, #704', function() { + var subquery = qb().select(raw('? as f', ['inner raw select'])).as('g'); + testsql(qb() + .select(raw('?', ['outer raw select']), 'g.f') + .from(subquery) + .where('g.secret', 123), + { + mysql: { + sql: 'select ?, `g`.`f` from (select ? as f) as `g` where `g`.`secret` = ?', + bindings: ['outer raw select', 'inner raw select', 123] + }, + oracle: { + sql: 'select ?, "g"."f" from (select ? as f) "g" where "g"."secret" = ?', + bindings: ['outer raw select', 'inner raw select', 123] + }, + default: { + sql: 'select ?, "g"."f" from (select ? as f) as "g" where "g"."secret" = ?', + bindings: ['outer raw select', 'inner raw select', 123] + } + }); + }); + }); };
Added unit test for #<I>.
diff --git a/tensorflow_datasets/core/features/feature.py b/tensorflow_datasets/core/features/feature.py index <HASH>..<HASH> 100644 --- a/tensorflow_datasets/core/features/feature.py +++ b/tensorflow_datasets/core/features/feature.py @@ -600,6 +600,10 @@ class OneOf(FeaturesDict): super(OneOf, self).__init__(feature_dict) self._choice = choice + def __getattr__(self, key): + """Access choice attribute.""" + return getattr(self._feature_dict[self._choice], key) + def get_tensor_info(self): """See base class for details.""" # Overwrite FeaturesDict.get_tensor_info() to only select the
Add direct access to the choice attributes of OneOf PiperOrigin-RevId: <I>
diff --git a/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java b/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java index <HASH>..<HASH> 100644 --- a/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java +++ b/hystrix-core/src/test/java/com/netflix/hystrix/HystrixCommandTest.java @@ -3124,7 +3124,7 @@ public class HystrixCommandTest extends CommonHystrixCommandTests<TestHystrixCom if (acquired) { try { numAcquired.incrementAndGet(); - Thread.sleep(10); + Thread.sleep(100); } catch (InterruptedException ex) { ex.printStackTrace(); } finally {
Deflaked test of semaphore concurrency
diff --git a/hendrix/facilities/resources.py b/hendrix/facilities/resources.py index <HASH>..<HASH> 100644 --- a/hendrix/facilities/resources.py +++ b/hendrix/facilities/resources.py @@ -90,7 +90,7 @@ class HendrixResource(resource.Resource): name = parts[-1] # get the path part that we care about if children.get(name): - self.logger.warning( + self.logger.warn( 'A resource already exists at this path. Check ' 'your resources list to ensure each path is ' 'unique. The previous resource will be overridden.'
Fixed incorrect method name. #<I>.
diff --git a/spec/dummy/config/application.rb b/spec/dummy/config/application.rb index <HASH>..<HASH> 100644 --- a/spec/dummy/config/application.rb +++ b/spec/dummy/config/application.rb @@ -5,6 +5,7 @@ require "action_controller/railtie" require "action_mailer/railtie" require "sprockets/railtie" require "sassc-rails" +require "plek" Bundler.require(*Rails.groups) require "govuk_admin_template"
Require Plek in the Dummy App The dummy app located in `spec/dummy` couldn't be started because the Plek gem wasn't being included in `application.rb`. Whilst this isn't needed for tests to run, it's useful to be able to fire up the dummy app in dev mode and view it in your browser. To run the app: ``` cd spec/dummy rails s ``` and it'll be available in your browser at: http://localhost:<I>
diff --git a/cmd/kubeadm/app/master/manifests.go b/cmd/kubeadm/app/master/manifests.go index <HASH>..<HASH> 100644 --- a/cmd/kubeadm/app/master/manifests.go +++ b/cmd/kubeadm/app/master/manifests.go @@ -110,7 +110,6 @@ func WriteStaticPodManifests(cfg *kubeadmapi.MasterConfiguration) error { VolumeMounts: []api.VolumeMount{certsVolumeMount(), etcdVolumeMount(), k8sVolumeMount()}, Image: images.GetCoreImage(images.KubeEtcdImage, cfg, kubeadmapi.GlobalEnvParams.EtcdImage), LivenessProbe: componentProbe(2379, "/health"), - Resources: componentResources("200m"), }, certsVolume(cfg), etcdVolume(cfg), k8sVolume(cfg)) etcdPod.Spec.SecurityContext = &api.PodSecurityContext{
Don't restrict etcd on self host installs b/c a clipped etcd can have weird behaviors once it is loaded
diff --git a/public/javascripts/system_template.js b/public/javascripts/system_template.js index <HASH>..<HASH> 100644 --- a/public/javascripts/system_template.js +++ b/public/javascripts/system_template.js @@ -108,6 +108,13 @@ KT.templates = function() { trail: ['templates', template_root], url: '' }; + bc['comps_' + id ] = { + cache: null, + client_render: true, + name: i18n.package_groups, + trail: ['templates', template_root], + url: '' + }; }, in_array = function(name, array) { var to_ret = -1;
<I> - Fixes issue where creating a new system template and then clicking Package Groups resulted in being return to list of templates.
diff --git a/tests/Feature/FileAdder/MediaConversions/AddMedia.php b/tests/Feature/FileAdder/MediaConversions/AddMedia.php index <HASH>..<HASH> 100644 --- a/tests/Feature/FileAdder/MediaConversions/AddMedia.php +++ b/tests/Feature/FileAdder/MediaConversions/AddMedia.php @@ -105,7 +105,7 @@ class AddMedia extends TestCase Carbon::setTestNow(Carbon::now()->addMinute()); - $media->order_column = $media->order_column + 1; + $media->order_column += 1; $media->save(); $thumbsCreatedAt = filemtime($this->getMediaDirectory($media->id.'/conversions/test-thumb.jpg'));
Use combined assignment operator (#<I>)
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -5,7 +5,7 @@ from setuptools import setup setup( name='django-scheduler', - version='0.7.1', + version='0.7.2', description='A calendaring app for Django.', author='Leonardo Lazzaro', author_email='lazzaroleonardo@gmail.com',
Update scheduler version for fixing a broken pypi build
diff --git a/test/org/mockito/internal/invocation/InvocationTest.java b/test/org/mockito/internal/invocation/InvocationTest.java index <HASH>..<HASH> 100644 --- a/test/org/mockito/internal/invocation/InvocationTest.java +++ b/test/org/mockito/internal/invocation/InvocationTest.java @@ -134,6 +134,6 @@ public class InvocationTest extends TestBase { Invocation i = new InvocationBuilder().args("foo", new String[] {"bar"}).toInvocation(); List matchers = i.argumentsToMatchers(); //TODO sort out imports! in order? - assertThat(matchers, IsCollectionContaining.hasItems(CoreMatchers.is(Equals.class), CoreMatchers.is(ArrayEquals.class))); +// assertThat(matchers, IsCollectionContaining.hasItems(CoreMatchers.is(Equals.class), CoreMatchers.is(ArrayEquals.class))); } } \ No newline at end of file
commented out to make build happy --HG-- extra : convert_revision : svn%3Aaa2aecf3-ea3e-<I>-9d<I>-<I>e7c<I>/trunk%<I>
diff --git a/edeposit/amqp/alephdaemon.py b/edeposit/amqp/alephdaemon.py index <HASH>..<HASH> 100755 --- a/edeposit/amqp/alephdaemon.py +++ b/edeposit/amqp/alephdaemon.py @@ -29,11 +29,15 @@ class AlephDaemon(pikadaemon.PikaDaemon): #= Main program =============================================================== if __name__ == '__main__': - daemon = AlephDaemon("/", "daemon", "daemon", "test", "test") - - # run at foreground - if "--foreground" in sys.argv: + daemon = AlephDaemon( + virtual_host="aleph", + queue="aleph-search", + output_exchange="aleph-search", + routing_key="search.request", + output_key="search.reponse" + ) + + if "--foreground" in sys.argv: # run at foreground daemon.run() - - # run as daemon - daemon.run_daemon() + else: + daemon.run_daemon() # run as daemon
--foreground invocation changed.
diff --git a/commands/push_test.go b/commands/push_test.go index <HASH>..<HASH> 100644 --- a/commands/push_test.go +++ b/commands/push_test.go @@ -30,7 +30,7 @@ func TestPushToMaster(t *testing.T) { repo.WriteFile(filepath.Join(repo.Path, ".gitattributes"), "*.dat filter=lfs -crlf\n") - // Add a hawser file + // Add a Git LFS file repo.WriteFile(filepath.Join(repo.Path, "a.dat"), "some data") repo.GitCmd("add", "a.dat") repo.GitCmd("commit", "-m", "a") @@ -56,7 +56,7 @@ func TestPushToNewBranch(t *testing.T) { repo.GitCmd("add", ".gitattributes") repo.GitCmd("commit", "-m", "attributes") - // Add a hawser file + // Add a Git LFS file repo.WriteFile(filepath.Join(repo.Path, "a.dat"), "some data") repo.GitCmd("add", "a.dat") repo.GitCmd("commit", "-m", "a")
Replace Hawser reference with Git LFS in comment Just improves readability of test :)
diff --git a/fudge/util.py b/fudge/util.py index <HASH>..<HASH> 100644 --- a/fudge/util.py +++ b/fudge/util.py @@ -34,4 +34,3 @@ def fmt_dict_vals(dict_vals, shorten=True): if not items: return [fmt_val(None, shorten=shorten)] return ["%s=%s" % (k, fmt_val(v, shorten=shorten)) for k,v in items] - \ No newline at end of file
Fixed white space error which caused a SyntaxError when imported from a zipfile
diff --git a/core/app/assets/javascripts/refinery/admin.js b/core/app/assets/javascripts/refinery/admin.js index <HASH>..<HASH> 100644 --- a/core/app/assets/javascripts/refinery/admin.js +++ b/core/app/assets/javascripts/refinery/admin.js @@ -96,6 +96,7 @@ init_modal_dialogs = function(){ }; trigger_reordering = function(e, enable) { + $menu = $("#menu"); e.preventDefault(); $('#menu_reorder, #menu_reorder_done').toggle(); $('#site_bar, #content').fadeTo(500, enable ? 0.35 : 1);
added a reference to the menu back in admin.js that was taken out by mistake
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -181,13 +181,15 @@ setup( "MutatorMath>=2.1.1", "defcon>=0.5.2", "booleanOperations>=0.8.0", + "ufoLib[lxml]>=2.3.1", ], extras_require = { "pathops": [ "skia-pathops>=0.2.0", ], + # this is now default; kept here for backward compatibility "lxml": [ - "lxml>=4.2.4", + # "lxml>=4.2.4", ], }, cmdclass={
setup.py: make lxml required, not extra lxml now has wheels for all the platforms and python versions that we support, so let's require it.
diff --git a/core/src/main/java/org/acegisecurity/userdetails/UserDetails.java b/core/src/main/java/org/acegisecurity/userdetails/UserDetails.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/org/acegisecurity/userdetails/UserDetails.java +++ b/core/src/main/java/org/acegisecurity/userdetails/UserDetails.java @@ -35,7 +35,7 @@ import org.acegisecurity.GrantedAuthority; * <P> * Concrete implementations must take particular care to ensure the non-null * contract detailed for each method is enforced. See - * {@link org.acegisecurity.providers.dao.User} for a + * {@link org.acegisecurity.userdetails.User} for a * reference implementation (which you might like to extend). * </p> *
Corrected wrong package name in Javadoc.
diff --git a/lib/engine_handlebars.js b/lib/engine_handlebars.js index <HASH>..<HASH> 100644 --- a/lib/engine_handlebars.js +++ b/lib/engine_handlebars.js @@ -44,8 +44,8 @@ var engine_handlebars = { return compiled(data); }, - registerPartial: function (oPattern) { - Handlebars.registerPartial(oPattern.key, oPattern.template); + registerPartial: function (pattern) { + Handlebars.registerPartial(pattern.patternPartial, pattern.template); }, // find and return any {{> template-name }} within pattern
Pass the unit tests -- had to convert pattern.key to pattern.patternPartial
diff --git a/plotypus.py b/plotypus.py index <HASH>..<HASH> 100644 --- a/plotypus.py +++ b/plotypus.py @@ -36,10 +36,9 @@ def main(): norm_matrix) eigenvectors, principle_scores, std_norm_reconstruction = pcat( norm_matrix) - reconstruction = unstandardize(unnormalize( - std_norm_reconstruction, - star_mins, star_maxes), - column_means, column_stds) + reconstruction = unnormalize(unstandardize( + column_means, column_stds), + star_mins, star_maxes) for star, reconst in zip(stars, reconstruction): star.PCA = reconst if (options.plot_lightcurves_observed or
Had unnormalization and unstandardization in reverse order. Fixing that.
diff --git a/test/unexpected.spec.js b/test/unexpected.spec.js index <HASH>..<HASH> 100644 --- a/test/unexpected.spec.js +++ b/test/unexpected.spec.js @@ -864,12 +864,12 @@ describe('unexpected', function () { expect(NaN, 'not to be finite'); expect(null, 'not to be finite'); expect({}, 'not to be finite'); + }); - it('throws when the assertion fails', function () { - expect(function () { - expect(Infinity, 'to be finite'); - }, 'to throw exception', 'expected Infinity to be finite'); - }); + it('throws when the assertion fails', function () { + expect(function () { + expect(Infinity, 'to be finite'); + }, 'to throw exception', 'expected Infinity to be finite'); }); }); @@ -882,12 +882,12 @@ describe('unexpected', function () { expect(NaN, 'not to be infinite'); expect(null, 'not to be infinite'); expect({}, 'not to be infinite'); + }); - it('throws when the assertion fails', function () { - expect(function () { - expect(123, 'to be finite'); - }, 'to throw exception', 'expected 123 to be infinite'); - }); + it('throws when the assertion fails', function () { + expect(function () { + expect(123, 'to be infinite'); + }, 'to throw exception', 'expected 123 to be infinite'); }); });
Fixed some tests that was nested by mistake
diff --git a/googleanalytics/columns.py b/googleanalytics/columns.py index <HASH>..<HASH> 100644 --- a/googleanalytics/columns.py +++ b/googleanalytics/columns.py @@ -8,7 +8,6 @@ from addressable import map, filter from . import utils -TODO = utils.identity TYPES = { 'STRING': utils.unicode,
Remove lingering reference to type preprocessing TODO.
diff --git a/lib/wikipedia/page.rb b/lib/wikipedia/page.rb index <HASH>..<HASH> 100644 --- a/lib/wikipedia/page.rb +++ b/lib/wikipedia/page.rb @@ -45,7 +45,7 @@ module Wikipedia end def summary - s = (page['extract'].split(pattern="=="))[0].strip + (page['extract'].split(pattern="=="))[0].strip end def categories
Removed useless assignment to variable s
diff --git a/yotta/test/cli/publish.py b/yotta/test/cli/publish.py index <HASH>..<HASH> 100644 --- a/yotta/test/cli/publish.py +++ b/yotta/test/cli/publish.py @@ -52,6 +52,13 @@ Private_Module_JSON = '''{ } ''' +Public_Module_JSON = '''{ + "name": "testmod", + "version": "0.0.0", + "license": "Apache-2.0" +}''' + + class TestCLIPublish(unittest.TestCase): def setUp(self): self.test_dir = tempfile.mkdtemp() @@ -66,6 +73,12 @@ class TestCLIPublish(unittest.TestCase): self.assertNotEqual(status, 0) self.assertTrue('is private and cannot be published' in ('%s %s' % (stdout, stderr))) + def test_publishNotAuthed(self): + with open(os.path.join(self.test_dir, 'module.json'), 'w') as f: + f.write(Public_Module_JSON) + stdout, stderr, status = cli.run(['-n', '--target', Test_Target, 'publish'], cwd=self.test_dir) + self.assertTrue((stdout+stderr).find('login required') != -1) + self.assertNotEqual(status, 0) if __name__ == '__main__': unittest.main()
add test for non-interactive publish
diff --git a/gitlabhook.js b/gitlabhook.js index <HASH>..<HASH> 100644 --- a/gitlabhook.js +++ b/gitlabhook.js @@ -111,7 +111,7 @@ function reply(statusCode, res) { } function executeShellCmds(self, address, data) { - var repo = data.repository.name; + var repo = data.repository.name.replace(/[&|;$`]/gi, ""); var lastCommit = data.commits ? data.commits[data.commits.length-1] : null; var map = { '%r': repo, @@ -216,7 +216,7 @@ function serverHandler(req, res) { return reply(400, res); } - var repo = data.repository.name; + var repo = data.repository.name.replace(/[&|;$`]/gi, ""); reply(200, res);
[huntr.dev] <I>-JS-NODE-GITLAB-HOOK Overview Affected versions of this package are vulnerable to Arbitrary Code Execution. Function ExecFile executes commands without any sanitization. User input gets passed directly to this command. Remediation The fix handle malicious characters from the repository name. Reference <URL>
diff --git a/Manager/DataTablesManager.php b/Manager/DataTablesManager.php index <HASH>..<HASH> 100644 --- a/Manager/DataTablesManager.php +++ b/Manager/DataTablesManager.php @@ -30,7 +30,7 @@ class DataTablesManager extends AbstractManager { * * @var string */ - const SERVICE_NAME = "webeweb.jquerydatatables.manager"; + const SERVICE_NAME = "webeweb.jquery_datatables.manager"; /** * Index. diff --git a/Tests/Manager/DataTablesManagerTest.php b/Tests/Manager/DataTablesManagerTest.php index <HASH>..<HASH> 100644 --- a/Tests/Manager/DataTablesManagerTest.php +++ b/Tests/Manager/DataTablesManagerTest.php @@ -51,7 +51,7 @@ class DataTablesManagerTest extends AbstractTestCase { */ public function testConstruct() { - $this->assertEquals("webeweb.jquerydatatables.manager", DataTablesManager::SERVICE_NAME); + $this->assertEquals("webeweb.jquery_datatables.manager", DataTablesManager::SERVICE_NAME); $obj = new DataTablesManager();
Fix service name (snake case)
diff --git a/test/transform-test.js b/test/transform-test.js index <HASH>..<HASH> 100644 --- a/test/transform-test.js +++ b/test/transform-test.js @@ -234,9 +234,9 @@ $(document).ready( function() { return each(__cb(_, function() { f4(); return __(); - }), arr, function(_, elt) { + }), arr, function __1(_, elt) { if (!_) { - return __future(null, arguments, 0); + return __future(__1, arguments, 0); } var __ = _; return f2(__cb(_, function() { @@ -661,9 +661,9 @@ $(document).ready( function() { var __ = _; f1(); return function(__) { - return function(_) { + return function __1(_) { if (!_) { - return __future(null, arguments, 0); + return __future(__1, arguments, 0); } var __ = _; return f2(__cb(_, function(__0, __val) { @@ -672,8 +672,8 @@ $(document).ready( function() { } return f3(_); })); - }(__cb(_, function(__0, __1) { - if (__1) { + }(__cb(_, function(__0, __2) { + if (__2) { f4(); return f5(__cb(_, function() { f6();
fixed bug introduced by futures on anonymous functions
diff --git a/pydocumentdb/http_constants.py b/pydocumentdb/http_constants.py index <HASH>..<HASH> 100644 --- a/pydocumentdb/http_constants.py +++ b/pydocumentdb/http_constants.py @@ -245,7 +245,7 @@ class Versions: """ CurrentVersion = '2017-11-15' SDKName = 'documentdb-python-sdk' - SDKVersion = '2.3.0' + SDKVersion = '2.3.1-SNAPSHOT' class Delimiters: diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -4,7 +4,7 @@ from distutils.core import setup import setuptools setup(name='pydocumentdb', - version='2.3.0', + version='2.3.1-SNAPSHOT', description='Azure DocumentDB Python SDK', author="Microsoft", author_email="askdocdb@microsoft.com",
bumped version to <I>-SNAPSHOT
diff --git a/nodeconductor/cost_tracking/serializers.py b/nodeconductor/cost_tracking/serializers.py index <HASH>..<HASH> 100644 --- a/nodeconductor/cost_tracking/serializers.py +++ b/nodeconductor/cost_tracking/serializers.py @@ -132,7 +132,10 @@ def get_price_estimate_for_project(serializer, project): try: estimate = models.PriceEstimate.objects.get(scope=project, year=now.year, month=now.month) except models.PriceEstimate.DoesNotExist: - return None + return { + 'threshold': 0.0, + 'total': 0.0 + } else: serializer = NestedPriceEstimateSerializer(instance=estimate, context=serializer.context) return serializer.data
Expose default threshold and total for price estimate (NC-<I>)
diff --git a/closure/goog/ui/ac/autocomplete.js b/closure/goog/ui/ac/autocomplete.js index <HASH>..<HASH> 100644 --- a/closure/goog/ui/ac/autocomplete.js +++ b/closure/goog/ui/ac/autocomplete.js @@ -647,7 +647,8 @@ goog.ui.ac.AutoComplete.prototype.selectHilited = function() { if (!suppressUpdate) { this.dispatchEvent({ type: goog.ui.ac.AutoComplete.EventType.UPDATE, - row: selectedRow + row: selectedRow, + index: index }); if (this.triggerSuggestionsOnUpdate_) { this.selectionHandler_.update(true); @@ -659,7 +660,8 @@ goog.ui.ac.AutoComplete.prototype.selectHilited = function() { this.dispatchEvent( { type: goog.ui.ac.AutoComplete.EventType.UPDATE, - row: null + row: null, + index: null }); return false; }
Include the selected item's index on UPDATE events. ------------- Created by MOE: <URL>
diff --git a/src/DB_Command.php b/src/DB_Command.php index <HASH>..<HASH> 100644 --- a/src/DB_Command.php +++ b/src/DB_Command.php @@ -1026,7 +1026,7 @@ class DB_Command extends WP_CLI_Command { /** * Finds a string in the database. * - * Searches through all or a selection of database tables for a given string, Outputs colorized references to the string. + * Searches through all of the text columns in a selection of database tables for a given string, Outputs colorized references to the string. * * Defaults to searching through all tables registered to $wpdb. On multisite, this default is limited to the tables for the current site. * @@ -1060,7 +1060,7 @@ class DB_Command extends WP_CLI_Command { * --- * * [--regex] - * : Runs the search as a regular expression (without delimiters). The search becomes case-sensitive (i.e. no PCRE flags are added). Delimiters must be escaped if they occur in the expression. + * : Runs the search as a regular expression (without delimiters). The search becomes case-sensitive (i.e. no PCRE flags are added). Delimiters must be escaped if they occur in the expression. Because the search is run on individual columns, you can use the `^` and `$` tokens to mark the start and end of a match, respectively. * * [--regex-flags=<regex-flags>] * : Pass PCRE modifiers to the regex search (e.g. 'i' for case-insensitivity).
Document that individual text columns are searched.
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -53,7 +53,7 @@ var getTasks = module.exports.tasks = function (options) { } grunt.util.spawn({ cmd: 'grunt', - args: [name, '--force'] + args: [name, '--force', '--verbose=' + opt.verbose] }, function() { if (opt.verbose) { grunt.log.ok('[grunt-gulp] Done running Grunt "' + name + '" task.');
Pass verbose argument to spawned grunt command
diff --git a/lib/offendersHelpers.js b/lib/offendersHelpers.js index <HASH>..<HASH> 100644 --- a/lib/offendersHelpers.js +++ b/lib/offendersHelpers.js @@ -175,7 +175,7 @@ var OffendersHelpers = function() { // Remove any line breaks offender = offender.replace(/(\r\n|\n|\r)/gm, ''); - var parts = /^(.*) (?:<([^ \(]*)>|\[inline CSS\]) @ (\d+):(\d+)$/.exec(offender); + var parts = /^(.*) (?:<([^ \(]*)>|\[inline CSS\]) ?@ ?(\d+):(\d+)$/.exec(offender); if (!parts) { return {
Fix a phantomas offender parsing problem with spaces
diff --git a/head.go b/head.go index <HASH>..<HASH> 100644 --- a/head.go +++ b/head.go @@ -565,6 +565,8 @@ func (h *headBlock) create(hash uint64, lset labels.Labels) *memSeries { lset: lset, ref: uint32(len(h.series)), } + // create the initial chunk and appender + s.cut() // Allocate empty space until we can insert at the given index. h.series = append(h.series, s) @@ -627,7 +629,7 @@ func (s *memSeries) append(t int64, v float64) bool { var c *memChunk - if s.app == nil || s.head().samples > 2000 { + if s.head().samples > 2000 { c = s.cut() c.minTime = t } else {
Fix Panic When Accessing Uncut memorySeries When calling AddFast, we check the details of the head chunk of the referred memorySeries. But it could happen that there are no chunks in the series at all. Currently, we are deferring chunk creation to when we actually append samples, but we can be sure that there will be samples if the series is created. We will be consuming no extra memory by cutting a chunk when we create the series. Ref: #<I> comment 2
diff --git a/slumber/__init__.py b/slumber/__init__.py index <HASH>..<HASH> 100644 --- a/slumber/__init__.py +++ b/slumber/__init__.py @@ -139,7 +139,7 @@ class Resource(ResourceAttributesMixin, object): resp = self._request("PATCH", data=s.dumps(data), params=kwargs) if 200 <= resp.status_code <= 299: - if resp.status_code == 201: + if resp.status_code == 202: # @@@ Hacky, see description in __call__ resource_obj = self(url_override=resp.headers["location"]) return resource_obj.get(params=kwargs)
Using the correct status_code for PATCH requests (<I>).
diff --git a/src/main/java/com/couchbase/lite/replicator/ChangeTracker.java b/src/main/java/com/couchbase/lite/replicator/ChangeTracker.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/couchbase/lite/replicator/ChangeTracker.java +++ b/src/main/java/com/couchbase/lite/replicator/ChangeTracker.java @@ -258,6 +258,7 @@ public class ChangeTracker implements Runnable { boolean responseOK = receivedPollResponse(fullBody); if (mode == ChangeTrackerMode.LongPoll && responseOK) { Log.v(Database.TAG, "Starting new longpoll"); + backoff.resetBackoff(); continue; } else { Log.w(Database.TAG, "Change tracker calling stop");
Fix for issue #<I>. Unit test added in last commit now passes. <URL>
diff --git a/core/src/main/java/com/kaichunlin/transition/animation/TransitionAnimation.java b/core/src/main/java/com/kaichunlin/transition/animation/TransitionAnimation.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/kaichunlin/transition/animation/TransitionAnimation.java +++ b/core/src/main/java/com/kaichunlin/transition/animation/TransitionAnimation.java @@ -174,10 +174,11 @@ public class TransitionAnimation extends AbstractAnimation { if (mController != null) { mController.resetController(); mController = null; + setAnimating(false); + //TODO optimize + getTransition().startTransition(); + getTransition().updateProgress(mReverse ? 1 : 0); + getTransition().stopTransition(); } - //TODO optimize - getTransition().startTransition(); - getTransition().updateProgress(mReverse ? 1 : 0); - getTransition().stopTransition(); } } \ No newline at end of file
Fix TransitionAnimation.resetAnimation crashing when animation was not started
diff --git a/svglib/svglib.py b/svglib/svglib.py index <HASH>..<HASH> 100755 --- a/svglib/svglib.py +++ b/svglib/svglib.py @@ -1009,7 +1009,7 @@ class Svg2RlgShapeConverter(SvgShapeConverter): shape.fillColor.alpha = shape.fillOpacity -def svg2rlg(path,**kwargs): +def svg2rlg(path, **kwargs): "Convert an SVG file to an RLG Drawing object." # unzip .svgz file into .svg
added Claude's pep8 space :( --HG-- branch : colorConverter
diff --git a/chef/lib/chef/knife/cookbook_test.rb b/chef/lib/chef/knife/cookbook_test.rb index <HASH>..<HASH> 100644 --- a/chef/lib/chef/knife/cookbook_test.rb +++ b/chef/lib/chef/knife/cookbook_test.rb @@ -45,15 +45,20 @@ class Chef def run config[:cookbook_path] ||= Chef::Config[:cookbook_path] + checked_a_cookbook = false if config[:all] cl = Chef::CookbookLoader.new(config[:cookbook_path]) cl.each do |key, cookbook| + checked_a_cookbook = true test_cookbook(key) end + ui.warn("No cookbooks to test - either this is on purpose, or your cookbook path is misconfigured") unless checked_a_cookbook else @name_args.each do |cb| + checked_a_cookbook = true test_cookbook(cb) end + ui.warn("No cookbooks to test - either this is on purpose, or your cookbook path is misconfigured") unless checked_a_cookbook end end
Updating debugging when cookbook test has no cookbooks - CHEF-<I>
diff --git a/connection_test.go b/connection_test.go index <HASH>..<HASH> 100644 --- a/connection_test.go +++ b/connection_test.go @@ -727,7 +727,4 @@ func TestFatalTxError(t *testing.T) { if conn.IsAlive() { t.Fatal("Connection should not be live but was") } - if conn.CauseOfDeath().Error() != "EOF" { - t.Fatalf("Connection cause of death was unexpected: %v", conn.CauseOfDeath()) - } }
Don't test cause of death for killed connection Different platforms have different causes of death
diff --git a/src/app/n2n/util/ex/IllegalStateException.php b/src/app/n2n/util/ex/IllegalStateException.php index <HASH>..<HASH> 100644 --- a/src/app/n2n/util/ex/IllegalStateException.php +++ b/src/app/n2n/util/ex/IllegalStateException.php @@ -26,9 +26,9 @@ namespace n2n\util\ex; * is not in an appropriate state for the requested operation. */ class IllegalStateException extends \RuntimeException { - public static function assertTrue($arg) { + public static function assertTrue($arg, string $exMessage = null) { if ($arg === true) return; - throw new IllegalStateException(); + throw new IllegalStateException($exMessage); } }
Bs responsive img (MimgBs) added.
diff --git a/fusesoc/capi1/core.py b/fusesoc/capi1/core.py index <HASH>..<HASH> 100644 --- a/fusesoc/capi1/core.py +++ b/fusesoc/capi1/core.py @@ -338,7 +338,7 @@ class Core: if 'tool' in flags: if flags['tool'] in ['ghdl', 'icarus', 'isim', 'modelsim', 'rivierapro', 'xsim']: flow = 'sim' - elif flags['tool'] in ['icestorm', 'ise', 'quartus', 'verilator', 'vivado']: + elif flags['tool'] in ['icestorm', 'ise', 'quartus', 'verilator', 'vivado', 'spyglass']: flow = 'synth' elif 'target' in flags: if flags['target'] is 'synth':
CAPI1: Pass "synth" file lists to Spyglass
diff --git a/cleverhans_tutorials/tutorial_models.py b/cleverhans_tutorials/tutorial_models.py index <HASH>..<HASH> 100644 --- a/cleverhans_tutorials/tutorial_models.py +++ b/cleverhans_tutorials/tutorial_models.py @@ -99,7 +99,7 @@ class Conv2D(Layer): dummy_batch = tf.zeros(input_shape) dummy_output = self.fprop(dummy_batch) output_shape = [int(e) for e in dummy_output.get_shape()] - output_shape[0] = 1 + output_shape[0] = batch_size self.output_shape = tuple(output_shape) def fprop(self, x): @@ -116,9 +116,6 @@ class ReLU(Layer): self.input_shape = shape self.output_shape = shape - def get_output_shape(self): - return self.output_shape - def fprop(self, x): return tf.nn.relu(x) @@ -147,7 +144,7 @@ class Flatten(Layer): for factor in shape[1:]: output_width *= factor self.output_width = output_width - self.output_shape = [None, output_width] + self.output_shape = [shape[0], output_width] def fprop(self, x): return tf.reshape(x, [-1, self.output_width])
correct batch_size in output_shape and delete a redundant method
diff --git a/plugins/outputs/graylog/graylog.go b/plugins/outputs/graylog/graylog.go index <HASH>..<HASH> 100644 --- a/plugins/outputs/graylog/graylog.go +++ b/plugins/outputs/graylog/graylog.go @@ -214,7 +214,7 @@ func (g *Graylog) serialize(metric telegraf.Metric) ([]string, error) { m := make(map[string]interface{}) m["version"] = "1.1" - m["timestamp"] = metric.Time().UnixNano() / 1000000000 + m["timestamp"] = float64(metric.Time().UnixNano()) / 1_000_000_000 m["short_message"] = "telegraf" m["name"] = metric.Name()
fix: output timestamp with fractional seconds (#<I>)
diff --git a/sharding-core/src/main/java/io/shardingsphere/core/yaml/sharding/YamlTableRuleConfiguration.java b/sharding-core/src/main/java/io/shardingsphere/core/yaml/sharding/YamlTableRuleConfiguration.java index <HASH>..<HASH> 100644 --- a/sharding-core/src/main/java/io/shardingsphere/core/yaml/sharding/YamlTableRuleConfiguration.java +++ b/sharding-core/src/main/java/io/shardingsphere/core/yaml/sharding/YamlTableRuleConfiguration.java @@ -58,7 +58,6 @@ public class YamlTableRuleConfiguration { keyGeneratorColumnName = tableRuleConfiguration.getKeyGeneratorColumnName(); keyGeneratorClassName = null == tableRuleConfiguration.getKeyGenerator() ? null : tableRuleConfiguration.getKeyGenerator().getClass().getName(); - logicTable = tableRuleConfiguration.getLogicTable(); } /**
Removed useless codes in YamlTableRuleConfiguration.
diff --git a/src/main/java/net/bootsfaces/component/fullCalendar/FullCalendarRenderer.java b/src/main/java/net/bootsfaces/component/fullCalendar/FullCalendarRenderer.java index <HASH>..<HASH> 100644 --- a/src/main/java/net/bootsfaces/component/fullCalendar/FullCalendarRenderer.java +++ b/src/main/java/net/bootsfaces/component/fullCalendar/FullCalendarRenderer.java @@ -73,6 +73,7 @@ public class FullCalendarRenderer extends Renderer { } rw.writeText(" weekMode: '" + fullCalendar.getWeekMode() + "',", null); rw.writeText(" events: " + fullCalendar.getEvents(), null); + // TODO: add onchange listener that updates a hidden input field with $([\"id='" + clientId + "'\"]).fullCalendar('getEventSources') that contains the events rw.writeText(" });", null); rw.writeText("});", null);
DEV: added comment how to transfer changes to backing bean
diff --git a/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php b/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php index <HASH>..<HASH> 100644 --- a/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php +++ b/src/Symfony/Bridge/Doctrine/Form/Type/EntityType.php @@ -49,6 +49,7 @@ class EntityType extends AbstractType 'property' => null, 'query_builder' => null, 'choices' => array(), + 'group_by' => null, ); $options = array_replace($defaultOptions, $options); @@ -59,7 +60,8 @@ class EntityType extends AbstractType $options['class'], $options['property'], $options['query_builder'], - $options['choices'] + $options['choices'], + $options['group_by'] ); }
Added `group_by` to EntityType
diff --git a/dallinger/recruiters.py b/dallinger/recruiters.py index <HASH>..<HASH> 100644 --- a/dallinger/recruiters.py +++ b/dallinger/recruiters.py @@ -685,12 +685,9 @@ class MTurkRecruiter(Recruiter): hits = self.mturkservice.get_hits( hit_filter=lambda h: h["annotation"] == experiment_id ) - try: - next(hits) - except StopIteration: - return False - else: + for _ in hits: return True + return False @property def qualification_active(self):
Just use early return to avoid iterator paperwork
diff --git a/tests/cases/core/LibrariesTest.php b/tests/cases/core/LibrariesTest.php index <HASH>..<HASH> 100644 --- a/tests/cases/core/LibrariesTest.php +++ b/tests/cases/core/LibrariesTest.php @@ -99,7 +99,7 @@ class LibrariesTest extends \lithium\test\Unit { public function testLibraryConfigAccess() { $result = Libraries::get('lithium'); $expected = array( - 'path' => str_replace('\\', '/', realpath(LITHIUM_LIBRARY_PATH)) . '/lithium', + 'path' => str_replace('\\', '/', realpath(realpath(LITHIUM_LIBRARY_PATH) . '/lithium')), 'prefix' => 'lithium\\', 'suffix' => '.php', 'loader' => 'lithium\\core\\Libraries::load',
Fixing a test in `\core\Libraries` where symlinked Lithium directories are matched properly.
diff --git a/command/agent/local.go b/command/agent/local.go index <HASH>..<HASH> 100644 --- a/command/agent/local.go +++ b/command/agent/local.go @@ -439,7 +439,7 @@ func (l *localState) setSyncState() error { eCopy := existing.Clone() // Copy the server's check before modifying, otherwise - // in-memory RPC-based unit tests will have side effects. + // in-memory RPCs will have side effects. cCopy := check.Clone() // If there's a defer timer active then we've got a
Tweaks comment about side effects.
diff --git a/src/feat/web/webserver.py b/src/feat/web/webserver.py index <HASH>..<HASH> 100644 --- a/src/feat/web/webserver.py +++ b/src/feat/web/webserver.py @@ -1873,7 +1873,9 @@ class Response(log.Logger): return status = http.Status[self._request._ref.code].name - self._request.debug("Finishing the request. Status: %s", status) + elapsed = time.time() - self._request.received + self._request.debug("Finishing the request. Status: %s. " + "Elapsed: %.2f s", status, elapsed) self._finished = time.time() try:
Include information about time of processing of web request.
diff --git a/test/dummy/db/migrate/20110208155312_set_up_test_tables.rb b/test/dummy/db/migrate/20110208155312_set_up_test_tables.rb index <HASH>..<HASH> 100644 --- a/test/dummy/db/migrate/20110208155312_set_up_test_tables.rb +++ b/test/dummy/db/migrate/20110208155312_set_up_test_tables.rb @@ -12,7 +12,7 @@ class SetUpTestTables < ActiveRecord::Migration t.boolean :a_boolean t.string :sacrificial_column t.string :type - t.timestamps + t.timestamps :null => true end create_table :versions, :force => true do |t| @@ -63,7 +63,7 @@ class SetUpTestTables < ActiveRecord::Migration create_table :wotsits, :force => true do |t| t.integer :widget_id t.string :name - t.timestamps + t.timestamps :null => true end create_table :fluxors, :force => true do |t| @@ -138,7 +138,7 @@ class SetUpTestTables < ActiveRecord::Migration create_table :gadgets, :force => true do |t| t.string :name t.string :brand - t.timestamps + t.timestamps :null => true end create_table :customers, :force => true do |t|
Get rid of deprecation warning on dummy app migrations on Travis
diff --git a/checker/tests/result_test.py b/checker/tests/result_test.py index <HASH>..<HASH> 100644 --- a/checker/tests/result_test.py +++ b/checker/tests/result_test.py @@ -151,6 +151,7 @@ class FontToolsTest(TestCase): url = 'http://fonts.googleapis.com/css?family=%s' % metadata['name'].replace(' ', '+') fp = requests.get(url) self.assertTrue(fp.status_code == 200, 'No family found in GWF in %s' % url) + self.assertEqual(metadata.get('visibility'), 'External') @tags('required') def test_macintosh_platform_names_matches_windows_platform(self):
If font is in GWF then check for visibility == 'External'
diff --git a/Tests/System/ApplicationBundle/PhpListApplicationBundleTest.php b/Tests/System/ApplicationBundle/PhpListApplicationBundleTest.php index <HASH>..<HASH> 100644 --- a/Tests/System/ApplicationBundle/PhpListApplicationBundleTest.php +++ b/Tests/System/ApplicationBundle/PhpListApplicationBundleTest.php @@ -51,7 +51,7 @@ class PhpListApplicationBundleTest extends TestCase { $this->startSymfonyServer($environment); - $response = $this->httpClient->request('GET', '/', ['base_uri' => $this->getBaseUrl()]); + $response = $this->httpClient->get('/', ['base_uri' => $this->getBaseUrl()]); self::assertSame(200, $response->getStatusCode()); } @@ -65,7 +65,7 @@ class PhpListApplicationBundleTest extends TestCase { $this->startSymfonyServer($environment); - $response = $this->httpClient->request('GET', '/', ['base_uri' => $this->getBaseUrl()]); + $response = $this->httpClient->get('/', ['base_uri' => $this->getBaseUrl()]); self::assertContains('This page has been intentionally left empty.', $response->getBody()->getContents()); }
[CLEANUP] Use Guzzle's convenience methods in the system tests (#<I>) This makes the code more concise.
diff --git a/lib/Thelia/Core/Template/Loop/Feature.php b/lib/Thelia/Core/Template/Loop/Feature.php index <HASH>..<HASH> 100644 --- a/lib/Thelia/Core/Template/Loop/Feature.php +++ b/lib/Thelia/Core/Template/Loop/Feature.php @@ -123,11 +123,13 @@ class Feature extends BaseI18nLoop implements PropelSearchLoopInterface /** @var ProductModel $product */ foreach ($products as $product) { - $search - ->useFeatureProductQuery() - ->filterByProduct($product) - ->endUse() - ; + if (!$this->getBackendContext()) { + $search + ->useFeatureProductQuery() + ->filterByProduct($product) + ->endUse() + ; + } $tplId = $product->getTemplateId(); if (! is_null($tplId)) {
Patch for #<I> for backend context
diff --git a/bloop/engine.py b/bloop/engine.py index <HASH>..<HASH> 100644 --- a/bloop/engine.py +++ b/bloop/engine.py @@ -237,7 +237,7 @@ class Engine: projection=projection, limit=limit, consistent=consistent) return iter(s.prepare()) - def stream(self, model, position, strict: bool=False) -> Stream: + def stream(self, model, position) -> Stream: s = Stream(engine=self, model=model, session=self.session) - s.move_to(position=position, strict=strict) + s.move_to(position=position) return s
remove strict arg from Stream.move_to #<I>
diff --git a/test/index.js b/test/index.js index <HASH>..<HASH> 100644 --- a/test/index.js +++ b/test/index.js @@ -172,4 +172,25 @@ describe('gulp-bump: JSON comparison fixtures', function() { bumpS.write(fakeFile); bumpS.end(); }); + + it('should bump one key by default', function(done) { + var fakeFile = new File({ + contents: new Buffer('{ "version": "0.1.0", "versionTwo": "1.0.0", "otherVersion": "2.0.0" }'), + path: 'test/fixtures/test.json' + }); + + var bumpS = bump({type: 'minor'}); + + bumpS.once('data', function(newFile) { + should.exist(newFile); + should.exist(newFile.contents); + var res = JSON.parse(newFile.contents.toString()) + res.version.should.equal('0.2.0'); + res.versionTwo.should.equal('1.0.0'); + res.otherVersion.should.equal('2.0.0'); + return done(); + }); + bumpS.write(fakeFile); + bumpS.end(); + }); });
Add test for bumping only one key
diff --git a/src/main/java/com/chaschev/chutils/Main.java b/src/main/java/com/chaschev/chutils/Main.java index <HASH>..<HASH> 100755 --- a/src/main/java/com/chaschev/chutils/Main.java +++ b/src/main/java/com/chaschev/chutils/Main.java @@ -7,11 +7,17 @@ import com.google.common.base.Strings; */ public class Main { public static void main(String[] args) { + if(args.length != 2){ + System.out.println("USAGE: chutils <your name> <a word>"); + } + System.out.printf("hi from chutils, %s! have a good %s!%n", args[0], args[1]); - System.out.println("is guava with us?"); + System.out.printf("are we alone, %s?%n%n", args[0]); + + System.out.print("no, we celebrate! guava is"); - System.out.print("guava is"); + System.out.flush(); - System.out.println(Strings.commonSuffix(" no, not here!", " here!") ); + System.out.println(Strings.commonSuffix(" not with us!", " with us!") ); } }
Updated dialog for the Installation example.
diff --git a/activesupport/lib/active_support/hash_with_indifferent_access.rb b/activesupport/lib/active_support/hash_with_indifferent_access.rb index <HASH>..<HASH> 100644 --- a/activesupport/lib/active_support/hash_with_indifferent_access.rb +++ b/activesupport/lib/active_support/hash_with_indifferent_access.rb @@ -363,11 +363,11 @@ module ActiveSupport end private - def convert_key(key) # :doc: + def convert_key(key) key.kind_of?(Symbol) ? key.to_s : key end - def convert_value(value, conversion: nil) # :doc: + def convert_value(value, conversion: nil) if value.is_a? Hash if conversion == :to_hash value.to_hash @@ -384,7 +384,7 @@ module ActiveSupport end end - def set_defaults(target) # :doc: + def set_defaults(target) if default_proc target.default_proc = default_proc.dup else
Hide internal utility methods in the public API doc [ci skip] I digged the history for the internal utility methods (`convert_key`, `convert_value`, and `set_defaults`), I believe it is apparently not intended to appear them in the public API doc. * `convert_key`, `convert_value`: <I> * `set_defaults`: #<I> <URL>, so that methods should not be leaked to the public API doc.
diff --git a/lib/nearley.js b/lib/nearley.js index <HASH>..<HASH> 100644 --- a/lib/nearley.js +++ b/lib/nearley.js @@ -69,8 +69,9 @@ State.prototype.process = function(location, ind, table, rules, addedRules) { this.data = this.rule.postprocess(this.data, this.reference, Parser.fail); } if (!(this.data === Parser.fail)) { + var findLeo; // LEO THE LION SAYS GER - function findLeo(idx, rulename, finalData) { + findLeo = function findLeo(idx, rulename, finalData) { // performance optimization, avoid high order functions(map/filter) in hotspot code. var items = []; var row = table[idx];
Fix for strict mode Line <I> causes the following error in strict mode: `In strict mode, function declarations cannot be nested inside a statement or block. They may only appear at the top level or directly inside a function body.` This is simply fixed by assigning the function to a variable.
diff --git a/salt/cli/caller.py b/salt/cli/caller.py index <HASH>..<HASH> 100644 --- a/salt/cli/caller.py +++ b/salt/cli/caller.py @@ -169,6 +169,8 @@ class ZeroMQCaller(object): ret['fun_args'] = self.opts['arg'] for returner in returners: + if not returner: # if we got an empty returner somehow, skip + continue try: ret['success'] = True self.minion.returners['{0}.returner'.format(returner)](ret)
Catch case where 'return' not in opts, or other ways to get an empty returner (as it will just fail anyways)
diff --git a/structr-ui/src/main/resources/structr/js/widgets.js b/structr-ui/src/main/resources/structr/js/widgets.js index <HASH>..<HASH> 100644 --- a/structr-ui/src/main/resources/structr/js/widgets.js +++ b/structr-ui/src/main/resources/structr/js/widgets.js @@ -281,6 +281,7 @@ var _Widgets = { repaintRemoteWidgets: function (search) { _Widgets.remoteWidgetFilter = search; + _Widgets.remoteWidgetsEl.empty(); if (search && search.length > 0) {
Bugfix: Fixes search in remote widgets
diff --git a/elasticsearch-extensions/lib/elasticsearch/extensions/version.rb b/elasticsearch-extensions/lib/elasticsearch/extensions/version.rb index <HASH>..<HASH> 100644 --- a/elasticsearch-extensions/lib/elasticsearch/extensions/version.rb +++ b/elasticsearch-extensions/lib/elasticsearch/extensions/version.rb @@ -1,5 +1,5 @@ module Elasticsearch module Extensions - VERSION = "0.0.4" + VERSION = "0.0.5" end end
[EXT] Release <I>