id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
227273570
|
Update AppSec-for-CISOs.md
@Don1Gibson nice first description
@ante-gulam check it out
|
gharchive/pull-request
| 2017-05-09T07:24:25 |
2025-04-01T06:41:12.607931
|
{
"authors": [
"DinisCruz",
"Don1Gibson"
],
"repo": "OWASP/owasp-summit-2017",
"url": "https://github.com/OWASP/owasp-summit-2017/pull/343",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
616082227
|
[Outlook] (AppSource) Include tips for OWA validation
Docs Build status updates of commit fa8f647:
:clock10: Pending: waiting for processors (9 builds ahead of you)
:warning: Docs Build is busy, currently there are 9 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.
Docs Build status updates of commit fa8f647:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/outlook/testing-and-tips.md
:white_check_mark:Succeeded
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
|
gharchive/pull-request
| 2020-05-11T18:15:48 |
2025-04-01T06:41:12.622092
|
{
"authors": [
"ElizabethSamuel-MSFT",
"o365devx"
],
"repo": "OfficeDev/office-js-docs-pr",
"url": "https://github.com/OfficeDev/office-js-docs-pr/pull/1832",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
792406066
|
Publish to live
Docs Build status updates of commit c553653:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View
docs/images/yo-office-outlook-1.png
:white_check_mark:Succeeded
View
docs/images/yo-office-outlook.png
:white_check_mark:Succeeded
docs/outlook/outlook-mobile-addins.md
:white_check_mark:Succeeded
View
docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded
View
docs/quickstarts/outlook-quickstart.md
:white_check_mark:Succeeded
View
docs/reference/manifest/extensionpoint.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel
Docs Build status updates of commit c553653:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View
docs/images/yo-office-outlook-1.png
:white_check_mark:Succeeded
View
docs/images/yo-office-outlook.png
:white_check_mark:Succeeded
docs/outlook/outlook-mobile-addins.md
:white_check_mark:Succeeded
View
docs/overview/office-add-in-availability.md
:white_check_mark:Succeeded
View
docs/quickstarts/outlook-quickstart.md
:white_check_mark:Succeeded
View
docs/reference/manifest/extensionpoint.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel
|
gharchive/pull-request
| 2021-01-23T01:48:56 |
2025-04-01T06:41:12.643921
|
{
"authors": [
"Rick-Kirkham",
"opbld34"
],
"repo": "OfficeDev/office-js-docs-pr",
"url": "https://github.com/OfficeDev/office-js-docs-pr/pull/2445",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
479060268
|
Update setting-up-a-redis-cache-system.md
Docs Build status updates of commit 0587a29:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
Skype/SDN/articles/setting-up-a-redis-cache-system.md
:white_check_mark:Succeeded
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
|
gharchive/pull-request
| 2019-08-09T16:04:20 |
2025-04-01T06:41:12.714134
|
{
"authors": [
"Ariantor",
"Linda-Editor"
],
"repo": "OfficeDev/skype-docs",
"url": "https://github.com/OfficeDev/skype-docs/pull/568",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
240631301
|
Review and change icons
Don't forget that we don't support Microsoft Access on 2.0.
|
gharchive/issue
| 2017-07-05T12:14:10 |
2025-04-01T06:41:12.715496
|
{
"authors": [
"wind39"
],
"repo": "OmniDB/OmniDB",
"url": "https://github.com/OmniDB/OmniDB/issues/113",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
74470189
|
Improve point default color
@jbeezley as discussed, I will let you fix the bugs.
I fixed the tests. Here is some comparisons of stroke widths 1, 1.25, 1.5, and 2 with both renderers. I think 2 is too wide especially for this size of point. In the past, I have noticed bad antialiasing for 1 pixel wide circles in svg. I checked various browsers and the antialiasing doesn't look too bad anymore, but I think 1.25 might look a bit better.
http://output.jsbin.com/tikota/13
thansk @jbeezley. If I zoom way in, then you will see that 1.25 and 1.5 both look good. I think 1.5 looks slightly better though but folks may prefer 1.25.
Okay, lets go with 1.25 then.
Fixed and ready for merge.
:+1:
|
gharchive/pull-request
| 2015-05-08T19:35:08 |
2025-04-01T06:41:12.722176
|
{
"authors": [
"aashish24",
"jbeezley"
],
"repo": "OpenGeoscience/geojs",
"url": "https://github.com/OpenGeoscience/geojs/pull/392",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
240501583
|
[WIP] TER compute lua implementation
Codecov Report
Merging #332 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #332 +/- ##
======================================
Coverage 70.7% 70.7%
======================================
Files 68 68
Lines 5674 5674
======================================
Hits 4012 4012
Misses 1662 1662
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92d443...ffe430e. Read the comment docs.
|
gharchive/pull-request
| 2017-07-04T21:47:28 |
2025-04-01T06:41:12.725714
|
{
"authors": [
"codecov-io",
"jsenellart"
],
"repo": "OpenNMT/OpenNMT",
"url": "https://github.com/OpenNMT/OpenNMT/pull/332",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
639763665
|
First pull request to test the contribution workflow
(At the risk of being self-deprecating) Everyone can safely ignore this PR for at least a week as I test and retry various workflows intricacies. There will be lots of small commits. Thanks!
No problem! GitHub lets you mark your pull requests as draft on the right hand side of this page ("Still in progress? Convert to draft")
Well, I guess we've discovered the limits of Docusaurus's allowed menu levels (that is, two).
@allanaaa Are you referring to some limit with Subcategories in the Sidebar? https://docusaurus.io/docs/en/navigation#adding-subcategories
or something in the Site Navigation Bar? https://docusaurus.io/docs/en/navigation#additions-to-the-site-navigation-bar
or something else?
Screenshot would help (you can copy paste a png or jpg image file directly into a reply comment on GitHub)
Well, I was making a note to myself first and foremost - no need to watch what happens in this space. But yes, I mean you can't nest subcategories.
Is this still active/needed or has it been supplanted by the real documentation PR?
It's not needed!
|
gharchive/pull-request
| 2020-06-16T15:25:31 |
2025-04-01T06:41:12.729035
|
{
"authors": [
"allanaaa",
"tfmorris",
"thadguidry",
"wetneb"
],
"repo": "OpenRefine/OpenRefine",
"url": "https://github.com/OpenRefine/OpenRefine/pull/2740",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
58079389
|
Cleaned up urls.py. Fixed #1472.
One comment. Please fix it or merge directly
ok
|
gharchive/pull-request
| 2015-02-18T15:08:07 |
2025-04-01T06:41:12.730697
|
{
"authors": [
"normanjaeckel",
"ostcar"
],
"repo": "OpenSlides/OpenSlides",
"url": "https://github.com/OpenSlides/OpenSlides/pull/1487",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
104426660
|
Mavlink socket initialization
@LorenzMeier I moved the initialization of the socket down so that the mavlink instance would be known and streams can be configured. I also had to prevent the receiver from using the socket before it was actually initialized.
Looks good, testing was clean I presume?
@LorenzMeier Yes, works fine.
|
gharchive/pull-request
| 2015-09-02T08:28:29 |
2025-04-01T06:41:12.741400
|
{
"authors": [
"LorenzMeier",
"tumbili"
],
"repo": "PX4/Firmware",
"url": "https://github.com/PX4/Firmware/pull/2796",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
946806707
|
'yolo_case'
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
|
gharchive/pull-request
| 2021-07-17T11:37:24 |
2025-04-01T06:41:12.742735
|
{
"authors": [
"CLAassistant",
"Patrick-Nick"
],
"repo": "PaddlePaddle/awesome-DeepLearning",
"url": "https://github.com/PaddlePaddle/awesome-DeepLearning/pull/432",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
249804233
|
Fixed typo: mactch -> match.
@sanfilip I also see "dtXxx" field described as "datatime" fields - not sure if this shouldn't be "datetime" instead?
Yes, "dtXxx" fields described as "datatime" fields should be "datetime". I made a ticket for this and will fix in the next release. Thanks!
I'm going to apply these change manually to the base branch.
|
gharchive/pull-request
| 2017-08-12T10:32:32 |
2025-04-01T06:41:12.745698
|
{
"authors": [
"manuelkiessling",
"sanfilip"
],
"repo": "Paperspace/paperspace-node",
"url": "https://github.com/Paperspace/paperspace-node/pull/3",
"license": "isc",
"license_type": "permissive",
"license_source": "bigquery"
}
|
643510170
|
Add cursor: pointer; for the buttons
Wow. Do default browser styles for buttons not do that?!
Fixed! Thanks again.
|
gharchive/issue
| 2020-06-23T03:55:47 |
2025-04-01T06:41:12.747091
|
{
"authors": [
"anonymous675",
"rosswintle"
],
"repo": "Peekobot/peekobot",
"url": "https://github.com/Peekobot/peekobot/issues/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
187191411
|
oracle.load_cards should fail if you pass it nonsense not return an empty list
ab9e1ad.
|
gharchive/issue
| 2016-11-03T21:11:39 |
2025-04-01T06:41:12.747511
|
{
"authors": [
"bakert"
],
"repo": "PennyDreadfulMTG/Penny-Dreadful-Tools",
"url": "https://github.com/PennyDreadfulMTG/Penny-Dreadful-Tools/issues/492",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
415363093
|
Add LICENSE.txt
Not a bad 10 minutes of work, on a phone, walking through traffic.
|
gharchive/pull-request
| 2019-02-27T22:47:37 |
2025-04-01T06:41:12.748027
|
{
"authors": [
"PerilousApricot",
"jpivarski"
],
"repo": "PerilousApricot/spark-ttree",
"url": "https://github.com/PerilousApricot/spark-ttree/pull/3",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
572578645
|
Update to latest service-manager
Coverage remained the same at 87.568% when pulling 648d2b38b2bffa6a3d74a006ca7107e68c56dd95 on up-sm into 0e6b6a528c8b8ce4f86bb58d7242f4329444e93e on master.
|
gharchive/pull-request
| 2020-02-28T07:30:16 |
2025-04-01T06:41:12.749022
|
{
"authors": [
"coveralls",
"dotchev"
],
"repo": "Peripli/service-broker-proxy",
"url": "https://github.com/Peripli/service-broker-proxy/pull/125",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
132223433
|
Mobile first / Desktop first
Outdated
|
gharchive/issue
| 2016-02-08T18:34:55 |
2025-04-01T06:41:12.751439
|
{
"authors": [
"PixelT"
],
"repo": "PixelT/unlimitedGrid",
"url": "https://github.com/PixelT/unlimitedGrid/issues/2",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
486549420
|
Add airflow version label to newly created buckets
Could you say something more about that?
Tracking GCP resources
To tag and track GCP resources spawned from Airflow, we have been adding airflow specific label(s) to GCP API service calls whenever possible and applicable. For example, we add “airflow-version” label to the dataproc cluster created. We expect new GCP service operators will also add Airflow top-level label “airflow-version” in addition to any service specific labels.
This is not done if only the hook is used.
Reference: GoogleCloudStorageHook.create_bucket
@GoogleCloudBaseHook.catch_http_exception
@GoogleCloudBaseHook.fallback_to_default_project_id
def create_bucket(self,
bucket_name,
resource=None,
storage_class='MULTI_REGIONAL',
location='US',
project_id=None,
labels=None
):
self.log.info('Creating Bucket: %s; Location: %s; Storage Class: %s',
bucket_name, location, storage_class)
client = self.get_conn()
bucket = client.bucket(bucket_name=bucket_name)
bucket_resource = resource or {}
for item in bucket_resource:
if item != "name":
bucket._patch_property(name=item, value=resource[item]) # pylint: disable=protected-access
bucket.storage_class = storage_class
bucket.labels = labels or {} . # <======
bucket.create(project=project_id, location=location)
return bucket.id
If the user uses the operator, these labels are not added when providing their own.
Ok, got it now!
Closed via https://github.com/apache/airflow/pull/5987
|
gharchive/issue
| 2019-08-28T18:48:14 |
2025-04-01T06:41:12.753111
|
{
"authors": [
"mik-laj",
"nuclearpinguin"
],
"repo": "PolideaInternal/airflow",
"url": "https://github.com/PolideaInternal/airflow/issues/265",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
737348139
|
Pass CoroutineScope instead of CoroutineContext in StorageService.
/gcbrun
|
gharchive/pull-request
| 2020-11-05T23:49:40 |
2025-04-01T06:41:12.753636
|
{
"authors": [
"yuangu-google"
],
"repo": "PolymerLabs/arcs",
"url": "https://github.com/PolymerLabs/arcs/pull/6512",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
476059110
|
미디어 파일 collection view로 띄우기
성수님 구현 완료
|
gharchive/issue
| 2019-08-02T08:25:04 |
2025-04-01T06:41:12.769586
|
{
"authors": [
"KangKyung"
],
"repo": "ProjectInTheClass/HiMoveIt",
"url": "https://github.com/ProjectInTheClass/HiMoveIt/issues/26",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
295753490
|
Add Squad Egg
You somehow messed up there I think ;)
|
gharchive/pull-request
| 2018-02-09T04:45:04 |
2025-04-01T06:41:12.771242
|
{
"authors": [
"Exonical",
"schrej"
],
"repo": "Pterodactyl/Panel",
"url": "https://github.com/Pterodactyl/Panel/pull/924",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
263576761
|
Me marker info window is pure json
In de pan map
Osm map
Fixed in 3d40f9fcfe9fa8f85d342aa2a0d3a24325cdb541
|
gharchive/issue
| 2017-10-06T21:28:34 |
2025-04-01T06:41:12.781006
|
{
"authors": [
"Dingenis",
"njittam"
],
"repo": "RSDT/Japp16",
"url": "https://github.com/RSDT/Japp16/issues/98",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
119076927
|
test(mapTo): add subscription assertions on mapTo tests
Merged with bf3c13c, thanks @staltz
|
gharchive/pull-request
| 2015-11-26T16:42:22 |
2025-04-01T06:41:12.786307
|
{
"authors": [
"kwonoj",
"staltz"
],
"repo": "ReactiveX/RxJS",
"url": "https://github.com/ReactiveX/RxJS/pull/801",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
135749856
|
Feature request: Create Url from current page url (from $_SERVER)
Apologies for the late answer. However, I feel this is somewhat out of the scope of this library. The problem with this particular feature is that specifics of how to extract the current page URL (or request URI) from the $_SERVER superglobal is highly architecture dependent.
Creating a request URI from the most common case is not particularly hard and could be achieved using something like:
<?php
require 'vendor/autoload.php';
$parser = new \Riimu\Kit\UrlParser\UriParser();
$uri = $parser->parse(sprintf(
'%s://%s%s',
empty($_SERVER['HTTPS']) || $_SERVER['HTTPS'] === 'off' ? 'http' : 'https',
$_SERVER['HTTP_HOST'],
$_SERVER['REQUEST_URI']
));
echo $uri;
However, this only covers the most common scenario. I don't feel like implementing something that incomplete is worth it. On the other hand, I don't really have the expertise nor the platforms to test and develop a more complete solution that works across many different platforms.
|
gharchive/issue
| 2016-02-23T14:22:08 |
2025-04-01T06:41:12.802869
|
{
"authors": [
"Nayjest",
"Riimu"
],
"repo": "Riimu/Kit-UrlParser",
"url": "https://github.com/Riimu/Kit-UrlParser/issues/2",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
159828489
|
Fix check for JS class
Good one. Thanks.
|
gharchive/pull-request
| 2016-06-12T13:48:53 |
2025-04-01T06:41:12.809959
|
{
"authors": [
"RobinRadic",
"aleemb"
],
"repo": "RobinRadic/blade-extensions",
"url": "https://github.com/RobinRadic/blade-extensions/pull/54",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
159068520
|
Feature/24 info manager
Dans l'ensemble c'est beau.
As-tu lancer la stratégie de testBench (celle par défaut dans le code) pour valider que ça roule encore correctement?
Aussi il faudra à terme penser à uniformiser les docstrings, pas important pour le moment, je note pour plus tard.
|
gharchive/pull-request
| 2016-06-08T02:55:40 |
2025-04-01T06:41:12.810572
|
{
"authors": [
"agingrasc",
"david2194"
],
"repo": "RoboCupULaval/StrategyIA",
"url": "https://github.com/RoboCupULaval/StrategyIA/pull/30",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
382001417
|
Shaped Script updated to 13.8.0
Greethings,
Did you intend to delete all these files ?
Thanks,
Cassie
@clevett yes, it is just removing old versions. Compare https://github.com/Roll20/roll20-api-scripts/tree/master/5eShapedCompanion vs https://github.com/mlenser/roll20-api-scripts/tree/master/5eShapedScript to see that the version released to roll20 is now just the latest version
|
gharchive/pull-request
| 2018-11-18T21:19:50 |
2025-04-01T06:41:12.812090
|
{
"authors": [
"clevett",
"mlenser"
],
"repo": "Roll20/roll20-api-scripts",
"url": "https://github.com/Roll20/roll20-api-scripts/pull/729",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
249201444
|
Criação do HTML para post de vídeo
Ok
|
gharchive/issue
| 2017-08-10T00:43:16 |
2025-04-01T06:41:12.812558
|
{
"authors": [
"Ronneesley"
],
"repo": "Ronneesley/redesocial",
"url": "https://github.com/Ronneesley/redesocial/issues/89",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
237536524
|
Add joseph to Contributors list
@Joseph1989, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
Hey, thank you so much for starting this project. Found it super helpful and feel now confident to start contributing to open source.
@Joseph1989: I'm happy that you found this useful. We also have a slack team to help/mentor people trying to contribute to open source. You can join us by going to https://firstcontributions.herokuapp.com
|
gharchive/pull-request
| 2017-06-21T13:35:24 |
2025-04-01T06:41:12.813841
|
{
"authors": [
"Joseph1989",
"Roshanjossey"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/201",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
304087255
|
Add Yasser El-Sayed to Contributors list
@YasserZ, could you please add your name in Contributing.md rather than CONTRIBUTORS.md?
@YasserZ, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
|
gharchive/pull-request
| 2018-03-10T17:18:59 |
2025-04-01T06:41:12.815500
|
{
"authors": [
"Roshanjossey",
"YasserZ"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/3312",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
252668053
|
Add Ryan Slade to Contributors list
@rdslade, I'm quite elated about your PR. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a PR and learned that I merged it?
|
gharchive/pull-request
| 2017-08-24T17:06:29 |
2025-04-01T06:41:12.816247
|
{
"authors": [
"Roshanjossey",
"rdslade"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/425",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
323854581
|
Add Camilo Muñoz to Contributors list
Hi @jcamilom, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
|
gharchive/pull-request
| 2018-05-17T02:54:31 |
2025-04-01T06:41:12.817401
|
{
"authors": [
"Roshanjossey",
"jcamilom"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/4437",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
325919348
|
Add vasedgod to Contributors list
Hi @vasedgod, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
|
gharchive/pull-request
| 2018-05-24T00:13:28 |
2025-04-01T06:41:12.818817
|
{
"authors": [
"Roshanjossey",
"vasedgod"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/4564",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
345502487
|
Add Jason Law to Contributors list
Hi @lckj210, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
|
gharchive/pull-request
| 2018-07-29T05:11:56 |
2025-04-01T06:41:12.819907
|
{
"authors": [
"Roshanjossey",
"lckj210"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/5643",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
356094393
|
Add Sumit Singh to Contributors list
Hi @sumit9696, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.
Firstly, thanks for merging my pull request.
I think tutorial is much useful and gives a complete overview about GitHub use. I have just started using github and a tutorial like this was a nice and easy way to get familiar with GitHub.
Can i know that why deleting the branch is required?
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh
Deleting branch is just a clean up chore. It'll be automatically done by GitHub at a later stage too.
|
gharchive/pull-request
| 2018-08-31T19:11:13 |
2025-04-01T06:41:12.822306
|
{
"authors": [
"Roshanjossey",
"sumit9696"
],
"repo": "Roshanjossey/first-contributions",
"url": "https://github.com/Roshanjossey/first-contributions/pull/6363",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
511847451
|
Fix Calydon's focus state CSS
pausing this ticket until other a11y topics are done
|
gharchive/issue
| 2019-10-24T10:15:39 |
2025-04-01T06:41:12.826897
|
{
"authors": [
"kacperknapik"
],
"repo": "SAP/cloud-commerce-spartacus-storefront",
"url": "https://github.com/SAP/cloud-commerce-spartacus-storefront/issues/5148",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
149251505
|
Release 132
Merge release-132 into develop.
|
gharchive/pull-request
| 2016-04-18T19:41:07 |
2025-04-01T06:41:12.835735
|
{
"authors": [
"xschildw"
],
"repo": "Sage-Bionetworks/Synapse-Repository-Services",
"url": "https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/2392",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
302244585
|
Find alternative to showing black screen on video load
This is a problem with Unity's video player. I initially set it to not play the video automatically. And in that case Unity will sometimes render a frame and sometimes render a black screen.
One thing to try is to play the video for a very short time (equiv. to 1 or 2 frames) and then pause. Not sure if this will avoid the black screen issue while still allowing you start the video paused.
Using video.frame = 2 instead of video.time=0 seems to work.
|
gharchive/issue
| 2018-03-05T10:25:19 |
2025-04-01T06:41:12.845297
|
{
"authors": [
"Kristof-Heyndels",
"Saticmotion"
],
"repo": "Saticmotion/360Video",
"url": "https://github.com/Saticmotion/360Video/issues/20",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
900725388
|
Initial functionality
Pull requests:
https://github.com/Senzing/g2-python/pull/3
https://github.com/Senzing/g2-python/pull/4
https://github.com/Senzing/g2-python/pull/5
https://github.com/Senzing/g2-python/pull/6
https://github.com/Senzing/g2-python/pull/7
https://github.com/Senzing/g2-python/pull/8
https://github.com/Senzing/g2-python/pull/9
https://github.com/Senzing/g2-python/pull/10
https://github.com/Senzing/g2-python/pull/11
https://github.com/Senzing/g2-python/pull/12
https://github.com/Senzing/g2-python/pull/13
https://github.com/Senzing/g2-python/pull/14
https://github.com/Senzing/g2-python/pull/15
https://github.com/Senzing/g2-python/pull/16
https://github.com/Senzing/g2-python/pull/17
https://github.com/Senzing/g2-python/pull/18
https://github.com/Senzing/g2-python/pull/19
https://github.com/Senzing/g2-python/pull/20
https://github.com/Senzing/g2-python/pull/21
https://github.com/Senzing/g2-python/pull/22
https://github.com/Senzing/g2-python/pull/23
https://github.com/Senzing/g2-python/pull/24
https://github.com/Senzing/g2-python/pull/25
https://github.com/Senzing/g2-python/pull/26
https://github.com/Senzing/g2-python/pull/27
https://github.com/Senzing/g2-python/pull/28
https://github.com/Senzing/g2-python/pull/29
https://github.com/Senzing/g2-python/pull/30
https://github.com/Senzing/g2-python/pull/31
https://github.com/Senzing/g2-python/pull/32
https://github.com/Senzing/g2-python/pull/33
https://github.com/Senzing/g2-python/pull/34
https://github.com/Senzing/g2-python/pull/35
https://github.com/Senzing/g2-python/pull/36
https://github.com/Senzing/g2-python/pull/37
https://github.com/Senzing/g2-python/pull/38
https://github.com/Senzing/g2-python/pull/39
https://github.com/Senzing/g2-python/pull/40
https://github.com/Senzing/g2-python/pull/41
https://github.com/Senzing/g2-python/pull/42
https://github.com/Senzing/g2-python/pull/43
https://github.com/Senzing/g2-python/pull/44
https://github.com/Senzing/g2-python/pull/45
https://github.com/Senzing/g2-python/pull/46
https://github.com/Senzing/g2-python/pull/47
https://github.com/Senzing/g2-python/pull/48
https://github.com/Senzing/g2-python/pull/49
https://github.com/Senzing/g2-python/pull/50
https://github.com/Senzing/g2-python/pull/51
https://github.com/Senzing/g2-python/pull/52
https://github.com/Senzing/g2-python/pull/53
https://github.com/Senzing/g2-python/pull/54
https://github.com/Senzing/g2-python/pull/55
https://github.com/Senzing/g2-python/pull/56
https://github.com/Senzing/g2-python/pull/57
https://github.com/Senzing/g2-python/pull/58
https://github.com/Senzing/g2-python/pull/59
https://github.com/Senzing/g2-python/pull/60
https://github.com/Senzing/g2-python/pull/61
https://github.com/Senzing/g2-python/pull/62
https://github.com/Senzing/g2-python/pull/63
https://github.com/Senzing/g2-python/pull/64
https://github.com/Senzing/g2-python/pull/65
https://github.com/Senzing/g2-python/pull/66
https://github.com/Senzing/g2-python/pull/67
https://github.com/Senzing/g2-python/pull/68
https://github.com/Senzing/g2-python/pull/69
https://github.com/Senzing/g2-python/pull/70
https://github.com/Senzing/g2-python/pull/71
https://github.com/Senzing/g2-python/pull/72
https://github.com/Senzing/g2-python/pull/73
https://github.com/Senzing/g2-python/pull/74
https://github.com/Senzing/g2-python/pull/75
https://github.com/Senzing/g2-python/pull/76
https://github.com/Senzing/g2-python/pull/77
https://github.com/Senzing/g2-python/pull/78
https://github.com/Senzing/g2-python/pull/79
|
gharchive/issue
| 2021-05-25T12:14:07 |
2025-04-01T06:41:12.864339
|
{
"authors": [
"docktermj"
],
"repo": "Senzing/g2-python",
"url": "https://github.com/Senzing/g2-python/issues/2",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
744295361
|
Expose grouped devices as a single accessory to HomeKit
Added in v5.0.15
|
gharchive/issue
| 2020-11-17T00:00:34 |
2025-04-01T06:41:12.872376
|
{
"authors": [
"SeydX"
],
"repo": "SeydX/homebridge-fritz-platform",
"url": "https://github.com/SeydX/homebridge-fritz-platform/issues/128",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
750695975
|
Simplified setup / Docker Swarm managed by GEP
Hi @pun-ky ,
Thank you for your contribution, but I won't use it.
I'd like to keep the overhead of the additional libraries in the example as low as possible, just to remain it unopinionated and easy to understand for everyone who knows Docker.
@Skejven sure, I understand... that overhead may not be nice in some cases but people are not aware of differences between Docker Toolbox and Docker Desktop and that was the main motivation to add GEP here. Docker Desktop with WSL2 is looking more and more promising and Toolbox usages is in that case getting continuously less popular. So sure I am fine with that ;)
|
gharchive/pull-request
| 2020-11-25T10:32:32 |
2025-04-01T06:41:12.906008
|
{
"authors": [
"Skejven",
"pun-ky"
],
"repo": "Skejven/aet-docker",
"url": "https://github.com/Skejven/aet-docker/pull/29",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
741707932
|
feat: add Serial Killer
Also it looks like you've removed the setUp part of a kill entirely, so please add that too.
I didn't remove it, I used goon as a template and there isn't any setUp()
|
gharchive/pull-request
| 2020-11-12T15:44:23 |
2025-04-01T06:41:12.926083
|
{
"authors": [
"MeDerpWasTaken"
],
"repo": "Soumil07/godfather",
"url": "https://github.com/Soumil07/godfather/pull/33",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
163477156
|
rhiac's numbers still don't match up.
Just realized we had issues open on this repo, as the notifications were skipping my inbox.
|
gharchive/issue
| 2016-07-01T21:28:56 |
2025-04-01T06:41:12.937808
|
{
"authors": [
"ericnatsmith",
"mcfrank"
],
"repo": "StanfordPsych254/replication_project",
"url": "https://github.com/StanfordPsych254/replication_project/issues/5",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
357763363
|
学习Agile敏捷开发
@LongHe1996 尽快给 @GeGe2333 材料。下次Project Meeting的时候希望能够尽量采用。
|
gharchive/issue
| 2018-09-06T17:58:17 |
2025-04-01T06:41:12.938250
|
{
"authors": [
"PeiyuanQi",
"tangticco"
],
"repo": "StoneOsho/CoolTodo",
"url": "https://github.com/StoneOsho/CoolTodo/issues/5",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
713384364
|
Fixed the description of getMax in PropertyAdapter
@RobWin merge it, pls)
|
gharchive/pull-request
| 2020-10-02T06:29:16 |
2025-04-01T06:41:12.946786
|
{
"authors": [
"SergKhram"
],
"repo": "Swagger2Markup/swagger2markup",
"url": "https://github.com/Swagger2Markup/swagger2markup/pull/412",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
126005642
|
Is there a way to do injections into AppDelegate?
Would you add more context or background behind your question to help me understand it?
I would like to inject some properties into AppDelegate like in the following way.
class AppDelegate: UIResponder, UIApplicationDelegate {
private let appearanceConfigurator: AppearanceConfigurator!
private let persistenceConfigurator: PersistenceConfigurator!
private let container = Container() { c in
c.registerForAppDelegate(AppDelegate.self) { _, appDelegate in
appDelegate.appearanceConfigurator = AppearanceConfiguratorImpl()
appDelegate. persistenceConfigurator = PersistenceConfiguratorImpl()
}
}
override init() {
container.resolve(self)
}
}
Generally I would like to build number of Assemblies and event inject them automatically or in an easy way.
I like the structure and architecture the "RamblerConferences" project, please see the source code https://github.com/rambler-ios/RamblerConferences/tree/develop/conferences/Classes/ApplicationLayer/Assemblies.
But they use objc and Typhoon (which doesn't support native Swift).
The architecture of RamblerConferences is interesting!
Swinject does not have registerForAppDelegate function, but you can do the similar thing by adding your own assembler class like this:
class AppDelegateAssembler {
func resolveDependencies(appDelegate: AppDelegate) {
appDelegate.appearanceConfigurator = AppearanceConfiguratorImpl()
appDelegate.persistenceConfigurator = PersistenceConfiguratorImpl()
}
}
Then AppDelegate can be:
class AppDelegate: UIResponder, UIApplicationDelegate {
private let appearanceConfigurator: AppearanceConfigurator!
private let persistenceConfigurator: PersistenceConfigurator!
override init() { // or application(_:didFinishLaunchingWithOptions:)
super.init()
AppDelegateAssembler().resolveDependencies(self)
}
}
, though I'm not sure this is a good way to do... The difficult thing is that AppDelegate is the entry point of an iOS program in Swift.
Thank you for the suggestion.
I think that there should be some native library mechanism to do such things.
What do you think about updating your library with the [UIApplication setAppDelegate] swizzling, like Typhoon does, and create solution like you did for SwinjectStoryboard.
I agree that the framework should be as much as possible native for Swift, but AppDelegate is obj-c object. And we're allowed to do the same things with AppDelegate that we do for objc objects.
I even think that resolving the most of dependencies should be done automatically if it's possible.
Looking at RamblerConferences example doesn't have any direct injections in the code, everything is done by Typhoon with Assemblers.
I understand Typhoon has the advantage of the automatic DI (though I prefer explicit DI like I did in my sample projects because of my background of tools or languages).
I would like to avoid swizzling UIApplication class or its methods because of its impact if Apple changes its implementation when they update Xcode or iOS. I want Swinject to be stable for the updates.
(In the same way, SwinjectStoryboard is not stable for the future updates of the environment. We might not be able to keep the SwinjectStoryboard feature if Apple changes something in the future. So, swizzling of SwinjectStoryboard is compromise.)
I keep this issue open to gather more information about DI to AppDelegate. Someone might have a good idea to solve it.
Thank you for the feedback.
Hope that Swift / UIKit will allow us to solve this issue very soon.
I also would like to have some kind of auto-resolving injections both on AppDelegate and UIViewController descendants, I described my thoughts of the way we could use in #59
Hello guys, @larryonoff @yoichitgy
I was facing a similar problem and this is how I solved it
My Swinject extension looks like this
extension SwinjectStoryboard {
class func setup() {
// Dependencies injections
defaultContainer.register(CustomClass.self) { _ in CustomClass(...) }
}
class func getCustomClass() -> CustomClass {
return defaultContainer.resolve(CustomClass.self)!
}
}
And my AppDelegate like this
class AppDelegate: UIResponder, UIApplicationDelegate {
var window: UIWindow?
var customClass: CustomClass!
func application(application: UIApplication, didFinishLaunchingWithOptions launchOptions: [NSObject: AnyObject]?) -> Bool {
// Gets the dependency from SwinjectStoryboard extension
customClass = SwinjectStoryboard.getCustomClass()
}
...
Hope it helps you!
@robertofrontado thank you for sharing the great idea!
I'm going to close this issue for the idea by @robertofrontado. Also auto-injection, discussed in #59, can be alternative way for this issue.
Unless there's something wrong with @igordeoliveirasa's approach, I used it and it seems to work well. No extension to SwinjectStoryboard was required. Just this single line of code. 💯
I'd like to offer my solution that I've found to be a bit cleaner. I create an AppDelegateProxy class and inject there via method injection. The proxy's job is to create and dependency inject the AppDelegate class and that's it
The end result looks like:
@UIApplicationMain
final class AppDelegateProxy: UIResponder, UIApplicationDelegate {
private let container = Container()
private weak var applicationDelegate: UIApplicationDelegate?
// MARK: - Initialization
override init() {
super.init()
container.register(UIWindow.self, factory: { _ in UIWindow() })
container.register(ApplicationProtocol.self, factory: { _ in UIApplication.shared })
container.register(AppDelegate.self, factory: { resolver in AppDelegate(application: resolver.resolve(ApplicationProtocol.self)!, window: resolver.resolve(UIWindow.self)!) })
container.register(UIApplicationDelegate.self, factory: { resolver in resolver.resolve(AppDelegate.self)! })
container.register(AppDelegateProxy.self, factory: { [weak self] resolver in
guard let vSelf = self else { fatalError("self should exist") }
vSelf.injectProperties(resolver: resolver)
return vSelf
})
}
// MARK: - Property Injection
func injectProperties(resolver: Resolver) {
self.applicationDelegate = resolver.resolve(UIApplicationDelegate.self)
}
}
with an added initializer in AppDelegate:
final class AppDelegate: UIResponder, UIApplicationDelegate {
var window: UIWindow?
let application: ApplicationProtocol
init(application: ApplicationProtocol, UIWindow?) {
self.window = window
self.application = application
}
}
Now you can completely control how and when AppDelegate gets instantiated.
There is one caveat however. Because AppDelegateProxy is now @UIApplicationMain, if you want to use an appDelegate method you have to forward it from the proxy to the real delegate.
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
return applicationDelegate?.application?(application, didFinishLaunchingWithOptions: launchOptions) ?? true
}
You'll also have to forward the UIResponder methods like touchBegan.
|
gharchive/issue
| 2016-01-11T18:23:12 |
2025-04-01T06:41:12.955448
|
{
"authors": [
"Sega-Zero",
"SuperTango",
"larryonoff",
"robertofrontado",
"startupthekid",
"yoichitgy"
],
"repo": "Swinject/Swinject",
"url": "https://github.com/Swinject/Swinject/issues/49",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
301948288
|
Make Editor contextual info label better
Done in https://github.com/Sygmei/ObEngine/commit/ed9e18e5bc937c8c55baef93e17e319c1fc6ec87
|
gharchive/issue
| 2018-03-03T00:35:01 |
2025-04-01T06:41:12.957245
|
{
"authors": [
"Sygmei"
],
"repo": "Sygmei/ObEngine",
"url": "https://github.com/Sygmei/ObEngine/issues/142",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
233394289
|
Hamburger menu icoon asset maken en uploaden
Menu is geen hamburger icoon meer maar een label. Zie Zeplin voor details.
|
gharchive/issue
| 2017-06-03T20:46:05 |
2025-04-01T06:41:12.961444
|
{
"authors": [
"OrpheTana"
],
"repo": "TOVS/tovs_website_2017",
"url": "https://github.com/TOVS/tovs_website_2017/issues/22",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
241378106
|
Add Travis, Codecov
I like the idea of this CI stuff being easily bundled, but it kind of feels like unnecessary complication for most of these small packages. The only part that seems very useful is the linter, and even that is probably way over-complicated, since we can get rid of all the "incremental improvement" features on these new projects.
What do you think?
I considered simplifying them, but:
I like having the standard ./bin/lint, ./bin/test, etc. locations.
Sure, they could be simpler, but as far as I see, there's no real harm in having slightly more complex tools, either? Especially since:
We might need the complexity in the future. For e.g. the ./bin/coverage script you'll need it when a package grows subpackages. I don't necessarily expect that any time soon for httperr, but it's not inconceivable either.
Personally, I care the most about the first point. If you want to simplify things then be me guest.
I like having the standard ./bin/lint, ./bin/test, etc. locations.
I'm not disagreeing with standard locations, or standard scripts. I just think the scripts are overkill for most of these projects. When they're useful (in large, monolithic projects such as Desk, possibly Projects/CRM/HelpDocs/etc, as those grow/move to go), I think your design is great.
I just question whether there's enough overlap between those cases and a simple lib like this, to actually use the same tool.
there's no real harm in having slightly more complex tools
But it's not "slightly more complex." The difference between go test -race -cover -covermode=set ./... -coverprofile=coverage.txt && bash <(curl -s https://codecov.io/bash) and the "standard" test/coverage scripts is 158 lines of complexity. 158x more complex isn't "slightly" more complex. It's immensely more complex.
We might need the complexity in the future
Then lets add it in the future, if/when we need it. I seriously doubt we will, but if we do, it's just as easy to add it then as it is now.
Yeah sure, that's a valid reasoning. I simplified the test and coverage scripts. For the lint script you still sort of need most of it, though.
For the lint script you still sort of need most of it, though.
Not really. 99% of the linter complexity is for dealing with old code bases, where we don't want to clean it all up at once. For a pristine code base, all we need is:
go get -u gopkg.in/alecthomas/gometalinter.v1 ...
gometalinter.v1 --deadline=60s --vendor --disable-all --enable=....
|
gharchive/pull-request
| 2017-07-07T20:56:36 |
2025-04-01T06:41:12.997533
|
{
"authors": [
"Carpetsmoker",
"flimzy"
],
"repo": "Teamwork/httperr",
"url": "https://github.com/Teamwork/httperr/pull/4",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
262684866
|
Add LinearSearch Java File
Thanks. Just a small contribution bro. :)
|
gharchive/pull-request
| 2017-10-04T06:55:26 |
2025-04-01T06:41:13.011627
|
{
"authors": [
"sarthak-sopho"
],
"repo": "Thuva4/Algorithms_Example",
"url": "https://github.com/Thuva4/Algorithms_Example/pull/10",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
775014060
|
Replace sout with Logging (SLF4J?)
Didn't catch all the e.printstacktrace calls >.>
A few things of note:
I've set some reasonable defaults for the logging levels, including disabling Jetty logging.
Default log level for the project is debug (see next points)
Since this seems to be built around registering callbacks, what I've done is replaced direct error logging with calls to the respective runOnError, runOnConnectionFailed, etc. methods.
Inside those runOn... methods, I set it to DEBUG log the intended message so that the client knows something happened. I also include a debug message stating that no callback was registered, if relevant, so that they can know to register their own callbacks if they need to react to those kinds of events.
|
gharchive/issue
| 2020-12-27T10:35:15 |
2025-04-01T06:41:13.039063
|
{
"authors": [
"TinaTiel"
],
"repo": "TinaTiel/websocket-obs-java",
"url": "https://github.com/TinaTiel/websocket-obs-java/issues/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
568985646
|
Objects
Codecov Report
Merging #9 into master will increase coverage by 0.18%.
The diff coverage is 93.55%.
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
+ Coverage 96.07% 96.26% +0.18%
==========================================
Files 40 43 +3
Lines 4050 4389 +339
==========================================
+ Hits 3891 4225 +334
- Misses 159 164 +5
Impacted Files
Coverage Δ
src/serde.rs
88.88% <ø> (ø)
:arrow_up:
src/rules/empty.rs
100% <ø> (ø)
:arrow_up:
src/character.rs
94.69% <ø> (ø)
:arrow_up:
src/space.rs
95.78% <ø> (ø)
:arrow_up:
tests/entropy.rs
100% <ø> (ø)
:arrow_up:
src/event.rs
96.1% <ø> (ø)
:arrow_up:
src/metric.rs
94.39% <ø> (ø)
:arrow_up:
src/entropy.rs
94.33% <ø> (ø)
:arrow_up:
tests/creature.rs
97.12% <ø> (+1.43%)
:arrow_up:
tests/fight.rs
100% <ø> (+1.96%)
:arrow_up:
... and 21 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8691e19...5b68cd8. Read the comment docs.
|
gharchive/pull-request
| 2020-02-21T14:23:33 |
2025-04-01T06:41:13.060525
|
{
"authors": [
"Trisfald",
"codecov-io"
],
"repo": "Trisfald/weasel",
"url": "https://github.com/Trisfald/weasel/pull/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
853196531
|
A better example for recipe
https://www.icedjems.com/2012/09/banana-trifle/
I wonder if https://wholefully.com/next-day-turkey-vegetable-soup/ could actually serve as an example of a recipe + narrative hybrid..?
Well, yes that surely is some kind of a hybrid. Perhaps Narrative blog + Recipe?
|
gharchive/issue
| 2021-04-08T08:09:06 |
2025-04-01T06:41:13.071194
|
{
"authors": [
"shellstroem",
"spyysalo"
],
"repo": "TurkuNLP/register-annotation-docs",
"url": "https://github.com/TurkuNLP/register-annotation-docs/issues/16",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
67599408
|
Algorithm selection description
Carl, please take a look
Merging now. Got another PR on the way.
|
gharchive/pull-request
| 2015-04-10T13:47:31 |
2025-04-01T06:41:13.078889
|
{
"authors": [
"isuftin"
],
"repo": "USGS-CIDA/gdp_web",
"url": "https://github.com/USGS-CIDA/gdp_web/pull/26",
"license": "cc0-1.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
162763729
|
estimated date range edges are now exclusive
Coverage decreased (-0.08%) to 86.747% when pulling 0674e70d6fa61b6d93d1deb3c22156075d45e18b on thongsav-usgs:master into 67fcaf7360dd0532a95408df05a1978134032055 on USGS-R:master.
Coverage decreased (-0.08%) to 86.747% when pulling 0674e70d6fa61b6d93d1deb3c22156075d45e18b on thongsav-usgs:master into 67fcaf7360dd0532a95408df05a1978134032055 on USGS-R:master.
Coverage decreased (-0.08%) to 86.747% when pulling 0674e70d6fa61b6d93d1deb3c22156075d45e18b on thongsav-usgs:master into 67fcaf7360dd0532a95408df05a1978134032055 on USGS-R:master.
|
gharchive/pull-request
| 2016-06-28T19:15:04 |
2025-04-01T06:41:13.082622
|
{
"authors": [
"coveralls",
"thongsav-usgs"
],
"repo": "USGS-R/repgen",
"url": "https://github.com/USGS-R/repgen/pull/360",
"license": "cc0-1.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
144722613
|
Support for non-json outputs
LGTM
|
gharchive/pull-request
| 2016-03-30T21:17:59 |
2025-04-01T06:41:13.103318
|
{
"authors": [
"lewisric",
"malibuworkcrew"
],
"repo": "Webtrends/wookiee-spray",
"url": "https://github.com/Webtrends/wookiee-spray/pull/20",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
91145957
|
Fix chrome compatibility
Now works in Chrome.
|
gharchive/issue
| 2015-06-26T04:00:52 |
2025-04-01T06:41:13.106028
|
{
"authors": [
"Widdershin"
],
"repo": "Widdershin/helix-pi-editor",
"url": "https://github.com/Widdershin/helix-pi-editor/issues/9",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
668825317
|
fixing typo, fixes #171
duplicate!
|
gharchive/pull-request
| 2020-07-30T14:54:21 |
2025-04-01T06:41:13.114185
|
{
"authors": [
"Sheeri"
],
"repo": "WildAid/o-fish-ios",
"url": "https://github.com/WildAid/o-fish-ios/pull/176",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
668658382
|
Add i18n support to Feedback
@dtdesign Okay, then this PR is ready. I also added a small smoke test for the i18n support.
If you are happy with this and press the green button then I'll update the version in WoltLab/WCF#3449 and adjust the PasswordStrength class over there to make use of localized feedback.
|
gharchive/pull-request
| 2020-07-30T12:08:59 |
2025-04-01T06:41:13.117457
|
{
"authors": [
"TimWolla"
],
"repo": "WoltLab/zxcvbn",
"url": "https://github.com/WoltLab/zxcvbn/pull/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
92434883
|
Administrator wants to use a shared openstack partition other than "shared"
I'm not sure I implemented this correctly - it only takes effect if the user in question is admin and they have configured 'alternate_shared_partition' in the device config.
|
gharchive/issue
| 2015-07-01T16:57:59 |
2025-04-01T06:41:13.149151
|
{
"authors": [
"dougwig",
"mdurrant-b3"
],
"repo": "a10networks/a10-neutron-lbaas",
"url": "https://github.com/a10networks/a10-neutron-lbaas/issues/72",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
898923445
|
patch
patch
|
gharchive/pull-request
| 2021-05-23T02:58:05 |
2025-04-01T06:41:13.161595
|
{
"authors": [
"haydendhampton"
],
"repo": "academicpages/academicpages.github.io",
"url": "https://github.com/academicpages/academicpages.github.io/pull/612",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
85834228
|
Semantic issues
Thanks for the fix/improvements. In the future, you might want to make changes via Markdown Here's Crowdin project: https://crowdin.com/project/markdown-here/es-ES
(I'll upload these changes to there right now.)
|
gharchive/pull-request
| 2015-06-07T01:39:07 |
2025-04-01T06:41:13.182432
|
{
"authors": [
"adam-p",
"kant"
],
"repo": "adam-p/markdown-here",
"url": "https://github.com/adam-p/markdown-here/pull/284",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
494958828
|
Added logic to list repositories.
Approved
|
gharchive/pull-request
| 2019-09-18T03:00:06 |
2025-04-01T06:41:13.183037
|
{
"authors": [
"adambaumeister",
"jsameerv"
],
"repo": "adambaumeister/skilletcli",
"url": "https://github.com/adambaumeister/skilletcli/pull/10",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
655179555
|
CMSargstring() needs implementing
Function has been replaced with new functions CMSargc, CMSargv, CMScalltype, CMSplist and CMSeplist in F0038 / v0.7.17
|
gharchive/issue
| 2020-07-11T10:10:03 |
2025-04-01T06:41:13.183894
|
{
"authors": [
"adesutherland"
],
"repo": "adesutherland/CMS-370-GCCLIB",
"url": "https://github.com/adesutherland/CMS-370-GCCLIB/issues/44",
"license": "Unlicense",
"license_type": "permissive",
"license_source": "github-api"
}
|
328823600
|
Release/2.0
Coverage decreased (-0.3%) to 93.056% when pulling 48faa38f979bd6631caec60aefacaba375d48b8c on release/2.0 into 52679700cbaea28e9f53f9ddce9ea910cfac8a8a on master.
Coverage decreased (-0.3%) to 93.056% when pulling 755e6efa5632bf1a8833e2ff34c7db767bb6bf96 on release/2.0 into 52679700cbaea28e9f53f9ddce9ea910cfac8a8a on master.
|
gharchive/pull-request
| 2018-06-03T12:13:52 |
2025-04-01T06:41:13.187396
|
{
"authors": [
"aditya7iyengar",
"coveralls"
],
"repo": "aditya7iyengar/rummage_ecto",
"url": "https://github.com/aditya7iyengar/rummage_ecto/pull/73",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
105584242
|
Minor spelling correction
@jiimaho You need to sign brackets-sla
Done.
Skickat från min iPhone
9 sep 2015 kl. 16:22 skrev Prashanth Nethi notifications@github.com:
@jiimaho You need to sign brackets-sla
—
Reply to this email directly or view it on GitHub.
Thanks for the contribution @jiimaho.
|
gharchive/pull-request
| 2015-09-09T12:16:00 |
2025-04-01T06:41:13.190451
|
{
"authors": [
"ingorichter",
"jiimaho",
"nethip"
],
"repo": "adobe/brackets",
"url": "https://github.com/adobe/brackets/pull/11678",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
891027317
|
add support for EF signing
Sample macOS installer:
@gdams conflicts
|
gharchive/pull-request
| 2021-05-13T13:09:04 |
2025-04-01T06:41:13.192128
|
{
"authors": [
"gdams",
"karianna"
],
"repo": "adoptium/installer",
"url": "https://github.com/adoptium/installer/pull/313",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
91726345
|
add homework
以下のコマンドは実行していますか？
rtmlaunch hrpsys_gazebo_tutorials samplerobot_hrpsys_bringup.launch
このコマンドが実行されていれば，rvizでロボットモデルが表示されるはずです．
もう一度，REAM.mdを読みなおして，
点群と画像もrvizで可視化できるかどうか確認して，2枚目のスクリーンショットを撮り直しましょう．
rtmlaunch hrpsys_gazebo_tutorials samplerobot_hrpsys_bringup.launch
は実行していますが roslaunch hrpsys_gazebo_tutorials test_object_detect.launch で以下のエラーが出てオブジェクトが出てきませんでした
jsk_data のパッケージがない感じでしょうか？
hydroなら
sudo apt-get install ros-hydro-jsk-data
indigoなら
sudo apt-get insltall ros-indigo-jsk-data
をして，jsk_dataを入れてください．
他にも足りないパッケージがあるようなら，
rosdep install jsk_pcl_ros
を試してみるといいかもしれません．
あとは同じようなエラーが出たら，apt-get install でエラーメッセージで足りないと出たパッケージをインストールしてください．
@yoshimalucky これでいいんでしょうか？
|
gharchive/pull-request
| 2015-06-29T07:41:38 |
2025-04-01T06:41:13.209520
|
{
"authors": [
"ganmacs",
"yoshimalucky"
],
"repo": "agent-system/homework",
"url": "https://github.com/agent-system/homework/pull/43",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
229257311
|
[sql lab] make database ordering alphabetical in left panel
LGTM
|
gharchive/pull-request
| 2017-05-17T07:11:23 |
2025-04-01T06:41:13.215490
|
{
"authors": [
"ascott",
"mistercrunch"
],
"repo": "airbnb/superset",
"url": "https://github.com/airbnb/superset/pull/2769",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
284884300
|
Add travis config file
@lesyk Can you add that pep8 stuff you suggested earlier
|
gharchive/pull-request
| 2017-12-28T10:16:10 |
2025-04-01T06:41:13.226401
|
{
"authors": [
"alfredfrancis",
"lesyk"
],
"repo": "alfredfrancis/ai-chatbot-framework",
"url": "https://github.com/alfredfrancis/ai-chatbot-framework/pull/50",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
371646700
|
Support WebFlux ReactiveHealthIndicator.
Pull Request Test Coverage Report for Build 563
0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%
Totals
Change from base Build 558:
0.0%
Covered Lines:
Relevant Lines:
0
💛 - Coveralls
|
gharchive/pull-request
| 2018-10-18T18:05:58 |
2025-04-01T06:41:13.242678
|
{
"authors": [
"QilongZhang",
"coveralls"
],
"repo": "alipay/sofa-boot",
"url": "https://github.com/alipay/sofa-boot/pull/246",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
409968986
|
[DC-288]Show the aggregate heel errors for PPI and PM data
Rebased and merged to develop
|
gharchive/pull-request
| 2019-02-13T19:41:27 |
2025-04-01T06:41:13.265416
|
{
"authors": [
"ksdkalluri",
"mark-velez"
],
"repo": "all-of-us/curation",
"url": "https://github.com/all-of-us/curation/pull/129",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
456134140
|
Switch to scala 2.13.0
Waiting for https://github.com/lihaoyi/Ammonite/pull/973, so that completions work fine in 2.13.
|
gharchive/pull-request
| 2019-06-14T08:51:59 |
2025-04-01T06:41:13.272207
|
{
"authors": [
"alexarchambault"
],
"repo": "almond-sh/almond",
"url": "https://github.com/almond-sh/almond/pull/375",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
236876929
|
Logging
Coverage decreased (-0.5%) to 87.476% when pulling e184ddd920200ab8c096bea50f4630725514c218 on logging into 74a58d3b19f499ab8d3a0f080a6e17d5004d35b7 on master.
|
gharchive/pull-request
| 2017-06-19T12:37:40 |
2025-04-01T06:41:13.276562
|
{
"authors": [
"coveralls",
"davidread"
],
"repo": "alphagov/land-availability-api",
"url": "https://github.com/alphagov/land-availability-api/pull/71",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
187856359
|
Feature/106 user add multi source
Addresses feature from #106
|
gharchive/pull-request
| 2016-11-07T23:09:40 |
2025-04-01T06:41:13.284481
|
{
"authors": [
"amardeshbd"
],
"repo": "amardeshbd/android-daily-headlines",
"url": "https://github.com/amardeshbd/android-daily-headlines/pull/110",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
186144262
|
Fixed typo
Thanks :)
|
gharchive/pull-request
| 2016-10-30T15:54:04 |
2025-04-01T06:41:13.292654
|
{
"authors": [
"amireh",
"yanni4night"
],
"repo": "amireh/happypack",
"url": "https://github.com/amireh/happypack/pull/101",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
131268952
|
[TACHYON-1697] Mark tachyon.underfs.LocalFileSystemCluster a final class
Can one of the admins verify this patch?
okay to test
Jenkins, test this please
ok to test
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Tachyon-Pull-Request-Builder/8497/
Test PASSed.
LGTM. Thanks for the improvement!
|
gharchive/pull-request
| 2016-02-04T07:35:58 |
2025-04-01T06:41:13.295702
|
{
"authors": [
"AmplabJenkins",
"beeflamian",
"gpang",
"yupeng9"
],
"repo": "amplab/tachyon",
"url": "https://github.com/amplab/tachyon/pull/2668",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
178805226
|
patch sub tests so they are testing mark/unmark correctly
Changes Unknown when pulling e109b465b90743d3a031e66c0b74e06156426cb2 on bugfix/fix-mark-unmark-tests into ** on master**.
|
gharchive/pull-request
| 2016-09-23T07:33:11 |
2025-04-01T06:41:13.324005
|
{
"authors": [
"andrewmichaud",
"coveralls"
],
"repo": "andrewmichaud/puckfetcher",
"url": "https://github.com/andrewmichaud/puckfetcher/pull/25",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
443113940
|
Dialog background element #15840
I don't think this is something we want to add an API for. Users can access the backdrop using document.querySelector('.cdk-overlay-backdrop') if needed.
|
gharchive/pull-request
| 2019-05-12T15:03:23 |
2025-04-01T06:41:13.331579
|
{
"authors": [
"jonathanRinciari",
"mmalerba"
],
"repo": "angular/components",
"url": "https://github.com/angular/components/pull/16007",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
737481940
|
chore: fix wrong package in README
Ooops. Thanks
|
gharchive/pull-request
| 2020-11-06T05:48:39 |
2025-04-01T06:41:13.337665
|
{
"authors": [
"TheLastZombie",
"antfu"
],
"repo": "antfu/ni",
"url": "https://github.com/antfu/ni/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
636917022
|
can not find cambo click event
graph.on('combo:click', e => {
console.log('click')
});
|
gharchive/issue
| 2020-06-11T10:51:57 |
2025-04-01T06:41:13.339271
|
{
"authors": [
"Yanyan-Wang",
"garysun90"
],
"repo": "antvis/G6",
"url": "https://github.com/antvis/G6/issues/1666",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
201041666
|
ARTEMIS-560 Add Support For JDBC Paging
@mtaylor conflict ^^
|
gharchive/pull-request
| 2017-01-16T15:02:35 |
2025-04-01T06:41:13.342825
|
{
"authors": [
"clebertsuconic",
"mtaylor"
],
"repo": "apache/activemq-artemis",
"url": "https://github.com/apache/activemq-artemis/pull/962",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
958157784
|
feat: handle idempotent key in PrepareConf
Codecov Report
Merging #27 (53a032d) into master (6ca0f5e) will decrease coverage by 3.22%.
The diff coverage is 86.36%.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 82.01% 78.78% -3.23%
==========================================
Files 9 9
Lines 567 594 +27
==========================================
+ Hits 465 468 +3
- Misses 79 100 +21
- Partials 23 26 +3
Impacted Files
Coverage Δ
internal/plugin/conf.go
89.04% <86.36%> (-2.80%)
:arrow_down:
internal/server/server.go
59.37% <0.00%> (-15.03%)
:arrow_down:
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca0f5e...53a032d. Read the comment docs.
|
gharchive/pull-request
| 2021-08-02T13:40:04 |
2025-04-01T06:41:13.351610
|
{
"authors": [
"codecov-commenter",
"spacewander"
],
"repo": "apache/apisix-go-plugin-runner",
"url": "https://github.com/apache/apisix-go-plugin-runner/pull/27",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
508565439
|
ARROW-6919: [Python] Expose more builders in Cython
Do you need this change in 0.15.1?
No. Only my previous Cython PR needs to be in 0.15.1 but that is marked as such in JIRA.
|
gharchive/pull-request
| 2019-10-17T15:44:55 |
2025-04-01T06:41:13.352931
|
{
"authors": [
"wesm",
"xhochy"
],
"repo": "apache/arrow",
"url": "https://github.com/apache/arrow/pull/5684",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
622109596
|
ARROW-8703: [R] schema$metadata should be properly typed
@jorisvandenbossche could you give this a quick glance? https://github.com/apache/arrow/pull/7236/files#diff-4f1c8c5db1e5e55eab54a6f88138bfe1R322-R333 is the most concise view of the interface this adds.
That looks good to me.
In Python, we don't allow editing the metadata in-place (there are methods to add or update it, but those return a new table / new schema), so in that sense we follow more how it is done on the C++ side, but I don't think it is a problem to update the pointer in place.
One question: if you do like tab$metadata <- list(test = TRUE), I understand in the code how this change is propagated to the actual table, but if you do tab$metadata$foo <- 42 (which updates the named list), how is that propagated to the metadata on the C++ level?
@jorisvandenbossche that part is a little magical. tab$metadata$foo <- 42 essentially gets the list from tab$metadata anonymously, does that$foo <- 42, and then assigns tab$metadata <- that. So there's only one path to updating at the C++ level, replacing the whole metadata object.
|
gharchive/pull-request
| 2020-05-20T21:57:32 |
2025-04-01T06:41:13.356251
|
{
"authors": [
"jorisvandenbossche",
"nealrichardson"
],
"repo": "apache/arrow",
"url": "https://github.com/apache/arrow/pull/7236",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
782751358
|
ARROW-11196: [GLib] Add support for mock, HDFS and S3 file systems with factory function
+1
+1
|
gharchive/pull-request
| 2021-01-10T06:02:15 |
2025-04-01T06:41:13.357211
|
{
"authors": [
"kou"
],
"repo": "apache/arrow",
"url": "https://github.com/apache/arrow/pull/9152",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
238510853
|
[CXF-7429] Prevent NPE on file log and null writer
I've closed this PR as the issue is already fixed. See also #286.
|
gharchive/pull-request
| 2017-06-26T11:12:21 |
2025-04-01T06:41:13.358748
|
{
"authors": [
"blasd",
"deki"
],
"repo": "apache/cxf",
"url": "https://github.com/apache/cxf/pull/287",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
418827580
|
interoperable - framework changes
Hey Marta,
using an Optional was a design decision, to not use objects directly. An
Optional allows for an easier understand behavior, than forcing everybody
to do null checks. It is a cleaner design approach.
Happy to hear other opinions, but these are my two cents.
Cheers
Markus
On Fri, Mar 8, 2019 at 4:13 PM marta-jankovics notifications@github.com
wrote:
You can view, comment on, or merge this pull request online at:
https://github.com/apache/fineract-cn-accounting/pull/10
Commit Summary
interoperable - framework changes
File Changes
M
service/src/main/java/org/apache/fineract/cn/accounting/service/internal/service/AccountService.java
https://github.com/apache/fineract-cn-accounting/pull/10/files#diff-0
(10)
M
service/src/main/java/org/apache/fineract/cn/accounting/service/rest/AccountRestController.java
https://github.com/apache/fineract-cn-accounting/pull/10/files#diff-1
(32)
M
service/src/main/java/org/apache/fineract/cn/accounting/service/rest/JournalRestController.java
https://github.com/apache/fineract-cn-accounting/pull/10/files#diff-2
(12)
Patch Links:
https://github.com/apache/fineract-cn-accounting/pull/10.patch
https://github.com/apache/fineract-cn-accounting/pull/10.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/fineract-cn-accounting/pull/10, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABv8crrqg2WSsYjFNKjv4Hjp-FLC4tfXks5vUn3_gaJpZM4bliiX
.
Markus is absolutely correct. Using Optional turns runtime errors into compiletime errors thus making it much harder to forget to handle the case that a value is not defined.
I'll close this PR without merging.
|
gharchive/pull-request
| 2019-03-08T15:13:03 |
2025-04-01T06:41:13.366851
|
{
"authors": [
"marta-jankovics",
"mgeiss",
"myrle-krantz"
],
"repo": "apache/fineract-cn-accounting",
"url": "https://github.com/apache/fineract-cn-accounting/pull/10",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
134334976
|
[FLINK-3436] Remove ComplexIntegrationITCase
Makes sense. The only tests that seem to remain anyways (are not ignored) are a simple map/writeFile test and an iteration test that is similarly elsewhere as well.
So, +1 from my side
+1
|
gharchive/pull-request
| 2016-02-17T16:47:49 |
2025-04-01T06:41:13.368113
|
{
"authors": [
"StephanEwen",
"aljoscha",
"uce"
],
"repo": "apache/flink",
"url": "https://github.com/apache/flink/pull/1659",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
315427507
|
[FLINK-9193] Deprecate non-well-defined output methods on DataStream
Created an updated version here: https://github.com/apache/flink/pull/5871
|
gharchive/pull-request
| 2018-04-18T10:45:25 |
2025-04-01T06:41:13.369161
|
{
"authors": [
"aljoscha"
],
"repo": "apache/flink",
"url": "https://github.com/apache/flink/pull/5868",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
155781966
|
Add Kiwi.com as a user to README
LGTM
Welcome @underyx !
|
gharchive/pull-request
| 2016-05-19T16:38:00 |
2025-04-01T06:41:13.370213
|
{
"authors": [
"artwr",
"r39132",
"underyx"
],
"repo": "apache/incubator-airflow",
"url": "https://github.com/apache/incubator-airflow/pull/1520",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
247233612
|
Change variable name from _defered_init to _deferred_init
same typo exists in tests/python/unittest/test_nn.py
Thanks Sheng! Do you know why "continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request"?
i got it
|
gharchive/pull-request
| 2017-08-01T23:42:56 |
2025-04-01T06:41:13.371696
|
{
"authors": [
"astonzhang",
"szha"
],
"repo": "apache/incubator-mxnet",
"url": "https://github.com/apache/incubator-mxnet/pull/7300",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
229525697
|
MINOR: Log transaction metadata state transitions plus a few cleanups
LGTM. Please rebase :)
|
gharchive/pull-request
| 2017-05-18T00:48:08 |
2025-04-01T06:41:13.373639
|
{
"authors": [
"guozhangwang",
"hachikuji"
],
"repo": "apache/kafka",
"url": "https://github.com/apache/kafka/pull/3081",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
121083920
|
KAFKA-2957: Fix typos in Kafka documentation
LGTM! Thank you for contributing.
Will merge to both 0.9.0 and trunk.
|
gharchive/pull-request
| 2015-12-08T19:45:55 |
2025-04-01T06:41:13.374600
|
{
"authors": [
"gwenshap",
"vahidhashemian"
],
"repo": "apache/kafka",
"url": "https://github.com/apache/kafka/pull/641",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
134767194
|
PARQUET-514: Automate code coverage uploads to coveralls.io, add README badge
See the coverage report generated by the Travis build: https://coveralls.io/builds/5130094
This is cool! Thanks! +1 LGTM
+1
|
gharchive/pull-request
| 2016-02-19T04:10:53 |
2025-04-01T06:41:13.376321
|
{
"authors": [
"julienledem",
"majetideepak",
"wesm"
],
"repo": "apache/parquet-cpp",
"url": "https://github.com/apache/parquet-cpp/pull/57",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
729535698
|
PHOENIX-6206 Update phoenix-thirdparty dependency version to 1.0.0
:broken_heart: -1 overall
Vote
Subsystem
Runtime
Comment
+0 :ok:
reexec
6m 51s
Docker mode activated.
_ Prechecks _
+1 :green_heart:
dupname
0m 0s
No case conflicting files found.
+1 :green_heart:
@author
0m 0s
The patch does not contain any @author tags.
-1 :x:
test4tests
0m 0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 :green_heart:
mvninstall
14m 12s
master passed
+1 :green_heart:
compile
1m 25s
master passed
+1 :green_heart:
javadoc
1m 6s
master passed
_ Patch Compile Tests _
+1 :green_heart:
mvninstall
9m 18s
the patch passed
+1 :green_heart:
compile
1m 26s
the patch passed
+1 :green_heart:
javac
1m 26s
the patch passed
+1 :green_heart:
whitespace
0m 1s
The patch has no whitespace issues.
+1 :green_heart:
xml
0m 1s
The patch has no ill-formed XML file.
+1 :green_heart:
javadoc
1m 7s
the patch passed
_ Other Tests _
-1 :x:
unit
178m 59s
root in the patch failed.
+1 :green_heart:
asflicense
0m 25s
The patch does not generate ASF License warnings.
217m 4s
Reason
Tests
Failed junit tests
phoenix.end2end.OrphanViewToolIT
phoenix.end2end.ParameterizedIndexUpgradeToolIT
Subsystem
Report/Notes
Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-940/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR
https://github.com/apache/phoenix/pull/940
Optional Tests
dupname asflicense javac javadoc unit xml compile
uname
Linux 6e7fadd2109e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool
maven
Personality
dev/phoenix-personality.sh
git revision
master / 46779eb
Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08
unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-940/1/artifact/yetus-general-check/output/patch-unit-root.txt
Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-940/1/testReport/
Max. process+thread count
6213 (vs. ulimit of 30000)
modules
C: . U: .
Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-940/1/console
versions
git=2.7.4 maven=3.3.9
Powered by
Apache Yetus 0.12.0 https://yetus.apache.org
This message was automatically generated.
|
gharchive/pull-request
| 2020-10-26T12:51:32 |
2025-04-01T06:41:13.397096
|
{
"authors": [
"stoty"
],
"repo": "apache/phoenix",
"url": "https://github.com/apache/phoenix/pull/940",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
72461202
|
[SPARK-7294][SQL] ADD BETWEEN
Can one of the admins verify this patch?
Jenkins, ok to test.
please test this pr.
Did you address my comments?
@rxin Please test this RR.
@rxin Please test this PR.
Jenkins, ok to test.
Merged build triggered.
Merged build started.
Test build #31765 has started for PR 5839 at commit 7e64d1e.
Test build #31765 has finished for PR 5839 at commit 7e64d1e.
This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31765/
Test FAILed.
Merged build triggered.
Merged build started.
Test build #31819 has started for PR 5839 at commit c54d904.
Test build #31819 has finished for PR 5839 at commit c54d904.
This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31819/
Test FAILed.
Merged build triggered.
Merged build started.
Test build #31822 has started for PR 5839 at commit d2e7f72.
Test build #31822 has finished for PR 5839 at commit d2e7f72.
This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31822/
Test FAILed.
Oro failure. Please retest it.
Jenkins, retest this please.
Merged build triggered.
Merged build started.
Test build #31834 has started for PR 5839 at commit d2e7f72.
Test build #31834 has finished for PR 5839 at commit d2e7f72.
This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31834/
Test FAILed.
Merged build triggered.
Merged build started.
Test build #31846 has started for PR 5839 at commit f928816.
Merged build triggered.
Merged build started.
Test build #31846 has finished for PR 5839 at commit f928816.
This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31846/
Test FAILed.
Please retest this =_=. @rxin
Merged build finished. Test FAILed.
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31856/
Test FAILed.
Jenkins, retest this please.
Merged build triggered.
Merged build started.
Test build #31891 has started for PR 5839 at commit b15360d.
Test build #31891 has finished for PR 5839 at commit b15360d.
This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
Merged build finished. Test PASSed.
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/31891/
Test PASSed.
Thanks. I've merged this.
|
gharchive/pull-request
| 2015-05-01T15:54:50 |
2025-04-01T06:41:13.424753
|
{
"authors": [
"AmplabJenkins",
"SparkQA",
"kaka1992",
"rxin"
],
"repo": "apache/spark",
"url": "https://github.com/apache/spark/pull/5839",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
110140171
|
TAJO-1915: Add a TajoClient example for creating and getting tables.
+1. I left a trivial comment. Please reflect it before you commit.
I removed sqlBuilder variable. I just committed the patch. Thank you for the quick review!
|
gharchive/pull-request
| 2015-10-07T02:19:55 |
2025-04-01T06:41:13.425983
|
{
"authors": [
"hyunsik",
"jihoonson"
],
"repo": "apache/tajo",
"url": "https://github.com/apache/tajo/pull/811",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
141811744
|
TAJO-2102: Migrate to Apache Orc from Presto's one
This patch is not ready for review yet. I need to fix a test failure and check the dependency on Hive.
+1 LGTM!
Thanks for your efforts!
@jinossy thanks for quick review.
|
gharchive/pull-request
| 2016-03-18T09:12:55 |
2025-04-01T06:41:13.427303
|
{
"authors": [
"jihoonson",
"jinossy"
],
"repo": "apache/tajo",
"url": "https://github.com/apache/tajo/pull/985",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
112918517
|
TS-3977: Merge cache-key-genid plugin
This replaces #308.
@ftarnell Can you please rebase this?
Hopefully we can get some documentation for this? Describe the problem its trying to solve; how to use it; how to configure; what configuration parameters exist and what they mean, etc.
If anyone else wonders what this does:
This plugin allows you to use a Kyoto database to increase genid per hostname, hence expiring the cache for a full domain using the zero cost mechanism to set the genid in the cache key.
The additional overhead for the plugin is:
Parse hostname from given url
Check kyoto DB for genid for the given host [DB lookup]
Set genid for the cache key dynamically
This plugin takes just one argument:
The path to the genid kyoto DB
I presume GoDaddy uses this in combination with a purge plugin like remap_purge to write values to the Kyoto DB to expire whole domains.
|
gharchive/pull-request
| 2015-10-23T00:31:48 |
2025-04-01T06:41:13.430725
|
{
"authors": [
"LionsAd",
"bryancall",
"ftarnell",
"mlibbey",
"unixwitch"
],
"repo": "apache/trafficserver",
"url": "https://github.com/apache/trafficserver/pull/309",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.