id
stringlengths 4
10
| text
stringlengths 4
2.14M
| source
stringclasses 2
values | created
timestamp[s]date 2001-05-16 21:05:09
2025-01-01 03:38:30
| added
stringdate 2025-04-01 04:05:38
2025-04-01 07:14:06
| metadata
dict |
|---|---|---|---|---|---|
142574023
|
#101 - Added route path and view for 404 message.
Fixes #101
|
gharchive/pull-request
| 2016-03-22T07:53:50 |
2025-04-01T06:41:14.162211
|
{
"authors": [
"captbaritone",
"denisinla"
],
"repo": "divad12/vim-awesome",
"url": "https://github.com/divad12/vim-awesome/pull/103",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
468630055
|
Configure hot module reloading for devs
Current status:
Separated Client Server:
[x] Hot Module reloading
[x] Typescript
Single Package:
[ ] Hot Module Reloading (50%)
[ ] Typescript
Future work
[ ] Finish the typescript module for single package. (*)
[ ] Discuss whether to use one package or the separated client/server
(*) Getting the typescript working on the front end shouldn't be too much work (less than a day) but will require some effort and research to ensure that we are doing it properly. The only reason it wasn't before was because of errors that made no sense cause by lack of understanding of typescript.
Thanks for the update... I'm mindful we need to choose the right approach. This sounds like the approach we'll take for a PoC ... but we may want to revisit if this PoC is adopted.
/cc @hdrury1
|
gharchive/issue
| 2019-07-16T12:38:31 |
2025-04-01T06:41:14.165327
|
{
"authors": [
"diversemix",
"will-byrne"
],
"repo": "diversemix/malcolm",
"url": "https://github.com/diversemix/malcolm/issues/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
487737922
|
cookbook-test-libraryをignore
Fixed at #28
|
gharchive/issue
| 2019-08-31T06:41:59 |
2025-04-01T06:41:14.169325
|
{
"authors": [
"Sobaya007",
"kubo39"
],
"repo": "dlang-jp/Cookbook",
"url": "https://github.com/dlang-jp/Cookbook/issues/24",
"license": "Unlicense",
"license_type": "permissive",
"license_source": "github-api"
}
|
823963572
|
Unexpectedly found quarter-final in results_processor
Heritage Classic scoresheet doesn't identify prelim rounds correctly
|
gharchive/issue
| 2021-03-07T16:59:02 |
2025-04-01T06:41:14.171196
|
{
"authors": [
"dlanghorne0428"
],
"repo": "dlanghorne0428/dancesport-tracker-project",
"url": "https://github.com/dlanghorne0428/dancesport-tracker-project/issues/112",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
108657442
|
Updated version to 0.7.1
Thanks! :+1:
|
gharchive/pull-request
| 2015-09-28T13:24:34 |
2025-04-01T06:41:14.179975
|
{
"authors": [
"tianon",
"vegasbrianc"
],
"repo": "docker-library/ghost",
"url": "https://github.com/docker-library/ghost/pull/21",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
100337684
|
fix: ==> default: Forcing shutdown of VM...
It seems there is a problem within debian 8 that ssh-server prevents shutdown.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751636
http://serverfault.com/questions/706475/ssh-sessions-hang-on-shutdown-reboot
i suggests to use the v1-ubuntu branch, which uses ubuntu 14.04
|
gharchive/issue
| 2015-08-11T15:23:49 |
2025-04-01T06:41:14.187304
|
{
"authors": [
"dominikzogg"
],
"repo": "dominikzogg/vagrant-php",
"url": "https://github.com/dominikzogg/vagrant-php/issues/15",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
936289401
|
Ignore patterns specified in excludes in docfx.json
@IEvangelist I'm going to close for now in favor of your suggested simpler approach: https://github.com/dotnet/docs-actions/pull/25.
|
gharchive/pull-request
| 2021-07-03T16:45:57 |
2025-04-01T06:41:14.243904
|
{
"authors": [
"Youssef1313"
],
"repo": "dotnet/docs-actions",
"url": "https://github.com/dotnet/docs-actions/pull/21",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
732709918
|
Internal users can easily migrate from TLC to ML.NET
Related:
https://github.com/dotnet/machinelearning-modelbuilder/issues/1175
Related:
https://github.com/dotnet/machinelearning-modelbuilder/issues/1175
|
gharchive/issue
| 2020-10-29T22:37:32 |
2025-04-01T06:41:14.245684
|
{
"authors": [
"JakeRadMSFT",
"briacht"
],
"repo": "dotnet/machinelearning-modelbuilder",
"url": "https://github.com/dotnet/machinelearning-modelbuilder/issues/1072",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
252922783
|
Add an basic chunk generator
Solved in #27 .
|
gharchive/issue
| 2017-08-25T14:42:30 |
2025-04-01T06:41:14.248369
|
{
"authors": [
"sunnycase"
],
"repo": "dotnetGame/MineCase",
"url": "https://github.com/dotnetGame/MineCase/issues/23",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
484302050
|
[Bug] Header file don't check fully, only class will check
This issue was fixed with (https://github.com/dougpuob/cpp-namelint/commit/09a2779baba670a6560fec320740fc3de27beacb) commit.
Add new test sample file Sample07.cpp and Sample07.h. You can run the test with cppnamelint.py bldgtest.
|
gharchive/issue
| 2019-08-23T02:44:29 |
2025-04-01T06:41:14.249786
|
{
"authors": [
"JeffHsu79",
"dougpuob"
],
"repo": "dougpuob/cpp-namelint",
"url": "https://github.com/dougpuob/cpp-namelint/issues/19",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
129516087
|
[DO NOT MERGE] just for testing
Can one of the admins verify this PR? Comment with 'ok to test' to start the build.
ok to test
Can one of the admins verify this PR? Comment with 'ok to test' to start the build.
|
gharchive/pull-request
| 2016-01-28T17:18:09 |
2025-04-01T06:41:14.257900
|
{
"authors": [
"kie-ci",
"psiroky",
"sometestuser1234"
],
"repo": "droolsjbpm/droolsjbpm-build-bootstrap",
"url": "https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/137",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
226178998
|
Add supervisors to overlord console.
@gianm could you add a screenshot of this in action in the PR please?
It looks like this:
If you don't have any supervisors then the top section doesn't show up.
|
gharchive/pull-request
| 2017-05-04T05:09:09 |
2025-04-01T06:41:14.259807
|
{
"authors": [
"drcrallen",
"gianm"
],
"repo": "druid-io/druid",
"url": "https://github.com/druid-io/druid/pull/4248",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
524463450
|
Added parliament support
I had the same errors locally when I tried to push this. I don't know if something broke upstream. The error is:
File "/home/travis/virtualenv/python3.7.1/lib/python3.7/site-packages/pipenv/vendor/toml/decoder.py", line 187, in loads
" Reached end of line.", original, i)
toml.decoder.TomlDecodeError: Key name found without value. Reached end of line. (line 18 column 11 char 326)
Only related issue I can find is from 2018 (https://github.com/pypa/pipenv/issues/3092) so I'm guessing it is not an upstream problem if no one else on the internet is hitting it.
|
gharchive/pull-request
| 2019-11-18T16:06:27 |
2025-04-01T06:41:14.267357
|
{
"authors": [
"0xdabbad00"
],
"repo": "duo-labs/cloudmapper",
"url": "https://github.com/duo-labs/cloudmapper/pull/601",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
674874833
|
Can't parse column with name: type, note
@liamnv thank you for report the issue, seen this already fixed at latest update
|
gharchive/issue
| 2020-08-07T09:04:22 |
2025-04-01T06:41:14.268868
|
{
"authors": [
"duythinht",
"liamnv"
],
"repo": "duythinht/dbml-go",
"url": "https://github.com/duythinht/dbml-go/issues/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
169585153
|
Whitelist files for npm and reduce lodash dependency
Nice.
|
gharchive/pull-request
| 2016-08-05T11:13:40 |
2025-04-01T06:41:14.302183
|
{
"authors": [
"ef4",
"kamalaknn"
],
"repo": "ef4/broccoli-uglify-sourcemap",
"url": "https://github.com/ef4/broccoli-uglify-sourcemap/pull/32",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
294143772
|
Add Dynamo execution support
Added
|
gharchive/issue
| 2018-02-03T20:47:38 |
2025-04-01T06:41:14.380178
|
{
"authors": [
"eirannejad"
],
"repo": "eirannejad/Revit-Journal-Maker",
"url": "https://github.com/eirannejad/Revit-Journal-Maker/issues/3",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
369926762
|
Add usernames filter
Out of curiosity, what would be a good use case for this?
@ekmartin for our use case we have multiple teams using the same repos use this and the repos filter to only remind specific team members about their teams prs to specific repos
@markddavidoff: In that case, would it be more useful if you could provide teams and have it filter by that? Team, as in https://github.com/orgs/ORGANIZATION/teams/
TEAMS=team1, team2 -> retrieve team members for team1 and for team2 -> filter PRs by members in those teams
Unfortunately we don't use GitHub teams, so for us that doesn't work. That would be neat to add but i like having usernames separate as well.
@ekmartin Unfortunately we don't use GitHub teams, so for us that doesn't work. That would be neat to add but i like having usernames separate as well.
Note:update doc
@ekmartin added teams support in another PR but i think this is still useful such as for members not in a team that still might make prs that need to show up (architect, infosec, etc)
@ekmartin any chance these features get in?
@markddavidoff: Thanks! Sorry about the late response.
|
gharchive/pull-request
| 2018-10-14T17:57:11 |
2025-04-01T06:41:14.386414
|
{
"authors": [
"ekmartin",
"markddavidoff"
],
"repo": "ekmartin/slack-pull-reminder",
"url": "https://github.com/ekmartin/slack-pull-reminder/pull/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
613038109
|
update some typos
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
|
gharchive/pull-request
| 2020-05-06T04:15:08 |
2025-04-01T06:41:14.412433
|
{
"authors": [
"CLAassistant",
"hutuxian"
],
"repo": "elasticdeeplearning/edl",
"url": "https://github.com/elasticdeeplearning/edl/pull/79",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
793651710
|
Fixed double-quote typo to make the command work when copied/pasted to terminal
Thanks, your PR has been accepted and merged into master branch. Thanks, it's a surprise to use.
Thanks, your PR has been accepted and merged into master branch. Thanks, it's a surprise to use.
|
gharchive/pull-request
| 2021-01-25T19:12:26 |
2025-04-01T06:41:14.416534
|
{
"authors": [
"stiartsly",
"wakqasahmed"
],
"repo": "elastos/Elastos.NET.Hive.Node",
"url": "https://github.com/elastos/Elastos.NET.Hive.Node/pull/62",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
165701821
|
Clarifying focusing essence of windowByIndex()
Yep, this is better.
I'm closing this PR due to lack of response over the past year.
@3n-mb, please feel free to open a new PR that addresses the changes that @codebytere suggested. I'd be happy for a fixed PR to be merged.
|
gharchive/pull-request
| 2016-07-15T03:01:02 |
2025-04-01T06:41:14.417626
|
{
"authors": [
"3n-mb",
"ckerr"
],
"repo": "electron/spectron",
"url": "https://github.com/electron/spectron/pull/88",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
316402033
|
Feature/responsive
Closing this. This code provided by @gustavoteodoro was used in the final release version. Thankss!!!
|
gharchive/pull-request
| 2018-04-20T20:29:23 |
2025-04-01T06:41:14.418329
|
{
"authors": [
"gustavoteodoro",
"luiguild"
],
"repo": "elemencast/elemencast.github.io",
"url": "https://github.com/elemencast/elemencast.github.io/pull/5",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
749348050
|
Create my-slide
Add elsnafyh's file
|
gharchive/pull-request
| 2020-11-24T05:12:25 |
2025-04-01T06:41:14.424354
|
{
"authors": [
"elsnafyh"
],
"repo": "elsnafyh/github-slideshow",
"url": "https://github.com/elsnafyh/github-slideshow/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
425105880
|
Add some testcases
outdated
|
gharchive/pull-request
| 2019-03-25T20:41:51 |
2025-04-01T06:41:14.426997
|
{
"authors": [
"terry-xiaoyu"
],
"repo": "emqx/emqx-rule-engine",
"url": "https://github.com/emqx/emqx-rule-engine/pull/4",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
25084719
|
Python 3 compatibility
Hi
I am interested in adding Python3 compatibility. My boss said I could spend a day working on it, so before I do this, I just want to check that a) you would be interested in accepting a PR and that b) there are no hidden dragons preventing the upgrade.
I am assuming that all I need to do is change to the new exception syntax etc and use some from futures import... as needed?
Hey Lee -- this sounds great! Definitely interested in a PR.
I don't have experience doing 2->3 ports, so can't speak to the work involved, but there shouldn't be any barriers. Explorer relies on 3 packages (Django, Factory Boy, and SQLparse), all of which are Python3 compatible.
Let me know if I can do anything to help. Feel free to ping me (chris@epantry.com) if you have any questions.
|
gharchive/issue
| 2014-01-06T03:51:18 |
2025-04-01T06:41:14.447822
|
{
"authors": [
"chrisclark",
"leebrooks0"
],
"repo": "epantry/django-sql-explorer",
"url": "https://github.com/epantry/django-sql-explorer/issues/36",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
136450901
|
return all munki prefs
Thank you kindly.
|
gharchive/pull-request
| 2016-02-25T17:14:27 |
2025-04-01T06:41:14.451333
|
{
"authors": [
"clburlison",
"erikng"
],
"repo": "erikng/munkireport-php",
"url": "https://github.com/erikng/munkireport-php/pull/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
788525342
|
fix: fix providerName type to allow user to extend default providers
:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
|
gharchive/pull-request
| 2021-01-18T20:20:17 |
2025-04-01T06:41:14.484549
|
{
"authors": [
"ala-n"
],
"repo": "exadel-inc/esl",
"url": "https://github.com/exadel-inc/esl/pull/11",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
859394308
|
Remove guard-for-in
Adding label to compensate for work done on main.
|
gharchive/pull-request
| 2021-04-16T02:11:52 |
2025-04-01T06:41:14.485386
|
{
"authors": [
"SleeplessByte"
],
"repo": "exercism/eslint-config-javascript",
"url": "https://github.com/exercism/eslint-config-javascript/pull/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
151214092
|
Expose autoCorrect and autoCapitalize Props
Oh wow! Since #4 was not active I wasn't expecting this to happen. Thanks for your work on this, I'm loving it so far.
Keep up the good work.
|
gharchive/pull-request
| 2016-04-26T19:03:43 |
2025-04-01T06:41:14.490605
|
{
"authors": [
"deniaz"
],
"repo": "eyaleizenberg/react-native-floating-label-text-input",
"url": "https://github.com/eyaleizenberg/react-native-floating-label-text-input/pull/5",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
486835207
|
[BUG] Analyzed transitive count also includes unknown transitives
https://jira.coreos.com/browse/APPAI-830
|
gharchive/issue
| 2019-08-29T09:11:37 |
2025-04-01T06:41:14.497023
|
{
"authors": [
"arajkumar",
"yzainee"
],
"repo": "fabric8-analytics/fabric8-analytics-vscode-extension",
"url": "https://github.com/fabric8-analytics/fabric8-analytics-vscode-extension/issues/339",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
424844379
|
swarm -> thorntail minor refactor
Can one of the admins verify this patch?
ok to test
retest this please
|
gharchive/pull-request
| 2019-03-25T11:10:33 |
2025-04-01T06:41:14.498063
|
{
"authors": [
"centos-ci",
"pmacko1",
"tradej"
],
"repo": "fabric8-launcher/launcher-documentation",
"url": "https://github.com/fabric8-launcher/launcher-documentation/pull/1252",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
161693265
|
Editxml
[merge]
|
gharchive/pull-request
| 2016-06-22T14:10:13 |
2025-04-01T06:41:14.498694
|
{
"authors": [
"davsclaus"
],
"repo": "fabric8io/fabric8-forge",
"url": "https://github.com/fabric8io/fabric8-forge/pull/316",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
88628318
|
Add array_min/array_max functions.
I think we can make greatest and least work for arrays.
To my understanding, greatest and array_max are semantically different function.
reatest treat array as a whole. It will return the maximum array
array_max will return the maximum element in the array.
This is what greatest return with array input.
presto:tiny> select greatest(ARRAY[1,2]);
_col0
--------
[1, 2]
(1 row)
This is array_max return
presto:tiny> select array_max(ARRAY[1,2]);
_col0
--------
2
(1 row)
I can get the correct result using presto-cli from the PrestoServer with this patch.
But the newly added test cases for array_max with the same query failed because of ExpressionCompiler failed to compile the expression. I am not familiar with the ByteCode/compiler part of Presto, could you guys give me some idea about it when you have time.
Here is the Exception of test assertFunction("ARRAY_MAX(ARRAY [1, 2, 3])", BIGINT, 3);
java.lang.RuntimeException: Error compiling "array_max"(ARRAY[1,2,3]): -1
at com.facebook.presto.operator.scalar.FunctionAssertions.compileFilterProject(FunctionAssertions.java:544)
at com.facebook.presto.operator.scalar.FunctionAssertions.executeProjectionWithAll(FunctionAssertions.java:260)
at com.facebook.presto.operator.scalar.FunctionAssertions.selectUniqueValue(FunctionAssertions.java:231)
at com.facebook.presto.operator.scalar.FunctionAssertions.selectSingleValue(FunctionAssertions.java:226)
at com.facebook.presto.operator.scalar.FunctionAssertions.assertFunction(FunctionAssertions.java:200)
at com.facebook.presto.operator.scalar.AbstractTestFunctions.assertFunction(AbstractTestFunctions.java:38)
at com.facebook.presto.type.TestArrayOperators.testMax(TestArrayOperators.java:301)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:84)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:714)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:901)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1231)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:127)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:111)
at org.testng.TestRunner.privateRun(TestRunner.java:767)
at org.testng.TestRunner.run(TestRunner.java:617)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:334)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:329)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:291)
at org.testng.SuiteRunner.run(SuiteRunner.java:240)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1224)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1149)
at org.testng.TestNG.run(TestNG.java:1057)
at org.testng.remote.RemoteTestNG.run(RemoteTestNG.java:111)
at org.testng.remote.RemoteTestNG.initAndRun(RemoteTestNG.java:204)
at org.testng.remote.RemoteTestNG.main(RemoteTestNG.java:175)
at org.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:125)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
at org.objectweb.asm.Frame.a(Unknown Source)
at org.objectweb.asm.MethodWriter.visitMaxs(Unknown Source)
at com.facebook.presto.byteCode.MethodDefinition.visit(MethodDefinition.java:253)
at com.facebook.presto.byteCode.MethodDefinition.visit(MethodDefinition.java:207)
at com.facebook.presto.byteCode.ClassDefinition.visit(ClassDefinition.java:158)
at com.facebook.presto.sql.gen.CompilerUtils.defineClasses(CompilerUtils.java:100)
at com.facebook.presto.sql.gen.CompilerUtils.defineClass(CompilerUtils.java:74)
at com.facebook.presto.sql.gen.CompilerUtils.defineClass(CompilerUtils.java:80)
at com.facebook.presto.sql.gen.ExpressionCompiler.compileProcessor(ExpressionCompiler.java:130)
at com.facebook.presto.sql.gen.ExpressionCompiler.compileAndInstantiate(ExpressionCompiler.java:93)
at com.facebook.presto.sql.gen.ExpressionCompiler.access$300(ExpressionCompiler.java:42)
at com.facebook.presto.sql.gen.ExpressionCompiler$1.load(ExpressionCompiler.java:53)
at com.facebook.presto.sql.gen.ExpressionCompiler$1.load(ExpressionCompiler.java:48)
at com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3527)
at com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2319)
at com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2282)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2197)
at com.google.common.cache.LocalCache.get(LocalCache.java:3937)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3941)
at com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4824)
at com.google.common.cache.LocalCache$LocalLoadingCache.getUnchecked(LocalCache.java:4830)
at com.facebook.presto.sql.gen.ExpressionCompiler.compilePageProcessor(ExpressionCompiler.java:87)
at com.facebook.presto.operator.scalar.FunctionAssertions.compileFilterProject(FunctionAssertions.java:536)
... 36 more
I think we should be very careful about making greatest and least work element-wise on arrays. I would find it confusing if greatest(array[1, 2]) - > 2 and greatest(array[3, 4]) - > 4 but greatest(array[1, 2], array[3, 4]) - > array[3, 4]. If we don't want to add array_max, I would be more in favor of looking into scalar subqueries to see if we can have max(unnest(array[1, 2])) - > 2 and evaluates as a scalar
My last comment was in reply to @electrum, btw.
@cberner @electrum
What should happen if the input array is null only?
Fixed the review comments and rebased on current master
Merged. Thanks! (made a minor change, so that nulls in arrays always return null, and empty array always returns null)
Thanks @cberner , I will read the commit to see how do you handle nulls.
So the logic is:
If the array is empty, return null
If there is any null in array, return null
Otherwise, return the min/max element.
|
gharchive/pull-request
| 2015-06-16T05:55:47 |
2025-04-01T06:41:14.506683
|
{
"authors": [
"cberner",
"electrum",
"haozhun",
"yaoxin226"
],
"repo": "facebook/presto",
"url": "https://github.com/facebook/presto/pull/3114",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
96924759
|
First draft of Mongodb plugin
This looks awesome! Very complete docs, too!
Nit: the preferred capitalization, from looking at their website, seems to be "MongoDB"
looks good
I've rebased on 0.123-SNAPSHOT and fixed various typos in the document.
@electrum, apologies if I'm missing something. Is there a merge plan for this?
@gonewandering yes, we're super backlogged processing pull requests, but this is definitely on our list.
@martint, awesome. Thanks. Looking forward
Hi, I am using this as a plugin, with my current version of PrestoDB, and may have found a bug. When creating a schema for a collection, the connector fails with error whenever the db collection has a field name with a mixture or lower-case and upper-case characters. If I rename the field in the collection to be all lower-case, the queries then work fine. This has to be tested with a MongoDB server hosted on a case-sensitive O/S like Linux. The problem does not happen when I use a MongoDB on OSX, which has a case-insensitive file system.
Can you rebase on latest master?
Merged, thanks!
|
gharchive/pull-request
| 2015-07-23T23:20:15 |
2025-04-01T06:41:14.510541
|
{
"authors": [
"akshatnair",
"electrum",
"gonewandering",
"martint",
"milespoindexter",
"miniway"
],
"repo": "facebook/presto",
"url": "https://github.com/facebook/presto/pull/3337",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
149888350
|
Better error message when using refmt without arguments
Closed in favor of #945
|
gharchive/issue
| 2016-04-20T21:17:24 |
2025-04-01T06:41:14.511371
|
{
"authors": [
"chenglou"
],
"repo": "facebook/reason",
"url": "https://github.com/facebook/reason/issues/359",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
308171480
|
Use detect over select...first
The git tree went crazy...
|
gharchive/pull-request
| 2018-03-23T20:37:56 |
2025-04-01T06:41:14.523775
|
{
"authors": [
"minuscorp"
],
"repo": "fastlane/ci",
"url": "https://github.com/fastlane/ci/pull/369",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
774599258
|
stabilize subtitle upload thing
refactor code
|
gharchive/issue
| 2020-12-25T02:01:09 |
2025-04-01T06:41:14.524357
|
{
"authors": [
"fawazahmed0"
],
"repo": "fawazahmed0/quran-videos",
"url": "https://github.com/fawazahmed0/quran-videos/issues/22",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
807929983
|
Cell
asdf
|
gharchive/pull-request
| 2021-02-14T10:13:26 |
2025-04-01T06:41:14.525581
|
{
"authors": [
"StanfordLin"
],
"repo": "fcor/arjs-gestures",
"url": "https://github.com/fcor/arjs-gestures/pull/9",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
895454024
|
Add support for php 7.4
@paulmaxwell @quantum-llama @GaborSuranyi can you take a look at this PR as it's a simple one.
closing due to inactivity
|
gharchive/pull-request
| 2021-05-19T13:34:22 |
2025-04-01T06:41:14.537655
|
{
"authors": [
"Ig0r-M-magic42"
],
"repo": "fetchify-dev/magento2-ukpostcodelookup",
"url": "https://github.com/fetchify-dev/magento2-ukpostcodelookup/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
174956887
|
Add tests for the examples
Current coverage is 75.31% (diff: 100%)
Merging #640 into master will increase coverage by 0.36%
Powered by Codecov. Last update f165e43...0cb285a
@vkostyukov updated :+1:
Thanks @BenFradet! Merging this in!
|
gharchive/pull-request
| 2016-09-04T16:25:45 |
2025-04-01T06:41:14.546299
|
{
"authors": [
"BenFradet",
"codecov-io",
"vkostyukov"
],
"repo": "finagle/finch",
"url": "https://github.com/finagle/finch/pull/640",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
278859317
|
Fix indonesia spec to support 9 digits
Coverage remained the same at 99.398% when pulling c18d70a3e2611e76d4dce8717e15997e93fc23c1 on yamanaltereh:fix_indonesia_spec into 53e6aa2b370623646d05518ef14669d54db15d66 on floere:master.
@yamanaltereh Thank you! 🎉 Released in 2.16.1 🚀
|
gharchive/pull-request
| 2017-12-04T03:25:00 |
2025-04-01T06:41:14.575977
|
{
"authors": [
"coveralls",
"floere",
"yamanaltereh"
],
"repo": "floere/phony",
"url": "https://github.com/floere/phony/pull/394",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
242788549
|
Fix style issues introduced by dba29aa0fce684b201c6b03efc73ba607c7b507b
Submitting on red flutter build as the underlying issue of the red-ness has been fixed now.
|
gharchive/pull-request
| 2017-07-13T18:22:22 |
2025-04-01T06:41:14.577767
|
{
"authors": [
"sivachandra"
],
"repo": "flutter/flutter",
"url": "https://github.com/flutter/flutter/pull/11203",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
177665879
|
Upgrade to Angular 2.0
👍
|
gharchive/pull-request
| 2016-09-18T17:49:52 |
2025-04-01T06:41:15.517337
|
{
"authors": [
"albertvolkman",
"travist"
],
"repo": "formio/ng2-formio",
"url": "https://github.com/formio/ng2-formio/pull/24",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
56941759
|
add pool for SystemProcess/Views
Not only need pool.
Each time SystemProcess call Views.iterator() will alloc extra a lot memory for for map.keys() and a little memory for anonymous function( hasnext(), next(), holder ) in every loop.
And another issue:
the Views T is anonymous type ,so in some special platform( e.g. C# ), the generated source codes will slower http://haxe.org/manual/types-structure-performance.html .
Can macro detect these anonymous structs and create new type class and replace them?
I believe the allocation problem is still there but I made a few tests of classes vs anonymous and I cannot find any real difference in terms of performances.
|
gharchive/issue
| 2015-02-08T06:56:55 |
2025-04-01T06:41:15.523446
|
{
"authors": [
"daisuda",
"fponticelli"
],
"repo": "fponticelli/edge",
"url": "https://github.com/fponticelli/edge/issues/12",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
59313903
|
Updated some links
Thanks!
|
gharchive/pull-request
| 2015-02-28T00:22:08 |
2025-04-01T06:41:15.529476
|
{
"authors": [
"fredreichbier",
"zort"
],
"repo": "fredreichbier/genie",
"url": "https://github.com/fredreichbier/genie/pull/2",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
111687985
|
User-oriented FAQ for WeChat in uProxy
Want to check on this - last I heard, this module is essentially blocked by server-side changes in wechat. If that is the case, then maybe this issue should be revised to "note that this module is blocked in the main landing README." Thoughts?
as i understand it, it's not 'blocked', it's just a slightly worse user
experience where the signaling messages aren't fully hidden from users.
Arguably the same as github where the gists/comments are visible to users
as well.
On Wed, May 11, 2016 at 2:29 PM, soycode notifications@github.com wrote:
Want to check on this - last I heard, this module is essentially blocked
by server-side changes in wechat. If that is the case, then maybe this
issue should be revised to "note that this module is blocked in the main
landing README." Thoughts?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/freedomjs/freedom-social-wechat/issues/8#issuecomment-218595901
Ah yeah, I think I recall the conversation more clearly now, but I also think that uProxy basically considers that a pretty unusable state (since with wechat those messages alert your phone). Do we have any plausible path for fixing that?
Left this in an issue raised in the uproxy issue, but I'll just copy here for completeness.
@soycode, From when I was last looking, Will is right in that it is a usability issue -- the messages can no longer be sent hidden. However, Within the wechat api (last I checked), users don't have to be alerted of messages; i.e. a message can get to a phone, and a user can see the message if they look, but the phone will not vibrate or make any sounds to alert a user that a new/unread message is available in a thread.
The current path is to create a separate thread for uproxy's use with your friend, meaning that all uproxy related information will be isolated into a new "contact" where you won't be alerted of any messages passed through there, while keeping a thread between your original contact uncluttered. Some work has been made in order to accomplish this, but hasn't been taken to completion.
|
gharchive/issue
| 2015-10-15T19:16:45 |
2025-04-01T06:41:15.534651
|
{
"authors": [
"LeMasque",
"soycode",
"willscott"
],
"repo": "freedomjs/freedom-social-wechat",
"url": "https://github.com/freedomjs/freedom-social-wechat/issues/8",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
294590311
|
Testing and basic samples needed
Done
|
gharchive/issue
| 2018-02-06T00:26:47 |
2025-04-01T06:41:15.544826
|
{
"authors": [
"dsyme"
],
"repo": "fsprojects/Elmish.XamarinForms",
"url": "https://github.com/fsprojects/Elmish.XamarinForms/issues/1",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
162732565
|
Advise against fastclick use
But there are still a lot of those older browsers in use right? Especially in WebViews on Android for example.
The title of this PR is actually a lot bolder than the content of the PR, which is more about advising users of when not to use fastclick. If I had the time I would do a PR to turn off fastclick for modern browsers
|
gharchive/pull-request
| 2016-06-28T16:44:15 |
2025-04-01T06:41:15.546788
|
{
"authors": [
"adam-lynch",
"wheresrhys"
],
"repo": "ftlabs/fastclick",
"url": "https://github.com/ftlabs/fastclick/pull/481",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
524325465
|
on-boarding redux implementation using wallet_core
This is the implementation of the onboarding process. I would really appreciate if everyone can go over it and suggest improvements/thoughts/etc.
@LiorRabin It looks ok, but as long it's not tied up to UI we can't say how good it fits.
@creatix thanks! I will try and run with your additions and see why the 400 error
@creatix I've fixed the 400 error, you can continue from here
Closing this PR, will open a new branch with #2
|
gharchive/pull-request
| 2019-11-18T12:08:30 |
2025-04-01T06:41:15.551328
|
{
"authors": [
"LiorRabin",
"leonprou"
],
"repo": "fuseio/fuse-wallet2.0",
"url": "https://github.com/fuseio/fuse-wallet2.0/pull/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
284990699
|
Release v0.2.3
@merge
!merge
|
gharchive/pull-request
| 2017-12-28T21:10:29 |
2025-04-01T06:41:15.552442
|
{
"authors": [
"KevinGrandon"
],
"repo": "fusionjs/fusion-cli",
"url": "https://github.com/fusionjs/fusion-cli/pull/94",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
346428341
|
Upgrade dependencies
!merge
|
gharchive/pull-request
| 2018-08-01T02:49:40 |
2025-04-01T06:41:15.553034
|
{
"authors": [
"KevinGrandon",
"rtsao"
],
"repo": "fusionjs/fusion-plugin-react-router",
"url": "https://github.com/fusionjs/fusion-plugin-react-router/pull/163",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
471674848
|
enable velero in tests
For UI and Velero we are using api groups (routes, etc.) that do not exist in kubernetes by default in molecule.
|
gharchive/pull-request
| 2019-07-23T12:42:58 |
2025-04-01T06:41:15.554213
|
{
"authors": [
"jmontleon"
],
"repo": "fusor/mig-operator",
"url": "https://github.com/fusor/mig-operator/pull/14",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
122828858
|
Publish vs. Register... pick a term and be consistent in CLI and Web
These are the definitions we will use for each term:
Register - add container to Dockstore
Publish - make a registered container public (visible to all users)
The isregistered and ispublic columns of the tool table don't seem to mean what we think they would mean. ispublic refers to if a repo is public on quay, and is registered is used to see if a container is published on Dockstore (using definition of publish mentioned in my above comment).
I believe the isregistered can be removed completely, and ispublic replaced with ispublished. This will prevent future confusion between how we store tools and the way quay stores repos.
ispublished will just determine if the tool is published. If a tool is registered on the site then it will be in the DB anyways, so it is a redundant field.
I think we're consistent with this nomenclature now, in user-facing interfaces, if not totally in code.
|
gharchive/issue
| 2015-12-17T21:41:45 |
2025-04-01T06:41:15.557573
|
{
"authors": [
"agduncan94",
"briandoconnor",
"denis-yuen"
],
"repo": "ga4gh/dockstore",
"url": "https://github.com/ga4gh/dockstore/issues/79",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
269539210
|
Greenkeeper/sequelize 4.20.1
Coverage remained the same at 98.105% when pulling ce1ff6c64874a50652d8c2cac2847fd09ce48fcd on greenkeeper/sequelize-4.20.1 into 32b8055d267111cba38c6eb763a6a81625cbadd4 on master.
|
gharchive/pull-request
| 2017-10-30T09:55:59 |
2025-04-01T06:41:15.562524
|
{
"authors": [
"coveralls",
"gabrieltanchen"
],
"repo": "gabrieltanchen/xpns-api",
"url": "https://github.com/gabrieltanchen/xpns-api/pull/48",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
314876694
|
Create README.md
Create README.md
Create README.md
|
gharchive/pull-request
| 2018-04-17T01:55:59 |
2025-04-01T06:41:15.566748
|
{
"authors": [
"esdmorais",
"galberafael"
],
"repo": "galberafael/javakings",
"url": "https://github.com/galberafael/javakings/pull/5",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
197749975
|
Small grammatical error =)
Thanks for this 👍
|
gharchive/pull-request
| 2016-12-27T19:53:26 |
2025-04-01T06:41:15.577544
|
{
"authors": [
"garetmckinley",
"rivertam"
],
"repo": "garetmckinley/inferno-boilerplate",
"url": "https://github.com/garetmckinley/inferno-boilerplate/pull/29",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
299434775
|
Updating deps
Codecov Report
Merging #6 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 100% 100%
Complexity 8 8
=======================================
Files 4 4
Lines 27 27
=======================================
Hits 27 27
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0736cb...515b3a4. Read the comment docs.
|
gharchive/pull-request
| 2018-02-22T17:10:35 |
2025-04-01T06:41:15.583805
|
{
"authors": [
"codecov-io",
"gbprod"
],
"repo": "gbprod/algolia-specification-bundle",
"url": "https://github.com/gbprod/algolia-specification-bundle/pull/6",
"license": "WTFPL",
"license_type": "permissive",
"license_source": "github-api"
}
|
223061856
|
Merge all internal statistics into 'Volumes', 'Memory' and 'CPU' statistics and drop 'Use%' from volume stats
Need to create a new content pack for the new stats that does all rollups but not for 'type'. Need to add removal of all existing statistics to the migration SQL.
|
gharchive/issue
| 2017-04-20T13:08:50 |
2025-04-01T06:41:15.584741
|
{
"authors": [
"stroomdev66"
],
"repo": "gchq/stroom",
"url": "https://github.com/gchq/stroom/issues/231",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
121881017
|
Do not get browser session for skipped suite
:+1:
|
gharchive/pull-request
| 2015-12-12T21:13:37 |
2025-04-01T06:41:15.585382
|
{
"authors": [
"j0tunn",
"sipayRT"
],
"repo": "gemini-testing/gemini",
"url": "https://github.com/gemini-testing/gemini/pull/336",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
338997598
|
Output values of generator network appear to be limited to a very low range, causing a darkened image to be generated
All activation functions are set to relu.
|
gharchive/issue
| 2018-07-06T16:21:52 |
2025-04-01T06:41:15.586704
|
{
"authors": [
"generic-github-user"
],
"repo": "generic-github-user/xkcd-Generator",
"url": "https://github.com/generic-github-user/xkcd-Generator/issues/15",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
468109025
|
VGA resources and final mem
Everything allright
|
gharchive/pull-request
| 2019-07-15T12:50:11 |
2025-04-01T06:41:15.594885
|
{
"authors": [
"germanbravolopez"
],
"repo": "germanbravolopez/TFM",
"url": "https://github.com/germanbravolopez/TFM/pull/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
740584397
|
fix: Remove duplicate data from sampling context
Can we then remove parent_sampled from within the to_json implementation entirely? I don't think we need to send this to the server at all?
Is it being sent to the server, though? The only place I see us calling to_json() (other than where I call it in start_transaction()) is here: https://github.com/getsentry/sentry-python/blob/cc08a6bed116e09db41c712c20ab63eb0a839e41/sentry_sdk/tracing.py#L537-L541 where it's being called on spans, not including self, meaning it wouldn't get called on a transaction.
EDIT: Yeah, I checked. When I threw a pdb into my transport's _send_envelope method, here's what I got:
(Pdb) pp envelope.items[0].payload.json
{'_meta': {'...'},
'contexts': {'runtime': {'...'},
'trace': {'description': None,
'op': None,
'parent_span_id': None,
'span_id': '979d39004e00edcc',
'trace_id': '5a4fc60521604bfea8d89162ce497dc4'}},
'environment': 'dev',
'event_id': 'fab597c687f74d9d9b47dffc57dc237b',
'extra': {'secret_word': None,
'sys.argv': ['/Users/Katie/Documents/Sentry/test-apps/flask/server.py'],
'things': 'stuff'},
'platform': 'python',
'request': {'...'},
'sdk': {...'},
'server_name': 'test-server',
'spans': [],
'start_timestamp': '2020-11-12T17:50:33.731546Z',
'tags': {'dogs': 'rule', 'dogtag': 'yes'},
'timestamp': '2020-11-12T17:50:33.731875Z',
'transaction': 'dogpark',
'type': 'transaction',
'user': {'id': '122112', 'is_silly': True, 'username': 'maiseythedog'}}
So I think we're safe.
Ok right. Do you agree though that we can remove the field from the to_json return value?
Ah, yeah, that would do it, too, at which point the entire PR becomes removing this line: https://github.com/getsentry/sentry-python/blob/c9120691c360336e7ef4767cafa14c7d7a7d8226/sentry_sdk/tracing.py#L561
Works for me.
(Looking at it now, I'm not actually sure why I felt like it needed to be there in the first place... Oh - I know. I was trying too hard to copy the JS implementation, which I now actually wish I could go back and redo more like the way I ended up doing it in Python... Anyway, yeah, let's just take out that line.)
|
gharchive/pull-request
| 2020-11-11T08:49:11 |
2025-04-01T06:41:15.605977
|
{
"authors": [
"lobsterkatie",
"untitaker"
],
"repo": "getsentry/sentry-python",
"url": "https://github.com/getsentry/sentry-python/pull/919",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
158602076
|
Vendor all external deps so app doesn't rely on network
Fixed by 9aef3d8c6f137bf0e1a31c449f05fb12e0078e94 and d4a2b3ae2c882fb15ffcc3ede446f5bfa2b9a756
|
gharchive/issue
| 2016-06-06T05:16:42 |
2025-04-01T06:41:15.616908
|
{
"authors": [
"BinaryMuse"
],
"repo": "git-school/visualizing-git",
"url": "https://github.com/git-school/visualizing-git/issues/67",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
99466891
|
#19 - Add Get contributors method to the repository DAO and service
Looked good!
|
gharchive/pull-request
| 2015-08-06T15:51:17 |
2025-04-01T06:41:15.621170
|
{
"authors": [
"callicles",
"jacobtardieu"
],
"repo": "gitlinks/gitrank-web",
"url": "https://github.com/gitlinks/gitrank-web/pull/23",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
953695220
|
Fix codev
Codecov Report
:exclamation: No coverage uploaded for pull request base (master@e60d178). Click here to learn what that means.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #6 +/- ##
=========================================
Coverage ? 80.66%
=========================================
Files ? 357
Lines ? 30737
Branches ? 0
=========================================
Hits ? 24795
Misses ? 5942
Partials ? 0
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e60d178...557290b. Read the comment docs.
|
gharchive/pull-request
| 2021-07-27T09:38:15 |
2025-04-01T06:41:15.637247
|
{
"authors": [
"codecov-commenter",
"glynpu"
],
"repo": "glynpu/espnet",
"url": "https://github.com/glynpu/espnet/pull/6",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
823305135
|
Add ZMScore cmd
@BenjaminPrieur thanks for the PR. I have left one comment, but otherwise this looks good.
@vmihailenco I did the changes you mentioned
Thanks :+1:
|
gharchive/pull-request
| 2021-03-05T18:04:34 |
2025-04-01T06:41:15.642459
|
{
"authors": [
"BenjaminPrieur",
"vmihailenco"
],
"repo": "go-redis/redis",
"url": "https://github.com/go-redis/redis/pull/1685",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
501592053
|
Added link to tutorial for Thread class
Also added to Semaphore and Mutex
Thanks!
|
gharchive/pull-request
| 2019-10-02T16:19:37 |
2025-04-01T06:41:15.652464
|
{
"authors": [
"Chaosus",
"akien-mga"
],
"repo": "godotengine/godot",
"url": "https://github.com/godotengine/godot/pull/32497",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
909256587
|
Added commonsense probe
@googlebot I signed it!
@dodgejesse We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!
@StellaAthena are one of the assigned reviewers for this task. Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).
@nayeon7lee are one of the assigned reviewers for this task. Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).
The amount of tasks we received this round is tremendous. With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29 (if you haven't already done so).
this is an automated message
Hello, I just saw the suggested change to update the README.md file with an explicit section about where we got the data. The README.md does say that our "dataset [was] built from ATOMIC (Sap et al., 2019), a commonsense KB", but I'd be happy to add that section to the README.md, as long as it's not too late. I don't see a review (or "accept" or "does not meet criteria") yet?
@dodgejesse This task dis not yet have any reviews (apologies!) so I will do a late review. My main comment is regarding correctness: I don't understand most of the sentences in the task. Here are a few examples of labelled sentences I find confusing:
PersonX inherits from PersonX's mother and as a result, everyone else die
PersonX sees PersonX's sister and as a result, everyone else greets
PersonX holds in PersonY's hand and as a result, everyone else is hurt
PersonX holds in PersonY's hand and as a result, everyone else cries
PersonX takes PersonY's places and as a result, everyone else smile
Regarding the data source section: Yes, please add this section to the readme. This will make it easy for us to find this information when we scan through tasks.
@dodgejesse Hi Jesse, I am meta-reviewing this task. I wanted to follow up and see if you saw Guy's question and if you are still open to revising the task for the benchmark?
Best,
Ethan
Hi, thanks for the feedback! I've added a section to the README.md file which explicitly states where we got the data. (This task is ATOMIC (Sap et al., 2020) that we transformed into a probing task).
About the data quality: ATOMIC is known to be pretty noisy on its own, but the original authors were hesitant to try to filter the annotations too much as it was one of the first large-scale commonsense datasets created (we don't yet have good annotation schemes for commonsense tasks). The examples you point out above are at least somewhat noisy because of the annotations from the Mechanical Turkers for ATOMIC. For example, the first instance you show, "PersonX inherits from PersonX's mother and as a result, everyone else die" is a natural language sentence built from the annotation in ATOMIC {Event: "PersonX inherits from PersonX's mother", Relation: "Others_then", Annotations: {"none", "die", "leave earthly goods behind"}}
You can see this example in ATOMIC here: https://mosaickg.apps.allenai.org/kg-atomic2020/?l=PersonX inherits from PersonX's mother
Our filtering removed "none" and "leave earthly goods behind", and only kept "die" (as it's a single token, thus appropriate for the cloze-style task). This task can be viewed as a probe for the ATOMIC dataset, which does have some noise; as described in the README, we filtered it in a number of ways (including removing annotations like "none") to make it more grammatical and coherent. We hope the task is still useful at capturing some notion of commonsense.
Hi Jesse,
Digging into the examples a little bit, I empathize with the concern that at present many are ambiguous. For example here is a typical contiguous block:
{"input": "PersonX gives birth to the PersonY and as a result, everyone else is ", "target": ["washed"]},
{"input": "PersonX regards PersonY with eyes and as a result, everyone else ", "target": ["laughs"]},
{"input": "PersonX sees PersonY daughter and as a result, everyone else ", "target": ["waves"]},
{"input": "PersonX amends PersonY act and as a result, everyone else is ", "target": ["scolded"]},
Looking at the ATOMIC graph browser, it looks like though noisy, the full graph structure helps to render examples a bit less ambiguous.
Some examples look like the noise is enhanced by subsetting to a specific relation. i.e.
in the example PersonX gives birth to the PersonY and as a result, everyone else is, the browser results show that the Others then category results are not great, and in particular are not well suited to being rephrased as everyone else is
In other examples, it looks like the restriction to only single word responses enhances the noise. For example in {"input": "PersonX makes PersonY escape and as a result, everyone else ", "target": ["smiles"]}, here, the other multi-word examples (eg Gets away from danger), though not perfect, help strengthen the signal.
If you are up for it, I would suggest the following changes:
Include single and multi word targets, rather than filtering to single word.
Convert the task to multiple choice, rather than generative, where all target's present in the graph give a correct score of 1, and negative examples with score 0 are introduced. These could be taken, for instance, from the targets from other relations.
Additionally, if there was some way to do grammatical sanitization of the results, that would be awesome! For instance there are many examples like: {"input": "PersonX plays PersonY's heart and as a result, everyone has ", "target": ["marriage"]} -- though I understand this might be a headache and was not done in the initial work.
Thanks again for the task submission!
Best,
Ethan
Hi Jesse,
We are trying to finalize all benchmark tasks. Please address the above comments by Monday Aug 16 to be able to be included. Thanks!
|
gharchive/pull-request
| 2021-06-02T08:50:25 |
2025-04-01T06:41:15.701078
|
{
"authors": [
"chiafullo",
"dodgejesse",
"ethansdyer",
"guygurari"
],
"repo": "google/BIG-bench",
"url": "https://github.com/google/BIG-bench/pull/428",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
281328924
|
Google Calender reminder setting not set for attendees
Please give a lot more detail than this, otherwise we'll be unable to help you.
Please:
Show the code you're using
Describe exactly what you've observed vs what you expected to observe
var remind = new Event.RemindersData()
{
UseDefault = false,
Overrides = new EventReminder[] {
new EventReminder() { Method = "popup", Minutes = 2880 },
}
};
i have created a event with reminder before 2 days.
but on the attendees calendar the reminder time shows before 30 minutes
To be honest, that's what I'd expect anyway - a reminder is a personal thing, I wouldn't expect you to be able to change the reminder for any calendar other than your own.
In the resource description it specifically says "Information about the event's reminders for the authenticated user."
To put it another way - have you tried doing this in the Calendar web UI? Are you able to set other people's reminders that way?
No i can't do it from Calendar web UI
Okay, it sounds like this is working as intended then. I'll close this issue now. Please note that this repo is really for the .NET client library specifically; general API questions would be better posted on Stack Overflow.
|
gharchive/issue
| 2017-12-12T10:19:51 |
2025-04-01T06:41:15.706111
|
{
"authors": [
"jskeet",
"mihir1208"
],
"repo": "google/google-api-dotnet-client-samples",
"url": "https://github.com/google/google-api-dotnet-client-samples/issues/20",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
130646792
|
Fixed Opening brace issue to fix php 5.4 build issue
This class gets autogenerated. You could add this method to Google\Model, which is the subclass where the property comes from.
Can you explain why you need to access the model data here?
|
gharchive/pull-request
| 2016-02-02T10:57:22 |
2025-04-01T06:41:15.707681
|
{
"authors": [
"bshaffer",
"thilanga"
],
"repo": "google/google-api-php-client",
"url": "https://github.com/google/google-api-php-client/pull/825",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
146708587
|
Subclasses should provide connection settings for ServiceApiSettings
PTAL
LGTM
|
gharchive/pull-request
| 2016-04-07T18:35:40 |
2025-04-01T06:41:15.710064
|
{
"authors": [
"garrettjonesgoogle",
"shinfan"
],
"repo": "googleapis/gax-java",
"url": "https://github.com/googleapis/gax-java/pull/55",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
}
|
431912177
|
Reimplement ircfmt.Strip() to fix issues with $c
Noice, thanks for the PR! Good fix
|
gharchive/pull-request
| 2019-04-11T09:08:33 |
2025-04-01T06:41:15.711882
|
{
"authors": [
"A-UNDERSCORE-D",
"DanielOaks"
],
"repo": "goshuirc/irc-go",
"url": "https://github.com/goshuirc/irc-go/pull/14",
"license": "ISC",
"license_type": "permissive",
"license_source": "github-api"
}
|
293829578
|
Rebaseline GradleInceptionPerformanceTest
Feedback build: https://builds.gradle.org/viewQueued.html?itemId=10730038
|
gharchive/pull-request
| 2018-02-02T09:47:51 |
2025-04-01T06:41:15.725863
|
{
"authors": [
"eskatos"
],
"repo": "gradle/gradle",
"url": "https://github.com/gradle/gradle/pull/4247",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
636333062
|
Enable the NodeJS environment if possible
Access to the NodeJS environment has been deemed impossible via standard means. Experimental means will not be pursued.
|
gharchive/issue
| 2020-06-10T15:14:22 |
2025-04-01T06:41:15.727669
|
{
"authors": [
"grakkit"
],
"repo": "grakkit/grakkit",
"url": "https://github.com/grakkit/grakkit/issues/5",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
777689575
|
travis ci env
travis ci replaced by github action
travis ci replaced by github action
|
gharchive/issue
| 2021-01-03T18:15:12 |
2025-04-01T06:41:15.748060
|
{
"authors": [
"grillazz"
],
"repo": "grillazz/twofa_for_drf",
"url": "https://github.com/grillazz/twofa_for_drf/issues/16",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
440077479
|
Release/v2.9.0
Superseded by #98.
|
gharchive/pull-request
| 2019-05-03T14:40:48 |
2025-04-01T06:41:15.749822
|
{
"authors": [
"jmbtutor",
"jrmykolyn"
],
"repo": "groupby/storefront",
"url": "https://github.com/groupby/storefront/pull/97",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
216120784
|
Enroll bm_chttp2_transport & bm_pollset into bigquery pipeline
Merging early: no tests here
|
gharchive/pull-request
| 2017-03-22T16:10:14 |
2025-04-01T06:41:15.750576
|
{
"authors": [
"ctiller"
],
"repo": "grpc/grpc",
"url": "https://github.com/grpc/grpc/pull/10253",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
224291215
|
Fix for cmake test failures
asan c failure due to know issue #10169
5aa4158 does not look like your commit, can you get rid of it?
This fix is for a failure in portability test linux aggregate_tests.run_tests_c++_linux_dbg_native_default_cmake
No issue was created for this.
The asan failure in this PR is due to another known issue #10169
Opened another PR since this had incorrect commit messages.
@MakMukhi and what PR is that?
@MakMukhi, nit: you could have done git rebase -i upstream/master and force push to this branch to reuse this PR.
What is the number of the new PR?
Guessing https://github.com/grpc/grpc/pull/10869
If it's not solved can we figure out how to rollback?
|
gharchive/pull-request
| 2017-04-25T22:31:18 |
2025-04-01T06:41:15.753730
|
{
"authors": [
"MakMukhi",
"ctiller",
"dgquintas",
"jtattermusch",
"yang-g"
],
"repo": "grpc/grpc",
"url": "https://github.com/grpc/grpc/pull/10848",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
114187698
|
xib 中怎样加载啊？ 作者
和在xib里面 用一般的 view 一样的，具体遇到什么问题了呢？
加载不出来，我是用xib 做的autolayout 但是你给的初始化方法不管用。
demo 直接发我邮箱吧，gsdios@126.com
xib初始化方式已经优化，请下载最新代码测试下
|
gharchive/issue
| 2015-10-30T02:33:04 |
2025-04-01T06:41:15.758028
|
{
"authors": [
"gsdios",
"herwangsong"
],
"repo": "gsdios/SDCycleScrollView",
"url": "https://github.com/gsdios/SDCycleScrollView/issues/71",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
226876037
|
Update all versions
👍 Thanks
IMHO If you remove version from git dependencies it can even build without error (cairo-rs-sys)
I'll start merging cairo's PR then restart tests in here and we'll go up like this. ;)
Your way will be same errors for other git dependencies.
I merged cairo (I'll restart CI for it later).
But as error be in my way too as it build against gtk with versioned dependencies
Oh damn, we need to merge everything to test! Well, then let's merge...
Hm, I don't see gdk PR but see update branch in your repo
:-.
I confirm that examples now builds locally
I restarted all builds, they seem to succeed as well. :)
|
gharchive/pull-request
| 2017-05-07T17:05:18 |
2025-04-01T06:41:15.765814
|
{
"authors": [
"EPashkin",
"GuillaumeGomez"
],
"repo": "gtk-rs/sys",
"url": "https://github.com/gtk-rs/sys/pull/49",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
715328991
|
update description of SafeCSS & SafeHTML pom
Close PR due to the fact, that the description is already updated
|
gharchive/pull-request
| 2020-10-06T04:30:14 |
2025-04-01T06:41:15.775754
|
{
"authors": [
"FrankHossfeld"
],
"repo": "gwtproject/gwt-safehtml",
"url": "https://github.com/gwtproject/gwt-safehtml/pull/12",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
187604651
|
Add Heroku generated app.json
I would rename the app
|
gharchive/pull-request
| 2016-11-07T00:57:42 |
2025-04-01T06:41:15.776362
|
{
"authors": [
"anniemeng",
"sandlerben"
],
"repo": "hack4impact/maps4all",
"url": "https://github.com/hack4impact/maps4all/pull/56",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
110081226
|
Install Steward plugin to record meeting logs
:+1:
Closing since we haven't been having formal meetings on IRC.
|
gharchive/issue
| 2015-10-06T19:22:53 |
2025-04-01T06:41:15.777199
|
{
"authors": [
"paked",
"zachlatta"
],
"repo": "hackclub/meta",
"url": "https://github.com/hackclub/meta/issues/191",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
127714134
|
Add notes from 01.19.16's planning session
|
gharchive/pull-request
| 2016-01-20T15:58:35 |
2025-04-01T06:41:15.778030
|
{
"authors": [
"zachlatta"
],
"repo": "hackclub/meta",
"url": "https://github.com/hackclub/meta/pull/479",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
309557912
|
Geocoding Addresses
I've got this coded - how do you want to deploy it? Do you want to geocode a batch of addresses up front and serve the results or do you want to geocode live in the front end / API?
Hi! Thanks for commenting. I was testing issue notes with Lynn, and so I'm not the only one looking for a solution to this. It would be good to have a discussion at our Thursday meeting about how to proceed.
I can't come to the meeting but you can hit me up in Slack most of the day.
Thanks!
|
gharchive/issue
| 2018-03-28T22:40:54 |
2025-04-01T06:41:15.780340
|
{
"authors": [
"mckinneybock",
"znmeb"
],
"repo": "hackoregon/neighborhoods-2018",
"url": "https://github.com/hackoregon/neighborhoods-2018/issues/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
602628061
|
feature allow&disallow comments
Thanks @yantxs :+1:
|
gharchive/pull-request
| 2020-04-19T05:37:41 |
2025-04-01T06:41:15.807385
|
{
"authors": [
"haxzie",
"yantxs"
],
"repo": "haxzie/instagram-live-streamer",
"url": "https://github.com/haxzie/instagram-live-streamer/pull/6",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
483863777
|
Update GettingStartedGuide.md
Either we need to update it from time to time, or we just put above a sentence saying something like You need to run an installation command similar to the one shown below, although the exact version of three.js might vary
Could we tell them to run:
$ npm view @here/harp.gl dependencies
|
gharchive/pull-request
| 2019-08-22T09:04:19 |
2025-04-01T06:41:15.821082
|
{
"authors": [
"CraigBerlin",
"ninok"
],
"repo": "heremaps/harp.gl",
"url": "https://github.com/heremaps/harp.gl/pull/739",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
487079960
|
Hotfix/minor changes
С временем создания всё хорошо.
Когда пытаешься удалить юзера, который уже есть у кого-то в контактах, сервер падает. Ошибка: DETAIL: Key (id)=(38) is still referenced from table "contacts". Исправь, пожалуйста.
Я смогла добавить пользователям несколько одинаковых контактов. Однако, мы не должны разрешать пользователям так делать. Это тоже нужно исправить.
И мы договорились переносить таски, которые касаются кода, в done тогда, когда они уже в девелопе.
@dziubakseniia
Я не знаю, как это пофиксить. Я готова переасайнить кого-то на этот таск, так как не имею понятия, как должен работать on_delete в таком случае. Я предлагала сделать это с помощью питона, а не базы данных, это бы помогло избежать таких проблем. Сейчас проблема связана с тем, что оно пытается удалить всё, что связано с определенной записью (это и значит on_delete = CASCADE), а это не правильно. Ему надо удалить только запись в контактах, не трогая пользователей.
Вот доказательство того, что оно работает отлично и как надо: https://streamable.com/59f8o . Я показала, что у определенного пользователя есть contact_id = 4 и попыталась создать новый контакт с contact_id = 4. В этом случае, я получила ошибку - 400. Если я могу добавить пользователя, то я получаю статус код - 201.
Без проблем, я перенесу таски в IN PROGRESS
|
gharchive/pull-request
| 2019-08-29T17:14:33 |
2025-04-01T06:41:15.825045
|
{
"authors": [
"Anya2ka",
"dziubakseniia"
],
"repo": "hesoyam11/chat-with-anyone",
"url": "https://github.com/hesoyam11/chat-with-anyone/pull/15",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
163821074
|
Gets rid of all styling within bootstrap-theme.less
Closing since this is incomplete
|
gharchive/pull-request
| 2016-07-05T10:38:46 |
2025-04-01T06:41:15.827253
|
{
"authors": [
"hqcasanova"
],
"repo": "hevnly/asset-bazaar",
"url": "https://github.com/hevnly/asset-bazaar/pull/77",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
955175081
|
Feat: withProps
Pull Request Test Coverage Report for Build 1076140978
10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 94.988%
Totals
Change from base Build 1069291358:
0.2%
Covered Lines:
304
Relevant Lines:
308
💛 - Coveralls
|
gharchive/pull-request
| 2021-07-28T19:36:52 |
2025-04-01T06:41:15.863180
|
{
"authors": [
"coveralls",
"pablo1v"
],
"repo": "hitechline/reactools",
"url": "https://github.com/hitechline/reactools/pull/179",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
151126138
|
[MTDSA-189] [DM] Change confidence level to 50 as default
👍
|
gharchive/pull-request
| 2016-04-26T12:53:41 |
2025-04-01T06:41:15.868437
|
{
"authors": [
"dabd",
"danmassie"
],
"repo": "hmrc/self-assessment-api",
"url": "https://github.com/hmrc/self-assessment-api/pull/10",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
304773708
|
Update docs for deployment
Done. PR #63
|
gharchive/issue
| 2018-03-13T13:53:36 |
2025-04-01T06:41:15.872305
|
{
"authors": [
"smit1678",
"theREALaltoid"
],
"repo": "hotosm/OpenMapKitServer",
"url": "https://github.com/hotosm/OpenMapKitServer/issues/11",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
}
|
582059076
|
待选列表、已选列表，全选移动有问题
请提供可复现步骤或demo @Cosen95
|
gharchive/issue
| 2020-03-16T07:14:22 |
2025-04-01T06:41:15.877169
|
{
"authors": [
"Cosen95",
"hql7"
],
"repo": "hql7/tree-transfer",
"url": "https://github.com/hql7/tree-transfer/issues/86",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
157552183
|
Added Aegis Nova Badge
Thanks! Published v0.19.1
Forget to add Devra 2016 and Chapeau 2016 badges.
Shame on me ... Added now and pull request sent.
|
gharchive/pull-request
| 2016-05-30T20:17:59 |
2025-04-01T06:41:15.884811
|
{
"authors": [
"Witaminer",
"therealklanni"
],
"repo": "hubot-scripts/hubot-ingress",
"url": "https://github.com/hubot-scripts/hubot-ingress/pull/55",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
894532504
|
docs: small typo fixes
Robert to the rescue!
haha
On Tue, 18 May 2021 at 18:08, Mathias Buus @.***> wrote:
Robert to the rescue!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
gharchive/pull-request
| 2021-05-18T15:54:40 |
2025-04-01T06:41:15.898682
|
{
"authors": [
"mafintosh",
"robertkowalski"
],
"repo": "hypercore-protocol/hyperbee",
"url": "https://github.com/hypercore-protocol/hyperbee/pull/31",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
2446123
|
.torrent 文件名不支持空格
文件名是否加了引号？如：lx download --torrent "torrent file name.torrent"
加上引号果然好了。。。
|
gharchive/issue
| 2011-12-05T06:43:13 |
2025-04-01T06:41:15.915217
|
{
"authors": [
"iambus",
"romoo"
],
"repo": "iambus/xunlei-lixian",
"url": "https://github.com/iambus/xunlei-lixian/issues/7",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
}
|
122766826
|
Remove entry /etc/hosts when container stops
Fixed bu #12
|
gharchive/issue
| 2015-12-17T16:12:06 |
2025-04-01T06:41:15.915855
|
{
"authors": [
"Jean-Beru",
"iamluc"
],
"repo": "iamluc/docker-hostmanager",
"url": "https://github.com/iamluc/docker-hostmanager/issues/4",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
797708838
|
Create a use-case diagram
Created a use-case diagram in the wiki
Created a use-case diagram in the wiki
|
gharchive/issue
| 2021-01-31T13:15:56 |
2025-04-01T06:41:15.918908
|
{
"authors": [
"ibrahimnamdar"
],
"repo": "ibrahimnamdar/CovidAnalyzer",
"url": "https://github.com/ibrahimnamdar/CovidAnalyzer/issues/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
894947856
|
Update dependencies
are we going to convert this to just be a build time extension?
are we going to convert this to just be a build time extension?
@aruniverse I was thinking about that when updating this yesterday. I think it makes sense to do so. I'll hopefully get to it in the next few days.
|
gharchive/pull-request
| 2021-05-19T03:17:06 |
2025-04-01T06:41:15.934715
|
{
"authors": [
"aruniverse",
"calebmshafer"
],
"repo": "imodeljs/extension-sample",
"url": "https://github.com/imodeljs/extension-sample/pull/16",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
}
|
347637837
|
tokio-core is deprecated.
Any progress on this?
Just a short note (as I otherwise don't have the time to work on this library): moving away from tokio_core to tokio would have to account for the use of the former in tokio_proto, also deprecated but unfortunately the foundation of ldap3. I don't see a straightforward way to excise tokio_proto without a massive rewrite of this crate's internals.
Yes, I was realizing that last night when I was trying to do the migration myself.
Hi @inejge , I had a go at trying to port to tokio today, and have made some progress. It looks like the blocker is tokio_proto more than anything, for the multiplex tcp connections.
I'm due to release a program that will be deployed at clients in the coming days, so I don't have a choice but to "make it work".
I'm going to try something from the tower ecosystem and see if it works. I'll provide feedback in a few days
Right, the tokio_proto multiplexer is the tricky part, and having it available is what made initial development comparatively straightforward. For your immediate problem, I'd recommend starting a dedicated thread for LDAP connection(s), with its own tokio_core event loop, and communicating with the rest of the system via oneshot/mpsc channels. I believe these can work across tokio flavors.
I found https://github.com/red75prime/tokio-proto/commit/cd1af828791fcd60dc518eb713a53d00e9aacf91, which while not ideal, still allowed me to get the crate to build. I just got it to build now actually.
With the port to Tokio 0.2, this can now be closed.
Thanks @inejge
|
gharchive/issue
| 2018-08-04T18:11:54 |
2025-04-01T06:41:15.946760
|
{
"authors": [
"bbigras",
"inejge",
"masonk",
"nevi-me",
"quadrupleslap"
],
"repo": "inejge/ldap3",
"url": "https://github.com/inejge/ldap3/issues/29",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
}
|
576497653
|
[10.1.x] ISPN-7819 update putAll docs
Integrated into 10.1.x, thanks @oraNod !
|
gharchive/pull-request
| 2020-03-05T20:01:17 |
2025-04-01T06:41:15.947870
|
{
"authors": [
"oraNod",
"wburns"
],
"repo": "infinispan/infinispan",
"url": "https://github.com/infinispan/infinispan/pull/8005",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.