type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/cosmos/pulls/comments/113573234","pull_request_review_id":34974174,"id":113573234,"diff_hunk":"@@ -24,3 +25,21 @@ trait PackageCollection {\n \n def search(query: Option[String])(implicit session: RequestSession): Future[List[rpc.v1.model.SearchResult]]\n }\n+\n+object PackageCollection {\n+\n+ /**\n+ * Return the versions of packages from `possibleUpgrades` that the package with the given\n+ * `name` and `version` can be upgraded to.\n+ */\n+ def upgradesTo(\n+ name: String,\n+ version: universe.v3.model.Version,\n+ possibleUpgrades: List[universe.v4.model.PackageDefinition]\n+ ): List[universe.v3.model.Version] = {\n+ possibleUpgrades.collect {\n+ case pkg if pkg.name == name && pkg.canUpgradeFrom(version) => pkg.version\n+ }\n+ }","path":"cosmos-server/src/main/scala/com/mesosphere/cosmos/repository/PackageCollection.scala","position":27,"original_position":27,"commit_id":"66de5970dcce80011afe298eb5bca1135bc18bcc","original_commit_id":"66de5970dcce80011afe298eb5bca1135bc18bcc","user":{"login":"jsancio","id":794394,"avatar_url":"https://avatars1.githubusercontent.com/u/794394?v=3","gravatar_id":"","url":"https://api.github.com/users/jsancio","html_url":"https://github.com/jsancio","followers_url":"https://api.github.com/users/jsancio/followers","following_url":"https://api.github.com/users/jsancio/following{/other_user}","gists_url":"https://api.github.com/users/jsancio/gists{/gist_id}","starred_url":"https://api.github.com/users/jsancio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsancio/subscriptions","organizations_url":"https://api.github.com/users/jsancio/orgs","repos_url":"https://api.github.com/users/jsancio/repos","events_url":"https://api.github.com/users/jsancio/events{/privacy}","received_events_url":"https://api.github.com/users/jsancio/received_events","type":"User","site_admin":false},"body":"Yeah. I think you are right. @larioj should know better if he needs `PackageDefinition` or `Version`.","created_at":"2017-04-26T21:59:06Z","updated_at":"2017-04-26T21:59:06Z","html_url":"https://github.com/dcos/cosmos/pull/614#discussion_r113573234","pull_request_url":"https://api.github.com/repos/dcos/cosmos/pulls/614","_links":{"self":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/comments/113573234"},"html":{"href":"https://github.com/dcos/cosmos/pull/614#discussion_r113573234"},"pull_request":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/cosmos/pulls/614","id":117602291,"html_url":"https://github.com/dcos/cosmos/pull/614","diff_url":"https://github.com/dcos/cosmos/pull/614.diff","patch_url":"https://github.com/dcos/cosmos/pull/614.patch","issue_url":"https://api.github.com/repos/dcos/cosmos/issues/614","number":614,"state":"open","locked":false,"title":"Add upgradesTo() method to PackageCollection","user":{"login":"cruhland","id":1936682,"avatar_url":"https://avatars3.githubusercontent.com/u/1936682?v=3","gravatar_id":"","url":"https://api.github.com/users/cruhland","html_url":"https://github.com/cruhland","followers_url":"https://api.github.com/users/cruhland/followers","following_url":"https://api.github.com/users/cruhland/following{/other_user}","gists_url":"https://api.github.com/users/cruhland/gists{/gist_id}","starred_url":"https://api.github.com/users/cruhland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruhland/subscriptions","organizations_url":"https://api.github.com/users/cruhland/orgs","repos_url":"https://api.github.com/users/cruhland/repos","events_url":"https://api.github.com/users/cruhland/events{/privacy}","received_events_url":"https://api.github.com/users/cruhland/received_events","type":"User","site_admin":false},"body":"I ended up going with the generator approach instead of the view approach that we talked about the other day. It does make the generators more complicated; I'll point out where. I decided not to use the view because it seemed too heavyweight a change for a simple feature.","created_at":"2017-04-25T23:26:46Z","updated_at":"2017-04-26T21:59:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b1ba6c6c4116ff2632c4ccc453e5220cbbae5a7","assignee":{"login":"cruhland","id":1936682,"avatar_url":"https://avatars3.githubusercontent.com/u/1936682?v=3","gravatar_id":"","url":"https://api.github.com/users/cruhland","html_url":"https://github.com/cruhland","followers_url":"https://api.github.com/users/cruhland/followers","following_url":"https://api.github.com/users/cruhland/following{/other_user}","gists_url":"https://api.github.com/users/cruhland/gists{/gist_id}","starred_url":"https://api.github.com/users/cruhland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruhland/subscriptions","organizations_url":"https://api.github.com/users/cruhland/orgs","repos_url":"https://api.github.com/users/cruhland/repos","events_url":"https://api.github.com/users/cruhland/events{/privacy}","received_events_url":"https://api.github.com/users/cruhland/received_events","type":"User","site_admin":false},"assignees":[{"login":"cruhland","id":1936682,"avatar_url":"https://avatars3.githubusercontent.com/u/1936682?v=3","gravatar_id":"","url":"https://api.github.com/users/cruhland","html_url":"https://github.com/cruhland","followers_url":"https://api.github.com/users/cruhland/followers","following_url":"https://api.github.com/users/cruhland/following{/other_user}","gists_url":"https://api.github.com/users/cruhland/gists{/gist_id}","starred_url":"https://api.github.com/users/cruhland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruhland/subscriptions","organizations_url":"https://api.github.com/users/cruhland/orgs","repos_url":"https://api.github.com/users/cruhland/repos","events_url":"https://api.github.com/users/cruhland/events{/privacy}","received_events_url":"https://api.github.com/users/cruhland/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/cosmos/pulls/614/commits","review_comments_url":"https://api.github.com/repos/dcos/cosmos/pulls/614/comments","review_comment_url":"https://api.github.com/repos/dcos/cosmos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/cosmos/issues/614/comments","statuses_url":"https://api.github.com/repos/dcos/cosmos/statuses/66de5970dcce80011afe298eb5bca1135bc18bcc","head":{"label":"dcos:upgrades-to","ref":"upgrades-to","sha":"66de5970dcce80011afe298eb5bca1135bc18bcc","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":47585661,"name":"cosmos","full_name":"dcos/cosmos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/cosmos","description":"Provides an API for the orderly, harmonious, and complete management of DC/OS service packages","fork":false,"url":"https://api.github.com/repos/dcos/cosmos","forks_url":"https://api.github.com/repos/dcos/cosmos/forks","keys_url":"https://api.github.com/repos/dcos/cosmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/cosmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/cosmos/teams","hooks_url":"https://api.github.com/repos/dcos/cosmos/hooks","issue_events_url":"https://api.github.com/repos/dcos/cosmos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/cosmos/events","assignees_url":"https://api.github.com/repos/dcos/cosmos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/cosmos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/cosmos/tags","blobs_url":"https://api.github.com/repos/dcos/cosmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/cosmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/cosmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/cosmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/cosmos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/cosmos/languages","stargazers_url":"https://api.github.com/repos/dcos/cosmos/stargazers","contributors_url":"https://api.github.com/repos/dcos/cosmos/contributors","subscribers_url":"https://api.github.com/repos/dcos/cosmos/subscribers","subscription_url":"https://api.github.com/repos/dcos/cosmos/subscription","commits_url":"https://api.github.com/repos/dcos/cosmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/cosmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/cosmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/cosmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/cosmos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/cosmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/cosmos/merges","archive_url":"https://api.github.com/repos/dcos/cosmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/cosmos/downloads","issues_url":"https://api.github.com/repos/dcos/cosmos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/cosmos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/cosmos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/cosmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/cosmos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/cosmos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/cosmos/deployments","created_at":"2015-12-07T23:23:49Z","updated_at":"2017-04-17T21:05:12Z","pushed_at":"2017-04-26T20:21:49Z","git_url":"git://github.com/dcos/cosmos.git","ssh_url":"git@github.com:dcos/cosmos.git","clone_url":"https://github.com/dcos/cosmos.git","svn_url":"https://github.com/dcos/cosmos","homepage":"","size":1696,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":43,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"1c2d26f703290ab21be6c37cd96297773bcae156","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":47585661,"name":"cosmos","full_name":"dcos/cosmos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/cosmos","description":"Provides an API for the orderly, harmonious, and complete management of DC/OS service packages","fork":false,"url":"https://api.github.com/repos/dcos/cosmos","forks_url":"https://api.github.com/repos/dcos/cosmos/forks","keys_url":"https://api.github.com/repos/dcos/cosmos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/cosmos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/cosmos/teams","hooks_url":"https://api.github.com/repos/dcos/cosmos/hooks","issue_events_url":"https://api.github.com/repos/dcos/cosmos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/cosmos/events","assignees_url":"https://api.github.com/repos/dcos/cosmos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/cosmos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/cosmos/tags","blobs_url":"https://api.github.com/repos/dcos/cosmos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/cosmos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/cosmos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/cosmos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/cosmos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/cosmos/languages","stargazers_url":"https://api.github.com/repos/dcos/cosmos/stargazers","contributors_url":"https://api.github.com/repos/dcos/cosmos/contributors","subscribers_url":"https://api.github.com/repos/dcos/cosmos/subscribers","subscription_url":"https://api.github.com/repos/dcos/cosmos/subscription","commits_url":"https://api.github.com/repos/dcos/cosmos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/cosmos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/cosmos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/cosmos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/cosmos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/cosmos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/cosmos/merges","archive_url":"https://api.github.com/repos/dcos/cosmos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/cosmos/downloads","issues_url":"https://api.github.com/repos/dcos/cosmos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/cosmos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/cosmos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/cosmos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/cosmos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/cosmos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/cosmos/deployments","created_at":"2015-12-07T23:23:49Z","updated_at":"2017-04-17T21:05:12Z","pushed_at":"2017-04-26T20:21:49Z","git_url":"git://github.com/dcos/cosmos.git","ssh_url":"git@github.com:dcos/cosmos.git","clone_url":"https://github.com/dcos/cosmos.git","svn_url":"https://github.com/dcos/cosmos","homepage":"","size":1696,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/614"},"html":{"href":"https://github.com/dcos/cosmos/pull/614"},"issue":{"href":"https://api.github.com/repos/dcos/cosmos/issues/614"},"comments":{"href":"https://api.github.com/repos/dcos/cosmos/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/cosmos/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/cosmos/statuses/66de5970dcce80011afe298eb5bca1135bc18bcc"}}}}
|
{
"id": 47585661,
"name": "dcos/cosmos",
"url": "https://api.github.com/repos/dcos/cosmos"
}
|
{
"id": 794394,
"login": "jsancio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/794394?",
"url": "https://api.github.com/users/jsancio"
}
|
{
"id": 17648048,
"login": "dcos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17648048?",
"url": "https://api.github.com/orgs/dcos"
}
| 2017-04-26T21:59:06 |
5764303254
|
{"actor":{"display_login":"jsancio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/112342223","pull_request_review_id":33650093,"id":112342223,"diff_hunk":"@@ -210,6 +210,7 @@ class CuDNNConvolutionOp : public Operator {\n typename DataType<DType>::ScaleType beta = 0.0f;\n typename DataType<DType>::ScaleType beta_add = 1.0f;\n if (!param_.no_bias) {\n+ CHECK_NE(req[conv::kBias], kNullOp);","path":"src/operator/cudnn_convolution-inl.h","position":4,"original_position":4,"commit_id":"c307725118a2ffb620a32a559261f781fc8608ff","original_commit_id":"2084129e8cadac312bb86dfa3b52dbcd7c82ae22","user":{"login":"piiswrong","id":568948,"avatar_url":"https://avatars3.githubusercontent.com/u/568948?v=3","gravatar_id":"","url":"https://api.github.com/users/piiswrong","html_url":"https://github.com/piiswrong","followers_url":"https://api.github.com/users/piiswrong/followers","following_url":"https://api.github.com/users/piiswrong/following{/other_user}","gists_url":"https://api.github.com/users/piiswrong/gists{/gist_id}","starred_url":"https://api.github.com/users/piiswrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piiswrong/subscriptions","organizations_url":"https://api.github.com/users/piiswrong/orgs","repos_url":"https://api.github.com/users/piiswrong/repos","events_url":"https://api.github.com/users/piiswrong/events{/privacy}","received_events_url":"https://api.github.com/users/piiswrong/received_events","type":"User","site_admin":false},"body":"I think it should be \r\nif (!param_.no_bias && req[conv::kBias] != kNullOp)","created_at":"2017-04-20T00:16:06Z","updated_at":"2017-04-20T00:16:06Z","html_url":"https://github.com/dmlc/mxnet/pull/5902#discussion_r112342223","pull_request_url":"https://api.github.com/repos/dmlc/mxnet/pulls/5902","_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/112342223"},"html":{"href":"https://github.com/dmlc/mxnet/pull/5902#discussion_r112342223"},"pull_request":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/5902"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/5902","id":116662019,"html_url":"https://github.com/dmlc/mxnet/pull/5902","diff_url":"https://github.com/dmlc/mxnet/pull/5902.diff","patch_url":"https://github.com/dmlc/mxnet/pull/5902.patch","issue_url":"https://api.github.com/repos/dmlc/mxnet/issues/5902","number":5902,"state":"open","locked":false,"title":"Avoids running unneeded backprop kernels.","user":{"login":"DickJC123","id":1703397,"avatar_url":"https://avatars3.githubusercontent.com/u/1703397?v=3","gravatar_id":"","url":"https://api.github.com/users/DickJC123","html_url":"https://github.com/DickJC123","followers_url":"https://api.github.com/users/DickJC123/followers","following_url":"https://api.github.com/users/DickJC123/following{/other_user}","gists_url":"https://api.github.com/users/DickJC123/gists{/gist_id}","starred_url":"https://api.github.com/users/DickJC123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickJC123/subscriptions","organizations_url":"https://api.github.com/users/DickJC123/orgs","repos_url":"https://api.github.com/users/DickJC123/repos","events_url":"https://api.github.com/users/DickJC123/events{/privacy}","received_events_url":"https://api.github.com/users/DickJC123/received_events","type":"User","site_admin":false},"body":"Within CuDNNConvolutionOp.Backward(), this adds checks to avoid launching backprop kernels unnecessarily (i.e. when req[] == kNullOp). This would result typically in avoiding the L1 dgrad kernel launch in CNN's.","created_at":"2017-04-19T23:22:02Z","updated_at":"2017-04-20T00:16:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef58ccb235b2a2bec7e72c2f81520b2c2e4a0f46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/mxnet/pulls/5902/commits","review_comments_url":"https://api.github.com/repos/dmlc/mxnet/pulls/5902/comments","review_comment_url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/mxnet/issues/5902/comments","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/c307725118a2ffb620a32a559261f781fc8608ff","head":{"label":"DickJC123:avoids_L1_dgrad","ref":"avoids_L1_dgrad","sha":"c307725118a2ffb620a32a559261f781fc8608ff","user":{"login":"DickJC123","id":1703397,"avatar_url":"https://avatars3.githubusercontent.com/u/1703397?v=3","gravatar_id":"","url":"https://api.github.com/users/DickJC123","html_url":"https://github.com/DickJC123","followers_url":"https://api.github.com/users/DickJC123/followers","following_url":"https://api.github.com/users/DickJC123/following{/other_user}","gists_url":"https://api.github.com/users/DickJC123/gists{/gist_id}","starred_url":"https://api.github.com/users/DickJC123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickJC123/subscriptions","organizations_url":"https://api.github.com/users/DickJC123/orgs","repos_url":"https://api.github.com/users/DickJC123/repos","events_url":"https://api.github.com/users/DickJC123/events{/privacy}","received_events_url":"https://api.github.com/users/DickJC123/received_events","type":"User","site_admin":false},"repo":{"id":86116214,"name":"mxnet","full_name":"DickJC123/mxnet","owner":{"login":"DickJC123","id":1703397,"avatar_url":"https://avatars3.githubusercontent.com/u/1703397?v=3","gravatar_id":"","url":"https://api.github.com/users/DickJC123","html_url":"https://github.com/DickJC123","followers_url":"https://api.github.com/users/DickJC123/followers","following_url":"https://api.github.com/users/DickJC123/following{/other_user}","gists_url":"https://api.github.com/users/DickJC123/gists{/gist_id}","starred_url":"https://api.github.com/users/DickJC123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DickJC123/subscriptions","organizations_url":"https://api.github.com/users/DickJC123/orgs","repos_url":"https://api.github.com/users/DickJC123/repos","events_url":"https://api.github.com/users/DickJC123/events{/privacy}","received_events_url":"https://api.github.com/users/DickJC123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DickJC123/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/DickJC123/mxnet","forks_url":"https://api.github.com/repos/DickJC123/mxnet/forks","keys_url":"https://api.github.com/repos/DickJC123/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DickJC123/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DickJC123/mxnet/teams","hooks_url":"https://api.github.com/repos/DickJC123/mxnet/hooks","issue_events_url":"https://api.github.com/repos/DickJC123/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/DickJC123/mxnet/events","assignees_url":"https://api.github.com/repos/DickJC123/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/DickJC123/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/DickJC123/mxnet/tags","blobs_url":"https://api.github.com/repos/DickJC123/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DickJC123/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DickJC123/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/DickJC123/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DickJC123/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/DickJC123/mxnet/languages","stargazers_url":"https://api.github.com/repos/DickJC123/mxnet/stargazers","contributors_url":"https://api.github.com/repos/DickJC123/mxnet/contributors","subscribers_url":"https://api.github.com/repos/DickJC123/mxnet/subscribers","subscription_url":"https://api.github.com/repos/DickJC123/mxnet/subscription","commits_url":"https://api.github.com/repos/DickJC123/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/DickJC123/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/DickJC123/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/DickJC123/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/DickJC123/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/DickJC123/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DickJC123/mxnet/merges","archive_url":"https://api.github.com/repos/DickJC123/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DickJC123/mxnet/downloads","issues_url":"https://api.github.com/repos/DickJC123/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/DickJC123/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/DickJC123/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/DickJC123/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DickJC123/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/DickJC123/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/DickJC123/mxnet/deployments","created_at":"2017-03-24T22:40:46Z","updated_at":"2017-03-24T22:40:51Z","pushed_at":"2017-04-19T23:48:34Z","git_url":"git://github.com/DickJC123/mxnet.git","ssh_url":"git@github.com:DickJC123/mxnet.git","clone_url":"https://github.com/DickJC123/mxnet.git","svn_url":"https://github.com/DickJC123/mxnet","homepage":"http://mxnet.io","size":16629,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"3e4be713a0aa135d6a1ef671f96cddc111857274","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars1.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"mxnet","full_name":"dmlc/mxnet","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars1.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/dmlc/mxnet","forks_url":"https://api.github.com/repos/dmlc/mxnet/forks","keys_url":"https://api.github.com/repos/dmlc/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/mxnet/teams","hooks_url":"https://api.github.com/repos/dmlc/mxnet/hooks","issue_events_url":"https://api.github.com/repos/dmlc/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/mxnet/events","assignees_url":"https://api.github.com/repos/dmlc/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/mxnet/tags","blobs_url":"https://api.github.com/repos/dmlc/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/mxnet/languages","stargazers_url":"https://api.github.com/repos/dmlc/mxnet/stargazers","contributors_url":"https://api.github.com/repos/dmlc/mxnet/contributors","subscribers_url":"https://api.github.com/repos/dmlc/mxnet/subscribers","subscription_url":"https://api.github.com/repos/dmlc/mxnet/subscription","commits_url":"https://api.github.com/repos/dmlc/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/mxnet/merges","archive_url":"https://api.github.com/repos/dmlc/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/mxnet/downloads","issues_url":"https://api.github.com/repos/dmlc/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2017-04-19T23:23:51Z","pushed_at":"2017-04-20T00:00:18Z","git_url":"git://github.com/dmlc/mxnet.git","ssh_url":"git@github.com:dmlc/mxnet.git","clone_url":"https://github.com/dmlc/mxnet.git","svn_url":"https://github.com/dmlc/mxnet","homepage":"http://mxnet.io","size":16625,"stargazers_count":9277,"watchers_count":9277,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3493,"mirror_url":null,"open_issues_count":1527,"forks":3493,"open_issues":1527,"watchers":9277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/5902"},"html":{"href":"https://github.com/dmlc/mxnet/pull/5902"},"issue":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/5902"},"comments":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/5902/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/5902/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/5902/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/mxnet/statuses/c307725118a2ffb620a32a559261f781fc8608ff"}}}}
|
{
"id": 34864402,
"name": "dmlc/mxnet",
"url": "https://api.github.com/repos/dmlc/mxnet"
}
|
{
"id": 568948,
"login": "piiswrong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/568948?",
"url": "https://api.github.com/users/piiswrong"
}
|
{
"id": 11508361,
"login": "dmlc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11508361?",
"url": "https://api.github.com/orgs/dmlc"
}
| 2017-04-20T00:16:06 |
5720094154
|
{"actor":{"display_login":"piiswrong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/100698020","pull_request_review_id":21412147,"id":100698020,"diff_hunk":"@@ -108,7 +108,7 @@ class SequenceMaskOp : public Operator {\n if (param_.use_sequence_length) {\n Tensor<xpu, 1, DType> indices =\n in_data[seq_mask::kSequenceLength].get<xpu, 1, DType>(s);\n- SequenceMask(data_grad, indices, static_cast<DType>(param_.value));\n+ SequenceMask(data_grad, indices, DType(0));","path":"src/operator/sequence_mask-inl.h","position":5,"original_position":5,"commit_id":"cdcdbabd3b4ef820897d9334c5c846a6523453e4","original_commit_id":"cdcdbabd3b4ef820897d9334c5c846a6523453e4","user":{"login":"sbodenstein","id":10237782,"avatar_url":"https://avatars.githubusercontent.com/u/10237782?v=3","gravatar_id":"","url":"https://api.github.com/users/sbodenstein","html_url":"https://github.com/sbodenstein","followers_url":"https://api.github.com/users/sbodenstein/followers","following_url":"https://api.github.com/users/sbodenstein/following{/other_user}","gists_url":"https://api.github.com/users/sbodenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/sbodenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbodenstein/subscriptions","organizations_url":"https://api.github.com/users/sbodenstein/orgs","repos_url":"https://api.github.com/users/sbodenstein/repos","events_url":"https://api.github.com/users/sbodenstein/events{/privacy}","received_events_url":"https://api.github.com/users/sbodenstein/received_events","type":"User","site_admin":false},"body":"Thanks for catching that!","created_at":"2017-02-12T17:08:50Z","updated_at":"2017-02-12T17:08:50Z","html_url":"https://github.com/dmlc/mxnet/pull/4986#discussion_r100698020","pull_request_url":"https://api.github.com/repos/dmlc/mxnet/pulls/4986","_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments/100698020"},"html":{"href":"https://github.com/dmlc/mxnet/pull/4986#discussion_r100698020"},"pull_request":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/4986"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/mxnet/pulls/4986","id":105784822,"html_url":"https://github.com/dmlc/mxnet/pull/4986","diff_url":"https://github.com/dmlc/mxnet/pull/4986.diff","patch_url":"https://github.com/dmlc/mxnet/pull/4986.patch","issue_url":"https://api.github.com/repos/dmlc/mxnet/issues/4986","number":4986,"state":"open","locked":false,"title":"Improve numerical gradient and fix tests","user":{"login":"piiswrong","id":568948,"avatar_url":"https://avatars.githubusercontent.com/u/568948?v=3","gravatar_id":"","url":"https://api.github.com/users/piiswrong","html_url":"https://github.com/piiswrong","followers_url":"https://api.github.com/users/piiswrong/followers","following_url":"https://api.github.com/users/piiswrong/following{/other_user}","gists_url":"https://api.github.com/users/piiswrong/gists{/gist_id}","starred_url":"https://api.github.com/users/piiswrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piiswrong/subscriptions","organizations_url":"https://api.github.com/users/piiswrong/orgs","repos_url":"https://api.github.com/users/piiswrong/repos","events_url":"https://api.github.com/users/piiswrong/events{/privacy}","received_events_url":"https://api.github.com/users/piiswrong/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-12T09:15:49Z","updated_at":"2017-02-12T17:08:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d50e9344f4de99fb5aa5b5225a7c28aac630619","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/mxnet/pulls/4986/commits","review_comments_url":"https://api.github.com/repos/dmlc/mxnet/pulls/4986/comments","review_comment_url":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/mxnet/issues/4986/comments","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/cdcdbabd3b4ef820897d9334c5c846a6523453e4","head":{"label":"piiswrong:test","ref":"test","sha":"cdcdbabd3b4ef820897d9334c5c846a6523453e4","user":{"login":"piiswrong","id":568948,"avatar_url":"https://avatars.githubusercontent.com/u/568948?v=3","gravatar_id":"","url":"https://api.github.com/users/piiswrong","html_url":"https://github.com/piiswrong","followers_url":"https://api.github.com/users/piiswrong/followers","following_url":"https://api.github.com/users/piiswrong/following{/other_user}","gists_url":"https://api.github.com/users/piiswrong/gists{/gist_id}","starred_url":"https://api.github.com/users/piiswrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piiswrong/subscriptions","organizations_url":"https://api.github.com/users/piiswrong/orgs","repos_url":"https://api.github.com/users/piiswrong/repos","events_url":"https://api.github.com/users/piiswrong/events{/privacy}","received_events_url":"https://api.github.com/users/piiswrong/received_events","type":"User","site_admin":false},"repo":{"id":44707337,"name":"mxnet","full_name":"piiswrong/mxnet","owner":{"login":"piiswrong","id":568948,"avatar_url":"https://avatars.githubusercontent.com/u/568948?v=3","gravatar_id":"","url":"https://api.github.com/users/piiswrong","html_url":"https://github.com/piiswrong","followers_url":"https://api.github.com/users/piiswrong/followers","following_url":"https://api.github.com/users/piiswrong/following{/other_user}","gists_url":"https://api.github.com/users/piiswrong/gists{/gist_id}","starred_url":"https://api.github.com/users/piiswrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piiswrong/subscriptions","organizations_url":"https://api.github.com/users/piiswrong/orgs","repos_url":"https://api.github.com/users/piiswrong/repos","events_url":"https://api.github.com/users/piiswrong/events{/privacy}","received_events_url":"https://api.github.com/users/piiswrong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/piiswrong/mxnet","description":"Efficient and Flexible Distributed Deep Learning Framework, for python, R, Julia and more","fork":true,"url":"https://api.github.com/repos/piiswrong/mxnet","forks_url":"https://api.github.com/repos/piiswrong/mxnet/forks","keys_url":"https://api.github.com/repos/piiswrong/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/piiswrong/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/piiswrong/mxnet/teams","hooks_url":"https://api.github.com/repos/piiswrong/mxnet/hooks","issue_events_url":"https://api.github.com/repos/piiswrong/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/piiswrong/mxnet/events","assignees_url":"https://api.github.com/repos/piiswrong/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/piiswrong/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/piiswrong/mxnet/tags","blobs_url":"https://api.github.com/repos/piiswrong/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/piiswrong/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/piiswrong/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/piiswrong/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/piiswrong/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/piiswrong/mxnet/languages","stargazers_url":"https://api.github.com/repos/piiswrong/mxnet/stargazers","contributors_url":"https://api.github.com/repos/piiswrong/mxnet/contributors","subscribers_url":"https://api.github.com/repos/piiswrong/mxnet/subscribers","subscription_url":"https://api.github.com/repos/piiswrong/mxnet/subscription","commits_url":"https://api.github.com/repos/piiswrong/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/piiswrong/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/piiswrong/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/piiswrong/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/piiswrong/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/piiswrong/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/piiswrong/mxnet/merges","archive_url":"https://api.github.com/repos/piiswrong/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/piiswrong/mxnet/downloads","issues_url":"https://api.github.com/repos/piiswrong/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/piiswrong/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/piiswrong/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/piiswrong/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/piiswrong/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/piiswrong/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/piiswrong/mxnet/deployments","created_at":"2015-10-21T22:07:57Z","updated_at":"2017-02-07T01:50:18Z","pushed_at":"2017-02-12T09:15:40Z","git_url":"git://github.com/piiswrong/mxnet.git","ssh_url":"git@github.com:piiswrong/mxnet.git","clone_url":"https://github.com/piiswrong/mxnet.git","svn_url":"https://github.com/piiswrong/mxnet","homepage":"http://mxnet.rtfd.org","size":14311,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"f4c6d5575b320d27f2a9ecada00f7d01dce3c3c8","user":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"mxnet","full_name":"dmlc/mxnet","owner":{"login":"dmlc","id":11508361,"avatar_url":"https://avatars.githubusercontent.com/u/11508361?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/dmlc/mxnet","forks_url":"https://api.github.com/repos/dmlc/mxnet/forks","keys_url":"https://api.github.com/repos/dmlc/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/mxnet/teams","hooks_url":"https://api.github.com/repos/dmlc/mxnet/hooks","issue_events_url":"https://api.github.com/repos/dmlc/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/mxnet/events","assignees_url":"https://api.github.com/repos/dmlc/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/mxnet/tags","blobs_url":"https://api.github.com/repos/dmlc/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/mxnet/languages","stargazers_url":"https://api.github.com/repos/dmlc/mxnet/stargazers","contributors_url":"https://api.github.com/repos/dmlc/mxnet/contributors","subscribers_url":"https://api.github.com/repos/dmlc/mxnet/subscribers","subscription_url":"https://api.github.com/repos/dmlc/mxnet/subscription","commits_url":"https://api.github.com/repos/dmlc/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/mxnet/merges","archive_url":"https://api.github.com/repos/dmlc/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/mxnet/downloads","issues_url":"https://api.github.com/repos/dmlc/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2017-02-12T16:27:22Z","pushed_at":"2017-02-12T15:01:53Z","git_url":"git://github.com/dmlc/mxnet.git","ssh_url":"git@github.com:dmlc/mxnet.git","clone_url":"https://github.com/dmlc/mxnet.git","svn_url":"https://github.com/dmlc/mxnet","homepage":"http://mxnet.io","size":13928,"stargazers_count":8228,"watchers_count":8228,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3043,"mirror_url":null,"open_issues_count":1185,"forks":3043,"open_issues":1185,"watchers":8228,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/4986"},"html":{"href":"https://github.com/dmlc/mxnet/pull/4986"},"issue":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/4986"},"comments":{"href":"https://api.github.com/repos/dmlc/mxnet/issues/4986/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/4986/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/mxnet/pulls/4986/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/mxnet/statuses/cdcdbabd3b4ef820897d9334c5c846a6523453e4"}}}}
|
{
"id": 34864402,
"name": "dmlc/mxnet",
"url": "https://api.github.com/repos/dmlc/mxnet"
}
|
{
"id": 10237782,
"login": "sbodenstein",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10237782?",
"url": "https://api.github.com/users/sbodenstein"
}
|
{
"id": 11508361,
"login": "dmlc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11508361?",
"url": "https://api.github.com/orgs/dmlc"
}
| 2017-02-12T17:08:50 |
5310102329
|
{"actor":{"display_login":"sbodenstein"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/etsy/phan/pulls/comments/104600736","pull_request_review_id":25443454,"id":104600736,"diff_hunk":"@@ -68,4 +68,11 @@ protected function canCastToNonNullableType(Type $type) : bool\n return parent::canCastToNonNullableType($type);\n }\n \n+ /**\n+ *\n+ */\n+ public function asFQSENString() : string","path":"src/Phan/Language/Type/ScalarType.php","position":7,"original_position":7,"commit_id":"5d2a9363fa050efcc063e5940c0397bd632edd16","original_commit_id":"5d2a9363fa050efcc063e5940c0397bd632edd16","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars1.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"body":"redundant, also in NativeType. Unlikely to be a bottleneck, since __toString() in scalars is also defined the same way, and won't call asFQSENString","created_at":"2017-03-07T07:06:20Z","updated_at":"2017-03-07T07:06:20Z","html_url":"https://github.com/etsy/phan/pull/563#discussion_r104600736","pull_request_url":"https://api.github.com/repos/etsy/phan/pulls/563","_links":{"self":{"href":"https://api.github.com/repos/etsy/phan/pulls/comments/104600736"},"html":{"href":"https://github.com/etsy/phan/pull/563#discussion_r104600736"},"pull_request":{"href":"https://api.github.com/repos/etsy/phan/pulls/563"}}},"pull_request":{"url":"https://api.github.com/repos/etsy/phan/pulls/563","id":107986774,"html_url":"https://github.com/etsy/phan/pull/563","diff_url":"https://github.com/etsy/phan/pull/563.diff","patch_url":"https://github.com/etsy/phan/pull/563.patch","issue_url":"https://api.github.com/repos/etsy/phan/issues/563","number":563,"state":"open","locked":false,"title":"Add a daemon mode to memoize parse state, fork off workers to analyze single files quickly","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars1.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"body":"Related to https://github.com/etsy/phan/issues/22 and https://github.com/TysonAndre/phan/issues/14\r\nMostly stable, but there's still some bugs when switching between git branches.\r\n\r\nIntermediate work on the squashed commits can be seen on https://github.com/TysonAndre/phan/commits/daemonize-and-analyze-individual-files\r\n\r\nThis depends on the pcntl extension.\r\n\r\nBecause there isn't a database, it is less likely that code changes will\r\nbreak this. However, this will keep using RAM in the background (Around the\r\nsame amount of ram to analyse a project in single process mode)\r\n\r\nServer implementation\r\n\r\n`./phan --daemonize-tcp-port 4846 --quick`\r\n\r\nClient implementation\r\n\r\n```bash\r\n./phan_client --daemonize-tcp-port 4846 -l src/Phan/Phan.php\r\n```\r\n\r\n(Similar to `php -l src/Phan/Phan.php`, and can be used as a substitute\r\nfor syntax check in some scripts)\r\n\r\nThis will parse every single file, but will only analyze a small subset\r\nof those files.\r\n\r\nWhen the daemon receives a request\r\n\r\n1. Check for modified files (it would be slightly faster if we did this\r\n for all files except the requested file(s) ahead of time, e.g. with\r\n inotify PECL)\r\n This requires stat()ing all files\r\n2. Remove classes, methods, functions, and constants from the files that\r\n were deleted or modified, and in the config..\r\n3. Add classes, methods, functions, and constants from the files that\r\n were added or modified, and in the config.\r\n4. Fork, and run the remaining method checks and analysis parse steps.\r\n The forked process doesn't affect the state of the daemon.\r\n (The memory(state) of the fork is a copy of the original,\r\n but doesn't affect the original)\r\n\r\nCommit Details:\r\n\r\n- exit(1) if the command line parameters of phan_client are invalid.\r\n- Listen on a TCP port or unix socket for requests as JSON blobs(unix in progress)\r\n (\"method\" can probable be translated to POSTs to the path /analyze_files, etc,\r\n if HTTP is supported in the future)\r\n- nit: Show 0% progress bar as well, make animation smoother\r\n- Depends on pcntl extension and assumes unix-like OS. (folder, path\r\n names)\r\n- The functionality to undo parse steps into CodeBase. An alternative would be to make\r\n CodeBase and the undoable CodeBase be classes implementing the same\r\n interface, but that would require changing all code using CodeBase,\r\n and is prone to braking.\r\n- Added micro-optimizations that affect only daemon mode\r\n (This script is invoked from an editor on file save/change,\r\n so it's desirable to be as fast as possible on large as possible.\r\n Outside of daemon mode, the pre-analyze steps (analyzeFunctions)\r\n don't take up a large fraction of the time.)\r\n- misc optimizations\r\n- misc TODOs, noting bugs that would happen in code that is part of\r\n parse mode.\r\n- Add debugging logs for things which would affect daemon mode (e.g.\r\n accidental duplicate classes).\r\n Disable this by default. Once this is stable, debugging logs can be\r\n removed\r\n- change analyzing file list to take a closure to generate the file list.\r\n This allows daemon mode to process any files that were added, deleted,\r\n or removed since the last time files were passed\r\n- make `phan_client` Print the requested relative/absolute path,\r\n not the relative path within the project\r\n (and only print the paths if they are requested)\r\n (so that editors open error view with the correct file name)\r\n\r\nOptimization steps and reasons:\r\n\r\n1. Without daemon mode, phan analysis of phan in debug mode took 11 seconds\r\n (would have been faster if php wasn't using --enable-debug mode)\r\n2. After keeping the parse state and memory, and forking off new\r\n processes to execute the remaining steps, steps took 2 seconds.\r\n3. Cut out analyzing files which aren't in the set of requested files.\r\n (Some steps after parse are applied to the whole codebase, not just\r\n the files to analyze).\r\n (takes 0.1 seconds on phan)\r\n\r\n At the current point in time, all issues I saw are with\r\n getContext()->getFile(). Some plugins may emit issues in a different\r\n file from the one being checked, but I'm not aware of any.\r\n\r\nAdd partial documentation on using the plugin\r\n\r\nFull documentation is pending (Step by step on setting up a VM)\r\nBuilding php on the host should be much faster.\r\n\r\nWork for later PRs:\r\n\r\n- make the example plugin able to automatically start the daemon.\r\n - automatically stop after 30 minutes without new requests or so\r\n- rate limit\r\n- Plugins in other languages\r\n\r\n - I wasn't familiar with how to install/develop a syntastic plugin, so that\r\n plugin was wasn't revived\r\n- Investigate and fix exceptions for classes which are suddenly missing from `use` statements when switching between checkouts\r\n- etc.\r\n\r\n# Examples\r\n\r\nSimple Vim and emacs plugins exist to analyze a single file on file save. (aside: Vim output became slightly more verbose)\r\n\r\n\r\n\r\n\r\n\r\n- See https://github.com/TysonAndre/flycheck-phanclient/tree/2f4638f0c35d91ad973adfbb77e8e98a9a8b9283 for an older version using the changes in this PR (New features were added, but this PR is large)\r\n\r\n1. Invoking the server (While --quick isn't mandatory, that option significantly reduces the duration of `phan_client` requests)\r\n\r\n```bash\r\n~/phan $ ./phan --daemonize-tcp-port 4849 --quick\r\nListening for Phan analysis requests at tcp://127.0.0.1:4849\r\n```\r\n\r\n2. Invoking the client, after server indicates it is listening for requests\r\n\r\n```bash\r\n~/phan $ echo '{\"method\":\"analyze_files\",\"files\":[\"src/Phan/Phan.php\"]}' | nc 127.0.0.1 4849\r\n{\"status\":\"ok\",\"issue_count\":0,\"issues\":[]}\r\n~/phan $ ./phan_client --daemonize-tcp-port 4849 -l src/Phan.php\r\nNo syntax errors detected in src/Phan/Phan.php\r\n~/phan $ vim src/Phan/Phan.php # add buggy, unused function to test out the daemon\r\n~/phan $ echo '{\"method\":\"analyze_files\",\"files\":[\"src/Phan/Phan.php\"]}' | nc 127.0.0.1 4849\r\n{\"status\":\"ok\",\"issue_count\":2,\"issues\":[{\"type\":\"issue\",\"check_name\":\"PhanUndeclaredMethod\",\"description\":\"UndefError PhanUndeclaredMethod Call to undeclared method \\\\Phan\\\\Config::thismethodisundefined\",\"severity\":5,\"location\":{\"path\":\"src\\/Phan\\/Phan.php\",\"lines\":{\"begin\":417,\"end\":417}}},{\"type\":\"issue\",\"check_name\":\"PhanTypeMismatchReturn\",\"description\":\"TypeError PhanTypeMismatchReturn Returning type null but examplefn() is declared to return string\",\"severity\":5,\"location\":{\"path\":\"src\\/Phan\\/Phan.php\",\"lines\":{\"begin\":418,\"end\":418}}}]\r\n\r\n~/phan $ time ./phan_client --daemonize-tcp-port 4849 -l src/Phan/Phan.php\r\nNo syntax errors detected in src/Phan/Phan.php\r\nPhan error: UndefError: PhanUndeclaredMethod: Call to undeclared method \\Phan\\Config::thismethodisundefined in src/Phan/Phan.php on line 417\r\nPhan error: TypeError: PhanTypeMismatchReturn: Returning type null but examplefn() is declared to return string in src/Phan/Phan.php on line 418\r\n./phan_client --daemonize-tcp-port 4849 -l src/Phan/Phan.php 0.03s user 0.01s system 40% cpu 0.089 total\r\n```","created_at":"2017-02-26T02:24:33Z","updated_at":"2017-03-07T07:06:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37211326fb40192cb3d366eb49ffbd6f43257402","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/etsy/phan/pulls/563/commits","review_comments_url":"https://api.github.com/repos/etsy/phan/pulls/563/comments","review_comment_url":"https://api.github.com/repos/etsy/phan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/etsy/phan/issues/563/comments","statuses_url":"https://api.github.com/repos/etsy/phan/statuses/5d2a9363fa050efcc063e5940c0397bd632edd16","head":{"label":"TysonAndre:daemonize-and-client-rebased-upstream","ref":"daemonize-and-client-rebased-upstream","sha":"5d2a9363fa050efcc063e5940c0397bd632edd16","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars1.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"repo":{"id":70954730,"name":"phan","full_name":"TysonAndre/phan","owner":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars1.githubusercontent.com/u/1904430?v=3","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TysonAndre/phan","description":"Static analyzer for PHP","fork":true,"url":"https://api.github.com/repos/TysonAndre/phan","forks_url":"https://api.github.com/repos/TysonAndre/phan/forks","keys_url":"https://api.github.com/repos/TysonAndre/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TysonAndre/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TysonAndre/phan/teams","hooks_url":"https://api.github.com/repos/TysonAndre/phan/hooks","issue_events_url":"https://api.github.com/repos/TysonAndre/phan/issues/events{/number}","events_url":"https://api.github.com/repos/TysonAndre/phan/events","assignees_url":"https://api.github.com/repos/TysonAndre/phan/assignees{/user}","branches_url":"https://api.github.com/repos/TysonAndre/phan/branches{/branch}","tags_url":"https://api.github.com/repos/TysonAndre/phan/tags","blobs_url":"https://api.github.com/repos/TysonAndre/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TysonAndre/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TysonAndre/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/TysonAndre/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TysonAndre/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/TysonAndre/phan/languages","stargazers_url":"https://api.github.com/repos/TysonAndre/phan/stargazers","contributors_url":"https://api.github.com/repos/TysonAndre/phan/contributors","subscribers_url":"https://api.github.com/repos/TysonAndre/phan/subscribers","subscription_url":"https://api.github.com/repos/TysonAndre/phan/subscription","commits_url":"https://api.github.com/repos/TysonAndre/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/TysonAndre/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/TysonAndre/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/TysonAndre/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/TysonAndre/phan/contents/{+path}","compare_url":"https://api.github.com/repos/TysonAndre/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TysonAndre/phan/merges","archive_url":"https://api.github.com/repos/TysonAndre/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TysonAndre/phan/downloads","issues_url":"https://api.github.com/repos/TysonAndre/phan/issues{/number}","pulls_url":"https://api.github.com/repos/TysonAndre/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/TysonAndre/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/TysonAndre/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TysonAndre/phan/labels{/name}","releases_url":"https://api.github.com/repos/TysonAndre/phan/releases{/id}","deployments_url":"https://api.github.com/repos/TysonAndre/phan/deployments","created_at":"2016-10-14T23:47:13Z","updated_at":"2017-02-03T00:39:18Z","pushed_at":"2017-03-07T07:00:54Z","git_url":"git://github.com/TysonAndre/phan.git","ssh_url":"git@github.com:TysonAndre/phan.git","clone_url":"https://github.com/TysonAndre/phan.git","svn_url":"https://github.com/TysonAndre/phan","homepage":null,"size":5803,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":22,"forks":0,"open_issues":22,"watchers":0,"default_branch":"master"}},"base":{"label":"etsy:master","ref":"master","sha":"62d15a2b732e347fd70f387154c9dcf90b9254a8","user":{"login":"etsy","id":193389,"avatar_url":"https://avatars3.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"repo":{"id":44751102,"name":"phan","full_name":"etsy/phan","owner":{"login":"etsy","id":193389,"avatar_url":"https://avatars3.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etsy/phan","description":"Phan is a static analyzer for PHP. Phan prefers to avoid false-positives and attempts to prove incorrectness rather than correctness.","fork":false,"url":"https://api.github.com/repos/etsy/phan","forks_url":"https://api.github.com/repos/etsy/phan/forks","keys_url":"https://api.github.com/repos/etsy/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etsy/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etsy/phan/teams","hooks_url":"https://api.github.com/repos/etsy/phan/hooks","issue_events_url":"https://api.github.com/repos/etsy/phan/issues/events{/number}","events_url":"https://api.github.com/repos/etsy/phan/events","assignees_url":"https://api.github.com/repos/etsy/phan/assignees{/user}","branches_url":"https://api.github.com/repos/etsy/phan/branches{/branch}","tags_url":"https://api.github.com/repos/etsy/phan/tags","blobs_url":"https://api.github.com/repos/etsy/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etsy/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etsy/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/etsy/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etsy/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/etsy/phan/languages","stargazers_url":"https://api.github.com/repos/etsy/phan/stargazers","contributors_url":"https://api.github.com/repos/etsy/phan/contributors","subscribers_url":"https://api.github.com/repos/etsy/phan/subscribers","subscription_url":"https://api.github.com/repos/etsy/phan/subscription","commits_url":"https://api.github.com/repos/etsy/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/etsy/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/etsy/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/etsy/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/etsy/phan/contents/{+path}","compare_url":"https://api.github.com/repos/etsy/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etsy/phan/merges","archive_url":"https://api.github.com/repos/etsy/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etsy/phan/downloads","issues_url":"https://api.github.com/repos/etsy/phan/issues{/number}","pulls_url":"https://api.github.com/repos/etsy/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/etsy/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/etsy/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etsy/phan/labels{/name}","releases_url":"https://api.github.com/repos/etsy/phan/releases{/id}","deployments_url":"https://api.github.com/repos/etsy/phan/deployments","created_at":"2015-10-22T14:34:09Z","updated_at":"2017-03-06T02:56:56Z","pushed_at":"2017-03-07T07:02:11Z","git_url":"git://github.com/etsy/phan.git","ssh_url":"git@github.com:etsy/phan.git","clone_url":"https://github.com/etsy/phan.git","svn_url":"https://github.com/etsy/phan","homepage":"","size":4367,"stargazers_count":1991,"watchers_count":1991,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":89,"forks":151,"open_issues":89,"watchers":1991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etsy/phan/pulls/563"},"html":{"href":"https://github.com/etsy/phan/pull/563"},"issue":{"href":"https://api.github.com/repos/etsy/phan/issues/563"},"comments":{"href":"https://api.github.com/repos/etsy/phan/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/etsy/phan/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/etsy/phan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/etsy/phan/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/etsy/phan/statuses/5d2a9363fa050efcc063e5940c0397bd632edd16"}}}}
|
{
"id": 44751102,
"name": "etsy/phan",
"url": "https://api.github.com/repos/etsy/phan"
}
|
{
"id": 1904430,
"login": "TysonAndre",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1904430?",
"url": "https://api.github.com/users/TysonAndre"
}
|
{
"id": 193389,
"login": "etsy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/193389?",
"url": "https://api.github.com/orgs/etsy"
}
| 2017-03-07T07:06:20 |
5445328137
|
{"actor":{"display_login":"TysonAndre"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/comments/100997532","pull_request_review_id":21714596,"id":100997532,"diff_hunk":"@@ -0,0 +1,11 @@\n+# The Bug","path":"test/issue260/README.md","position":1,"original_position":1,"commit_id":"e88a2f42df1f252a75a4c5a2027770d942d4ac57","original_commit_id":"e88a2f42df1f252a75a4c5a2027770d942d4ac57","user":{"login":"awalterschulze","id":1829933,"avatar_url":"https://avatars.githubusercontent.com/u/1829933?v=3","gravatar_id":"","url":"https://api.github.com/users/awalterschulze","html_url":"https://github.com/awalterschulze","followers_url":"https://api.github.com/users/awalterschulze/followers","following_url":"https://api.github.com/users/awalterschulze/following{/other_user}","gists_url":"https://api.github.com/users/awalterschulze/gists{/gist_id}","starred_url":"https://api.github.com/users/awalterschulze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awalterschulze/subscriptions","organizations_url":"https://api.github.com/users/awalterschulze/orgs","repos_url":"https://api.github.com/users/awalterschulze/repos","events_url":"https://api.github.com/users/awalterschulze/events{/privacy}","received_events_url":"https://api.github.com/users/awalterschulze/received_events","type":"User","site_admin":false},"body":"I really like this file. Good idea.","created_at":"2017-02-14T10:05:40Z","updated_at":"2017-02-14T10:05:41Z","html_url":"https://github.com/gogo/protobuf/pull/258#discussion_r100997532","pull_request_url":"https://api.github.com/repos/gogo/protobuf/pulls/258","_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments/100997532"},"html":{"href":"https://github.com/gogo/protobuf/pull/258#discussion_r100997532"},"pull_request":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/gogo/protobuf/pulls/258","id":105046508,"html_url":"https://github.com/gogo/protobuf/pull/258","diff_url":"https://github.com/gogo/protobuf/pull/258.diff","patch_url":"https://github.com/gogo/protobuf/pull/258.patch","issue_url":"https://api.github.com/repos/gogo/protobuf/issues/258","number":258,"state":"open","locked":false,"title":"Add references to some custom imports","user":{"login":"Serabe","id":36221,"avatar_url":"https://avatars.githubusercontent.com/u/36221?v=3","gravatar_id":"","url":"https://api.github.com/users/Serabe","html_url":"https://github.com/Serabe","followers_url":"https://api.github.com/users/Serabe/followers","following_url":"https://api.github.com/users/Serabe/following{/other_user}","gists_url":"https://api.github.com/users/Serabe/gists{/gist_id}","starred_url":"https://api.github.com/users/Serabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Serabe/subscriptions","organizations_url":"https://api.github.com/users/Serabe/orgs","repos_url":"https://api.github.com/users/Serabe/repos","events_url":"https://api.github.com/users/Serabe/events{/privacy}","received_events_url":"https://api.github.com/users/Serabe/received_events","type":"User","site_admin":false},"body":"When using stdtime and typedecl options, an error is raised because we are\r\nimporting time and not using it (if the time field is not nullable).\r\n\r\nThis is fixed substituting `customImports` in the generator to receive a custom\r\nstruct containing three optional fields:\r\n\r\n* *Alias* for the import\r\n* *Path* for the import\r\n* *UnderscorableSymbol* for an exported symbol in the package that can be used\r\nas an expression (it will be used in `var _ = <Alias>.<UnderscorableSymbol>`)\r\n\r\nThen, `writtenImports` is used to make sure we don't write the `var` assignment\r\ntwice.\r\n\r\nIf a `customImport` has no `UnderscorableSymbol`, then the statement won't be\r\ngenerated at all.","created_at":"2017-02-07T16:49:46Z","updated_at":"2017-02-14T10:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b9a8b7485f7cdca28853a31c70a7960a022bc86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/gogo/protobuf/pulls/258/commits","review_comments_url":"https://api.github.com/repos/gogo/protobuf/pulls/258/comments","review_comment_url":"https://api.github.com/repos/gogo/protobuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gogo/protobuf/issues/258/comments","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/e88a2f42df1f252a75a4c5a2027770d942d4ac57","head":{"label":"Serabe:fix/getter_and_time_and_typedecl","ref":"fix/getter_and_time_and_typedecl","sha":"e88a2f42df1f252a75a4c5a2027770d942d4ac57","user":{"login":"Serabe","id":36221,"avatar_url":"https://avatars.githubusercontent.com/u/36221?v=3","gravatar_id":"","url":"https://api.github.com/users/Serabe","html_url":"https://github.com/Serabe","followers_url":"https://api.github.com/users/Serabe/followers","following_url":"https://api.github.com/users/Serabe/following{/other_user}","gists_url":"https://api.github.com/users/Serabe/gists{/gist_id}","starred_url":"https://api.github.com/users/Serabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Serabe/subscriptions","organizations_url":"https://api.github.com/users/Serabe/orgs","repos_url":"https://api.github.com/users/Serabe/repos","events_url":"https://api.github.com/users/Serabe/events{/privacy}","received_events_url":"https://api.github.com/users/Serabe/received_events","type":"User","site_admin":false},"repo":{"id":76854167,"name":"protobuf","full_name":"Serabe/protobuf","owner":{"login":"Serabe","id":36221,"avatar_url":"https://avatars.githubusercontent.com/u/36221?v=3","gravatar_id":"","url":"https://api.github.com/users/Serabe","html_url":"https://github.com/Serabe","followers_url":"https://api.github.com/users/Serabe/followers","following_url":"https://api.github.com/users/Serabe/following{/other_user}","gists_url":"https://api.github.com/users/Serabe/gists{/gist_id}","starred_url":"https://api.github.com/users/Serabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Serabe/subscriptions","organizations_url":"https://api.github.com/users/Serabe/orgs","repos_url":"https://api.github.com/users/Serabe/repos","events_url":"https://api.github.com/users/Serabe/events{/privacy}","received_events_url":"https://api.github.com/users/Serabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Serabe/protobuf","description":"Protocol Buffers for Go with Gadgets","fork":true,"url":"https://api.github.com/repos/Serabe/protobuf","forks_url":"https://api.github.com/repos/Serabe/protobuf/forks","keys_url":"https://api.github.com/repos/Serabe/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Serabe/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Serabe/protobuf/teams","hooks_url":"https://api.github.com/repos/Serabe/protobuf/hooks","issue_events_url":"https://api.github.com/repos/Serabe/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/Serabe/protobuf/events","assignees_url":"https://api.github.com/repos/Serabe/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/Serabe/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/Serabe/protobuf/tags","blobs_url":"https://api.github.com/repos/Serabe/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Serabe/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Serabe/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Serabe/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Serabe/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/Serabe/protobuf/languages","stargazers_url":"https://api.github.com/repos/Serabe/protobuf/stargazers","contributors_url":"https://api.github.com/repos/Serabe/protobuf/contributors","subscribers_url":"https://api.github.com/repos/Serabe/protobuf/subscribers","subscription_url":"https://api.github.com/repos/Serabe/protobuf/subscription","commits_url":"https://api.github.com/repos/Serabe/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Serabe/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Serabe/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Serabe/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Serabe/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/Serabe/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Serabe/protobuf/merges","archive_url":"https://api.github.com/repos/Serabe/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Serabe/protobuf/downloads","issues_url":"https://api.github.com/repos/Serabe/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/Serabe/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/Serabe/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/Serabe/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Serabe/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/Serabe/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/Serabe/protobuf/deployments","created_at":"2016-12-19T10:53:45Z","updated_at":"2016-12-19T10:53:48Z","pushed_at":"2017-02-14T09:53:05Z","git_url":"git://github.com/Serabe/protobuf.git","ssh_url":"git@github.com:Serabe/protobuf.git","clone_url":"https://github.com/Serabe/protobuf.git","svn_url":"https://github.com/Serabe/protobuf","homepage":"","size":20507,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gogo:master","ref":"master","sha":"9c5b7bafbfccf2b40d274e0496f3a09418a87af4","user":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"repo":{"id":27483832,"name":"protobuf","full_name":"gogo/protobuf","owner":{"login":"gogo","id":9958490,"avatar_url":"https://avatars.githubusercontent.com/u/9958490?v=3","gravatar_id":"","url":"https://api.github.com/users/gogo","html_url":"https://github.com/gogo","followers_url":"https://api.github.com/users/gogo/followers","following_url":"https://api.github.com/users/gogo/following{/other_user}","gists_url":"https://api.github.com/users/gogo/gists{/gist_id}","starred_url":"https://api.github.com/users/gogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gogo/subscriptions","organizations_url":"https://api.github.com/users/gogo/orgs","repos_url":"https://api.github.com/users/gogo/repos","events_url":"https://api.github.com/users/gogo/events{/privacy}","received_events_url":"https://api.github.com/users/gogo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gogo/protobuf","description":"Protocol Buffers for Go with Gadgets","fork":false,"url":"https://api.github.com/repos/gogo/protobuf","forks_url":"https://api.github.com/repos/gogo/protobuf/forks","keys_url":"https://api.github.com/repos/gogo/protobuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gogo/protobuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gogo/protobuf/teams","hooks_url":"https://api.github.com/repos/gogo/protobuf/hooks","issue_events_url":"https://api.github.com/repos/gogo/protobuf/issues/events{/number}","events_url":"https://api.github.com/repos/gogo/protobuf/events","assignees_url":"https://api.github.com/repos/gogo/protobuf/assignees{/user}","branches_url":"https://api.github.com/repos/gogo/protobuf/branches{/branch}","tags_url":"https://api.github.com/repos/gogo/protobuf/tags","blobs_url":"https://api.github.com/repos/gogo/protobuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gogo/protobuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gogo/protobuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/gogo/protobuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gogo/protobuf/statuses/{sha}","languages_url":"https://api.github.com/repos/gogo/protobuf/languages","stargazers_url":"https://api.github.com/repos/gogo/protobuf/stargazers","contributors_url":"https://api.github.com/repos/gogo/protobuf/contributors","subscribers_url":"https://api.github.com/repos/gogo/protobuf/subscribers","subscription_url":"https://api.github.com/repos/gogo/protobuf/subscription","commits_url":"https://api.github.com/repos/gogo/protobuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/gogo/protobuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/gogo/protobuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/gogo/protobuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/gogo/protobuf/contents/{+path}","compare_url":"https://api.github.com/repos/gogo/protobuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gogo/protobuf/merges","archive_url":"https://api.github.com/repos/gogo/protobuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gogo/protobuf/downloads","issues_url":"https://api.github.com/repos/gogo/protobuf/issues{/number}","pulls_url":"https://api.github.com/repos/gogo/protobuf/pulls{/number}","milestones_url":"https://api.github.com/repos/gogo/protobuf/milestones{/number}","notifications_url":"https://api.github.com/repos/gogo/protobuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gogo/protobuf/labels{/name}","releases_url":"https://api.github.com/repos/gogo/protobuf/releases{/id}","deployments_url":"https://api.github.com/repos/gogo/protobuf/deployments","created_at":"2014-12-03T11:27:10Z","updated_at":"2017-02-14T04:02:30Z","pushed_at":"2017-02-14T09:53:06Z","git_url":"git://github.com/gogo/protobuf.git","ssh_url":"git@github.com:gogo/protobuf.git","clone_url":"https://github.com/gogo/protobuf.git","svn_url":"https://github.com/gogo/protobuf","homepage":"","size":19840,"stargazers_count":771,"watchers_count":771,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":107,"mirror_url":null,"open_issues_count":39,"forks":107,"open_issues":39,"watchers":771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/258"},"html":{"href":"https://github.com/gogo/protobuf/pull/258"},"issue":{"href":"https://api.github.com/repos/gogo/protobuf/issues/258"},"comments":{"href":"https://api.github.com/repos/gogo/protobuf/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gogo/protobuf/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/gogo/protobuf/statuses/e88a2f42df1f252a75a4c5a2027770d942d4ac57"}}}}
|
{
"id": 27483832,
"name": "gogo/protobuf",
"url": "https://api.github.com/repos/gogo/protobuf"
}
|
{
"id": 1829933,
"login": "awalterschulze",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1829933?",
"url": "https://api.github.com/users/awalterschulze"
}
|
{
"id": 9958490,
"login": "gogo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9958490?",
"url": "https://api.github.com/orgs/gogo"
}
| 2017-02-14T10:05:40 |
5320300595
|
{"actor":{"display_login":"awalterschulze"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/136237698","pull_request_review_id":59746919,"id":136237698,"diff_hunk":"@@ -334,6 +365,7 @@ func main() {\n \t\tlen(maxConcurrentCalls), len(reqSizeBytes), len(respSizeBytes), len(enableCompressor)}\n \tinitalPos := make([]int, len(featuresPos))\n \ts := stats.NewStats(10)\n+\ts.SortLantency()","path":"benchmark/benchmain/main.go","position":null,"original_position":60,"commit_id":"408fcc6679cce4938884acbf377b3e68edb7dabf","original_commit_id":"5c63d896c4038ecda8cd3ac905f4343c5437599c","user":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-08-31T03:12:04Z","updated_at":"2017-08-31T03:12:04Z","html_url":"https://github.com/grpc/grpc-go/pull/1493#discussion_r136237698","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/136237698"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1493#discussion_r136237698"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493"}},"in_reply_to_id":136116419},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493","id":138309588,"html_url":"https://github.com/grpc/grpc-go/pull/1493","diff_url":"https://github.com/grpc/grpc-go/pull/1493.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1493.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1493","number":1493,"state":"open","locked":false,"title":"benchmain: format output of benchmark to a table","user":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"body":"The output will be a table with 5 columns: benchmark name, 50% latency, 90% lantency, Bytes per Alloc and number of Allocs.\r\n\r\nTo shorten the benchmark name, features shared by all test cases will be extracted and print ahead of the table.\r\n\r\nFor example,\r\n`go run benchmark/benchmain/main.go -benchtime=1s -workloads=all -compression=on -maxConcurrentCalls=1 -traceMode=false -reqSizeBytes=1,1048576 -respSizeBytes=1,1048576 -latency=0s -kbps=0 -mtu=0 -cpuProfile=cpuProf -memProfile=memProf -memProfileRate=10000`\r\nwill print\r\n```\r\n Shared festures: \r\n--------------------\r\nenable-tracing_false\r\nlatency_0s\r\nkbps_0\r\nMTU_0\r\nmaxConcurrentCalls_1\r\nCompressor_true\r\n\r\n------------------------------\r\nBenchmark Name \t50% latency \t90% latency \tBytes per Alloc \tNumber of Allocs\r\nUnary-reqSize_1B-respSize_1B : 242.4330 µs 301.6290 µs \t 11771 B/op\t 225 allocs/op \r\nStream-reqSize_1B-respSize_1B : 550.5400 µs 765.9560 µs \t 1172962 B/op\t 139 allocs/op \r\nUnary-reqSize_1B-respSize_1048576B : 4.1215 ms 4.7527 ms \t10553718 B/op\t 1338 allocs/op \r\nStream-reqSize_1B-respSize_1048576B : 12.9757 ms 17.6339 ms \t 9074074 B/op\t 173 allocs/op \r\nUnary-reqSize_1048576B-respSize_1B : 4.3785 ms 5.0291 ms \t10555464 B/op\t 1374 allocs/op \r\nStream-reqSize_1048576B-respSize_1B : 12.7951 ms 17.4144 ms \t 9068061 B/op\t 172 allocs/op \r\nUnary-reqSize_1048576B-respSize_1048576B : 8.1528 ms 9.2155 ms \t21096680 B/op\t 2467 allocs/op \r\nStream-reqSize_1048576B-respSize_1048576B : 29.4988 ms 33.5302 ms \t16610965 B/op\t 191 allocs/op\r\n```","created_at":"2017-08-29T23:55:24Z","updated_at":"2017-08-31T03:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732b009498d132b0371ff38b14a18c7d81da9349","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1493/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/408fcc6679cce4938884acbf377b3e68edb7dabf","head":{"label":"ZhouyihaiDing:column_output","ref":"column_output","sha":"408fcc6679cce4938884acbf377b3e68edb7dabf","user":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"repo":{"id":95264928,"name":"grpc-go","full_name":"ZhouyihaiDing/grpc-go","owner":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZhouyihaiDing/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go","forks_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/forks","keys_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/teams","hooks_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/events","assignees_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/tags","blobs_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/languages","stargazers_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/subscription","commits_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/merges","archive_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/downloads","issues_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/deployments","created_at":"2017-06-24T00:07:31Z","updated_at":"2017-06-24T00:07:33Z","pushed_at":"2017-08-31T03:09:56Z","git_url":"git://github.com/ZhouyihaiDing/grpc-go.git","ssh_url":"git@github.com:ZhouyihaiDing/grpc-go.git","clone_url":"https://github.com/ZhouyihaiDing/grpc-go.git","svn_url":"https://github.com/ZhouyihaiDing/grpc-go","homepage":"","size":4130,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"3a378f9deb683b3a7d282e3c75dc2a35fb042977","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2017-08-31T02:38:57Z","pushed_at":"2017-08-31T03:09:57Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":4041,"stargazers_count":3806,"watchers_count":3806,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":712,"mirror_url":null,"open_issues_count":100,"forks":712,"open_issues":100,"watchers":3806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1493"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1493"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/408fcc6679cce4938884acbf377b3e68edb7dabf"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27729907,
"name": "grpc/grpc-go",
"url": "https://api.github.com/repos/grpc/grpc-go"
}
|
{
"id": 28968539,
"login": "ZhouyihaiDing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28968539?",
"url": "https://api.github.com/users/ZhouyihaiDing"
}
|
{
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
}
| 2017-08-31T03:12:04 |
6533018016
|
{"actor":{"display_login":"ZhouyihaiDing"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/150196478","pull_request_review_id":75711645,"id":150196478,"diff_hunk":"@@ -748,12 +757,13 @@ static void create_rr_locked(grpc_exec_ctx* exec_ctx, glb_lb_policy* glb_policy,\n grpc_lb_policy_create(exec_ctx, \"round_robin\", args);\n if (new_rr_policy == NULL) {\n gpr_log(GPR_ERROR,\n- \"Failure creating a RoundRobin policy for serverlist update with \"\n- \"%lu entries. The previous RR instance (%p), if any, will continue \"\n- \"to be used. Future updates from the LB will attempt to create new \"\n+ \"[grpclb %p] Failure creating a RoundRobin policy for serverlist \"\n+ \"update with %\" PRIuPTR\n+ \" entries. The previous RR instance (%p), if any, will continue to \"","path":"src/core/ext/filters/client_channel/lb_policy/grpclb/grpclb.cc","position":89,"original_position":89,"commit_id":"59607907a84982bbbada0a4c2c10e890de915493","original_commit_id":"59607907a84982bbbada0a4c2c10e890de915493","user":{"login":"AspirinSJL","id":3314176,"avatar_url":"https://avatars0.githubusercontent.com/u/3314176?v=4","gravatar_id":"","url":"https://api.github.com/users/AspirinSJL","html_url":"https://github.com/AspirinSJL","followers_url":"https://api.github.com/users/AspirinSJL/followers","following_url":"https://api.github.com/users/AspirinSJL/following{/other_user}","gists_url":"https://api.github.com/users/AspirinSJL/gists{/gist_id}","starred_url":"https://api.github.com/users/AspirinSJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AspirinSJL/subscriptions","organizations_url":"https://api.github.com/users/AspirinSJL/orgs","repos_url":"https://api.github.com/users/AspirinSJL/repos","events_url":"https://api.github.com/users/AspirinSJL/events{/privacy}","received_events_url":"https://api.github.com/users/AspirinSJL/received_events","type":"User","site_admin":false},"body":"Nit: This line can be moved up to the end of the previous line.","created_at":"2017-11-10T10:08:13Z","updated_at":"2017-11-10T10:11:13Z","html_url":"https://github.com/grpc/grpc/pull/13332#discussion_r150196478","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/13332","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/150196478"},"html":{"href":"https://github.com/grpc/grpc/pull/13332#discussion_r150196478"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13332"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/13332","id":151730011,"html_url":"https://github.com/grpc/grpc/pull/13332","diff_url":"https://github.com/grpc/grpc/pull/13332.diff","patch_url":"https://github.com/grpc/grpc/pull/13332.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/13332","number":13332,"state":"open","locked":false,"title":"grpclb: Improved logging","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars3.githubusercontent.com/u/120217?v=4","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-09T18:38:23Z","updated_at":"2017-11-10T10:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b3656d12a1566c3a109e1f07f6a535303b04f33","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ctiller","id":10120821,"avatar_url":"https://avatars3.githubusercontent.com/u/10120821?v=4","gravatar_id":"","url":"https://api.github.com/users/ctiller","html_url":"https://github.com/ctiller","followers_url":"https://api.github.com/users/ctiller/followers","following_url":"https://api.github.com/users/ctiller/following{/other_user}","gists_url":"https://api.github.com/users/ctiller/gists{/gist_id}","starred_url":"https://api.github.com/users/ctiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctiller/subscriptions","organizations_url":"https://api.github.com/users/ctiller/orgs","repos_url":"https://api.github.com/users/ctiller/repos","events_url":"https://api.github.com/users/ctiller/events{/privacy}","received_events_url":"https://api.github.com/users/ctiller/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/13332/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/13332/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/13332/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/59607907a84982bbbada0a4c2c10e890de915493","head":{"label":"dgquintas:grpclb_better_logging","ref":"grpclb_better_logging","sha":"59607907a84982bbbada0a4c2c10e890de915493","user":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars3.githubusercontent.com/u/120217?v=4","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"repo":{"id":34546298,"name":"grpc","full_name":"dgquintas/grpc","owner":{"login":"dgquintas","id":120217,"avatar_url":"https://avatars3.githubusercontent.com/u/120217?v=4","gravatar_id":"","url":"https://api.github.com/users/dgquintas","html_url":"https://github.com/dgquintas","followers_url":"https://api.github.com/users/dgquintas/followers","following_url":"https://api.github.com/users/dgquintas/following{/other_user}","gists_url":"https://api.github.com/users/dgquintas/gists{/gist_id}","starred_url":"https://api.github.com/users/dgquintas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgquintas/subscriptions","organizations_url":"https://api.github.com/users/dgquintas/orgs","repos_url":"https://api.github.com/users/dgquintas/repos","events_url":"https://api.github.com/users/dgquintas/events{/privacy}","received_events_url":"https://api.github.com/users/dgquintas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgquintas/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/dgquintas/grpc","forks_url":"https://api.github.com/repos/dgquintas/grpc/forks","keys_url":"https://api.github.com/repos/dgquintas/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgquintas/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgquintas/grpc/teams","hooks_url":"https://api.github.com/repos/dgquintas/grpc/hooks","issue_events_url":"https://api.github.com/repos/dgquintas/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/dgquintas/grpc/events","assignees_url":"https://api.github.com/repos/dgquintas/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/dgquintas/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/dgquintas/grpc/tags","blobs_url":"https://api.github.com/repos/dgquintas/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgquintas/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgquintas/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgquintas/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgquintas/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/dgquintas/grpc/languages","stargazers_url":"https://api.github.com/repos/dgquintas/grpc/stargazers","contributors_url":"https://api.github.com/repos/dgquintas/grpc/contributors","subscribers_url":"https://api.github.com/repos/dgquintas/grpc/subscribers","subscription_url":"https://api.github.com/repos/dgquintas/grpc/subscription","commits_url":"https://api.github.com/repos/dgquintas/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgquintas/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgquintas/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgquintas/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgquintas/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/dgquintas/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgquintas/grpc/merges","archive_url":"https://api.github.com/repos/dgquintas/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgquintas/grpc/downloads","issues_url":"https://api.github.com/repos/dgquintas/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/dgquintas/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/dgquintas/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/dgquintas/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgquintas/grpc/labels{/name}","releases_url":"https://api.github.com/repos/dgquintas/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/dgquintas/grpc/deployments","created_at":"2015-04-24T23:07:11Z","updated_at":"2017-11-08T15:56:52Z","pushed_at":"2017-11-10T01:34:36Z","git_url":"git://github.com/dgquintas/grpc.git","ssh_url":"git@github.com:dgquintas/grpc.git","clone_url":"https://github.com/dgquintas/grpc.git","svn_url":"https://github.com/dgquintas/grpc","homepage":"","size":141738,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"forks":0,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"3a54b8673eed472679b11bb463cfcaf50ba6e282","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2017-11-10T07:05:09Z","pushed_at":"2017-11-10T08:00:38Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"","size":144841,"stargazers_count":12220,"watchers_count":12220,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2597,"mirror_url":null,"archived":false,"open_issues_count":1383,"forks":2597,"open_issues":1383,"watchers":12220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13332"},"html":{"href":"https://github.com/grpc/grpc/pull/13332"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/13332"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/13332/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13332/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/13332/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/59607907a84982bbbada0a4c2c10e890de915493"}},"author_association":"MEMBER"}}
|
{
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
}
|
{
"id": 3314176,
"login": "AspirinSJL",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3314176?",
"url": "https://api.github.com/users/AspirinSJL"
}
|
{
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
}
| 2017-11-10T10:08:13 |
6837029176
|
{"actor":{"display_login":"AspirinSJL"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/comments/107472239","pull_request_review_id":28447254,"id":107472239,"diff_hunk":"@@ -241,6 +241,14 @@ def install\n -DZLIB_LIBRARY=/usr/lib/libz.dylib\n ]\n \n+ # Compile with PGSQL\n+ cmake_args += %W[\n+ -DENABLE_EXTENSION_PGSQL=ON\n+ -DPGSQL_INCLUDE_DIR=/usr/local/opt/postgres/include\n+ -DPGSQL_LIBRARY=/usr/local/opt/postgres/lib/libpq.dylib\n+ ]\n+ inreplace \"hphp/runtime/ext/pgsql/pdo_pgsql_connection.cpp\", \"long\", \"int64_t\"","path":"hhvm.rb","position":10,"original_position":10,"commit_id":"f94e18989b76e539d51daafc923effb6022b5816","original_commit_id":"f94e18989b76e539d51daafc923effb6022b5816","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars1.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"body":"Yep, I have D4749714 up internally to fix this. (it's currently landing)","created_at":"2017-03-22T17:02:49Z","updated_at":"2017-03-22T17:02:49Z","html_url":"https://github.com/hhvm/homebrew-hhvm/pull/78#discussion_r107472239","pull_request_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/comments/107472239"},"html":{"href":"https://github.com/hhvm/homebrew-hhvm/pull/78#discussion_r107472239"},"pull_request":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78","id":111922332,"html_url":"https://github.com/hhvm/homebrew-hhvm/pull/78","diff_url":"https://github.com/hhvm/homebrew-hhvm/pull/78.diff","patch_url":"https://github.com/hhvm/homebrew-hhvm/pull/78.patch","issue_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/78","number":78,"state":"open","locked":false,"title":"Added PGSQL support","user":{"login":"ADPuckey","id":1147066,"avatar_url":"https://avatars2.githubusercontent.com/u/1147066?v=3","gravatar_id":"","url":"https://api.github.com/users/ADPuckey","html_url":"https://github.com/ADPuckey","followers_url":"https://api.github.com/users/ADPuckey/followers","following_url":"https://api.github.com/users/ADPuckey/following{/other_user}","gists_url":"https://api.github.com/users/ADPuckey/gists{/gist_id}","starred_url":"https://api.github.com/users/ADPuckey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADPuckey/subscriptions","organizations_url":"https://api.github.com/users/ADPuckey/orgs","repos_url":"https://api.github.com/users/ADPuckey/repos","events_url":"https://api.github.com/users/ADPuckey/events{/privacy}","received_events_url":"https://api.github.com/users/ADPuckey/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-22T02:52:26Z","updated_at":"2017-03-22T17:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a043e17d7fd0f4349cacd7c235261507b092bdae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78/commits","review_comments_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78/comments","review_comment_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/78/comments","statuses_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/statuses/f94e18989b76e539d51daafc923effb6022b5816","head":{"label":"ADPuckey:master","ref":"master","sha":"f94e18989b76e539d51daafc923effb6022b5816","user":{"login":"ADPuckey","id":1147066,"avatar_url":"https://avatars2.githubusercontent.com/u/1147066?v=3","gravatar_id":"","url":"https://api.github.com/users/ADPuckey","html_url":"https://github.com/ADPuckey","followers_url":"https://api.github.com/users/ADPuckey/followers","following_url":"https://api.github.com/users/ADPuckey/following{/other_user}","gists_url":"https://api.github.com/users/ADPuckey/gists{/gist_id}","starred_url":"https://api.github.com/users/ADPuckey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADPuckey/subscriptions","organizations_url":"https://api.github.com/users/ADPuckey/orgs","repos_url":"https://api.github.com/users/ADPuckey/repos","events_url":"https://api.github.com/users/ADPuckey/events{/privacy}","received_events_url":"https://api.github.com/users/ADPuckey/received_events","type":"User","site_admin":false},"repo":{"id":85777706,"name":"homebrew-hhvm","full_name":"ADPuckey/homebrew-hhvm","owner":{"login":"ADPuckey","id":1147066,"avatar_url":"https://avatars2.githubusercontent.com/u/1147066?v=3","gravatar_id":"","url":"https://api.github.com/users/ADPuckey","html_url":"https://github.com/ADPuckey","followers_url":"https://api.github.com/users/ADPuckey/followers","following_url":"https://api.github.com/users/ADPuckey/following{/other_user}","gists_url":"https://api.github.com/users/ADPuckey/gists{/gist_id}","starred_url":"https://api.github.com/users/ADPuckey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ADPuckey/subscriptions","organizations_url":"https://api.github.com/users/ADPuckey/orgs","repos_url":"https://api.github.com/users/ADPuckey/repos","events_url":"https://api.github.com/users/ADPuckey/events{/privacy}","received_events_url":"https://api.github.com/users/ADPuckey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ADPuckey/homebrew-hhvm","description":"Official Mac OS X Homebrew formula for HHVM","fork":true,"url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm","forks_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/forks","keys_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/teams","hooks_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/hooks","issue_events_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/events","assignees_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/tags","blobs_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/languages","stargazers_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/stargazers","contributors_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/contributors","subscribers_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/subscribers","subscription_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/subscription","commits_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/merges","archive_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/downloads","issues_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/labels{/name}","releases_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/releases{/id}","deployments_url":"https://api.github.com/repos/ADPuckey/homebrew-hhvm/deployments","created_at":"2017-03-22T02:49:28Z","updated_at":"2017-03-22T02:49:29Z","pushed_at":"2017-03-22T02:50:47Z","git_url":"git://github.com/ADPuckey/homebrew-hhvm.git","ssh_url":"git@github.com:ADPuckey/homebrew-hhvm.git","clone_url":"https://github.com/ADPuckey/homebrew-hhvm.git","svn_url":"https://github.com/ADPuckey/homebrew-hhvm","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hhvm:master","ref":"master","sha":"2ef659329e15bd95ae5b711cfccb5c018555d5d5","user":{"login":"hhvm","id":4553654,"avatar_url":"https://avatars3.githubusercontent.com/u/4553654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhvm","html_url":"https://github.com/hhvm","followers_url":"https://api.github.com/users/hhvm/followers","following_url":"https://api.github.com/users/hhvm/following{/other_user}","gists_url":"https://api.github.com/users/hhvm/gists{/gist_id}","starred_url":"https://api.github.com/users/hhvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhvm/subscriptions","organizations_url":"https://api.github.com/users/hhvm/orgs","repos_url":"https://api.github.com/users/hhvm/repos","events_url":"https://api.github.com/users/hhvm/events{/privacy}","received_events_url":"https://api.github.com/users/hhvm/received_events","type":"Organization","site_admin":false},"repo":{"id":41442992,"name":"homebrew-hhvm","full_name":"hhvm/homebrew-hhvm","owner":{"login":"hhvm","id":4553654,"avatar_url":"https://avatars3.githubusercontent.com/u/4553654?v=3","gravatar_id":"","url":"https://api.github.com/users/hhvm","html_url":"https://github.com/hhvm","followers_url":"https://api.github.com/users/hhvm/followers","following_url":"https://api.github.com/users/hhvm/following{/other_user}","gists_url":"https://api.github.com/users/hhvm/gists{/gist_id}","starred_url":"https://api.github.com/users/hhvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hhvm/subscriptions","organizations_url":"https://api.github.com/users/hhvm/orgs","repos_url":"https://api.github.com/users/hhvm/repos","events_url":"https://api.github.com/users/hhvm/events{/privacy}","received_events_url":"https://api.github.com/users/hhvm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hhvm/homebrew-hhvm","description":"Official Mac OS X Homebrew formula for HHVM","fork":false,"url":"https://api.github.com/repos/hhvm/homebrew-hhvm","forks_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/forks","keys_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/teams","hooks_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/hooks","issue_events_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/events","assignees_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/tags","blobs_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/languages","stargazers_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/stargazers","contributors_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/contributors","subscribers_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/subscribers","subscription_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/subscription","commits_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/merges","archive_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/downloads","issues_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/labels{/name}","releases_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/releases{/id}","deployments_url":"https://api.github.com/repos/hhvm/homebrew-hhvm/deployments","created_at":"2015-08-26T18:33:42Z","updated_at":"2017-03-10T22:46:16Z","pushed_at":"2017-03-22T02:52:27Z","git_url":"git://github.com/hhvm/homebrew-hhvm.git","ssh_url":"git@github.com:hhvm/homebrew-hhvm.git","clone_url":"https://github.com/hhvm/homebrew-hhvm.git","svn_url":"https://github.com/hhvm/homebrew-hhvm","homepage":null,"size":43,"stargazers_count":50,"watchers_count":50,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":11,"forks":15,"open_issues":11,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78"},"html":{"href":"https://github.com/hhvm/homebrew-hhvm/pull/78"},"issue":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/78"},"comments":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/hhvm/homebrew-hhvm/statuses/f94e18989b76e539d51daafc923effb6022b5816"}}}}
|
{
"id": 41442992,
"name": "hhvm/homebrew-hhvm",
"url": "https://api.github.com/repos/hhvm/homebrew-hhvm"
}
|
{
"id": 709247,
"login": "Orvid",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/709247?",
"url": "https://api.github.com/users/Orvid"
}
|
{
"id": 4553654,
"login": "hhvm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4553654?",
"url": "https://api.github.com/orgs/hhvm"
}
| 2017-03-22T17:02:49 |
5543491967
|
{"actor":{"display_login":"Orvid"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/comments/142434567","pull_request_review_id":66792979,"id":142434567,"diff_hunk":"@@ -0,0 +1,37 @@\n+\n+package stubs\n+\n+import com.github.tomakehurst.wiremock.stubbing.StubMapping\n+import common.Constants.MTD_VAT_ENROLMENT_KEY\n+import play.api.http.Status._\n+import play.api.libs.json.{JsObject, Json}\n+\n+object AuthStub extends WireMockMethods {\n+\n+ private val authoriseUri = \"/auth/authorise\"\n+\n+ def stubAuthSuccess(): StubMapping = {\n+ when(method = POST, uri = authoriseUri)\n+ .thenReturn(status = OK, body = successfulAuthResponse(mtdVatEnrolment))\n+ }\n+\n+ def stubUnauthorised(): StubMapping = {\n+ when(method = POST, uri = authoriseUri)\n+ .thenReturn(status = UNAUTHORIZED, headers = Map(\"WWW-Authenticate\" -> \"\"\"MDTP detail=\"MissingBearerToken\"\"\"\"))\n+ }\n+\n+ private val mtdVatEnrolment = Json.obj(\n+ \"key\" -> MTD_VAT_ENROLMENT_KEY,\n+ \"identifiers\" -> Json.arr(\n+ Json.obj(\n+ \"key\" -> \"MtdVatId\",\n+ \"value\" -> \"ChazDingle\"","path":"it/stubs/AuthStub.scala","position":28,"original_position":28,"commit_id":"c9c0d0e797c493c90438cd648c6b6cc216d8ddd8","original_commit_id":"c9c0d0e797c493c90438cd648c6b6cc216d8ddd8","user":{"login":"miranda-hawkes","id":17408278,"avatar_url":"https://avatars3.githubusercontent.com/u/17408278?v=4","gravatar_id":"","url":"https://api.github.com/users/miranda-hawkes","html_url":"https://github.com/miranda-hawkes","followers_url":"https://api.github.com/users/miranda-hawkes/followers","following_url":"https://api.github.com/users/miranda-hawkes/following{/other_user}","gists_url":"https://api.github.com/users/miranda-hawkes/gists{/gist_id}","starred_url":"https://api.github.com/users/miranda-hawkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranda-hawkes/subscriptions","organizations_url":"https://api.github.com/users/miranda-hawkes/orgs","repos_url":"https://api.github.com/users/miranda-hawkes/repos","events_url":"https://api.github.com/users/miranda-hawkes/events{/privacy}","received_events_url":"https://api.github.com/users/miranda-hawkes/received_events","type":"User","site_admin":false},"body":"Given this is an open-source repo, please could you replace this with something meaningful and sensible :laughing: ","created_at":"2017-10-03T15:22:49Z","updated_at":"2017-10-03T15:31:08Z","html_url":"https://github.com/hmrc/view-vat-returns-frontend/pull/13#discussion_r142434567","pull_request_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/comments/142434567"},"html":{"href":"https://github.com/hmrc/view-vat-returns-frontend/pull/13#discussion_r142434567"},"pull_request":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13","id":143889655,"html_url":"https://github.com/hmrc/view-vat-returns-frontend/pull/13","diff_url":"https://github.com/hmrc/view-vat-returns-frontend/pull/13.diff","patch_url":"https://github.com/hmrc/view-vat-returns-frontend/pull/13.patch","issue_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/13","number":13,"state":"open","locked":false,"title":"Btat 595","user":{"login":"WilliamJohnathonLea","id":18347292,"avatar_url":"https://avatars1.githubusercontent.com/u/18347292?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamJohnathonLea","html_url":"https://github.com/WilliamJohnathonLea","followers_url":"https://api.github.com/users/WilliamJohnathonLea/followers","following_url":"https://api.github.com/users/WilliamJohnathonLea/following{/other_user}","gists_url":"https://api.github.com/users/WilliamJohnathonLea/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamJohnathonLea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamJohnathonLea/subscriptions","organizations_url":"https://api.github.com/users/WilliamJohnathonLea/orgs","repos_url":"https://api.github.com/users/WilliamJohnathonLea/repos","events_url":"https://api.github.com/users/WilliamJohnathonLea/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamJohnathonLea/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-29T13:33:33Z","updated_at":"2017-10-03T15:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11c3bbaaae4664663fd10f7eff396a903056cf05","assignee":{"login":"miranda-hawkes","id":17408278,"avatar_url":"https://avatars3.githubusercontent.com/u/17408278?v=4","gravatar_id":"","url":"https://api.github.com/users/miranda-hawkes","html_url":"https://github.com/miranda-hawkes","followers_url":"https://api.github.com/users/miranda-hawkes/followers","following_url":"https://api.github.com/users/miranda-hawkes/following{/other_user}","gists_url":"https://api.github.com/users/miranda-hawkes/gists{/gist_id}","starred_url":"https://api.github.com/users/miranda-hawkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranda-hawkes/subscriptions","organizations_url":"https://api.github.com/users/miranda-hawkes/orgs","repos_url":"https://api.github.com/users/miranda-hawkes/repos","events_url":"https://api.github.com/users/miranda-hawkes/events{/privacy}","received_events_url":"https://api.github.com/users/miranda-hawkes/received_events","type":"User","site_admin":false},"assignees":[{"login":"miranda-hawkes","id":17408278,"avatar_url":"https://avatars3.githubusercontent.com/u/17408278?v=4","gravatar_id":"","url":"https://api.github.com/users/miranda-hawkes","html_url":"https://github.com/miranda-hawkes","followers_url":"https://api.github.com/users/miranda-hawkes/followers","following_url":"https://api.github.com/users/miranda-hawkes/following{/other_user}","gists_url":"https://api.github.com/users/miranda-hawkes/gists{/gist_id}","starred_url":"https://api.github.com/users/miranda-hawkes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miranda-hawkes/subscriptions","organizations_url":"https://api.github.com/users/miranda-hawkes/orgs","repos_url":"https://api.github.com/users/miranda-hawkes/repos","events_url":"https://api.github.com/users/miranda-hawkes/events{/privacy}","received_events_url":"https://api.github.com/users/miranda-hawkes/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13/commits","review_comments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13/comments","review_comment_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/13/comments","statuses_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/statuses/c9c0d0e797c493c90438cd648c6b6cc216d8ddd8","head":{"label":"hmrc:BTAT-595","ref":"BTAT-595","sha":"c9c0d0e797c493c90438cd648c6b6cc216d8ddd8","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":101051034,"name":"view-vat-returns-frontend","full_name":"hmrc/view-vat-returns-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/view-vat-returns-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend","forks_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/deployments","created_at":"2017-08-22T10:25:41Z","updated_at":"2017-08-23T08:11:22Z","pushed_at":"2017-10-03T12:54:15Z","git_url":"git://github.com/hmrc/view-vat-returns-frontend.git","ssh_url":"git@github.com:hmrc/view-vat-returns-frontend.git","clone_url":"https://github.com/hmrc/view-vat-returns-frontend.git","svn_url":"https://github.com/hmrc/view-vat-returns-frontend","homepage":"","size":86,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"8a717fc15e9041a41ccbe8cd94fe59d15a862579","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":101051034,"name":"view-vat-returns-frontend","full_name":"hmrc/view-vat-returns-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/view-vat-returns-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend","forks_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/deployments","created_at":"2017-08-22T10:25:41Z","updated_at":"2017-08-23T08:11:22Z","pushed_at":"2017-10-03T12:54:15Z","git_url":"git://github.com/hmrc/view-vat-returns-frontend.git","ssh_url":"git@github.com:hmrc/view-vat-returns-frontend.git","clone_url":"https://github.com/hmrc/view-vat-returns-frontend.git","svn_url":"https://github.com/hmrc/view-vat-returns-frontend","homepage":"","size":86,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13"},"html":{"href":"https://github.com/hmrc/view-vat-returns-frontend/pull/13"},"issue":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/13"},"comments":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/view-vat-returns-frontend/statuses/c9c0d0e797c493c90438cd648c6b6cc216d8ddd8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101051034,
"name": "hmrc/view-vat-returns-frontend",
"url": "https://api.github.com/repos/hmrc/view-vat-returns-frontend"
}
|
{
"id": 17408278,
"login": "miranda-hawkes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17408278?",
"url": "https://api.github.com/users/miranda-hawkes"
}
|
{
"id": 5755339,
"login": "hmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5755339?",
"url": "https://api.github.com/orgs/hmrc"
}
| 2017-10-03T15:22:49 |
6668349563
|
{"actor":{"display_login":"miranda-hawkes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/comments/137549146","pull_request_review_id":61232099,"id":137549146,"diff_hunk":"@@ -0,0 +1,216 @@\n+/*\n+ * Copyright 2017 HM Revenue & Customs\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package controllers.matching\n+\n+import assets.MessageLookup.{UserDetails => messages}\n+import controllers.{ControllerBaseSpec, ITSASessionKeys}\n+import forms.UserDetailsForm\n+import models.DateModel\n+import models.matching.UserDetailsModel\n+import org.jsoup.Jsoup\n+import play.api.http.Status\n+import play.api.mvc.{Action, AnyContent}\n+import play.api.test.Helpers.{await, contentAsString, contentType, _}\n+import services.mocks.{MockKeystoreService, MockUserLockoutService}\n+import uk.gov.hmrc.play.http.{HttpResponse, SessionKeys}\n+import utils.TestConstants._\n+import utils.TestModels._\n+\n+\n+class UserDetailsControllerSpec extends ControllerBaseSpec\n+ with MockKeystoreService\n+ with MockUserLockoutService {\n+\n+ override val controllerName: String = \"ClientDetailsController\"\n+ override val authorisedRoutes: Map[String, Action[AnyContent]] = Map(\n+ \"show\" -> TestUserDetailsController.show(isEditMode = false),\n+ \"submit\" -> TestUserDetailsController.submit(isEditMode = false)\n+ )\n+\n+ object TestUserDetailsController extends UserDetailsController(\n+ MockBaseControllerConfig,\n+ messagesApi,\n+ MockKeystoreService,\n+ mockAuthService,\n+ mockUserLockoutService\n+ )\n+ lazy val request = fakeRequest.withSession(SessionKeys.token -> testToken, ITSASessionKeys.GoHome -> \"et\")\n+\n+ \"Calling the show action of the ClientDetailsController with an authorised user\" should {\n+ lazy val result = await(TestUserDetailsController.show(isEditMode = false)(request))\n+\n+ \"return ok (200)\" in {\n+ setupMockKeystore(fetchUserDetails = None)\n+ setupMockNotLockedOut(testToken)\n+\n+ status(result) must be(Status.OK)\n+\n+ verifyKeystore(fetchUserDetails = 1, saveUserDetails = 0, deleteAll = 0)\n+\n+ contentType(result) must be(Some(\"text/html\"))\n+ charset(result) must be(Some(\"utf-8\"))\n+\n+ val document = Jsoup.parse(contentAsString(result))\n+ document.title mustBe messages.title\n+ }\n+ }\n+\n+\n+ for (editMode <- Seq(true, false)) {\n+\n+ s\"when editMode=$editMode and\" when {\n+\n+ \"Calling the submit action of the ClientDetailsController with an authorised user and valid submission and\" when {","path":"test/controllers/matching/UserDetailsControllerSpec.scala","position":77,"original_position":77,"commit_id":"f32e44b89e9061646772cbc44a1ca17791cc576e","original_commit_id":"f32e44b89e9061646772cbc44a1ca17791cc576e","user":{"login":"JSJohal","id":22663194,"avatar_url":"https://avatars0.githubusercontent.com/u/22663194?v=4","gravatar_id":"","url":"https://api.github.com/users/JSJohal","html_url":"https://github.com/JSJohal","followers_url":"https://api.github.com/users/JSJohal/followers","following_url":"https://api.github.com/users/JSJohal/following{/other_user}","gists_url":"https://api.github.com/users/JSJohal/gists{/gist_id}","starred_url":"https://api.github.com/users/JSJohal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JSJohal/subscriptions","organizations_url":"https://api.github.com/users/JSJohal/orgs","repos_url":"https://api.github.com/users/JSJohal/repos","events_url":"https://api.github.com/users/JSJohal/events{/privacy}","received_events_url":"https://api.github.com/users/JSJohal/received_events","type":"User","site_admin":false},"body":"change string?","created_at":"2017-09-07T14:09:56Z","updated_at":"2017-09-07T14:09:56Z","html_url":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201#discussion_r137549146","pull_request_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/comments/137549146"},"html":{"href":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201#discussion_r137549146"},"pull_request":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201","id":139795757,"html_url":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201","diff_url":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201.diff","patch_url":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201.patch","issue_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/201","number":201,"state":"open","locked":false,"title":"SAR-907 - Copy over user matching functionality","user":{"login":"kabuumu","id":17453872,"avatar_url":"https://avatars1.githubusercontent.com/u/17453872?v=4","gravatar_id":"","url":"https://api.github.com/users/kabuumu","html_url":"https://github.com/kabuumu","followers_url":"https://api.github.com/users/kabuumu/followers","following_url":"https://api.github.com/users/kabuumu/following{/other_user}","gists_url":"https://api.github.com/users/kabuumu/gists{/gist_id}","starred_url":"https://api.github.com/users/kabuumu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabuumu/subscriptions","organizations_url":"https://api.github.com/users/kabuumu/orgs","repos_url":"https://api.github.com/users/kabuumu/repos","events_url":"https://api.github.com/users/kabuumu/events{/privacy}","received_events_url":"https://api.github.com/users/kabuumu/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-07T12:46:05Z","updated_at":"2017-09-07T14:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8dbbccb6763c1dbcd13d1d82ec655de228e1952","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201/commits","review_comments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201/comments","review_comment_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/201/comments","statuses_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/statuses/f32e44b89e9061646772cbc44a1ca17791cc576e","head":{"label":"hmrc:SAR-907","ref":"SAR-907","sha":"f32e44b89e9061646772cbc44a1ca17791cc576e","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":75821123,"name":"income-tax-subscription-frontend","full_name":"hmrc/income-tax-subscription-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/income-tax-subscription-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend","forks_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/deployments","created_at":"2016-12-07T09:35:56Z","updated_at":"2016-12-07T10:00:40Z","pushed_at":"2017-09-07T13:20:20Z","git_url":"git://github.com/hmrc/income-tax-subscription-frontend.git","ssh_url":"git@github.com:hmrc/income-tax-subscription-frontend.git","clone_url":"https://github.com/hmrc/income-tax-subscription-frontend.git","svn_url":"https://github.com/hmrc/income-tax-subscription-frontend","homepage":"","size":1532,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"67d0b947e869f113afda8170fe3e57c4d3e609a6","user":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":75821123,"name":"income-tax-subscription-frontend","full_name":"hmrc/income-tax-subscription-frontend","owner":{"login":"hmrc","id":5755339,"avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/income-tax-subscription-frontend","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend","forks_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/forks","keys_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/teams","hooks_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/events","assignees_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/tags","blobs_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/languages","stargazers_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/subscription","commits_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/merges","archive_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/downloads","issues_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/deployments","created_at":"2016-12-07T09:35:56Z","updated_at":"2016-12-07T10:00:40Z","pushed_at":"2017-09-07T13:20:20Z","git_url":"git://github.com/hmrc/income-tax-subscription-frontend.git","ssh_url":"git@github.com:hmrc/income-tax-subscription-frontend.git","clone_url":"https://github.com/hmrc/income-tax-subscription-frontend.git","svn_url":"https://github.com/hmrc/income-tax-subscription-frontend","homepage":"","size":1532,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201"},"html":{"href":"https://github.com/hmrc/income-tax-subscription-frontend/pull/201"},"issue":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/201"},"comments":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/income-tax-subscription-frontend/statuses/f32e44b89e9061646772cbc44a1ca17791cc576e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 75821123,
"name": "hmrc/income-tax-subscription-frontend",
"url": "https://api.github.com/repos/hmrc/income-tax-subscription-frontend"
}
|
{
"id": 22663194,
"login": "JSJohal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22663194?",
"url": "https://api.github.com/users/JSJohal"
}
|
{
"id": 5755339,
"login": "hmrc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5755339?",
"url": "https://api.github.com/orgs/hmrc"
}
| 2017-09-07T14:09:56 |
6561691104
|
{"actor":{"display_login":"JSJohal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/loot/skyrimse/pulls/comments/138182469","pull_request_review_id":61945783,"id":138182469,"diff_hunk":"@@ -401,6 +404,12 @@ plugins:\n - 'SoS - The Wilds.esp'\n - 'SoS - The Dungeons.esp'\n - 'SoS - Civilization.esp'\n+ tag:\n+ - C.Location\n+ - C.Owner\n+ - C.Regions\n+ - C.Water\n+ - Graphics","path":"masterlist.yaml","position":null,"original_position":19,"commit_id":"e023673fff1d8ed98aa97145330f3a4781a75386","original_commit_id":"d8dd84e5b146cf95500cfc0533287e496e81675e","user":{"login":"BeermotorWB","id":30019823,"avatar_url":"https://avatars0.githubusercontent.com/u/30019823?v=4","gravatar_id":"","url":"https://api.github.com/users/BeermotorWB","html_url":"https://github.com/BeermotorWB","followers_url":"https://api.github.com/users/BeermotorWB/followers","following_url":"https://api.github.com/users/BeermotorWB/following{/other_user}","gists_url":"https://api.github.com/users/BeermotorWB/gists{/gist_id}","starred_url":"https://api.github.com/users/BeermotorWB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeermotorWB/subscriptions","organizations_url":"https://api.github.com/users/BeermotorWB/orgs","repos_url":"https://api.github.com/users/BeermotorWB/repos","events_url":"https://api.github.com/users/BeermotorWB/events{/privacy}","received_events_url":"https://api.github.com/users/BeermotorWB/received_events","type":"User","site_admin":false},"body":"OK it's raining sideways here but I figured out the C.Owner tag on RWT: the plugin sets player ownership of a RWT-placed horse trough (RWT_HorseTrough) in the various Hearthfires homes. \r\n\r\nIt'll probably be fine to leave it out. If we ever hear of anything clobbering the RWT Horse Troughs we can add it back.","created_at":"2017-09-11T20:30:12Z","updated_at":"2017-09-11T20:30:12Z","html_url":"https://github.com/loot/skyrimse/pull/45#discussion_r138182469","pull_request_url":"https://api.github.com/repos/loot/skyrimse/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/comments/138182469"},"html":{"href":"https://github.com/loot/skyrimse/pull/45#discussion_r138182469"},"pull_request":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/45"}},"in_reply_to_id":138058201},"pull_request":{"url":"https://api.github.com/repos/loot/skyrimse/pulls/45","id":140205807,"html_url":"https://github.com/loot/skyrimse/pull/45","diff_url":"https://github.com/loot/skyrimse/pull/45.diff","patch_url":"https://github.com/loot/skyrimse/pull/45.patch","issue_url":"https://api.github.com/repos/loot/skyrimse/issues/45","number":45,"state":"open","locked":false,"title":"Bash tag adds","user":{"login":"BeermotorWB","id":30019823,"avatar_url":"https://avatars0.githubusercontent.com/u/30019823?v=4","gravatar_id":"","url":"https://api.github.com/users/BeermotorWB","html_url":"https://github.com/BeermotorWB","followers_url":"https://api.github.com/users/BeermotorWB/followers","following_url":"https://api.github.com/users/BeermotorWB/following{/other_user}","gists_url":"https://api.github.com/users/BeermotorWB/gists{/gist_id}","starred_url":"https://api.github.com/users/BeermotorWB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeermotorWB/subscriptions","organizations_url":"https://api.github.com/users/BeermotorWB/orgs","repos_url":"https://api.github.com/users/BeermotorWB/repos","events_url":"https://api.github.com/users/BeermotorWB/events{/privacy}","received_events_url":"https://api.github.com/users/BeermotorWB/received_events","type":"User","site_admin":false},"body":"Added bash tags for several extant and new plugins. ","created_at":"2017-09-10T11:48:31Z","updated_at":"2017-09-11T20:30:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85a06c6c61cee0e43a21a0def4fc58ddbf26fe11","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/loot/skyrimse/pulls/45/commits","review_comments_url":"https://api.github.com/repos/loot/skyrimse/pulls/45/comments","review_comment_url":"https://api.github.com/repos/loot/skyrimse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loot/skyrimse/issues/45/comments","statuses_url":"https://api.github.com/repos/loot/skyrimse/statuses/e023673fff1d8ed98aa97145330f3a4781a75386","head":{"label":"BeermotorWB:v0.10","ref":"v0.10","sha":"e023673fff1d8ed98aa97145330f3a4781a75386","user":{"login":"BeermotorWB","id":30019823,"avatar_url":"https://avatars0.githubusercontent.com/u/30019823?v=4","gravatar_id":"","url":"https://api.github.com/users/BeermotorWB","html_url":"https://github.com/BeermotorWB","followers_url":"https://api.github.com/users/BeermotorWB/followers","following_url":"https://api.github.com/users/BeermotorWB/following{/other_user}","gists_url":"https://api.github.com/users/BeermotorWB/gists{/gist_id}","starred_url":"https://api.github.com/users/BeermotorWB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeermotorWB/subscriptions","organizations_url":"https://api.github.com/users/BeermotorWB/orgs","repos_url":"https://api.github.com/users/BeermotorWB/repos","events_url":"https://api.github.com/users/BeermotorWB/events{/privacy}","received_events_url":"https://api.github.com/users/BeermotorWB/received_events","type":"User","site_admin":false},"repo":{"id":102470158,"name":"skyrimse","full_name":"BeermotorWB/skyrimse","owner":{"login":"BeermotorWB","id":30019823,"avatar_url":"https://avatars0.githubusercontent.com/u/30019823?v=4","gravatar_id":"","url":"https://api.github.com/users/BeermotorWB","html_url":"https://github.com/BeermotorWB","followers_url":"https://api.github.com/users/BeermotorWB/followers","following_url":"https://api.github.com/users/BeermotorWB/following{/other_user}","gists_url":"https://api.github.com/users/BeermotorWB/gists{/gist_id}","starred_url":"https://api.github.com/users/BeermotorWB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeermotorWB/subscriptions","organizations_url":"https://api.github.com/users/BeermotorWB/orgs","repos_url":"https://api.github.com/users/BeermotorWB/repos","events_url":"https://api.github.com/users/BeermotorWB/events{/privacy}","received_events_url":"https://api.github.com/users/BeermotorWB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BeermotorWB/skyrimse","description":"The TES V: Skyrim Special Edition masterlist.","fork":true,"url":"https://api.github.com/repos/BeermotorWB/skyrimse","forks_url":"https://api.github.com/repos/BeermotorWB/skyrimse/forks","keys_url":"https://api.github.com/repos/BeermotorWB/skyrimse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BeermotorWB/skyrimse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BeermotorWB/skyrimse/teams","hooks_url":"https://api.github.com/repos/BeermotorWB/skyrimse/hooks","issue_events_url":"https://api.github.com/repos/BeermotorWB/skyrimse/issues/events{/number}","events_url":"https://api.github.com/repos/BeermotorWB/skyrimse/events","assignees_url":"https://api.github.com/repos/BeermotorWB/skyrimse/assignees{/user}","branches_url":"https://api.github.com/repos/BeermotorWB/skyrimse/branches{/branch}","tags_url":"https://api.github.com/repos/BeermotorWB/skyrimse/tags","blobs_url":"https://api.github.com/repos/BeermotorWB/skyrimse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BeermotorWB/skyrimse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BeermotorWB/skyrimse/git/refs{/sha}","trees_url":"https://api.github.com/repos/BeermotorWB/skyrimse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BeermotorWB/skyrimse/statuses/{sha}","languages_url":"https://api.github.com/repos/BeermotorWB/skyrimse/languages","stargazers_url":"https://api.github.com/repos/BeermotorWB/skyrimse/stargazers","contributors_url":"https://api.github.com/repos/BeermotorWB/skyrimse/contributors","subscribers_url":"https://api.github.com/repos/BeermotorWB/skyrimse/subscribers","subscription_url":"https://api.github.com/repos/BeermotorWB/skyrimse/subscription","commits_url":"https://api.github.com/repos/BeermotorWB/skyrimse/commits{/sha}","git_commits_url":"https://api.github.com/repos/BeermotorWB/skyrimse/git/commits{/sha}","comments_url":"https://api.github.com/repos/BeermotorWB/skyrimse/comments{/number}","issue_comment_url":"https://api.github.com/repos/BeermotorWB/skyrimse/issues/comments{/number}","contents_url":"https://api.github.com/repos/BeermotorWB/skyrimse/contents/{+path}","compare_url":"https://api.github.com/repos/BeermotorWB/skyrimse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BeermotorWB/skyrimse/merges","archive_url":"https://api.github.com/repos/BeermotorWB/skyrimse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BeermotorWB/skyrimse/downloads","issues_url":"https://api.github.com/repos/BeermotorWB/skyrimse/issues{/number}","pulls_url":"https://api.github.com/repos/BeermotorWB/skyrimse/pulls{/number}","milestones_url":"https://api.github.com/repos/BeermotorWB/skyrimse/milestones{/number}","notifications_url":"https://api.github.com/repos/BeermotorWB/skyrimse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BeermotorWB/skyrimse/labels{/name}","releases_url":"https://api.github.com/repos/BeermotorWB/skyrimse/releases{/id}","deployments_url":"https://api.github.com/repos/BeermotorWB/skyrimse/deployments","created_at":"2017-09-05T10:54:43Z","updated_at":"2017-06-09T17:38:09Z","pushed_at":"2017-09-11T14:57:05Z","git_url":"git://github.com/BeermotorWB/skyrimse.git","ssh_url":"git@github.com:BeermotorWB/skyrimse.git","clone_url":"https://github.com/BeermotorWB/skyrimse.git","svn_url":"https://github.com/BeermotorWB/skyrimse","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0.10"}},"base":{"label":"loot:v0.10","ref":"v0.10","sha":"5cfef9c7176b401b22e3d3ad4b9995d1ca727986","user":{"login":"loot","id":6802491,"avatar_url":"https://avatars2.githubusercontent.com/u/6802491?v=4","gravatar_id":"","url":"https://api.github.com/users/loot","html_url":"https://github.com/loot","followers_url":"https://api.github.com/users/loot/followers","following_url":"https://api.github.com/users/loot/following{/other_user}","gists_url":"https://api.github.com/users/loot/gists{/gist_id}","starred_url":"https://api.github.com/users/loot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loot/subscriptions","organizations_url":"https://api.github.com/users/loot/orgs","repos_url":"https://api.github.com/users/loot/repos","events_url":"https://api.github.com/users/loot/events{/privacy}","received_events_url":"https://api.github.com/users/loot/received_events","type":"Organization","site_admin":false},"repo":{"id":72236811,"name":"skyrimse","full_name":"loot/skyrimse","owner":{"login":"loot","id":6802491,"avatar_url":"https://avatars2.githubusercontent.com/u/6802491?v=4","gravatar_id":"","url":"https://api.github.com/users/loot","html_url":"https://github.com/loot","followers_url":"https://api.github.com/users/loot/followers","following_url":"https://api.github.com/users/loot/following{/other_user}","gists_url":"https://api.github.com/users/loot/gists{/gist_id}","starred_url":"https://api.github.com/users/loot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loot/subscriptions","organizations_url":"https://api.github.com/users/loot/orgs","repos_url":"https://api.github.com/users/loot/repos","events_url":"https://api.github.com/users/loot/events{/privacy}","received_events_url":"https://api.github.com/users/loot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loot/skyrimse","description":"The TES V: Skyrim Special Edition masterlist.","fork":false,"url":"https://api.github.com/repos/loot/skyrimse","forks_url":"https://api.github.com/repos/loot/skyrimse/forks","keys_url":"https://api.github.com/repos/loot/skyrimse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loot/skyrimse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loot/skyrimse/teams","hooks_url":"https://api.github.com/repos/loot/skyrimse/hooks","issue_events_url":"https://api.github.com/repos/loot/skyrimse/issues/events{/number}","events_url":"https://api.github.com/repos/loot/skyrimse/events","assignees_url":"https://api.github.com/repos/loot/skyrimse/assignees{/user}","branches_url":"https://api.github.com/repos/loot/skyrimse/branches{/branch}","tags_url":"https://api.github.com/repos/loot/skyrimse/tags","blobs_url":"https://api.github.com/repos/loot/skyrimse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loot/skyrimse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loot/skyrimse/git/refs{/sha}","trees_url":"https://api.github.com/repos/loot/skyrimse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loot/skyrimse/statuses/{sha}","languages_url":"https://api.github.com/repos/loot/skyrimse/languages","stargazers_url":"https://api.github.com/repos/loot/skyrimse/stargazers","contributors_url":"https://api.github.com/repos/loot/skyrimse/contributors","subscribers_url":"https://api.github.com/repos/loot/skyrimse/subscribers","subscription_url":"https://api.github.com/repos/loot/skyrimse/subscription","commits_url":"https://api.github.com/repos/loot/skyrimse/commits{/sha}","git_commits_url":"https://api.github.com/repos/loot/skyrimse/git/commits{/sha}","comments_url":"https://api.github.com/repos/loot/skyrimse/comments{/number}","issue_comment_url":"https://api.github.com/repos/loot/skyrimse/issues/comments{/number}","contents_url":"https://api.github.com/repos/loot/skyrimse/contents/{+path}","compare_url":"https://api.github.com/repos/loot/skyrimse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loot/skyrimse/merges","archive_url":"https://api.github.com/repos/loot/skyrimse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loot/skyrimse/downloads","issues_url":"https://api.github.com/repos/loot/skyrimse/issues{/number}","pulls_url":"https://api.github.com/repos/loot/skyrimse/pulls{/number}","milestones_url":"https://api.github.com/repos/loot/skyrimse/milestones{/number}","notifications_url":"https://api.github.com/repos/loot/skyrimse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loot/skyrimse/labels{/name}","releases_url":"https://api.github.com/repos/loot/skyrimse/releases{/id}","deployments_url":"https://api.github.com/repos/loot/skyrimse/deployments","created_at":"2016-10-28T19:39:58Z","updated_at":"2017-06-09T17:38:09Z","pushed_at":"2017-09-11T14:57:06Z","git_url":"git://github.com/loot/skyrimse.git","ssh_url":"git@github.com:loot/skyrimse.git","clone_url":"https://github.com/loot/skyrimse.git","svn_url":"https://github.com/loot/skyrimse","homepage":"","size":62,"stargazers_count":14,"watchers_count":14,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":14,"default_branch":"v0.10"}},"_links":{"self":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/45"},"html":{"href":"https://github.com/loot/skyrimse/pull/45"},"issue":{"href":"https://api.github.com/repos/loot/skyrimse/issues/45"},"comments":{"href":"https://api.github.com/repos/loot/skyrimse/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loot/skyrimse/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/loot/skyrimse/statuses/e023673fff1d8ed98aa97145330f3a4781a75386"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 72236811,
"name": "loot/skyrimse",
"url": "https://api.github.com/repos/loot/skyrimse"
}
|
{
"id": 30019823,
"login": "BeermotorWB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30019823?",
"url": "https://api.github.com/users/BeermotorWB"
}
|
{
"id": 6802491,
"login": "loot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6802491?",
"url": "https://api.github.com/orgs/loot"
}
| 2017-09-11T20:30:12 |
6576605498
|
{"actor":{"display_login":"BeermotorWB"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments/103321293","pull_request_review_id":24104398,"id":103321293,"diff_hunk":"@@ -21,21 +21,23 @@\n * see <http://www.lsstcorp.org/LegalNotices/>.\n */\n \n+#include \"pybind11/pybind11.h\"\n \n-%include \"lsst/meas/modelfit/optimizer.i\"\n+#include \"lsst/meas/modelfit/integrals.h\"\n \n-%{\n-#include \"lsst/meas/modelfit/GeneralPsfFitter.h\"\n-#include \"lsst/meas/modelfit/DoubleShapeletPsfApprox.h\"\n-%}\n+namespace py = pybind11;\n+using namespace pybind11::literals;\n \n-%include \"lsst/meas/modelfit/GeneralPsfFitter.h\"\n-%include \"lsst/meas/modelfit/DoubleShapeletPsfApprox.h\"\n+namespace lsst {\n+namespace meas {\n+namespace modelfit {\n+namespace {\n \n-%pythoncode %{\n-import lsst.pex.config\n+PYBIND11_PLUGIN(integrals) {\n+ py::module mod(\"integrals\");\n+ mod.def(\"phid\", &detail::phid);\n+ mod.def(\"bvnu\", &detail::bvnu);","path":"python/lsst/meas/modelfit/integrals.cc","position":28,"original_position":28,"commit_id":"05b397d2104f0859919012087ec5dfe8a2c048ba","original_commit_id":"05b397d2104f0859919012087ec5dfe8a2c048ba","user":{"login":"TallJimbo","id":1330720,"avatar_url":"https://avatars.githubusercontent.com/u/1330720?v=3","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"It's actually referenced as `lsst.meas.modelfit.detail.bvnu`, which works because `meas/modelfit/__init__.py` has:\r\n```\r\nfrom . import integrals as detail\r\n```\r\nI'm not sure that was wise, but it nicely makes the Python namespace match the C++ one while letting the wrapper source file match the header name.\r\n","created_at":"2017-02-27T21:50:18Z","updated_at":"2017-02-27T21:50:18Z","html_url":"https://github.com/lsst/meas_modelfit/pull/40#discussion_r103321293","pull_request_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments/103321293"},"html":{"href":"https://github.com/lsst/meas_modelfit/pull/40#discussion_r103321293"},"pull_request":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40","id":107906359,"html_url":"https://github.com/lsst/meas_modelfit/pull/40","diff_url":"https://github.com/lsst/meas_modelfit/pull/40.diff","patch_url":"https://github.com/lsst/meas_modelfit/pull/40.patch","issue_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/40","number":40,"state":"open","locked":false,"title":"DM-8465: wrap meas_modelfit with pybind11","user":{"login":"TallJimbo","id":1330720,"avatar_url":"https://avatars.githubusercontent.com/u/1330720?v=3","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-24T20:50:17Z","updated_at":"2017-02-27T21:50:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce5dadfd49ea6c655c74cc11529aeb8689ae452a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40/commits","review_comments_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40/comments","review_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/40/comments","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/05b397d2104f0859919012087ec5dfe8a2c048ba","head":{"label":"lsst:tickets/DM-8465","ref":"tickets/DM-8465","sha":"05b397d2104f0859919012087ec5dfe8a2c048ba","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013386,"name":"meas_modelfit","full_name":"lsst/meas_modelfit","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_modelfit","description":"LSST Data Management: model fitting algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_modelfit","forks_url":"https://api.github.com/repos/lsst/meas_modelfit/forks","keys_url":"https://api.github.com/repos/lsst/meas_modelfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_modelfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_modelfit/teams","hooks_url":"https://api.github.com/repos/lsst/meas_modelfit/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_modelfit/events","assignees_url":"https://api.github.com/repos/lsst/meas_modelfit/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_modelfit/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_modelfit/tags","blobs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_modelfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_modelfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_modelfit/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_modelfit/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_modelfit/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_modelfit/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_modelfit/subscription","commits_url":"https://api.github.com/repos/lsst/meas_modelfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_modelfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_modelfit/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_modelfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_modelfit/merges","archive_url":"https://api.github.com/repos/lsst/meas_modelfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_modelfit/downloads","issues_url":"https://api.github.com/repos/lsst/meas_modelfit/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_modelfit/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_modelfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_modelfit/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_modelfit/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_modelfit/deployments","created_at":"2014-08-16T07:46:42Z","updated_at":"2016-11-03T15:37:40Z","pushed_at":"2017-02-27T08:14:47Z","git_url":"git://github.com/lsst/meas_modelfit.git","ssh_url":"git@github.com:lsst/meas_modelfit.git","clone_url":"https://github.com/lsst/meas_modelfit.git","svn_url":"https://github.com/lsst/meas_modelfit","homepage":"http://dm.lsst.org/","size":47418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"lsst:tickets/DM-8467","ref":"tickets/DM-8467","sha":"1c691b3f3c428d078c43c2afade05eb2b0631724","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":23013386,"name":"meas_modelfit","full_name":"lsst/meas_modelfit","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars.githubusercontent.com/u/1134504?v=3","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/meas_modelfit","description":"LSST Data Management: model fitting algorithms","fork":false,"url":"https://api.github.com/repos/lsst/meas_modelfit","forks_url":"https://api.github.com/repos/lsst/meas_modelfit/forks","keys_url":"https://api.github.com/repos/lsst/meas_modelfit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/meas_modelfit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/meas_modelfit/teams","hooks_url":"https://api.github.com/repos/lsst/meas_modelfit/hooks","issue_events_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/meas_modelfit/events","assignees_url":"https://api.github.com/repos/lsst/meas_modelfit/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/meas_modelfit/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/meas_modelfit/tags","blobs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/meas_modelfit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/meas_modelfit/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/meas_modelfit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/meas_modelfit/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/meas_modelfit/languages","stargazers_url":"https://api.github.com/repos/lsst/meas_modelfit/stargazers","contributors_url":"https://api.github.com/repos/lsst/meas_modelfit/contributors","subscribers_url":"https://api.github.com/repos/lsst/meas_modelfit/subscribers","subscription_url":"https://api.github.com/repos/lsst/meas_modelfit/subscription","commits_url":"https://api.github.com/repos/lsst/meas_modelfit/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/meas_modelfit/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/meas_modelfit/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/meas_modelfit/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/meas_modelfit/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/meas_modelfit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/meas_modelfit/merges","archive_url":"https://api.github.com/repos/lsst/meas_modelfit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/meas_modelfit/downloads","issues_url":"https://api.github.com/repos/lsst/meas_modelfit/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/meas_modelfit/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/meas_modelfit/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/meas_modelfit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/meas_modelfit/labels{/name}","releases_url":"https://api.github.com/repos/lsst/meas_modelfit/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/meas_modelfit/deployments","created_at":"2014-08-16T07:46:42Z","updated_at":"2016-11-03T15:37:40Z","pushed_at":"2017-02-27T08:14:47Z","git_url":"git://github.com/lsst/meas_modelfit.git","ssh_url":"git@github.com:lsst/meas_modelfit.git","clone_url":"https://github.com/lsst/meas_modelfit.git","svn_url":"https://github.com/lsst/meas_modelfit","homepage":"http://dm.lsst.org/","size":47418,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40"},"html":{"href":"https://github.com/lsst/meas_modelfit/pull/40"},"issue":{"href":"https://api.github.com/repos/lsst/meas_modelfit/issues/40"},"comments":{"href":"https://api.github.com/repos/lsst/meas_modelfit/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/meas_modelfit/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/meas_modelfit/statuses/05b397d2104f0859919012087ec5dfe8a2c048ba"}}}}
|
{
"id": 23013386,
"name": "lsst/meas_modelfit",
"url": "https://api.github.com/repos/lsst/meas_modelfit"
}
|
{
"id": 1330720,
"login": "TallJimbo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1330720?",
"url": "https://api.github.com/users/TallJimbo"
}
|
{
"id": 1134504,
"login": "lsst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1134504?",
"url": "https://api.github.com/orgs/lsst"
}
| 2017-02-27T21:50:18 |
5400358454
|
{"actor":{"display_login":"TallJimbo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/comments/143080786","pull_request_review_id":66634138,"id":143080786,"diff_hunk":"@@ -4,66 +4,209 @@\n \n #include <memory>\n \n+#include \"lsst/afw/image/PhotoCalib.h\"\n+\n+#include \"lsst/jointcal/CcdImage.h\"\n #include \"lsst/jointcal/Eigenstuff.h\"\n+#include \"lsst/jointcal/MeasuredStar.h\"\n #include \"lsst/jointcal/Point.h\"\n #include \"lsst/jointcal/PhotometryTransfo.h\"\n \n namespace lsst {\n namespace jointcal {\n \n-class Point;\n-\n-class PhotometryMapping {\n+/**\n+ * Relates transfo(s) to their position in the fitting matrix and allows interaction with the transfo(s).\n+ */\n+class PhotometryMappingBase {\n public:\n- explicit PhotometryMapping(PhotometryTransfo const &_transfo) : index(-1), transfo(_transfo.clone()) {}\n+ PhotometryMappingBase() : index(-1), fixed(false) {}\n \n /// No copy or move: there is only ever one instance of a given mapping (i.e. per ccd+visit)\n- PhotometryMapping(PhotometryMapping const &) = delete;\n- PhotometryMapping(PhotometryMapping &&) = delete;\n- PhotometryMapping &operator=(PhotometryMapping const &) = delete;\n- PhotometryMapping &operator=(PhotometryMapping &&) = delete;\n+ PhotometryMappingBase(PhotometryMappingBase const &) = delete;\n+ PhotometryMappingBase(PhotometryMappingBase &&) = delete;\n+ PhotometryMappingBase &operator=(PhotometryMappingBase const &) = delete;\n+ PhotometryMappingBase &operator=(PhotometryMappingBase &&) = delete;\n \n /// Number of total parameters in this mapping\n- unsigned getNpar() const { return transfo->getNpar(); }\n+ virtual unsigned getNpar() const = 0;\n \n- /*\n- * Sets how this set of parameters (of length getNpar()) map into the \"grand\" fit.\n- * Expects that indices has enough space reserved.\n+ /**\n+ * Return the on-sky transformed flux at (x,y).\n+ *\n+ * @param[in] measuredStar The measured star position to transform.\n+ * @param[in] instFlux The instrument flux to transform.\n+ *\n+ * @return The on-sky flux transformed from instFlux at measuredStar's\n+ * position.\n */\n- void setMappingIndices(std::vector<unsigned> &indices) const {\n- indices.reserve(getNpar());\n- for (unsigned k = 0; k < getNpar(); ++k) {\n- indices[k] = index + k;\n- }\n- }\n+ virtual double transform(MeasuredStar const &measuredStar, double instFlux) const = 0;\n+\n+ /**\n+ * Compute the derivatives with respect to the parameters (i.e. the coefficients).\n+ *\n+ * @param[in] measuredStar The measured star position to transform.\n+ * @param[in] instFlux The instrument flux to compute the derivative at.\n+ * @param[out] derivatives The computed derivatives, in the same order as the deltas in offsetParams.\n+ */\n+ virtual void computeParameterDerivatives(MeasuredStar const &measuredStar, double instFlux,\n+ Eigen::Ref<Eigen::VectorXd> derivatives) const = 0;\n \n /**\n- * Applies the mapping and evaluates the derivatives with respect to the fitted parameters.\n+ * Offset the transfo parameters by delta.\n *\n- * This is grouped into a single call because for most models,\n- * evaluating the derivatives w.r.t parameters is not much longer than just transforming.\n+ * @param[in] delta vector to offset transfo parameters. Same ordering as derivatives in\n+ * computeParameterDerivatives();\n */\n- void computeTransformAndDerivatives(Point const &where, double &out, Eigen::MatrixX2d &H) const;\n+ virtual void offsetParams(Eigen::VectorXd const &delta) = 0;\n \n- //! The same as above but without the parameter derivatives (used to evaluate chi^2)\n- void transformPosAndErrors(Point const &where, double &out) const;\n+ /// Make this mapping's parameters fixed (i.e. not varied during fitting).\n+ void setFixed(bool _fixed) { fixed = _fixed; }\n+ bool isFixed() { return fixed; }\n \n- void offsetParams(const double *delta) { transfo->offsetParams(delta); }\n+ virtual Eigen::VectorXd getParameters() = 0;\n+\n+ /**\n+ * Gets how this set of parameters (of length getNpar()) map into the \"grand\" fit.\n+ * Expects that indices has enough space reserved.\n+ */\n+ virtual void getMappingIndices(std::vector<unsigned> &indices) const = 0;\n+\n+ /// Dump the contents of the transfos, for debugging.\n+ virtual void dump(std::ostream &stream = std::cout) const = 0;\n \n /// Get the index of this mapping in the grand fit.\n unsigned getIndex() { return index; }\n \n /// Set the index of this mapping in the grand fit.\n void setIndex(unsigned i) { index = i; }\n \n- PhotometryTransfo const &getTransfo() { return *(transfo.get()); }\n-\n protected:\n // Start index of this mapping in the \"grand\" fit\n unsigned index;\n+ // Should this mapping be varied during fitting?\n+ bool fixed;\n+};\n+\n+/**\n+ * A mapping containing a single photometryTransfo.\n+ */\n+class PhotometryMapping : public PhotometryMappingBase {\n+public:\n+ explicit PhotometryMapping(std::shared_ptr<PhotometryTransfo> transfo)\n+ : PhotometryMappingBase(), _transfo(std::move(transfo)) {}\n+\n+ /// @copydoc PhotometryMappingBase::getNpar\n+ unsigned getNpar() const override {\n+ if (fixed) {\n+ return 0;\n+ } else {\n+ return _transfo->getNpar();\n+ }\n+ }\n+\n+ /// @copydoc PhotometryMappingBase::transform\n+ double transform(MeasuredStar const &measuredStar, double instFlux) const override {\n+ return _transfo->transform(measuredStar.x, measuredStar.y, instFlux);\n+ }\n+\n+ /// @copydoc PhotometryMappingBase::computeParameterDerivatives\n+ void computeParameterDerivatives(MeasuredStar const &measuredStar, double instFlux,\n+ Eigen::Ref<Eigen::VectorXd> derivatives) const override {\n+ if (fixed) {\n+ return;\n+ } else {\n+ _transfo->computeParameterDerivatives(measuredStar.x, measuredStar.y, instFlux, derivatives);\n+ }\n+ }\n+\n+ /// @copydoc PhotometryMappingBase::offsetParams\n+ void offsetParams(Eigen::VectorXd const &delta) override { _transfo->offsetParams(delta); }\n+\n+ /// @copydoc PhotometryMappingBase::getParameters\n+ Eigen::VectorXd getParameters() override { return _transfo->getParameters(); }\n+\n+ /// @copydoc PhotometryMappingBase::getMappingIndices\n+ void getMappingIndices(std::vector<unsigned> &indices) const override {\n+ if (indices.size() < getNpar()) indices.resize(getNpar());\n+ for (unsigned k = 0; k < getNpar(); ++k) {\n+ indices[k] = index + k;\n+ }\n+ }\n+\n+ /// @copydoc PhotometryMappingBase::dump\n+ void dump(std::ostream &stream = std::cout) const override {\n+ stream << \"index: \" << index << \" params: \";\n+ _transfo->dump(stream);\n+ }\n+\n+ std::shared_ptr<PhotometryTransfo> getTransfo() const { return _transfo; }\n+\n+private:\n+ // the actual transformation to be fit\n+ std::shared_ptr<PhotometryTransfo> _transfo;\n+};\n+\n+/**\n+ * A two-level photometric transform: one for the ccd and one for the visit.\n+ */\n+class ChipVisitPhotometryMapping : public PhotometryMappingBase {\n+public:\n+ ChipVisitPhotometryMapping(std::shared_ptr<PhotometryMapping> chipMapping,\n+ std::shared_ptr<PhotometryMapping> visitMapping)\n+ : PhotometryMappingBase(),\n+ _chipMapping(std::move(chipMapping)),\n+ _visitMapping(std::move(visitMapping)) {}\n+\n+ // std::shared_ptr<afw::image::PhotoCalib> toPhotoCalib() const {\n+ // return std::shared_ptr<afw::image::PhotoCalib>(new afw::image::PhotoCalib(0.0));\n+ // }","path":"include/lsst/jointcal/PhotometryMapping.h","position":187,"original_position":187,"commit_id":"bf36792981657762b3e1dc593877d8b3e288ee4d","original_commit_id":"bf36792981657762b3e1dc593877d8b3e288ee4d","user":{"login":"pschella","id":211955,"avatar_url":"https://avatars3.githubusercontent.com/u/211955?v=4","gravatar_id":"","url":"https://api.github.com/users/pschella","html_url":"https://github.com/pschella","followers_url":"https://api.github.com/users/pschella/followers","following_url":"https://api.github.com/users/pschella/following{/other_user}","gists_url":"https://api.github.com/users/pschella/gists{/gist_id}","starred_url":"https://api.github.com/users/pschella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschella/subscriptions","organizations_url":"https://api.github.com/users/pschella/orgs","repos_url":"https://api.github.com/users/pschella/repos","events_url":"https://api.github.com/users/pschella/events{/privacy}","received_events_url":"https://api.github.com/users/pschella/received_events","type":"User","site_admin":false},"body":"Please remove","created_at":"2017-10-05T23:21:47Z","updated_at":"2017-10-05T23:46:25Z","html_url":"https://github.com/lsst/jointcal/pull/45#discussion_r143080786","pull_request_url":"https://api.github.com/repos/lsst/jointcal/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments/143080786"},"html":{"href":"https://github.com/lsst/jointcal/pull/45#discussion_r143080786"},"pull_request":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/jointcal/pulls/45","id":133406116,"html_url":"https://github.com/lsst/jointcal/pull/45","diff_url":"https://github.com/lsst/jointcal/pull/45.diff","patch_url":"https://github.com/lsst/jointcal/pull/45.patch","issue_url":"https://api.github.com/repos/lsst/jointcal/issues/45","number":45,"state":"open","locked":false,"title":"DM-9195 improved 2-level photometric model","user":{"login":"parejkoj","id":1606089,"avatar_url":"https://avatars3.githubusercontent.com/u/1606089?v=4","gravatar_id":"","url":"https://api.github.com/users/parejkoj","html_url":"https://github.com/parejkoj","followers_url":"https://api.github.com/users/parejkoj/followers","following_url":"https://api.github.com/users/parejkoj/following{/other_user}","gists_url":"https://api.github.com/users/parejkoj/gists{/gist_id}","starred_url":"https://api.github.com/users/parejkoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parejkoj/subscriptions","organizations_url":"https://api.github.com/users/parejkoj/orgs","repos_url":"https://api.github.com/users/parejkoj/repos","events_url":"https://api.github.com/users/parejkoj/events{/privacy}","received_events_url":"https://api.github.com/users/parejkoj/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-01T07:34:00Z","updated_at":"2017-10-05T23:46:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3215e4e6cc764ddb86aaa51115771eb53bf9b9f7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/jointcal/pulls/45/commits","review_comments_url":"https://api.github.com/repos/lsst/jointcal/pulls/45/comments","review_comment_url":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/jointcal/issues/45/comments","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/bf36792981657762b3e1dc593877d8b3e288ee4d","head":{"label":"lsst:tickets/DM-9195","ref":"tickets/DM-9195","sha":"bf36792981657762b3e1dc593877d8b3e288ee4d","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":false,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2017-08-10T16:42:09Z","pushed_at":"2017-10-03T22:37:28Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":3326,"stargazers_count":5,"watchers_count":5,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"b0bba321952411d1e5f0178ec492ac78a3f7bbe6","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":52640673,"name":"jointcal","full_name":"lsst/jointcal","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/jointcal","description":"Simultaneous astrometry ","fork":false,"url":"https://api.github.com/repos/lsst/jointcal","forks_url":"https://api.github.com/repos/lsst/jointcal/forks","keys_url":"https://api.github.com/repos/lsst/jointcal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/jointcal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/jointcal/teams","hooks_url":"https://api.github.com/repos/lsst/jointcal/hooks","issue_events_url":"https://api.github.com/repos/lsst/jointcal/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/jointcal/events","assignees_url":"https://api.github.com/repos/lsst/jointcal/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/jointcal/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/jointcal/tags","blobs_url":"https://api.github.com/repos/lsst/jointcal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/jointcal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/jointcal/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/jointcal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/jointcal/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/jointcal/languages","stargazers_url":"https://api.github.com/repos/lsst/jointcal/stargazers","contributors_url":"https://api.github.com/repos/lsst/jointcal/contributors","subscribers_url":"https://api.github.com/repos/lsst/jointcal/subscribers","subscription_url":"https://api.github.com/repos/lsst/jointcal/subscription","commits_url":"https://api.github.com/repos/lsst/jointcal/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/jointcal/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/jointcal/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/jointcal/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/jointcal/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/jointcal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/jointcal/merges","archive_url":"https://api.github.com/repos/lsst/jointcal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/jointcal/downloads","issues_url":"https://api.github.com/repos/lsst/jointcal/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/jointcal/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/jointcal/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/jointcal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/jointcal/labels{/name}","releases_url":"https://api.github.com/repos/lsst/jointcal/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/jointcal/deployments","created_at":"2016-02-26T23:56:59Z","updated_at":"2017-08-10T16:42:09Z","pushed_at":"2017-10-03T22:37:28Z","git_url":"git://github.com/lsst/jointcal.git","ssh_url":"git@github.com:lsst/jointcal.git","clone_url":"https://github.com/lsst/jointcal.git","svn_url":"https://github.com/lsst/jointcal","homepage":null,"size":3326,"stargazers_count":5,"watchers_count":5,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/45"},"html":{"href":"https://github.com/lsst/jointcal/pull/45"},"issue":{"href":"https://api.github.com/repos/lsst/jointcal/issues/45"},"comments":{"href":"https://api.github.com/repos/lsst/jointcal/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/jointcal/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/jointcal/statuses/bf36792981657762b3e1dc593877d8b3e288ee4d"}},"author_association":"COLLABORATOR"}}
|
{
"id": 52640673,
"name": "lsst/jointcal",
"url": "https://api.github.com/repos/lsst/jointcal"
}
|
{
"id": 211955,
"login": "pschella",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/211955?",
"url": "https://api.github.com/users/pschella"
}
|
{
"id": 1134504,
"login": "lsst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1134504?",
"url": "https://api.github.com/orgs/lsst"
}
| 2017-10-05T23:21:47 |
6680926502
|
{"actor":{"display_login":"pschella"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3collector/pulls/comments/133283769","pull_request_review_id":56447226,"id":133283769,"diff_hunk":"@@ -156,11 +156,10 @@ func (w *writer) flushWithLock() error {\n \t\t\tencoder.Unlock()\n \t\t\tcontinue\n \t\t}\n-\t\tnewBufferedEncoder := w.encoderPool.Get()\n-\t\tnewBufferedEncoder.Reset()\n-\t\tencoder.Reset(newBufferedEncoder)\n+\t\t// Use a sizeBefore of 0 to indicate we want to write the entire buffer.\n+\t\toldBufferedEncoder := w.prepareEnqueueBufferWithLock(encoder, 0)","path":"backend/msgpack/writer.go","position":8,"original_position":8,"commit_id":"8c41db465e60038a9b47d116093691a787a699b4","original_commit_id":"8c41db465e60038a9b47d116093691a787a699b4","user":{"login":"xichen2020","id":12239421,"avatar_url":"https://avatars1.githubusercontent.com/u/12239421?v=4","gravatar_id":"","url":"https://api.github.com/users/xichen2020","html_url":"https://github.com/xichen2020","followers_url":"https://api.github.com/users/xichen2020/followers","following_url":"https://api.github.com/users/xichen2020/following{/other_user}","gists_url":"https://api.github.com/users/xichen2020/gists{/gist_id}","starred_url":"https://api.github.com/users/xichen2020/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xichen2020/subscriptions","organizations_url":"https://api.github.com/users/xichen2020/orgs","repos_url":"https://api.github.com/users/xichen2020/repos","events_url":"https://api.github.com/users/xichen2020/events{/privacy}","received_events_url":"https://api.github.com/users/xichen2020/received_events","type":"User","site_admin":false},"body":"Hm this seems like a bit of a hack, perhaps we should leave it as is just to be very explicit about writing out the whole buffer.","created_at":"2017-08-15T19:41:48Z","updated_at":"2017-08-15T19:41:48Z","html_url":"https://github.com/m3db/m3collector/pull/26#discussion_r133283769","pull_request_url":"https://api.github.com/repos/m3db/m3collector/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/comments/133283769"},"html":{"href":"https://github.com/m3db/m3collector/pull/26#discussion_r133283769"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3collector/pulls/26","id":135814874,"html_url":"https://github.com/m3db/m3collector/pull/26","diff_url":"https://github.com/m3db/m3collector/pull/26.diff","patch_url":"https://github.com/m3db/m3collector/pull/26.patch","issue_url":"https://api.github.com/repos/m3db/m3collector/issues/26","number":26,"state":"open","locked":false,"title":"[writer] Simplify logic of flush function","user":{"login":"jeromefroe","id":7217598,"avatar_url":"https://avatars1.githubusercontent.com/u/7217598?v=4","gravatar_id":"","url":"https://api.github.com/users/jeromefroe","html_url":"https://github.com/jeromefroe","followers_url":"https://api.github.com/users/jeromefroe/followers","following_url":"https://api.github.com/users/jeromefroe/following{/other_user}","gists_url":"https://api.github.com/users/jeromefroe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromefroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromefroe/subscriptions","organizations_url":"https://api.github.com/users/jeromefroe/orgs","repos_url":"https://api.github.com/users/jeromefroe/repos","events_url":"https://api.github.com/users/jeromefroe/events{/privacy}","received_events_url":"https://api.github.com/users/jeromefroe/received_events","type":"User","site_admin":false},"body":"I noticed that we were duplicating the logic of `prepareEnqueueBufferWithLock` in `flushWithLock` so this small PR replace those lines with a single call to `prepareEnqueueBufferWithLock`.\r\n\r\ncc @xichen2020 ","created_at":"2017-08-15T14:38:58Z","updated_at":"2017-08-15T19:41:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7bc2ec66b2f0b0c8e178e05cdda667b084f0048","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3collector/pulls/26/commits","review_comments_url":"https://api.github.com/repos/m3db/m3collector/pulls/26/comments","review_comment_url":"https://api.github.com/repos/m3db/m3collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3collector/issues/26/comments","statuses_url":"https://api.github.com/repos/m3db/m3collector/statuses/8c41db465e60038a9b47d116093691a787a699b4","head":{"label":"m3db:jeromefroe/writer/simplify-flush-logic","ref":"jeromefroe/writer/simplify-flush-logic","sha":"8c41db465e60038a9b47d116093691a787a699b4","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":79852610,"name":"m3collector","full_name":"m3db/m3collector","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3collector","description":"Collects local metrics and sends them to downstream services","fork":false,"url":"https://api.github.com/repos/m3db/m3collector","forks_url":"https://api.github.com/repos/m3db/m3collector/forks","keys_url":"https://api.github.com/repos/m3db/m3collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3collector/teams","hooks_url":"https://api.github.com/repos/m3db/m3collector/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3collector/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3collector/events","assignees_url":"https://api.github.com/repos/m3db/m3collector/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3collector/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3collector/tags","blobs_url":"https://api.github.com/repos/m3db/m3collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3collector/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3collector/languages","stargazers_url":"https://api.github.com/repos/m3db/m3collector/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3collector/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3collector/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3collector/subscription","commits_url":"https://api.github.com/repos/m3db/m3collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3collector/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3collector/merges","archive_url":"https://api.github.com/repos/m3db/m3collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3collector/downloads","issues_url":"https://api.github.com/repos/m3db/m3collector/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3collector/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3collector/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3collector/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3collector/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3collector/deployments","created_at":"2017-01-23T21:59:30Z","updated_at":"2017-07-14T00:53:49Z","pushed_at":"2017-08-15T15:40:44Z","git_url":"git://github.com/m3db/m3collector.git","ssh_url":"git@github.com:m3db/m3collector.git","clone_url":"https://github.com/m3db/m3collector.git","svn_url":"https://github.com/m3db/m3collector","homepage":null,"size":120,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"3e603421286e768ce68b3ea21121caef8803115b","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":79852610,"name":"m3collector","full_name":"m3db/m3collector","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3collector","description":"Collects local metrics and sends them to downstream services","fork":false,"url":"https://api.github.com/repos/m3db/m3collector","forks_url":"https://api.github.com/repos/m3db/m3collector/forks","keys_url":"https://api.github.com/repos/m3db/m3collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3collector/teams","hooks_url":"https://api.github.com/repos/m3db/m3collector/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3collector/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3collector/events","assignees_url":"https://api.github.com/repos/m3db/m3collector/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3collector/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3collector/tags","blobs_url":"https://api.github.com/repos/m3db/m3collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3collector/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3collector/languages","stargazers_url":"https://api.github.com/repos/m3db/m3collector/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3collector/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3collector/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3collector/subscription","commits_url":"https://api.github.com/repos/m3db/m3collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3collector/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3collector/merges","archive_url":"https://api.github.com/repos/m3db/m3collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3collector/downloads","issues_url":"https://api.github.com/repos/m3db/m3collector/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3collector/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3collector/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3collector/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3collector/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3collector/deployments","created_at":"2017-01-23T21:59:30Z","updated_at":"2017-07-14T00:53:49Z","pushed_at":"2017-08-15T15:40:44Z","git_url":"git://github.com/m3db/m3collector.git","ssh_url":"git@github.com:m3db/m3collector.git","clone_url":"https://github.com/m3db/m3collector.git","svn_url":"https://github.com/m3db/m3collector","homepage":null,"size":120,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/26"},"html":{"href":"https://github.com/m3db/m3collector/pull/26"},"issue":{"href":"https://api.github.com/repos/m3db/m3collector/issues/26"},"comments":{"href":"https://api.github.com/repos/m3db/m3collector/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3collector/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3collector/statuses/8c41db465e60038a9b47d116093691a787a699b4"}}}}
|
{
"id": 79852610,
"name": "m3db/m3collector",
"url": "https://api.github.com/repos/m3db/m3collector"
}
|
{
"id": 12239421,
"login": "xichen2020",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12239421?",
"url": "https://api.github.com/users/xichen2020"
}
|
{
"id": 19937171,
"login": "m3db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19937171?",
"url": "https://api.github.com/orgs/m3db"
}
| 2017-08-15T19:41:48 |
6457918004
|
{"actor":{"display_login":"xichen2020"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3db/pulls/comments/128670628","pull_request_review_id":51372908,"id":128670628,"diff_hunk":"@@ -41,16 +42,15 @@ func TestAdminSessionFetchBlocksFromPeers(t *testing.T) {\n \tif testing.Short() {\n \t\tt.SkipNow() // Just skip if we're doing a short run\n \t}\n+\n \t// Test setup\n-\ttestSetup, err := newTestSetup(newTestOptions())\n+\ttickInterval := time.Second\n+\ttestSetup, err := newTestSetup(t, newTestOptions(t).SetTickInterval(tickInterval))","path":"integration/admin_session_fetch_blocks_test.go","position":16,"original_position":16,"commit_id":"f02a38debaccb9c1fe387ce9ac33a5d20f3498ad","original_commit_id":"342e197bb8a674c5419d5fb53a0b28afd84d9aaf","user":{"login":"prateek","id":199982,"avatar_url":"https://avatars3.githubusercontent.com/u/199982?v=4","gravatar_id":"","url":"https://api.github.com/users/prateek","html_url":"https://github.com/prateek","followers_url":"https://api.github.com/users/prateek/followers","following_url":"https://api.github.com/users/prateek/following{/other_user}","gists_url":"https://api.github.com/users/prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateek/subscriptions","organizations_url":"https://api.github.com/users/prateek/orgs","repos_url":"https://api.github.com/users/prateek/repos","events_url":"https://api.github.com/users/prateek/events{/privacy}","received_events_url":"https://api.github.com/users/prateek/received_events","type":"User","site_admin":false},"body":"Already have a property for it set to 3 seconds by default, will make the default 1 and see if that's sufficient for tests ","created_at":"2017-07-21T02:09:02Z","updated_at":"2017-07-21T02:09:02Z","html_url":"https://github.com/m3db/m3db/pull/306#discussion_r128670628","pull_request_url":"https://api.github.com/repos/m3db/m3db/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3db/pulls/comments/128670628"},"html":{"href":"https://github.com/m3db/m3db/pull/306#discussion_r128670628"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/m3db/m3db/pulls/306","id":126335249,"html_url":"https://github.com/m3db/m3db/pull/306","diff_url":"https://github.com/m3db/m3db/pull/306.diff","patch_url":"https://github.com/m3db/m3db/pull/306.patch","issue_url":"https://api.github.com/repos/m3db/m3db/issues/306","number":306,"state":"open","locked":false,"title":"Improve Namespace Isolation","user":{"login":"prateek","id":199982,"avatar_url":"https://avatars3.githubusercontent.com/u/199982?v=4","gravatar_id":"","url":"https://api.github.com/users/prateek","html_url":"https://github.com/prateek","followers_url":"https://api.github.com/users/prateek/followers","following_url":"https://api.github.com/users/prateek/following{/other_user}","gists_url":"https://api.github.com/users/prateek/gists{/gist_id}","starred_url":"https://api.github.com/users/prateek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prateek/subscriptions","organizations_url":"https://api.github.com/users/prateek/orgs","repos_url":"https://api.github.com/users/prateek/repos","events_url":"https://api.github.com/users/prateek/events{/privacy}","received_events_url":"https://api.github.com/users/prateek/received_events","type":"User","site_admin":false},"body":"Prior to this PR, RetentionOptions were global across namespaces and the commit log. This PR changes that to allow every namespace, and the database commit log to have independent retention options. \r\n\r\nMajor changes:\r\n- `namespace.Options` has a new field: `RetentionOptions`\r\n- New construct: `namespace.NamespaceRegistry` (maps namespace ID -> namespace Metadata)\r\n- Replace RetentionOptions with NamespaceRegistry in all Options\r\n- Corresponding changes to retrieve retentionOpts based on Namespace everywhere (e.g. a couple of `client.AdminClient` method, `databaseFlushManager`, `databaseCleanupManager`, etc).\r\n - this induced a lot of interface changes, especially in tests, to pass the ns id parameter.\r\n\r\n/cc @robskillington @xichen2020 @martin-mao @cw9 \r\n\r\nPending chunks:\r\n- [x] builds are :(\r\n- [x] rethink persistManager, `persist/fs/Options` usage of `RetentionOptions`\r\n- [x] cleanup manager handling of commit log cleanup \r\n- [x] repairer needs to track state per namespace\r\n- [x] commit log bootstrapper handling of multiple retentions\r\n- [x] more unit tests\r\n- [x] cleanup multiple ns integration test\r\n- [x] flush multiple ns integration test\r\n- [x] bootstrap from commit log integration test\r\n- [x] bootstrap multiple ns from commit log integration test\r\n- [ ] instrumentation for multiple namespaces\r\n","created_at":"2017-06-19T15:44:52Z","updated_at":"2017-07-21T02:09:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b6831cb811a46714e7588efe0125be7124eb41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3db/pulls/306/commits","review_comments_url":"https://api.github.com/repos/m3db/m3db/pulls/306/comments","review_comment_url":"https://api.github.com/repos/m3db/m3db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3db/issues/306/comments","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/f02a38debaccb9c1fe387ce9ac33a5d20f3498ad","head":{"label":"m3db:prateek/ns-isolation","ref":"prateek/ns-isolation","sha":"f02a38debaccb9c1fe387ce9ac33a5d20f3498ad","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"name":"m3db","full_name":"m3db/m3db","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3db","description":"A distributed time series database using M3TSZ compression ","fork":false,"url":"https://api.github.com/repos/m3db/m3db","forks_url":"https://api.github.com/repos/m3db/m3db/forks","keys_url":"https://api.github.com/repos/m3db/m3db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3db/teams","hooks_url":"https://api.github.com/repos/m3db/m3db/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3db/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3db/events","assignees_url":"https://api.github.com/repos/m3db/m3db/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3db/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3db/tags","blobs_url":"https://api.github.com/repos/m3db/m3db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3db/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3db/languages","stargazers_url":"https://api.github.com/repos/m3db/m3db/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3db/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3db/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3db/subscription","commits_url":"https://api.github.com/repos/m3db/m3db/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3db/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3db/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3db/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3db/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3db/merges","archive_url":"https://api.github.com/repos/m3db/m3db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3db/downloads","issues_url":"https://api.github.com/repos/m3db/m3db/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3db/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3db/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3db/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3db/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3db/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2017-07-14T05:20:41Z","pushed_at":"2017-07-21T01:48:52Z","git_url":"git://github.com/m3db/m3db.git","ssh_url":"git@github.com:m3db/m3db.git","clone_url":"https://github.com/m3db/m3db.git","svn_url":"https://github.com/m3db/m3db","homepage":"http://uber.github.io/","size":4339,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":110,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"0376c4d2f4624e723c9b442044b9d944dbbaf032","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":61153677,"name":"m3db","full_name":"m3db/m3db","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3db","description":"A distributed time series database using M3TSZ compression ","fork":false,"url":"https://api.github.com/repos/m3db/m3db","forks_url":"https://api.github.com/repos/m3db/m3db/forks","keys_url":"https://api.github.com/repos/m3db/m3db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3db/teams","hooks_url":"https://api.github.com/repos/m3db/m3db/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3db/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3db/events","assignees_url":"https://api.github.com/repos/m3db/m3db/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3db/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3db/tags","blobs_url":"https://api.github.com/repos/m3db/m3db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3db/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3db/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3db/languages","stargazers_url":"https://api.github.com/repos/m3db/m3db/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3db/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3db/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3db/subscription","commits_url":"https://api.github.com/repos/m3db/m3db/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3db/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3db/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3db/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3db/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3db/merges","archive_url":"https://api.github.com/repos/m3db/m3db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3db/downloads","issues_url":"https://api.github.com/repos/m3db/m3db/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3db/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3db/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3db/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3db/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3db/deployments","created_at":"2016-06-14T20:29:45Z","updated_at":"2017-07-14T05:20:41Z","pushed_at":"2017-07-21T01:48:52Z","git_url":"git://github.com/m3db/m3db.git","ssh_url":"git@github.com:m3db/m3db.git","clone_url":"https://github.com/m3db/m3db.git","svn_url":"https://github.com/m3db/m3db","homepage":"http://uber.github.io/","size":4339,"stargazers_count":110,"watchers_count":110,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":20,"forks":2,"open_issues":20,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306"},"html":{"href":"https://github.com/m3db/m3db/pull/306"},"issue":{"href":"https://api.github.com/repos/m3db/m3db/issues/306"},"comments":{"href":"https://api.github.com/repos/m3db/m3db/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3db/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3db/statuses/f02a38debaccb9c1fe387ce9ac33a5d20f3498ad"}}}}
|
{
"id": 61153677,
"name": "m3db/m3db",
"url": "https://api.github.com/repos/m3db/m3db"
}
|
{
"id": 199982,
"login": "prateek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/199982?",
"url": "https://api.github.com/users/prateek"
}
|
{
"id": 19937171,
"login": "m3db",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19937171?",
"url": "https://api.github.com/orgs/m3db"
}
| 2017-07-21T02:09:02 |
6300122874
|
{"actor":{"display_login":"prateek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mono/monodevelop/pulls/comments/112754108","pull_request_review_id":34097738,"id":112754108,"diff_hunk":"@@ -1366,7 +1366,9 @@ void OnFileRemoved (object sender, MonoDevelop.Projects.ProjectFileEventArgs arg\n \t\t\t\t\tvar id = data.GetDocumentId (fargs.ProjectFile.FilePath);\r\n \t\t\t\t\tif (id != null) {\r\n \t\t\t\t\t\tClearDocumentData (id);\r\n-\t\t\t\t\t\tOnDocumentRemoved (id);\r\n+\t\t\t\t\t\ttry {\n+\t\t\t\t\t\t\tOnDocumentRemoved (id);\r\n+\t\t\t\t\t\t} catch (Exception) {}\r","path":"main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.TypeSystem/MonoDevelopWorkspace.cs","position":25,"original_position":25,"commit_id":"6e3afb07253e6cae0aaec4c556068da47923a417","original_commit_id":"6e3afb07253e6cae0aaec4c556068da47923a417","user":{"login":"slluis","id":260349,"avatar_url":"https://avatars1.githubusercontent.com/u/260349?v=3","gravatar_id":"","url":"https://api.github.com/users/slluis","html_url":"https://github.com/slluis","followers_url":"https://api.github.com/users/slluis/followers","following_url":"https://api.github.com/users/slluis/following{/other_user}","gists_url":"https://api.github.com/users/slluis/gists{/gist_id}","starred_url":"https://api.github.com/users/slluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slluis/subscriptions","organizations_url":"https://api.github.com/users/slluis/orgs","repos_url":"https://api.github.com/users/slluis/repos","events_url":"https://api.github.com/users/slluis/events{/privacy}","received_events_url":"https://api.github.com/users/slluis/received_events","type":"User","site_admin":false},"body":"Please don't do use empty catch blocks. You should log the exception or, if the exception is expected, do a specialized catch. ","created_at":"2017-04-21T18:46:59Z","updated_at":"2017-04-21T18:47:11Z","html_url":"https://github.com/mono/monodevelop/pull/2237#discussion_r112754108","pull_request_url":"https://api.github.com/repos/mono/monodevelop/pulls/2237","_links":{"self":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/comments/112754108"},"html":{"href":"https://github.com/mono/monodevelop/pull/2237#discussion_r112754108"},"pull_request":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2237"}}},"pull_request":{"url":"https://api.github.com/repos/mono/monodevelop/pulls/2237","id":117036442,"html_url":"https://github.com/mono/monodevelop/pull/2237","diff_url":"https://github.com/mono/monodevelop/pull/2237.diff","patch_url":"https://github.com/mono/monodevelop/pull/2237.patch","issue_url":"https://api.github.com/repos/mono/monodevelop/issues/2237","number":2237,"state":"open","locked":false,"title":"Fixed 'Bug 55455 - Code completion lost when moving files'","user":{"login":"mkrueger","id":341098,"avatar_url":"https://avatars0.githubusercontent.com/u/341098?v=3","gravatar_id":"","url":"https://api.github.com/users/mkrueger","html_url":"https://github.com/mkrueger","followers_url":"https://api.github.com/users/mkrueger/followers","following_url":"https://api.github.com/users/mkrueger/following{/other_user}","gists_url":"https://api.github.com/users/mkrueger/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrueger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrueger/subscriptions","organizations_url":"https://api.github.com/users/mkrueger/orgs","repos_url":"https://api.github.com/users/mkrueger/repos","events_url":"https://api.github.com/users/mkrueger/events{/privacy}","received_events_url":"https://api.github.com/users/mkrueger/received_events","type":"User","site_admin":false},"body":"Fixed some potential exceptions found during trying out various\r\nworkarounds.","created_at":"2017-04-21T17:55:58Z","updated_at":"2017-04-21T18:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efdc35bc7e4418518f469f15c568c4f9295e04ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/monodevelop/pulls/2237/commits","review_comments_url":"https://api.github.com/repos/mono/monodevelop/pulls/2237/comments","review_comment_url":"https://api.github.com/repos/mono/monodevelop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/monodevelop/issues/2237/comments","statuses_url":"https://api.github.com/repos/mono/monodevelop/statuses/6e3afb07253e6cae0aaec4c556068da47923a417","head":{"label":"mono:d15-2-fix55455","ref":"d15-2-fix55455","sha":"6e3afb07253e6cae0aaec4c556068da47923a417","user":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791299,"name":"monodevelop","full_name":"mono/monodevelop","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/monodevelop","description":"MonoDevelop is a cross platform IDE mostly aimed at Mono/.NET developers","fork":false,"url":"https://api.github.com/repos/mono/monodevelop","forks_url":"https://api.github.com/repos/mono/monodevelop/forks","keys_url":"https://api.github.com/repos/mono/monodevelop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/monodevelop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/monodevelop/teams","hooks_url":"https://api.github.com/repos/mono/monodevelop/hooks","issue_events_url":"https://api.github.com/repos/mono/monodevelop/issues/events{/number}","events_url":"https://api.github.com/repos/mono/monodevelop/events","assignees_url":"https://api.github.com/repos/mono/monodevelop/assignees{/user}","branches_url":"https://api.github.com/repos/mono/monodevelop/branches{/branch}","tags_url":"https://api.github.com/repos/mono/monodevelop/tags","blobs_url":"https://api.github.com/repos/mono/monodevelop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/monodevelop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/monodevelop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/monodevelop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/monodevelop/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/monodevelop/languages","stargazers_url":"https://api.github.com/repos/mono/monodevelop/stargazers","contributors_url":"https://api.github.com/repos/mono/monodevelop/contributors","subscribers_url":"https://api.github.com/repos/mono/monodevelop/subscribers","subscription_url":"https://api.github.com/repos/mono/monodevelop/subscription","commits_url":"https://api.github.com/repos/mono/monodevelop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/monodevelop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/monodevelop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/monodevelop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/monodevelop/contents/{+path}","compare_url":"https://api.github.com/repos/mono/monodevelop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/monodevelop/merges","archive_url":"https://api.github.com/repos/mono/monodevelop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/monodevelop/downloads","issues_url":"https://api.github.com/repos/mono/monodevelop/issues{/number}","pulls_url":"https://api.github.com/repos/mono/monodevelop/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/monodevelop/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/monodevelop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/monodevelop/labels{/name}","releases_url":"https://api.github.com/repos/mono/monodevelop/releases{/id}","deployments_url":"https://api.github.com/repos/mono/monodevelop/deployments","created_at":"2010-07-22T16:09:08Z","updated_at":"2017-04-20T06:08:12Z","pushed_at":"2017-04-21T18:10:25Z","git_url":"git://github.com/mono/monodevelop.git","ssh_url":"git@github.com:mono/monodevelop.git","clone_url":"https://github.com/mono/monodevelop.git","svn_url":"https://github.com/mono/monodevelop","homepage":"http://www.monodevelop.com","size":306468,"stargazers_count":1827,"watchers_count":1827,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":742,"mirror_url":null,"open_issues_count":36,"forks":742,"open_issues":36,"watchers":1827,"default_branch":"master"}},"base":{"label":"mono:d15-2","ref":"d15-2","sha":"4027f57d86d54bebd31ae6489d4dbe8a58117bd8","user":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791299,"name":"monodevelop","full_name":"mono/monodevelop","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars0.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/monodevelop","description":"MonoDevelop is a cross platform IDE mostly aimed at Mono/.NET developers","fork":false,"url":"https://api.github.com/repos/mono/monodevelop","forks_url":"https://api.github.com/repos/mono/monodevelop/forks","keys_url":"https://api.github.com/repos/mono/monodevelop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/monodevelop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/monodevelop/teams","hooks_url":"https://api.github.com/repos/mono/monodevelop/hooks","issue_events_url":"https://api.github.com/repos/mono/monodevelop/issues/events{/number}","events_url":"https://api.github.com/repos/mono/monodevelop/events","assignees_url":"https://api.github.com/repos/mono/monodevelop/assignees{/user}","branches_url":"https://api.github.com/repos/mono/monodevelop/branches{/branch}","tags_url":"https://api.github.com/repos/mono/monodevelop/tags","blobs_url":"https://api.github.com/repos/mono/monodevelop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/monodevelop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/monodevelop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/monodevelop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/monodevelop/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/monodevelop/languages","stargazers_url":"https://api.github.com/repos/mono/monodevelop/stargazers","contributors_url":"https://api.github.com/repos/mono/monodevelop/contributors","subscribers_url":"https://api.github.com/repos/mono/monodevelop/subscribers","subscription_url":"https://api.github.com/repos/mono/monodevelop/subscription","commits_url":"https://api.github.com/repos/mono/monodevelop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/monodevelop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/monodevelop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/monodevelop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/monodevelop/contents/{+path}","compare_url":"https://api.github.com/repos/mono/monodevelop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/monodevelop/merges","archive_url":"https://api.github.com/repos/mono/monodevelop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/monodevelop/downloads","issues_url":"https://api.github.com/repos/mono/monodevelop/issues{/number}","pulls_url":"https://api.github.com/repos/mono/monodevelop/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/monodevelop/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/monodevelop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/monodevelop/labels{/name}","releases_url":"https://api.github.com/repos/mono/monodevelop/releases{/id}","deployments_url":"https://api.github.com/repos/mono/monodevelop/deployments","created_at":"2010-07-22T16:09:08Z","updated_at":"2017-04-20T06:08:12Z","pushed_at":"2017-04-21T18:10:25Z","git_url":"git://github.com/mono/monodevelop.git","ssh_url":"git@github.com:mono/monodevelop.git","clone_url":"https://github.com/mono/monodevelop.git","svn_url":"https://github.com/mono/monodevelop","homepage":"http://www.monodevelop.com","size":306468,"stargazers_count":1827,"watchers_count":1827,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":742,"mirror_url":null,"open_issues_count":36,"forks":742,"open_issues":36,"watchers":1827,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2237"},"html":{"href":"https://github.com/mono/monodevelop/pull/2237"},"issue":{"href":"https://api.github.com/repos/mono/monodevelop/issues/2237"},"comments":{"href":"https://api.github.com/repos/mono/monodevelop/issues/2237/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2237/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/monodevelop/pulls/2237/commits"},"statuses":{"href":"https://api.github.com/repos/mono/monodevelop/statuses/6e3afb07253e6cae0aaec4c556068da47923a417"}}}}
|
{
"id": 791299,
"name": "mono/monodevelop",
"url": "https://api.github.com/repos/mono/monodevelop"
}
|
{
"id": 260349,
"login": "slluis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/260349?",
"url": "https://api.github.com/users/slluis"
}
|
{
"id": 53395,
"login": "mono",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53395?",
"url": "https://api.github.com/orgs/mono"
}
| 2017-04-21T18:46:59 |
5734006563
|
{"actor":{"display_login":"slluis"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mono/libgdiplus/pulls/comments/141488947","pull_request_review_id":65711379,"id":141488947,"diff_hunk":"@@ -529,7 +529,7 @@ gdip_region_bitmap_from_path (GpPath *path)\n \n \t/* here the memory is allocated for a ARGB bitmap - so 32 times bigger than our normal alpha bitmap */\n \tif ((size < 1) || (size > REGION_MAX_BITMAP_SIZE << 5)) {\n-\t\tg_warning (\"Path conversion requested %d bytes (%d x %d). Maximum size is %d bytes.\",\n+ g_warning (\"Path conversion requested %lu bytes (%d x %d). Maximum size is %d bytes.\",","path":"src/region-bitmap.c","position":5,"original_position":5,"commit_id":"0241c18aaf4be3e7619fb1845277c26e7a31dbf3","original_commit_id":"0241c18aaf4be3e7619fb1845277c26e7a31dbf3","user":{"login":"akoeplinger","id":1376924,"avatar_url":"https://avatars2.githubusercontent.com/u/1376924?v=4","gravatar_id":"","url":"https://api.github.com/users/akoeplinger","html_url":"https://github.com/akoeplinger","followers_url":"https://api.github.com/users/akoeplinger/followers","following_url":"https://api.github.com/users/akoeplinger/following{/other_user}","gists_url":"https://api.github.com/users/akoeplinger/gists{/gist_id}","starred_url":"https://api.github.com/users/akoeplinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akoeplinger/subscriptions","organizations_url":"https://api.github.com/users/akoeplinger/orgs","repos_url":"https://api.github.com/users/akoeplinger/repos","events_url":"https://api.github.com/users/akoeplinger/events{/privacy}","received_events_url":"https://api.github.com/users/akoeplinger/received_events","type":"User","site_admin":false},"body":"indentation","created_at":"2017-09-27T22:56:25Z","updated_at":"2017-09-27T23:02:24Z","html_url":"https://github.com/mono/libgdiplus/pull/106#discussion_r141488947","pull_request_url":"https://api.github.com/repos/mono/libgdiplus/pulls/106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/comments/141488947"},"html":{"href":"https://github.com/mono/libgdiplus/pull/106#discussion_r141488947"},"pull_request":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/mono/libgdiplus/pulls/106","id":143413892,"html_url":"https://github.com/mono/libgdiplus/pull/106","diff_url":"https://github.com/mono/libgdiplus/pull/106.diff","patch_url":"https://github.com/mono/libgdiplus/pull/106.patch","issue_url":"https://api.github.com/repos/mono/libgdiplus/issues/106","number":106,"state":"open","locked":false,"title":"Fix remaining Clang warnings","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-27T14:47:47Z","updated_at":"2017-09-27T23:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"867447f3e5cef38bfd1142381f6a43fc4eec8320","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/libgdiplus/pulls/106/commits","review_comments_url":"https://api.github.com/repos/mono/libgdiplus/pulls/106/comments","review_comment_url":"https://api.github.com/repos/mono/libgdiplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/libgdiplus/issues/106/comments","statuses_url":"https://api.github.com/repos/mono/libgdiplus/statuses/0241c18aaf4be3e7619fb1845277c26e7a31dbf3","head":{"label":"hughbe:clang-warnings","ref":"clang-warnings","sha":"0241c18aaf4be3e7619fb1845277c26e7a31dbf3","user":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"repo":{"id":95409644,"name":"libgdiplus","full_name":"hughbe/libgdiplus","owner":{"login":"hughbe","id":1275900,"avatar_url":"https://avatars0.githubusercontent.com/u/1275900?v=4","gravatar_id":"","url":"https://api.github.com/users/hughbe","html_url":"https://github.com/hughbe","followers_url":"https://api.github.com/users/hughbe/followers","following_url":"https://api.github.com/users/hughbe/following{/other_user}","gists_url":"https://api.github.com/users/hughbe/gists{/gist_id}","starred_url":"https://api.github.com/users/hughbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hughbe/subscriptions","organizations_url":"https://api.github.com/users/hughbe/orgs","repos_url":"https://api.github.com/users/hughbe/repos","events_url":"https://api.github.com/users/hughbe/events{/privacy}","received_events_url":"https://api.github.com/users/hughbe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hughbe/libgdiplus","description":"C-based implementation of the GDI+ API","fork":true,"url":"https://api.github.com/repos/hughbe/libgdiplus","forks_url":"https://api.github.com/repos/hughbe/libgdiplus/forks","keys_url":"https://api.github.com/repos/hughbe/libgdiplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hughbe/libgdiplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hughbe/libgdiplus/teams","hooks_url":"https://api.github.com/repos/hughbe/libgdiplus/hooks","issue_events_url":"https://api.github.com/repos/hughbe/libgdiplus/issues/events{/number}","events_url":"https://api.github.com/repos/hughbe/libgdiplus/events","assignees_url":"https://api.github.com/repos/hughbe/libgdiplus/assignees{/user}","branches_url":"https://api.github.com/repos/hughbe/libgdiplus/branches{/branch}","tags_url":"https://api.github.com/repos/hughbe/libgdiplus/tags","blobs_url":"https://api.github.com/repos/hughbe/libgdiplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hughbe/libgdiplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hughbe/libgdiplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/hughbe/libgdiplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hughbe/libgdiplus/statuses/{sha}","languages_url":"https://api.github.com/repos/hughbe/libgdiplus/languages","stargazers_url":"https://api.github.com/repos/hughbe/libgdiplus/stargazers","contributors_url":"https://api.github.com/repos/hughbe/libgdiplus/contributors","subscribers_url":"https://api.github.com/repos/hughbe/libgdiplus/subscribers","subscription_url":"https://api.github.com/repos/hughbe/libgdiplus/subscription","commits_url":"https://api.github.com/repos/hughbe/libgdiplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/hughbe/libgdiplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/hughbe/libgdiplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/hughbe/libgdiplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/hughbe/libgdiplus/contents/{+path}","compare_url":"https://api.github.com/repos/hughbe/libgdiplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hughbe/libgdiplus/merges","archive_url":"https://api.github.com/repos/hughbe/libgdiplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hughbe/libgdiplus/downloads","issues_url":"https://api.github.com/repos/hughbe/libgdiplus/issues{/number}","pulls_url":"https://api.github.com/repos/hughbe/libgdiplus/pulls{/number}","milestones_url":"https://api.github.com/repos/hughbe/libgdiplus/milestones{/number}","notifications_url":"https://api.github.com/repos/hughbe/libgdiplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hughbe/libgdiplus/labels{/name}","releases_url":"https://api.github.com/repos/hughbe/libgdiplus/releases{/id}","deployments_url":"https://api.github.com/repos/hughbe/libgdiplus/deployments","created_at":"2017-06-26T04:53:00Z","updated_at":"2017-06-26T04:53:02Z","pushed_at":"2017-09-27T22:02:29Z","git_url":"git://github.com/hughbe/libgdiplus.git","ssh_url":"git@github.com:hughbe/libgdiplus.git","clone_url":"https://github.com/hughbe/libgdiplus.git","svn_url":"https://github.com/hughbe/libgdiplus","homepage":"http://www.mono-project.com/","size":13262,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"2c01aff6271cc9a4f4bbdf87fe26f4142cd16225","user":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791260,"name":"libgdiplus","full_name":"mono/libgdiplus","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/libgdiplus","description":"C-based implementation of the GDI+ API","fork":false,"url":"https://api.github.com/repos/mono/libgdiplus","forks_url":"https://api.github.com/repos/mono/libgdiplus/forks","keys_url":"https://api.github.com/repos/mono/libgdiplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/libgdiplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/libgdiplus/teams","hooks_url":"https://api.github.com/repos/mono/libgdiplus/hooks","issue_events_url":"https://api.github.com/repos/mono/libgdiplus/issues/events{/number}","events_url":"https://api.github.com/repos/mono/libgdiplus/events","assignees_url":"https://api.github.com/repos/mono/libgdiplus/assignees{/user}","branches_url":"https://api.github.com/repos/mono/libgdiplus/branches{/branch}","tags_url":"https://api.github.com/repos/mono/libgdiplus/tags","blobs_url":"https://api.github.com/repos/mono/libgdiplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/libgdiplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/libgdiplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/libgdiplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/libgdiplus/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/libgdiplus/languages","stargazers_url":"https://api.github.com/repos/mono/libgdiplus/stargazers","contributors_url":"https://api.github.com/repos/mono/libgdiplus/contributors","subscribers_url":"https://api.github.com/repos/mono/libgdiplus/subscribers","subscription_url":"https://api.github.com/repos/mono/libgdiplus/subscription","commits_url":"https://api.github.com/repos/mono/libgdiplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/libgdiplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/libgdiplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/libgdiplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/libgdiplus/contents/{+path}","compare_url":"https://api.github.com/repos/mono/libgdiplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/libgdiplus/merges","archive_url":"https://api.github.com/repos/mono/libgdiplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/libgdiplus/downloads","issues_url":"https://api.github.com/repos/mono/libgdiplus/issues{/number}","pulls_url":"https://api.github.com/repos/mono/libgdiplus/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/libgdiplus/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/libgdiplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/libgdiplus/labels{/name}","releases_url":"https://api.github.com/repos/mono/libgdiplus/releases{/id}","deployments_url":"https://api.github.com/repos/mono/libgdiplus/deployments","created_at":"2010-07-22T15:56:20Z","updated_at":"2017-09-24T13:57:59Z","pushed_at":"2017-09-27T21:23:50Z","git_url":"git://github.com/mono/libgdiplus.git","ssh_url":"git@github.com:mono/libgdiplus.git","clone_url":"https://github.com/mono/libgdiplus.git","svn_url":"https://github.com/mono/libgdiplus","homepage":"http://www.mono-project.com/","size":13615,"stargazers_count":88,"watchers_count":88,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":5,"forks":78,"open_issues":5,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/106"},"html":{"href":"https://github.com/mono/libgdiplus/pull/106"},"issue":{"href":"https://api.github.com/repos/mono/libgdiplus/issues/106"},"comments":{"href":"https://api.github.com/repos/mono/libgdiplus/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/libgdiplus/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/mono/libgdiplus/statuses/0241c18aaf4be3e7619fb1845277c26e7a31dbf3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 791260,
"name": "mono/libgdiplus",
"url": "https://api.github.com/repos/mono/libgdiplus"
}
|
{
"id": 1376924,
"login": "akoeplinger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1376924?",
"url": "https://api.github.com/users/akoeplinger"
}
|
{
"id": 53395,
"login": "mono",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53395?",
"url": "https://api.github.com/orgs/mono"
}
| 2017-09-27T22:56:25 |
6646676174
|
{"actor":{"display_login":"akoeplinger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/155508502","pull_request_review_id":81836417,"id":155508502,"diff_hunk":"@@ -0,0 +1,67 @@\n+<?php\n+namespace Neos\\Flow\\Log;\n+\n+/**\n+ *","path":"Neos.Flow.Log/Classes/FormatUtility.php","position":5,"original_position":5,"commit_id":"2b7545c1d5ead36d806a1b2be08dd6d7bc8263a1","original_commit_id":"2b7545c1d5ead36d806a1b2be08dd6d7bc8263a1","user":{"login":"kdambekalns","id":95873,"avatar_url":"https://avatars2.githubusercontent.com/u/95873?v=4","gravatar_id":"","url":"https://api.github.com/users/kdambekalns","html_url":"https://github.com/kdambekalns","followers_url":"https://api.github.com/users/kdambekalns/followers","following_url":"https://api.github.com/users/kdambekalns/following{/other_user}","gists_url":"https://api.github.com/users/kdambekalns/gists{/gist_id}","starred_url":"https://api.github.com/users/kdambekalns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdambekalns/subscriptions","organizations_url":"https://api.github.com/users/kdambekalns/orgs","repos_url":"https://api.github.com/users/kdambekalns/repos","events_url":"https://api.github.com/users/kdambekalns/events{/privacy}","received_events_url":"https://api.github.com/users/kdambekalns/received_events","type":"User","site_admin":false},"body":"Some comment, maybe?\r\n\r\nAlso, the name `FormatUtility` sounds rather generic. Something completely different would be a `FormattedVariable` class, where you pass the `$variable` to the constructor and then call `getAsPlaintext()` on that. Phew. :)\r\n\r\nSpeaking of which, I think it should be \"plain text\", not \"plaintext\".","created_at":"2017-12-07T12:32:45Z","updated_at":"2017-12-07T12:44:27Z","html_url":"https://github.com/neos/flow-development-collection/pull/216#discussion_r155508502","pull_request_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/216","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/155508502"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/216#discussion_r155508502"},"pull_request":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/216","id":56748001,"html_url":"https://github.com/neos/flow-development-collection/pull/216","diff_url":"https://github.com/neos/flow-development-collection/pull/216.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/216.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/216","number":216,"state":"open","locked":false,"title":"TASK: Split Flow Log to separate package","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars2.githubusercontent.com/u/324408?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"body":"Creates the new `neos/flow-log` package containing the original\r\nlog infrastructure with the original namespace (`Neos\\Flow`). So\r\nnothing should change for userland code.\r\n\r\nThe Readme.rst contains a summary of dependencies of this package\r\nto make it easier to work on removing them and making this package\r\nmore independent of Flow.\r\n\r\nThe choosen way to split allows for transitioning to a new namespace\r\nwhile keeping the old classes.\r\n\r\nThe `SystemLoggerInterface` and `SecurityLoggerInterface` are kept\r\nin Flow as they have not much meaning in the Logger package. Additionally\r\nthe `EarlyLogger` was not moved as it depends on those interfaces.\r\n","created_at":"2016-01-21T13:20:57Z","updated_at":"2017-12-07T12:44:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4269146bf54c2da3f52dce4f5df2af6662244a75","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/216/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/216/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/216/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/2b7545c1d5ead36d806a1b2be08dd6d7bc8263a1","head":{"label":"kitsunet:split-log-package","ref":"split-log-package","sha":"2b7545c1d5ead36d806a1b2be08dd6d7bc8263a1","user":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars2.githubusercontent.com/u/324408?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"repo":{"id":41028859,"name":"flow-development-collection","full_name":"kitsunet/flow-development-collection","owner":{"login":"kitsunet","id":324408,"avatar_url":"https://avatars2.githubusercontent.com/u/324408?v=4","gravatar_id":"","url":"https://api.github.com/users/kitsunet","html_url":"https://github.com/kitsunet","followers_url":"https://api.github.com/users/kitsunet/followers","following_url":"https://api.github.com/users/kitsunet/following{/other_user}","gists_url":"https://api.github.com/users/kitsunet/gists{/gist_id}","starred_url":"https://api.github.com/users/kitsunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitsunet/subscriptions","organizations_url":"https://api.github.com/users/kitsunet/orgs","repos_url":"https://api.github.com/users/kitsunet/repos","events_url":"https://api.github.com/users/kitsunet/events{/privacy}","received_events_url":"https://api.github.com/users/kitsunet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kitsunet/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/kitsunet/flow-development-collection","forks_url":"https://api.github.com/repos/kitsunet/flow-development-collection/forks","keys_url":"https://api.github.com/repos/kitsunet/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitsunet/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitsunet/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/kitsunet/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/kitsunet/flow-development-collection/events","assignees_url":"https://api.github.com/repos/kitsunet/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/kitsunet/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/kitsunet/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitsunet/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/kitsunet/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/kitsunet/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/kitsunet/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/kitsunet/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/kitsunet/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/kitsunet/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitsunet/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitsunet/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitsunet/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/kitsunet/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitsunet/flow-development-collection/merges","archive_url":"https://api.github.com/repos/kitsunet/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitsunet/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/kitsunet/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/kitsunet/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/kitsunet/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/kitsunet/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitsunet/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/kitsunet/flow-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/kitsunet/flow-development-collection/deployments","created_at":"2015-08-19T10:55:38Z","updated_at":"2016-04-20T11:02:58Z","pushed_at":"2017-12-06T22:22:29Z","git_url":"git://github.com/kitsunet/flow-development-collection.git","ssh_url":"git@github.com:kitsunet/flow-development-collection.git","clone_url":"https://github.com/kitsunet/flow-development-collection.git","svn_url":"https://github.com/kitsunet/flow-development-collection","homepage":null,"size":42654,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:master","ref":"master","sha":"f21c9b238ceb29a77155976412ca63452893fe81","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars2.githubusercontent.com/u/11575267?v=4","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars2.githubusercontent.com/u/11575267?v=4","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","deployments_url":"https://api.github.com/repos/neos/flow-development-collection/deployments","created_at":"2015-08-18T09:48:13Z","updated_at":"2017-11-28T13:47:51Z","pushed_at":"2017-12-07T12:18:32Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":"https://flow.neos.io/","size":42652,"stargazers_count":56,"watchers_count":56,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":116,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":116,"open_issues":170,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/216"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/216"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/216"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/2b7545c1d5ead36d806a1b2be08dd6d7bc8263a1"}},"author_association":"OWNER"}}
|
{
"id": 40963991,
"name": "neos/flow-development-collection",
"url": "https://api.github.com/repos/neos/flow-development-collection"
}
|
{
"id": 95873,
"login": "kdambekalns",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/95873?",
"url": "https://api.github.com/users/kdambekalns"
}
|
{
"id": 11575267,
"login": "neos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11575267?",
"url": "https://api.github.com/orgs/neos"
}
| 2017-12-07T12:32:45 |
6956726132
|
{"actor":{"display_login":"kdambekalns"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nipy/dipy/pulls/comments/100468679","pull_request_review_id":21173529,"id":100468679,"diff_hunk":"@@ -0,0 +1,612 @@\n+import numpy as np\n+\n+from dipy.viz.interactor import CustomInteractorStyle\n+\n+from dipy.utils.optpkg import optional_package\n+\n+# Allow import, but disable doctests if we don't have vtk.\n+vtk, have_vtk, setup_module = optional_package('vtk')\n+\n+if have_vtk:\n+ version = vtk.vtkVersion.GetVTKSourceVersion().split(' ')[-1]\n+ major_version = vtk.vtkVersion.GetVTKMajorVersion()\n+else:\n+ vtkInteractorStyleUser = object\n+\n+\n+class UI(object):\n+ \"\"\" An umbrella class for all UI elements.\n+ While adding UI elements to the renderer, we go over all the sub-elements\n+ that come with it and add those to the renderer automatically.\n+\n+ Attributes\n+ ----------\n+ ui_param : object\n+ This is an attribute that can be passed to the UI object by the interactor.\n+ ui_list : list(UI)\n+ This is used when there are more than one UI elements inside\n+ a UI element. They're all automatically added to the renderer at the same time\n+ as this one.\n+ parent_UI: UI\n+ Reference to the parent UI element. This is useful of there is a parent\n+ UI element and its reference needs to be passed down to the child.\n+ on_left_mouse_button_pressed: function\n+ on_left_mouse_button_drag: function\n+ on_right_mouse_button_pressed: function\n+ on_right_mouse_button_drag: function\n+ \"\"\"\n+\n+ def __init__(self):\n+ self.ui_param = None\n+ self.ui_list = list()\n+\n+ self.parent_UI = None\n+ self._callbacks = []\n+\n+ self.left_button_state = \"released\"\n+ self.right_button_state = \"released\"\n+\n+ self.handle_events()\n+\n+ self.on_left_mouse_button_pressed = lambda i_ren, obj, element: None\n+ self.on_left_mouse_button_drag = lambda i_ren, obj, element: None\n+ self.on_right_mouse_button_pressed = lambda i_ren, obj, element: None\n+ self.on_right_mouse_button_drag = lambda i_ren, obj, element: None\n+\n+ def get_actors(self):\n+ \"\"\" Returns the actors that compose this UI component. \"\"\"\n+ msg = \"Subclasses of UI must implement `get_actors(self)`.\"\n+ raise NotImplementedError(msg)\n+\n+ def add_to_renderer(self, ren):\n+ \"\"\" Allows UI objects to add their own props to the renderer.\n+\n+ Parameters\n+ ----------\n+ ren : renderer\n+ \"\"\"\n+ ren.add(*self.get_actors())\n+\n+ # Get a hold on the current interactor style.\n+ iren = ren.GetRenderWindow().GetInteractor().GetInteractorStyle()\n+\n+ for callback in self._callbacks:\n+ if not isinstance(iren, CustomInteractorStyle):\n+ msg = (\"The ShowManager requires `CustomInteractorStyle` in\"\n+ \" order to use callbacks.\")\n+ raise TypeError(msg)\n+\n+ iren.add_callback(*callback, args=[self])\n+\n+ def add_callback(self, prop, event_type, callback, priority=0):\n+ \"\"\" Adds a callback to a specific event for this UI component.\n+\n+ Parameters\n+ ----------\n+ prop : vtkProp\n+ The prop on which is callback is to be added.\n+ event_type : string\n+ The event code.\n+ callback : function\n+ The callback function.\n+ priority : int\n+ \"\"\"\n+ # Actually since we need an interactor style we will add the callback\n+ # only when this UI component is added to the renderer.\n+ self._callbacks.append((prop, event_type, callback, priority))\n+\n+ def set_center(self, position):\n+ \"\"\" Sets the center of the UI component\n+\n+ Parameters\n+ ----------\n+ position : (float, float)\n+ \"\"\"\n+ msg = \"Subclasses of UI must implement `set_center(self, position)`.\"\n+ raise NotImplementedError(msg)\n+\n+ def set_visibility(self, visibility):\n+ \"\"\" Sets visibility of this UI component and all its sub-components. \"\"\"\n+ for actor in self.get_actors():\n+ actor.SetVisibility(visibility)\n+\n+ def handle_events(self):\n+ self.add_callback(\"LeftButtonPressEvent\", self.left_button_click_callback)\n+ self.add_callback(\"LeftButtonReleaseEvent\", self.left_button_release_callback)\n+ self.add_callback(\"RightButtonPressEvent\", self.right_button_click_callback)\n+ self.add_callback(\"RightButtonReleaseEvent\", self.right_button_release_callback)\n+ self.add_callback(\"MouseMoveEvent\", self.mouse_move_callback)\n+\n+ @staticmethod\n+ def left_button_click_callback(i_ren, obj, self):\n+ self.left_button_state = \"clicked\"\n+ i_ren.event.abort()\n+\n+ @staticmethod\n+ def left_button_release_callback(i_ren, obj, self):\n+ if self.left_button_state == \"clicked\":\n+ self.on_left_mouse_button_pressed(i_ren, obj, self)\n+ self.left_button_state = \"released\"\n+\n+ @staticmethod\n+ def right_button_click_callback(i_ren, obj, self):\n+ self.right_button_state = \"clicked\"\n+ i_ren.event.abort()\n+\n+ @staticmethod\n+ def right_button_release_callback(i_ren, obj, self):\n+ if self.right_button_state == \"clicked\":\n+ self.on_right_mouse_button_pressed(i_ren, obj, self)\n+ self.right_button_state = \"released\"\n+\n+ @staticmethod\n+ def mouse_move_callback(i_ren, obj, self):\n+ if self.left_button_state == \"clicked\" or self.left_button_state == \"dragging\":\n+ self.left_button_state = \"dragging\"\n+ self.on_left_mouse_button_drag(i_ren, obj, self)\n+ elif self.right_button_state == \"clicked\" or self.right_button_state == \"dragging\":\n+ self.right_button_state = \"dragging\"\n+ self.on_right_mouse_button_drag(i_ren, obj, self)\n+ else:\n+ pass\n+\n+\n+class Button2D(UI):\n+ \"\"\"A 2D overlay button and is of type vtkTexturedActor2D.\n+ Currently supports:\n+ - Multiple icons.\n+ - Switching between icons.\n+\n+ Attributes\n+ ----------\n+ size: (float, float)\n+ Button Size.\n+ \"\"\"\n+\n+ def __init__(self, icon_fnames, size=(30, 30)):\n+ \"\"\"\n+ Parameters\n+ ----------\n+ size : 2-tuple of int, optional\n+ Button size.\n+ icon_fnames : dict\n+ {iconname : filename, iconname : filename, ...}\n+ \"\"\"\n+ self.icon_extents = dict()\n+ self.icons = self.build_icons(icon_fnames)\n+ self.icon_names = list(self.icons.keys())\n+ self.current_icon_id = 0\n+ self.current_icon_name = self.icon_names[self.current_icon_id]\n+ self.actor = self.build_actor(self.icons[self.current_icon_name])\n+ self.size = size\n+ super(Button2D, self).__init__()\n+\n+ def build_icons(self, icon_fnames):\n+ \"\"\" Converts file names to vtkImageDataGeometryFilters.\n+ A pre-processing step to prevent re-read of file names during every state change.\n+\n+ Parameters\n+ ----------\n+ icon_fnames : dict\n+ {iconname: filename, iconname: filename, ...}\n+\n+ Returns\n+ -------\n+ icons : dict\n+ A dictionary of corresponding vtkImageDataGeometryFilters.\n+ \"\"\"\n+ icons = {}\n+ for icon_name, icon_fname in icon_fnames.items():\n+ if icon_fname.split(\".\")[-1] not in [\"png\", \"PNG\"]:\n+ print(\"Warning: A specified icon file is not in the PNG format. SKIPPING.\")\n+ else:\n+ png = vtk.vtkPNGReader()\n+ png.SetFileName(icon_fname)\n+ png.Update()\n+ icons[icon_name] = png.GetOutput()\n+\n+ return icons\n+\n+ @property\n+ def size(self):\n+ \"\"\"Gets the button size.\"\"\"\n+ return self._size\n+\n+ @size.setter\n+ def size(self, size):\n+ \"\"\"Sets the button size.","path":"dipy/viz/ui.py","position":217,"original_position":217,"commit_id":"3374fcbb99c95ba16115fa3f53d590f5e4927802","original_commit_id":"3374fcbb99c95ba16115fa3f53d590f5e4927802","user":{"login":"MarcCote","id":660004,"avatar_url":"https://avatars.githubusercontent.com/u/660004?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcCote","html_url":"https://github.com/MarcCote","followers_url":"https://api.github.com/users/MarcCote/followers","following_url":"https://api.github.com/users/MarcCote/following{/other_user}","gists_url":"https://api.github.com/users/MarcCote/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcCote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcCote/subscriptions","organizations_url":"https://api.github.com/users/MarcCote/orgs","repos_url":"https://api.github.com/users/MarcCote/repos","events_url":"https://api.github.com/users/MarcCote/events{/privacy}","received_events_url":"https://api.github.com/users/MarcCote/received_events","type":"User","site_admin":false},"body":"space","created_at":"2017-02-10T04:13:05Z","updated_at":"2017-02-10T04:23:20Z","html_url":"https://github.com/nipy/dipy/pull/1140#discussion_r100468679","pull_request_url":"https://api.github.com/repos/nipy/dipy/pulls/1140","_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments/100468679"},"html":{"href":"https://github.com/nipy/dipy/pull/1140#discussion_r100468679"},"pull_request":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1140"}}},"pull_request":{"url":"https://api.github.com/repos/nipy/dipy/pulls/1140","id":91999649,"html_url":"https://github.com/nipy/dipy/pull/1140","diff_url":"https://github.com/nipy/dipy/pull/1140.diff","patch_url":"https://github.com/nipy/dipy/pull/1140.patch","issue_url":"https://api.github.com/repos/nipy/dipy/issues/1140","number":1140,"state":"open","locked":false,"title":"A lightweight UI for medical visualizations #1: Button","user":{"login":"ranveeraggarwal","id":3941281,"avatar_url":"https://avatars.githubusercontent.com/u/3941281?v=3","gravatar_id":"","url":"https://api.github.com/users/ranveeraggarwal","html_url":"https://github.com/ranveeraggarwal","followers_url":"https://api.github.com/users/ranveeraggarwal/followers","following_url":"https://api.github.com/users/ranveeraggarwal/following{/other_user}","gists_url":"https://api.github.com/users/ranveeraggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ranveeraggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranveeraggarwal/subscriptions","organizations_url":"https://api.github.com/users/ranveeraggarwal/orgs","repos_url":"https://api.github.com/users/ranveeraggarwal/repos","events_url":"https://api.github.com/users/ranveeraggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ranveeraggarwal/received_events","type":"User","site_admin":false},"body":"This is one of the several PRs that will be made over time to incorporate features of #1111 with tests.","created_at":"2016-11-02T15:58:23Z","updated_at":"2017-02-10T04:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94e375ed4034f3747b78dccbf64c6192724aef7a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nipy/dipy/pulls/1140/commits","review_comments_url":"https://api.github.com/repos/nipy/dipy/pulls/1140/comments","review_comment_url":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nipy/dipy/issues/1140/comments","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/3374fcbb99c95ba16115fa3f53d590f5e4927802","head":{"label":"ranveeraggarwal:ui","ref":"ui","sha":"3374fcbb99c95ba16115fa3f53d590f5e4927802","user":{"login":"ranveeraggarwal","id":3941281,"avatar_url":"https://avatars.githubusercontent.com/u/3941281?v=3","gravatar_id":"","url":"https://api.github.com/users/ranveeraggarwal","html_url":"https://github.com/ranveeraggarwal","followers_url":"https://api.github.com/users/ranveeraggarwal/followers","following_url":"https://api.github.com/users/ranveeraggarwal/following{/other_user}","gists_url":"https://api.github.com/users/ranveeraggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ranveeraggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranveeraggarwal/subscriptions","organizations_url":"https://api.github.com/users/ranveeraggarwal/orgs","repos_url":"https://api.github.com/users/ranveeraggarwal/repos","events_url":"https://api.github.com/users/ranveeraggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ranveeraggarwal/received_events","type":"User","site_admin":false},"repo":{"id":57324078,"name":"dipy","full_name":"ranveeraggarwal/dipy","owner":{"login":"ranveeraggarwal","id":3941281,"avatar_url":"https://avatars.githubusercontent.com/u/3941281?v=3","gravatar_id":"","url":"https://api.github.com/users/ranveeraggarwal","html_url":"https://github.com/ranveeraggarwal","followers_url":"https://api.github.com/users/ranveeraggarwal/followers","following_url":"https://api.github.com/users/ranveeraggarwal/following{/other_user}","gists_url":"https://api.github.com/users/ranveeraggarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ranveeraggarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranveeraggarwal/subscriptions","organizations_url":"https://api.github.com/users/ranveeraggarwal/orgs","repos_url":"https://api.github.com/users/ranveeraggarwal/repos","events_url":"https://api.github.com/users/ranveeraggarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ranveeraggarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ranveeraggarwal/dipy","description":"Diffusion MR Imaging in Python","fork":true,"url":"https://api.github.com/repos/ranveeraggarwal/dipy","forks_url":"https://api.github.com/repos/ranveeraggarwal/dipy/forks","keys_url":"https://api.github.com/repos/ranveeraggarwal/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ranveeraggarwal/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ranveeraggarwal/dipy/teams","hooks_url":"https://api.github.com/repos/ranveeraggarwal/dipy/hooks","issue_events_url":"https://api.github.com/repos/ranveeraggarwal/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/ranveeraggarwal/dipy/events","assignees_url":"https://api.github.com/repos/ranveeraggarwal/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/ranveeraggarwal/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/ranveeraggarwal/dipy/tags","blobs_url":"https://api.github.com/repos/ranveeraggarwal/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ranveeraggarwal/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ranveeraggarwal/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/ranveeraggarwal/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ranveeraggarwal/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/ranveeraggarwal/dipy/languages","stargazers_url":"https://api.github.com/repos/ranveeraggarwal/dipy/stargazers","contributors_url":"https://api.github.com/repos/ranveeraggarwal/dipy/contributors","subscribers_url":"https://api.github.com/repos/ranveeraggarwal/dipy/subscribers","subscription_url":"https://api.github.com/repos/ranveeraggarwal/dipy/subscription","commits_url":"https://api.github.com/repos/ranveeraggarwal/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/ranveeraggarwal/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/ranveeraggarwal/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/ranveeraggarwal/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/ranveeraggarwal/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/ranveeraggarwal/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ranveeraggarwal/dipy/merges","archive_url":"https://api.github.com/repos/ranveeraggarwal/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ranveeraggarwal/dipy/downloads","issues_url":"https://api.github.com/repos/ranveeraggarwal/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/ranveeraggarwal/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/ranveeraggarwal/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/ranveeraggarwal/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ranveeraggarwal/dipy/labels{/name}","releases_url":"https://api.github.com/repos/ranveeraggarwal/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/ranveeraggarwal/dipy/deployments","created_at":"2016-04-28T18:16:53Z","updated_at":"2016-04-28T18:16:55Z","pushed_at":"2017-02-09T17:09:28Z","git_url":"git://github.com/ranveeraggarwal/dipy.git","ssh_url":"git@github.com:ranveeraggarwal/dipy.git","clone_url":"https://github.com/ranveeraggarwal/dipy.git","svn_url":"https://github.com/ranveeraggarwal/dipy","homepage":"http://dipy.org","size":31766,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"ui"}},"base":{"label":"nipy:master","ref":"master","sha":"94a46684639486535b509e5666f5b2d31bf92c61","user":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"repo":{"id":505209,"name":"dipy","full_name":"nipy/dipy","owner":{"login":"nipy","id":233707,"avatar_url":"https://avatars.githubusercontent.com/u/233707?v=3","gravatar_id":"","url":"https://api.github.com/users/nipy","html_url":"https://github.com/nipy","followers_url":"https://api.github.com/users/nipy/followers","following_url":"https://api.github.com/users/nipy/following{/other_user}","gists_url":"https://api.github.com/users/nipy/gists{/gist_id}","starred_url":"https://api.github.com/users/nipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nipy/subscriptions","organizations_url":"https://api.github.com/users/nipy/orgs","repos_url":"https://api.github.com/users/nipy/repos","events_url":"https://api.github.com/users/nipy/events{/privacy}","received_events_url":"https://api.github.com/users/nipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nipy/dipy","description":"Diffusion MR Imaging in Python","fork":false,"url":"https://api.github.com/repos/nipy/dipy","forks_url":"https://api.github.com/repos/nipy/dipy/forks","keys_url":"https://api.github.com/repos/nipy/dipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nipy/dipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nipy/dipy/teams","hooks_url":"https://api.github.com/repos/nipy/dipy/hooks","issue_events_url":"https://api.github.com/repos/nipy/dipy/issues/events{/number}","events_url":"https://api.github.com/repos/nipy/dipy/events","assignees_url":"https://api.github.com/repos/nipy/dipy/assignees{/user}","branches_url":"https://api.github.com/repos/nipy/dipy/branches{/branch}","tags_url":"https://api.github.com/repos/nipy/dipy/tags","blobs_url":"https://api.github.com/repos/nipy/dipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nipy/dipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nipy/dipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/nipy/dipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nipy/dipy/statuses/{sha}","languages_url":"https://api.github.com/repos/nipy/dipy/languages","stargazers_url":"https://api.github.com/repos/nipy/dipy/stargazers","contributors_url":"https://api.github.com/repos/nipy/dipy/contributors","subscribers_url":"https://api.github.com/repos/nipy/dipy/subscribers","subscription_url":"https://api.github.com/repos/nipy/dipy/subscription","commits_url":"https://api.github.com/repos/nipy/dipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/nipy/dipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/nipy/dipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/nipy/dipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/nipy/dipy/contents/{+path}","compare_url":"https://api.github.com/repos/nipy/dipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nipy/dipy/merges","archive_url":"https://api.github.com/repos/nipy/dipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nipy/dipy/downloads","issues_url":"https://api.github.com/repos/nipy/dipy/issues{/number}","pulls_url":"https://api.github.com/repos/nipy/dipy/pulls{/number}","milestones_url":"https://api.github.com/repos/nipy/dipy/milestones{/number}","notifications_url":"https://api.github.com/repos/nipy/dipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nipy/dipy/labels{/name}","releases_url":"https://api.github.com/repos/nipy/dipy/releases{/id}","deployments_url":"https://api.github.com/repos/nipy/dipy/deployments","created_at":"2010-02-06T11:43:08Z","updated_at":"2017-01-16T11:34:26Z","pushed_at":"2017-02-09T17:09:30Z","git_url":"git://github.com/nipy/dipy.git","ssh_url":"git@github.com:nipy/dipy.git","clone_url":"https://github.com/nipy/dipy.git","svn_url":"https://github.com/nipy/dipy","homepage":"http://dipy.org","size":29909,"stargazers_count":103,"watchers_count":103,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":149,"forks":153,"open_issues":149,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1140"},"html":{"href":"https://github.com/nipy/dipy/pull/1140"},"issue":{"href":"https://api.github.com/repos/nipy/dipy/issues/1140"},"comments":{"href":"https://api.github.com/repos/nipy/dipy/issues/1140/comments"},"review_comments":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1140/comments"},"review_comment":{"href":"https://api.github.com/repos/nipy/dipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nipy/dipy/pulls/1140/commits"},"statuses":{"href":"https://api.github.com/repos/nipy/dipy/statuses/3374fcbb99c95ba16115fa3f53d590f5e4927802"}}}}
|
{
"id": 505209,
"name": "nipy/dipy",
"url": "https://api.github.com/repos/nipy/dipy"
}
|
{
"id": 660004,
"login": "MarcCote",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/660004?",
"url": "https://api.github.com/users/MarcCote"
}
|
{
"id": 233707,
"login": "nipy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/233707?",
"url": "https://api.github.com/orgs/nipy"
}
| 2017-02-10T04:13:05 |
5300356667
|
{"actor":{"display_login":"MarcCote"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/onnx/onnx/pulls/comments/150295132","pull_request_review_id":75827015,"id":150295132,"diff_hunk":"@@ -229,8 +242,10 @@ def create_extension(ExtType, name, sources, dependencies, extra_link_args, extr\n class ONNXCpp2PyExtension(setuptools.Extension):\n def pre_run(self):\n self.sources = recursive_glob(SRC_DIR, '*.cc')\n- if os.path.join(SRC_DIR, \"onnx-ml.pb.cc\") in self.sources:\n+ if (os.path.join(SRC_DIR, \"onnx-ml.pb.cc\") in self.sources and 0 == ONNX_ML):","path":"setup.py","position":70,"original_position":70,"commit_id":"e3e52506be27e5ae35fac33685e06abf24abeeab","original_commit_id":"e3e52506be27e5ae35fac33685e06abf24abeeab","user":{"login":"bddppq","id":9300575,"avatar_url":"https://avatars2.githubusercontent.com/u/9300575?v=4","gravatar_id":"","url":"https://api.github.com/users/bddppq","html_url":"https://github.com/bddppq","followers_url":"https://api.github.com/users/bddppq/followers","following_url":"https://api.github.com/users/bddppq/following{/other_user}","gists_url":"https://api.github.com/users/bddppq/gists{/gist_id}","starred_url":"https://api.github.com/users/bddppq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bddppq/subscriptions","organizations_url":"https://api.github.com/users/bddppq/orgs","repos_url":"https://api.github.com/users/bddppq/repos","events_url":"https://api.github.com/users/bddppq/events{/privacy}","received_events_url":"https://api.github.com/users/bddppq/received_events","type":"User","site_admin":false},"body":"Yes agree, please pick out the correct 'pb.cc' file instead of raising errors.\r\nAnd like above, do not use `0 == ONNX_ML`, it's a boolean already.","created_at":"2017-11-10T17:33:19Z","updated_at":"2017-11-10T17:35:07Z","html_url":"https://github.com/onnx/onnx/pull/226#discussion_r150295132","pull_request_url":"https://api.github.com/repos/onnx/onnx/pulls/226","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments/150295132"},"html":{"href":"https://github.com/onnx/onnx/pull/226#discussion_r150295132"},"pull_request":{"href":"https://api.github.com/repos/onnx/onnx/pulls/226"}},"in_reply_to_id":150181550},"pull_request":{"url":"https://api.github.com/repos/onnx/onnx/pulls/226","id":151842659,"html_url":"https://github.com/onnx/onnx/pull/226","diff_url":"https://github.com/onnx/onnx/pull/226.diff","patch_url":"https://github.com/onnx/onnx/pull/226.patch","issue_url":"https://api.github.com/repos/onnx/onnx/issues/226","number":226,"state":"open","locked":false,"title":"add argument \"--onnxml=1\" to enable onnx-ml.proto build","user":{"login":"linkerzhang","id":5194557,"avatar_url":"https://avatars2.githubusercontent.com/u/5194557?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerzhang","html_url":"https://github.com/linkerzhang","followers_url":"https://api.github.com/users/linkerzhang/followers","following_url":"https://api.github.com/users/linkerzhang/following{/other_user}","gists_url":"https://api.github.com/users/linkerzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerzhang/subscriptions","organizations_url":"https://api.github.com/users/linkerzhang/orgs","repos_url":"https://api.github.com/users/linkerzhang/repos","events_url":"https://api.github.com/users/linkerzhang/events{/privacy}","received_events_url":"https://api.github.com/users/linkerzhang/received_events","type":"User","site_admin":false},"body":"Add customized argument \"--onnxml=1\" to enable onnx-ml proto build.","created_at":"2017-11-10T07:29:05Z","updated_at":"2017-11-10T17:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be5711c4a5e38cd6a421ccfbd081beee89f8006a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ezyang","id":13564,"avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},{"login":"donbox","id":520275,"avatar_url":"https://avatars0.githubusercontent.com/u/520275?v=4","gravatar_id":"","url":"https://api.github.com/users/donbox","html_url":"https://github.com/donbox","followers_url":"https://api.github.com/users/donbox/followers","following_url":"https://api.github.com/users/donbox/following{/other_user}","gists_url":"https://api.github.com/users/donbox/gists{/gist_id}","starred_url":"https://api.github.com/users/donbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donbox/subscriptions","organizations_url":"https://api.github.com/users/donbox/orgs","repos_url":"https://api.github.com/users/donbox/repos","events_url":"https://api.github.com/users/donbox/events{/privacy}","received_events_url":"https://api.github.com/users/donbox/received_events","type":"User","site_admin":false},{"login":"yuanbyu","id":2342391,"avatar_url":"https://avatars1.githubusercontent.com/u/2342391?v=4","gravatar_id":"","url":"https://api.github.com/users/yuanbyu","html_url":"https://github.com/yuanbyu","followers_url":"https://api.github.com/users/yuanbyu/followers","following_url":"https://api.github.com/users/yuanbyu/following{/other_user}","gists_url":"https://api.github.com/users/yuanbyu/gists{/gist_id}","starred_url":"https://api.github.com/users/yuanbyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuanbyu/subscriptions","organizations_url":"https://api.github.com/users/yuanbyu/orgs","repos_url":"https://api.github.com/users/yuanbyu/repos","events_url":"https://api.github.com/users/yuanbyu/events{/privacy}","received_events_url":"https://api.github.com/users/yuanbyu/received_events","type":"User","site_admin":false},{"login":"jywumsft","id":31933502,"avatar_url":"https://avatars3.githubusercontent.com/u/31933502?v=4","gravatar_id":"","url":"https://api.github.com/users/jywumsft","html_url":"https://github.com/jywumsft","followers_url":"https://api.github.com/users/jywumsft/followers","following_url":"https://api.github.com/users/jywumsft/following{/other_user}","gists_url":"https://api.github.com/users/jywumsft/gists{/gist_id}","starred_url":"https://api.github.com/users/jywumsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jywumsft/subscriptions","organizations_url":"https://api.github.com/users/jywumsft/orgs","repos_url":"https://api.github.com/users/jywumsft/repos","events_url":"https://api.github.com/users/jywumsft/events{/privacy}","received_events_url":"https://api.github.com/users/jywumsft/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/onnx/onnx/pulls/226/commits","review_comments_url":"https://api.github.com/repos/onnx/onnx/pulls/226/comments","review_comment_url":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onnx/onnx/issues/226/comments","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/e3e52506be27e5ae35fac33685e06abf24abeeab","head":{"label":"linkerzhang:kezhan/build_onnx_ml","ref":"kezhan/build_onnx_ml","sha":"e3e52506be27e5ae35fac33685e06abf24abeeab","user":{"login":"linkerzhang","id":5194557,"avatar_url":"https://avatars2.githubusercontent.com/u/5194557?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerzhang","html_url":"https://github.com/linkerzhang","followers_url":"https://api.github.com/users/linkerzhang/followers","following_url":"https://api.github.com/users/linkerzhang/following{/other_user}","gists_url":"https://api.github.com/users/linkerzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerzhang/subscriptions","organizations_url":"https://api.github.com/users/linkerzhang/orgs","repos_url":"https://api.github.com/users/linkerzhang/repos","events_url":"https://api.github.com/users/linkerzhang/events{/privacy}","received_events_url":"https://api.github.com/users/linkerzhang/received_events","type":"User","site_admin":false},"repo":{"id":104685327,"name":"onnx","full_name":"linkerzhang/onnx","owner":{"login":"linkerzhang","id":5194557,"avatar_url":"https://avatars2.githubusercontent.com/u/5194557?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerzhang","html_url":"https://github.com/linkerzhang","followers_url":"https://api.github.com/users/linkerzhang/followers","following_url":"https://api.github.com/users/linkerzhang/following{/other_user}","gists_url":"https://api.github.com/users/linkerzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerzhang/subscriptions","organizations_url":"https://api.github.com/users/linkerzhang/orgs","repos_url":"https://api.github.com/users/linkerzhang/repos","events_url":"https://api.github.com/users/linkerzhang/events{/privacy}","received_events_url":"https://api.github.com/users/linkerzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/linkerzhang/onnx","description":"Open Neural Network Exchange","fork":true,"url":"https://api.github.com/repos/linkerzhang/onnx","forks_url":"https://api.github.com/repos/linkerzhang/onnx/forks","keys_url":"https://api.github.com/repos/linkerzhang/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerzhang/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerzhang/onnx/teams","hooks_url":"https://api.github.com/repos/linkerzhang/onnx/hooks","issue_events_url":"https://api.github.com/repos/linkerzhang/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/linkerzhang/onnx/events","assignees_url":"https://api.github.com/repos/linkerzhang/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/linkerzhang/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/linkerzhang/onnx/tags","blobs_url":"https://api.github.com/repos/linkerzhang/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerzhang/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerzhang/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerzhang/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerzhang/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerzhang/onnx/languages","stargazers_url":"https://api.github.com/repos/linkerzhang/onnx/stargazers","contributors_url":"https://api.github.com/repos/linkerzhang/onnx/contributors","subscribers_url":"https://api.github.com/repos/linkerzhang/onnx/subscribers","subscription_url":"https://api.github.com/repos/linkerzhang/onnx/subscription","commits_url":"https://api.github.com/repos/linkerzhang/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerzhang/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerzhang/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerzhang/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerzhang/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/linkerzhang/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerzhang/onnx/merges","archive_url":"https://api.github.com/repos/linkerzhang/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerzhang/onnx/downloads","issues_url":"https://api.github.com/repos/linkerzhang/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/linkerzhang/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerzhang/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerzhang/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerzhang/onnx/labels{/name}","releases_url":"https://api.github.com/repos/linkerzhang/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/linkerzhang/onnx/deployments","created_at":"2017-09-25T00:09:43Z","updated_at":"2017-09-25T00:09:45Z","pushed_at":"2017-11-10T17:23:40Z","git_url":"git://github.com/linkerzhang/onnx.git","ssh_url":"git@github.com:linkerzhang/onnx.git","clone_url":"https://github.com/linkerzhang/onnx.git","svn_url":"https://github.com/linkerzhang/onnx","homepage":null,"size":564,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onnx:master","ref":"master","sha":"28e9ee20deecac831e2db80b0d3cd8db63211b19","user":{"login":"onnx","id":31675368,"avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"repo":{"id":102692863,"name":"onnx","full_name":"onnx/onnx","owner":{"login":"onnx","id":31675368,"avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onnx/onnx","description":"Open Neural Network Exchange","fork":false,"url":"https://api.github.com/repos/onnx/onnx","forks_url":"https://api.github.com/repos/onnx/onnx/forks","keys_url":"https://api.github.com/repos/onnx/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onnx/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onnx/onnx/teams","hooks_url":"https://api.github.com/repos/onnx/onnx/hooks","issue_events_url":"https://api.github.com/repos/onnx/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/onnx/onnx/events","assignees_url":"https://api.github.com/repos/onnx/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/onnx/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/onnx/onnx/tags","blobs_url":"https://api.github.com/repos/onnx/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onnx/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onnx/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onnx/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/onnx/onnx/languages","stargazers_url":"https://api.github.com/repos/onnx/onnx/stargazers","contributors_url":"https://api.github.com/repos/onnx/onnx/contributors","subscribers_url":"https://api.github.com/repos/onnx/onnx/subscribers","subscription_url":"https://api.github.com/repos/onnx/onnx/subscription","commits_url":"https://api.github.com/repos/onnx/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onnx/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onnx/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onnx/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onnx/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/onnx/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onnx/onnx/merges","archive_url":"https://api.github.com/repos/onnx/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onnx/onnx/downloads","issues_url":"https://api.github.com/repos/onnx/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/onnx/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/onnx/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/onnx/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onnx/onnx/labels{/name}","releases_url":"https://api.github.com/repos/onnx/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/onnx/onnx/deployments","created_at":"2017-09-07T04:53:45Z","updated_at":"2017-11-10T14:33:37Z","pushed_at":"2017-11-10T17:01:10Z","git_url":"git://github.com/onnx/onnx.git","ssh_url":"git@github.com:onnx/onnx.git","clone_url":"https://github.com/onnx/onnx.git","svn_url":"https://github.com/onnx/onnx","homepage":"https://onnx.ai/","size":705,"stargazers_count":1535,"watchers_count":1535,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":59,"forks":129,"open_issues":59,"watchers":1535,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/226"},"html":{"href":"https://github.com/onnx/onnx/pull/226"},"issue":{"href":"https://api.github.com/repos/onnx/onnx/issues/226"},"comments":{"href":"https://api.github.com/repos/onnx/onnx/issues/226/comments"},"review_comments":{"href":"https://api.github.com/repos/onnx/onnx/pulls/226/comments"},"review_comment":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onnx/onnx/pulls/226/commits"},"statuses":{"href":"https://api.github.com/repos/onnx/onnx/statuses/e3e52506be27e5ae35fac33685e06abf24abeeab"}},"author_association":"MEMBER"}}
|
{
"id": 102692863,
"name": "onnx/onnx",
"url": "https://api.github.com/repos/onnx/onnx"
}
|
{
"id": 9300575,
"login": "bddppq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9300575?",
"url": "https://api.github.com/users/bddppq"
}
|
{
"id": 31675368,
"login": "onnx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31675368?",
"url": "https://api.github.com/orgs/onnx"
}
| 2017-11-10T17:33:19 |
6839005319
|
{"actor":{"display_login":"bddppq"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/pynacl/pulls/comments/136237273","pull_request_review_id":59746521,"id":136237273,"diff_hunk":"@@ -244,3 +244,28 @@ def test_box_seal_wrong_types():\n with pytest.raises(TypeError):\n c.crypto_box_seal_open(\n None, A_pubkey, A_secretkey)\n+\n+\n+def test_box_seed_keypair_reference():\n+\n+ from box_secret_from_seed_ref import test_seed, test_pk, test_sk","path":"tests/test_bindings.py","position":8,"original_position":8,"commit_id":"41962239b23e8b2fa1936b98d80289632501de26","original_commit_id":"41962239b23e8b2fa1936b98d80289632501de26","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars2.githubusercontent.com/u/161495?v=4","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"body":"Oh, having said that I see they're used in both test_bindings and test_box so nevermind.\r\n\r\nDo we have any other python files containing vectors like this? Typically we've made these types of vectors text files that we load and parse.","created_at":"2017-08-31T03:07:38Z","updated_at":"2017-08-31T03:07:38Z","html_url":"https://github.com/pyca/pynacl/pull/317#discussion_r136237273","pull_request_url":"https://api.github.com/repos/pyca/pynacl/pulls/317","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/comments/136237273"},"html":{"href":"https://github.com/pyca/pynacl/pull/317#discussion_r136237273"},"pull_request":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/317"}},"in_reply_to_id":136237164},"pull_request":{"url":"https://api.github.com/repos/pyca/pynacl/pulls/317","id":128368541,"html_url":"https://github.com/pyca/pynacl/pull/317","diff_url":"https://github.com/pyca/pynacl/pull/317.diff","patch_url":"https://github.com/pyca/pynacl/pull/317.patch","issue_url":"https://api.github.com/repos/pyca/pynacl/issues/317","number":317,"state":"open","locked":false,"title":"Add \"from_seed\" APIs for public key encryption","user":{"login":"lmctv","id":1045050,"avatar_url":"https://avatars0.githubusercontent.com/u/1045050?v=4","gravatar_id":"","url":"https://api.github.com/users/lmctv","html_url":"https://github.com/lmctv","followers_url":"https://api.github.com/users/lmctv/followers","following_url":"https://api.github.com/users/lmctv/following{/other_user}","gists_url":"https://api.github.com/users/lmctv/gists{/gist_id}","starred_url":"https://api.github.com/users/lmctv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmctv/subscriptions","organizations_url":"https://api.github.com/users/lmctv/orgs","repos_url":"https://api.github.com/users/lmctv/repos","events_url":"https://api.github.com/users/lmctv/events{/privacy}","received_events_url":"https://api.github.com/users/lmctv/received_events","type":"User","site_admin":false},"body":"Should fulfill #292 requirements.","created_at":"2017-06-30T13:20:38Z","updated_at":"2017-08-31T03:07:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76f5b6ba69b8ba35eba5f856b43b7ffe80548f1b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pyca/pynacl/pulls/317/commits","review_comments_url":"https://api.github.com/repos/pyca/pynacl/pulls/317/comments","review_comment_url":"https://api.github.com/repos/pyca/pynacl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyca/pynacl/issues/317/comments","statuses_url":"https://api.github.com/repos/pyca/pynacl/statuses/41962239b23e8b2fa1936b98d80289632501de26","head":{"label":"lmctv:add-box-from-seed-api","ref":"add-box-from-seed-api","sha":"41962239b23e8b2fa1936b98d80289632501de26","user":{"login":"lmctv","id":1045050,"avatar_url":"https://avatars0.githubusercontent.com/u/1045050?v=4","gravatar_id":"","url":"https://api.github.com/users/lmctv","html_url":"https://github.com/lmctv","followers_url":"https://api.github.com/users/lmctv/followers","following_url":"https://api.github.com/users/lmctv/following{/other_user}","gists_url":"https://api.github.com/users/lmctv/gists{/gist_id}","starred_url":"https://api.github.com/users/lmctv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmctv/subscriptions","organizations_url":"https://api.github.com/users/lmctv/orgs","repos_url":"https://api.github.com/users/lmctv/repos","events_url":"https://api.github.com/users/lmctv/events{/privacy}","received_events_url":"https://api.github.com/users/lmctv/received_events","type":"User","site_admin":false},"repo":{"id":60359592,"name":"pynacl","full_name":"lmctv/pynacl","owner":{"login":"lmctv","id":1045050,"avatar_url":"https://avatars0.githubusercontent.com/u/1045050?v=4","gravatar_id":"","url":"https://api.github.com/users/lmctv","html_url":"https://github.com/lmctv","followers_url":"https://api.github.com/users/lmctv/followers","following_url":"https://api.github.com/users/lmctv/following{/other_user}","gists_url":"https://api.github.com/users/lmctv/gists{/gist_id}","starred_url":"https://api.github.com/users/lmctv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmctv/subscriptions","organizations_url":"https://api.github.com/users/lmctv/orgs","repos_url":"https://api.github.com/users/lmctv/repos","events_url":"https://api.github.com/users/lmctv/events{/privacy}","received_events_url":"https://api.github.com/users/lmctv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lmctv/pynacl","description":"Python binding to the Networking and Cryptography (NaCl) library","fork":true,"url":"https://api.github.com/repos/lmctv/pynacl","forks_url":"https://api.github.com/repos/lmctv/pynacl/forks","keys_url":"https://api.github.com/repos/lmctv/pynacl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmctv/pynacl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmctv/pynacl/teams","hooks_url":"https://api.github.com/repos/lmctv/pynacl/hooks","issue_events_url":"https://api.github.com/repos/lmctv/pynacl/issues/events{/number}","events_url":"https://api.github.com/repos/lmctv/pynacl/events","assignees_url":"https://api.github.com/repos/lmctv/pynacl/assignees{/user}","branches_url":"https://api.github.com/repos/lmctv/pynacl/branches{/branch}","tags_url":"https://api.github.com/repos/lmctv/pynacl/tags","blobs_url":"https://api.github.com/repos/lmctv/pynacl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmctv/pynacl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmctv/pynacl/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmctv/pynacl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmctv/pynacl/statuses/{sha}","languages_url":"https://api.github.com/repos/lmctv/pynacl/languages","stargazers_url":"https://api.github.com/repos/lmctv/pynacl/stargazers","contributors_url":"https://api.github.com/repos/lmctv/pynacl/contributors","subscribers_url":"https://api.github.com/repos/lmctv/pynacl/subscribers","subscription_url":"https://api.github.com/repos/lmctv/pynacl/subscription","commits_url":"https://api.github.com/repos/lmctv/pynacl/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmctv/pynacl/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmctv/pynacl/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmctv/pynacl/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmctv/pynacl/contents/{+path}","compare_url":"https://api.github.com/repos/lmctv/pynacl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmctv/pynacl/merges","archive_url":"https://api.github.com/repos/lmctv/pynacl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmctv/pynacl/downloads","issues_url":"https://api.github.com/repos/lmctv/pynacl/issues{/number}","pulls_url":"https://api.github.com/repos/lmctv/pynacl/pulls{/number}","milestones_url":"https://api.github.com/repos/lmctv/pynacl/milestones{/number}","notifications_url":"https://api.github.com/repos/lmctv/pynacl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmctv/pynacl/labels{/name}","releases_url":"https://api.github.com/repos/lmctv/pynacl/releases{/id}","deployments_url":"https://api.github.com/repos/lmctv/pynacl/deployments","created_at":"2016-06-03T15:48:53Z","updated_at":"2016-06-03T15:48:58Z","pushed_at":"2017-08-27T16:12:20Z","git_url":"git://github.com/lmctv/pynacl.git","ssh_url":"git@github.com:lmctv/pynacl.git","clone_url":"https://github.com/lmctv/pynacl.git","svn_url":"https://github.com/lmctv/pynacl","homepage":"https://pynacl.readthedocs.io/","size":5009,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"30ea7a6ea5791ebc403e000d94e4aad14f85f29e","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars1.githubusercontent.com/u/5615737?v=4","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":8350032,"name":"pynacl","full_name":"pyca/pynacl","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars1.githubusercontent.com/u/5615737?v=4","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/pynacl","description":"Python binding to the Networking and Cryptography (NaCl) library","fork":false,"url":"https://api.github.com/repos/pyca/pynacl","forks_url":"https://api.github.com/repos/pyca/pynacl/forks","keys_url":"https://api.github.com/repos/pyca/pynacl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/pynacl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/pynacl/teams","hooks_url":"https://api.github.com/repos/pyca/pynacl/hooks","issue_events_url":"https://api.github.com/repos/pyca/pynacl/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/pynacl/events","assignees_url":"https://api.github.com/repos/pyca/pynacl/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/pynacl/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/pynacl/tags","blobs_url":"https://api.github.com/repos/pyca/pynacl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/pynacl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/pynacl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/pynacl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/pynacl/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/pynacl/languages","stargazers_url":"https://api.github.com/repos/pyca/pynacl/stargazers","contributors_url":"https://api.github.com/repos/pyca/pynacl/contributors","subscribers_url":"https://api.github.com/repos/pyca/pynacl/subscribers","subscription_url":"https://api.github.com/repos/pyca/pynacl/subscription","commits_url":"https://api.github.com/repos/pyca/pynacl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/pynacl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/pynacl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/pynacl/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyca/pynacl/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/pynacl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/pynacl/merges","archive_url":"https://api.github.com/repos/pyca/pynacl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/pynacl/downloads","issues_url":"https://api.github.com/repos/pyca/pynacl/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/pynacl/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/pynacl/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/pynacl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/pynacl/labels{/name}","releases_url":"https://api.github.com/repos/pyca/pynacl/releases{/id}","deployments_url":"https://api.github.com/repos/pyca/pynacl/deployments","created_at":"2013-02-22T03:52:39Z","updated_at":"2017-08-30T03:03:20Z","pushed_at":"2017-08-31T03:01:06Z","git_url":"git://github.com/pyca/pynacl.git","ssh_url":"git@github.com:pyca/pynacl.git","clone_url":"https://github.com/pyca/pynacl.git","svn_url":"https://github.com/pyca/pynacl","homepage":"https://pynacl.readthedocs.io/","size":4959,"stargazers_count":388,"watchers_count":388,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":30,"forks":79,"open_issues":30,"watchers":388,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/317"},"html":{"href":"https://github.com/pyca/pynacl/pull/317"},"issue":{"href":"https://api.github.com/repos/pyca/pynacl/issues/317"},"comments":{"href":"https://api.github.com/repos/pyca/pynacl/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyca/pynacl/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/pynacl/statuses/41962239b23e8b2fa1936b98d80289632501de26"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8350032,
"name": "pyca/pynacl",
"url": "https://api.github.com/repos/pyca/pynacl"
}
|
{
"id": 161495,
"login": "reaperhulk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/161495?",
"url": "https://api.github.com/users/reaperhulk"
}
|
{
"id": 5615737,
"login": "pyca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5615737?",
"url": "https://api.github.com/orgs/pyca"
}
| 2017-08-31T03:07:38 |
6533008413
|
{"actor":{"display_login":"reaperhulk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/comments/125518711","pull_request_review_id":47914680,"id":125518711,"diff_hunk":"@@ -116,20 +149,148 @@ Parameters\n Default: *(not set)*\n \n ``SQL query`` [string]\n- Defines the SQL query, for example 'create schema test;'.\n+ Defines the SQL query, for example ``UPDATE my_table SET field=10``.\n \n Default: *(not set)*\n \n Outputs\n .......\n+No new outputs will be created. The layer chosen will be updated with the executed\n+SQL query. By opening the table (for example with Data Manager) you will see\n+the results.\n \n Console usage\n .............\n \n ::\n \n- processing.runalg('qgis:postgisexecutesql', database, sql)\n+ processing.run('qgis:postgisexecutesql', database, sql)\n+\n+\n+.. _qgis_import_into_spatialite:\n+\n+Import into Spatialite\n+----------------------\n+\n+Imports a vector layer currently loaded in QGIS into a Spatialite database.\n+Prior to this a connection between QGIS and the Spatialite database has to\n+be created (for example with the DB Manager).\n+\n+\n+Parameters\n+..........\n+\n+``Layer to import`` [vector: any]\n+ Existing vector layer in QGIS.\n+\n+``File database`` [selection]\n+ Name of the database connection. The combobox will show all the databases of\n+ the layers loaded in QGIS. Moreover, it is possible to choose an external\n+ `sqlite` file.\n+\n+``Table to import to (leave blank to use layer name)`` [string]\n+ Optional.\n+\n+ Defines a table name for the imported vector file.\n+ If nothing is added, the layer name will be chosen.","path":"source/docs/user_manual/processing_algs/qgis/database.rst","position":170,"original_position":170,"commit_id":"d6a5b1118ebded33719743e12f24d348a569ec93","original_commit_id":"d6a5b1118ebded33719743e12f24d348a569ec93","user":{"login":"DelazJ","id":7983394,"avatar_url":"https://avatars3.githubusercontent.com/u/7983394?v=3","gravatar_id":"","url":"https://api.github.com/users/DelazJ","html_url":"https://github.com/DelazJ","followers_url":"https://api.github.com/users/DelazJ/followers","following_url":"https://api.github.com/users/DelazJ/following{/other_user}","gists_url":"https://api.github.com/users/DelazJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DelazJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DelazJ/subscriptions","organizations_url":"https://api.github.com/users/DelazJ/orgs","repos_url":"https://api.github.com/users/DelazJ/repos","events_url":"https://api.github.com/users/DelazJ/events{/privacy}","received_events_url":"https://api.github.com/users/DelazJ/received_events","type":"User","site_admin":false},"body":"Like above?","created_at":"2017-07-04T18:35:51Z","updated_at":"2017-07-04T18:38:14Z","html_url":"https://github.com/qgis/QGIS-Documentation/pull/1969#discussion_r125518711","pull_request_url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/comments/125518711"},"html":{"href":"https://github.com/qgis/QGIS-Documentation/pull/1969#discussion_r125518711"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969","id":128610399,"html_url":"https://github.com/qgis/QGIS-Documentation/pull/1969","diff_url":"https://github.com/qgis/QGIS-Documentation/pull/1969.diff","patch_url":"https://github.com/qgis/QGIS-Documentation/pull/1969.patch","issue_url":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/1969","number":1969,"state":"open","locked":false,"title":"processing database algorithm updates","user":{"login":"ghtmtt","id":2884884,"avatar_url":"https://avatars1.githubusercontent.com/u/2884884?v=3","gravatar_id":"","url":"https://api.github.com/users/ghtmtt","html_url":"https://github.com/ghtmtt","followers_url":"https://api.github.com/users/ghtmtt/followers","following_url":"https://api.github.com/users/ghtmtt/following{/other_user}","gists_url":"https://api.github.com/users/ghtmtt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghtmtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghtmtt/subscriptions","organizations_url":"https://api.github.com/users/ghtmtt/orgs","repos_url":"https://api.github.com/users/ghtmtt/repos","events_url":"https://api.github.com/users/ghtmtt/events{/privacy}","received_events_url":"https://api.github.com/users/ghtmtt/received_events","type":"User","site_admin":false},"body":"This is a first commit of the improving Processing Help framework.\r\n\r\nDatabases algorithms have been updated (both parameters e.g. PostGIS and new ones e.g. SpatiaLite)","created_at":"2017-07-03T11:41:30Z","updated_at":"2017-07-04T18:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"630704cbe2fa435aab7f23fb2d9230e0c78caa9c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/qgis/QGIS-Documentation/milestones/7","html_url":"https://github.com/qgis/QGIS-Documentation/milestone/7","labels_url":"https://api.github.com/repos/qgis/QGIS-Documentation/milestones/7/labels","id":1875164,"number":7,"title":"QGIS 3.0","description":"","creator":{"login":"DelazJ","id":7983394,"avatar_url":"https://avatars3.githubusercontent.com/u/7983394?v=3","gravatar_id":"","url":"https://api.github.com/users/DelazJ","html_url":"https://github.com/DelazJ","followers_url":"https://api.github.com/users/DelazJ/followers","following_url":"https://api.github.com/users/DelazJ/following{/other_user}","gists_url":"https://api.github.com/users/DelazJ/gists{/gist_id}","starred_url":"https://api.github.com/users/DelazJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DelazJ/subscriptions","organizations_url":"https://api.github.com/users/DelazJ/orgs","repos_url":"https://api.github.com/users/DelazJ/repos","events_url":"https://api.github.com/users/DelazJ/events{/privacy}","received_events_url":"https://api.github.com/users/DelazJ/received_events","type":"User","site_admin":false},"open_issues":223,"closed_issues":123,"state":"open","created_at":"2016-07-11T08:31:06Z","updated_at":"2017-07-04T07:25:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/1969/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS-Documentation/statuses/d6a5b1118ebded33719743e12f24d348a569ec93","head":{"label":"ghtmtt:processing_help","ref":"processing_help","sha":"d6a5b1118ebded33719743e12f24d348a569ec93","user":{"login":"ghtmtt","id":2884884,"avatar_url":"https://avatars1.githubusercontent.com/u/2884884?v=3","gravatar_id":"","url":"https://api.github.com/users/ghtmtt","html_url":"https://github.com/ghtmtt","followers_url":"https://api.github.com/users/ghtmtt/followers","following_url":"https://api.github.com/users/ghtmtt/following{/other_user}","gists_url":"https://api.github.com/users/ghtmtt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghtmtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghtmtt/subscriptions","organizations_url":"https://api.github.com/users/ghtmtt/orgs","repos_url":"https://api.github.com/users/ghtmtt/repos","events_url":"https://api.github.com/users/ghtmtt/events{/privacy}","received_events_url":"https://api.github.com/users/ghtmtt/received_events","type":"User","site_admin":false},"repo":{"id":84329319,"name":"QGIS-Documentation","full_name":"ghtmtt/QGIS-Documentation","owner":{"login":"ghtmtt","id":2884884,"avatar_url":"https://avatars1.githubusercontent.com/u/2884884?v=3","gravatar_id":"","url":"https://api.github.com/users/ghtmtt","html_url":"https://github.com/ghtmtt","followers_url":"https://api.github.com/users/ghtmtt/followers","following_url":"https://api.github.com/users/ghtmtt/following{/other_user}","gists_url":"https://api.github.com/users/ghtmtt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghtmtt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghtmtt/subscriptions","organizations_url":"https://api.github.com/users/ghtmtt/orgs","repos_url":"https://api.github.com/users/ghtmtt/repos","events_url":"https://api.github.com/users/ghtmtt/events{/privacy}","received_events_url":"https://api.github.com/users/ghtmtt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghtmtt/QGIS-Documentation","description":null,"fork":true,"url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation","forks_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/forks","keys_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/teams","hooks_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/hooks","issue_events_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/issues/events{/number}","events_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/events","assignees_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/assignees{/user}","branches_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/branches{/branch}","tags_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/tags","blobs_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/languages","stargazers_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/stargazers","contributors_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/contributors","subscribers_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/subscribers","subscription_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/subscription","commits_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/contents/{+path}","compare_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/merges","archive_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/downloads","issues_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/issues{/number}","pulls_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/labels{/name}","releases_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/releases{/id}","deployments_url":"https://api.github.com/repos/ghtmtt/QGIS-Documentation/deployments","created_at":"2017-03-08T14:29:13Z","updated_at":"2017-03-08T14:29:20Z","pushed_at":"2017-07-04T11:50:47Z","git_url":"git://github.com/ghtmtt/QGIS-Documentation.git","ssh_url":"git@github.com:ghtmtt/QGIS-Documentation.git","clone_url":"https://github.com/ghtmtt/QGIS-Documentation.git","svn_url":"https://github.com/ghtmtt/QGIS-Documentation","homepage":null,"size":627132,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"release_2.18"}},"base":{"label":"qgis:master","ref":"master","sha":"4a6e677ba77b9a55a387380c23a4e4a3a1bd115a","user":{"login":"qgis","id":483444,"avatar_url":"https://avatars0.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":8466379,"name":"QGIS-Documentation","full_name":"qgis/QGIS-Documentation","owner":{"login":"qgis","id":483444,"avatar_url":"https://avatars0.githubusercontent.com/u/483444?v=3","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS-Documentation","description":null,"fork":false,"url":"https://api.github.com/repos/qgis/QGIS-Documentation","forks_url":"https://api.github.com/repos/qgis/QGIS-Documentation/forks","keys_url":"https://api.github.com/repos/qgis/QGIS-Documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS-Documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS-Documentation/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS-Documentation/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS-Documentation/events","assignees_url":"https://api.github.com/repos/qgis/QGIS-Documentation/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS-Documentation/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS-Documentation/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS-Documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS-Documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS-Documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS-Documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS-Documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS-Documentation/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS-Documentation/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS-Documentation/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS-Documentation/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS-Documentation/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS-Documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS-Documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS-Documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS-Documentation/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS-Documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS-Documentation/merges","archive_url":"https://api.github.com/repos/qgis/QGIS-Documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS-Documentation/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS-Documentation/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS-Documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS-Documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS-Documentation/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS-Documentation/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS-Documentation/deployments","created_at":"2013-02-27T21:54:56Z","updated_at":"2017-06-12T12:07:31Z","pushed_at":"2017-07-04T11:50:49Z","git_url":"git://github.com/qgis/QGIS-Documentation.git","ssh_url":"git@github.com:qgis/QGIS-Documentation.git","clone_url":"https://github.com/qgis/QGIS-Documentation.git","svn_url":"https://github.com/qgis/QGIS-Documentation","homepage":null,"size":627203,"stargazers_count":65,"watchers_count":65,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"open_issues_count":294,"forks":198,"open_issues":294,"watchers":65,"default_branch":"release_2.18"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969"},"html":{"href":"https://github.com/qgis/QGIS-Documentation/pull/1969"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/1969"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/issues/1969/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/pulls/1969/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS-Documentation/statuses/d6a5b1118ebded33719743e12f24d348a569ec93"}}}}
|
{
"id": 8466379,
"name": "qgis/QGIS-Documentation",
"url": "https://api.github.com/repos/qgis/QGIS-Documentation"
}
|
{
"id": 7983394,
"login": "DelazJ",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7983394?",
"url": "https://api.github.com/users/DelazJ"
}
|
{
"id": 483444,
"login": "qgis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/483444?",
"url": "https://api.github.com/orgs/qgis"
}
| 2017-07-04T18:35:51 |
6191303409
|
{"actor":{"display_login":"DelazJ"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/111757181","pull_request_review_id":33018669,"id":111757181,"diff_hunk":"@@ -18,24 +18,22 @@ Note that we are striving for even more smooth integration with Kubernetes in th\n \n With your Kubernetes cluster running, Rook can be setup and deployed by simply creating the [rook-operator](/demo/kubernetes/rook-operator.yaml) deployment and creating a [rook cluster](/demo/kubernetes/rook-cluster.yaml).\n \n-```\n+```bash\n cd demo/kubernetes\n kubectl create -f rook-operator.yaml\n-```\n \n-This will start the rook-operator pod. Verify that it is in the `Running` state before proceeding:\n-```\n+# This will start the rook-operator pod. Verify that it is in the `Running` state before proceeding:\n kubectl get pod | grep rook-operator\n ```\n \n-Now that the rook-operator pod is in the `Running` state, we can create the Rook cluster. See the documentation on [configuring the cluster](cluster-tpr.md).\n-```\n+Now that the rook-operator pod is running, we can create the Rook cluster. See the documentation on [configuring the cluster](cluster-tpr.md).","path":"Documentation/kubernetes.md","position":18,"original_position":18,"commit_id":"212e70fdbcfeeb4aecf72e2d747a84dffd1d19ea","original_commit_id":"212e70fdbcfeeb4aecf72e2d747a84dffd1d19ea","user":{"login":"jbw976","id":4313439,"avatar_url":"https://avatars1.githubusercontent.com/u/4313439?v=3","gravatar_id":"","url":"https://api.github.com/users/jbw976","html_url":"https://github.com/jbw976","followers_url":"https://api.github.com/users/jbw976/followers","following_url":"https://api.github.com/users/jbw976/following{/other_user}","gists_url":"https://api.github.com/users/jbw976/gists{/gist_id}","starred_url":"https://api.github.com/users/jbw976/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbw976/subscriptions","organizations_url":"https://api.github.com/users/jbw976/orgs","repos_url":"https://api.github.com/users/jbw976/repos","events_url":"https://api.github.com/users/jbw976/events{/privacy}","received_events_url":"https://api.github.com/users/jbw976/received_events","type":"User","site_admin":false},"body":"I liked having `Running` in the text because it matches (and calls out) exactly what the user should be looking for in their console output.","created_at":"2017-04-17T15:20:56Z","updated_at":"2017-04-17T15:22:45Z","html_url":"https://github.com/rook/rook/pull/578#discussion_r111757181","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/111757181"},"html":{"href":"https://github.com/rook/rook/pull/578#discussion_r111757181"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/578"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/578","id":116004031,"html_url":"https://github.com/rook/rook/pull/578","diff_url":"https://github.com/rook/rook/pull/578.diff","patch_url":"https://github.com/rook/rook/pull/578.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/578","number":578,"state":"open","locked":false,"title":"Add object and file system walkthroughs","user":{"login":"travisn","id":1048514,"avatar_url":"https://avatars3.githubusercontent.com/u/1048514?v=3","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"body":"The docs are refactored so we now have block, file, and object all in the walkthrough. While I was refactoring I went ahead and included docs from a couple other sources.\r\n\r\n@sajal, I took your content from #569 if you don't mind me including it here. In that case you can close that PR. One question I have is that when I go through the test section at the end, I didn't see a `docker` subfolder. Do I need to actually upload an image to the registry to get that folder to show up?\r\n\r\n@rothgar, this includes object storage to fix #509. Your review is appreciated!\r\n\r\nTo see the docs in rendered form, you may want to refer to the branch: https://github.com/travisn/rook/blob/doc-update/Documentation/kubernetes.md\r\n\r\nThanks @sajal and @rothgar!","created_at":"2017-04-14T23:41:57Z","updated_at":"2017-04-17T15:22:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6774de7624ed8e59b26b0b15726eb4a1ca813af2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/578/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/578/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/578/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/212e70fdbcfeeb4aecf72e2d747a84dffd1d19ea","head":{"label":"travisn:doc-update","ref":"doc-update","sha":"212e70fdbcfeeb4aecf72e2d747a84dffd1d19ea","user":{"login":"travisn","id":1048514,"avatar_url":"https://avatars3.githubusercontent.com/u/1048514?v=3","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"repo":{"id":73165238,"name":"rook","full_name":"travisn/rook","owner":{"login":"travisn","id":1048514,"avatar_url":"https://avatars3.githubusercontent.com/u/1048514?v=3","gravatar_id":"","url":"https://api.github.com/users/travisn","html_url":"https://github.com/travisn","followers_url":"https://api.github.com/users/travisn/followers","following_url":"https://api.github.com/users/travisn/following{/other_user}","gists_url":"https://api.github.com/users/travisn/gists{/gist_id}","starred_url":"https://api.github.com/users/travisn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisn/subscriptions","organizations_url":"https://api.github.com/users/travisn/orgs","repos_url":"https://api.github.com/users/travisn/repos","events_url":"https://api.github.com/users/travisn/events{/privacy}","received_events_url":"https://api.github.com/users/travisn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/travisn/rook","description":"Open, Universal, Cloud Native, Distributed Storage","fork":true,"url":"https://api.github.com/repos/travisn/rook","forks_url":"https://api.github.com/repos/travisn/rook/forks","keys_url":"https://api.github.com/repos/travisn/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travisn/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travisn/rook/teams","hooks_url":"https://api.github.com/repos/travisn/rook/hooks","issue_events_url":"https://api.github.com/repos/travisn/rook/issues/events{/number}","events_url":"https://api.github.com/repos/travisn/rook/events","assignees_url":"https://api.github.com/repos/travisn/rook/assignees{/user}","branches_url":"https://api.github.com/repos/travisn/rook/branches{/branch}","tags_url":"https://api.github.com/repos/travisn/rook/tags","blobs_url":"https://api.github.com/repos/travisn/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travisn/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travisn/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/travisn/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travisn/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/travisn/rook/languages","stargazers_url":"https://api.github.com/repos/travisn/rook/stargazers","contributors_url":"https://api.github.com/repos/travisn/rook/contributors","subscribers_url":"https://api.github.com/repos/travisn/rook/subscribers","subscription_url":"https://api.github.com/repos/travisn/rook/subscription","commits_url":"https://api.github.com/repos/travisn/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/travisn/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/travisn/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/travisn/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/travisn/rook/contents/{+path}","compare_url":"https://api.github.com/repos/travisn/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travisn/rook/merges","archive_url":"https://api.github.com/repos/travisn/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travisn/rook/downloads","issues_url":"https://api.github.com/repos/travisn/rook/issues{/number}","pulls_url":"https://api.github.com/repos/travisn/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/travisn/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/travisn/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travisn/rook/labels{/name}","releases_url":"https://api.github.com/repos/travisn/rook/releases{/id}","deployments_url":"https://api.github.com/repos/travisn/rook/deployments","created_at":"2016-11-08T08:30:24Z","updated_at":"2016-11-08T08:30:25Z","pushed_at":"2017-04-15T00:39:50Z","git_url":"git://github.com/travisn/rook.git","ssh_url":"git@github.com:travisn/rook.git","clone_url":"https://github.com/travisn/rook.git","svn_url":"https://github.com/travisn/rook","homepage":"http://rook.io","size":1732,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"43f62d909067cba950c56ad1219afc2dd05ff003","user":{"login":"rook","id":22860722,"avatar_url":"https://avatars2.githubusercontent.com/u/22860722?v=3","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"avatar_url":"https://avatars2.githubusercontent.com/u/22860722?v=3","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"Open, Cloud Native, and Universal Distributed Storage","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2017-04-17T12:41:35Z","pushed_at":"2017-04-17T13:38:22Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":1724,"stargazers_count":1253,"watchers_count":1253,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":126,"forks":67,"open_issues":126,"watchers":1253,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/578"},"html":{"href":"https://github.com/rook/rook/pull/578"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/578"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/212e70fdbcfeeb4aecf72e2d747a84dffd1d19ea"}}}}
|
{
"id": 62921553,
"name": "rook/rook",
"url": "https://api.github.com/repos/rook/rook"
}
|
{
"id": 4313439,
"login": "jbw976",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4313439?",
"url": "https://api.github.com/users/jbw976"
}
|
{
"id": 22860722,
"login": "rook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22860722?",
"url": "https://api.github.com/orgs/rook"
}
| 2017-04-17T15:20:56 |
5700465024
|
{"actor":{"display_login":"jbw976"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/comments/120391133","pull_request_review_id":42348515,"id":120391133,"diff_hunk":"@@ -1,53 +1,51 @@\n-# http://ros.org/doc/groovy/api/catkin/html/user_guide/supposed.html\n-cmake_minimum_required(VERSION 2.8)\n+cmake_minimum_required(VERSION 3.5)\n project(depthimage_to_laserscan)\n+if(NOT WIN32)\n+ set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -std=c++14 -Wall -Wextra -Wpedantic\")\n+endif()\n \n-# Load catkin and all dependencies required for this package\n-find_package(catkin REQUIRED dynamic_reconfigure image_geometry image_transport nodelet roscpp sensor_msgs)\n-#find_package(OpenCV REQUIRED)\n+find_package(ament_cmake REQUIRED)\n \n-# Dynamic reconfigure support\n-generate_dynamic_reconfigure_options(cfg/Depth.cfg)\n+find_package(image_geometry REQUIRED)\n+find_package(OpenCV REQUIRED)\n+find_package(rclcpp REQUIRED)\n+find_package(sensor_msgs REQUIRED)\n \n-catkin_package(\n- INCLUDE_DIRS include\n- LIBRARIES DepthImageToLaserScan DepthImageToLaserScanROS DepthImageToLaserScanNodelet\n- CATKIN_DEPENDS dynamic_reconfigure image_geometry image_transport nodelet roscpp sensor_msgs\n+include_directories(include\n+ ${OpenCV_INCLUDE_DIRS}\n )\n \n-include_directories(include ${catkin_INCLUDE_DIRS})\n+add_library(DepthImageToLaserScan","path":"CMakeLists.txt","position":30,"original_position":30,"commit_id":"87c0725e220eac898c11c0688094f8a3f8c6550e","original_commit_id":"87c0725e220eac898c11c0688094f8a3f8c6550e","user":{"login":"mikaelarguedas","id":6644208,"avatar_url":"https://avatars2.githubusercontent.com/u/6644208?v=3","gravatar_id":"","url":"https://api.github.com/users/mikaelarguedas","html_url":"https://github.com/mikaelarguedas","followers_url":"https://api.github.com/users/mikaelarguedas/followers","following_url":"https://api.github.com/users/mikaelarguedas/following{/other_user}","gists_url":"https://api.github.com/users/mikaelarguedas/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelarguedas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelarguedas/subscriptions","organizations_url":"https://api.github.com/users/mikaelarguedas/orgs","repos_url":"https://api.github.com/users/mikaelarguedas/repos","events_url":"https://api.github.com/users/mikaelarguedas/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelarguedas/received_events","type":"User","site_admin":false},"body":"I think we always build our libraries as SHARED. Otherwise we use ament_cmake_ros to control the behavior of building static or shared globally (same remark for every add_library call)","created_at":"2017-06-06T15:18:06Z","updated_at":"2017-06-06T15:48:31Z","html_url":"https://github.com/ros2/depthimage_to_laserscan/pull/1#discussion_r120391133","pull_request_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/comments/120391133"},"html":{"href":"https://github.com/ros2/depthimage_to_laserscan/pull/1#discussion_r120391133"},"pull_request":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1","id":124185569,"html_url":"https://github.com/ros2/depthimage_to_laserscan/pull/1","diff_url":"https://github.com/ros2/depthimage_to_laserscan/pull/1.diff","patch_url":"https://github.com/ros2/depthimage_to_laserscan/pull/1.patch","issue_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/1","number":1,"state":"open","locked":false,"title":"Port depthimage_to_laserscan to ROS2.","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars3.githubusercontent.com/u/163000?v=3","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"body":"We need this to do 2D cartographer on turtlebot.\r\n\r\nconnects to ros2/ros2#342\r\n\r\nCI:\r\n* TB2 Linux [](http://ci.ros2.org/job/ci_turtlebot-demo_linux/24/)\r\n* TB2 Linux-aarch64 [](http://ci.ros2.org/job/ci_turtlebot-demo_linux-aarch64/40/)","created_at":"2017-06-06T13:04:46Z","updated_at":"2017-06-06T15:48:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fffd06f2b38ac7a2195b40197bc4e0a592fea4e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/1/comments","statuses_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/statuses/87c0725e220eac898c11c0688094f8a3f8c6550e","head":{"label":"ros2:ros2-devel","ref":"ros2-devel","sha":"87c0725e220eac898c11c0688094f8a3f8c6550e","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":93416154,"name":"depthimage_to_laserscan","full_name":"ros2/depthimage_to_laserscan","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/depthimage_to_laserscan","description":"Converts a depth image to a laser scan for use with navigation and localization.","fork":true,"url":"https://api.github.com/repos/ros2/depthimage_to_laserscan","forks_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/forks","keys_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/teams","hooks_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/hooks","issue_events_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/events","assignees_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/tags","blobs_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/languages","stargazers_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/stargazers","contributors_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/contributors","subscribers_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/subscribers","subscription_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/subscription","commits_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/merges","archive_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/downloads","issues_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/labels{/name}","releases_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/deployments","created_at":"2017-06-05T15:05:07Z","updated_at":"2017-06-05T15:05:21Z","pushed_at":"2017-06-06T13:22:40Z","git_url":"git://github.com/ros2/depthimage_to_laserscan.git","ssh_url":"git@github.com:ros2/depthimage_to_laserscan.git","clone_url":"https://github.com/ros2/depthimage_to_laserscan.git","svn_url":"https://github.com/ros2/depthimage_to_laserscan","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"ros2"}},"base":{"label":"ros2:ros2","ref":"ros2","sha":"f135fbd5f60dc7b33aa6d01f9d60c0ec9cb9d787","user":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"repo":{"id":93416154,"name":"depthimage_to_laserscan","full_name":"ros2/depthimage_to_laserscan","owner":{"login":"ros2","id":3979232,"avatar_url":"https://avatars2.githubusercontent.com/u/3979232?v=3","gravatar_id":"","url":"https://api.github.com/users/ros2","html_url":"https://github.com/ros2","followers_url":"https://api.github.com/users/ros2/followers","following_url":"https://api.github.com/users/ros2/following{/other_user}","gists_url":"https://api.github.com/users/ros2/gists{/gist_id}","starred_url":"https://api.github.com/users/ros2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros2/subscriptions","organizations_url":"https://api.github.com/users/ros2/orgs","repos_url":"https://api.github.com/users/ros2/repos","events_url":"https://api.github.com/users/ros2/events{/privacy}","received_events_url":"https://api.github.com/users/ros2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros2/depthimage_to_laserscan","description":"Converts a depth image to a laser scan for use with navigation and localization.","fork":true,"url":"https://api.github.com/repos/ros2/depthimage_to_laserscan","forks_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/forks","keys_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/teams","hooks_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/hooks","issue_events_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/events{/number}","events_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/events","assignees_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/assignees{/user}","branches_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/branches{/branch}","tags_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/tags","blobs_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/statuses/{sha}","languages_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/languages","stargazers_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/stargazers","contributors_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/contributors","subscribers_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/subscribers","subscription_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/subscription","commits_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/contents/{+path}","compare_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/merges","archive_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/downloads","issues_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues{/number}","pulls_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls{/number}","milestones_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/milestones{/number}","notifications_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/labels{/name}","releases_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/releases{/id}","deployments_url":"https://api.github.com/repos/ros2/depthimage_to_laserscan/deployments","created_at":"2017-06-05T15:05:07Z","updated_at":"2017-06-05T15:05:21Z","pushed_at":"2017-06-06T13:22:40Z","git_url":"git://github.com/ros2/depthimage_to_laserscan.git","ssh_url":"git@github.com:ros2/depthimage_to_laserscan.git","clone_url":"https://github.com/ros2/depthimage_to_laserscan.git","svn_url":"https://github.com/ros2/depthimage_to_laserscan","homepage":null,"size":33,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"ros2"}},"_links":{"self":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1"},"html":{"href":"https://github.com/ros2/depthimage_to_laserscan/pull/1"},"issue":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/1"},"comments":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ros2/depthimage_to_laserscan/statuses/87c0725e220eac898c11c0688094f8a3f8c6550e"}}}}
|
{
"id": 93416154,
"name": "ros2/depthimage_to_laserscan",
"url": "https://api.github.com/repos/ros2/depthimage_to_laserscan"
}
|
{
"id": 6644208,
"login": "mikaelarguedas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6644208?",
"url": "https://api.github.com/users/mikaelarguedas"
}
|
{
"id": 3979232,
"login": "ros2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3979232?",
"url": "https://api.github.com/orgs/ros2"
}
| 2017-06-06T15:18:06 |
6011753657
|
{"actor":{"display_login":"mikaelarguedas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments/153623326","pull_request_review_id":79656032,"id":153623326,"diff_hunk":"@@ -9,7 +9,8 @@ receive a webhook notification, we determine if the change is related to an\n active version for your project, and if it is, a build is triggered for that\n version.\n \n-.. _integration-detail:\n+GitHub\n+------","path":"docs/webhooks.rst","position":6,"original_position":6,"commit_id":"ad6ba743a5589f545f298584ca5e8d286c06faee","original_commit_id":"ad6ba743a5589f545f298584ca5e8d286c06faee","user":{"login":"agjohnson","id":1140183,"avatar_url":"https://avatars0.githubusercontent.com/u/1140183?v=4","gravatar_id":"","url":"https://api.github.com/users/agjohnson","html_url":"https://github.com/agjohnson","followers_url":"https://api.github.com/users/agjohnson/followers","following_url":"https://api.github.com/users/agjohnson/following{/other_user}","gists_url":"https://api.github.com/users/agjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/agjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agjohnson/subscriptions","organizations_url":"https://api.github.com/users/agjohnson/orgs","repos_url":"https://api.github.com/users/agjohnson/repos","events_url":"https://api.github.com/users/agjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/agjohnson/received_events","type":"User","site_admin":false},"body":"No heading here, this is under \"Webhook Integrations\"","created_at":"2017-11-28T21:07:17Z","updated_at":"2017-11-28T21:17:33Z","html_url":"https://github.com/rtfd/readthedocs.org/pull/3327#discussion_r153623326","pull_request_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments/153623326"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/3327#discussion_r153623326"},"pull_request":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327"}}},"pull_request":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327","id":154953777,"html_url":"https://github.com/rtfd/readthedocs.org/pull/3327","diff_url":"https://github.com/rtfd/readthedocs.org/pull/3327.diff","patch_url":"https://github.com/rtfd/readthedocs.org/pull/3327.patch","issue_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3327","number":3327,"state":"open","locked":false,"title":"GitLab Integration","user":{"login":"humitos","id":244656,"avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false},"body":"This is the continuation of the work done by @saily at #1870 \r\n\r\nI updated the code to follow the new codebase and also use the `apiv4` endpoints from gitlab. Besides, there are a bunch of style-things.\r\n\r\nMissing things:\r\n\r\n- [x] update webhook method\r\n- [x] more testing\r\n\r\nCloses #1441\r\nCloses #1870 \r\nCloses #1443\r\n","created_at":"2017-11-28T00:50:30Z","updated_at":"2017-11-28T21:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8464a4572b6bc250ec4222541cbb825346eb635","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327/commits","review_comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327/comments","review_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3327/comments","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/ad6ba743a5589f545f298584ca5e8d286c06faee","head":{"label":"rtfd:humitos/gitlab/integration","ref":"humitos/gitlab/integration","sha":"ad6ba743a5589f545f298584ca5e8d286c06faee","user":{"login":"rtfd","id":366329,"avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"name":"readthedocs.org","full_name":"rtfd/readthedocs.org","owner":{"login":"rtfd","id":366329,"avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2017-11-28T14:18:04Z","pushed_at":"2017-11-28T20:52:43Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":41247,"stargazers_count":3866,"watchers_count":3866,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2012,"mirror_url":null,"archived":false,"open_issues_count":534,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2012,"open_issues":534,"watchers":3866,"default_branch":"master"}},"base":{"label":"rtfd:master","ref":"master","sha":"cd9802ef2a4d478d9ccb7696b5a99d33b297767b","user":{"login":"rtfd","id":366329,"avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"name":"readthedocs.org","full_name":"rtfd/readthedocs.org","owner":{"login":"rtfd","id":366329,"avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2017-11-28T14:18:04Z","pushed_at":"2017-11-28T20:52:43Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":41247,"stargazers_count":3866,"watchers_count":3866,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2012,"mirror_url":null,"archived":false,"open_issues_count":534,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2012,"open_issues":534,"watchers":3866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/3327"},"issue":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3327"},"comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/3327/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/3327/commits"},"statuses":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/ad6ba743a5589f545f298584ca5e8d286c06faee"}},"author_association":"MEMBER"}}
|
{
"id": 841835,
"name": "rtfd/readthedocs.org",
"url": "https://api.github.com/repos/rtfd/readthedocs.org"
}
|
{
"id": 1140183,
"login": "agjohnson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1140183?",
"url": "https://api.github.com/users/agjohnson"
}
|
{
"id": 366329,
"login": "rtfd",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/366329?",
"url": "https://api.github.com/orgs/rtfd"
}
| 2017-11-28T21:07:17 |
6915315868
|
{"actor":{"display_login":"agjohnson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sdbg/sdbg/pulls/comments/138111717","pull_request_review_id":61865342,"id":138111717,"diff_hunk":"@@ -33,6 +40,19 @@ public String getPath(IBreakpoint breakpoint) throws CoreException {\n }\n }\n \n+ public String getLocalPath(IJavaBreakpoint bp) throws CoreException {","path":"com.github.sdbg.integration.jdt/src/com/github/sdbg/integration/jdt/JDTBreakpointPathResolver.java","position":25,"original_position":25,"commit_id":"3fe293194f16d8a9b6353511ec7929c00f348c45","original_commit_id":"3fe293194f16d8a9b6353511ec7929c00f348c45","user":{"login":"ivmarkov","id":2607589,"avatar_url":"https://avatars3.githubusercontent.com/u/2607589?v=4","gravatar_id":"","url":"https://api.github.com/users/ivmarkov","html_url":"https://github.com/ivmarkov","followers_url":"https://api.github.com/users/ivmarkov/followers","following_url":"https://api.github.com/users/ivmarkov/following{/other_user}","gists_url":"https://api.github.com/users/ivmarkov/gists{/gist_id}","starred_url":"https://api.github.com/users/ivmarkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivmarkov/subscriptions","organizations_url":"https://api.github.com/users/ivmarkov/orgs","repos_url":"https://api.github.com/users/ivmarkov/repos","events_url":"https://api.github.com/users/ivmarkov/events{/privacy}","received_events_url":"https://api.github.com/users/ivmarkov/received_events","type":"User","site_admin":false},"body":"The method does not need to be public. If so, please lower the visibility to 'private'.","created_at":"2017-09-11T15:48:51Z","updated_at":"2017-09-11T15:54:58Z","html_url":"https://github.com/sdbg/sdbg/pull/160#discussion_r138111717","pull_request_url":"https://api.github.com/repos/sdbg/sdbg/pulls/160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/comments/138111717"},"html":{"href":"https://github.com/sdbg/sdbg/pull/160#discussion_r138111717"},"pull_request":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/sdbg/sdbg/pulls/160","id":140216900,"html_url":"https://github.com/sdbg/sdbg/pull/160","diff_url":"https://github.com/sdbg/sdbg/pull/160.diff","patch_url":"https://github.com/sdbg/sdbg/pull/160.patch","issue_url":"https://api.github.com/repos/sdbg/sdbg/issues/160","number":160,"state":"open","locked":false,"title":"Fix breakoint source file resolution if class name does not match fil…","user":{"login":"aragozin","id":235548,"avatar_url":"https://avatars3.githubusercontent.com/u/235548?v=4","gravatar_id":"","url":"https://api.github.com/users/aragozin","html_url":"https://github.com/aragozin","followers_url":"https://api.github.com/users/aragozin/followers","following_url":"https://api.github.com/users/aragozin/following{/other_user}","gists_url":"https://api.github.com/users/aragozin/gists{/gist_id}","starred_url":"https://api.github.com/users/aragozin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragozin/subscriptions","organizations_url":"https://api.github.com/users/aragozin/orgs","repos_url":"https://api.github.com/users/aragozin/repos","events_url":"https://api.github.com/users/aragozin/events{/privacy}","received_events_url":"https://api.github.com/users/aragozin/received_events","type":"User","site_admin":false},"body":"Breakpoints were not working if Java class name wasn't matching file name.\r\nChanged source resolution to relay on resource associated with breakpoint if available.","created_at":"2017-09-10T17:15:05Z","updated_at":"2017-09-11T15:54:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44bce9169f7dbed1194b12813d155af755cb8a0a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sdbg/sdbg/pulls/160/commits","review_comments_url":"https://api.github.com/repos/sdbg/sdbg/pulls/160/comments","review_comment_url":"https://api.github.com/repos/sdbg/sdbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdbg/sdbg/issues/160/comments","statuses_url":"https://api.github.com/repos/sdbg/sdbg/statuses/3fe293194f16d8a9b6353511ec7929c00f348c45","head":{"label":"aragozin:pull-request/fix-breakpoint-source-resolution","ref":"pull-request/fix-breakpoint-source-resolution","sha":"3fe293194f16d8a9b6353511ec7929c00f348c45","user":{"login":"aragozin","id":235548,"avatar_url":"https://avatars3.githubusercontent.com/u/235548?v=4","gravatar_id":"","url":"https://api.github.com/users/aragozin","html_url":"https://github.com/aragozin","followers_url":"https://api.github.com/users/aragozin/followers","following_url":"https://api.github.com/users/aragozin/following{/other_user}","gists_url":"https://api.github.com/users/aragozin/gists{/gist_id}","starred_url":"https://api.github.com/users/aragozin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragozin/subscriptions","organizations_url":"https://api.github.com/users/aragozin/orgs","repos_url":"https://api.github.com/users/aragozin/repos","events_url":"https://api.github.com/users/aragozin/events{/privacy}","received_events_url":"https://api.github.com/users/aragozin/received_events","type":"User","site_admin":false},"repo":{"id":100516821,"name":"sdbg","full_name":"aragozin/sdbg","owner":{"login":"aragozin","id":235548,"avatar_url":"https://avatars3.githubusercontent.com/u/235548?v=4","gravatar_id":"","url":"https://api.github.com/users/aragozin","html_url":"https://github.com/aragozin","followers_url":"https://api.github.com/users/aragozin/followers","following_url":"https://api.github.com/users/aragozin/following{/other_user}","gists_url":"https://api.github.com/users/aragozin/gists{/gist_id}","starred_url":"https://api.github.com/users/aragozin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aragozin/subscriptions","organizations_url":"https://api.github.com/users/aragozin/orgs","repos_url":"https://api.github.com/users/aragozin/repos","events_url":"https://api.github.com/users/aragozin/events{/privacy}","received_events_url":"https://api.github.com/users/aragozin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aragozin/sdbg","description":"Eclipse debugger for GWT SuperDevMode","fork":true,"url":"https://api.github.com/repos/aragozin/sdbg","forks_url":"https://api.github.com/repos/aragozin/sdbg/forks","keys_url":"https://api.github.com/repos/aragozin/sdbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aragozin/sdbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aragozin/sdbg/teams","hooks_url":"https://api.github.com/repos/aragozin/sdbg/hooks","issue_events_url":"https://api.github.com/repos/aragozin/sdbg/issues/events{/number}","events_url":"https://api.github.com/repos/aragozin/sdbg/events","assignees_url":"https://api.github.com/repos/aragozin/sdbg/assignees{/user}","branches_url":"https://api.github.com/repos/aragozin/sdbg/branches{/branch}","tags_url":"https://api.github.com/repos/aragozin/sdbg/tags","blobs_url":"https://api.github.com/repos/aragozin/sdbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aragozin/sdbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aragozin/sdbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/aragozin/sdbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aragozin/sdbg/statuses/{sha}","languages_url":"https://api.github.com/repos/aragozin/sdbg/languages","stargazers_url":"https://api.github.com/repos/aragozin/sdbg/stargazers","contributors_url":"https://api.github.com/repos/aragozin/sdbg/contributors","subscribers_url":"https://api.github.com/repos/aragozin/sdbg/subscribers","subscription_url":"https://api.github.com/repos/aragozin/sdbg/subscription","commits_url":"https://api.github.com/repos/aragozin/sdbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/aragozin/sdbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/aragozin/sdbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/aragozin/sdbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/aragozin/sdbg/contents/{+path}","compare_url":"https://api.github.com/repos/aragozin/sdbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aragozin/sdbg/merges","archive_url":"https://api.github.com/repos/aragozin/sdbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aragozin/sdbg/downloads","issues_url":"https://api.github.com/repos/aragozin/sdbg/issues{/number}","pulls_url":"https://api.github.com/repos/aragozin/sdbg/pulls{/number}","milestones_url":"https://api.github.com/repos/aragozin/sdbg/milestones{/number}","notifications_url":"https://api.github.com/repos/aragozin/sdbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aragozin/sdbg/labels{/name}","releases_url":"https://api.github.com/repos/aragozin/sdbg/releases{/id}","deployments_url":"https://api.github.com/repos/aragozin/sdbg/deployments","created_at":"2017-08-16T17:47:49Z","updated_at":"2017-08-16T17:47:54Z","pushed_at":"2017-09-10T17:13:15Z","git_url":"git://github.com/aragozin/sdbg.git","ssh_url":"git@github.com:aragozin/sdbg.git","clone_url":"https://github.com/aragozin/sdbg.git","svn_url":"https://github.com/aragozin/sdbg","homepage":"http://sdbg.github.io","size":666043,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sdbg:master","ref":"master","sha":"78f4c2147e2e3f5040937638d7b242560df0baa2","user":{"login":"sdbg","id":6445481,"avatar_url":"https://avatars0.githubusercontent.com/u/6445481?v=4","gravatar_id":"","url":"https://api.github.com/users/sdbg","html_url":"https://github.com/sdbg","followers_url":"https://api.github.com/users/sdbg/followers","following_url":"https://api.github.com/users/sdbg/following{/other_user}","gists_url":"https://api.github.com/users/sdbg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdbg/subscriptions","organizations_url":"https://api.github.com/users/sdbg/orgs","repos_url":"https://api.github.com/users/sdbg/repos","events_url":"https://api.github.com/users/sdbg/events{/privacy}","received_events_url":"https://api.github.com/users/sdbg/received_events","type":"Organization","site_admin":false},"repo":{"id":16054725,"name":"sdbg","full_name":"sdbg/sdbg","owner":{"login":"sdbg","id":6445481,"avatar_url":"https://avatars0.githubusercontent.com/u/6445481?v=4","gravatar_id":"","url":"https://api.github.com/users/sdbg","html_url":"https://github.com/sdbg","followers_url":"https://api.github.com/users/sdbg/followers","following_url":"https://api.github.com/users/sdbg/following{/other_user}","gists_url":"https://api.github.com/users/sdbg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdbg/subscriptions","organizations_url":"https://api.github.com/users/sdbg/orgs","repos_url":"https://api.github.com/users/sdbg/repos","events_url":"https://api.github.com/users/sdbg/events{/privacy}","received_events_url":"https://api.github.com/users/sdbg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdbg/sdbg","description":"Eclipse debugger for GWT SuperDevMode","fork":false,"url":"https://api.github.com/repos/sdbg/sdbg","forks_url":"https://api.github.com/repos/sdbg/sdbg/forks","keys_url":"https://api.github.com/repos/sdbg/sdbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdbg/sdbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdbg/sdbg/teams","hooks_url":"https://api.github.com/repos/sdbg/sdbg/hooks","issue_events_url":"https://api.github.com/repos/sdbg/sdbg/issues/events{/number}","events_url":"https://api.github.com/repos/sdbg/sdbg/events","assignees_url":"https://api.github.com/repos/sdbg/sdbg/assignees{/user}","branches_url":"https://api.github.com/repos/sdbg/sdbg/branches{/branch}","tags_url":"https://api.github.com/repos/sdbg/sdbg/tags","blobs_url":"https://api.github.com/repos/sdbg/sdbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdbg/sdbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdbg/sdbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdbg/sdbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdbg/sdbg/statuses/{sha}","languages_url":"https://api.github.com/repos/sdbg/sdbg/languages","stargazers_url":"https://api.github.com/repos/sdbg/sdbg/stargazers","contributors_url":"https://api.github.com/repos/sdbg/sdbg/contributors","subscribers_url":"https://api.github.com/repos/sdbg/sdbg/subscribers","subscription_url":"https://api.github.com/repos/sdbg/sdbg/subscription","commits_url":"https://api.github.com/repos/sdbg/sdbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdbg/sdbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdbg/sdbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdbg/sdbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdbg/sdbg/contents/{+path}","compare_url":"https://api.github.com/repos/sdbg/sdbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdbg/sdbg/merges","archive_url":"https://api.github.com/repos/sdbg/sdbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdbg/sdbg/downloads","issues_url":"https://api.github.com/repos/sdbg/sdbg/issues{/number}","pulls_url":"https://api.github.com/repos/sdbg/sdbg/pulls{/number}","milestones_url":"https://api.github.com/repos/sdbg/sdbg/milestones{/number}","notifications_url":"https://api.github.com/repos/sdbg/sdbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdbg/sdbg/labels{/name}","releases_url":"https://api.github.com/repos/sdbg/sdbg/releases{/id}","deployments_url":"https://api.github.com/repos/sdbg/sdbg/deployments","created_at":"2014-01-19T21:27:11Z","updated_at":"2017-08-31T06:26:40Z","pushed_at":"2017-09-10T17:15:05Z","git_url":"git://github.com/sdbg/sdbg.git","ssh_url":"git@github.com:sdbg/sdbg.git","clone_url":"https://github.com/sdbg/sdbg.git","svn_url":"https://github.com/sdbg/sdbg","homepage":"http://sdbg.github.io","size":689515,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":20,"forks":16,"open_issues":20,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/160"},"html":{"href":"https://github.com/sdbg/sdbg/pull/160"},"issue":{"href":"https://api.github.com/repos/sdbg/sdbg/issues/160"},"comments":{"href":"https://api.github.com/repos/sdbg/sdbg/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdbg/sdbg/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/sdbg/sdbg/statuses/3fe293194f16d8a9b6353511ec7929c00f348c45"}},"author_association":"NONE"}}
|
{
"id": 16054725,
"name": "sdbg/sdbg",
"url": "https://api.github.com/repos/sdbg/sdbg"
}
|
{
"id": 2607589,
"login": "ivmarkov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2607589?",
"url": "https://api.github.com/users/ivmarkov"
}
|
{
"id": 6445481,
"login": "sdbg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6445481?",
"url": "https://api.github.com/orgs/sdbg"
}
| 2017-09-11T15:48:51 |
6575388434
|
{"actor":{"display_login":"ivmarkov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/127589569","pull_request_review_id":50194138,"id":127589569,"diff_hunk":"@@ -108,10 +108,15 @@\n \n $(document)\n .on('click.bs.button.data-api', '[data-toggle^=\"button\"]', function (e) {\n- var $btn = $(e.target)\n- if (!$btn.hasClass('btn')) $btn = $btn.closest('.btn')\n+ var $btn = $(e.target).closest('.btn')\n Plugin.call($btn, 'toggle')\n- if (!($(e.target).is('input[type=\"radio\"]') || $(e.target).is('input[type=\"checkbox\"]'))) e.preventDefault()\n+ if (!($(e.target).is('input[type=\"radio\"], input[type=\"checkbox\"]'))) {\n+ // Prevent double click on radios, and the double selections (so cancellation) on checkboxes","path":"js/button.js","position":43,"original_position":43,"commit_id":"9b7d1406b922300c5d01e99026e4fffc67445185","original_commit_id":"9b7d1406b922300c5d01e99026e4fffc67445185","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars4.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Line is too long.","created_at":"2017-07-15T17:53:23Z","updated_at":"2017-07-15T17:53:23Z","html_url":"https://github.com/twbs/bootstrap/pull/23098#discussion_r127589569","pull_request_url":"https://api.github.com/repos/twbs/bootstrap/pulls/23098","_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments/127589569"},"html":{"href":"https://github.com/twbs/bootstrap/pull/23098#discussion_r127589569"},"pull_request":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/23098"}}},"pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/23098","id":130724013,"html_url":"https://github.com/twbs/bootstrap/pull/23098","diff_url":"https://github.com/twbs/bootstrap/pull/23098.diff","patch_url":"https://github.com/twbs/bootstrap/pull/23098.patch","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/23098","number":23098,"state":"closed","locked":false,"title":"Master","user":{"login":"torrejonrodrigo","id":17417514,"avatar_url":"https://avatars6.githubusercontent.com/u/17417514?v=4","gravatar_id":"","url":"https://api.github.com/users/torrejonrodrigo","html_url":"https://github.com/torrejonrodrigo","followers_url":"https://api.github.com/users/torrejonrodrigo/followers","following_url":"https://api.github.com/users/torrejonrodrigo/following{/other_user}","gists_url":"https://api.github.com/users/torrejonrodrigo/gists{/gist_id}","starred_url":"https://api.github.com/users/torrejonrodrigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torrejonrodrigo/subscriptions","organizations_url":"https://api.github.com/users/torrejonrodrigo/orgs","repos_url":"https://api.github.com/users/torrejonrodrigo/repos","events_url":"https://api.github.com/users/torrejonrodrigo/events{/privacy}","received_events_url":"https://api.github.com/users/torrejonrodrigo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-15T17:52:51Z","updated_at":"2017-07-15T17:53:23Z","closed_at":"2017-07-15T17:52:54Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/twbs/bootstrap/pulls/23098/commits","review_comments_url":"https://api.github.com/repos/twbs/bootstrap/pulls/23098/comments","review_comment_url":"https://api.github.com/repos/twbs/bootstrap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/23098/comments","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/9b7d1406b922300c5d01e99026e4fffc67445185","head":{"label":"twbs:master","ref":"master","sha":"9b7d1406b922300c5d01e99026e4fffc67445185","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars4.githubusercontent.com/u/2918581?v=4","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":2126244,"name":"bootstrap","full_name":"twbs/bootstrap","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars4.githubusercontent.com/u/2918581?v=4","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":false,"url":"https://api.github.com/repos/twbs/bootstrap","forks_url":"https://api.github.com/repos/twbs/bootstrap/forks","keys_url":"https://api.github.com/repos/twbs/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/bootstrap/teams","hooks_url":"https://api.github.com/repos/twbs/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/twbs/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/bootstrap/events","assignees_url":"https://api.github.com/repos/twbs/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/bootstrap/tags","blobs_url":"https://api.github.com/repos/twbs/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/bootstrap/languages","stargazers_url":"https://api.github.com/repos/twbs/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/twbs/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/twbs/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/twbs/bootstrap/subscription","commits_url":"https://api.github.com/repos/twbs/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/twbs/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/bootstrap/merges","archive_url":"https://api.github.com/repos/twbs/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/bootstrap/downloads","issues_url":"https://api.github.com/repos/twbs/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/twbs/bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/twbs/bootstrap/deployments","created_at":"2011-07-29T21:19:00Z","updated_at":"2017-07-15T17:35:25Z","pushed_at":"2017-07-15T17:52:55Z","git_url":"git://github.com/twbs/bootstrap.git","ssh_url":"git@github.com:twbs/bootstrap.git","clone_url":"https://github.com/twbs/bootstrap.git","svn_url":"https://github.com/twbs/bootstrap","homepage":"http://getbootstrap.com","size":99647,"stargazers_count":112664,"watchers_count":112664,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52262,"mirror_url":null,"open_issues_count":257,"forks":52262,"open_issues":257,"watchers":112664,"default_branch":"v4-dev"}},"base":{"label":"twbs:v4-dev","ref":"v4-dev","sha":"62a47962683a751ddbd6eb4d507c53c16721d97f","user":{"login":"twbs","id":2918581,"avatar_url":"https://avatars4.githubusercontent.com/u/2918581?v=4","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"repo":{"id":2126244,"name":"bootstrap","full_name":"twbs/bootstrap","owner":{"login":"twbs","id":2918581,"avatar_url":"https://avatars4.githubusercontent.com/u/2918581?v=4","gravatar_id":"","url":"https://api.github.com/users/twbs","html_url":"https://github.com/twbs","followers_url":"https://api.github.com/users/twbs/followers","following_url":"https://api.github.com/users/twbs/following{/other_user}","gists_url":"https://api.github.com/users/twbs/gists{/gist_id}","starred_url":"https://api.github.com/users/twbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twbs/subscriptions","organizations_url":"https://api.github.com/users/twbs/orgs","repos_url":"https://api.github.com/users/twbs/repos","events_url":"https://api.github.com/users/twbs/events{/privacy}","received_events_url":"https://api.github.com/users/twbs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twbs/bootstrap","description":"The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.","fork":false,"url":"https://api.github.com/repos/twbs/bootstrap","forks_url":"https://api.github.com/repos/twbs/bootstrap/forks","keys_url":"https://api.github.com/repos/twbs/bootstrap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twbs/bootstrap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twbs/bootstrap/teams","hooks_url":"https://api.github.com/repos/twbs/bootstrap/hooks","issue_events_url":"https://api.github.com/repos/twbs/bootstrap/issues/events{/number}","events_url":"https://api.github.com/repos/twbs/bootstrap/events","assignees_url":"https://api.github.com/repos/twbs/bootstrap/assignees{/user}","branches_url":"https://api.github.com/repos/twbs/bootstrap/branches{/branch}","tags_url":"https://api.github.com/repos/twbs/bootstrap/tags","blobs_url":"https://api.github.com/repos/twbs/bootstrap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twbs/bootstrap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twbs/bootstrap/git/refs{/sha}","trees_url":"https://api.github.com/repos/twbs/bootstrap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twbs/bootstrap/statuses/{sha}","languages_url":"https://api.github.com/repos/twbs/bootstrap/languages","stargazers_url":"https://api.github.com/repos/twbs/bootstrap/stargazers","contributors_url":"https://api.github.com/repos/twbs/bootstrap/contributors","subscribers_url":"https://api.github.com/repos/twbs/bootstrap/subscribers","subscription_url":"https://api.github.com/repos/twbs/bootstrap/subscription","commits_url":"https://api.github.com/repos/twbs/bootstrap/commits{/sha}","git_commits_url":"https://api.github.com/repos/twbs/bootstrap/git/commits{/sha}","comments_url":"https://api.github.com/repos/twbs/bootstrap/comments{/number}","issue_comment_url":"https://api.github.com/repos/twbs/bootstrap/issues/comments{/number}","contents_url":"https://api.github.com/repos/twbs/bootstrap/contents/{+path}","compare_url":"https://api.github.com/repos/twbs/bootstrap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twbs/bootstrap/merges","archive_url":"https://api.github.com/repos/twbs/bootstrap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twbs/bootstrap/downloads","issues_url":"https://api.github.com/repos/twbs/bootstrap/issues{/number}","pulls_url":"https://api.github.com/repos/twbs/bootstrap/pulls{/number}","milestones_url":"https://api.github.com/repos/twbs/bootstrap/milestones{/number}","notifications_url":"https://api.github.com/repos/twbs/bootstrap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twbs/bootstrap/labels{/name}","releases_url":"https://api.github.com/repos/twbs/bootstrap/releases{/id}","deployments_url":"https://api.github.com/repos/twbs/bootstrap/deployments","created_at":"2011-07-29T21:19:00Z","updated_at":"2017-07-15T17:35:25Z","pushed_at":"2017-07-15T17:52:55Z","git_url":"git://github.com/twbs/bootstrap.git","ssh_url":"git@github.com:twbs/bootstrap.git","clone_url":"https://github.com/twbs/bootstrap.git","svn_url":"https://github.com/twbs/bootstrap","homepage":"http://getbootstrap.com","size":99647,"stargazers_count":112664,"watchers_count":112664,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":52262,"mirror_url":null,"open_issues_count":257,"forks":52262,"open_issues":257,"watchers":112664,"default_branch":"v4-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/23098"},"html":{"href":"https://github.com/twbs/bootstrap/pull/23098"},"issue":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/23098"},"comments":{"href":"https://api.github.com/repos/twbs/bootstrap/issues/23098/comments"},"review_comments":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/23098/comments"},"review_comment":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twbs/bootstrap/pulls/23098/commits"},"statuses":{"href":"https://api.github.com/repos/twbs/bootstrap/statuses/9b7d1406b922300c5d01e99026e4fffc67445185"}}}}
|
{
"id": 2126244,
"name": "twbs/bootstrap",
"url": "https://api.github.com/repos/twbs/bootstrap"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 2918581,
"login": "twbs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2918581?",
"url": "https://api.github.com/orgs/twbs"
}
| 2017-07-15T17:53:23 |
6263200607
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/uber/react-vis/pulls/comments/147586325","pull_request_review_id":72702181,"id":147586325,"diff_hunk":"@@ -37,6 +39,22 @@ test('Sankey: labels', t => {\n \n });\n \n+test('Sankey: children', t => {\n+ const wrap = mount(","path":"tests/components/sankey-tests.js","position":18,"original_position":18,"commit_id":"10e4a4f0cb06e81990b0c06136964f790daf1c76","original_commit_id":"10e4a4f0cb06e81990b0c06136964f790daf1c76","user":{"login":"mcnuttandrew","id":6854312,"avatar_url":"https://avatars1.githubusercontent.com/u/6854312?v=4","gravatar_id":"","url":"https://api.github.com/users/mcnuttandrew","html_url":"https://github.com/mcnuttandrew","followers_url":"https://api.github.com/users/mcnuttandrew/followers","following_url":"https://api.github.com/users/mcnuttandrew/following{/other_user}","gists_url":"https://api.github.com/users/mcnuttandrew/gists{/gist_id}","starred_url":"https://api.github.com/users/mcnuttandrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcnuttandrew/subscriptions","organizations_url":"https://api.github.com/users/mcnuttandrew/orgs","repos_url":"https://api.github.com/users/mcnuttandrew/repos","events_url":"https://api.github.com/users/mcnuttandrew/events{/privacy}","received_events_url":"https://api.github.com/users/mcnuttandrew/received_events","type":"User","site_admin":false},"body":"for consistancy wrap should be $","created_at":"2017-10-29T16:16:09Z","updated_at":"2017-10-29T16:16:52Z","html_url":"https://github.com/uber/react-vis/pull/648#discussion_r147586325","pull_request_url":"https://api.github.com/repos/uber/react-vis/pulls/648","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/uber/react-vis/pulls/comments/147586325"},"html":{"href":"https://github.com/uber/react-vis/pull/648#discussion_r147586325"},"pull_request":{"href":"https://api.github.com/repos/uber/react-vis/pulls/648"}}},"pull_request":{"url":"https://api.github.com/repos/uber/react-vis/pulls/648","id":149392037,"html_url":"https://github.com/uber/react-vis/pull/648","diff_url":"https://github.com/uber/react-vis/pull/648.diff","patch_url":"https://github.com/uber/react-vis/pull/648.patch","issue_url":"https://api.github.com/repos/uber/react-vis/issues/648","number":648,"state":"open","locked":false,"title":" Add support for children at Sankey to enable usage of Hint","user":{"login":"chlumper","id":25345228,"avatar_url":"https://avatars1.githubusercontent.com/u/25345228?v=4","gravatar_id":"","url":"https://api.github.com/users/chlumper","html_url":"https://github.com/chlumper","followers_url":"https://api.github.com/users/chlumper/followers","following_url":"https://api.github.com/users/chlumper/following{/other_user}","gists_url":"https://api.github.com/users/chlumper/gists{/gist_id}","starred_url":"https://api.github.com/users/chlumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlumper/subscriptions","organizations_url":"https://api.github.com/users/chlumper/orgs","repos_url":"https://api.github.com/users/chlumper/repos","events_url":"https://api.github.com/users/chlumper/events{/privacy}","received_events_url":"https://api.github.com/users/chlumper/received_events","type":"User","site_admin":false},"body":"- Add support for children at Sankey to enable usage of Hint\r\nAdds support for children property at Sankey diagram to render additional content at underlying XYPlot. This enables the rendering of Hints within the Sankey.\r\n- Add showcase sample for Sankey with Hint on hover of link\r\n- Add tests for children at Sankey and showcase of Sankey with Hint\r\n\r\nRelated to #631 and #634 ","created_at":"2017-10-29T16:00:59Z","updated_at":"2017-10-29T16:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"165854f9c035542209b7e1ee832c47719684027b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/react-vis/pulls/648/commits","review_comments_url":"https://api.github.com/repos/uber/react-vis/pulls/648/comments","review_comment_url":"https://api.github.com/repos/uber/react-vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/react-vis/issues/648/comments","statuses_url":"https://api.github.com/repos/uber/react-vis/statuses/10e4a4f0cb06e81990b0c06136964f790daf1c76","head":{"label":"chlumper:master","ref":"master","sha":"10e4a4f0cb06e81990b0c06136964f790daf1c76","user":{"login":"chlumper","id":25345228,"avatar_url":"https://avatars1.githubusercontent.com/u/25345228?v=4","gravatar_id":"","url":"https://api.github.com/users/chlumper","html_url":"https://github.com/chlumper","followers_url":"https://api.github.com/users/chlumper/followers","following_url":"https://api.github.com/users/chlumper/following{/other_user}","gists_url":"https://api.github.com/users/chlumper/gists{/gist_id}","starred_url":"https://api.github.com/users/chlumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlumper/subscriptions","organizations_url":"https://api.github.com/users/chlumper/orgs","repos_url":"https://api.github.com/users/chlumper/repos","events_url":"https://api.github.com/users/chlumper/events{/privacy}","received_events_url":"https://api.github.com/users/chlumper/received_events","type":"User","site_admin":false},"repo":{"id":103733479,"name":"react-vis","full_name":"chlumper/react-vis","owner":{"login":"chlumper","id":25345228,"avatar_url":"https://avatars1.githubusercontent.com/u/25345228?v=4","gravatar_id":"","url":"https://api.github.com/users/chlumper","html_url":"https://github.com/chlumper","followers_url":"https://api.github.com/users/chlumper/followers","following_url":"https://api.github.com/users/chlumper/following{/other_user}","gists_url":"https://api.github.com/users/chlumper/gists{/gist_id}","starred_url":"https://api.github.com/users/chlumper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chlumper/subscriptions","organizations_url":"https://api.github.com/users/chlumper/orgs","repos_url":"https://api.github.com/users/chlumper/repos","events_url":"https://api.github.com/users/chlumper/events{/privacy}","received_events_url":"https://api.github.com/users/chlumper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chlumper/react-vis","description":"Data-Visualization oriented components","fork":true,"url":"https://api.github.com/repos/chlumper/react-vis","forks_url":"https://api.github.com/repos/chlumper/react-vis/forks","keys_url":"https://api.github.com/repos/chlumper/react-vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chlumper/react-vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chlumper/react-vis/teams","hooks_url":"https://api.github.com/repos/chlumper/react-vis/hooks","issue_events_url":"https://api.github.com/repos/chlumper/react-vis/issues/events{/number}","events_url":"https://api.github.com/repos/chlumper/react-vis/events","assignees_url":"https://api.github.com/repos/chlumper/react-vis/assignees{/user}","branches_url":"https://api.github.com/repos/chlumper/react-vis/branches{/branch}","tags_url":"https://api.github.com/repos/chlumper/react-vis/tags","blobs_url":"https://api.github.com/repos/chlumper/react-vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chlumper/react-vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chlumper/react-vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/chlumper/react-vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chlumper/react-vis/statuses/{sha}","languages_url":"https://api.github.com/repos/chlumper/react-vis/languages","stargazers_url":"https://api.github.com/repos/chlumper/react-vis/stargazers","contributors_url":"https://api.github.com/repos/chlumper/react-vis/contributors","subscribers_url":"https://api.github.com/repos/chlumper/react-vis/subscribers","subscription_url":"https://api.github.com/repos/chlumper/react-vis/subscription","commits_url":"https://api.github.com/repos/chlumper/react-vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/chlumper/react-vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/chlumper/react-vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/chlumper/react-vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/chlumper/react-vis/contents/{+path}","compare_url":"https://api.github.com/repos/chlumper/react-vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chlumper/react-vis/merges","archive_url":"https://api.github.com/repos/chlumper/react-vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chlumper/react-vis/downloads","issues_url":"https://api.github.com/repos/chlumper/react-vis/issues{/number}","pulls_url":"https://api.github.com/repos/chlumper/react-vis/pulls{/number}","milestones_url":"https://api.github.com/repos/chlumper/react-vis/milestones{/number}","notifications_url":"https://api.github.com/repos/chlumper/react-vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chlumper/react-vis/labels{/name}","releases_url":"https://api.github.com/repos/chlumper/react-vis/releases{/id}","deployments_url":"https://api.github.com/repos/chlumper/react-vis/deployments","created_at":"2017-09-16T07:18:21Z","updated_at":"2017-09-16T07:18:23Z","pushed_at":"2017-10-29T15:56:14Z","git_url":"git://github.com/chlumper/react-vis.git","ssh_url":"git@github.com:chlumper/react-vis.git","clone_url":"https://github.com/chlumper/react-vis.git","svn_url":"https://github.com/chlumper/react-vis","homepage":"https://uber.github.io/react-vis","size":5620,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"ec1ed9f9b9dc140c1ee1d53292e51f31f99161a1","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":52304362,"name":"react-vis","full_name":"uber/react-vis","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/react-vis","description":"Data-Visualization oriented components","fork":false,"url":"https://api.github.com/repos/uber/react-vis","forks_url":"https://api.github.com/repos/uber/react-vis/forks","keys_url":"https://api.github.com/repos/uber/react-vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/react-vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/react-vis/teams","hooks_url":"https://api.github.com/repos/uber/react-vis/hooks","issue_events_url":"https://api.github.com/repos/uber/react-vis/issues/events{/number}","events_url":"https://api.github.com/repos/uber/react-vis/events","assignees_url":"https://api.github.com/repos/uber/react-vis/assignees{/user}","branches_url":"https://api.github.com/repos/uber/react-vis/branches{/branch}","tags_url":"https://api.github.com/repos/uber/react-vis/tags","blobs_url":"https://api.github.com/repos/uber/react-vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/react-vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/react-vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/react-vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/react-vis/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/react-vis/languages","stargazers_url":"https://api.github.com/repos/uber/react-vis/stargazers","contributors_url":"https://api.github.com/repos/uber/react-vis/contributors","subscribers_url":"https://api.github.com/repos/uber/react-vis/subscribers","subscription_url":"https://api.github.com/repos/uber/react-vis/subscription","commits_url":"https://api.github.com/repos/uber/react-vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/react-vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/react-vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/react-vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/react-vis/contents/{+path}","compare_url":"https://api.github.com/repos/uber/react-vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/react-vis/merges","archive_url":"https://api.github.com/repos/uber/react-vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/react-vis/downloads","issues_url":"https://api.github.com/repos/uber/react-vis/issues{/number}","pulls_url":"https://api.github.com/repos/uber/react-vis/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/react-vis/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/react-vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/react-vis/labels{/name}","releases_url":"https://api.github.com/repos/uber/react-vis/releases{/id}","deployments_url":"https://api.github.com/repos/uber/react-vis/deployments","created_at":"2016-02-22T20:45:50Z","updated_at":"2017-10-29T01:10:28Z","pushed_at":"2017-10-29T16:01:00Z","git_url":"git://github.com/uber/react-vis.git","ssh_url":"git@github.com:uber/react-vis.git","clone_url":"https://github.com/uber/react-vis.git","svn_url":"https://github.com/uber/react-vis","homepage":"https://uber.github.io/react-vis","size":7703,"stargazers_count":2485,"watchers_count":2485,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":70,"forks":208,"open_issues":70,"watchers":2485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/react-vis/pulls/648"},"html":{"href":"https://github.com/uber/react-vis/pull/648"},"issue":{"href":"https://api.github.com/repos/uber/react-vis/issues/648"},"comments":{"href":"https://api.github.com/repos/uber/react-vis/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/react-vis/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/react-vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/react-vis/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/uber/react-vis/statuses/10e4a4f0cb06e81990b0c06136964f790daf1c76"}},"author_association":"NONE"}}
|
{
"id": 52304362,
"name": "uber/react-vis",
"url": "https://api.github.com/repos/uber/react-vis"
}
|
{
"id": 6854312,
"login": "mcnuttandrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6854312?",
"url": "https://api.github.com/users/mcnuttandrew"
}
|
{
"id": 538264,
"login": "uber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/538264?",
"url": "https://api.github.com/orgs/uber"
}
| 2017-10-29T16:16:09 |
6780636038
|
{"actor":{"display_login":"mcnuttandrew"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/comments/144699752","pull_request_review_id":69398085,"id":144699752,"diff_hunk":"@@ -160,8 +160,8 @@ export default class PolygonLayer extends CompositeLayer {\n miterLimit: lineMiterLimit,\n \n getPath: x => x.path,\n- getColor: getLineColor,\n- getWidth: getLineWidth,\n+ getColor: x => getLineColor(x.object),","path":"src/core-layers/polygon-layer/polygon-layer.js","position":6,"original_position":6,"commit_id":"1ab95f9394cbfe2d424f84d05bf26033f5d0ab07","original_commit_id":"1ab95f9394cbfe2d424f84d05bf26033f5d0ab07","user":{"login":"ibgreen","id":7025232,"avatar_url":"https://avatars1.githubusercontent.com/u/7025232?v=4","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"body":"@georgios-uber As far as I can tell this would make the layer look for `<object>.object.fillColor` which is inconsistent with the docs that says we are looking for `<object>.fillColor` and would be a big change. \r\n\r\nhttps://uber.github.io/deck.gl/#/documentation/layer-catalog/polygon-layer?section=render-options\r\n\r\nMaybe something in the docs is unclear?","created_at":"2017-10-14T17:54:23Z","updated_at":"2017-10-14T17:55:00Z","html_url":"https://github.com/uber/deck.gl/pull/1032#discussion_r144699752","pull_request_url":"https://api.github.com/repos/uber/deck.gl/pulls/1032","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments/144699752"},"html":{"href":"https://github.com/uber/deck.gl/pull/1032#discussion_r144699752"},"pull_request":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1032"}}},"pull_request":{"url":"https://api.github.com/repos/uber/deck.gl/pulls/1032","id":146581561,"html_url":"https://github.com/uber/deck.gl/pull/1032","diff_url":"https://github.com/uber/deck.gl/pull/1032.diff","patch_url":"https://github.com/uber/deck.gl/pull/1032.patch","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/1032","number":1032,"state":"open","locked":false,"title":"Fix PolygonLayer issue with Data Accessors","user":{"login":"georgios-uber","id":25012840,"avatar_url":"https://avatars2.githubusercontent.com/u/25012840?v=4","gravatar_id":"","url":"https://api.github.com/users/georgios-uber","html_url":"https://github.com/georgios-uber","followers_url":"https://api.github.com/users/georgios-uber/followers","following_url":"https://api.github.com/users/georgios-uber/following{/other_user}","gists_url":"https://api.github.com/users/georgios-uber/gists{/gist_id}","starred_url":"https://api.github.com/users/georgios-uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgios-uber/subscriptions","organizations_url":"https://api.github.com/users/georgios-uber/orgs","repos_url":"https://api.github.com/users/georgios-uber/repos","events_url":"https://api.github.com/users/georgios-uber/events{/privacy}","received_events_url":"https://api.github.com/users/georgios-uber/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-14T01:51:50Z","updated_at":"2017-10-14T17:55:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8b3889913407109d1a2b95f700119982a5b0e02","assignee":{"login":"georgios-uber","id":25012840,"avatar_url":"https://avatars2.githubusercontent.com/u/25012840?v=4","gravatar_id":"","url":"https://api.github.com/users/georgios-uber","html_url":"https://github.com/georgios-uber","followers_url":"https://api.github.com/users/georgios-uber/followers","following_url":"https://api.github.com/users/georgios-uber/following{/other_user}","gists_url":"https://api.github.com/users/georgios-uber/gists{/gist_id}","starred_url":"https://api.github.com/users/georgios-uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgios-uber/subscriptions","organizations_url":"https://api.github.com/users/georgios-uber/orgs","repos_url":"https://api.github.com/users/georgios-uber/repos","events_url":"https://api.github.com/users/georgios-uber/events{/privacy}","received_events_url":"https://api.github.com/users/georgios-uber/received_events","type":"User","site_admin":false},"assignees":[{"login":"georgios-uber","id":25012840,"avatar_url":"https://avatars2.githubusercontent.com/u/25012840?v=4","gravatar_id":"","url":"https://api.github.com/users/georgios-uber","html_url":"https://github.com/georgios-uber","followers_url":"https://api.github.com/users/georgios-uber/followers","following_url":"https://api.github.com/users/georgios-uber/following{/other_user}","gists_url":"https://api.github.com/users/georgios-uber/gists{/gist_id}","starred_url":"https://api.github.com/users/georgios-uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgios-uber/subscriptions","organizations_url":"https://api.github.com/users/georgios-uber/orgs","repos_url":"https://api.github.com/users/georgios-uber/repos","events_url":"https://api.github.com/users/georgios-uber/events{/privacy}","received_events_url":"https://api.github.com/users/georgios-uber/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/deck.gl/pulls/1032/commits","review_comments_url":"https://api.github.com/repos/uber/deck.gl/pulls/1032/comments","review_comment_url":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/1032/comments","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/1ab95f9394cbfe2d424f84d05bf26033f5d0ab07","head":{"label":"uber:fixPolygonLayerAccessors","ref":"fixPolygonLayerAccessors","sha":"1ab95f9394cbfe2d424f84d05bf26033f5d0ab07","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"WebGL based visualization layers","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2017-10-14T11:06:40Z","pushed_at":"2017-10-14T01:51:51Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"http://uber.github.io/deck.gl","size":93530,"stargazers_count":3600,"watchers_count":3600,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":429,"mirror_url":null,"open_issues_count":52,"forks":429,"open_issues":52,"watchers":3600,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"4783819f9b0789314ca28c819086bc832db67c93","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":48030204,"name":"deck.gl","full_name":"uber/deck.gl","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/deck.gl","description":"WebGL based visualization layers","fork":false,"url":"https://api.github.com/repos/uber/deck.gl","forks_url":"https://api.github.com/repos/uber/deck.gl/forks","keys_url":"https://api.github.com/repos/uber/deck.gl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/deck.gl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/deck.gl/teams","hooks_url":"https://api.github.com/repos/uber/deck.gl/hooks","issue_events_url":"https://api.github.com/repos/uber/deck.gl/issues/events{/number}","events_url":"https://api.github.com/repos/uber/deck.gl/events","assignees_url":"https://api.github.com/repos/uber/deck.gl/assignees{/user}","branches_url":"https://api.github.com/repos/uber/deck.gl/branches{/branch}","tags_url":"https://api.github.com/repos/uber/deck.gl/tags","blobs_url":"https://api.github.com/repos/uber/deck.gl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/deck.gl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/deck.gl/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/deck.gl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/deck.gl/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/deck.gl/languages","stargazers_url":"https://api.github.com/repos/uber/deck.gl/stargazers","contributors_url":"https://api.github.com/repos/uber/deck.gl/contributors","subscribers_url":"https://api.github.com/repos/uber/deck.gl/subscribers","subscription_url":"https://api.github.com/repos/uber/deck.gl/subscription","commits_url":"https://api.github.com/repos/uber/deck.gl/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/deck.gl/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/deck.gl/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/deck.gl/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/deck.gl/contents/{+path}","compare_url":"https://api.github.com/repos/uber/deck.gl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/deck.gl/merges","archive_url":"https://api.github.com/repos/uber/deck.gl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/deck.gl/downloads","issues_url":"https://api.github.com/repos/uber/deck.gl/issues{/number}","pulls_url":"https://api.github.com/repos/uber/deck.gl/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/deck.gl/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/deck.gl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/deck.gl/labels{/name}","releases_url":"https://api.github.com/repos/uber/deck.gl/releases{/id}","deployments_url":"https://api.github.com/repos/uber/deck.gl/deployments","created_at":"2015-12-15T08:38:29Z","updated_at":"2017-10-14T11:06:40Z","pushed_at":"2017-10-14T01:51:51Z","git_url":"git://github.com/uber/deck.gl.git","ssh_url":"git@github.com:uber/deck.gl.git","clone_url":"https://github.com/uber/deck.gl.git","svn_url":"https://github.com/uber/deck.gl","homepage":"http://uber.github.io/deck.gl","size":93530,"stargazers_count":3600,"watchers_count":3600,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":429,"mirror_url":null,"open_issues_count":52,"forks":429,"open_issues":52,"watchers":3600,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1032"},"html":{"href":"https://github.com/uber/deck.gl/pull/1032"},"issue":{"href":"https://api.github.com/repos/uber/deck.gl/issues/1032"},"comments":{"href":"https://api.github.com/repos/uber/deck.gl/issues/1032/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1032/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/deck.gl/pulls/1032/commits"},"statuses":{"href":"https://api.github.com/repos/uber/deck.gl/statuses/1ab95f9394cbfe2d424f84d05bf26033f5d0ab07"}},"author_association":"NONE"}}
|
{
"id": 48030204,
"name": "uber/deck.gl",
"url": "https://api.github.com/repos/uber/deck.gl"
}
|
{
"id": 7025232,
"login": "ibgreen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7025232?",
"url": "https://api.github.com/users/ibgreen"
}
|
{
"id": 538264,
"login": "uber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/538264?",
"url": "https://api.github.com/orgs/uber"
}
| 2017-10-14T17:54:23 |
6717170417
|
{"actor":{"display_login":"ibgreen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/product-emm/pulls/comments/95305025","pull_request_review_id":15854289,"id":95305025,"diff_hunk":"@@ -289,8 +289,12 @@ private AndroidConfigurationManagement() {\n public static final String ROLE_NAME = \"administration\";\n public static final String UPDATED_ROLE_NAME = \"manager\";\n public static final String ROLE_ENDPOINT = \"/api/device-mgt/v1.0/roles\";\n+ public static final String ROLE_ENDPOINT_WITH_PAGINATION\n+ = \"/api/device-mgt/v1.0/roles?offset=0&limit=2\";\n public static final String SCOPE_ROLE_ENDPOINT = \"/api/device-mgt/v1.0/roles/scopes\";\n public static final String ROLE_PAYLOAD_FILE_NAME = \"role-payloads.json\";\n+ public static final String ROLE_RESPONSE_PAYLOAD\n+ = \"[{\\\"key\\\":\\\"role:view\\\",\\\"name\\\":\\\"View roles\\\",\\\"roles\\\":\\\"admin,manager\\\",\\\"description\\\":\\\"\\\"},{\\\"key\\\":\\\"role:manage\\\",\\\"name\\\":\\\"Add roles\\\",\\\"roles\\\":\\\"admin,manager\\\",\\\"description\\\":\\\"\\\"}]\";","path":"modules/integration/tests-integration/src/test/java/org/wso2/mdm/integration/common/Constants.java","position":9,"original_position":9,"commit_id":"b841085f5e153d2875f150e67637731b01a21425","original_commit_id":"b841085f5e153d2875f150e67637731b01a21425","user":{"login":"chaturadilan","id":390081,"avatar_url":"https://avatars.githubusercontent.com/u/390081?v=3","gravatar_id":"","url":"https://api.github.com/users/chaturadilan","html_url":"https://github.com/chaturadilan","followers_url":"https://api.github.com/users/chaturadilan/followers","following_url":"https://api.github.com/users/chaturadilan/following{/other_user}","gists_url":"https://api.github.com/users/chaturadilan/gists{/gist_id}","starred_url":"https://api.github.com/users/chaturadilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaturadilan/subscriptions","organizations_url":"https://api.github.com/users/chaturadilan/orgs","repos_url":"https://api.github.com/users/chaturadilan/repos","events_url":"https://api.github.com/users/chaturadilan/events{/privacy}","received_events_url":"https://api.github.com/users/chaturadilan/received_events","type":"User","site_admin":false},"body":"declare this as a JSON array and get the string value when needed. ","created_at":"2017-01-10T06:10:46Z","updated_at":"2017-01-10T06:10:46Z","html_url":"https://github.com/wso2/product-emm/pull/281#discussion_r95305025","pull_request_url":"https://api.github.com/repos/wso2/product-emm/pulls/281","_links":{"self":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/comments/95305025"},"html":{"href":"https://github.com/wso2/product-emm/pull/281#discussion_r95305025"},"pull_request":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/281"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/product-emm/pulls/281","id":82668878,"html_url":"https://github.com/wso2/product-emm/pull/281","diff_url":"https://github.com/wso2/product-emm/pull/281.diff","patch_url":"https://github.com/wso2/product-emm/pull/281.patch","issue_url":"https://api.github.com/repos/wso2/product-emm/issues/281","number":281,"state":"closed","locked":false,"title":"Fixes for integration tests","user":{"login":"madhawap","id":12988860,"avatar_url":"https://avatars.githubusercontent.com/u/12988860?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawap","html_url":"https://github.com/madhawap","followers_url":"https://api.github.com/users/madhawap/followers","following_url":"https://api.github.com/users/madhawap/following{/other_user}","gists_url":"https://api.github.com/users/madhawap/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawap/subscriptions","organizations_url":"https://api.github.com/users/madhawap/orgs","repos_url":"https://api.github.com/users/madhawap/repos","events_url":"https://api.github.com/users/madhawap/events{/privacy}","received_events_url":"https://api.github.com/users/madhawap/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-08-25T07:23:20Z","updated_at":"2017-01-10T06:10:46Z","closed_at":"2016-08-25T10:56:48Z","merged_at":"2016-08-25T10:56:48Z","merge_commit_sha":"f25f7c5ed3a1734666ee2dd8b0b77b86ec5aadcf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/product-emm/pulls/281/commits","review_comments_url":"https://api.github.com/repos/wso2/product-emm/pulls/281/comments","review_comment_url":"https://api.github.com/repos/wso2/product-emm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/product-emm/issues/281/comments","statuses_url":"https://api.github.com/repos/wso2/product-emm/statuses/b841085f5e153d2875f150e67637731b01a21425","head":{"label":"madhawap:master","ref":"master","sha":"b841085f5e153d2875f150e67637731b01a21425","user":{"login":"madhawap","id":12988860,"avatar_url":"https://avatars.githubusercontent.com/u/12988860?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawap","html_url":"https://github.com/madhawap","followers_url":"https://api.github.com/users/madhawap/followers","following_url":"https://api.github.com/users/madhawap/following{/other_user}","gists_url":"https://api.github.com/users/madhawap/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawap/subscriptions","organizations_url":"https://api.github.com/users/madhawap/orgs","repos_url":"https://api.github.com/users/madhawap/repos","events_url":"https://api.github.com/users/madhawap/events{/privacy}","received_events_url":"https://api.github.com/users/madhawap/received_events","type":"User","site_admin":false},"repo":{"id":59989510,"name":"product-emm","full_name":"madhawap/product-emm","owner":{"login":"madhawap","id":12988860,"avatar_url":"https://avatars.githubusercontent.com/u/12988860?v=3","gravatar_id":"","url":"https://api.github.com/users/madhawap","html_url":"https://github.com/madhawap","followers_url":"https://api.github.com/users/madhawap/followers","following_url":"https://api.github.com/users/madhawap/following{/other_user}","gists_url":"https://api.github.com/users/madhawap/gists{/gist_id}","starred_url":"https://api.github.com/users/madhawap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/madhawap/subscriptions","organizations_url":"https://api.github.com/users/madhawap/orgs","repos_url":"https://api.github.com/users/madhawap/repos","events_url":"https://api.github.com/users/madhawap/events{/privacy}","received_events_url":"https://api.github.com/users/madhawap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/madhawap/product-emm","description":null,"fork":true,"url":"https://api.github.com/repos/madhawap/product-emm","forks_url":"https://api.github.com/repos/madhawap/product-emm/forks","keys_url":"https://api.github.com/repos/madhawap/product-emm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/madhawap/product-emm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/madhawap/product-emm/teams","hooks_url":"https://api.github.com/repos/madhawap/product-emm/hooks","issue_events_url":"https://api.github.com/repos/madhawap/product-emm/issues/events{/number}","events_url":"https://api.github.com/repos/madhawap/product-emm/events","assignees_url":"https://api.github.com/repos/madhawap/product-emm/assignees{/user}","branches_url":"https://api.github.com/repos/madhawap/product-emm/branches{/branch}","tags_url":"https://api.github.com/repos/madhawap/product-emm/tags","blobs_url":"https://api.github.com/repos/madhawap/product-emm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/madhawap/product-emm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/madhawap/product-emm/git/refs{/sha}","trees_url":"https://api.github.com/repos/madhawap/product-emm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/madhawap/product-emm/statuses/{sha}","languages_url":"https://api.github.com/repos/madhawap/product-emm/languages","stargazers_url":"https://api.github.com/repos/madhawap/product-emm/stargazers","contributors_url":"https://api.github.com/repos/madhawap/product-emm/contributors","subscribers_url":"https://api.github.com/repos/madhawap/product-emm/subscribers","subscription_url":"https://api.github.com/repos/madhawap/product-emm/subscription","commits_url":"https://api.github.com/repos/madhawap/product-emm/commits{/sha}","git_commits_url":"https://api.github.com/repos/madhawap/product-emm/git/commits{/sha}","comments_url":"https://api.github.com/repos/madhawap/product-emm/comments{/number}","issue_comment_url":"https://api.github.com/repos/madhawap/product-emm/issues/comments{/number}","contents_url":"https://api.github.com/repos/madhawap/product-emm/contents/{+path}","compare_url":"https://api.github.com/repos/madhawap/product-emm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/madhawap/product-emm/merges","archive_url":"https://api.github.com/repos/madhawap/product-emm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/madhawap/product-emm/downloads","issues_url":"https://api.github.com/repos/madhawap/product-emm/issues{/number}","pulls_url":"https://api.github.com/repos/madhawap/product-emm/pulls{/number}","milestones_url":"https://api.github.com/repos/madhawap/product-emm/milestones{/number}","notifications_url":"https://api.github.com/repos/madhawap/product-emm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/madhawap/product-emm/labels{/name}","releases_url":"https://api.github.com/repos/madhawap/product-emm/releases{/id}","deployments_url":"https://api.github.com/repos/madhawap/product-emm/deployments","created_at":"2016-05-30T07:28:01Z","updated_at":"2016-05-30T07:28:07Z","pushed_at":"2016-12-19T04:57:27Z","git_url":"git://github.com/madhawap/product-emm.git","ssh_url":"git@github.com:madhawap/product-emm.git","clone_url":"https://github.com/madhawap/product-emm.git","svn_url":"https://github.com/madhawap/product-emm","homepage":null,"size":148850,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"570cb1570555f73171ce389a2673e07e5b215c78","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":29459213,"name":"product-emm","full_name":"wso2/product-emm","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars.githubusercontent.com/u/533043?v=3","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/product-emm","description":"Welcome to the WSO2 Enterprise Mobility Manager source code! For info on working with the WSO2 Enterprise Mobility Manager repository and contributing code, click the link below.","fork":false,"url":"https://api.github.com/repos/wso2/product-emm","forks_url":"https://api.github.com/repos/wso2/product-emm/forks","keys_url":"https://api.github.com/repos/wso2/product-emm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/product-emm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/product-emm/teams","hooks_url":"https://api.github.com/repos/wso2/product-emm/hooks","issue_events_url":"https://api.github.com/repos/wso2/product-emm/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/product-emm/events","assignees_url":"https://api.github.com/repos/wso2/product-emm/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/product-emm/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/product-emm/tags","blobs_url":"https://api.github.com/repos/wso2/product-emm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/product-emm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/product-emm/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/product-emm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/product-emm/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/product-emm/languages","stargazers_url":"https://api.github.com/repos/wso2/product-emm/stargazers","contributors_url":"https://api.github.com/repos/wso2/product-emm/contributors","subscribers_url":"https://api.github.com/repos/wso2/product-emm/subscribers","subscription_url":"https://api.github.com/repos/wso2/product-emm/subscription","commits_url":"https://api.github.com/repos/wso2/product-emm/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/product-emm/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/product-emm/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/product-emm/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/product-emm/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/product-emm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/product-emm/merges","archive_url":"https://api.github.com/repos/wso2/product-emm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/product-emm/downloads","issues_url":"https://api.github.com/repos/wso2/product-emm/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/product-emm/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/product-emm/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/product-emm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/product-emm/labels{/name}","releases_url":"https://api.github.com/repos/wso2/product-emm/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/product-emm/deployments","created_at":"2015-01-19T07:36:01Z","updated_at":"2017-01-07T22:53:58Z","pushed_at":"2016-12-29T03:32:00Z","git_url":"git://github.com/wso2/product-emm.git","ssh_url":"git@github.com:wso2/product-emm.git","clone_url":"https://github.com/wso2/product-emm.git","svn_url":"https://github.com/wso2/product-emm","homepage":"http://wso2.github.io/","size":153182,"stargazers_count":89,"watchers_count":89,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":24,"forks":124,"open_issues":24,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/281"},"html":{"href":"https://github.com/wso2/product-emm/pull/281"},"issue":{"href":"https://api.github.com/repos/wso2/product-emm/issues/281"},"comments":{"href":"https://api.github.com/repos/wso2/product-emm/issues/281/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/281/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/product-emm/pulls/281/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/product-emm/statuses/b841085f5e153d2875f150e67637731b01a21425"}}}}
|
{
"id": 29459213,
"name": "wso2/product-emm",
"url": "https://api.github.com/repos/wso2/product-emm"
}
|
{
"id": 390081,
"login": "chaturadilan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/390081?",
"url": "https://api.github.com/users/chaturadilan"
}
|
{
"id": 533043,
"login": "wso2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/533043?",
"url": "https://api.github.com/orgs/wso2"
}
| 2017-01-10T06:10:46 |
5127137359
|
{"actor":{"display_login":"chaturadilan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/comments/150733493","pull_request_review_id":76326282,"id":150733493,"diff_hunk":"@@ -0,0 +1,283 @@\n+/*\n+ * Copyright (c) 2017, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.\n+ *\n+ * WSO2 Inc. licenses this file to you under the Apache License,\n+ * Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License.\n+ * You may obtain a copy of the License at\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.wso2.carbon.mediator.cache;\n+\n+import org.apache.axiom.om.OMAttribute;\n+import org.apache.axiom.om.OMElement;\n+import org.apache.synapse.Mediator;\n+import org.apache.synapse.config.xml.AbstractMediatorFactory;\n+import org.apache.synapse.config.xml.SequenceMediatorFactory;\n+import org.apache.synapse.config.xml.XMLConfigConstants;\n+import org.apache.synapse.transport.passthru.PassThroughConstants;\n+import org.wso2.carbon.mediator.cache.digest.DigestGenerator;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.Properties;\n+import javax.xml.namespace.QName;\n+\n+/**\n+ * Creates a {@link CacheMediator} using the given OMElement for the cache mediator.\n+ */\n+public class CacheMediatorFactory extends AbstractMediatorFactory {\n+\n+ /**\n+ * QName of the timeout.\n+ */\n+ private static final QName ATT_TIMEOUT = new QName(CachingConstants.TIMEOUT_STRING);\n+\n+ /**\n+ * QName of the collector.\n+ */\n+ private static final QName ATT_COLLECTOR = new QName(CachingConstants.COLLECTOR_STRING);\n+\n+ /**\n+ * QName of the maximum message size.\n+ */\n+ private static final QName ATT_MAX_MSG_SIZE = new QName(CachingConstants.MAX_MESSAGE_SIZE_STRING);\n+\n+ /**\n+ * QName of the onCacheHit mediator sequence reference.\n+ */\n+ private static final QName ON_CACHE_HIT_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.ON_CACHE_HIT_STRING);\n+\n+ /**\n+ * QName of the mediator sequence.\n+ */\n+ private static final QName ATT_SEQUENCE = new QName(CachingConstants.SEQUENCE_STRING);\n+\n+ /**\n+ * QName of the onCacheHit mediator sequence reference.\n+ */\n+ private static final QName PROTOCOL_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.PROTOCOL_STRING);\n+\n+ /**\n+ * QName of the protocol type.\n+ */\n+ private static final QName ATT_TYPE = new QName(CachingConstants.TYPE_STRING);\n+\n+ /**\n+ * QName of the hTTPMethodToCache.\n+ */\n+ private static final QName HTTP_METHODS_TO_CACHE_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.METHODS_STRING);\n+\n+ /**\n+ * QName of the headersToExcludeInHash.\n+ */\n+ private static final QName HEADERS_TO_EXCLUDE_IN_HASH_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.HEADERS_TO_EXCLUDE_STRING);\n+ /**\n+ * QName of the response codes to include when hashing.\n+ */\n+ private static final QName RESPONSE_CODES_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.RESPONSE_CODES_STRING);\n+\n+ /**\n+ * QName of the digest generator.\n+ */\n+ private static final QName HASH_GENERATOR_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.HASH_GENERATOR_STRING);\n+\n+ /**\n+ * Attribute QName of the digest generator for backward compatibility.\n+ */\n+ private static final QName ATT_HASH_GENERATOR = new QName(CachingConstants.HASH_GENERATOR_STRING);\n+\n+ /**\n+ * QName of the cache implementation.\n+ */\n+ private static final QName IMPLEMENTATION_Q = new QName(XMLConfigConstants.SYNAPSE_NAMESPACE,\n+ CachingConstants.IMPLEMENTATION_STRING);\n+\n+ /**\n+ * QName of the maximum message size.\n+ */\n+ private static final QName ATT_SIZE = new QName(CachingConstants.MAX_SIZE_STRING);\n+\n+\n+ /**\n+ * {@inheritDoc}\n+ */\n+ protected Mediator createSpecificMediator(OMElement elem, Properties properties) {\n+ if (!CachingConstants.CACHE_Q.equals(elem.getQName())) {\n+ handleException(\n+ \"Unable to create the cache mediator. Unexpected element as the cache mediator configuration\");\n+ }\n+\n+ CacheMediator cache = new CacheMediator();\n+\n+ OMAttribute collectorAttr = elem.getAttribute(ATT_COLLECTOR);\n+ if (collectorAttr != null && collectorAttr.getAttributeValue() != null) {\n+ if (\"true\".equals(collectorAttr.getAttributeValue())) {\n+ cache.setCollector(true);\n+ } else if (\"false\".equals(collectorAttr.getAttributeValue())) {\n+ cache.setCollector(false);\n+\n+ OMAttribute timeoutAttr = elem.getAttribute(ATT_TIMEOUT);\n+ if (timeoutAttr != null && timeoutAttr.getAttributeValue() != null) {\n+ cache.setTimeout(Long.parseLong(timeoutAttr.getAttributeValue().trim()));\n+ } else {\n+ cache.setTimeout(CachingConstants.DEFAULT_TIMEOUT);\n+ }\n+\n+ OMAttribute maxMessageSizeAttr = elem.getAttribute(ATT_MAX_MSG_SIZE);\n+ if (maxMessageSizeAttr != null && maxMessageSizeAttr.getAttributeValue() != null) {\n+ cache.setMaxMessageSize(Integer.parseInt(maxMessageSizeAttr.getAttributeValue().trim()));\n+ } else {\n+ cache.setMaxMessageSize(-1);\n+ }\n+\n+ String className = null;\n+ OMElement protocolElem = elem.getFirstChildWithName(PROTOCOL_Q);\n+ Map<String, Object> props = new HashMap<>();\n+ if (protocolElem != null) {\n+ OMAttribute typeAttr = protocolElem.getAttribute(ATT_TYPE);\n+\n+ if (typeAttr != null &&\n+ typeAttr.getAttributeValue() != null) {\n+ OMElement hashGeneratorElem = protocolElem.getFirstChildWithName(HASH_GENERATOR_Q);\n+ if (hashGeneratorElem != null) {\n+ className = hashGeneratorElem.getText();\n+ }\n+\n+ String protocolType = typeAttr.getAttributeValue().toUpperCase().trim();\n+ cache.setProtocolType(protocolType);\n+ if (CachingConstants.HTTP_PROTOCOL_TYPE.equals(protocolType)) {\n+ OMElement methodElem = protocolElem.getFirstChildWithName(HTTP_METHODS_TO_CACHE_Q);\n+ if (methodElem != null) {\n+ String[] methods = methodElem.getText().split(\",\");\n+ if (!\"\".equals(methods[0])) {\n+ for (int i = 0; i < methods.length; i++) {\n+ methods[i] = methods[i].toUpperCase().trim();\n+ if (!(PassThroughConstants.HTTP_POST.equals(methods[i]) ||\n+ PassThroughConstants.HTTP_GET.equals(methods[i]) ||","path":"components/mediators/cache/org.wso2.carbon.mediator.cache/src/main/java/org/wso2/carbon/mediator/cache/CacheMediatorFactory.java","position":170,"original_position":170,"commit_id":"dbfb25b01c915319d034801709465ac8a6679140","original_commit_id":"dbfb25b01c915319d034801709465ac8a6679140","user":{"login":"Niranjan-K","id":5525926,"avatar_url":"https://avatars3.githubusercontent.com/u/5525926?v=4","gravatar_id":"","url":"https://api.github.com/users/Niranjan-K","html_url":"https://github.com/Niranjan-K","followers_url":"https://api.github.com/users/Niranjan-K/followers","following_url":"https://api.github.com/users/Niranjan-K/following{/other_user}","gists_url":"https://api.github.com/users/Niranjan-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Niranjan-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Niranjan-K/subscriptions","organizations_url":"https://api.github.com/users/Niranjan-K/orgs","repos_url":"https://api.github.com/users/Niranjan-K/repos","events_url":"https://api.github.com/users/Niranjan-K/events{/privacy}","received_events_url":"https://api.github.com/users/Niranjan-K/received_events","type":"User","site_admin":false},"body":"In if condition, it would be better to have the variable first and have the constant in the equals bracket.","created_at":"2017-11-14T04:10:36Z","updated_at":"2017-11-14T04:13:51Z","html_url":"https://github.com/wso2/carbon-mediation/pull/843#discussion_r150733493","pull_request_url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/comments/150733493"},"html":{"href":"https://github.com/wso2/carbon-mediation/pull/843#discussion_r150733493"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843","id":134802508,"html_url":"https://github.com/wso2/carbon-mediation/pull/843","diff_url":"https://github.com/wso2/carbon-mediation/pull/843.diff","patch_url":"https://github.com/wso2/carbon-mediation/pull/843.patch","issue_url":"https://api.github.com/repos/wso2/carbon-mediation/issues/843","number":843,"state":"closed","locked":false,"title":"Rewrite cache mediator","user":{"login":"riyafa","id":8238078,"avatar_url":"https://avatars2.githubusercontent.com/u/8238078?v=4","gravatar_id":"","url":"https://api.github.com/users/riyafa","html_url":"https://github.com/riyafa","followers_url":"https://api.github.com/users/riyafa/followers","following_url":"https://api.github.com/users/riyafa/following{/other_user}","gists_url":"https://api.github.com/users/riyafa/gists{/gist_id}","starred_url":"https://api.github.com/users/riyafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyafa/subscriptions","organizations_url":"https://api.github.com/users/riyafa/orgs","repos_url":"https://api.github.com/users/riyafa/repos","events_url":"https://api.github.com/users/riyafa/events{/privacy}","received_events_url":"https://api.github.com/users/riyafa/received_events","type":"User","site_admin":false},"body":"*Syntax changes: Support protocol specific parameters--currently only http is supported--and remove unsupported syntaxes\r\n*Hash generator changes: The hash generator can be protocol specific and if it's http only the Url and headers would be hashed for GET, HEAD and DELETE methods\r\n*UI changes: this is based on the syntax changes","created_at":"2017-08-09T03:25:20Z","updated_at":"2017-11-14T04:13:51Z","closed_at":"2017-08-23T06:45:21Z","merged_at":"2017-08-23T06:45:21Z","merge_commit_sha":"5ea3f1e691bff7fb21321a8f60aa448f875d619b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-mediation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-mediation/issues/843/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-mediation/statuses/dbfb25b01c915319d034801709465ac8a6679140","head":{"label":"riyafa:cache","ref":"cache","sha":"dbfb25b01c915319d034801709465ac8a6679140","user":{"login":"riyafa","id":8238078,"avatar_url":"https://avatars2.githubusercontent.com/u/8238078?v=4","gravatar_id":"","url":"https://api.github.com/users/riyafa","html_url":"https://github.com/riyafa","followers_url":"https://api.github.com/users/riyafa/followers","following_url":"https://api.github.com/users/riyafa/following{/other_user}","gists_url":"https://api.github.com/users/riyafa/gists{/gist_id}","starred_url":"https://api.github.com/users/riyafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyafa/subscriptions","organizations_url":"https://api.github.com/users/riyafa/orgs","repos_url":"https://api.github.com/users/riyafa/repos","events_url":"https://api.github.com/users/riyafa/events{/privacy}","received_events_url":"https://api.github.com/users/riyafa/received_events","type":"User","site_admin":false},"repo":{"id":95518140,"name":"carbon-mediation","full_name":"riyafa/carbon-mediation","owner":{"login":"riyafa","id":8238078,"avatar_url":"https://avatars2.githubusercontent.com/u/8238078?v=4","gravatar_id":"","url":"https://api.github.com/users/riyafa","html_url":"https://github.com/riyafa","followers_url":"https://api.github.com/users/riyafa/followers","following_url":"https://api.github.com/users/riyafa/following{/other_user}","gists_url":"https://api.github.com/users/riyafa/gists{/gist_id}","starred_url":"https://api.github.com/users/riyafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyafa/subscriptions","organizations_url":"https://api.github.com/users/riyafa/orgs","repos_url":"https://api.github.com/users/riyafa/repos","events_url":"https://api.github.com/users/riyafa/events{/privacy}","received_events_url":"https://api.github.com/users/riyafa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/riyafa/carbon-mediation","description":null,"fork":true,"url":"https://api.github.com/repos/riyafa/carbon-mediation","forks_url":"https://api.github.com/repos/riyafa/carbon-mediation/forks","keys_url":"https://api.github.com/repos/riyafa/carbon-mediation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riyafa/carbon-mediation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riyafa/carbon-mediation/teams","hooks_url":"https://api.github.com/repos/riyafa/carbon-mediation/hooks","issue_events_url":"https://api.github.com/repos/riyafa/carbon-mediation/issues/events{/number}","events_url":"https://api.github.com/repos/riyafa/carbon-mediation/events","assignees_url":"https://api.github.com/repos/riyafa/carbon-mediation/assignees{/user}","branches_url":"https://api.github.com/repos/riyafa/carbon-mediation/branches{/branch}","tags_url":"https://api.github.com/repos/riyafa/carbon-mediation/tags","blobs_url":"https://api.github.com/repos/riyafa/carbon-mediation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riyafa/carbon-mediation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riyafa/carbon-mediation/git/refs{/sha}","trees_url":"https://api.github.com/repos/riyafa/carbon-mediation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riyafa/carbon-mediation/statuses/{sha}","languages_url":"https://api.github.com/repos/riyafa/carbon-mediation/languages","stargazers_url":"https://api.github.com/repos/riyafa/carbon-mediation/stargazers","contributors_url":"https://api.github.com/repos/riyafa/carbon-mediation/contributors","subscribers_url":"https://api.github.com/repos/riyafa/carbon-mediation/subscribers","subscription_url":"https://api.github.com/repos/riyafa/carbon-mediation/subscription","commits_url":"https://api.github.com/repos/riyafa/carbon-mediation/commits{/sha}","git_commits_url":"https://api.github.com/repos/riyafa/carbon-mediation/git/commits{/sha}","comments_url":"https://api.github.com/repos/riyafa/carbon-mediation/comments{/number}","issue_comment_url":"https://api.github.com/repos/riyafa/carbon-mediation/issues/comments{/number}","contents_url":"https://api.github.com/repos/riyafa/carbon-mediation/contents/{+path}","compare_url":"https://api.github.com/repos/riyafa/carbon-mediation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riyafa/carbon-mediation/merges","archive_url":"https://api.github.com/repos/riyafa/carbon-mediation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riyafa/carbon-mediation/downloads","issues_url":"https://api.github.com/repos/riyafa/carbon-mediation/issues{/number}","pulls_url":"https://api.github.com/repos/riyafa/carbon-mediation/pulls{/number}","milestones_url":"https://api.github.com/repos/riyafa/carbon-mediation/milestones{/number}","notifications_url":"https://api.github.com/repos/riyafa/carbon-mediation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riyafa/carbon-mediation/labels{/name}","releases_url":"https://api.github.com/repos/riyafa/carbon-mediation/releases{/id}","deployments_url":"https://api.github.com/repos/riyafa/carbon-mediation/deployments","created_at":"2017-06-27T04:40:21Z","updated_at":"2017-06-27T04:40:29Z","pushed_at":"2017-11-09T04:45:35Z","git_url":"git://github.com/riyafa/carbon-mediation.git","ssh_url":"git@github.com:riyafa/carbon-mediation.git","clone_url":"https://github.com/riyafa/carbon-mediation.git","svn_url":"https://github.com/riyafa/carbon-mediation","homepage":null,"size":24547,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:master","ref":"master","sha":"f69cafbe1ceb4aa81199992931ccb18d734d14b9","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":16429916,"name":"carbon-mediation","full_name":"wso2/carbon-mediation","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-mediation","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-mediation","forks_url":"https://api.github.com/repos/wso2/carbon-mediation/forks","keys_url":"https://api.github.com/repos/wso2/carbon-mediation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-mediation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-mediation/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-mediation/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-mediation/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-mediation/events","assignees_url":"https://api.github.com/repos/wso2/carbon-mediation/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-mediation/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-mediation/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-mediation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-mediation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-mediation/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-mediation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-mediation/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-mediation/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-mediation/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-mediation/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-mediation/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-mediation/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-mediation/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-mediation/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-mediation/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-mediation/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-mediation/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-mediation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-mediation/merges","archive_url":"https://api.github.com/repos/wso2/carbon-mediation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-mediation/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-mediation/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-mediation/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-mediation/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-mediation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-mediation/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-mediation/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-mediation/deployments","created_at":"2014-02-01T07:01:29Z","updated_at":"2017-11-10T02:20:34Z","pushed_at":"2017-11-13T13:14:16Z","git_url":"git://github.com/wso2/carbon-mediation.git","ssh_url":"git@github.com:wso2/carbon-mediation.git","clone_url":"https://github.com/wso2/carbon-mediation.git","svn_url":"https://github.com/wso2/carbon-mediation","homepage":null,"size":25183,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":45,"forks":198,"open_issues":45,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843"},"html":{"href":"https://github.com/wso2/carbon-mediation/pull/843"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-mediation/issues/843"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-mediation/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-mediation/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-mediation/statuses/dbfb25b01c915319d034801709465ac8a6679140"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 16429916,
"name": "wso2/carbon-mediation",
"url": "https://api.github.com/repos/wso2/carbon-mediation"
}
|
{
"id": 5525926,
"login": "Niranjan-K",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5525926?",
"url": "https://api.github.com/users/Niranjan-K"
}
|
{
"id": 533043,
"login": "wso2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/533043?",
"url": "https://api.github.com/orgs/wso2"
}
| 2017-11-14T04:10:36 |
6850586331
|
{"actor":{"display_login":"Niranjan-K"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/comments/126666017","pull_request_review_id":49170484,"id":126666017,"diff_hunk":"@@ -0,0 +1,50 @@\n+FROM ubuntu:latest\n+MAINTAINER Harshit Prasad\n+\n+# Update\n+RUN apt-get update\n+RUN apt-get upgrade -y\n+\n+# add packages\n+RUN apt-get install -y git openjdk-8-jdk\n+\n+#install gradle required for build\n+RUN add-apt-repository ppa:cwchien/gradle\n+RUN apt-get update\n+RUN apt-get install gradle\n+\n+# install apache ftp server 1.1.0\n+RUN wget http://www-eu.apache.org/dist/mina/ftpserver/1.1.0/dist/apache-ftpserver-1.1.0.tar.gz\n+RUN tar xfz apache-ftpserver-1.1.0.tar.gz\n+","path":"Dockerfile","position":19,"original_position":19,"commit_id":"7230d47d09b55a93adee9670c9c8fd3aaae04a1e","original_commit_id":"7230d47d09b55a93adee9670c9c8fd3aaae04a1e","user":{"login":"nikhilrayaprolu","id":15216503,"avatar_url":"https://avatars0.githubusercontent.com/u/15216503?v=3","gravatar_id":"","url":"https://api.github.com/users/nikhilrayaprolu","html_url":"https://github.com/nikhilrayaprolu","followers_url":"https://api.github.com/users/nikhilrayaprolu/followers","following_url":"https://api.github.com/users/nikhilrayaprolu/following{/other_user}","gists_url":"https://api.github.com/users/nikhilrayaprolu/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhilrayaprolu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhilrayaprolu/subscriptions","organizations_url":"https://api.github.com/users/nikhilrayaprolu/orgs","repos_url":"https://api.github.com/users/nikhilrayaprolu/repos","events_url":"https://api.github.com/users/nikhilrayaprolu/events{/privacy}","received_events_url":"https://api.github.com/users/nikhilrayaprolu/received_events","type":"User","site_admin":false},"body":"configure apache ftp server\r\n**Things to do:**\r\n\r\n1.add these lines to apache-ftpserver-1.1.0/res/conf/users.properties\r\n```\r\nftpserver.user.yacygrid.userpassword=fcd6f2c8d772db634cd9fd960f4668a0\r\nftpserver.user.yacygrid.homedirectory=./res/home\r\nftpserver.user.yacygrid.enableflag=true\r\nftpserver.user.yacygrid.writepermission=true\r\nftpserver.user.yacygrid.maxloginnumber=2000\r\nftpserver.user.yacygrid.maxloginperip=2000\r\nftpserver.user.yacygrid.idletime=300\r\nftpserver.user.yacygrid.uploadrate=0\r\nftpserver.user.yacygrid.downloadrate=0\r\n```\r\n\r\nyou can refer https://unix.stackexchange.com/questions/77277/how-to-append-multiple-lines-to-a-file for how to add multiple lines into a file.\r\nbut I prefer write these configurations into a configfile and then\r\ndo,\r\n\r\n`cat ftpconfigfile >> apache-ftpserver-1.1.0/res/conf/users.properties`","created_at":"2017-07-11T11:52:33Z","updated_at":"2017-07-11T12:02:50Z","html_url":"https://github.com/yacy/yacy_grid_mcp/pull/12#discussion_r126666017","pull_request_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/comments/126666017"},"html":{"href":"https://github.com/yacy/yacy_grid_mcp/pull/12#discussion_r126666017"},"pull_request":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12","id":129885470,"html_url":"https://github.com/yacy/yacy_grid_mcp/pull/12","diff_url":"https://github.com/yacy/yacy_grid_mcp/pull/12.diff","patch_url":"https://github.com/yacy/yacy_grid_mcp/pull/12.patch","issue_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/12","number":12,"state":"open","locked":false,"title":"[WIP] Fixes #10: Add Dockerfile for Yacy","user":{"login":"harshit98","id":22245418,"avatar_url":"https://avatars3.githubusercontent.com/u/22245418?v=3","gravatar_id":"","url":"https://api.github.com/users/harshit98","html_url":"https://github.com/harshit98","followers_url":"https://api.github.com/users/harshit98/followers","following_url":"https://api.github.com/users/harshit98/following{/other_user}","gists_url":"https://api.github.com/users/harshit98/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit98/subscriptions","organizations_url":"https://api.github.com/users/harshit98/orgs","repos_url":"https://api.github.com/users/harshit98/repos","events_url":"https://api.github.com/users/harshit98/events{/privacy}","received_events_url":"https://api.github.com/users/harshit98/received_events","type":"User","site_admin":false},"body":"Fixes #10 \r\n\r\nIn this PR: \r\n- Created a Dockerfile for running MCP service.\r\n- Created a `docker-compose.yml` to link services: apache ftp, elasticsearch and rabbitmq containers.\r\n- Configurations for apache ftp and rabbitmq are still pending to be written.\r\n\r\nKindly review @nikhilrayaprolu @Marauderer97 @Orbiter ","created_at":"2017-07-11T11:34:33Z","updated_at":"2017-07-11T12:02:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96f9d78952d5378f51187348a4be7682c43806ab","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12/commits","review_comments_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12/comments","review_comment_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/12/comments","statuses_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/statuses/7230d47d09b55a93adee9670c9c8fd3aaae04a1e","head":{"label":"harshit98:docker","ref":"docker","sha":"7230d47d09b55a93adee9670c9c8fd3aaae04a1e","user":{"login":"harshit98","id":22245418,"avatar_url":"https://avatars3.githubusercontent.com/u/22245418?v=3","gravatar_id":"","url":"https://api.github.com/users/harshit98","html_url":"https://github.com/harshit98","followers_url":"https://api.github.com/users/harshit98/followers","following_url":"https://api.github.com/users/harshit98/following{/other_user}","gists_url":"https://api.github.com/users/harshit98/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit98/subscriptions","organizations_url":"https://api.github.com/users/harshit98/orgs","repos_url":"https://api.github.com/users/harshit98/repos","events_url":"https://api.github.com/users/harshit98/events{/privacy}","received_events_url":"https://api.github.com/users/harshit98/received_events","type":"User","site_admin":false},"repo":{"id":96583646,"name":"yacy_grid_mcp","full_name":"harshit98/yacy_grid_mcp","owner":{"login":"harshit98","id":22245418,"avatar_url":"https://avatars3.githubusercontent.com/u/22245418?v=3","gravatar_id":"","url":"https://api.github.com/users/harshit98","html_url":"https://github.com/harshit98","followers_url":"https://api.github.com/users/harshit98/followers","following_url":"https://api.github.com/users/harshit98/following{/other_user}","gists_url":"https://api.github.com/users/harshit98/gists{/gist_id}","starred_url":"https://api.github.com/users/harshit98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshit98/subscriptions","organizations_url":"https://api.github.com/users/harshit98/orgs","repos_url":"https://api.github.com/users/harshit98/repos","events_url":"https://api.github.com/users/harshit98/events{/privacy}","received_events_url":"https://api.github.com/users/harshit98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshit98/yacy_grid_mcp","description":"The YaCy Grid Master Connect Program","fork":true,"url":"https://api.github.com/repos/harshit98/yacy_grid_mcp","forks_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/forks","keys_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/teams","hooks_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/hooks","issue_events_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/issues/events{/number}","events_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/events","assignees_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/assignees{/user}","branches_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/branches{/branch}","tags_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/tags","blobs_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/statuses/{sha}","languages_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/languages","stargazers_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/stargazers","contributors_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/contributors","subscribers_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/subscribers","subscription_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/subscription","commits_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/contents/{+path}","compare_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/merges","archive_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/downloads","issues_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/issues{/number}","pulls_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/pulls{/number}","milestones_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/milestones{/number}","notifications_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/labels{/name}","releases_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/releases{/id}","deployments_url":"https://api.github.com/repos/harshit98/yacy_grid_mcp/deployments","created_at":"2017-07-07T23:32:28Z","updated_at":"2017-07-07T23:32:29Z","pushed_at":"2017-07-11T11:30:04Z","git_url":"git://github.com/harshit98/yacy_grid_mcp.git","ssh_url":"git@github.com:harshit98/yacy_grid_mcp.git","clone_url":"https://github.com/harshit98/yacy_grid_mcp.git","svn_url":"https://github.com/harshit98/yacy_grid_mcp","homepage":null,"size":352,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yacy:master","ref":"master","sha":"4b93b6ababe37019cdfa6ac7dee4644df899a318","user":{"login":"yacy","id":238733,"avatar_url":"https://avatars1.githubusercontent.com/u/238733?v=3","gravatar_id":"","url":"https://api.github.com/users/yacy","html_url":"https://github.com/yacy","followers_url":"https://api.github.com/users/yacy/followers","following_url":"https://api.github.com/users/yacy/following{/other_user}","gists_url":"https://api.github.com/users/yacy/gists{/gist_id}","starred_url":"https://api.github.com/users/yacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacy/subscriptions","organizations_url":"https://api.github.com/users/yacy/orgs","repos_url":"https://api.github.com/users/yacy/repos","events_url":"https://api.github.com/users/yacy/events{/privacy}","received_events_url":"https://api.github.com/users/yacy/received_events","type":"Organization","site_admin":false},"repo":{"id":80466405,"name":"yacy_grid_mcp","full_name":"yacy/yacy_grid_mcp","owner":{"login":"yacy","id":238733,"avatar_url":"https://avatars1.githubusercontent.com/u/238733?v=3","gravatar_id":"","url":"https://api.github.com/users/yacy","html_url":"https://github.com/yacy","followers_url":"https://api.github.com/users/yacy/followers","following_url":"https://api.github.com/users/yacy/following{/other_user}","gists_url":"https://api.github.com/users/yacy/gists{/gist_id}","starred_url":"https://api.github.com/users/yacy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yacy/subscriptions","organizations_url":"https://api.github.com/users/yacy/orgs","repos_url":"https://api.github.com/users/yacy/repos","events_url":"https://api.github.com/users/yacy/events{/privacy}","received_events_url":"https://api.github.com/users/yacy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yacy/yacy_grid_mcp","description":"The YaCy Grid Master Connect Program","fork":false,"url":"https://api.github.com/repos/yacy/yacy_grid_mcp","forks_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/forks","keys_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/teams","hooks_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/hooks","issue_events_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/events{/number}","events_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/events","assignees_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/assignees{/user}","branches_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/branches{/branch}","tags_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/tags","blobs_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/git/refs{/sha}","trees_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/statuses/{sha}","languages_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/languages","stargazers_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/stargazers","contributors_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/contributors","subscribers_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/subscribers","subscription_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/subscription","commits_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/commits{/sha}","git_commits_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/git/commits{/sha}","comments_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/comments{/number}","issue_comment_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/comments{/number}","contents_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/contents/{+path}","compare_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/merges","archive_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/downloads","issues_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues{/number}","pulls_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls{/number}","milestones_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/milestones{/number}","notifications_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/labels{/name}","releases_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/releases{/id}","deployments_url":"https://api.github.com/repos/yacy/yacy_grid_mcp/deployments","created_at":"2017-01-30T21:39:48Z","updated_at":"2017-07-11T11:36:29Z","pushed_at":"2017-07-11T11:34:33Z","git_url":"git://github.com/yacy/yacy_grid_mcp.git","ssh_url":"git@github.com:yacy/yacy_grid_mcp.git","clone_url":"https://github.com/yacy/yacy_grid_mcp.git","svn_url":"https://github.com/yacy/yacy_grid_mcp","homepage":null,"size":349,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":11,"forks":8,"open_issues":11,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12"},"html":{"href":"https://github.com/yacy/yacy_grid_mcp/pull/12"},"issue":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/12"},"comments":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/yacy/yacy_grid_mcp/statuses/7230d47d09b55a93adee9670c9c8fd3aaae04a1e"}}}}
|
{
"id": 80466405,
"name": "yacy/yacy_grid_mcp",
"url": "https://api.github.com/repos/yacy/yacy_grid_mcp"
}
|
{
"id": 15216503,
"login": "nikhilrayaprolu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15216503?",
"url": "https://api.github.com/users/nikhilrayaprolu"
}
|
{
"id": 238733,
"login": "yacy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/238733?",
"url": "https://api.github.com/orgs/yacy"
}
| 2017-07-11T11:52:33 |
6231956315
|
{"actor":{"display_login":"nikhilrayaprolu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/111589969","pull_request_review_id":32847389,"id":111589969,"diff_hunk":"@@ -698,7 +701,6 @@ def build_vmss_resource(name, naming_prefix, location, tags, overprovision, upgr\n # Build VMSS\n vmss_properties = {\n 'overprovision': overprovision,\n- 'singlePlacementGroup': single_placement_group,","path":"src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_template_builder.py","position":23,"original_position":24,"commit_id":"84b6cbe7e1f524852c133c81e1266660a4bbbb86","original_commit_id":"45a688a7c76b2d31d58a57ec16ec24d5ca002a55","user":{"login":"tjprescott","id":5723682,"avatar_url":"https://avatars1.githubusercontent.com/u/5723682?v=3","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"I thought this PR was not intended to make VM/VMSS create \"profile compliant\"? ","created_at":"2017-04-14T15:33:23Z","updated_at":"2017-04-14T15:33:23Z","html_url":"https://github.com/Azure/azure-cli/pull/2834#discussion_r111589969","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/2834","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/111589969"},"html":{"href":"https://github.com/Azure/azure-cli/pull/2834#discussion_r111589969"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/2834"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/2834","id":115426334,"html_url":"https://github.com/Azure/azure-cli/pull/2834","diff_url":"https://github.com/Azure/azure-cli/pull/2834.diff","patch_url":"https://github.com/Azure/azure-cli/pull/2834.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/2834","number":2834,"state":"open","locked":false,"title":"API Profile Support","user":{"login":"derekbekoe","id":16448634,"avatar_url":"https://avatars0.githubusercontent.com/u/16448634?v=3","gravatar_id":"","url":"https://api.github.com/users/derekbekoe","html_url":"https://github.com/derekbekoe","followers_url":"https://api.github.com/users/derekbekoe/followers","following_url":"https://api.github.com/users/derekbekoe/following{/other_user}","gists_url":"https://api.github.com/users/derekbekoe/gists{/gist_id}","starred_url":"https://api.github.com/users/derekbekoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekbekoe/subscriptions","organizations_url":"https://api.github.com/users/derekbekoe/orgs","repos_url":"https://api.github.com/users/derekbekoe/repos","events_url":"https://api.github.com/users/derekbekoe/events{/privacy}","received_events_url":"https://api.github.com/users/derekbekoe/received_events","type":"User","site_admin":false},"body":"- Use published SDKs available on PyPI now\r\n- Loading versioned models for network and resources, object model initialization changes for 2015-* profile (#2812)\r\n- Custom ca certs - Setting Requests_ca_bundle environment variable (#2813)\r\n- changes for 2015-* profile to work against azure stack (#2794)\r\n- Loading versioned Resources client and versioned models in VM\r\n- Updating the supported api-versions for the 2015-example profile\r\n- Fixing network, compute sdk load errors for 2015-* profiles (+5 squashed commit)\r\n- Support multi-API versioned Storage dataplane SDK (#2796)\r\n- Support multi-versioned mgmt SDK (#2526)\r\n- Fix token \"management\" endpoint is being used in the place of \"activeDirectoryResourceId\" (#2410)\r\n- Add profile switching params and profile listing command (#2398)\r\n- Use ARM 'resource manager' endpoint if ASM 'management' endpoint not set\r\n\r\nCloses https://github.com/Azure/azure-cli/issues/2578\r\nCloses https://github.com/Azure/azure-cli/issues/2579\r\nCloses https://github.com/Azure/azure-cli/issues/2577\r\n\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n### General Guidelines\r\n\r\n- [X] The PR has modified HISTORY.rst with an appropriate description of the change (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n### Command Guidelines\r\n\r\n- [X] Each command and parameter has a meaningful description.\r\n- [X] Each new command has a test.\r\n\r\n(see [Authoring Command Modules](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules))\r\n","created_at":"2017-04-11T22:12:28Z","updated_at":"2017-04-14T15:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"982f2ed47de8ff366139ffcf4653c629de057b4b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/2834/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/2834/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/2834/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/84b6cbe7e1f524852c133c81e1266660a4bbbb86","head":{"label":"Azure:api-profile-support","ref":"api-profile-support","sha":"84b6cbe7e1f524852c133c81e1266660a4bbbb86","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2017-04-14T14:32:07Z","pushed_at":"2017-04-14T02:01:46Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":17379,"stargazers_count":354,"watchers_count":354,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":361,"forks":145,"open_issues":361,"watchers":354,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"5c53a3b60fc57451237270956afc890c75e32210","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2017-04-14T14:32:07Z","pushed_at":"2017-04-14T02:01:46Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":17379,"stargazers_count":354,"watchers_count":354,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":361,"forks":145,"open_issues":361,"watchers":354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/2834"},"html":{"href":"https://github.com/Azure/azure-cli/pull/2834"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/2834"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/2834/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/2834/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/2834/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/84b6cbe7e1f524852c133c81e1266660a4bbbb86"}}}}
|
{
"id": 51040886,
"name": "Azure/azure-cli",
"url": "https://api.github.com/repos/Azure/azure-cli"
}
|
{
"id": 5723682,
"login": "tjprescott",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5723682?",
"url": "https://api.github.com/users/tjprescott"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-04-14T15:33:23 |
5690931150
|
{"actor":{"display_login":"tjprescott"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/123400755","pull_request_review_id":45599950,"id":123400755,"diff_hunk":"@@ -153,6 +153,14 @@ def sf_select(endpoint, cert=None,\n set_global_config_value(\"servicefabric\", \"endpoint\", endpoint)\n \n \n+def validate_app_path(app_path):\n+ abspath = os.path.abspath(app_path)\n+ if os.path.isdir(abspath):\n+ return abspath\n+ else:\n+ raise CLIError(\"Invalid path to application directory: {0}\".format(abspath))","path":"src/command_modules/azure-cli-sf/azure/cli/command_modules/sf/custom.py","position":9,"original_position":9,"commit_id":"4fce40ff3dd13b93f11d9b3fbfe5c629a8264c98","original_commit_id":"4fce40ff3dd13b93f11d9b3fbfe5c629a8264c98","user":{"login":"troydai","id":1329240,"avatar_url":"https://avatars1.githubusercontent.com/u/1329240?v=3","gravatar_id":"","url":"https://api.github.com/users/troydai","html_url":"https://github.com/troydai","followers_url":"https://api.github.com/users/troydai/followers","following_url":"https://api.github.com/users/troydai/following{/other_user}","gists_url":"https://api.github.com/users/troydai/gists{/gist_id}","starred_url":"https://api.github.com/users/troydai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troydai/subscriptions","organizations_url":"https://api.github.com/users/troydai/orgs","repos_url":"https://api.github.com/users/troydai/repos","events_url":"https://api.github.com/users/troydai/events{/privacy}","received_events_url":"https://api.github.com/users/troydai/received_events","type":"User","site_admin":false},"body":"I would suggest a `ValueError` to be throw instead. The error here is not CLI specific but input parameter issue. ","created_at":"2017-06-22T01:02:23Z","updated_at":"2017-06-22T01:10:25Z","html_url":"https://github.com/Azure/azure-cli/pull/3796#discussion_r123400755","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/3796","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/123400755"},"html":{"href":"https://github.com/Azure/azure-cli/pull/3796#discussion_r123400755"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/3796"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/3796","id":126659009,"html_url":"https://github.com/Azure/azure-cli/pull/3796","diff_url":"https://github.com/Azure/azure-cli/pull/3796.diff","patch_url":"https://github.com/Azure/azure-cli/pull/3796.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/3796","number":3796,"state":"open","locked":false,"title":"Fix file truncation in Service Fabric commands","user":{"login":"samedder","id":26749906,"avatar_url":"https://avatars2.githubusercontent.com/u/26749906?v=3","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false},"body":"Fixes #3666 and adds automated testing to cover this case.\r\n","created_at":"2017-06-21T00:47:45Z","updated_at":"2017-06-22T01:10:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1f9a9312d1b7b226a50acffbc9c87f3d7a63bc2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/3796/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/3796/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/3796/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/4fce40ff3dd13b93f11d9b3fbfe5c629a8264c98","head":{"label":"samedder:fix_sf_large_file_upload","ref":"fix_sf_large_file_upload","sha":"4fce40ff3dd13b93f11d9b3fbfe5c629a8264c98","user":{"login":"samedder","id":26749906,"avatar_url":"https://avatars2.githubusercontent.com/u/26749906?v=3","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false},"repo":{"id":86640031,"name":"azure-cli","full_name":"samedder/azure-cli","owner":{"login":"samedder","id":26749906,"avatar_url":"https://avatars2.githubusercontent.com/u/26749906?v=3","gravatar_id":"","url":"https://api.github.com/users/samedder","html_url":"https://github.com/samedder","followers_url":"https://api.github.com/users/samedder/followers","following_url":"https://api.github.com/users/samedder/following{/other_user}","gists_url":"https://api.github.com/users/samedder/gists{/gist_id}","starred_url":"https://api.github.com/users/samedder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samedder/subscriptions","organizations_url":"https://api.github.com/users/samedder/orgs","repos_url":"https://api.github.com/users/samedder/repos","events_url":"https://api.github.com/users/samedder/events{/privacy}","received_events_url":"https://api.github.com/users/samedder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samedder/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/samedder/azure-cli","forks_url":"https://api.github.com/repos/samedder/azure-cli/forks","keys_url":"https://api.github.com/repos/samedder/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samedder/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samedder/azure-cli/teams","hooks_url":"https://api.github.com/repos/samedder/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/samedder/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/samedder/azure-cli/events","assignees_url":"https://api.github.com/repos/samedder/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/samedder/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/samedder/azure-cli/tags","blobs_url":"https://api.github.com/repos/samedder/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samedder/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samedder/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/samedder/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samedder/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/samedder/azure-cli/languages","stargazers_url":"https://api.github.com/repos/samedder/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/samedder/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/samedder/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/samedder/azure-cli/subscription","commits_url":"https://api.github.com/repos/samedder/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/samedder/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/samedder/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/samedder/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/samedder/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/samedder/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samedder/azure-cli/merges","archive_url":"https://api.github.com/repos/samedder/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samedder/azure-cli/downloads","issues_url":"https://api.github.com/repos/samedder/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/samedder/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/samedder/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/samedder/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samedder/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/samedder/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/samedder/azure-cli/deployments","created_at":"2017-03-29T23:58:38Z","updated_at":"2017-03-29T23:58:42Z","pushed_at":"2017-06-21T00:46:43Z","git_url":"git://github.com/samedder/azure-cli.git","ssh_url":"git@github.com:samedder/azure-cli.git","clone_url":"https://github.com/samedder/azure-cli.git","svn_url":"https://github.com/samedder/azure-cli","homepage":null,"size":22822,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"855f1233a4211c99cb7708833b5c85d5a47b36bf","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2017-06-21T19:49:42Z","pushed_at":"2017-06-22T01:07:36Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":22902,"stargazers_count":440,"watchers_count":440,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"open_issues_count":465,"forks":207,"open_issues":465,"watchers":440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/3796"},"html":{"href":"https://github.com/Azure/azure-cli/pull/3796"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/3796"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/3796/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/3796/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/3796/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/4fce40ff3dd13b93f11d9b3fbfe5c629a8264c98"}}}}
|
{
"id": 51040886,
"name": "Azure/azure-cli",
"url": "https://api.github.com/repos/Azure/azure-cli"
}
|
{
"id": 1329240,
"login": "troydai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1329240?",
"url": "https://api.github.com/users/troydai"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-06-22T01:02:23 |
6114430673
|
{"actor":{"display_login":"troydai"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/comments/139022540","pull_request_review_id":62900255,"id":139022540,"diff_hunk":"@@ -0,0 +1,546 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+#include <stdlib.h>\n+#include <stddef.h>\n+#include <stdint.h>\n+#include <ctype.h>\n+#include <stdio.h>\n+#include <string.h>\n+#include \"azure_c_shared_utility/gballoc.h\"\n+#include \"azure_c_shared_utility/tlsio_appleios.h\"\n+#include \"azure_c_shared_utility/socketio.h\"\n+#include \"azure_c_shared_utility/optimize_size.h\"\n+#include \"azure_c_shared_utility/xlogging.h\"\n+#include \"azure_c_shared_utility/platform.h\"\n+#include \"azure_c_shared_utility/threadapi.h\"\n+#include \"azure_c_shared_utility/optionhandler.h\"\n+\n+#include <CoreFoundation/CoreFoundation.h>\n+#include <CFNetwork/CFSocketStream.h>\n+\n+/* Codes_SRS_TLSIO_APPLEIOS_32_001: [ The tlsio_appleios shall implement and export all the Concrete functions in the VTable IO_INTERFACE_DESCRIPTION defined in the `xio.h`. ]*/\n+/* Codes_SRS_TLSIO_APPLEIOS_32_002: [ The tlsio_appleios shall report the open operation status using the IO_OPEN_RESULT enumerator defined in the `xio.h`.]*/\n+/* Codes_SRS_TLSIO_APPLEIOS_32_003: [ The tlsio_appleios shall report the send operation status using the IO_SEND_RESULT enumerator defined in the `xio.h`. ]*/\n+/* Codes_SRS_TLSIO_APPLEIOS_32_004: [ The tlsio_appleios shall call the callbacks functions defined in the `xio.h`. ]*/\n+#include \"azure_c_shared_utility/xio.h\"\n+\n+/* Codes_SRS_TLSIO_APPLEIOS_32_005: [ The tlsio_appleios shall received the connection information using the TLSIO_CONFIG structure defined in `tlsio.h`. ]*/\n+#include \"azure_c_shared_utility/tlsio.h\"\n+\n+\n+/* Codes_SRS_TLSIO_APPLEIOS_32_001: [ The tlsio_appleios shall implement and export all the Concrete functions in the VTable IO_INTERFACE_DESCRIPTION defined in the `xio.h`. ]*/\n+CONCRETE_IO_HANDLE tlsio_appleios_create(void* io_create_parameters);\n+void tlsio_appleios_destroy(CONCRETE_IO_HANDLE tls_io);\n+int tlsio_appleios_open(CONCRETE_IO_HANDLE tls_io, ON_IO_OPEN_COMPLETE on_io_open_complete, void* on_io_open_complete_context, ON_BYTES_RECEIVED on_bytes_received, void* on_bytes_received_context, ON_IO_ERROR on_io_error, void* on_io_error_context);\n+int tlsio_appleios_close(CONCRETE_IO_HANDLE tls_io, ON_IO_CLOSE_COMPLETE on_io_close_complete, void* callback_context);\n+int tlsio_appleios_send(CONCRETE_IO_HANDLE tls_io, const void* buffer, size_t size, ON_SEND_COMPLETE on_send_complete, void* callback_context);\n+void tlsio_appleios_dowork(CONCRETE_IO_HANDLE tls_io);\n+int tlsio_appleios_setoption(CONCRETE_IO_HANDLE tls_io, const char* optionName, const void* value);\n+OPTIONHANDLER_HANDLE tlsio_appleios_retrieveoptions(CONCRETE_IO_HANDLE tls_io);\n+\n+static const IO_INTERFACE_DESCRIPTION tlsio_handle_interface_description =\n+{\n+ tlsio_appleios_retrieveoptions,\n+ tlsio_appleios_create,\n+ tlsio_appleios_destroy,\n+ tlsio_appleios_open,\n+ tlsio_appleios_close,\n+ tlsio_appleios_send,\n+ tlsio_appleios_dowork,\n+ tlsio_appleios_setoption\n+};\n+\n+/* Codes_SRS_TLSIO_APPLEIOS_32_027: [ The tlsio_appleios_open shall set the tlsio to try to open the connection for 10 times before assuming that connection failed. ]*/\n+#define MAX_TLS_OPENING_RETRY 10","path":"adapters/tlsio_appleios.c","position":55,"original_position":55,"commit_id":"2ae7e6530202117b18d9e90d1eab3f85ecae7049","original_commit_id":"2ae7e6530202117b18d9e90d1eab3f85ecae7049","user":{"login":"dcristoloveanu","id":8507399,"avatar_url":"https://avatars3.githubusercontent.com/u/8507399?v=4","gravatar_id":"","url":"https://api.github.com/users/dcristoloveanu","html_url":"https://github.com/dcristoloveanu","followers_url":"https://api.github.com/users/dcristoloveanu/followers","following_url":"https://api.github.com/users/dcristoloveanu/following{/other_user}","gists_url":"https://api.github.com/users/dcristoloveanu/gists{/gist_id}","starred_url":"https://api.github.com/users/dcristoloveanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcristoloveanu/subscriptions","organizations_url":"https://api.github.com/users/dcristoloveanu/orgs","repos_url":"https://api.github.com/users/dcristoloveanu/repos","events_url":"https://api.github.com/users/dcristoloveanu/events{/privacy}","received_events_url":"https://api.github.com/users/dcristoloveanu/received_events","type":"User","site_admin":false},"body":">MAX_TLS_OPENING_RETRY [](start = 8, length = 21)\r\n\r\nWhy is a retry used at this layer?","created_at":"2017-09-14T22:04:07Z","updated_at":"2017-09-14T22:04:07Z","html_url":"https://github.com/Azure/azure-c-shared-utility/pull/109#discussion_r139022540","pull_request_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/comments/139022540"},"html":{"href":"https://github.com/Azure/azure-c-shared-utility/pull/109#discussion_r139022540"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109","id":141171223,"html_url":"https://github.com/Azure/azure-c-shared-utility/pull/109","diff_url":"https://github.com/Azure/azure-c-shared-utility/pull/109.diff","patch_url":"https://github.com/Azure/azure-c-shared-utility/pull/109.patch","issue_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/109","number":109,"state":"open","locked":false,"title":"Mriosbuild","user":{"login":"markrad","id":12402055,"avatar_url":"https://avatars2.githubusercontent.com/u/12402055?v=4","gravatar_id":"","url":"https://api.github.com/users/markrad","html_url":"https://github.com/markrad","followers_url":"https://api.github.com/users/markrad/followers","following_url":"https://api.github.com/users/markrad/following{/other_user}","gists_url":"https://api.github.com/users/markrad/gists{/gist_id}","starred_url":"https://api.github.com/users/markrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrad/subscriptions","organizations_url":"https://api.github.com/users/markrad/orgs","repos_url":"https://api.github.com/users/markrad/repos","events_url":"https://api.github.com/users/markrad/events{/privacy}","received_events_url":"https://api.github.com/users/markrad/received_events","type":"User","site_admin":false},"body":"Add iOS adapters for cross compiling and running SDK on iPhone. ","created_at":"2017-09-14T20:36:56Z","updated_at":"2017-09-14T22:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f31431e0c92e17852eaa72069e9e5269e5ee7d6b","assignee":{"login":"markrad","id":12402055,"avatar_url":"https://avatars2.githubusercontent.com/u/12402055?v=4","gravatar_id":"","url":"https://api.github.com/users/markrad","html_url":"https://github.com/markrad","followers_url":"https://api.github.com/users/markrad/followers","following_url":"https://api.github.com/users/markrad/following{/other_user}","gists_url":"https://api.github.com/users/markrad/gists{/gist_id}","starred_url":"https://api.github.com/users/markrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrad/subscriptions","organizations_url":"https://api.github.com/users/markrad/orgs","repos_url":"https://api.github.com/users/markrad/repos","events_url":"https://api.github.com/users/markrad/events{/privacy}","received_events_url":"https://api.github.com/users/markrad/received_events","type":"User","site_admin":false},"assignees":[{"login":"markrad","id":12402055,"avatar_url":"https://avatars2.githubusercontent.com/u/12402055?v=4","gravatar_id":"","url":"https://api.github.com/users/markrad","html_url":"https://github.com/markrad","followers_url":"https://api.github.com/users/markrad/followers","following_url":"https://api.github.com/users/markrad/following{/other_user}","gists_url":"https://api.github.com/users/markrad/gists{/gist_id}","starred_url":"https://api.github.com/users/markrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrad/subscriptions","organizations_url":"https://api.github.com/users/markrad/orgs","repos_url":"https://api.github.com/users/markrad/repos","events_url":"https://api.github.com/users/markrad/events{/privacy}","received_events_url":"https://api.github.com/users/markrad/received_events","type":"User","site_admin":false},{"login":"mamokarz","id":18200629,"avatar_url":"https://avatars3.githubusercontent.com/u/18200629?v=4","gravatar_id":"","url":"https://api.github.com/users/mamokarz","html_url":"https://github.com/mamokarz","followers_url":"https://api.github.com/users/mamokarz/followers","following_url":"https://api.github.com/users/mamokarz/following{/other_user}","gists_url":"https://api.github.com/users/mamokarz/gists{/gist_id}","starred_url":"https://api.github.com/users/mamokarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamokarz/subscriptions","organizations_url":"https://api.github.com/users/mamokarz/orgs","repos_url":"https://api.github.com/users/mamokarz/repos","events_url":"https://api.github.com/users/mamokarz/events{/privacy}","received_events_url":"https://api.github.com/users/mamokarz/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jebrando","id":8583083,"avatar_url":"https://avatars0.githubusercontent.com/u/8583083?v=4","gravatar_id":"","url":"https://api.github.com/users/jebrando","html_url":"https://github.com/jebrando","followers_url":"https://api.github.com/users/jebrando/followers","following_url":"https://api.github.com/users/jebrando/following{/other_user}","gists_url":"https://api.github.com/users/jebrando/gists{/gist_id}","starred_url":"https://api.github.com/users/jebrando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebrando/subscriptions","organizations_url":"https://api.github.com/users/jebrando/orgs","repos_url":"https://api.github.com/users/jebrando/repos","events_url":"https://api.github.com/users/jebrando/events{/privacy}","received_events_url":"https://api.github.com/users/jebrando/received_events","type":"User","site_admin":false},{"login":"ewertons","id":12401690,"avatar_url":"https://avatars0.githubusercontent.com/u/12401690?v=4","gravatar_id":"","url":"https://api.github.com/users/ewertons","html_url":"https://github.com/ewertons","followers_url":"https://api.github.com/users/ewertons/followers","following_url":"https://api.github.com/users/ewertons/following{/other_user}","gists_url":"https://api.github.com/users/ewertons/gists{/gist_id}","starred_url":"https://api.github.com/users/ewertons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewertons/subscriptions","organizations_url":"https://api.github.com/users/ewertons/orgs","repos_url":"https://api.github.com/users/ewertons/repos","events_url":"https://api.github.com/users/ewertons/events{/privacy}","received_events_url":"https://api.github.com/users/ewertons/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/109/comments","statuses_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/statuses/2ae7e6530202117b18d9e90d1eab3f85ecae7049","head":{"label":"Azure:mriosbuild","ref":"mriosbuild","sha":"2ae7e6530202117b18d9e90d1eab3f85ecae7049","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":44986892,"name":"azure-c-shared-utility","full_name":"Azure/azure-c-shared-utility","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-c-shared-utility","description":"Azure C SDKs common code","fork":false,"url":"https://api.github.com/repos/Azure/azure-c-shared-utility","forks_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/forks","keys_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/teams","hooks_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/events","assignees_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/tags","blobs_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/subscription","commits_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/merges","archive_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/downloads","issues_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/deployments","created_at":"2015-10-26T17:53:51Z","updated_at":"2017-08-18T13:07:54Z","pushed_at":"2017-09-14T21:40:28Z","git_url":"git://github.com/Azure/azure-c-shared-utility.git","ssh_url":"git@github.com:Azure/azure-c-shared-utility.git","clone_url":"https://github.com/Azure/azure-c-shared-utility.git","svn_url":"https://github.com/Azure/azure-c-shared-utility","homepage":"","size":8806,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":19,"forks":65,"open_issues":19,"watchers":19,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"2b0fda287f7b33ccfc6058dec5f35b501d6ca76a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":44986892,"name":"azure-c-shared-utility","full_name":"Azure/azure-c-shared-utility","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-c-shared-utility","description":"Azure C SDKs common code","fork":false,"url":"https://api.github.com/repos/Azure/azure-c-shared-utility","forks_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/forks","keys_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/teams","hooks_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/events","assignees_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/tags","blobs_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/subscription","commits_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/merges","archive_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/downloads","issues_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-c-shared-utility/deployments","created_at":"2015-10-26T17:53:51Z","updated_at":"2017-08-18T13:07:54Z","pushed_at":"2017-09-14T21:40:28Z","git_url":"git://github.com/Azure/azure-c-shared-utility.git","ssh_url":"git@github.com:Azure/azure-c-shared-utility.git","clone_url":"https://github.com/Azure/azure-c-shared-utility.git","svn_url":"https://github.com/Azure/azure-c-shared-utility","homepage":"","size":8806,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":19,"forks":65,"open_issues":19,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109"},"html":{"href":"https://github.com/Azure/azure-c-shared-utility/pull/109"},"issue":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/109"},"comments":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-c-shared-utility/statuses/2ae7e6530202117b18d9e90d1eab3f85ecae7049"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44986892,
"name": "Azure/azure-c-shared-utility",
"url": "https://api.github.com/repos/Azure/azure-c-shared-utility"
}
|
{
"id": 8507399,
"login": "dcristoloveanu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8507399?",
"url": "https://api.github.com/users/dcristoloveanu"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-09-14T22:04:07 |
6592965712
|
{"actor":{"display_login":"dcristoloveanu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/146400951","pull_request_review_id":71337919,"id":146400951,"diff_hunk":"@@ -0,0 +1,282 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+'use strict';\n+\n+import { EventEmitter } from 'events';\n+import { errors, X509, SharedAccessSignature } from 'azure-iot-common';\n+import * as machina from 'machina';\n+import * as Provisioning from './transport_interface';\n+import * as dbg from 'debug';\n+const debug = dbg('azure-device-provisioning:transport-fsm');\n+\n+export interface TransportHandlers {\n+ _doConnectForFsm(callback: (err?: Error) => void): void;\n+ _doDisconnectForFsm(callback: (err?: Error) => void): void;\n+ _doFirstRegistrationRequestForFsm(registrationId: string, authorization: SharedAccessSignature | X509 | string, requestBody: any, forceRegistration: boolean, callback: (err?: Error, responseBody?: any, result?: any, pollingInterval?: number) => void): void;\n+ _doOperationStatusQueryForFsm(registrationId: string, operationId: string, callback: (err?: Error, responseBody?: any, result?: any, pollingInterval?: number) => void): void;\n+ _getErrorFromResultForFsm(result: any): any;\n+}\n+\n+export class TransportStateMachine extends EventEmitter implements Provisioning.Transport, TransportHandlers{\n+ protected _apiVersion: string = '2017-08-31-preview';\n+ private _fsm: machina.Fsm;\n+ private _pollingTimer: any;\n+ private _registrationCallback: Provisioning.ResponseCallback;\n+\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_001: [ The `constructor` shall accept no arguments ] */\n+ constructor() {\n+ super();\n+\n+ this._fsm = new machina.Fsm({\n+ namespace: 'Provisioning',\n+ initialState: 'disconnected',\n+ states: {\n+ disconnected: {\n+ _onEnter: (callback, err) => {\n+ debug('entering disconnected state');\n+ this._pollingTimer = null;\n+ this._registrationCallback = null;\n+ if (callback) {\n+ callback(err);\n+ }\n+ },\n+ connect: (callback) => {\n+ this._fsm.transition('connecting', callback);\n+ },\n+ register: (callback, registrationId, authorization, requestBody, forceRegistration) => {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_010: [ `register` shall `connect` the transport if it is not connected. ] */\n+ this._fsm.handle('connect', (err) => {\n+ if (err) {\n+ this._fsm.transition('disconnecting', callback, err);\n+ } else {\n+ this._fsm.transition('sendingRegistrationReqest', callback, registrationId, authorization, requestBody, forceRegistration);\n+ }\n+ });\n+ },\n+ disconnect: (callback) => {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_025: [ If `disconnect` is called while disconnected, it shall immediately call its `callback`. ] */\n+ // nothing to do.\n+ callback();\n+ }\n+ },\n+ connecting: {\n+ _onEnter: (callback) => {\n+ debug('entering connecting state');\n+ debug('calling transport _doConnectForFsm');\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_002: [ `connect` shall call `_doConnectForFsm`. ] */\n+ this._doConnectForFsm((err) => {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_003: [ If `_doConnectForFsm` fails, then `connect` shall fail. ] */\n+ if (err) {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_011: [ `register` shall fail if the connection fails. ] */\n+ this._fsm.transition('disconnecting', callback, err);\n+ } else {\n+ this._fsm.transition('connected', callback);\n+ }\n+ });\n+ },\n+ '*': () => this._fsm.deferUntilTransition()\n+ },\n+ connected: {\n+ _onEnter: (callback, err, body, result) => {\n+ debug('entering connected state');\n+ callback(err, body, result);\n+ },\n+ connect: (callback) => {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_004: [ If the transport is already connected, then `connect` shall do nothing and call the `callback` immediately. ] */\n+ // nothing to do.\n+ callback();\n+ },\n+ disconnect: (callback) => {\n+ this._fsm.transition('disconnecting', callback);\n+ },\n+ register: (callback, registrationId, authorization, requestBody, forceRegistration) => {\n+ this._fsm.transition('sendingRegistrationRequest', callback, registrationId, authorization, requestBody, forceRegistration);\n+ },\n+ },\n+ sendingRegistrationReqest: {\n+ _onEnter: (callback, registrationId, authorization, requestBody, forceRegistration) => {\n+ debug('entering sendingRegistrationRequest state');\n+ this._registrationCallback = callback;\n+ debug('calling transport _doFirstRegistrationRequestForFsm');\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_012: [ `register` shall call `_doFirstRegistrationRequestForFsm`. ] */\n+ this._doFirstRegistrationRequestForFsm(registrationId, authorization, requestBody, forceRegistration, (err, responseBody, result, pollingInterval) => {\n+ if (this._registrationInProgress()) { // make sure we weren't cancelled before doing something with the response\n+ if (err) {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_013: [ If the registration request fails, `register` shall fail. ] */\n+ this._fsm.transition('connected', callback, err);\n+ } else {\n+ this._handleOperationStatusResponse(registrationId, responseBody, result, pollingInterval, callback);\n+ }\n+ }\n+ });\n+ },\n+ disconnect: (callback) => this._fsm.transition('disconnecting', callback),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_006: [ If `connect` is called while the transport is executing the first registration request, it shall do nothing and call `callback` immediately. ] */\n+ connect: (callback) => callback(),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_024: [ If `register` is called while a different request is in progress, it shall fail with an `InvalidOperationError`. ] */\n+ register: (callback) => callback(new errors.InvalidOperationError('another operation is in progress'))\n+ },\n+ waiting_to_poll: {\n+ _onEnter: (callback, registrationId, operationId, pollingInterval) => {\n+ debug('entering waitingToPoll state');\n+ debug('waiting for ' + pollingInterval + ' ms');\n+ this._pollingTimer = setTimeout(() => {\n+ this._fsm.transition('polling', callback, registrationId, operationId, pollingInterval);\n+ }, pollingInterval);\n+ },\n+ disconnect: (callback, err, responseBody) => this._fsm.transition('disconnecting', callback, err, responseBody),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_007: [ If `connect` is called while the transport is waiting between operation status queries, it shall do nothing and call `callback` immediately. ] */\n+ connect: (callback) => callback(),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_024: [ If `register` is called while a different request is in progress, it shall fail with an `InvalidOperationError`. ] */\n+ register: (callback) => callback(new errors.InvalidOperationError('another operation is in progress'))\n+ },\n+ polling: {\n+ _onEnter: (callback, registrationId, operationId, pollingInterval) => {\n+ debug('entering polling state');\n+ debug('calling transport _doOperationStatusQueryForFsm');\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_018: [ When the polling interval elapses, `register` shall call `_doOperationStatusQueryForFsm`. ] */\n+ this._doOperationStatusQueryForFsm(registrationId, operationId, (err, result, body, pollingInterval) => {\n+ if (this._registrationInProgress()) { // make sure we weren't cancelled before doing something with the response\n+ if (err) {\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_019: [ If `_doOperationStatusQueryForFsm` fails, `register` shall fail. ] */\n+ this._fsm.transition('connected', callback, err);\n+ } else {\n+ this._handleOperationStatusResponse(registrationId, result, body, pollingInterval, callback);\n+ }\n+ }\n+ });\n+ },\n+ disconnect: (callback) => this._fsm.transition('disconnecting', callback),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_008: [ If `connect` is called while the transport is executing an operation status query, it shall do nothing and call `callback` immediately. ] */\n+ connect: (callback) => callback(),\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_024: [ If `register` is called while a different request is in progress, it shall fail with an `InvalidOperationError`. ] */\n+ register: (callback) => callback(new errors.InvalidOperationError('another operation is in progress'))\n+ },\n+ disconnecting: {\n+ _onEnter: (callback, err) => {\n+ debug('entering disconnecting state');\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_027: [ If a registration is in progress, `disconnect` shall cause that registration to fail with an `OperationCancelledError`. ] */\n+ this._cancelCurrentOperation((cancelErr) => {\n+ // log any errors, which are extremely unlikely, but continue disconnecting.\n+ if (cancelErr) {\n+ debug('error received from transport during disconnection (1):' + cancelErr.toString());\n+ }\n+ debug('calling transport _doDisconnectForFsm');\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_026: [ `disconnect` shall call `_doDisconnectForFsm` of it's called while the transport is connected. ] */\n+ this._doDisconnectForFsm((disconnectErr) => {\n+ if (disconnectErr) {\n+ debug('error received from transport during disconnection (2):' + cancelErr.toString());\n+ }\n+ this._fsm.transition('disconnected', callback, err);\n+ });\n+ });\n+ },\n+ /* Codes_SRS_NODE_PROVISIONING_TRANSPORT_STATE_MACHINE_18_009: [ If `connect` is called while the transport is disconnecting, it shall wait for the disconnection to complete, then initiate the connection. ] */\n+ '*': () => this._fsm.deferUntilTransition()\n+ }\n+ }\n+ });\n+ }\n+\n+ /* istanbul ignore next */\n+ _doConnectForFsm(callback: (err?: Error) => void): void {\n+ throw new errors.NotImplementedError('_doConnectForFsm not implemented in this transport');\n+ }\n+\n+ /* istanbul ignore next */\n+ _doDisconnectForFsm(callback: (err?: Error) => void): void {\n+ throw new errors.NotImplementedError('_doDisconnectForFsm not implemented in this transport');\n+ }\n+\n+ /* istanbul ignore next */\n+ _doFirstRegistrationRequestForFsm(registrationId: string, authorization: SharedAccessSignature | X509 | string, requestBody: any, forceRegistration: boolean, callback: (err?: Error, responseBody?: any, result?: any, pollingInterval?: number) => void): void {\n+ throw new errors.NotImplementedError('_doFirstRegistrationRequestForFsm not implemented in this transport');\n+ }\n+\n+ /* istanbul ignore next */\n+ _doOperationStatusQueryForFsm(registrationId: string, operationId: string, callback: (err?: Error, responseBody?: any, result?: any, pollingInterval?: number) => void): void {\n+ throw new errors.NotImplementedError('_doOperationStatusQueryForFsm not implemented in this transport');\n+ }\n+\n+ /* istanbul ignore next */\n+ _getErrorFromResultForFsm(result: any): any {\n+ throw new errors.NotImplementedError('_getErrorFromResultForFsm not implemented in this transport');\n+ }\n+\n+\n+ connect(callback: (err?: Error) => void): void {\n+ debug('connect called');\n+ this._fsm.handle('connect', callback);\n+ }\n+\n+ register(registrationId: string, authorization: string | X509, requestBody: any, forceRegistration: boolean, callback: Provisioning.ResponseCallback): void {\n+ debug('register called for registrationId \"' + registrationId + '\"');\n+ this._fsm.handle('register', callback, registrationId, authorization, requestBody, forceRegistration);\n+ }\n+\n+ disconnect(callback: (err: Error) => void): void {\n+ debug('disconnect called');\n+ this._fsm.handle('disconnect', callback);\n+ }\n+\n+ private _cancelCurrentOperation(callback: (err?: Error) => void): void {\n+ if (this._pollingTimer != null) {\n+ debug('_cancelCurrentOperation: stopping polling timer');\n+ clearTimeout(this._pollingTimer);\n+ this._pollingTimer = null;\n+ }\n+\n+ if (this._registrationInProgress()) {\n+ debug('_cancelCurrentOperation: operation is in progress. Cancelling.');\n+ let _callback = this._registrationCallback;\n+ this._registrationCallback = null;\n+ _callback(new errors.OperationCancelledError());\n+ }\n+\n+ callback();\n+ }\n+ private _handleOperationStatusResponse(registrationId: string, responseBody: any, result: any, pollingInterval: number, callback: any): void {","path":"provisioning/device/src/transport_state_machine.ts","position":239,"original_position":239,"commit_id":"17dd1dbe9188d1783b6ea637b74a6676db6254e2","original_commit_id":"17dd1dbe9188d1783b6ea637b74a6676db6254e2","user":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":">private [](start = 2, length = 7)\r\n\r\nnit: missing newline","created_at":"2017-10-23T21:37:15Z","updated_at":"2017-10-23T21:37:15Z","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/115#discussion_r146400951","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/146400951"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/115#discussion_r146400951"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115","id":147904540,"html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/115","diff_url":"https://github.com/Azure/azure-iot-sdk-node/pull/115.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-node/pull/115.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/115","number":115,"state":"open","locked":false,"title":"transport agnostic state machine for DPS","user":{"login":"BertKleewein","id":8028738,"avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"body":"# Description of the problem]\r\n\r\nWhile working on the MQTT protocol, I discovered that MQTT, HTTP, and, I presume, AMQP have a ton in common, both in terms of how the protocols operate, but also in terms of the state machine I need to use. (For example, MQTT registration queries for operation status instead of using a C2D topic to send status updates. In other words, we have to poll with MQTT just like we poll with HTTP.)\r\n\r\nWhile writing the MQTT state machine, I discovered that I was copying a bunch of code from the HTTP state machine. Rather than copy/paste, I decided to refactor the state machine out of the transport implementation. TransportStateMachine is effectively an abstract base class for all the transports. It has the state machine and all the transport-specific operations are left to the derived object to implement.\r\n","created_at":"2017-10-20T22:03:40Z","updated_at":"2017-10-23T21:37:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d983271209584e55fe27c1c7d727a4be73dbc33","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/115/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/17dd1dbe9188d1783b6ea637b74a6676db6254e2","head":{"label":"Azure:bertk-mqtt","ref":"bertk-mqtt","sha":"17dd1dbe9188d1783b6ea637b74a6676db6254e2","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2017-10-21T15:20:03Z","pushed_at":"2017-10-23T20:42:27Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":42592,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":21,"forks":51,"open_issues":21,"watchers":61,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"ff0f3f2ef608e4be3909d1c4f81f788ebc351323","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2017-10-21T15:20:03Z","pushed_at":"2017-10-23T20:42:27Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":42592,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":21,"forks":51,"open_issues":21,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/115"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/115"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/17dd1dbe9188d1783b6ea637b74a6676db6254e2"}},"author_association":"MEMBER"}}
|
{
"id": 70935002,
"name": "Azure/azure-iot-sdk-node",
"url": "https://api.github.com/repos/Azure/azure-iot-sdk-node"
}
|
{
"id": 4979572,
"login": "pierreca",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4979572?",
"url": "https://api.github.com/users/pierreca"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-10-23T21:37:15 |
6754893522
|
{"actor":{"display_login":"pierreca"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/134127897","pull_request_review_id":57383514,"id":134127897,"diff_hunk":"@@ -0,0 +1,793 @@\n+{\r\n+ \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\r\n+ \"contentVersion\": \"1.0.0.0\",\r\n+ \"parameters\": {\r\n+\r\n+ },\r\n+ \"variables\": {\r\n+ \"adminUsername\": \"demouser\",\r\n+ \"adminPassword\": \"demoPassword1!\",\r\n+ \"virtualNetworkName\": \"es-vnet\",\r\n+ \"OS\": \"ubuntu\",\r\n+ \"authenticationType\": \"password\",\r\n+ \"sshPublicKey\": \"\",\r\n+ \"loadBalancerType\": \"internal\",\r\n+ \"jumpbox\": \"Yes\",\r\n+ \"vmClientNodeCount\": 1,\r\n+ \"vmSizeClientNodes\": \"Standard_D2_v2\",\r\n+ \"vmSizeMasterNodes\": \"Standard_D2_v2\",\r\n+ \"vmSizeDataNodes\": \"Standard_D2_v2\",\r\n+ \"vmDataNodeCount\": 3,\r\n+ \"esClusterName\": \"elasticsearch\",\r\n+ \"esVersion\": \"2.3.1\",\r\n+ \"afs\": \"no\",\r\n+ \"marvel\": \"yes\",\r\n+ \"marvelCluster\": \"no\",\r\n+ \"vmSizeMarvelNodes\": \"Standard_D2_v2\",\r\n+ \"kibana\": \"yes\",\r\n+ \"sense\": \"yes\",\r\n+ \"_artifactsLocationSasToken\": \"\",\r\n+ \"cloudAzureStorageAccount\": \"\",\r\n+ \"jmeterAgent\": \"no\",\r\n+ \"cloudAzure\": \"no\",\r\n+ \"cloudAzureStorageKey\": \"\",\r\n+ \"_artifactsLocation\": \"https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/elasticsearch\",\r\n+ \"nestedTemplatesFolderName\": \"nestedtemplates\",\r\n+ \"scriptsLocation\": \"[concat(variables('_artifactsLocation'), '/scripts/')]\",\r\n+ \"sharedScriptsLocation\": \"https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/shared_scripts/ubuntu/\",\r\n+ \"storageAccountPrefix\": \"[concat(substring(uniqueString(resourceGroup().id, variables('esClusterName')), 0, 6), substring(variables('esClusterName'), 0, 3))]\",\r\n+ \"storageAccountNameAFS\": \"[concat(variables('storageAccountPrefix'), 'afs')]\",\r\n+ \"storageAccountNameShared\": \"[concat(variables('storageAccountPrefix'), 'sh')]\",\r\n+ \"masterNodesIpPrefix\": \"10.0.0.1\",\r\n+ \"marvelNodesIpPrefix\": \"10.0.2.2\",\r\n+ \"kibanaIPPrefix\": {\r\n+ \"yes\": \"[variables('marvelNodesIpPrefix')]\",\r\n+ \"no\": \"[variables('masterNodesIpPrefix')]\"\r\n+ },\r\n+ \"kibanaIP\": \"[concat('http://', variables('kibanaIPPrefix')[variables('marvelCluster')], '0:9200')]\",\r\n+ \"networkSettings\": {\r\n+ \"virtualNetworkName\": \"[variables('virtualNetworkName')]\",\r\n+ \"addressPrefix\": \"10.0.0.0/16\",\r\n+ \"subnet\": {\r\n+ \"master\": {\r\n+ \"name\": \"master\",\r\n+ \"prefix\": \"10.0.0.0/24\",\r\n+ \"vnet\": \"[variables('virtualNetworkName')]\"\r\n+ },\r\n+ \"data\": {\r\n+ \"name\": \"data\",\r\n+ \"prefix\": \"10.0.1.0/24\",\r\n+ \"vnet\": \"[variables('virtualNetworkName')]\"\r\n+ },\r\n+ \"other\": {\r\n+ \"name\": \"other\",\r\n+ \"prefix\": \"10.0.2.0/24\",\r\n+ \"vnet\": \"[variables('virtualNetworkName')]\"\r\n+ }\r\n+ }\r\n+ },\r\n+ \"esSettings\": {\r\n+ \"clusterName\": \"[variables('esClusterName')]\",\r\n+ \"marvelClusterName\": \"[concat(variables('esClusterName'), '-marvel')]\",\r\n+ \"version\": \"[variables('esVersion')]\",\r\n+ \"discoveryHosts\": \"[concat(variables('masterNodesIpPrefix'), '-3')]\",\r\n+ \"marvelHosts\": \"[concat(variables('marvelNodesIpPrefix'), '-3')]\"\r\n+ },\r\n+ \"sharedTemplateFileName\": \"shared-resources.json\",\r\n+ \"masterTemplateFileName\": \"master-nodes-resources.json\",\r\n+ \"marvelTemplates\": {\r\n+ \"yes\": \"marvel-nodes-resources.json\",\r\n+ \"no\": \"empty-resources.json\"\r\n+ },\r\n+ \"clientTemplates\": [\r\n+ \"empty-resources.json\",\r\n+ \"client-nodes-resources.json\"\r\n+ ],\r\n+ \"marvelTemplateFileName\": \"[variables('marvelTemplates')[variables('marvelCluster')]]\",\r\n+ \"clientTemplateFileName\": \"[variables('clientTemplates')[mod(add(variables('vmClientNodeCount'), 2), add(variables('vmClientNodeCount'), 1))]]\",\r\n+ \"lbBackEndPoolsAdded\": {\r\n+ \"backendPools\": [{\r\n+ \"id\": \"[concat(resourceId('Microsoft.Network/loadBalancers', 'es-load-balancer'), '/backendAddressPools/LBBE')]\"\r\n+ }]\r\n+ },\r\n+ \"lbBackendPoolsRemoved\": {\r\n+ \"backendPools\": []\r\n+ },\r\n+ \"dataLBSettingOptions\": [\r\n+ \"[variables('lbBackEndPoolsAdded')]\",\r\n+ \"[variables('lbBackendPoolsRemoved')]\"\r\n+ ],\r\n+ \"dataLBSettings\": \"[variables('dataLBSettingOptions')[mod(add(variables('vmClientNodeCount'), 2), add(variables('vmClientNodeCount'), 1))]]\",\r\n+ \"jumpboxTemplateYes\": \"jumpbox-resources.json\",\r\n+ \"jumpboxTemplateNo\": \"empty-resources.json\",\r\n+ \"jumpboxTemplateFileName\": \"[variables(concat('jumpboxTemplate', variables('jumpbox')))]\",\r\n+ \"senseParam\": {\r\n+ \"yes\": \" -s \",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"marvelParam\": {\r\n+ \"ubuntu\": {\r\n+ \"yes\": \" -m \",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"centos\": {\r\n+ \"yes\": \" -m \",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"windows\": {\r\n+ \"yes\": \" -m \",\r\n+ \"no\": \"\"\r\n+ }\r\n+ },\r\n+ \"afsParam\": {\r\n+ \"ubuntu\": {\r\n+ \"yes\": \"[concat(' -a ', variables('storageAccountNameAFS'), ' -c -k ')]\",\r\n+ \"no\": \"[concat(' -a ', variables('storageAccountNameAFS'), ' -k ')]\"\r\n+ },\r\n+ \"centos\": {\r\n+ \"yes\": \"\",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"windows\": {\r\n+ \"yes\": \"\",\r\n+ \"no\": \"\"\r\n+ }\r\n+ },\r\n+ \"marvelExportParam\": {\r\n+ \"ubuntu\": {\r\n+ \"yes\": \"[concat(' -e ', variables('marvelNodesIpPrefix'), '-3')]\",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"centos\": {\r\n+ \"yes\": \"[concat(' -e ', variables('marvelNodesIpPrefix'), '-3')]\",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"windows\": {\r\n+ \"yes\": \"[concat(' -marvelEndpoints ', variables('marvelNodesIpPrefix'), '-3')]\",\r\n+ \"no\": \"\"\r\n+ }\r\n+ },\r\n+ \"jmeterParam\": {\r\n+ \"yes\": \" -j \",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"cloudAzureParam\": {\r\n+ \"yes\": \"[concat(' -po ', variables('cloudAzureStorageAccount'), ' -r ', variables('cloudAzureStorageKey'), ' ')]\",\r\n+ \"no\": \"\"\r\n+ },\r\n+ \"cloudAzureParamValue\": \"[variables('cloudAzureParam')[variables('cloudAzure')]]\",\r\n+ \"marvelExportParamValue\": \"[variables('marvelExportParam')[variables('OS')][variables('marvelCluster')]]\",\r\n+ \"senseParamValue\": \"[variables('senseParam')[variables('sense')]]\",\r\n+ \"marvelParamValue\": \"[variables('marvelParam')[variables('OS')][variables('marvel')]]\",\r\n+ \"jmeterParamValue\": \"[variables('jmeterParam')[variables('jmeterAgent')]]\",\r\n+ \"afsParamValue\": \"[variables('afsParam')[variables('OS')][variables('afs')]]\",\r\n+ \"kibanaTemplates\": {\r\n+ \"yes\": \"kibana-resources.json\",\r\n+ \"no\": \"empty-resources.json\"\r\n+ },\r\n+ \"kibanaTemplateFileName\": \"[variables('kibanaTemplates')[variables('kibana')]]\",\r\n+ \"ubuntuScripts\": [\r\n+ \"[concat(variables('scriptsLocation'), 'elasticsearch-ubuntu-install.sh', variables('_artifactsLocationSasToken'))]\",\r\n+ \"[concat(variables('scriptsLocation'), 'kibana-install.sh', variables('_artifactsLocationSasToken'))]\",\r\n+ \"[concat(variables('sharedScriptsLocation'), 'vm-disk-utils-0.1.sh')]\",\r\n+ \"[concat(variables('sharedScriptsLocation'), 'afs-utils-0.1.sh')]\"\r\n+ ],\r\n+ \"centosScripts\": [\r\n+ \"[concat(variables('scriptsLocation'), 'elasticsearch-centos-install.sh', variables('_artifactsLocationSasToken'))]\",\r\n+ \"[concat(variables('scriptsLocation'), 'kibana-centos-install.sh', variables('_artifactsLocationSasToken'))]\",\r\n+ \"[concat(variables('sharedScriptsLocation'), 'vm-disk-utils-0.1.sh')]\"\r\n+ ],\r\n+ \"windowsScripts\": [\r\n+ \"[concat(variables('scriptsLocation'), 'elasticsearch-windows-install.ps1', variables('_artifactsLocationSasToken'))]\"\r\n+ ],\r\n+ \"authSet\": {\r\n+ \"password\": \"[variables('adminPassword')]\",\r\n+ \"sshKey\": \"[variables('sshPublicKey')]\",\r\n+ \"type\": \"[variables('authenticationType')]\"\r\n+ },\r\n+ \"configurationObject\": {\r\n+ \"password\": {},\r\n+ \"sshPublicKey\": {\r\n+ \"disablePasswordAuthentication\": \"true\",\r\n+ \"ssh\": {\r\n+ \"publicKeys\": [{\r\n+ \"path\": \"[concat('/home/', variables('adminUsername'), '/.ssh/authorized_keys')]\",\r\n+ \"keyData\": \"[variables('sshPublicKey')]\"\r\n+ }]\r\n+ }\r\n+ }\r\n+ },\r\n+ \"ubuntuSettings\": {\r\n+ \"imageReference\": {\r\n+ \"publisher\": \"Canonical\",\r\n+ \"offer\": \"UbuntuServer\",\r\n+ \"sku\": \"14.04.4-LTS\",\r\n+ \"version\": \"latest\"\r\n+ },\r\n+ \"linuxConfiguration\": \"[variables('configurationObject')[variables('authenticationType')]]\",\r\n+ \"managementPort\": \"22\",\r\n+ \"extensionSettings\": {\r\n+ \"marvel\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('ubuntuScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-ubuntu-install.sh -wn ', variables('esSettings').marvelClusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').marvelHosts, ' -k ')]\"\r\n+ }\r\n+ },\r\n+ \"master\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('ubuntuScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-ubuntu-install.sh -xn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'), variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"client\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('ubuntuScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-ubuntu-install.sh -yn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'), variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"data\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('ubuntuScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-ubuntu-install.sh -zn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'), variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"kibana\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('ubuntuScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash kibana-install.sh -v ', variables('esSettings').version, variables('marvelParamValue'), variables('senseParamValue'), ' -t ', variables('kibanaIP'))]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ \"centosSettings\": {\r\n+ \"imageReference\": {\r\n+ \"publisher\": \"OpenLogic\",\r\n+ \"offer\": \"CentOS\",\r\n+ \"sku\": \"7.2\",\r\n+ \"version\": \"latest\"\r\n+ },\r\n+ \"linuxConfiguration\": \"[variables('configurationObject')[variables('authenticationType')]]\",\r\n+ \"managementPort\": \"22\",\r\n+ \"extensionSettings\": {\r\n+ \"marvel\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('centosScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-centos-install.sh -wn ', variables('esSettings').marvelClusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').marvelHosts, ' -k ')]\"\r\n+ }\r\n+ },\r\n+ \"master\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('centosScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-centos-install.sh -xn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'), variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"client\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('centosScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-centos-install.sh -yn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'),variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"data\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('centosScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash elasticsearch-centos-install.sh -zn ', variables('esSettings').clusterName, ' -v ', variables('esSettings').version, ' -d ', variables('esSettings').discoveryHosts, variables('marvelParamValue'), variables('jmeterParamValue'), variables('cloudAzureParamValue'),variables('marvelExportParamValue'), variables('afsParamValue'))]\"\r\n+ }\r\n+ },\r\n+ \"kibana\": {\r\n+ \"publisher\": \"Microsoft.Azure.Extensions\",\r\n+ \"type\": \"CustomScript\",\r\n+ \"typeHandlerVersion\": \"2.0\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('centosScripts')]\",\r\n+ \"commandToExecute\": \"[concat('bash kibana-centos-install.sh -v ', variables('esSettings').version, variables('marvelParamValue'), variables('senseParamValue'), ' -t ', variables('kibanaIP'))]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ \"windowsSettings\": {\r\n+ \"imageReference\": {\r\n+ \"publisher\": \"MicrosoftWindowsServer\",\r\n+ \"offer\": \"WindowsServer\",\r\n+ \"sku\": \"2012-R2-Datacenter\",\r\n+ \"version\": \"latest\"\r\n+ },\r\n+ \"linuxConfiguration\": \"\",\r\n+ \"managementPort\": \"3389\",\r\n+ \"extensionSettings\": {\r\n+ \"marvel\": {\r\n+ \"publisher\": \"Microsoft.Compute\",\r\n+ \"type\": \"CustomScriptExtension\",\r\n+ \"typeHandlerVersion\": \"1.4\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('windowsScripts')]\",\r\n+ \"commandToExecute\": \"[concat('powershell.exe -File elasticsearch-windows-install.ps1 -elasticSearchVersion ', variables('esSettings').version, ' -elasticClusterName ', variables('esSettings').marvelClusterName, ' -discoveryEndpoints ', variables('esSettings').marvelHosts, ' -marvelOnlyNode -storageKey ')]\"\r\n+ }\r\n+ },\r\n+ \"master\": {\r\n+ \"publisher\": \"Microsoft.Compute\",\r\n+ \"type\": \"CustomScriptExtension\",\r\n+ \"typeHandlerVersion\": \"1.4\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('windowsScripts')]\",\r\n+ \"commandToExecute\": \"[concat('powershell.exe -File elasticsearch-windows-install.ps1 -elasticSearchVersion ', variables('esSettings').version, ' -elasticClusterName ', variables('esSettings').clusterName, ' -discoveryEndpoints ', variables('esSettings').discoveryHosts, variables('cloudAzureParamValue'), variables('marvelParamValue'), variables('marvelExportParamValue'), ' -masterOnlyNode -storageKey ')]\"\r\n+ }\r\n+ },\r\n+ \"client\": {\r\n+ \"publisher\": \"Microsoft.Compute\",\r\n+ \"type\": \"CustomScriptExtension\",\r\n+ \"typeHandlerVersion\": \"1.4\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('windowsScripts')]\",\r\n+ \"commandToExecute\": \"[concat('powershell.exe -File elasticsearch-windows-install.ps1 -elasticSearchVersion ', variables('esSettings').version, ' -elasticClusterName ', variables('esSettings').clusterName, ' -discoveryEndpoints ', variables('esSettings').discoveryHosts, variables('cloudAzureParamValue'), variables('marvelParamValue'), variables('marvelExportParamValue'), ' -clientOnlyNode -storageKey ')]\"\r\n+ }\r\n+ },\r\n+ \"data\": {\r\n+ \"publisher\": \"Microsoft.Compute\",\r\n+ \"type\": \"CustomScriptExtension\",\r\n+ \"typeHandlerVersion\": \"1.4\",\r\n+ \"autoUpgradeMinorVersion\": true,\r\n+ \"settings\": {\r\n+ \"fileUris\": \"[variables('windowsScripts')]\",\r\n+ \"commandToExecute\": \"[concat('powershell.exe -File elasticsearch-windows-install.ps1 -elasticSearchVersion ', variables('esSettings').version, ' -elasticClusterName ', variables('esSettings').clusterName, ' -discoveryEndpoints ', variables('esSettings').discoveryHosts, variables('cloudAzureParamValue'), variables('marvelParamValue'), variables('marvelExportParamValue'), ' -dataOnlyNode -storageKey ')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ \"osSettings\": \"[variables(concat(variables('OS'), 'Settings'))]\",\r\n+ \"dataSkuSettings\": {\r\n+ \"Standard_D1_v2\": {\r\n+ \"dataDisks\": 2,\r\n+ \"nodesPerStorageAccount\": 6,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_D2_v2\": {\r\n+ \"dataDisks\": 4,\r\n+ \"nodesPerStorageAccount\": 4,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_D3_v2\": {\r\n+ \"dataDisks\": 8,\r\n+ \"nodesPerStorageAccount\": 3,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_D4_v2\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_D12_v2\": {\r\n+ \"dataDisks\": 8,\r\n+ \"nodesPerStorageAccount\": 3,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_DS1\": {\r\n+ \"dataDisks\": 2,\r\n+ \"nodesPerStorageAccount\": 6,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_DS2\": {\r\n+ \"dataDisks\": 4,\r\n+ \"nodesPerStorageAccount\": 4,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_DS3\": {\r\n+ \"dataDisks\": 8,\r\n+ \"nodesPerStorageAccount\": 4,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_DS4\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_DS13\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_DS14\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Premium_LRS\"\r\n+ },\r\n+ \"Standard_A2\": {\r\n+ \"dataDisks\": 4,\r\n+ \"nodesPerStorageAccount\": 6,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_A3\": {\r\n+ \"dataDisks\": 8,\r\n+ \"nodesPerStorageAccount\": 4,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_A4\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ },\r\n+ \"Standard_A7\": {\r\n+ \"dataDisks\": 16,\r\n+ \"nodesPerStorageAccount\": 2,\r\n+ \"storageAccountType\": \"Standard_LRS\"\r\n+ }\r\n+ },\r\n+ \"nodesPerStorageAccount\": \"[variables('dataSkuSettings')[variables('vmSizeDataNodes')].nodesPerStorageAccount]\",\r\n+ \"storageBinPackMap\": [\r\n+ \"[div(sub(add(1, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(2, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(3, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(4, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(5, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(6, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(7, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(8, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(9, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(10, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(11, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(12, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(13, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(14, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(15, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(16, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(17, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(18, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(19, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(20, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(21, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(22, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(23, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(24, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(25, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(26, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(27, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(28, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(29, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(30, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(31, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(32, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(33, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(34, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(35, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(36, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(37, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(38, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(39, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(40, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(51, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(52, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(53, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(54, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(55, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(56, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(57, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(58, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(59, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"[div(sub(add(60, variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\"\r\n+ ],\r\n+ \"dataNodeStorageSettings\": {\r\n+ \"count\": \"[div(sub(add(variables('vmDataNodeCount'), variables('nodesPerStorageAccount')), 1), variables('nodesPerStorageAccount'))]\",\r\n+ \"mapping\": \"[variables('storageBinPackMap')]\",\r\n+ \"accountType\": \"[variables('dataSkuSettings')[variables('vmSizeDataNodes')].storageAccountType]\",\r\n+ \"afs\": \"[variables('storageAccountNameAFS')]\",\r\n+ \"shared\": \"[variables('storageAccountNameShared')]\",\r\n+ \"prefix\": \"[concat(variables('storageAccountPrefix'), 'da')]\"\r\n+ },\r\n+ \"dataTemplateFileName\": {\r\n+ \"afs-yes\": \"data-nodes-0disk-resources.json\",\r\n+ \"afs-no\": \"[concat('data-nodes-', string(variables('dataSkuSettings')[variables('vmSizeDataNodes')].dataDisks), 'disk-resources.json')]\"\r\n+ },\r\n+ \"dataTemplateFileNameValue\": \"[variables('dataTemplateFileName')[concat('afs-', variables('afs'))]]\"\r\n+ },\r\n+ \"resources\": [{\r\n+ \"name\": \"master-nodes\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('masterTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"storageSettings\": {\r\n+ \"value\": \"[variables('dataNodeStorageSettings')]\"\r\n+ },\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"masterNodesIpPrefix\": {\r\n+ \"value\": \"[variables('masterNodesIpPrefix')]\"\r\n+ },\r\n+ \"vmSize\": {\r\n+ \"value\": \"[variables('vmSizeMasterNodes')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.master]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-master')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"marvel-nodes\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('marvelTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"storageAccountName\": {\r\n+ \"value\": \"[variables('storageAccountNameShared')]\"\r\n+ },\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"marvelNodesIpPrefix\": {\r\n+ \"value\": \"[variables('marvelNodesIpPrefix')]\"\r\n+ },\r\n+ \"vmSize\": {\r\n+ \"value\": \"[variables('vmSizeMarvelNodes')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.other]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-marvel')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"shared\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('sharedTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"networkSettings\": {\r\n+ \"value\": \"[variables('networkSettings')]\"\r\n+ },\r\n+ \"storageSettings\": {\r\n+ \"value\": \"[variables('dataNodeStorageSettings')]\"\r\n+ },\r\n+ \"loadBalancerType\": {\r\n+ \"value\": \"[variables('loadBalancerType')]\"\r\n+ },\r\n+ \"ilbIpAddress\": {\r\n+ \"value\": \"10.0.2.100\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"client-nodes\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('clientTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"storageSettings\": {\r\n+ \"value\": \"[variables('dataNodeStorageSettings')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.other]\"\r\n+ },\r\n+ \"vmSize\": {\r\n+ \"value\": \"[variables('vmSizeClientNodes')]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"vmCount\": {\r\n+ \"value\": \"[variables('vmClientNodeCount')]\"\r\n+ },\r\n+ \"lbBackendPools\": {\r\n+ \"value\": \"[variables('lbBackEndPoolsAdded')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-client')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"data-nodes\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('dataTemplateFileNameValue'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"storageSettings\": {\r\n+ \"value\": \"[variables('dataNodeStorageSettings')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.data]\"\r\n+ },\r\n+ \"vmSize\": {\r\n+ \"value\": \"[variables('vmSizeDataNodes')]\"\r\n+ },\r\n+ \"vmCount\": {\r\n+ \"value\": \"[variables('vmDataNodeCount')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-data')]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"lbBackendPools\": {\r\n+ \"value\": \"[variables('dataLBSettings')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"jumpbox\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('jumpboxTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"storageAccountName\": {\r\n+ \"value\": \"[variables('storageAccountNameShared')]\"\r\n+ },\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.other]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-jumpbox')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ },\r\n+ {\r\n+ \"name\": \"kibana\",\r\n+ \"type\": \"Microsoft.Resources/deployments\",\r\n+ \"apiVersion\": \"2015-01-01\",\r\n+ \"dependsOn\": [\r\n+ \"[resourceId('Microsoft.Resources/deployments', 'shared')]\"\r\n+ ],\r\n+ \"properties\": {\r\n+ \"mode\": \"Incremental\",\r\n+ \"templateLink\": {\r\n+ \"uri\": \"[concat(variables('_artifactsLocation'), '/', variables('nestedTemplatesFolderName'), '/', variables('kibanaTemplateFileName'), variables('_artifactsLocationSasToken'))]\",\r\n+ \"contentVersion\": \"1.0.0.0\"\r\n+ },\r\n+ \"parameters\": {\r\n+ \"storageAccountName\": {\r\n+ \"value\": \"[variables('storageAccountNameShared')]\"\r\n+ },\r\n+ \"adminUsername\": {\r\n+ \"value\": \"[variables('adminUsername')]\"\r\n+ },\r\n+ \"authSet\": {\r\n+ \"value\": \"[variables('authSet')]\"\r\n+ },\r\n+ \"subnet\": {\r\n+ \"value\": \"[variables('networkSettings').subnet.other]\"\r\n+ },\r\n+ \"osSettings\": {\r\n+ \"value\": \"[variables('osSettings')]\"\r\n+ },\r\n+ \"namespace\": {\r\n+ \"value\": \"[concat(variables('esClusterName'), '-kibana')]\"\r\n+ }\r\n+ }\r\n+ }\r\n+ }\r\n+ ],\r\n+ \"outputs\": {\r\n+ \"existingvnetname\": {\r","path":"elasticsearch-jmeter/prereqs/prereq.azuredeploy.json","position":788,"original_position":788,"commit_id":"d560ccc0225e44bbeb8405f7cab742d5cb64fbb9","original_commit_id":"d560ccc0225e44bbeb8405f7cab742d5cb64fbb9","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars1.githubusercontent.com/u/10090014?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"camelCase","created_at":"2017-08-20T22:17:54Z","updated_at":"2017-08-20T22:18:01Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3794#discussion_r134127897","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/134127897"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3794#discussion_r134127897"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794","id":136514949,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3794","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3794.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3794.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3794","number":3794,"state":"open","locked":false,"title":"elasticsearch-jmeter: Modified to include prereqs directory","user":{"login":"PraveenAnil","id":7903608,"avatar_url":"https://avatars2.githubusercontent.com/u/7903608?v=4","gravatar_id":"","url":"https://api.github.com/users/PraveenAnil","html_url":"https://github.com/PraveenAnil","followers_url":"https://api.github.com/users/PraveenAnil/followers","following_url":"https://api.github.com/users/PraveenAnil/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAnil/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAnil/subscriptions","organizations_url":"https://api.github.com/users/PraveenAnil/orgs","repos_url":"https://api.github.com/users/PraveenAnil/repos","events_url":"https://api.github.com/users/PraveenAnil/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAnil/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [x] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n*\r\n*\r\n*\r\n\r\n","created_at":"2017-08-18T16:12:16Z","updated_at":"2017-08-20T22:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98146a257ba47124739e6465c680903585dc5f5b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3794/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/d560ccc0225e44bbeb8405f7cab742d5cb64fbb9","head":{"label":"PraveenAnil:Spektra-prereqs-p-20","ref":"Spektra-prereqs-p-20","sha":"d560ccc0225e44bbeb8405f7cab742d5cb64fbb9","user":{"login":"PraveenAnil","id":7903608,"avatar_url":"https://avatars2.githubusercontent.com/u/7903608?v=4","gravatar_id":"","url":"https://api.github.com/users/PraveenAnil","html_url":"https://github.com/PraveenAnil","followers_url":"https://api.github.com/users/PraveenAnil/followers","following_url":"https://api.github.com/users/PraveenAnil/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAnil/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAnil/subscriptions","organizations_url":"https://api.github.com/users/PraveenAnil/orgs","repos_url":"https://api.github.com/users/PraveenAnil/repos","events_url":"https://api.github.com/users/PraveenAnil/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAnil/received_events","type":"User","site_admin":false},"repo":{"id":97118869,"name":"azure-quickstart-templates","full_name":"PraveenAnil/azure-quickstart-templates","owner":{"login":"PraveenAnil","id":7903608,"avatar_url":"https://avatars2.githubusercontent.com/u/7903608?v=4","gravatar_id":"","url":"https://api.github.com/users/PraveenAnil","html_url":"https://github.com/PraveenAnil","followers_url":"https://api.github.com/users/PraveenAnil/followers","following_url":"https://api.github.com/users/PraveenAnil/following{/other_user}","gists_url":"https://api.github.com/users/PraveenAnil/gists{/gist_id}","starred_url":"https://api.github.com/users/PraveenAnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PraveenAnil/subscriptions","organizations_url":"https://api.github.com/users/PraveenAnil/orgs","repos_url":"https://api.github.com/users/PraveenAnil/repos","events_url":"https://api.github.com/users/PraveenAnil/events{/privacy}","received_events_url":"https://api.github.com/users/PraveenAnil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PraveenAnil/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates","forks_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/PraveenAnil/azure-quickstart-templates/deployments","created_at":"2017-07-13T12:11:50Z","updated_at":"2017-07-13T12:12:00Z","pushed_at":"2017-08-18T16:43:24Z","git_url":"git://github.com/PraveenAnil/azure-quickstart-templates.git","ssh_url":"git@github.com:PraveenAnil/azure-quickstart-templates.git","clone_url":"https://github.com/PraveenAnil/azure-quickstart-templates.git","svn_url":"https://github.com/PraveenAnil/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":203387,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"041ccb5585927de31a7839bcb11f20d331785337","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-08-19T23:58:23Z","pushed_at":"2017-08-20T21:57:54Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":204834,"stargazers_count":2651,"watchers_count":2651,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3783,"mirror_url":null,"open_issues_count":379,"forks":3783,"open_issues":379,"watchers":2651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3794"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3794"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3794/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3794/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/d560ccc0225e44bbeb8405f7cab742d5cb64fbb9"}}}}
|
{
"id": 34407651,
"name": "Azure/azure-quickstart-templates",
"url": "https://api.github.com/repos/Azure/azure-quickstart-templates"
}
|
{
"id": 10090014,
"login": "bmoore-msft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10090014?",
"url": "https://api.github.com/users/bmoore-msft"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-08-20T22:17:54 |
6489048877
|
{"actor":{"display_login":"bmoore-msft"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/127562744","pull_request_review_id":50166727,"id":127562744,"diff_hunk":"@@ -0,0 +1,855 @@\n+{\n+ \"$schema\": \"https://schema.management.azure.com/schemas/2015-01-01/deploymentTemplate.json#\",\n+ \"contentVersion\": \"1.0.0.0\",\n+ \"parameters\": {\n+ \"templatePrefix\": {\n+ \"type\": \"string\",\n+ \"minLength\": 3,\n+ \"metadata\": {\n+ \"description\": \"Value used as a prefix to generate name of various objects like the vnet or the storage account. IT MUST CONTAIN ONLY NUMBERS AND lowercase LETTERS\"\n+ }\n+ },\n+ \"storageAccountType\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"Standard_LRS\",\n+ \"allowedValues\": [ \"Standard_LRS\", \"Standard_GRS\", \"Premium_LRS\" ],\n+ \"metadata\": {\n+ \"description\": \"Type of the storage accounts to create. Allowed values are \\\"Standard_LRS\\\", \\\"Standard_GRS\\\" and \\\"Premium_LRS\\\"\"\n+ }\n+ },\n+ \"sharePointVersion\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"2016\",\n+ \"allowedValues\": [ \"2013\", \"2016\" ],\n+ \"metadata\": {\n+ \"description\": \"Version of SharePoint farm to create.\"\n+ }\n+ },\n+ \"domainFQDN\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"contoso.local\",\n+ \"minLength\": 5,\n+ \"metadata\": {\n+ \"description\": \"FQDN of the AD forest to create\"\n+ }\n+ },\n+ \"adminUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"yvand\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the AD and SharePoint administrator\"\n+ }\n+ },\n+ \"adminPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"adfsSvcUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"adfssvc\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will run ADFS\"\n+ }\n+ },\n+ \"adfsSvcPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"sqlSvcUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"sqlsvc\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will run SQL Server instance\"\n+ }\n+ },\n+ \"sqlSvcPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"spSetupUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"spsetup\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will create and configure the SharePoint farm\"\n+ }\n+ },\n+ \"spSetupPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"spFarmUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"spfarm\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will run SharePoint central administration and Timer services\"\n+ }\n+ },\n+ \"spFarmPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"spSvcUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"spsvc\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will run SharePoint service applications\"\n+ }\n+ },\n+ \"spSvcPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"spAppPoolUserName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"spapppool\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Name of the service account that will run SharePoint web applications\"\n+ }\n+ },\n+ \"spAppPoolPassword\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 8,\n+ \"metadata\": {\n+ \"description\": \"Input must meet password complexity requirements as documented for property 'adminPassword' in https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/virtualmachines-create-or-update\"\n+ }\n+ },\n+ \"spPassphrase\": {\n+ \"type\": \"securestring\",\n+ \"minLength\": 1,\n+ \"metadata\": {\n+ \"description\": \"Passphrase of the SharePoint farm\"\n+ }\n+ },\n+ \"vmDCName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"DC\",\n+ \"minLength\": 2,\n+ \"metadata\": {\n+ \"description\": \"Internal name of DC VM\"\n+ }\n+ },\n+ \"vmDCSize\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"Standard_F4\",\n+ \"metadata\": {\n+ \"description\": \"Size of the DC VM\"\n+ }\n+ },\n+ \"vmDCPublicIPDnsName\": {\n+ \"type\": \"string\",\n+ \"minLength\": 2,\n+ \"metadata\": {\n+ \"description\": \"'Input' used to create public DNS name 'Input.region.cloudapp.azure.com' of DC VM\"\n+ }\n+ },\n+ \"vmSQLName\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"SQL\",\n+ \"minLength\": 2,\n+ \"metadata\": {\n+ \"description\": \"Internal name of SQL VM\"\n+ }\n+ },\n+ \"vmSQLSize\": {\n+ \"type\": \"string\",\n+ \"defaultValue\": \"Standard_A4_v2\",\n+ \"metadata\": {\n+ \"description\": \"Size of the SQL VM\"\n+ }\n+ },\n+ \"vmSQLPublicIPDnsName\": {\n+ \"type\": \"string\",\n+ \"minLength\": 2,\n+ \"metadata\": {\n+ \"description\": \"'Input' used to create public DNS name 'Input.region.cloudapp.azure.com' of SQL VM\"\n+ }\n+ },\n+ \"vmSPName\": {","path":"sharepoint-adfs/azuredeploy.json","position":192,"original_position":192,"commit_id":"b4b63d68847784dc00cf946c1df3df03c7d0b8eb","original_commit_id":"b4b63d68847784dc00cf946c1df3df03c7d0b8eb","user":{"login":"bmoore-msft","id":10090014,"avatar_url":"https://avatars5.githubusercontent.com/u/10090014?v=4","gravatar_id":"","url":"https://api.github.com/users/bmoore-msft","html_url":"https://github.com/bmoore-msft","followers_url":"https://api.github.com/users/bmoore-msft/followers","following_url":"https://api.github.com/users/bmoore-msft/following{/other_user}","gists_url":"https://api.github.com/users/bmoore-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/bmoore-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmoore-msft/subscriptions","organizations_url":"https://api.github.com/users/bmoore-msft/orgs","repos_url":"https://api.github.com/users/bmoore-msft/repos","events_url":"https://api.github.com/users/bmoore-msft/events{/privacy}","received_events_url":"https://api.github.com/users/bmoore-msft/received_events","type":"User","site_admin":false},"body":"variable?","created_at":"2017-07-14T22:44:23Z","updated_at":"2017-07-14T22:55:14Z","html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3528#discussion_r127562744","pull_request_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments/127562744"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3528#discussion_r127562744"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528","id":124211934,"html_url":"https://github.com/Azure/azure-quickstart-templates/pull/3528","diff_url":"https://github.com/Azure/azure-quickstart-templates/pull/3528.diff","patch_url":"https://github.com/Azure/azure-quickstart-templates/pull/3528.patch","issue_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3528","number":3528,"state":"open","locked":false,"title":"Add new template that deploys a SharePoint 2016 or 2013 farm with ADFS","user":{"login":"Yvand","id":8788631,"avatar_url":"https://avatars6.githubusercontent.com/u/8788631?v=4","gravatar_id":"","url":"https://api.github.com/users/Yvand","html_url":"https://github.com/Yvand","followers_url":"https://api.github.com/users/Yvand/followers","following_url":"https://api.github.com/users/Yvand/following{/other_user}","gists_url":"https://api.github.com/users/Yvand/gists{/gist_id}","starred_url":"https://api.github.com/users/Yvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yvand/subscriptions","organizations_url":"https://api.github.com/users/Yvand/orgs","repos_url":"https://api.github.com/users/Yvand/repos","events_url":"https://api.github.com/users/Yvand/events{/privacy}","received_events_url":"https://api.github.com/users/Yvand/received_events","type":"User","site_admin":false},"body":"### Best Practice Checklist\r\nCheck these items before submitting a PR... See the Contribution Guide for the full detail: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/README.md \r\n\r\n1. uri's compatible with all clouds (Stack, China, Government)\r\n1. Staged artifacts use _artifactsLocation & _artifactsLocationSasToken\r\n1. Use resourceGroup().location for resource locations\r\n1. Folder names for artifacts (nestedtemplates, scripts, DSC)\r\n1. Use literal values for apiVersion (no variables)\r\n1. Parameter files (GEN-UNIQUE for value generation and no \"changemeplease\" values\r\n1. $schema and other uris use https\r\n1. Use uniqueString() whenever possible to generate names for resources. While this is not required, it's one of the most common failure points in a deployment. \r\n1. Update the metadata.json with the current date\r\n\r\nFor details: https://github.com/Azure/azure-quickstart-templates/blob/master/1-CONTRIBUTION-GUIDE/bp-checklist.md\r\n\r\n- [x] - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.\r\n\r\n### Changelog\r\n\r\n* Submitted PR\r\n","created_at":"2017-06-06T14:57:33Z","updated_at":"2017-07-14T22:55:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b7c03e6b4fc3491af9d42c38c6f533462b4b3f2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3528/comments","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/b4b63d68847784dc00cf946c1df3df03c7d0b8eb","head":{"label":"Yvand:sharepoint-adfs","ref":"sharepoint-adfs","sha":"b4b63d68847784dc00cf946c1df3df03c7d0b8eb","user":{"login":"Yvand","id":8788631,"avatar_url":"https://avatars6.githubusercontent.com/u/8788631?v=4","gravatar_id":"","url":"https://api.github.com/users/Yvand","html_url":"https://github.com/Yvand","followers_url":"https://api.github.com/users/Yvand/followers","following_url":"https://api.github.com/users/Yvand/following{/other_user}","gists_url":"https://api.github.com/users/Yvand/gists{/gist_id}","starred_url":"https://api.github.com/users/Yvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yvand/subscriptions","organizations_url":"https://api.github.com/users/Yvand/orgs","repos_url":"https://api.github.com/users/Yvand/repos","events_url":"https://api.github.com/users/Yvand/events{/privacy}","received_events_url":"https://api.github.com/users/Yvand/received_events","type":"User","site_admin":false},"repo":{"id":85952574,"name":"azure-quickstart-templates","full_name":"Yvand/azure-quickstart-templates","owner":{"login":"Yvand","id":8788631,"avatar_url":"https://avatars6.githubusercontent.com/u/8788631?v=4","gravatar_id":"","url":"https://api.github.com/users/Yvand","html_url":"https://github.com/Yvand","followers_url":"https://api.github.com/users/Yvand/followers","following_url":"https://api.github.com/users/Yvand/following{/other_user}","gists_url":"https://api.github.com/users/Yvand/gists{/gist_id}","starred_url":"https://api.github.com/users/Yvand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yvand/subscriptions","organizations_url":"https://api.github.com/users/Yvand/orgs","repos_url":"https://api.github.com/users/Yvand/repos","events_url":"https://api.github.com/users/Yvand/events{/privacy}","received_events_url":"https://api.github.com/users/Yvand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yvand/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":true,"url":"https://api.github.com/repos/Yvand/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Yvand/azure-quickstart-templates/deployments","created_at":"2017-03-23T13:24:27Z","updated_at":"2017-03-23T13:24:35Z","pushed_at":"2017-06-29T09:18:47Z","git_url":"git://github.com/Yvand/azure-quickstart-templates.git","ssh_url":"git@github.com:Yvand/azure-quickstart-templates.git","clone_url":"https://github.com/Yvand/azure-quickstart-templates.git","svn_url":"https://github.com/Yvand/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":196844,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"f3f7e000734dbf1f4de8589e660754efed13dd46","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars4.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":34407651,"name":"azure-quickstart-templates","full_name":"Azure/azure-quickstart-templates","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars4.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-quickstart-templates","description":"Azure Quickstart Templates","fork":false,"url":"https://api.github.com/repos/Azure/azure-quickstart-templates","forks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/forks","keys_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/teams","hooks_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/events","assignees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/tags","blobs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/subscription","commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/merges","archive_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/downloads","issues_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-quickstart-templates/deployments","created_at":"2015-04-22T18:19:03Z","updated_at":"2017-07-14T20:42:03Z","pushed_at":"2017-07-14T22:37:58Z","git_url":"git://github.com/Azure/azure-quickstart-templates.git","ssh_url":"git@github.com:Azure/azure-quickstart-templates.git","clone_url":"https://github.com/Azure/azure-quickstart-templates.git","svn_url":"https://github.com/Azure/azure-quickstart-templates","homepage":"https://azure.microsoft.com/en-us/documentation/templates","size":204000,"stargazers_count":2519,"watchers_count":2519,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3598,"mirror_url":null,"open_issues_count":340,"forks":3598,"open_issues":340,"watchers":2519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528"},"html":{"href":"https://github.com/Azure/azure-quickstart-templates/pull/3528"},"issue":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3528"},"comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/issues/3528/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/pulls/3528/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-quickstart-templates/statuses/b4b63d68847784dc00cf946c1df3df03c7d0b8eb"}}}}
|
{
"id": 34407651,
"name": "Azure/azure-quickstart-templates",
"url": "https://api.github.com/repos/Azure/azure-quickstart-templates"
}
|
{
"id": 10090014,
"login": "bmoore-msft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10090014?",
"url": "https://api.github.com/users/bmoore-msft"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2017-07-14T22:44:23 |
6261161744
|
{"actor":{"display_login":"bmoore-msft"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CT-18/cg/pulls/comments/104534331","pull_request_review_id":25370463,"id":104534331,"diff_hunk":"@@ -0,0 +1,1645 @@\n+{\n+ \"cells\": [\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> Введение в NumPy </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"import numpy as np # Как правило импортируют именно так\\n\",\n+ \"import numpy.ma as ma\\n\",\n+ \"import numpy.linalg as LA\\n\",\n+ \"import matplotlib.pyplot as plt\\n\",\n+ \"import os\\n\",\n+ \"from numpy import pi\\n\",\n+ \"\\n\",\n+ \"from utils import printoptions\\n\",\n+ \"from answers import*\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__NumPy__ - open-source модуль, который предостовляет эффективную работу с массивами и однородными данными (~MATLAB), очень прост и удобен в использовании. \\n\",\n+ \"\\n\",\n+ \"__NumPy array__ - многомерный массив объектов одинакового типа. В памяти представлен как блок памяти + метка говорящая о типе данных + кол-во размерностей + размерности векторов ``[n * m *...]``.\\n\",\n+ \"\\n\",\n+ \"Обычные массивы в питоне в принципе хороши т.к. имеют в себе удобный `list comprehension` и могут хранить данные разных типов. Но они не поддерживают векторизацию, должны хранить информацию о типе для каждого элемента и для выполнения каких-либо операций нужен будет `dispatching`. Да __NumPy array__ этого не поддерживает, зато он эффективен и многое уже написано для удобного использования.\\n\",\n+ \"\\n\",\n+ \"Класс представлющий массивы в NumPy - __ndarray__ (экземпляр можно получить, например с помощью `np.array(...)`)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Пример 1:__ Двумерный массив [2 * 5], где каждый элемент занимает 4 байта\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true,\n+ \"scrolled\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = np.array([[0, 1, 2, 3, 4],\\n\",\n+ \" [5, 6, 7, 8, 9]], dtype=np.int32)\\n\",\n+ \"print(x) # np.darray умеет выводится в человеческом виде\\n\",\n+ \"print(\\\"Количество размерностей (numpy называет rank):\\\", x.ndim)\\n\",\n+ \"print(\\\"Сами размерности(axes):\\\", x.shape)\\n\",\n+ \"print(\\\"Тип данных:\\\", x.dtype)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Представление (view)__ - конкретный взгляд на ndarray, например мы можем иметь просто матрицу, а после сделать из нее `view` в виде транспонированной за O(1), или из массива 15 элементов, сделать `view` - матрицу 3 * 5 (еще примеры будут ниже).\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(15) # создают ndarray([0..15]) тип определяет сам (int64, float64)\\n\",\n+ \"b = a.reshape((3, 5)) # создает новое представление (view) и возвращает его, \\n\",\n+ \" # (если возможно, то данные не копируются)\\n\",\n+ \"c = b.T # создает новое представление транспонированной матрицы\\n\",\n+ \"\\n\",\n+ \"print(a)\\n\",\n+ \"print(b)\\n\",\n+ \"print(c)\\n\",\n+ \"\\n\",\n+ \"c.reshape(15) # здесь он будет вынужден копировать данные, \\n\",\n+ \" # т.к. `c` - это представление транспонированной матрицы, \\n\",\n+ \" # мы не сможем просто так ее превратить в одномерный массив\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Функции для создания масивов, тип по умолчанию - `float64`:\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"z = np.zeros((3, 4)) # Создаст матрицу 3 * 4, заполненную нулями с типом float64\\n\",\n+ \"o = np.ones((2, 3, 4), dtype=np.int16) # 2 * 3 * 4, int16\\n\",\n+ \"e = np.empty((2, 3)) # создаст матрицу 2 * 3, не инициализрованную, \\n\",\n+ \" # значаения зависят от состояния памяти текущего\\n\",\n+ \"print(\\\"zeros:\\\", os.linesep, z)\\n\",\n+ \"print(\\\"ones:\\\" , os.linesep, o)\\n\",\n+ \"print(\\\"empty:\\\", os.linesep, e)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__np.diag(v, k=0)__ - извлекает диагональ, либо создает диагональную матрицу <br/>\\n\",\n+ \"k > 0 - достает k-ую диагональ относительно главной вверх <br/>\\n\",\n+ \"k < 0 - достает k-ую диагональ от главной вниз \\n\",\n+ \"\\n\",\n+ \"__np.eye(N, M=None, k=0)__ - создает матрицу __N * M__ из нулей и с единицами на диагонали __k__ (имеет тот же смысл, что и в __np.diag__)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = np.arange(9).reshape((3,3))\\n\",\n+ \"print(x)\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.diag(x))\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.diag(x, k=1))\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.diag(x, k=-1))\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.diag((10, 7, 9, 8)))\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.eye(3))\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, np.eye(4, 3, 1))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__numpy.arange([start, ]stop, [step, ]dtype=None)__ - генерирует ndarray, аналог `range`\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"i = np.arange(10, 30, 5)\\n\",\n+ \"f = np.arange(0, 2, 0.3) # создаст массив 0..2, с шагом 0.3\\n\",\n+ \"\\n\",\n+ \"print(\\\"i = \\\", i)\\n\",\n+ \"print(\\\"f = \\\", f)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Если использовать шаг как вещественное число, \\n\",\n+ \"то в общем случае нельзя определить точное кол-во елементов (из-за лимитированной точности даблов).\\n\",\n+ \"Для этого есть __np.linspace(from, to, count)__:\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"print(np.linspace(0, 2, 9))\\n\",\n+ \"x = np.linspace(0, 2 * pi, 5)\\n\",\n+ \"print(\\\"x =\\\", x)\\n\",\n+ \"\\n\",\n+ \"\\\"\\\"\\\"\\n\",\n+ \" В numpy можно менять формат вывод на экран, printoptions - функция из utils.py\\n\",\n+ \" после выхода из блока with, все настройки формата вывода сбросятся\\n\",\n+ \" precision - задает точность вывода\\n\",\n+ \" supress - выводит в челевеко читаемом виде, убирает exp, округляет маленькие значения\\n\",\n+ \"\\\"\\\"\\\"\\n\",\n+ \"with printoptions(precision=3, suppress=True): \\n\",\n+ \" print(\\\"sin =\\\", np.sin(x)) # Возьмет sin от каждого элемента массива\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Еще есть __np.logspace(from, to, count, endpoint, base)__ - возвращает числа в диапозоне `[base ** from, base ** to)` равномерно распределенные в логарифмической шкале.<br/>\\n\",\n+ \"```python\\n\",\n+ \"np.logspace(from, to, count, True, 10) == 10 ** np.linspace(from, to, count)\\n\",\n+ \"np.log10(np.logspace(from, to, count, True, 10)) == np.linspace(from, to, count)\\n\",\n+ \"```\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"xs = np.linspace(0.02, 2, 10)\\n\",\n+ \"lnsp = xs\\n\",\n+ \"lgsp = np.logspace(0.02, 2, 10)\\n\",\n+ \"\\n\",\n+ \"\\n\",\n+ \"f, (ax1, ax2) = plt.subplots(1, 2)\\n\",\n+ \"f.set_figheight(5)\\n\",\n+ \"f.set_figwidth(10)\\n\",\n+ \"\\n\",\n+ \"# В линейной шкале\\n\",\n+ \"ax1.set_title('lin scale')\\n\",\n+ \"ax1.grid(True)\\n\",\n+ \"ax1.set_yscale('linear')\\n\",\n+ \"ax1.set_ylim(0, 30)\\n\",\n+ \"\\n\",\n+ \"ax1.plot(xs, lnsp, 'r')\\n\",\n+ \"ax1.plot(xs, lgsp, 'b')\\n\",\n+ \"\\n\",\n+ \"# В логарифмической шкале\\n\",\n+ \"ax2.set_title('log scale')\\n\",\n+ \"ax2.grid(True)\\n\",\n+ \"ax2.set_yscale('log')\\n\",\n+ \" \\n\",\n+ \"ax2.plot(xs, lnsp, 'r')\\n\",\n+ \"ax2.plot(xs, lgsp, 'b')\\n\",\n+ \"\\n\",\n+ \"plt.subplots_adjust(hspace=0.4)\\n\",\n+ \"\\n\",\n+ \"_ = plt.show()\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"# По умолчанию NumPy умеет понимать, что элементов очень много(>1000) и выводит только начало и конец\\n\",\n+ \"print(np.arange(1001))\\n\",\n+ \"\\n\",\n+ \"# чтобы вывести все используйте опцию форматирование threshold = np.inf\\n\",\n+ \"with printoptions(threshold=np.inf):\\n\",\n+ \" print(np.arange(1001))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {},\n+ \"source\": [\n+ \"__np.apply_along_axis(func1d, axis, arr, *args, **kwargs)__ - аналог __map__, применяет __func1d__, к срезке массива __arr__ по оси с номером __axis__ и может передать доп. аргументы __args, kwargs__ в функцию, если треуется. <br/>\\n\",\n+ \"\\n\",\n+ \"Если есть массив __A__, например, с размерностью __[N, M, K, L]__, мы хотим применить __np.sum__ по второй оси (__M__), тогда мы получим массив __B__ с размерностью __[N, K, L]__, у которого __B[i, j, k] = np.sum(A[i, :, j, k]__ <br/>\\n\",\n+ \"\\n\",\n+ \"__numpy.apply_over_axes(func, a, axes)__ - применяет по очереди функцию __func__ к осям __a__ с номерами перечисленным в массиве __axes__, похож на пред. функцию, отличие только, что она сохраняет __shape__ массива и может применить сразу к нескольким.\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(10).reshape(2, 5)\\n\",\n+ \"print(a)\\n\",\n+ \"print()\\n\",\n+ \"print(np.apply_along_axis(np.prod, 0, a)) # np.prod - перемножает элементы в массиве\\n\",\n+ \"print()\\n\",\n+ \"print(np.apply_along_axis(np.prod, 1, a))\\n\",\n+ \"print()\\n\",\n+ \"print(np.apply_over_axes(np.sum, a, [0, 1]))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"# Чуть сложнее пример\\n\",\n+ \"a = np.arange(24).reshape(2,3,4)\\n\",\n+ \"print(a)\\n\",\n+ \"print()\\n\",\n+ \"print(np.apply_over_axes(np.sum, a, [0]))\\n\",\n+ \"print()\\n\",\n+ \"print(np.apply_over_axes(np.sum, a, [0, 2]))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> numpy.random module </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Здесь будут приведены примеры использования данного модуля. Все пояснения в комментариях.\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__np.random.rand(d1, d2, ...)__ - возвращает ndarray с shape = (d1, d2, ...), <br/>\\n\",\n+ \"и заполняет рандомом (float64) от [0, 1) по равномерному распределению\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"np.random.rand(3, 2)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__np.random.randint(low, high=None, size=None)__ - возвращает целый рандом по равномерному распределению <br/>\\n\",\n+ \"в диапозоне [low, high) и с shape = size\\n\",\n+ \"\\n\",\n+ \"для вещественных чисел аналог __np.random.uniform(low, high=None, size=None)__\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"r_val = np.random.randint(10, 20) \\n\",\n+ \"r_val2 = np.random.randint(20) # если high=None, то вернет рандом из [0, low = 20)\\n\",\n+ \"r_val_sh = np.random.randint(7, 20, size=(3, 4)) # ndarray с shape = size, и заполнит его соответственно\\n\",\n+ \"\\n\",\n+ \"print(r_val)\\n\",\n+ \"print(r_val2)\\n\",\n+ \"print(r_val_sh)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__np.random.permutation(x)__ - возвращает новый массив с перемешанными элементами <br/>\\n\",\n+ \"в многомерном случае, перемешивание происходит только по первой координате\\n\",\n+ \" \\n\",\n+ \"__np.random.shuffle(x)__ - тоже самое, только перемешивание происхдит in-place (т.е. меняется сам массив)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = np.arange(12)\\n\",\n+ \"\\n\",\n+ \"print(x)\\n\",\n+ \"print(np.random.permutation(x)) \\n\",\n+ \"\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"y = x.reshape((4, -1)).copy()\\n\",\n+ \"print(y) \\n\",\n+ \"np.random.shuffle(y)\\n\",\n+ \"print(y) \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"# numpy.random.normal(loc=0.0, scale=1.0, size=None)\\n\",\n+ \"\\n\",\n+ \"mu, sigma = 0, 0.1 # Мат. ожидание и дисперсия соответственно\\n\",\n+ \"s = np.random.normal(mu, sigma, 1001) # создает нормально разпределение, как ни странно, с параметрми mu, sigma\\n\",\n+ \"\\n\",\n+ \"print(abs(s.mean() - mu) < sigma ** 2)\\n\",\n+ \"with printoptions(precision=3):\\n\",\n+ \" print(s)\\n\",\n+ \"\\n\",\n+ \"_, bins, _ = plt.hist(s, 30, normed=True)\\n\",\n+ \"f_norm_dist = 1/(sigma * np.sqrt(2 * np.pi)) * np.exp( - (bins - mu)**2 / (2 * sigma**2) )\\n\",\n+ \"plt.plot(bins, f_norm_dist, linewidth=2, color='r')\\n\",\n+ \"plt.show()\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> Базовые операции </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Арифметические операции выполняются поэлементно. \\n\",\n+ \"Создается новый массив и заполняется соответствующими значениями\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.array([20, 30, 40, 50])\\n\",\n+ \"b = np.arange(4)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"print(\\\"a: \\\", a)\\n\",\n+ \"print(\\\"b: \\\", b)\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"print(\\\"a - b : \\\", a - b)\\n\",\n+ \"print(\\\"a * b : \\\", a * b)\\n\",\n+ \"print(\\\"2 * b ** 2: \\\", 2 * b ** 2)\\n\",\n+ \"print(\\\"a < 35 : \\\", a < 35)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"A = np.array( [[1,1],\\n\",\n+ \" [0,1]] )\\n\",\n+ \"\\n\",\n+ \"B = np.array( [[2,0],\\n\",\n+ \" [3,4]] )\\n\",\n+ \"\\n\",\n+ \"print(A * B) # поэлементное перемножение\\n\",\n+ \"print()\\n\",\n+ \"print(A.dot(B)) # привычное перемножение матриц, или = np.dot(A, B)\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"При выполнении операция над массивами разных типов, происходит __upcast__ - т.е. тип липо сохраняется, либо берется наиболее общий\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Выполнение унарных операций над масивом, реализуются как методы класса __ndarray__ (max, min etc)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true,\n+ \"scrolled\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.random.random((2, 3)) # возвращает ndarray заполненный рандомом [0..1], c shape = (2, 3)\\n\",\n+ \"print(a)\\n\",\n+ \"print(a.sum())\\n\",\n+ \"print(a.min())\\n\",\n+ \"print(a.max())\\n\",\n+ \"print(a.argmax()) # возвращает индекс максимаального элемента\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Задание 1:__ Найти угол в градусах, __кратный 10__, такой что, __ln(|sin(a) * cos(a)|)__ максимален (при помощи numpy естественно)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"def task1():\\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" This function should return angle\\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" return 10\\n\",\n+ \"\\n\",\n+ \"check_task1(task1)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> Индексация </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Одномерные мыссивы NumPy позволяют итерирование, взятие срезки и обращение по индексу, также как и обычные массивы (даже чуть больше)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(10) ** 3\\n\",\n+ \"print(\\\"a =\\\", a)\\n\",\n+ \"\\n\",\n+ \"print(a[2])\\n\",\n+ \"print(a[2:5])\\n\",\n+ \"\\n\",\n+ \"a[:6:2] = 7 # a[0:6:2]; всем эллементам на позициях [0, 6) с шагом 2 присвоить 7\\n\",\n+ \"print(a)\\n\",\n+ \"\\n\",\n+ \"print(a[ : :-1]) # перевернутый a\\n\",\n+ \"\\n\",\n+ \"for i in a:\\n\",\n+ \" print(i ** (1 / 3.))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Обращаться к элементам многомерного массива можно перечисляя нужные индексы через запятую, примеры: \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"def f(x,y):\\n\",\n+ \" return 10*x+y\\n\",\n+ \"\\n\",\n+ \"b = np.fromfunction(f, (5, 4), dtype=int) # Создать ndarray размерностью 5 * 4 и генератор для элементов - f\\n\",\n+ \"print(b)\\n\",\n+ \"\\n\",\n+ \"print(b[2, 3]) # = b[2][3]\\n\",\n+ \"\\n\",\n+ \"print(b[0:5, 1]) # = b[ :, 1], взять всю вторую колонку матрицы b\\n\",\n+ \"\\n\",\n+ \"print()\\n\",\n+ \"print(b[1:3, : ]) # взять строчки с [1, 3) = 1, 2\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"print(b[-1]) # взять последнюю строку, когда индексов меньше, то они заменяются на дефолтные значения - `:`\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Можно вставллять __троеточие (...)___, вставляет нужное кол-во (:), когда их не хватает <br/>\\n\",\n+ \"Примеры: пусть `x` имеет ранк(размерности) 5, тогда: <br/>\\n\",\n+ \"\\n\",\n+ \"```text\\n\",\n+ \"x[1,2,...] = x[1,2,:,:,:],\\n\",\n+ \"x[...,3] = x[:,:,:,:,3], \\n\",\n+ \"x[4,...,5,:] = x[4,:,:,5,:].\\n\",\n+ \"```\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.floor(10 * np.random.random((3, 4)))\\n\",\n+ \"b = a.ravel() # вернет одномерный массив из 12 (3 * 4) элементов\\n\",\n+ \"c = a.reshape(3, -1) # -1 в reshape - значит этот параметр посчитается автоматически\\n\",\n+ \"\\n\",\n+ \"print(a)\\n\",\n+ \"print(b)\\n\",\n+ \"print(c)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Два __ndarray__ могут быть сконкатинированны, горизонтально или вертикально. \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.floor(10 * np.random.random((2, 2)))\\n\",\n+ \"print(a, os.linesep) \\n\",\n+ \" \\n\",\n+ \"b = np.floor(10 * np.random.random((2, 2)))\\n\",\n+ \"print(b)\\n\",\n+ \"\\n\",\n+ \"abv = np.vstack((a,b)) # сконкатинировать по вертикали\\n\",\n+ \"abh = np.hstack((a,b)) # по горизонтали\\n\",\n+ \"print()\\n\",\n+ \"print(\\\"ver:\\\", os.linesep, abv)\\n\",\n+ \"\\n\",\n+ \"print()\\n\",\n+ \"print(\\\"hor:\\\", os.linesep, abh)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Либо разбиты по горизонтали или вертикали.\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"vab = np.vsplit(abv, 2)\\n\",\n+ \"print()\\n\",\n+ \"print(\\\"split ver:\\\", os.linesep, vab[0], os.linesep, vab[1])\\n\",\n+ \"\\n\",\n+ \"hab = np.hsplit(abh, 2)\\n\",\n+ \"print()\\n\",\n+ \"print(\\\"split hor:\\\", os.linesep, hab[0], os.linesep, hab[1])\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Делая срезку массива, транспонирование и другие функции создающие `view` не делают копии данных. <br/>\\n\",\n+ \"Чтобы сделать копию используй метод __ndarray.copy()__ \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Несколько примеров продвинутой индексации:__\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(12) ** 2\\n\",\n+ \"print(a, os.linesep)\\n\",\n+ \"\\n\",\n+ \"i = np.array([1,1,3,8,5]) # массив индексов\\n\",\n+ \"print(a[i]) # создаст новый ndarray, взяв элементы из `a` с индексами перечисленными в `i`\\n\",\n+ \"\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"j = np.array([ [3, 4], [9, 7] ]) # двумерный индексы\\n\",\n+ \"print(a[j]) # создаст ndarray, у которого `shape` == j.shape, \\n\",\n+ \" # и заполнит его элементами на соответствующих позициях\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"# Пример двумерных индексов\\n\",\n+ \"\\n\",\n+ \"a = np.arange(12).reshape(3,4)\\n\",\n+ \"\\n\",\n+ \"i = np.array([[0, 1], # Индексы по первой координате\\n\",\n+ \" [1, 2]])\\n\",\n+ \" \\n\",\n+ \"j = np.array([[2, 1], # Индексы по второй координате\\n\",\n+ \" [3, 3]])\\n\",\n+ \"\\n\",\n+ \"print(a)\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, \\\"a[i, j]\\\")\\n\",\n+ \"print(a[i, j]) # i и j должны иметь одинаковый `shape`, создаст матрицу беря элементы с индексами [i, j]\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, \\\"a[i, 2]\\\") # возьмет второй столбец `a`, и создаст из нее массив shape = i.shape, \\n\",\n+ \" # и элементы соответствуют индексам в данном столбце\\n\",\n+ \"print(a[i, 2])\\n\",\n+ \"\\n\",\n+ \"print(os.linesep, \\\"a[:, j]\\\") # выполнит для каждой строки создание матрицы, \\n\",\n+ \"print(a[:, j]) # заполнит элементами с индексами `j` в соответствующей строке\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(5)\\n\",\n+ \"\\n\",\n+ \"# Можно присваивать новые значения соответствующему индексу =) \\n\",\n+ \"a[[1,3,4]] = 536\\n\",\n+ \"a\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(5)\\n\",\n+ \"\\n\",\n+ \"# Если индекс повторяется, то присвоится последнее значение\\n\",\n+ \"a[[0,0,2]] = [1,2,3]\\n\",\n+ \"a\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(5)\\n\",\n+ \"\\n\",\n+ \"# Пример может сделать не то что ты ожидаешь, из-за ограничений питона, что a += 1 <=> a = a + 1\\n\",\n+ \"a[[0,0,2]] += 1\\n\",\n+ \"a\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Еще очень полезная фича - __Булевская индексация__. Применима для фильтрации значений, подходящих под определенное условие\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(10)\\n\",\n+ \"cond = a % 3 == 0 # создаст массив shape = a.shape, dtype = bool, в правильных позициях будет стоять True\\n\",\n+ \"\\n\",\n+ \"good_a = a[cond]\\n\",\n+ \"bad_a = a[~cond]\\n\",\n+ \"\\n\",\n+ \"print(a, os.linesep)\\n\",\n+ \"print(good_a) # = a[a % 3 == 0]\\n\",\n+ \"print(bad_a)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Задание 2:__ Thresholding изображения, вам передают изображение (двумерный массив оттенков серого [0, 256)), и __threshold (t)__, вы должны вернуть изображение, в котором, все значения меньшие данного __t__ обнулить, а значения большие __t__ заменить на 255\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"def task2(img, t):\\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" Returns new thresholding image \\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" return img\\n\",\n+ \"\\n\",\n+ \"check_task2(task2)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> numpy.ma module </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__ma__ - masked array. В некоторых ситуациях имеющийся датасет может быть испорчен по совершенно разным причинам. У нас есть написанный код, который производит различные вычисления, на испорченных данных могут произойти проблемы. Собственно для этого этот модуль и нужен. Мы можем пометить некоторые данные как невалидные и передать их в функцию, не боясь, что их кто-то сможет увидеть или произвести вычисление.\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__True__ - значит данные испорчены. __False__ - данные хорошие. __ma.nomask__ - массив из всех `False`, т.е. все данные хорошие. \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = np.array([1, 2, 3, -1, 5])\\n\",\n+ \"# Валидные все, кроме (-1)\\n\",\n+ \"mx = ma.masked_array(x, mask=[0, 0, 0, 1, 0])\\n\",\n+ \"mx.mean() # посчитает среднее значение, без учета (-1)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"`ma.masked_array` синоним для __MaskedArray__ - подкласс `ndarray`. __Примеры создания:__\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"y = ma.array([1, 2, 3], mask = [0, 1, 0])\\n\",\n+ \"z = ma.masked_equal([1, 2, 3], 2)\\n\",\n+ \"w = ma.masked_less(np.arange(1, 20), 10)\\n\",\n+ \"\\n\",\n+ \"print(\\\"1 and 3 valid :\\\", y)\\n\",\n+ \"print(\\\"2 is invalid :\\\", z)\\n\",\n+ \"print(\\\"<10 are invalid:\\\", w)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__MaskedArray.fill_value__ - значение которым заполнятся невалидные данные, при вызове метода __MaskedArray.filled()__, по умолчанию __fill_value__ = 999999\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"a = np.arange(1, 10)\\n\",\n+ \"y = ma.masked_where(a ** 2 < 30, a) # Помечает невалидными те, которые подходят под условие\\n\",\n+ \"print(y)\\n\",\n+ \"\\n\",\n+ \"y.fill_value = -1\\n\",\n+ \"print(y.filled()) # возвращает ndarray\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = np.array([[1, 2],\\n\",\n+ \" [3, 4]])\\n\",\n+ \"mask = [[0, 0],\\n\",\n+ \" [1, 0]]\\n\",\n+ \"\\n\",\n+ \"mx = ma.array(x, mask=mask)\\n\",\n+ \"print(mx[~mx.mask]) # Так можно забрать все валидные данные\\n\",\n+ \"\\n\",\n+ \"print(mx.compressed()) # compressed - возвращает все валидные данные, всегда в одномрном массиве\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Чтобы обновлять маску советуют присваивать по индексу значение __ma.masked__. <br/>\\n\",\n+ \"Чтобы сделать все элементы помеченными(невалидными) используй __MaskedArray.mask = True__. <br/>\\n\",\n+ \"Чтобы сделать все элементы непомеченными(валидными) используй __MaskedArray.mask = ma.nomask__. <br/>\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"y = ma.array([[1, 2, 3], [4, 5, 6], [7, 8, 9]])\\n\",\n+ \"\\\"\\\"\\\"\\n\",\n+ \"y[(0, 1, 2), (1, 0, 2)] == y[[0, 1, 2], [1, 0, 2]]: \\n\",\n+ \" [0, 1, 2] - индексы по первой координате\\n\",\n+ \" [1, 0, 2] - индексы по второй координате\\n\",\n+ \" т.е. [y[0][1], y[1][0], y[2][2]]\\n\",\n+ \"\\\"\\\"\\\"\\n\",\n+ \"y[(0, 1, 2), (1, 0, 2)] = ma.masked\\n\",\n+ \"print(y)\\n\",\n+ \"\\n\",\n+ \"y[0] = ma.masked\\n\",\n+ \"print(os.linesep, y)\\n\",\n+ \"\\n\",\n+ \"y.mask = True\\n\",\n+ \"print(os.linesep, y)\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Чтобы убрать маску с конкретного значения, нужно просто присвоить ему новое значение. <br/>\\n\",\n+ \"Если стоит __hard mask__ то она не снимется, нужно сначала будет вызвать __soften_mask__, после поменять значения и вызвать __harden_mask__\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.array([1, 2, 3], mask=[0, 0, 1])\\n\",\n+ \"print(x)\\n\",\n+ \"\\n\",\n+ \"x[-1] = 5\\n\",\n+ \"print(x)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.array([1, 2, 3], mask=[0, 0, 1], hard_mask=True)\\n\",\n+ \"print(x)\\n\",\n+ \"\\n\",\n+ \"x[-1] = 5\\n\",\n+ \"print(x)\\n\",\n+ \"\\n\",\n+ \"x.soften_mask()\\n\",\n+ \"x[-1] = 5\\n\",\n+ \"print(x)\\n\",\n+ \"\\n\",\n+ \"x.harden_mask()\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.array([1, 2, 3], mask=[0, 0, 1])\\n\",\n+ \"\\n\",\n+ \"print(x[0])\\n\",\n+ \"print(x[-1])\\n\",\n+ \"print(x[-1] is ma.masked)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"В текущих версиях __numpy.ma__ когда делаешь slicing массива, данные не копируются создается __view__, а маска копируется, чтобы при изменении, не менять ее в родителе. (Однако это поведение __поменяется в будущем__)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.array([1, 2, 3, 4, 5], mask=[0, 1, 0, 0, 1])\\n\",\n+ \"mx = x[:3]\\n\",\n+ \"print(\\\"x: \\\", x)\\n\",\n+ \"print(\\\"mx:\\\", mx)\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"mx[1] = -1\\n\",\n+ \"\\n\",\n+ \"print(\\\"mx: \\\", mx)\\n\",\n+ \"print(\\\"mask:\\\", mx.mask)\\n\",\n+ \"print()\\n\",\n+ \"\\n\",\n+ \"print(\\\"x: \\\", x)\\n\",\n+ \"print(\\\"x.mask:\\\", x.mask)\\n\",\n+ \"print(\\\"x.data:\\\", x.data)\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Не стоит полагаться__ при выполнении различных операций на то, что маскированные элементы не изменятся, они могут измениться - все таки это невалидные данные. <br/>\\n\",\n+ \"`numpy.ma` предоставляет некоторые удобные обертки над унарными, бинарными операциями, такими как - __divide__, __log__ <br/>\\n\",\n+ \"Также __np.log__ etc тоже будет маскировать невалидные данные, если ему передать экземпляр __MaskedArray__\\n\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.log([-1, 0, 1, 2])\\n\",\n+ \"print(x)\\n\",\n+ \"print(x.mask)\\n\",\n+ \"\\n\",\n+ \"x = ma.array([-1, 1, 0, 2, 3], mask=[0, 0, 0, 0, 1])\\n\",\n+ \"xl = np.log(x)\\n\",\n+ \"print(xl)\\n\",\n+ \"print(xl.mask)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"__Задание 3:__ Коррекция изображения. Вам передают изображение (двумерный массив оттенков серого [0, 256)). К сожалению при передачи по сети некоторые значения могли испортиться. Верните изображение, в котором все значение лежащие вне допустимого диапозона заменены на среднее значение по всем __валидным значениям__ (округленное вниз). \"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"# полезная функция ma.masked_outside\\n\",\n+ \"def task3(img):\\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" Должна вернуть измененное изображение\\n\",\n+ \" \\\"\\\"\\\"\\n\",\n+ \" return img\\n\",\n+ \"\\n\",\n+ \"check_task3(task3)\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"code\",\n+ \"execution_count\": null,\n+ \"metadata\": {\n+ \"collapsed\": false,\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"outputs\": [],\n+ \"source\": [\n+ \"x = ma.array([[1, 2], [3, 4]], mask=[[0, 0], [1, 0]])\\n\",\n+ \"type(x.filled(-1))\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"<center> <h2> numpy.linalg - модуль линейной алгебры </h2> </center>\"\n+ ]\n+ },\n+ {\n+ \"cell_type\": \"markdown\",\n+ \"metadata\": {\n+ \"deletable\": true,\n+ \"editable\": true\n+ },\n+ \"source\": [\n+ \"Очень многое из линейки реализовано в этом модуле.\"","path":"24_numpy/Introduction to numpy.ipynb","position":1376,"original_position":1376,"commit_id":"59b3b2a657a3b18084f0ec9eae091382e4a0675b","original_commit_id":"59b3b2a657a3b18084f0ec9eae091382e4a0675b","user":{"login":"sandwwraith","id":11777575,"avatar_url":"https://avatars2.githubusercontent.com/u/11777575?v=3","gravatar_id":"","url":"https://api.github.com/users/sandwwraith","html_url":"https://github.com/sandwwraith","followers_url":"https://api.github.com/users/sandwwraith/followers","following_url":"https://api.github.com/users/sandwwraith/following{/other_user}","gists_url":"https://api.github.com/users/sandwwraith/gists{/gist_id}","starred_url":"https://api.github.com/users/sandwwraith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandwwraith/subscriptions","organizations_url":"https://api.github.com/users/sandwwraith/orgs","repos_url":"https://api.github.com/users/sandwwraith/repos","events_url":"https://api.github.com/users/sandwwraith/events{/privacy}","received_events_url":"https://api.github.com/users/sandwwraith/received_events","type":"User","site_admin":false},"body":"> из линейки\r\n\r\nчто-то я не вижу в этом модуле ничего, что имело бы отношение к Lineage 2. ~(мне тоже не следует заниматься юмором)~\r\n\r\nПовторю из ревью другого конспекта:\r\n\r\n> Не в курилке, блин, болтаем, а пишем более-менее формальный документ","created_at":"2017-03-06T21:58:36Z","updated_at":"2017-03-06T22:04:49Z","html_url":"https://github.com/CT-18/cg/pull/23#discussion_r104534331","pull_request_url":"https://api.github.com/repos/CT-18/cg/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/CT-18/cg/pulls/comments/104534331"},"html":{"href":"https://github.com/CT-18/cg/pull/23#discussion_r104534331"},"pull_request":{"href":"https://api.github.com/repos/CT-18/cg/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/CT-18/cg/pulls/23","id":107908269,"html_url":"https://github.com/CT-18/cg/pull/23","diff_url":"https://github.com/CT-18/cg/pull/23.diff","patch_url":"https://github.com/CT-18/cg/pull/23.patch","issue_url":"https://api.github.com/repos/CT-18/cg/issues/23","number":23,"state":"open","locked":false,"title":"24 numpy","user":{"login":"jon536","id":5980005,"avatar_url":"https://avatars0.githubusercontent.com/u/5980005?v=3","gravatar_id":"","url":"https://api.github.com/users/jon536","html_url":"https://github.com/jon536","followers_url":"https://api.github.com/users/jon536/followers","following_url":"https://api.github.com/users/jon536/following{/other_user}","gists_url":"https://api.github.com/users/jon536/gists{/gist_id}","starred_url":"https://api.github.com/users/jon536/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon536/subscriptions","organizations_url":"https://api.github.com/users/jon536/orgs","repos_url":"https://api.github.com/users/jon536/repos","events_url":"https://api.github.com/users/jon536/events{/privacy}","received_events_url":"https://api.github.com/users/jon536/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-24T21:02:24Z","updated_at":"2017-03-06T22:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12fb8c82ec2b1c0ec4ddc892e15a2100199b9bfb","assignee":{"login":"jon536","id":5980005,"avatar_url":"https://avatars0.githubusercontent.com/u/5980005?v=3","gravatar_id":"","url":"https://api.github.com/users/jon536","html_url":"https://github.com/jon536","followers_url":"https://api.github.com/users/jon536/followers","following_url":"https://api.github.com/users/jon536/following{/other_user}","gists_url":"https://api.github.com/users/jon536/gists{/gist_id}","starred_url":"https://api.github.com/users/jon536/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon536/subscriptions","organizations_url":"https://api.github.com/users/jon536/orgs","repos_url":"https://api.github.com/users/jon536/repos","events_url":"https://api.github.com/users/jon536/events{/privacy}","received_events_url":"https://api.github.com/users/jon536/received_events","type":"User","site_admin":false},"assignees":[{"login":"jon536","id":5980005,"avatar_url":"https://avatars0.githubusercontent.com/u/5980005?v=3","gravatar_id":"","url":"https://api.github.com/users/jon536","html_url":"https://github.com/jon536","followers_url":"https://api.github.com/users/jon536/followers","following_url":"https://api.github.com/users/jon536/following{/other_user}","gists_url":"https://api.github.com/users/jon536/gists{/gist_id}","starred_url":"https://api.github.com/users/jon536/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jon536/subscriptions","organizations_url":"https://api.github.com/users/jon536/orgs","repos_url":"https://api.github.com/users/jon536/repos","events_url":"https://api.github.com/users/jon536/events{/privacy}","received_events_url":"https://api.github.com/users/jon536/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CT-18/cg/pulls/23/commits","review_comments_url":"https://api.github.com/repos/CT-18/cg/pulls/23/comments","review_comment_url":"https://api.github.com/repos/CT-18/cg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CT-18/cg/issues/23/comments","statuses_url":"https://api.github.com/repos/CT-18/cg/statuses/59b3b2a657a3b18084f0ec9eae091382e4a0675b","head":{"label":"CT-18:24_numpy","ref":"24_numpy","sha":"59b3b2a657a3b18084f0ec9eae091382e4a0675b","user":{"login":"CT-18","id":24701901,"avatar_url":"https://avatars2.githubusercontent.com/u/24701901?v=3","gravatar_id":"","url":"https://api.github.com/users/CT-18","html_url":"https://github.com/CT-18","followers_url":"https://api.github.com/users/CT-18/followers","following_url":"https://api.github.com/users/CT-18/following{/other_user}","gists_url":"https://api.github.com/users/CT-18/gists{/gist_id}","starred_url":"https://api.github.com/users/CT-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CT-18/subscriptions","organizations_url":"https://api.github.com/users/CT-18/orgs","repos_url":"https://api.github.com/users/CT-18/repos","events_url":"https://api.github.com/users/CT-18/events{/privacy}","received_events_url":"https://api.github.com/users/CT-18/received_events","type":"Organization","site_admin":false},"repo":{"id":77070568,"name":"cg","full_name":"CT-18/cg","owner":{"login":"CT-18","id":24701901,"avatar_url":"https://avatars2.githubusercontent.com/u/24701901?v=3","gravatar_id":"","url":"https://api.github.com/users/CT-18","html_url":"https://github.com/CT-18","followers_url":"https://api.github.com/users/CT-18/followers","following_url":"https://api.github.com/users/CT-18/following{/other_user}","gists_url":"https://api.github.com/users/CT-18/gists{/gist_id}","starred_url":"https://api.github.com/users/CT-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CT-18/subscriptions","organizations_url":"https://api.github.com/users/CT-18/orgs","repos_url":"https://api.github.com/users/CT-18/repos","events_url":"https://api.github.com/users/CT-18/events{/privacy}","received_events_url":"https://api.github.com/users/CT-18/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CT-18/cg","description":"computational geometry notes","fork":false,"url":"https://api.github.com/repos/CT-18/cg","forks_url":"https://api.github.com/repos/CT-18/cg/forks","keys_url":"https://api.github.com/repos/CT-18/cg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CT-18/cg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CT-18/cg/teams","hooks_url":"https://api.github.com/repos/CT-18/cg/hooks","issue_events_url":"https://api.github.com/repos/CT-18/cg/issues/events{/number}","events_url":"https://api.github.com/repos/CT-18/cg/events","assignees_url":"https://api.github.com/repos/CT-18/cg/assignees{/user}","branches_url":"https://api.github.com/repos/CT-18/cg/branches{/branch}","tags_url":"https://api.github.com/repos/CT-18/cg/tags","blobs_url":"https://api.github.com/repos/CT-18/cg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CT-18/cg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CT-18/cg/git/refs{/sha}","trees_url":"https://api.github.com/repos/CT-18/cg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CT-18/cg/statuses/{sha}","languages_url":"https://api.github.com/repos/CT-18/cg/languages","stargazers_url":"https://api.github.com/repos/CT-18/cg/stargazers","contributors_url":"https://api.github.com/repos/CT-18/cg/contributors","subscribers_url":"https://api.github.com/repos/CT-18/cg/subscribers","subscription_url":"https://api.github.com/repos/CT-18/cg/subscription","commits_url":"https://api.github.com/repos/CT-18/cg/commits{/sha}","git_commits_url":"https://api.github.com/repos/CT-18/cg/git/commits{/sha}","comments_url":"https://api.github.com/repos/CT-18/cg/comments{/number}","issue_comment_url":"https://api.github.com/repos/CT-18/cg/issues/comments{/number}","contents_url":"https://api.github.com/repos/CT-18/cg/contents/{+path}","compare_url":"https://api.github.com/repos/CT-18/cg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CT-18/cg/merges","archive_url":"https://api.github.com/repos/CT-18/cg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CT-18/cg/downloads","issues_url":"https://api.github.com/repos/CT-18/cg/issues{/number}","pulls_url":"https://api.github.com/repos/CT-18/cg/pulls{/number}","milestones_url":"https://api.github.com/repos/CT-18/cg/milestones{/number}","notifications_url":"https://api.github.com/repos/CT-18/cg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CT-18/cg/labels{/name}","releases_url":"https://api.github.com/repos/CT-18/cg/releases{/id}","deployments_url":"https://api.github.com/repos/CT-18/cg/deployments","created_at":"2016-12-21T17:01:30Z","updated_at":"2017-02-24T00:58:44Z","pushed_at":"2017-03-06T19:49:01Z","git_url":"git://github.com/CT-18/cg.git","ssh_url":"git@github.com:CT-18/cg.git","clone_url":"https://github.com/CT-18/cg.git","svn_url":"https://github.com/CT-18/cg","homepage":null,"size":34047,"stargazers_count":4,"watchers_count":4,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":4,"default_branch":"master"}},"base":{"label":"CT-18:master","ref":"master","sha":"835b64143dbe084e9ca5dc9e4a2ff97448837ac1","user":{"login":"CT-18","id":24701901,"avatar_url":"https://avatars2.githubusercontent.com/u/24701901?v=3","gravatar_id":"","url":"https://api.github.com/users/CT-18","html_url":"https://github.com/CT-18","followers_url":"https://api.github.com/users/CT-18/followers","following_url":"https://api.github.com/users/CT-18/following{/other_user}","gists_url":"https://api.github.com/users/CT-18/gists{/gist_id}","starred_url":"https://api.github.com/users/CT-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CT-18/subscriptions","organizations_url":"https://api.github.com/users/CT-18/orgs","repos_url":"https://api.github.com/users/CT-18/repos","events_url":"https://api.github.com/users/CT-18/events{/privacy}","received_events_url":"https://api.github.com/users/CT-18/received_events","type":"Organization","site_admin":false},"repo":{"id":77070568,"name":"cg","full_name":"CT-18/cg","owner":{"login":"CT-18","id":24701901,"avatar_url":"https://avatars2.githubusercontent.com/u/24701901?v=3","gravatar_id":"","url":"https://api.github.com/users/CT-18","html_url":"https://github.com/CT-18","followers_url":"https://api.github.com/users/CT-18/followers","following_url":"https://api.github.com/users/CT-18/following{/other_user}","gists_url":"https://api.github.com/users/CT-18/gists{/gist_id}","starred_url":"https://api.github.com/users/CT-18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CT-18/subscriptions","organizations_url":"https://api.github.com/users/CT-18/orgs","repos_url":"https://api.github.com/users/CT-18/repos","events_url":"https://api.github.com/users/CT-18/events{/privacy}","received_events_url":"https://api.github.com/users/CT-18/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CT-18/cg","description":"computational geometry notes","fork":false,"url":"https://api.github.com/repos/CT-18/cg","forks_url":"https://api.github.com/repos/CT-18/cg/forks","keys_url":"https://api.github.com/repos/CT-18/cg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CT-18/cg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CT-18/cg/teams","hooks_url":"https://api.github.com/repos/CT-18/cg/hooks","issue_events_url":"https://api.github.com/repos/CT-18/cg/issues/events{/number}","events_url":"https://api.github.com/repos/CT-18/cg/events","assignees_url":"https://api.github.com/repos/CT-18/cg/assignees{/user}","branches_url":"https://api.github.com/repos/CT-18/cg/branches{/branch}","tags_url":"https://api.github.com/repos/CT-18/cg/tags","blobs_url":"https://api.github.com/repos/CT-18/cg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CT-18/cg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CT-18/cg/git/refs{/sha}","trees_url":"https://api.github.com/repos/CT-18/cg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CT-18/cg/statuses/{sha}","languages_url":"https://api.github.com/repos/CT-18/cg/languages","stargazers_url":"https://api.github.com/repos/CT-18/cg/stargazers","contributors_url":"https://api.github.com/repos/CT-18/cg/contributors","subscribers_url":"https://api.github.com/repos/CT-18/cg/subscribers","subscription_url":"https://api.github.com/repos/CT-18/cg/subscription","commits_url":"https://api.github.com/repos/CT-18/cg/commits{/sha}","git_commits_url":"https://api.github.com/repos/CT-18/cg/git/commits{/sha}","comments_url":"https://api.github.com/repos/CT-18/cg/comments{/number}","issue_comment_url":"https://api.github.com/repos/CT-18/cg/issues/comments{/number}","contents_url":"https://api.github.com/repos/CT-18/cg/contents/{+path}","compare_url":"https://api.github.com/repos/CT-18/cg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CT-18/cg/merges","archive_url":"https://api.github.com/repos/CT-18/cg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CT-18/cg/downloads","issues_url":"https://api.github.com/repos/CT-18/cg/issues{/number}","pulls_url":"https://api.github.com/repos/CT-18/cg/pulls{/number}","milestones_url":"https://api.github.com/repos/CT-18/cg/milestones{/number}","notifications_url":"https://api.github.com/repos/CT-18/cg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CT-18/cg/labels{/name}","releases_url":"https://api.github.com/repos/CT-18/cg/releases{/id}","deployments_url":"https://api.github.com/repos/CT-18/cg/deployments","created_at":"2016-12-21T17:01:30Z","updated_at":"2017-02-24T00:58:44Z","pushed_at":"2017-03-06T19:49:01Z","git_url":"git://github.com/CT-18/cg.git","ssh_url":"git@github.com:CT-18/cg.git","clone_url":"https://github.com/CT-18/cg.git","svn_url":"https://github.com/CT-18/cg","homepage":null,"size":34047,"stargazers_count":4,"watchers_count":4,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":10,"forks":5,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CT-18/cg/pulls/23"},"html":{"href":"https://github.com/CT-18/cg/pull/23"},"issue":{"href":"https://api.github.com/repos/CT-18/cg/issues/23"},"comments":{"href":"https://api.github.com/repos/CT-18/cg/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/CT-18/cg/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/CT-18/cg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CT-18/cg/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/CT-18/cg/statuses/59b3b2a657a3b18084f0ec9eae091382e4a0675b"}}}}
|
{
"id": 77070568,
"name": "CT-18/cg",
"url": "https://api.github.com/repos/CT-18/cg"
}
|
{
"id": 11777575,
"login": "sandwwraith",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11777575?",
"url": "https://api.github.com/users/sandwwraith"
}
|
{
"id": 24701901,
"login": "CT-18",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24701901?",
"url": "https://api.github.com/orgs/CT-18"
}
| 2017-03-06T21:58:36 |
5443054588
|
{"actor":{"display_login":"sandwwraith"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/comments/143148086","pull_request_review_id":67617194,"id":143148086,"diff_hunk":"@@ -0,0 +1,77 @@\n+#include \"traindetection.h\"\n+\n+void TrainDetection::computeSpeed(time_t coverTimestamp) {\n+ std::cout << \"FUCK SPEED\" << std::endl;\n+}\n+\n+void TrainDetection::computeLength(time_t departionTimestamp) {\n+ std::cout << \"FUCK SPEED\" << std::endl;\n+}\n+\n+bool TrainDetection::step(SensorSide side, EdgeDirection dir, time_t timestamp) {\n+ bool stepped = false;\n+ switch (this->state) {\n+ case C:\n+ if (side != this->side && dir == RISING) {\n+ this->state = CO;\n+ this->computeSpeed(timestamp);\n+ stepped = true;\n+ break;\n+ }\n+// if (side == this->side && dir == FALLING) {","path":"src/cpp/hu.bme.mit.inf.modes3.components.traindetector/traindetector/traindetection.cpp","position":21,"original_position":21,"commit_id":"479393c0d2dc081ff4ab56ad943be9af84e0e63d","original_commit_id":"479393c0d2dc081ff4ab56ad943be9af84e0e63d","user":{"login":"benedekh","id":8940487,"avatar_url":"https://avatars2.githubusercontent.com/u/8940487?v=4","gravatar_id":"","url":"https://api.github.com/users/benedekh","html_url":"https://github.com/benedekh","followers_url":"https://api.github.com/users/benedekh/followers","following_url":"https://api.github.com/users/benedekh/following{/other_user}","gists_url":"https://api.github.com/users/benedekh/gists{/gist_id}","starred_url":"https://api.github.com/users/benedekh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benedekh/subscriptions","organizations_url":"https://api.github.com/users/benedekh/orgs","repos_url":"https://api.github.com/users/benedekh/repos","events_url":"https://api.github.com/users/benedekh/events{/privacy}","received_events_url":"https://api.github.com/users/benedekh/received_events","type":"User","site_admin":false},"body":"Please remove codes in comment from this file.","created_at":"2017-10-06T09:35:15Z","updated_at":"2017-10-06T09:38:37Z","html_url":"https://github.com/FTSRG/BME-MODES3/pull/88#discussion_r143148086","pull_request_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/comments/143148086"},"html":{"href":"https://github.com/FTSRG/BME-MODES3/pull/88#discussion_r143148086"},"pull_request":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88","id":145107258,"html_url":"https://github.com/FTSRG/BME-MODES3/pull/88","diff_url":"https://github.com/FTSRG/BME-MODES3/pull/88.diff","patch_url":"https://github.com/FTSRG/BME-MODES3/pull/88.patch","issue_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/88","number":88,"state":"open","locked":false,"title":"Add traindetector project","user":{"login":"hegyibalint","id":1925779,"avatar_url":"https://avatars0.githubusercontent.com/u/1925779?v=4","gravatar_id":"","url":"https://api.github.com/users/hegyibalint","html_url":"https://github.com/hegyibalint","followers_url":"https://api.github.com/users/hegyibalint/followers","following_url":"https://api.github.com/users/hegyibalint/following{/other_user}","gists_url":"https://api.github.com/users/hegyibalint/gists{/gist_id}","starred_url":"https://api.github.com/users/hegyibalint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hegyibalint/subscriptions","organizations_url":"https://api.github.com/users/hegyibalint/orgs","repos_url":"https://api.github.com/users/hegyibalint/repos","events_url":"https://api.github.com/users/hegyibalint/events{/privacy}","received_events_url":"https://api.github.com/users/hegyibalint/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-06T09:25:35Z","updated_at":"2017-10-06T09:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a54425f02da6b6f2211a5d20bc116c8f21847aae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88/commits","review_comments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88/comments","review_comment_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/88/comments","statuses_url":"https://api.github.com/repos/FTSRG/BME-MODES3/statuses/479393c0d2dc081ff4ab56ad943be9af84e0e63d","head":{"label":"FTSRG:traindetector","ref":"traindetector","sha":"479393c0d2dc081ff4ab56ad943be9af84e0e63d","user":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":43633849,"name":"BME-MODES3","full_name":"FTSRG/BME-MODES3","owner":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/BME-MODES3","description":" Model-based Demonstrator for Smart and Safe Systems","fork":false,"url":"https://api.github.com/repos/FTSRG/BME-MODES3","forks_url":"https://api.github.com/repos/FTSRG/BME-MODES3/forks","keys_url":"https://api.github.com/repos/FTSRG/BME-MODES3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/BME-MODES3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/BME-MODES3/teams","hooks_url":"https://api.github.com/repos/FTSRG/BME-MODES3/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/BME-MODES3/events","assignees_url":"https://api.github.com/repos/FTSRG/BME-MODES3/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/BME-MODES3/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/BME-MODES3/tags","blobs_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/BME-MODES3/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/BME-MODES3/languages","stargazers_url":"https://api.github.com/repos/FTSRG/BME-MODES3/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/BME-MODES3/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/BME-MODES3/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/BME-MODES3/subscription","commits_url":"https://api.github.com/repos/FTSRG/BME-MODES3/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/BME-MODES3/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/BME-MODES3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/BME-MODES3/merges","archive_url":"https://api.github.com/repos/FTSRG/BME-MODES3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/BME-MODES3/downloads","issues_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/BME-MODES3/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/BME-MODES3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/BME-MODES3/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/BME-MODES3/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/deployments","created_at":"2015-10-04T11:15:30Z","updated_at":"2017-01-04T18:11:06Z","pushed_at":"2017-10-06T09:25:36Z","git_url":"git://github.com/FTSRG/BME-MODES3.git","ssh_url":"git@github.com:FTSRG/BME-MODES3.git","clone_url":"https://github.com/FTSRG/BME-MODES3.git","svn_url":"https://github.com/FTSRG/BME-MODES3","homepage":"","size":87020,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":9,"default_branch":"master"}},"base":{"label":"FTSRG:master","ref":"master","sha":"9efb0f723ef7da4117830cfc4434d99b56bbd214","user":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":43633849,"name":"BME-MODES3","full_name":"FTSRG/BME-MODES3","owner":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars1.githubusercontent.com/u/6715687?v=4","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/BME-MODES3","description":" Model-based Demonstrator for Smart and Safe Systems","fork":false,"url":"https://api.github.com/repos/FTSRG/BME-MODES3","forks_url":"https://api.github.com/repos/FTSRG/BME-MODES3/forks","keys_url":"https://api.github.com/repos/FTSRG/BME-MODES3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/BME-MODES3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/BME-MODES3/teams","hooks_url":"https://api.github.com/repos/FTSRG/BME-MODES3/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/BME-MODES3/events","assignees_url":"https://api.github.com/repos/FTSRG/BME-MODES3/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/BME-MODES3/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/BME-MODES3/tags","blobs_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/BME-MODES3/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/BME-MODES3/languages","stargazers_url":"https://api.github.com/repos/FTSRG/BME-MODES3/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/BME-MODES3/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/BME-MODES3/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/BME-MODES3/subscription","commits_url":"https://api.github.com/repos/FTSRG/BME-MODES3/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/BME-MODES3/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/BME-MODES3/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/BME-MODES3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/BME-MODES3/merges","archive_url":"https://api.github.com/repos/FTSRG/BME-MODES3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/BME-MODES3/downloads","issues_url":"https://api.github.com/repos/FTSRG/BME-MODES3/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/BME-MODES3/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/BME-MODES3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/BME-MODES3/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/BME-MODES3/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/BME-MODES3/deployments","created_at":"2015-10-04T11:15:30Z","updated_at":"2017-01-04T18:11:06Z","pushed_at":"2017-10-06T09:25:36Z","git_url":"git://github.com/FTSRG/BME-MODES3.git","ssh_url":"git@github.com:FTSRG/BME-MODES3.git","clone_url":"https://github.com/FTSRG/BME-MODES3.git","svn_url":"https://github.com/FTSRG/BME-MODES3","homepage":"","size":87020,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":19,"forks":4,"open_issues":19,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88"},"html":{"href":"https://github.com/FTSRG/BME-MODES3/pull/88"},"issue":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/88"},"comments":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/FTSRG/BME-MODES3/statuses/479393c0d2dc081ff4ab56ad943be9af84e0e63d"}},"author_association":"MEMBER"}}
|
{
"id": 43633849,
"name": "FTSRG/BME-MODES3",
"url": "https://api.github.com/repos/FTSRG/BME-MODES3"
}
|
{
"id": 8940487,
"login": "benedekh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8940487?",
"url": "https://api.github.com/users/benedekh"
}
|
{
"id": 6715687,
"login": "FTSRG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6715687?",
"url": "https://api.github.com/orgs/FTSRG"
}
| 2017-10-06T09:35:15 |
6682388371
|
{"actor":{"display_login":"benedekh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments/121486978","pull_request_review_id":43519471,"id":121486978,"diff_hunk":"@@ -0,0 +1,65 @@\n+package sre.task\n+\n+import sre.task.Core._\n+import sre.task.Expressions.BExpr\n+\n+object Direction {\n+ sealed trait Value\n+ final case object Out extends Value\n+ final case object In extends Value\n+ final case object Both extends Value\n+\n+ val values: Set[Value] = Set(Out, In, Both)\n+}\n+object Iterators {\n+\n+ class VertexIterator(\n+ private val iterator: Iterator[VertexT]\n+ ) extends Iterator[VertexT] {\n+\n+ def check(assert: BExpr[VertexT]): Iterator[VertexT] =\n+ new VertexIterator(iterator.filter((vertex) => assert(vertex)))\n+\n+ def extend(direction: Direction.Value, label: Option[String]): EdgeIterator = {\n+ val iteratorFromMapVariant = label match {\n+ case Some(label) => (x: scala.collection.Map[String, EdgeT])\n+ => x.get(label).iterator // we can create an iterator out of an Option\n+ case _ => (x: scala.collection.Map[String, EdgeT])\n+ // FIXME: if we don't have any label criteria, we should get all edges, right?","path":"ingraph-engine/ingraph-engine-sre/src/main/scala/sre/task/Task.scala","position":28,"original_position":28,"commit_id":"014bf4e975869d1e584db64012647f5f2c6b55ca","original_commit_id":"014bf4e975869d1e584db64012647f5f2c6b55ca","user":{"login":"szarnyasg","id":1402801,"avatar_url":"https://avatars0.githubusercontent.com/u/1402801?v=3","gravatar_id":"","url":"https://api.github.com/users/szarnyasg","html_url":"https://github.com/szarnyasg","followers_url":"https://api.github.com/users/szarnyasg/followers","following_url":"https://api.github.com/users/szarnyasg/following{/other_user}","gists_url":"https://api.github.com/users/szarnyasg/gists{/gist_id}","starred_url":"https://api.github.com/users/szarnyasg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szarnyasg/subscriptions","organizations_url":"https://api.github.com/users/szarnyasg/orgs","repos_url":"https://api.github.com/users/szarnyasg/repos","events_url":"https://api.github.com/users/szarnyasg/events{/privacy}","received_events_url":"https://api.github.com/users/szarnyasg/received_events","type":"User","site_admin":false},"body":"Yes, the comment is correct","created_at":"2017-06-12T18:14:28Z","updated_at":"2017-06-12T18:14:28Z","html_url":"https://github.com/FTSRG/ingraph/pull/161#discussion_r121486978","pull_request_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/161","_links":{"self":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments/121486978"},"html":{"href":"https://github.com/FTSRG/ingraph/pull/161#discussion_r121486978"},"pull_request":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/161"}}},"pull_request":{"url":"https://api.github.com/repos/FTSRG/ingraph/pulls/161","id":125196566,"html_url":"https://github.com/FTSRG/ingraph/pull/161","diff_url":"https://github.com/FTSRG/ingraph/pull/161.diff","patch_url":"https://github.com/FTSRG/ingraph/pull/161.patch","issue_url":"https://api.github.com/repos/FTSRG/ingraph/issues/161","number":161,"state":"open","locked":false,"title":"Add search based physical execution steps","user":{"login":"szdavid92","id":5807322,"avatar_url":"https://avatars1.githubusercontent.com/u/5807322?v=3","gravatar_id":"","url":"https://api.github.com/users/szdavid92","html_url":"https://github.com/szdavid92","followers_url":"https://api.github.com/users/szdavid92/followers","following_url":"https://api.github.com/users/szdavid92/following{/other_user}","gists_url":"https://api.github.com/users/szdavid92/gists{/gist_id}","starred_url":"https://api.github.com/users/szdavid92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szdavid92/subscriptions","organizations_url":"https://api.github.com/users/szdavid92/orgs","repos_url":"https://api.github.com/users/szdavid92/repos","events_url":"https://api.github.com/users/szdavid92/events{/privacy}","received_events_url":"https://api.github.com/users/szdavid92/received_events","type":"User","site_admin":false},"body":"- [x] Expressions for property checks\r\n- [ ] Basic iterators (vertex/edge)\r\n- [ ] Iterator combinators for trees (multiple HEADS)\r\n- [ ] Find out what else is needed\r\n","created_at":"2017-06-12T18:11:27Z","updated_at":"2017-06-12T18:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfb2fa4522d0f61aad2f068a72573946dcbabbf6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/161/commits","review_comments_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/161/comments","review_comment_url":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/issues/161/comments","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/014bf4e975869d1e584db64012647f5f2c6b55ca","head":{"label":"FTSRG:sre","ref":"sre","sha":"014bf4e975869d1e584db64012647f5f2c6b55ca","user":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars2.githubusercontent.com/u/6715687?v=3","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":56909416,"name":"ingraph","full_name":"FTSRG/ingraph","owner":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars2.githubusercontent.com/u/6715687?v=3","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/ingraph","description":"Incremental evaluation of openCypher queries","fork":false,"url":"https://api.github.com/repos/FTSRG/ingraph","forks_url":"https://api.github.com/repos/FTSRG/ingraph/forks","keys_url":"https://api.github.com/repos/FTSRG/ingraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/ingraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/ingraph/teams","hooks_url":"https://api.github.com/repos/FTSRG/ingraph/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/ingraph/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/ingraph/events","assignees_url":"https://api.github.com/repos/FTSRG/ingraph/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/ingraph/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/ingraph/tags","blobs_url":"https://api.github.com/repos/FTSRG/ingraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/ingraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/ingraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/ingraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/ingraph/languages","stargazers_url":"https://api.github.com/repos/FTSRG/ingraph/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/ingraph/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/ingraph/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/ingraph/subscription","commits_url":"https://api.github.com/repos/FTSRG/ingraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/ingraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/ingraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/ingraph/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/ingraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/ingraph/merges","archive_url":"https://api.github.com/repos/FTSRG/ingraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/ingraph/downloads","issues_url":"https://api.github.com/repos/FTSRG/ingraph/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/ingraph/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/ingraph/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/ingraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/ingraph/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/ingraph/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/ingraph/deployments","created_at":"2016-04-23T08:41:41Z","updated_at":"2017-06-09T16:07:35Z","pushed_at":"2017-06-12T18:11:28Z","git_url":"git://github.com/FTSRG/ingraph.git","ssh_url":"git@github.com:FTSRG/ingraph.git","clone_url":"https://github.com/FTSRG/ingraph.git","svn_url":"https://github.com/FTSRG/ingraph","homepage":"http://docs.inf.mit.bme.hu/ingraph/","size":34993,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":26,"forks":2,"open_issues":26,"watchers":9,"default_branch":"master"}},"base":{"label":"FTSRG:master","ref":"master","sha":"9b4dd12846b232495637978f086c9bc339dd2260","user":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars2.githubusercontent.com/u/6715687?v=3","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"repo":{"id":56909416,"name":"ingraph","full_name":"FTSRG/ingraph","owner":{"login":"FTSRG","id":6715687,"avatar_url":"https://avatars2.githubusercontent.com/u/6715687?v=3","gravatar_id":"","url":"https://api.github.com/users/FTSRG","html_url":"https://github.com/FTSRG","followers_url":"https://api.github.com/users/FTSRG/followers","following_url":"https://api.github.com/users/FTSRG/following{/other_user}","gists_url":"https://api.github.com/users/FTSRG/gists{/gist_id}","starred_url":"https://api.github.com/users/FTSRG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FTSRG/subscriptions","organizations_url":"https://api.github.com/users/FTSRG/orgs","repos_url":"https://api.github.com/users/FTSRG/repos","events_url":"https://api.github.com/users/FTSRG/events{/privacy}","received_events_url":"https://api.github.com/users/FTSRG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FTSRG/ingraph","description":"Incremental evaluation of openCypher queries","fork":false,"url":"https://api.github.com/repos/FTSRG/ingraph","forks_url":"https://api.github.com/repos/FTSRG/ingraph/forks","keys_url":"https://api.github.com/repos/FTSRG/ingraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FTSRG/ingraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FTSRG/ingraph/teams","hooks_url":"https://api.github.com/repos/FTSRG/ingraph/hooks","issue_events_url":"https://api.github.com/repos/FTSRG/ingraph/issues/events{/number}","events_url":"https://api.github.com/repos/FTSRG/ingraph/events","assignees_url":"https://api.github.com/repos/FTSRG/ingraph/assignees{/user}","branches_url":"https://api.github.com/repos/FTSRG/ingraph/branches{/branch}","tags_url":"https://api.github.com/repos/FTSRG/ingraph/tags","blobs_url":"https://api.github.com/repos/FTSRG/ingraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FTSRG/ingraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FTSRG/ingraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/FTSRG/ingraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FTSRG/ingraph/statuses/{sha}","languages_url":"https://api.github.com/repos/FTSRG/ingraph/languages","stargazers_url":"https://api.github.com/repos/FTSRG/ingraph/stargazers","contributors_url":"https://api.github.com/repos/FTSRG/ingraph/contributors","subscribers_url":"https://api.github.com/repos/FTSRG/ingraph/subscribers","subscription_url":"https://api.github.com/repos/FTSRG/ingraph/subscription","commits_url":"https://api.github.com/repos/FTSRG/ingraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/FTSRG/ingraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/FTSRG/ingraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/FTSRG/ingraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/FTSRG/ingraph/contents/{+path}","compare_url":"https://api.github.com/repos/FTSRG/ingraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FTSRG/ingraph/merges","archive_url":"https://api.github.com/repos/FTSRG/ingraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FTSRG/ingraph/downloads","issues_url":"https://api.github.com/repos/FTSRG/ingraph/issues{/number}","pulls_url":"https://api.github.com/repos/FTSRG/ingraph/pulls{/number}","milestones_url":"https://api.github.com/repos/FTSRG/ingraph/milestones{/number}","notifications_url":"https://api.github.com/repos/FTSRG/ingraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FTSRG/ingraph/labels{/name}","releases_url":"https://api.github.com/repos/FTSRG/ingraph/releases{/id}","deployments_url":"https://api.github.com/repos/FTSRG/ingraph/deployments","created_at":"2016-04-23T08:41:41Z","updated_at":"2017-06-09T16:07:35Z","pushed_at":"2017-06-12T18:11:28Z","git_url":"git://github.com/FTSRG/ingraph.git","ssh_url":"git@github.com:FTSRG/ingraph.git","clone_url":"https://github.com/FTSRG/ingraph.git","svn_url":"https://github.com/FTSRG/ingraph","homepage":"http://docs.inf.mit.bme.hu/ingraph/","size":34993,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":26,"forks":2,"open_issues":26,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/161"},"html":{"href":"https://github.com/FTSRG/ingraph/pull/161"},"issue":{"href":"https://api.github.com/repos/FTSRG/ingraph/issues/161"},"comments":{"href":"https://api.github.com/repos/FTSRG/ingraph/issues/161/comments"},"review_comments":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/161/comments"},"review_comment":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FTSRG/ingraph/pulls/161/commits"},"statuses":{"href":"https://api.github.com/repos/FTSRG/ingraph/statuses/014bf4e975869d1e584db64012647f5f2c6b55ca"}}}}
|
{
"id": 56909416,
"name": "FTSRG/ingraph",
"url": "https://api.github.com/repos/FTSRG/ingraph"
}
|
{
"id": 1402801,
"login": "szarnyasg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1402801?",
"url": "https://api.github.com/users/szarnyasg"
}
|
{
"id": 6715687,
"login": "FTSRG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6715687?",
"url": "https://api.github.com/orgs/FTSRG"
}
| 2017-06-12T18:14:28 |
6049211831
|
{"actor":{"display_login":"szarnyasg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/comments/152669629","pull_request_review_id":78567832,"id":152669629,"diff_hunk":"@@ -12,73 +12,78 @@ var ASYNC_RESPONSE_REGEX = /^(5[0-9]{2} )/;\n function ResponseHandler(clientSocket) {\n var destroyed = false;\n var notifier = new events.EventEmitter();\n- var buffer = \"\";\n- var nextResponseIsMultiline = false;\n- \n- function isBufferComplete() {\n- var lines = buffer.split(\"\\r\\n\");\n- // there will always be an empty element at the end as every line will always end in \"\\r\\n\"\n- // so remove it.\n- // i.e. \"1\\r\\n2\\r\\n\" => [\"1\", \"2\", \"\"]\n- lines.pop();\n- if (lines.length === 1) {\n- var asyncResponse = ASYNC_RESPONSE_REGEX.exec(lines[0]);\n- if (!asyncResponse) {\n- if (nextResponseIsMultiline) {\n- logger.debug('Assuming buffer is not complete because nextResponseIsMultiline flag is set.');\n- nextResponseIsMultiline = false;\n- return false;\n- }\n- }\n- // is it a single line response?\n- return lines[0].indexOf(\":\") !== lines[0].length-1;\n- } \n- // multi line response so waiting for a blank line to signify end\n- return lines[lines.length-1] === \"\";\n+ var buffer = [];\n+\n+ function isRespComplete() {\n+ let complete = false;\n+\n+ if (buffer.length === 1) {\n+ // a single line response\n+ // single line response first line should never ends with \":\" and\n+ // 1XX and 200 is always single line response\n+ complete = buffer[0].search(/^1\\d\\d\\s|200\\sok$/) === 0 && buffer[0].endsWith(':') === false;","path":"src/hyperdeck/response-handler.js","position":36,"original_position":36,"commit_id":"20ae8564cd63dbcdf1ef0550e257d714f8043cf3","original_commit_id":"20ae8564cd63dbcdf1ef0550e257d714f8043cf3","user":{"login":"tjenkinson","id":3259993,"avatar_url":"https://avatars0.githubusercontent.com/u/3259993?v=4","gravatar_id":"","url":"https://api.github.com/users/tjenkinson","html_url":"https://github.com/tjenkinson","followers_url":"https://api.github.com/users/tjenkinson/followers","following_url":"https://api.github.com/users/tjenkinson/following{/other_user}","gists_url":"https://api.github.com/users/tjenkinson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjenkinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjenkinson/subscriptions","organizations_url":"https://api.github.com/users/tjenkinson/orgs","repos_url":"https://api.github.com/users/tjenkinson/repos","events_url":"https://api.github.com/users/tjenkinson/events{/privacy}","received_events_url":"https://api.github.com/users/tjenkinson/received_events","type":"User","site_admin":false},"body":"We could do this in one regex instead (which we should put a the top of the file so it is cached).\r\n\r\n```javascript\r\nvar SINGLE_LINE_REGEX = /^(?:1\\d{2}|200) .*?[^\\:]$/;\r\n```\r\n\r\nand do\r\n```javascript\r\nif (SINGLE_LINE_REGEX.test(buffer[0])) {\r\n return true;\r\n}\r\n```","created_at":"2017-11-22T20:15:32Z","updated_at":"2017-11-22T20:44:02Z","html_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46#discussion_r152669629","pull_request_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/comments/152669629"},"html":{"href":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46#discussion_r152669629"},"pull_request":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46"}}},"pull_request":{"url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46","id":154078758,"html_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46","diff_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46.diff","patch_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46.patch","issue_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/46","number":46,"state":"open","locked":false,"title":"#44 Fix","user":{"login":"sarveshwar-singh","id":19986226,"avatar_url":"https://avatars1.githubusercontent.com/u/19986226?v=4","gravatar_id":"","url":"https://api.github.com/users/sarveshwar-singh","html_url":"https://github.com/sarveshwar-singh","followers_url":"https://api.github.com/users/sarveshwar-singh/followers","following_url":"https://api.github.com/users/sarveshwar-singh/following{/other_user}","gists_url":"https://api.github.com/users/sarveshwar-singh/gists{/gist_id}","starred_url":"https://api.github.com/users/sarveshwar-singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarveshwar-singh/subscriptions","organizations_url":"https://api.github.com/users/sarveshwar-singh/orgs","repos_url":"https://api.github.com/users/sarveshwar-singh/repos","events_url":"https://api.github.com/users/sarveshwar-singh/events{/privacy}","received_events_url":"https://api.github.com/users/sarveshwar-singh/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-22T07:16:38Z","updated_at":"2017-11-22T20:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46/commits","review_comments_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46/comments","review_comment_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/46/comments","statuses_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/statuses/20ae8564cd63dbcdf1ef0550e257d714f8043cf3","head":{"label":"sarveshwar-singh:handle-multiple-responses-from-socket-in-same-data-event","ref":"handle-multiple-responses-from-socket-in-same-data-event","sha":"20ae8564cd63dbcdf1ef0550e257d714f8043cf3","user":{"login":"sarveshwar-singh","id":19986226,"avatar_url":"https://avatars1.githubusercontent.com/u/19986226?v=4","gravatar_id":"","url":"https://api.github.com/users/sarveshwar-singh","html_url":"https://github.com/sarveshwar-singh","followers_url":"https://api.github.com/users/sarveshwar-singh/followers","following_url":"https://api.github.com/users/sarveshwar-singh/following{/other_user}","gists_url":"https://api.github.com/users/sarveshwar-singh/gists{/gist_id}","starred_url":"https://api.github.com/users/sarveshwar-singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarveshwar-singh/subscriptions","organizations_url":"https://api.github.com/users/sarveshwar-singh/orgs","repos_url":"https://api.github.com/users/sarveshwar-singh/repos","events_url":"https://api.github.com/users/sarveshwar-singh/events{/privacy}","received_events_url":"https://api.github.com/users/sarveshwar-singh/received_events","type":"User","site_admin":false},"repo":{"id":111061623,"name":"Hyperdeck-JS-Lib","full_name":"sarveshwar-singh/Hyperdeck-JS-Lib","owner":{"login":"sarveshwar-singh","id":19986226,"avatar_url":"https://avatars1.githubusercontent.com/u/19986226?v=4","gravatar_id":"","url":"https://api.github.com/users/sarveshwar-singh","html_url":"https://github.com/sarveshwar-singh","followers_url":"https://api.github.com/users/sarveshwar-singh/followers","following_url":"https://api.github.com/users/sarveshwar-singh/following{/other_user}","gists_url":"https://api.github.com/users/sarveshwar-singh/gists{/gist_id}","starred_url":"https://api.github.com/users/sarveshwar-singh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarveshwar-singh/subscriptions","organizations_url":"https://api.github.com/users/sarveshwar-singh/orgs","repos_url":"https://api.github.com/users/sarveshwar-singh/repos","events_url":"https://api.github.com/users/sarveshwar-singh/events{/privacy}","received_events_url":"https://api.github.com/users/sarveshwar-singh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarveshwar-singh/Hyperdeck-JS-Lib","description":"A javascript library for communication with the Blackmagic Hyperdeck.","fork":true,"url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib","forks_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/forks","keys_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/teams","hooks_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/hooks","issue_events_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/issues/events{/number}","events_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/events","assignees_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/assignees{/user}","branches_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/branches{/branch}","tags_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/tags","blobs_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/statuses/{sha}","languages_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/languages","stargazers_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/stargazers","contributors_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/contributors","subscribers_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/subscribers","subscription_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/subscription","commits_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/contents/{+path}","compare_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/merges","archive_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/downloads","issues_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/issues{/number}","pulls_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/pulls{/number}","milestones_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/milestones{/number}","notifications_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/labels{/name}","releases_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/releases{/id}","deployments_url":"https://api.github.com/repos/sarveshwar-singh/Hyperdeck-JS-Lib/deployments","created_at":"2017-11-17T05:24:04Z","updated_at":"2017-11-17T05:24:05Z","pushed_at":"2017-11-22T07:22:34Z","git_url":"git://github.com/sarveshwar-singh/Hyperdeck-JS-Lib.git","ssh_url":"git@github.com:sarveshwar-singh/Hyperdeck-JS-Lib.git","clone_url":"https://github.com/sarveshwar-singh/Hyperdeck-JS-Lib.git","svn_url":"https://github.com/sarveshwar-singh/Hyperdeck-JS-Lib","homepage":null,"size":8404,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LA1TV:handle-multiple-responses-from-socket-in-same-data-event","ref":"handle-multiple-responses-from-socket-in-same-data-event","sha":"ee61a27973a22b0cd649bb7930808fc04c9a970e","user":{"login":"LA1TV","id":5175258,"avatar_url":"https://avatars1.githubusercontent.com/u/5175258?v=4","gravatar_id":"","url":"https://api.github.com/users/LA1TV","html_url":"https://github.com/LA1TV","followers_url":"https://api.github.com/users/LA1TV/followers","following_url":"https://api.github.com/users/LA1TV/following{/other_user}","gists_url":"https://api.github.com/users/LA1TV/gists{/gist_id}","starred_url":"https://api.github.com/users/LA1TV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LA1TV/subscriptions","organizations_url":"https://api.github.com/users/LA1TV/orgs","repos_url":"https://api.github.com/users/LA1TV/repos","events_url":"https://api.github.com/users/LA1TV/events{/privacy}","received_events_url":"https://api.github.com/users/LA1TV/received_events","type":"Organization","site_admin":false},"repo":{"id":54552519,"name":"Hyperdeck-JS-Lib","full_name":"LA1TV/Hyperdeck-JS-Lib","owner":{"login":"LA1TV","id":5175258,"avatar_url":"https://avatars1.githubusercontent.com/u/5175258?v=4","gravatar_id":"","url":"https://api.github.com/users/LA1TV","html_url":"https://github.com/LA1TV","followers_url":"https://api.github.com/users/LA1TV/followers","following_url":"https://api.github.com/users/LA1TV/following{/other_user}","gists_url":"https://api.github.com/users/LA1TV/gists{/gist_id}","starred_url":"https://api.github.com/users/LA1TV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LA1TV/subscriptions","organizations_url":"https://api.github.com/users/LA1TV/orgs","repos_url":"https://api.github.com/users/LA1TV/repos","events_url":"https://api.github.com/users/LA1TV/events{/privacy}","received_events_url":"https://api.github.com/users/LA1TV/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib","description":"A javascript library for communication with the Blackmagic Hyperdeck.","fork":false,"url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib","forks_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/forks","keys_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/teams","hooks_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/hooks","issue_events_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/events{/number}","events_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/events","assignees_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/assignees{/user}","branches_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/branches{/branch}","tags_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/tags","blobs_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/git/refs{/sha}","trees_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/statuses/{sha}","languages_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/languages","stargazers_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/stargazers","contributors_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/contributors","subscribers_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/subscribers","subscription_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/subscription","commits_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/commits{/sha}","git_commits_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/git/commits{/sha}","comments_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/comments{/number}","issue_comment_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/comments{/number}","contents_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/contents/{+path}","compare_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/merges","archive_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/downloads","issues_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues{/number}","pulls_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls{/number}","milestones_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/milestones{/number}","notifications_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/labels{/name}","releases_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/releases{/id}","deployments_url":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/deployments","created_at":"2016-03-23T10:52:42Z","updated_at":"2017-02-07T12:14:05Z","pushed_at":"2017-11-22T07:22:35Z","git_url":"git://github.com/LA1TV/Hyperdeck-JS-Lib.git","ssh_url":"git@github.com:LA1TV/Hyperdeck-JS-Lib.git","clone_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib.git","svn_url":"https://github.com/LA1TV/Hyperdeck-JS-Lib","homepage":null,"size":8399,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46"},"html":{"href":"https://github.com/LA1TV/Hyperdeck-JS-Lib/pull/46"},"issue":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/46"},"comments":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib/statuses/20ae8564cd63dbcdf1ef0550e257d714f8043cf3"}},"author_association":"NONE"}}
|
{
"id": 54552519,
"name": "LA1TV/Hyperdeck-JS-Lib",
"url": "https://api.github.com/repos/LA1TV/Hyperdeck-JS-Lib"
}
|
{
"id": 3259993,
"login": "tjenkinson",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3259993?",
"url": "https://api.github.com/users/tjenkinson"
}
|
{
"id": 5175258,
"login": "LA1TV",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5175258?",
"url": "https://api.github.com/orgs/LA1TV"
}
| 2017-11-22T20:15:32 |
6892366100
|
{"actor":{"display_login":"tjenkinson"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/138127882","pull_request_review_id":61884102,"id":138127882,"diff_hunk":"@@ -0,0 +1,134 @@\n+{ config, pkgs, lib, ... }:\n+\n+with lib;\n+\n+let\n+ cfg = config.services.prometheus.collectdExporter;\n+\n+ collectSettingsArgs = if (cfg.collectdBinary.enable) then ''\n+ -collectd.listen-address ${optionalString (cfg.collectdBinary.listenAddress != null) cfg.collectdBinary.listenAddress}:${toString cfg.collectdBinary.port} \\\n+ -collectd.security-level ${cfg.collectdBinary.securityLevel} \\\n+ '' else \"\";\n+\n+in {\n+ options = {\n+ services.prometheus.collectdExporter = {\n+ enable = mkEnableOption \"prometheus collectd exporter\";\n+\n+ port = mkOption {\n+ type = types.int;\n+ default = 9103;\n+ description = ''\n+ Port to listen on.\n+ This is used for scraping as well as the to receive collectd data via the write_http plugin.\n+ '';\n+ };\n+\n+ listenAddress = mkOption {\n+ type = types.nullOr types.str;\n+ default = null;\n+ example = \"0.0.0.0\";\n+ description = ''\n+ Address to listen on for web interface, telemetry and collectd JSON data.\n+ '';\n+ };\n+\n+ collectdBinary = mkOption {\n+ description = ''\n+ Configure collection via the collectd binary network protocol.\n+ '';\n+ type = (types.submodule {\n+ options = {\n+ enable = mkEnableOption \"collectd binary protocol receiver\";\n+\n+ authFile = mkOption {\n+ default = null;\n+ type = types.nullOr types.path;\n+ description = \"File mapping user names to pre-shared keys (passwords).\";\n+ };\n+\n+ port = mkOption {\n+ type = types.int;\n+ default = 25826;\n+ description = ''Network address on which to accept collectd binary network packets.'';\n+ };\n+\n+ listenAddress = mkOption {\n+ type = types.nullOr types.str;\n+ default = null;\n+ example = \"0.0.0.0\";\n+ description = ''\n+ Address to listen on for binary network packets.\n+ '';\n+ };\n+\n+ securityLevel = mkOption {\n+ type = types.enum [\"None\" \"Sign\" \"Encrypt\"];\n+ default = \"None\";\n+ description = ''\n+ Minimum required security level for accepted packets.\n+ '';\n+ };\n+ };\n+ });\n+ };\n+\n+ extraFlags = mkOption {\n+ type = types.listOf types.str;\n+ default = [];\n+ description = ''\n+ Extra commandline options when launching the collectd exporter.\n+ '';\n+ };\n+\n+ logFormat = mkOption {\n+ type = types.str;\n+ default = \"logger:stderr\";\n+ example = \"logger:syslog?appname=bob&local=7 or logger:stdout?json=true\";\n+ description = ''\n+ Set the log target and format.\n+ '';\n+ };\n+\n+ logLevel = mkOption {\n+ type = types.enum [\"debug\" \"info\" \"warn\" \"error\" \"fatal\"];\n+ default = \"info\";\n+ description = ''\n+ Only log messages with the given severity or above.\n+ '';\n+ };\n+\n+ openFirewall = mkOption {\n+ type = types.bool;\n+ default = false;\n+ description = ''\n+ Open port in firewall for incoming connections.\n+ '';\n+ };\n+ };\n+ };\n+\n+ config = mkIf cfg.enable {\n+ networking.firewall.allowedTCPPorts = (optional cfg.openFirewall cfg.port) ++ (optional (cfg.openFirewall && cfg.collectdBinary.enable) cfg.collectdBinary.port);\n+\n+ systemd.services.prometheus-collectd-exporter = {\n+ description = \"Prometheus exporter for Collectd metrics\";\n+ unitConfig.Documentation = \"https://github.com/prometheus/collectd_exporter\";\n+ wantedBy = [ \"multi-user.target\" ];\n+ serviceConfig = {\n+ User = \"nobody\";","path":"nixos/modules/services/monitoring/prometheus/collectd-exporter.nix","position":119,"original_position":119,"commit_id":"ae442605f1f35f6ad808606fb563c565a26c7d37","original_commit_id":"ae442605f1f35f6ad808606fb563c565a26c7d37","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars1.githubusercontent.com/u/333807?v=4","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"body":"I didn't know about that. I just copied it from the other collectors. A quick tests shows it seems to work. I updated the PR accordingly.","created_at":"2017-09-11T16:51:34Z","updated_at":"2017-09-11T16:51:34Z","html_url":"https://github.com/NixOS/nixpkgs/pull/29212#discussion_r138127882","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/138127882"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29212#discussion_r138127882"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212"}},"in_reply_to_id":138126526},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212","id":140214381,"html_url":"https://github.com/NixOS/nixpkgs/pull/29212","diff_url":"https://github.com/NixOS/nixpkgs/pull/29212.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/29212.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29212","number":29212,"state":"open","locked":false,"title":"prometheus-collectd-exporter service: init module","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars1.githubusercontent.com/u/333807?v=4","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nAllow easy configuration of the collectd exporter\r\n\r\nSupports JSON and binary (optional) protocol\r\nof collectd.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [x] NixOS\r\n - [ ] macOS\r\n - [ ] Linux\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-09-10T16:06:30Z","updated_at":"2017-09-11T16:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e7663bcbffeb0a52425e4e2297d5db205ee77a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29212/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ae442605f1f35f6ad808606fb563c565a26c7d37","head":{"label":"bachp:prometheus-collectd","ref":"prometheus-collectd","sha":"ae442605f1f35f6ad808606fb563c565a26c7d37","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars1.githubusercontent.com/u/333807?v=4","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"repo":{"id":68442977,"name":"nixpkgs","full_name":"bachp/nixpkgs","owner":{"login":"bachp","id":333807,"avatar_url":"https://avatars1.githubusercontent.com/u/333807?v=4","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bachp/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bachp/nixpkgs","forks_url":"https://api.github.com/repos/bachp/nixpkgs/forks","keys_url":"https://api.github.com/repos/bachp/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bachp/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bachp/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bachp/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bachp/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bachp/nixpkgs/events","assignees_url":"https://api.github.com/repos/bachp/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bachp/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bachp/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bachp/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bachp/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bachp/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bachp/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bachp/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bachp/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bachp/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bachp/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bachp/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bachp/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bachp/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bachp/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bachp/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bachp/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bachp/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bachp/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bachp/nixpkgs/merges","archive_url":"https://api.github.com/repos/bachp/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bachp/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bachp/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bachp/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bachp/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bachp/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bachp/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bachp/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bachp/nixpkgs/deployments","created_at":"2016-09-17T09:17:09Z","updated_at":"2016-09-17T09:17:31Z","pushed_at":"2017-09-11T16:39:01Z","git_url":"git://github.com/bachp/nixpkgs.git","ssh_url":"git@github.com:bachp/nixpkgs.git","clone_url":"https://github.com/bachp/nixpkgs.git","svn_url":"https://github.com/bachp/nixpkgs","homepage":null,"size":556516,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"949cfe2daed867621b21d027362246157a5e2b07","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-09-11T11:06:30Z","pushed_at":"2017-09-11T16:50:48Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":574396,"stargazers_count":1860,"watchers_count":1860,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2227,"mirror_url":null,"open_issues_count":2306,"forks":2227,"open_issues":2306,"watchers":1860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29212"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29212"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29212/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29212/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ae442605f1f35f6ad808606fb563c565a26c7d37"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
}
|
{
"id": 333807,
"login": "bachp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/333807?",
"url": "https://api.github.com/users/bachp"
}
|
{
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
}
| 2017-09-11T16:51:34 |
6575662325
|
{"actor":{"display_login":"bachp"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/140964673","pull_request_review_id":65103120,"id":140964673,"diff_hunk":"@@ -0,0 +1,20 @@\n+{ fetchFromGitHub, buildPerlPackage, stdenv, perl }:\n+\n+buildPerlPackage rec {\n+ name = \"MNI-Perllib-0.08\";","path":"pkgs/development/perl-modules/MNI/default.nix","position":4,"original_position":4,"commit_id":"b55216d721fd945d44fc87a70004b7ef4dc1b6ac","original_commit_id":"b55216d721fd945d44fc87a70004b7ef4dc1b6ac","user":{"login":"vyp","id":3889405,"avatar_url":"https://avatars2.githubusercontent.com/u/3889405?v=4","gravatar_id":"","url":"https://api.github.com/users/vyp","html_url":"https://github.com/vyp","followers_url":"https://api.github.com/users/vyp/followers","following_url":"https://api.github.com/users/vyp/following{/other_user}","gists_url":"https://api.github.com/users/vyp/gists{/gist_id}","starred_url":"https://api.github.com/users/vyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyp/subscriptions","organizations_url":"https://api.github.com/users/vyp/orgs","repos_url":"https://api.github.com/users/vyp/repos","events_url":"https://api.github.com/users/vyp/events{/privacy}","received_events_url":"https://api.github.com/users/vyp/received_events","type":"User","site_admin":false},"body":"Where did you get this version number?","created_at":"2017-09-26T06:10:56Z","updated_at":"2017-09-26T06:25:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/29782#discussion_r140964673","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/140964673"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29782#discussion_r140964673"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782","id":142964620,"html_url":"https://github.com/NixOS/nixpkgs/pull/29782","diff_url":"https://github.com/NixOS/nixpkgs/pull/29782.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/29782.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29782","number":29782,"state":"open","locked":false,"title":"several MINC additions/updates in separate commits: libminc, minc-tools, minc-widgets, N3, inormalize, EBTKS, mni_autoreg, and some Perl modules","user":{"login":"bcdarwin","id":164148,"avatar_url":"https://avatars2.githubusercontent.com/u/164148?v=4","gravatar_id":"","url":"https://api.github.com/users/bcdarwin","html_url":"https://github.com/bcdarwin","followers_url":"https://api.github.com/users/bcdarwin/followers","following_url":"https://api.github.com/users/bcdarwin/following{/other_user}","gists_url":"https://api.github.com/users/bcdarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/bcdarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcdarwin/subscriptions","organizations_url":"https://api.github.com/users/bcdarwin/orgs","repos_url":"https://api.github.com/users/bcdarwin/repos","events_url":"https://api.github.com/users/bcdarwin/events{/privacy}","received_events_url":"https://api.github.com/users/bcdarwin/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n - [x] NixOS\r\n - [ ] macOS\r\n - [x] Linux\r\n- [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [NA] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-09-25T19:29:05Z","updated_at":"2017-09-26T06:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abec0e6a28d51a0dda9d61990b7fbfe21eea63cf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/29782/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b55216d721fd945d44fc87a70004b7ef4dc1b6ac","head":{"label":"bcdarwin:mni-autoreg","ref":"mni-autoreg","sha":"b55216d721fd945d44fc87a70004b7ef4dc1b6ac","user":{"login":"bcdarwin","id":164148,"avatar_url":"https://avatars2.githubusercontent.com/u/164148?v=4","gravatar_id":"","url":"https://api.github.com/users/bcdarwin","html_url":"https://github.com/bcdarwin","followers_url":"https://api.github.com/users/bcdarwin/followers","following_url":"https://api.github.com/users/bcdarwin/following{/other_user}","gists_url":"https://api.github.com/users/bcdarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/bcdarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcdarwin/subscriptions","organizations_url":"https://api.github.com/users/bcdarwin/orgs","repos_url":"https://api.github.com/users/bcdarwin/repos","events_url":"https://api.github.com/users/bcdarwin/events{/privacy}","received_events_url":"https://api.github.com/users/bcdarwin/received_events","type":"User","site_admin":false},"repo":{"id":31118521,"name":"nixpkgs","full_name":"bcdarwin/nixpkgs","owner":{"login":"bcdarwin","id":164148,"avatar_url":"https://avatars2.githubusercontent.com/u/164148?v=4","gravatar_id":"","url":"https://api.github.com/users/bcdarwin","html_url":"https://github.com/bcdarwin","followers_url":"https://api.github.com/users/bcdarwin/followers","following_url":"https://api.github.com/users/bcdarwin/following{/other_user}","gists_url":"https://api.github.com/users/bcdarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/bcdarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcdarwin/subscriptions","organizations_url":"https://api.github.com/users/bcdarwin/orgs","repos_url":"https://api.github.com/users/bcdarwin/repos","events_url":"https://api.github.com/users/bcdarwin/events{/privacy}","received_events_url":"https://api.github.com/users/bcdarwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcdarwin/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bcdarwin/nixpkgs","forks_url":"https://api.github.com/repos/bcdarwin/nixpkgs/forks","keys_url":"https://api.github.com/repos/bcdarwin/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcdarwin/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcdarwin/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bcdarwin/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bcdarwin/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bcdarwin/nixpkgs/events","assignees_url":"https://api.github.com/repos/bcdarwin/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bcdarwin/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bcdarwin/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bcdarwin/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcdarwin/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcdarwin/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcdarwin/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcdarwin/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bcdarwin/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bcdarwin/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bcdarwin/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bcdarwin/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bcdarwin/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bcdarwin/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcdarwin/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcdarwin/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcdarwin/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcdarwin/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bcdarwin/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcdarwin/nixpkgs/merges","archive_url":"https://api.github.com/repos/bcdarwin/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcdarwin/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bcdarwin/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bcdarwin/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bcdarwin/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bcdarwin/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcdarwin/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bcdarwin/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bcdarwin/nixpkgs/deployments","created_at":"2015-02-21T07:27:33Z","updated_at":"2015-02-21T07:31:08Z","pushed_at":"2017-09-25T18:23:24Z","git_url":"git://github.com/bcdarwin/nixpkgs.git","ssh_url":"git@github.com:bcdarwin/nixpkgs.git","clone_url":"https://github.com/bcdarwin/nixpkgs.git","svn_url":"https://github.com/bcdarwin/nixpkgs","homepage":null,"size":551585,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"8ccce8de891923b40b897c11f9a494c6b3722a58","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-09-26T03:22:46Z","pushed_at":"2017-09-26T06:25:25Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":594000,"stargazers_count":1895,"watchers_count":1895,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2249,"mirror_url":null,"open_issues_count":2350,"forks":2249,"open_issues":2350,"watchers":1895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/29782"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29782"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/29782/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/29782/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/b55216d721fd945d44fc87a70004b7ef4dc1b6ac"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 4542716,
"name": "NixOS/nixpkgs",
"url": "https://api.github.com/repos/NixOS/nixpkgs"
}
|
{
"id": 3889405,
"login": "vyp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3889405?",
"url": "https://api.github.com/users/vyp"
}
|
{
"id": 487568,
"login": "NixOS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487568?",
"url": "https://api.github.com/orgs/NixOS"
}
| 2017-09-26T06:10:56 |
6636583022
|
{"actor":{"display_login":"vyp"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/comments/141532022","pull_request_review_id":65758499,"id":141532022,"diff_hunk":"@@ -0,0 +1,42 @@\n+<?php\n+\n+namespace YoastSeoForTypo3\\YoastSeo\\ViewHelpers;\n+\n+use TYPO3\\CMS\\Fluid\\Core\\ViewHelper\\AbstractViewHelper;\n+\n+/**\n+ * Class KeyValueViewHelper\n+ *\n+ * @package YoastSeoForTypo3\\YoastSeo\\ViewHelpers\n+ */\n+class KeyValueViewHelper extends AbstractViewHelper\n+{\n+","path":"Classes/ViewHelpers/KeyValueViewHelper.php","position":12,"original_position":14,"commit_id":"a16b05da450b5317fd435a4a930e92f0dcedb847","original_commit_id":"42aeeda91cafeeec13f973dc0744272756e3e9a2","user":{"login":"haassie","id":11075733,"avatar_url":"https://avatars2.githubusercontent.com/u/11075733?v=4","gravatar_id":"","url":"https://api.github.com/users/haassie","html_url":"https://github.com/haassie","followers_url":"https://api.github.com/users/haassie/followers","following_url":"https://api.github.com/users/haassie/following{/other_user}","gists_url":"https://api.github.com/users/haassie/gists{/gist_id}","starred_url":"https://api.github.com/users/haassie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haassie/subscriptions","organizations_url":"https://api.github.com/users/haassie/orgs","repos_url":"https://api.github.com/users/haassie/repos","events_url":"https://api.github.com/users/haassie/events{/privacy}","received_events_url":"https://api.github.com/users/haassie/received_events","type":"User","site_admin":false},"body":"@sfsmfc line 12 is causing the fail of travis. No empty line after the opening brace of a class.","created_at":"2017-09-28T06:03:27Z","updated_at":"2017-09-28T06:03:27Z","html_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98#discussion_r141532022","pull_request_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/comments/141532022"},"html":{"href":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98#discussion_r141532022"},"pull_request":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98"}},"in_reply_to_id":141444728},"pull_request":{"url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98","id":143429329,"html_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98","diff_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98.diff","patch_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98.patch","issue_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/98","number":98,"state":"open","locked":false,"title":"[FEATURE] #97 title and canonical field names can be set over typoscript","user":{"login":"sfsmfc","id":5294925,"avatar_url":"https://avatars1.githubusercontent.com/u/5294925?v=4","gravatar_id":"","url":"https://api.github.com/users/sfsmfc","html_url":"https://github.com/sfsmfc","followers_url":"https://api.github.com/users/sfsmfc/followers","following_url":"https://api.github.com/users/sfsmfc/following{/other_user}","gists_url":"https://api.github.com/users/sfsmfc/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmfc/subscriptions","organizations_url":"https://api.github.com/users/sfsmfc/orgs","repos_url":"https://api.github.com/users/sfsmfc/repos","events_url":"https://api.github.com/users/sfsmfc/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmfc/received_events","type":"User","site_admin":false},"body":"... and update condition for disable plugin in frontend","created_at":"2017-09-27T15:43:13Z","updated_at":"2017-09-28T06:03:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75b9b578b108bbfad3141c7c2ce24c99bbb3e2f5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/98/comments","statuses_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/statuses/a16b05da450b5317fd435a4a930e92f0dcedb847","head":{"label":"sfsmfc:master","ref":"master","sha":"a16b05da450b5317fd435a4a930e92f0dcedb847","user":{"login":"sfsmfc","id":5294925,"avatar_url":"https://avatars1.githubusercontent.com/u/5294925?v=4","gravatar_id":"","url":"https://api.github.com/users/sfsmfc","html_url":"https://github.com/sfsmfc","followers_url":"https://api.github.com/users/sfsmfc/followers","following_url":"https://api.github.com/users/sfsmfc/following{/other_user}","gists_url":"https://api.github.com/users/sfsmfc/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmfc/subscriptions","organizations_url":"https://api.github.com/users/sfsmfc/orgs","repos_url":"https://api.github.com/users/sfsmfc/repos","events_url":"https://api.github.com/users/sfsmfc/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmfc/received_events","type":"User","site_admin":false},"repo":{"id":105017380,"name":"Yoast-SEO-for-TYPO3","full_name":"sfsmfc/Yoast-SEO-for-TYPO3","owner":{"login":"sfsmfc","id":5294925,"avatar_url":"https://avatars1.githubusercontent.com/u/5294925?v=4","gravatar_id":"","url":"https://api.github.com/users/sfsmfc","html_url":"https://github.com/sfsmfc","followers_url":"https://api.github.com/users/sfsmfc/followers","following_url":"https://api.github.com/users/sfsmfc/following{/other_user}","gists_url":"https://api.github.com/users/sfsmfc/gists{/gist_id}","starred_url":"https://api.github.com/users/sfsmfc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfsmfc/subscriptions","organizations_url":"https://api.github.com/users/sfsmfc/orgs","repos_url":"https://api.github.com/users/sfsmfc/repos","events_url":"https://api.github.com/users/sfsmfc/events{/privacy}","received_events_url":"https://api.github.com/users/sfsmfc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfsmfc/Yoast-SEO-for-TYPO3","description":"Yoast SEO plugin for TYPO3","fork":true,"url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3","forks_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/forks","keys_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/teams","hooks_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/hooks","issue_events_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/issues/events{/number}","events_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/events","assignees_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/assignees{/user}","branches_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/branches{/branch}","tags_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/tags","blobs_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/statuses/{sha}","languages_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/languages","stargazers_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/stargazers","contributors_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/contributors","subscribers_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/subscribers","subscription_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/subscription","commits_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/contents/{+path}","compare_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/merges","archive_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/downloads","issues_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/issues{/number}","pulls_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/pulls{/number}","milestones_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/milestones{/number}","notifications_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/labels{/name}","releases_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/releases{/id}","deployments_url":"https://api.github.com/repos/sfsmfc/Yoast-SEO-for-TYPO3/deployments","created_at":"2017-09-27T12:47:33Z","updated_at":"2017-09-27T12:47:35Z","pushed_at":"2017-09-28T05:59:31Z","git_url":"git://github.com/sfsmfc/Yoast-SEO-for-TYPO3.git","ssh_url":"git@github.com:sfsmfc/Yoast-SEO-for-TYPO3.git","clone_url":"https://github.com/sfsmfc/Yoast-SEO-for-TYPO3.git","svn_url":"https://github.com/sfsmfc/Yoast-SEO-for-TYPO3","homepage":null,"size":2235,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yoast:master","ref":"master","sha":"212166fe0ef83bc30f5b86b442dddce2c069d512","user":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":62291663,"name":"Yoast-SEO-for-TYPO3","full_name":"Yoast/Yoast-SEO-for-TYPO3","owner":{"login":"Yoast","id":4690436,"avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3","description":"Yoast SEO plugin for TYPO3","fork":false,"url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3","forks_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/forks","keys_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/teams","hooks_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/hooks","issue_events_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/events","assignees_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/tags","blobs_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/languages","stargazers_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/stargazers","contributors_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/contributors","subscribers_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/subscribers","subscription_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/subscription","commits_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/merges","archive_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/downloads","issues_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/deployments","created_at":"2016-06-30T07:57:52Z","updated_at":"2017-09-27T20:43:15Z","pushed_at":"2017-09-28T05:59:32Z","git_url":"git://github.com/Yoast/Yoast-SEO-for-TYPO3.git","ssh_url":"git@github.com:Yoast/Yoast-SEO-for-TYPO3.git","clone_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3.git","svn_url":"https://github.com/Yoast/Yoast-SEO-for-TYPO3","homepage":null,"size":2237,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":11,"forks":18,"open_issues":11,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98"},"html":{"href":"https://github.com/Yoast/Yoast-SEO-for-TYPO3/pull/98"},"issue":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/98"},"comments":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3/statuses/a16b05da450b5317fd435a4a930e92f0dcedb847"}},"author_association":"NONE"}}
|
{
"id": 62291663,
"name": "Yoast/Yoast-SEO-for-TYPO3",
"url": "https://api.github.com/repos/Yoast/Yoast-SEO-for-TYPO3"
}
|
{
"id": 11075733,
"login": "haassie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11075733?",
"url": "https://api.github.com/users/haassie"
}
|
{
"id": 4690436,
"login": "Yoast",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4690436?",
"url": "https://api.github.com/orgs/Yoast"
}
| 2017-09-28T06:03:27 |
6647699336
|
{"actor":{"display_login":"haassie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/advox/training_lf/pulls/comments/130543413","pull_request_review_id":53424976,"id":130543413,"diff_hunk":"@@ -0,0 +1,82 @@\n+<?php\n+\n+class Florek_Manufacturer_Block_Adminhtml_Manufacturer_Grid extends Mage_Adminhtml_Block_Widget_Grid \n+{\n+ protected function _prepareCollection() \n+ {\n+ /* @var $collection Florek_Manufacturer_Model_Manufacturer */\n+ $collection = Mage::getResourceModel('florek_manufacturer/manufacturer_collection');\n+ $this->setCollection($collection); \n+ \n+ return parent::_prepareCollection();\n+ }\n+ \n+ protected function _prepareColumns() \n+ {\n+ /* @var $helper Florek_Manufacturer_Helper_Data */\n+ $helper = Mage::helper('florek_manufacturer');\n+ \n+ $this->addColumn('manufacturer_id', [\n+ 'header' => $helper->__('Manufacturer Id'),\n+ 'width' => 50,\n+ 'index' => 'id',\n+ 'sortable' => true, \n+ ]);\n+ $this->addColumn('name', [\n+ 'header' => $helper->__('Name'),\n+ 'width' => 200,\n+ 'index' => 'name',\n+ 'sortable' => true, \n+ ]);\n+ $this->addColumn('description', [\n+ 'header' => $helper->__('Description'),\n+ 'width' => 300,\n+ 'index' => 'description',\n+ 'sortable' => false,\n+ ]);\n+ $this->addColumn('created_at', [\n+ 'header' => $helper->__('Created At'),\n+ 'width' => 150,\n+ 'index' => 'created_at',\n+ 'sortable' => true,\n+ ]);\n+ $this->addColumn('updated_at', [\n+ 'header' => $helper->__('Updated At'),\n+ 'width' => 150,\n+ 'index' => 'updated_at',\n+ 'sortable' => true,\n+ ]);\n+ $this->addColumn('action', [\n+ 'header' => $helper->__('Action'),\n+ 'width' => 50,\n+ 'type' => 'action',\n+ 'actions' => [\n+ [\n+ 'caption' => $helper->__('Edit'),\n+ 'url' => [\n+ 'base' => '*/*/edit',\n+ ],\n+ 'field' => 'id',\n+ ],\n+ ],\n+ 'filter' => false,\n+ 'sortable' => false,\n+ 'index' => 'id',\n+ ]);\n+ \n+ return parent::_prepareColumns();\n+ }\n+ \n+ /**\n+ * \n+ * @param string $row","path":"app/code/local/Florek/Manufacturer/Block/Adminhtml/Manufacturer/Grid.php","position":72,"original_position":72,"commit_id":"755fc310f45ef86ca14e773fe0edba8f859a4c03","original_commit_id":"755fc310f45ef86ca14e773fe0edba8f859a4c03","user":{"login":"lukaszthecoded","id":28778774,"avatar_url":"https://avatars1.githubusercontent.com/u/28778774?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszthecoded","html_url":"https://github.com/lukaszthecoded","followers_url":"https://api.github.com/users/lukaszthecoded/followers","following_url":"https://api.github.com/users/lukaszthecoded/following{/other_user}","gists_url":"https://api.github.com/users/lukaszthecoded/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszthecoded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszthecoded/subscriptions","organizations_url":"https://api.github.com/users/lukaszthecoded/orgs","repos_url":"https://api.github.com/users/lukaszthecoded/repos","events_url":"https://api.github.com/users/lukaszthecoded/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszthecoded/received_events","type":"User","site_admin":false},"body":"$row nie jest stringiem","created_at":"2017-08-01T08:06:47Z","updated_at":"2017-08-01T08:19:49Z","html_url":"https://github.com/advox/training_lf/pull/5#discussion_r130543413","pull_request_url":"https://api.github.com/repos/advox/training_lf/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/advox/training_lf/pulls/comments/130543413"},"html":{"href":"https://github.com/advox/training_lf/pull/5#discussion_r130543413"},"pull_request":{"href":"https://api.github.com/repos/advox/training_lf/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/advox/training_lf/pulls/5","id":131749270,"html_url":"https://github.com/advox/training_lf/pull/5","diff_url":"https://github.com/advox/training_lf/pull/5.diff","patch_url":"https://github.com/advox/training_lf/pull/5.patch","issue_url":"https://api.github.com/repos/advox/training_lf/issues/5","number":5,"state":"open","locked":false,"title":"TRAIN-65","user":{"login":"lukaszflorczakthecoded","id":30036153,"avatar_url":"https://avatars1.githubusercontent.com/u/30036153?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszflorczakthecoded","html_url":"https://github.com/lukaszflorczakthecoded","followers_url":"https://api.github.com/users/lukaszflorczakthecoded/followers","following_url":"https://api.github.com/users/lukaszflorczakthecoded/following{/other_user}","gists_url":"https://api.github.com/users/lukaszflorczakthecoded/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszflorczakthecoded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszflorczakthecoded/subscriptions","organizations_url":"https://api.github.com/users/lukaszflorczakthecoded/orgs","repos_url":"https://api.github.com/users/lukaszflorczakthecoded/repos","events_url":"https://api.github.com/users/lukaszflorczakthecoded/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszflorczakthecoded/received_events","type":"User","site_admin":false},"body":"train66","created_at":"2017-07-21T10:57:00Z","updated_at":"2017-08-01T08:19:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b52d7554e4f797610b17246139428af977230eae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/advox/training_lf/pulls/5/commits","review_comments_url":"https://api.github.com/repos/advox/training_lf/pulls/5/comments","review_comment_url":"https://api.github.com/repos/advox/training_lf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/advox/training_lf/issues/5/comments","statuses_url":"https://api.github.com/repos/advox/training_lf/statuses/755fc310f45ef86ca14e773fe0edba8f859a4c03","head":{"label":"advox:train65","ref":"train65","sha":"755fc310f45ef86ca14e773fe0edba8f859a4c03","user":{"login":"advox","id":1726556,"avatar_url":"https://avatars3.githubusercontent.com/u/1726556?v=4","gravatar_id":"","url":"https://api.github.com/users/advox","html_url":"https://github.com/advox","followers_url":"https://api.github.com/users/advox/followers","following_url":"https://api.github.com/users/advox/following{/other_user}","gists_url":"https://api.github.com/users/advox/gists{/gist_id}","starred_url":"https://api.github.com/users/advox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advox/subscriptions","organizations_url":"https://api.github.com/users/advox/orgs","repos_url":"https://api.github.com/users/advox/repos","events_url":"https://api.github.com/users/advox/events{/privacy}","received_events_url":"https://api.github.com/users/advox/received_events","type":"Organization","site_admin":false},"repo":{"id":96876010,"name":"training_lf","full_name":"advox/training_lf","owner":{"login":"advox","id":1726556,"avatar_url":"https://avatars3.githubusercontent.com/u/1726556?v=4","gravatar_id":"","url":"https://api.github.com/users/advox","html_url":"https://github.com/advox","followers_url":"https://api.github.com/users/advox/followers","following_url":"https://api.github.com/users/advox/following{/other_user}","gists_url":"https://api.github.com/users/advox/gists{/gist_id}","starred_url":"https://api.github.com/users/advox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advox/subscriptions","organizations_url":"https://api.github.com/users/advox/orgs","repos_url":"https://api.github.com/users/advox/repos","events_url":"https://api.github.com/users/advox/events{/privacy}","received_events_url":"https://api.github.com/users/advox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advox/training_lf","description":"Training","fork":false,"url":"https://api.github.com/repos/advox/training_lf","forks_url":"https://api.github.com/repos/advox/training_lf/forks","keys_url":"https://api.github.com/repos/advox/training_lf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advox/training_lf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advox/training_lf/teams","hooks_url":"https://api.github.com/repos/advox/training_lf/hooks","issue_events_url":"https://api.github.com/repos/advox/training_lf/issues/events{/number}","events_url":"https://api.github.com/repos/advox/training_lf/events","assignees_url":"https://api.github.com/repos/advox/training_lf/assignees{/user}","branches_url":"https://api.github.com/repos/advox/training_lf/branches{/branch}","tags_url":"https://api.github.com/repos/advox/training_lf/tags","blobs_url":"https://api.github.com/repos/advox/training_lf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advox/training_lf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advox/training_lf/git/refs{/sha}","trees_url":"https://api.github.com/repos/advox/training_lf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advox/training_lf/statuses/{sha}","languages_url":"https://api.github.com/repos/advox/training_lf/languages","stargazers_url":"https://api.github.com/repos/advox/training_lf/stargazers","contributors_url":"https://api.github.com/repos/advox/training_lf/contributors","subscribers_url":"https://api.github.com/repos/advox/training_lf/subscribers","subscription_url":"https://api.github.com/repos/advox/training_lf/subscription","commits_url":"https://api.github.com/repos/advox/training_lf/commits{/sha}","git_commits_url":"https://api.github.com/repos/advox/training_lf/git/commits{/sha}","comments_url":"https://api.github.com/repos/advox/training_lf/comments{/number}","issue_comment_url":"https://api.github.com/repos/advox/training_lf/issues/comments{/number}","contents_url":"https://api.github.com/repos/advox/training_lf/contents/{+path}","compare_url":"https://api.github.com/repos/advox/training_lf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advox/training_lf/merges","archive_url":"https://api.github.com/repos/advox/training_lf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advox/training_lf/downloads","issues_url":"https://api.github.com/repos/advox/training_lf/issues{/number}","pulls_url":"https://api.github.com/repos/advox/training_lf/pulls{/number}","milestones_url":"https://api.github.com/repos/advox/training_lf/milestones{/number}","notifications_url":"https://api.github.com/repos/advox/training_lf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advox/training_lf/labels{/name}","releases_url":"https://api.github.com/repos/advox/training_lf/releases{/id}","deployments_url":"https://api.github.com/repos/advox/training_lf/deployments","created_at":"2017-07-11T09:29:36Z","updated_at":"2017-07-18T05:35:16Z","pushed_at":"2017-08-01T07:24:57Z","git_url":"git://github.com/advox/training_lf.git","ssh_url":"git@github.com:advox/training_lf.git","clone_url":"https://github.com/advox/training_lf.git","svn_url":"https://github.com/advox/training_lf","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"advox:master","ref":"master","sha":"a304c04bc1490d6fba469e727c767a98cd22bd7f","user":{"login":"advox","id":1726556,"avatar_url":"https://avatars3.githubusercontent.com/u/1726556?v=4","gravatar_id":"","url":"https://api.github.com/users/advox","html_url":"https://github.com/advox","followers_url":"https://api.github.com/users/advox/followers","following_url":"https://api.github.com/users/advox/following{/other_user}","gists_url":"https://api.github.com/users/advox/gists{/gist_id}","starred_url":"https://api.github.com/users/advox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advox/subscriptions","organizations_url":"https://api.github.com/users/advox/orgs","repos_url":"https://api.github.com/users/advox/repos","events_url":"https://api.github.com/users/advox/events{/privacy}","received_events_url":"https://api.github.com/users/advox/received_events","type":"Organization","site_admin":false},"repo":{"id":96876010,"name":"training_lf","full_name":"advox/training_lf","owner":{"login":"advox","id":1726556,"avatar_url":"https://avatars3.githubusercontent.com/u/1726556?v=4","gravatar_id":"","url":"https://api.github.com/users/advox","html_url":"https://github.com/advox","followers_url":"https://api.github.com/users/advox/followers","following_url":"https://api.github.com/users/advox/following{/other_user}","gists_url":"https://api.github.com/users/advox/gists{/gist_id}","starred_url":"https://api.github.com/users/advox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/advox/subscriptions","organizations_url":"https://api.github.com/users/advox/orgs","repos_url":"https://api.github.com/users/advox/repos","events_url":"https://api.github.com/users/advox/events{/privacy}","received_events_url":"https://api.github.com/users/advox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/advox/training_lf","description":"Training","fork":false,"url":"https://api.github.com/repos/advox/training_lf","forks_url":"https://api.github.com/repos/advox/training_lf/forks","keys_url":"https://api.github.com/repos/advox/training_lf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/advox/training_lf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/advox/training_lf/teams","hooks_url":"https://api.github.com/repos/advox/training_lf/hooks","issue_events_url":"https://api.github.com/repos/advox/training_lf/issues/events{/number}","events_url":"https://api.github.com/repos/advox/training_lf/events","assignees_url":"https://api.github.com/repos/advox/training_lf/assignees{/user}","branches_url":"https://api.github.com/repos/advox/training_lf/branches{/branch}","tags_url":"https://api.github.com/repos/advox/training_lf/tags","blobs_url":"https://api.github.com/repos/advox/training_lf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/advox/training_lf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/advox/training_lf/git/refs{/sha}","trees_url":"https://api.github.com/repos/advox/training_lf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/advox/training_lf/statuses/{sha}","languages_url":"https://api.github.com/repos/advox/training_lf/languages","stargazers_url":"https://api.github.com/repos/advox/training_lf/stargazers","contributors_url":"https://api.github.com/repos/advox/training_lf/contributors","subscribers_url":"https://api.github.com/repos/advox/training_lf/subscribers","subscription_url":"https://api.github.com/repos/advox/training_lf/subscription","commits_url":"https://api.github.com/repos/advox/training_lf/commits{/sha}","git_commits_url":"https://api.github.com/repos/advox/training_lf/git/commits{/sha}","comments_url":"https://api.github.com/repos/advox/training_lf/comments{/number}","issue_comment_url":"https://api.github.com/repos/advox/training_lf/issues/comments{/number}","contents_url":"https://api.github.com/repos/advox/training_lf/contents/{+path}","compare_url":"https://api.github.com/repos/advox/training_lf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/advox/training_lf/merges","archive_url":"https://api.github.com/repos/advox/training_lf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/advox/training_lf/downloads","issues_url":"https://api.github.com/repos/advox/training_lf/issues{/number}","pulls_url":"https://api.github.com/repos/advox/training_lf/pulls{/number}","milestones_url":"https://api.github.com/repos/advox/training_lf/milestones{/number}","notifications_url":"https://api.github.com/repos/advox/training_lf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/advox/training_lf/labels{/name}","releases_url":"https://api.github.com/repos/advox/training_lf/releases{/id}","deployments_url":"https://api.github.com/repos/advox/training_lf/deployments","created_at":"2017-07-11T09:29:36Z","updated_at":"2017-07-18T05:35:16Z","pushed_at":"2017-08-01T07:24:57Z","git_url":"git://github.com/advox/training_lf.git","ssh_url":"git@github.com:advox/training_lf.git","clone_url":"https://github.com/advox/training_lf.git","svn_url":"https://github.com/advox/training_lf","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/advox/training_lf/pulls/5"},"html":{"href":"https://github.com/advox/training_lf/pull/5"},"issue":{"href":"https://api.github.com/repos/advox/training_lf/issues/5"},"comments":{"href":"https://api.github.com/repos/advox/training_lf/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/advox/training_lf/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/advox/training_lf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/advox/training_lf/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/advox/training_lf/statuses/755fc310f45ef86ca14e773fe0edba8f859a4c03"}}}}
|
{
"id": 96876010,
"name": "advox/training_lf",
"url": "https://api.github.com/repos/advox/training_lf"
}
|
{
"id": 28778774,
"login": "lukaszthecoded",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28778774?",
"url": "https://api.github.com/users/lukaszthecoded"
}
|
{
"id": 1726556,
"login": "advox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1726556?",
"url": "https://api.github.com/orgs/advox"
}
| 2017-08-01T08:06:47 |
6368078529
|
{"actor":{"display_login":"lukaszthecoded"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/120023391","pull_request_review_id":41953195,"id":120023391,"diff_hunk":"@@ -68,8 +68,12 @@ static SectionInfo getSectionInfo(const char *imageName,\n SectionInfo sectionInfo = { 0, nullptr };\n void *handle = dlopen(imageName, RTLD_LAZY | RTLD_NOLOAD);\n if (!handle) {\n+#ifdef __ANDROID__\n+ return sectionInfo;\n+#else","path":"stdlib/public/runtime/ImageInspectionELF.cpp","position":6,"original_position":6,"commit_id":"8248322be00e718714295b13d35c632ea76f46c3","original_commit_id":"8248322be00e718714295b13d35c632ea76f46c3","user":{"login":"CodaFi","id":1896383,"avatar_url":"https://avatars0.githubusercontent.com/u/1896383?v=3","gravatar_id":"","url":"https://api.github.com/users/CodaFi","html_url":"https://github.com/CodaFi","followers_url":"https://api.github.com/users/CodaFi/followers","following_url":"https://api.github.com/users/CodaFi/following{/other_user}","gists_url":"https://api.github.com/users/CodaFi/gists{/gist_id}","starred_url":"https://api.github.com/users/CodaFi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodaFi/subscriptions","organizations_url":"https://api.github.com/users/CodaFi/orgs","repos_url":"https://api.github.com/users/CodaFi/repos","events_url":"https://api.github.com/users/CodaFi/events{/privacy}","received_events_url":"https://api.github.com/users/CodaFi/received_events","type":"User","site_admin":false},"body":"Why is this relevant to the fatal error patch? I would prefer this get reviewed separately if it could.","created_at":"2017-06-04T23:02:47Z","updated_at":"2017-06-04T23:02:53Z","html_url":"https://github.com/apple/swift/pull/9869#discussion_r120023391","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/9869","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/120023391"},"html":{"href":"https://github.com/apple/swift/pull/9869#discussion_r120023391"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/9869"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/9869","id":121943201,"html_url":"https://github.com/apple/swift/pull/9869","diff_url":"https://github.com/apple/swift/pull/9869.diff","patch_url":"https://github.com/apple/swift/pull/9869.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/9869","number":9869,"state":"open","locked":false,"title":"Ensure fatalError message logged on Android","user":{"login":"johnno1962","id":1786033,"avatar_url":"https://avatars0.githubusercontent.com/u/1786033?v=3","gravatar_id":"","url":"https://api.github.com/users/johnno1962","html_url":"https://github.com/johnno1962","followers_url":"https://api.github.com/users/johnno1962/followers","following_url":"https://api.github.com/users/johnno1962/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962/subscriptions","organizations_url":"https://api.github.com/users/johnno1962/orgs","repos_url":"https://api.github.com/users/johnno1962/repos","events_url":"https://api.github.com/users/johnno1962/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962/received_events","type":"User","site_admin":false},"body":"Change to make sure the message passed to fatalError() in Swift is logged to the console on Android. Requires linking with an additional library -llog so any help on exactly where in the CMake file this should be added would certainly be appreciated.\r\n\r\nResolves [SR-2734](https://bugs.swift.org/browse/SR-2734).\r\n","created_at":"2017-05-23T08:46:59Z","updated_at":"2017-06-04T23:02:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5534c00a888e596296fa71ece3fcfb234909e4f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/9869/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/9869/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/9869/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/8248322be00e718714295b13d35c632ea76f46c3","head":{"label":"johnno1962a:master","ref":"master","sha":"8248322be00e718714295b13d35c632ea76f46c3","user":{"login":"johnno1962a","id":17772788,"avatar_url":"https://avatars0.githubusercontent.com/u/17772788?v=3","gravatar_id":"","url":"https://api.github.com/users/johnno1962a","html_url":"https://github.com/johnno1962a","followers_url":"https://api.github.com/users/johnno1962a/followers","following_url":"https://api.github.com/users/johnno1962a/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962a/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962a/subscriptions","organizations_url":"https://api.github.com/users/johnno1962a/orgs","repos_url":"https://api.github.com/users/johnno1962a/repos","events_url":"https://api.github.com/users/johnno1962a/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962a/received_events","type":"Organization","site_admin":false},"repo":{"id":92112498,"name":"swift","full_name":"johnno1962a/swift","owner":{"login":"johnno1962a","id":17772788,"avatar_url":"https://avatars0.githubusercontent.com/u/17772788?v=3","gravatar_id":"","url":"https://api.github.com/users/johnno1962a","html_url":"https://github.com/johnno1962a","followers_url":"https://api.github.com/users/johnno1962a/followers","following_url":"https://api.github.com/users/johnno1962a/following{/other_user}","gists_url":"https://api.github.com/users/johnno1962a/gists{/gist_id}","starred_url":"https://api.github.com/users/johnno1962a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnno1962a/subscriptions","organizations_url":"https://api.github.com/users/johnno1962a/orgs","repos_url":"https://api.github.com/users/johnno1962a/repos","events_url":"https://api.github.com/users/johnno1962a/events{/privacy}","received_events_url":"https://api.github.com/users/johnno1962a/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/johnno1962a/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/johnno1962a/swift","forks_url":"https://api.github.com/repos/johnno1962a/swift/forks","keys_url":"https://api.github.com/repos/johnno1962a/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnno1962a/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnno1962a/swift/teams","hooks_url":"https://api.github.com/repos/johnno1962a/swift/hooks","issue_events_url":"https://api.github.com/repos/johnno1962a/swift/issues/events{/number}","events_url":"https://api.github.com/repos/johnno1962a/swift/events","assignees_url":"https://api.github.com/repos/johnno1962a/swift/assignees{/user}","branches_url":"https://api.github.com/repos/johnno1962a/swift/branches{/branch}","tags_url":"https://api.github.com/repos/johnno1962a/swift/tags","blobs_url":"https://api.github.com/repos/johnno1962a/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnno1962a/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnno1962a/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnno1962a/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnno1962a/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/johnno1962a/swift/languages","stargazers_url":"https://api.github.com/repos/johnno1962a/swift/stargazers","contributors_url":"https://api.github.com/repos/johnno1962a/swift/contributors","subscribers_url":"https://api.github.com/repos/johnno1962a/swift/subscribers","subscription_url":"https://api.github.com/repos/johnno1962a/swift/subscription","commits_url":"https://api.github.com/repos/johnno1962a/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnno1962a/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnno1962a/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnno1962a/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnno1962a/swift/contents/{+path}","compare_url":"https://api.github.com/repos/johnno1962a/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnno1962a/swift/merges","archive_url":"https://api.github.com/repos/johnno1962a/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnno1962a/swift/downloads","issues_url":"https://api.github.com/repos/johnno1962a/swift/issues{/number}","pulls_url":"https://api.github.com/repos/johnno1962a/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/johnno1962a/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/johnno1962a/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnno1962a/swift/labels{/name}","releases_url":"https://api.github.com/repos/johnno1962a/swift/releases{/id}","deployments_url":"https://api.github.com/repos/johnno1962a/swift/deployments","created_at":"2017-05-23T00:46:41Z","updated_at":"2017-05-23T00:47:27Z","pushed_at":"2017-06-04T22:34:30Z","git_url":"git://github.com/johnno1962a/swift.git","ssh_url":"git@github.com:johnno1962a/swift.git","clone_url":"https://github.com/johnno1962a/swift.git","svn_url":"https://github.com/johnno1962a/swift","homepage":"https://swift.org/","size":206450,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"1c390bc5787728e90a3b4db84dd082eca5b82c1c","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-06-04T14:09:22Z","pushed_at":"2017-06-04T22:50:52Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":205064,"stargazers_count":38689,"watchers_count":38689,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5787,"mirror_url":null,"open_issues_count":169,"forks":5787,"open_issues":169,"watchers":38689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/9869"},"html":{"href":"https://github.com/apple/swift/pull/9869"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/9869"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/9869/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/9869/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/9869/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/8248322be00e718714295b13d35c632ea76f46c3"}}}}
|
{
"id": 44838949,
"name": "apple/swift",
"url": "https://api.github.com/repos/apple/swift"
}
|
{
"id": 1896383,
"login": "CodaFi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1896383?",
"url": "https://api.github.com/users/CodaFi"
}
|
{
"id": 10639145,
"login": "apple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10639145?",
"url": "https://api.github.com/orgs/apple"
}
| 2017-06-04T23:02:47 |
5999628964
|
{"actor":{"display_login":"CodaFi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/98284500","pull_request_review_id":18925071,"id":98284500,"diff_hunk":"@@ -194,10 +192,17 @@ describe 'ArticleView', ->\n \n it 'on small screens, resets image sizes for imageset previews', ->\n @view.windowWidth = 600\n- @imgsFillContainer.callCount.should.be.above 1\n+ @imgsFillContainer.callCount.should.equal 1\n \n describe '#imgsFillContainer', ->\n it 'returns true if images are narrower than their container', ->\n container = @view.$('.article-section-artworks ul').width(1400)\n imgsFillContainer = @view.imgsFillContainer([{width: 600}, {width:700}], container, 5)\n imgsFillContainer.isFilled.should.equal true\n+\n+ describe '#renderCalloutSections', ->\n+\n+ it 'renders callouts', ->","path":"components/article/test/view.coffee","position":162,"original_position":162,"commit_id":"2c53cd357b7d6652b2d49c547e498fe34bbae44c","original_commit_id":"2c53cd357b7d6652b2d49c547e498fe34bbae44c","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars.githubusercontent.com/u/555859?v=3","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"body":"👌 ","created_at":"2017-01-27T20:31:08Z","updated_at":"2017-01-27T20:31:12Z","html_url":"https://github.com/artsy/force/pull/782#discussion_r98284500","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/782","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/98284500"},"html":{"href":"https://github.com/artsy/force/pull/782#discussion_r98284500"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/782"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/782","id":103437966,"html_url":"https://github.com/artsy/force/pull/782","diff_url":"https://github.com/artsy/force/pull/782.diff","patch_url":"https://github.com/artsy/force/pull/782.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/782","number":782,"state":"open","locked":false,"title":"@craigspaeth => Callout Fix on Infinite Scroll","user":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars.githubusercontent.com/u/2236794?v=3","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"body":"Yesterday I moved callout article fetching to server-side and introduced a bug with infinite scroll articles that have callouts. If it's an infinite scroll article with a callout, we will render it client-side with this PR. ","created_at":"2017-01-27T04:49:51Z","updated_at":"2017-01-27T20:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2894890b7e0ebbf425e16586775e2e6a438fae12","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/782/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/782/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/782/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/2c53cd357b7d6652b2d49c547e498fe34bbae44c","head":{"label":"kanaabe:callout-fix","ref":"callout-fix","sha":"2c53cd357b7d6652b2d49c547e498fe34bbae44c","user":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars.githubusercontent.com/u/2236794?v=3","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"repo":{"id":65848072,"name":"force","full_name":"kanaabe/force","owner":{"login":"kanaabe","id":2236794,"avatar_url":"https://avatars.githubusercontent.com/u/2236794?v=3","gravatar_id":"","url":"https://api.github.com/users/kanaabe","html_url":"https://github.com/kanaabe","followers_url":"https://api.github.com/users/kanaabe/followers","following_url":"https://api.github.com/users/kanaabe/following{/other_user}","gists_url":"https://api.github.com/users/kanaabe/gists{/gist_id}","starred_url":"https://api.github.com/users/kanaabe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanaabe/subscriptions","organizations_url":"https://api.github.com/users/kanaabe/orgs","repos_url":"https://api.github.com/users/kanaabe/repos","events_url":"https://api.github.com/users/kanaabe/events{/privacy}","received_events_url":"https://api.github.com/users/kanaabe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanaabe/force","description":"Repository for the Artsy.net frontend","fork":true,"url":"https://api.github.com/repos/kanaabe/force","forks_url":"https://api.github.com/repos/kanaabe/force/forks","keys_url":"https://api.github.com/repos/kanaabe/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanaabe/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanaabe/force/teams","hooks_url":"https://api.github.com/repos/kanaabe/force/hooks","issue_events_url":"https://api.github.com/repos/kanaabe/force/issues/events{/number}","events_url":"https://api.github.com/repos/kanaabe/force/events","assignees_url":"https://api.github.com/repos/kanaabe/force/assignees{/user}","branches_url":"https://api.github.com/repos/kanaabe/force/branches{/branch}","tags_url":"https://api.github.com/repos/kanaabe/force/tags","blobs_url":"https://api.github.com/repos/kanaabe/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanaabe/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanaabe/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanaabe/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanaabe/force/statuses/{sha}","languages_url":"https://api.github.com/repos/kanaabe/force/languages","stargazers_url":"https://api.github.com/repos/kanaabe/force/stargazers","contributors_url":"https://api.github.com/repos/kanaabe/force/contributors","subscribers_url":"https://api.github.com/repos/kanaabe/force/subscribers","subscription_url":"https://api.github.com/repos/kanaabe/force/subscription","commits_url":"https://api.github.com/repos/kanaabe/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanaabe/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanaabe/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanaabe/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanaabe/force/contents/{+path}","compare_url":"https://api.github.com/repos/kanaabe/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanaabe/force/merges","archive_url":"https://api.github.com/repos/kanaabe/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanaabe/force/downloads","issues_url":"https://api.github.com/repos/kanaabe/force/issues{/number}","pulls_url":"https://api.github.com/repos/kanaabe/force/pulls{/number}","milestones_url":"https://api.github.com/repos/kanaabe/force/milestones{/number}","notifications_url":"https://api.github.com/repos/kanaabe/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanaabe/force/labels{/name}","releases_url":"https://api.github.com/repos/kanaabe/force/releases{/id}","deployments_url":"https://api.github.com/repos/kanaabe/force/deployments","created_at":"2016-08-16T19:35:04Z","updated_at":"2016-12-12T03:38:58Z","pushed_at":"2017-01-27T17:09:06Z","git_url":"git://github.com/kanaabe/force.git","ssh_url":"git@github.com:kanaabe/force.git","clone_url":"https://github.com/kanaabe/force.git","svn_url":"https://github.com/kanaabe/force","homepage":"","size":118388,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"e3ff78ab2464ae7c83e537af15512810ab6b0c51","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"name":"force","full_name":"artsy/force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2017-01-25T02:21:04Z","pushed_at":"2017-01-27T17:55:24Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":118410,"stargazers_count":159,"watchers_count":159,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"open_issues_count":59,"forks":54,"open_issues":59,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/782"},"html":{"href":"https://github.com/artsy/force/pull/782"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/782"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/782/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/782/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/782/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/2c53cd357b7d6652b2d49c547e498fe34bbae44c"}}}}
|
{
"id": 22887404,
"name": "artsy/force",
"url": "https://api.github.com/repos/artsy/force"
}
|
{
"id": 555859,
"login": "craigspaeth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/555859?",
"url": "https://api.github.com/users/craigspaeth"
}
|
{
"id": 546231,
"login": "artsy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/546231?",
"url": "https://api.github.com/orgs/artsy"
}
| 2017-01-27T20:31:08 |
5226172414
|
{"actor":{"display_login":"craigspaeth"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/reaction-force/pulls/comments/103107429","pull_request_review_id":23884224,"id":103107429,"diff_hunk":"@@ -36,8 +36,10 @@\n \"typescript\": \"^2.1.5\"\n },\n \"dependencies\": {\n+ \"@types/react-bootstrap\": \"^0.0.45\",\n \"asap\": \"https://github.com/alloy/asap.git\",\n \"react\": \"^15.4.2\",\n+ \"react-bootstrap\": \"^0.30.7\",","path":"package.json","position":7,"original_position":7,"commit_id":"a75700f91e80f6094faf6cc4fc3654d5c94cff17","original_commit_id":"a75700f91e80f6094faf6cc4fc3654d5c94cff17","user":{"login":"orta","id":49038,"avatar_url":"https://avatars.githubusercontent.com/u/49038?v=3","gravatar_id":"","url":"https://api.github.com/users/orta","html_url":"https://github.com/orta","followers_url":"https://api.github.com/users/orta/followers","following_url":"https://api.github.com/users/orta/following{/other_user}","gists_url":"https://api.github.com/users/orta/gists{/gist_id}","starred_url":"https://api.github.com/users/orta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orta/subscriptions","organizations_url":"https://api.github.com/users/orta/orgs","repos_url":"https://api.github.com/users/orta/repos","events_url":"https://api.github.com/users/orta/events{/privacy}","received_events_url":"https://api.github.com/users/orta/received_events","type":"User","site_admin":false},"body":"This is a massive framework ( https://react-bootstrap.github.io/components.html ) was there discussion about whether this is worth it anywhere I can read?","created_at":"2017-02-26T15:27:10Z","updated_at":"2017-02-26T15:27:11Z","html_url":"https://github.com/artsy/reaction-force/pull/25#discussion_r103107429","pull_request_url":"https://api.github.com/repos/artsy/reaction-force/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/comments/103107429"},"html":{"href":"https://github.com/artsy/reaction-force/pull/25#discussion_r103107429"},"pull_request":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/reaction-force/pulls/25","id":107914309,"html_url":"https://github.com/artsy/reaction-force/pull/25","diff_url":"https://github.com/artsy/reaction-force/pull/25.diff","patch_url":"https://github.com/artsy/reaction-force/pull/25.patch","issue_url":"https://api.github.com/repos/artsy/reaction-force/issues/25","number":25,"state":"open","locked":false,"title":"Button component","user":{"login":"l2succes","id":296775,"avatar_url":"https://avatars.githubusercontent.com/u/296775?v=3","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},"body":"This PR is meant to be a discussion on the component styling pattern itself (that's why I added the whole squad)\r\n\r\n\r\n","created_at":"2017-02-24T21:42:02Z","updated_at":"2017-02-26T15:27:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a96d6fe9e8cd79e210629a5652ac0c83afa802e","assignee":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},{"login":"yuki24","id":386234,"avatar_url":"https://avatars.githubusercontent.com/u/386234?v=3","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},{"login":"broskoski","id":821469,"avatar_url":"https://avatars.githubusercontent.com/u/821469?v=3","gravatar_id":"","url":"https://api.github.com/users/broskoski","html_url":"https://github.com/broskoski","followers_url":"https://api.github.com/users/broskoski/followers","following_url":"https://api.github.com/users/broskoski/following{/other_user}","gists_url":"https://api.github.com/users/broskoski/gists{/gist_id}","starred_url":"https://api.github.com/users/broskoski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broskoski/subscriptions","organizations_url":"https://api.github.com/users/broskoski/orgs","repos_url":"https://api.github.com/users/broskoski/repos","events_url":"https://api.github.com/users/broskoski/events{/privacy}","received_events_url":"https://api.github.com/users/broskoski/received_events","type":"User","site_admin":false},{"login":"mzikherman","id":1457859,"avatar_url":"https://avatars.githubusercontent.com/u/1457859?v=3","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},{"login":"xtina-starr","id":5201004,"avatar_url":"https://avatars.githubusercontent.com/u/5201004?v=3","gravatar_id":"","url":"https://api.github.com/users/xtina-starr","html_url":"https://github.com/xtina-starr","followers_url":"https://api.github.com/users/xtina-starr/followers","following_url":"https://api.github.com/users/xtina-starr/following{/other_user}","gists_url":"https://api.github.com/users/xtina-starr/gists{/gist_id}","starred_url":"https://api.github.com/users/xtina-starr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtina-starr/subscriptions","organizations_url":"https://api.github.com/users/xtina-starr/orgs","repos_url":"https://api.github.com/users/xtina-starr/repos","events_url":"https://api.github.com/users/xtina-starr/events{/privacy}","received_events_url":"https://api.github.com/users/xtina-starr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/reaction-force/pulls/25/commits","review_comments_url":"https://api.github.com/repos/artsy/reaction-force/pulls/25/comments","review_comment_url":"https://api.github.com/repos/artsy/reaction-force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/reaction-force/issues/25/comments","statuses_url":"https://api.github.com/repos/artsy/reaction-force/statuses/a75700f91e80f6094faf6cc4fc3654d5c94cff17","head":{"label":"artsy:button-component","ref":"button-component","sha":"a75700f91e80f6094faf6cc4fc3654d5c94cff17","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"name":"reaction-force","full_name":"artsy/reaction-force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction-force","description":"Force’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction-force","forks_url":"https://api.github.com/repos/artsy/reaction-force/forks","keys_url":"https://api.github.com/repos/artsy/reaction-force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction-force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction-force/teams","hooks_url":"https://api.github.com/repos/artsy/reaction-force/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction-force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction-force/events","assignees_url":"https://api.github.com/repos/artsy/reaction-force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction-force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction-force/tags","blobs_url":"https://api.github.com/repos/artsy/reaction-force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction-force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction-force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction-force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction-force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction-force/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction-force/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction-force/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction-force/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction-force/subscription","commits_url":"https://api.github.com/repos/artsy/reaction-force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction-force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction-force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction-force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction-force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction-force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction-force/merges","archive_url":"https://api.github.com/repos/artsy/reaction-force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction-force/downloads","issues_url":"https://api.github.com/repos/artsy/reaction-force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction-force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction-force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction-force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction-force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction-force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction-force/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2017-02-25T05:20:20Z","pushed_at":"2017-02-24T22:06:13Z","git_url":"git://github.com/artsy/reaction-force.git","ssh_url":"git@github.com:artsy/reaction-force.git","clone_url":"https://github.com/artsy/reaction-force.git","svn_url":"https://github.com/artsy/reaction-force","homepage":"https://artsy.github.io/reaction-force","size":4416,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":8,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"3ecad9fab4da356a9ca02ac476aeff9a346d6343","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"name":"reaction-force","full_name":"artsy/reaction-force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars.githubusercontent.com/u/546231?v=3","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction-force","description":"Force’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction-force","forks_url":"https://api.github.com/repos/artsy/reaction-force/forks","keys_url":"https://api.github.com/repos/artsy/reaction-force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction-force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction-force/teams","hooks_url":"https://api.github.com/repos/artsy/reaction-force/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction-force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction-force/events","assignees_url":"https://api.github.com/repos/artsy/reaction-force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction-force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction-force/tags","blobs_url":"https://api.github.com/repos/artsy/reaction-force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction-force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction-force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction-force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction-force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction-force/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction-force/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction-force/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction-force/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction-force/subscription","commits_url":"https://api.github.com/repos/artsy/reaction-force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction-force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction-force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction-force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction-force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction-force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction-force/merges","archive_url":"https://api.github.com/repos/artsy/reaction-force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction-force/downloads","issues_url":"https://api.github.com/repos/artsy/reaction-force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction-force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction-force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction-force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction-force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction-force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction-force/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2017-02-25T05:20:20Z","pushed_at":"2017-02-24T22:06:13Z","git_url":"git://github.com/artsy/reaction-force.git","ssh_url":"git@github.com:artsy/reaction-force.git","clone_url":"https://github.com/artsy/reaction-force.git","svn_url":"https://github.com/artsy/reaction-force","homepage":"https://artsy.github.io/reaction-force","size":4416,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":13,"forks":3,"open_issues":13,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/25"},"html":{"href":"https://github.com/artsy/reaction-force/pull/25"},"issue":{"href":"https://api.github.com/repos/artsy/reaction-force/issues/25"},"comments":{"href":"https://api.github.com/repos/artsy/reaction-force/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/reaction-force/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/reaction-force/statuses/a75700f91e80f6094faf6cc4fc3654d5c94cff17"}}}}
|
{
"id": 81253735,
"name": "artsy/reaction-force",
"url": "https://api.github.com/repos/artsy/reaction-force"
}
|
{
"id": 49038,
"login": "orta",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49038?",
"url": "https://api.github.com/users/orta"
}
|
{
"id": 546231,
"login": "artsy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/546231?",
"url": "https://api.github.com/orgs/artsy"
}
| 2017-02-26T15:27:10 |
5392899883
|
{"actor":{"display_login":"orta"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/reaction/pulls/comments/143567812","pull_request_review_id":68097136,"id":143567812,"diff_hunk":"@@ -0,0 +1,70 @@\n+import * as React from \"react\"\n+import styled from \"styled-components\"\n+\n+import SelectableToggle from \"../selectable_toggle\"\n+import { StepProps } from \"../types\"\n+import { Layout } from \"./layout\"\n+\n+const OptionsContainer = styled.div`\n+width: 450px;\n+margin: 0 auto 100px;\n+&:last-child {\n+ border-bottom: 1px solid #e5e5e5;\n+}\n+`\n+\n+interface State {\n+ selection: string","path":"src/components/onboarding/steps/budget.tsx","position":17,"original_position":17,"commit_id":"0c3f2b716a50de16cc04e48876ca0ed2fc169efc","original_commit_id":"0c3f2b716a50de16cc04e48876ca0ed2fc169efc","user":{"login":"xtina-starr","id":5201004,"avatar_url":"https://avatars2.githubusercontent.com/u/5201004?v=4","gravatar_id":"","url":"https://api.github.com/users/xtina-starr","html_url":"https://github.com/xtina-starr","followers_url":"https://api.github.com/users/xtina-starr/followers","following_url":"https://api.github.com/users/xtina-starr/following{/other_user}","gists_url":"https://api.github.com/users/xtina-starr/gists{/gist_id}","starred_url":"https://api.github.com/users/xtina-starr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtina-starr/subscriptions","organizations_url":"https://api.github.com/users/xtina-starr/orgs","repos_url":"https://api.github.com/users/xtina-starr/repos","events_url":"https://api.github.com/users/xtina-starr/events{/privacy}","received_events_url":"https://api.github.com/users/xtina-starr/received_events","type":"User","site_admin":false},"body":"Not quite sure I understand what you mean here? Isn't the text being produced based on what the index of the options array is? ","created_at":"2017-10-09T20:22:21Z","updated_at":"2017-10-09T20:22:22Z","html_url":"https://github.com/artsy/reaction/pull/269#discussion_r143567812","pull_request_url":"https://api.github.com/repos/artsy/reaction/pulls/269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments/143567812"},"html":{"href":"https://github.com/artsy/reaction/pull/269#discussion_r143567812"},"pull_request":{"href":"https://api.github.com/repos/artsy/reaction/pulls/269"}},"in_reply_to_id":143538733},"pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/269","id":145505231,"html_url":"https://github.com/artsy/reaction/pull/269","diff_url":"https://github.com/artsy/reaction/pull/269.diff","patch_url":"https://github.com/artsy/reaction/pull/269.patch","issue_url":"https://api.github.com/repos/artsy/reaction/issues/269","number":269,"state":"open","locked":false,"title":"[Onboarding] Budget screen views","user":{"login":"mennenia","id":373860,"avatar_url":"https://avatars0.githubusercontent.com/u/373860?v=4","gravatar_id":"","url":"https://api.github.com/users/mennenia","html_url":"https://github.com/mennenia","followers_url":"https://api.github.com/users/mennenia/followers","following_url":"https://api.github.com/users/mennenia/following{/other_user}","gists_url":"https://api.github.com/users/mennenia/gists{/gist_id}","starred_url":"https://api.github.com/users/mennenia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mennenia/subscriptions","organizations_url":"https://api.github.com/users/mennenia/orgs","repos_url":"https://api.github.com/users/mennenia/repos","events_url":"https://api.github.com/users/mennenia/events{/privacy}","received_events_url":"https://api.github.com/users/mennenia/received_events","type":"User","site_admin":false},"body":"Made with the 🎉 @xtina-starr \r\n\r\nIssue [here](https://github.com/artsy/collector-experience/issues/507). \r\n\r\nCurrently looks like:\r\n\r\n<img width=\"1434\" alt=\"screen shot 2017-10-09 at 18 13 19\" src=\"https://user-images.githubusercontent.com/373860/31350064-9b7a499c-ad1d-11e7-8c41-00a32866afab.png\">\r\n\r\nStill needs:\r\n- [ ] Icon\r\n- [ ] Potential refactor / cleanup? Some overlap code with `selectable_link.tsx`\r\n\r\nWe've just added a few reviewers just for some extra eyes 😄 ","created_at":"2017-10-09T17:15:26Z","updated_at":"2017-10-09T20:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcbf91398738503f0a99075f03ed69225752603a","assignee":{"login":"alloy","id":2320,"avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"assignees":[{"login":"alloy","id":2320,"avatar_url":"https://avatars2.githubusercontent.com/u/2320?v=4","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"l2succes","id":296775,"avatar_url":"https://avatars0.githubusercontent.com/u/296775?v=4","gravatar_id":"","url":"https://api.github.com/users/l2succes","html_url":"https://github.com/l2succes","followers_url":"https://api.github.com/users/l2succes/followers","following_url":"https://api.github.com/users/l2succes/following{/other_user}","gists_url":"https://api.github.com/users/l2succes/gists{/gist_id}","starred_url":"https://api.github.com/users/l2succes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l2succes/subscriptions","organizations_url":"https://api.github.com/users/l2succes/orgs","repos_url":"https://api.github.com/users/l2succes/repos","events_url":"https://api.github.com/users/l2succes/events{/privacy}","received_events_url":"https://api.github.com/users/l2succes/received_events","type":"User","site_admin":false},{"login":"yuki24","id":386234,"avatar_url":"https://avatars0.githubusercontent.com/u/386234?v=4","gravatar_id":"","url":"https://api.github.com/users/yuki24","html_url":"https://github.com/yuki24","followers_url":"https://api.github.com/users/yuki24/followers","following_url":"https://api.github.com/users/yuki24/following{/other_user}","gists_url":"https://api.github.com/users/yuki24/gists{/gist_id}","starred_url":"https://api.github.com/users/yuki24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuki24/subscriptions","organizations_url":"https://api.github.com/users/yuki24/orgs","repos_url":"https://api.github.com/users/yuki24/repos","events_url":"https://api.github.com/users/yuki24/events{/privacy}","received_events_url":"https://api.github.com/users/yuki24/received_events","type":"User","site_admin":false},{"login":"xtina-starr","id":5201004,"avatar_url":"https://avatars2.githubusercontent.com/u/5201004?v=4","gravatar_id":"","url":"https://api.github.com/users/xtina-starr","html_url":"https://github.com/xtina-starr","followers_url":"https://api.github.com/users/xtina-starr/followers","following_url":"https://api.github.com/users/xtina-starr/following{/other_user}","gists_url":"https://api.github.com/users/xtina-starr/gists{/gist_id}","starred_url":"https://api.github.com/users/xtina-starr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xtina-starr/subscriptions","organizations_url":"https://api.github.com/users/xtina-starr/orgs","repos_url":"https://api.github.com/users/xtina-starr/repos","events_url":"https://api.github.com/users/xtina-starr/events{/privacy}","received_events_url":"https://api.github.com/users/xtina-starr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/reaction/pulls/269/commits","review_comments_url":"https://api.github.com/repos/artsy/reaction/pulls/269/comments","review_comment_url":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/269/comments","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/0c3f2b716a50de16cc04e48876ca0ed2fc169efc","head":{"label":"artsy:onboarding-budget","ref":"onboarding-budget","sha":"0c3f2b716a50de16cc04e48876ca0ed2fc169efc","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2017-10-09T18:31:20Z","pushed_at":"2017-10-09T17:15:26Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":7483,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":27,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"272ca4cf491b7419bdff07165b156f9c57647fb1","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2017-10-09T18:31:20Z","pushed_at":"2017-10-09T17:15:26Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":7483,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/269"},"html":{"href":"https://github.com/artsy/reaction/pull/269"},"issue":{"href":"https://api.github.com/repos/artsy/reaction/issues/269"},"comments":{"href":"https://api.github.com/repos/artsy/reaction/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/reaction/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/reaction/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/reaction/statuses/0c3f2b716a50de16cc04e48876ca0ed2fc169efc"}},"author_association":"NONE"}}
|
{
"id": 81253735,
"name": "artsy/reaction",
"url": "https://api.github.com/repos/artsy/reaction"
}
|
{
"id": 5201004,
"login": "xtina-starr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5201004?",
"url": "https://api.github.com/users/xtina-starr"
}
|
{
"id": 546231,
"login": "artsy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/546231?",
"url": "https://api.github.com/orgs/artsy"
}
| 2017-10-09T20:22:21 |
6693443810
|
{"actor":{"display_login":"xtina-starr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/biola/customers/pulls/comments/100177987","pull_request_review_id":20875466,"id":100177987,"diff_hunk":"@@ -0,0 +1,71 @@\n+# Dynamically import data from csv for different classes\n+class Import\n+ include Mongoid::Document\n+ include Mongoid::Timestamps\n+ attr_accessor :import_errors\n+\n+ belongs_to :user # The importing user\n+\n+ field :import_class, type: String\n+ field :file_title, type: String\n+ field :field_mapping, type: Hash, default: {} # eg {class_attr: 'header_name'}\n+ field :number_of_records, type: Integer","path":"app/models/import.rb","position":12,"original_position":12,"commit_id":"a0f3c4b4d4e436355368dbc5c97936d5553868dc","original_commit_id":"a0f3c4b4d4e436355368dbc5c97936d5553868dc","user":{"login":"halloffame","id":957859,"avatar_url":"https://avatars.githubusercontent.com/u/957859?v=3","gravatar_id":"","url":"https://api.github.com/users/halloffame","html_url":"https://github.com/halloffame","followers_url":"https://api.github.com/users/halloffame/followers","following_url":"https://api.github.com/users/halloffame/following{/other_user}","gists_url":"https://api.github.com/users/halloffame/gists{/gist_id}","starred_url":"https://api.github.com/users/halloffame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halloffame/subscriptions","organizations_url":"https://api.github.com/users/halloffame/orgs","repos_url":"https://api.github.com/users/halloffame/repos","events_url":"https://api.github.com/users/halloffame/events{/privacy}","received_events_url":"https://api.github.com/users/halloffame/received_events","type":"User","site_admin":false},"body":"Should this default to 0?","created_at":"2017-02-08T21:45:41Z","updated_at":"2017-02-08T22:01:23Z","html_url":"https://github.com/biola/customers/pull/8#discussion_r100177987","pull_request_url":"https://api.github.com/repos/biola/customers/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/biola/customers/pulls/comments/100177987"},"html":{"href":"https://github.com/biola/customers/pull/8#discussion_r100177987"},"pull_request":{"href":"https://api.github.com/repos/biola/customers/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/biola/customers/pulls/8","id":105084326,"html_url":"https://github.com/biola/customers/pull/8","diff_url":"https://github.com/biola/customers/pull/8.diff","patch_url":"https://github.com/biola/customers/pull/8.patch","issue_url":"https://api.github.com/repos/biola/customers/issues/8","number":8,"state":"open","locked":false,"title":"Added general Import class for customers imports","user":{"login":"rift137","id":1801619,"avatar_url":"https://avatars.githubusercontent.com/u/1801619?v=3","gravatar_id":"","url":"https://api.github.com/users/rift137","html_url":"https://github.com/rift137","followers_url":"https://api.github.com/users/rift137/followers","following_url":"https://api.github.com/users/rift137/following{/other_user}","gists_url":"https://api.github.com/users/rift137/gists{/gist_id}","starred_url":"https://api.github.com/users/rift137/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rift137/subscriptions","organizations_url":"https://api.github.com/users/rift137/orgs","repos_url":"https://api.github.com/users/rift137/repos","events_url":"https://api.github.com/users/rift137/events{/privacy}","received_events_url":"https://api.github.com/users/rift137/received_events","type":"User","site_admin":false},"body":"Including rubocop settings file.","created_at":"2017-02-07T20:12:31Z","updated_at":"2017-02-08T22:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"504d2d8c7ebed19386c8c6bcfee9059382e34b1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/biola/customers/pulls/8/commits","review_comments_url":"https://api.github.com/repos/biola/customers/pulls/8/comments","review_comment_url":"https://api.github.com/repos/biola/customers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biola/customers/issues/8/comments","statuses_url":"https://api.github.com/repos/biola/customers/statuses/a0f3c4b4d4e436355368dbc5c97936d5553868dc","head":{"label":"biola:customer-import","ref":"customer-import","sha":"a0f3c4b4d4e436355368dbc5c97936d5553868dc","user":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"repo":{"id":64510492,"name":"customers","full_name":"biola/customers","owner":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biola/customers","description":"simple customer database ","fork":false,"url":"https://api.github.com/repos/biola/customers","forks_url":"https://api.github.com/repos/biola/customers/forks","keys_url":"https://api.github.com/repos/biola/customers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biola/customers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biola/customers/teams","hooks_url":"https://api.github.com/repos/biola/customers/hooks","issue_events_url":"https://api.github.com/repos/biola/customers/issues/events{/number}","events_url":"https://api.github.com/repos/biola/customers/events","assignees_url":"https://api.github.com/repos/biola/customers/assignees{/user}","branches_url":"https://api.github.com/repos/biola/customers/branches{/branch}","tags_url":"https://api.github.com/repos/biola/customers/tags","blobs_url":"https://api.github.com/repos/biola/customers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biola/customers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biola/customers/git/refs{/sha}","trees_url":"https://api.github.com/repos/biola/customers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biola/customers/statuses/{sha}","languages_url":"https://api.github.com/repos/biola/customers/languages","stargazers_url":"https://api.github.com/repos/biola/customers/stargazers","contributors_url":"https://api.github.com/repos/biola/customers/contributors","subscribers_url":"https://api.github.com/repos/biola/customers/subscribers","subscription_url":"https://api.github.com/repos/biola/customers/subscription","commits_url":"https://api.github.com/repos/biola/customers/commits{/sha}","git_commits_url":"https://api.github.com/repos/biola/customers/git/commits{/sha}","comments_url":"https://api.github.com/repos/biola/customers/comments{/number}","issue_comment_url":"https://api.github.com/repos/biola/customers/issues/comments{/number}","contents_url":"https://api.github.com/repos/biola/customers/contents/{+path}","compare_url":"https://api.github.com/repos/biola/customers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biola/customers/merges","archive_url":"https://api.github.com/repos/biola/customers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biola/customers/downloads","issues_url":"https://api.github.com/repos/biola/customers/issues{/number}","pulls_url":"https://api.github.com/repos/biola/customers/pulls{/number}","milestones_url":"https://api.github.com/repos/biola/customers/milestones{/number}","notifications_url":"https://api.github.com/repos/biola/customers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biola/customers/labels{/name}","releases_url":"https://api.github.com/repos/biola/customers/releases{/id}","deployments_url":"https://api.github.com/repos/biola/customers/deployments","created_at":"2016-07-29T21:06:46Z","updated_at":"2017-01-23T18:27:24Z","pushed_at":"2017-02-07T23:33:32Z","git_url":"git://github.com/biola/customers.git","ssh_url":"git@github.com:biola/customers.git","clone_url":"https://github.com/biola/customers.git","svn_url":"https://github.com/biola/customers","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"biola:master","ref":"master","sha":"59ebad44c892e430329af1be00fcfd2202854972","user":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"repo":{"id":64510492,"name":"customers","full_name":"biola/customers","owner":{"login":"biola","id":395114,"avatar_url":"https://avatars.githubusercontent.com/u/395114?v=3","gravatar_id":"","url":"https://api.github.com/users/biola","html_url":"https://github.com/biola","followers_url":"https://api.github.com/users/biola/followers","following_url":"https://api.github.com/users/biola/following{/other_user}","gists_url":"https://api.github.com/users/biola/gists{/gist_id}","starred_url":"https://api.github.com/users/biola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biola/subscriptions","organizations_url":"https://api.github.com/users/biola/orgs","repos_url":"https://api.github.com/users/biola/repos","events_url":"https://api.github.com/users/biola/events{/privacy}","received_events_url":"https://api.github.com/users/biola/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biola/customers","description":"simple customer database ","fork":false,"url":"https://api.github.com/repos/biola/customers","forks_url":"https://api.github.com/repos/biola/customers/forks","keys_url":"https://api.github.com/repos/biola/customers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biola/customers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biola/customers/teams","hooks_url":"https://api.github.com/repos/biola/customers/hooks","issue_events_url":"https://api.github.com/repos/biola/customers/issues/events{/number}","events_url":"https://api.github.com/repos/biola/customers/events","assignees_url":"https://api.github.com/repos/biola/customers/assignees{/user}","branches_url":"https://api.github.com/repos/biola/customers/branches{/branch}","tags_url":"https://api.github.com/repos/biola/customers/tags","blobs_url":"https://api.github.com/repos/biola/customers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biola/customers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biola/customers/git/refs{/sha}","trees_url":"https://api.github.com/repos/biola/customers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biola/customers/statuses/{sha}","languages_url":"https://api.github.com/repos/biola/customers/languages","stargazers_url":"https://api.github.com/repos/biola/customers/stargazers","contributors_url":"https://api.github.com/repos/biola/customers/contributors","subscribers_url":"https://api.github.com/repos/biola/customers/subscribers","subscription_url":"https://api.github.com/repos/biola/customers/subscription","commits_url":"https://api.github.com/repos/biola/customers/commits{/sha}","git_commits_url":"https://api.github.com/repos/biola/customers/git/commits{/sha}","comments_url":"https://api.github.com/repos/biola/customers/comments{/number}","issue_comment_url":"https://api.github.com/repos/biola/customers/issues/comments{/number}","contents_url":"https://api.github.com/repos/biola/customers/contents/{+path}","compare_url":"https://api.github.com/repos/biola/customers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biola/customers/merges","archive_url":"https://api.github.com/repos/biola/customers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biola/customers/downloads","issues_url":"https://api.github.com/repos/biola/customers/issues{/number}","pulls_url":"https://api.github.com/repos/biola/customers/pulls{/number}","milestones_url":"https://api.github.com/repos/biola/customers/milestones{/number}","notifications_url":"https://api.github.com/repos/biola/customers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biola/customers/labels{/name}","releases_url":"https://api.github.com/repos/biola/customers/releases{/id}","deployments_url":"https://api.github.com/repos/biola/customers/deployments","created_at":"2016-07-29T21:06:46Z","updated_at":"2017-01-23T18:27:24Z","pushed_at":"2017-02-07T23:33:32Z","git_url":"git://github.com/biola/customers.git","ssh_url":"git@github.com:biola/customers.git","clone_url":"https://github.com/biola/customers.git","svn_url":"https://github.com/biola/customers","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biola/customers/pulls/8"},"html":{"href":"https://github.com/biola/customers/pull/8"},"issue":{"href":"https://api.github.com/repos/biola/customers/issues/8"},"comments":{"href":"https://api.github.com/repos/biola/customers/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/biola/customers/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/biola/customers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biola/customers/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/biola/customers/statuses/a0f3c4b4d4e436355368dbc5c97936d5553868dc"}}}}
|
{
"id": 64510492,
"name": "biola/customers",
"url": "https://api.github.com/repos/biola/customers"
}
|
{
"id": 957859,
"login": "halloffame",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/957859?",
"url": "https://api.github.com/users/halloffame"
}
|
{
"id": 395114,
"login": "biola",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/395114?",
"url": "https://api.github.com/orgs/biola"
}
| 2017-02-08T21:45:41 |
5291250837
|
{"actor":{"display_login":"halloffame"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/137230525","pull_request_review_id":60868464,"id":137230525,"diff_hunk":"@@ -277,3 +294,21 @@ class AutofillAddressPanel extends React.Component {\n }\n \n module.exports = ReduxComponent.connect(AutofillAddressPanel)\n+\n+const styles = StyleSheet.create({\n+ // Copied from textbox.js\n+ input: {\n+ width: '100%'\n+ },\n+\n+ sectionWrapper__expirationDate: {","path":"app/renderer/components/autofill/autofillAddressPanel.js","position":89,"original_position":89,"commit_id":"454747bc812b90287419e030232b1076f5852d83","original_commit_id":"454747bc812b90287419e030232b1076f5852d83","user":{"login":"luixxiul","id":3362943,"avatar_url":"https://avatars3.githubusercontent.com/u/3362943?v=4","gravatar_id":"","url":"https://api.github.com/users/luixxiul","html_url":"https://github.com/luixxiul","followers_url":"https://api.github.com/users/luixxiul/followers","following_url":"https://api.github.com/users/luixxiul/following{/other_user}","gists_url":"https://api.github.com/users/luixxiul/gists{/gist_id}","starred_url":"https://api.github.com/users/luixxiul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luixxiul/subscriptions","organizations_url":"https://api.github.com/users/luixxiul/orgs","repos_url":"https://api.github.com/users/luixxiul/repos","events_url":"https://api.github.com/users/luixxiul/events{/privacy}","received_events_url":"https://api.github.com/users/luixxiul/received_events","type":"User","site_admin":false},"body":"Is this necessary?","created_at":"2017-09-06T10:34:47Z","updated_at":"2017-09-06T10:34:47Z","html_url":"https://github.com/brave/browser-laptop/pull/10300#discussion_r137230525","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10300","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/137230525"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10300#discussion_r137230525"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10300"}}},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/10300","id":134230364,"html_url":"https://github.com/brave/browser-laptop/pull/10300","diff_url":"https://github.com/brave/browser-laptop/pull/10300.diff","patch_url":"https://github.com/brave/browser-laptop/pull/10300.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/10300","number":10300,"state":"open","locked":false,"title":"Issue #9053: Making country field in autofill a dropdown list instead of text input box.","user":{"login":"dfperry5","id":8182684,"avatar_url":"https://avatars2.githubusercontent.com/u/8182684?v=4","gravatar_id":"","url":"https://api.github.com/users/dfperry5","html_url":"https://github.com/dfperry5","followers_url":"https://api.github.com/users/dfperry5/followers","following_url":"https://api.github.com/users/dfperry5/following{/other_user}","gists_url":"https://api.github.com/users/dfperry5/gists{/gist_id}","starred_url":"https://api.github.com/users/dfperry5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfperry5/subscriptions","organizations_url":"https://api.github.com/users/dfperry5/orgs","repos_url":"https://api.github.com/users/dfperry5/repos","events_url":"https://api.github.com/users/dfperry5/events{/privacy}","received_events_url":"https://api.github.com/users/dfperry5/received_events","type":"User","site_admin":false},"body":"Fixes #9053\r\n\r\nSubmitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n\r\nTest Plan:\r\n\r\n\r\nReviewer Checklist:\r\n\r\nTests\r\n\r\n\r\n- [x] Adequate test coverage exists to prevent regressions\r\n- [x] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [x] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2017-08-04T18:58:03Z","updated_at":"2017-09-06T10:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c909193c0dc9e93231a8b959a277d518379245b0","assignee":{"login":"dfperry5","id":8182684,"avatar_url":"https://avatars2.githubusercontent.com/u/8182684?v=4","gravatar_id":"","url":"https://api.github.com/users/dfperry5","html_url":"https://github.com/dfperry5","followers_url":"https://api.github.com/users/dfperry5/followers","following_url":"https://api.github.com/users/dfperry5/following{/other_user}","gists_url":"https://api.github.com/users/dfperry5/gists{/gist_id}","starred_url":"https://api.github.com/users/dfperry5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfperry5/subscriptions","organizations_url":"https://api.github.com/users/dfperry5/orgs","repos_url":"https://api.github.com/users/dfperry5/repos","events_url":"https://api.github.com/users/dfperry5/events{/privacy}","received_events_url":"https://api.github.com/users/dfperry5/received_events","type":"User","site_admin":false},"assignees":[{"login":"dfperry5","id":8182684,"avatar_url":"https://avatars2.githubusercontent.com/u/8182684?v=4","gravatar_id":"","url":"https://api.github.com/users/dfperry5","html_url":"https://github.com/dfperry5","followers_url":"https://api.github.com/users/dfperry5/followers","following_url":"https://api.github.com/users/dfperry5/following{/other_user}","gists_url":"https://api.github.com/users/dfperry5/gists{/gist_id}","starred_url":"https://api.github.com/users/dfperry5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfperry5/subscriptions","organizations_url":"https://api.github.com/users/dfperry5/orgs","repos_url":"https://api.github.com/users/dfperry5/repos","events_url":"https://api.github.com/users/dfperry5/events{/privacy}","received_events_url":"https://api.github.com/users/dfperry5/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"darkdh","id":11330831,"avatar_url":"https://avatars0.githubusercontent.com/u/11330831?v=4","gravatar_id":"","url":"https://api.github.com/users/darkdh","html_url":"https://github.com/darkdh","followers_url":"https://api.github.com/users/darkdh/followers","following_url":"https://api.github.com/users/darkdh/following{/other_user}","gists_url":"https://api.github.com/users/darkdh/gists{/gist_id}","starred_url":"https://api.github.com/users/darkdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkdh/subscriptions","organizations_url":"https://api.github.com/users/darkdh/orgs","repos_url":"https://api.github.com/users/darkdh/repos","events_url":"https://api.github.com/users/darkdh/events{/privacy}","received_events_url":"https://api.github.com/users/darkdh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/81","html_url":"https://github.com/brave/browser-laptop/milestone/81","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/81/labels","id":2666281,"number":81,"title":"0.22.x","description":" - #6708 - possible way to erase ledger info (auto erase on each reconciliation?)\r\n - tab dragging improvements (locking x axis for tabs)","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":0,"state":"open","created_at":"2017-07-27T22:25:26Z","updated_at":"2017-09-06T10:11:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10300/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/10300/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/10300/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/454747bc812b90287419e030232b1076f5852d83","head":{"label":"dfperry5:master","ref":"master","sha":"454747bc812b90287419e030232b1076f5852d83","user":{"login":"dfperry5","id":8182684,"avatar_url":"https://avatars2.githubusercontent.com/u/8182684?v=4","gravatar_id":"","url":"https://api.github.com/users/dfperry5","html_url":"https://github.com/dfperry5","followers_url":"https://api.github.com/users/dfperry5/followers","following_url":"https://api.github.com/users/dfperry5/following{/other_user}","gists_url":"https://api.github.com/users/dfperry5/gists{/gist_id}","starred_url":"https://api.github.com/users/dfperry5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfperry5/subscriptions","organizations_url":"https://api.github.com/users/dfperry5/orgs","repos_url":"https://api.github.com/users/dfperry5/repos","events_url":"https://api.github.com/users/dfperry5/events{/privacy}","received_events_url":"https://api.github.com/users/dfperry5/received_events","type":"User","site_admin":false},"repo":{"id":99050765,"name":"browser-laptop","full_name":"dfperry5/browser-laptop","owner":{"login":"dfperry5","id":8182684,"avatar_url":"https://avatars2.githubusercontent.com/u/8182684?v=4","gravatar_id":"","url":"https://api.github.com/users/dfperry5","html_url":"https://github.com/dfperry5","followers_url":"https://api.github.com/users/dfperry5/followers","following_url":"https://api.github.com/users/dfperry5/following{/other_user}","gists_url":"https://api.github.com/users/dfperry5/gists{/gist_id}","starred_url":"https://api.github.com/users/dfperry5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfperry5/subscriptions","organizations_url":"https://api.github.com/users/dfperry5/orgs","repos_url":"https://api.github.com/users/dfperry5/repos","events_url":"https://api.github.com/users/dfperry5/events{/privacy}","received_events_url":"https://api.github.com/users/dfperry5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfperry5/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/dfperry5/browser-laptop","forks_url":"https://api.github.com/repos/dfperry5/browser-laptop/forks","keys_url":"https://api.github.com/repos/dfperry5/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfperry5/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfperry5/browser-laptop/teams","hooks_url":"https://api.github.com/repos/dfperry5/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/dfperry5/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/dfperry5/browser-laptop/events","assignees_url":"https://api.github.com/repos/dfperry5/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/dfperry5/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/dfperry5/browser-laptop/tags","blobs_url":"https://api.github.com/repos/dfperry5/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfperry5/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfperry5/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfperry5/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfperry5/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/dfperry5/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/dfperry5/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/dfperry5/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/dfperry5/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/dfperry5/browser-laptop/subscription","commits_url":"https://api.github.com/repos/dfperry5/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfperry5/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfperry5/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfperry5/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfperry5/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/dfperry5/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfperry5/browser-laptop/merges","archive_url":"https://api.github.com/repos/dfperry5/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfperry5/browser-laptop/downloads","issues_url":"https://api.github.com/repos/dfperry5/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/dfperry5/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/dfperry5/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/dfperry5/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfperry5/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/dfperry5/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/dfperry5/browser-laptop/deployments","created_at":"2017-08-01T23:13:28Z","updated_at":"2017-08-01T23:13:33Z","pushed_at":"2017-09-04T21:01:44Z","git_url":"git://github.com/dfperry5/browser-laptop.git","ssh_url":"git@github.com:dfperry5/browser-laptop.git","clone_url":"https://github.com/dfperry5/browser-laptop.git","svn_url":"https://github.com/dfperry5/browser-laptop","homepage":"https://www.brave.com","size":51314,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"027589c3053e4e0581a3c5508b75c6fd600659f4","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2017-09-06T06:50:47Z","pushed_at":"2017-09-06T09:40:22Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":52900,"stargazers_count":5672,"watchers_count":5672,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":682,"mirror_url":null,"open_issues_count":2478,"forks":682,"open_issues":2478,"watchers":5672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10300"},"html":{"href":"https://github.com/brave/browser-laptop/pull/10300"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10300"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/10300/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10300/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/10300/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/454747bc812b90287419e030232b1076f5852d83"}},"author_association":"NONE"}}
|
{
"id": 46891997,
"name": "brave/browser-laptop",
"url": "https://api.github.com/repos/brave/browser-laptop"
}
|
{
"id": 3362943,
"login": "luixxiul",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3362943?",
"url": "https://api.github.com/users/luixxiul"
}
|
{
"id": 12301619,
"login": "brave",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12301619?",
"url": "https://api.github.com/orgs/brave"
}
| 2017-09-06T10:34:47 |
6555512228
|
{"actor":{"display_login":"luixxiul"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/canjs/can-define/pulls/comments/141634042","pull_request_review_id":65878632,"id":141634042,"diff_hunk":"@@ -1445,7 +1453,7 @@ Object.defineProperty(DefineList.prototype, \"length\", {\n \t\t\treturn;\n \t\t}\n \n-\t\tif (newVal === this._length) {\n+\t\tif (newVal == null || isNaN(+newVal) || newVal === this._length) {","path":"list/list.js","position":185,"original_position":31,"commit_id":"9056d22ebce4ccd378593ebd73070cd6cf191242","original_commit_id":"f385cc6e58188f676ea002a659d41c8ac6e52706","user":{"login":"phillipskevin","id":5851984,"avatar_url":"https://avatars2.githubusercontent.com/u/5851984?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipskevin","html_url":"https://github.com/phillipskevin","followers_url":"https://api.github.com/users/phillipskevin/followers","following_url":"https://api.github.com/users/phillipskevin/following{/other_user}","gists_url":"https://api.github.com/users/phillipskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipskevin/subscriptions","organizations_url":"https://api.github.com/users/phillipskevin/orgs","repos_url":"https://api.github.com/users/phillipskevin/repos","events_url":"https://api.github.com/users/phillipskevin/events{/privacy}","received_events_url":"https://api.github.com/users/phillipskevin/received_events","type":"User","site_admin":false},"body":"Some comments explaining these cases would be helpful.","created_at":"2017-09-28T14:27:20Z","updated_at":"2017-09-28T14:28:32Z","html_url":"https://github.com/canjs/can-define/pull/250#discussion_r141634042","pull_request_url":"https://api.github.com/repos/canjs/can-define/pulls/250","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/canjs/can-define/pulls/comments/141634042"},"html":{"href":"https://github.com/canjs/can-define/pull/250#discussion_r141634042"},"pull_request":{"href":"https://api.github.com/repos/canjs/can-define/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/canjs/can-define/pulls/250","id":135635258,"html_url":"https://github.com/canjs/can-define/pull/250","diff_url":"https://github.com/canjs/can-define/pull/250.diff","patch_url":"https://github.com/canjs/can-define/pull/250.patch","issue_url":"https://api.github.com/repos/canjs/can-define/issues/250","number":250,"state":"open","locked":false,"title":"Deprecate passing an object to .set","user":{"login":"obaidott","id":18535169,"avatar_url":"https://avatars3.githubusercontent.com/u/18535169?v=4","gravatar_id":"","url":"https://api.github.com/users/obaidott","html_url":"https://github.com/obaidott","followers_url":"https://api.github.com/users/obaidott/followers","following_url":"https://api.github.com/users/obaidott/following{/other_user}","gists_url":"https://api.github.com/users/obaidott/gists{/gist_id}","starred_url":"https://api.github.com/users/obaidott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obaidott/subscriptions","organizations_url":"https://api.github.com/users/obaidott/orgs","repos_url":"https://api.github.com/users/obaidott/repos","events_url":"https://api.github.com/users/obaidott/events{/privacy}","received_events_url":"https://api.github.com/users/obaidott/received_events","type":"User","site_admin":false},"body":"This PR addresses the first part of issue #245 \r\n\r\n- [x] Create / document assign on DefineMap\r\n- [x] Create / document update on DefineMap\r\n- [x] Create / document deepAssign on DefineMap\r\n- [x] Create / document deepUpdate on DefineMap\r\nand..\r\n- [x] Create / document assign on DefineList\r\n- [x] Create / document update on DefineList\r\n- [x] Create / document deepAssign on DefineList\r\n- [x] Create / document deepUpdate on DefineList","created_at":"2017-08-14T16:27:13Z","updated_at":"2017-09-28T14:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7800046cc007218d8a0b5cc7ee0cfdd9a54987a1","assignee":{"login":"phillipskevin","id":5851984,"avatar_url":"https://avatars2.githubusercontent.com/u/5851984?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipskevin","html_url":"https://github.com/phillipskevin","followers_url":"https://api.github.com/users/phillipskevin/followers","following_url":"https://api.github.com/users/phillipskevin/following{/other_user}","gists_url":"https://api.github.com/users/phillipskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipskevin/subscriptions","organizations_url":"https://api.github.com/users/phillipskevin/orgs","repos_url":"https://api.github.com/users/phillipskevin/repos","events_url":"https://api.github.com/users/phillipskevin/events{/privacy}","received_events_url":"https://api.github.com/users/phillipskevin/received_events","type":"User","site_admin":false},"assignees":[{"login":"phillipskevin","id":5851984,"avatar_url":"https://avatars2.githubusercontent.com/u/5851984?v=4","gravatar_id":"","url":"https://api.github.com/users/phillipskevin","html_url":"https://github.com/phillipskevin","followers_url":"https://api.github.com/users/phillipskevin/followers","following_url":"https://api.github.com/users/phillipskevin/following{/other_user}","gists_url":"https://api.github.com/users/phillipskevin/gists{/gist_id}","starred_url":"https://api.github.com/users/phillipskevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phillipskevin/subscriptions","organizations_url":"https://api.github.com/users/phillipskevin/orgs","repos_url":"https://api.github.com/users/phillipskevin/repos","events_url":"https://api.github.com/users/phillipskevin/events{/privacy}","received_events_url":"https://api.github.com/users/phillipskevin/received_events","type":"User","site_admin":false},{"login":"bmomberger-bitovi","id":18686722,"avatar_url":"https://avatars3.githubusercontent.com/u/18686722?v=4","gravatar_id":"","url":"https://api.github.com/users/bmomberger-bitovi","html_url":"https://github.com/bmomberger-bitovi","followers_url":"https://api.github.com/users/bmomberger-bitovi/followers","following_url":"https://api.github.com/users/bmomberger-bitovi/following{/other_user}","gists_url":"https://api.github.com/users/bmomberger-bitovi/gists{/gist_id}","starred_url":"https://api.github.com/users/bmomberger-bitovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmomberger-bitovi/subscriptions","organizations_url":"https://api.github.com/users/bmomberger-bitovi/orgs","repos_url":"https://api.github.com/users/bmomberger-bitovi/repos","events_url":"https://api.github.com/users/bmomberger-bitovi/events{/privacy}","received_events_url":"https://api.github.com/users/bmomberger-bitovi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/canjs/can-define/pulls/250/commits","review_comments_url":"https://api.github.com/repos/canjs/can-define/pulls/250/comments","review_comment_url":"https://api.github.com/repos/canjs/can-define/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canjs/can-define/issues/250/comments","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/9056d22ebce4ccd378593ebd73070cd6cf191242","head":{"label":"canjs:245-deprecate-set","ref":"245-deprecate-set","sha":"9056d22ebce4ccd378593ebd73070cd6cf191242","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48712549,"name":"can-define","full_name":"canjs/can-define","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-define","description":"Observable properties","fork":false,"url":"https://api.github.com/repos/canjs/can-define","forks_url":"https://api.github.com/repos/canjs/can-define/forks","keys_url":"https://api.github.com/repos/canjs/can-define/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-define/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-define/teams","hooks_url":"https://api.github.com/repos/canjs/can-define/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-define/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-define/events","assignees_url":"https://api.github.com/repos/canjs/can-define/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-define/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-define/tags","blobs_url":"https://api.github.com/repos/canjs/can-define/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-define/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-define/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-define/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-define/languages","stargazers_url":"https://api.github.com/repos/canjs/can-define/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-define/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-define/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-define/subscription","commits_url":"https://api.github.com/repos/canjs/can-define/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-define/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-define/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-define/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-define/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-define/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-define/merges","archive_url":"https://api.github.com/repos/canjs/can-define/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-define/downloads","issues_url":"https://api.github.com/repos/canjs/can-define/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-define/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-define/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-define/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-define/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-define/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-define/deployments","created_at":"2015-12-28T21:13:05Z","updated_at":"2017-09-24T22:27:49Z","pushed_at":"2017-09-28T12:15:45Z","git_url":"git://github.com/canjs/can-define.git","ssh_url":"git@github.com:canjs/can-define.git","clone_url":"https://github.com/canjs/can-define.git","svn_url":"https://github.com/canjs/can-define","homepage":"https://canjs.com/doc/can-define.html","size":1155,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":29,"forks":6,"open_issues":29,"watchers":13,"default_branch":"master"}},"base":{"label":"canjs:master","ref":"master","sha":"dd48c5273ef87962fa144aa2b49583433189ba2c","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":48712549,"name":"can-define","full_name":"canjs/can-define","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-define","description":"Observable properties","fork":false,"url":"https://api.github.com/repos/canjs/can-define","forks_url":"https://api.github.com/repos/canjs/can-define/forks","keys_url":"https://api.github.com/repos/canjs/can-define/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-define/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-define/teams","hooks_url":"https://api.github.com/repos/canjs/can-define/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-define/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-define/events","assignees_url":"https://api.github.com/repos/canjs/can-define/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-define/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-define/tags","blobs_url":"https://api.github.com/repos/canjs/can-define/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-define/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-define/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-define/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-define/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-define/languages","stargazers_url":"https://api.github.com/repos/canjs/can-define/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-define/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-define/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-define/subscription","commits_url":"https://api.github.com/repos/canjs/can-define/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-define/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-define/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-define/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-define/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-define/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-define/merges","archive_url":"https://api.github.com/repos/canjs/can-define/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-define/downloads","issues_url":"https://api.github.com/repos/canjs/can-define/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-define/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-define/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-define/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-define/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-define/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-define/deployments","created_at":"2015-12-28T21:13:05Z","updated_at":"2017-09-24T22:27:49Z","pushed_at":"2017-09-28T12:15:45Z","git_url":"git://github.com/canjs/can-define.git","ssh_url":"git@github.com:canjs/can-define.git","clone_url":"https://github.com/canjs/can-define.git","svn_url":"https://github.com/canjs/can-define","homepage":"https://canjs.com/doc/can-define.html","size":1155,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":29,"forks":6,"open_issues":29,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canjs/can-define/pulls/250"},"html":{"href":"https://github.com/canjs/can-define/pull/250"},"issue":{"href":"https://api.github.com/repos/canjs/can-define/issues/250"},"comments":{"href":"https://api.github.com/repos/canjs/can-define/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/canjs/can-define/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/canjs/can-define/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canjs/can-define/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/canjs/can-define/statuses/9056d22ebce4ccd378593ebd73070cd6cf191242"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 48712549,
"name": "canjs/can-define",
"url": "https://api.github.com/repos/canjs/can-define"
}
|
{
"id": 5851984,
"login": "phillipskevin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5851984?",
"url": "https://api.github.com/users/phillipskevin"
}
|
{
"id": 11798761,
"login": "canjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11798761?",
"url": "https://api.github.com/orgs/canjs"
}
| 2017-09-28T14:27:20 |
6649832045
|
{"actor":{"display_login":"phillipskevin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chain/chain/pulls/comments/111832186","pull_request_review_id":33101847,"id":111832186,"diff_hunk":"@@ -0,0 +1,98 @@\n+import React from 'react'\n+import { chainClient } from 'utility/environment'\n+import { baseListActions } from 'features/shared/actions'\n+import { actions as appActions } from 'features/app'\n+import { push } from 'react-router-redux'\n+import TokenCreateModal from './components/TokenCreateModal'\n+\n+const baseActions = baseListActions('accessControl', {\n+ clientApi: () => chainClient().accessControl\n+})\n+\n+export default {\n+ fetchItems: () => {\n+ return (dispatch) => {\n+ const promise = chainClient().accessControl.list()\n+\n+ promise.then(\n+ (param) => dispatch({\n+ type: 'RECEIVED_ACCESSCONTROL_ITEMS',\n+ param,\n+ })\n+ )\n+\n+ return promise\n+ }\n+ },\n+\n+ deleteItem: baseActions.deleteItem,\n+\n+ submitTokenForm: data => {\n+ const body = {...data}\n+\n+ body.guardType = 'access_token'\n+\n+ return function(dispatch) {\n+ return chainClient().accessTokens.create({\n+ id: body.guardData.id,\n+ type: 'client', // TODO: remove me when deprecated!\n+ }).then(tokenResp => {\n+ chainClient().accessControl.create(body).then(grantResp => {\n+ dispatch(appActions.showModal(\n+ <TokenCreateModal token={tokenResp.token}/>,\n+ appActions.hideModal\n+ ))\n+\n+ dispatch({ type: 'CREATED_ACCESSTOKEN', grantResp })\n+\n+ dispatch(push({\n+ pathname: '/access-control',\n+ search: '?type=token',\n+ state: {preserveFlash: true},\n+ }))\n+ })\n+ }).catch(err => Promise.reject({_error: err}))\n+ }\n+ },\n+\n+ submitCertificateForm: data => {\n+ const subject = data.subject\n+ delete data.subject","path":"dashboard/src/features/accessControl/actions.js","position":60,"original_position":60,"commit_id":"9073f68930e92745265bb099934381f8a55c4fdc","original_commit_id":"9073f68930e92745265bb099934381f8a55c4fdc","user":{"login":"dominic","id":185645,"avatar_url":"https://avatars2.githubusercontent.com/u/185645?v=3","gravatar_id":"","url":"https://api.github.com/users/dominic","html_url":"https://github.com/dominic","followers_url":"https://api.github.com/users/dominic/followers","following_url":"https://api.github.com/users/dominic/following{/other_user}","gists_url":"https://api.github.com/users/dominic/gists{/gist_id}","starred_url":"https://api.github.com/users/dominic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominic/subscriptions","organizations_url":"https://api.github.com/users/dominic/orgs","repos_url":"https://api.github.com/users/dominic/repos","events_url":"https://api.github.com/users/dominic/events{/privacy}","received_events_url":"https://api.github.com/users/dominic/received_events","type":"User","site_admin":false},"body":"Refactor for multiple policies.","created_at":"2017-04-17T22:03:53Z","updated_at":"2017-04-17T22:03:53Z","html_url":"https://github.com/chain/chain/pull/945#discussion_r111832186","pull_request_url":"https://api.github.com/repos/chain/chain/pulls/945","_links":{"self":{"href":"https://api.github.com/repos/chain/chain/pulls/comments/111832186"},"html":{"href":"https://github.com/chain/chain/pull/945#discussion_r111832186"},"pull_request":{"href":"https://api.github.com/repos/chain/chain/pulls/945"}}},"pull_request":{"url":"https://api.github.com/repos/chain/chain/pulls/945","id":116007780,"html_url":"https://github.com/chain/chain/pull/945","diff_url":"https://github.com/chain/chain/pull/945.diff","patch_url":"https://github.com/chain/chain/pull/945.patch","issue_url":"https://api.github.com/repos/chain/chain/issues/945","number":945,"state":"open","locked":false,"title":"dashboard: add access control interface","user":{"login":"dominic","id":185645,"avatar_url":"https://avatars2.githubusercontent.com/u/185645?v=3","gravatar_id":"","url":"https://api.github.com/users/dominic","html_url":"https://github.com/dominic","followers_url":"https://api.github.com/users/dominic/followers","following_url":"https://api.github.com/users/dominic/following{/other_user}","gists_url":"https://api.github.com/users/dominic/gists{/gist_id}","starred_url":"https://api.github.com/users/dominic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominic/subscriptions","organizations_url":"https://api.github.com/users/dominic/orgs","repos_url":"https://api.github.com/users/dominic/repos","events_url":"https://api.github.com/users/dominic/events{/privacy}","received_events_url":"https://api.github.com/users/dominic/received_events","type":"User","site_admin":false},"body":"Adds the ability to grant policy permissions to access tokens and x509 certs \r\nbased on cert subject field. Replaces `Client Token` and `Network Token`\r\nsections in the secondary navigation.","created_at":"2017-04-15T00:52:51Z","updated_at":"2017-04-17T22:03:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41506d004a357ac6b72fa772cbf5e47629599ebb","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/chain/chain/pulls/945/commits","review_comments_url":"https://api.github.com/repos/chain/chain/pulls/945/comments","review_comment_url":"https://api.github.com/repos/chain/chain/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chain/chain/issues/945/comments","statuses_url":"https://api.github.com/repos/chain/chain/statuses/9073f68930e92745265bb099934381f8a55c4fdc","head":{"label":"chain:acl-dashboard","ref":"acl-dashboard","sha":"9073f68930e92745265bb099934381f8a55c4fdc","user":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"repo":{"id":71740230,"name":"chain","full_name":"chain/chain","owner":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chain/chain","description":"Chain Core Developer Edition","fork":false,"url":"https://api.github.com/repos/chain/chain","forks_url":"https://api.github.com/repos/chain/chain/forks","keys_url":"https://api.github.com/repos/chain/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chain/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chain/chain/teams","hooks_url":"https://api.github.com/repos/chain/chain/hooks","issue_events_url":"https://api.github.com/repos/chain/chain/issues/events{/number}","events_url":"https://api.github.com/repos/chain/chain/events","assignees_url":"https://api.github.com/repos/chain/chain/assignees{/user}","branches_url":"https://api.github.com/repos/chain/chain/branches{/branch}","tags_url":"https://api.github.com/repos/chain/chain/tags","blobs_url":"https://api.github.com/repos/chain/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chain/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chain/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/chain/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chain/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/chain/chain/languages","stargazers_url":"https://api.github.com/repos/chain/chain/stargazers","contributors_url":"https://api.github.com/repos/chain/chain/contributors","subscribers_url":"https://api.github.com/repos/chain/chain/subscribers","subscription_url":"https://api.github.com/repos/chain/chain/subscription","commits_url":"https://api.github.com/repos/chain/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/chain/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/chain/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/chain/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/chain/chain/contents/{+path}","compare_url":"https://api.github.com/repos/chain/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chain/chain/merges","archive_url":"https://api.github.com/repos/chain/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chain/chain/downloads","issues_url":"https://api.github.com/repos/chain/chain/issues{/number}","pulls_url":"https://api.github.com/repos/chain/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/chain/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/chain/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chain/chain/labels{/name}","releases_url":"https://api.github.com/repos/chain/chain/releases{/id}","deployments_url":"https://api.github.com/repos/chain/chain/deployments","created_at":"2016-10-24T01:12:26Z","updated_at":"2017-04-15T17:47:06Z","pushed_at":"2017-04-17T22:01:03Z","git_url":"git://github.com/chain/chain.git","ssh_url":"git@github.com:chain/chain.git","clone_url":"https://github.com/chain/chain.git","svn_url":"https://github.com/chain/chain","homepage":"https://chain.com","size":121476,"stargazers_count":847,"watchers_count":847,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":42,"forks":137,"open_issues":42,"watchers":847,"default_branch":"main"}},"base":{"label":"chain:main","ref":"main","sha":"0bb897e72c22b22658fef0078e8f86431071cfd0","user":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"repo":{"id":71740230,"name":"chain","full_name":"chain/chain","owner":{"login":"chain","id":412728,"avatar_url":"https://avatars0.githubusercontent.com/u/412728?v=3","gravatar_id":"","url":"https://api.github.com/users/chain","html_url":"https://github.com/chain","followers_url":"https://api.github.com/users/chain/followers","following_url":"https://api.github.com/users/chain/following{/other_user}","gists_url":"https://api.github.com/users/chain/gists{/gist_id}","starred_url":"https://api.github.com/users/chain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chain/subscriptions","organizations_url":"https://api.github.com/users/chain/orgs","repos_url":"https://api.github.com/users/chain/repos","events_url":"https://api.github.com/users/chain/events{/privacy}","received_events_url":"https://api.github.com/users/chain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chain/chain","description":"Chain Core Developer Edition","fork":false,"url":"https://api.github.com/repos/chain/chain","forks_url":"https://api.github.com/repos/chain/chain/forks","keys_url":"https://api.github.com/repos/chain/chain/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chain/chain/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chain/chain/teams","hooks_url":"https://api.github.com/repos/chain/chain/hooks","issue_events_url":"https://api.github.com/repos/chain/chain/issues/events{/number}","events_url":"https://api.github.com/repos/chain/chain/events","assignees_url":"https://api.github.com/repos/chain/chain/assignees{/user}","branches_url":"https://api.github.com/repos/chain/chain/branches{/branch}","tags_url":"https://api.github.com/repos/chain/chain/tags","blobs_url":"https://api.github.com/repos/chain/chain/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chain/chain/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chain/chain/git/refs{/sha}","trees_url":"https://api.github.com/repos/chain/chain/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chain/chain/statuses/{sha}","languages_url":"https://api.github.com/repos/chain/chain/languages","stargazers_url":"https://api.github.com/repos/chain/chain/stargazers","contributors_url":"https://api.github.com/repos/chain/chain/contributors","subscribers_url":"https://api.github.com/repos/chain/chain/subscribers","subscription_url":"https://api.github.com/repos/chain/chain/subscription","commits_url":"https://api.github.com/repos/chain/chain/commits{/sha}","git_commits_url":"https://api.github.com/repos/chain/chain/git/commits{/sha}","comments_url":"https://api.github.com/repos/chain/chain/comments{/number}","issue_comment_url":"https://api.github.com/repos/chain/chain/issues/comments{/number}","contents_url":"https://api.github.com/repos/chain/chain/contents/{+path}","compare_url":"https://api.github.com/repos/chain/chain/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chain/chain/merges","archive_url":"https://api.github.com/repos/chain/chain/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chain/chain/downloads","issues_url":"https://api.github.com/repos/chain/chain/issues{/number}","pulls_url":"https://api.github.com/repos/chain/chain/pulls{/number}","milestones_url":"https://api.github.com/repos/chain/chain/milestones{/number}","notifications_url":"https://api.github.com/repos/chain/chain/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chain/chain/labels{/name}","releases_url":"https://api.github.com/repos/chain/chain/releases{/id}","deployments_url":"https://api.github.com/repos/chain/chain/deployments","created_at":"2016-10-24T01:12:26Z","updated_at":"2017-04-15T17:47:06Z","pushed_at":"2017-04-17T22:01:03Z","git_url":"git://github.com/chain/chain.git","ssh_url":"git@github.com:chain/chain.git","clone_url":"https://github.com/chain/chain.git","svn_url":"https://github.com/chain/chain","homepage":"https://chain.com","size":121476,"stargazers_count":847,"watchers_count":847,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"open_issues_count":42,"forks":137,"open_issues":42,"watchers":847,"default_branch":"main"}},"_links":{"self":{"href":"https://api.github.com/repos/chain/chain/pulls/945"},"html":{"href":"https://github.com/chain/chain/pull/945"},"issue":{"href":"https://api.github.com/repos/chain/chain/issues/945"},"comments":{"href":"https://api.github.com/repos/chain/chain/issues/945/comments"},"review_comments":{"href":"https://api.github.com/repos/chain/chain/pulls/945/comments"},"review_comment":{"href":"https://api.github.com/repos/chain/chain/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chain/chain/pulls/945/commits"},"statuses":{"href":"https://api.github.com/repos/chain/chain/statuses/9073f68930e92745265bb099934381f8a55c4fdc"}}}}
|
{
"id": 71740230,
"name": "chain/chain",
"url": "https://api.github.com/repos/chain/chain"
}
|
{
"id": 185645,
"login": "dominic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/185645?",
"url": "https://api.github.com/users/dominic"
}
|
{
"id": 412728,
"login": "chain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/412728?",
"url": "https://api.github.com/orgs/chain"
}
| 2017-04-17T22:03:53 |
5702917528
|
{"actor":{"display_login":"dominic"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/112270044","pull_request_review_id":33571819,"id":112270044,"diff_hunk":"@@ -0,0 +1,123 @@\n+# Insert appropriate license here\n+require_relative 'node_util'\n+require_relative 'interface'\n+\n+module Cisco\n+ # node utils class for SPAN (switchport analyzer) sessions\n+ class SpanSession < NodeUtil\n+ attr_reader :session_id\n+\n+ def initialize(session_id, instantiate=true)\n+ validate_args(session_id.to_i)\n+ create if instantiate\n+ end\n+\n+ def self.sessions\n+ hash = {}\n+ all = config_get('span_session', 'all_sessions')\n+ return hash if all.nil?\n+\n+ all.each do |id|\n+ hash[id] = SpanSession.new(id, false)\n+ end\n+ hash\n+ end\n+\n+ def validate_args(session_id)\n+ fail TypeError unless session_id.is_a?(Integer)\n+ @session_id = session_id\n+ end\n+\n+ def create\n+ config_set('span_session', 'create', id: @session_id)\n+ end\n+\n+ def destroy\n+ config_set('span_session', 'destroy', id: @session_id)\n+ end\n+\n+ def description\n+ config_get('span_session', 'description', id: @session_id)\n+ end\n+\n+ def description=(val)\n+ val = val.to_s\n+ if val.empty?\n+ config_set('span_session', 'description', id: @session_id,\n+ state: 'no', description: '')\n+ else\n+ config_set('span_session', 'description', id: @session_id,\n+ state: '', description: val)\n+ end\n+ end\n+\n+ def destination\n+ config_get('span_session', 'destination', id: @session_id)\n+ end\n+\n+ def destination=(int)\n+ # fail if int is not a valid interface\n+ fail TypeError unless Interface.interfaces.key?(int)\n+ config_set('span_session', 'destination', id: @session_id, intf_name: int)\n+ end\n+\n+ def session_id\n+ config_get('span_session', 'session_id')\n+ end\n+\n+ def session_id=(id)\n+ fail TypeError unless id.is_a?(Integer)\n+ config_set('span_session', 'session_id', id: id, state: '')\n+ end\n+\n+ def shutdown\n+ config_get('span_session', 'shutdown', id: @session_id)\n+ end\n+\n+ def shutdown=(bool)\n+ fail TypeError unless bool.is_a?(Boolean)\n+ config_set('span_session', 'shutdown', id: @session_id, shutdown: bool)\n+ end\n+\n+ def source_interface\n+ config_get('span_session', 'source_interface', id: @session_id)\n+ end\n+\n+ def source_interface=(sources)","path":"lib/cisco_node_utils/span_session.rb","position":86,"original_position":86,"commit_id":"7987e8339fb1d3f00d8e018699fc92a50af7847c","original_commit_id":"7987e8339fb1d3f00d8e018699fc92a50af7847c","user":{"login":"mikewiebe","id":12445795,"avatar_url":"https://avatars1.githubusercontent.com/u/12445795?v=3","gravatar_id":"","url":"https://api.github.com/users/mikewiebe","html_url":"https://github.com/mikewiebe","followers_url":"https://api.github.com/users/mikewiebe/followers","following_url":"https://api.github.com/users/mikewiebe/following{/other_user}","gists_url":"https://api.github.com/users/mikewiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/mikewiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikewiebe/subscriptions","organizations_url":"https://api.github.com/users/mikewiebe/orgs","repos_url":"https://api.github.com/users/mikewiebe/repos","events_url":"https://api.github.com/users/mikewiebe/events{/privacy}","received_events_url":"https://api.github.com/users/mikewiebe/received_events","type":"User","site_admin":false},"body":"@tomcooperca How would you like to represent the `source_interface` and `source_vlan` properties in the manifest? Typically we have represented these as array's since there are more then one and they are additive. We will need to re-work the getters/setters for these but want to make sure you are ok with representing them as array's first.","created_at":"2017-04-19T17:49:43Z","updated_at":"2017-04-19T17:49:43Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/539#discussion_r112270044","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/112270044"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/539#discussion_r112270044"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539","id":115242302,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/539","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/539.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/539.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/539","number":539,"state":"open","locked":false,"title":"SPAN session provider","user":{"login":"tomcooperca","id":23202065,"avatar_url":"https://avatars0.githubusercontent.com/u/23202065?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcooperca","html_url":"https://github.com/tomcooperca","followers_url":"https://api.github.com/users/tomcooperca/followers","following_url":"https://api.github.com/users/tomcooperca/following{/other_user}","gists_url":"https://api.github.com/users/tomcooperca/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcooperca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcooperca/subscriptions","organizations_url":"https://api.github.com/users/tomcooperca/orgs","repos_url":"https://api.github.com/users/tomcooperca/repos","events_url":"https://api.github.com/users/tomcooperca/events{/privacy}","received_events_url":"https://api.github.com/users/tomcooperca/received_events","type":"User","site_admin":false},"body":"New SPAN session provider for NU. Only have included the more basic settings so far with a standard test.\r\n\r\n*Note, due to work restrictions, I don't have a proper dev environment. As such, I haven't ran the minitest for this new provider yet. However, when I do, I will post the test results here. ","created_at":"2017-04-11T05:11:37Z","updated_at":"2017-04-19T17:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68012c35a5d8d713bc48d44f523cba25fc41d21b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/539/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/7987e8339fb1d3f00d8e018699fc92a50af7847c","head":{"label":"tomcooperca:tom/monitor_session","ref":"tom/monitor_session","sha":"7987e8339fb1d3f00d8e018699fc92a50af7847c","user":{"login":"tomcooperca","id":23202065,"avatar_url":"https://avatars0.githubusercontent.com/u/23202065?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcooperca","html_url":"https://github.com/tomcooperca","followers_url":"https://api.github.com/users/tomcooperca/followers","following_url":"https://api.github.com/users/tomcooperca/following{/other_user}","gists_url":"https://api.github.com/users/tomcooperca/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcooperca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcooperca/subscriptions","organizations_url":"https://api.github.com/users/tomcooperca/orgs","repos_url":"https://api.github.com/users/tomcooperca/repos","events_url":"https://api.github.com/users/tomcooperca/events{/privacy}","received_events_url":"https://api.github.com/users/tomcooperca/received_events","type":"User","site_admin":false},"repo":{"id":84344022,"name":"cisco-network-node-utils","full_name":"tomcooperca/cisco-network-node-utils","owner":{"login":"tomcooperca","id":23202065,"avatar_url":"https://avatars0.githubusercontent.com/u/23202065?v=3","gravatar_id":"","url":"https://api.github.com/users/tomcooperca","html_url":"https://github.com/tomcooperca","followers_url":"https://api.github.com/users/tomcooperca/followers","following_url":"https://api.github.com/users/tomcooperca/following{/other_user}","gists_url":"https://api.github.com/users/tomcooperca/gists{/gist_id}","starred_url":"https://api.github.com/users/tomcooperca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomcooperca/subscriptions","organizations_url":"https://api.github.com/users/tomcooperca/orgs","repos_url":"https://api.github.com/users/tomcooperca/repos","events_url":"https://api.github.com/users/tomcooperca/events{/privacy}","received_events_url":"https://api.github.com/users/tomcooperca/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomcooperca/cisco-network-node-utils","description":null,"fork":true,"url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils","forks_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/tomcooperca/cisco-network-node-utils/deployments","created_at":"2017-03-08T16:47:17Z","updated_at":"2017-03-08T16:47:19Z","pushed_at":"2017-04-19T01:50:33Z","git_url":"git://github.com/tomcooperca/cisco-network-node-utils.git","ssh_url":"git@github.com:tomcooperca/cisco-network-node-utils.git","clone_url":"https://github.com/tomcooperca/cisco-network-node-utils.git","svn_url":"https://github.com/tomcooperca/cisco-network-node-utils","homepage":null,"size":4188,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"886c39fffc5cef59230a11497002cdf541519724","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars3.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars3.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":null,"fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","deployments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/deployments","created_at":"2015-07-23T12:07:39Z","updated_at":"2016-12-09T14:52:21Z","pushed_at":"2017-04-19T01:50:35Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":4137,"stargazers_count":18,"watchers_count":18,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":2,"forks":39,"open_issues":2,"watchers":18,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/539"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/539"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/539/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/539/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/7987e8339fb1d3f00d8e018699fc92a50af7847c"}}}}
|
{
"id": 39565196,
"name": "cisco/cisco-network-node-utils",
"url": "https://api.github.com/repos/cisco/cisco-network-node-utils"
}
|
{
"id": 12445795,
"login": "mikewiebe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12445795?",
"url": "https://api.github.com/users/mikewiebe"
}
|
{
"id": 1376999,
"login": "cisco",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1376999?",
"url": "https://api.github.com/orgs/cisco"
}
| 2017-04-19T17:49:43 |
5717691980
|
{"actor":{"display_login":"mikewiebe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/coala/gci-leaders/pulls/comments/158011087","pull_request_review_id":84748195,"id":158011087,"diff_hunk":"@@ -0,0 +1,192 @@\n+const RSS = require('rss')\n+const generateDiff = require('deep-diff').diff\n+const fs = require('fs')\n+\n+function createLeadersHash(array) {\n+ return array.reduce((hash, elem) => {\n+ hash[elem.id] = elem\n+ return hash\n+ }, {})\n+}\n+\n+function createOrgHash(array) {\n+ let rank = 0\n+ return array.reduce((hash, elem) => {\n+ rank++\n+ elem.rank = rank\n+ elem.leaders = createLeadersHash(elem.leaders)\n+ hash[elem.slug] = elem\n+ return hash\n+ }, {})\n+}\n+\n+let current = {}\n+try {\n+ current = JSON.parse(\n+ fs.readFileSync(`${__dirname}/../out/feed_items.json`).toString()\n+ )\n+} catch (e) {\n+ current = {}\n+}\n+\n+const buildInfo = JSON.parse(\n+ fs.readFileSync(`${__dirname}/../out/scrape_info.json`).toString()\n+)\n+\n+const oldData = JSON.parse(\n+ fs.readFileSync(`${__dirname}/../out/data_old.json`).toString()\n+)\n+const newData = JSON.parse(\n+ fs.readFileSync(`${__dirname}/../out/data.json`).toString()\n+)\n+\n+const oldOrgs = createOrgHash(oldData)\n+const newOrgs = createOrgHash(newData)\n+\n+console.log(oldOrgs)\n+\n+if (oldOrgs && newOrgs) {\n+ const diffs = generateDiff(oldOrgs, newOrgs) || []\n+ console.log(diffs)\n+\n+ const feedItems = current.items || []\n+\n+ if (current.lastUpdated !== buildInfo.generated) {","path":"lib/rss.js","position":54,"original_position":54,"commit_id":"f26f342a7fc48cbd94f9c483b11c6b82ed3ab977","original_commit_id":"f26f342a7fc48cbd94f9c483b11c6b82ed3ab977","user":{"login":"jayvdb","id":15092,"avatar_url":"https://avatars1.githubusercontent.com/u/15092?v=4","gravatar_id":"","url":"https://api.github.com/users/jayvdb","html_url":"https://github.com/jayvdb","followers_url":"https://api.github.com/users/jayvdb/followers","following_url":"https://api.github.com/users/jayvdb/following{/other_user}","gists_url":"https://api.github.com/users/jayvdb/gists{/gist_id}","starred_url":"https://api.github.com/users/jayvdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayvdb/subscriptions","organizations_url":"https://api.github.com/users/jayvdb/orgs","repos_url":"https://api.github.com/users/jayvdb/repos","events_url":"https://api.github.com/users/jayvdb/events{/privacy}","received_events_url":"https://api.github.com/users/jayvdb/received_events","type":"User","site_admin":false},"body":"how can they ever be equal!?\r\n\r\nmore importantly, you do not need to store the date generated. The `out/` files have dates, and HTTP tells you the dates of those files.","created_at":"2017-12-20T12:33:09Z","updated_at":"2017-12-20T12:38:14Z","html_url":"https://github.com/coala/gci-leaders/pull/95#discussion_r158011087","pull_request_url":"https://api.github.com/repos/coala/gci-leaders/pulls/95","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/comments/158011087"},"html":{"href":"https://github.com/coala/gci-leaders/pull/95#discussion_r158011087"},"pull_request":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/coala/gci-leaders/pulls/95","id":159097785,"html_url":"https://github.com/coala/gci-leaders/pull/95","diff_url":"https://github.com/coala/gci-leaders/pull/95.diff","patch_url":"https://github.com/coala/gci-leaders/pull/95.patch","issue_url":"https://api.github.com/repos/coala/gci-leaders/issues/95","number":95,"state":"open","locked":false,"title":"Create RSS feed of data changes","user":{"login":"andrewda","id":10191084,"avatar_url":"https://avatars1.githubusercontent.com/u/10191084?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewda","html_url":"https://github.com/andrewda","followers_url":"https://api.github.com/users/andrewda/followers","following_url":"https://api.github.com/users/andrewda/following{/other_user}","gists_url":"https://api.github.com/users/andrewda/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewda/subscriptions","organizations_url":"https://api.github.com/users/andrewda/orgs","repos_url":"https://api.github.com/users/andrewda/repos","events_url":"https://api.github.com/users/andrewda/events{/privacy}","received_events_url":"https://api.github.com/users/andrewda/received_events","type":"User","site_admin":false},"body":"This adds an RSS feed containing all the changes in the data.\r\n\r\nCloses https://github.com/coala/gci-leaders/issues/91","created_at":"2017-12-19T07:40:20Z","updated_at":"2017-12-20T12:38:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f615f77d99d48cce700b9a2da027dfbe9087a31","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/gci-leaders/pulls/95/commits","review_comments_url":"https://api.github.com/repos/coala/gci-leaders/pulls/95/comments","review_comment_url":"https://api.github.com/repos/coala/gci-leaders/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/gci-leaders/issues/95/comments","statuses_url":"https://api.github.com/repos/coala/gci-leaders/statuses/f26f342a7fc48cbd94f9c483b11c6b82ed3ab977","head":{"label":"andrewda:rss","ref":"rss","sha":"f26f342a7fc48cbd94f9c483b11c6b82ed3ab977","user":{"login":"andrewda","id":10191084,"avatar_url":"https://avatars1.githubusercontent.com/u/10191084?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewda","html_url":"https://github.com/andrewda","followers_url":"https://api.github.com/users/andrewda/followers","following_url":"https://api.github.com/users/andrewda/following{/other_user}","gists_url":"https://api.github.com/users/andrewda/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewda/subscriptions","organizations_url":"https://api.github.com/users/andrewda/orgs","repos_url":"https://api.github.com/users/andrewda/repos","events_url":"https://api.github.com/users/andrewda/events{/privacy}","received_events_url":"https://api.github.com/users/andrewda/received_events","type":"User","site_admin":false},"repo":{"id":113151815,"name":"gci-leaders","full_name":"andrewda/gci-leaders","owner":{"login":"andrewda","id":10191084,"avatar_url":"https://avatars1.githubusercontent.com/u/10191084?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewda","html_url":"https://github.com/andrewda","followers_url":"https://api.github.com/users/andrewda/followers","following_url":"https://api.github.com/users/andrewda/following{/other_user}","gists_url":"https://api.github.com/users/andrewda/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewda/subscriptions","organizations_url":"https://api.github.com/users/andrewda/orgs","repos_url":"https://api.github.com/users/andrewda/repos","events_url":"https://api.github.com/users/andrewda/events{/privacy}","received_events_url":"https://api.github.com/users/andrewda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewda/gci-leaders","description":null,"fork":true,"url":"https://api.github.com/repos/andrewda/gci-leaders","forks_url":"https://api.github.com/repos/andrewda/gci-leaders/forks","keys_url":"https://api.github.com/repos/andrewda/gci-leaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewda/gci-leaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewda/gci-leaders/teams","hooks_url":"https://api.github.com/repos/andrewda/gci-leaders/hooks","issue_events_url":"https://api.github.com/repos/andrewda/gci-leaders/issues/events{/number}","events_url":"https://api.github.com/repos/andrewda/gci-leaders/events","assignees_url":"https://api.github.com/repos/andrewda/gci-leaders/assignees{/user}","branches_url":"https://api.github.com/repos/andrewda/gci-leaders/branches{/branch}","tags_url":"https://api.github.com/repos/andrewda/gci-leaders/tags","blobs_url":"https://api.github.com/repos/andrewda/gci-leaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewda/gci-leaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewda/gci-leaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewda/gci-leaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewda/gci-leaders/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewda/gci-leaders/languages","stargazers_url":"https://api.github.com/repos/andrewda/gci-leaders/stargazers","contributors_url":"https://api.github.com/repos/andrewda/gci-leaders/contributors","subscribers_url":"https://api.github.com/repos/andrewda/gci-leaders/subscribers","subscription_url":"https://api.github.com/repos/andrewda/gci-leaders/subscription","commits_url":"https://api.github.com/repos/andrewda/gci-leaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewda/gci-leaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewda/gci-leaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewda/gci-leaders/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewda/gci-leaders/contents/{+path}","compare_url":"https://api.github.com/repos/andrewda/gci-leaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewda/gci-leaders/merges","archive_url":"https://api.github.com/repos/andrewda/gci-leaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewda/gci-leaders/downloads","issues_url":"https://api.github.com/repos/andrewda/gci-leaders/issues{/number}","pulls_url":"https://api.github.com/repos/andrewda/gci-leaders/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewda/gci-leaders/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewda/gci-leaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewda/gci-leaders/labels{/name}","releases_url":"https://api.github.com/repos/andrewda/gci-leaders/releases{/id}","deployments_url":"https://api.github.com/repos/andrewda/gci-leaders/deployments","created_at":"2017-12-05T08:04:13Z","updated_at":"2017-12-05T08:04:14Z","pushed_at":"2017-12-20T11:13:50Z","git_url":"git://github.com/andrewda/gci-leaders.git","ssh_url":"git@github.com:andrewda/gci-leaders.git","clone_url":"https://github.com/andrewda/gci-leaders.git","svn_url":"https://github.com/andrewda/gci-leaders","homepage":"http://coala.github.io/gci-leaders/","size":420,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"5174e2f8ad82f40a9a894f13024249067d5a10ea","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":113068646,"name":"gci-leaders","full_name":"coala/gci-leaders","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/gci-leaders","description":"A website showing all current leaders of Google Code-in 2017 🏆","fork":false,"url":"https://api.github.com/repos/coala/gci-leaders","forks_url":"https://api.github.com/repos/coala/gci-leaders/forks","keys_url":"https://api.github.com/repos/coala/gci-leaders/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/gci-leaders/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/gci-leaders/teams","hooks_url":"https://api.github.com/repos/coala/gci-leaders/hooks","issue_events_url":"https://api.github.com/repos/coala/gci-leaders/issues/events{/number}","events_url":"https://api.github.com/repos/coala/gci-leaders/events","assignees_url":"https://api.github.com/repos/coala/gci-leaders/assignees{/user}","branches_url":"https://api.github.com/repos/coala/gci-leaders/branches{/branch}","tags_url":"https://api.github.com/repos/coala/gci-leaders/tags","blobs_url":"https://api.github.com/repos/coala/gci-leaders/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/gci-leaders/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/gci-leaders/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/gci-leaders/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/gci-leaders/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/gci-leaders/languages","stargazers_url":"https://api.github.com/repos/coala/gci-leaders/stargazers","contributors_url":"https://api.github.com/repos/coala/gci-leaders/contributors","subscribers_url":"https://api.github.com/repos/coala/gci-leaders/subscribers","subscription_url":"https://api.github.com/repos/coala/gci-leaders/subscription","commits_url":"https://api.github.com/repos/coala/gci-leaders/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/gci-leaders/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/gci-leaders/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/gci-leaders/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/gci-leaders/contents/{+path}","compare_url":"https://api.github.com/repos/coala/gci-leaders/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/gci-leaders/merges","archive_url":"https://api.github.com/repos/coala/gci-leaders/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/gci-leaders/downloads","issues_url":"https://api.github.com/repos/coala/gci-leaders/issues{/number}","pulls_url":"https://api.github.com/repos/coala/gci-leaders/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/gci-leaders/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/gci-leaders/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/gci-leaders/labels{/name}","releases_url":"https://api.github.com/repos/coala/gci-leaders/releases{/id}","deployments_url":"https://api.github.com/repos/coala/gci-leaders/deployments","created_at":"2017-12-04T16:46:05Z","updated_at":"2017-12-17T14:34:08Z","pushed_at":"2017-12-20T11:13:51Z","git_url":"git://github.com/coala/gci-leaders.git","ssh_url":"git@github.com:coala/gci-leaders.git","clone_url":"https://github.com/coala/gci-leaders.git","svn_url":"https://github.com/coala/gci-leaders","homepage":"https://gci-leaders.netlify.com","size":806,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":16,"open_issues":19,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/95"},"html":{"href":"https://github.com/coala/gci-leaders/pull/95"},"issue":{"href":"https://api.github.com/repos/coala/gci-leaders/issues/95"},"comments":{"href":"https://api.github.com/repos/coala/gci-leaders/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/gci-leaders/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/coala/gci-leaders/statuses/f26f342a7fc48cbd94f9c483b11c6b82ed3ab977"}},"author_association":"MEMBER"}}
|
{
"id": 113068646,
"name": "coala/gci-leaders",
"url": "https://api.github.com/repos/coala/gci-leaders"
}
|
{
"id": 15092,
"login": "jayvdb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15092?",
"url": "https://api.github.com/users/jayvdb"
}
|
{
"id": 10620750,
"login": "coala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10620750?",
"url": "https://api.github.com/orgs/coala"
}
| 2017-12-20T12:33:09 |
7012931844
|
{"actor":{"display_login":"jayvdb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/142109555","pull_request_review_id":66422219,"id":142109555,"diff_hunk":"@@ -41,15 +40,32 @@ import java.security.SignatureException\n import java.util.*\n import javax.annotation.concurrent.ThreadSafe\n \n+class NodeLookupImpl(private val identityService: IdentityService, private val networkMapCache: NetworkMapCache) : NodeLookup {","path":"node/src/main/kotlin/net/corda/node/services/network/PersistentNetworkMapCache.kt","position":33,"original_position":33,"commit_id":"7409d2cda8ce229578fa26a4f96f2feb10fe9f08","original_commit_id":"7409d2cda8ce229578fa26a4f96f2feb10fe9f08","user":{"login":"mnesbit","id":20210228,"avatar_url":"https://avatars2.githubusercontent.com/u/20210228?v=4","gravatar_id":"","url":"https://api.github.com/users/mnesbit","html_url":"https://github.com/mnesbit","followers_url":"https://api.github.com/users/mnesbit/followers","following_url":"https://api.github.com/users/mnesbit/following{/other_user}","gists_url":"https://api.github.com/users/mnesbit/gists{/gist_id}","starred_url":"https://api.github.com/users/mnesbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnesbit/subscriptions","organizations_url":"https://api.github.com/users/mnesbit/orgs","repos_url":"https://api.github.com/users/mnesbit/repos","events_url":"https://api.github.com/users/mnesbit/events{/privacy}","received_events_url":"https://api.github.com/users/mnesbit/received_events","type":"User","site_admin":false},"body":"I like the idea, but perhaps we have to keep it hidden due to api effects.","created_at":"2017-10-02T11:00:35Z","updated_at":"2017-10-02T11:00:38Z","html_url":"https://github.com/corda/corda/pull/1652#discussion_r142109555","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/1652","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/142109555"},"html":{"href":"https://github.com/corda/corda/pull/1652#discussion_r142109555"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/1652"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/1652","id":143098631,"html_url":"https://github.com/corda/corda/pull/1652","diff_url":"https://github.com/corda/corda/pull/1652.diff","patch_url":"https://github.com/corda/corda/pull/1652.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/1652","number":1652,"state":"open","locked":false,"title":"CORDA-599 PersistentNetworkMapCache no longer circularly depends on SH","user":{"login":"andr3ej","id":26927791,"avatar_url":"https://avatars3.githubusercontent.com/u/26927791?v=4","gravatar_id":"","url":"https://api.github.com/users/andr3ej","html_url":"https://github.com/andr3ej","followers_url":"https://api.github.com/users/andr3ej/followers","following_url":"https://api.github.com/users/andr3ej/following{/other_user}","gists_url":"https://api.github.com/users/andr3ej/gists{/gist_id}","starred_url":"https://api.github.com/users/andr3ej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andr3ej/subscriptions","organizations_url":"https://api.github.com/users/andr3ej/orgs","repos_url":"https://api.github.com/users/andr3ej/repos","events_url":"https://api.github.com/users/andr3ej/events{/privacy}","received_events_url":"https://api.github.com/users/andr3ej/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-26T10:41:24Z","updated_at":"2017-10-02T11:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe93f9a0ee36f7e88b40bb59da9461667e6f6f67","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Clintonio","id":474659,"avatar_url":"https://avatars2.githubusercontent.com/u/474659?v=4","gravatar_id":"","url":"https://api.github.com/users/Clintonio","html_url":"https://github.com/Clintonio","followers_url":"https://api.github.com/users/Clintonio/followers","following_url":"https://api.github.com/users/Clintonio/following{/other_user}","gists_url":"https://api.github.com/users/Clintonio/gists{/gist_id}","starred_url":"https://api.github.com/users/Clintonio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Clintonio/subscriptions","organizations_url":"https://api.github.com/users/Clintonio/orgs","repos_url":"https://api.github.com/users/Clintonio/repos","events_url":"https://api.github.com/users/Clintonio/events{/privacy}","received_events_url":"https://api.github.com/users/Clintonio/received_events","type":"User","site_admin":false},{"login":"rick-r3","id":23558791,"avatar_url":"https://avatars2.githubusercontent.com/u/23558791?v=4","gravatar_id":"","url":"https://api.github.com/users/rick-r3","html_url":"https://github.com/rick-r3","followers_url":"https://api.github.com/users/rick-r3/followers","following_url":"https://api.github.com/users/rick-r3/following{/other_user}","gists_url":"https://api.github.com/users/rick-r3/gists{/gist_id}","starred_url":"https://api.github.com/users/rick-r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rick-r3/subscriptions","organizations_url":"https://api.github.com/users/rick-r3/orgs","repos_url":"https://api.github.com/users/rick-r3/repos","events_url":"https://api.github.com/users/rick-r3/events{/privacy}","received_events_url":"https://api.github.com/users/rick-r3/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/corda/corda/milestones/9","html_url":"https://github.com/corda/corda/milestone/9","labels_url":"https://api.github.com/repos/corda/corda/milestones/9/labels","id":2759923,"number":9,"title":"1.1","description":"","creator":{"login":"rnicoll","id":3513077,"avatar_url":"https://avatars2.githubusercontent.com/u/3513077?v=4","gravatar_id":"","url":"https://api.github.com/users/rnicoll","html_url":"https://github.com/rnicoll","followers_url":"https://api.github.com/users/rnicoll/followers","following_url":"https://api.github.com/users/rnicoll/following{/other_user}","gists_url":"https://api.github.com/users/rnicoll/gists{/gist_id}","starred_url":"https://api.github.com/users/rnicoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnicoll/subscriptions","organizations_url":"https://api.github.com/users/rnicoll/orgs","repos_url":"https://api.github.com/users/rnicoll/repos","events_url":"https://api.github.com/users/rnicoll/events{/privacy}","received_events_url":"https://api.github.com/users/rnicoll/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":24,"state":"open","created_at":"2017-09-12T11:59:59Z","updated_at":"2017-10-02T09:29:13Z","due_on":"2017-10-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/corda/corda/pulls/1652/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/1652/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/1652/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/7409d2cda8ce229578fa26a4f96f2feb10fe9f08","head":{"label":"corda:andr3ej-PersistentNetworkMapCache","ref":"andr3ej-PersistentNetworkMapCache","sha":"7409d2cda8ce229578fa26a4f96f2feb10fe9f08","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries. It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-10-02T10:39:47Z","pushed_at":"2017-10-02T10:53:10Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":98532,"stargazers_count":1014,"watchers_count":1014,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":114,"forks":293,"open_issues":114,"watchers":1014,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"cac739e48d349369e5329ed2f215d7450344b1eb","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries. It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2017-10-02T10:39:47Z","pushed_at":"2017-10-02T10:53:10Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":98532,"stargazers_count":1014,"watchers_count":1014,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":293,"mirror_url":null,"open_issues_count":114,"forks":293,"open_issues":114,"watchers":1014,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/1652"},"html":{"href":"https://github.com/corda/corda/pull/1652"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/1652"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/1652/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/1652/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/1652/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/7409d2cda8ce229578fa26a4f96f2feb10fe9f08"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 70137417,
"name": "corda/corda",
"url": "https://api.github.com/repos/corda/corda"
}
|
{
"id": 20210228,
"login": "mnesbit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20210228?",
"url": "https://api.github.com/users/mnesbit"
}
|
{
"id": 22600631,
"login": "corda",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22600631?",
"url": "https://api.github.com/orgs/corda"
}
| 2017-10-02T11:00:35 |
6661962164
|
{"actor":{"display_login":"mnesbit"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/phobos/pulls/comments/143342694","pull_request_review_id":67845028,"id":143342694,"diff_hunk":"@@ -68,7 +68,8 @@ import std.traits;\n \n // Generate a uniformly-distributed real in the range [0, 100)\n auto r = uniform(0.0L, 100.0L, rnd);\n- assert(r == 79.65429843861011285);\n+ import std.math : approxEqual;\n+ assert(approxEqual(r, 79.65429843861011285));\n ","path":"std/random.d","position":7,"original_position":7,"commit_id":"76512906616f6ce9c5c21b666a203dfd209c2a41","original_commit_id":"76512906616f6ce9c5c21b666a203dfd209c2a41","user":{"login":"WebDrake","id":125075,"avatar_url":"https://avatars3.githubusercontent.com/u/125075?v=4","gravatar_id":"","url":"https://api.github.com/users/WebDrake","html_url":"https://github.com/WebDrake","followers_url":"https://api.github.com/users/WebDrake/followers","following_url":"https://api.github.com/users/WebDrake/following{/other_user}","gists_url":"https://api.github.com/users/WebDrake/gists{/gist_id}","starred_url":"https://api.github.com/users/WebDrake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebDrake/subscriptions","organizations_url":"https://api.github.com/users/WebDrake/orgs","repos_url":"https://api.github.com/users/WebDrake/repos","events_url":"https://api.github.com/users/WebDrake/events{/privacy}","received_events_url":"https://api.github.com/users/WebDrake/received_events","type":"User","site_admin":false},"body":"Oh, so you mean in this case you'd check that the resulting number is `>= 0` and `< 100`, and for the `uniform(0, 15, rnd)` call you'd check that it's `>= 0` and `< 15`?\r\n\r\nThat sounds reasonable, yes. Note that for the `uniform!uint` case this won't really work since the range of possible values covers the entire range of possible values for that type; but you don't really have to validate that result at all anyway.","created_at":"2017-10-07T23:12:31Z","updated_at":"2017-10-07T23:12:31Z","html_url":"https://github.com/dlang/phobos/pull/5762#discussion_r143342694","pull_request_url":"https://api.github.com/repos/dlang/phobos/pulls/5762","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments/143342694"},"html":{"href":"https://github.com/dlang/phobos/pull/5762#discussion_r143342694"},"pull_request":{"href":"https://api.github.com/repos/dlang/phobos/pulls/5762"}},"in_reply_to_id":143342475},"pull_request":{"url":"https://api.github.com/repos/dlang/phobos/pulls/5762","id":145303885,"html_url":"https://github.com/dlang/phobos/pull/5762","diff_url":"https://github.com/dlang/phobos/pull/5762.diff","patch_url":"https://github.com/dlang/phobos/pull/5762.patch","issue_url":"https://api.github.com/repos/dlang/phobos/issues/5762","number":5762,"state":"open","locked":false,"title":"std.random: Relax unittest assertion for 64-bit reals","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-07T18:51:08Z","updated_at":"2017-10-07T23:12:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56b72913cd2042daa5ec96828778fed3a55c99e9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/phobos/pulls/5762/commits","review_comments_url":"https://api.github.com/repos/dlang/phobos/pulls/5762/comments","review_comment_url":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/phobos/issues/5762/comments","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/76512906616f6ce9c5c21b666a203dfd209c2a41","head":{"label":"kinke:random","ref":"random","sha":"76512906616f6ce9c5c21b666a203dfd209c2a41","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":7739198,"name":"phobos","full_name":"kinke/phobos","owner":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinke/phobos","description":"MSVCRT and Win64 related fixes.","fork":true,"url":"https://api.github.com/repos/kinke/phobos","forks_url":"https://api.github.com/repos/kinke/phobos/forks","keys_url":"https://api.github.com/repos/kinke/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/phobos/teams","hooks_url":"https://api.github.com/repos/kinke/phobos/hooks","issue_events_url":"https://api.github.com/repos/kinke/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/phobos/events","assignees_url":"https://api.github.com/repos/kinke/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/phobos/tags","blobs_url":"https://api.github.com/repos/kinke/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/phobos/languages","stargazers_url":"https://api.github.com/repos/kinke/phobos/stargazers","contributors_url":"https://api.github.com/repos/kinke/phobos/contributors","subscribers_url":"https://api.github.com/repos/kinke/phobos/subscribers","subscription_url":"https://api.github.com/repos/kinke/phobos/subscription","commits_url":"https://api.github.com/repos/kinke/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/phobos/merges","archive_url":"https://api.github.com/repos/kinke/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/phobos/downloads","issues_url":"https://api.github.com/repos/kinke/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/phobos/labels{/name}","releases_url":"https://api.github.com/repos/kinke/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/phobos/deployments","created_at":"2013-01-21T19:53:16Z","updated_at":"2013-10-25T01:55:22Z","pushed_at":"2017-10-07T18:50:00Z","git_url":"git://github.com/kinke/phobos.git","ssh_url":"git@github.com:kinke/phobos.git","clone_url":"https://github.com/kinke/phobos.git","svn_url":"https://github.com/kinke/phobos","homepage":"","size":45559,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"win64"}},"base":{"label":"dlang:stable","ref":"stable","sha":"8f2a221b9ec3fec30c64d562de07b0b68ecd0df9","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257084,"name":"phobos","full_name":"dlang/phobos","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/phobos","description":"The standard library of the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/phobos","forks_url":"https://api.github.com/repos/dlang/phobos/forks","keys_url":"https://api.github.com/repos/dlang/phobos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/phobos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/phobos/teams","hooks_url":"https://api.github.com/repos/dlang/phobos/hooks","issue_events_url":"https://api.github.com/repos/dlang/phobos/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/phobos/events","assignees_url":"https://api.github.com/repos/dlang/phobos/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/phobos/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/phobos/tags","blobs_url":"https://api.github.com/repos/dlang/phobos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/phobos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/phobos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/phobos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/phobos/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/phobos/languages","stargazers_url":"https://api.github.com/repos/dlang/phobos/stargazers","contributors_url":"https://api.github.com/repos/dlang/phobos/contributors","subscribers_url":"https://api.github.com/repos/dlang/phobos/subscribers","subscription_url":"https://api.github.com/repos/dlang/phobos/subscription","commits_url":"https://api.github.com/repos/dlang/phobos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/phobos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/phobos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/phobos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/phobos/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/phobos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/phobos/merges","archive_url":"https://api.github.com/repos/dlang/phobos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/phobos/downloads","issues_url":"https://api.github.com/repos/dlang/phobos/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/phobos/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/phobos/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/phobos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/phobos/labels{/name}","releases_url":"https://api.github.com/repos/dlang/phobos/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/phobos/deployments","created_at":"2011-01-15T07:00:06Z","updated_at":"2017-10-04T08:37:10Z","pushed_at":"2017-10-07T21:51:56Z","git_url":"git://github.com/dlang/phobos.git","ssh_url":"git@github.com:dlang/phobos.git","clone_url":"https://github.com/dlang/phobos.git","svn_url":"https://github.com/dlang/phobos","homepage":"dlang.org/phobos","size":44726,"stargazers_count":840,"watchers_count":840,"language":"D","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":560,"mirror_url":null,"open_issues_count":108,"forks":560,"open_issues":108,"watchers":840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/phobos/pulls/5762"},"html":{"href":"https://github.com/dlang/phobos/pull/5762"},"issue":{"href":"https://api.github.com/repos/dlang/phobos/issues/5762"},"comments":{"href":"https://api.github.com/repos/dlang/phobos/issues/5762/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/phobos/pulls/5762/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/phobos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/phobos/pulls/5762/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/phobos/statuses/76512906616f6ce9c5c21b666a203dfd209c2a41"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 1257084,
"name": "dlang/phobos",
"url": "https://api.github.com/repos/dlang/phobos"
}
|
{
"id": 125075,
"login": "WebDrake",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/125075?",
"url": "https://api.github.com/users/WebDrake"
}
|
{
"id": 565913,
"login": "dlang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/565913?",
"url": "https://api.github.com/orgs/dlang"
}
| 2017-10-07T23:12:31 |
6687403756
|
{"actor":{"display_login":"WebDrake"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/157361573","pull_request_review_id":83993839,"id":157361573,"diff_hunk":"@@ -121,736 +121,1580 @@ struct Code(T_, int N_)\n alias AliasSeq(Args...) = Args;\n \n // dfmt off\n-alias baselineCases = AliasSeq!(\n- Code!(ubyte, 16 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* punpcklbw xmm0,xmm0 */ 0x66, 0x0f, 0x60, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ubyte*, 16 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,BYTE PTR [rdi] */ 0x0f, 0xb6, 0x07,\n- /* movd xmm0,eax */ 0x66, 0x0f, 0x6e, 0xc0,\n- /* punpcklbw xmm0,xmm0 */ 0x66, 0x0f, 0x60, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(byte, 16 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* punpcklbw xmm0,xmm0 */ 0x66, 0x0f, 0x60, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(byte*, 16 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,BYTE PTR [rdi] */ 0x0f, 0xbe, 0x07,\n- /* movd xmm0,eax */ 0x66, 0x0f, 0x6e, 0xc0,\n- /* punpcklbw xmm0,xmm0 */ 0x66, 0x0f, 0x60, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ushort, 16 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ushort*, 16 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,WORD PTR [rdi] */ 0x0f, 0xb7, 0x07,\n- /* movd xmm0,eax */ 0x66, 0x0f, 0x6e, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(short, 16 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(short*, 16 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,WORD PTR [rdi] */ 0x0f, 0xbf, 0x07,\n- /* movd xmm0,eax */ 0x66, 0x0f, 0x6e, 0xc0,\n- /* punpcklwd xmm0,xmm0 */ 0x66, 0x0f, 0x61, 0xc0,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(uint, 16 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(uint*, 16 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,DWORD PTR [rdi] */ 0x66, 0x0f, 0x6e, 0x07,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int, 16 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,edi */ 0x66, 0x0f, 0x6e, 0xc7,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int*, 16 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* movd xmm0,DWORD PTR [rdi] */ 0x66, 0x0f, 0x6e, 0x07,\n- /* pshufd xmm0,xmm0,0x0 */ 0x66, 0x0f, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong, 16 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* movq xmm0,rdi */ 0x66, 0x48, 0x0f, 0x6e, 0xc7,\n- /* punpcklqdq xmm0,xmm0 */ 0x66, 0x0f, 0x6c, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong*, 16 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* punpcklqdq xmm0,XMMWORD PTR [rdi] */ 0x66, 0x0f, 0x6c, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long, 16 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* movq xmm0,rdi */ 0x66, 0x48, 0x0f, 0x6e, 0xc7,\n- /* punpcklqdq xmm0,xmm0 */ 0x66, 0x0f, 0x6c, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long*, 16 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* punpcklqdq xmm0,XMMWORD PTR [rdi] */ 0x66, 0x0f, 0x6c, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float, 16 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* shufps xmm0,xmm0,0x0 */ 0x0f, 0xc6, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float*, 16 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* movss xmm0,DWORD PTR [rdi] */ 0xf3, 0x0f, 0x10, 0x07,\n- /* shufps xmm0,xmm0,0x0 */ 0x0f, 0xc6, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(double, 16 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* unpcklpd xmm0,xmm0 */ 0x66, 0x0f, 0x14, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(double*, 16 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* movsd xmm0,QWORD PTR [rdi] */ 0xf2, 0x0f, 0x10, 0x07,\n- /* unpcklpd xmm0,xmm0 */ 0x66, 0x0f, 0x14, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n-);\n-\n-alias avxCases = AliasSeq!(\n- Code!(ubyte, 16 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ubyte*, 16 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,BYTE PTR [rdi] */ 0x0f, 0xb6, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ubyte, 32 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ubyte*, 32 / ubyte.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,BYTE PTR [rdi] */ 0x0f, 0xb6, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- /* add BYTE PTR [rax],al */ 0x00, 0x00,\n- ]),\n- Code!(byte, 16 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(byte*, 16 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,BYTE PTR [rdi] */ 0x0f, 0xbe, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(byte, 32 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(byte*, 32 / byte.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,BYTE PTR [rdi] */ 0x0f, 0xbe, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpxor xmm1,xmm1,xmm1 */ 0xc5, 0xf1, 0xef, 0xc9,\n- /* vpshufb xmm0,xmm0,xmm1 */ 0xc4, 0xe2, 0x79, 0x00, 0xc1,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- /* add BYTE PTR [rax],al */ 0x00, 0x00,\n- ]),\n- Code!(ushort, 16 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ushort*, 16 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,WORD PTR [rdi] */ 0x0f, 0xb7, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ushort, 32 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ushort*, 32 / ushort.sizeof)([\n- /* push rax */ 0x50,\n- /* movzx eax,WORD PTR [rdi] */ 0x0f, 0xb7, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- /* add BYTE PTR [rax],al */ 0x00, 0x00,\n- ]),\n- Code!(short, 16 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(short*, 16 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,WORD PTR [rdi] */ 0x0f, 0xbf, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(short, 32 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(short*, 32 / short.sizeof)([\n- /* push rax */ 0x50,\n- /* movsx eax,WORD PTR [rdi] */ 0x0f, 0xbf, 0x07,\n- /* vmovd xmm0,eax */ 0xc5, 0xf9, 0x6e, 0xc0,\n- /* vpunpcklwd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x61, 0xc0,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- /* add BYTE PTR [rax],al */ 0x00, 0x00,\n- ]),\n- Code!(uint, 16 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(uint*, 16 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss xmm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x79, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(uint, 32 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(uint*, 32 / uint.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss ymm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int, 16 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int*, 16 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss xmm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x79, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int, 32 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovd xmm0,edi */ 0xc5, 0xf9, 0x6e, 0xc7,\n- /* vpshufd xmm0,xmm0,0x0 */ 0xc5, 0xf9, 0x70, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(int*, 32 / int.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss ymm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong, 16 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovq xmm0,rdi */ 0xc4, 0xe1, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklqdq xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x6c, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong*, 16 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* vpunpcklqdq xmm0,xmm0,XMMWORD PTR [rdi] */ 0xc5, 0xf9, 0x6c, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong, 32 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovq xmm0,rdi */ 0xc4, 0xe1, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklqdq xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x6c, 0xc0,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(ulong*, 32 / ulong.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastsd ymm0,QWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x19, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long, 16 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovq xmm0,rdi */ 0xc4, 0xe1, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklqdq xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x6c, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long*, 16 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* vpunpcklqdq xmm0,xmm0,XMMWORD PTR [rdi] */ 0xc5, 0xf9, 0x6c, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long, 32 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovq xmm0,rdi */ 0xc4, 0xe1, 0xf9, 0x6e, 0xc7,\n- /* vpunpcklqdq xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x6c, 0xc0,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(long*, 32 / long.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastsd ymm0,QWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x19, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float, 16 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* vshufps xmm0,xmm0,xmm0,0x0 */ 0xc5, 0xf8, 0xc6, 0xc0, 0x00,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float*, 16 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss xmm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x79, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float, 32 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* vshufps ymm0,ymm0,ymm0,0x0 */ 0xc5, 0xfc, 0xc6, 0xc0, 0x00,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(float*, 32 / float.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastss ymm0,DWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x18, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(double, 16 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* vunpcklpd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x14, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(double*, 16 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* vmovsd xmm0,QWORD PTR [rdi] */ 0xc5, 0xfb, 0x10, 0x07,\n- /* vunpcklpd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x14, 0xc0,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n- Code!(double, 32 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* vunpcklpd xmm0,xmm0,xmm0 */ 0xc5, 0xf9, 0x14, 0xc0,\n- /* vinsertf128 ymm0,ymm0,xmm0,0x1 */ 0xc4, 0xe3, 0x7d, 0x18, 0xc0, 0x01,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- /* add BYTE PTR [rax],al */ 0x00, 0x00,\n- ]),\n- Code!(double*, 32 / double.sizeof)([\n- /* push rax */ 0x50,\n- /* vbroadcastsd ymm0,QWORD PTR [rdi] */ 0xc4, 0xe2, 0x7d, 0x19, 0x07,\n- /* pop rcx */ 0x59,\n- /* ret */ 0xc3,\n- ]),\n-);\n+version(D_PIC)\n+{","path":"test/runnable/test_cdvecfill.d","position":470,"original_position":470,"commit_id":"b0d929516c7f26f16b99af56ad28bd06f04dcd8a","original_commit_id":"b0d929516c7f26f16b99af56ad28bd06f04dcd8a","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"The one which can be used to generate this output. Who did you get the `-fPIC` instructions?\r\nCheck the header of this file ;-)","created_at":"2017-12-17T08:06:33Z","updated_at":"2017-12-17T08:06:33Z","html_url":"https://github.com/dlang/dmd/pull/7454#discussion_r157361573","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/7454","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/157361573"},"html":{"href":"https://github.com/dlang/dmd/pull/7454#discussion_r157361573"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7454"}},"in_reply_to_id":157361152},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7454","id":158774892,"html_url":"https://github.com/dlang/dmd/pull/7454","diff_url":"https://github.com/dlang/dmd/pull/7454.diff","patch_url":"https://github.com/dlang/dmd/pull/7454.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7454","number":7454,"state":"open","locked":false,"title":"Fix Issue 18013 - DMD test suite assertion failure in test_cdvecfill.d","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-17T07:30:39Z","updated_at":"2017-12-17T08:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6631951e0065dec2d54d554362ec9fa72cc44ddd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/7454/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/7454/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7454/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/b0d929516c7f26f16b99af56ad28bd06f04dcd8a","head":{"label":"JinShil:cdvecfill_pic","ref":"cdvecfill_pic","sha":"b0d929516c7f26f16b99af56ad28bd06f04dcd8a","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"repo":{"id":100016446,"name":"dmd","full_name":"JinShil/dmd","owner":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JinShil/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/JinShil/dmd","forks_url":"https://api.github.com/repos/JinShil/dmd/forks","keys_url":"https://api.github.com/repos/JinShil/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JinShil/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JinShil/dmd/teams","hooks_url":"https://api.github.com/repos/JinShil/dmd/hooks","issue_events_url":"https://api.github.com/repos/JinShil/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/JinShil/dmd/events","assignees_url":"https://api.github.com/repos/JinShil/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/JinShil/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/JinShil/dmd/tags","blobs_url":"https://api.github.com/repos/JinShil/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JinShil/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JinShil/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/JinShil/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JinShil/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/JinShil/dmd/languages","stargazers_url":"https://api.github.com/repos/JinShil/dmd/stargazers","contributors_url":"https://api.github.com/repos/JinShil/dmd/contributors","subscribers_url":"https://api.github.com/repos/JinShil/dmd/subscribers","subscription_url":"https://api.github.com/repos/JinShil/dmd/subscription","commits_url":"https://api.github.com/repos/JinShil/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/JinShil/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/JinShil/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/JinShil/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/JinShil/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/JinShil/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JinShil/dmd/merges","archive_url":"https://api.github.com/repos/JinShil/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JinShil/dmd/downloads","issues_url":"https://api.github.com/repos/JinShil/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/JinShil/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/JinShil/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/JinShil/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JinShil/dmd/labels{/name}","releases_url":"https://api.github.com/repos/JinShil/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/JinShil/dmd/deployments","created_at":"2017-08-11T09:36:15Z","updated_at":"2017-08-11T09:36:23Z","pushed_at":"2017-12-17T05:53:23Z","git_url":"git://github.com/JinShil/dmd.git","ssh_url":"git@github.com:JinShil/dmd.git","clone_url":"https://github.com/JinShil/dmd.git","svn_url":"https://github.com/JinShil/dmd","homepage":"dlang.org","size":80319,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"d28274e1c666ce8c8905587b8d86945927302315","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2017-12-14T10:02:07Z","pushed_at":"2017-12-17T07:30:39Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":80655,"stargazers_count":1712,"watchers_count":1712,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":433,"mirror_url":null,"archived":false,"open_issues_count":147,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":433,"open_issues":147,"watchers":1712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7454"},"html":{"href":"https://github.com/dlang/dmd/pull/7454"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/7454"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/7454/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7454/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7454/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/b0d929516c7f26f16b99af56ad28bd06f04dcd8a"}},"author_association":"MEMBER"}}
|
{
"id": 1257070,
"name": "dlang/dmd",
"url": "https://api.github.com/repos/dlang/dmd"
}
|
{
"id": 4370550,
"login": "wilzbach",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4370550?",
"url": "https://api.github.com/users/wilzbach"
}
|
{
"id": 565913,
"login": "dlang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/565913?",
"url": "https://api.github.com/orgs/dlang"
}
| 2017-12-17T08:06:33 |
6998606844
|
{"actor":{"display_login":"wilzbach"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eggjs/egg/pulls/comments/99530256","pull_request_review_id":20208550,"id":99530256,"diff_hunk":"@@ -20,27 +20,122 @@ title: controller\n \n ## 如何编写 controller\n \n-所有的 controller 都必须放在 `app/controller` 目录下，每一个 controller 都是一个 generator function，它的 `this` 都被绑定成了 [Context](./extend.md#context) 对象的实例，通过它我们可以拿到框架封装好的各种便捷属性和方法。\n+所有的 controller 文件都必须放在 `app/controller` 目录下。controller 支持多种形式进行编写，可以根据不同的项目场景和开发习惯来选择。\n \n-例如我们写一个对应到 `POST /api/posts` 接口的 controller，我们会在 `app/controller` 目录下创建一个 `post.js` 文件\n+### controller 类（推荐）\n+\n+我们可以通过定义 controller 类的方式来编写代码：\n \n ```js\n // app/controller/post.js\n-const createRule = {\n- title: { type: 'string' },\n- content: { type: 'string' },\n+module.exports = app => {\n+ class PostController extends app.Controller {\n+ * create() {\n+ const ctx = this.ctx;\n+ const createRule = {\n+ title: { type: 'string' },\n+ content: { type: 'string' },\n+ };\n+ // 校验参数\n+ ctx.validate(createRule);\n+ // 组装参数\n+ const author = ctx.session.userId;\n+ const req = Object.assign(ctx.request.body, { author });\n+ // 调用 service 进行业务处理\n+ const res = yield ctx.service.post.create(req);\n+ // 设置响应内容和响应状态码\n+ ctx.body = { id: res.id };\n+ ctx.status = 201;\n+ },\n+ };\n+\n+ return PostController;\n+}\n+```\n+\n+我们通过上面的代码定义了一个 `PostController` 的类，类里面的每一个方法都可以作为一个 controller 在 router 中引用到。\n+\n+```js\n+// app/router.js\n+module.exports = {\n+ app.post('createPost', '/api/posts', 'post.create');\n+}\n+```\n+\n+定义的 controller 类，会在每一个请求访问到 server 时实例化一个全新的对象，而项目中的 controller 类继承于 `app.Controller`，会有下面几个属性挂在 `this` 上。\n+\n+- `this.ctx`: 当前请求的上下文 [Context](./extend.md#context) 对象的实例，通过它我们可以拿到框架封装好的处理当前请求的各种便捷属性和方法。\n+- `this.app`: 当前应用 [Application](./extend.md#application) 对象的实例，通过它我们可以拿到框架提供的全局对象和方法。\n+- `this.service`：应用定义的 [service](./service.md)，通过它我们可以访问到抽象出的业务层。\n+- `this.config`：应用运行时的[配置项](./config.md)。\n+\n+#### 自定义 Controller 基类\n+\n+按照类的方式编写 controller，不仅可以让我们更好的对 controller 层代码进行抽象（例如将一些统一的处理抽象成一些私有方法），还可以通过自定义 controller 基类的方式封装应用中常用的方法。\n+\n+在[启动自定义](./app-start.md)中，应用可自己定义 controller 基类，这样在 `app/controller` 中编写 controller 时就可以使用到定义在基类上的这些方法了。\n+\n+```js\n+// app.js","path":"docs/source/zh-cn/basics/controller.md","position":62,"original_position":65,"commit_id":"0239f1bad6cbbe51fc805043ae7cc053520bdbd8","original_commit_id":"0239f1bad6cbbe51fc805043ae7cc053520bdbd8","user":{"login":"popomore","id":360661,"avatar_url":"https://avatars.githubusercontent.com/u/360661?v=3","gravatar_id":"","url":"https://api.github.com/users/popomore","html_url":"https://github.com/popomore","followers_url":"https://api.github.com/users/popomore/followers","following_url":"https://api.github.com/users/popomore/following{/other_user}","gists_url":"https://api.github.com/users/popomore/gists{/gist_id}","starred_url":"https://api.github.com/users/popomore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popomore/subscriptions","organizations_url":"https://api.github.com/users/popomore/orgs","repos_url":"https://api.github.com/users/popomore/repos","events_url":"https://api.github.com/users/popomore/events{/privacy}","received_events_url":"https://api.github.com/users/popomore/received_events","type":"User","site_admin":false},"body":"是不是写在 app/extend/application.js 更好一些","created_at":"2017-02-06T07:47:23Z","updated_at":"2017-02-06T07:47:23Z","html_url":"https://github.com/eggjs/egg/pull/314#discussion_r99530256","pull_request_url":"https://api.github.com/repos/eggjs/egg/pulls/314","_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg/pulls/comments/99530256"},"html":{"href":"https://github.com/eggjs/egg/pull/314#discussion_r99530256"},"pull_request":{"href":"https://api.github.com/repos/eggjs/egg/pulls/314"}}},"pull_request":{"url":"https://api.github.com/repos/eggjs/egg/pulls/314","id":104696272,"html_url":"https://github.com/eggjs/egg/pull/314","diff_url":"https://github.com/eggjs/egg/pull/314.diff","patch_url":"https://github.com/eggjs/egg/pull/314.patch","issue_url":"https://api.github.com/repos/eggjs/egg/issues/314","number":314,"state":"closed","locked":false,"title":"docs: controller support class and refactor jsonp","user":{"login":"dead-horse","id":985607,"avatar_url":"https://avatars.githubusercontent.com/u/985607?v=3","gravatar_id":"","url":"https://api.github.com/users/dead-horse","html_url":"https://github.com/dead-horse","followers_url":"https://api.github.com/users/dead-horse/followers","following_url":"https://api.github.com/users/dead-horse/following{/other_user}","gists_url":"https://api.github.com/users/dead-horse/gists{/gist_id}","starred_url":"https://api.github.com/users/dead-horse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dead-horse/subscriptions","organizations_url":"https://api.github.com/users/dead-horse/orgs","repos_url":"https://api.github.com/users/dead-horse/repos","events_url":"https://api.github.com/users/dead-horse/events{/privacy}","received_events_url":"https://api.github.com/users/dead-horse/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please review below requirements.\r\nBug fixes and new features should include tests and possibly benchmarks.\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n\r\n感谢您贡献代码。请确认下列 checklist 的完成情况。\r\nBug 修复和新功能必须包含测试，必要时请附上性能测试。\r\nContributors guide: https://github.com/eggjs/egg/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s). -->\r\n\r\n\r\n##### Description of change\r\n<!-- Provide a description of the change below this comment. -->\r\n","created_at":"2017-02-05T11:16:32Z","updated_at":"2017-02-06T07:47:23Z","closed_at":"2017-02-06T07:25:19Z","merged_at":"2017-02-06T07:25:19Z","merge_commit_sha":"ba7d5f51890d8bc5a7d3ad59a5501725b9b919b8","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/eggjs/egg/milestones/1","html_url":"https://github.com/eggjs/egg/milestone/1","labels_url":"https://api.github.com/repos/eggjs/egg/milestones/1/labels","id":1835754,"number":1,"title":"1.0.0","description":"- First opensource version\r\n- Publish beta version on JSConf China 2016\r\n- Publish 1.x version at the end of 2016","creator":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":145,"state":"open","created_at":"2016-06-18T07:14:07Z","updated_at":"2017-02-06T07:25:19Z","due_on":"2017-12-27T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/eggjs/egg/pulls/314/commits","review_comments_url":"https://api.github.com/repos/eggjs/egg/pulls/314/comments","review_comment_url":"https://api.github.com/repos/eggjs/egg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggjs/egg/issues/314/comments","statuses_url":"https://api.github.com/repos/eggjs/egg/statuses/0239f1bad6cbbe51fc805043ae7cc053520bdbd8","head":{"label":"eggjs:docs-controller","ref":"docs-controller","sha":"0239f1bad6cbbe51fc805043ae7cc053520bdbd8","user":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"repo":{"id":61421257,"name":"egg","full_name":"eggjs/egg","owner":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggjs/egg","description":"Born to build better enterprise frameworks and apps","fork":false,"url":"https://api.github.com/repos/eggjs/egg","forks_url":"https://api.github.com/repos/eggjs/egg/forks","keys_url":"https://api.github.com/repos/eggjs/egg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggjs/egg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggjs/egg/teams","hooks_url":"https://api.github.com/repos/eggjs/egg/hooks","issue_events_url":"https://api.github.com/repos/eggjs/egg/issues/events{/number}","events_url":"https://api.github.com/repos/eggjs/egg/events","assignees_url":"https://api.github.com/repos/eggjs/egg/assignees{/user}","branches_url":"https://api.github.com/repos/eggjs/egg/branches{/branch}","tags_url":"https://api.github.com/repos/eggjs/egg/tags","blobs_url":"https://api.github.com/repos/eggjs/egg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggjs/egg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggjs/egg/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggjs/egg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggjs/egg/statuses/{sha}","languages_url":"https://api.github.com/repos/eggjs/egg/languages","stargazers_url":"https://api.github.com/repos/eggjs/egg/stargazers","contributors_url":"https://api.github.com/repos/eggjs/egg/contributors","subscribers_url":"https://api.github.com/repos/eggjs/egg/subscribers","subscription_url":"https://api.github.com/repos/eggjs/egg/subscription","commits_url":"https://api.github.com/repos/eggjs/egg/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggjs/egg/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggjs/egg/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggjs/egg/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggjs/egg/contents/{+path}","compare_url":"https://api.github.com/repos/eggjs/egg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggjs/egg/merges","archive_url":"https://api.github.com/repos/eggjs/egg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggjs/egg/downloads","issues_url":"https://api.github.com/repos/eggjs/egg/issues{/number}","pulls_url":"https://api.github.com/repos/eggjs/egg/pulls{/number}","milestones_url":"https://api.github.com/repos/eggjs/egg/milestones{/number}","notifications_url":"https://api.github.com/repos/eggjs/egg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggjs/egg/labels{/name}","releases_url":"https://api.github.com/repos/eggjs/egg/releases{/id}","deployments_url":"https://api.github.com/repos/eggjs/egg/deployments","created_at":"2016-06-18T06:53:23Z","updated_at":"2017-02-05T11:14:31Z","pushed_at":"2017-02-06T07:25:22Z","git_url":"git://github.com/eggjs/egg.git","ssh_url":"git@github.com:eggjs/egg.git","clone_url":"https://github.com/eggjs/egg.git","svn_url":"https://github.com/eggjs/egg","homepage":"https://eggjs.org","size":1956,"stargazers_count":672,"watchers_count":672,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":45,"forks":55,"open_issues":45,"watchers":672,"default_branch":"master"}},"base":{"label":"eggjs:master","ref":"master","sha":"e47572ca91c7b0431675e933590f413e066c64ae","user":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"repo":{"id":61421257,"name":"egg","full_name":"eggjs/egg","owner":{"login":"eggjs","id":15833670,"avatar_url":"https://avatars.githubusercontent.com/u/15833670?v=3","gravatar_id":"","url":"https://api.github.com/users/eggjs","html_url":"https://github.com/eggjs","followers_url":"https://api.github.com/users/eggjs/followers","following_url":"https://api.github.com/users/eggjs/following{/other_user}","gists_url":"https://api.github.com/users/eggjs/gists{/gist_id}","starred_url":"https://api.github.com/users/eggjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggjs/subscriptions","organizations_url":"https://api.github.com/users/eggjs/orgs","repos_url":"https://api.github.com/users/eggjs/repos","events_url":"https://api.github.com/users/eggjs/events{/privacy}","received_events_url":"https://api.github.com/users/eggjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggjs/egg","description":"Born to build better enterprise frameworks and apps","fork":false,"url":"https://api.github.com/repos/eggjs/egg","forks_url":"https://api.github.com/repos/eggjs/egg/forks","keys_url":"https://api.github.com/repos/eggjs/egg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggjs/egg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggjs/egg/teams","hooks_url":"https://api.github.com/repos/eggjs/egg/hooks","issue_events_url":"https://api.github.com/repos/eggjs/egg/issues/events{/number}","events_url":"https://api.github.com/repos/eggjs/egg/events","assignees_url":"https://api.github.com/repos/eggjs/egg/assignees{/user}","branches_url":"https://api.github.com/repos/eggjs/egg/branches{/branch}","tags_url":"https://api.github.com/repos/eggjs/egg/tags","blobs_url":"https://api.github.com/repos/eggjs/egg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggjs/egg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggjs/egg/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggjs/egg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggjs/egg/statuses/{sha}","languages_url":"https://api.github.com/repos/eggjs/egg/languages","stargazers_url":"https://api.github.com/repos/eggjs/egg/stargazers","contributors_url":"https://api.github.com/repos/eggjs/egg/contributors","subscribers_url":"https://api.github.com/repos/eggjs/egg/subscribers","subscription_url":"https://api.github.com/repos/eggjs/egg/subscription","commits_url":"https://api.github.com/repos/eggjs/egg/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggjs/egg/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggjs/egg/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggjs/egg/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggjs/egg/contents/{+path}","compare_url":"https://api.github.com/repos/eggjs/egg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggjs/egg/merges","archive_url":"https://api.github.com/repos/eggjs/egg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggjs/egg/downloads","issues_url":"https://api.github.com/repos/eggjs/egg/issues{/number}","pulls_url":"https://api.github.com/repos/eggjs/egg/pulls{/number}","milestones_url":"https://api.github.com/repos/eggjs/egg/milestones{/number}","notifications_url":"https://api.github.com/repos/eggjs/egg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggjs/egg/labels{/name}","releases_url":"https://api.github.com/repos/eggjs/egg/releases{/id}","deployments_url":"https://api.github.com/repos/eggjs/egg/deployments","created_at":"2016-06-18T06:53:23Z","updated_at":"2017-02-05T11:14:31Z","pushed_at":"2017-02-06T07:25:22Z","git_url":"git://github.com/eggjs/egg.git","ssh_url":"git@github.com:eggjs/egg.git","clone_url":"https://github.com/eggjs/egg.git","svn_url":"https://github.com/eggjs/egg","homepage":"https://eggjs.org","size":1956,"stargazers_count":672,"watchers_count":672,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":45,"forks":55,"open_issues":45,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eggjs/egg/pulls/314"},"html":{"href":"https://github.com/eggjs/egg/pull/314"},"issue":{"href":"https://api.github.com/repos/eggjs/egg/issues/314"},"comments":{"href":"https://api.github.com/repos/eggjs/egg/issues/314/comments"},"review_comments":{"href":"https://api.github.com/repos/eggjs/egg/pulls/314/comments"},"review_comment":{"href":"https://api.github.com/repos/eggjs/egg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggjs/egg/pulls/314/commits"},"statuses":{"href":"https://api.github.com/repos/eggjs/egg/statuses/0239f1bad6cbbe51fc805043ae7cc053520bdbd8"}}}}
|
{
"id": 61421257,
"name": "eggjs/egg",
"url": "https://api.github.com/repos/eggjs/egg"
}
|
{
"id": 360661,
"login": "popomore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/360661?",
"url": "https://api.github.com/users/popomore"
}
|
{
"id": 15833670,
"login": "eggjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15833670?",
"url": "https://api.github.com/orgs/eggjs"
}
| 2017-02-06T07:47:23 |
5270925885
|
{"actor":{"display_login":"popomore"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/govau/service-manual/pulls/comments/143093032","pull_request_review_id":67554813,"id":143093032,"diff_hunk":"@@ -0,0 +1,45 @@\n+import PropTypes from 'prop-types';\n+import Slugify from 'slugify';\n+import React from 'react';\n+\n+\n+/**\n+ * The plaintextblock component\n+ */\n+const Plaintextblock = ( page ) => {\n+\n+\tconsole.log(page._body);","path":"src/text/plaintextblock.js","position":11,"original_position":11,"commit_id":"f0ca9bc7ecb56e656617396c0a1089269e20db4e","original_commit_id":"f0ca9bc7ecb56e656617396c0a1089269e20db4e","user":{"login":"dominikwilkowski","id":1266923,"avatar_url":"https://avatars3.githubusercontent.com/u/1266923?v=4","gravatar_id":"","url":"https://api.github.com/users/dominikwilkowski","html_url":"https://github.com/dominikwilkowski","followers_url":"https://api.github.com/users/dominikwilkowski/followers","following_url":"https://api.github.com/users/dominikwilkowski/following{/other_user}","gists_url":"https://api.github.com/users/dominikwilkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/dominikwilkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominikwilkowski/subscriptions","organizations_url":"https://api.github.com/users/dominikwilkowski/orgs","repos_url":"https://api.github.com/users/dominikwilkowski/repos","events_url":"https://api.github.com/users/dominikwilkowski/events{/privacy}","received_events_url":"https://api.github.com/users/dominikwilkowski/received_events","type":"User","site_admin":false},"body":"wanna take that one out eh? :)","created_at":"2017-10-06T01:16:11Z","updated_at":"2017-10-06T01:16:56Z","html_url":"https://github.com/govau/service-manual/pull/394#discussion_r143093032","pull_request_url":"https://api.github.com/repos/govau/service-manual/pulls/394","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/govau/service-manual/pulls/comments/143093032"},"html":{"href":"https://github.com/govau/service-manual/pull/394#discussion_r143093032"},"pull_request":{"href":"https://api.github.com/repos/govau/service-manual/pulls/394"}}},"pull_request":{"url":"https://api.github.com/repos/govau/service-manual/pulls/394","id":145054244,"html_url":"https://github.com/govau/service-manual/pull/394","diff_url":"https://github.com/govau/service-manual/pull/394.diff","patch_url":"https://github.com/govau/service-manual/pull/394.patch","issue_url":"https://api.github.com/repos/govau/service-manual/issues/394","number":394,"state":"open","locked":false,"title":"email template","user":{"login":"marksantoso","id":3507850,"avatar_url":"https://avatars3.githubusercontent.com/u/3507850?v=4","gravatar_id":"","url":"https://api.github.com/users/marksantoso","html_url":"https://github.com/marksantoso","followers_url":"https://api.github.com/users/marksantoso/followers","following_url":"https://api.github.com/users/marksantoso/following{/other_user}","gists_url":"https://api.github.com/users/marksantoso/gists{/gist_id}","starred_url":"https://api.github.com/users/marksantoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksantoso/subscriptions","organizations_url":"https://api.github.com/users/marksantoso/orgs","repos_url":"https://api.github.com/users/marksantoso/repos","events_url":"https://api.github.com/users/marksantoso/events{/privacy}","received_events_url":"https://api.github.com/users/marksantoso/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-06T01:09:47Z","updated_at":"2017-10-06T01:16:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1946850d25c85f8e42c32a27f983d7f1006dacef","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/govau/service-manual/pulls/394/commits","review_comments_url":"https://api.github.com/repos/govau/service-manual/pulls/394/comments","review_comment_url":"https://api.github.com/repos/govau/service-manual/pulls/comments{/number}","comments_url":"https://api.github.com/repos/govau/service-manual/issues/394/comments","statuses_url":"https://api.github.com/repos/govau/service-manual/statuses/f0ca9bc7ecb56e656617396c0a1089269e20db4e","head":{"label":"marksantoso:test-staging","ref":"test-staging","sha":"f0ca9bc7ecb56e656617396c0a1089269e20db4e","user":{"login":"marksantoso","id":3507850,"avatar_url":"https://avatars3.githubusercontent.com/u/3507850?v=4","gravatar_id":"","url":"https://api.github.com/users/marksantoso","html_url":"https://github.com/marksantoso","followers_url":"https://api.github.com/users/marksantoso/followers","following_url":"https://api.github.com/users/marksantoso/following{/other_user}","gists_url":"https://api.github.com/users/marksantoso/gists{/gist_id}","starred_url":"https://api.github.com/users/marksantoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksantoso/subscriptions","organizations_url":"https://api.github.com/users/marksantoso/orgs","repos_url":"https://api.github.com/users/marksantoso/repos","events_url":"https://api.github.com/users/marksantoso/events{/privacy}","received_events_url":"https://api.github.com/users/marksantoso/received_events","type":"User","site_admin":false},"repo":{"id":95724493,"name":"service-manual","full_name":"marksantoso/service-manual","owner":{"login":"marksantoso","id":3507850,"avatar_url":"https://avatars3.githubusercontent.com/u/3507850?v=4","gravatar_id":"","url":"https://api.github.com/users/marksantoso","html_url":"https://github.com/marksantoso","followers_url":"https://api.github.com/users/marksantoso/followers","following_url":"https://api.github.com/users/marksantoso/following{/other_user}","gists_url":"https://api.github.com/users/marksantoso/gists{/gist_id}","starred_url":"https://api.github.com/users/marksantoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksantoso/subscriptions","organizations_url":"https://api.github.com/users/marksantoso/orgs","repos_url":"https://api.github.com/users/marksantoso/repos","events_url":"https://api.github.com/users/marksantoso/events{/privacy}","received_events_url":"https://api.github.com/users/marksantoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marksantoso/service-manual","description":"Service manual","fork":true,"url":"https://api.github.com/repos/marksantoso/service-manual","forks_url":"https://api.github.com/repos/marksantoso/service-manual/forks","keys_url":"https://api.github.com/repos/marksantoso/service-manual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marksantoso/service-manual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marksantoso/service-manual/teams","hooks_url":"https://api.github.com/repos/marksantoso/service-manual/hooks","issue_events_url":"https://api.github.com/repos/marksantoso/service-manual/issues/events{/number}","events_url":"https://api.github.com/repos/marksantoso/service-manual/events","assignees_url":"https://api.github.com/repos/marksantoso/service-manual/assignees{/user}","branches_url":"https://api.github.com/repos/marksantoso/service-manual/branches{/branch}","tags_url":"https://api.github.com/repos/marksantoso/service-manual/tags","blobs_url":"https://api.github.com/repos/marksantoso/service-manual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marksantoso/service-manual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marksantoso/service-manual/git/refs{/sha}","trees_url":"https://api.github.com/repos/marksantoso/service-manual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marksantoso/service-manual/statuses/{sha}","languages_url":"https://api.github.com/repos/marksantoso/service-manual/languages","stargazers_url":"https://api.github.com/repos/marksantoso/service-manual/stargazers","contributors_url":"https://api.github.com/repos/marksantoso/service-manual/contributors","subscribers_url":"https://api.github.com/repos/marksantoso/service-manual/subscribers","subscription_url":"https://api.github.com/repos/marksantoso/service-manual/subscription","commits_url":"https://api.github.com/repos/marksantoso/service-manual/commits{/sha}","git_commits_url":"https://api.github.com/repos/marksantoso/service-manual/git/commits{/sha}","comments_url":"https://api.github.com/repos/marksantoso/service-manual/comments{/number}","issue_comment_url":"https://api.github.com/repos/marksantoso/service-manual/issues/comments{/number}","contents_url":"https://api.github.com/repos/marksantoso/service-manual/contents/{+path}","compare_url":"https://api.github.com/repos/marksantoso/service-manual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marksantoso/service-manual/merges","archive_url":"https://api.github.com/repos/marksantoso/service-manual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marksantoso/service-manual/downloads","issues_url":"https://api.github.com/repos/marksantoso/service-manual/issues{/number}","pulls_url":"https://api.github.com/repos/marksantoso/service-manual/pulls{/number}","milestones_url":"https://api.github.com/repos/marksantoso/service-manual/milestones{/number}","notifications_url":"https://api.github.com/repos/marksantoso/service-manual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marksantoso/service-manual/labels{/name}","releases_url":"https://api.github.com/repos/marksantoso/service-manual/releases{/id}","deployments_url":"https://api.github.com/repos/marksantoso/service-manual/deployments","created_at":"2017-06-29T01:01:12Z","updated_at":"2017-06-29T01:01:13Z","pushed_at":"2017-10-06T01:08:18Z","git_url":"git://github.com/marksantoso/service-manual.git","ssh_url":"git@github.com:marksantoso/service-manual.git","clone_url":"https://github.com/marksantoso/service-manual.git","svn_url":"https://github.com/marksantoso/service-manual","homepage":null,"size":26061,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"govau:test-staging","ref":"test-staging","sha":"f46299ddce5ccb80c8983a0d007b274588924ce6","user":{"login":"govau","id":25235510,"avatar_url":"https://avatars3.githubusercontent.com/u/25235510?v=4","gravatar_id":"","url":"https://api.github.com/users/govau","html_url":"https://github.com/govau","followers_url":"https://api.github.com/users/govau/followers","following_url":"https://api.github.com/users/govau/following{/other_user}","gists_url":"https://api.github.com/users/govau/gists{/gist_id}","starred_url":"https://api.github.com/users/govau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govau/subscriptions","organizations_url":"https://api.github.com/users/govau/orgs","repos_url":"https://api.github.com/users/govau/repos","events_url":"https://api.github.com/users/govau/events{/privacy}","received_events_url":"https://api.github.com/users/govau/received_events","type":"Organization","site_admin":false},"repo":{"id":90583682,"name":"service-manual","full_name":"govau/service-manual","owner":{"login":"govau","id":25235510,"avatar_url":"https://avatars3.githubusercontent.com/u/25235510?v=4","gravatar_id":"","url":"https://api.github.com/users/govau","html_url":"https://github.com/govau","followers_url":"https://api.github.com/users/govau/followers","following_url":"https://api.github.com/users/govau/following{/other_user}","gists_url":"https://api.github.com/users/govau/gists{/gist_id}","starred_url":"https://api.github.com/users/govau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govau/subscriptions","organizations_url":"https://api.github.com/users/govau/orgs","repos_url":"https://api.github.com/users/govau/repos","events_url":"https://api.github.com/users/govau/events{/privacy}","received_events_url":"https://api.github.com/users/govau/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/govau/service-manual","description":"Service manual","fork":false,"url":"https://api.github.com/repos/govau/service-manual","forks_url":"https://api.github.com/repos/govau/service-manual/forks","keys_url":"https://api.github.com/repos/govau/service-manual/keys{/key_id}","collaborators_url":"https://api.github.com/repos/govau/service-manual/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/govau/service-manual/teams","hooks_url":"https://api.github.com/repos/govau/service-manual/hooks","issue_events_url":"https://api.github.com/repos/govau/service-manual/issues/events{/number}","events_url":"https://api.github.com/repos/govau/service-manual/events","assignees_url":"https://api.github.com/repos/govau/service-manual/assignees{/user}","branches_url":"https://api.github.com/repos/govau/service-manual/branches{/branch}","tags_url":"https://api.github.com/repos/govau/service-manual/tags","blobs_url":"https://api.github.com/repos/govau/service-manual/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/govau/service-manual/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/govau/service-manual/git/refs{/sha}","trees_url":"https://api.github.com/repos/govau/service-manual/git/trees{/sha}","statuses_url":"https://api.github.com/repos/govau/service-manual/statuses/{sha}","languages_url":"https://api.github.com/repos/govau/service-manual/languages","stargazers_url":"https://api.github.com/repos/govau/service-manual/stargazers","contributors_url":"https://api.github.com/repos/govau/service-manual/contributors","subscribers_url":"https://api.github.com/repos/govau/service-manual/subscribers","subscription_url":"https://api.github.com/repos/govau/service-manual/subscription","commits_url":"https://api.github.com/repos/govau/service-manual/commits{/sha}","git_commits_url":"https://api.github.com/repos/govau/service-manual/git/commits{/sha}","comments_url":"https://api.github.com/repos/govau/service-manual/comments{/number}","issue_comment_url":"https://api.github.com/repos/govau/service-manual/issues/comments{/number}","contents_url":"https://api.github.com/repos/govau/service-manual/contents/{+path}","compare_url":"https://api.github.com/repos/govau/service-manual/compare/{base}...{head}","merges_url":"https://api.github.com/repos/govau/service-manual/merges","archive_url":"https://api.github.com/repos/govau/service-manual/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/govau/service-manual/downloads","issues_url":"https://api.github.com/repos/govau/service-manual/issues{/number}","pulls_url":"https://api.github.com/repos/govau/service-manual/pulls{/number}","milestones_url":"https://api.github.com/repos/govau/service-manual/milestones{/number}","notifications_url":"https://api.github.com/repos/govau/service-manual/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/govau/service-manual/labels{/name}","releases_url":"https://api.github.com/repos/govau/service-manual/releases{/id}","deployments_url":"https://api.github.com/repos/govau/service-manual/deployments","created_at":"2017-05-08T03:41:41Z","updated_at":"2017-08-09T04:07:47Z","pushed_at":"2017-10-06T01:09:49Z","git_url":"git://github.com/govau/service-manual.git","ssh_url":"git@github.com:govau/service-manual.git","clone_url":"https://github.com/govau/service-manual.git","svn_url":"https://github.com/govau/service-manual","homepage":"https://guides.service.gov.au/","size":26059,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":13,"mirror_url":null,"open_issues_count":1,"forks":13,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/govau/service-manual/pulls/394"},"html":{"href":"https://github.com/govau/service-manual/pull/394"},"issue":{"href":"https://api.github.com/repos/govau/service-manual/issues/394"},"comments":{"href":"https://api.github.com/repos/govau/service-manual/issues/394/comments"},"review_comments":{"href":"https://api.github.com/repos/govau/service-manual/pulls/394/comments"},"review_comment":{"href":"https://api.github.com/repos/govau/service-manual/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/govau/service-manual/pulls/394/commits"},"statuses":{"href":"https://api.github.com/repos/govau/service-manual/statuses/f0ca9bc7ecb56e656617396c0a1089269e20db4e"}},"author_association":"COLLABORATOR"}}
|
{
"id": 90583682,
"name": "govau/service-manual",
"url": "https://api.github.com/repos/govau/service-manual"
}
|
{
"id": 1266923,
"login": "dominikwilkowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1266923?",
"url": "https://api.github.com/users/dominikwilkowski"
}
|
{
"id": 25235510,
"login": "govau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25235510?",
"url": "https://api.github.com/orgs/govau"
}
| 2017-10-06T01:16:11 |
6681130041
|
{"actor":{"display_login":"dominikwilkowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hexpm/hexpm/pulls/comments/119281197","pull_request_review_id":41144487,"id":119281197,"diff_hunk":"@@ -0,0 +1,46 @@\n+defmodule Hexpm.Accounts.UserTwoFactor do\n+ use Hexpm.Web, :schema\n+\n+ @types ~w(totp disabled)\n+\n+ embedded_schema do\n+ field :enabled, :boolean, default: false\n+ field :type, :string, default: \"disabled\"","path":"lib/hexpm/accounts/user_twofactor.ex","position":null,"original_position":8,"commit_id":"3f4a1651ed4822932726d257b42c930d15bbad41","original_commit_id":"33ec46138d7ee0f6909605f3a1c3d4144d274854","user":{"login":"jcspencer","id":860934,"avatar_url":"https://avatars3.githubusercontent.com/u/860934?v=3","gravatar_id":"","url":"https://api.github.com/users/jcspencer","html_url":"https://github.com/jcspencer","followers_url":"https://api.github.com/users/jcspencer/followers","following_url":"https://api.github.com/users/jcspencer/following{/other_user}","gists_url":"https://api.github.com/users/jcspencer/gists{/gist_id}","starred_url":"https://api.github.com/users/jcspencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcspencer/subscriptions","organizations_url":"https://api.github.com/users/jcspencer/orgs","repos_url":"https://api.github.com/users/jcspencer/repos","events_url":"https://api.github.com/users/jcspencer/events{/privacy}","received_events_url":"https://api.github.com/users/jcspencer/received_events","type":"User","site_admin":false},"body":"It's supposed to identify whether the 2FA is via TOTP or something else (SMS). Not sure whether it's worth keeping in at this point.","created_at":"2017-05-31T06:46:17Z","updated_at":"2017-05-31T06:46:17Z","html_url":"https://github.com/hexpm/hexpm/pull/505#discussion_r119281197","pull_request_url":"https://api.github.com/repos/hexpm/hexpm/pulls/505","_links":{"self":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/comments/119281197"},"html":{"href":"https://github.com/hexpm/hexpm/pull/505#discussion_r119281197"},"pull_request":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/hexpm/hexpm/pulls/505","id":123029388,"html_url":"https://github.com/hexpm/hexpm/pull/505","diff_url":"https://github.com/hexpm/hexpm/pull/505.diff","patch_url":"https://github.com/hexpm/hexpm/pull/505.patch","issue_url":"https://api.github.com/repos/hexpm/hexpm/issues/505","number":505,"state":"open","locked":false,"title":"Add TwoFactor Authentication [WIP]","user":{"login":"jcspencer","id":860934,"avatar_url":"https://avatars3.githubusercontent.com/u/860934?v=3","gravatar_id":"","url":"https://api.github.com/users/jcspencer","html_url":"https://github.com/jcspencer","followers_url":"https://api.github.com/users/jcspencer/followers","following_url":"https://api.github.com/users/jcspencer/following{/other_user}","gists_url":"https://api.github.com/users/jcspencer/gists{/gist_id}","starred_url":"https://api.github.com/users/jcspencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcspencer/subscriptions","organizations_url":"https://api.github.com/users/jcspencer/orgs","repos_url":"https://api.github.com/users/jcspencer/repos","events_url":"https://api.github.com/users/jcspencer/events{/privacy}","received_events_url":"https://api.github.com/users/jcspencer/received_events","type":"User","site_admin":false},"body":"⚠️ work in progress ⚠️ \r\n\r\nTODO:\r\n- [ ] Add unit tests\r\n- [ ] Move 2FA login to secondary page\r\n- [ ] Add *sudo mode* to 2FA dashboard page\r\n\r\n--\r\n\r\n**Implementation Details**\r\n\r\nBy default, a each user has a twofactor column that looks like:\r\n```json\r\n{\r\n \"id\": \"<uuid>\", \r\n \"type\": \"disabled\", \r\n \"secret\": \"\", \r\n \"enabled\": false,\r\n \"backupcodes\": []\r\n}\r\n```\r\n \r\nWhere:\r\n- `type` is the type of 2FA to use; currently, it's limited to 'disabled' and 'totp' (future implementations could include 'sms', etc.)\r\n- `secret` is a shared secret (20 bytes - base32) used for TOTP. It is encrypted using PBES2_HMAC_SHA2 / AES_CBC_HMAC_SHA2 (described here hexpm/hexpm#255) with an app secret before we store it.\r\n- `backupcodes` is an array of base32 strings - each 10 bytes (base32) which are formatted in the structure \"xxxx-xxxx-xxxx\" - these are single-use tokens that the user can use to access their account if they lose their phone, etc. These are also encrypted using PBES2_HMAC_SHA2 / AES_CBC_HMAC_SHA2.\r\n\r\n**Setup Process**\r\n- The secret, as well as ten backup codes are generated and stored in the database.\r\n- A QR code is generated to allow the user to quickly setup Google Authenticator (or a similar TOTP generator), along with a secret to manually type in. After this, the QR code cannot be regenerated for security purposes.\r\n- The user is requested to enter the current TOTP token to confirm that their client is setup properly (makes sure we don't lock anybody out!)\r\n- If the code is correct, we toggle the `enabled` field and give the user their 10 backup codes.\r\n\r\n**Authentication Process**\r\n*Web*\r\n- The login page has an additional field called `OTP`. If the code is incorrect or not included, the response is returned with the message \"Two factor authentication required.\"\r\n\r\n*API*\r\n- The user must append the header `x-hex-otp` with the current OTP to the request\r\n- If the TOTP token is either wrong or not included, the response is returned with the `x-hex-otp` header `required; type` (where type is either 'totp' or 'sms'), a 401 status code and the message \"two-factor authentication required\".\r\n\r\n--\r\n\r\nScreenshots:\r\n<img width=\"742\" alt=\"screen shot 2017-05-30 at 9 35 17 pm\" src=\"https://cloud.githubusercontent.com/assets/860934/26581470/fb3c7c52-457f-11e7-98f6-dc4877609c67.png\">\r\n<img width=\"591\" alt=\"screen shot 2017-05-30 at 9 35 34 pm\" src=\"https://cloud.githubusercontent.com/assets/860934/26581471/fb3eaf9a-457f-11e7-9edb-81a9208e0b04.png\">","created_at":"2017-05-30T11:39:33Z","updated_at":"2017-05-31T06:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2feaefab481b74e2e9174e059f7b3c186deecdf3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hexpm/hexpm/pulls/505/commits","review_comments_url":"https://api.github.com/repos/hexpm/hexpm/pulls/505/comments","review_comment_url":"https://api.github.com/repos/hexpm/hexpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hexpm/hexpm/issues/505/comments","statuses_url":"https://api.github.com/repos/hexpm/hexpm/statuses/3f4a1651ed4822932726d257b42c930d15bbad41","head":{"label":"jcspencer:2fa","ref":"2fa","sha":"3f4a1651ed4822932726d257b42c930d15bbad41","user":{"login":"jcspencer","id":860934,"avatar_url":"https://avatars3.githubusercontent.com/u/860934?v=3","gravatar_id":"","url":"https://api.github.com/users/jcspencer","html_url":"https://github.com/jcspencer","followers_url":"https://api.github.com/users/jcspencer/followers","following_url":"https://api.github.com/users/jcspencer/following{/other_user}","gists_url":"https://api.github.com/users/jcspencer/gists{/gist_id}","starred_url":"https://api.github.com/users/jcspencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcspencer/subscriptions","organizations_url":"https://api.github.com/users/jcspencer/orgs","repos_url":"https://api.github.com/users/jcspencer/repos","events_url":"https://api.github.com/users/jcspencer/events{/privacy}","received_events_url":"https://api.github.com/users/jcspencer/received_events","type":"User","site_admin":false},"repo":{"id":28681320,"name":"hex_web","full_name":"jcspencer/hex_web","owner":{"login":"jcspencer","id":860934,"avatar_url":"https://avatars3.githubusercontent.com/u/860934?v=3","gravatar_id":"","url":"https://api.github.com/users/jcspencer","html_url":"https://github.com/jcspencer","followers_url":"https://api.github.com/users/jcspencer/followers","following_url":"https://api.github.com/users/jcspencer/following{/other_user}","gists_url":"https://api.github.com/users/jcspencer/gists{/gist_id}","starred_url":"https://api.github.com/users/jcspencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcspencer/subscriptions","organizations_url":"https://api.github.com/users/jcspencer/orgs","repos_url":"https://api.github.com/users/jcspencer/repos","events_url":"https://api.github.com/users/jcspencer/events{/privacy}","received_events_url":"https://api.github.com/users/jcspencer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcspencer/hex_web","description":"API server and website for Hex","fork":true,"url":"https://api.github.com/repos/jcspencer/hex_web","forks_url":"https://api.github.com/repos/jcspencer/hex_web/forks","keys_url":"https://api.github.com/repos/jcspencer/hex_web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcspencer/hex_web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcspencer/hex_web/teams","hooks_url":"https://api.github.com/repos/jcspencer/hex_web/hooks","issue_events_url":"https://api.github.com/repos/jcspencer/hex_web/issues/events{/number}","events_url":"https://api.github.com/repos/jcspencer/hex_web/events","assignees_url":"https://api.github.com/repos/jcspencer/hex_web/assignees{/user}","branches_url":"https://api.github.com/repos/jcspencer/hex_web/branches{/branch}","tags_url":"https://api.github.com/repos/jcspencer/hex_web/tags","blobs_url":"https://api.github.com/repos/jcspencer/hex_web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcspencer/hex_web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcspencer/hex_web/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcspencer/hex_web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcspencer/hex_web/statuses/{sha}","languages_url":"https://api.github.com/repos/jcspencer/hex_web/languages","stargazers_url":"https://api.github.com/repos/jcspencer/hex_web/stargazers","contributors_url":"https://api.github.com/repos/jcspencer/hex_web/contributors","subscribers_url":"https://api.github.com/repos/jcspencer/hex_web/subscribers","subscription_url":"https://api.github.com/repos/jcspencer/hex_web/subscription","commits_url":"https://api.github.com/repos/jcspencer/hex_web/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcspencer/hex_web/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcspencer/hex_web/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcspencer/hex_web/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcspencer/hex_web/contents/{+path}","compare_url":"https://api.github.com/repos/jcspencer/hex_web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcspencer/hex_web/merges","archive_url":"https://api.github.com/repos/jcspencer/hex_web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcspencer/hex_web/downloads","issues_url":"https://api.github.com/repos/jcspencer/hex_web/issues{/number}","pulls_url":"https://api.github.com/repos/jcspencer/hex_web/pulls{/number}","milestones_url":"https://api.github.com/repos/jcspencer/hex_web/milestones{/number}","notifications_url":"https://api.github.com/repos/jcspencer/hex_web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcspencer/hex_web/labels{/name}","releases_url":"https://api.github.com/repos/jcspencer/hex_web/releases{/id}","deployments_url":"https://api.github.com/repos/jcspencer/hex_web/deployments","created_at":"2015-01-01T05:51:53Z","updated_at":"2015-01-01T05:51:54Z","pushed_at":"2017-05-31T02:45:42Z","git_url":"git://github.com/jcspencer/hex_web.git","ssh_url":"git@github.com:jcspencer/hex_web.git","clone_url":"https://github.com/jcspencer/hex_web.git","svn_url":"https://github.com/jcspencer/hex_web","homepage":"https://hex.pm","size":6189,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hexpm:master","ref":"master","sha":"8dea750acb8a3335ae2d16e8e4ef6f693153eb54","user":{"login":"hexpm","id":6621265,"avatar_url":"https://avatars0.githubusercontent.com/u/6621265?v=3","gravatar_id":"","url":"https://api.github.com/users/hexpm","html_url":"https://github.com/hexpm","followers_url":"https://api.github.com/users/hexpm/followers","following_url":"https://api.github.com/users/hexpm/following{/other_user}","gists_url":"https://api.github.com/users/hexpm/gists{/gist_id}","starred_url":"https://api.github.com/users/hexpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexpm/subscriptions","organizations_url":"https://api.github.com/users/hexpm/orgs","repos_url":"https://api.github.com/users/hexpm/repos","events_url":"https://api.github.com/users/hexpm/events{/privacy}","received_events_url":"https://api.github.com/users/hexpm/received_events","type":"Organization","site_admin":false},"repo":{"id":16328245,"name":"hexpm","full_name":"hexpm/hexpm","owner":{"login":"hexpm","id":6621265,"avatar_url":"https://avatars0.githubusercontent.com/u/6621265?v=3","gravatar_id":"","url":"https://api.github.com/users/hexpm","html_url":"https://github.com/hexpm","followers_url":"https://api.github.com/users/hexpm/followers","following_url":"https://api.github.com/users/hexpm/following{/other_user}","gists_url":"https://api.github.com/users/hexpm/gists{/gist_id}","starred_url":"https://api.github.com/users/hexpm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexpm/subscriptions","organizations_url":"https://api.github.com/users/hexpm/orgs","repos_url":"https://api.github.com/users/hexpm/repos","events_url":"https://api.github.com/users/hexpm/events{/privacy}","received_events_url":"https://api.github.com/users/hexpm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hexpm/hexpm","description":"API server and website for Hex","fork":false,"url":"https://api.github.com/repos/hexpm/hexpm","forks_url":"https://api.github.com/repos/hexpm/hexpm/forks","keys_url":"https://api.github.com/repos/hexpm/hexpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hexpm/hexpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hexpm/hexpm/teams","hooks_url":"https://api.github.com/repos/hexpm/hexpm/hooks","issue_events_url":"https://api.github.com/repos/hexpm/hexpm/issues/events{/number}","events_url":"https://api.github.com/repos/hexpm/hexpm/events","assignees_url":"https://api.github.com/repos/hexpm/hexpm/assignees{/user}","branches_url":"https://api.github.com/repos/hexpm/hexpm/branches{/branch}","tags_url":"https://api.github.com/repos/hexpm/hexpm/tags","blobs_url":"https://api.github.com/repos/hexpm/hexpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hexpm/hexpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hexpm/hexpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hexpm/hexpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hexpm/hexpm/statuses/{sha}","languages_url":"https://api.github.com/repos/hexpm/hexpm/languages","stargazers_url":"https://api.github.com/repos/hexpm/hexpm/stargazers","contributors_url":"https://api.github.com/repos/hexpm/hexpm/contributors","subscribers_url":"https://api.github.com/repos/hexpm/hexpm/subscribers","subscription_url":"https://api.github.com/repos/hexpm/hexpm/subscription","commits_url":"https://api.github.com/repos/hexpm/hexpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hexpm/hexpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hexpm/hexpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hexpm/hexpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hexpm/hexpm/contents/{+path}","compare_url":"https://api.github.com/repos/hexpm/hexpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hexpm/hexpm/merges","archive_url":"https://api.github.com/repos/hexpm/hexpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hexpm/hexpm/downloads","issues_url":"https://api.github.com/repos/hexpm/hexpm/issues{/number}","pulls_url":"https://api.github.com/repos/hexpm/hexpm/pulls{/number}","milestones_url":"https://api.github.com/repos/hexpm/hexpm/milestones{/number}","notifications_url":"https://api.github.com/repos/hexpm/hexpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hexpm/hexpm/labels{/name}","releases_url":"https://api.github.com/repos/hexpm/hexpm/releases{/id}","deployments_url":"https://api.github.com/repos/hexpm/hexpm/deployments","created_at":"2014-01-28T22:29:21Z","updated_at":"2017-05-28T18:18:33Z","pushed_at":"2017-05-31T02:45:44Z","git_url":"git://github.com/hexpm/hexpm.git","ssh_url":"git@github.com:hexpm/hexpm.git","clone_url":"https://github.com/hexpm/hexpm.git","svn_url":"https://github.com/hexpm/hexpm","homepage":"https://hex.pm","size":6230,"stargazers_count":313,"watchers_count":313,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":131,"mirror_url":null,"open_issues_count":25,"forks":131,"open_issues":25,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/505"},"html":{"href":"https://github.com/hexpm/hexpm/pull/505"},"issue":{"href":"https://api.github.com/repos/hexpm/hexpm/issues/505"},"comments":{"href":"https://api.github.com/repos/hexpm/hexpm/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hexpm/hexpm/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/hexpm/hexpm/statuses/3f4a1651ed4822932726d257b42c930d15bbad41"}}}}
|
{
"id": 16328245,
"name": "hexpm/hexpm",
"url": "https://api.github.com/repos/hexpm/hexpm"
}
|
{
"id": 860934,
"login": "jcspencer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/860934?",
"url": "https://api.github.com/users/jcspencer"
}
|
{
"id": 6621265,
"login": "hexpm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6621265?",
"url": "https://api.github.com/orgs/hexpm"
}
| 2017-05-31T06:46:17 |
5972315793
|
{"actor":{"display_login":"jcspencer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/135295832","pull_request_review_id":58696573,"id":135295832,"diff_hunk":"@@ -16,3 +16,10 @@\n @include button($grey-3);","path":"src/main/public/stylesheets/components/_form.scss","position":1,"original_position":1,"commit_id":"065a804a251c6b8ea3b8c05b2eb62dbabc0d6109","original_commit_id":"c5c6be057de3a1f37df45bb8e929fd99ddc0b482","user":{"login":"yarpo","id":5647337,"avatar_url":"https://avatars0.githubusercontent.com/u/5647337?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpo","html_url":"https://github.com/yarpo","followers_url":"https://api.github.com/users/yarpo/followers","following_url":"https://api.github.com/users/yarpo/following{/other_user}","gists_url":"https://api.github.com/users/yarpo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpo/subscriptions","organizations_url":"https://api.github.com/users/yarpo/orgs","repos_url":"https://api.github.com/users/yarpo/repos","events_url":"https://api.github.com/users/yarpo/events{/privacy}","received_events_url":"https://api.github.com/users/yarpo/received_events","type":"User","site_admin":false},"body":"we have two different approaches:\r\n\r\n```.input-symbol-pound::before {\r\n content: '£';\r\n left: 7px;\r\n position: absolute;\r\n top: 1px;\r\n}```\r\n\r\nand this image.\r\n\r\nI'll talk to UX guys to find out if this is what we want. If not - I'll align it.","created_at":"2017-08-25T16:07:07Z","updated_at":"2017-08-25T16:07:07Z","html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/21#discussion_r135295832","pull_request_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments/135295832"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/21#discussion_r135295832"},"pull_request":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21"}},"in_reply_to_id":134949107},"pull_request":{"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21","id":137264356,"html_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/21","diff_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/21.diff","patch_url":"https://github.com/hmcts/cmc-citizen-frontend/pull/21.patch","issue_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/21","number":21,"state":"open","locked":false,"title":"Feature/roc 1530 ccj amount","user":{"login":"yarpo","id":5647337,"avatar_url":"https://avatars0.githubusercontent.com/u/5647337?v=4","gravatar_id":"","url":"https://api.github.com/users/yarpo","html_url":"https://github.com/yarpo","followers_url":"https://api.github.com/users/yarpo/followers","following_url":"https://api.github.com/users/yarpo/following{/other_user}","gists_url":"https://api.github.com/users/yarpo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpo/subscriptions","organizations_url":"https://api.github.com/users/yarpo/orgs","repos_url":"https://api.github.com/users/yarpo/repos","events_url":"https://api.github.com/users/yarpo/events{/privacy}","received_events_url":"https://api.github.com/users/yarpo/received_events","type":"User","site_admin":false},"body":"### JIRA link ###\r\nhttps://tools.hmcts.net/jira/browse/ROC-1530\r\n\r\n\r\n### Change description ###\r\nAdded new page to let claimant provide the answer if defendant has paid anything. If so - amount that was already paid.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n","created_at":"2017-08-23T16:35:00Z","updated_at":"2017-08-25T16:07:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce3f592da5062ee020ba0b17962686594f267955","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21/commits","review_comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21/comments","review_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/21/comments","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/065a804a251c6b8ea3b8c05b2eb62dbabc0d6109","head":{"label":"hmcts:feature/ROC-1530-ccj-amount","ref":"feature/ROC-1530-ccj-amount","sha":"065a804a251c6b8ea3b8c05b2eb62dbabc0d6109","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Frontend application for CMC","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-08-16T15:56:04Z","pushed_at":"2017-08-25T16:03:12Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"50e85d39bbe4366c537e05f0ebd7a3c50f027ef3","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":100393203,"name":"cmc-citizen-frontend","full_name":"hmcts/cmc-citizen-frontend","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/cmc-citizen-frontend","description":"Frontend application for CMC","fork":false,"url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend","forks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/forks","keys_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/teams","hooks_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/hooks","issue_events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/events","assignees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/tags","blobs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/languages","stargazers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/stargazers","contributors_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contributors","subscribers_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscribers","subscription_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/subscription","commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/merges","archive_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/downloads","issues_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/deployments","created_at":"2017-08-15T15:44:48Z","updated_at":"2017-08-16T15:56:04Z","pushed_at":"2017-08-25T16:03:12Z","git_url":"git://github.com/hmcts/cmc-citizen-frontend.git","ssh_url":"git@github.com:hmcts/cmc-citizen-frontend.git","clone_url":"https://github.com/hmcts/cmc-citizen-frontend.git","svn_url":"https://github.com/hmcts/cmc-citizen-frontend","homepage":"","size":552,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21"},"html":{"href":"https://github.com/hmcts/cmc-citizen-frontend/pull/21"},"issue":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/21"},"comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/cmc-citizen-frontend/statuses/065a804a251c6b8ea3b8c05b2eb62dbabc0d6109"}}}}
|
{
"id": 100393203,
"name": "hmcts/cmc-citizen-frontend",
"url": "https://api.github.com/repos/hmcts/cmc-citizen-frontend"
}
|
{
"id": 5647337,
"login": "yarpo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5647337?",
"url": "https://api.github.com/users/yarpo"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2017-08-25T16:07:07 |
6512909394
|
{"actor":{"display_login":"yarpo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/comments/158490057","pull_request_review_id":85311717,"id":158490057,"diff_hunk":"@@ -11,9 +10,9 @@\n \n @JsonCreator\n public InternalHealth(\n- @JsonProperty(\"status\") Status status","path":"src/main/java/uk/gov/hmcts/reform/ccd/client/healthcheck/InternalHealth.java","position":12,"original_position":12,"commit_id":"222499ba278f1e5e5c26a30e415d16173a29b18b","original_commit_id":"222499ba278f1e5e5c26a30e415d16173a29b18b","user":{"login":"rlewan","id":1095386,"avatar_url":"https://avatars0.githubusercontent.com/u/1095386?v=4","gravatar_id":"","url":"https://api.github.com/users/rlewan","html_url":"https://github.com/rlewan","followers_url":"https://api.github.com/users/rlewan/followers","following_url":"https://api.github.com/users/rlewan/following{/other_user}","gists_url":"https://api.github.com/users/rlewan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlewan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlewan/subscriptions","organizations_url":"https://api.github.com/users/rlewan/orgs","repos_url":"https://api.github.com/users/rlewan/repos","events_url":"https://api.github.com/users/rlewan/events{/privacy}","received_events_url":"https://api.github.com/users/rlewan/received_events","type":"User","site_admin":false},"body":"This didn't work, not sure why. Lost an hour on it and gave up.","created_at":"2017-12-22T13:16:19Z","updated_at":"2017-12-22T13:16:19Z","html_url":"https://github.com/hmcts/core-case-data-store-client/pull/16#discussion_r158490057","pull_request_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/comments/158490057"},"html":{"href":"https://github.com/hmcts/core-case-data-store-client/pull/16#discussion_r158490057"},"pull_request":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16","id":159865882,"html_url":"https://github.com/hmcts/core-case-data-store-client/pull/16","diff_url":"https://github.com/hmcts/core-case-data-store-client/pull/16.diff","patch_url":"https://github.com/hmcts/core-case-data-store-client/pull/16.patch","issue_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/16","number":16,"state":"open","locked":false,"title":"Use autoconfiguration to initialise components","user":{"login":"rlewan","id":1095386,"avatar_url":"https://avatars0.githubusercontent.com/u/1095386?v=4","gravatar_id":"","url":"https://api.github.com/users/rlewan","html_url":"https://github.com/rlewan","followers_url":"https://api.github.com/users/rlewan/followers","following_url":"https://api.github.com/users/rlewan/following{/other_user}","gists_url":"https://api.github.com/users/rlewan/gists{/gist_id}","starred_url":"https://api.github.com/users/rlewan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlewan/subscriptions","organizations_url":"https://api.github.com/users/rlewan/orgs","repos_url":"https://api.github.com/users/rlewan/repos","events_url":"https://api.github.com/users/rlewan/events{/privacy}","received_events_url":"https://api.github.com/users/rlewan/received_events","type":"User","site_admin":false},"body":"This change makes sure that no CCD related components are being initialised if the CCD url configuration property is not provided.","created_at":"2017-12-22T13:14:41Z","updated_at":"2017-12-22T13:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"427331bcd88aac3af20db6a80eab914329ac7414","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16/commits","review_comments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16/comments","review_comment_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/16/comments","statuses_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/statuses/222499ba278f1e5e5c26a30e415d16173a29b18b","head":{"label":"hmcts:feature/Use-autoconfiguration-to-initialise-components","ref":"feature/Use-autoconfiguration-to-initialise-components","sha":"222499ba278f1e5e5c26a30e415d16173a29b18b","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":113875271,"name":"core-case-data-store-client","full_name":"hmcts/core-case-data-store-client","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/core-case-data-store-client","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/core-case-data-store-client","forks_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/forks","keys_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/teams","hooks_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/hooks","issue_events_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/events","assignees_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/tags","blobs_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/languages","stargazers_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/stargazers","contributors_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/contributors","subscribers_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/subscribers","subscription_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/subscription","commits_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/merges","archive_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/downloads","issues_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/deployments","created_at":"2017-12-11T15:24:43Z","updated_at":"2017-12-12T15:37:46Z","pushed_at":"2017-12-22T13:14:42Z","git_url":"git://github.com/hmcts/core-case-data-store-client.git","ssh_url":"git@github.com:hmcts/core-case-data-store-client.git","clone_url":"https://github.com/hmcts/core-case-data-store-client.git","svn_url":"https://github.com/hmcts/core-case-data-store-client","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmcts:master","ref":"master","sha":"b10a21928065dbc6933df8406fef7c3c084a3346","user":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"repo":{"id":113875271,"name":"core-case-data-store-client","full_name":"hmcts/core-case-data-store-client","owner":{"login":"hmcts","id":22817111,"avatar_url":"https://avatars1.githubusercontent.com/u/22817111?v=4","gravatar_id":"","url":"https://api.github.com/users/hmcts","html_url":"https://github.com/hmcts","followers_url":"https://api.github.com/users/hmcts/followers","following_url":"https://api.github.com/users/hmcts/following{/other_user}","gists_url":"https://api.github.com/users/hmcts/gists{/gist_id}","starred_url":"https://api.github.com/users/hmcts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmcts/subscriptions","organizations_url":"https://api.github.com/users/hmcts/orgs","repos_url":"https://api.github.com/users/hmcts/repos","events_url":"https://api.github.com/users/hmcts/events{/privacy}","received_events_url":"https://api.github.com/users/hmcts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmcts/core-case-data-store-client","description":null,"fork":false,"url":"https://api.github.com/repos/hmcts/core-case-data-store-client","forks_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/forks","keys_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/teams","hooks_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/hooks","issue_events_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/events{/number}","events_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/events","assignees_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/assignees{/user}","branches_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/branches{/branch}","tags_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/tags","blobs_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/statuses/{sha}","languages_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/languages","stargazers_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/stargazers","contributors_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/contributors","subscribers_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/subscribers","subscription_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/subscription","commits_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/contents/{+path}","compare_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/merges","archive_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/downloads","issues_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues{/number}","pulls_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls{/number}","milestones_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/milestones{/number}","notifications_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/labels{/name}","releases_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/releases{/id}","deployments_url":"https://api.github.com/repos/hmcts/core-case-data-store-client/deployments","created_at":"2017-12-11T15:24:43Z","updated_at":"2017-12-12T15:37:46Z","pushed_at":"2017-12-22T13:14:42Z","git_url":"git://github.com/hmcts/core-case-data-store-client.git","ssh_url":"git@github.com:hmcts/core-case-data-store-client.git","clone_url":"https://github.com/hmcts/core-case-data-store-client.git","svn_url":"https://github.com/hmcts/core-case-data-store-client","homepage":null,"size":87,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16"},"html":{"href":"https://github.com/hmcts/core-case-data-store-client/pull/16"},"issue":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/16"},"comments":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/hmcts/core-case-data-store-client/statuses/222499ba278f1e5e5c26a30e415d16173a29b18b"}},"author_association":"NONE"}}
|
{
"id": 113875271,
"name": "hmcts/core-case-data-store-client",
"url": "https://api.github.com/repos/hmcts/core-case-data-store-client"
}
|
{
"id": 1095386,
"login": "rlewan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1095386?",
"url": "https://api.github.com/users/rlewan"
}
|
{
"id": 22817111,
"login": "hmcts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22817111?",
"url": "https://api.github.com/orgs/hmcts"
}
| 2017-12-22T13:16:19 |
7022960410
|
{"actor":{"display_login":"rlewan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/inaka/Emysql/pulls/comments/101023952","pull_request_review_id":21741071,"id":101023952,"diff_hunk":"@@ -305,6 +301,13 @@ reset_connection(Pools, Conn, StayLocked) ->\n add_monitor_ref(Conn, MonitorRef) ->\n Conn#emysql_connection{monitor_ref = MonitorRef}.\n \n+close_connections(Pool) ->\n+ AllConns = lists:append(\n+ queue:to_list(Pool#pool.available),\n+ gb_trees:values(Pool#pool.locked)\n+ ),\n+ lists:foreach(fun emysql_conn:close_connection/1, AllConns).\n+\n close_connection(Conn) ->\n \t%% garbage collect statements","path":"src/emysql_conn.erl","position":46,"original_position":46,"commit_id":"53ff3a4611f9bdb6275650314341fc8a4391733c","original_commit_id":"53ff3a4611f9bdb6275650314341fc8a4391733c","user":{"login":"elvisci","id":8136322,"avatar_url":"https://avatars.githubusercontent.com/u/8136322?v=3","gravatar_id":"","url":"https://api.github.com/users/elvisci","html_url":"https://github.com/elvisci","followers_url":"https://api.github.com/users/elvisci/followers","following_url":"https://api.github.com/users/elvisci/following{/other_user}","gists_url":"https://api.github.com/users/elvisci/gists{/gist_id}","starred_url":"https://api.github.com/users/elvisci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvisci/subscriptions","organizations_url":"https://api.github.com/users/elvisci/orgs","repos_url":"https://api.github.com/users/elvisci/repos","events_url":"https://api.github.com/users/elvisci/events{/privacy}","received_events_url":"https://api.github.com/users/elvisci/received_events","type":"User","site_admin":false},"body":"Line 312 has a tab at column 0.","created_at":"2017-02-14T12:29:44Z","updated_at":"2017-02-14T12:29:44Z","html_url":"https://github.com/inaka/Emysql/pull/15#discussion_r101023952","pull_request_url":"https://api.github.com/repos/inaka/Emysql/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/comments/101023952"},"html":{"href":"https://github.com/inaka/Emysql/pull/15#discussion_r101023952"},"pull_request":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/inaka/Emysql/pulls/15","id":106094757,"html_url":"https://github.com/inaka/Emysql/pull/15","diff_url":"https://github.com/inaka/Emysql/pull/15.diff","patch_url":"https://github.com/inaka/Emysql/pull/15.patch","issue_url":"https://api.github.com/repos/inaka/Emysql/issues/15","number":15,"state":"open","locked":false,"title":"Fix connection leak when add_pool is called in rapid succession","user":{"login":"huss01","id":3910152,"avatar_url":"https://avatars.githubusercontent.com/u/3910152?v=3","gravatar_id":"","url":"https://api.github.com/users/huss01","html_url":"https://github.com/huss01","followers_url":"https://api.github.com/users/huss01/followers","following_url":"https://api.github.com/users/huss01/following{/other_user}","gists_url":"https://api.github.com/users/huss01/gists{/gist_id}","starred_url":"https://api.github.com/users/huss01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huss01/subscriptions","organizations_url":"https://api.github.com/users/huss01/orgs","repos_url":"https://api.github.com/users/huss01/repos","events_url":"https://api.github.com/users/huss01/events{/privacy}","received_events_url":"https://api.github.com/users/huss01/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-14T12:29:38Z","updated_at":"2017-02-14T12:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d9dbaed1d955b4c92495954e542d7d5c13e57f5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/inaka/Emysql/pulls/15/commits","review_comments_url":"https://api.github.com/repos/inaka/Emysql/pulls/15/comments","review_comment_url":"https://api.github.com/repos/inaka/Emysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inaka/Emysql/issues/15/comments","statuses_url":"https://api.github.com/repos/inaka/Emysql/statuses/53ff3a4611f9bdb6275650314341fc8a4391733c","head":{"label":"campanja-forks:fix-connection-leak","ref":"fix-connection-leak","sha":"53ff3a4611f9bdb6275650314341fc8a4391733c","user":{"login":"campanja-forks","id":10634329,"avatar_url":"https://avatars.githubusercontent.com/u/10634329?v=3","gravatar_id":"","url":"https://api.github.com/users/campanja-forks","html_url":"https://github.com/campanja-forks","followers_url":"https://api.github.com/users/campanja-forks/followers","following_url":"https://api.github.com/users/campanja-forks/following{/other_user}","gists_url":"https://api.github.com/users/campanja-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/campanja-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campanja-forks/subscriptions","organizations_url":"https://api.github.com/users/campanja-forks/orgs","repos_url":"https://api.github.com/users/campanja-forks/repos","events_url":"https://api.github.com/users/campanja-forks/events{/privacy}","received_events_url":"https://api.github.com/users/campanja-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":72753453,"name":"Emysql","full_name":"campanja-forks/Emysql","owner":{"login":"campanja-forks","id":10634329,"avatar_url":"https://avatars.githubusercontent.com/u/10634329?v=3","gravatar_id":"","url":"https://api.github.com/users/campanja-forks","html_url":"https://github.com/campanja-forks","followers_url":"https://api.github.com/users/campanja-forks/followers","following_url":"https://api.github.com/users/campanja-forks/following{/other_user}","gists_url":"https://api.github.com/users/campanja-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/campanja-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campanja-forks/subscriptions","organizations_url":"https://api.github.com/users/campanja-forks/orgs","repos_url":"https://api.github.com/users/campanja-forks/repos","events_url":"https://api.github.com/users/campanja-forks/events{/privacy}","received_events_url":"https://api.github.com/users/campanja-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/campanja-forks/Emysql","description":"Erlang MySQL driver","fork":true,"url":"https://api.github.com/repos/campanja-forks/Emysql","forks_url":"https://api.github.com/repos/campanja-forks/Emysql/forks","keys_url":"https://api.github.com/repos/campanja-forks/Emysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campanja-forks/Emysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campanja-forks/Emysql/teams","hooks_url":"https://api.github.com/repos/campanja-forks/Emysql/hooks","issue_events_url":"https://api.github.com/repos/campanja-forks/Emysql/issues/events{/number}","events_url":"https://api.github.com/repos/campanja-forks/Emysql/events","assignees_url":"https://api.github.com/repos/campanja-forks/Emysql/assignees{/user}","branches_url":"https://api.github.com/repos/campanja-forks/Emysql/branches{/branch}","tags_url":"https://api.github.com/repos/campanja-forks/Emysql/tags","blobs_url":"https://api.github.com/repos/campanja-forks/Emysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campanja-forks/Emysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campanja-forks/Emysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/campanja-forks/Emysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campanja-forks/Emysql/statuses/{sha}","languages_url":"https://api.github.com/repos/campanja-forks/Emysql/languages","stargazers_url":"https://api.github.com/repos/campanja-forks/Emysql/stargazers","contributors_url":"https://api.github.com/repos/campanja-forks/Emysql/contributors","subscribers_url":"https://api.github.com/repos/campanja-forks/Emysql/subscribers","subscription_url":"https://api.github.com/repos/campanja-forks/Emysql/subscription","commits_url":"https://api.github.com/repos/campanja-forks/Emysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/campanja-forks/Emysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/campanja-forks/Emysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/campanja-forks/Emysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/campanja-forks/Emysql/contents/{+path}","compare_url":"https://api.github.com/repos/campanja-forks/Emysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campanja-forks/Emysql/merges","archive_url":"https://api.github.com/repos/campanja-forks/Emysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campanja-forks/Emysql/downloads","issues_url":"https://api.github.com/repos/campanja-forks/Emysql/issues{/number}","pulls_url":"https://api.github.com/repos/campanja-forks/Emysql/pulls{/number}","milestones_url":"https://api.github.com/repos/campanja-forks/Emysql/milestones{/number}","notifications_url":"https://api.github.com/repos/campanja-forks/Emysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campanja-forks/Emysql/labels{/name}","releases_url":"https://api.github.com/repos/campanja-forks/Emysql/releases{/id}","deployments_url":"https://api.github.com/repos/campanja-forks/Emysql/deployments","created_at":"2016-11-03T14:26:47Z","updated_at":"2016-11-03T14:26:49Z","pushed_at":"2017-02-14T12:27:46Z","git_url":"git://github.com/campanja-forks/Emysql.git","ssh_url":"git@github.com:campanja-forks/Emysql.git","clone_url":"https://github.com/campanja-forks/Emysql.git","svn_url":"https://github.com/campanja-forks/Emysql","homepage":"http://eonblast.github.com/Emysql","size":1086,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inaka:master","ref":"master","sha":"eb48a2cf02b8d6fc2e0508f075c6515a805b305f","user":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"repo":{"id":4602065,"name":"Emysql","full_name":"inaka/Emysql","owner":{"login":"inaka","id":867053,"avatar_url":"https://avatars.githubusercontent.com/u/867053?v=3","gravatar_id":"","url":"https://api.github.com/users/inaka","html_url":"https://github.com/inaka","followers_url":"https://api.github.com/users/inaka/followers","following_url":"https://api.github.com/users/inaka/following{/other_user}","gists_url":"https://api.github.com/users/inaka/gists{/gist_id}","starred_url":"https://api.github.com/users/inaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inaka/subscriptions","organizations_url":"https://api.github.com/users/inaka/orgs","repos_url":"https://api.github.com/users/inaka/repos","events_url":"https://api.github.com/users/inaka/events{/privacy}","received_events_url":"https://api.github.com/users/inaka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inaka/Emysql","description":"Erlang MySQL driver","fork":true,"url":"https://api.github.com/repos/inaka/Emysql","forks_url":"https://api.github.com/repos/inaka/Emysql/forks","keys_url":"https://api.github.com/repos/inaka/Emysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inaka/Emysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inaka/Emysql/teams","hooks_url":"https://api.github.com/repos/inaka/Emysql/hooks","issue_events_url":"https://api.github.com/repos/inaka/Emysql/issues/events{/number}","events_url":"https://api.github.com/repos/inaka/Emysql/events","assignees_url":"https://api.github.com/repos/inaka/Emysql/assignees{/user}","branches_url":"https://api.github.com/repos/inaka/Emysql/branches{/branch}","tags_url":"https://api.github.com/repos/inaka/Emysql/tags","blobs_url":"https://api.github.com/repos/inaka/Emysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inaka/Emysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inaka/Emysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/inaka/Emysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inaka/Emysql/statuses/{sha}","languages_url":"https://api.github.com/repos/inaka/Emysql/languages","stargazers_url":"https://api.github.com/repos/inaka/Emysql/stargazers","contributors_url":"https://api.github.com/repos/inaka/Emysql/contributors","subscribers_url":"https://api.github.com/repos/inaka/Emysql/subscribers","subscription_url":"https://api.github.com/repos/inaka/Emysql/subscription","commits_url":"https://api.github.com/repos/inaka/Emysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/inaka/Emysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/inaka/Emysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/inaka/Emysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/inaka/Emysql/contents/{+path}","compare_url":"https://api.github.com/repos/inaka/Emysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inaka/Emysql/merges","archive_url":"https://api.github.com/repos/inaka/Emysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inaka/Emysql/downloads","issues_url":"https://api.github.com/repos/inaka/Emysql/issues{/number}","pulls_url":"https://api.github.com/repos/inaka/Emysql/pulls{/number}","milestones_url":"https://api.github.com/repos/inaka/Emysql/milestones{/number}","notifications_url":"https://api.github.com/repos/inaka/Emysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inaka/Emysql/labels{/name}","releases_url":"https://api.github.com/repos/inaka/Emysql/releases{/id}","deployments_url":"https://api.github.com/repos/inaka/Emysql/deployments","created_at":"2012-06-08T20:43:19Z","updated_at":"2016-12-03T18:25:32Z","pushed_at":"2017-02-14T12:29:39Z","git_url":"git://github.com/inaka/Emysql.git","ssh_url":"git@github.com:inaka/Emysql.git","clone_url":"https://github.com/inaka/Emysql.git","svn_url":"https://github.com/inaka/Emysql","homepage":"http://eonblast.github.com/Emysql","size":1086,"stargazers_count":1,"watchers_count":1,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/15"},"html":{"href":"https://github.com/inaka/Emysql/pull/15"},"issue":{"href":"https://api.github.com/repos/inaka/Emysql/issues/15"},"comments":{"href":"https://api.github.com/repos/inaka/Emysql/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inaka/Emysql/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/inaka/Emysql/statuses/53ff3a4611f9bdb6275650314341fc8a4391733c"}}}}
|
{
"id": 4602065,
"name": "inaka/Emysql",
"url": "https://api.github.com/repos/inaka/Emysql"
}
|
{
"id": 8136322,
"login": "elvisci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8136322?",
"url": "https://api.github.com/users/elvisci"
}
|
{
"id": 867053,
"login": "inaka",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/867053?",
"url": "https://api.github.com/orgs/inaka"
}
| 2017-02-14T12:29:44 |
5321082091
|
{"actor":{"display_login":"elvisci"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/152431835","pull_request_review_id":78226547,"id":152431835,"diff_hunk":"@@ -230,8 +236,9 @@ func (c *lruCache) SetWithExpiration(key interface{}, value interface{}, expirat\n \tent.value = value\n \tent.expiration = exp\n \n-\tc.stats.Writes++\n \tc.Unlock()\n+\n+\tatomic.AddUint64(&c.stats.Writes, 1)","path":"mixer/pkg/cache/lruCache.go","position":111,"original_position":111,"commit_id":"e92f7746481d4c0608374f0a97fb1ea98b6a0fb4","original_commit_id":"e92f7746481d4c0608374f0a97fb1ea98b6a0fb4","user":{"login":"guptasu","id":11448595,"avatar_url":"https://avatars3.githubusercontent.com/u/11448595?v=4","gravatar_id":"","url":"https://api.github.com/users/guptasu","html_url":"https://github.com/guptasu","followers_url":"https://api.github.com/users/guptasu/followers","following_url":"https://api.github.com/users/guptasu/following{/other_user}","gists_url":"https://api.github.com/users/guptasu/gists{/gist_id}","starred_url":"https://api.github.com/users/guptasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptasu/subscriptions","organizations_url":"https://api.github.com/users/guptasu/orgs","repos_url":"https://api.github.com/users/guptasu/repos","events_url":"https://api.github.com/users/guptasu/events{/privacy}","received_events_url":"https://api.github.com/users/guptasu/received_events","type":"User","site_admin":false},"body":"There are other places in the code where we are doing `c.stats.Writes++`. We should change them too.","created_at":"2017-11-21T23:32:18Z","updated_at":"2017-11-21T23:36:25Z","html_url":"https://github.com/istio/istio/pull/1785#discussion_r152431835","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/1785","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/152431835"},"html":{"href":"https://github.com/istio/istio/pull/1785#discussion_r152431835"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/1785"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/1785","id":153509969,"html_url":"https://github.com/istio/istio/pull/1785","diff_url":"https://github.com/istio/istio/pull/1785.diff","patch_url":"https://github.com/istio/istio/pull/1785.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/1785","number":1785,"state":"open","locked":false,"title":"Add the Cache.RemoveAll and ExpiringCache.EvictExpired methods","user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!-- Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2017-11-19T18:56:29Z","updated_at":"2017-11-21T23:36:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78f456bb3a31f40172f8bf69fc044002e2be63df","assignee":null,"assignees":[],"requested_reviewers":[{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/1785/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/1785/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/1785/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/e92f7746481d4c0608374f0a97fb1ea98b6a0fb4","head":{"label":"geeknoid:cache","ref":"cache","sha":"e92f7746481d4c0608374f0a97fb1ea98b6a0fb4","user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"repo":{"id":109762069,"name":"istio","full_name":"geeknoid/istio","owner":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/geeknoid/istio","description":"Istio service mesh for polyglot microservice applications","fork":true,"url":"https://api.github.com/repos/geeknoid/istio","forks_url":"https://api.github.com/repos/geeknoid/istio/forks","keys_url":"https://api.github.com/repos/geeknoid/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geeknoid/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geeknoid/istio/teams","hooks_url":"https://api.github.com/repos/geeknoid/istio/hooks","issue_events_url":"https://api.github.com/repos/geeknoid/istio/issues/events{/number}","events_url":"https://api.github.com/repos/geeknoid/istio/events","assignees_url":"https://api.github.com/repos/geeknoid/istio/assignees{/user}","branches_url":"https://api.github.com/repos/geeknoid/istio/branches{/branch}","tags_url":"https://api.github.com/repos/geeknoid/istio/tags","blobs_url":"https://api.github.com/repos/geeknoid/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geeknoid/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geeknoid/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/geeknoid/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geeknoid/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/geeknoid/istio/languages","stargazers_url":"https://api.github.com/repos/geeknoid/istio/stargazers","contributors_url":"https://api.github.com/repos/geeknoid/istio/contributors","subscribers_url":"https://api.github.com/repos/geeknoid/istio/subscribers","subscription_url":"https://api.github.com/repos/geeknoid/istio/subscription","commits_url":"https://api.github.com/repos/geeknoid/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/geeknoid/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/geeknoid/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/geeknoid/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/geeknoid/istio/contents/{+path}","compare_url":"https://api.github.com/repos/geeknoid/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geeknoid/istio/merges","archive_url":"https://api.github.com/repos/geeknoid/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geeknoid/istio/downloads","issues_url":"https://api.github.com/repos/geeknoid/istio/issues{/number}","pulls_url":"https://api.github.com/repos/geeknoid/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/geeknoid/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/geeknoid/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geeknoid/istio/labels{/name}","releases_url":"https://api.github.com/repos/geeknoid/istio/releases{/id}","deployments_url":"https://api.github.com/repos/geeknoid/istio/deployments","created_at":"2017-11-06T23:27:23Z","updated_at":"2017-11-06T23:27:27Z","pushed_at":"2017-11-21T19:22:31Z","git_url":"git://github.com/geeknoid/istio.git","ssh_url":"git@github.com:geeknoid/istio.git","clone_url":"https://github.com/geeknoid/istio.git","svn_url":"https://github.com/geeknoid/istio","homepage":"https://istio.io","size":10162,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"7a5923ba1d4a775ff167ec599b02c070257ebb6b","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2017-11-21T18:28:43Z","pushed_at":"2017-11-21T23:32:33Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":10291,"stargazers_count":3956,"watchers_count":3956,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":453,"mirror_url":null,"archived":false,"open_issues_count":360,"forks":453,"open_issues":360,"watchers":3956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/1785"},"html":{"href":"https://github.com/istio/istio/pull/1785"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/1785"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/1785/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/1785/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/1785/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/e92f7746481d4c0608374f0a97fb1ea98b6a0fb4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 74175805,
"name": "istio/istio",
"url": "https://api.github.com/repos/istio/istio"
}
|
{
"id": 11448595,
"login": "guptasu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11448595?",
"url": "https://api.github.com/users/guptasu"
}
|
{
"id": 23534644,
"login": "istio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23534644?",
"url": "https://api.github.com/orgs/istio"
}
| 2017-11-21T23:32:18 |
6887464910
|
{"actor":{"display_login":"guptasu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/koajs/koa/pulls/comments/103397696","pull_request_review_id":24180761,"id":103397696,"diff_hunk":"@@ -88,6 +88,30 @@ describe('ctx.onerror(err)', function(){\n })\n })\n \n+ it('should ignore error after headerSent', function(){\n+ var app = koa();\n+\n+ app.on('error', function(err){\n+ console.log(err);","path":"test/context/onerror.js","position":null,"original_position":8,"commit_id":"ce68b8f908fa02ad4ec62bdf0decae10c6fb7ba4","original_commit_id":"3be61e36d1f13c180115bef7889009926fa29eed","user":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-02-28T08:17:54Z","updated_at":"2017-02-28T08:17:54Z","html_url":"https://github.com/koajs/koa/pull/923#discussion_r103397696","pull_request_url":"https://api.github.com/repos/koajs/koa/pulls/923","_links":{"self":{"href":"https://api.github.com/repos/koajs/koa/pulls/comments/103397696"},"html":{"href":"https://github.com/koajs/koa/pull/923#discussion_r103397696"},"pull_request":{"href":"https://api.github.com/repos/koajs/koa/pulls/923"}}},"pull_request":{"url":"https://api.github.com/repos/koajs/koa/pulls/923","id":108274850,"html_url":"https://github.com/koajs/koa/pull/923","diff_url":"https://github.com/koajs/koa/pull/923.diff","patch_url":"https://github.com/koajs/koa/pull/923.patch","issue_url":"https://api.github.com/repos/koajs/koa/issues/923","number":923,"state":"open","locked":false,"title":"feat: set err.headerSent before app error event emit #919","user":{"login":"fengmk2","id":156269,"avatar_url":"https://avatars.githubusercontent.com/u/156269?v=3","gravatar_id":"","url":"https://api.github.com/users/fengmk2","html_url":"https://github.com/fengmk2","followers_url":"https://api.github.com/users/fengmk2/followers","following_url":"https://api.github.com/users/fengmk2/following{/other_user}","gists_url":"https://api.github.com/users/fengmk2/gists{/gist_id}","starred_url":"https://api.github.com/users/fengmk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fengmk2/subscriptions","organizations_url":"https://api.github.com/users/fengmk2/orgs","repos_url":"https://api.github.com/users/fengmk2/repos","events_url":"https://api.github.com/users/fengmk2/events{/privacy}","received_events_url":"https://api.github.com/users/fengmk2/received_events","type":"User","site_admin":false},"body":"cherry-pick from https://github.com/koajs/koa/pull/919","created_at":"2017-02-28T07:44:10Z","updated_at":"2017-02-28T08:17:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e665db53ce71a25d9e8d5ffa6d53d9dc956c194","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/koajs/koa/pulls/923/commits","review_comments_url":"https://api.github.com/repos/koajs/koa/pulls/923/comments","review_comment_url":"https://api.github.com/repos/koajs/koa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koajs/koa/issues/923/comments","statuses_url":"https://api.github.com/repos/koajs/koa/statuses/ce68b8f908fa02ad4ec62bdf0decae10c6fb7ba4","head":{"label":"koajs:error-headerSent-v1","ref":"error-headerSent-v1","sha":"ce68b8f908fa02ad4ec62bdf0decae10c6fb7ba4","user":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"repo":{"id":11551538,"name":"koa","full_name":"koajs/koa","owner":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koajs/koa","description":"Expressive middleware for node.js using ES2017 async functions","fork":false,"url":"https://api.github.com/repos/koajs/koa","forks_url":"https://api.github.com/repos/koajs/koa/forks","keys_url":"https://api.github.com/repos/koajs/koa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koajs/koa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koajs/koa/teams","hooks_url":"https://api.github.com/repos/koajs/koa/hooks","issue_events_url":"https://api.github.com/repos/koajs/koa/issues/events{/number}","events_url":"https://api.github.com/repos/koajs/koa/events","assignees_url":"https://api.github.com/repos/koajs/koa/assignees{/user}","branches_url":"https://api.github.com/repos/koajs/koa/branches{/branch}","tags_url":"https://api.github.com/repos/koajs/koa/tags","blobs_url":"https://api.github.com/repos/koajs/koa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koajs/koa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koajs/koa/git/refs{/sha}","trees_url":"https://api.github.com/repos/koajs/koa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koajs/koa/statuses/{sha}","languages_url":"https://api.github.com/repos/koajs/koa/languages","stargazers_url":"https://api.github.com/repos/koajs/koa/stargazers","contributors_url":"https://api.github.com/repos/koajs/koa/contributors","subscribers_url":"https://api.github.com/repos/koajs/koa/subscribers","subscription_url":"https://api.github.com/repos/koajs/koa/subscription","commits_url":"https://api.github.com/repos/koajs/koa/commits{/sha}","git_commits_url":"https://api.github.com/repos/koajs/koa/git/commits{/sha}","comments_url":"https://api.github.com/repos/koajs/koa/comments{/number}","issue_comment_url":"https://api.github.com/repos/koajs/koa/issues/comments{/number}","contents_url":"https://api.github.com/repos/koajs/koa/contents/{+path}","compare_url":"https://api.github.com/repos/koajs/koa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koajs/koa/merges","archive_url":"https://api.github.com/repos/koajs/koa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koajs/koa/downloads","issues_url":"https://api.github.com/repos/koajs/koa/issues{/number}","pulls_url":"https://api.github.com/repos/koajs/koa/pulls{/number}","milestones_url":"https://api.github.com/repos/koajs/koa/milestones{/number}","notifications_url":"https://api.github.com/repos/koajs/koa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koajs/koa/labels{/name}","releases_url":"https://api.github.com/repos/koajs/koa/releases{/id}","deployments_url":"https://api.github.com/repos/koajs/koa/deployments","created_at":"2013-07-20T18:53:45Z","updated_at":"2017-02-28T07:40:51Z","pushed_at":"2017-02-28T08:16:51Z","git_url":"git://github.com/koajs/koa.git","ssh_url":"git@github.com:koajs/koa.git","clone_url":"https://github.com/koajs/koa.git","svn_url":"https://github.com/koajs/koa","homepage":"http://koajs.com","size":1720,"stargazers_count":14095,"watchers_count":14095,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1235,"mirror_url":null,"open_issues_count":29,"forks":1235,"open_issues":29,"watchers":14095,"default_branch":"master"}},"base":{"label":"koajs:v1.x","ref":"v1.x","sha":"188feafdf089244dfaf4a22812c6394e01940b09","user":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"repo":{"id":11551538,"name":"koa","full_name":"koajs/koa","owner":{"login":"koajs","id":5055057,"avatar_url":"https://avatars.githubusercontent.com/u/5055057?v=3","gravatar_id":"","url":"https://api.github.com/users/koajs","html_url":"https://github.com/koajs","followers_url":"https://api.github.com/users/koajs/followers","following_url":"https://api.github.com/users/koajs/following{/other_user}","gists_url":"https://api.github.com/users/koajs/gists{/gist_id}","starred_url":"https://api.github.com/users/koajs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koajs/subscriptions","organizations_url":"https://api.github.com/users/koajs/orgs","repos_url":"https://api.github.com/users/koajs/repos","events_url":"https://api.github.com/users/koajs/events{/privacy}","received_events_url":"https://api.github.com/users/koajs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koajs/koa","description":"Expressive middleware for node.js using ES2017 async functions","fork":false,"url":"https://api.github.com/repos/koajs/koa","forks_url":"https://api.github.com/repos/koajs/koa/forks","keys_url":"https://api.github.com/repos/koajs/koa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koajs/koa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koajs/koa/teams","hooks_url":"https://api.github.com/repos/koajs/koa/hooks","issue_events_url":"https://api.github.com/repos/koajs/koa/issues/events{/number}","events_url":"https://api.github.com/repos/koajs/koa/events","assignees_url":"https://api.github.com/repos/koajs/koa/assignees{/user}","branches_url":"https://api.github.com/repos/koajs/koa/branches{/branch}","tags_url":"https://api.github.com/repos/koajs/koa/tags","blobs_url":"https://api.github.com/repos/koajs/koa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koajs/koa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koajs/koa/git/refs{/sha}","trees_url":"https://api.github.com/repos/koajs/koa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koajs/koa/statuses/{sha}","languages_url":"https://api.github.com/repos/koajs/koa/languages","stargazers_url":"https://api.github.com/repos/koajs/koa/stargazers","contributors_url":"https://api.github.com/repos/koajs/koa/contributors","subscribers_url":"https://api.github.com/repos/koajs/koa/subscribers","subscription_url":"https://api.github.com/repos/koajs/koa/subscription","commits_url":"https://api.github.com/repos/koajs/koa/commits{/sha}","git_commits_url":"https://api.github.com/repos/koajs/koa/git/commits{/sha}","comments_url":"https://api.github.com/repos/koajs/koa/comments{/number}","issue_comment_url":"https://api.github.com/repos/koajs/koa/issues/comments{/number}","contents_url":"https://api.github.com/repos/koajs/koa/contents/{+path}","compare_url":"https://api.github.com/repos/koajs/koa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koajs/koa/merges","archive_url":"https://api.github.com/repos/koajs/koa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koajs/koa/downloads","issues_url":"https://api.github.com/repos/koajs/koa/issues{/number}","pulls_url":"https://api.github.com/repos/koajs/koa/pulls{/number}","milestones_url":"https://api.github.com/repos/koajs/koa/milestones{/number}","notifications_url":"https://api.github.com/repos/koajs/koa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koajs/koa/labels{/name}","releases_url":"https://api.github.com/repos/koajs/koa/releases{/id}","deployments_url":"https://api.github.com/repos/koajs/koa/deployments","created_at":"2013-07-20T18:53:45Z","updated_at":"2017-02-28T07:40:51Z","pushed_at":"2017-02-28T08:16:51Z","git_url":"git://github.com/koajs/koa.git","ssh_url":"git@github.com:koajs/koa.git","clone_url":"https://github.com/koajs/koa.git","svn_url":"https://github.com/koajs/koa","homepage":"http://koajs.com","size":1720,"stargazers_count":14095,"watchers_count":14095,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1235,"mirror_url":null,"open_issues_count":29,"forks":1235,"open_issues":29,"watchers":14095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koajs/koa/pulls/923"},"html":{"href":"https://github.com/koajs/koa/pull/923"},"issue":{"href":"https://api.github.com/repos/koajs/koa/issues/923"},"comments":{"href":"https://api.github.com/repos/koajs/koa/issues/923/comments"},"review_comments":{"href":"https://api.github.com/repos/koajs/koa/pulls/923/comments"},"review_comment":{"href":"https://api.github.com/repos/koajs/koa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koajs/koa/pulls/923/commits"},"statuses":{"href":"https://api.github.com/repos/koajs/koa/statuses/ce68b8f908fa02ad4ec62bdf0decae10c6fb7ba4"}}}}
|
{
"id": 11551538,
"name": "koajs/koa",
"url": "https://api.github.com/repos/koajs/koa"
}
|
{
"id": 156269,
"login": "fengmk2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/156269?",
"url": "https://api.github.com/users/fengmk2"
}
|
{
"id": 5055057,
"login": "koajs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5055057?",
"url": "https://api.github.com/orgs/koajs"
}
| 2017-02-28T08:17:54 |
5402973324
|
{"actor":{"display_login":"fengmk2"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kytos/python-openflow/pulls/comments/119942384","pull_request_review_id":41872543,"id":119942384,"diff_hunk":"@@ -204,7 +203,12 @@ def pack(self, value=None):\n raise PackException(msg)\n \n def unpack(self, buff, offset=0):\n- \"\"\"Unpack binary data into python object.\"\"\"\n+ \"\"\"Unpack binary data into python object.\n+\n+ Parameters:","path":"pyof/v0x01/asynchronous/error_msg.py","position":39,"original_position":39,"commit_id":"84e537aade588de1d9e00cc1622f2fc72a00c49c","original_commit_id":"84e537aade588de1d9e00cc1622f2fc72a00c49c","user":{"login":"macartur","id":2965806,"avatar_url":"https://avatars2.githubusercontent.com/u/2965806?v=3","gravatar_id":"","url":"https://api.github.com/users/macartur","html_url":"https://github.com/macartur","followers_url":"https://api.github.com/users/macartur/followers","following_url":"https://api.github.com/users/macartur/following{/other_user}","gists_url":"https://api.github.com/users/macartur/gists{/gist_id}","starred_url":"https://api.github.com/users/macartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macartur/subscriptions","organizations_url":"https://api.github.com/users/macartur/orgs","repos_url":"https://api.github.com/users/macartur/repos","events_url":"https://api.github.com/users/macartur/events{/privacy}","received_events_url":"https://api.github.com/users/macartur/received_events","type":"User","site_admin":false},"body":"OK, I will change this.","created_at":"2017-06-02T20:09:49Z","updated_at":"2017-06-02T20:09:50Z","html_url":"https://github.com/kytos/python-openflow/pull/370#discussion_r119942384","pull_request_url":"https://api.github.com/repos/kytos/python-openflow/pulls/370","_links":{"self":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/comments/119942384"},"html":{"href":"https://github.com/kytos/python-openflow/pull/370#discussion_r119942384"},"pull_request":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/kytos/python-openflow/pulls/370","id":122932453,"html_url":"https://github.com/kytos/python-openflow/pull/370","diff_url":"https://github.com/kytos/python-openflow/pull/370.diff","patch_url":"https://github.com/kytos/python-openflow/pull/370.patch","issue_url":"https://api.github.com/repos/kytos/python-openflow/issues/370","number":370,"state":"open","locked":false,"title":"Issue #211","user":{"login":"macartur","id":2965806,"avatar_url":"https://avatars2.githubusercontent.com/u/2965806?v=3","gravatar_id":"","url":"https://api.github.com/users/macartur","html_url":"https://github.com/macartur","followers_url":"https://api.github.com/users/macartur/followers","following_url":"https://api.github.com/users/macartur/following{/other_user}","gists_url":"https://api.github.com/users/macartur/gists{/gist_id}","starred_url":"https://api.github.com/users/macartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macartur/subscriptions","organizations_url":"https://api.github.com/users/macartur/orgs","repos_url":"https://api.github.com/users/macartur/repos","events_url":"https://api.github.com/users/macartur/events{/privacy}","received_events_url":"https://api.github.com/users/macartur/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-29T18:34:35Z","updated_at":"2017-06-02T20:09:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dc8e284597ea95e15b9512118ca829ec75072a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kytos/python-openflow/pulls/370/commits","review_comments_url":"https://api.github.com/repos/kytos/python-openflow/pulls/370/comments","review_comment_url":"https://api.github.com/repos/kytos/python-openflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kytos/python-openflow/issues/370/comments","statuses_url":"https://api.github.com/repos/kytos/python-openflow/statuses/84e537aade588de1d9e00cc1622f2fc72a00c49c","head":{"label":"macartur:issue-#211","ref":"issue-#211","sha":"84e537aade588de1d9e00cc1622f2fc72a00c49c","user":{"login":"macartur","id":2965806,"avatar_url":"https://avatars2.githubusercontent.com/u/2965806?v=3","gravatar_id":"","url":"https://api.github.com/users/macartur","html_url":"https://github.com/macartur","followers_url":"https://api.github.com/users/macartur/followers","following_url":"https://api.github.com/users/macartur/following{/other_user}","gists_url":"https://api.github.com/users/macartur/gists{/gist_id}","starred_url":"https://api.github.com/users/macartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macartur/subscriptions","organizations_url":"https://api.github.com/users/macartur/orgs","repos_url":"https://api.github.com/users/macartur/repos","events_url":"https://api.github.com/users/macartur/events{/privacy}","received_events_url":"https://api.github.com/users/macartur/received_events","type":"User","site_admin":false},"repo":{"id":84203499,"name":"python-openflow","full_name":"macartur/python-openflow","owner":{"login":"macartur","id":2965806,"avatar_url":"https://avatars2.githubusercontent.com/u/2965806?v=3","gravatar_id":"","url":"https://api.github.com/users/macartur","html_url":"https://github.com/macartur","followers_url":"https://api.github.com/users/macartur/followers","following_url":"https://api.github.com/users/macartur/following{/other_user}","gists_url":"https://api.github.com/users/macartur/gists{/gist_id}","starred_url":"https://api.github.com/users/macartur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macartur/subscriptions","organizations_url":"https://api.github.com/users/macartur/orgs","repos_url":"https://api.github.com/users/macartur/repos","events_url":"https://api.github.com/users/macartur/events{/privacy}","received_events_url":"https://api.github.com/users/macartur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/macartur/python-openflow","description":"Low level OpenFlow Messages Parser","fork":true,"url":"https://api.github.com/repos/macartur/python-openflow","forks_url":"https://api.github.com/repos/macartur/python-openflow/forks","keys_url":"https://api.github.com/repos/macartur/python-openflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macartur/python-openflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macartur/python-openflow/teams","hooks_url":"https://api.github.com/repos/macartur/python-openflow/hooks","issue_events_url":"https://api.github.com/repos/macartur/python-openflow/issues/events{/number}","events_url":"https://api.github.com/repos/macartur/python-openflow/events","assignees_url":"https://api.github.com/repos/macartur/python-openflow/assignees{/user}","branches_url":"https://api.github.com/repos/macartur/python-openflow/branches{/branch}","tags_url":"https://api.github.com/repos/macartur/python-openflow/tags","blobs_url":"https://api.github.com/repos/macartur/python-openflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macartur/python-openflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macartur/python-openflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/macartur/python-openflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macartur/python-openflow/statuses/{sha}","languages_url":"https://api.github.com/repos/macartur/python-openflow/languages","stargazers_url":"https://api.github.com/repos/macartur/python-openflow/stargazers","contributors_url":"https://api.github.com/repos/macartur/python-openflow/contributors","subscribers_url":"https://api.github.com/repos/macartur/python-openflow/subscribers","subscription_url":"https://api.github.com/repos/macartur/python-openflow/subscription","commits_url":"https://api.github.com/repos/macartur/python-openflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/macartur/python-openflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/macartur/python-openflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/macartur/python-openflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/macartur/python-openflow/contents/{+path}","compare_url":"https://api.github.com/repos/macartur/python-openflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macartur/python-openflow/merges","archive_url":"https://api.github.com/repos/macartur/python-openflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macartur/python-openflow/downloads","issues_url":"https://api.github.com/repos/macartur/python-openflow/issues{/number}","pulls_url":"https://api.github.com/repos/macartur/python-openflow/pulls{/number}","milestones_url":"https://api.github.com/repos/macartur/python-openflow/milestones{/number}","notifications_url":"https://api.github.com/repos/macartur/python-openflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macartur/python-openflow/labels{/name}","releases_url":"https://api.github.com/repos/macartur/python-openflow/releases{/id}","deployments_url":"https://api.github.com/repos/macartur/python-openflow/deployments","created_at":"2017-03-07T13:41:13Z","updated_at":"2017-03-07T13:41:15Z","pushed_at":"2017-05-31T14:10:23Z","git_url":"git://github.com/macartur/python-openflow.git","ssh_url":"git@github.com:macartur/python-openflow.git","clone_url":"https://github.com/macartur/python-openflow.git","svn_url":"https://github.com/macartur/python-openflow","homepage":null,"size":2908,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kytos:master","ref":"master","sha":"43feaed681c32bffc9e5428940a8f1a75236090c","user":{"login":"kytos","id":16357103,"avatar_url":"https://avatars2.githubusercontent.com/u/16357103?v=3","gravatar_id":"","url":"https://api.github.com/users/kytos","html_url":"https://github.com/kytos","followers_url":"https://api.github.com/users/kytos/followers","following_url":"https://api.github.com/users/kytos/following{/other_user}","gists_url":"https://api.github.com/users/kytos/gists{/gist_id}","starred_url":"https://api.github.com/users/kytos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kytos/subscriptions","organizations_url":"https://api.github.com/users/kytos/orgs","repos_url":"https://api.github.com/users/kytos/repos","events_url":"https://api.github.com/users/kytos/events{/privacy}","received_events_url":"https://api.github.com/users/kytos/received_events","type":"Organization","site_admin":false},"repo":{"id":54393307,"name":"python-openflow","full_name":"kytos/python-openflow","owner":{"login":"kytos","id":16357103,"avatar_url":"https://avatars2.githubusercontent.com/u/16357103?v=3","gravatar_id":"","url":"https://api.github.com/users/kytos","html_url":"https://github.com/kytos","followers_url":"https://api.github.com/users/kytos/followers","following_url":"https://api.github.com/users/kytos/following{/other_user}","gists_url":"https://api.github.com/users/kytos/gists{/gist_id}","starred_url":"https://api.github.com/users/kytos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kytos/subscriptions","organizations_url":"https://api.github.com/users/kytos/orgs","repos_url":"https://api.github.com/users/kytos/repos","events_url":"https://api.github.com/users/kytos/events{/privacy}","received_events_url":"https://api.github.com/users/kytos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kytos/python-openflow","description":"Low level OpenFlow messages parser used by Kytos SDN Platform","fork":false,"url":"https://api.github.com/repos/kytos/python-openflow","forks_url":"https://api.github.com/repos/kytos/python-openflow/forks","keys_url":"https://api.github.com/repos/kytos/python-openflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kytos/python-openflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kytos/python-openflow/teams","hooks_url":"https://api.github.com/repos/kytos/python-openflow/hooks","issue_events_url":"https://api.github.com/repos/kytos/python-openflow/issues/events{/number}","events_url":"https://api.github.com/repos/kytos/python-openflow/events","assignees_url":"https://api.github.com/repos/kytos/python-openflow/assignees{/user}","branches_url":"https://api.github.com/repos/kytos/python-openflow/branches{/branch}","tags_url":"https://api.github.com/repos/kytos/python-openflow/tags","blobs_url":"https://api.github.com/repos/kytos/python-openflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kytos/python-openflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kytos/python-openflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kytos/python-openflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kytos/python-openflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kytos/python-openflow/languages","stargazers_url":"https://api.github.com/repos/kytos/python-openflow/stargazers","contributors_url":"https://api.github.com/repos/kytos/python-openflow/contributors","subscribers_url":"https://api.github.com/repos/kytos/python-openflow/subscribers","subscription_url":"https://api.github.com/repos/kytos/python-openflow/subscription","commits_url":"https://api.github.com/repos/kytos/python-openflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kytos/python-openflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kytos/python-openflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kytos/python-openflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kytos/python-openflow/contents/{+path}","compare_url":"https://api.github.com/repos/kytos/python-openflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kytos/python-openflow/merges","archive_url":"https://api.github.com/repos/kytos/python-openflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kytos/python-openflow/downloads","issues_url":"https://api.github.com/repos/kytos/python-openflow/issues{/number}","pulls_url":"https://api.github.com/repos/kytos/python-openflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kytos/python-openflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kytos/python-openflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kytos/python-openflow/labels{/name}","releases_url":"https://api.github.com/repos/kytos/python-openflow/releases{/id}","deployments_url":"https://api.github.com/repos/kytos/python-openflow/deployments","created_at":"2016-03-21T13:58:31Z","updated_at":"2017-05-11T18:18:51Z","pushed_at":"2017-06-01T23:27:08Z","git_url":"git://github.com/kytos/python-openflow.git","ssh_url":"git@github.com:kytos/python-openflow.git","clone_url":"https://github.com/kytos/python-openflow.git","svn_url":"https://github.com/kytos/python-openflow","homepage":"https://kytos.io/","size":2874,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":29,"forks":8,"open_issues":29,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/370"},"html":{"href":"https://github.com/kytos/python-openflow/pull/370"},"issue":{"href":"https://api.github.com/repos/kytos/python-openflow/issues/370"},"comments":{"href":"https://api.github.com/repos/kytos/python-openflow/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kytos/python-openflow/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/kytos/python-openflow/statuses/84e537aade588de1d9e00cc1622f2fc72a00c49c"}}}}
|
{
"id": 54393307,
"name": "kytos/python-openflow",
"url": "https://api.github.com/repos/kytos/python-openflow"
}
|
{
"id": 2965806,
"login": "macartur",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2965806?",
"url": "https://api.github.com/users/macartur"
}
|
{
"id": 16357103,
"login": "kytos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16357103?",
"url": "https://api.github.com/orgs/kytos"
}
| 2017-06-02T20:09:49 |
5993908862
|
{"actor":{"display_login":"macartur"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-go/pulls/comments/105333825","pull_request_review_id":26208834,"id":105333825,"diff_hunk":"@@ -0,0 +1,258 @@\n+/*\n+ * Minio Go Library for Amazon S3 Compatible Cloud Storage (C) 2017 Minio, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package minio\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto/aes\"\n+\t\"crypto/cipher\"\n+\t\"crypto/rand\"\n+\t\"encoding/base64\"\n+\t\"errors\"\n+\t\"io\"\n+\t\"net/http\"\n+)\n+\n+const (\n+\tAmzHeaderIV = \"X-Amz-Meta-X-Amz-Iv\"\n+\tAmzHeaderKey = \"X-Amz-Meta-X-Amz-Key\"\n+\tAmzHeaderMatDesc = \"X-Amz-Meta-X-Amz-Matdesc\"\n+)\n+\n+// Crypt mode - encryption or decryption\n+type cryptMode int\n+\n+const (\n+\tencryptMode cryptMode = iota\n+\tdecryptMode\n+)\n+\n+// Encrypt/Decrypt data using AES CBC algorithm\n+type CBCSecureData struct {\n+\t// Stream to encrypt/decrypt\n+\tstream io.Reader\n+\n+\terr error\n+\teof bool\n+\n+\tsrcBuf *bytes.Buffer\n+\tdstBuf *bytes.Buffer\n+\n+\tencryptionKey EncryptionKey\n+\tcryptedKey []byte\n+\tcontentKey []byte\n+\tiv []byte\n+\tmatDesc []byte\n+\n+\tcryptMode cryptMode\n+\tblockMode cipher.BlockMode\n+}\n+\n+func NewCBCSecureData(key EncryptionKey) *CBCSecureData {\n+\treturn &CBCSecureData{\n+\t\tsrcBuf: bytes.NewBuffer([]byte{}),\n+\t\tdstBuf: bytes.NewBuffer([]byte{}),\n+\t\tencryptionKey: key,\n+\t\tmatDesc: []byte(\"{}\"),\n+\t}\n+}\n+\n+func (s *CBCSecureData) SetInputStream(stream io.Reader) {\n+\ts.stream = stream\n+}\n+\n+func (s *CBCSecureData) SetEncryptMode() error {\n+\n+\t// Set mode to encrypt\n+\ts.cryptMode = encryptMode\n+\n+\ts.eof = false\n+\ts.srcBuf.Reset()\n+\ts.dstBuf.Reset()\n+\n+\tvar err error\n+\n+\t// Generate random content key\n+\ts.contentKey = make([]byte, aes.BlockSize*2)\n+\tif _, err := rand.Read(s.contentKey); err != nil {\n+\t\treturn err\n+\t}\n+\t// Encrypt content key\n+\ts.cryptedKey, err = s.encryptionKey.Encrypt(s.contentKey)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\t// Generate random IV\n+\ts.iv = make([]byte, aes.BlockSize)\n+\tif _, err = rand.Read(s.iv); err != nil {\n+\t\treturn err\n+\t}\n+\t// New cipher\n+\tencryptContentBlock, err := aes.NewCipher(s.contentKey)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\ts.blockMode = cipher.NewCBCEncrypter(encryptContentBlock, s.iv)\n+\n+\treturn nil\n+}\n+\n+func (s *CBCSecureData) SetDecryptMode(metadata http.Header) error {","path":"encryption-cbc.go","position":115,"original_position":115,"commit_id":"3ce629a6c03e9f95be6c4525681870d5cf83bde8","original_commit_id":"3ce629a6c03e9f95be6c4525681870d5cf83bde8","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars3.githubusercontent.com/u/622699?v=3","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"Comment.. ","created_at":"2017-03-10T05:38:22Z","updated_at":"2017-03-10T05:43:45Z","html_url":"https://github.com/minio/minio-go/pull/613#discussion_r105333825","pull_request_url":"https://api.github.com/repos/minio/minio-go/pulls/613","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments/105333825"},"html":{"href":"https://github.com/minio/minio-go/pull/613#discussion_r105333825"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-go/pulls/613"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio-go/pulls/613","id":106421420,"html_url":"https://github.com/minio/minio-go/pull/613","diff_url":"https://github.com/minio/minio-go/pull/613.diff","patch_url":"https://github.com/minio/minio-go/pull/613.patch","issue_url":"https://api.github.com/repos/minio/minio-go/issues/613","number":613,"state":"open","locked":false,"title":"API: Object PUT/GET func supporting CBC encryption","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars2.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-15T23:15:40Z","updated_at":"2017-03-10T05:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60ae5830a802c5cef41ce5824d7bc1138814b1ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-go/pulls/613/commits","review_comments_url":"https://api.github.com/repos/minio/minio-go/pulls/613/comments","review_comment_url":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-go/issues/613/comments","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/3ce629a6c03e9f95be6c4525681870d5cf83bde8","head":{"label":"vadmeste:add_encryption_client_side","ref":"add_encryption_client_side","sha":"3ce629a6c03e9f95be6c4525681870d5cf83bde8","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars2.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"repo":{"id":55795857,"name":"minio-go","full_name":"vadmeste/minio-go","owner":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars2.githubusercontent.com/u/283197?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadmeste/minio-go","description":":green_book: Minio Go Library for Amazon S3 compatible cloud storage","fork":true,"url":"https://api.github.com/repos/vadmeste/minio-go","forks_url":"https://api.github.com/repos/vadmeste/minio-go/forks","keys_url":"https://api.github.com/repos/vadmeste/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadmeste/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadmeste/minio-go/teams","hooks_url":"https://api.github.com/repos/vadmeste/minio-go/hooks","issue_events_url":"https://api.github.com/repos/vadmeste/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/vadmeste/minio-go/events","assignees_url":"https://api.github.com/repos/vadmeste/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/vadmeste/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/vadmeste/minio-go/tags","blobs_url":"https://api.github.com/repos/vadmeste/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadmeste/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadmeste/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadmeste/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadmeste/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/vadmeste/minio-go/languages","stargazers_url":"https://api.github.com/repos/vadmeste/minio-go/stargazers","contributors_url":"https://api.github.com/repos/vadmeste/minio-go/contributors","subscribers_url":"https://api.github.com/repos/vadmeste/minio-go/subscribers","subscription_url":"https://api.github.com/repos/vadmeste/minio-go/subscription","commits_url":"https://api.github.com/repos/vadmeste/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadmeste/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadmeste/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadmeste/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadmeste/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/vadmeste/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadmeste/minio-go/merges","archive_url":"https://api.github.com/repos/vadmeste/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadmeste/minio-go/downloads","issues_url":"https://api.github.com/repos/vadmeste/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/vadmeste/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/vadmeste/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/vadmeste/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadmeste/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/vadmeste/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/vadmeste/minio-go/deployments","created_at":"2016-04-08T17:02:58Z","updated_at":"2016-04-08T17:02:59Z","pushed_at":"2017-03-09T22:07:14Z","git_url":"git://github.com/vadmeste/minio-go.git","ssh_url":"git@github.com:vadmeste/minio-go.git","clone_url":"https://github.com/vadmeste/minio-go.git","svn_url":"https://github.com/vadmeste/minio-go","homepage":"http://minio.io/download/#minio-sdk","size":3949,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"7a3619e41885dcbcfafee193c10eb80530c2be53","user":{"login":"minio","id":695951,"avatar_url":"https://avatars0.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":34933072,"name":"minio-go","full_name":"minio/minio-go","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars0.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-go","description":"Minio Go Library for Amazon S3 compatible cloud storage","fork":false,"url":"https://api.github.com/repos/minio/minio-go","forks_url":"https://api.github.com/repos/minio/minio-go/forks","keys_url":"https://api.github.com/repos/minio/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-go/teams","hooks_url":"https://api.github.com/repos/minio/minio-go/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-go/events","assignees_url":"https://api.github.com/repos/minio/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-go/tags","blobs_url":"https://api.github.com/repos/minio/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-go/languages","stargazers_url":"https://api.github.com/repos/minio/minio-go/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-go/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-go/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-go/subscription","commits_url":"https://api.github.com/repos/minio/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-go/merges","archive_url":"https://api.github.com/repos/minio/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-go/downloads","issues_url":"https://api.github.com/repos/minio/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-go/deployments","created_at":"2015-05-02T02:36:46Z","updated_at":"2017-03-10T03:27:11Z","pushed_at":"2017-03-09T22:38:32Z","git_url":"git://github.com/minio/minio-go.git","ssh_url":"git@github.com:minio/minio-go.git","clone_url":"https://github.com/minio/minio-go.git","svn_url":"https://github.com/minio/minio-go","homepage":"http://minio.io/downloads/#minio-sdk","size":3912,"stargazers_count":274,"watchers_count":274,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":78,"mirror_url":null,"open_issues_count":11,"forks":78,"open_issues":11,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/613"},"html":{"href":"https://github.com/minio/minio-go/pull/613"},"issue":{"href":"https://api.github.com/repos/minio/minio-go/issues/613"},"comments":{"href":"https://api.github.com/repos/minio/minio-go/issues/613/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-go/pulls/613/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-go/pulls/613/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-go/statuses/3ce629a6c03e9f95be6c4525681870d5cf83bde8"}}}}
|
{
"id": 34933072,
"name": "minio/minio-go",
"url": "https://api.github.com/repos/minio/minio-go"
}
|
{
"id": 622699,
"login": "harshavardhana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/622699?",
"url": "https://api.github.com/users/harshavardhana"
}
|
{
"id": 695951,
"login": "minio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/695951?",
"url": "https://api.github.com/orgs/minio"
}
| 2017-03-10T05:38:22 |
5468366137
|
{"actor":{"display_login":"harshavardhana"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-java/pulls/comments/138540071","pull_request_review_id":62346936,"id":138540071,"diff_hunk":"@@ -19,89 +19,90 @@\n /*************************/\n \n buildscript {\n- repositories {\n- jcenter()\n- }\n- dependencies {\n- classpath 'com.github.jengelman.gradle.plugins:shadow:1.2.3'\n- }\n+ repositories {","path":"build.gradle","position":17,"original_position":17,"commit_id":"ac9194699d85c88cca9a9b479e4389d8b8e5ba7d","original_commit_id":"ac9194699d85c88cca9a9b479e4389d8b8e5ba7d","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"That's a mistake reverting.. ","created_at":"2017-09-13T07:15:13Z","updated_at":"2017-09-13T07:15:13Z","html_url":"https://github.com/minio/minio-java/pull/611#discussion_r138540071","pull_request_url":"https://api.github.com/repos/minio/minio-java/pulls/611","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-java/pulls/comments/138540071"},"html":{"href":"https://github.com/minio/minio-java/pull/611#discussion_r138540071"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-java/pulls/611"}},"in_reply_to_id":138539528},"pull_request":{"url":"https://api.github.com/repos/minio/minio-java/pulls/611","id":140749290,"html_url":"https://github.com/minio/minio-java/pull/611","diff_url":"https://github.com/minio/minio-java/pull/611.diff","patch_url":"https://github.com/minio/minio-java/pull/611.patch","issue_url":"https://api.github.com/repos/minio/minio-java/issues/611","number":611,"state":"open","locked":false,"title":"Support releasing an minio-java artifact from maven.","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"body":"Earlier we used to rely on Nexus repo manager to\r\nrelease minio-java jar's, but with this change we\r\ncan now just `release` the repository after\r\n`uploadArchives`.\r\n\r\nAdditionally MAINTAINERS.md is updated with relevant\r\ninstructions.","created_at":"2017-09-13T07:06:34Z","updated_at":"2017-09-13T07:15:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-java/pulls/611/commits","review_comments_url":"https://api.github.com/repos/minio/minio-java/pulls/611/comments","review_comment_url":"https://api.github.com/repos/minio/minio-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-java/issues/611/comments","statuses_url":"https://api.github.com/repos/minio/minio-java/statuses/ac9194699d85c88cca9a9b479e4389d8b8e5ba7d","head":{"label":"harshavardhana:auto-build","ref":"auto-build","sha":"ac9194699d85c88cca9a9b479e4389d8b8e5ba7d","user":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"repo":{"id":35013407,"name":"minio-java","full_name":"harshavardhana/minio-java","owner":{"login":"harshavardhana","id":622699,"avatar_url":"https://avatars0.githubusercontent.com/u/622699?v=4","gravatar_id":"","url":"https://api.github.com/users/harshavardhana","html_url":"https://github.com/harshavardhana","followers_url":"https://api.github.com/users/harshavardhana/followers","following_url":"https://api.github.com/users/harshavardhana/following{/other_user}","gists_url":"https://api.github.com/users/harshavardhana/gists{/gist_id}","starred_url":"https://api.github.com/users/harshavardhana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshavardhana/subscriptions","organizations_url":"https://api.github.com/users/harshavardhana/orgs","repos_url":"https://api.github.com/users/harshavardhana/repos","events_url":"https://api.github.com/users/harshavardhana/events{/privacy}","received_events_url":"https://api.github.com/users/harshavardhana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harshavardhana/minio-java","description":"Object storage library for Java programming language","fork":true,"url":"https://api.github.com/repos/harshavardhana/minio-java","forks_url":"https://api.github.com/repos/harshavardhana/minio-java/forks","keys_url":"https://api.github.com/repos/harshavardhana/minio-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshavardhana/minio-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshavardhana/minio-java/teams","hooks_url":"https://api.github.com/repos/harshavardhana/minio-java/hooks","issue_events_url":"https://api.github.com/repos/harshavardhana/minio-java/issues/events{/number}","events_url":"https://api.github.com/repos/harshavardhana/minio-java/events","assignees_url":"https://api.github.com/repos/harshavardhana/minio-java/assignees{/user}","branches_url":"https://api.github.com/repos/harshavardhana/minio-java/branches{/branch}","tags_url":"https://api.github.com/repos/harshavardhana/minio-java/tags","blobs_url":"https://api.github.com/repos/harshavardhana/minio-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshavardhana/minio-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshavardhana/minio-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshavardhana/minio-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshavardhana/minio-java/statuses/{sha}","languages_url":"https://api.github.com/repos/harshavardhana/minio-java/languages","stargazers_url":"https://api.github.com/repos/harshavardhana/minio-java/stargazers","contributors_url":"https://api.github.com/repos/harshavardhana/minio-java/contributors","subscribers_url":"https://api.github.com/repos/harshavardhana/minio-java/subscribers","subscription_url":"https://api.github.com/repos/harshavardhana/minio-java/subscription","commits_url":"https://api.github.com/repos/harshavardhana/minio-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshavardhana/minio-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshavardhana/minio-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshavardhana/minio-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshavardhana/minio-java/contents/{+path}","compare_url":"https://api.github.com/repos/harshavardhana/minio-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshavardhana/minio-java/merges","archive_url":"https://api.github.com/repos/harshavardhana/minio-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshavardhana/minio-java/downloads","issues_url":"https://api.github.com/repos/harshavardhana/minio-java/issues{/number}","pulls_url":"https://api.github.com/repos/harshavardhana/minio-java/pulls{/number}","milestones_url":"https://api.github.com/repos/harshavardhana/minio-java/milestones{/number}","notifications_url":"https://api.github.com/repos/harshavardhana/minio-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshavardhana/minio-java/labels{/name}","releases_url":"https://api.github.com/repos/harshavardhana/minio-java/releases{/id}","deployments_url":"https://api.github.com/repos/harshavardhana/minio-java/deployments","created_at":"2015-05-04T04:07:38Z","updated_at":"2015-05-23T22:53:40Z","pushed_at":"2017-09-13T07:04:59Z","git_url":"git://github.com/harshavardhana/minio-java.git","ssh_url":"git@github.com:harshavardhana/minio-java.git","clone_url":"https://github.com/harshavardhana/minio-java.git","svn_url":"https://github.com/harshavardhana/minio-java","homepage":"","size":1542,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"cfa641795fb91ea1217d0e7e4d9c421ce48b2066","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":34966186,"name":"minio-java","full_name":"minio/minio-java","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-java","description":"Minio Client SDK for Java","fork":false,"url":"https://api.github.com/repos/minio/minio-java","forks_url":"https://api.github.com/repos/minio/minio-java/forks","keys_url":"https://api.github.com/repos/minio/minio-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-java/teams","hooks_url":"https://api.github.com/repos/minio/minio-java/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-java/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-java/events","assignees_url":"https://api.github.com/repos/minio/minio-java/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-java/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-java/tags","blobs_url":"https://api.github.com/repos/minio/minio-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-java/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-java/languages","stargazers_url":"https://api.github.com/repos/minio/minio-java/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-java/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-java/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-java/subscription","commits_url":"https://api.github.com/repos/minio/minio-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-java/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-java/merges","archive_url":"https://api.github.com/repos/minio/minio-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-java/downloads","issues_url":"https://api.github.com/repos/minio/minio-java/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-java/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-java/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-java/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-java/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-java/deployments","created_at":"2015-05-02T23:01:03Z","updated_at":"2017-09-07T18:16:13Z","pushed_at":"2017-09-13T07:06:35Z","git_url":"git://github.com/minio/minio-java.git","ssh_url":"git@github.com:minio/minio-java.git","clone_url":"https://github.com/minio/minio-java.git","svn_url":"https://github.com/minio/minio-java","homepage":"http://minio.io/downloads/#minio-sdk","size":2422,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"open_issues_count":11,"forks":48,"open_issues":11,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-java/pulls/611"},"html":{"href":"https://github.com/minio/minio-java/pull/611"},"issue":{"href":"https://api.github.com/repos/minio/minio-java/issues/611"},"comments":{"href":"https://api.github.com/repos/minio/minio-java/issues/611/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-java/pulls/611/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-java/pulls/611/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-java/statuses/ac9194699d85c88cca9a9b479e4389d8b8e5ba7d"}},"author_association":"OWNER"}}
|
{
"id": 34966186,
"name": "minio/minio-java",
"url": "https://api.github.com/repos/minio/minio-java"
}
|
{
"id": 622699,
"login": "harshavardhana",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/622699?",
"url": "https://api.github.com/users/harshavardhana"
}
|
{
"id": 695951,
"login": "minio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/695951?",
"url": "https://api.github.com/orgs/minio"
}
| 2017-09-13T07:15:13 |
6583695678
|
{"actor":{"display_login":"harshavardhana"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/110439630","pull_request_review_id":31616959,"id":110439630,"diff_hunk":"@@ -47,6 +47,22 @@ func skipContentSha256Cksum(r *http.Request) bool {\n \treturn isRequestUnsignedPayload(r) || isRequestPresignedUnsignedPayload(r)\n }\n \n+// Returns SHA256 for calculating canonical-request.\n+func getContentSha256Cksum(r *http.Request) string {\n+\tdefaultSum := emptySHA256","path":"cmd/signature-v4-utils.go","position":6,"original_position":6,"commit_id":"adae58fe4637a2530edfb09d6dc443e45270b9d4","original_commit_id":"adae58fe4637a2530edfb09d6dc443e45270b9d4","user":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars3.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"body":"do you have suggestions?","created_at":"2017-04-07T17:22:34Z","updated_at":"2017-04-07T17:22:34Z","html_url":"https://github.com/minio/minio/pull/4064#discussion_r110439630","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/4064","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/110439630"},"html":{"href":"https://github.com/minio/minio/pull/4064#discussion_r110439630"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/4064"}}},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/4064","id":114770747,"html_url":"https://github.com/minio/minio/pull/4064","diff_url":"https://github.com/minio/minio/pull/4064.diff","patch_url":"https://github.com/minio/minio/pull/4064.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/4064","number":4064,"state":"open","locked":false,"title":"signature-v4: Use sha256(\"\") for calculating canonical request","user":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars3.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"body":"\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\nWhen x-amz-content-sha256 header is missing assume e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\r\nas the SHA256 value for calculating canonical-request.\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nfixes #4039\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nmake test\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2017-04-07T08:52:05Z","updated_at":"2017-04-07T17:22:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e106a4360dd692efa196d5172920a609bf8e296","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/4064/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/4064/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/4064/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/adae58fe4637a2530edfb09d6dc443e45270b9d4","head":{"label":"krishnasrinivas:ios-fix2","ref":"ios-fix2","sha":"adae58fe4637a2530edfb09d6dc443e45270b9d4","user":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars3.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"repo":{"id":39705039,"name":"minio","full_name":"krishnasrinivas/minio","owner":{"login":"krishnasrinivas","id":634494,"avatar_url":"https://avatars3.githubusercontent.com/u/634494?v=3","gravatar_id":"","url":"https://api.github.com/users/krishnasrinivas","html_url":"https://github.com/krishnasrinivas","followers_url":"https://api.github.com/users/krishnasrinivas/followers","following_url":"https://api.github.com/users/krishnasrinivas/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrinivas/subscriptions","organizations_url":"https://api.github.com/users/krishnasrinivas/orgs","repos_url":"https://api.github.com/users/krishnasrinivas/repos","events_url":"https://api.github.com/users/krishnasrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrinivas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnasrinivas/minio","description":"Minio Cloud Storage Server","fork":true,"url":"https://api.github.com/repos/krishnasrinivas/minio","forks_url":"https://api.github.com/repos/krishnasrinivas/minio/forks","keys_url":"https://api.github.com/repos/krishnasrinivas/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnasrinivas/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnasrinivas/minio/teams","hooks_url":"https://api.github.com/repos/krishnasrinivas/minio/hooks","issue_events_url":"https://api.github.com/repos/krishnasrinivas/minio/issues/events{/number}","events_url":"https://api.github.com/repos/krishnasrinivas/minio/events","assignees_url":"https://api.github.com/repos/krishnasrinivas/minio/assignees{/user}","branches_url":"https://api.github.com/repos/krishnasrinivas/minio/branches{/branch}","tags_url":"https://api.github.com/repos/krishnasrinivas/minio/tags","blobs_url":"https://api.github.com/repos/krishnasrinivas/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnasrinivas/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnasrinivas/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnasrinivas/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnasrinivas/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnasrinivas/minio/languages","stargazers_url":"https://api.github.com/repos/krishnasrinivas/minio/stargazers","contributors_url":"https://api.github.com/repos/krishnasrinivas/minio/contributors","subscribers_url":"https://api.github.com/repos/krishnasrinivas/minio/subscribers","subscription_url":"https://api.github.com/repos/krishnasrinivas/minio/subscription","commits_url":"https://api.github.com/repos/krishnasrinivas/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnasrinivas/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnasrinivas/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnasrinivas/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/krishnasrinivas/minio/contents/{+path}","compare_url":"https://api.github.com/repos/krishnasrinivas/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnasrinivas/minio/merges","archive_url":"https://api.github.com/repos/krishnasrinivas/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnasrinivas/minio/downloads","issues_url":"https://api.github.com/repos/krishnasrinivas/minio/issues{/number}","pulls_url":"https://api.github.com/repos/krishnasrinivas/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnasrinivas/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnasrinivas/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnasrinivas/minio/labels{/name}","releases_url":"https://api.github.com/repos/krishnasrinivas/minio/releases{/id}","deployments_url":"https://api.github.com/repos/krishnasrinivas/minio/deployments","created_at":"2015-07-25T22:31:14Z","updated_at":"2016-11-30T06:58:14Z","pushed_at":"2017-04-07T08:51:09Z","git_url":"git://github.com/krishnasrinivas/minio.git","ssh_url":"git@github.com:krishnasrinivas/minio.git","clone_url":"https://github.com/krishnasrinivas/minio.git","svn_url":"https://github.com/krishnasrinivas/minio","homepage":"https://minio.io/#minio-server","size":24121,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"5ed1a8ad23598445a1a459f1590210c22b053af1","user":{"login":"minio","id":695951,"avatar_url":"https://avatars0.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"name":"minio","full_name":"minio/minio","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars0.githubusercontent.com/u/695951?v=3","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2017-04-07T16:37:44Z","pushed_at":"2017-04-07T17:16:35Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io","size":22427,"stargazers_count":6355,"watchers_count":6355,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":446,"mirror_url":null,"open_issues_count":81,"forks":446,"open_issues":81,"watchers":6355,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/4064"},"html":{"href":"https://github.com/minio/minio/pull/4064"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/4064"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/4064/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/4064/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/4064/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/adae58fe4637a2530edfb09d6dc443e45270b9d4"}}}}
|
{
"id": 29261473,
"name": "minio/minio",
"url": "https://api.github.com/repos/minio/minio"
}
|
{
"id": 634494,
"login": "krishnasrinivas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/634494?",
"url": "https://api.github.com/users/krishnasrinivas"
}
|
{
"id": 695951,
"login": "minio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/695951?",
"url": "https://api.github.com/orgs/minio"
}
| 2017-04-07T17:22:34 |
5648604979
|
{"actor":{"display_login":"krishnasrinivas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ndlib/QA_tests/pulls/comments/103747469","pull_request_review_id":24540499,"id":103747469,"diff_hunk":"@@ -87,6 +87,27 @@\n visit departmental_link.link\n expect(dept_search_page).to be_on_page\n end\n+\n+ scenario \"Show an Article\" do\n+ visit '/'\n+ home_page = Curate::Pages::HomePage.new\n+ expect(home_page).to be_on_page\n+ search_term = \"Article\"\n+ fill_in('catalog_search', with: search_term)\n+ click_on('Search')\n+ catalog_page = Curate::Pages::CatalogPage.new(search_term: search_term)\n+ expect(catalog_page).to be_on_page\n+ article_link = first('a[id^=\"src_copy_link\"]')\n+ show_article = Curate::Pages::ShowArticlePage.new(title: article_link.text)\n+ article_link.click\n+ expect(show_article).to be_on_page\n+ download_button=find(\"a.action.btn\", :text => \"Download\")\n+ article_link = download_button['href'].split('/').last(2)\n+ download_button.click\n+ page.driver.browser.switch_to_window(page.driver.browser.window_handles.last)\n+ expect(page.current_url).to eq(File.join(Capybara.app_host, article_link))\n+ expect(status_code).to eq(200 || 201 || 206)","path":"spec/curate/functional/func_curate_spec.rb","position":23,"original_position":23,"commit_id":"fb1da0a18e7ae2950bc0900c5627a60c7dda8630","original_commit_id":"fb1da0a18e7ae2950bc0900c5627a60c7dda8630","user":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars1.githubusercontent.com/u/2130?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"body":"I don't believe this is working as intented:\r\n\r\n```ruby\r\nexpect(200).to eq(200 || 201 || 206)\r\n=> true\r\n\r\nexpect(201).to eq(200 || 201 || 206)\r\n=> false\r\n```\r\n\r\n`200 || 201 || 206` always returns 200 (e.g. the first \"truthy\" value in the OR operation).\r\n\r\nI believe you want:\r\n\r\n```ruby\r\nexpect(200.to_s).to match(/^20[0,6,7]$/)\r\n```\r\n","created_at":"2017-03-01T17:55:24Z","updated_at":"2017-03-01T18:03:47Z","html_url":"https://github.com/ndlib/QA_tests/pull/72#discussion_r103747469","pull_request_url":"https://api.github.com/repos/ndlib/QA_tests/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/comments/103747469"},"html":{"href":"https://github.com/ndlib/QA_tests/pull/72#discussion_r103747469"},"pull_request":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/ndlib/QA_tests/pulls/72","id":108155682,"html_url":"https://github.com/ndlib/QA_tests/pull/72","diff_url":"https://github.com/ndlib/QA_tests/pull/72.diff","patch_url":"https://github.com/ndlib/QA_tests/pull/72.patch","issue_url":"https://api.github.com/repos/ndlib/QA_tests/issues/72","number":72,"state":"open","locked":false,"title":"Curate login tests","user":{"login":"NicHaydel95","id":11080022,"avatar_url":"https://avatars3.githubusercontent.com/u/11080022?v=3","gravatar_id":"","url":"https://api.github.com/users/NicHaydel95","html_url":"https://github.com/NicHaydel95","followers_url":"https://api.github.com/users/NicHaydel95/followers","following_url":"https://api.github.com/users/NicHaydel95/following{/other_user}","gists_url":"https://api.github.com/users/NicHaydel95/gists{/gist_id}","starred_url":"https://api.github.com/users/NicHaydel95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicHaydel95/subscriptions","organizations_url":"https://api.github.com/users/NicHaydel95/orgs","repos_url":"https://api.github.com/users/NicHaydel95/repos","events_url":"https://api.github.com/users/NicHaydel95/events{/privacy}","received_events_url":"https://api.github.com/users/NicHaydel95/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-27T16:53:17Z","updated_at":"2017-03-01T18:03:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ec03c55af9609b81942ab532ca76d6e0b0f8216","assignee":{"login":"jeremyf","id":2130,"avatar_url":"https://avatars1.githubusercontent.com/u/2130?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeremyf","id":2130,"avatar_url":"https://avatars1.githubusercontent.com/u/2130?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremyf","html_url":"https://github.com/jeremyf","followers_url":"https://api.github.com/users/jeremyf/followers","following_url":"https://api.github.com/users/jeremyf/following{/other_user}","gists_url":"https://api.github.com/users/jeremyf/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyf/subscriptions","organizations_url":"https://api.github.com/users/jeremyf/orgs","repos_url":"https://api.github.com/users/jeremyf/repos","events_url":"https://api.github.com/users/jeremyf/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyf/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/QA_tests/pulls/72/commits","review_comments_url":"https://api.github.com/repos/ndlib/QA_tests/pulls/72/comments","review_comment_url":"https://api.github.com/repos/ndlib/QA_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndlib/QA_tests/issues/72/comments","statuses_url":"https://api.github.com/repos/ndlib/QA_tests/statuses/fb1da0a18e7ae2950bc0900c5627a60c7dda8630","head":{"label":"ndlib:Curate-Login-Tests","ref":"Curate-Login-Tests","sha":"fb1da0a18e7ae2950bc0900c5627a60c7dda8630","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars1.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":69483770,"name":"QA_tests","full_name":"ndlib/QA_tests","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars1.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/QA_tests","description":"A collection of test suites for validating quality (functional, integration, performance) of DLT and WSE applications","fork":false,"url":"https://api.github.com/repos/ndlib/QA_tests","forks_url":"https://api.github.com/repos/ndlib/QA_tests/forks","keys_url":"https://api.github.com/repos/ndlib/QA_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/QA_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/QA_tests/teams","hooks_url":"https://api.github.com/repos/ndlib/QA_tests/hooks","issue_events_url":"https://api.github.com/repos/ndlib/QA_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/QA_tests/events","assignees_url":"https://api.github.com/repos/ndlib/QA_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/QA_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/QA_tests/tags","blobs_url":"https://api.github.com/repos/ndlib/QA_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/QA_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/QA_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/QA_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/QA_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/QA_tests/languages","stargazers_url":"https://api.github.com/repos/ndlib/QA_tests/stargazers","contributors_url":"https://api.github.com/repos/ndlib/QA_tests/contributors","subscribers_url":"https://api.github.com/repos/ndlib/QA_tests/subscribers","subscription_url":"https://api.github.com/repos/ndlib/QA_tests/subscription","commits_url":"https://api.github.com/repos/ndlib/QA_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/QA_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/QA_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/QA_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/QA_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/QA_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/QA_tests/merges","archive_url":"https://api.github.com/repos/ndlib/QA_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/QA_tests/downloads","issues_url":"https://api.github.com/repos/ndlib/QA_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/QA_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/QA_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/QA_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/QA_tests/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/QA_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ndlib/QA_tests/deployments","created_at":"2016-09-28T16:44:44Z","updated_at":"2017-03-01T16:54:51Z","pushed_at":"2017-03-01T16:41:39Z","git_url":"git://github.com/ndlib/QA_tests.git","ssh_url":"git@github.com:ndlib/QA_tests.git","clone_url":"https://github.com/ndlib/QA_tests.git","svn_url":"https://github.com/ndlib/QA_tests","homepage":"","size":962,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"aeeb564b019dc688417afbe25eb6d44f3791087d","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars1.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":69483770,"name":"QA_tests","full_name":"ndlib/QA_tests","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars1.githubusercontent.com/u/160943?v=3","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/QA_tests","description":"A collection of test suites for validating quality (functional, integration, performance) of DLT and WSE applications","fork":false,"url":"https://api.github.com/repos/ndlib/QA_tests","forks_url":"https://api.github.com/repos/ndlib/QA_tests/forks","keys_url":"https://api.github.com/repos/ndlib/QA_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/QA_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/QA_tests/teams","hooks_url":"https://api.github.com/repos/ndlib/QA_tests/hooks","issue_events_url":"https://api.github.com/repos/ndlib/QA_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/QA_tests/events","assignees_url":"https://api.github.com/repos/ndlib/QA_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/QA_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/QA_tests/tags","blobs_url":"https://api.github.com/repos/ndlib/QA_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/QA_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/QA_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/QA_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/QA_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/QA_tests/languages","stargazers_url":"https://api.github.com/repos/ndlib/QA_tests/stargazers","contributors_url":"https://api.github.com/repos/ndlib/QA_tests/contributors","subscribers_url":"https://api.github.com/repos/ndlib/QA_tests/subscribers","subscription_url":"https://api.github.com/repos/ndlib/QA_tests/subscription","commits_url":"https://api.github.com/repos/ndlib/QA_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/QA_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/QA_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/QA_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/QA_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/QA_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/QA_tests/merges","archive_url":"https://api.github.com/repos/ndlib/QA_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/QA_tests/downloads","issues_url":"https://api.github.com/repos/ndlib/QA_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/QA_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/QA_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/QA_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/QA_tests/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/QA_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ndlib/QA_tests/deployments","created_at":"2016-09-28T16:44:44Z","updated_at":"2017-03-01T16:54:51Z","pushed_at":"2017-03-01T16:41:39Z","git_url":"git://github.com/ndlib/QA_tests.git","ssh_url":"git@github.com:ndlib/QA_tests.git","clone_url":"https://github.com/ndlib/QA_tests.git","svn_url":"https://github.com/ndlib/QA_tests","homepage":"","size":962,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/72"},"html":{"href":"https://github.com/ndlib/QA_tests/pull/72"},"issue":{"href":"https://api.github.com/repos/ndlib/QA_tests/issues/72"},"comments":{"href":"https://api.github.com/repos/ndlib/QA_tests/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndlib/QA_tests/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/QA_tests/statuses/fb1da0a18e7ae2950bc0900c5627a60c7dda8630"}}}}
|
{
"id": 69483770,
"name": "ndlib/QA_tests",
"url": "https://api.github.com/repos/ndlib/QA_tests"
}
|
{
"id": 2130,
"login": "jeremyf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2130?",
"url": "https://api.github.com/users/jeremyf"
}
|
{
"id": 160943,
"login": "ndlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160943?",
"url": "https://api.github.com/orgs/ndlib"
}
| 2017-03-01T17:55:24 |
5414015490
|
{"actor":{"display_login":"jeremyf"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ndlib/bendo/pulls/comments/135895847","pull_request_review_id":59329459,"id":135895847,"diff_hunk":"@@ -139,3 +155,118 @@ func (s *RESTServer) scanfixity() {\n \t}\n \tlog.Println(\"Ending scanfixity. duration = \", time.Now().Sub(starttime))\n }\n+\n+func (s *RESTServer) GetFixityHandler(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {\n+\n+\titem := r.FormValue(\"item\")\n+\tstart := r.FormValue(\"start\")\n+\tend := r.FormValue(\"end\")\n+\tstatus := r.FormValue(\"status\")\n+\n+\tlog.Println(\"GetFixityHandler called\")\n+\tlog.Println(\"item= \", item)\n+\tlog.Println(\"start= \", start)\n+\tlog.Println(\"end= \", end)\n+\tlog.Println(\"status= \", status)\n+\n+\tstartValue, startErr := startValidate(start)\n+\tif startErr != nil {\n+\t\tw.WriteHeader(400)\n+\t\tlog.Println(\"GetFixityHandler :\", startErr.Error())\n+\t\treturn\n+\t}\n+\n+\tendValue, endErr := endValidate(end)\n+\tif endErr != nil {\n+\t\tw.WriteHeader(400)\n+\t\tlog.Println(\"GetFixityHandler :\", endErr.Error())\n+\t\treturn\n+\t}\n+\n+\titemValue, itemErr := itemValidate(item)\n+\tif itemErr != nil {\n+\t\tw.WriteHeader(400)\n+\t\tlog.Println(\"GetFixityHandler :\", itemErr.Error())\n+\t\treturn\n+\t}\n+\n+\tstatusValue, statusErr := statusValidate(status)\n+\tif statusErr != nil {\n+\t\tw.WriteHeader(400)\n+\t\tlog.Println(\"GetFixityHandler :\", statusErr.Error())\n+\t\treturn\n+\t}\n+\n+\tfixityResults := s.Fixity.GetFixity(startValue, endValue, itemValue, statusValue)\n+\tif fixityResults == nil {\n+\t\tw.WriteHeader(404)\n+\t\tlog.Println(\"GetFixityHandler start =\", startValue, \"end= \", endValue, \"item =\", itemValue, \"status = \", statusValue, \" Returns 404\")\n+\t\treturn\n+\t}\n+\n+\t//Return results\n+\tenc := json.NewEncoder(w)\n+\tenc.Encode(fixityResults)\n+}\n+\n+func (s *RESTServer) GetFixityIdHandler(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {\n+\tid := ps.ByName(\"id\")\n+\tlog.Println(\"GetFixityIdHandler passed id =\", id)\n+\tthisFixity := s.Fixity.GetFixityById(id)\n+\n+\tif thisFixity == nil {\n+\t\tw.WriteHeader(404)\n+\t\tlog.Println(\"GetFixityIdHandler id =\", id, \" Returns 404\")\n+\t\treturn\n+\t}\n+\n+\tenc := json.NewEncoder(w)\n+\tenc.Encode(thisFixity)\n+}\n+\n+// Some validation routines for GET /fixity params\n+\n+func startValidate(param string) (string, error) {\n+\tif param == \"\" {\n+\t\ttime_midnight := time.Now().Truncate(86400 * time.Second)\n+\t\treturn time_midnight.Format(time.RFC3339), nil\n+\t}\n+\tif param == \"*\" {\n+\t\treturn \"*\", nil\n+\t}\n+\ttime_formatted, terr := time.Parse(time.RFC3339, param)\n+\tif terr != nil {\n+\t\treturn \"\", terr\n+\t}\n+\treturn time_formatted.Format(time.RFC3339), nil\n+}\n+\n+func endValidate(param string) (string, error) {\n+\tif param == \"\" {\n+\t\tnext_midnight := time.Now().Truncate(86400 * time.Second).Unix() + 86400\n+\t\ttime_next := time.Unix(next_midnight, 0)\n+\t\treturn time_next.Format(time.RFC3339), nil\n+\t}\n+\tif param == \"*\" {\n+\t\treturn \"*\", nil\n+\t}\n+\ttime_formatted, terr := time.Parse(time.RFC3339, param)","path":"server/fixity.go","position":122,"original_position":138,"commit_id":"1c8871881c2f588553fe46ce3873ed6c91e4a292","original_commit_id":"1c8871881c2f588553fe46ce3873ed6c91e4a292","user":{"login":"dbrower","id":1843787,"avatar_url":"https://avatars3.githubusercontent.com/u/1843787?v=4","gravatar_id":"","url":"https://api.github.com/users/dbrower","html_url":"https://github.com/dbrower","followers_url":"https://api.github.com/users/dbrower/followers","following_url":"https://api.github.com/users/dbrower/following{/other_user}","gists_url":"https://api.github.com/users/dbrower/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrower/subscriptions","organizations_url":"https://api.github.com/users/dbrower/orgs","repos_url":"https://api.github.com/users/dbrower/repos","events_url":"https://api.github.com/users/dbrower/events{/privacy}","received_events_url":"https://api.github.com/users/dbrower/received_events","type":"User","site_admin":false},"body":"use `err` instead of `terr`.","created_at":"2017-08-29T19:59:27Z","updated_at":"2017-08-29T20:00:10Z","html_url":"https://github.com/ndlib/bendo/pull/152#discussion_r135895847","pull_request_url":"https://api.github.com/repos/ndlib/bendo/pulls/152","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/comments/135895847"},"html":{"href":"https://github.com/ndlib/bendo/pull/152#discussion_r135895847"},"pull_request":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/ndlib/bendo/pulls/152","id":138245126,"html_url":"https://github.com/ndlib/bendo/pull/152","diff_url":"https://github.com/ndlib/bendo/pull/152.diff","patch_url":"https://github.com/ndlib/bendo/pull/152.patch","issue_url":"https://api.github.com/repos/ndlib/bendo/issues/152","number":152,"state":"open","locked":false,"title":"Get fixity routes","user":{"login":"msuhovec","id":3360332,"avatar_url":"https://avatars0.githubusercontent.com/u/3360332?v=4","gravatar_id":"","url":"https://api.github.com/users/msuhovec","html_url":"https://github.com/msuhovec","followers_url":"https://api.github.com/users/msuhovec/followers","following_url":"https://api.github.com/users/msuhovec/following{/other_user}","gists_url":"https://api.github.com/users/msuhovec/gists{/gist_id}","starred_url":"https://api.github.com/users/msuhovec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msuhovec/subscriptions","organizations_url":"https://api.github.com/users/msuhovec/orgs","repos_url":"https://api.github.com/users/msuhovec/repos","events_url":"https://api.github.com/users/msuhovec/events{/privacy}","received_events_url":"https://api.github.com/users/msuhovec/received_events","type":"User","site_admin":false},"body":"#6","created_at":"2017-08-29T17:53:45Z","updated_at":"2017-08-29T20:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a4237c657e45771ef7e2f670933d60ec1cfdf204","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ndlib/bendo/pulls/152/commits","review_comments_url":"https://api.github.com/repos/ndlib/bendo/pulls/152/comments","review_comment_url":"https://api.github.com/repos/ndlib/bendo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ndlib/bendo/issues/152/comments","statuses_url":"https://api.github.com/repos/ndlib/bendo/statuses/1c8871881c2f588553fe46ce3873ed6c91e4a292","head":{"label":"ndlib:get-fixity-routes","ref":"get-fixity-routes","sha":"1c8871881c2f588553fe46ce3873ed6c91e4a292","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars2.githubusercontent.com/u/160943?v=4","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":38450809,"name":"bendo","full_name":"ndlib/bendo","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars2.githubusercontent.com/u/160943?v=4","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/bendo","description":"Tape storage manager","fork":false,"url":"https://api.github.com/repos/ndlib/bendo","forks_url":"https://api.github.com/repos/ndlib/bendo/forks","keys_url":"https://api.github.com/repos/ndlib/bendo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/bendo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/bendo/teams","hooks_url":"https://api.github.com/repos/ndlib/bendo/hooks","issue_events_url":"https://api.github.com/repos/ndlib/bendo/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/bendo/events","assignees_url":"https://api.github.com/repos/ndlib/bendo/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/bendo/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/bendo/tags","blobs_url":"https://api.github.com/repos/ndlib/bendo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/bendo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/bendo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/bendo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/bendo/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/bendo/languages","stargazers_url":"https://api.github.com/repos/ndlib/bendo/stargazers","contributors_url":"https://api.github.com/repos/ndlib/bendo/contributors","subscribers_url":"https://api.github.com/repos/ndlib/bendo/subscribers","subscription_url":"https://api.github.com/repos/ndlib/bendo/subscription","commits_url":"https://api.github.com/repos/ndlib/bendo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/bendo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/bendo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/bendo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/bendo/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/bendo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/bendo/merges","archive_url":"https://api.github.com/repos/ndlib/bendo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/bendo/downloads","issues_url":"https://api.github.com/repos/ndlib/bendo/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/bendo/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/bendo/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/bendo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/bendo/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/bendo/releases{/id}","deployments_url":"https://api.github.com/repos/ndlib/bendo/deployments","created_at":"2015-07-02T18:51:20Z","updated_at":"2016-11-15T18:46:36Z","pushed_at":"2017-08-29T17:53:45Z","git_url":"git://github.com/ndlib/bendo.git","ssh_url":"git@github.com:ndlib/bendo.git","clone_url":"https://github.com/ndlib/bendo.git","svn_url":"https://github.com/ndlib/bendo","homepage":null,"size":10266,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"base":{"label":"ndlib:master","ref":"master","sha":"49a9d0a2daa97b74c23c658e844cdddaa6d160bc","user":{"login":"ndlib","id":160943,"avatar_url":"https://avatars2.githubusercontent.com/u/160943?v=4","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"repo":{"id":38450809,"name":"bendo","full_name":"ndlib/bendo","owner":{"login":"ndlib","id":160943,"avatar_url":"https://avatars2.githubusercontent.com/u/160943?v=4","gravatar_id":"","url":"https://api.github.com/users/ndlib","html_url":"https://github.com/ndlib","followers_url":"https://api.github.com/users/ndlib/followers","following_url":"https://api.github.com/users/ndlib/following{/other_user}","gists_url":"https://api.github.com/users/ndlib/gists{/gist_id}","starred_url":"https://api.github.com/users/ndlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndlib/subscriptions","organizations_url":"https://api.github.com/users/ndlib/orgs","repos_url":"https://api.github.com/users/ndlib/repos","events_url":"https://api.github.com/users/ndlib/events{/privacy}","received_events_url":"https://api.github.com/users/ndlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ndlib/bendo","description":"Tape storage manager","fork":false,"url":"https://api.github.com/repos/ndlib/bendo","forks_url":"https://api.github.com/repos/ndlib/bendo/forks","keys_url":"https://api.github.com/repos/ndlib/bendo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ndlib/bendo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ndlib/bendo/teams","hooks_url":"https://api.github.com/repos/ndlib/bendo/hooks","issue_events_url":"https://api.github.com/repos/ndlib/bendo/issues/events{/number}","events_url":"https://api.github.com/repos/ndlib/bendo/events","assignees_url":"https://api.github.com/repos/ndlib/bendo/assignees{/user}","branches_url":"https://api.github.com/repos/ndlib/bendo/branches{/branch}","tags_url":"https://api.github.com/repos/ndlib/bendo/tags","blobs_url":"https://api.github.com/repos/ndlib/bendo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ndlib/bendo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ndlib/bendo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ndlib/bendo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ndlib/bendo/statuses/{sha}","languages_url":"https://api.github.com/repos/ndlib/bendo/languages","stargazers_url":"https://api.github.com/repos/ndlib/bendo/stargazers","contributors_url":"https://api.github.com/repos/ndlib/bendo/contributors","subscribers_url":"https://api.github.com/repos/ndlib/bendo/subscribers","subscription_url":"https://api.github.com/repos/ndlib/bendo/subscription","commits_url":"https://api.github.com/repos/ndlib/bendo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ndlib/bendo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ndlib/bendo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ndlib/bendo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ndlib/bendo/contents/{+path}","compare_url":"https://api.github.com/repos/ndlib/bendo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ndlib/bendo/merges","archive_url":"https://api.github.com/repos/ndlib/bendo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ndlib/bendo/downloads","issues_url":"https://api.github.com/repos/ndlib/bendo/issues{/number}","pulls_url":"https://api.github.com/repos/ndlib/bendo/pulls{/number}","milestones_url":"https://api.github.com/repos/ndlib/bendo/milestones{/number}","notifications_url":"https://api.github.com/repos/ndlib/bendo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ndlib/bendo/labels{/name}","releases_url":"https://api.github.com/repos/ndlib/bendo/releases{/id}","deployments_url":"https://api.github.com/repos/ndlib/bendo/deployments","created_at":"2015-07-02T18:51:20Z","updated_at":"2016-11-15T18:46:36Z","pushed_at":"2017-08-29T17:53:45Z","git_url":"git://github.com/ndlib/bendo.git","ssh_url":"git@github.com:ndlib/bendo.git","clone_url":"https://github.com/ndlib/bendo.git","svn_url":"https://github.com/ndlib/bendo","homepage":null,"size":10266,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":17,"forks":0,"open_issues":17,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/152"},"html":{"href":"https://github.com/ndlib/bendo/pull/152"},"issue":{"href":"https://api.github.com/repos/ndlib/bendo/issues/152"},"comments":{"href":"https://api.github.com/repos/ndlib/bendo/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ndlib/bendo/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/ndlib/bendo/statuses/1c8871881c2f588553fe46ce3873ed6c91e4a292"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38450809,
"name": "ndlib/bendo",
"url": "https://api.github.com/repos/ndlib/bendo"
}
|
{
"id": 1843787,
"login": "dbrower",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1843787?",
"url": "https://api.github.com/users/dbrower"
}
|
{
"id": 160943,
"login": "ndlib",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/160943?",
"url": "https://api.github.com/orgs/ndlib"
}
| 2017-08-29T19:59:27 |
6526518274
|
{"actor":{"display_login":"dbrower"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/112424997","pull_request_review_id":33737836,"id":112424997,"diff_hunk":"@@ -0,0 +1,54 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!--\n+ ~ Copyright 2017 The Netty Project\n+ ~\n+ ~ The Netty Project licenses this file to you under the Apache License,\n+ ~ version 2.0 (the \"License\"); you may not use this file except in compliance\n+ ~ with the License. You may obtain a copy of the License at:\n+ ~\n+ ~ http://www.apache.org/licenses/LICENSE-2.0\n+ ~\n+ ~ Unless required by applicable law or agreed to in writing, software\n+ ~ distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ ~ WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ ~ License for the specific language governing permissions and limitations\n+ ~ under the License.\n+ -->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+ xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd\">\n+ <modelVersion>4.0.0</modelVersion>\n+ <parent>\n+ <groupId>org.sonatype.oss</groupId>\n+ <artifactId>oss-parent</artifactId>\n+ <version>7</version>\n+ <relativePath></relativePath>\n+ </parent>\n+\n+ <groupId>io.netty</groupId>\n+ <artifactId>netty-dev-tools</artifactId>\n+ <version>4.1.8.Final-SNAPSHOT</version>","path":"dev-tools/pom.xml","position":29,"original_position":29,"commit_id":"84990386c410c29944526f499402e67ae8c9c20d","original_commit_id":"84990386c410c29944526f499402e67ae8c9c20d","user":{"login":"fenik17","id":20779569,"avatar_url":"https://avatars0.githubusercontent.com/u/20779569?v=3","gravatar_id":"","url":"https://api.github.com/users/fenik17","html_url":"https://github.com/fenik17","followers_url":"https://api.github.com/users/fenik17/followers","following_url":"https://api.github.com/users/fenik17/following{/other_user}","gists_url":"https://api.github.com/users/fenik17/gists{/gist_id}","starred_url":"https://api.github.com/users/fenik17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fenik17/subscriptions","organizations_url":"https://api.github.com/users/fenik17/orgs","repos_url":"https://api.github.com/users/fenik17/repos","events_url":"https://api.github.com/users/fenik17/events{/privacy}","received_events_url":"https://api.github.com/users/fenik17/received_events","type":"User","site_admin":false},"body":"4.1.10 at now.","created_at":"2017-04-20T10:58:34Z","updated_at":"2017-04-20T10:58:34Z","html_url":"https://github.com/netty/netty/pull/6224#discussion_r112424997","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6224","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/112424997"},"html":{"href":"https://github.com/netty/netty/pull/6224#discussion_r112424997"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6224"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6224","id":101748904,"html_url":"https://github.com/netty/netty/pull/6224","diff_url":"https://github.com/netty/netty/pull/6224.diff","patch_url":"https://github.com/netty/netty/pull/6224.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6224","number":6224,"state":"open","locked":false,"title":"Enable configuring available processors","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nIn cases when an application is running in a container or is otherwise constrained to the number of processors that it is using, the JVM invocation Runtime#availableProcessors will not return the constrained value but rather the number of processors available to the virtual machine. Netty uses this number in sizing various resources. Additionally, some applications will constrain the number of threads that they are using independenly of the number of processors available on the system. Thus, applications should have a way to globally configure the number of processors.\r\n\r\nModifications:\r\n\r\nRather than invoking Runtime#availableProcessors, Netty should rely on a method that enables configuration when the JVM is started or by the application. This commit exposes a new class NettyRuntime for enabling such configuraiton. This value can only be set once. Its default value is Runtime#availableProcessors so that there is no visible change to existing applications, but enables configuring either a system property or configuring during application startup (e.g., based on settings used to configure the application).\r\n\r\nAdditionally, we introduce the usage of forbidden-apis to prevent future uses of Runtime#availableProcessors from creeping. Future work should enable the bundled signatures and clean up uses of deprecated and other forbidden methods.\r\n\r\nResult:\r\n\r\nNetty can be configured to not use the underlying number of processors, but rather the constrained number of processors.\r\n","created_at":"2017-01-16T19:49:43Z","updated_at":"2017-04-20T10:58:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"565af271928a020643cd420119e79480e9e99bdd","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6224/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6224/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6224/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/84990386c410c29944526f499402e67ae8c9c20d","head":{"label":"jasontedor:available-processors","ref":"available-processors","sha":"84990386c410c29944526f499402e67ae8c9c20d","user":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"repo":{"id":62667953,"name":"netty","full_name":"jasontedor/netty","owner":{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasontedor/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/jasontedor/netty","forks_url":"https://api.github.com/repos/jasontedor/netty/forks","keys_url":"https://api.github.com/repos/jasontedor/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasontedor/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasontedor/netty/teams","hooks_url":"https://api.github.com/repos/jasontedor/netty/hooks","issue_events_url":"https://api.github.com/repos/jasontedor/netty/issues/events{/number}","events_url":"https://api.github.com/repos/jasontedor/netty/events","assignees_url":"https://api.github.com/repos/jasontedor/netty/assignees{/user}","branches_url":"https://api.github.com/repos/jasontedor/netty/branches{/branch}","tags_url":"https://api.github.com/repos/jasontedor/netty/tags","blobs_url":"https://api.github.com/repos/jasontedor/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasontedor/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasontedor/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasontedor/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasontedor/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/jasontedor/netty/languages","stargazers_url":"https://api.github.com/repos/jasontedor/netty/stargazers","contributors_url":"https://api.github.com/repos/jasontedor/netty/contributors","subscribers_url":"https://api.github.com/repos/jasontedor/netty/subscribers","subscription_url":"https://api.github.com/repos/jasontedor/netty/subscription","commits_url":"https://api.github.com/repos/jasontedor/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasontedor/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasontedor/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasontedor/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasontedor/netty/contents/{+path}","compare_url":"https://api.github.com/repos/jasontedor/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasontedor/netty/merges","archive_url":"https://api.github.com/repos/jasontedor/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasontedor/netty/downloads","issues_url":"https://api.github.com/repos/jasontedor/netty/issues{/number}","pulls_url":"https://api.github.com/repos/jasontedor/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/jasontedor/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/jasontedor/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasontedor/netty/labels{/name}","releases_url":"https://api.github.com/repos/jasontedor/netty/releases{/id}","deployments_url":"https://api.github.com/repos/jasontedor/netty/deployments","created_at":"2016-07-05T20:36:42Z","updated_at":"2016-07-05T20:36:54Z","pushed_at":"2017-04-20T09:53:38Z","git_url":"git://github.com/jasontedor/netty.git","ssh_url":"git@github.com:jasontedor/netty.git","clone_url":"https://github.com/jasontedor/netty.git","svn_url":"https://github.com/jasontedor/netty","homepage":"http://netty.io/","size":44659,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"970d310ec9ae3d0581adf48eec815d54e93b4960","user":{"login":"netty","id":473791,"avatar_url":"https://avatars2.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars2.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2017-04-20T09:33:54Z","pushed_at":"2017-04-20T09:53:40Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":46562,"stargazers_count":9730,"watchers_count":9730,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4768,"mirror_url":null,"open_issues_count":372,"forks":4768,"open_issues":372,"watchers":9730,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6224"},"html":{"href":"https://github.com/netty/netty/pull/6224"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6224"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6224/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6224/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6224/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/84990386c410c29944526f499402e67ae8c9c20d"}}}}
|
{
"id": 1064563,
"name": "netty/netty",
"url": "https://api.github.com/repos/netty/netty"
}
|
{
"id": 20779569,
"login": "fenik17",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20779569?",
"url": "https://api.github.com/users/fenik17"
}
|
{
"id": 473791,
"login": "netty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473791?",
"url": "https://api.github.com/orgs/netty"
}
| 2017-04-20T10:58:34 |
5723001424
|
{"actor":{"display_login":"fenik17"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/100395881","pull_request_review_id":21102711,"id":100395881,"diff_hunk":"@@ -504,6 +504,36 @@ public void testCancelClose() throws Exception {\n assertTrue(future.isCancelled());\n }\n \n+ @Test(expected = IllegalArgumentException.class)\n+ public void testWrongPromiseChannel() throws Exception {\n+ ChannelPipeline pipeline = new LocalChannel().pipeline();\n+ group.register(pipeline.channel());\n+\n+ ChannelPipeline pipeline2 = new LocalChannel().pipeline();\n+ group.register(pipeline2.channel());\n+\n+ ChannelPromise promise2 = pipeline2.channel().newPromise();\n+ pipeline.close(promise2);\n+ }\n+\n+ @Test(expected = IllegalArgumentException.class)\n+ public void testUnexpectedVoidChannelPromise() throws Exception {\n+ ChannelPipeline pipeline = new LocalChannel().pipeline();\n+ group.register(pipeline.channel());\n+\n+ ChannelPromise promise = new VoidChannelPromise(pipeline.channel(), false);\n+ pipeline.close(promise);\n+ }\n+\n+ @Test(expected = IllegalArgumentException.class)\n+ public void testUnexpectedVoidChannelPromiseCloseFuture() throws Exception {\n+ ChannelPipeline pipeline = new LocalChannel().pipeline();\n+ group.register(pipeline.channel());","path":"transport/src/test/java/io/netty/channel/DefaultChannelPipelineTest.java","position":28,"original_position":28,"commit_id":"0dcd0abfc708bff829ae80257fe412853b120e70","original_commit_id":"0dcd0abfc708bff829ae80257fe412853b120e70","user":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"body":"`.sync()`","created_at":"2017-02-09T19:49:17Z","updated_at":"2017-02-09T19:50:33Z","html_url":"https://github.com/netty/netty/pull/6339#discussion_r100395881","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/6339","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/100395881"},"html":{"href":"https://github.com/netty/netty/pull/6339#discussion_r100395881"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/6339"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/6339","id":105484090,"html_url":"https://github.com/netty/netty/pull/6339","diff_url":"https://github.com/netty/netty/pull/6339.diff","patch_url":"https://github.com/netty/netty/pull/6339.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/6339","number":6339,"state":"open","locked":false,"title":"Cleanup : validatePromise ranamed to isNotValidPromise with inverted state + tests","user":{"login":"doom369","id":1536494,"avatar_url":"https://avatars.githubusercontent.com/u/1536494?v=3","gravatar_id":"","url":"https://api.github.com/users/doom369","html_url":"https://github.com/doom369","followers_url":"https://api.github.com/users/doom369/followers","following_url":"https://api.github.com/users/doom369/following{/other_user}","gists_url":"https://api.github.com/users/doom369/gists{/gist_id}","starred_url":"https://api.github.com/users/doom369/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doom369/subscriptions","organizations_url":"https://api.github.com/users/doom369/orgs","repos_url":"https://api.github.com/users/doom369/repos","events_url":"https://api.github.com/users/doom369/events{/privacy}","received_events_url":"https://api.github.com/users/doom369/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nResult of `validatePromise()` is always inverted with `if (!validatePromise())`.\r\n\r\nModification:\r\n\r\n`validatePromise()` renamed to `isNotValidPromise()` and now returns inverted state so you don't need to invert state in conditions. Also name is now more meaningful according to returned result.\r\nAdded more tests for `validatePromise` corner cases with Exceptions.\r\n\r\nResult:\r\n\r\nCode easier to read. No need in inverted result.","created_at":"2017-02-09T18:17:34Z","updated_at":"2017-02-09T19:50:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a281713f155c0ff7792b26323aa8b95925ae4e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/6339/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/6339/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/6339/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/0dcd0abfc708bff829ae80257fe412853b120e70","head":{"label":"doom369:inverted_state","ref":"inverted_state","sha":"0dcd0abfc708bff829ae80257fe412853b120e70","user":{"login":"doom369","id":1536494,"avatar_url":"https://avatars.githubusercontent.com/u/1536494?v=3","gravatar_id":"","url":"https://api.github.com/users/doom369","html_url":"https://github.com/doom369","followers_url":"https://api.github.com/users/doom369/followers","following_url":"https://api.github.com/users/doom369/following{/other_user}","gists_url":"https://api.github.com/users/doom369/gists{/gist_id}","starred_url":"https://api.github.com/users/doom369/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doom369/subscriptions","organizations_url":"https://api.github.com/users/doom369/orgs","repos_url":"https://api.github.com/users/doom369/repos","events_url":"https://api.github.com/users/doom369/events{/privacy}","received_events_url":"https://api.github.com/users/doom369/received_events","type":"User","site_admin":false},"repo":{"id":64644770,"name":"netty","full_name":"doom369/netty","owner":{"login":"doom369","id":1536494,"avatar_url":"https://avatars.githubusercontent.com/u/1536494?v=3","gravatar_id":"","url":"https://api.github.com/users/doom369","html_url":"https://github.com/doom369","followers_url":"https://api.github.com/users/doom369/followers","following_url":"https://api.github.com/users/doom369/following{/other_user}","gists_url":"https://api.github.com/users/doom369/gists{/gist_id}","starred_url":"https://api.github.com/users/doom369/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doom369/subscriptions","organizations_url":"https://api.github.com/users/doom369/orgs","repos_url":"https://api.github.com/users/doom369/repos","events_url":"https://api.github.com/users/doom369/events{/privacy}","received_events_url":"https://api.github.com/users/doom369/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doom369/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/doom369/netty","forks_url":"https://api.github.com/repos/doom369/netty/forks","keys_url":"https://api.github.com/repos/doom369/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doom369/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doom369/netty/teams","hooks_url":"https://api.github.com/repos/doom369/netty/hooks","issue_events_url":"https://api.github.com/repos/doom369/netty/issues/events{/number}","events_url":"https://api.github.com/repos/doom369/netty/events","assignees_url":"https://api.github.com/repos/doom369/netty/assignees{/user}","branches_url":"https://api.github.com/repos/doom369/netty/branches{/branch}","tags_url":"https://api.github.com/repos/doom369/netty/tags","blobs_url":"https://api.github.com/repos/doom369/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doom369/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doom369/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/doom369/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doom369/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/doom369/netty/languages","stargazers_url":"https://api.github.com/repos/doom369/netty/stargazers","contributors_url":"https://api.github.com/repos/doom369/netty/contributors","subscribers_url":"https://api.github.com/repos/doom369/netty/subscribers","subscription_url":"https://api.github.com/repos/doom369/netty/subscription","commits_url":"https://api.github.com/repos/doom369/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/doom369/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/doom369/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/doom369/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/doom369/netty/contents/{+path}","compare_url":"https://api.github.com/repos/doom369/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doom369/netty/merges","archive_url":"https://api.github.com/repos/doom369/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doom369/netty/downloads","issues_url":"https://api.github.com/repos/doom369/netty/issues{/number}","pulls_url":"https://api.github.com/repos/doom369/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/doom369/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/doom369/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doom369/netty/labels{/name}","releases_url":"https://api.github.com/repos/doom369/netty/releases{/id}","deployments_url":"https://api.github.com/repos/doom369/netty/deployments","created_at":"2016-08-01T07:15:34Z","updated_at":"2016-08-01T07:15:46Z","pushed_at":"2017-02-09T18:11:04Z","git_url":"git://github.com/doom369/netty.git","ssh_url":"git@github.com:doom369/netty.git","clone_url":"https://github.com/doom369/netty.git","svn_url":"https://github.com/doom369/netty","homepage":"http://netty.io/","size":43815,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.1"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"d06990f43458e9ac7cea803269e83d072ada61f6","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","deployments_url":"https://api.github.com/repos/netty/netty/deployments","created_at":"2010-11-09T09:22:21Z","updated_at":"2017-02-09T15:02:43Z","pushed_at":"2017-02-09T18:17:34Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":45081,"stargazers_count":9040,"watchers_count":9040,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4460,"mirror_url":null,"open_issues_count":371,"forks":4460,"open_issues":371,"watchers":9040,"default_branch":"4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/6339"},"html":{"href":"https://github.com/netty/netty/pull/6339"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/6339"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/6339/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/6339/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/6339/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/0dcd0abfc708bff829ae80257fe412853b120e70"}}}}
|
{
"id": 1064563,
"name": "netty/netty",
"url": "https://api.github.com/repos/netty/netty"
}
|
{
"id": 439362,
"login": "normanmaurer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/439362?",
"url": "https://api.github.com/users/normanmaurer"
}
|
{
"id": 473791,
"login": "netty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473791?",
"url": "https://api.github.com/orgs/netty"
}
| 2017-02-09T19:49:17 |
5297927948
|
{"actor":{"display_login":"normanmaurer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/comments/150471332","pull_request_review_id":76023487,"id":150471332,"diff_hunk":"@@ -1063,16 +1055,46 @@ var UI = {\n UI.connect(null, UI.reconnect_password);\n },\n \n+ connectFinished: function (e) {\n+ UI.connected = true;\n+ UI.inhibit_reconnect = false;\n+ UI.doneInitialResize = false;\n+\n+ let msg;\n+ if (UI.getSetting('encrypt')) {\n+ msg = _(\"Connected (encrypted) to \") + UI.desktopName;\n+ } else {\n+ msg = _(\"Connected (unencrypted) to \") + UI.desktopName;\n+ }\n+ UI.showStatus(msg);\n+ document.getElementById('noVNC_canvas').focus();\n+\n+ UI.updateVisualState('connected');\n+ },\n+\n disconnectFinished: function (e) {\n+ // This variable is ideally set when disconnection starts, but\n+ // when the disconnection isn't clean or if it is initiated by\n+ // the server, we need to do it here as well since\n+ // UI.disconnect() won't be used in those cases.\n+ UI.connected = false;\n+\n if (typeof e.detail.reason !== 'undefined') {\n UI.showStatus(e.detail.reason, 'error');\n+ UI.updateVisualState('disconnected');\n+\n } else if (UI.getSetting('reconnect', false) === true && !UI.inhibit_reconnect) {\n- document.getElementById(\"noVNC_transition_text\").textContent = _(\"Reconnecting...\");\n- document.documentElement.classList.add(\"noVNC_reconnecting\");\n+","path":"app/ui.js","position":244,"original_position":153,"commit_id":"68c78f7993826a39ea09cbbb27a33ebdb8767a0d","original_commit_id":"118d92931196092bb4c647eff1822bae2900aeba","user":{"login":"CendioOssman","id":6640916,"avatar_url":"https://avatars1.githubusercontent.com/u/6640916?v=4","gravatar_id":"","url":"https://api.github.com/users/CendioOssman","html_url":"https://github.com/CendioOssman","followers_url":"https://api.github.com/users/CendioOssman/followers","following_url":"https://api.github.com/users/CendioOssman/following{/other_user}","gists_url":"https://api.github.com/users/CendioOssman/gists{/gist_id}","starred_url":"https://api.github.com/users/CendioOssman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CendioOssman/subscriptions","organizations_url":"https://api.github.com/users/CendioOssman/orgs","repos_url":"https://api.github.com/users/CendioOssman/repos","events_url":"https://api.github.com/users/CendioOssman/events{/privacy}","received_events_url":"https://api.github.com/users/CendioOssman/received_events","type":"User","site_admin":false},"body":"Extra blank lines in this general area","created_at":"2017-11-13T08:30:56Z","updated_at":"2017-11-13T08:43:20Z","html_url":"https://github.com/novnc/noVNC/pull/950#discussion_r150471332","pull_request_url":"https://api.github.com/repos/novnc/noVNC/pulls/950","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments/150471332"},"html":{"href":"https://github.com/novnc/noVNC/pull/950#discussion_r150471332"},"pull_request":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/950"}}},"pull_request":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/950","id":152082164,"html_url":"https://github.com/novnc/noVNC/pull/950","diff_url":"https://github.com/novnc/noVNC/pull/950.diff","patch_url":"https://github.com/novnc/noVNC/pull/950.patch","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/950","number":950,"state":"open","locked":false,"title":"Abstract information from RFB to the UI ","user":{"login":"samhed","id":4117162,"avatar_url":"https://avatars0.githubusercontent.com/u/4117162?v=4","gravatar_id":"","url":"https://api.github.com/users/samhed","html_url":"https://github.com/samhed","followers_url":"https://api.github.com/users/samhed/followers","following_url":"https://api.github.com/users/samhed/following{/other_user}","gists_url":"https://api.github.com/users/samhed/gists{/gist_id}","starred_url":"https://api.github.com/users/samhed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhed/subscriptions","organizations_url":"https://api.github.com/users/samhed/orgs","repos_url":"https://api.github.com/users/samhed/repos","events_url":"https://api.github.com/users/samhed/events{/privacy}","received_events_url":"https://api.github.com/users/samhed/received_events","type":"User","site_admin":false},"body":"We had a problem with strings being passed from RFB to UI using the notification and disconnect events. These were strings that were intended to be shown directly to the end user. Since these strings were defined in RFB the UI did not have control over translations.\r\n\r\nThis PR removes the `notification` event, and the `updatestate` event. It adds a `connect` event, a `securityfailure` event, and modifies the `disconnect` event:\r\n * The `notification` event was unnecessary and was easily replaced by logging\r\n * The `updatestate` event was being sent at alongside the `disconnect` event, causing unnecessary complexity for the applications. Applications do normally not have any use for the more detailed internal state information anyway.\r\n * There is now a `connect` event that works nicely with the `disconnect` event.\r\n * The `disconnect` event no longer includes a reason. Instead it includes a boolean that marks if the disconnection was clean (normal) or not clean (exited with errors).\r\n * A `securityfailure` event is now available for applications that want to display the security result failure string that can be sent directly from the server. One example of this is authentication failures. \r\n\r\nI still have to update the API documentation, but feel free to review.","created_at":"2017-11-12T00:34:09Z","updated_at":"2017-11-13T08:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17f4b57f04ea3cbafd1bcd34df871b8f5b8284e2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/novnc/noVNC/milestones/2","html_url":"https://github.com/novnc/noVNC/milestone/2","labels_url":"https://api.github.com/repos/novnc/noVNC/milestones/2/labels","id":2010059,"number":2,"title":"v0.7.0","description":"","creator":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":97,"state":"open","created_at":"2016-09-16T20:17:49Z","updated_at":"2017-11-12T00:34:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/novnc/noVNC/pulls/950/commits","review_comments_url":"https://api.github.com/repos/novnc/noVNC/pulls/950/comments","review_comment_url":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/950/comments","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/68c78f7993826a39ea09cbbb27a33ebdb8767a0d","head":{"label":"samhed:disconnectapi","ref":"disconnectapi","sha":"68c78f7993826a39ea09cbbb27a33ebdb8767a0d","user":{"login":"samhed","id":4117162,"avatar_url":"https://avatars0.githubusercontent.com/u/4117162?v=4","gravatar_id":"","url":"https://api.github.com/users/samhed","html_url":"https://github.com/samhed","followers_url":"https://api.github.com/users/samhed/followers","following_url":"https://api.github.com/users/samhed/following{/other_user}","gists_url":"https://api.github.com/users/samhed/gists{/gist_id}","starred_url":"https://api.github.com/users/samhed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhed/subscriptions","organizations_url":"https://api.github.com/users/samhed/orgs","repos_url":"https://api.github.com/users/samhed/repos","events_url":"https://api.github.com/users/samhed/events{/privacy}","received_events_url":"https://api.github.com/users/samhed/received_events","type":"User","site_admin":false},"repo":{"id":10818903,"name":"noVNC","full_name":"samhed/noVNC","owner":{"login":"samhed","id":4117162,"avatar_url":"https://avatars0.githubusercontent.com/u/4117162?v=4","gravatar_id":"","url":"https://api.github.com/users/samhed","html_url":"https://github.com/samhed","followers_url":"https://api.github.com/users/samhed/followers","following_url":"https://api.github.com/users/samhed/following{/other_user}","gists_url":"https://api.github.com/users/samhed/gists{/gist_id}","starred_url":"https://api.github.com/users/samhed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhed/subscriptions","organizations_url":"https://api.github.com/users/samhed/orgs","repos_url":"https://api.github.com/users/samhed/repos","events_url":"https://api.github.com/users/samhed/events{/privacy}","received_events_url":"https://api.github.com/users/samhed/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samhed/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/samhed/noVNC","forks_url":"https://api.github.com/repos/samhed/noVNC/forks","keys_url":"https://api.github.com/repos/samhed/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samhed/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samhed/noVNC/teams","hooks_url":"https://api.github.com/repos/samhed/noVNC/hooks","issue_events_url":"https://api.github.com/repos/samhed/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/samhed/noVNC/events","assignees_url":"https://api.github.com/repos/samhed/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/samhed/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/samhed/noVNC/tags","blobs_url":"https://api.github.com/repos/samhed/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samhed/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samhed/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/samhed/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samhed/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/samhed/noVNC/languages","stargazers_url":"https://api.github.com/repos/samhed/noVNC/stargazers","contributors_url":"https://api.github.com/repos/samhed/noVNC/contributors","subscribers_url":"https://api.github.com/repos/samhed/noVNC/subscribers","subscription_url":"https://api.github.com/repos/samhed/noVNC/subscription","commits_url":"https://api.github.com/repos/samhed/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/samhed/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/samhed/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/samhed/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/samhed/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/samhed/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samhed/noVNC/merges","archive_url":"https://api.github.com/repos/samhed/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samhed/noVNC/downloads","issues_url":"https://api.github.com/repos/samhed/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/samhed/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/samhed/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/samhed/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samhed/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/samhed/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/samhed/noVNC/deployments","created_at":"2013-06-20T12:04:59Z","updated_at":"2017-06-17T22:59:00Z","pushed_at":"2017-11-12T00:16:30Z","git_url":"git://github.com/samhed/noVNC.git","ssh_url":"git@github.com:samhed/noVNC.git","clone_url":"https://github.com/samhed/noVNC.git","svn_url":"https://github.com/samhed/noVNC","homepage":"novnc.com","size":13413,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"novnc:master","ref":"master","sha":"b8dfb983dfa44d4c6adfa70f6d216806619d72da","user":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"repo":{"id":598164,"name":"noVNC","full_name":"novnc/noVNC","owner":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novnc/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/novnc/noVNC","forks_url":"https://api.github.com/repos/novnc/noVNC/forks","keys_url":"https://api.github.com/repos/novnc/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novnc/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novnc/noVNC/teams","hooks_url":"https://api.github.com/repos/novnc/noVNC/hooks","issue_events_url":"https://api.github.com/repos/novnc/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/novnc/noVNC/events","assignees_url":"https://api.github.com/repos/novnc/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/novnc/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/novnc/noVNC/tags","blobs_url":"https://api.github.com/repos/novnc/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novnc/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novnc/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/novnc/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/novnc/noVNC/languages","stargazers_url":"https://api.github.com/repos/novnc/noVNC/stargazers","contributors_url":"https://api.github.com/repos/novnc/noVNC/contributors","subscribers_url":"https://api.github.com/repos/novnc/noVNC/subscribers","subscription_url":"https://api.github.com/repos/novnc/noVNC/subscription","commits_url":"https://api.github.com/repos/novnc/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/novnc/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/novnc/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/novnc/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/novnc/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/novnc/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novnc/noVNC/merges","archive_url":"https://api.github.com/repos/novnc/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novnc/noVNC/downloads","issues_url":"https://api.github.com/repos/novnc/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/novnc/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/novnc/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/novnc/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novnc/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/novnc/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/novnc/noVNC/deployments","created_at":"2010-04-07T01:55:44Z","updated_at":"2017-11-13T06:39:01Z","pushed_at":"2017-11-12T00:34:10Z","git_url":"git://github.com/novnc/noVNC.git","ssh_url":"git@github.com:novnc/noVNC.git","clone_url":"https://github.com/novnc/noVNC.git","svn_url":"https://github.com/novnc/noVNC","homepage":"novnc.com","size":8780,"stargazers_count":3807,"watchers_count":3807,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":833,"mirror_url":null,"archived":false,"open_issues_count":51,"forks":833,"open_issues":51,"watchers":3807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/950"},"html":{"href":"https://github.com/novnc/noVNC/pull/950"},"issue":{"href":"https://api.github.com/repos/novnc/noVNC/issues/950"},"comments":{"href":"https://api.github.com/repos/novnc/noVNC/issues/950/comments"},"review_comments":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/950/comments"},"review_comment":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/950/commits"},"statuses":{"href":"https://api.github.com/repos/novnc/noVNC/statuses/68c78f7993826a39ea09cbbb27a33ebdb8767a0d"}},"author_association":"MEMBER"}}
|
{
"id": 598164,
"name": "novnc/noVNC",
"url": "https://api.github.com/repos/novnc/noVNC"
}
|
{
"id": 6640916,
"login": "CendioOssman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6640916?",
"url": "https://api.github.com/users/CendioOssman"
}
|
{
"id": 24572588,
"login": "novnc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24572588?",
"url": "https://api.github.com/orgs/novnc"
}
| 2017-11-13T08:30:56 |
6845544304
|
{"actor":{"display_login":"CendioOssman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/comments/147496801","pull_request_review_id":72606157,"id":147496801,"diff_hunk":"@@ -0,0 +1,45 @@\n+/*\n+ * noVNC: HTML5 VNC client\n+ * Copyright 2017 Pierre Ossman for Cendio AB\n+ * Licensed under MPL 2.0 (see LICENSE.txt)\n+ *\n+ * See README.md for usage and integration instructions.\n+ */\n+\n+export var EventTargetMixin = {","path":"core/util/eventtarget.js","position":9,"original_position":9,"commit_id":"e3a1c0ed048712270779c59fbe6afbd39ebd1534","original_commit_id":"e3a1c0ed048712270779c59fbe6afbd39ebd1534","user":{"login":"DirectXMan12","id":119737,"avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"body":"just `export default` this","created_at":"2017-10-27T19:24:46Z","updated_at":"2017-10-27T19:30:48Z","html_url":"https://github.com/novnc/noVNC/pull/927#discussion_r147496801","pull_request_url":"https://api.github.com/repos/novnc/noVNC/pulls/927","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments/147496801"},"html":{"href":"https://github.com/novnc/noVNC/pull/927#discussion_r147496801"},"pull_request":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/927"}}},"pull_request":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/927","id":146448960,"html_url":"https://github.com/novnc/noVNC/pull/927","diff_url":"https://github.com/novnc/noVNC/pull/927.diff","patch_url":"https://github.com/novnc/noVNC/pull/927.patch","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/927","number":927,"state":"open","locked":false,"title":"[WIP] Adjust public API","user":{"login":"CendioOssman","id":6640916,"avatar_url":"https://avatars1.githubusercontent.com/u/6640916?v=4","gravatar_id":"","url":"https://api.github.com/users/CendioOssman","html_url":"https://github.com/CendioOssman","followers_url":"https://api.github.com/users/CendioOssman/followers","following_url":"https://api.github.com/users/CendioOssman/following{/other_user}","gists_url":"https://api.github.com/users/CendioOssman/gists{/gist_id}","starred_url":"https://api.github.com/users/CendioOssman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CendioOssman/subscriptions","organizations_url":"https://api.github.com/users/CendioOssman/orgs","repos_url":"https://api.github.com/users/CendioOssman/repos","events_url":"https://api.github.com/users/CendioOssman/events{/privacy}","received_events_url":"https://api.github.com/users/CendioOssman/received_events","type":"User","site_admin":false},"body":"These are the changes I'd like to make before closing #924 and releasing 1.0. I'm still looking over things, but this branch should include what I've found so far.","created_at":"2017-10-13T12:49:54Z","updated_at":"2017-10-27T19:30:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ab38e806b77828ac2abc2ddfd4843195b6aad3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/novnc/noVNC/pulls/927/commits","review_comments_url":"https://api.github.com/repos/novnc/noVNC/pulls/927/comments","review_comment_url":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/927/comments","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/e3a1c0ed048712270779c59fbe6afbd39ebd1534","head":{"label":"CendioOssman:api","ref":"api","sha":"e3a1c0ed048712270779c59fbe6afbd39ebd1534","user":{"login":"CendioOssman","id":6640916,"avatar_url":"https://avatars1.githubusercontent.com/u/6640916?v=4","gravatar_id":"","url":"https://api.github.com/users/CendioOssman","html_url":"https://github.com/CendioOssman","followers_url":"https://api.github.com/users/CendioOssman/followers","following_url":"https://api.github.com/users/CendioOssman/following{/other_user}","gists_url":"https://api.github.com/users/CendioOssman/gists{/gist_id}","starred_url":"https://api.github.com/users/CendioOssman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CendioOssman/subscriptions","organizations_url":"https://api.github.com/users/CendioOssman/orgs","repos_url":"https://api.github.com/users/CendioOssman/repos","events_url":"https://api.github.com/users/CendioOssman/events{/privacy}","received_events_url":"https://api.github.com/users/CendioOssman/received_events","type":"User","site_admin":false},"repo":{"id":67400601,"name":"noVNC","full_name":"CendioOssman/noVNC","owner":{"login":"CendioOssman","id":6640916,"avatar_url":"https://avatars1.githubusercontent.com/u/6640916?v=4","gravatar_id":"","url":"https://api.github.com/users/CendioOssman","html_url":"https://github.com/CendioOssman","followers_url":"https://api.github.com/users/CendioOssman/followers","following_url":"https://api.github.com/users/CendioOssman/following{/other_user}","gists_url":"https://api.github.com/users/CendioOssman/gists{/gist_id}","starred_url":"https://api.github.com/users/CendioOssman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CendioOssman/subscriptions","organizations_url":"https://api.github.com/users/CendioOssman/orgs","repos_url":"https://api.github.com/users/CendioOssman/repos","events_url":"https://api.github.com/users/CendioOssman/events{/privacy}","received_events_url":"https://api.github.com/users/CendioOssman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CendioOssman/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/CendioOssman/noVNC","forks_url":"https://api.github.com/repos/CendioOssman/noVNC/forks","keys_url":"https://api.github.com/repos/CendioOssman/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CendioOssman/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CendioOssman/noVNC/teams","hooks_url":"https://api.github.com/repos/CendioOssman/noVNC/hooks","issue_events_url":"https://api.github.com/repos/CendioOssman/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/CendioOssman/noVNC/events","assignees_url":"https://api.github.com/repos/CendioOssman/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/CendioOssman/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/CendioOssman/noVNC/tags","blobs_url":"https://api.github.com/repos/CendioOssman/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CendioOssman/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CendioOssman/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/CendioOssman/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CendioOssman/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/CendioOssman/noVNC/languages","stargazers_url":"https://api.github.com/repos/CendioOssman/noVNC/stargazers","contributors_url":"https://api.github.com/repos/CendioOssman/noVNC/contributors","subscribers_url":"https://api.github.com/repos/CendioOssman/noVNC/subscribers","subscription_url":"https://api.github.com/repos/CendioOssman/noVNC/subscription","commits_url":"https://api.github.com/repos/CendioOssman/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/CendioOssman/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/CendioOssman/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/CendioOssman/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/CendioOssman/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/CendioOssman/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CendioOssman/noVNC/merges","archive_url":"https://api.github.com/repos/CendioOssman/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CendioOssman/noVNC/downloads","issues_url":"https://api.github.com/repos/CendioOssman/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/CendioOssman/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/CendioOssman/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/CendioOssman/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CendioOssman/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/CendioOssman/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/CendioOssman/noVNC/deployments","created_at":"2016-09-05T08:05:02Z","updated_at":"2017-03-30T14:24:35Z","pushed_at":"2017-10-27T12:39:26Z","git_url":"git://github.com/CendioOssman/noVNC.git","ssh_url":"git@github.com:CendioOssman/noVNC.git","clone_url":"https://github.com/CendioOssman/noVNC.git","svn_url":"https://github.com/CendioOssman/noVNC","homepage":"novnc.com","size":7475,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"novnc:master","ref":"master","sha":"fc64213cecbe08db2b1eb88fddf592ec1ba230cc","user":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"repo":{"id":598164,"name":"noVNC","full_name":"novnc/noVNC","owner":{"login":"novnc","id":24572588,"avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novnc/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/novnc/noVNC","forks_url":"https://api.github.com/repos/novnc/noVNC/forks","keys_url":"https://api.github.com/repos/novnc/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novnc/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novnc/noVNC/teams","hooks_url":"https://api.github.com/repos/novnc/noVNC/hooks","issue_events_url":"https://api.github.com/repos/novnc/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/novnc/noVNC/events","assignees_url":"https://api.github.com/repos/novnc/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/novnc/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/novnc/noVNC/tags","blobs_url":"https://api.github.com/repos/novnc/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novnc/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novnc/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/novnc/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/novnc/noVNC/languages","stargazers_url":"https://api.github.com/repos/novnc/noVNC/stargazers","contributors_url":"https://api.github.com/repos/novnc/noVNC/contributors","subscribers_url":"https://api.github.com/repos/novnc/noVNC/subscribers","subscription_url":"https://api.github.com/repos/novnc/noVNC/subscription","commits_url":"https://api.github.com/repos/novnc/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/novnc/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/novnc/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/novnc/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/novnc/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/novnc/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novnc/noVNC/merges","archive_url":"https://api.github.com/repos/novnc/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novnc/noVNC/downloads","issues_url":"https://api.github.com/repos/novnc/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/novnc/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/novnc/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/novnc/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novnc/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/novnc/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/novnc/noVNC/deployments","created_at":"2010-04-07T01:55:44Z","updated_at":"2017-10-27T14:08:12Z","pushed_at":"2017-10-27T12:39:28Z","git_url":"git://github.com/novnc/noVNC.git","ssh_url":"git@github.com:novnc/noVNC.git","clone_url":"https://github.com/novnc/noVNC.git","svn_url":"https://github.com/novnc/noVNC","homepage":"novnc.com","size":8740,"stargazers_count":3776,"watchers_count":3776,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":819,"mirror_url":null,"archived":false,"open_issues_count":59,"forks":819,"open_issues":59,"watchers":3776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/927"},"html":{"href":"https://github.com/novnc/noVNC/pull/927"},"issue":{"href":"https://api.github.com/repos/novnc/noVNC/issues/927"},"comments":{"href":"https://api.github.com/repos/novnc/noVNC/issues/927/comments"},"review_comments":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/927/comments"},"review_comment":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/927/commits"},"statuses":{"href":"https://api.github.com/repos/novnc/noVNC/statuses/e3a1c0ed048712270779c59fbe6afbd39ebd1534"}},"author_association":"MEMBER"}}
|
{
"id": 598164,
"name": "novnc/noVNC",
"url": "https://api.github.com/repos/novnc/noVNC"
}
|
{
"id": 119737,
"login": "DirectXMan12",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/119737?",
"url": "https://api.github.com/users/DirectXMan12"
}
|
{
"id": 24572588,
"login": "novnc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24572588?",
"url": "https://api.github.com/orgs/novnc"
}
| 2017-10-27T19:24:46 |
6776844523
|
{"actor":{"display_login":"DirectXMan12"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/157385371","pull_request_review_id":84016948,"id":157385371,"diff_hunk":"@@ -414,20 +414,23 @@ PyArray_PrepareThreeRawArrayIter(int ndim, npy_intp *shape,\n char **out_dataC, npy_intp *out_stridesC);\n \n /*\n- * Return number of elements that must be peeled from\n- * the start of 'addr' with 'nvals' elements of size 'esize'\n- * in order to reach 'alignment'.\n- * alignment must be a power of two.\n- * see npy_blocked_end for an example\n+ * Return number of elements that must be peeled from the start of 'addr' with\n+ * 'nvals' elements of size 'esize' in order to reach 'alignment'. alignment\n+ * must be a power of two. see npy_blocked_end for an example\n */\n-static NPY_INLINE npy_uintp\n+static NPY_INLINE npy_intp\n npy_aligned_block_offset(const void * addr, const npy_uintp esize,\n- const npy_uintp alignment, const npy_uintp nvals)\n+ const npy_uintp alignment, const npy_intp nvals)","path":"numpy/core/src/private/lowlevel_strided_loops.h","position":17,"original_position":17,"commit_id":"cd8b57d9546ffc098286fd36278d5339098e7ff5","original_commit_id":"cd8b57d9546ffc098286fd36278d5339098e7ff5","user":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"I feel just the opposite, unsigned integers are a PITA and should be avoided ;) ","created_at":"2017-12-18T00:23:05Z","updated_at":"2017-12-18T00:23:05Z","html_url":"https://github.com/numpy/numpy/pull/10224#discussion_r157385371","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/10224","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/157385371"},"html":{"href":"https://github.com/numpy/numpy/pull/10224#discussion_r157385371"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10224"}},"in_reply_to_id":157384923},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/10224","id":158768969,"html_url":"https://github.com/numpy/numpy/pull/10224","diff_url":"https://github.com/numpy/numpy/pull/10224.diff","patch_url":"https://github.com/numpy/numpy/pull/10224.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/10224","number":10224,"state":"open","locked":false,"title":"BUG: Fix signed-unsigned comparison warnings in simd.inc.src.","user":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"As stated. Travis CI has changed the default warnings and these now show up, so this is needed as part of the fix for the NumPy daily builds.\r\n\r\nThis is not a big patch, I broke it out of a larger set of patches as it requires some cogitation about the choices made. It also fixes the majority of the warnings. It may or may not need a backport, we will see.","created_at":"2017-12-17T02:47:52Z","updated_at":"2017-12-18T00:23:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c4f9ea33350c6a8d87b77fbb78e5607463d9896","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/10224/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/10224/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/10224/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/cd8b57d9546ffc098286fd36278d5339098e7ff5","head":{"label":"charris:fix-simd-warnings","ref":"fix-simd-warnings","sha":"cd8b57d9546ffc098286fd36278d5339098e7ff5","user":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"repo":{"id":908701,"name":"numpy","full_name":"charris/numpy","owner":{"login":"charris","id":77272,"avatar_url":"https://avatars3.githubusercontent.com/u/77272?v=4","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/charris/numpy","description":"Fork of numpy/numpy","fork":true,"url":"https://api.github.com/repos/charris/numpy","forks_url":"https://api.github.com/repos/charris/numpy/forks","keys_url":"https://api.github.com/repos/charris/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/charris/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/charris/numpy/teams","hooks_url":"https://api.github.com/repos/charris/numpy/hooks","issue_events_url":"https://api.github.com/repos/charris/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/charris/numpy/events","assignees_url":"https://api.github.com/repos/charris/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/charris/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/charris/numpy/tags","blobs_url":"https://api.github.com/repos/charris/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/charris/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/charris/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/charris/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/charris/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/charris/numpy/languages","stargazers_url":"https://api.github.com/repos/charris/numpy/stargazers","contributors_url":"https://api.github.com/repos/charris/numpy/contributors","subscribers_url":"https://api.github.com/repos/charris/numpy/subscribers","subscription_url":"https://api.github.com/repos/charris/numpy/subscription","commits_url":"https://api.github.com/repos/charris/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/charris/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/charris/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/charris/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/charris/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/charris/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/charris/numpy/merges","archive_url":"https://api.github.com/repos/charris/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/charris/numpy/downloads","issues_url":"https://api.github.com/repos/charris/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/charris/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/charris/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/charris/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/charris/numpy/labels{/name}","releases_url":"https://api.github.com/repos/charris/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/charris/numpy/deployments","created_at":"2010-09-13T23:57:46Z","updated_at":"2015-05-02T19:17:10Z","pushed_at":"2017-12-17T23:50:34Z","git_url":"git://github.com/charris/numpy.git","ssh_url":"git@github.com:charris/numpy.git","clone_url":"https://github.com/charris/numpy.git","svn_url":"https://github.com/charris/numpy","homepage":"","size":53166,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"9d054c141b084546810486f91e763f3eb89af633","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2017-12-17T23:03:22Z","pushed_at":"2017-12-18T00:21:18Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":54407,"stargazers_count":5961,"watchers_count":5961,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2441,"mirror_url":null,"archived":false,"open_issues_count":1724,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2441,"open_issues":1724,"watchers":5961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10224"},"html":{"href":"https://github.com/numpy/numpy/pull/10224"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/10224"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/10224/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10224/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/10224/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/cd8b57d9546ffc098286fd36278d5339098e7ff5"}},"author_association":"OWNER"}}
|
{
"id": 908607,
"name": "numpy/numpy",
"url": "https://api.github.com/repos/numpy/numpy"
}
|
{
"id": 77272,
"login": "charris",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/77272?",
"url": "https://api.github.com/users/charris"
}
|
{
"id": 288276,
"login": "numpy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/288276?",
"url": "https://api.github.com/orgs/numpy"
}
| 2017-12-18T00:23:05 |
6999934281
|
{"actor":{"display_login":"charris"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nunit/nunit/pulls/comments/149565932","pull_request_review_id":74980194,"id":149565932,"diff_hunk":"@@ -31,7 +31,7 @@ namespace NUnit.Framework.Internal\n /// other selected parameters needed for constructing\n /// a parameterized test case.\n /// </summary>\n- public class TestCaseParameters : TestParameters, ITestCaseData, IApplyToTest\n+ public class TestCaseParameters : TestParameters, ITestCaseData","path":"src/NUnitFramework/framework/Internal/TestCaseParameters.cs","position":5,"original_position":5,"commit_id":"220e00a2b50df4120d110056fc0e9f1f9140b7a9","original_commit_id":"e1a5d2c0e2dcd3a8ebcfa067d297cb03aec4a9b8","user":{"login":"CharliePoole","id":2678661,"avatar_url":"https://avatars2.githubusercontent.com/u/2678661?v=4","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"body":"I agree that the way the code is written currently is wrong. It's not how any other attribute or object works. The `TestCaseParameters` object should decide what to do in it's ApplyToTest method __if anything__ and the method should always be called. But ApplyToTest should not be responsible for the __default__ name. That should just be there before it is ever called.\r\n\r\nIt's true that doing it that way causes the name to be set twice, but that doesn't seem to have caused any problems up to now.\r\n","created_at":"2017-11-08T03:15:00Z","updated_at":"2017-11-08T03:15:00Z","html_url":"https://github.com/nunit/nunit/pull/2538#discussion_r149565932","pull_request_url":"https://api.github.com/repos/nunit/nunit/pulls/2538","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments/149565932"},"html":{"href":"https://github.com/nunit/nunit/pull/2538#discussion_r149565932"},"pull_request":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2538"}},"in_reply_to_id":149476052},"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2538","id":151023580,"html_url":"https://github.com/nunit/nunit/pull/2538","diff_url":"https://github.com/nunit/nunit/pull/2538.diff","patch_url":"https://github.com/nunit/nunit/pull/2538.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2538","number":2538,"state":"open","locked":false,"title":"TestCaseData.SetArgNames (and TestFixtureData)","user":{"login":"jnm2","id":8040367,"avatar_url":"https://avatars2.githubusercontent.com/u/8040367?v=4","gravatar_id":"","url":"https://api.github.com/users/jnm2","html_url":"https://github.com/jnm2","followers_url":"https://api.github.com/users/jnm2/followers","following_url":"https://api.github.com/users/jnm2/following{/other_user}","gists_url":"https://api.github.com/users/jnm2/gists{/gist_id}","starred_url":"https://api.github.com/users/jnm2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnm2/subscriptions","organizations_url":"https://api.github.com/users/jnm2/orgs","repos_url":"https://api.github.com/users/jnm2/repos","events_url":"https://api.github.com/users/jnm2/events{/privacy}","received_events_url":"https://api.github.com/users/jnm2/received_events","type":"User","site_admin":false},"body":"Still looking for a good way to write tests on TestCaseData and TestFixtureData custom names.\r\n\r\nMeanwhile, I believe this is the entire implementation; please review. See the TestNameGeneratorTests for a quick intro to the approach I took. Walking through the commits one by one could help because they are separable.\r\n\r\nI also added it to TestFixtureData which made it super easy to make `TestFixtureData.SetName` consistent with `TestCaseData` with name generation. Expansions will work. This is something we should discuss and agree on before `TestFixtureData.SetName` makes its debut in 3.9. /cc @rprouse @CharliePoole \r\n\r\nAPI changes:\r\n\r\n```diff\r\nnamespace NUnit.Framework\r\n{\r\n- public class TestCaseData : TestCaseParameters, ITestCaseData, IApplyToTest\r\n+ public class TestCaseData : TestCaseParameters, ITestCaseData\r\n {\r\n+ public TestCaseData SetArgNames(params string[] displayNames);\r\n }\r\n\r\n- public class TestFixtureData : TestFixtureParameters, ITestFixtureData, IApplyToTest\r\n+ public class TestFixtureData : TestFixtureParameters, ITestFixtureData\r\n {\r\n+ public TestFixtureData SetArgNames(params string[] displayNames);\r\n }\r\n}\r\nnamespace NUnit.Framework.Internal\r\n{\r\n- public class TestParameters : ITestData, IApplyToTest\r\n+ public class TestParameters : ITestData\r\n {\r\n+ protected string[] ArgNames { set; }\r\n\r\n- public void ApplyToTest(Test test)\r\n+ public void ApplyToTest(Test test, TestNameGenerator defaultTestNameGenerator)\r\n }\r\n\r\n- public class TestCaseParameters : TestParameters, ITestCaseData, IApplyToTest\r\n+ public class TestCaseParameters : TestParameters, ITestCaseData\r\n {\r\n }\r\n\r\n- public class TestFixtureParameters : TestParameters, ITestFixtureData, IApplyToTest\r\n+ public class TestFixtureParameters : TestParameters, ITestFixtureData\r\n {\r\n }\r\n}\r\n```","created_at":"2017-11-07T04:38:20Z","updated_at":"2017-11-08T03:15:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dac5e12218d5b751497d30166c7a642394f590b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/2538/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/2538/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2538/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/220e00a2b50df4120d110056fc0e9f1f9140b7a9","head":{"label":"nunit:SetArgNames","ref":"SetArgNames","sha":"220e00a2b50df4120d110056fc0e9f1f9140b7a9","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2017-11-06T17:28:59Z","pushed_at":"2017-11-08T03:00:32Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":42766,"stargazers_count":1130,"watchers_count":1130,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":245,"forks":442,"open_issues":245,"watchers":1130,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"07d719b6851b8889934971152fb44e015b045961","user":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2017-11-06T17:28:59Z","pushed_at":"2017-11-08T03:00:32Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":42766,"stargazers_count":1130,"watchers_count":1130,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":442,"mirror_url":null,"archived":false,"open_issues_count":245,"forks":442,"open_issues":245,"watchers":1130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2538"},"html":{"href":"https://github.com/nunit/nunit/pull/2538"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/2538"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/2538/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2538/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2538/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/220e00a2b50df4120d110056fc0e9f1f9140b7a9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 13692183,
"name": "nunit/nunit",
"url": "https://api.github.com/repos/nunit/nunit"
}
|
{
"id": 2678661,
"login": "CharliePoole",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2678661?",
"url": "https://api.github.com/users/CharliePoole"
}
|
{
"id": 2678858,
"login": "nunit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2678858?",
"url": "https://api.github.com/orgs/nunit"
}
| 2017-11-08T03:15:00 |
6824009642
|
{"actor":{"display_login":"CharliePoole"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/124275522","pull_request_review_id":46549467,"id":124275522,"diff_hunk":"@@ -169,6 +169,10 @@ chapter~\\ref{c:intf-c}.\n Never use the \"strip\" command on executables produced by \"ocamlc -custom\",\n this would remove the bytecode part of the executable.\n \\end{unix}\n+\\begin{unix}\n+Security warning: never set the \"setuid\" or \"setgid\" bits on executables","path":"manual/manual/cmds/unified-options.etex","position":5,"original_position":5,"commit_id":"a9b511b8af04a9e13f4486f18b0b286c827d9947","original_commit_id":"a9b511b8af04a9e13f4486f18b0b286c827d9947","user":{"login":"xavierleroy","id":3845810,"avatar_url":"https://avatars3.githubusercontent.com/u/3845810?v=3","gravatar_id":"","url":"https://api.github.com/users/xavierleroy","html_url":"https://github.com/xavierleroy","followers_url":"https://api.github.com/users/xavierleroy/followers","following_url":"https://api.github.com/users/xavierleroy/following{/other_user}","gists_url":"https://api.github.com/users/xavierleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/xavierleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavierleroy/subscriptions","organizations_url":"https://api.github.com/users/xavierleroy/orgs","repos_url":"https://api.github.com/users/xavierleroy/repos","events_url":"https://api.github.com/users/xavierleroy/events{/privacy}","received_events_url":"https://api.github.com/users/xavierleroy/received_events","type":"User","site_admin":false},"body":"The double quotes around \"setuid\" causes this word to be typeset in \\tt font. This is probably not what you want. Consider ``setuid'' instead. Likewise for setgid.","created_at":"2017-06-27T13:39:12Z","updated_at":"2017-06-27T13:39:13Z","html_url":"https://github.com/ocaml/ocaml/pull/1213#discussion_r124275522","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1213","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/124275522"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1213#discussion_r124275522"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1213","id":127490207,"html_url":"https://github.com/ocaml/ocaml/pull/1213","diff_url":"https://github.com/ocaml/ocaml/pull/1213.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1213.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1213","number":1213,"state":"open","locked":false,"title":"Some tweaks for MPR#7557","user":{"login":"damiendoligez","id":19104,"avatar_url":"https://avatars1.githubusercontent.com/u/19104?v=3","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"body":"For the first commit, @setharnold pointed out in https://github.com/ocaml/ocaml/commit/38e2cd6a580e5b14a503f34d5ca7709d190c36a3#commitcomment-22736369 that `secure_getenv` is a \"relatively new\" addition to glibc (introduced in 2012 with glibc 2.17). This PR adds a fall-back to `__secure_getenv`, which dates back (at least) to 2002 with glibc 2.2.5.\r\n\r\nreferences:\r\n* https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=708061 -- shows that `__secure_getenv` was in glibc 2.2.5\r\n* https://sourceware.org/glibc/wiki/Glibc%20Timeline -- glibc release timeline\r\n\r\n\r\nThe second commit secures one more call to `getenv` in the Spacetime code. Although you'd be crazy to set the setuid bit on a program compiled with instrumentation, I think it's better to fix this potential vulnerability (reported privately by Eric Milliken).\r\n\r\n\r\nThe third commit is a change in the manual to warn users against setting the setuid bit on a custom-mode bytecode executable because this configuration is always vulnerable to privilege escalation attacks.\r\n","created_at":"2017-06-26T14:56:19Z","updated_at":"2017-06-27T13:39:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45c0d2516345d33969a541f29dd7f25e6647a901","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/ocaml/ocaml/milestones/9","html_url":"https://github.com/ocaml/ocaml/milestone/9","labels_url":"https://api.github.com/repos/ocaml/ocaml/milestones/9/labels","id":2127013,"number":9,"title":"4.05.0","description":"next major release\r\n","creator":{"login":"damiendoligez","id":19104,"avatar_url":"https://avatars1.githubusercontent.com/u/19104?v=3","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":27,"state":"open","created_at":"2016-11-10T12:58:17Z","updated_at":"2017-06-26T14:56:19Z","due_on":"2017-02-01T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1213/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/a9b511b8af04a9e13f4486f18b0b286c827d9947","head":{"label":"damiendoligez:more-secure-getenv","ref":"more-secure-getenv","sha":"a9b511b8af04a9e13f4486f18b0b286c827d9947","user":{"login":"damiendoligez","id":19104,"avatar_url":"https://avatars1.githubusercontent.com/u/19104?v=3","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"repo":{"id":26542075,"name":"ocaml","full_name":"damiendoligez/ocaml","owner":{"login":"damiendoligez","id":19104,"avatar_url":"https://avatars1.githubusercontent.com/u/19104?v=3","gravatar_id":"","url":"https://api.github.com/users/damiendoligez","html_url":"https://github.com/damiendoligez","followers_url":"https://api.github.com/users/damiendoligez/followers","following_url":"https://api.github.com/users/damiendoligez/following{/other_user}","gists_url":"https://api.github.com/users/damiendoligez/gists{/gist_id}","starred_url":"https://api.github.com/users/damiendoligez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damiendoligez/subscriptions","organizations_url":"https://api.github.com/users/damiendoligez/orgs","repos_url":"https://api.github.com/users/damiendoligez/repos","events_url":"https://api.github.com/users/damiendoligez/events{/privacy}","received_events_url":"https://api.github.com/users/damiendoligez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damiendoligez/ocaml","description":"New experimental features for OCaml","fork":true,"url":"https://api.github.com/repos/damiendoligez/ocaml","forks_url":"https://api.github.com/repos/damiendoligez/ocaml/forks","keys_url":"https://api.github.com/repos/damiendoligez/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damiendoligez/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damiendoligez/ocaml/teams","hooks_url":"https://api.github.com/repos/damiendoligez/ocaml/hooks","issue_events_url":"https://api.github.com/repos/damiendoligez/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/damiendoligez/ocaml/events","assignees_url":"https://api.github.com/repos/damiendoligez/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/damiendoligez/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/damiendoligez/ocaml/tags","blobs_url":"https://api.github.com/repos/damiendoligez/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damiendoligez/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damiendoligez/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/damiendoligez/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damiendoligez/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/damiendoligez/ocaml/languages","stargazers_url":"https://api.github.com/repos/damiendoligez/ocaml/stargazers","contributors_url":"https://api.github.com/repos/damiendoligez/ocaml/contributors","subscribers_url":"https://api.github.com/repos/damiendoligez/ocaml/subscribers","subscription_url":"https://api.github.com/repos/damiendoligez/ocaml/subscription","commits_url":"https://api.github.com/repos/damiendoligez/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/damiendoligez/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/damiendoligez/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/damiendoligez/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/damiendoligez/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/damiendoligez/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damiendoligez/ocaml/merges","archive_url":"https://api.github.com/repos/damiendoligez/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damiendoligez/ocaml/downloads","issues_url":"https://api.github.com/repos/damiendoligez/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/damiendoligez/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/damiendoligez/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/damiendoligez/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damiendoligez/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/damiendoligez/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/damiendoligez/ocaml/deployments","created_at":"2014-11-12T15:23:58Z","updated_at":"2016-03-20T12:49:23Z","pushed_at":"2017-06-27T13:19:14Z","git_url":"git://github.com/damiendoligez/ocaml.git","ssh_url":"git@github.com:damiendoligez/ocaml.git","clone_url":"https://github.com/damiendoligez/ocaml.git","svn_url":"https://github.com/damiendoligez/ocaml","homepage":"","size":157171,"stargazers_count":3,"watchers_count":3,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"4.02.1-vanilla"}},"base":{"label":"ocaml:4.05","ref":"4.05","sha":"d4972ea1d3f21deec0566d7bcf9c44f20a6f776f","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars0.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars0.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2017-06-26T05:58:57Z","pushed_at":"2017-06-27T13:19:16Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":143701,"stargazers_count":1341,"watchers_count":1341,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":138,"forks":367,"open_issues":138,"watchers":1341,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1213"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1213"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1213"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/a9b511b8af04a9e13f4486f18b0b286c827d9947"}}}}
|
{
"id": 6786166,
"name": "ocaml/ocaml",
"url": "https://api.github.com/repos/ocaml/ocaml"
}
|
{
"id": 3845810,
"login": "xavierleroy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3845810?",
"url": "https://api.github.com/users/xavierleroy"
}
|
{
"id": 1841483,
"login": "ocaml",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1841483?",
"url": "https://api.github.com/orgs/ocaml"
}
| 2017-06-27T13:39:12 |
6146319408
|
{"actor":{"display_login":"xavierleroy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/136394641","pull_request_review_id":59928823,"id":136394641,"diff_hunk":"@@ -294,6 +294,17 @@ external open_desc : string -> open_flag list -> int -> int = \"caml_sys_open\"\n external set_out_channel_name: out_channel -> string -> unit =\n \"caml_ml_set_channel_name\"\n \n+(* [finally_ f g x] calls [f x], but takes care of always calling [g x]\n+ whether [f] raises or returns *)\n+let finally_ f g x =\n+ try\n+ let res = f x in\n+ g x;\n+ res\n+ with e ->\n+ g x;\n+ raise e\n+\n let open_out_gen mode perm name =","path":"stdlib/pervasives.ml","position":null,"original_position":15,"commit_id":"c61dd6b7748298ae45c88877feaaae43e6da1010","original_commit_id":"cfb0c6faeec8e2de3e4dfa8697e06849e34222af","user":{"login":"mseri","id":4040623,"avatar_url":"https://avatars0.githubusercontent.com/u/4040623?v=4","gravatar_id":"","url":"https://api.github.com/users/mseri","html_url":"https://github.com/mseri","followers_url":"https://api.github.com/users/mseri/followers","following_url":"https://api.github.com/users/mseri/following{/other_user}","gists_url":"https://api.github.com/users/mseri/gists{/gist_id}","starred_url":"https://api.github.com/users/mseri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseri/subscriptions","organizations_url":"https://api.github.com/users/mseri/orgs","repos_url":"https://api.github.com/users/mseri/repos","events_url":"https://api.github.com/users/mseri/events{/privacy}","received_events_url":"https://api.github.com/users/mseri/received_events","type":"User","site_admin":false},"body":"The same `finally_` is defined in `otherlibs/threads/pervasives.ml` as well. I think it would be better to define it just once in pervasives and expose it, then you can call it in `threads` as well.","created_at":"2017-08-31T17:15:08Z","updated_at":"2017-08-31T17:15:08Z","html_url":"https://github.com/ocaml/ocaml/pull/640#discussion_r136394641","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/640","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/136394641"},"html":{"href":"https://github.com/ocaml/ocaml/pull/640#discussion_r136394641"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/640"}},"in_reply_to_id":68757705},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/640","id":75478388,"html_url":"https://github.com/ocaml/ocaml/pull/640","diff_url":"https://github.com/ocaml/ocaml/pull/640.diff","patch_url":"https://github.com/ocaml/ocaml/pull/640.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/640","number":640,"state":"open","locked":false,"title":"add resource-handling IO functions in pervasives","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"body":"Two things here:\n- functions to open files, give the channel to a continuation, and automatically close the file afterwards\n- a function to read a whole `in_channel` into a string. This is yet another piece of code that gets rewritten literally everywhere.\n","created_at":"2016-06-28T13:37:51Z","updated_at":"2017-08-31T17:15:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97e8863bdae72c7dd021ecbed15762c2ee5ba695","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/640/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/640/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/640/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/c61dd6b7748298ae45c88877feaaae43e6da1010","head":{"label":"c-cube:stdlib-safe-io","ref":"stdlib-safe-io","sha":"c61dd6b7748298ae45c88877feaaae43e6da1010","user":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"repo":{"id":10560325,"name":"ocaml","full_name":"c-cube/ocaml","owner":{"login":"c-cube","id":1274291,"avatar_url":"https://avatars0.githubusercontent.com/u/1274291?v=4","gravatar_id":"","url":"https://api.github.com/users/c-cube","html_url":"https://github.com/c-cube","followers_url":"https://api.github.com/users/c-cube/followers","following_url":"https://api.github.com/users/c-cube/following{/other_user}","gists_url":"https://api.github.com/users/c-cube/gists{/gist_id}","starred_url":"https://api.github.com/users/c-cube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-cube/subscriptions","organizations_url":"https://api.github.com/users/c-cube/orgs","repos_url":"https://api.github.com/users/c-cube/repos","events_url":"https://api.github.com/users/c-cube/events{/privacy}","received_events_url":"https://api.github.com/users/c-cube/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/c-cube/ocaml","description":"Read-only mirror of INRIA SVN","fork":true,"url":"https://api.github.com/repos/c-cube/ocaml","forks_url":"https://api.github.com/repos/c-cube/ocaml/forks","keys_url":"https://api.github.com/repos/c-cube/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/c-cube/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/c-cube/ocaml/teams","hooks_url":"https://api.github.com/repos/c-cube/ocaml/hooks","issue_events_url":"https://api.github.com/repos/c-cube/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/c-cube/ocaml/events","assignees_url":"https://api.github.com/repos/c-cube/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/c-cube/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/c-cube/ocaml/tags","blobs_url":"https://api.github.com/repos/c-cube/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/c-cube/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/c-cube/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/c-cube/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/c-cube/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/c-cube/ocaml/languages","stargazers_url":"https://api.github.com/repos/c-cube/ocaml/stargazers","contributors_url":"https://api.github.com/repos/c-cube/ocaml/contributors","subscribers_url":"https://api.github.com/repos/c-cube/ocaml/subscribers","subscription_url":"https://api.github.com/repos/c-cube/ocaml/subscription","commits_url":"https://api.github.com/repos/c-cube/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/c-cube/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/c-cube/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/c-cube/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/c-cube/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/c-cube/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/c-cube/ocaml/merges","archive_url":"https://api.github.com/repos/c-cube/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/c-cube/ocaml/downloads","issues_url":"https://api.github.com/repos/c-cube/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/c-cube/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/c-cube/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/c-cube/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/c-cube/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/c-cube/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/c-cube/ocaml/deployments","created_at":"2013-06-07T22:55:22Z","updated_at":"2015-01-13T21:32:00Z","pushed_at":"2017-04-18T19:27:28Z","git_url":"git://github.com/c-cube/ocaml.git","ssh_url":"git@github.com:c-cube/ocaml.git","clone_url":"https://github.com/c-cube/ocaml.git","svn_url":"https://github.com/c-cube/ocaml","homepage":null,"size":144393,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"cc6ed310057bfac7137dd80ff4966667eac86c1f","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2017-08-31T07:42:15Z","pushed_at":"2017-08-31T16:27:13Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":146455,"stargazers_count":1424,"watchers_count":1424,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":395,"mirror_url":null,"open_issues_count":120,"forks":395,"open_issues":120,"watchers":1424,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/640"},"html":{"href":"https://github.com/ocaml/ocaml/pull/640"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/640"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/640/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/640/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/640/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/c61dd6b7748298ae45c88877feaaae43e6da1010"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6786166,
"name": "ocaml/ocaml",
"url": "https://api.github.com/repos/ocaml/ocaml"
}
|
{
"id": 4040623,
"login": "mseri",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4040623?",
"url": "https://api.github.com/users/mseri"
}
|
{
"id": 1841483,
"login": "ocaml",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1841483?",
"url": "https://api.github.com/orgs/ocaml"
}
| 2017-08-31T17:15:08 |
6536211359
|
{"actor":{"display_login":"mseri"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/128076474","pull_request_review_id":50722338,"id":128076474,"diff_hunk":"@@ -54,8 +54,6 @@ static int ft_open_cntrs(void)\n {\n \tint ret;\n \n-\topts.comp_method = test_info.cq_wait_obj;\n-","path":"complex/ft_comp.c","position":5,"original_position":5,"commit_id":"e631ecae1beb15e045b0f000afe137aa457d7e69","original_commit_id":"e631ecae1beb15e045b0f000afe137aa457d7e69","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"@aingerson - I removed this. This assignment is done in a very odd location, and it was not clear why such an association should be made, or where the correct place to make it was.\r\n\r\nThis currently breaks the build, so we need at least a quick fix for that now. Are there new test config files for these new options, or updates to the config files?","created_at":"2017-07-18T19:46:44Z","updated_at":"2017-07-18T19:46:45Z","html_url":"https://github.com/ofiwg/fabtests/pull/685#discussion_r128076474","pull_request_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/685","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments/128076474"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/685#discussion_r128076474"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/685"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/fabtests/pulls/685","id":131170836,"html_url":"https://github.com/ofiwg/fabtests/pull/685","diff_url":"https://github.com/ofiwg/fabtests/pull/685.diff","patch_url":"https://github.com/ofiwg/fabtests/pull/685.patch","issue_url":"https://api.github.com/repos/ofiwg/fabtests/issues/685","number":685,"state":"open","locked":false,"title":"ubertest: Fix coverity issues for mixed enum values","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"Plus uninitialized variables.\r\n\r\nSigned-off-by: Sean Hefty <sean.hefty@intel.com>","created_at":"2017-07-18T19:44:44Z","updated_at":"2017-07-18T19:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e987ba3d1291c6025810f0314c0607db427e76b6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/685/commits","review_comments_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/685/comments","review_comment_url":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/issues/685/comments","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/e631ecae1beb15e045b0f000afe137aa457d7e69","head":{"label":"shefty:master","ref":"master","sha":"e631ecae1beb15e045b0f000afe137aa457d7e69","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"repo":{"id":23239588,"name":"fabtests","full_name":"shefty/fabtests","owner":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shefty/fabtests","description":null,"fork":true,"url":"https://api.github.com/repos/shefty/fabtests","forks_url":"https://api.github.com/repos/shefty/fabtests/forks","keys_url":"https://api.github.com/repos/shefty/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shefty/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shefty/fabtests/teams","hooks_url":"https://api.github.com/repos/shefty/fabtests/hooks","issue_events_url":"https://api.github.com/repos/shefty/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/shefty/fabtests/events","assignees_url":"https://api.github.com/repos/shefty/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/shefty/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/shefty/fabtests/tags","blobs_url":"https://api.github.com/repos/shefty/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shefty/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shefty/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/shefty/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shefty/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/shefty/fabtests/languages","stargazers_url":"https://api.github.com/repos/shefty/fabtests/stargazers","contributors_url":"https://api.github.com/repos/shefty/fabtests/contributors","subscribers_url":"https://api.github.com/repos/shefty/fabtests/subscribers","subscription_url":"https://api.github.com/repos/shefty/fabtests/subscription","commits_url":"https://api.github.com/repos/shefty/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/shefty/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/shefty/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/shefty/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/shefty/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/shefty/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shefty/fabtests/merges","archive_url":"https://api.github.com/repos/shefty/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shefty/fabtests/downloads","issues_url":"https://api.github.com/repos/shefty/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/shefty/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/shefty/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/shefty/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shefty/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/shefty/fabtests/releases{/id}","deployments_url":"https://api.github.com/repos/shefty/fabtests/deployments","created_at":"2014-08-22T20:55:09Z","updated_at":"2016-01-30T07:52:58Z","pushed_at":"2017-07-18T19:43:55Z","git_url":"git://github.com/shefty/fabtests.git","ssh_url":"git@github.com:shefty/fabtests.git","clone_url":"https://github.com/shefty/fabtests.git","svn_url":"https://github.com/shefty/fabtests","homepage":null,"size":2428,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"e705c0db57cb77c9b48de490c0ac1ccfc7da5c39","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996869,"name":"fabtests","full_name":"ofiwg/fabtests","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/fabtests","description":"A set of examples that uses Libfabric","fork":false,"url":"https://api.github.com/repos/ofiwg/fabtests","forks_url":"https://api.github.com/repos/ofiwg/fabtests/forks","keys_url":"https://api.github.com/repos/ofiwg/fabtests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/fabtests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/fabtests/teams","hooks_url":"https://api.github.com/repos/ofiwg/fabtests/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/fabtests/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/fabtests/events","assignees_url":"https://api.github.com/repos/ofiwg/fabtests/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/fabtests/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/fabtests/tags","blobs_url":"https://api.github.com/repos/ofiwg/fabtests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/fabtests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/fabtests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/fabtests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/fabtests/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/fabtests/languages","stargazers_url":"https://api.github.com/repos/ofiwg/fabtests/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/fabtests/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/fabtests/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/fabtests/subscription","commits_url":"https://api.github.com/repos/ofiwg/fabtests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/fabtests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/fabtests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/fabtests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/fabtests/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/fabtests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/fabtests/merges","archive_url":"https://api.github.com/repos/ofiwg/fabtests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/fabtests/downloads","issues_url":"https://api.github.com/repos/ofiwg/fabtests/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/fabtests/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/fabtests/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/fabtests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/fabtests/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/fabtests/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/fabtests/deployments","created_at":"2014-08-15T17:13:04Z","updated_at":"2017-07-10T06:04:22Z","pushed_at":"2017-07-18T19:44:45Z","git_url":"git://github.com/ofiwg/fabtests.git","ssh_url":"git@github.com:ofiwg/fabtests.git","clone_url":"https://github.com/ofiwg/fabtests.git","svn_url":"https://github.com/ofiwg/fabtests","homepage":"http://libfabric.org","size":2447,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":36,"forks":56,"open_issues":36,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/685"},"html":{"href":"https://github.com/ofiwg/fabtests/pull/685"},"issue":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/685"},"comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/issues/685/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/685/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/fabtests/pulls/685/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/fabtests/statuses/e631ecae1beb15e045b0f000afe137aa457d7e69"}}}}
|
{
"id": 22996869,
"name": "ofiwg/fabtests",
"url": "https://api.github.com/repos/ofiwg/fabtests"
}
|
{
"id": 3967608,
"login": "shefty",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3967608?",
"url": "https://api.github.com/users/shefty"
}
|
{
"id": 8459445,
"login": "ofiwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8459445?",
"url": "https://api.github.com/orgs/ofiwg"
}
| 2017-07-18T19:46:44 |
6281035153
|
{"actor":{"display_login":"shefty"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oppia/oppia/pulls/comments/130208285","pull_request_review_id":53062681,"id":130208285,"diff_hunk":"@@ -157,28 +152,27 @@ def get(self, exploration_id):\n 'DEFAULT_TWITTER_SHARE_MESSAGE_EDITOR': (\n DEFAULT_TWITTER_SHARE_MESSAGE_EDITOR.value),\n 'additional_angular_modules': additional_angular_modules,\n- 'can_delete': rights_manager.Actor(\n- self.user_id).can_delete(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_edit': can_edit,\n- 'can_modify_roles': rights_manager.Actor(\n- self.user_id).can_modify_roles(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_publicize': rights_manager.Actor(\n- self.user_id).can_publicize(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_publish': rights_manager.Actor(\n- self.user_id).can_publish(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_release_ownership': rights_manager.Actor(\n- self.user_id).can_release_ownership(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_unpublicize': rights_manager.Actor(\n- self.user_id).can_unpublicize(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n- 'can_unpublish': rights_manager.Actor(\n- self.user_id).can_unpublish(\n- feconf.ACTIVITY_TYPE_EXPLORATION, exploration_id),\n+ 'can_delete': acl_decorators.check_can_delete_exploration(","path":"core/controllers/editor.py","position":47,"original_position":47,"commit_id":"c7e95d15036e8f75e731e8a2cd496670f82efd4b","original_commit_id":"c7e95d15036e8f75e731e8a2cd496670f82efd4b","user":{"login":"seanlip","id":10575562,"avatar_url":"https://avatars0.githubusercontent.com/u/10575562?v=4","gravatar_id":"","url":"https://api.github.com/users/seanlip","html_url":"https://github.com/seanlip","followers_url":"https://api.github.com/users/seanlip/followers","following_url":"https://api.github.com/users/seanlip/following{/other_user}","gists_url":"https://api.github.com/users/seanlip/gists{/gist_id}","starred_url":"https://api.github.com/users/seanlip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanlip/subscriptions","organizations_url":"https://api.github.com/users/seanlip/orgs","repos_url":"https://api.github.com/users/seanlip/repos","events_url":"https://api.github.com/users/seanlip/events{/privacy}","received_events_url":"https://api.github.com/users/seanlip/received_events","type":"User","site_admin":false},"body":"It strikes me that, here, you're making a bunch of calls, and each call is fetching the activity rights object via a datastore RPC. This makes things slow. The previous implementation did that, too, but I wonder if we can improve upon it.\r\n\r\nIs there a way we can design this such that the rights object is fetched from the datastore just once in this entire request/response cycle?","created_at":"2017-07-29T00:25:26Z","updated_at":"2017-07-29T00:46:38Z","html_url":"https://github.com/oppia/oppia/pull/3682#discussion_r130208285","pull_request_url":"https://api.github.com/repos/oppia/oppia/pulls/3682","_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments/130208285"},"html":{"href":"https://github.com/oppia/oppia/pull/3682#discussion_r130208285"},"pull_request":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3682"}}},"pull_request":{"url":"https://api.github.com/repos/oppia/oppia/pulls/3682","id":133042048,"html_url":"https://github.com/oppia/oppia/pull/3682","diff_url":"https://github.com/oppia/oppia/pull/3682.diff","patch_url":"https://github.com/oppia/oppia/pull/3682.patch","issue_url":"https://api.github.com/repos/oppia/oppia/issues/3682","number":3682,"state":"open","locked":false,"title":"SiteWide ACL Refactor: Milestone 3.1","user":{"login":"1995YogeshSharma","id":9693472,"avatar_url":"https://avatars2.githubusercontent.com/u/9693472?v=4","gravatar_id":"","url":"https://api.github.com/users/1995YogeshSharma","html_url":"https://github.com/1995YogeshSharma","followers_url":"https://api.github.com/users/1995YogeshSharma/followers","following_url":"https://api.github.com/users/1995YogeshSharma/following{/other_user}","gists_url":"https://api.github.com/users/1995YogeshSharma/gists{/gist_id}","starred_url":"https://api.github.com/users/1995YogeshSharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1995YogeshSharma/subscriptions","organizations_url":"https://api.github.com/users/1995YogeshSharma/orgs","repos_url":"https://api.github.com/users/1995YogeshSharma/repos","events_url":"https://api.github.com/users/1995YogeshSharma/events{/privacy}","received_events_url":"https://api.github.com/users/1995YogeshSharma/received_events","type":"User","site_admin":false},"body":"This milestone replaces use of old system for all the controllers.","created_at":"2017-07-28T20:03:21Z","updated_at":"2017-07-29T00:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37578dd56ffad5e16d40aaf30bb2abf0a2ea7987","assignee":null,"assignees":[],"requested_reviewers":[{"login":"wxyxinyu","id":5061134,"avatar_url":"https://avatars3.githubusercontent.com/u/5061134?v=4","gravatar_id":"","url":"https://api.github.com/users/wxyxinyu","html_url":"https://github.com/wxyxinyu","followers_url":"https://api.github.com/users/wxyxinyu/followers","following_url":"https://api.github.com/users/wxyxinyu/following{/other_user}","gists_url":"https://api.github.com/users/wxyxinyu/gists{/gist_id}","starred_url":"https://api.github.com/users/wxyxinyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxyxinyu/subscriptions","organizations_url":"https://api.github.com/users/wxyxinyu/orgs","repos_url":"https://api.github.com/users/wxyxinyu/repos","events_url":"https://api.github.com/users/wxyxinyu/events{/privacy}","received_events_url":"https://api.github.com/users/wxyxinyu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/oppia/oppia/pulls/3682/commits","review_comments_url":"https://api.github.com/repos/oppia/oppia/pulls/3682/comments","review_comment_url":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oppia/oppia/issues/3682/comments","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/c7e95d15036e8f75e731e8a2cd496670f82efd4b","head":{"label":"1995YogeshSharma:milestone-3.1","ref":"milestone-3.1","sha":"c7e95d15036e8f75e731e8a2cd496670f82efd4b","user":{"login":"1995YogeshSharma","id":9693472,"avatar_url":"https://avatars2.githubusercontent.com/u/9693472?v=4","gravatar_id":"","url":"https://api.github.com/users/1995YogeshSharma","html_url":"https://github.com/1995YogeshSharma","followers_url":"https://api.github.com/users/1995YogeshSharma/followers","following_url":"https://api.github.com/users/1995YogeshSharma/following{/other_user}","gists_url":"https://api.github.com/users/1995YogeshSharma/gists{/gist_id}","starred_url":"https://api.github.com/users/1995YogeshSharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1995YogeshSharma/subscriptions","organizations_url":"https://api.github.com/users/1995YogeshSharma/orgs","repos_url":"https://api.github.com/users/1995YogeshSharma/repos","events_url":"https://api.github.com/users/1995YogeshSharma/events{/privacy}","received_events_url":"https://api.github.com/users/1995YogeshSharma/received_events","type":"User","site_admin":false},"repo":{"id":81466647,"name":"oppia","full_name":"1995YogeshSharma/oppia","owner":{"login":"1995YogeshSharma","id":9693472,"avatar_url":"https://avatars2.githubusercontent.com/u/9693472?v=4","gravatar_id":"","url":"https://api.github.com/users/1995YogeshSharma","html_url":"https://github.com/1995YogeshSharma","followers_url":"https://api.github.com/users/1995YogeshSharma/followers","following_url":"https://api.github.com/users/1995YogeshSharma/following{/other_user}","gists_url":"https://api.github.com/users/1995YogeshSharma/gists{/gist_id}","starred_url":"https://api.github.com/users/1995YogeshSharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1995YogeshSharma/subscriptions","organizations_url":"https://api.github.com/users/1995YogeshSharma/orgs","repos_url":"https://api.github.com/users/1995YogeshSharma/repos","events_url":"https://api.github.com/users/1995YogeshSharma/events{/privacy}","received_events_url":"https://api.github.com/users/1995YogeshSharma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/1995YogeshSharma/oppia","description":"Tool for collaboratively building interactive lessons.","fork":true,"url":"https://api.github.com/repos/1995YogeshSharma/oppia","forks_url":"https://api.github.com/repos/1995YogeshSharma/oppia/forks","keys_url":"https://api.github.com/repos/1995YogeshSharma/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1995YogeshSharma/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1995YogeshSharma/oppia/teams","hooks_url":"https://api.github.com/repos/1995YogeshSharma/oppia/hooks","issue_events_url":"https://api.github.com/repos/1995YogeshSharma/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/1995YogeshSharma/oppia/events","assignees_url":"https://api.github.com/repos/1995YogeshSharma/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/1995YogeshSharma/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/1995YogeshSharma/oppia/tags","blobs_url":"https://api.github.com/repos/1995YogeshSharma/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1995YogeshSharma/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1995YogeshSharma/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/1995YogeshSharma/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1995YogeshSharma/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/1995YogeshSharma/oppia/languages","stargazers_url":"https://api.github.com/repos/1995YogeshSharma/oppia/stargazers","contributors_url":"https://api.github.com/repos/1995YogeshSharma/oppia/contributors","subscribers_url":"https://api.github.com/repos/1995YogeshSharma/oppia/subscribers","subscription_url":"https://api.github.com/repos/1995YogeshSharma/oppia/subscription","commits_url":"https://api.github.com/repos/1995YogeshSharma/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/1995YogeshSharma/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/1995YogeshSharma/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/1995YogeshSharma/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/1995YogeshSharma/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/1995YogeshSharma/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1995YogeshSharma/oppia/merges","archive_url":"https://api.github.com/repos/1995YogeshSharma/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1995YogeshSharma/oppia/downloads","issues_url":"https://api.github.com/repos/1995YogeshSharma/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/1995YogeshSharma/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/1995YogeshSharma/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/1995YogeshSharma/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1995YogeshSharma/oppia/labels{/name}","releases_url":"https://api.github.com/repos/1995YogeshSharma/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/1995YogeshSharma/oppia/deployments","created_at":"2017-02-09T15:50:27Z","updated_at":"2017-02-09T15:50:32Z","pushed_at":"2017-07-28T20:02:26Z","git_url":"git://github.com/1995YogeshSharma/oppia.git","ssh_url":"git@github.com:1995YogeshSharma/oppia.git","clone_url":"https://github.com/1995YogeshSharma/oppia.git","svn_url":"https://github.com/1995YogeshSharma/oppia","homepage":"https://www.oppia.org","size":66862,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"oppia:develop","ref":"develop","sha":"95605220ef15b641f0462baaf2b3a89e1a373547","user":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"repo":{"id":40687563,"name":"oppia","full_name":"oppia/oppia","owner":{"login":"oppia","id":11620230,"avatar_url":"https://avatars1.githubusercontent.com/u/11620230?v=4","gravatar_id":"","url":"https://api.github.com/users/oppia","html_url":"https://github.com/oppia","followers_url":"https://api.github.com/users/oppia/followers","following_url":"https://api.github.com/users/oppia/following{/other_user}","gists_url":"https://api.github.com/users/oppia/gists{/gist_id}","starred_url":"https://api.github.com/users/oppia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oppia/subscriptions","organizations_url":"https://api.github.com/users/oppia/orgs","repos_url":"https://api.github.com/users/oppia/repos","events_url":"https://api.github.com/users/oppia/events{/privacy}","received_events_url":"https://api.github.com/users/oppia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oppia/oppia","description":"Tool for collaboratively building interactive lessons.","fork":false,"url":"https://api.github.com/repos/oppia/oppia","forks_url":"https://api.github.com/repos/oppia/oppia/forks","keys_url":"https://api.github.com/repos/oppia/oppia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oppia/oppia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oppia/oppia/teams","hooks_url":"https://api.github.com/repos/oppia/oppia/hooks","issue_events_url":"https://api.github.com/repos/oppia/oppia/issues/events{/number}","events_url":"https://api.github.com/repos/oppia/oppia/events","assignees_url":"https://api.github.com/repos/oppia/oppia/assignees{/user}","branches_url":"https://api.github.com/repos/oppia/oppia/branches{/branch}","tags_url":"https://api.github.com/repos/oppia/oppia/tags","blobs_url":"https://api.github.com/repos/oppia/oppia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oppia/oppia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oppia/oppia/git/refs{/sha}","trees_url":"https://api.github.com/repos/oppia/oppia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oppia/oppia/statuses/{sha}","languages_url":"https://api.github.com/repos/oppia/oppia/languages","stargazers_url":"https://api.github.com/repos/oppia/oppia/stargazers","contributors_url":"https://api.github.com/repos/oppia/oppia/contributors","subscribers_url":"https://api.github.com/repos/oppia/oppia/subscribers","subscription_url":"https://api.github.com/repos/oppia/oppia/subscription","commits_url":"https://api.github.com/repos/oppia/oppia/commits{/sha}","git_commits_url":"https://api.github.com/repos/oppia/oppia/git/commits{/sha}","comments_url":"https://api.github.com/repos/oppia/oppia/comments{/number}","issue_comment_url":"https://api.github.com/repos/oppia/oppia/issues/comments{/number}","contents_url":"https://api.github.com/repos/oppia/oppia/contents/{+path}","compare_url":"https://api.github.com/repos/oppia/oppia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oppia/oppia/merges","archive_url":"https://api.github.com/repos/oppia/oppia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oppia/oppia/downloads","issues_url":"https://api.github.com/repos/oppia/oppia/issues{/number}","pulls_url":"https://api.github.com/repos/oppia/oppia/pulls{/number}","milestones_url":"https://api.github.com/repos/oppia/oppia/milestones{/number}","notifications_url":"https://api.github.com/repos/oppia/oppia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oppia/oppia/labels{/name}","releases_url":"https://api.github.com/repos/oppia/oppia/releases{/id}","deployments_url":"https://api.github.com/repos/oppia/oppia/deployments","created_at":"2015-08-14T00:16:14Z","updated_at":"2017-07-27T04:48:28Z","pushed_at":"2017-07-28T20:03:22Z","git_url":"git://github.com/oppia/oppia.git","ssh_url":"git@github.com:oppia/oppia.git","clone_url":"https://github.com/oppia/oppia.git","svn_url":"https://github.com/oppia/oppia","homepage":"https://www.oppia.org","size":66821,"stargazers_count":334,"watchers_count":334,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":436,"mirror_url":null,"open_issues_count":345,"forks":436,"open_issues":345,"watchers":334,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3682"},"html":{"href":"https://github.com/oppia/oppia/pull/3682"},"issue":{"href":"https://api.github.com/repos/oppia/oppia/issues/3682"},"comments":{"href":"https://api.github.com/repos/oppia/oppia/issues/3682/comments"},"review_comments":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3682/comments"},"review_comment":{"href":"https://api.github.com/repos/oppia/oppia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oppia/oppia/pulls/3682/commits"},"statuses":{"href":"https://api.github.com/repos/oppia/oppia/statuses/c7e95d15036e8f75e731e8a2cd496670f82efd4b"}}}}
|
{
"id": 40687563,
"name": "oppia/oppia",
"url": "https://api.github.com/repos/oppia/oppia"
}
|
{
"id": 10575562,
"login": "seanlip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10575562?",
"url": "https://api.github.com/users/seanlip"
}
|
{
"id": 11620230,
"login": "oppia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11620230?",
"url": "https://api.github.com/orgs/oppia"
}
| 2017-07-29T00:25:26 |
6353609899
|
{"actor":{"display_login":"seanlip"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/99729278","pull_request_review_id":20414362,"id":99729278,"diff_hunk":"@@ -1518,4 +1518,15 @@ def test_default_values_are_deeply_dupped\n assert Developer.new.respond_to?(:last_name=)\n assert Developer.new.respond_to?(:last_name?)\n end\n+\n+ test \"when #reload called, ignored columns' attribute methods are not defined\" do\n+ developer = Developer.create!(name: 'Developer')\n+ refute developer.respond_to?(:first_name)","path":"activerecord/test/cases/base_test.rb","position":7,"original_position":7,"commit_id":"84a750586ef4ba63cca2781d02f4c0352198f0aa","original_commit_id":"3823c47d65c661ccad207f4ec4c6e5b3d8ec3228","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"body":"@composerinteralia No real reason, just went with what was used elsewhere.","created_at":"2017-02-07T01:50:16Z","updated_at":"2017-02-07T01:50:16Z","html_url":"https://github.com/rails/rails/pull/27918#discussion_r99729278","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/27918","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/99729278"},"html":{"href":"https://github.com/rails/rails/pull/27918#discussion_r99729278"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/27918"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/27918","id":104716983,"html_url":"https://github.com/rails/rails/pull/27918","diff_url":"https://github.com/rails/rails/pull/27918.diff","patch_url":"https://github.com/rails/rails/pull/27918.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/27918","number":27918,"state":"open","locked":false,"title":"Do not use `Arel.star` when `ignored_columns`","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"body":"### Summary\r\n\r\nIf there are any ignored columns, we will now list out all columns we\r\nwant to be returned from the database.\r\n\r\n### Other Information\r\n\r\n- Includes a regression test.\r\n- Re: the test I had to change, it should have never been passing in the\r\nfirst place, due to the ignored `first_name` column on `Developer.","created_at":"2017-02-05T21:47:11Z","updated_at":"2017-02-07T01:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a683aec628ab3ed9795f4fecf67693f738b5931d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/27918/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/27918/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/rails/issues/27918/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/84a750586ef4ba63cca2781d02f4c0352198f0aa","head":{"label":"maclover7:jm-fix-27914","ref":"jm-fix-27914","sha":"84a750586ef4ba63cca2781d02f4c0352198f0aa","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"repo":{"id":40943063,"name":"rails","full_name":"maclover7/rails","owner":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars.githubusercontent.com/u/3020626?v=3","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maclover7/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/maclover7/rails","forks_url":"https://api.github.com/repos/maclover7/rails/forks","keys_url":"https://api.github.com/repos/maclover7/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maclover7/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maclover7/rails/teams","hooks_url":"https://api.github.com/repos/maclover7/rails/hooks","issue_events_url":"https://api.github.com/repos/maclover7/rails/issues/events{/number}","events_url":"https://api.github.com/repos/maclover7/rails/events","assignees_url":"https://api.github.com/repos/maclover7/rails/assignees{/user}","branches_url":"https://api.github.com/repos/maclover7/rails/branches{/branch}","tags_url":"https://api.github.com/repos/maclover7/rails/tags","blobs_url":"https://api.github.com/repos/maclover7/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maclover7/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maclover7/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/maclover7/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maclover7/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/maclover7/rails/languages","stargazers_url":"https://api.github.com/repos/maclover7/rails/stargazers","contributors_url":"https://api.github.com/repos/maclover7/rails/contributors","subscribers_url":"https://api.github.com/repos/maclover7/rails/subscribers","subscription_url":"https://api.github.com/repos/maclover7/rails/subscription","commits_url":"https://api.github.com/repos/maclover7/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/maclover7/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/maclover7/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/maclover7/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/maclover7/rails/contents/{+path}","compare_url":"https://api.github.com/repos/maclover7/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maclover7/rails/merges","archive_url":"https://api.github.com/repos/maclover7/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maclover7/rails/downloads","issues_url":"https://api.github.com/repos/maclover7/rails/issues{/number}","pulls_url":"https://api.github.com/repos/maclover7/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/maclover7/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/maclover7/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maclover7/rails/labels{/name}","releases_url":"https://api.github.com/repos/maclover7/rails/releases{/id}","deployments_url":"https://api.github.com/repos/maclover7/rails/deployments","created_at":"2015-08-18T01:26:06Z","updated_at":"2016-06-21T20:33:31Z","pushed_at":"2017-02-07T01:49:55Z","git_url":"git://github.com/maclover7/rails.git","ssh_url":"git@github.com:maclover7/rails.git","clone_url":"https://github.com/maclover7/rails.git","svn_url":"https://github.com/maclover7/rails","homepage":"http://rubyonrails.org","size":139303,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"aff5e52484da7b4c2bc26552eb02222513d3976b","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","deployments_url":"https://api.github.com/repos/rails/rails/deployments","created_at":"2008-04-11T02:19:47Z","updated_at":"2017-02-07T00:55:01Z","pushed_at":"2017-02-07T01:49:58Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":142678,"stargazers_count":34363,"watchers_count":34363,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13999,"mirror_url":null,"open_issues_count":1254,"forks":13999,"open_issues":1254,"watchers":34363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/27918"},"html":{"href":"https://github.com/rails/rails/pull/27918"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/27918"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/27918/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/27918/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/27918/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/84a750586ef4ba63cca2781d02f4c0352198f0aa"}}}}
|
{
"id": 8514,
"name": "rails/rails",
"url": "https://api.github.com/repos/rails/rails"
}
|
{
"id": 3020626,
"login": "maclover7",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3020626?",
"url": "https://api.github.com/users/maclover7"
}
|
{
"id": 4223,
"login": "rails",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4223?",
"url": "https://api.github.com/orgs/rails"
}
| 2017-02-07T01:50:16 |
5277142601
|
{"actor":{"display_login":"maclover7"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-java/pulls/comments/147328347","pull_request_review_id":72409005,"id":147328347,"diff_hunk":"@@ -38,6 +46,29 @@ allprojects {\n jcenter()\n google()\n }\n+\n+ if (!project.name.startsWith(\"realm-examples\")\n+ && !project.name.startsWith(\"library\")\n+ && !project.name.startsWith(\"moduleExample\")) { // exclude root and library project\n+ task runMonkey(dependsOn: 'installDebug') {","path":"examples/build.gradle","position":32,"original_position":32,"commit_id":"d00eeb37bfa534cab2c34b7e4cd56337ab4e4b30","original_commit_id":"d00eeb37bfa534cab2c34b7e4cd56337ab4e4b30","user":{"login":"beeender","id":449296,"avatar_url":"https://avatars3.githubusercontent.com/u/449296?v=4","gravatar_id":"","url":"https://api.github.com/users/beeender","html_url":"https://github.com/beeender","followers_url":"https://api.github.com/users/beeender/followers","following_url":"https://api.github.com/users/beeender/following{/other_user}","gists_url":"https://api.github.com/users/beeender/gists{/gist_id}","starred_url":"https://api.github.com/users/beeender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beeender/subscriptions","organizations_url":"https://api.github.com/users/beeender/orgs","repos_url":"https://api.github.com/users/beeender/repos","events_url":"https://api.github.com/users/beeender/events{/privacy}","received_events_url":"https://api.github.com/users/beeender/received_events","type":"User","site_admin":false},"body":"I don't quite understand this, the task to run monkey for example is still `:monkeyDebug` and `:monkeyRelease`?","created_at":"2017-10-27T06:00:16Z","updated_at":"2017-10-27T06:00:20Z","html_url":"https://github.com/realm/realm-java/pull/5478#discussion_r147328347","pull_request_url":"https://api.github.com/repos/realm/realm-java/pulls/5478","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments/147328347"},"html":{"href":"https://github.com/realm/realm-java/pull/5478#discussion_r147328347"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-java/pulls/5478"}},"in_reply_to_id":147328085},"pull_request":{"url":"https://api.github.com/repos/realm/realm-java/pulls/5478","id":149070283,"html_url":"https://github.com/realm/realm-java/pull/5478","diff_url":"https://github.com/realm/realm-java/pull/5478.diff","patch_url":"https://github.com/realm/realm-java/pull/5478.patch","issue_url":"https://api.github.com/repos/realm/realm-java/issues/5478","number":5478,"state":"open","locked":false,"title":"Fix monkey, release no longer need a real device","user":{"login":"nhachicha","id":1793238,"avatar_url":"https://avatars0.githubusercontent.com/u/1793238?v=4","gravatar_id":"","url":"https://api.github.com/users/nhachicha","html_url":"https://github.com/nhachicha","followers_url":"https://api.github.com/users/nhachicha/followers","following_url":"https://api.github.com/users/nhachicha/following{/other_user}","gists_url":"https://api.github.com/users/nhachicha/gists{/gist_id}","starred_url":"https://api.github.com/users/nhachicha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhachicha/subscriptions","organizations_url":"https://api.github.com/users/nhachicha/orgs","repos_url":"https://api.github.com/users/nhachicha/repos","events_url":"https://api.github.com/users/nhachicha/events{/privacy}","received_events_url":"https://api.github.com/users/nhachicha/received_events","type":"User","site_admin":false},"body":"As reported by @beeender https://github.com/novoda/gradle-android-command-plugin/issues/122 the `android-command` plugin has an issue when running `monkey`. This PR remove this dependency, also we no longer require having a physical device to run monkey task (and perform a release)\r\n\r\nfixes https://github.com/realm/realm-java/issues/5192\r\n","created_at":"2017-10-26T23:35:53Z","updated_at":"2017-10-27T06:00:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dec7c47d53d3a3dc9ae2b0cb394c04a1fac248c6","assignee":{"login":"nhachicha","id":1793238,"avatar_url":"https://avatars0.githubusercontent.com/u/1793238?v=4","gravatar_id":"","url":"https://api.github.com/users/nhachicha","html_url":"https://github.com/nhachicha","followers_url":"https://api.github.com/users/nhachicha/followers","following_url":"https://api.github.com/users/nhachicha/following{/other_user}","gists_url":"https://api.github.com/users/nhachicha/gists{/gist_id}","starred_url":"https://api.github.com/users/nhachicha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhachicha/subscriptions","organizations_url":"https://api.github.com/users/nhachicha/orgs","repos_url":"https://api.github.com/users/nhachicha/repos","events_url":"https://api.github.com/users/nhachicha/events{/privacy}","received_events_url":"https://api.github.com/users/nhachicha/received_events","type":"User","site_admin":false},"assignees":[{"login":"nhachicha","id":1793238,"avatar_url":"https://avatars0.githubusercontent.com/u/1793238?v=4","gravatar_id":"","url":"https://api.github.com/users/nhachicha","html_url":"https://github.com/nhachicha","followers_url":"https://api.github.com/users/nhachicha/followers","following_url":"https://api.github.com/users/nhachicha/following{/other_user}","gists_url":"https://api.github.com/users/nhachicha/gists{/gist_id}","starred_url":"https://api.github.com/users/nhachicha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhachicha/subscriptions","organizations_url":"https://api.github.com/users/nhachicha/orgs","repos_url":"https://api.github.com/users/nhachicha/repos","events_url":"https://api.github.com/users/nhachicha/events{/privacy}","received_events_url":"https://api.github.com/users/nhachicha/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-java/pulls/5478/commits","review_comments_url":"https://api.github.com/repos/realm/realm-java/pulls/5478/comments","review_comment_url":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-java/issues/5478/comments","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/d00eeb37bfa534cab2c34b7e4cd56337ab4e4b30","head":{"label":"realm:nh/fix_monkey","ref":"nh/fix_monkey","sha":"d00eeb37bfa534cab2c34b7e4cd56337ab4e4b30","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-10-27T05:51:22Z","pushed_at":"2017-10-26T23:41:57Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":56004,"stargazers_count":8639,"watchers_count":8639,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1360,"mirror_url":null,"archived":false,"open_issues_count":356,"forks":1360,"open_issues":356,"watchers":8639,"default_branch":"master"}},"base":{"label":"realm:releases","ref":"releases","sha":"68f4e79404fe6ed991b1ec40c7dee5ced6eb58c1","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4084908,"name":"realm-java","full_name":"realm/realm-java","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars0.githubusercontent.com/u/7575099?v=4","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-java","description":"Realm is a mobile database: a replacement for SQLite & ORMs","fork":false,"url":"https://api.github.com/repos/realm/realm-java","forks_url":"https://api.github.com/repos/realm/realm-java/forks","keys_url":"https://api.github.com/repos/realm/realm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-java/teams","hooks_url":"https://api.github.com/repos/realm/realm-java/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-java/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-java/events","assignees_url":"https://api.github.com/repos/realm/realm-java/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-java/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-java/tags","blobs_url":"https://api.github.com/repos/realm/realm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-java/languages","stargazers_url":"https://api.github.com/repos/realm/realm-java/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-java/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-java/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-java/subscription","commits_url":"https://api.github.com/repos/realm/realm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-java/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-java/merges","archive_url":"https://api.github.com/repos/realm/realm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-java/downloads","issues_url":"https://api.github.com/repos/realm/realm-java/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-java/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-java/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-java/deployments","created_at":"2012-04-20T09:18:42Z","updated_at":"2017-10-27T05:51:22Z","pushed_at":"2017-10-26T23:41:57Z","git_url":"git://github.com/realm/realm-java.git","ssh_url":"git@github.com:realm/realm-java.git","clone_url":"https://github.com/realm/realm-java.git","svn_url":"https://github.com/realm/realm-java","homepage":"http://realm.io","size":56004,"stargazers_count":8639,"watchers_count":8639,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1360,"mirror_url":null,"archived":false,"open_issues_count":356,"forks":1360,"open_issues":356,"watchers":8639,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-java/pulls/5478"},"html":{"href":"https://github.com/realm/realm-java/pull/5478"},"issue":{"href":"https://api.github.com/repos/realm/realm-java/issues/5478"},"comments":{"href":"https://api.github.com/repos/realm/realm-java/issues/5478/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-java/pulls/5478/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-java/pulls/5478/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-java/statuses/d00eeb37bfa534cab2c34b7e4cd56337ab4e4b30"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 4084908,
"name": "realm/realm-java",
"url": "https://api.github.com/repos/realm/realm-java"
}
|
{
"id": 449296,
"login": "beeender",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/449296?",
"url": "https://api.github.com/users/beeender"
}
|
{
"id": 7575099,
"login": "realm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7575099?",
"url": "https://api.github.com/orgs/realm"
}
| 2017-10-27T06:00:16 |
6773447305
|
{"actor":{"display_login":"beeender"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/realm/realm-cocoa/pulls/comments/97179862","pull_request_review_id":17789618,"id":97179862,"diff_hunk":"@@ -53,20 +53,38 @@ - (instancetype)initWithFullURLPath:(NSString *)urlPath\n }\n \n - (void)invalidate {\n- [self.timer invalidate];\n- self.user = nil;\n+ dispatch_async(dispatch_get_main_queue(), ^{\n+ [self.timer invalidate];\n+ self.user = nil;\n+ });\n }\n \n - (void)scheduleRefreshTimer:(NSTimeInterval)fireTime {\n- static const NSInteger refreshBuffer = 10;\n- [self.timer invalidate];\n- self.timer = [[NSTimer alloc] initWithFireDate:[NSDate dateWithTimeIntervalSince1970:(fireTime - refreshBuffer)]\n- interval:0\n- target:self\n- selector:@selector(timerFired:)\n- userInfo:nil\n- repeats:NO];\n- [[NSRunLoop currentRunLoop] addTimer:self.timer forMode:NSDefaultRunLoopMode];\n+ constexpr NSInteger REFRESH_BUFFER = 10;\n+ // Schedule the timer on the main queue.\n+ // It's very likely that this method will be run on a side thread, for example\n+ // on the thread that runs `NSURLSession`'s completion blocks. We can't be\n+ // guaranteed that there's an existing runloop on those threads, and we don't want\n+ // to create and start a new one if one doesn't already exist.\n+ dispatch_async(dispatch_get_main_queue(), ^{\n+ [self.timer invalidate];\n+ // The fire time is `REFRESH_BUFFER` seconds before the token expires, but it also\n+ // must be at least `REFRESH_BUFFER` seconds in the future from now.","path":"Realm/RLMSyncSessionRefreshHandle.mm","position":53,"original_position":53,"commit_id":"c3836ed0801e6a43912e8a44fcf9bf711a8b1263","original_commit_id":"c3836ed0801e6a43912e8a44fcf9bf711a8b1263","user":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"body":"My reasoning was that, if the server was misconfigured and sending tokens that expired e.g. only after 5 seconds, this check would prevent clients from hammering the server with requests.\r\n\r\nThinking about it more, though, the server would still be hammered; the codepath would just be different (5 seconds after a token is expired the object store gets the \"not logged in\" error and the client still tries to refresh the token). I'll remove it.","created_at":"2017-01-21T00:07:32Z","updated_at":"2017-01-21T00:07:32Z","html_url":"https://github.com/realm/realm-cocoa/pull/4570#discussion_r97179862","pull_request_url":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570","_links":{"self":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/comments/97179862"},"html":{"href":"https://github.com/realm/realm-cocoa/pull/4570#discussion_r97179862"},"pull_request":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570"}}},"pull_request":{"url":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570","id":102520351,"html_url":"https://github.com/realm/realm-cocoa/pull/4570","diff_url":"https://github.com/realm/realm-cocoa/pull/4570.diff","patch_url":"https://github.com/realm/realm-cocoa/pull/4570.patch","issue_url":"https://api.github.com/repos/realm/realm-cocoa/issues/4570","number":4570,"state":"open","locked":false,"title":"Fix issues with automatic sync token refresh subsystem","user":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"body":"Changes:\r\n- Sync token refresh timers will now be registered upon the main queue\r\n- Sync token refresh handles will now be properly created with the path to the Realm (instead of the full URL)\r\n- Made the logic to calculate the time at which the token is refreshed more resilient to bad values\r\n\r\nFixes https://github.com/realm/realm-cocoa/issues/4569. Related to https://github.com/realm/realm-sync/issues/1114 and https://github.com/realm/RealmTasks/issues/384.","created_at":"2017-01-20T19:23:47Z","updated_at":"2017-01-21T00:07:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"651d0e8d75184af8ff86e53fe19c19f12862d0f4","assignee":{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false},"assignees":[{"login":"austinzheng","id":3687054,"avatar_url":"https://avatars.githubusercontent.com/u/3687054?v=3","gravatar_id":"","url":"https://api.github.com/users/austinzheng","html_url":"https://github.com/austinzheng","followers_url":"https://api.github.com/users/austinzheng/followers","following_url":"https://api.github.com/users/austinzheng/following{/other_user}","gists_url":"https://api.github.com/users/austinzheng/gists{/gist_id}","starred_url":"https://api.github.com/users/austinzheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/austinzheng/subscriptions","organizations_url":"https://api.github.com/users/austinzheng/orgs","repos_url":"https://api.github.com/users/austinzheng/repos","events_url":"https://api.github.com/users/austinzheng/events{/privacy}","received_events_url":"https://api.github.com/users/austinzheng/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570/commits","review_comments_url":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570/comments","review_comment_url":"https://api.github.com/repos/realm/realm-cocoa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/realm-cocoa/issues/4570/comments","statuses_url":"https://api.github.com/repos/realm/realm-cocoa/statuses/c3836ed0801e6a43912e8a44fcf9bf711a8b1263","head":{"label":"realm:az/fix-sync-token-refresh","ref":"az/fix-sync-token-refresh","sha":"c3836ed0801e6a43912e8a44fcf9bf711a8b1263","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4044891,"name":"realm-cocoa","full_name":"realm/realm-cocoa","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-cocoa","description":"Realm is a mobile database: a replacement for Core Data & SQLite","fork":false,"url":"https://api.github.com/repos/realm/realm-cocoa","forks_url":"https://api.github.com/repos/realm/realm-cocoa/forks","keys_url":"https://api.github.com/repos/realm/realm-cocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-cocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-cocoa/teams","hooks_url":"https://api.github.com/repos/realm/realm-cocoa/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-cocoa/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-cocoa/events","assignees_url":"https://api.github.com/repos/realm/realm-cocoa/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-cocoa/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-cocoa/tags","blobs_url":"https://api.github.com/repos/realm/realm-cocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-cocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-cocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-cocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-cocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-cocoa/languages","stargazers_url":"https://api.github.com/repos/realm/realm-cocoa/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-cocoa/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-cocoa/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-cocoa/subscription","commits_url":"https://api.github.com/repos/realm/realm-cocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-cocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-cocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-cocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-cocoa/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-cocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-cocoa/merges","archive_url":"https://api.github.com/repos/realm/realm-cocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-cocoa/downloads","issues_url":"https://api.github.com/repos/realm/realm-cocoa/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-cocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-cocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-cocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-cocoa/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-cocoa/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-cocoa/deployments","created_at":"2012-04-16T20:06:56Z","updated_at":"2017-01-20T21:21:59Z","pushed_at":"2017-01-20T23:29:59Z","git_url":"git://github.com/realm/realm-cocoa.git","ssh_url":"git@github.com:realm/realm-cocoa.git","clone_url":"https://github.com/realm/realm-cocoa.git","svn_url":"https://github.com/realm/realm-cocoa","homepage":"https://realm.io","size":49686,"stargazers_count":9707,"watchers_count":9707,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1208,"mirror_url":null,"open_issues_count":262,"forks":1208,"open_issues":262,"watchers":9707,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"fef9c95554bb52b9f48c59249bc38a14565fdc16","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":4044891,"name":"realm-cocoa","full_name":"realm/realm-cocoa","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/realm-cocoa","description":"Realm is a mobile database: a replacement for Core Data & SQLite","fork":false,"url":"https://api.github.com/repos/realm/realm-cocoa","forks_url":"https://api.github.com/repos/realm/realm-cocoa/forks","keys_url":"https://api.github.com/repos/realm/realm-cocoa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/realm-cocoa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/realm-cocoa/teams","hooks_url":"https://api.github.com/repos/realm/realm-cocoa/hooks","issue_events_url":"https://api.github.com/repos/realm/realm-cocoa/issues/events{/number}","events_url":"https://api.github.com/repos/realm/realm-cocoa/events","assignees_url":"https://api.github.com/repos/realm/realm-cocoa/assignees{/user}","branches_url":"https://api.github.com/repos/realm/realm-cocoa/branches{/branch}","tags_url":"https://api.github.com/repos/realm/realm-cocoa/tags","blobs_url":"https://api.github.com/repos/realm/realm-cocoa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/realm-cocoa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/realm-cocoa/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/realm-cocoa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/realm-cocoa/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/realm-cocoa/languages","stargazers_url":"https://api.github.com/repos/realm/realm-cocoa/stargazers","contributors_url":"https://api.github.com/repos/realm/realm-cocoa/contributors","subscribers_url":"https://api.github.com/repos/realm/realm-cocoa/subscribers","subscription_url":"https://api.github.com/repos/realm/realm-cocoa/subscription","commits_url":"https://api.github.com/repos/realm/realm-cocoa/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/realm-cocoa/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/realm-cocoa/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/realm-cocoa/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/realm-cocoa/contents/{+path}","compare_url":"https://api.github.com/repos/realm/realm-cocoa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/realm-cocoa/merges","archive_url":"https://api.github.com/repos/realm/realm-cocoa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/realm-cocoa/downloads","issues_url":"https://api.github.com/repos/realm/realm-cocoa/issues{/number}","pulls_url":"https://api.github.com/repos/realm/realm-cocoa/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/realm-cocoa/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/realm-cocoa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/realm-cocoa/labels{/name}","releases_url":"https://api.github.com/repos/realm/realm-cocoa/releases{/id}","deployments_url":"https://api.github.com/repos/realm/realm-cocoa/deployments","created_at":"2012-04-16T20:06:56Z","updated_at":"2017-01-20T21:21:59Z","pushed_at":"2017-01-20T23:29:59Z","git_url":"git://github.com/realm/realm-cocoa.git","ssh_url":"git@github.com:realm/realm-cocoa.git","clone_url":"https://github.com/realm/realm-cocoa.git","svn_url":"https://github.com/realm/realm-cocoa","homepage":"https://realm.io","size":49686,"stargazers_count":9707,"watchers_count":9707,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1208,"mirror_url":null,"open_issues_count":262,"forks":1208,"open_issues":262,"watchers":9707,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570"},"html":{"href":"https://github.com/realm/realm-cocoa/pull/4570"},"issue":{"href":"https://api.github.com/repos/realm/realm-cocoa/issues/4570"},"comments":{"href":"https://api.github.com/repos/realm/realm-cocoa/issues/4570/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/realm-cocoa/pulls/4570/commits"},"statuses":{"href":"https://api.github.com/repos/realm/realm-cocoa/statuses/c3836ed0801e6a43912e8a44fcf9bf711a8b1263"}}}}
|
{
"id": 4044891,
"name": "realm/realm-cocoa",
"url": "https://api.github.com/repos/realm/realm-cocoa"
}
|
{
"id": 3687054,
"login": "austinzheng",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3687054?",
"url": "https://api.github.com/users/austinzheng"
}
|
{
"id": 7575099,
"login": "realm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7575099?",
"url": "https://api.github.com/orgs/realm"
}
| 2017-01-21T00:07:32 |
5189610573
|
{"actor":{"display_login":"austinzheng"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/108685745","pull_request_review_id":29732346,"id":108685745,"diff_hunk":"@@ -129,13 +196,48 @@ struct union_alphabet\n //! the type of the alphabet when converted to char (e.g. via @link to_char @endlink)\n using char_type = typename first_alphabet_type::char_type;\n //! the type of the alphabet when represented as a number (e.g. via @link to_integral @endlink)\n- using integral_type = decltype(detail::at_least_type<value_size>());\n+ using integral_type = detail::at_least_type_t<value_size>;\n+ /*! the type used to assign a value from one of the base alphabets during\n+ * copy construction or copy assignment. (i.e. via\n+ * @link union_alphabet(const variant_type & alphabet) @endlink or\n+ * @link operator= (const variant_type & alphabet) @endlink )\n+ */\n+ using variant_type = std::variant<first_alphabet_type, alphabet_types...>;\n+\n+ //! @name default constructors\n+ //!@{\n+ constexpr union_alphabet() = default;\n+ constexpr union_alphabet(const union_alphabet &) = default;\n+ constexpr union_alphabet(union_alphabet &&) = default;\n+ constexpr union_alphabet(const integral_type & value) : value{value}{}\n+ //!@}\n \n-protected:\n- using tuple_t = std::tuple<first_alphabet_type, alphabet_types...>;\n- using index_sequence_t = decltype(std::make_index_sequence<std::tuple_size_v<tuple_t>>{});\n- static constexpr auto sizes = detail::alphabet_sizes<tuple_t>(index_sequence_t{});\n- static constexpr auto alphabets = detail::alphabet_objects<tuple_t>(index_sequence_t{});\n+ //! @name default assignment operators\n+ //!@{\n+ constexpr union_alphabet & operator= (const union_alphabet &) = default;\n+ constexpr union_alphabet & operator= (union_alphabet &&) = default;\n+ constexpr union_alphabet(integral_type && value) : value{value}{}\n+ //!@}\n+\n+ /*! allow construction via a value of the base alphabets\n+ *~~~~~~~~~~~~~~~{.cpp}\n+ * union_alphabet<dna4, gap> letter1{dna4::C}; // or\n+ * union_alphabet<dna4, gap> letter2 = gap::GAP;\n+ *~~~~~~~~~~~~~~~\n+ */\n+ constexpr union_alphabet(const variant_type & alphabet) : value(from_base_(alphabet)){}","path":"include/seqan3/alphabet/union_alphabet.hpp","position":193,"original_position":193,"commit_id":"aa935f615ab1d588a3780bbd1090896f21b47dfe","original_commit_id":"aa935f615ab1d588a3780bbd1090896f21b47dfe","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars2.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-03-29T14:09:26Z","updated_at":"2017-03-29T14:09:26Z","html_url":"https://github.com/seqan/seqan3/pull/35#discussion_r108685745","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/108685745"},"html":{"href":"https://github.com/seqan/seqan3/pull/35#discussion_r108685745"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/35","id":113040052,"html_url":"https://github.com/seqan/seqan3/pull/35","diff_url":"https://github.com/seqan/seqan3/pull/35.diff","patch_url":"https://github.com/seqan/seqan3/pull/35.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/35","number":35,"state":"open","locked":false,"title":"[FEATURE] Build union_alphabet lookup tables at compile time to guarantee constant operations","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars2.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"body":"Furthermore:\r\n* assign/construct directly from base alphabets of union_type, i.e.\r\n ```c++\r\n // converts C of base class into union's C\r\n seqan3::union_alphabet<dna4, dna5, gap> letter0 = dna4::C; // internal value = 2\r\n seqan3::union_alphabet<dna4, dna5, gap> letter1 = dna5::C; // internal value = 6\r\n seqan3::union_alphabet<dna4, dna5, gap> letter2 = gap::GAP; // internal value = 9\r\n ```\r\n* add unit tests for alphabet::detail function that are used by union_alphabet\r\n* union_alphabet uses lookup tables\r\n* move seqan::detail functions into seqan::detail::union_alphabet\r\n* remove detail::alphabet_objects\r\n* add gap::GAP and gap::UNKNOWN","created_at":"2017-03-28T18:46:24Z","updated_at":"2017-03-29T14:09:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5682ab63df30fbde4a02cbe2dfd797ccdea8f6e","assignee":{"login":"h-2","id":2996863,"avatar_url":"https://avatars1.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-2","id":2996863,"avatar_url":"https://avatars1.githubusercontent.com/u/2996863?v=3","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/35/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/35/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/35/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/aa935f615ab1d588a3780bbd1090896f21b47dfe","head":{"label":"marehr:constant_time_union_alphabet","ref":"constant_time_union_alphabet","sha":"aa935f615ab1d588a3780bbd1090896f21b47dfe","user":{"login":"marehr","id":103778,"avatar_url":"https://avatars2.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"repo":{"id":85842097,"name":"seqan3","full_name":"marehr/seqan3","owner":{"login":"marehr","id":103778,"avatar_url":"https://avatars2.githubusercontent.com/u/103778?v=3","gravatar_id":"","url":"https://api.github.com/users/marehr","html_url":"https://github.com/marehr","followers_url":"https://api.github.com/users/marehr/followers","following_url":"https://api.github.com/users/marehr/following{/other_user}","gists_url":"https://api.github.com/users/marehr/gists{/gist_id}","starred_url":"https://api.github.com/users/marehr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marehr/subscriptions","organizations_url":"https://api.github.com/users/marehr/orgs","repos_url":"https://api.github.com/users/marehr/repos","events_url":"https://api.github.com/users/marehr/events{/privacy}","received_events_url":"https://api.github.com/users/marehr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marehr/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/marehr/seqan3","forks_url":"https://api.github.com/repos/marehr/seqan3/forks","keys_url":"https://api.github.com/repos/marehr/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marehr/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marehr/seqan3/teams","hooks_url":"https://api.github.com/repos/marehr/seqan3/hooks","issue_events_url":"https://api.github.com/repos/marehr/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/marehr/seqan3/events","assignees_url":"https://api.github.com/repos/marehr/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/marehr/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/marehr/seqan3/tags","blobs_url":"https://api.github.com/repos/marehr/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marehr/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marehr/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/marehr/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marehr/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/marehr/seqan3/languages","stargazers_url":"https://api.github.com/repos/marehr/seqan3/stargazers","contributors_url":"https://api.github.com/repos/marehr/seqan3/contributors","subscribers_url":"https://api.github.com/repos/marehr/seqan3/subscribers","subscription_url":"https://api.github.com/repos/marehr/seqan3/subscription","commits_url":"https://api.github.com/repos/marehr/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/marehr/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/marehr/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/marehr/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/marehr/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/marehr/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marehr/seqan3/merges","archive_url":"https://api.github.com/repos/marehr/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marehr/seqan3/downloads","issues_url":"https://api.github.com/repos/marehr/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/marehr/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/marehr/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/marehr/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marehr/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/marehr/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/marehr/seqan3/deployments","created_at":"2017-03-22T15:05:43Z","updated_at":"2017-03-22T15:05:44Z","pushed_at":"2017-03-28T18:44:56Z","git_url":"git://github.com/marehr/seqan3.git","ssh_url":"git@github.com:marehr/seqan3.git","clone_url":"https://github.com/marehr/seqan3.git","svn_url":"https://github.com/marehr/seqan3","homepage":"http://www.seqan.de","size":117,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"daa4c9c33f287aa665b72302ea6825acbe8af749","user":{"login":"seqan","id":1752144,"avatar_url":"https://avatars1.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"name":"seqan3","full_name":"seqan/seqan3","owner":{"login":"seqan","id":1752144,"avatar_url":"https://avatars1.githubusercontent.com/u/1752144?v=3","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2017-03-21T19:04:38Z","pushed_at":"2017-03-28T18:46:25Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":102,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":10,"forks":15,"open_issues":10,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/35"},"html":{"href":"https://github.com/seqan/seqan3/pull/35"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/35"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/aa935f615ab1d588a3780bbd1090896f21b47dfe"}}}}
|
{
"id": 55410078,
"name": "seqan/seqan3",
"url": "https://api.github.com/repos/seqan/seqan3"
}
|
{
"id": 103778,
"login": "marehr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/103778?",
"url": "https://api.github.com/users/marehr"
}
|
{
"id": 1752144,
"login": "seqan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1752144?",
"url": "https://api.github.com/orgs/seqan"
}
| 2017-03-29T14:09:26 |
5587468915
|
{"actor":{"display_login":"marehr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/servo/servo/pulls/comments/120527514","pull_request_review_id":42496066,"id":120527514,"diff_hunk":"@@ -1188,10 +1177,16 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>\n \n self.mem_profiler_chan.send(mem::ProfilerMsg::Exit);\n \n- // TODO: exit before the root browsing context is initialized?\n- debug!(\"Removing root browsing context.\");\n- let root_browsing_context_id = BrowsingContextId::from(self.root_browsing_context_id);\n- self.close_browsing_context(root_browsing_context_id, ExitPipelineMode::Normal);\n+ // Close the top-level browsing contexts\n+ let top_level_browsing_context_ids: Vec<TopLevelBrowsingContextId> = self.browsing_contexts.values()\n+ .filter(|browsing_context| browsing_context.is_top_level())","path":"components/constellation/constellation.rs","position":null,"original_position":92,"commit_id":"8047f6a07fb050c1720e526712ccc32787482742","original_commit_id":"66f61ea275cbf2f212e87b7b405c5fc0ecba9a71","user":{"login":"cbrewster","id":9086315,"avatar_url":"https://avatars2.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrewster","html_url":"https://github.com/cbrewster","followers_url":"https://api.github.com/users/cbrewster/followers","following_url":"https://api.github.com/users/cbrewster/following{/other_user}","gists_url":"https://api.github.com/users/cbrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrewster/subscriptions","organizations_url":"https://api.github.com/users/cbrewster/orgs","repos_url":"https://api.github.com/users/cbrewster/repos","events_url":"https://api.github.com/users/cbrewster/events{/privacy}","received_events_url":"https://api.github.com/users/cbrewster/received_events","type":"User","site_admin":false},"body":"Tis a shame","created_at":"2017-06-07T03:28:18Z","updated_at":"2017-06-07T03:28:18Z","html_url":"https://github.com/servo/servo/pull/17077#discussion_r120527514","pull_request_url":"https://api.github.com/repos/servo/servo/pulls/17077","_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/comments/120527514"},"html":{"href":"https://github.com/servo/servo/pull/17077#discussion_r120527514"},"pull_request":{"href":"https://api.github.com/repos/servo/servo/pulls/17077"}}},"pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/17077","id":122901614,"html_url":"https://github.com/servo/servo/pull/17077","diff_url":"https://github.com/servo/servo/pull/17077.diff","patch_url":"https://github.com/servo/servo/pull/17077.patch","issue_url":"https://api.github.com/repos/servo/servo/issues/17077","number":17077,"state":"open","locked":false,"title":"Removed root browsing context from constellation","user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars2.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\nRemoved the special root browsing context from the constellation.\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [X] `./mach build -d` does not report any errors\r\n- [X] `./mach test-tidy` does not report any errors\r\n- [X] These changes fix #13994 \r\n- [X] These changes do not require tests because this isn't visible from user code\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/17077)\n<!-- Reviewable:end -->\n","created_at":"2017-05-29T14:06:11Z","updated_at":"2017-06-07T03:28:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3491968ccc11aae42247ed0a6866770fbe90c7","assignee":{"login":"cbrewster","id":9086315,"avatar_url":"https://avatars2.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrewster","html_url":"https://github.com/cbrewster","followers_url":"https://api.github.com/users/cbrewster/followers","following_url":"https://api.github.com/users/cbrewster/following{/other_user}","gists_url":"https://api.github.com/users/cbrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrewster/subscriptions","organizations_url":"https://api.github.com/users/cbrewster/orgs","repos_url":"https://api.github.com/users/cbrewster/repos","events_url":"https://api.github.com/users/cbrewster/events{/privacy}","received_events_url":"https://api.github.com/users/cbrewster/received_events","type":"User","site_admin":false},"assignees":[{"login":"cbrewster","id":9086315,"avatar_url":"https://avatars2.githubusercontent.com/u/9086315?v=3","gravatar_id":"","url":"https://api.github.com/users/cbrewster","html_url":"https://github.com/cbrewster","followers_url":"https://api.github.com/users/cbrewster/followers","following_url":"https://api.github.com/users/cbrewster/following{/other_user}","gists_url":"https://api.github.com/users/cbrewster/gists{/gist_id}","starred_url":"https://api.github.com/users/cbrewster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbrewster/subscriptions","organizations_url":"https://api.github.com/users/cbrewster/orgs","repos_url":"https://api.github.com/users/cbrewster/repos","events_url":"https://api.github.com/users/cbrewster/events{/privacy}","received_events_url":"https://api.github.com/users/cbrewster/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/servo/servo/pulls/17077/commits","review_comments_url":"https://api.github.com/repos/servo/servo/pulls/17077/comments","review_comment_url":"https://api.github.com/repos/servo/servo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/servo/servo/issues/17077/comments","statuses_url":"https://api.github.com/repos/servo/servo/statuses/8047f6a07fb050c1720e526712ccc32787482742","head":{"label":"asajeffrey:constellation-no-root-browsing-context","ref":"constellation-no-root-browsing-context","sha":"8047f6a07fb050c1720e526712ccc32787482742","user":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars2.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"repo":{"id":44559130,"name":"servo","full_name":"asajeffrey/servo","owner":{"login":"asajeffrey","id":403333,"avatar_url":"https://avatars2.githubusercontent.com/u/403333?v=3","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asajeffrey/servo","description":"The Servo Browser Engine","fork":true,"url":"https://api.github.com/repos/asajeffrey/servo","forks_url":"https://api.github.com/repos/asajeffrey/servo/forks","keys_url":"https://api.github.com/repos/asajeffrey/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asajeffrey/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asajeffrey/servo/teams","hooks_url":"https://api.github.com/repos/asajeffrey/servo/hooks","issue_events_url":"https://api.github.com/repos/asajeffrey/servo/issues/events{/number}","events_url":"https://api.github.com/repos/asajeffrey/servo/events","assignees_url":"https://api.github.com/repos/asajeffrey/servo/assignees{/user}","branches_url":"https://api.github.com/repos/asajeffrey/servo/branches{/branch}","tags_url":"https://api.github.com/repos/asajeffrey/servo/tags","blobs_url":"https://api.github.com/repos/asajeffrey/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asajeffrey/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asajeffrey/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/asajeffrey/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asajeffrey/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/asajeffrey/servo/languages","stargazers_url":"https://api.github.com/repos/asajeffrey/servo/stargazers","contributors_url":"https://api.github.com/repos/asajeffrey/servo/contributors","subscribers_url":"https://api.github.com/repos/asajeffrey/servo/subscribers","subscription_url":"https://api.github.com/repos/asajeffrey/servo/subscription","commits_url":"https://api.github.com/repos/asajeffrey/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/asajeffrey/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/asajeffrey/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/asajeffrey/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/asajeffrey/servo/contents/{+path}","compare_url":"https://api.github.com/repos/asajeffrey/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asajeffrey/servo/merges","archive_url":"https://api.github.com/repos/asajeffrey/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asajeffrey/servo/downloads","issues_url":"https://api.github.com/repos/asajeffrey/servo/issues{/number}","pulls_url":"https://api.github.com/repos/asajeffrey/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/asajeffrey/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/asajeffrey/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asajeffrey/servo/labels{/name}","releases_url":"https://api.github.com/repos/asajeffrey/servo/releases{/id}","deployments_url":"https://api.github.com/repos/asajeffrey/servo/deployments","created_at":"2015-10-19T19:40:43Z","updated_at":"2016-01-18T23:24:06Z","pushed_at":"2017-06-06T21:32:31Z","git_url":"git://github.com/asajeffrey/servo.git","ssh_url":"git@github.com:asajeffrey/servo.git","clone_url":"https://github.com/asajeffrey/servo.git","svn_url":"https://github.com/asajeffrey/servo","homepage":"","size":280020,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"servo:master","ref":"master","sha":"86dcd5366f18ab01fa309c976a895effdd959fa8","user":{"login":"servo","id":2566135,"avatar_url":"https://avatars2.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"repo":{"id":3390243,"name":"servo","full_name":"servo/servo","owner":{"login":"servo","id":2566135,"avatar_url":"https://avatars2.githubusercontent.com/u/2566135?v=3","gravatar_id":"","url":"https://api.github.com/users/servo","html_url":"https://github.com/servo","followers_url":"https://api.github.com/users/servo/followers","following_url":"https://api.github.com/users/servo/following{/other_user}","gists_url":"https://api.github.com/users/servo/gists{/gist_id}","starred_url":"https://api.github.com/users/servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/servo/subscriptions","organizations_url":"https://api.github.com/users/servo/orgs","repos_url":"https://api.github.com/users/servo/repos","events_url":"https://api.github.com/users/servo/events{/privacy}","received_events_url":"https://api.github.com/users/servo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/servo/servo","description":"The Servo Browser Engine","fork":false,"url":"https://api.github.com/repos/servo/servo","forks_url":"https://api.github.com/repos/servo/servo/forks","keys_url":"https://api.github.com/repos/servo/servo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/servo/servo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/servo/servo/teams","hooks_url":"https://api.github.com/repos/servo/servo/hooks","issue_events_url":"https://api.github.com/repos/servo/servo/issues/events{/number}","events_url":"https://api.github.com/repos/servo/servo/events","assignees_url":"https://api.github.com/repos/servo/servo/assignees{/user}","branches_url":"https://api.github.com/repos/servo/servo/branches{/branch}","tags_url":"https://api.github.com/repos/servo/servo/tags","blobs_url":"https://api.github.com/repos/servo/servo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/servo/servo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/servo/servo/git/refs{/sha}","trees_url":"https://api.github.com/repos/servo/servo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/servo/servo/statuses/{sha}","languages_url":"https://api.github.com/repos/servo/servo/languages","stargazers_url":"https://api.github.com/repos/servo/servo/stargazers","contributors_url":"https://api.github.com/repos/servo/servo/contributors","subscribers_url":"https://api.github.com/repos/servo/servo/subscribers","subscription_url":"https://api.github.com/repos/servo/servo/subscription","commits_url":"https://api.github.com/repos/servo/servo/commits{/sha}","git_commits_url":"https://api.github.com/repos/servo/servo/git/commits{/sha}","comments_url":"https://api.github.com/repos/servo/servo/comments{/number}","issue_comment_url":"https://api.github.com/repos/servo/servo/issues/comments{/number}","contents_url":"https://api.github.com/repos/servo/servo/contents/{+path}","compare_url":"https://api.github.com/repos/servo/servo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/servo/servo/merges","archive_url":"https://api.github.com/repos/servo/servo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/servo/servo/downloads","issues_url":"https://api.github.com/repos/servo/servo/issues{/number}","pulls_url":"https://api.github.com/repos/servo/servo/pulls{/number}","milestones_url":"https://api.github.com/repos/servo/servo/milestones{/number}","notifications_url":"https://api.github.com/repos/servo/servo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/servo/servo/labels{/name}","releases_url":"https://api.github.com/repos/servo/servo/releases{/id}","deployments_url":"https://api.github.com/repos/servo/servo/deployments","created_at":"2012-02-08T19:07:25Z","updated_at":"2017-06-07T02:51:49Z","pushed_at":"2017-06-07T03:26:20Z","git_url":"git://github.com/servo/servo.git","ssh_url":"git@github.com:servo/servo.git","clone_url":"https://github.com/servo/servo.git","svn_url":"https://github.com/servo/servo","homepage":"https://servo.org/","size":346798,"stargazers_count":9498,"watchers_count":9498,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1627,"mirror_url":null,"open_issues_count":2176,"forks":1627,"open_issues":2176,"watchers":9498,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/servo/servo/pulls/17077"},"html":{"href":"https://github.com/servo/servo/pull/17077"},"issue":{"href":"https://api.github.com/repos/servo/servo/issues/17077"},"comments":{"href":"https://api.github.com/repos/servo/servo/issues/17077/comments"},"review_comments":{"href":"https://api.github.com/repos/servo/servo/pulls/17077/comments"},"review_comment":{"href":"https://api.github.com/repos/servo/servo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/servo/servo/pulls/17077/commits"},"statuses":{"href":"https://api.github.com/repos/servo/servo/statuses/8047f6a07fb050c1720e526712ccc32787482742"}}}}
|
{
"id": 3390243,
"name": "servo/servo",
"url": "https://api.github.com/repos/servo/servo"
}
|
{
"id": 9086315,
"login": "cbrewster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9086315?",
"url": "https://api.github.com/users/cbrewster"
}
|
{
"id": 2566135,
"login": "servo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2566135?",
"url": "https://api.github.com/orgs/servo"
}
| 2017-06-07T03:28:18 |
6015715623
|
{"actor":{"display_login":"cbrewster"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/comments/121799570","pull_request_review_id":43857979,"id":121799570,"diff_hunk":"@@ -3,6 +3,15 @@\n \n Dir[__dir__ + '/betagouvbot/**/*.rb'].sort.each(&method(:require))\n \n+require 'active_support/core_ext/hash/indifferent_access'","path":"lib/betagouvbot.rb","position":4,"original_position":4,"commit_id":"3f1f9f7f72f136972f76cb87fc1a3d1317463912","original_commit_id":"39159d7985dd6e2a8f2b8af261a2fc9cade854d4","user":{"login":"Morendil","id":216452,"avatar_url":"https://avatars1.githubusercontent.com/u/216452?v=3","gravatar_id":"","url":"https://api.github.com/users/Morendil","html_url":"https://github.com/Morendil","followers_url":"https://api.github.com/users/Morendil/followers","following_url":"https://api.github.com/users/Morendil/following{/other_user}","gists_url":"https://api.github.com/users/Morendil/gists{/gist_id}","starred_url":"https://api.github.com/users/Morendil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morendil/subscriptions","organizations_url":"https://api.github.com/users/Morendil/orgs","repos_url":"https://api.github.com/users/Morendil/repos","events_url":"https://api.github.com/users/Morendil/events{/privacy}","received_events_url":"https://api.github.com/users/Morendil/received_events","type":"User","site_admin":false},"body":"What's the benefit?","created_at":"2017-06-13T21:18:45Z","updated_at":"2017-06-13T21:18:45Z","html_url":"https://github.com/sgmap/betaGouvBot/pull/83#discussion_r121799570","pull_request_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/comments/121799570"},"html":{"href":"https://github.com/sgmap/betaGouvBot/pull/83#discussion_r121799570"},"pull_request":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83","id":125021411,"html_url":"https://github.com/sgmap/betaGouvBot/pull/83","diff_url":"https://github.com/sgmap/betaGouvBot/pull/83.diff","patch_url":"https://github.com/sgmap/betaGouvBot/pull/83.patch","issue_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/83","number":83,"state":"open","locked":false,"title":"Redistribute responsibilities for sending out notifications","user":{"login":"Morendil","id":216452,"avatar_url":"https://avatars1.githubusercontent.com/u/216452?v=3","gravatar_id":"","url":"https://api.github.com/users/Morendil","html_url":"https://github.com/Morendil","followers_url":"https://api.github.com/users/Morendil/followers","following_url":"https://api.github.com/users/Morendil/following{/other_user}","gists_url":"https://api.github.com/users/Morendil/gists{/gist_id}","starred_url":"https://api.github.com/users/Morendil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Morendil/subscriptions","organizations_url":"https://api.github.com/users/Morendil/orgs","repos_url":"https://api.github.com/users/Morendil/repos","events_url":"https://api.github.com/users/Morendil/events{/privacy}","received_events_url":"https://api.github.com/users/Morendil/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-11T10:46:12Z","updated_at":"2017-06-13T21:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f66402f0b0dc21b0ee0b85ea914efea79723b8ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83/commits","review_comments_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83/comments","review_comment_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/83/comments","statuses_url":"https://api.github.com/repos/sgmap/betaGouvBot/statuses/3f1f9f7f72f136972f76cb87fc1a3d1317463912","head":{"label":"sgmap:remove-anticipator","ref":"remove-anticipator","sha":"3f1f9f7f72f136972f76cb87fc1a3d1317463912","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":67072865,"name":"betaGouvBot","full_name":"sgmap/betaGouvBot","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/betaGouvBot","description":"Automated assistant for beta.gouv.fr administrative tasks.","fork":false,"url":"https://api.github.com/repos/sgmap/betaGouvBot","forks_url":"https://api.github.com/repos/sgmap/betaGouvBot/forks","keys_url":"https://api.github.com/repos/sgmap/betaGouvBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/betaGouvBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/betaGouvBot/teams","hooks_url":"https://api.github.com/repos/sgmap/betaGouvBot/hooks","issue_events_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/betaGouvBot/events","assignees_url":"https://api.github.com/repos/sgmap/betaGouvBot/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/betaGouvBot/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/betaGouvBot/tags","blobs_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/betaGouvBot/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/betaGouvBot/languages","stargazers_url":"https://api.github.com/repos/sgmap/betaGouvBot/stargazers","contributors_url":"https://api.github.com/repos/sgmap/betaGouvBot/contributors","subscribers_url":"https://api.github.com/repos/sgmap/betaGouvBot/subscribers","subscription_url":"https://api.github.com/repos/sgmap/betaGouvBot/subscription","commits_url":"https://api.github.com/repos/sgmap/betaGouvBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/betaGouvBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/betaGouvBot/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/betaGouvBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/betaGouvBot/merges","archive_url":"https://api.github.com/repos/sgmap/betaGouvBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/betaGouvBot/downloads","issues_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/betaGouvBot/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/betaGouvBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/betaGouvBot/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/betaGouvBot/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/betaGouvBot/deployments","created_at":"2016-08-31T20:55:18Z","updated_at":"2017-05-03T13:12:13Z","pushed_at":"2017-06-13T21:08:47Z","git_url":"git://github.com/sgmap/betaGouvBot.git","ssh_url":"git@github.com:sgmap/betaGouvBot.git","clone_url":"https://github.com/sgmap/betaGouvBot.git","svn_url":"https://github.com/sgmap/betaGouvBot","homepage":"https://beta.gouv.fr","size":233,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":1,"default_branch":"master"}},"base":{"label":"sgmap:master","ref":"master","sha":"d48b6b5b5c0d6736166edc8272ab0cee2d034b63","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":67072865,"name":"betaGouvBot","full_name":"sgmap/betaGouvBot","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/betaGouvBot","description":"Automated assistant for beta.gouv.fr administrative tasks.","fork":false,"url":"https://api.github.com/repos/sgmap/betaGouvBot","forks_url":"https://api.github.com/repos/sgmap/betaGouvBot/forks","keys_url":"https://api.github.com/repos/sgmap/betaGouvBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/betaGouvBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/betaGouvBot/teams","hooks_url":"https://api.github.com/repos/sgmap/betaGouvBot/hooks","issue_events_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/betaGouvBot/events","assignees_url":"https://api.github.com/repos/sgmap/betaGouvBot/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/betaGouvBot/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/betaGouvBot/tags","blobs_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/betaGouvBot/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/betaGouvBot/languages","stargazers_url":"https://api.github.com/repos/sgmap/betaGouvBot/stargazers","contributors_url":"https://api.github.com/repos/sgmap/betaGouvBot/contributors","subscribers_url":"https://api.github.com/repos/sgmap/betaGouvBot/subscribers","subscription_url":"https://api.github.com/repos/sgmap/betaGouvBot/subscription","commits_url":"https://api.github.com/repos/sgmap/betaGouvBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/betaGouvBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/betaGouvBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/betaGouvBot/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/betaGouvBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/betaGouvBot/merges","archive_url":"https://api.github.com/repos/sgmap/betaGouvBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/betaGouvBot/downloads","issues_url":"https://api.github.com/repos/sgmap/betaGouvBot/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/betaGouvBot/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/betaGouvBot/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/betaGouvBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/betaGouvBot/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/betaGouvBot/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/betaGouvBot/deployments","created_at":"2016-08-31T20:55:18Z","updated_at":"2017-05-03T13:12:13Z","pushed_at":"2017-06-13T21:08:47Z","git_url":"git://github.com/sgmap/betaGouvBot.git","ssh_url":"git@github.com:sgmap/betaGouvBot.git","clone_url":"https://github.com/sgmap/betaGouvBot.git","svn_url":"https://github.com/sgmap/betaGouvBot","homepage":"https://beta.gouv.fr","size":233,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":13,"forks":4,"open_issues":13,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83"},"html":{"href":"https://github.com/sgmap/betaGouvBot/pull/83"},"issue":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/issues/83"},"comments":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/sgmap/betaGouvBot/statuses/3f1f9f7f72f136972f76cb87fc1a3d1317463912"}}}}
|
{
"id": 67072865,
"name": "sgmap/betaGouvBot",
"url": "https://api.github.com/repos/sgmap/betaGouvBot"
}
|
{
"id": 216452,
"login": "Morendil",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/216452?",
"url": "https://api.github.com/users/Morendil"
}
|
{
"id": 7874148,
"login": "sgmap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7874148?",
"url": "https://api.github.com/orgs/sgmap"
}
| 2017-06-13T21:18:45 |
6059136842
|
{"actor":{"display_login":"Morendil"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/comments/110853784","pull_request_review_id":32053780,"id":110853784,"diff_hunk":"@@ -29,6 +29,14 @@ install_manifest() { # $1 = name of the manifest file\n curl --location --remote-name https://raw.githubusercontent.com/$MANIFESTS_SOURCE_REPOSITORY/$MANIFESTS_SOURCE_FOLDER/$1.pp --output $BOOTSTRAP_MANIFESTS_DESTINATION_FOLDER\n }\n \n+function run_puppet {\n+ set +e\n+ puppet apply --detailed-exitcodes --verbose $@","path":"bootstrap.sh","position":6,"original_position":6,"commit_id":"2092644ba098d9d0940fee871d3c804e519b4202","original_commit_id":"2092644ba098d9d0940fee871d3c804e519b4202","user":{"login":"MattiSG","id":222463,"avatar_url":"https://avatars0.githubusercontent.com/u/222463?v=3","gravatar_id":"","url":"https://api.github.com/users/MattiSG","html_url":"https://github.com/MattiSG","followers_url":"https://api.github.com/users/MattiSG/followers","following_url":"https://api.github.com/users/MattiSG/following{/other_user}","gists_url":"https://api.github.com/users/MattiSG/gists{/gist_id}","starred_url":"https://api.github.com/users/MattiSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattiSG/subscriptions","organizations_url":"https://api.github.com/users/MattiSG/orgs","repos_url":"https://api.github.com/users/MattiSG/repos","events_url":"https://api.github.com/users/MattiSG/events{/privacy}","received_events_url":"https://api.github.com/users/MattiSG/received_events","type":"User","site_admin":false},"body":"Nope, I really meant `\"$@\"`, with quotes around `$@` :wink: See http://linuxsig.org/files/bash_scripting.html.","created_at":"2017-04-11T09:23:54Z","updated_at":"2017-04-11T09:25:55Z","html_url":"https://github.com/sgmap/mes-aides-ops/pull/13#discussion_r110853784","pull_request_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/comments/110853784"},"html":{"href":"https://github.com/sgmap/mes-aides-ops/pull/13#discussion_r110853784"},"pull_request":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13","id":113378388,"html_url":"https://github.com/sgmap/mes-aides-ops/pull/13","diff_url":"https://github.com/sgmap/mes-aides-ops/pull/13.diff","patch_url":"https://github.com/sgmap/mes-aides-ops/pull/13.patch","issue_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/13","number":13,"state":"open","locked":false,"title":"Ensure puppet failures are visible.","user":{"login":"guillett","id":1410356,"avatar_url":"https://avatars3.githubusercontent.com/u/1410356?v=3","gravatar_id":"","url":"https://api.github.com/users/guillett","html_url":"https://github.com/guillett","followers_url":"https://api.github.com/users/guillett/followers","following_url":"https://api.github.com/users/guillett/following{/other_user}","gists_url":"https://api.github.com/users/guillett/gists{/gist_id}","starred_url":"https://api.github.com/users/guillett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillett/subscriptions","organizations_url":"https://api.github.com/users/guillett/orgs","repos_url":"https://api.github.com/users/guillett/repos","events_url":"https://api.github.com/users/guillett/events{/privacy}","received_events_url":"https://api.github.com/users/guillett/received_events","type":"User","site_admin":false},"body":"Depends on #7, #8, #11 and #12. Fixes #10.","created_at":"2017-03-30T09:01:48Z","updated_at":"2017-04-11T09:25:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fbaf29333adc0076dc7c113340987f0cc050be8","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13/commits","review_comments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13/comments","review_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/13/comments","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ops/statuses/2092644ba098d9d0940fee871d3c804e519b4202","head":{"label":"sgmap:enforce_failure","ref":"enforce_failure","sha":"2092644ba098d9d0940fee871d3c804e519b4202","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":65657838,"name":"mes-aides-ops","full_name":"sgmap/mes-aides-ops","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/mes-aides-ops","description":"Stack setup for Mes Aides","fork":false,"url":"https://api.github.com/repos/sgmap/mes-aides-ops","forks_url":"https://api.github.com/repos/sgmap/mes-aides-ops/forks","keys_url":"https://api.github.com/repos/sgmap/mes-aides-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/mes-aides-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/mes-aides-ops/teams","hooks_url":"https://api.github.com/repos/sgmap/mes-aides-ops/hooks","issue_events_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/mes-aides-ops/events","assignees_url":"https://api.github.com/repos/sgmap/mes-aides-ops/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/mes-aides-ops/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/mes-aides-ops/tags","blobs_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/mes-aides-ops/languages","stargazers_url":"https://api.github.com/repos/sgmap/mes-aides-ops/stargazers","contributors_url":"https://api.github.com/repos/sgmap/mes-aides-ops/contributors","subscribers_url":"https://api.github.com/repos/sgmap/mes-aides-ops/subscribers","subscription_url":"https://api.github.com/repos/sgmap/mes-aides-ops/subscription","commits_url":"https://api.github.com/repos/sgmap/mes-aides-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/mes-aides-ops/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/mes-aides-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/mes-aides-ops/merges","archive_url":"https://api.github.com/repos/sgmap/mes-aides-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/mes-aides-ops/downloads","issues_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/mes-aides-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/mes-aides-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/mes-aides-ops/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/mes-aides-ops/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/deployments","created_at":"2016-08-14T08:48:57Z","updated_at":"2017-03-21T14:18:59Z","pushed_at":"2017-04-10T16:02:42Z","git_url":"git://github.com/sgmap/mes-aides-ops.git","ssh_url":"git@github.com:sgmap/mes-aides-ops.git","clone_url":"https://github.com/sgmap/mes-aides-ops.git","svn_url":"https://github.com/sgmap/mes-aides-ops","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"sgmap:continuous_deployment","ref":"continuous_deployment","sha":"fb3858eebc0beb2b0027b8653c850eaae8299f03","user":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"repo":{"id":65657838,"name":"mes-aides-ops","full_name":"sgmap/mes-aides-ops","owner":{"login":"sgmap","id":7874148,"avatar_url":"https://avatars3.githubusercontent.com/u/7874148?v=3","gravatar_id":"","url":"https://api.github.com/users/sgmap","html_url":"https://github.com/sgmap","followers_url":"https://api.github.com/users/sgmap/followers","following_url":"https://api.github.com/users/sgmap/following{/other_user}","gists_url":"https://api.github.com/users/sgmap/gists{/gist_id}","starred_url":"https://api.github.com/users/sgmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgmap/subscriptions","organizations_url":"https://api.github.com/users/sgmap/orgs","repos_url":"https://api.github.com/users/sgmap/repos","events_url":"https://api.github.com/users/sgmap/events{/privacy}","received_events_url":"https://api.github.com/users/sgmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sgmap/mes-aides-ops","description":"Stack setup for Mes Aides","fork":false,"url":"https://api.github.com/repos/sgmap/mes-aides-ops","forks_url":"https://api.github.com/repos/sgmap/mes-aides-ops/forks","keys_url":"https://api.github.com/repos/sgmap/mes-aides-ops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgmap/mes-aides-ops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgmap/mes-aides-ops/teams","hooks_url":"https://api.github.com/repos/sgmap/mes-aides-ops/hooks","issue_events_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/events{/number}","events_url":"https://api.github.com/repos/sgmap/mes-aides-ops/events","assignees_url":"https://api.github.com/repos/sgmap/mes-aides-ops/assignees{/user}","branches_url":"https://api.github.com/repos/sgmap/mes-aides-ops/branches{/branch}","tags_url":"https://api.github.com/repos/sgmap/mes-aides-ops/tags","blobs_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgmap/mes-aides-ops/statuses/{sha}","languages_url":"https://api.github.com/repos/sgmap/mes-aides-ops/languages","stargazers_url":"https://api.github.com/repos/sgmap/mes-aides-ops/stargazers","contributors_url":"https://api.github.com/repos/sgmap/mes-aides-ops/contributors","subscribers_url":"https://api.github.com/repos/sgmap/mes-aides-ops/subscribers","subscription_url":"https://api.github.com/repos/sgmap/mes-aides-ops/subscription","commits_url":"https://api.github.com/repos/sgmap/mes-aides-ops/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgmap/mes-aides-ops/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgmap/mes-aides-ops/contents/{+path}","compare_url":"https://api.github.com/repos/sgmap/mes-aides-ops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgmap/mes-aides-ops/merges","archive_url":"https://api.github.com/repos/sgmap/mes-aides-ops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgmap/mes-aides-ops/downloads","issues_url":"https://api.github.com/repos/sgmap/mes-aides-ops/issues{/number}","pulls_url":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls{/number}","milestones_url":"https://api.github.com/repos/sgmap/mes-aides-ops/milestones{/number}","notifications_url":"https://api.github.com/repos/sgmap/mes-aides-ops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgmap/mes-aides-ops/labels{/name}","releases_url":"https://api.github.com/repos/sgmap/mes-aides-ops/releases{/id}","deployments_url":"https://api.github.com/repos/sgmap/mes-aides-ops/deployments","created_at":"2016-08-14T08:48:57Z","updated_at":"2017-03-21T14:18:59Z","pushed_at":"2017-04-10T16:02:42Z","git_url":"git://github.com/sgmap/mes-aides-ops.git","ssh_url":"git@github.com:sgmap/mes-aides-ops.git","clone_url":"https://github.com/sgmap/mes-aides-ops.git","svn_url":"https://github.com/sgmap/mes-aides-ops","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13"},"html":{"href":"https://github.com/sgmap/mes-aides-ops/pull/13"},"issue":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/13"},"comments":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/sgmap/mes-aides-ops/statuses/2092644ba098d9d0940fee871d3c804e519b4202"}}}}
|
{
"id": 65657838,
"name": "sgmap/mes-aides-ops",
"url": "https://api.github.com/repos/sgmap/mes-aides-ops"
}
|
{
"id": 222463,
"login": "MattiSG",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/222463?",
"url": "https://api.github.com/users/MattiSG"
}
|
{
"id": 7874148,
"login": "sgmap",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7874148?",
"url": "https://api.github.com/orgs/sgmap"
}
| 2017-04-11T09:23:54 |
5666242510
|
{"actor":{"display_login":"MattiSG"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/src-d/docsrv/pulls/comments/120607055","pull_request_review_id":42582276,"id":120607055,"diff_hunk":"@@ -1,3 +1,79 @@\n+# Default shell\n+SHELL := /bin/sh\n+\n+# Global CI\n+LANGUAGES := go\n+# Global CI. Do not edit\n+MAKEFILE := Makefile.docs\n+CI_REPO_URL := https://github.com/src-d/ci.git\n+SHARED_PATH ?= /etc/shared\n+CI_PATH ?= $(SHARED_PATH)/ci\n+\n+$(MAKEFILE):\n+\t@if [ ! -r \"./$(MAKEFILE)\" ]; then \\\n+\t\tif [ ! -r \"$(CI_PATH)/$(MAKEFILE)\" ]; then \\\n+\t\t\techo \"Downloading 'ci'...\"; \\\n+\t\t\trm -rf \"$(CI_PATH)\"; \\\n+\t\t\tmkdir -p \"$(CI_PATH)\"; \\\n+\t\t\tgit clone \"$(CI_REPO_URL)\" \"$(CI_PATH)\"; \\\n+\t\tfi; \\\n+\t\techo \"Installing 'ci'...\"; \\\n+\t\tcp $(CI_PATH)/$(MAKEFILE) .; \\\n+\tfi; \\\n+\n+-include $(MAKEFILE)\n+\n+# Conf vars\n+GITHUB_API_KEY ?=\n+LOGS_PATH ?= /var/log/docsrv\n+LANDING_PATH ?= $(SHARED_PATH)/landing\n+INIT_PATH ?= $(shell pwd)/../ci/docs/init.d\n+CONF_PATH ?= $(shell pwd)/../ci/docs/conf.d\n+\n+#vars\n+docker_container_name = docsrv-instance\n+docker_image_name = docsrv-image\n+\n+#tools\n+mkdir := mkdir -p\n+goBuild := CGO_ENABLED=0 go build -o\n+remove := rm -rf\n+dockerRun := docker run --detach","path":"Makefile","position":41,"original_position":41,"commit_id":"d9f0c5f4c44f78e86c2a91ae6958bab57afb0146","original_commit_id":"d9f0c5f4c44f78e86c2a91ae6958bab57afb0146","user":{"login":"erizocosmico","id":1312023,"avatar_url":"https://avatars2.githubusercontent.com/u/1312023?v=3","gravatar_id":"","url":"https://api.github.com/users/erizocosmico","html_url":"https://github.com/erizocosmico","followers_url":"https://api.github.com/users/erizocosmico/followers","following_url":"https://api.github.com/users/erizocosmico/following{/other_user}","gists_url":"https://api.github.com/users/erizocosmico/gists{/gist_id}","starred_url":"https://api.github.com/users/erizocosmico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erizocosmico/subscriptions","organizations_url":"https://api.github.com/users/erizocosmico/orgs","repos_url":"https://api.github.com/users/erizocosmico/repos","events_url":"https://api.github.com/users/erizocosmico/events{/privacy}","received_events_url":"https://api.github.com/users/erizocosmico/received_events","type":"User","site_admin":false},"body":"s/dockerRun/docker_run/","created_at":"2017-06-07T12:07:46Z","updated_at":"2017-06-07T12:08:42Z","html_url":"https://github.com/src-d/docsrv/pull/13#discussion_r120607055","pull_request_url":"https://api.github.com/repos/src-d/docsrv/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/comments/120607055"},"html":{"href":"https://github.com/src-d/docsrv/pull/13#discussion_r120607055"},"pull_request":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/src-d/docsrv/pulls/13","id":123210922,"html_url":"https://github.com/src-d/docsrv/pull/13","diff_url":"https://github.com/src-d/docsrv/pull/13.diff","patch_url":"https://github.com/src-d/docsrv/pull/13.patch","issue_url":"https://api.github.com/repos/src-d/docsrv/issues/13","number":13,"state":"open","locked":false,"title":"Add a development rule to launch docker container","user":{"login":"dpordomingo","id":2437584,"avatar_url":"https://avatars1.githubusercontent.com/u/2437584?v=3","gravatar_id":"","url":"https://api.github.com/users/dpordomingo","html_url":"https://github.com/dpordomingo","followers_url":"https://api.github.com/users/dpordomingo/followers","following_url":"https://api.github.com/users/dpordomingo/following{/other_user}","gists_url":"https://api.github.com/users/dpordomingo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpordomingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpordomingo/subscriptions","organizations_url":"https://api.github.com/users/dpordomingo/orgs","repos_url":"https://api.github.com/users/dpordomingo/repos","events_url":"https://api.github.com/users/dpordomingo/events{/privacy}","received_events_url":"https://api.github.com/users/dpordomingo/received_events","type":"User","site_admin":false},"body":"depends on https://github.com/src-d/docsrv/pull/20\r\n\r\nuseful as readed from the `README.md`","created_at":"2017-05-31T07:38:03Z","updated_at":"2017-06-07T12:08:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af6e6934aea5728b76454f605e71914c79a44af6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcuadros","id":1573114,"avatar_url":"https://avatars3.githubusercontent.com/u/1573114?v=3","gravatar_id":"","url":"https://api.github.com/users/mcuadros","html_url":"https://github.com/mcuadros","followers_url":"https://api.github.com/users/mcuadros/followers","following_url":"https://api.github.com/users/mcuadros/following{/other_user}","gists_url":"https://api.github.com/users/mcuadros/gists{/gist_id}","starred_url":"https://api.github.com/users/mcuadros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcuadros/subscriptions","organizations_url":"https://api.github.com/users/mcuadros/orgs","repos_url":"https://api.github.com/users/mcuadros/repos","events_url":"https://api.github.com/users/mcuadros/events{/privacy}","received_events_url":"https://api.github.com/users/mcuadros/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/src-d/docsrv/pulls/13/commits","review_comments_url":"https://api.github.com/repos/src-d/docsrv/pulls/13/comments","review_comment_url":"https://api.github.com/repos/src-d/docsrv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/src-d/docsrv/issues/13/comments","statuses_url":"https://api.github.com/repos/src-d/docsrv/statuses/d9f0c5f4c44f78e86c2a91ae6958bab57afb0146","head":{"label":"dpordomingo:develMakeRule","ref":"develMakeRule","sha":"d9f0c5f4c44f78e86c2a91ae6958bab57afb0146","user":{"login":"dpordomingo","id":2437584,"avatar_url":"https://avatars1.githubusercontent.com/u/2437584?v=3","gravatar_id":"","url":"https://api.github.com/users/dpordomingo","html_url":"https://github.com/dpordomingo","followers_url":"https://api.github.com/users/dpordomingo/followers","following_url":"https://api.github.com/users/dpordomingo/following{/other_user}","gists_url":"https://api.github.com/users/dpordomingo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpordomingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpordomingo/subscriptions","organizations_url":"https://api.github.com/users/dpordomingo/orgs","repos_url":"https://api.github.com/users/dpordomingo/repos","events_url":"https://api.github.com/users/dpordomingo/events{/privacy}","received_events_url":"https://api.github.com/users/dpordomingo/received_events","type":"User","site_admin":false},"repo":{"id":92796687,"name":"docsrv","full_name":"dpordomingo/docsrv","owner":{"login":"dpordomingo","id":2437584,"avatar_url":"https://avatars1.githubusercontent.com/u/2437584?v=3","gravatar_id":"","url":"https://api.github.com/users/dpordomingo","html_url":"https://github.com/dpordomingo","followers_url":"https://api.github.com/users/dpordomingo/followers","following_url":"https://api.github.com/users/dpordomingo/following{/other_user}","gists_url":"https://api.github.com/users/dpordomingo/gists{/gist_id}","starred_url":"https://api.github.com/users/dpordomingo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpordomingo/subscriptions","organizations_url":"https://api.github.com/users/dpordomingo/orgs","repos_url":"https://api.github.com/users/dpordomingo/repos","events_url":"https://api.github.com/users/dpordomingo/events{/privacy}","received_events_url":"https://api.github.com/users/dpordomingo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpordomingo/docsrv","description":"docsrv is an app to serve versioned documentation for GitHub projects on demand","fork":true,"url":"https://api.github.com/repos/dpordomingo/docsrv","forks_url":"https://api.github.com/repos/dpordomingo/docsrv/forks","keys_url":"https://api.github.com/repos/dpordomingo/docsrv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpordomingo/docsrv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpordomingo/docsrv/teams","hooks_url":"https://api.github.com/repos/dpordomingo/docsrv/hooks","issue_events_url":"https://api.github.com/repos/dpordomingo/docsrv/issues/events{/number}","events_url":"https://api.github.com/repos/dpordomingo/docsrv/events","assignees_url":"https://api.github.com/repos/dpordomingo/docsrv/assignees{/user}","branches_url":"https://api.github.com/repos/dpordomingo/docsrv/branches{/branch}","tags_url":"https://api.github.com/repos/dpordomingo/docsrv/tags","blobs_url":"https://api.github.com/repos/dpordomingo/docsrv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpordomingo/docsrv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpordomingo/docsrv/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpordomingo/docsrv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpordomingo/docsrv/statuses/{sha}","languages_url":"https://api.github.com/repos/dpordomingo/docsrv/languages","stargazers_url":"https://api.github.com/repos/dpordomingo/docsrv/stargazers","contributors_url":"https://api.github.com/repos/dpordomingo/docsrv/contributors","subscribers_url":"https://api.github.com/repos/dpordomingo/docsrv/subscribers","subscription_url":"https://api.github.com/repos/dpordomingo/docsrv/subscription","commits_url":"https://api.github.com/repos/dpordomingo/docsrv/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpordomingo/docsrv/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpordomingo/docsrv/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpordomingo/docsrv/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpordomingo/docsrv/contents/{+path}","compare_url":"https://api.github.com/repos/dpordomingo/docsrv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpordomingo/docsrv/merges","archive_url":"https://api.github.com/repos/dpordomingo/docsrv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpordomingo/docsrv/downloads","issues_url":"https://api.github.com/repos/dpordomingo/docsrv/issues{/number}","pulls_url":"https://api.github.com/repos/dpordomingo/docsrv/pulls{/number}","milestones_url":"https://api.github.com/repos/dpordomingo/docsrv/milestones{/number}","notifications_url":"https://api.github.com/repos/dpordomingo/docsrv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpordomingo/docsrv/labels{/name}","releases_url":"https://api.github.com/repos/dpordomingo/docsrv/releases{/id}","deployments_url":"https://api.github.com/repos/dpordomingo/docsrv/deployments","created_at":"2017-05-30T04:03:50Z","updated_at":"2017-05-30T04:03:52Z","pushed_at":"2017-06-07T09:30:44Z","git_url":"git://github.com/dpordomingo/docsrv.git","ssh_url":"git@github.com:dpordomingo/docsrv.git","clone_url":"https://github.com/dpordomingo/docsrv.git","svn_url":"https://github.com/dpordomingo/docsrv","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"src-d:master","ref":"master","sha":"b86ff832730e0db3db11d004320ea2f0c4f77329","user":{"login":"src-d","id":15128793,"avatar_url":"https://avatars1.githubusercontent.com/u/15128793?v=3","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"repo":{"id":91670242,"name":"docsrv","full_name":"src-d/docsrv","owner":{"login":"src-d","id":15128793,"avatar_url":"https://avatars1.githubusercontent.com/u/15128793?v=3","gravatar_id":"","url":"https://api.github.com/users/src-d","html_url":"https://github.com/src-d","followers_url":"https://api.github.com/users/src-d/followers","following_url":"https://api.github.com/users/src-d/following{/other_user}","gists_url":"https://api.github.com/users/src-d/gists{/gist_id}","starred_url":"https://api.github.com/users/src-d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/src-d/subscriptions","organizations_url":"https://api.github.com/users/src-d/orgs","repos_url":"https://api.github.com/users/src-d/repos","events_url":"https://api.github.com/users/src-d/events{/privacy}","received_events_url":"https://api.github.com/users/src-d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/src-d/docsrv","description":"docsrv is an app to serve versioned documentation for GitHub projects on demand","fork":false,"url":"https://api.github.com/repos/src-d/docsrv","forks_url":"https://api.github.com/repos/src-d/docsrv/forks","keys_url":"https://api.github.com/repos/src-d/docsrv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/src-d/docsrv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/src-d/docsrv/teams","hooks_url":"https://api.github.com/repos/src-d/docsrv/hooks","issue_events_url":"https://api.github.com/repos/src-d/docsrv/issues/events{/number}","events_url":"https://api.github.com/repos/src-d/docsrv/events","assignees_url":"https://api.github.com/repos/src-d/docsrv/assignees{/user}","branches_url":"https://api.github.com/repos/src-d/docsrv/branches{/branch}","tags_url":"https://api.github.com/repos/src-d/docsrv/tags","blobs_url":"https://api.github.com/repos/src-d/docsrv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/src-d/docsrv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/src-d/docsrv/git/refs{/sha}","trees_url":"https://api.github.com/repos/src-d/docsrv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/src-d/docsrv/statuses/{sha}","languages_url":"https://api.github.com/repos/src-d/docsrv/languages","stargazers_url":"https://api.github.com/repos/src-d/docsrv/stargazers","contributors_url":"https://api.github.com/repos/src-d/docsrv/contributors","subscribers_url":"https://api.github.com/repos/src-d/docsrv/subscribers","subscription_url":"https://api.github.com/repos/src-d/docsrv/subscription","commits_url":"https://api.github.com/repos/src-d/docsrv/commits{/sha}","git_commits_url":"https://api.github.com/repos/src-d/docsrv/git/commits{/sha}","comments_url":"https://api.github.com/repos/src-d/docsrv/comments{/number}","issue_comment_url":"https://api.github.com/repos/src-d/docsrv/issues/comments{/number}","contents_url":"https://api.github.com/repos/src-d/docsrv/contents/{+path}","compare_url":"https://api.github.com/repos/src-d/docsrv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/src-d/docsrv/merges","archive_url":"https://api.github.com/repos/src-d/docsrv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/src-d/docsrv/downloads","issues_url":"https://api.github.com/repos/src-d/docsrv/issues{/number}","pulls_url":"https://api.github.com/repos/src-d/docsrv/pulls{/number}","milestones_url":"https://api.github.com/repos/src-d/docsrv/milestones{/number}","notifications_url":"https://api.github.com/repos/src-d/docsrv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/src-d/docsrv/labels{/name}","releases_url":"https://api.github.com/repos/src-d/docsrv/releases{/id}","deployments_url":"https://api.github.com/repos/src-d/docsrv/deployments","created_at":"2017-05-18T08:45:18Z","updated_at":"2017-05-23T07:03:20Z","pushed_at":"2017-06-07T09:30:45Z","git_url":"git://github.com/src-d/docsrv.git","ssh_url":"git@github.com:src-d/docsrv.git","clone_url":"https://github.com/src-d/docsrv.git","svn_url":"https://github.com/src-d/docsrv","homepage":"","size":126,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/13"},"html":{"href":"https://github.com/src-d/docsrv/pull/13"},"issue":{"href":"https://api.github.com/repos/src-d/docsrv/issues/13"},"comments":{"href":"https://api.github.com/repos/src-d/docsrv/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/src-d/docsrv/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/src-d/docsrv/statuses/d9f0c5f4c44f78e86c2a91ae6958bab57afb0146"}}}}
|
{
"id": 91670242,
"name": "src-d/docsrv",
"url": "https://api.github.com/repos/src-d/docsrv"
}
|
{
"id": 1312023,
"login": "erizocosmico",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1312023?",
"url": "https://api.github.com/users/erizocosmico"
}
|
{
"id": 15128793,
"login": "src-d",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15128793?",
"url": "https://api.github.com/orgs/src-d"
}
| 2017-06-07T12:07:46 |
6018361571
|
{"actor":{"display_login":"erizocosmico"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sw360/sw360portal/pulls/comments/115284563","pull_request_review_id":36811446,"id":115284563,"diff_hunk":"@@ -70,7 +70,7 @@\n '<select class=\"toplabelledInput\" ' +\n 'id=\"verificationChangeSelectFor<sw360:out value='${vulnerability.externalId}'/>\" ' +\n 'name=\"<portlet:namespace/><%=VerificationState.class%>\" ' +\n- 'onchange=\"changeVerification(this, `<sw360:out value='${vulnerability.externalId}'/>`,`${vulnerabilityVerifications.get(vulnerability.externalId).get(releaseId).ordinal()}`)\" ' +\n+ \"onchange='changeVerification(this, "<sw360:out value='${vulnerability.externalId}'/>","${vulnerabilityVerifications.get(vulnerability.externalId).get(releaseId).ordinal()}")' \" +","path":"frontend/sw360-portlet/src/main/webapp/html/components/includes/releases/vulnerabilities.jspf","position":14,"original_position":14,"commit_id":"87cddca8824624d1d7f3c4af85d0047de2803b45","original_commit_id":"87cddca8824624d1d7f3c4af85d0047de2803b45","user":{"login":"maximilianhuber","id":1187050,"avatar_url":"https://avatars0.githubusercontent.com/u/1187050?v=3","gravatar_id":"","url":"https://api.github.com/users/maximilianhuber","html_url":"https://github.com/maximilianhuber","followers_url":"https://api.github.com/users/maximilianhuber/followers","following_url":"https://api.github.com/users/maximilianhuber/following{/other_user}","gists_url":"https://api.github.com/users/maximilianhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/maximilianhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maximilianhuber/subscriptions","organizations_url":"https://api.github.com/users/maximilianhuber/orgs","repos_url":"https://api.github.com/users/maximilianhuber/repos","events_url":"https://api.github.com/users/maximilianhuber/events{/privacy}","received_events_url":"https://api.github.com/users/maximilianhuber/received_events","type":"User","site_admin":false},"body":"The patch is \r\n```\r\nFrom b472d9e24edfd1ceb2b234ac042cd4fa2687e33a Mon Sep 17 00:00:00 2001\r\nFrom: Alex Borodin <alex.borodin@evosoft.com>\r\nDate: Thu, 4 May 2017 17:26:42 +0200\r\nSubject: [PATCH] fix(ui): remove backticks from JS code to eliminate Liferay's\r\n minifier errors\r\n\r\n---\r\n .../src/main/webapp/WEB-INF/tags/TrimLineBreaks.tag | 12 ++++++++++++\r\n .../html/components/includes/components/vulnerabilities.jspf | 2 +-\r\n .../html/components/includes/releases/vulnerabilities.jspf | 2 +-\r\n .../sw360-portlet/src/main/webapp/html/components/view.jsp | 5 +++--\r\n .../html/projects/includes/projects/vulnerabilities.jspf | 2 +-\r\n 5 files changed, 18 insertions(+), 5 deletions(-)\r\n create mode 100644 frontend/sw360-portlet/src/main/webapp/WEB-INF/tags/TrimLineBreaks.tag\r\n\r\ndiff --git a/frontend/sw360-portlet/src/main/webapp/WEB-INF/tags/TrimLineBreaks.tag b/frontend/sw360-portlet/src/main/webapp/WEB-INF/tags/TrimLineBreaks.tag\r\nnew file mode 100644\r\nindex 00000000..3570f63a\r\n--- /dev/null\r\n+++ b/frontend/sw360-portlet/src/main/webapp/WEB-INF/tags/TrimLineBreaks.tag\r\n@@ -0,0 +1,12 @@\r\n+<%--\r\n+ ~ Copyright Siemens AG, 2017. Part of the SW360 Portal Project.\r\n+ ~\r\n+ ~ All rights reserved. This program and the accompanying materials\r\n+ ~ are made available under the terms of the Eclipse Public License v1.0\r\n+ ~ which accompanies this distribution, and is available at\r\n+ ~ http://www.eclipse.org/legal/epl-v10.html\r\n+ ~\r\n+ ~ This tag file MUST NOT have any line breaks outside of this multiline comment.\r\n+ ~ It is surely possible to implement it in Java to avoid having this weird restriction,\r\n+ ~ but this way was perceived as quickest by me at the time.\r\n+ --%><%@ attribute name=\"input\" type=\"java.lang.String\" required=\"true\" %><%@ taglib prefix=\"c\" uri=\"http://java.sun.com/jstl/core_rt\"%><%@ taglib prefix=\"fn\" uri=\"http://java.sun.com/jsp/jstl/functions\" %><c:set var=\"newline\" value='<%=\"\\n\"%>' />${fn:replace(input, newline, '')}\r\n\\ No newline at end of file\r\ndiff --git a/frontend/sw360-portlet/src/main/webapp/html/components/includes/components/vulnerabilities.jspf b/frontend/sw360-portlet/src/main/webapp/html/components/includes/components/vulnerabilities.jspf\r\nindex 8f1e9006..ec3cc09f 100644\r\n--- a/frontend/sw360-portlet/src/main/webapp/html/components/includes/components/vulnerabilities.jspf\r\n+++ b/frontend/sw360-portlet/src/main/webapp/html/components/includes/components/vulnerabilities.jspf\r\n@@ -67,7 +67,7 @@\r\n '<select class=\"toplabelledInput\" ' +\r\n 'id=\"verificationChangeSelectFor${vulnerability.externalId}\" ' +\r\n 'name=\"<portlet:namespace/><%=VerificationState.class%>\" ' +\r\n- 'onchange=\"changeVerification(this, `${vulnerability.externalId}`,`${vulnerabilityVerifications.get(vulnerability.externalId).get(vulnerability.intReleaseId).ordinal()}`, `${vulnerability.intReleaseId}`)\" ' +\r\n+ 'onchange=\"changeVerification(this, \\'${vulnerability.externalId}\\',\\'${vulnerabilityVerifications.get(vulnerability.externalId).get(vulnerability.intReleaseId).ordinal()}\\', \\'${vulnerability.intReleaseId}\\')\" ' +\r\n 'title=\"<sw360:out value='${vulnerabilityVerificationTooltips.get(vulnerability.externalId).get(vulnerability.intReleaseId)}'/>\"'+\r\n 'style=\"min-width: 90px; min-height: 28px;\">' +\r\n <sw360:DisplayEnumOptions type=\"<%=VerificationState.class%>\" selected=\"${vulnerabilityVerifications.get(vulnerability.externalId).get(vulnerability.intReleaseId)}\" inQuotes=\"true\"/> +\r\ndiff --git a/frontend/sw360-portlet/src/main/webapp/html/components/includes/releases/vulnerabilities.jspf b/frontend/sw360-portlet/src/main/webapp/html/components/includes/releases/vulnerabilities.jspf\r\nindex ba7fee68..93f4abc2 100644\r\n--- a/frontend/sw360-portlet/src/main/webapp/html/components/includes/releases/vulnerabilities.jspf\r\n+++ b/frontend/sw360-portlet/src/main/webapp/html/components/includes/releases/vulnerabilities.jspf\r\n@@ -70,7 +70,7 @@\r\n '<select class=\"toplabelledInput\" ' +\r\n 'id=\"verificationChangeSelectFor<sw360:out value='${vulnerability.externalId}'/>\" ' +\r\n 'name=\"<portlet:namespace/><%=VerificationState.class%>\" ' +\r\n- 'onchange=\"changeVerification(this, `<sw360:out value='${vulnerability.externalId}'/>`,`${vulnerabilityVerifications.get(vulnerability.externalId).get(releaseId).ordinal()}`)\" ' +\r\n+ 'onchange=\"changeVerification(this, \\'<sw360:out value='${vulnerability.externalId}'/>\\',\\'${vulnerabilityVerifications.get(vulnerability.externalId).get(releaseId).ordinal()}\\')\" ' +\r\n 'title=\"<sw360:out value='${vulnerabilityVerificationTooltips.get(vulnerability.externalId).get(releaseId)}'/>\"'+\r\n 'style=\"min-width: 90px; min-height: 28px;\">' +\r\n <sw360:DisplayEnumOptions type=\"<%=VerificationState.class%>\" selected=\"${vulnerabilityVerifications.get(vulnerability.externalId).get(releaseId)}\" inQuotes=\"true\"/> +\r\ndiff --git a/frontend/sw360-portlet/src/main/webapp/html/components/view.jsp b/frontend/sw360-portlet/src/main/webapp/html/components/view.jsp\r\nindex f4ca3fd4..c70fd7a6 100644\r\n--- a/frontend/sw360-portlet/src/main/webapp/html/components/view.jsp\r\n+++ b/frontend/sw360-portlet/src/main/webapp/html/components/view.jsp\r\n@@ -1,5 +1,5 @@\r\n <%--\r\n- ~ Copyright Siemens AG, 2013-2016. Part of the SW360 Portal Project.\r\n+ ~ Copyright Siemens AG, 2013-2017. Part of the SW360 Portal Project.\r\n ~ With modifications by Bosch Software Innovations GmbH, 2016.\r\n ~\r\n ~ All rights reserved. This program and the accompanying materials\r\n@@ -248,11 +248,12 @@\r\n var result = [];\r\n \r\n <core_rt:forEach items=\"${componentList}\" var=\"component\">\r\n+ <core_rt:set var=\"licenseCollectionTagOutput\"><tags:DisplayLicenseCollection licenseIds=\"${component.mainLicenseIds}\" scopeGroupId=\"${pageContext.getAttribute('scopeGroupId')}\"/></core_rt:set>\r\n result.push({\r\n \"DT_RowId\": \"${component.id}\",\r\n \"0\": '<sw360:DisplayCollection value=\"${component.vendorNames}\"/>',\r\n \"1\": \"<a href='\" + createDetailURLfromComponentId(\"${component.id}\") + \"' target='_self'><sw360:out value=\"${component.name}\"/></a>\",\r\n- \"2\": `<tags:DisplayLicenseCollection licenseIds=\"${component.mainLicenseIds}\" scopeGroupId=\"${pageContext.getAttribute('scopeGroupId')}\"/>`,\r\n+ \"2\": \"<tags:TrimLineBreaks input=\"${licenseCollectionTagOutput}\"/>\",\r\n \"3\": '<sw360:DisplayEnum value=\"${component.componentType}\"/>',\r\n \"4\": \"<a href='<portlet:renderURL ><portlet:param name=\"<%=PortalConstants.COMPONENT_ID%>\" value=\"${component.id}\"/><portlet:param name=\"<%=PortalConstants.PAGENAME%>\" value=\"<%=PortalConstants.PAGENAME_EDIT%>\"/></portlet:renderURL>'><img src='<%=request.getContextPath()%>/images/edit.png' alt='Edit' title='Edit'> </a>\"\r\n + \"<img src='<%=request.getContextPath()%>/images/Trash.png' onclick=\\\"deleteComponent('${component.id}', '<b>${component.name}</b>',${component.releaseIdsSize},${component.attachmentsSize})\\\" alt='Delete' title='Delete'>\"\r\ndiff --git a/frontend/sw360-portlet/src/main/webapp/html/projects/includes/projects/vulnerabilities.jspf b/frontend/sw360-portlet/src/main/webapp/html/projects/includes/projects/vulnerabilities.jspf\r\nindex 54890be4..c47cea84 100644\r\n--- a/frontend/sw360-portlet/src/main/webapp/html/projects/includes/projects/vulnerabilities.jspf\r\n+++ b/frontend/sw360-portlet/src/main/webapp/html/projects/includes/projects/vulnerabilities.jspf\r\n@@ -70,7 +70,7 @@\r\n '<select class=\"toplabelledInput\" '+\r\n 'id=\"ratingChangeSelectFor${vulnerability.externalId}\" '+\r\n 'name=\"<portlet:namespace/><%=VulnerabilityRatingForProject.class%>\" '+\r\n- 'onchange=\"changeRating(this, `${vulnerability.externalId}`,`${vulnerabilityRatings.get(vulnerability.externalId).get(vulnerability.intReleaseId).ordinal()}`, `${vulnerability.intReleaseId}`)\" '+\r\n+ 'onchange=\"changeRating(this, \\'${vulnerability.externalId}\\',\\'${vulnerabilityRatings.get(vulnerability.externalId).get(vulnerability.intReleaseId).ordinal()}\\', \\'${vulnerability.intReleaseId}\\')\" '+\r\n 'title=\"<sw360:out value='${vulnerabilityCheckstatusTooltips.get(vulnerability.externalId).get(vulnerability.intReleaseId)}'/>\"'+\r\n 'style=\"min-width: 90px; min-height: 28px;\">'+\r\n <sw360:DisplayEnumOptions type=\"<%=VulnerabilityRatingForProject.class%>\" selected=\"${vulnerabilityRatings.get(vulnerability.externalId).get(vulnerability.intReleaseId)}\" inQuotes=\"true\"/> +\r\n-- \r\n2.12.2\r\n```","created_at":"2017-05-08T15:58:21Z","updated_at":"2017-05-08T15:58:21Z","html_url":"https://github.com/sw360/sw360portal/pull/390#discussion_r115284563","pull_request_url":"https://api.github.com/repos/sw360/sw360portal/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/comments/115284563"},"html":{"href":"https://github.com/sw360/sw360portal/pull/390#discussion_r115284563"},"pull_request":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/sw360/sw360portal/pulls/390","id":119154735,"html_url":"https://github.com/sw360/sw360portal/pull/390","diff_url":"https://github.com/sw360/sw360portal/pull/390.diff","patch_url":"https://github.com/sw360/sw360portal/pull/390.patch","issue_url":"https://api.github.com/repos/sw360/sw360portal/issues/390","number":390,"state":"open","locked":false,"title":"Remove backticks from JS code to eliminate Liferay's minifier errors","user":{"login":"alex-evo","id":16780167,"avatar_url":"https://avatars3.githubusercontent.com/u/16780167?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-evo","html_url":"https://github.com/alex-evo","followers_url":"https://api.github.com/users/alex-evo/followers","following_url":"https://api.github.com/users/alex-evo/following{/other_user}","gists_url":"https://api.github.com/users/alex-evo/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-evo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-evo/subscriptions","organizations_url":"https://api.github.com/users/alex-evo/orgs","repos_url":"https://api.github.com/users/alex-evo/repos","events_url":"https://api.github.com/users/alex-evo/events{/privacy}","received_events_url":"https://api.github.com/users/alex-evo/received_events","type":"User","site_admin":false},"body":"Remove backticks from JS code to eliminate Liferay's minifier errors","created_at":"2017-05-05T11:15:50Z","updated_at":"2017-05-08T15:58:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33ce9e89f21f8bbb4d2d2fa8129ce94e05adc06e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sw360/sw360portal/pulls/390/commits","review_comments_url":"https://api.github.com/repos/sw360/sw360portal/pulls/390/comments","review_comment_url":"https://api.github.com/repos/sw360/sw360portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sw360/sw360portal/issues/390/comments","statuses_url":"https://api.github.com/repos/sw360/sw360portal/statuses/87cddca8824624d1d7f3c4af85d0047de2803b45","head":{"label":"sw360:fix/minifierErrors","ref":"fix/minifierErrors","sha":"87cddca8824624d1d7f3c4af85d0047de2803b45","user":{"login":"sw360","id":16389175,"avatar_url":"https://avatars3.githubusercontent.com/u/16389175?v=3","gravatar_id":"","url":"https://api.github.com/users/sw360","html_url":"https://github.com/sw360","followers_url":"https://api.github.com/users/sw360/followers","following_url":"https://api.github.com/users/sw360/following{/other_user}","gists_url":"https://api.github.com/users/sw360/gists{/gist_id}","starred_url":"https://api.github.com/users/sw360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sw360/subscriptions","organizations_url":"https://api.github.com/users/sw360/orgs","repos_url":"https://api.github.com/users/sw360/repos","events_url":"https://api.github.com/users/sw360/events{/privacy}","received_events_url":"https://api.github.com/users/sw360/received_events","type":"Organization","site_admin":false},"repo":{"id":43326581,"name":"sw360portal","full_name":"sw360/sw360portal","owner":{"login":"sw360","id":16389175,"avatar_url":"https://avatars3.githubusercontent.com/u/16389175?v=3","gravatar_id":"","url":"https://api.github.com/users/sw360","html_url":"https://github.com/sw360","followers_url":"https://api.github.com/users/sw360/followers","following_url":"https://api.github.com/users/sw360/following{/other_user}","gists_url":"https://api.github.com/users/sw360/gists{/gist_id}","starred_url":"https://api.github.com/users/sw360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sw360/subscriptions","organizations_url":"https://api.github.com/users/sw360/orgs","repos_url":"https://api.github.com/users/sw360/repos","events_url":"https://api.github.com/users/sw360/events{/privacy}","received_events_url":"https://api.github.com/users/sw360/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sw360/sw360portal","description":"A software component catalogue application - designed to work with FOSSology.","fork":false,"url":"https://api.github.com/repos/sw360/sw360portal","forks_url":"https://api.github.com/repos/sw360/sw360portal/forks","keys_url":"https://api.github.com/repos/sw360/sw360portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sw360/sw360portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sw360/sw360portal/teams","hooks_url":"https://api.github.com/repos/sw360/sw360portal/hooks","issue_events_url":"https://api.github.com/repos/sw360/sw360portal/issues/events{/number}","events_url":"https://api.github.com/repos/sw360/sw360portal/events","assignees_url":"https://api.github.com/repos/sw360/sw360portal/assignees{/user}","branches_url":"https://api.github.com/repos/sw360/sw360portal/branches{/branch}","tags_url":"https://api.github.com/repos/sw360/sw360portal/tags","blobs_url":"https://api.github.com/repos/sw360/sw360portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sw360/sw360portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sw360/sw360portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/sw360/sw360portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sw360/sw360portal/statuses/{sha}","languages_url":"https://api.github.com/repos/sw360/sw360portal/languages","stargazers_url":"https://api.github.com/repos/sw360/sw360portal/stargazers","contributors_url":"https://api.github.com/repos/sw360/sw360portal/contributors","subscribers_url":"https://api.github.com/repos/sw360/sw360portal/subscribers","subscription_url":"https://api.github.com/repos/sw360/sw360portal/subscription","commits_url":"https://api.github.com/repos/sw360/sw360portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/sw360/sw360portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/sw360/sw360portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/sw360/sw360portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/sw360/sw360portal/contents/{+path}","compare_url":"https://api.github.com/repos/sw360/sw360portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sw360/sw360portal/merges","archive_url":"https://api.github.com/repos/sw360/sw360portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sw360/sw360portal/downloads","issues_url":"https://api.github.com/repos/sw360/sw360portal/issues{/number}","pulls_url":"https://api.github.com/repos/sw360/sw360portal/pulls{/number}","milestones_url":"https://api.github.com/repos/sw360/sw360portal/milestones{/number}","notifications_url":"https://api.github.com/repos/sw360/sw360portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sw360/sw360portal/labels{/name}","releases_url":"https://api.github.com/repos/sw360/sw360portal/releases{/id}","deployments_url":"https://api.github.com/repos/sw360/sw360portal/deployments","created_at":"2015-09-28T20:56:14Z","updated_at":"2017-03-02T10:55:15Z","pushed_at":"2017-05-08T12:54:23Z","git_url":"git://github.com/sw360/sw360portal.git","ssh_url":"git@github.com:sw360/sw360portal.git","clone_url":"https://github.com/sw360/sw360portal.git","svn_url":"https://github.com/sw360/sw360portal","homepage":null,"size":6784,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":75,"forks":16,"open_issues":75,"watchers":10,"default_branch":"master"}},"base":{"label":"sw360:master","ref":"master","sha":"88a2dfadb550256c654cb8ceb36d4ead6813979f","user":{"login":"sw360","id":16389175,"avatar_url":"https://avatars3.githubusercontent.com/u/16389175?v=3","gravatar_id":"","url":"https://api.github.com/users/sw360","html_url":"https://github.com/sw360","followers_url":"https://api.github.com/users/sw360/followers","following_url":"https://api.github.com/users/sw360/following{/other_user}","gists_url":"https://api.github.com/users/sw360/gists{/gist_id}","starred_url":"https://api.github.com/users/sw360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sw360/subscriptions","organizations_url":"https://api.github.com/users/sw360/orgs","repos_url":"https://api.github.com/users/sw360/repos","events_url":"https://api.github.com/users/sw360/events{/privacy}","received_events_url":"https://api.github.com/users/sw360/received_events","type":"Organization","site_admin":false},"repo":{"id":43326581,"name":"sw360portal","full_name":"sw360/sw360portal","owner":{"login":"sw360","id":16389175,"avatar_url":"https://avatars3.githubusercontent.com/u/16389175?v=3","gravatar_id":"","url":"https://api.github.com/users/sw360","html_url":"https://github.com/sw360","followers_url":"https://api.github.com/users/sw360/followers","following_url":"https://api.github.com/users/sw360/following{/other_user}","gists_url":"https://api.github.com/users/sw360/gists{/gist_id}","starred_url":"https://api.github.com/users/sw360/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sw360/subscriptions","organizations_url":"https://api.github.com/users/sw360/orgs","repos_url":"https://api.github.com/users/sw360/repos","events_url":"https://api.github.com/users/sw360/events{/privacy}","received_events_url":"https://api.github.com/users/sw360/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sw360/sw360portal","description":"A software component catalogue application - designed to work with FOSSology.","fork":false,"url":"https://api.github.com/repos/sw360/sw360portal","forks_url":"https://api.github.com/repos/sw360/sw360portal/forks","keys_url":"https://api.github.com/repos/sw360/sw360portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sw360/sw360portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sw360/sw360portal/teams","hooks_url":"https://api.github.com/repos/sw360/sw360portal/hooks","issue_events_url":"https://api.github.com/repos/sw360/sw360portal/issues/events{/number}","events_url":"https://api.github.com/repos/sw360/sw360portal/events","assignees_url":"https://api.github.com/repos/sw360/sw360portal/assignees{/user}","branches_url":"https://api.github.com/repos/sw360/sw360portal/branches{/branch}","tags_url":"https://api.github.com/repos/sw360/sw360portal/tags","blobs_url":"https://api.github.com/repos/sw360/sw360portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sw360/sw360portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sw360/sw360portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/sw360/sw360portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sw360/sw360portal/statuses/{sha}","languages_url":"https://api.github.com/repos/sw360/sw360portal/languages","stargazers_url":"https://api.github.com/repos/sw360/sw360portal/stargazers","contributors_url":"https://api.github.com/repos/sw360/sw360portal/contributors","subscribers_url":"https://api.github.com/repos/sw360/sw360portal/subscribers","subscription_url":"https://api.github.com/repos/sw360/sw360portal/subscription","commits_url":"https://api.github.com/repos/sw360/sw360portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/sw360/sw360portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/sw360/sw360portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/sw360/sw360portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/sw360/sw360portal/contents/{+path}","compare_url":"https://api.github.com/repos/sw360/sw360portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sw360/sw360portal/merges","archive_url":"https://api.github.com/repos/sw360/sw360portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sw360/sw360portal/downloads","issues_url":"https://api.github.com/repos/sw360/sw360portal/issues{/number}","pulls_url":"https://api.github.com/repos/sw360/sw360portal/pulls{/number}","milestones_url":"https://api.github.com/repos/sw360/sw360portal/milestones{/number}","notifications_url":"https://api.github.com/repos/sw360/sw360portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sw360/sw360portal/labels{/name}","releases_url":"https://api.github.com/repos/sw360/sw360portal/releases{/id}","deployments_url":"https://api.github.com/repos/sw360/sw360portal/deployments","created_at":"2015-09-28T20:56:14Z","updated_at":"2017-03-02T10:55:15Z","pushed_at":"2017-05-08T12:54:23Z","git_url":"git://github.com/sw360/sw360portal.git","ssh_url":"git@github.com:sw360/sw360portal.git","clone_url":"https://github.com/sw360/sw360portal.git","svn_url":"https://github.com/sw360/sw360portal","homepage":null,"size":6784,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":75,"forks":16,"open_issues":75,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/390"},"html":{"href":"https://github.com/sw360/sw360portal/pull/390"},"issue":{"href":"https://api.github.com/repos/sw360/sw360portal/issues/390"},"comments":{"href":"https://api.github.com/repos/sw360/sw360portal/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sw360/sw360portal/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/sw360/sw360portal/statuses/87cddca8824624d1d7f3c4af85d0047de2803b45"}}}}
|
{
"id": 43326581,
"name": "sw360/sw360portal",
"url": "https://api.github.com/repos/sw360/sw360portal"
}
|
{
"id": 1187050,
"login": "maximilianhuber",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1187050?",
"url": "https://api.github.com/users/maximilianhuber"
}
|
{
"id": 16389175,
"login": "sw360",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16389175?",
"url": "https://api.github.com/orgs/sw360"
}
| 2017-05-08T15:58:21 |
5830087593
|
{"actor":{"display_login":"maximilianhuber"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tboox/xmake/pulls/comments/115696265","pull_request_review_id":37255380,"id":115696265,"diff_hunk":"@@ -47,8 +48,34 @@ function sandbox_core_sandbox.interactive()\n -- bind sandbox environment\n -- setfenv(0, instance._PUBLIC)\n \n+ local enable_readline = os.versioninfo().features.readline\n+ local replhistory\n+ if enable_readline then\n+ -- clear history\n+ readline.clear_history()\n+\n+ -- load history\n+ replhistory = history.load(\"replhistory\") or {}\n+ for _, ln in ipairs(replhistory) do\n+ readline.add_history(ln)\n+ end\n+ end\n+\n -- enter interactive mode with this new sandbox\n sandbox.interactive(instance._PUBLIC) \n+\n+ if enable_readline then\n+ -- save to history\n+ local entries = readline.history_list()\n+ if #entries > #replhistory then\n+ for i = #replhistory+1, #entries do\n+ history.save(\"replhistory\", entries[i].line)\n+ end\n+ end\n+\n+ -- clear history\n+ readline.clear_history()\n+ end\n end\n ","path":"xmake/core/sandbox/modules/import/core/sandbox/sandbox.lua","position":41,"original_position":41,"commit_id":"b87438fbe8e8fe7b971fb1bd1dd4675ae3efbf64","original_commit_id":"b87438fbe8e8fe7b971fb1bd1dd4675ae3efbf64","user":{"login":"waruqi","id":151335,"avatar_url":"https://avatars0.githubusercontent.com/u/151335?v=3","gravatar_id":"","url":"https://api.github.com/users/waruqi","html_url":"https://github.com/waruqi","followers_url":"https://api.github.com/users/waruqi/followers","following_url":"https://api.github.com/users/waruqi/following{/other_user}","gists_url":"https://api.github.com/users/waruqi/gists{/gist_id}","starred_url":"https://api.github.com/users/waruqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waruqi/subscriptions","organizations_url":"https://api.github.com/users/waruqi/orgs","repos_url":"https://api.github.com/users/waruqi/repos","events_url":"https://api.github.com/users/waruqi/events{/privacy}","received_events_url":"https://api.github.com/users/waruqi/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-05-10T09:38:30Z","updated_at":"2017-05-10T09:38:30Z","html_url":"https://github.com/tboox/xmake/pull/84#discussion_r115696265","pull_request_url":"https://api.github.com/repos/tboox/xmake/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/tboox/xmake/pulls/comments/115696265"},"html":{"href":"https://github.com/tboox/xmake/pull/84#discussion_r115696265"},"pull_request":{"href":"https://api.github.com/repos/tboox/xmake/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/tboox/xmake/pulls/84","id":119812526,"html_url":"https://github.com/tboox/xmake/pull/84","diff_url":"https://github.com/tboox/xmake/pull/84.diff","patch_url":"https://github.com/tboox/xmake/pull/84.patch","issue_url":"https://api.github.com/repos/tboox/xmake/issues/84","number":84,"state":"open","locked":false,"title":"replhistory","user":{"login":"TitanSnow","id":19969470,"avatar_url":"https://avatars1.githubusercontent.com/u/19969470?v=3","gravatar_id":"","url":"https://api.github.com/users/TitanSnow","html_url":"https://github.com/TitanSnow","followers_url":"https://api.github.com/users/TitanSnow/followers","following_url":"https://api.github.com/users/TitanSnow/following{/other_user}","gists_url":"https://api.github.com/users/TitanSnow/gists{/gist_id}","starred_url":"https://api.github.com/users/TitanSnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TitanSnow/subscriptions","organizations_url":"https://api.github.com/users/TitanSnow/orgs","repos_url":"https://api.github.com/users/TitanSnow/repos","events_url":"https://api.github.com/users/TitanSnow/events{/privacy}","received_events_url":"https://api.github.com/users/TitanSnow/received_events","type":"User","site_admin":false},"body":"1. keep repl command history\r\n2. add module `lib.readline`\r\n3. add fields `host`, `arch`, `nuldev` to `os.versioninfo()`","created_at":"2017-05-10T06:43:38Z","updated_at":"2017-05-10T09:38:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce81c02a85bf7c97f7e919644e97462351609bb3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tboox/xmake/pulls/84/commits","review_comments_url":"https://api.github.com/repos/tboox/xmake/pulls/84/comments","review_comment_url":"https://api.github.com/repos/tboox/xmake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tboox/xmake/issues/84/comments","statuses_url":"https://api.github.com/repos/tboox/xmake/statuses/b87438fbe8e8fe7b971fb1bd1dd4675ae3efbf64","head":{"label":"TitanSnow:replhistory","ref":"replhistory","sha":"b87438fbe8e8fe7b971fb1bd1dd4675ae3efbf64","user":{"login":"TitanSnow","id":19969470,"avatar_url":"https://avatars1.githubusercontent.com/u/19969470?v=3","gravatar_id":"","url":"https://api.github.com/users/TitanSnow","html_url":"https://github.com/TitanSnow","followers_url":"https://api.github.com/users/TitanSnow/followers","following_url":"https://api.github.com/users/TitanSnow/following{/other_user}","gists_url":"https://api.github.com/users/TitanSnow/gists{/gist_id}","starred_url":"https://api.github.com/users/TitanSnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TitanSnow/subscriptions","organizations_url":"https://api.github.com/users/TitanSnow/orgs","repos_url":"https://api.github.com/users/TitanSnow/repos","events_url":"https://api.github.com/users/TitanSnow/events{/privacy}","received_events_url":"https://api.github.com/users/TitanSnow/received_events","type":"User","site_admin":false},"repo":{"id":86153218,"name":"xmake","full_name":"TitanSnow/xmake","owner":{"login":"TitanSnow","id":19969470,"avatar_url":"https://avatars1.githubusercontent.com/u/19969470?v=3","gravatar_id":"","url":"https://api.github.com/users/TitanSnow","html_url":"https://github.com/TitanSnow","followers_url":"https://api.github.com/users/TitanSnow/followers","following_url":"https://api.github.com/users/TitanSnow/following{/other_user}","gists_url":"https://api.github.com/users/TitanSnow/gists{/gist_id}","starred_url":"https://api.github.com/users/TitanSnow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TitanSnow/subscriptions","organizations_url":"https://api.github.com/users/TitanSnow/orgs","repos_url":"https://api.github.com/users/TitanSnow/repos","events_url":"https://api.github.com/users/TitanSnow/events{/privacy}","received_events_url":"https://api.github.com/users/TitanSnow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TitanSnow/xmake","description":"A make-like build utility based on Lua","fork":true,"url":"https://api.github.com/repos/TitanSnow/xmake","forks_url":"https://api.github.com/repos/TitanSnow/xmake/forks","keys_url":"https://api.github.com/repos/TitanSnow/xmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TitanSnow/xmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TitanSnow/xmake/teams","hooks_url":"https://api.github.com/repos/TitanSnow/xmake/hooks","issue_events_url":"https://api.github.com/repos/TitanSnow/xmake/issues/events{/number}","events_url":"https://api.github.com/repos/TitanSnow/xmake/events","assignees_url":"https://api.github.com/repos/TitanSnow/xmake/assignees{/user}","branches_url":"https://api.github.com/repos/TitanSnow/xmake/branches{/branch}","tags_url":"https://api.github.com/repos/TitanSnow/xmake/tags","blobs_url":"https://api.github.com/repos/TitanSnow/xmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TitanSnow/xmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TitanSnow/xmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/TitanSnow/xmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TitanSnow/xmake/statuses/{sha}","languages_url":"https://api.github.com/repos/TitanSnow/xmake/languages","stargazers_url":"https://api.github.com/repos/TitanSnow/xmake/stargazers","contributors_url":"https://api.github.com/repos/TitanSnow/xmake/contributors","subscribers_url":"https://api.github.com/repos/TitanSnow/xmake/subscribers","subscription_url":"https://api.github.com/repos/TitanSnow/xmake/subscription","commits_url":"https://api.github.com/repos/TitanSnow/xmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/TitanSnow/xmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/TitanSnow/xmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/TitanSnow/xmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/TitanSnow/xmake/contents/{+path}","compare_url":"https://api.github.com/repos/TitanSnow/xmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TitanSnow/xmake/merges","archive_url":"https://api.github.com/repos/TitanSnow/xmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TitanSnow/xmake/downloads","issues_url":"https://api.github.com/repos/TitanSnow/xmake/issues{/number}","pulls_url":"https://api.github.com/repos/TitanSnow/xmake/pulls{/number}","milestones_url":"https://api.github.com/repos/TitanSnow/xmake/milestones{/number}","notifications_url":"https://api.github.com/repos/TitanSnow/xmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TitanSnow/xmake/labels{/name}","releases_url":"https://api.github.com/repos/TitanSnow/xmake/releases{/id}","deployments_url":"https://api.github.com/repos/TitanSnow/xmake/deployments","created_at":"2017-03-25T11:42:33Z","updated_at":"2017-03-26T09:16:13Z","pushed_at":"2017-05-10T08:31:40Z","git_url":"git://github.com/TitanSnow/xmake.git","ssh_url":"git@github.com:TitanSnow/xmake.git","clone_url":"https://github.com/TitanSnow/xmake.git","svn_url":"https://github.com/TitanSnow/xmake","homepage":"http://www.xmake.io","size":11065,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tboox:dev","ref":"dev","sha":"194980341bd177815feb13a529892519138b9cb0","user":{"login":"tboox","id":1333270,"avatar_url":"https://avatars0.githubusercontent.com/u/1333270?v=3","gravatar_id":"","url":"https://api.github.com/users/tboox","html_url":"https://github.com/tboox","followers_url":"https://api.github.com/users/tboox/followers","following_url":"https://api.github.com/users/tboox/following{/other_user}","gists_url":"https://api.github.com/users/tboox/gists{/gist_id}","starred_url":"https://api.github.com/users/tboox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboox/subscriptions","organizations_url":"https://api.github.com/users/tboox/orgs","repos_url":"https://api.github.com/users/tboox/repos","events_url":"https://api.github.com/users/tboox/events{/privacy}","received_events_url":"https://api.github.com/users/tboox/received_events","type":"Organization","site_admin":false},"repo":{"id":34431834,"name":"xmake","full_name":"tboox/xmake","owner":{"login":"tboox","id":1333270,"avatar_url":"https://avatars0.githubusercontent.com/u/1333270?v=3","gravatar_id":"","url":"https://api.github.com/users/tboox","html_url":"https://github.com/tboox","followers_url":"https://api.github.com/users/tboox/followers","following_url":"https://api.github.com/users/tboox/following{/other_user}","gists_url":"https://api.github.com/users/tboox/gists{/gist_id}","starred_url":"https://api.github.com/users/tboox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tboox/subscriptions","organizations_url":"https://api.github.com/users/tboox/orgs","repos_url":"https://api.github.com/users/tboox/repos","events_url":"https://api.github.com/users/tboox/events{/privacy}","received_events_url":"https://api.github.com/users/tboox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tboox/xmake","description":"A make-like build utility based on Lua","fork":false,"url":"https://api.github.com/repos/tboox/xmake","forks_url":"https://api.github.com/repos/tboox/xmake/forks","keys_url":"https://api.github.com/repos/tboox/xmake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tboox/xmake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tboox/xmake/teams","hooks_url":"https://api.github.com/repos/tboox/xmake/hooks","issue_events_url":"https://api.github.com/repos/tboox/xmake/issues/events{/number}","events_url":"https://api.github.com/repos/tboox/xmake/events","assignees_url":"https://api.github.com/repos/tboox/xmake/assignees{/user}","branches_url":"https://api.github.com/repos/tboox/xmake/branches{/branch}","tags_url":"https://api.github.com/repos/tboox/xmake/tags","blobs_url":"https://api.github.com/repos/tboox/xmake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tboox/xmake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tboox/xmake/git/refs{/sha}","trees_url":"https://api.github.com/repos/tboox/xmake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tboox/xmake/statuses/{sha}","languages_url":"https://api.github.com/repos/tboox/xmake/languages","stargazers_url":"https://api.github.com/repos/tboox/xmake/stargazers","contributors_url":"https://api.github.com/repos/tboox/xmake/contributors","subscribers_url":"https://api.github.com/repos/tboox/xmake/subscribers","subscription_url":"https://api.github.com/repos/tboox/xmake/subscription","commits_url":"https://api.github.com/repos/tboox/xmake/commits{/sha}","git_commits_url":"https://api.github.com/repos/tboox/xmake/git/commits{/sha}","comments_url":"https://api.github.com/repos/tboox/xmake/comments{/number}","issue_comment_url":"https://api.github.com/repos/tboox/xmake/issues/comments{/number}","contents_url":"https://api.github.com/repos/tboox/xmake/contents/{+path}","compare_url":"https://api.github.com/repos/tboox/xmake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tboox/xmake/merges","archive_url":"https://api.github.com/repos/tboox/xmake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tboox/xmake/downloads","issues_url":"https://api.github.com/repos/tboox/xmake/issues{/number}","pulls_url":"https://api.github.com/repos/tboox/xmake/pulls{/number}","milestones_url":"https://api.github.com/repos/tboox/xmake/milestones{/number}","notifications_url":"https://api.github.com/repos/tboox/xmake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tboox/xmake/labels{/name}","releases_url":"https://api.github.com/repos/tboox/xmake/releases{/id}","deployments_url":"https://api.github.com/repos/tboox/xmake/deployments","created_at":"2015-04-23T03:37:31Z","updated_at":"2017-05-10T07:59:05Z","pushed_at":"2017-05-10T09:06:08Z","git_url":"git://github.com/tboox/xmake.git","ssh_url":"git@github.com:tboox/xmake.git","clone_url":"https://github.com/tboox/xmake.git","svn_url":"https://github.com/tboox/xmake","homepage":"http://xmake.io","size":11034,"stargazers_count":497,"watchers_count":497,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":4,"forks":98,"open_issues":4,"watchers":497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tboox/xmake/pulls/84"},"html":{"href":"https://github.com/tboox/xmake/pull/84"},"issue":{"href":"https://api.github.com/repos/tboox/xmake/issues/84"},"comments":{"href":"https://api.github.com/repos/tboox/xmake/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/tboox/xmake/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/tboox/xmake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tboox/xmake/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/tboox/xmake/statuses/b87438fbe8e8fe7b971fb1bd1dd4675ae3efbf64"}}}}
|
{
"id": 34431834,
"name": "tboox/xmake",
"url": "https://api.github.com/repos/tboox/xmake"
}
|
{
"id": 151335,
"login": "waruqi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/151335?",
"url": "https://api.github.com/users/waruqi"
}
|
{
"id": 1333270,
"login": "tboox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1333270?",
"url": "https://api.github.com/orgs/tboox"
}
| 2017-05-10T09:38:30 |
5843621105
|
{"actor":{"display_login":"waruqi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/115314304","pull_request_review_id":36838593,"id":115314304,"diff_hunk":"@@ -363,6 +385,38 @@ for b in $BMCVLAN; do\n let idev=idev+1\n done\n \n+\n+\n+# update the node status to 'bmcready' for openbmc, no more configuration is needed.\n+if [ ! -z \"$ISOPENBMC\" ]; then\n+ # To enable network configuration for openbmc\n+ let idev=0\n+ TRIES=0\n+ bmc_config_rc=0\n+ # Set Channel Access to apply network setting \n+ #while ! ipmitool -d $idev lan set $LANCHAN access on; do\n+ while ! ipmitool -d $idev raw 0x06 0x40 $LANCHAN 0x42 0x44 > /dev/null; do\n+ snooze\n+ let TRIES=TRIES+1\n+ if [ $TRIES -gt $TIMEOUT ]; then \n+ bmc_config_rc=1\n+ break;\n+ fi\n+ done\n+\n+ # update the node status to 'bmcready'\n+ if [ ! -z \"$XCATMASTER\" ]; then\n+ if [ \"$bmc_config_rc\" = \"0\" ]; then\n+ # Wait for some time for the new network setting is ready \n+ snooze","path":"xCAT-genesis-scripts/bin/bmcsetup","position":94,"original_position":94,"commit_id":"2aa3136094940b174e93a3e3769799dee2d8576a","original_commit_id":"2aa3136094940b174e93a3e3769799dee2d8576a","user":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"body":"Did we check with firmware team about this snooze, it will default to 1 second, is it even needed? ","created_at":"2017-05-08T18:08:13Z","updated_at":"2017-05-08T18:17:28Z","html_url":"https://github.com/xcat2/xcat-core/pull/2990#discussion_r115314304","pull_request_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990","_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments/115314304"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/2990#discussion_r115314304"},"pull_request":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990"}}},"pull_request":{"url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990","id":119130988,"html_url":"https://github.com/xcat2/xcat-core/pull/2990","diff_url":"https://github.com/xcat2/xcat-core/pull/2990.diff","patch_url":"https://github.com/xcat2/xcat-core/pull/2990.patch","issue_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2990","number":2990,"state":"open","locked":false,"title":"enhance bmcsetup logic for openbmc","user":{"login":"zet809","id":8222144,"avatar_url":"https://avatars1.githubusercontent.com/u/8222144?v=3","gravatar_id":"","url":"https://api.github.com/users/zet809","html_url":"https://github.com/zet809","followers_url":"https://api.github.com/users/zet809/followers","following_url":"https://api.github.com/users/zet809/following{/other_user}","gists_url":"https://api.github.com/users/zet809/gists{/gist_id}","starred_url":"https://api.github.com/users/zet809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zet809/subscriptions","organizations_url":"https://api.github.com/users/zet809/orgs","repos_url":"https://api.github.com/users/zet809/repos","events_url":"https://api.github.com/users/zet809/events{/privacy}","received_events_url":"https://api.github.com/users/zet809/received_events","type":"User","site_admin":false},"body":"Include 3 main modification:\r\n1. add `isopenbmc` attribute for the `getbmcconfig` command send by `getipmi` script in xcat-genesis-scripts\r\n2. modify `bmcsetup` script to disable unsupported ipmitool in-band command for openbmc\r\n3. in bmcconfig.pm, read bmc information from `openbmc` table if the request come from an openbmc.\r\n4. read default password with key `openbmc` from `passwd` table if the request come from an openbmc.\r\n\r\nBefore modifying:\r\n```\r\n[p9euh02 /]# ipmitool lan print 1\r\nSet in Progress : Set Complete\r\n...\r\nIP Address : 10.6.9.200\r\nSubnet Mask : 255.0.0.0\r\nMAC Address : 70:e2:84:14:24:74\r\nDefault Gateway IP : 10.0.0.101\r\n...\r\n```\r\nConfiguring BMC:\r\n```\r\n[p9euh02 /]# /bin/bmcsetup\r\nipmitool version 1.8.18\r\nInvalid channel: 16\r\n/bin/bmcsetup: line 151: 3709 Terminated allowcred.awk\r\n<167>May 8 05:24:45 xcat.genesis.bmcsetup: BMC Information obtained from xCAT\r\n<167>May 8 05:24:45 xcat.genesis.bmcsetup: NUMBMCS=1 ==> BMC IP=10.6.9.254/255.0.0.0, GW=10.0.0.101, VLAN=off\r\n<166>May 8 05:24:45 xcat.genesis.bmcsetup: IPMIVER=2.0, IPMIMFG=42817, XPROD=16975\r\n<166>May 8 05:24:45 xcat.genesis.bmcsetup: Auto detecting LAN channel...\r\n<166>May 8 05:24:45 xcat.genesis.bmcsetup: Detected LAN channel 1\r\nSetting LAN IP Address to 10.6.9.254\r\nSetting LAN Subnet Mask to 255.0.0.0\r\nSetting LAN Default Gateway IP to 10.0.0.101\r\n<167>May 8 05:24:47 xcat.genesis.bmcsetup: snooze for 1 second...\r\n```\r\nAfter modifying:\r\n```\r\n[p9euh02 /]# ipmitool lan print 1\r\nSet in Progress : Set Complete\r\n...\r\nIP Address : 10.6.9.254\r\nSubnet Mask : 255.0.0.0\r\nMAC Address : 70:e2:84:14:24:74\r\nDefault Gateway IP : 10.0.0.101\r\n...\r\n```\r\nFor the task #2810 ","created_at":"2017-05-05T08:42:50Z","updated_at":"2017-05-08T18:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d4225555e56c3197854cc0727c20055c4fc6bef","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/xcat2/xcat-core/milestones/27","html_url":"https://github.com/xcat2/xcat-core/milestone/27","labels_url":"https://api.github.com/repos/xcat2/xcat-core/milestones/27/labels","id":2381922,"number":27,"title":"2.13.4","description":"","creator":{"login":"whowutwut","id":10049070,"avatar_url":"https://avatars3.githubusercontent.com/u/10049070?v=3","gravatar_id":"","url":"https://api.github.com/users/whowutwut","html_url":"https://github.com/whowutwut","followers_url":"https://api.github.com/users/whowutwut/followers","following_url":"https://api.github.com/users/whowutwut/following{/other_user}","gists_url":"https://api.github.com/users/whowutwut/gists{/gist_id}","starred_url":"https://api.github.com/users/whowutwut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whowutwut/subscriptions","organizations_url":"https://api.github.com/users/whowutwut/orgs","repos_url":"https://api.github.com/users/whowutwut/repos","events_url":"https://api.github.com/users/whowutwut/events{/privacy}","received_events_url":"https://api.github.com/users/whowutwut/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":108,"state":"open","created_at":"2017-03-13T13:27:05Z","updated_at":"2017-05-08T18:08:42Z","due_on":"2017-05-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990/commits","review_comments_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990/comments","review_comment_url":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/issues/2990/comments","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/2aa3136094940b174e93a3e3769799dee2d8576a","head":{"label":"zet809:enhance_bmcsetup_for_openbmc","ref":"enhance_bmcsetup_for_openbmc","sha":"2aa3136094940b174e93a3e3769799dee2d8576a","user":{"login":"zet809","id":8222144,"avatar_url":"https://avatars1.githubusercontent.com/u/8222144?v=3","gravatar_id":"","url":"https://api.github.com/users/zet809","html_url":"https://github.com/zet809","followers_url":"https://api.github.com/users/zet809/followers","following_url":"https://api.github.com/users/zet809/following{/other_user}","gists_url":"https://api.github.com/users/zet809/gists{/gist_id}","starred_url":"https://api.github.com/users/zet809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zet809/subscriptions","organizations_url":"https://api.github.com/users/zet809/orgs","repos_url":"https://api.github.com/users/zet809/repos","events_url":"https://api.github.com/users/zet809/events{/privacy}","received_events_url":"https://api.github.com/users/zet809/received_events","type":"User","site_admin":false},"repo":{"id":42983219,"name":"xcat-core","full_name":"zet809/xcat-core","owner":{"login":"zet809","id":8222144,"avatar_url":"https://avatars1.githubusercontent.com/u/8222144?v=3","gravatar_id":"","url":"https://api.github.com/users/zet809","html_url":"https://github.com/zet809","followers_url":"https://api.github.com/users/zet809/followers","following_url":"https://api.github.com/users/zet809/following{/other_user}","gists_url":"https://api.github.com/users/zet809/gists{/gist_id}","starred_url":"https://api.github.com/users/zet809/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zet809/subscriptions","organizations_url":"https://api.github.com/users/zet809/orgs","repos_url":"https://api.github.com/users/zet809/repos","events_url":"https://api.github.com/users/zet809/events{/privacy}","received_events_url":"https://api.github.com/users/zet809/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zet809/xcat-core","description":"Code repo for xCAT core packages","fork":true,"url":"https://api.github.com/repos/zet809/xcat-core","forks_url":"https://api.github.com/repos/zet809/xcat-core/forks","keys_url":"https://api.github.com/repos/zet809/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zet809/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zet809/xcat-core/teams","hooks_url":"https://api.github.com/repos/zet809/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/zet809/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/zet809/xcat-core/events","assignees_url":"https://api.github.com/repos/zet809/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/zet809/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/zet809/xcat-core/tags","blobs_url":"https://api.github.com/repos/zet809/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zet809/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zet809/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zet809/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zet809/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zet809/xcat-core/languages","stargazers_url":"https://api.github.com/repos/zet809/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/zet809/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/zet809/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/zet809/xcat-core/subscription","commits_url":"https://api.github.com/repos/zet809/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zet809/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zet809/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zet809/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zet809/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/zet809/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zet809/xcat-core/merges","archive_url":"https://api.github.com/repos/zet809/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zet809/xcat-core/downloads","issues_url":"https://api.github.com/repos/zet809/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/zet809/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zet809/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zet809/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zet809/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/zet809/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/zet809/xcat-core/deployments","created_at":"2015-09-23T06:43:10Z","updated_at":"2016-07-20T03:51:27Z","pushed_at":"2017-05-08T09:13:54Z","git_url":"git://github.com/zet809/xcat-core.git","ssh_url":"git@github.com:zet809/xcat-core.git","clone_url":"https://github.com/zet809/xcat-core.git","svn_url":"https://github.com/zet809/xcat-core","homepage":null,"size":189640,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xcat2:master","ref":"master","sha":"12610abaedd40b5b9802bf12d62e3a9b02c9644e","user":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars0.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"repo":{"id":27747508,"name":"xcat-core","full_name":"xcat2/xcat-core","owner":{"login":"xcat2","id":10124414,"avatar_url":"https://avatars0.githubusercontent.com/u/10124414?v=3","gravatar_id":"","url":"https://api.github.com/users/xcat2","html_url":"https://github.com/xcat2","followers_url":"https://api.github.com/users/xcat2/followers","following_url":"https://api.github.com/users/xcat2/following{/other_user}","gists_url":"https://api.github.com/users/xcat2/gists{/gist_id}","starred_url":"https://api.github.com/users/xcat2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcat2/subscriptions","organizations_url":"https://api.github.com/users/xcat2/orgs","repos_url":"https://api.github.com/users/xcat2/repos","events_url":"https://api.github.com/users/xcat2/events{/privacy}","received_events_url":"https://api.github.com/users/xcat2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xcat2/xcat-core","description":"Code repo for xCAT core packages","fork":false,"url":"https://api.github.com/repos/xcat2/xcat-core","forks_url":"https://api.github.com/repos/xcat2/xcat-core/forks","keys_url":"https://api.github.com/repos/xcat2/xcat-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xcat2/xcat-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xcat2/xcat-core/teams","hooks_url":"https://api.github.com/repos/xcat2/xcat-core/hooks","issue_events_url":"https://api.github.com/repos/xcat2/xcat-core/issues/events{/number}","events_url":"https://api.github.com/repos/xcat2/xcat-core/events","assignees_url":"https://api.github.com/repos/xcat2/xcat-core/assignees{/user}","branches_url":"https://api.github.com/repos/xcat2/xcat-core/branches{/branch}","tags_url":"https://api.github.com/repos/xcat2/xcat-core/tags","blobs_url":"https://api.github.com/repos/xcat2/xcat-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xcat2/xcat-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xcat2/xcat-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/xcat2/xcat-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xcat2/xcat-core/statuses/{sha}","languages_url":"https://api.github.com/repos/xcat2/xcat-core/languages","stargazers_url":"https://api.github.com/repos/xcat2/xcat-core/stargazers","contributors_url":"https://api.github.com/repos/xcat2/xcat-core/contributors","subscribers_url":"https://api.github.com/repos/xcat2/xcat-core/subscribers","subscription_url":"https://api.github.com/repos/xcat2/xcat-core/subscription","commits_url":"https://api.github.com/repos/xcat2/xcat-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/xcat2/xcat-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/xcat2/xcat-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/xcat2/xcat-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/xcat2/xcat-core/contents/{+path}","compare_url":"https://api.github.com/repos/xcat2/xcat-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xcat2/xcat-core/merges","archive_url":"https://api.github.com/repos/xcat2/xcat-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xcat2/xcat-core/downloads","issues_url":"https://api.github.com/repos/xcat2/xcat-core/issues{/number}","pulls_url":"https://api.github.com/repos/xcat2/xcat-core/pulls{/number}","milestones_url":"https://api.github.com/repos/xcat2/xcat-core/milestones{/number}","notifications_url":"https://api.github.com/repos/xcat2/xcat-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xcat2/xcat-core/labels{/name}","releases_url":"https://api.github.com/repos/xcat2/xcat-core/releases{/id}","deployments_url":"https://api.github.com/repos/xcat2/xcat-core/deployments","created_at":"2014-12-09T03:21:50Z","updated_at":"2017-05-08T02:59:23Z","pushed_at":"2017-05-08T18:07:13Z","git_url":"git://github.com/xcat2/xcat-core.git","ssh_url":"git@github.com:xcat2/xcat-core.git","clone_url":"https://github.com/xcat2/xcat-core.git","svn_url":"https://github.com/xcat2/xcat-core","homepage":null,"size":190077,"stargazers_count":88,"watchers_count":88,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"open_issues_count":200,"forks":84,"open_issues":200,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990"},"html":{"href":"https://github.com/xcat2/xcat-core/pull/2990"},"issue":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/2990"},"comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/issues/2990/comments"},"review_comments":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990/comments"},"review_comment":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xcat2/xcat-core/pulls/2990/commits"},"statuses":{"href":"https://api.github.com/repos/xcat2/xcat-core/statuses/2aa3136094940b174e93a3e3769799dee2d8576a"}}}}
|
{
"id": 27747508,
"name": "xcat2/xcat-core",
"url": "https://api.github.com/repos/xcat2/xcat-core"
}
|
{
"id": 10049070,
"login": "whowutwut",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10049070?",
"url": "https://api.github.com/users/whowutwut"
}
|
{
"id": 10124414,
"login": "xcat2",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10124414?",
"url": "https://api.github.com/orgs/xcat2"
}
| 2017-05-08T18:08:13 |
5831018525
|
{"actor":{"display_login":"whowutwut"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/yahoo/elide/pulls/comments/144031671","pull_request_review_id":68630387,"id":144031671,"diff_hunk":"@@ -106,33 +170,37 @@ public ActivePermissionExecutor(boolean verbose, final RequestScope requestScope\n * @see com.yahoo.elide.annotation.DeletePermission\n */\n @Override\n- public <A extends Annotation> ExpressionResult checkPermission(Class<A> annotationClass,\n+ public <A extends Annotation> ExpressionResult checkPermissionDeferred(EntityAction action,\n PersistentResource resource,\n ChangeSpec changeSpec) {\n- Supplier<Expression> expressionSupplier = () -> {\n- if (SharePermission.class == annotationClass) {\n- if (requestScope.getDictionary().isShareable(resource.getResourceClass())) {\n- return expressionBuilder.buildAnyFieldExpressions(resource, ReadPermission.class, changeSpec);\n- } else {\n- return expressionBuilder.FAIL_EXPRESSION;\n- }\n- }\n- return expressionBuilder.buildAnyFieldExpressions(resource, annotationClass, changeSpec);\n- };\n+\n+ if (action == EntityAction.SHARE && !requestScope.getDictionary().isShareable(resource.getResourceClass())) {\n+ ForbiddenAccessException e = new ForbiddenAccessException(\n+ SharePermission.class.getSimpleName(),\n+ expressionBuilder.FAIL_EXPRESSION,\n+ Expression.EvaluationMode.ALL_CHECKS);\n+ log.trace(\"{}\", e.getLoggedMessage());\n+ throw e;","path":"elide-core/src/main/java/com/yahoo/elide/security/executors/ActivePermissionExecutor.java","position":79,"original_position":132,"commit_id":"0f9a32893ad2394c37568a787e0da2de12df94f4","original_commit_id":"0f9a32893ad2394c37568a787e0da2de12df94f4","user":{"login":"suriyasundar92","id":14365156,"avatar_url":"https://avatars3.githubusercontent.com/u/14365156?v=4","gravatar_id":"","url":"https://api.github.com/users/suriyasundar92","html_url":"https://github.com/suriyasundar92","followers_url":"https://api.github.com/users/suriyasundar92/followers","following_url":"https://api.github.com/users/suriyasundar92/following{/other_user}","gists_url":"https://api.github.com/users/suriyasundar92/gists{/gist_id}","starred_url":"https://api.github.com/users/suriyasundar92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suriyasundar92/subscriptions","organizations_url":"https://api.github.com/users/suriyasundar92/orgs","repos_url":"https://api.github.com/users/suriyasundar92/repos","events_url":"https://api.github.com/users/suriyasundar92/events{/privacy}","received_events_url":"https://api.github.com/users/suriyasundar92/received_events","type":"User","site_admin":false},"body":"I had it done that way initially, but when we happen to have some user check on the @ReadPermission we seem to be fetching the cached expression and never seem to evaluate the FAIL_EXPRESSION that we pass. This is happening inside the checkPermissions().\r\nhttps://github.com/yahoo/elide/blob/master/elide-core/src/main/java/com/yahoo/elide/security/executors/ActivePermissionExecutor.java#L289","created_at":"2017-10-11T14:37:36Z","updated_at":"2017-10-11T14:37:37Z","html_url":"https://github.com/yahoo/elide/pull/551#discussion_r144031671","pull_request_url":"https://api.github.com/repos/yahoo/elide/pulls/551","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments/144031671"},"html":{"href":"https://github.com/yahoo/elide/pull/551#discussion_r144031671"},"pull_request":{"href":"https://api.github.com/repos/yahoo/elide/pulls/551"}},"in_reply_to_id":143869354},"pull_request":{"url":"https://api.github.com/repos/yahoo/elide/pulls/551","id":143977392,"html_url":"https://github.com/yahoo/elide/pull/551","diff_url":"https://github.com/yahoo/elide/pull/551.diff","patch_url":"https://github.com/yahoo/elide/pull/551.patch","issue_url":"https://api.github.com/repos/yahoo/elide/issues/551","number":551,"state":"open","locked":false,"title":"Allowing CreatePermissions to be specified on attributes and relations","user":{"login":"suriyasundar92","id":14365156,"avatar_url":"https://avatars3.githubusercontent.com/u/14365156?v=4","gravatar_id":"","url":"https://api.github.com/users/suriyasundar92","html_url":"https://github.com/suriyasundar92","followers_url":"https://api.github.com/users/suriyasundar92/followers","following_url":"https://api.github.com/users/suriyasundar92/following{/other_user}","gists_url":"https://api.github.com/users/suriyasundar92/gists{/gist_id}","starred_url":"https://api.github.com/users/suriyasundar92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suriyasundar92/subscriptions","organizations_url":"https://api.github.com/users/suriyasundar92/orgs","repos_url":"https://api.github.com/users/suriyasundar92/repos","events_url":"https://api.github.com/users/suriyasundar92/events{/privacy}","received_events_url":"https://api.github.com/users/suriyasundar92/received_events","type":"User","site_admin":false},"body":"This PR is an update to a previous PR https://github.com/yahoo/elide/pull/544\r\nIt was closed as I tried to rename the branch\r\n\r\nThe changes include the following:\r\n1. Changed PersistenceResource and ActivePermissionExecutor to support the change\r\n2. Added tests in for the same, with some refactoring as we couldn't add more tests to PersistenceResourceTests\r\n\r\n","created_at":"2017-09-29T20:48:29Z","updated_at":"2017-10-11T14:37:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4f32806e6eaf85ac86c19f5d9d1ca2ff425ddee","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/yahoo/elide/pulls/551/commits","review_comments_url":"https://api.github.com/repos/yahoo/elide/pulls/551/comments","review_comment_url":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yahoo/elide/issues/551/comments","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/0f9a32893ad2394c37568a787e0da2de12df94f4","head":{"label":"yahoo:adding-createpermission-on-attributes-and-relationships","ref":"adding-createpermission-on-attributes-and-relationships","sha":"0f9a32893ad2394c37568a787e0da2de12df94f4","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2017-10-11T08:59:12Z","pushed_at":"2017-10-10T21:06:36Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":4463,"stargazers_count":233,"watchers_count":233,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":51,"forks":69,"open_issues":51,"watchers":233,"default_branch":"master"}},"base":{"label":"yahoo:elide-4.x","ref":"elide-4.x","sha":"d4760c6eb5e8b3bb252cc5da06366ccd8a019d27","user":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"repo":{"id":44124366,"name":"elide","full_name":"yahoo/elide","owner":{"login":"yahoo","id":16574,"avatar_url":"https://avatars1.githubusercontent.com/u/16574?v=4","gravatar_id":"","url":"https://api.github.com/users/yahoo","html_url":"https://github.com/yahoo","followers_url":"https://api.github.com/users/yahoo/followers","following_url":"https://api.github.com/users/yahoo/following{/other_user}","gists_url":"https://api.github.com/users/yahoo/gists{/gist_id}","starred_url":"https://api.github.com/users/yahoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yahoo/subscriptions","organizations_url":"https://api.github.com/users/yahoo/orgs","repos_url":"https://api.github.com/users/yahoo/repos","events_url":"https://api.github.com/users/yahoo/events{/privacy}","received_events_url":"https://api.github.com/users/yahoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yahoo/elide","description":"Elide is a Java library that lets you stand up a JSON API web service with minimal effort","fork":false,"url":"https://api.github.com/repos/yahoo/elide","forks_url":"https://api.github.com/repos/yahoo/elide/forks","keys_url":"https://api.github.com/repos/yahoo/elide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yahoo/elide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yahoo/elide/teams","hooks_url":"https://api.github.com/repos/yahoo/elide/hooks","issue_events_url":"https://api.github.com/repos/yahoo/elide/issues/events{/number}","events_url":"https://api.github.com/repos/yahoo/elide/events","assignees_url":"https://api.github.com/repos/yahoo/elide/assignees{/user}","branches_url":"https://api.github.com/repos/yahoo/elide/branches{/branch}","tags_url":"https://api.github.com/repos/yahoo/elide/tags","blobs_url":"https://api.github.com/repos/yahoo/elide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yahoo/elide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yahoo/elide/git/refs{/sha}","trees_url":"https://api.github.com/repos/yahoo/elide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yahoo/elide/statuses/{sha}","languages_url":"https://api.github.com/repos/yahoo/elide/languages","stargazers_url":"https://api.github.com/repos/yahoo/elide/stargazers","contributors_url":"https://api.github.com/repos/yahoo/elide/contributors","subscribers_url":"https://api.github.com/repos/yahoo/elide/subscribers","subscription_url":"https://api.github.com/repos/yahoo/elide/subscription","commits_url":"https://api.github.com/repos/yahoo/elide/commits{/sha}","git_commits_url":"https://api.github.com/repos/yahoo/elide/git/commits{/sha}","comments_url":"https://api.github.com/repos/yahoo/elide/comments{/number}","issue_comment_url":"https://api.github.com/repos/yahoo/elide/issues/comments{/number}","contents_url":"https://api.github.com/repos/yahoo/elide/contents/{+path}","compare_url":"https://api.github.com/repos/yahoo/elide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yahoo/elide/merges","archive_url":"https://api.github.com/repos/yahoo/elide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yahoo/elide/downloads","issues_url":"https://api.github.com/repos/yahoo/elide/issues{/number}","pulls_url":"https://api.github.com/repos/yahoo/elide/pulls{/number}","milestones_url":"https://api.github.com/repos/yahoo/elide/milestones{/number}","notifications_url":"https://api.github.com/repos/yahoo/elide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yahoo/elide/labels{/name}","releases_url":"https://api.github.com/repos/yahoo/elide/releases{/id}","deployments_url":"https://api.github.com/repos/yahoo/elide/deployments","created_at":"2015-10-12T17:55:01Z","updated_at":"2017-10-11T08:59:12Z","pushed_at":"2017-10-10T21:06:36Z","git_url":"git://github.com/yahoo/elide.git","ssh_url":"git@github.com:yahoo/elide.git","clone_url":"https://github.com/yahoo/elide.git","svn_url":"https://github.com/yahoo/elide","homepage":"http://elide.io/","size":4463,"stargazers_count":233,"watchers_count":233,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":51,"forks":69,"open_issues":51,"watchers":233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yahoo/elide/pulls/551"},"html":{"href":"https://github.com/yahoo/elide/pull/551"},"issue":{"href":"https://api.github.com/repos/yahoo/elide/issues/551"},"comments":{"href":"https://api.github.com/repos/yahoo/elide/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/yahoo/elide/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/yahoo/elide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yahoo/elide/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/yahoo/elide/statuses/0f9a32893ad2394c37568a787e0da2de12df94f4"}},"author_association":"COLLABORATOR"}}
|
{
"id": 44124366,
"name": "yahoo/elide",
"url": "https://api.github.com/repos/yahoo/elide"
}
|
{
"id": 14365156,
"login": "suriyasundar92",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14365156?",
"url": "https://api.github.com/users/suriyasundar92"
}
|
{
"id": 16574,
"login": "yahoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16574?",
"url": "https://api.github.com/orgs/yahoo"
}
| 2017-10-11T14:37:36 |
6702907486
|
{"actor":{"display_login":"suriyasundar92"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/110879908","pull_request_review_id":32081603,"id":110879908,"diff_hunk":"@@ -39,13 +40,25 @@ import (\n \n // Create creates an RPC from the given parameters or fails the whole behavior.\n func Create(t crossdock.T) *yarpc.Dispatcher {\n+\treturn CreateTransport(t, \"\")\n+}\n+\n+// CreateTransport creates an RPC from the given parameters or fails the whole behavior.\n+//\n+// If trans is non-empty, this will be used instead of the behavior transport.\n+func CreateTransport(t crossdock.T, trans string) *yarpc.Dispatcher {","path":"internal/crossdock/client/dispatcher/dispatcher.go","position":null,"original_position":18,"commit_id":"9e8d197090dcab79344478c894d381d4975f9006","original_commit_id":"b159f50e3e60b73664467136203ff9972bd77d90","user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars2.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"body":"Ya for sure, updated","created_at":"2017-04-11T11:43:59Z","updated_at":"2017-04-11T11:43:59Z","html_url":"https://github.com/yarpc/yarpc-go/pull/863#discussion_r110879908","pull_request_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863","_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments/110879908"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/863#discussion_r110879908"},"pull_request":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863"}}},"pull_request":{"url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863","id":113456216,"html_url":"https://github.com/yarpc/yarpc-go/pull/863","diff_url":"https://github.com/yarpc/yarpc-go/pull/863.diff","patch_url":"https://github.com/yarpc/yarpc-go/pull/863.patch","issue_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/863","number":863,"state":"open","locked":false,"title":"gRPC transport initial work with crossdock testing","user":{"login":"peter-edge","id":4228796,"avatar_url":"https://avatars2.githubusercontent.com/u/4228796?v=3","gravatar_id":"","url":"https://api.github.com/users/peter-edge","html_url":"https://github.com/peter-edge","followers_url":"https://api.github.com/users/peter-edge/followers","following_url":"https://api.github.com/users/peter-edge/following{/other_user}","gists_url":"https://api.github.com/users/peter-edge/gists{/gist_id}","starred_url":"https://api.github.com/users/peter-edge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peter-edge/subscriptions","organizations_url":"https://api.github.com/users/peter-edge/orgs","repos_url":"https://api.github.com/users/peter-edge/repos","events_url":"https://api.github.com/users/peter-edge/events{/privacy}","received_events_url":"https://api.github.com/users/peter-edge/received_events","type":"User","site_admin":false},"body":"Done so far:\r\n\r\n- end-to-end working including testing with a client and server using protobuf\r\n- end-to-end working including testing with a generated grpc-go client talking to a yarpc server using protobuf\r\n- end-to-end working with thrift and json including testing in examples\r\n- oneway working\r\n- crossdock testing for protobuf, and for grpc with all encodings (only on go), and with oneway testing, except for a bug with context propagation, there's an issue that the context gets cancelled after the oneway call, and i think this issue could affect all oneway implementations, but other implementations get around it by effectively creating a new context, see handlers.go\r\n\r\nTo do:\r\n\r\n- couple cleanup items\r\n- more testing (the testing in encoding/x/protobuf/testing actually covers about 76% of transport/x/grpc but ya)\r\n- examples with thrift, json, etc\r\n- use `peer.Chooser` etc\r\n- get all keys for transport.Request set from headers\r\n\r\nGenerally I want to get most of this in, and then iterate from there. This is a start, we can refine as we go, I want to get the basics committed to x/ and then I can add stuff with more granularity.","created_at":"2017-03-30T15:24:49Z","updated_at":"2017-04-11T11:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57554a130fdfd418ddcb4dbd527813a0a44d1cad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863/commits","review_comments_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863/comments","review_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/863/comments","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/9e8d197090dcab79344478c894d381d4975f9006","head":{"label":"yarpc:pgrpc","ref":"pgrpc","sha":"9e8d197090dcab79344478c894d381d4975f9006","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars1.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars1.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Go - message passing for microservices","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2017-04-09T11:16:55Z","pushed_at":"2017-04-11T11:43:58Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":6031,"stargazers_count":40,"watchers_count":40,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":106,"forks":5,"open_issues":106,"watchers":40,"default_branch":"dev"}},"base":{"label":"yarpc:dev","ref":"dev","sha":"9f8be5dbc113ba551c61aef4cec9104b84139a56","user":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars1.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"repo":{"id":50390111,"name":"yarpc-go","full_name":"yarpc/yarpc-go","owner":{"login":"yarpc","id":16569504,"avatar_url":"https://avatars1.githubusercontent.com/u/16569504?v=3","gravatar_id":"","url":"https://api.github.com/users/yarpc","html_url":"https://github.com/yarpc","followers_url":"https://api.github.com/users/yarpc/followers","following_url":"https://api.github.com/users/yarpc/following{/other_user}","gists_url":"https://api.github.com/users/yarpc/gists{/gist_id}","starred_url":"https://api.github.com/users/yarpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarpc/subscriptions","organizations_url":"https://api.github.com/users/yarpc/orgs","repos_url":"https://api.github.com/users/yarpc/repos","events_url":"https://api.github.com/users/yarpc/events{/privacy}","received_events_url":"https://api.github.com/users/yarpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarpc/yarpc-go","description":"YARPC for Go - message passing for microservices","fork":false,"url":"https://api.github.com/repos/yarpc/yarpc-go","forks_url":"https://api.github.com/repos/yarpc/yarpc-go/forks","keys_url":"https://api.github.com/repos/yarpc/yarpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarpc/yarpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarpc/yarpc-go/teams","hooks_url":"https://api.github.com/repos/yarpc/yarpc-go/hooks","issue_events_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/yarpc/yarpc-go/events","assignees_url":"https://api.github.com/repos/yarpc/yarpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/yarpc/yarpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/yarpc/yarpc-go/tags","blobs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarpc/yarpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarpc/yarpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarpc/yarpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarpc/yarpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/yarpc/yarpc-go/languages","stargazers_url":"https://api.github.com/repos/yarpc/yarpc-go/stargazers","contributors_url":"https://api.github.com/repos/yarpc/yarpc-go/contributors","subscribers_url":"https://api.github.com/repos/yarpc/yarpc-go/subscribers","subscription_url":"https://api.github.com/repos/yarpc/yarpc-go/subscription","commits_url":"https://api.github.com/repos/yarpc/yarpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarpc/yarpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarpc/yarpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarpc/yarpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarpc/yarpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/yarpc/yarpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarpc/yarpc-go/merges","archive_url":"https://api.github.com/repos/yarpc/yarpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarpc/yarpc-go/downloads","issues_url":"https://api.github.com/repos/yarpc/yarpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/yarpc/yarpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/yarpc/yarpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/yarpc/yarpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarpc/yarpc-go/labels{/name}","releases_url":"https://api.github.com/repos/yarpc/yarpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/yarpc/yarpc-go/deployments","created_at":"2016-01-26T00:04:14Z","updated_at":"2017-04-09T11:16:55Z","pushed_at":"2017-04-11T11:43:58Z","git_url":"git://github.com/yarpc/yarpc-go.git","ssh_url":"git@github.com:yarpc/yarpc-go.git","clone_url":"https://github.com/yarpc/yarpc-go.git","svn_url":"https://github.com/yarpc/yarpc-go","homepage":"","size":6031,"stargazers_count":40,"watchers_count":40,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":106,"forks":5,"open_issues":106,"watchers":40,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863"},"html":{"href":"https://github.com/yarpc/yarpc-go/pull/863"},"issue":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/863"},"comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/issues/863/comments"},"review_comments":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863/comments"},"review_comment":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarpc/yarpc-go/pulls/863/commits"},"statuses":{"href":"https://api.github.com/repos/yarpc/yarpc-go/statuses/9e8d197090dcab79344478c894d381d4975f9006"}}}}
|
{
"id": 50390111,
"name": "yarpc/yarpc-go",
"url": "https://api.github.com/repos/yarpc/yarpc-go"
}
|
{
"id": 4228796,
"login": "peter-edge",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4228796?",
"url": "https://api.github.com/users/peter-edge"
}
|
{
"id": 16569504,
"login": "yarpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16569504?",
"url": "https://api.github.com/orgs/yarpc"
}
| 2017-04-11T11:43:59 |
5667064995
|
{"actor":{"display_login":"peter-edge"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments/132141854","pull_request_review_id":55189009,"id":132141854,"diff_hunk":"@@ -85,8 +85,10 @@ export default class SearchMessagesCard extends PureComponent {\n <MessageList\n actions={actions}\n messages={messages}\n- caughtUp={{ older: true, newer: true }}\n- fetching={{ older: false, newer: isFetching }}\n+ fetchingOlder={false}","path":"src/search/SearchMessagesCard.js","position":6,"original_position":6,"commit_id":"758201cbe3f8abc2627b4a63f1a0837732a727a7","original_commit_id":"758201cbe3f8abc2627b4a63f1a0837732a727a7","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"body":"Good catch.","created_at":"2017-08-09T10:06:53Z","updated_at":"2017-08-09T10:08:49Z","html_url":"https://github.com/zulip/zulip-mobile/pull/1006#discussion_r132141854","pull_request_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006","_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments/132141854"},"html":{"href":"https://github.com/zulip/zulip-mobile/pull/1006#discussion_r132141854"},"pull_request":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006"}}},"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006","id":134818574,"html_url":"https://github.com/zulip/zulip-mobile/pull/1006","diff_url":"https://github.com/zulip/zulip-mobile/pull/1006.diff","patch_url":"https://github.com/zulip/zulip-mobile/pull/1006.patch","issue_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/1006","number":1006,"state":"open","locked":false,"title":"Refactor: MessageList and create container component.","user":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars0.githubusercontent.com/u/14239866?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"body":"first part of the message list refactor","created_at":"2017-08-09T06:27:14Z","updated_at":"2017-08-09T10:08:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b9a3ccfc2e319ce0c432c345fbf06ca8f406289","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/1006/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/758201cbe3f8abc2627b4a63f1a0837732a727a7","head":{"label":"Sam1301:refactor","ref":"refactor","sha":"758201cbe3f8abc2627b4a63f1a0837732a727a7","user":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars0.githubusercontent.com/u/14239866?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"repo":{"id":84159100,"name":"zulip-mobile","full_name":"Sam1301/zulip-mobile","owner":{"login":"Sam1301","id":14239866,"avatar_url":"https://avatars0.githubusercontent.com/u/14239866?v=4","gravatar_id":"","url":"https://api.github.com/users/Sam1301","html_url":"https://github.com/Sam1301","followers_url":"https://api.github.com/users/Sam1301/followers","following_url":"https://api.github.com/users/Sam1301/following{/other_user}","gists_url":"https://api.github.com/users/Sam1301/gists{/gist_id}","starred_url":"https://api.github.com/users/Sam1301/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sam1301/subscriptions","organizations_url":"https://api.github.com/users/Sam1301/orgs","repos_url":"https://api.github.com/users/Sam1301/repos","events_url":"https://api.github.com/users/Sam1301/events{/privacy}","received_events_url":"https://api.github.com/users/Sam1301/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sam1301/zulip-mobile","description":"Zulip mobile app using React Native","fork":true,"url":"https://api.github.com/repos/Sam1301/zulip-mobile","forks_url":"https://api.github.com/repos/Sam1301/zulip-mobile/forks","keys_url":"https://api.github.com/repos/Sam1301/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sam1301/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sam1301/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/Sam1301/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/Sam1301/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/Sam1301/zulip-mobile/events","assignees_url":"https://api.github.com/repos/Sam1301/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/Sam1301/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/Sam1301/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/Sam1301/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sam1301/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sam1301/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sam1301/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sam1301/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/Sam1301/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/Sam1301/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/Sam1301/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/Sam1301/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/Sam1301/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/Sam1301/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sam1301/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sam1301/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sam1301/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sam1301/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/Sam1301/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sam1301/zulip-mobile/merges","archive_url":"https://api.github.com/repos/Sam1301/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sam1301/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/Sam1301/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/Sam1301/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/Sam1301/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/Sam1301/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sam1301/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/Sam1301/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/Sam1301/zulip-mobile/deployments","created_at":"2017-03-07T05:35:57Z","updated_at":"2017-03-07T05:35:59Z","pushed_at":"2017-08-09T06:21:04Z","git_url":"git://github.com/Sam1301/zulip-mobile.git","ssh_url":"git@github.com:Sam1301/zulip-mobile.git","clone_url":"https://github.com/Sam1301/zulip-mobile.git","svn_url":"https://github.com/Sam1301/zulip-mobile","homepage":"","size":16247,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"8d7745178b6be46f33e33975703891e31fbf4c4f","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":58298428,"name":"zulip-mobile","full_name":"zulip/zulip-mobile","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-mobile","description":"Zulip mobile app using React Native","fork":false,"url":"https://api.github.com/repos/zulip/zulip-mobile","forks_url":"https://api.github.com/repos/zulip/zulip-mobile/forks","keys_url":"https://api.github.com/repos/zulip/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-mobile/events","assignees_url":"https://api.github.com/repos/zulip/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-mobile/merges","archive_url":"https://api.github.com/repos/zulip/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-mobile/deployments","created_at":"2016-05-08T05:41:48Z","updated_at":"2017-08-07T06:05:30Z","pushed_at":"2017-08-09T09:45:22Z","git_url":"git://github.com/zulip/zulip-mobile.git","ssh_url":"git@github.com:zulip/zulip-mobile.git","clone_url":"https://github.com/zulip/zulip-mobile.git","svn_url":"https://github.com/zulip/zulip-mobile","homepage":"","size":16231,"stargazers_count":89,"watchers_count":89,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":131,"forks":55,"open_issues":131,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006"},"html":{"href":"https://github.com/zulip/zulip-mobile/pull/1006"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/1006"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/1006/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/1006/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-mobile/statuses/758201cbe3f8abc2627b4a63f1a0837732a727a7"}}}}
|
{
"id": 58298428,
"name": "zulip/zulip-mobile",
"url": "https://api.github.com/repos/zulip/zulip-mobile"
}
|
{
"id": 867242,
"login": "borisyankov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/867242?",
"url": "https://api.github.com/users/borisyankov"
}
|
{
"id": 4921959,
"login": "zulip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4921959?",
"url": "https://api.github.com/orgs/zulip"
}
| 2017-08-09T10:06:53 |
6423115516
|
{"actor":{"display_login":"borisyankov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/124092718","pull_request_review_id":46352437,"id":124092718,"diff_hunk":"@@ -25,6 +25,11 @@\n \"description\": \"kazoo_endpoint default ignore completed elsewhere\",\n \"type\": \"boolean\"\n },\n+ \"default_rtcp_mux\": {","path":"applications/crossbar/priv/couchdb/schemas/system_config.kazoo_endpoint.json","position":4,"original_position":4,"commit_id":"402d7b3b4187079987e3484487417e918d6e1ae9","original_commit_id":"402d7b3b4187079987e3484487417e918d6e1ae9","user":{"login":"sergey-safarov","id":2562241,"avatar_url":"https://avatars1.githubusercontent.com/u/2562241?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-safarov","html_url":"https://github.com/sergey-safarov","followers_url":"https://api.github.com/users/sergey-safarov/followers","following_url":"https://api.github.com/users/sergey-safarov/following{/other_user}","gists_url":"https://api.github.com/users/sergey-safarov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-safarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-safarov/subscriptions","organizations_url":"https://api.github.com/users/sergey-safarov/orgs","repos_url":"https://api.github.com/users/sergey-safarov/repos","events_url":"https://api.github.com/users/sergey-safarov/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-safarov/received_events","type":"User","site_admin":false},"body":"FreeSwitch default value is 'false' this setting reflect it is.\r\nThis this value nothing is changed in current kazoo clusters.","created_at":"2017-06-26T19:02:28Z","updated_at":"2017-06-26T19:02:28Z","html_url":"https://github.com/2600hz/kazoo/pull/3872#discussion_r124092718","pull_request_url":"https://api.github.com/repos/2600hz/kazoo/pulls/3872","_links":{"self":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/comments/124092718"},"html":{"href":"https://github.com/2600hz/kazoo/pull/3872#discussion_r124092718"},"pull_request":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/3872"}}},"pull_request":{"url":"https://api.github.com/repos/2600hz/kazoo/pulls/3872","id":127329819,"html_url":"https://github.com/2600hz/kazoo/pull/3872","diff_url":"https://github.com/2600hz/kazoo/pull/3872.diff","patch_url":"https://github.com/2600hz/kazoo/pull/3872.patch","issue_url":"https://api.github.com/repos/2600hz/kazoo/issues/3872","number":3872,"state":"open","locked":false,"title":"Added feature to disable rtcp_mux for calls to SIP endpoints","user":{"login":"sergey-safarov","id":2562241,"avatar_url":"https://avatars1.githubusercontent.com/u/2562241?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-safarov","html_url":"https://github.com/sergey-safarov","followers_url":"https://api.github.com/users/sergey-safarov/followers","following_url":"https://api.github.com/users/sergey-safarov/following{/other_user}","gists_url":"https://api.github.com/users/sergey-safarov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-safarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-safarov/subscriptions","organizations_url":"https://api.github.com/users/sergey-safarov/orgs","repos_url":"https://api.github.com/users/sergey-safarov/repos","events_url":"https://api.github.com/users/sergey-safarov/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-safarov/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-24T13:16:09Z","updated_at":"2017-06-26T19:02:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"672846795a4cf9671ca83193c447b7bbde002570","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/2600hz/kazoo/pulls/3872/commits","review_comments_url":"https://api.github.com/repos/2600hz/kazoo/pulls/3872/comments","review_comment_url":"https://api.github.com/repos/2600hz/kazoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/2600hz/kazoo/issues/3872/comments","statuses_url":"https://api.github.com/repos/2600hz/kazoo/statuses/402d7b3b4187079987e3484487417e918d6e1ae9","head":{"label":"sergey-safarov:rtcp-mux8","ref":"rtcp-mux8","sha":"402d7b3b4187079987e3484487417e918d6e1ae9","user":{"login":"sergey-safarov","id":2562241,"avatar_url":"https://avatars1.githubusercontent.com/u/2562241?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-safarov","html_url":"https://github.com/sergey-safarov","followers_url":"https://api.github.com/users/sergey-safarov/followers","following_url":"https://api.github.com/users/sergey-safarov/following{/other_user}","gists_url":"https://api.github.com/users/sergey-safarov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-safarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-safarov/subscriptions","organizations_url":"https://api.github.com/users/sergey-safarov/orgs","repos_url":"https://api.github.com/users/sergey-safarov/repos","events_url":"https://api.github.com/users/sergey-safarov/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-safarov/received_events","type":"User","site_admin":false},"repo":{"id":42859241,"name":"kazoo","full_name":"sergey-safarov/kazoo","owner":{"login":"sergey-safarov","id":2562241,"avatar_url":"https://avatars1.githubusercontent.com/u/2562241?v=3","gravatar_id":"","url":"https://api.github.com/users/sergey-safarov","html_url":"https://github.com/sergey-safarov","followers_url":"https://api.github.com/users/sergey-safarov/followers","following_url":"https://api.github.com/users/sergey-safarov/following{/other_user}","gists_url":"https://api.github.com/users/sergey-safarov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-safarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-safarov/subscriptions","organizations_url":"https://api.github.com/users/sergey-safarov/orgs","repos_url":"https://api.github.com/users/sergey-safarov/repos","events_url":"https://api.github.com/users/sergey-safarov/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-safarov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sergey-safarov/kazoo","description":null,"fork":true,"url":"https://api.github.com/repos/sergey-safarov/kazoo","forks_url":"https://api.github.com/repos/sergey-safarov/kazoo/forks","keys_url":"https://api.github.com/repos/sergey-safarov/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergey-safarov/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergey-safarov/kazoo/teams","hooks_url":"https://api.github.com/repos/sergey-safarov/kazoo/hooks","issue_events_url":"https://api.github.com/repos/sergey-safarov/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/sergey-safarov/kazoo/events","assignees_url":"https://api.github.com/repos/sergey-safarov/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/sergey-safarov/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/sergey-safarov/kazoo/tags","blobs_url":"https://api.github.com/repos/sergey-safarov/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergey-safarov/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergey-safarov/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergey-safarov/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergey-safarov/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/sergey-safarov/kazoo/languages","stargazers_url":"https://api.github.com/repos/sergey-safarov/kazoo/stargazers","contributors_url":"https://api.github.com/repos/sergey-safarov/kazoo/contributors","subscribers_url":"https://api.github.com/repos/sergey-safarov/kazoo/subscribers","subscription_url":"https://api.github.com/repos/sergey-safarov/kazoo/subscription","commits_url":"https://api.github.com/repos/sergey-safarov/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergey-safarov/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergey-safarov/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergey-safarov/kazoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergey-safarov/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/sergey-safarov/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergey-safarov/kazoo/merges","archive_url":"https://api.github.com/repos/sergey-safarov/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergey-safarov/kazoo/downloads","issues_url":"https://api.github.com/repos/sergey-safarov/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/sergey-safarov/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/sergey-safarov/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/sergey-safarov/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergey-safarov/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/sergey-safarov/kazoo/releases{/id}","deployments_url":"https://api.github.com/repos/sergey-safarov/kazoo/deployments","created_at":"2015-09-21T10:19:07Z","updated_at":"2016-01-13T09:41:26Z","pushed_at":"2017-06-24T18:33:58Z","git_url":"git://github.com/sergey-safarov/kazoo.git","ssh_url":"git@github.com:sergey-safarov/kazoo.git","clone_url":"https://github.com/sergey-safarov/kazoo.git","svn_url":"https://github.com/sergey-safarov/kazoo","homepage":"","size":349468,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"2600hz:master","ref":"master","sha":"0710883871ce717ba38ac16536ff1f4c65a482c2","user":{"login":"2600hz","id":408801,"avatar_url":"https://avatars0.githubusercontent.com/u/408801?v=3","gravatar_id":"","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"repo":{"id":2966241,"name":"kazoo","full_name":"2600hz/kazoo","owner":{"login":"2600hz","id":408801,"avatar_url":"https://avatars0.githubusercontent.com/u/408801?v=3","gravatar_id":"","url":"https://api.github.com/users/2600hz","html_url":"https://github.com/2600hz","followers_url":"https://api.github.com/users/2600hz/followers","following_url":"https://api.github.com/users/2600hz/following{/other_user}","gists_url":"https://api.github.com/users/2600hz/gists{/gist_id}","starred_url":"https://api.github.com/users/2600hz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2600hz/subscriptions","organizations_url":"https://api.github.com/users/2600hz/orgs","repos_url":"https://api.github.com/users/2600hz/repos","events_url":"https://api.github.com/users/2600hz/events{/privacy}","received_events_url":"https://api.github.com/users/2600hz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2600hz/kazoo","description":"The core of an open-source, distributed, highly scalable platform designed to provide robust telecom services","fork":false,"url":"https://api.github.com/repos/2600hz/kazoo","forks_url":"https://api.github.com/repos/2600hz/kazoo/forks","keys_url":"https://api.github.com/repos/2600hz/kazoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2600hz/kazoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2600hz/kazoo/teams","hooks_url":"https://api.github.com/repos/2600hz/kazoo/hooks","issue_events_url":"https://api.github.com/repos/2600hz/kazoo/issues/events{/number}","events_url":"https://api.github.com/repos/2600hz/kazoo/events","assignees_url":"https://api.github.com/repos/2600hz/kazoo/assignees{/user}","branches_url":"https://api.github.com/repos/2600hz/kazoo/branches{/branch}","tags_url":"https://api.github.com/repos/2600hz/kazoo/tags","blobs_url":"https://api.github.com/repos/2600hz/kazoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2600hz/kazoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2600hz/kazoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/2600hz/kazoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2600hz/kazoo/statuses/{sha}","languages_url":"https://api.github.com/repos/2600hz/kazoo/languages","stargazers_url":"https://api.github.com/repos/2600hz/kazoo/stargazers","contributors_url":"https://api.github.com/repos/2600hz/kazoo/contributors","subscribers_url":"https://api.github.com/repos/2600hz/kazoo/subscribers","subscription_url":"https://api.github.com/repos/2600hz/kazoo/subscription","commits_url":"https://api.github.com/repos/2600hz/kazoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/2600hz/kazoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/2600hz/kazoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/2600hz/kazoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/2600hz/kazoo/contents/{+path}","compare_url":"https://api.github.com/repos/2600hz/kazoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2600hz/kazoo/merges","archive_url":"https://api.github.com/repos/2600hz/kazoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2600hz/kazoo/downloads","issues_url":"https://api.github.com/repos/2600hz/kazoo/issues{/number}","pulls_url":"https://api.github.com/repos/2600hz/kazoo/pulls{/number}","milestones_url":"https://api.github.com/repos/2600hz/kazoo/milestones{/number}","notifications_url":"https://api.github.com/repos/2600hz/kazoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2600hz/kazoo/labels{/name}","releases_url":"https://api.github.com/repos/2600hz/kazoo/releases{/id}","deployments_url":"https://api.github.com/repos/2600hz/kazoo/deployments","created_at":"2011-12-12T18:08:02Z","updated_at":"2017-06-25T00:23:29Z","pushed_at":"2017-06-26T18:26:47Z","git_url":"git://github.com/2600hz/kazoo.git","ssh_url":"git@github.com:2600hz/kazoo.git","clone_url":"https://github.com/2600hz/kazoo.git","svn_url":"https://github.com/2600hz/kazoo","homepage":"http://www.2600hz.org/","size":351203,"stargazers_count":481,"watchers_count":481,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":252,"mirror_url":null,"open_issues_count":19,"forks":252,"open_issues":19,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/3872"},"html":{"href":"https://github.com/2600hz/kazoo/pull/3872"},"issue":{"href":"https://api.github.com/repos/2600hz/kazoo/issues/3872"},"comments":{"href":"https://api.github.com/repos/2600hz/kazoo/issues/3872/comments"},"review_comments":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/3872/comments"},"review_comment":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/2600hz/kazoo/pulls/3872/commits"},"statuses":{"href":"https://api.github.com/repos/2600hz/kazoo/statuses/402d7b3b4187079987e3484487417e918d6e1ae9"}}}}
|
{
"id": 2966241,
"name": "2600hz/kazoo",
"url": "https://api.github.com/repos/2600hz/kazoo"
}
|
{
"id": 2562241,
"login": "sergey-safarov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2562241?",
"url": "https://api.github.com/users/sergey-safarov"
}
|
{
"id": 408801,
"login": "2600hz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/408801?",
"url": "https://api.github.com/orgs/2600hz"
}
| 2017-06-26T19:02:28 |
6140430107
|
{"actor":{"display_login":"sergey-safarov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/comments/116535673","pull_request_review_id":38164430,"id":116535673,"diff_hunk":"@@ -480,25 +480,33 @@ def add_all():\n return None\n \n if l:","path":"ui/ecsconfig.py","position":3,"original_position":3,"commit_id":"d647b9dc9103476bdc5d1a9f0e12aca15ad97e05","original_commit_id":"d647b9dc9103476bdc5d1a9f0e12aca15ad97e05","user":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"body":"👍 And yeah, pretty much anything you don't like or is broken, feel free to call it out in an issue. IMO, issues are how we keep improving.","created_at":"2017-05-15T16:18:39Z","updated_at":"2017-05-15T16:18:39Z","html_url":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231#discussion_r116535673","pull_request_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231","_links":{"self":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/comments/116535673"},"html":{"href":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231#discussion_r116535673"},"pull_request":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231","id":120428169,"html_url":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231","diff_url":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231.diff","patch_url":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231.patch","issue_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/231","number":231,"state":"open","locked":false,"title":"[WIP] ECS-CommunityEdition-77 Installer should have flag to skip creation of RG/User/Namespace","user":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"body":"Addresses #77\nDoesn't quite work; needs conflict resolution with config validation and Ansible inventory.","created_at":"2017-05-13T00:45:19Z","updated_at":"2017-05-15T16:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2560222164bcc3b9f7465d08391353d35a592e51","assignee":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"assignees":[{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/milestones/6","html_url":"https://github.com/EMCECS/ECS-CommunityEdition/milestone/6","labels_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/milestones/6/labels","id":1697178,"number":6,"title":"installer 2.0.2","description":"","creator":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":11,"state":"open","created_at":"2016-04-11T09:56:47Z","updated_at":"2017-05-13T00:58:06Z","due_on":"2017-05-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231/commits","review_comments_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231/comments","review_comment_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/231/comments","statuses_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/statuses/d647b9dc9103476bdc5d1a9f0e12aca15ad97e05","head":{"label":"padthaitofuhot:ECS-CommunityEdition-77","ref":"ECS-CommunityEdition-77","sha":"d647b9dc9103476bdc5d1a9f0e12aca15ad97e05","user":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"repo":{"id":41120378,"name":"ECS-CommunityEdition","full_name":"padthaitofuhot/ECS-CommunityEdition","owner":{"login":"padthaitofuhot","id":3824438,"avatar_url":"https://avatars1.githubusercontent.com/u/3824438?v=3","gravatar_id":"","url":"https://api.github.com/users/padthaitofuhot","html_url":"https://github.com/padthaitofuhot","followers_url":"https://api.github.com/users/padthaitofuhot/followers","following_url":"https://api.github.com/users/padthaitofuhot/following{/other_user}","gists_url":"https://api.github.com/users/padthaitofuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/padthaitofuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padthaitofuhot/subscriptions","organizations_url":"https://api.github.com/users/padthaitofuhot/orgs","repos_url":"https://api.github.com/users/padthaitofuhot/repos","events_url":"https://api.github.com/users/padthaitofuhot/events{/privacy}","received_events_url":"https://api.github.com/users/padthaitofuhot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/padthaitofuhot/ECS-CommunityEdition","description":"ECS Free & Frictionless Community Edition Repository ","fork":true,"url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition","forks_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/forks","keys_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/teams","hooks_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/hooks","issue_events_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/issues/events{/number}","events_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/events","assignees_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/assignees{/user}","branches_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/branches{/branch}","tags_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/tags","blobs_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/git/refs{/sha}","trees_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/statuses/{sha}","languages_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/languages","stargazers_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/stargazers","contributors_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/contributors","subscribers_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/subscribers","subscription_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/subscription","commits_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/commits{/sha}","git_commits_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/git/commits{/sha}","comments_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/comments{/number}","issue_comment_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/issues/comments{/number}","contents_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/contents/{+path}","compare_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/merges","archive_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/downloads","issues_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/issues{/number}","pulls_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/pulls{/number}","milestones_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/milestones{/number}","notifications_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/labels{/name}","releases_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/releases{/id}","deployments_url":"https://api.github.com/repos/padthaitofuhot/ECS-CommunityEdition/deployments","created_at":"2015-08-20T21:47:42Z","updated_at":"2017-04-24T14:05:11Z","pushed_at":"2017-05-13T00:55:19Z","git_url":"git://github.com/padthaitofuhot/ECS-CommunityEdition.git","ssh_url":"git@github.com:padthaitofuhot/ECS-CommunityEdition.git","clone_url":"https://github.com/padthaitofuhot/ECS-CommunityEdition.git","svn_url":"https://github.com/padthaitofuhot/ECS-CommunityEdition","homepage":null,"size":3259,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"EMCECS:develop","ref":"develop","sha":"8989150c8cd73f383ce9b43471c5b8d8148ca2fe","user":{"login":"EMCECS","id":12926680,"avatar_url":"https://avatars1.githubusercontent.com/u/12926680?v=3","gravatar_id":"","url":"https://api.github.com/users/EMCECS","html_url":"https://github.com/EMCECS","followers_url":"https://api.github.com/users/EMCECS/followers","following_url":"https://api.github.com/users/EMCECS/following{/other_user}","gists_url":"https://api.github.com/users/EMCECS/gists{/gist_id}","starred_url":"https://api.github.com/users/EMCECS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EMCECS/subscriptions","organizations_url":"https://api.github.com/users/EMCECS/orgs","repos_url":"https://api.github.com/users/EMCECS/repos","events_url":"https://api.github.com/users/EMCECS/events{/privacy}","received_events_url":"https://api.github.com/users/EMCECS/received_events","type":"Organization","site_admin":false},"repo":{"id":37556554,"name":"ECS-CommunityEdition","full_name":"EMCECS/ECS-CommunityEdition","owner":{"login":"EMCECS","id":12926680,"avatar_url":"https://avatars1.githubusercontent.com/u/12926680?v=3","gravatar_id":"","url":"https://api.github.com/users/EMCECS","html_url":"https://github.com/EMCECS","followers_url":"https://api.github.com/users/EMCECS/followers","following_url":"https://api.github.com/users/EMCECS/following{/other_user}","gists_url":"https://api.github.com/users/EMCECS/gists{/gist_id}","starred_url":"https://api.github.com/users/EMCECS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EMCECS/subscriptions","organizations_url":"https://api.github.com/users/EMCECS/orgs","repos_url":"https://api.github.com/users/EMCECS/repos","events_url":"https://api.github.com/users/EMCECS/events{/privacy}","received_events_url":"https://api.github.com/users/EMCECS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EMCECS/ECS-CommunityEdition","description":"ECS Community Edition (aka Free & Frictionless) Repository ","fork":false,"url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition","forks_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/forks","keys_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/teams","hooks_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/hooks","issue_events_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/events{/number}","events_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/events","assignees_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/assignees{/user}","branches_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/branches{/branch}","tags_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/tags","blobs_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/git/refs{/sha}","trees_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/statuses/{sha}","languages_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/languages","stargazers_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/stargazers","contributors_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/contributors","subscribers_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/subscribers","subscription_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/subscription","commits_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/commits{/sha}","git_commits_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/git/commits{/sha}","comments_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/comments{/number}","issue_comment_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/comments{/number}","contents_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/contents/{+path}","compare_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/merges","archive_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/downloads","issues_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues{/number}","pulls_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls{/number}","milestones_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/milestones{/number}","notifications_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/labels{/name}","releases_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/releases{/id}","deployments_url":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/deployments","created_at":"2015-06-16T21:16:20Z","updated_at":"2017-05-12T10:53:51Z","pushed_at":"2017-05-13T03:18:41Z","git_url":"git://github.com/EMCECS/ECS-CommunityEdition.git","ssh_url":"git@github.com:EMCECS/ECS-CommunityEdition.git","clone_url":"https://github.com/EMCECS/ECS-CommunityEdition.git","svn_url":"https://github.com/EMCECS/ECS-CommunityEdition","homepage":"","size":3249,"stargazers_count":49,"watchers_count":49,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":48,"forks":39,"open_issues":48,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231"},"html":{"href":"https://github.com/EMCECS/ECS-CommunityEdition/pull/231"},"issue":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/231"},"comments":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/EMCECS/ECS-CommunityEdition/statuses/d647b9dc9103476bdc5d1a9f0e12aca15ad97e05"}}}}
|
{
"id": 37556554,
"name": "EMCECS/ECS-CommunityEdition",
"url": "https://api.github.com/repos/EMCECS/ECS-CommunityEdition"
}
|
{
"id": 3824438,
"login": "padthaitofuhot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3824438?",
"url": "https://api.github.com/users/padthaitofuhot"
}
|
{
"id": 12926680,
"login": "EMCECS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12926680?",
"url": "https://api.github.com/orgs/EMCECS"
}
| 2017-05-15T16:18:39 |
5874556685
|
{"actor":{"display_login":"padthaitofuhot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/G-Node/gin-repo/pulls/comments/96305984","pull_request_review_id":16884019,"id":96305984,"diff_hunk":"@@ -749,27 +749,29 @@ func (s *Server) listRepoCollaborators(w http.ResponseWriter, r *http.Request) {\n \t\treturn\n \t}\n \n+\ttype collaborator struct {\n+\t\tUser string `json:\"User\"`","path":"cmd/gin-repod/repo.go","position":5,"original_position":5,"commit_id":"3333add739a1b0bfc55e1631fa10661c69bce618","original_commit_id":"3333add739a1b0bfc55e1631fa10661c69bce618","user":{"login":"gicmo","id":2040,"avatar_url":"https://avatars.githubusercontent.com/u/2040?v=3","gravatar_id":"","url":"https://api.github.com/users/gicmo","html_url":"https://github.com/gicmo","followers_url":"https://api.github.com/users/gicmo/followers","following_url":"https://api.github.com/users/gicmo/following{/other_user}","gists_url":"https://api.github.com/users/gicmo/gists{/gist_id}","starred_url":"https://api.github.com/users/gicmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gicmo/subscriptions","organizations_url":"https://api.github.com/users/gicmo/orgs","repos_url":"https://api.github.com/users/gicmo/repos","events_url":"https://api.github.com/users/gicmo/events{/privacy}","received_events_url":"https://api.github.com/users/gicmo/received_events","type":"User","site_admin":false},"body":"The `json:User` part as well es the `json:AccessLevel` part are not really required, but I guess they don't hurt much either.","created_at":"2017-01-16T21:15:34Z","updated_at":"2017-01-16T21:15:34Z","html_url":"https://github.com/G-Node/gin-repo/pull/71#discussion_r96305984","pull_request_url":"https://api.github.com/repos/G-Node/gin-repo/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/comments/96305984"},"html":{"href":"https://github.com/G-Node/gin-repo/pull/71#discussion_r96305984"},"pull_request":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/G-Node/gin-repo/pulls/71","id":101732463,"html_url":"https://github.com/G-Node/gin-repo/pull/71","diff_url":"https://github.com/G-Node/gin-repo/pull/71.diff","patch_url":"https://github.com/G-Node/gin-repo/pull/71.patch","issue_url":"https://api.github.com/repos/G-Node/gin-repo/issues/71","number":71,"state":"open","locked":false,"title":"Collaborator handling","user":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars.githubusercontent.com/u/9533513?v=3","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"body":"Closes #69.\r\n\r\nAdditional changes\r\n- A jQuery 1.9+ ajax request requires a non empty JSON string in the request response ([details](http://jquery.com/upgrade-guide/1.9/#jquery-ajax-returning-a-json-result-of-an-empty-string)). This pull request adds a minimal JSON response to `putRepoCollaborator` due to this reason.","created_at":"2017-01-16T17:39:31Z","updated_at":"2017-01-16T21:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79853edd9c9b4c41d05cd9ad4817261061bbd1b4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/G-Node/gin-repo/pulls/71/commits","review_comments_url":"https://api.github.com/repos/G-Node/gin-repo/pulls/71/comments","review_comment_url":"https://api.github.com/repos/G-Node/gin-repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/G-Node/gin-repo/issues/71/comments","statuses_url":"https://api.github.com/repos/G-Node/gin-repo/statuses/3333add739a1b0bfc55e1631fa10661c69bce618","head":{"label":"mpsonntag:collabHandling","ref":"collabHandling","sha":"3333add739a1b0bfc55e1631fa10661c69bce618","user":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars.githubusercontent.com/u/9533513?v=3","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"repo":{"id":66255194,"name":"gin-repo","full_name":"mpsonntag/gin-repo","owner":{"login":"mpsonntag","id":9533513,"avatar_url":"https://avatars.githubusercontent.com/u/9533513?v=3","gravatar_id":"","url":"https://api.github.com/users/mpsonntag","html_url":"https://github.com/mpsonntag","followers_url":"https://api.github.com/users/mpsonntag/followers","following_url":"https://api.github.com/users/mpsonntag/following{/other_user}","gists_url":"https://api.github.com/users/mpsonntag/gists{/gist_id}","starred_url":"https://api.github.com/users/mpsonntag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpsonntag/subscriptions","organizations_url":"https://api.github.com/users/mpsonntag/orgs","repos_url":"https://api.github.com/users/mpsonntag/repos","events_url":"https://api.github.com/users/mpsonntag/events{/privacy}","received_events_url":"https://api.github.com/users/mpsonntag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpsonntag/gin-repo","description":null,"fork":true,"url":"https://api.github.com/repos/mpsonntag/gin-repo","forks_url":"https://api.github.com/repos/mpsonntag/gin-repo/forks","keys_url":"https://api.github.com/repos/mpsonntag/gin-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpsonntag/gin-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpsonntag/gin-repo/teams","hooks_url":"https://api.github.com/repos/mpsonntag/gin-repo/hooks","issue_events_url":"https://api.github.com/repos/mpsonntag/gin-repo/issues/events{/number}","events_url":"https://api.github.com/repos/mpsonntag/gin-repo/events","assignees_url":"https://api.github.com/repos/mpsonntag/gin-repo/assignees{/user}","branches_url":"https://api.github.com/repos/mpsonntag/gin-repo/branches{/branch}","tags_url":"https://api.github.com/repos/mpsonntag/gin-repo/tags","blobs_url":"https://api.github.com/repos/mpsonntag/gin-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpsonntag/gin-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpsonntag/gin-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpsonntag/gin-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpsonntag/gin-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/mpsonntag/gin-repo/languages","stargazers_url":"https://api.github.com/repos/mpsonntag/gin-repo/stargazers","contributors_url":"https://api.github.com/repos/mpsonntag/gin-repo/contributors","subscribers_url":"https://api.github.com/repos/mpsonntag/gin-repo/subscribers","subscription_url":"https://api.github.com/repos/mpsonntag/gin-repo/subscription","commits_url":"https://api.github.com/repos/mpsonntag/gin-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpsonntag/gin-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpsonntag/gin-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpsonntag/gin-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpsonntag/gin-repo/contents/{+path}","compare_url":"https://api.github.com/repos/mpsonntag/gin-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpsonntag/gin-repo/merges","archive_url":"https://api.github.com/repos/mpsonntag/gin-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpsonntag/gin-repo/downloads","issues_url":"https://api.github.com/repos/mpsonntag/gin-repo/issues{/number}","pulls_url":"https://api.github.com/repos/mpsonntag/gin-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/mpsonntag/gin-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/mpsonntag/gin-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpsonntag/gin-repo/labels{/name}","releases_url":"https://api.github.com/repos/mpsonntag/gin-repo/releases{/id}","deployments_url":"https://api.github.com/repos/mpsonntag/gin-repo/deployments","created_at":"2016-08-22T08:45:54Z","updated_at":"2016-08-22T08:45:55Z","pushed_at":"2017-01-16T16:37:23Z","git_url":"git://github.com/mpsonntag/gin-repo.git","ssh_url":"git@github.com:mpsonntag/gin-repo.git","clone_url":"https://github.com/mpsonntag/gin-repo.git","svn_url":"https://github.com/mpsonntag/gin-repo","homepage":null,"size":312,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"G-Node:master","ref":"master","sha":"5d16556ad417c270e273c241724c553fe3f85b64","user":{"login":"G-Node","id":574778,"avatar_url":"https://avatars.githubusercontent.com/u/574778?v=3","gravatar_id":"","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"repo":{"id":54627870,"name":"gin-repo","full_name":"G-Node/gin-repo","owner":{"login":"G-Node","id":574778,"avatar_url":"https://avatars.githubusercontent.com/u/574778?v=3","gravatar_id":"","url":"https://api.github.com/users/G-Node","html_url":"https://github.com/G-Node","followers_url":"https://api.github.com/users/G-Node/followers","following_url":"https://api.github.com/users/G-Node/following{/other_user}","gists_url":"https://api.github.com/users/G-Node/gists{/gist_id}","starred_url":"https://api.github.com/users/G-Node/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/G-Node/subscriptions","organizations_url":"https://api.github.com/users/G-Node/orgs","repos_url":"https://api.github.com/users/G-Node/repos","events_url":"https://api.github.com/users/G-Node/events{/privacy}","received_events_url":"https://api.github.com/users/G-Node/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/G-Node/gin-repo","description":"G-Node Infrastructure - Repository server","fork":false,"url":"https://api.github.com/repos/G-Node/gin-repo","forks_url":"https://api.github.com/repos/G-Node/gin-repo/forks","keys_url":"https://api.github.com/repos/G-Node/gin-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/G-Node/gin-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/G-Node/gin-repo/teams","hooks_url":"https://api.github.com/repos/G-Node/gin-repo/hooks","issue_events_url":"https://api.github.com/repos/G-Node/gin-repo/issues/events{/number}","events_url":"https://api.github.com/repos/G-Node/gin-repo/events","assignees_url":"https://api.github.com/repos/G-Node/gin-repo/assignees{/user}","branches_url":"https://api.github.com/repos/G-Node/gin-repo/branches{/branch}","tags_url":"https://api.github.com/repos/G-Node/gin-repo/tags","blobs_url":"https://api.github.com/repos/G-Node/gin-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/G-Node/gin-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/G-Node/gin-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/G-Node/gin-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/G-Node/gin-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/G-Node/gin-repo/languages","stargazers_url":"https://api.github.com/repos/G-Node/gin-repo/stargazers","contributors_url":"https://api.github.com/repos/G-Node/gin-repo/contributors","subscribers_url":"https://api.github.com/repos/G-Node/gin-repo/subscribers","subscription_url":"https://api.github.com/repos/G-Node/gin-repo/subscription","commits_url":"https://api.github.com/repos/G-Node/gin-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/G-Node/gin-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/G-Node/gin-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/G-Node/gin-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/G-Node/gin-repo/contents/{+path}","compare_url":"https://api.github.com/repos/G-Node/gin-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/G-Node/gin-repo/merges","archive_url":"https://api.github.com/repos/G-Node/gin-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/G-Node/gin-repo/downloads","issues_url":"https://api.github.com/repos/G-Node/gin-repo/issues{/number}","pulls_url":"https://api.github.com/repos/G-Node/gin-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/G-Node/gin-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/G-Node/gin-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/G-Node/gin-repo/labels{/name}","releases_url":"https://api.github.com/repos/G-Node/gin-repo/releases{/id}","deployments_url":"https://api.github.com/repos/G-Node/gin-repo/deployments","created_at":"2016-03-24T08:48:31Z","updated_at":"2016-10-27T11:58:02Z","pushed_at":"2017-01-16T17:39:32Z","git_url":"git://github.com/G-Node/gin-repo.git","ssh_url":"git@github.com:G-Node/gin-repo.git","clone_url":"https://github.com/G-Node/gin-repo.git","svn_url":"https://github.com/G-Node/gin-repo","homepage":"","size":373,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":19,"forks":5,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/71"},"html":{"href":"https://github.com/G-Node/gin-repo/pull/71"},"issue":{"href":"https://api.github.com/repos/G-Node/gin-repo/issues/71"},"comments":{"href":"https://api.github.com/repos/G-Node/gin-repo/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/G-Node/gin-repo/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/G-Node/gin-repo/statuses/3333add739a1b0bfc55e1631fa10661c69bce618"}}}}
|
{
"id": 54627870,
"name": "G-Node/gin-repo",
"url": "https://api.github.com/repos/G-Node/gin-repo"
}
|
{
"id": 2040,
"login": "gicmo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2040?",
"url": "https://api.github.com/users/gicmo"
}
|
{
"id": 574778,
"login": "G-Node",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/574778?",
"url": "https://api.github.com/orgs/G-Node"
}
| 2017-01-16T21:15:34 |
5161688415
|
{"actor":{"display_login":"gicmo"}}
|