type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
334k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
10
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/comments/122384978","pull_request_review_id":44496243,"id":122384978,"diff_hunk":"@@ -0,0 +1,230 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\" ?>\n+<!--\n+ *\n+ * (c) Kitodo. Key to digital objects e. V. <contact@kitodo.org>\n+ *\n+ * This file is part of the Kitodo project.\n+ *\n+ * It is licensed under GNU General Public License version 3 or later.\n+ *\n+ * For the full copyright and license information, please read the\n+ * GPL3-License.txt file that was distributed with this source code.\n+ *\n+-->\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+ xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+ xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0\n+ http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n+ <modelVersion>4.0.0</modelVersion>\n+ <groupId>org.kitodo</groupId>\n+ <artifactId>kitodo-ugh</artifactId>\n+ <version>3.0-SNAPSHOT</version>\n+\n+ <organization>\n+ <name>kitodo.org</name>\n+ <url>http://kitodo.org</url>\n+ </organization>\n+ <name>Kitodo UGH</name>\n+ <url>https://github.com/kitodo/kitodo-ugh</url>\n+\n+ <properties>\n+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>\n+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>\n+ <maven.compiler.source>1.7</maven.compiler.source>\n+ <maven.compiler.target>1.7</maven.compiler.target>\n+ <timestamp>${maven.build.timestamp}</timestamp>\n+ <maven.build.timestamp.format>dd-MMMM-yyyy HH:mm:ss</maven.build.timestamp.format>\n+ </properties>\n+\n+ <repositories>\n+ <!-- Let's first add the default Maven central repo,\n+ otherwise Maven will not use Maven Central as first download option -->\n+ <repository>\n+ <id>central</id>\n+ <name>Maven Repository Switchboard</name>\n+ <layout>default</layout>\n+ <url>https://repo1.maven.org/maven2</url>\n+ <snapshots>\n+ <enabled>false</enabled>\n+ </snapshots>\n+ </repository>\n+ <repository>\n+ <id>maven-eu</id>\n+ <name>maven-eu Repository</name>\n+ <url>https://maven-eu.nuxeo.org/nexus/content/repositories/public/</url>\n+ <snapshots>\n+ <enabled>false</enabled>\n+ </snapshots>\n+ </repository>\n+ <repository>\n+ <id>slubnexus-public</id>\n+ <name>Slub-Nexus:3rd Party Releases</name>\n+ <url>http://nexus.slub-dresden.de:8081/nexus/content/repositories/public/</url>\n+ <releases>\n+ <enabled>true</enabled>\n+ </releases>\n+ </repository>\n+ <repository>\n+ <id>slubnexus-snapshots</id>\n+ <name>Slub-Nexus:Internal Snapshots</name>\n+ <url>http://nexus.slub-dresden.de:8081/nexus/content/repositories/snapshots/</url>\n+ <snapshots>\n+ <enabled>true</enabled>\n+ </snapshots>\n+ </repository>\n+ <repository>\n+ <id>slubnexus-releases</id>\n+ <name>Slub-Nexus:Internal Releases</name>\n+ <url>http://nexus.slub-dresden.de:8081/nexus/content/repositories/releases/</url>\n+ <releases>\n+ <enabled>true</enabled>\n+ </releases>\n+ </repository>\n+ </repositories>\n+\n+ <dependencies>\n+ <dependency>\n+ <groupId>com.lowagie</groupId>\n+ <artifactId>itext</artifactId>\n+ <version>2.1.5</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>com.thoughtworks.xstream</groupId>\n+ <artifactId>xstream</artifactId>\n+ <version>1.3.1</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>commons-cli</groupId>\n+ <artifactId>commons-cli</artifactId>\n+ <version>1.2</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>commons-configuration</groupId>\n+ <artifactId>commons-configuration</artifactId>\n+ <version>1.6</version>\n+ <exclusions>\n+ <exclusion>\n+ <artifactId>commons-logging</artifactId>\n+ <groupId>commons-logging</groupId>\n+ </exclusion>\n+ </exclusions>\n+ </dependency>\n+ <dependency>\n+ <groupId>commons-io</groupId>\n+ <artifactId>commons-io</artifactId>\n+ <version>1.4</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>commons-jxpath</groupId>\n+ <artifactId>commons-jxpath</artifactId>\n+ <version>1.2</version>\n+ <exclusions>\n+ <exclusion>\n+ <artifactId>servlet-api</artifactId>\n+ <groupId>javax.servlet</groupId>\n+ </exclusion>\n+ <exclusion>\n+ <artifactId>xerces</artifactId>\n+ <groupId>xerces</groupId>\n+ </exclusion>\n+ <exclusion>\n+ <groupId>commons-collections</groupId>\n+ <artifactId>commons-collections</artifactId>\n+ </exclusion>\n+ <exclusion>\n+ <artifactId>commons-logging</artifactId>\n+ <groupId>commons-logging</groupId>\n+ </exclusion>\n+ <exclusion>\n+ <groupId>jdom</groupId>\n+ <artifactId>jdom</artifactId>\n+ </exclusion>\n+ <exclusion>\n+ <groupId>junit</groupId>\n+ <artifactId>junit</artifactId>\n+ </exclusion>\n+ </exclusions>\n+ </dependency>\n+ <dependency>\n+ <groupId>poi</groupId>\n+ <artifactId>poi</artifactId>\n+ <version>2.0-final-20040126</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.apache.xmlbeans</groupId>\n+ <artifactId>xmlbeans</artifactId>\n+ <version>2.4.0</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>xerces</groupId>\n+ <artifactId>xercesImpl</artifactId>\n+ <version>2.9.1</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>javax.media</groupId>\n+ <artifactId>jai_codec</artifactId>\n+ <version>1.1.2_01</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>javax.media</groupId>\n+ <artifactId>jai_core</artifactId>\n+ <version>1.1.2_01</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.apache.logging.log4j</groupId>\n+ <artifactId>log4j-core</artifactId>\n+ <version>2.6.2</version>\n+ </dependency>\n+ <!-- compatiblity layer for old log4j version 1 loggers -->\n+ <dependency>\n+ <groupId>org.apache.logging.log4j</groupId>\n+ <artifactId>log4j-1.2-api</artifactId>\n+ <version>2.6.2</version>\n+ </dependency>\n+ <!-- replacement for commons-logging through log4j2 -->\n+ <dependency>\n+ <groupId>org.apache.logging.log4j</groupId>\n+ <artifactId>log4j-jcl</artifactId>\n+ <version>2.6.2</version>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.apache.oro</groupId>","path":"pom.xml","position":191,"original_position":191,"commit_id":"4698667983e66f120d6e9aff3263b0a5efdd0f89","original_commit_id":"4698667983e66f120d6e9aff3263b0a5efdd0f89","user":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars0.githubusercontent.com/u/2129672?v=3","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"body":"I take this information from https://mvnrepository.com/artifact/org.apache.oro/com.springsource.org.apache.oro/2.0.8 and I think, this should be OK or?","created_at":"2017-06-16T07:59:38Z","updated_at":"2017-06-16T07:59:38Z","html_url":"https://github.com/kitodo/kitodo-ugh/pull/67#discussion_r122384978","pull_request_url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/comments/122384978"},"html":{"href":"https://github.com/kitodo/kitodo-ugh/pull/67#discussion_r122384978"},"pull_request":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67","id":125967273,"html_url":"https://github.com/kitodo/kitodo-ugh/pull/67","diff_url":"https://github.com/kitodo/kitodo-ugh/pull/67.diff","patch_url":"https://github.com/kitodo/kitodo-ugh/pull/67.patch","issue_url":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/67","number":67,"state":"open","locked":false,"title":"Maven","user":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars0.githubusercontent.com/u/2129672?v=3","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"body":"Convert current ant based structure to a maven structure","created_at":"2017-06-16T06:28:03Z","updated_at":"2017-06-16T07:59:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5060fcdb24f2b9e2c5927121ab1dbc4797e25d5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kitodo/kitodo-ugh/milestones/3","html_url":"https://github.com/kitodo/kitodo-ugh/milestone/3","labels_url":"https://api.github.com/repos/kitodo/kitodo-ugh/milestones/3/labels","id":2516921,"number":3,"title":"Kitodo.UGH 3.x","description":"Contains changes needed for Kitodo.Production master branch development and resulting Kitodo.Production 3.x release","creator":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars0.githubusercontent.com/u/2129672?v=3","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2017-05-12T09:09:53Z","updated_at":"2017-06-16T06:28:03Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67/commits","review_comments_url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67/comments","review_comment_url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/67/comments","statuses_url":"https://api.github.com/repos/kitodo/kitodo-ugh/statuses/4698667983e66f120d6e9aff3263b0a5efdd0f89","head":{"label":"henning-gerhardt:maven","ref":"maven","sha":"4698667983e66f120d6e9aff3263b0a5efdd0f89","user":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars0.githubusercontent.com/u/2129672?v=3","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"repo":{"id":27480466,"name":"kitodo-ugh","full_name":"henning-gerhardt/kitodo-ugh","owner":{"login":"henning-gerhardt","id":2129672,"avatar_url":"https://avatars0.githubusercontent.com/u/2129672?v=3","gravatar_id":"","url":"https://api.github.com/users/henning-gerhardt","html_url":"https://github.com/henning-gerhardt","followers_url":"https://api.github.com/users/henning-gerhardt/followers","following_url":"https://api.github.com/users/henning-gerhardt/following{/other_user}","gists_url":"https://api.github.com/users/henning-gerhardt/gists{/gist_id}","starred_url":"https://api.github.com/users/henning-gerhardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henning-gerhardt/subscriptions","organizations_url":"https://api.github.com/users/henning-gerhardt/orgs","repos_url":"https://api.github.com/users/henning-gerhardt/repos","events_url":"https://api.github.com/users/henning-gerhardt/events{/privacy}","received_events_url":"https://api.github.com/users/henning-gerhardt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henning-gerhardt/kitodo-ugh","description":"Goobi.UGH Library Community Edition","fork":true,"url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh","forks_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/forks","keys_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/teams","hooks_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/hooks","issue_events_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/issues/events{/number}","events_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/events","assignees_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/assignees{/user}","branches_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/branches{/branch}","tags_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/tags","blobs_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/git/refs{/sha}","trees_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/statuses/{sha}","languages_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/languages","stargazers_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/stargazers","contributors_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/contributors","subscribers_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/subscribers","subscription_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/subscription","commits_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/commits{/sha}","git_commits_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/git/commits{/sha}","comments_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/comments{/number}","issue_comment_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/issues/comments{/number}","contents_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/contents/{+path}","compare_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/merges","archive_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/downloads","issues_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/issues{/number}","pulls_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/pulls{/number}","milestones_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/milestones{/number}","notifications_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/labels{/name}","releases_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/releases{/id}","deployments_url":"https://api.github.com/repos/henning-gerhardt/kitodo-ugh/deployments","created_at":"2014-12-03T09:55:38Z","updated_at":"2017-01-10T08:36:22Z","pushed_at":"2017-05-22T10:56:47Z","git_url":"git://github.com/henning-gerhardt/kitodo-ugh.git","ssh_url":"git@github.com:henning-gerhardt/kitodo-ugh.git","clone_url":"https://github.com/henning-gerhardt/kitodo-ugh.git","svn_url":"https://github.com/henning-gerhardt/kitodo-ugh","homepage":"","size":20069,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kitodo:master","ref":"master","sha":"9e63de88048ae87e7a3711b6c4792c1e0d88da66","user":{"login":"kitodo","id":18034325,"avatar_url":"https://avatars0.githubusercontent.com/u/18034325?v=3","gravatar_id":"","url":"https://api.github.com/users/kitodo","html_url":"https://github.com/kitodo","followers_url":"https://api.github.com/users/kitodo/followers","following_url":"https://api.github.com/users/kitodo/following{/other_user}","gists_url":"https://api.github.com/users/kitodo/gists{/gist_id}","starred_url":"https://api.github.com/users/kitodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitodo/subscriptions","organizations_url":"https://api.github.com/users/kitodo/orgs","repos_url":"https://api.github.com/users/kitodo/repos","events_url":"https://api.github.com/users/kitodo/events{/privacy}","received_events_url":"https://api.github.com/users/kitodo/received_events","type":"Organization","site_admin":false},"repo":{"id":19273723,"name":"kitodo-ugh","full_name":"kitodo/kitodo-ugh","owner":{"login":"kitodo","id":18034325,"avatar_url":"https://avatars0.githubusercontent.com/u/18034325?v=3","gravatar_id":"","url":"https://api.github.com/users/kitodo","html_url":"https://github.com/kitodo","followers_url":"https://api.github.com/users/kitodo/followers","following_url":"https://api.github.com/users/kitodo/following{/other_user}","gists_url":"https://api.github.com/users/kitodo/gists{/gist_id}","starred_url":"https://api.github.com/users/kitodo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitodo/subscriptions","organizations_url":"https://api.github.com/users/kitodo/orgs","repos_url":"https://api.github.com/users/kitodo/repos","events_url":"https://api.github.com/users/kitodo/events{/privacy}","received_events_url":"https://api.github.com/users/kitodo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kitodo/kitodo-ugh","description":"Kitodo.UGH Library","fork":false,"url":"https://api.github.com/repos/kitodo/kitodo-ugh","forks_url":"https://api.github.com/repos/kitodo/kitodo-ugh/forks","keys_url":"https://api.github.com/repos/kitodo/kitodo-ugh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kitodo/kitodo-ugh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kitodo/kitodo-ugh/teams","hooks_url":"https://api.github.com/repos/kitodo/kitodo-ugh/hooks","issue_events_url":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/events{/number}","events_url":"https://api.github.com/repos/kitodo/kitodo-ugh/events","assignees_url":"https://api.github.com/repos/kitodo/kitodo-ugh/assignees{/user}","branches_url":"https://api.github.com/repos/kitodo/kitodo-ugh/branches{/branch}","tags_url":"https://api.github.com/repos/kitodo/kitodo-ugh/tags","blobs_url":"https://api.github.com/repos/kitodo/kitodo-ugh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kitodo/kitodo-ugh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kitodo/kitodo-ugh/git/refs{/sha}","trees_url":"https://api.github.com/repos/kitodo/kitodo-ugh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kitodo/kitodo-ugh/statuses/{sha}","languages_url":"https://api.github.com/repos/kitodo/kitodo-ugh/languages","stargazers_url":"https://api.github.com/repos/kitodo/kitodo-ugh/stargazers","contributors_url":"https://api.github.com/repos/kitodo/kitodo-ugh/contributors","subscribers_url":"https://api.github.com/repos/kitodo/kitodo-ugh/subscribers","subscription_url":"https://api.github.com/repos/kitodo/kitodo-ugh/subscription","commits_url":"https://api.github.com/repos/kitodo/kitodo-ugh/commits{/sha}","git_commits_url":"https://api.github.com/repos/kitodo/kitodo-ugh/git/commits{/sha}","comments_url":"https://api.github.com/repos/kitodo/kitodo-ugh/comments{/number}","issue_comment_url":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/comments{/number}","contents_url":"https://api.github.com/repos/kitodo/kitodo-ugh/contents/{+path}","compare_url":"https://api.github.com/repos/kitodo/kitodo-ugh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kitodo/kitodo-ugh/merges","archive_url":"https://api.github.com/repos/kitodo/kitodo-ugh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kitodo/kitodo-ugh/downloads","issues_url":"https://api.github.com/repos/kitodo/kitodo-ugh/issues{/number}","pulls_url":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls{/number}","milestones_url":"https://api.github.com/repos/kitodo/kitodo-ugh/milestones{/number}","notifications_url":"https://api.github.com/repos/kitodo/kitodo-ugh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kitodo/kitodo-ugh/labels{/name}","releases_url":"https://api.github.com/repos/kitodo/kitodo-ugh/releases{/id}","deployments_url":"https://api.github.com/repos/kitodo/kitodo-ugh/deployments","created_at":"2014-04-29T11:12:59Z","updated_at":"2016-11-10T22:14:26Z","pushed_at":"2017-06-16T06:28:03Z","git_url":"git://github.com/kitodo/kitodo-ugh.git","ssh_url":"git@github.com:kitodo/kitodo-ugh.git","clone_url":"https://github.com/kitodo/kitodo-ugh.git","svn_url":"https://github.com/kitodo/kitodo-ugh","homepage":"","size":20065,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67"},"html":{"href":"https://github.com/kitodo/kitodo-ugh/pull/67"},"issue":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/67"},"comments":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/kitodo/kitodo-ugh/statuses/4698667983e66f120d6e9aff3263b0a5efdd0f89"}}}}
|
{
"id": 19273723,
"name": "kitodo/kitodo-ugh",
"url": "https://api.github.com/repos/kitodo/kitodo-ugh"
}
|
{
"id": 2129672,
"login": "henning-gerhardt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2129672?",
"url": "https://api.github.com/users/henning-gerhardt"
}
|
{
"id": 18034325,
"login": "kitodo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18034325?",
"url": "https://api.github.com/orgs/kitodo"
}
| 2017-06-16T07:59:38 |
6078347317
|
{"actor":{"display_login":"henning-gerhardt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ligato/cn-infra/pulls/comments/154934252","pull_request_review_id":81169843,"id":154934252,"diff_hunk":"@@ -24,3 +25,14 @@ message PluginStatus {\n int64 last_update = 5; /* last update of the state */\n string error = 6; /* last seen error */\n }\n+\n+message InterfaceStatus {\n+ message Interfaces {","path":"health/statuscheck/model/status/status.proto","position":14,"original_position":14,"commit_id":"e562976f8783ae16a6bd9ea8138ec615b0016557","original_commit_id":"e562976f8783ae16a6bd9ea8138ec615b0016557","user":{"login":"ondrej-fabry","id":32484950,"avatar_url":"https://avatars1.githubusercontent.com/u/32484950?v=4","gravatar_id":"","url":"https://api.github.com/users/ondrej-fabry","html_url":"https://github.com/ondrej-fabry","followers_url":"https://api.github.com/users/ondrej-fabry/followers","following_url":"https://api.github.com/users/ondrej-fabry/following{/other_user}","gists_url":"https://api.github.com/users/ondrej-fabry/gists{/gist_id}","starred_url":"https://api.github.com/users/ondrej-fabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ondrej-fabry/subscriptions","organizations_url":"https://api.github.com/users/ondrej-fabry/orgs","repos_url":"https://api.github.com/users/ondrej-fabry/repos","events_url":"https://api.github.com/users/ondrej-fabry/events{/privacy}","received_events_url":"https://api.github.com/users/ondrej-fabry/received_events","type":"User","site_admin":false},"body":"This should be `Interface`.","created_at":"2017-12-05T12:49:03Z","updated_at":"2017-12-05T12:49:03Z","html_url":"https://github.com/ligato/cn-infra/pull/227#discussion_r154934252","pull_request_url":"https://api.github.com/repos/ligato/cn-infra/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/comments/154934252"},"html":{"href":"https://github.com/ligato/cn-infra/pull/227#discussion_r154934252"},"pull_request":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/ligato/cn-infra/pulls/227","id":155838731,"html_url":"https://github.com/ligato/cn-infra/pull/227","diff_url":"https://github.com/ligato/cn-infra/pull/227.diff","patch_url":"https://github.com/ligato/cn-infra/pull/227.patch","issue_url":"https://api.github.com/repos/ligato/cn-infra/issues/227","number":227,"state":"open","locked":false,"title":"ODPM-642: add interface state to readiness probe ","user":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-01T11:19:25Z","updated_at":"2017-12-05T12:49:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb53024063405d16036935096dac4c6d99b9c268","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ligato/cn-infra/pulls/227/commits","review_comments_url":"https://api.github.com/repos/ligato/cn-infra/pulls/227/comments","review_comment_url":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ligato/cn-infra/issues/227/comments","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/e562976f8783ae16a6bd9ea8138ec615b0016557","head":{"label":"VladoLavor:dev","ref":"dev","sha":"e562976f8783ae16a6bd9ea8138ec615b0016557","user":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"repo":{"id":98873097,"name":"cn-infra","full_name":"VladoLavor/cn-infra","owner":{"login":"VladoLavor","id":15376606,"avatar_url":"https://avatars2.githubusercontent.com/u/15376606?v=4","gravatar_id":"","url":"https://api.github.com/users/VladoLavor","html_url":"https://github.com/VladoLavor","followers_url":"https://api.github.com/users/VladoLavor/followers","following_url":"https://api.github.com/users/VladoLavor/following{/other_user}","gists_url":"https://api.github.com/users/VladoLavor/gists{/gist_id}","starred_url":"https://api.github.com/users/VladoLavor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VladoLavor/subscriptions","organizations_url":"https://api.github.com/users/VladoLavor/orgs","repos_url":"https://api.github.com/users/VladoLavor/repos","events_url":"https://api.github.com/users/VladoLavor/events{/privacy}","received_events_url":"https://api.github.com/users/VladoLavor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VladoLavor/cn-infra","description":"Cloud-native Virtual Network Function (VNF) framework","fork":true,"url":"https://api.github.com/repos/VladoLavor/cn-infra","forks_url":"https://api.github.com/repos/VladoLavor/cn-infra/forks","keys_url":"https://api.github.com/repos/VladoLavor/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VladoLavor/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VladoLavor/cn-infra/teams","hooks_url":"https://api.github.com/repos/VladoLavor/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/VladoLavor/cn-infra/events","assignees_url":"https://api.github.com/repos/VladoLavor/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/VladoLavor/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/tags","blobs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VladoLavor/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/VladoLavor/cn-infra/languages","stargazers_url":"https://api.github.com/repos/VladoLavor/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/VladoLavor/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/VladoLavor/cn-infra/subscription","commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/VladoLavor/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/VladoLavor/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/VladoLavor/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/VladoLavor/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VladoLavor/cn-infra/merges","archive_url":"https://api.github.com/repos/VladoLavor/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VladoLavor/cn-infra/downloads","issues_url":"https://api.github.com/repos/VladoLavor/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/VladoLavor/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/VladoLavor/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/VladoLavor/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VladoLavor/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/VladoLavor/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/VladoLavor/cn-infra/deployments","created_at":"2017-07-31T09:40:33Z","updated_at":"2017-07-31T09:40:35Z","pushed_at":"2017-12-04T10:20:44Z","git_url":"git://github.com/VladoLavor/cn-infra.git","ssh_url":"git@github.com:VladoLavor/cn-infra.git","clone_url":"https://github.com/VladoLavor/cn-infra.git","svn_url":"https://github.com/VladoLavor/cn-infra","homepage":"","size":62795,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ligato:master","ref":"master","sha":"ff4bac1b1d5b603433cd10242834facc6791e134","user":{"login":"ligato","id":28989152,"avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"repo":{"id":94889501,"name":"cn-infra","full_name":"ligato/cn-infra","owner":{"login":"ligato","id":28989152,"avatar_url":"https://avatars0.githubusercontent.com/u/28989152?v=4","gravatar_id":"","url":"https://api.github.com/users/ligato","html_url":"https://github.com/ligato","followers_url":"https://api.github.com/users/ligato/followers","following_url":"https://api.github.com/users/ligato/following{/other_user}","gists_url":"https://api.github.com/users/ligato/gists{/gist_id}","starred_url":"https://api.github.com/users/ligato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligato/subscriptions","organizations_url":"https://api.github.com/users/ligato/orgs","repos_url":"https://api.github.com/users/ligato/repos","events_url":"https://api.github.com/users/ligato/events{/privacy}","received_events_url":"https://api.github.com/users/ligato/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ligato/cn-infra","description":"A platform for developing cloud-native VNFs","fork":false,"url":"https://api.github.com/repos/ligato/cn-infra","forks_url":"https://api.github.com/repos/ligato/cn-infra/forks","keys_url":"https://api.github.com/repos/ligato/cn-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ligato/cn-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ligato/cn-infra/teams","hooks_url":"https://api.github.com/repos/ligato/cn-infra/hooks","issue_events_url":"https://api.github.com/repos/ligato/cn-infra/issues/events{/number}","events_url":"https://api.github.com/repos/ligato/cn-infra/events","assignees_url":"https://api.github.com/repos/ligato/cn-infra/assignees{/user}","branches_url":"https://api.github.com/repos/ligato/cn-infra/branches{/branch}","tags_url":"https://api.github.com/repos/ligato/cn-infra/tags","blobs_url":"https://api.github.com/repos/ligato/cn-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ligato/cn-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ligato/cn-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/ligato/cn-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ligato/cn-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/ligato/cn-infra/languages","stargazers_url":"https://api.github.com/repos/ligato/cn-infra/stargazers","contributors_url":"https://api.github.com/repos/ligato/cn-infra/contributors","subscribers_url":"https://api.github.com/repos/ligato/cn-infra/subscribers","subscription_url":"https://api.github.com/repos/ligato/cn-infra/subscription","commits_url":"https://api.github.com/repos/ligato/cn-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/ligato/cn-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/ligato/cn-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/ligato/cn-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/ligato/cn-infra/contents/{+path}","compare_url":"https://api.github.com/repos/ligato/cn-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ligato/cn-infra/merges","archive_url":"https://api.github.com/repos/ligato/cn-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ligato/cn-infra/downloads","issues_url":"https://api.github.com/repos/ligato/cn-infra/issues{/number}","pulls_url":"https://api.github.com/repos/ligato/cn-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/ligato/cn-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/ligato/cn-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ligato/cn-infra/labels{/name}","releases_url":"https://api.github.com/repos/ligato/cn-infra/releases{/id}","deployments_url":"https://api.github.com/repos/ligato/cn-infra/deployments","created_at":"2017-06-20T12:37:37Z","updated_at":"2017-11-24T06:54:07Z","pushed_at":"2017-12-04T10:22:49Z","git_url":"git://github.com/ligato/cn-infra.git","ssh_url":"git@github.com:ligato/cn-infra.git","clone_url":"https://github.com/ligato/cn-infra.git","svn_url":"https://github.com/ligato/cn-infra","homepage":"","size":62766,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":2,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/227"},"html":{"href":"https://github.com/ligato/cn-infra/pull/227"},"issue":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/227"},"comments":{"href":"https://api.github.com/repos/ligato/cn-infra/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ligato/cn-infra/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/ligato/cn-infra/statuses/e562976f8783ae16a6bd9ea8138ec615b0016557"}},"author_association":"COLLABORATOR"}}
|
{
"id": 94889501,
"name": "ligato/cn-infra",
"url": "https://api.github.com/repos/ligato/cn-infra"
}
|
{
"id": 32484950,
"login": "ondrej-fabry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/32484950?",
"url": "https://api.github.com/users/ondrej-fabry"
}
|
{
"id": 28989152,
"login": "ligato",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28989152?",
"url": "https://api.github.com/orgs/ligato"
}
| 2017-12-05T12:49:03 |
6945093687
|
{"actor":{"display_login":"ondrej-fabry"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/comments/157964946","pull_request_review_id":84694672,"id":157964946,"diff_hunk":"@@ -78,12 +80,14 @@ public function enableHardRotation(): self\n /**\n * Define threshold of how much relevant must the recommended items be to be returned.\n * Default minimal relevance is \"low\".\n+ *\n+ * @return static","path":"src/Model/Command/UserRecommendation.php","position":23,"original_position":23,"commit_id":"a3177c59225e8f1754ac30d657f1e877e6429962","original_commit_id":"a3177c59225e8f1754ac30d657f1e877e6429962","user":{"login":"Fantomas-7","id":33895432,"avatar_url":"https://avatars3.githubusercontent.com/u/33895432?v=4","gravatar_id":"","url":"https://api.github.com/users/Fantomas-7","html_url":"https://github.com/Fantomas-7","followers_url":"https://api.github.com/users/Fantomas-7/followers","following_url":"https://api.github.com/users/Fantomas-7/following{/other_user}","gists_url":"https://api.github.com/users/Fantomas-7/gists{/gist_id}","starred_url":"https://api.github.com/users/Fantomas-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fantomas-7/subscriptions","organizations_url":"https://api.github.com/users/Fantomas-7/orgs","repos_url":"https://api.github.com/users/Fantomas-7/repos","events_url":"https://api.github.com/users/Fantomas-7/events{/privacy}","received_events_url":"https://api.github.com/users/Fantomas-7/received_events","type":"User","site_admin":false},"body":"`@return static` and `@return $this` mean the same thing 🤔","created_at":"2017-12-20T08:49:32Z","updated_at":"2017-12-20T08:49:32Z","html_url":"https://github.com/lmc-eu/matej-client-php/pull/56#discussion_r157964946","pull_request_url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/comments/157964946"},"html":{"href":"https://github.com/lmc-eu/matej-client-php/pull/56#discussion_r157964946"},"pull_request":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56"}},"in_reply_to_id":157745618},"pull_request":{"url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56","id":157555622,"html_url":"https://github.com/lmc-eu/matej-client-php/pull/56","diff_url":"https://github.com/lmc-eu/matej-client-php/pull/56.diff","patch_url":"https://github.com/lmc-eu/matej-client-php/pull/56.patch","issue_url":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/56","number":56,"state":"open","locked":false,"title":"Use static instead of self where possible","user":{"login":"Fantomas-7","id":33895432,"avatar_url":"https://avatars3.githubusercontent.com/u/33895432?v=4","gravatar_id":"","url":"https://api.github.com/users/Fantomas-7","html_url":"https://github.com/Fantomas-7","followers_url":"https://api.github.com/users/Fantomas-7/followers","following_url":"https://api.github.com/users/Fantomas-7/following{/other_user}","gists_url":"https://api.github.com/users/Fantomas-7/gists{/gist_id}","starred_url":"https://api.github.com/users/Fantomas-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fantomas-7/subscriptions","organizations_url":"https://api.github.com/users/Fantomas-7/orgs","repos_url":"https://api.github.com/users/Fantomas-7/repos","events_url":"https://api.github.com/users/Fantomas-7/events{/privacy}","received_events_url":"https://api.github.com/users/Fantomas-7/received_events","type":"User","site_admin":false},"body":"Ref. #17","created_at":"2017-12-11T12:55:22Z","updated_at":"2017-12-20T08:49:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0c4a832f13ad6dd5f379d51b6933e41ede73967","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tenerd","id":270200,"avatar_url":"https://avatars2.githubusercontent.com/u/270200?v=4","gravatar_id":"","url":"https://api.github.com/users/tenerd","html_url":"https://github.com/tenerd","followers_url":"https://api.github.com/users/tenerd/followers","following_url":"https://api.github.com/users/tenerd/following{/other_user}","gists_url":"https://api.github.com/users/tenerd/gists{/gist_id}","starred_url":"https://api.github.com/users/tenerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenerd/subscriptions","organizations_url":"https://api.github.com/users/tenerd/orgs","repos_url":"https://api.github.com/users/tenerd/repos","events_url":"https://api.github.com/users/tenerd/events{/privacy}","received_events_url":"https://api.github.com/users/tenerd/received_events","type":"User","site_admin":false},{"login":"davidkmenta","id":759218,"avatar_url":"https://avatars3.githubusercontent.com/u/759218?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkmenta","html_url":"https://github.com/davidkmenta","followers_url":"https://api.github.com/users/davidkmenta/followers","following_url":"https://api.github.com/users/davidkmenta/following{/other_user}","gists_url":"https://api.github.com/users/davidkmenta/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkmenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkmenta/subscriptions","organizations_url":"https://api.github.com/users/davidkmenta/orgs","repos_url":"https://api.github.com/users/davidkmenta/repos","events_url":"https://api.github.com/users/davidkmenta/events{/privacy}","received_events_url":"https://api.github.com/users/davidkmenta/received_events","type":"User","site_admin":false},{"login":"jirinovak","id":1377270,"avatar_url":"https://avatars1.githubusercontent.com/u/1377270?v=4","gravatar_id":"","url":"https://api.github.com/users/jirinovak","html_url":"https://github.com/jirinovak","followers_url":"https://api.github.com/users/jirinovak/followers","following_url":"https://api.github.com/users/jirinovak/following{/other_user}","gists_url":"https://api.github.com/users/jirinovak/gists{/gist_id}","starred_url":"https://api.github.com/users/jirinovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirinovak/subscriptions","organizations_url":"https://api.github.com/users/jirinovak/orgs","repos_url":"https://api.github.com/users/jirinovak/repos","events_url":"https://api.github.com/users/jirinovak/events{/privacy}","received_events_url":"https://api.github.com/users/jirinovak/received_events","type":"User","site_admin":false},{"login":"kdosiodjinud","id":5029273,"avatar_url":"https://avatars1.githubusercontent.com/u/5029273?v=4","gravatar_id":"","url":"https://api.github.com/users/kdosiodjinud","html_url":"https://github.com/kdosiodjinud","followers_url":"https://api.github.com/users/kdosiodjinud/followers","following_url":"https://api.github.com/users/kdosiodjinud/following{/other_user}","gists_url":"https://api.github.com/users/kdosiodjinud/gists{/gist_id}","starred_url":"https://api.github.com/users/kdosiodjinud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kdosiodjinud/subscriptions","organizations_url":"https://api.github.com/users/kdosiodjinud/orgs","repos_url":"https://api.github.com/users/kdosiodjinud/repos","events_url":"https://api.github.com/users/kdosiodjinud/events{/privacy}","received_events_url":"https://api.github.com/users/kdosiodjinud/received_events","type":"User","site_admin":false},{"login":"MortalFlesh","id":6317184,"avatar_url":"https://avatars0.githubusercontent.com/u/6317184?v=4","gravatar_id":"","url":"https://api.github.com/users/MortalFlesh","html_url":"https://github.com/MortalFlesh","followers_url":"https://api.github.com/users/MortalFlesh/followers","following_url":"https://api.github.com/users/MortalFlesh/following{/other_user}","gists_url":"https://api.github.com/users/MortalFlesh/gists{/gist_id}","starred_url":"https://api.github.com/users/MortalFlesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MortalFlesh/subscriptions","organizations_url":"https://api.github.com/users/MortalFlesh/orgs","repos_url":"https://api.github.com/users/MortalFlesh/repos","events_url":"https://api.github.com/users/MortalFlesh/events{/privacy}","received_events_url":"https://api.github.com/users/MortalFlesh/received_events","type":"User","site_admin":false},{"login":"hokypierce","id":9384512,"avatar_url":"https://avatars1.githubusercontent.com/u/9384512?v=4","gravatar_id":"","url":"https://api.github.com/users/hokypierce","html_url":"https://github.com/hokypierce","followers_url":"https://api.github.com/users/hokypierce/followers","following_url":"https://api.github.com/users/hokypierce/following{/other_user}","gists_url":"https://api.github.com/users/hokypierce/gists{/gist_id}","starred_url":"https://api.github.com/users/hokypierce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hokypierce/subscriptions","organizations_url":"https://api.github.com/users/hokypierce/orgs","repos_url":"https://api.github.com/users/hokypierce/repos","events_url":"https://api.github.com/users/hokypierce/events{/privacy}","received_events_url":"https://api.github.com/users/hokypierce/received_events","type":"User","site_admin":false},{"login":"MarketaFilipova","id":22296471,"avatar_url":"https://avatars0.githubusercontent.com/u/22296471?v=4","gravatar_id":"","url":"https://api.github.com/users/MarketaFilipova","html_url":"https://github.com/MarketaFilipova","followers_url":"https://api.github.com/users/MarketaFilipova/followers","following_url":"https://api.github.com/users/MarketaFilipova/following{/other_user}","gists_url":"https://api.github.com/users/MarketaFilipova/gists{/gist_id}","starred_url":"https://api.github.com/users/MarketaFilipova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarketaFilipova/subscriptions","organizations_url":"https://api.github.com/users/MarketaFilipova/orgs","repos_url":"https://api.github.com/users/MarketaFilipova/repos","events_url":"https://api.github.com/users/MarketaFilipova/events{/privacy}","received_events_url":"https://api.github.com/users/MarketaFilipova/received_events","type":"User","site_admin":false},{"login":"florianjiri","id":33280741,"avatar_url":"https://avatars0.githubusercontent.com/u/33280741?v=4","gravatar_id":"","url":"https://api.github.com/users/florianjiri","html_url":"https://github.com/florianjiri","followers_url":"https://api.github.com/users/florianjiri/followers","following_url":"https://api.github.com/users/florianjiri/following{/other_user}","gists_url":"https://api.github.com/users/florianjiri/gists{/gist_id}","starred_url":"https://api.github.com/users/florianjiri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/florianjiri/subscriptions","organizations_url":"https://api.github.com/users/florianjiri/orgs","repos_url":"https://api.github.com/users/florianjiri/repos","events_url":"https://api.github.com/users/florianjiri/events{/privacy}","received_events_url":"https://api.github.com/users/florianjiri/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56/commits","review_comments_url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56/comments","review_comment_url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/56/comments","statuses_url":"https://api.github.com/repos/lmc-eu/matej-client-php/statuses/a3177c59225e8f1754ac30d657f1e877e6429962","head":{"label":"Fantomas-7:feature/unify-self-vs-static","ref":"feature/unify-self-vs-static","sha":"a3177c59225e8f1754ac30d657f1e877e6429962","user":{"login":"Fantomas-7","id":33895432,"avatar_url":"https://avatars3.githubusercontent.com/u/33895432?v=4","gravatar_id":"","url":"https://api.github.com/users/Fantomas-7","html_url":"https://github.com/Fantomas-7","followers_url":"https://api.github.com/users/Fantomas-7/followers","following_url":"https://api.github.com/users/Fantomas-7/following{/other_user}","gists_url":"https://api.github.com/users/Fantomas-7/gists{/gist_id}","starred_url":"https://api.github.com/users/Fantomas-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fantomas-7/subscriptions","organizations_url":"https://api.github.com/users/Fantomas-7/orgs","repos_url":"https://api.github.com/users/Fantomas-7/repos","events_url":"https://api.github.com/users/Fantomas-7/events{/privacy}","received_events_url":"https://api.github.com/users/Fantomas-7/received_events","type":"User","site_admin":false},"repo":{"id":113856518,"name":"matej-client-php","full_name":"Fantomas-7/matej-client-php","owner":{"login":"Fantomas-7","id":33895432,"avatar_url":"https://avatars3.githubusercontent.com/u/33895432?v=4","gravatar_id":"","url":"https://api.github.com/users/Fantomas-7","html_url":"https://github.com/Fantomas-7","followers_url":"https://api.github.com/users/Fantomas-7/followers","following_url":"https://api.github.com/users/Fantomas-7/following{/other_user}","gists_url":"https://api.github.com/users/Fantomas-7/gists{/gist_id}","starred_url":"https://api.github.com/users/Fantomas-7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fantomas-7/subscriptions","organizations_url":"https://api.github.com/users/Fantomas-7/orgs","repos_url":"https://api.github.com/users/Fantomas-7/repos","events_url":"https://api.github.com/users/Fantomas-7/events{/privacy}","received_events_url":"https://api.github.com/users/Fantomas-7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fantomas-7/matej-client-php","description":"PHP API Client for Matej recommendation engine","fork":true,"url":"https://api.github.com/repos/Fantomas-7/matej-client-php","forks_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/forks","keys_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/teams","hooks_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/hooks","issue_events_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/issues/events{/number}","events_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/events","assignees_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/assignees{/user}","branches_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/branches{/branch}","tags_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/tags","blobs_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/statuses/{sha}","languages_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/languages","stargazers_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/stargazers","contributors_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/contributors","subscribers_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/subscribers","subscription_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/subscription","commits_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/contents/{+path}","compare_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/merges","archive_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/downloads","issues_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/issues{/number}","pulls_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/pulls{/number}","milestones_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/milestones{/number}","notifications_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/labels{/name}","releases_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/releases{/id}","deployments_url":"https://api.github.com/repos/Fantomas-7/matej-client-php/deployments","created_at":"2017-12-11T12:30:38Z","updated_at":"2017-12-11T12:30:40Z","pushed_at":"2017-12-12T13:39:22Z","git_url":"git://github.com/Fantomas-7/matej-client-php.git","ssh_url":"git@github.com:Fantomas-7/matej-client-php.git","clone_url":"https://github.com/Fantomas-7/matej-client-php.git","svn_url":"https://github.com/Fantomas-7/matej-client-php","homepage":null,"size":196,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lmc-eu:master","ref":"master","sha":"86dcd482c9d8fe9706527f3c2b4fe121eb651370","user":{"login":"lmc-eu","id":429615,"avatar_url":"https://avatars3.githubusercontent.com/u/429615?v=4","gravatar_id":"","url":"https://api.github.com/users/lmc-eu","html_url":"https://github.com/lmc-eu","followers_url":"https://api.github.com/users/lmc-eu/followers","following_url":"https://api.github.com/users/lmc-eu/following{/other_user}","gists_url":"https://api.github.com/users/lmc-eu/gists{/gist_id}","starred_url":"https://api.github.com/users/lmc-eu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmc-eu/subscriptions","organizations_url":"https://api.github.com/users/lmc-eu/orgs","repos_url":"https://api.github.com/users/lmc-eu/repos","events_url":"https://api.github.com/users/lmc-eu/events{/privacy}","received_events_url":"https://api.github.com/users/lmc-eu/received_events","type":"Organization","site_admin":false},"repo":{"id":108859964,"name":"matej-client-php","full_name":"lmc-eu/matej-client-php","owner":{"login":"lmc-eu","id":429615,"avatar_url":"https://avatars3.githubusercontent.com/u/429615?v=4","gravatar_id":"","url":"https://api.github.com/users/lmc-eu","html_url":"https://github.com/lmc-eu","followers_url":"https://api.github.com/users/lmc-eu/followers","following_url":"https://api.github.com/users/lmc-eu/following{/other_user}","gists_url":"https://api.github.com/users/lmc-eu/gists{/gist_id}","starred_url":"https://api.github.com/users/lmc-eu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmc-eu/subscriptions","organizations_url":"https://api.github.com/users/lmc-eu/orgs","repos_url":"https://api.github.com/users/lmc-eu/repos","events_url":"https://api.github.com/users/lmc-eu/events{/privacy}","received_events_url":"https://api.github.com/users/lmc-eu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lmc-eu/matej-client-php","description":"PHP API Client for Matej recommendation engine","fork":false,"url":"https://api.github.com/repos/lmc-eu/matej-client-php","forks_url":"https://api.github.com/repos/lmc-eu/matej-client-php/forks","keys_url":"https://api.github.com/repos/lmc-eu/matej-client-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lmc-eu/matej-client-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lmc-eu/matej-client-php/teams","hooks_url":"https://api.github.com/repos/lmc-eu/matej-client-php/hooks","issue_events_url":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/events{/number}","events_url":"https://api.github.com/repos/lmc-eu/matej-client-php/events","assignees_url":"https://api.github.com/repos/lmc-eu/matej-client-php/assignees{/user}","branches_url":"https://api.github.com/repos/lmc-eu/matej-client-php/branches{/branch}","tags_url":"https://api.github.com/repos/lmc-eu/matej-client-php/tags","blobs_url":"https://api.github.com/repos/lmc-eu/matej-client-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lmc-eu/matej-client-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lmc-eu/matej-client-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/lmc-eu/matej-client-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lmc-eu/matej-client-php/statuses/{sha}","languages_url":"https://api.github.com/repos/lmc-eu/matej-client-php/languages","stargazers_url":"https://api.github.com/repos/lmc-eu/matej-client-php/stargazers","contributors_url":"https://api.github.com/repos/lmc-eu/matej-client-php/contributors","subscribers_url":"https://api.github.com/repos/lmc-eu/matej-client-php/subscribers","subscription_url":"https://api.github.com/repos/lmc-eu/matej-client-php/subscription","commits_url":"https://api.github.com/repos/lmc-eu/matej-client-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/lmc-eu/matej-client-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/lmc-eu/matej-client-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/lmc-eu/matej-client-php/contents/{+path}","compare_url":"https://api.github.com/repos/lmc-eu/matej-client-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lmc-eu/matej-client-php/merges","archive_url":"https://api.github.com/repos/lmc-eu/matej-client-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lmc-eu/matej-client-php/downloads","issues_url":"https://api.github.com/repos/lmc-eu/matej-client-php/issues{/number}","pulls_url":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls{/number}","milestones_url":"https://api.github.com/repos/lmc-eu/matej-client-php/milestones{/number}","notifications_url":"https://api.github.com/repos/lmc-eu/matej-client-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lmc-eu/matej-client-php/labels{/name}","releases_url":"https://api.github.com/repos/lmc-eu/matej-client-php/releases{/id}","deployments_url":"https://api.github.com/repos/lmc-eu/matej-client-php/deployments","created_at":"2017-10-30T14:11:02Z","updated_at":"2017-12-11T07:45:01Z","pushed_at":"2017-12-19T14:56:30Z","git_url":"git://github.com/lmc-eu/matej-client-php.git","ssh_url":"git@github.com:lmc-eu/matej-client-php.git","clone_url":"https://github.com/lmc-eu/matej-client-php.git","svn_url":"https://github.com/lmc-eu/matej-client-php","homepage":null,"size":191,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56"},"html":{"href":"https://github.com/lmc-eu/matej-client-php/pull/56"},"issue":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/56"},"comments":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/lmc-eu/matej-client-php/statuses/a3177c59225e8f1754ac30d657f1e877e6429962"}},"author_association":"NONE"}}
|
{
"id": 108859964,
"name": "lmc-eu/matej-client-php",
"url": "https://api.github.com/repos/lmc-eu/matej-client-php"
}
|
{
"id": 33895432,
"login": "Fantomas-7",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33895432?",
"url": "https://api.github.com/users/Fantomas-7"
}
|
{
"id": 429615,
"login": "lmc-eu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/429615?",
"url": "https://api.github.com/orgs/lmc-eu"
}
| 2017-12-20T08:49:32 |
7011957157
|
{"actor":{"display_login":"Fantomas-7"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/loomio/loomio/pulls/comments/108289479","pull_request_review_id":29310836,"id":108289479,"diff_hunk":"@@ -90,4 +90,13 @@ def percentage_for(poll, index)\n (100 * poll.stance_counts[index].to_f / poll.stance_counts.max).to_i\n end\n end\n+\n+ def stance_choice_percentage_for(stance, stance_choice)\n+ scores = stance.stance_choices.pluck(:score)","path":"app/helpers/email_helper.rb","position":6,"original_position":6,"commit_id":"c2217998a9661bd9a8001fe7db1fbe8559db1236","original_commit_id":"c2217998a9661bd9a8001fe7db1fbe8559db1236","user":{"login":"gdpelican","id":750477,"avatar_url":"https://avatars1.githubusercontent.com/u/750477?v=3","gravatar_id":"","url":"https://api.github.com/users/gdpelican","html_url":"https://github.com/gdpelican","followers_url":"https://api.github.com/users/gdpelican/followers","following_url":"https://api.github.com/users/gdpelican/following{/other_user}","gists_url":"https://api.github.com/users/gdpelican/gists{/gist_id}","starred_url":"https://api.github.com/users/gdpelican/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdpelican/subscriptions","organizations_url":"https://api.github.com/users/gdpelican/orgs","repos_url":"https://api.github.com/users/gdpelican/repos","events_url":"https://api.github.com/users/gdpelican/events{/privacy}","received_events_url":"https://api.github.com/users/gdpelican/received_events","type":"User","site_admin":false},"body":"I think `max` here might be slow. What about\r\n```\r\nmax_score = stance.stance_choices.maximum(:score).to_i\r\nif max_score.to_i <= 0\r\n 0\r\nelse\r\n (100 * stance_choice.score.to_f / max_score).to_i\r\nend\r\n```\r\n\r\n?","created_at":"2017-03-27T21:53:27Z","updated_at":"2017-03-27T21:56:47Z","html_url":"https://github.com/loomio/loomio/pull/3998#discussion_r108289479","pull_request_url":"https://api.github.com/repos/loomio/loomio/pulls/3998","_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments/108289479"},"html":{"href":"https://github.com/loomio/loomio/pull/3998#discussion_r108289479"},"pull_request":{"href":"https://api.github.com/repos/loomio/loomio/pulls/3998"}}},"pull_request":{"url":"https://api.github.com/repos/loomio/loomio/pulls/3998","id":112647009,"html_url":"https://github.com/loomio/loomio/pull/3998","diff_url":"https://github.com/loomio/loomio/pull/3998.diff","patch_url":"https://github.com/loomio/loomio/pull/3998.patch","issue_url":"https://api.github.com/repos/loomio/loomio/issues/3998","number":3998,"state":"open","locked":false,"title":"Dot vote stance chart","user":{"login":"robguthrie","id":486367,"avatar_url":"https://avatars1.githubusercontent.com/u/486367?v=3","gravatar_id":"","url":"https://api.github.com/users/robguthrie","html_url":"https://github.com/robguthrie","followers_url":"https://api.github.com/users/robguthrie/followers","following_url":"https://api.github.com/users/robguthrie/following{/other_user}","gists_url":"https://api.github.com/users/robguthrie/gists{/gist_id}","starred_url":"https://api.github.com/users/robguthrie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robguthrie/subscriptions","organizations_url":"https://api.github.com/users/robguthrie/orgs","repos_url":"https://api.github.com/users/robguthrie/repos","events_url":"https://api.github.com/users/robguthrie/events{/privacy}","received_events_url":"https://api.github.com/users/robguthrie/received_events","type":"User","site_admin":false},"body":"Displays each dot-vote-stance as its own little chart.","created_at":"2017-03-26T22:07:14Z","updated_at":"2017-03-27T21:56:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb1d1511819bf1d121e394f802d46fef09ee6a65","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/loomio/loomio/pulls/3998/commits","review_comments_url":"https://api.github.com/repos/loomio/loomio/pulls/3998/comments","review_comment_url":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loomio/loomio/issues/3998/comments","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/c2217998a9661bd9a8001fe7db1fbe8559db1236","head":{"label":"loomio:dot-vote-stance-chart","ref":"dot-vote-stance-chart","sha":"c2217998a9661bd9a8001fe7db1fbe8559db1236","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars1.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars1.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","deployments_url":"https://api.github.com/repos/loomio/loomio/deployments","created_at":"2011-11-08T03:27:12Z","updated_at":"2017-03-27T00:48:22Z","pushed_at":"2017-03-27T21:46:19Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":62018,"stargazers_count":1377,"watchers_count":1377,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":472,"mirror_url":null,"open_issues_count":53,"forks":472,"open_issues":53,"watchers":1377,"default_branch":"master"}},"base":{"label":"loomio:master","ref":"master","sha":"d89c5bc51b4b8c5816ab3646f36be602d1618e43","user":{"login":"loomio","id":1896739,"avatar_url":"https://avatars1.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"repo":{"id":2731301,"name":"loomio","full_name":"loomio/loomio","owner":{"login":"loomio","id":1896739,"avatar_url":"https://avatars1.githubusercontent.com/u/1896739?v=3","gravatar_id":"","url":"https://api.github.com/users/loomio","html_url":"https://github.com/loomio","followers_url":"https://api.github.com/users/loomio/followers","following_url":"https://api.github.com/users/loomio/following{/other_user}","gists_url":"https://api.github.com/users/loomio/gists{/gist_id}","starred_url":"https://api.github.com/users/loomio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loomio/subscriptions","organizations_url":"https://api.github.com/users/loomio/orgs","repos_url":"https://api.github.com/users/loomio/repos","events_url":"https://api.github.com/users/loomio/events{/privacy}","received_events_url":"https://api.github.com/users/loomio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/loomio/loomio","description":"Loomio is an open-source web application that helps groups make better decisions together.","fork":false,"url":"https://api.github.com/repos/loomio/loomio","forks_url":"https://api.github.com/repos/loomio/loomio/forks","keys_url":"https://api.github.com/repos/loomio/loomio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loomio/loomio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loomio/loomio/teams","hooks_url":"https://api.github.com/repos/loomio/loomio/hooks","issue_events_url":"https://api.github.com/repos/loomio/loomio/issues/events{/number}","events_url":"https://api.github.com/repos/loomio/loomio/events","assignees_url":"https://api.github.com/repos/loomio/loomio/assignees{/user}","branches_url":"https://api.github.com/repos/loomio/loomio/branches{/branch}","tags_url":"https://api.github.com/repos/loomio/loomio/tags","blobs_url":"https://api.github.com/repos/loomio/loomio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loomio/loomio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loomio/loomio/git/refs{/sha}","trees_url":"https://api.github.com/repos/loomio/loomio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loomio/loomio/statuses/{sha}","languages_url":"https://api.github.com/repos/loomio/loomio/languages","stargazers_url":"https://api.github.com/repos/loomio/loomio/stargazers","contributors_url":"https://api.github.com/repos/loomio/loomio/contributors","subscribers_url":"https://api.github.com/repos/loomio/loomio/subscribers","subscription_url":"https://api.github.com/repos/loomio/loomio/subscription","commits_url":"https://api.github.com/repos/loomio/loomio/commits{/sha}","git_commits_url":"https://api.github.com/repos/loomio/loomio/git/commits{/sha}","comments_url":"https://api.github.com/repos/loomio/loomio/comments{/number}","issue_comment_url":"https://api.github.com/repos/loomio/loomio/issues/comments{/number}","contents_url":"https://api.github.com/repos/loomio/loomio/contents/{+path}","compare_url":"https://api.github.com/repos/loomio/loomio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loomio/loomio/merges","archive_url":"https://api.github.com/repos/loomio/loomio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loomio/loomio/downloads","issues_url":"https://api.github.com/repos/loomio/loomio/issues{/number}","pulls_url":"https://api.github.com/repos/loomio/loomio/pulls{/number}","milestones_url":"https://api.github.com/repos/loomio/loomio/milestones{/number}","notifications_url":"https://api.github.com/repos/loomio/loomio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loomio/loomio/labels{/name}","releases_url":"https://api.github.com/repos/loomio/loomio/releases{/id}","deployments_url":"https://api.github.com/repos/loomio/loomio/deployments","created_at":"2011-11-08T03:27:12Z","updated_at":"2017-03-27T00:48:22Z","pushed_at":"2017-03-27T21:46:19Z","git_url":"git://github.com/loomio/loomio.git","ssh_url":"git@github.com:loomio/loomio.git","clone_url":"https://github.com/loomio/loomio.git","svn_url":"https://github.com/loomio/loomio","homepage":"www.loomio.org","size":62018,"stargazers_count":1377,"watchers_count":1377,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":472,"mirror_url":null,"open_issues_count":53,"forks":472,"open_issues":53,"watchers":1377,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loomio/loomio/pulls/3998"},"html":{"href":"https://github.com/loomio/loomio/pull/3998"},"issue":{"href":"https://api.github.com/repos/loomio/loomio/issues/3998"},"comments":{"href":"https://api.github.com/repos/loomio/loomio/issues/3998/comments"},"review_comments":{"href":"https://api.github.com/repos/loomio/loomio/pulls/3998/comments"},"review_comment":{"href":"https://api.github.com/repos/loomio/loomio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loomio/loomio/pulls/3998/commits"},"statuses":{"href":"https://api.github.com/repos/loomio/loomio/statuses/c2217998a9661bd9a8001fe7db1fbe8559db1236"}}}}
|
{
"id": 2731301,
"name": "loomio/loomio",
"url": "https://api.github.com/repos/loomio/loomio"
}
|
{
"id": 750477,
"login": "gdpelican",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/750477?",
"url": "https://api.github.com/users/gdpelican"
}
|
{
"id": 1896739,
"login": "loomio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1896739?",
"url": "https://api.github.com/orgs/loomio"
}
| 2017-03-27T21:53:27 |
5574329367
|
{"actor":{"display_login":"gdpelican"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments/137657656","pull_request_review_id":61354967,"id":137657656,"diff_hunk":"@@ -55,22 +54,24 @@ public void addTurnLanes(IntersectionLanes[] lanes, String maneuverModifier) {\n notifyDataSetChanged();\n }\n \n- private void setLaneImage(TurnLaneViewHolder holder, IntersectionLanes lane) {\n+ private void setLaneImage(TurnLaneViewHolder holder, IntersectionLanes lanes) {\n StringBuilder builder = new StringBuilder();\n \n // Indications\n- if (lane.getIndications() != null) {\n- for (String indication : lane.getIndications()) {\n+ if (lanes.getIndications() != null) {","path":"navigation/libandroid-navigation-ui/src/main/java/com/mapbox/services/android/navigation/ui/v5/instruction/turnlane/TurnLaneAdapter.java","position":19,"original_position":19,"commit_id":"5f56d1e634b9c226e5045510d24f827370c13055","original_commit_id":"5f56d1e634b9c226e5045510d24f827370c13055","user":{"login":"ericrwolfe","id":664805,"avatar_url":"https://avatars3.githubusercontent.com/u/664805?v=4","gravatar_id":"","url":"https://api.github.com/users/ericrwolfe","html_url":"https://github.com/ericrwolfe","followers_url":"https://api.github.com/users/ericrwolfe/followers","following_url":"https://api.github.com/users/ericrwolfe/following{/other_user}","gists_url":"https://api.github.com/users/ericrwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrwolfe/subscriptions","organizations_url":"https://api.github.com/users/ericrwolfe/orgs","repos_url":"https://api.github.com/users/ericrwolfe/repos","events_url":"https://api.github.com/users/ericrwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/ericrwolfe/received_events","type":"User","site_admin":false},"body":"(i.e. only a `straight` arrow or a `left` arrow)","created_at":"2017-09-07T21:15:06Z","updated_at":"2017-09-07T21:15:06Z","html_url":"https://github.com/mapbox/mapbox-navigation-android/pull/198#discussion_r137657656","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments/137657656"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-android/pull/198#discussion_r137657656"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198"}},"in_reply_to_id":137650566},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198","id":138975429,"html_url":"https://github.com/mapbox/mapbox-navigation-android/pull/198","diff_url":"https://github.com/mapbox/mapbox-navigation-android/pull/198.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-android/pull/198.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/198","number":198,"state":"open","locked":false,"title":"Camera Recenter, Turn Lane UI Update, Instruction Initialization ","user":{"login":"danesfeder","id":8434572,"avatar_url":"https://avatars0.githubusercontent.com/u/8434572?v=4","gravatar_id":"","url":"https://api.github.com/users/danesfeder","html_url":"https://github.com/danesfeder","followers_url":"https://api.github.com/users/danesfeder/followers","following_url":"https://api.github.com/users/danesfeder/following{/other_user}","gists_url":"https://api.github.com/users/danesfeder/gists{/gist_id}","starred_url":"https://api.github.com/users/danesfeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danesfeder/subscriptions","organizations_url":"https://api.github.com/users/danesfeder/orgs","repos_url":"https://api.github.com/users/danesfeder/repos","events_url":"https://api.github.com/users/danesfeder/events{/privacy}","received_events_url":"https://api.github.com/users/danesfeder/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-01T21:19:26Z","updated_at":"2017-09-07T21:16:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b70b9ce8a78436b404d733eaea3b8752f013c5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones/6","html_url":"https://github.com/mapbox/mapbox-navigation-android/milestone/6","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones/6/labels","id":2730744,"number":6,"title":"v0.6.0-2","description":"","creator":{"login":"ericrwolfe","id":664805,"avatar_url":"https://avatars3.githubusercontent.com/u/664805?v=4","gravatar_id":"","url":"https://api.github.com/users/ericrwolfe","html_url":"https://github.com/ericrwolfe","followers_url":"https://api.github.com/users/ericrwolfe/followers","following_url":"https://api.github.com/users/ericrwolfe/following{/other_user}","gists_url":"https://api.github.com/users/ericrwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/ericrwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericrwolfe/subscriptions","organizations_url":"https://api.github.com/users/ericrwolfe/orgs","repos_url":"https://api.github.com/users/ericrwolfe/repos","events_url":"https://api.github.com/users/ericrwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/ericrwolfe/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":10,"state":"open","created_at":"2017-08-29T18:10:29Z","updated_at":"2017-09-07T20:03:29Z","due_on":"2017-09-07T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/198/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/5f56d1e634b9c226e5045510d24f827370c13055","head":{"label":"mapbox:dan-camera-turnlane-recenter","ref":"dan-camera-turnlane-recenter","sha":"5f56d1e634b9c226e5045510d24f827370c13055","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":87455763,"name":"mapbox-navigation-android","full_name":"mapbox/mapbox-navigation-android","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-android","description":"Mapbox Navigation SDK for Android","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/deployments","created_at":"2017-04-06T17:18:23Z","updated_at":"2017-09-05T23:02:00Z","pushed_at":"2017-09-07T20:39:21Z","git_url":"git://github.com/mapbox/mapbox-navigation-android.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-android.git","clone_url":"https://github.com/mapbox/mapbox-navigation-android.git","svn_url":"https://github.com/mapbox/mapbox-navigation-android","homepage":"https://www.mapbox.com/android-docs/navigation/overview/","size":2798,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":34,"forks":20,"open_issues":34,"watchers":31,"default_branch":"master"}},"base":{"label":"mapbox:dan-navigation-ui","ref":"dan-navigation-ui","sha":"1a833c432dff63b96abcfe9a9e77fd3f4a66ee51","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":87455763,"name":"mapbox-navigation-android","full_name":"mapbox/mapbox-navigation-android","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-android","description":"Mapbox Navigation SDK for Android","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-android/deployments","created_at":"2017-04-06T17:18:23Z","updated_at":"2017-09-05T23:02:00Z","pushed_at":"2017-09-07T20:39:21Z","git_url":"git://github.com/mapbox/mapbox-navigation-android.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-android.git","clone_url":"https://github.com/mapbox/mapbox-navigation-android.git","svn_url":"https://github.com/mapbox/mapbox-navigation-android","homepage":"https://www.mapbox.com/android-docs/navigation/overview/","size":2798,"stargazers_count":31,"watchers_count":31,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":34,"forks":20,"open_issues":34,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-android/pull/198"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/198"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-android/statuses/5f56d1e634b9c226e5045510d24f827370c13055"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 87455763,
"name": "mapbox/mapbox-navigation-android",
"url": "https://api.github.com/repos/mapbox/mapbox-navigation-android"
}
|
{
"id": 664805,
"login": "ericrwolfe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/664805?",
"url": "https://api.github.com/users/ericrwolfe"
}
|
{
"id": 600935,
"login": "mapbox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/600935?",
"url": "https://api.github.com/orgs/mapbox"
}
| 2017-09-07T21:15:06 |
6563715839
|
{"actor":{"display_login":"ericrwolfe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/156629682","pull_request_review_id":83136125,"id":156629682,"diff_hunk":"@@ -107,6 +118,11 @@ public Builder x509TrustManager(X509TrustManager x509TrustManager) {\n return this;\n }\n \n+ public Builder debugLoggingEnabled(Boolean debugLoggingEnabled) {","path":"libtelemetry/src/main/java/com/mapbox/services/android/telemetry/TelemetryClientSettings.java","position":49,"original_position":49,"commit_id":"2d9ac6b517aab5db6205d27d8765fc0c0ca65004","original_commit_id":"2d9ac6b517aab5db6205d27d8765fc0c0ca65004","user":{"login":"Guardiola31337","id":1668582,"avatar_url":"https://avatars1.githubusercontent.com/u/1668582?v=4","gravatar_id":"","url":"https://api.github.com/users/Guardiola31337","html_url":"https://github.com/Guardiola31337","followers_url":"https://api.github.com/users/Guardiola31337/followers","following_url":"https://api.github.com/users/Guardiola31337/following{/other_user}","gists_url":"https://api.github.com/users/Guardiola31337/gists{/gist_id}","starred_url":"https://api.github.com/users/Guardiola31337/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guardiola31337/subscriptions","organizations_url":"https://api.github.com/users/Guardiola31337/orgs","repos_url":"https://api.github.com/users/Guardiola31337/repos","events_url":"https://api.github.com/users/Guardiola31337/events{/privacy}","received_events_url":"https://api.github.com/users/Guardiola31337/received_events","type":"User","site_admin":false},"body":"Why are we using the `Boolean` wrapped form here instead of `boolean`?","created_at":"2017-12-13T11:20:18Z","updated_at":"2017-12-13T11:33:20Z","html_url":"https://github.com/mapbox/mapbox-events-android/pull/22#discussion_r156629682","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments/156629682"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/22#discussion_r156629682"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22","id":157073631,"html_url":"https://github.com/mapbox/mapbox-events-android/pull/22","diff_url":"https://github.com/mapbox/mapbox-events-android/pull/22.diff","patch_url":"https://github.com/mapbox/mapbox-events-android/pull/22.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/22","number":22,"state":"open","locked":false,"title":"Debug Logging API","user":{"login":"electrostat","id":1819666,"avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false},"body":"Enables extra logging of telemetry request when activated. This is defaulted to off, but can be activated through a public api.","created_at":"2017-12-07T18:53:00Z","updated_at":"2017-12-13T11:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"electrostat","id":1819666,"avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false},"assignees":[{"login":"electrostat","id":1819666,"avatar_url":"https://avatars0.githubusercontent.com/u/1819666?v=4","gravatar_id":"","url":"https://api.github.com/users/electrostat","html_url":"https://github.com/electrostat","followers_url":"https://api.github.com/users/electrostat/followers","following_url":"https://api.github.com/users/electrostat/following{/other_user}","gists_url":"https://api.github.com/users/electrostat/gists{/gist_id}","starred_url":"https://api.github.com/users/electrostat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrostat/subscriptions","organizations_url":"https://api.github.com/users/electrostat/orgs","repos_url":"https://api.github.com/users/electrostat/repos","events_url":"https://api.github.com/users/electrostat/events{/privacy}","received_events_url":"https://api.github.com/users/electrostat/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/22/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/2d9ac6b517aab5db6205d27d8765fc0c0ca65004","head":{"label":"mapbox:aa-debug-logging-api","ref":"aa-debug-logging-api","sha":"2d9ac6b517aab5db6205d27d8765fc0c0ca65004","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2017-11-30T05:50:38Z","pushed_at":"2017-12-12T22:43:49Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":null,"size":291,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"aa4d7bd2836b4626d0469b1f5c23bcf9a49acaee","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":106559436,"name":"mapbox-events-android","full_name":"mapbox/mapbox-events-android","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-events-android","description":"Mapbox telemetry for Android.","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-events-android","forks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-events-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-events-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-events-android/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-events-android/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-events-android/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-events-android/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-events-android/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-events-android/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-events-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-events-android/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-events-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-events-android/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-events-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-events-android/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-events-android/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-events-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-events-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-events-android/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-events-android/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-events-android/deployments","created_at":"2017-10-11T13:41:33Z","updated_at":"2017-11-30T05:50:38Z","pushed_at":"2017-12-12T22:43:49Z","git_url":"git://github.com/mapbox/mapbox-events-android.git","ssh_url":"git@github.com:mapbox/mapbox-events-android.git","clone_url":"https://github.com/mapbox/mapbox-events-android.git","svn_url":"https://github.com/mapbox/mapbox-events-android","homepage":null,"size":291,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22"},"html":{"href":"https://github.com/mapbox/mapbox-events-android/pull/22"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/22"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-events-android/statuses/2d9ac6b517aab5db6205d27d8765fc0c0ca65004"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 106559436,
"name": "mapbox/mapbox-events-android",
"url": "https://api.github.com/repos/mapbox/mapbox-events-android"
}
|
{
"id": 1668582,
"login": "Guardiola31337",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1668582?",
"url": "https://api.github.com/users/Guardiola31337"
}
|
{
"id": 600935,
"login": "mapbox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/600935?",
"url": "https://api.github.com/orgs/mapbox"
}
| 2017-12-13T11:20:18 |
6982364950
|
{"actor":{"display_login":"Guardiola31337"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/114276758","pull_request_review_id":35727952,"id":114276758,"diff_hunk":"@@ -76,8 +76,13 @@ void ClipIDGenerator::update(Renderables& renderables) {\n bit_offset += bit_count;\n }\n \n- if (bit_offset > 8) {\n+ // Prevent this warning from firing on every frame,\n+ // which can be expensive in some platforms.\n+ static bool warned = false;","path":"src/mbgl/algorithm/generate_clip_ids_impl.hpp","position":7,"original_position":7,"commit_id":"c96d9469c02bf7222dc98ac1bae774e79aa7ba88","original_commit_id":"c96d9469c02bf7222dc98ac1bae774e79aa7ba88","user":{"login":"kkaefer","id":52399,"avatar_url":"https://avatars3.githubusercontent.com/u/52399?v=3","gravatar_id":"","url":"https://api.github.com/users/kkaefer","html_url":"https://github.com/kkaefer","followers_url":"https://api.github.com/users/kkaefer/followers","following_url":"https://api.github.com/users/kkaefer/following{/other_user}","gists_url":"https://api.github.com/users/kkaefer/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaefer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaefer/subscriptions","organizations_url":"https://api.github.com/users/kkaefer/orgs","repos_url":"https://api.github.com/users/kkaefer/repos","events_url":"https://api.github.com/users/kkaefer/events{/privacy}","received_events_url":"https://api.github.com/users/kkaefer/received_events","type":"User","site_admin":false},"body":"Yeah, a `static` is fine here.","created_at":"2017-05-02T09:09:54Z","updated_at":"2017-05-02T09:09:56Z","html_url":"https://github.com/mapbox/mapbox-gl-native/pull/8847#discussion_r114276758","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments/114276758"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/8847#discussion_r114276758"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847","id":118158329,"html_url":"https://github.com/mapbox/mapbox-gl-native/pull/8847","diff_url":"https://github.com/mapbox/mapbox-gl-native/pull/8847.diff","patch_url":"https://github.com/mapbox/mapbox-gl-native/pull/8847.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8847","number":8847,"state":"open","locked":false,"title":"[core] Suppress \"stencil mask overflow\" warning","user":{"login":"tmpsantos","id":996307,"avatar_url":"https://avatars3.githubusercontent.com/u/996307?v=3","gravatar_id":"","url":"https://api.github.com/users/tmpsantos","html_url":"https://github.com/tmpsantos","followers_url":"https://api.github.com/users/tmpsantos/followers","following_url":"https://api.github.com/users/tmpsantos/following{/other_user}","gists_url":"https://api.github.com/users/tmpsantos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmpsantos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmpsantos/subscriptions","organizations_url":"https://api.github.com/users/tmpsantos/orgs","repos_url":"https://api.github.com/users/tmpsantos/repos","events_url":"https://api.github.com/users/tmpsantos/events{/privacy}","received_events_url":"https://api.github.com/users/tmpsantos/received_events","type":"User","site_admin":false},"body":"When it starts, we get a log warning for every frame, which is\nexpensive. Now we get only one warning.","created_at":"2017-04-28T13:58:59Z","updated_at":"2017-05-02T09:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87f59ddc9bfcb595bfc73bc006800cadcea98500","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8847/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/c96d9469c02bf7222dc98ac1bae774e79aa7ba88","head":{"label":"mapbox:tmpsantos-suppress_warning","ref":"tmpsantos-suppress_warning","sha":"c96d9469c02bf7222dc98ac1bae774e79aa7ba88","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2017-05-01T19:59:02Z","pushed_at":"2017-05-02T09:05:19Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":163782,"stargazers_count":1843,"watchers_count":1843,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":583,"mirror_url":null,"open_issues_count":611,"forks":583,"open_issues":611,"watchers":1843,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"1d955d330bba5e6a0bb65e25c6a7c074b7ed439f","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":16286131,"name":"mapbox-gl-native","full_name":"mapbox/mapbox-gl-native","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-gl-native","description":"Interactive, thoroughly customizable maps in native Android, iOS, macOS, Node.js, and Qt applications, powered by vector tiles and OpenGL","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-gl-native","forks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-gl-native/deployments","created_at":"2014-01-27T17:14:48Z","updated_at":"2017-05-01T19:59:02Z","pushed_at":"2017-05-02T09:05:19Z","git_url":"git://github.com/mapbox/mapbox-gl-native.git","ssh_url":"git@github.com:mapbox/mapbox-gl-native.git","clone_url":"https://github.com/mapbox/mapbox-gl-native.git","svn_url":"https://github.com/mapbox/mapbox-gl-native","homepage":"https://mapbox.com/mobile","size":163782,"stargazers_count":1843,"watchers_count":1843,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":583,"mirror_url":null,"open_issues_count":611,"forks":583,"open_issues":611,"watchers":1843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847"},"html":{"href":"https://github.com/mapbox/mapbox-gl-native/pull/8847"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8847"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/issues/8847/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/pulls/8847/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-gl-native/statuses/c96d9469c02bf7222dc98ac1bae774e79aa7ba88"}}}}
|
{
"id": 16286131,
"name": "mapbox/mapbox-gl-native",
"url": "https://api.github.com/repos/mapbox/mapbox-gl-native"
}
|
{
"id": 52399,
"login": "kkaefer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/52399?",
"url": "https://api.github.com/users/kkaefer"
}
|
{
"id": 600935,
"login": "mapbox",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/600935?",
"url": "https://api.github.com/orgs/mapbox"
}
| 2017-05-02T09:09:54 |
5792321858
|
{"actor":{"display_login":"kkaefer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/95365569","pull_request_review_id":15917141,"id":95365569,"diff_hunk":"@@ -142,6 +170,7 @@ public void onScrollStateChanged(RecyclerView recyclerView, int newState)\n private final LastPosition mLastPosition = new LastPosition();\n private boolean mSearchRunning;\n private String mInitialQuery;\n+ private @Nullable HotelsFilter mInitialHotelsFilter;","path":"android/src/com/mapswithme/maps/search/SearchFragment.java","position":86,"original_position":86,"commit_id":"7ed9594f8a5d2ad3a3aeaa081ed5a6efab2ab776","original_commit_id":"7ed9594f8a5d2ad3a3aeaa081ed5a6efab2ab776","user":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars.githubusercontent.com/u/8442156?v=3","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"body":"@Nullable на новую строчку плиз","created_at":"2017-01-10T13:45:52Z","updated_at":"2017-01-10T13:45:52Z","html_url":"https://github.com/mapsme/omim/pull/5099#discussion_r95365569","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/5099","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/95365569"},"html":{"href":"https://github.com/mapsme/omim/pull/5099#discussion_r95365569"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5099"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/5099","id":99418717,"html_url":"https://github.com/mapsme/omim/pull/5099","diff_url":"https://github.com/mapsme/omim/pull/5099.diff","patch_url":"https://github.com/mapsme/omim/pull/5099.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/5099","number":5099,"state":"open","locked":false,"title":"[android] Hotel filters","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"Added hotels filter to the search fragment.\r\nAdded hotels filter to the map activity.\r\n(http://jira.65apps.com/browse/MAP-97)\r\n\r\n@alexzatsepin \r\n@mpimenov ","created_at":"2016-12-27T08:30:34Z","updated_at":"2017-01-10T13:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31f560b0f2e129b42c3b900c0bf0f40a5a307a00","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/5099/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/5099/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/5099/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/7ed9594f8a5d2ad3a3aeaa081ed5a6efab2ab776","head":{"label":"goblinr:MAPSME-97-ext-hotel-filters","ref":"MAPSME-97-ext-hotel-filters","sha":"7ed9594f8a5d2ad3a3aeaa081ed5a6efab2ab776","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"repo":{"id":68004519,"name":"omim","full_name":"goblinr/omim","owner":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goblinr/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/goblinr/omim","forks_url":"https://api.github.com/repos/goblinr/omim/forks","keys_url":"https://api.github.com/repos/goblinr/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goblinr/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goblinr/omim/teams","hooks_url":"https://api.github.com/repos/goblinr/omim/hooks","issue_events_url":"https://api.github.com/repos/goblinr/omim/issues/events{/number}","events_url":"https://api.github.com/repos/goblinr/omim/events","assignees_url":"https://api.github.com/repos/goblinr/omim/assignees{/user}","branches_url":"https://api.github.com/repos/goblinr/omim/branches{/branch}","tags_url":"https://api.github.com/repos/goblinr/omim/tags","blobs_url":"https://api.github.com/repos/goblinr/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goblinr/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goblinr/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/goblinr/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goblinr/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/goblinr/omim/languages","stargazers_url":"https://api.github.com/repos/goblinr/omim/stargazers","contributors_url":"https://api.github.com/repos/goblinr/omim/contributors","subscribers_url":"https://api.github.com/repos/goblinr/omim/subscribers","subscription_url":"https://api.github.com/repos/goblinr/omim/subscription","commits_url":"https://api.github.com/repos/goblinr/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/goblinr/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/goblinr/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/goblinr/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/goblinr/omim/contents/{+path}","compare_url":"https://api.github.com/repos/goblinr/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goblinr/omim/merges","archive_url":"https://api.github.com/repos/goblinr/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goblinr/omim/downloads","issues_url":"https://api.github.com/repos/goblinr/omim/issues{/number}","pulls_url":"https://api.github.com/repos/goblinr/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/goblinr/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/goblinr/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goblinr/omim/labels{/name}","releases_url":"https://api.github.com/repos/goblinr/omim/releases{/id}","deployments_url":"https://api.github.com/repos/goblinr/omim/deployments","created_at":"2016-09-12T11:50:39Z","updated_at":"2016-09-12T11:52:10Z","pushed_at":"2017-01-10T10:20:01Z","git_url":"git://github.com/goblinr/omim.git","ssh_url":"git@github.com:goblinr/omim.git","clone_url":"https://github.com/goblinr/omim.git","svn_url":"https://github.com/goblinr/omim","homepage":null,"size":2893392,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"e1dd06edd940c15a2b7f23f8a1ac1ca75e55e5e2","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-01-10T12:30:23Z","pushed_at":"2017-01-10T13:45:21Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":null,"size":2902143,"stargazers_count":2116,"watchers_count":2116,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"open_issues_count":390,"forks":419,"open_issues":390,"watchers":2116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5099"},"html":{"href":"https://github.com/mapsme/omim/pull/5099"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/5099"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/5099/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5099/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5099/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/7ed9594f8a5d2ad3a3aeaa081ed5a6efab2ab776"}}}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 8442156,
"login": "alexzatsepin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8442156?",
"url": "https://api.github.com/users/alexzatsepin"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-01-10T13:45:52 |
5129104704
|
{"actor":{"display_login":"alexzatsepin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/98912759","pull_request_review_id":19546506,"id":98912759,"diff_hunk":"@@ -265,17 +267,26 @@ static void setInfoListener(@NonNull OnHotelInfoReceivedListener listener)\n * @param id A Hotel id\n * @param currencyCode A user currency\n */\n- static void requestPrice(String id, String currencyCode)\n+ static void requestPrice(@NonNull Context context, @NonNull final String id,\n+ @NonNull final String currencyCode)\n {\n Price p = sPriceCache.get(id);\n if (p != null)\n onPriceReceived(id, p.mPrice, p.mCurrency);\n \n- nativeRequestPrice(id, currencyCode);\n+ NetworkPolicy.checkNetworkPolicy(context, new NetworkPolicy.NetworkPolicyListener()","path":"android/src/com/mapswithme/maps/widget/placepage/Sponsored.java","position":28,"original_position":28,"commit_id":"07a44a8dc6bf06b427c50daa327696f255c8faeb","original_commit_id":"07a44a8dc6bf06b427c50daa327696f255c8faeb","user":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars.githubusercontent.com/u/8442156?v=3","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"body":"Вот это место приводит к наложению двух диалогов друг на друга:\r\n1. Тапаем на отель\r\n2. Появляется диалог\r\n3. Тапаем HOME или Recent Apps\r\n4. Возвращаемся в приложение - показывается еще один диалог. \r\n\r\nНадо подумать как это аккуратнее поправить, желательно без статических полей флажков","created_at":"2017-02-01T15:07:44Z","updated_at":"2017-02-01T15:53:27Z","html_url":"https://github.com/mapsme/omim/pull/5318#discussion_r98912759","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/5318","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/98912759"},"html":{"href":"https://github.com/mapsme/omim/pull/5318#discussion_r98912759"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5318"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/5318","id":103926360,"html_url":"https://github.com/mapsme/omim/pull/5318","diff_url":"https://github.com/mapsme/omim/pull/5318.diff","patch_url":"https://github.com/mapsme/omim/pull/5318.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/5318","number":5318,"state":"open","locked":false,"title":"[android]Network policy android implementation","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"Added network policy android implementation(https://jira.mail.ru/browse/MAPSME-2990).\r\n\r\n@alexzatsepin \r\n@mpimenov \r\n@milchakov \r\nPTAL","created_at":"2017-01-31T12:30:29Z","updated_at":"2017-02-01T15:53:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76ad97a2ec803b5f84d97f8435ce67de0e012102","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/5318/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/5318/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/5318/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/07a44a8dc6bf06b427c50daa327696f255c8faeb","head":{"label":"goblinr:MAPSME-134-ext-network-policy","ref":"MAPSME-134-ext-network-policy","sha":"07a44a8dc6bf06b427c50daa327696f255c8faeb","user":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"repo":{"id":68004519,"name":"omim","full_name":"goblinr/omim","owner":{"login":"goblinr","id":2997073,"avatar_url":"https://avatars.githubusercontent.com/u/2997073?v=3","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goblinr/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/goblinr/omim","forks_url":"https://api.github.com/repos/goblinr/omim/forks","keys_url":"https://api.github.com/repos/goblinr/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goblinr/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goblinr/omim/teams","hooks_url":"https://api.github.com/repos/goblinr/omim/hooks","issue_events_url":"https://api.github.com/repos/goblinr/omim/issues/events{/number}","events_url":"https://api.github.com/repos/goblinr/omim/events","assignees_url":"https://api.github.com/repos/goblinr/omim/assignees{/user}","branches_url":"https://api.github.com/repos/goblinr/omim/branches{/branch}","tags_url":"https://api.github.com/repos/goblinr/omim/tags","blobs_url":"https://api.github.com/repos/goblinr/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goblinr/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goblinr/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/goblinr/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goblinr/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/goblinr/omim/languages","stargazers_url":"https://api.github.com/repos/goblinr/omim/stargazers","contributors_url":"https://api.github.com/repos/goblinr/omim/contributors","subscribers_url":"https://api.github.com/repos/goblinr/omim/subscribers","subscription_url":"https://api.github.com/repos/goblinr/omim/subscription","commits_url":"https://api.github.com/repos/goblinr/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/goblinr/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/goblinr/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/goblinr/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/goblinr/omim/contents/{+path}","compare_url":"https://api.github.com/repos/goblinr/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goblinr/omim/merges","archive_url":"https://api.github.com/repos/goblinr/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goblinr/omim/downloads","issues_url":"https://api.github.com/repos/goblinr/omim/issues{/number}","pulls_url":"https://api.github.com/repos/goblinr/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/goblinr/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/goblinr/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goblinr/omim/labels{/name}","releases_url":"https://api.github.com/repos/goblinr/omim/releases{/id}","deployments_url":"https://api.github.com/repos/goblinr/omim/deployments","created_at":"2016-09-12T11:50:39Z","updated_at":"2016-09-12T11:52:10Z","pushed_at":"2017-02-01T12:53:25Z","git_url":"git://github.com/goblinr/omim.git","ssh_url":"git@github.com:goblinr/omim.git","clone_url":"https://github.com/goblinr/omim.git","svn_url":"https://github.com/goblinr/omim","homepage":null,"size":2904332,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"5017b013e9ec91a8e55d3dd862f5f5870d3e7f0e","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-01-31T06:18:32Z","pushed_at":"2017-02-01T15:53:05Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":2920749,"stargazers_count":2135,"watchers_count":2135,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"open_issues_count":407,"forks":425,"open_issues":407,"watchers":2135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5318"},"html":{"href":"https://github.com/mapsme/omim/pull/5318"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/5318"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/5318/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5318/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5318/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/07a44a8dc6bf06b427c50daa327696f255c8faeb"}}}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 8442156,
"login": "alexzatsepin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8442156?",
"url": "https://api.github.com/users/alexzatsepin"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-02-01T15:07:44 |
5248506287
|
{"actor":{"display_login":"alexzatsepin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/106699630","pull_request_review_id":27638687,"id":106699630,"diff_hunk":"@@ -174,4 +293,84 @@ void CrossMwmIndexGraph::InsertWholeMwmTransitionSegments(NumMwmId numMwmId)\n if (!LoadWith(numMwmId, fillAllTransitionSegments))\n m_transitionCache.emplace(numMwmId, TransitionSegments());\n }\n+\n+void CrossMwmIndexGraph::GetBorderCross(TRoutingMappingPtr const & mapping, Segment const & s,\n+ bool isOutgoing, vector<BorderCross> & borderCrosses)\n+{\n+ // ingoing edge\n+ NodeIds const nodeIdsTo = GetDirectAndReverseNodeId(mapping->m_segMapping, s);\n+\n+ vector<ms::LatLon> const & transitionPnt =\n+ isOutgoing ? GetIngoingTransitionPnt(s) : GetOutgoingTransitionPnt(s);\n+ CHECK(!transitionPnt.empty(), ());\n+\n+ // If |isOutgoing| == true |nodes| is \"to\" cross nodes, otherwise |nodes| is \"from\" cross nodes.\n+ vector<CrossNode> nodes;\n+ for (ms::LatLon const & p : transitionPnt)\n+ nodes.emplace_back(nodeIdsTo.m_directNodeId, nodeIdsTo.m_reverseNodeId, mapping->GetMwmId(), p);\n+\n+ // outgoing edge\n+ vector<Segment> twins;\n+ GetTwins(s, !isOutgoing, twins);\n+ CHECK(!twins.empty(), ());\n+ for (Segment const & twin : twins)\n+ {\n+ // If |isOutgoing| == true |otherSideMapping| is mapping outgoing (to) border cross.\n+ // If |isOutgoing| == false |mapping| is mapping ingoing (from) border cross.\n+ auto const fillBorderCrossOut = [&](TRoutingMappingPtr const & otherSideMapping) {\n+ NodeIds const nodeIdsFrom = GetDirectAndReverseNodeId(otherSideMapping->m_segMapping, twin);\n+ vector<ms::LatLon> const & otherSideTransitionPnt =\n+ isOutgoing ? GetOutgoingTransitionPnt(twin) : GetIngoingTransitionPnt(twin);\n+\n+ CHECK(!otherSideTransitionPnt.empty(), ());\n+ for (CrossNode const & node : nodes)\n+ {\n+ // If |isOutgoing| == true |otherSideNodes| is \"from\" cross nodes, otherwise\n+ // |otherSideNodes| is \"to\" cross nodes.\n+ BorderCross bc;\n+ if (isOutgoing)\n+ bc.toNode = node;\n+ else\n+ bc.fromNode = node;\n+\n+ for (ms::LatLon const & ll : otherSideTransitionPnt)\n+ {\n+ CrossNode & resultNode = isOutgoing ? bc.fromNode : bc.toNode;\n+ resultNode = CrossNode(nodeIdsFrom.m_directNodeId, nodeIdsFrom.m_reverseNodeId,\n+ otherSideMapping->GetMwmId(), ll);\n+ borderCrosses.push_back(bc);\n+ }\n+ }\n+ };\n+ LoadWith(twin.GetMwmId(), fillBorderCrossOut);\n+ }\n+}\n+\n+CrossMwmIndexGraph::TransitionSegments const & CrossMwmIndexGraph::GetSegmentMaps(NumMwmId numMwmId)\n+{\n+ auto it = m_transitionCache.find(numMwmId);\n+ if (it == m_transitionCache.cend())\n+ {\n+ InsertWholeMwmTransitionSegments(numMwmId);\n+ it = m_transitionCache.find(numMwmId);\n+ }\n+ CHECK(it != m_transitionCache.cend(), (\"Mwm \", numMwmId, \"has not been downloaded.\"));\n+ return it->second;\n+}\n+\n+vector<ms::LatLon> const & CrossMwmIndexGraph::GetIngoingTransitionPnt(Segment const & s)\n+{\n+ auto const & ingoingSeg = GetSegmentMaps(s.GetMwmId()).m_ingoing;\n+ auto const it = ingoingSeg.find(s);\n+ CHECK(it != ingoingSeg.cend(), ());","path":"routing/cross_mwm_index_graph.cpp","position":393,"original_position":393,"commit_id":"4cb915e258163789c0bac92a927134a4c4b878f5","original_commit_id":"4cb915e258163789c0bac92a927134a4c4b878f5","user":{"login":"dobriy-eeh","id":19839790,"avatar_url":"https://avatars1.githubusercontent.com/u/19839790?v=3","gravatar_id":"","url":"https://api.github.com/users/dobriy-eeh","html_url":"https://github.com/dobriy-eeh","followers_url":"https://api.github.com/users/dobriy-eeh/followers","following_url":"https://api.github.com/users/dobriy-eeh/following{/other_user}","gists_url":"https://api.github.com/users/dobriy-eeh/gists{/gist_id}","starred_url":"https://api.github.com/users/dobriy-eeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dobriy-eeh/subscriptions","organizations_url":"https://api.github.com/users/dobriy-eeh/orgs","repos_url":"https://api.github.com/users/dobriy-eeh/repos","events_url":"https://api.github.com/users/dobriy-eeh/events{/privacy}","received_events_url":"https://api.github.com/users/dobriy-eeh/received_events","type":"User","site_admin":false},"body":"Давай добавим печать s","created_at":"2017-03-17T17:09:32Z","updated_at":"2017-03-17T17:09:32Z","html_url":"https://github.com/mapsme/omim/pull/5618#discussion_r106699630","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/5618","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/106699630"},"html":{"href":"https://github.com/mapsme/omim/pull/5618#discussion_r106699630"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5618"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/5618","id":111237707,"html_url":"https://github.com/mapsme/omim/pull/5618","diff_url":"https://github.com/mapsme/omim/pull/5618.diff","patch_url":"https://github.com/mapsme/omim/pull/5618.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/5618","number":5618,"state":"open","locked":false,"title":"CrossMwmIndexGraph::GetEdgeList(...) implementation.","user":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars3.githubusercontent.com/u/1768114?v=3","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"* реализация метода для получения списка прескоков в cross mwm-ом роутинге на базе OSRM;\r\n* реализовано кеширование MappingGuard при кросс mwm-ом роутинге;\r\n* включен WorldGraph;\r\n\r\nДанный PR тестировался на маршрутах:\r\nМосква - Лиссабон, Москва - Париж, Москва - Берлин, Москва - Минск\r\n\r\n@dobriy-eeh @ygorshenin @mpimenov PTAL","created_at":"2017-03-17T08:57:08Z","updated_at":"2017-03-17T17:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03cc5ea12b5f688808574d7656a553acafe05bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/5618/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/5618/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/5618/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/4cb915e258163789c0bac92a927134a4c4b878f5","head":{"label":"bykoianko:master-cross-mwm-GetEdgeList","ref":"master-cross-mwm-GetEdgeList","sha":"4cb915e258163789c0bac92a927134a4c4b878f5","user":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars3.githubusercontent.com/u/1768114?v=3","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"repo":{"id":43428862,"name":"omim","full_name":"bykoianko/omim","owner":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars3.githubusercontent.com/u/1768114?v=3","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bykoianko/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/bykoianko/omim","forks_url":"https://api.github.com/repos/bykoianko/omim/forks","keys_url":"https://api.github.com/repos/bykoianko/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bykoianko/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bykoianko/omim/teams","hooks_url":"https://api.github.com/repos/bykoianko/omim/hooks","issue_events_url":"https://api.github.com/repos/bykoianko/omim/issues/events{/number}","events_url":"https://api.github.com/repos/bykoianko/omim/events","assignees_url":"https://api.github.com/repos/bykoianko/omim/assignees{/user}","branches_url":"https://api.github.com/repos/bykoianko/omim/branches{/branch}","tags_url":"https://api.github.com/repos/bykoianko/omim/tags","blobs_url":"https://api.github.com/repos/bykoianko/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bykoianko/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bykoianko/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bykoianko/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bykoianko/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/bykoianko/omim/languages","stargazers_url":"https://api.github.com/repos/bykoianko/omim/stargazers","contributors_url":"https://api.github.com/repos/bykoianko/omim/contributors","subscribers_url":"https://api.github.com/repos/bykoianko/omim/subscribers","subscription_url":"https://api.github.com/repos/bykoianko/omim/subscription","commits_url":"https://api.github.com/repos/bykoianko/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bykoianko/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bykoianko/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bykoianko/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bykoianko/omim/contents/{+path}","compare_url":"https://api.github.com/repos/bykoianko/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bykoianko/omim/merges","archive_url":"https://api.github.com/repos/bykoianko/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bykoianko/omim/downloads","issues_url":"https://api.github.com/repos/bykoianko/omim/issues{/number}","pulls_url":"https://api.github.com/repos/bykoianko/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/bykoianko/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/bykoianko/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bykoianko/omim/labels{/name}","releases_url":"https://api.github.com/repos/bykoianko/omim/releases{/id}","deployments_url":"https://api.github.com/repos/bykoianko/omim/deployments","created_at":"2015-09-30T11:21:20Z","updated_at":"2016-03-24T12:55:17Z","pushed_at":"2017-03-17T14:43:45Z","git_url":"git://github.com/bykoianko/omim.git","ssh_url":"git@github.com:bykoianko/omim.git","clone_url":"https://github.com/bykoianko/omim.git","svn_url":"https://github.com/bykoianko/omim","homepage":null,"size":2891848,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"c0dfe1b872e79b804c85d13d9dcf6b0e802e53ea","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-03-17T10:25:52Z","pushed_at":"2017-03-17T16:33:45Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":2980617,"stargazers_count":2186,"watchers_count":2186,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"open_issues_count":439,"forks":440,"open_issues":439,"watchers":2186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5618"},"html":{"href":"https://github.com/mapsme/omim/pull/5618"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/5618"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/5618/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5618/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5618/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/4cb915e258163789c0bac92a927134a4c4b878f5"}}}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 19839790,
"login": "dobriy-eeh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19839790?",
"url": "https://api.github.com/users/dobriy-eeh"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-03-17T17:09:32 |
5515324720
|
{"actor":{"display_login":"dobriy-eeh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/144208721","pull_request_review_id":68832322,"id":144208721,"diff_hunk":"@@ -80,11 +80,13 @@ protected void onSubmitButtonClick()\n List<UGC.Rating> modifiedRatings = mUGCRatingAdapter.getItems();\n UGC.Rating[] ratings = new UGC.Rating[modifiedRatings.size()];\n modifiedRatings.toArray(ratings);\n- UGCUpdate update = new UGCUpdate(ratings, mReviewEditText.getText().toString());\n+ UGCUpdate update = new UGCUpdate(ratings, mReviewEditText.getText().toString(),\n+ 0 /* mTimeMillis. It's set in JNI, UGC.cpp */);","path":"android/src/com/mapswithme/maps/ugc/UGCEditorFragment.java","position":6,"original_position":6,"commit_id":"a733ab1fb4302aa6da3f93b9a81853b78abe5075","original_commit_id":"a733ab1fb4302aa6da3f93b9a81853b78abe5075","user":{"login":"milchakov","id":2606569,"avatar_url":"https://avatars1.githubusercontent.com/u/2606569?v=4","gravatar_id":"","url":"https://api.github.com/users/milchakov","html_url":"https://github.com/milchakov","followers_url":"https://api.github.com/users/milchakov/followers","following_url":"https://api.github.com/users/milchakov/following{/other_user}","gists_url":"https://api.github.com/users/milchakov/gists{/gist_id}","starred_url":"https://api.github.com/users/milchakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milchakov/subscriptions","organizations_url":"https://api.github.com/users/milchakov/orgs","repos_url":"https://api.github.com/users/milchakov/repos","events_url":"https://api.github.com/users/milchakov/events{/privacy}","received_events_url":"https://api.github.com/users/milchakov/received_events","type":"User","site_admin":false},"body":"надо бы конструктор из двух параметров сделать, чтоб ноль не проставлять. Пометил себе.","created_at":"2017-10-12T07:06:20Z","updated_at":"2017-10-12T07:06:20Z","html_url":"https://github.com/mapsme/omim/pull/7245#discussion_r144208721","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/7245","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/144208721"},"html":{"href":"https://github.com/mapsme/omim/pull/7245#discussion_r144208721"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7245"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/7245","id":146005223,"html_url":"https://github.com/mapsme/omim/pull/7245","diff_url":"https://github.com/mapsme/omim/pull/7245.diff","patch_url":"https://github.com/mapsme/omim/pull/7245.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/7245","number":7245,"state":"open","locked":false,"title":"Mapsme 5520 ugc reviews fixes","user":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars2.githubusercontent.com/u/8442156?v=4","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"body":"https://jira.mail.ru/browse/MAPSME-5520","created_at":"2017-10-11T16:52:34Z","updated_at":"2017-10-12T07:06:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482d443699de1538611844251f14bd55ebe79fa9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rokuz","id":5437220,"avatar_url":"https://avatars1.githubusercontent.com/u/5437220?v=4","gravatar_id":"","url":"https://api.github.com/users/rokuz","html_url":"https://github.com/rokuz","followers_url":"https://api.github.com/users/rokuz/followers","following_url":"https://api.github.com/users/rokuz/following{/other_user}","gists_url":"https://api.github.com/users/rokuz/gists{/gist_id}","starred_url":"https://api.github.com/users/rokuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rokuz/subscriptions","organizations_url":"https://api.github.com/users/rokuz/orgs","repos_url":"https://api.github.com/users/rokuz/repos","events_url":"https://api.github.com/users/rokuz/events{/privacy}","received_events_url":"https://api.github.com/users/rokuz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/7245/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/7245/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/7245/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/a733ab1fb4302aa6da3f93b9a81853b78abe5075","head":{"label":"alexzatsepin:MAPSME-5520-ugc-reviews-fixes","ref":"MAPSME-5520-ugc-reviews-fixes","sha":"a733ab1fb4302aa6da3f93b9a81853b78abe5075","user":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars2.githubusercontent.com/u/8442156?v=4","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"repo":{"id":67988467,"name":"omim","full_name":"alexzatsepin/omim","owner":{"login":"alexzatsepin","id":8442156,"avatar_url":"https://avatars2.githubusercontent.com/u/8442156?v=4","gravatar_id":"","url":"https://api.github.com/users/alexzatsepin","html_url":"https://github.com/alexzatsepin","followers_url":"https://api.github.com/users/alexzatsepin/followers","following_url":"https://api.github.com/users/alexzatsepin/following{/other_user}","gists_url":"https://api.github.com/users/alexzatsepin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexzatsepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexzatsepin/subscriptions","organizations_url":"https://api.github.com/users/alexzatsepin/orgs","repos_url":"https://api.github.com/users/alexzatsepin/repos","events_url":"https://api.github.com/users/alexzatsepin/events{/privacy}","received_events_url":"https://api.github.com/users/alexzatsepin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexzatsepin/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/alexzatsepin/omim","forks_url":"https://api.github.com/repos/alexzatsepin/omim/forks","keys_url":"https://api.github.com/repos/alexzatsepin/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexzatsepin/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexzatsepin/omim/teams","hooks_url":"https://api.github.com/repos/alexzatsepin/omim/hooks","issue_events_url":"https://api.github.com/repos/alexzatsepin/omim/issues/events{/number}","events_url":"https://api.github.com/repos/alexzatsepin/omim/events","assignees_url":"https://api.github.com/repos/alexzatsepin/omim/assignees{/user}","branches_url":"https://api.github.com/repos/alexzatsepin/omim/branches{/branch}","tags_url":"https://api.github.com/repos/alexzatsepin/omim/tags","blobs_url":"https://api.github.com/repos/alexzatsepin/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexzatsepin/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexzatsepin/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexzatsepin/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexzatsepin/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/alexzatsepin/omim/languages","stargazers_url":"https://api.github.com/repos/alexzatsepin/omim/stargazers","contributors_url":"https://api.github.com/repos/alexzatsepin/omim/contributors","subscribers_url":"https://api.github.com/repos/alexzatsepin/omim/subscribers","subscription_url":"https://api.github.com/repos/alexzatsepin/omim/subscription","commits_url":"https://api.github.com/repos/alexzatsepin/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexzatsepin/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexzatsepin/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexzatsepin/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexzatsepin/omim/contents/{+path}","compare_url":"https://api.github.com/repos/alexzatsepin/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexzatsepin/omim/merges","archive_url":"https://api.github.com/repos/alexzatsepin/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexzatsepin/omim/downloads","issues_url":"https://api.github.com/repos/alexzatsepin/omim/issues{/number}","pulls_url":"https://api.github.com/repos/alexzatsepin/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/alexzatsepin/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/alexzatsepin/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexzatsepin/omim/labels{/name}","releases_url":"https://api.github.com/repos/alexzatsepin/omim/releases{/id}","deployments_url":"https://api.github.com/repos/alexzatsepin/omim/deployments","created_at":"2016-09-12T07:57:50Z","updated_at":"2016-09-12T07:59:26Z","pushed_at":"2017-10-11T16:51:39Z","git_url":"git://github.com/alexzatsepin/omim.git","ssh_url":"git@github.com:alexzatsepin/omim.git","clone_url":"https://github.com/alexzatsepin/omim.git","svn_url":"https://github.com/alexzatsepin/omim","homepage":null,"size":3381235,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"24c4cd1e8940d670b553fc08cb637bb660a024e4","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-10-11T21:59:42Z","pushed_at":"2017-10-11T22:06:32Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3428113,"stargazers_count":2440,"watchers_count":2440,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":525,"mirror_url":null,"open_issues_count":587,"forks":525,"open_issues":587,"watchers":2440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7245"},"html":{"href":"https://github.com/mapsme/omim/pull/7245"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/7245"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/7245/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7245/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7245/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/a733ab1fb4302aa6da3f93b9a81853b78abe5075"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 2606569,
"login": "milchakov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2606569?",
"url": "https://api.github.com/users/milchakov"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-10-12T07:06:20 |
6706449978
|
{"actor":{"display_login":"milchakov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/106644301","pull_request_review_id":27577727,"id":106644301,"diff_hunk":"@@ -0,0 +1,54 @@\n+#pragma once\n+\n+#include \"routing/road_access.hpp\"\n+\n+#include \"generator/intermediate_elements.hpp\"\n+\n+#include <cstdint>\n+#include <fstream>\n+#include <string>\n+\n+struct OsmElement;\n+class FeatureParams;\n+\n+// The road accessibility information is collected in the same manner\n+// as the restrictions are.\n+// See generator/restriction_generator.hpp for details.\n+namespace routing\n+{\n+class RoadAccessWriter\n+{\n+public:\n+ void Open(std::string const & filePath);\n+\n+ void Process(OsmElement * p, FeatureParams & params);\n+\n+private:\n+ bool IsOpened();\n+\n+ std::ofstream m_stream;\n+};\n+\n+class RoadAccessCollector\n+{\n+public:\n+ RoadAccessCollector(std::string const & roadAccessPath, std::string const & osmIdsToFeatureIdsPath);\n+\n+ RoadAccess & GetRoadAccess() { return m_roadAccess; }\n+ RoadAccess const & GetRoadAccess() const { return m_roadAccess; }\n+\n+ bool IsValid() const { return m_valid; }\n+\n+private:\n+ bool ParseRoadAccess(std::string const & roadAccessPath);\n+\n+ map<uint64_t, uint32_t> m_osmIdToFeatureId;","path":"generator/road_access_generator.hpp","position":45,"original_position":45,"commit_id":"e84da04815477129f9c2d88279ae121e66ef831d","original_commit_id":"e84da04815477129f9c2d88279ae121e66ef831d","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars3.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-03-17T13:01:35Z","updated_at":"2017-03-17T13:01:35Z","html_url":"https://github.com/mapsme/omim/pull/5609#discussion_r106644301","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/5609","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/106644301"},"html":{"href":"https://github.com/mapsme/omim/pull/5609#discussion_r106644301"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5609"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/5609","id":110907116,"html_url":"https://github.com/mapsme/omim/pull/5609","diff_url":"https://github.com/mapsme/omim/pull/5609.diff","patch_url":"https://github.com/mapsme/omim/pull/5609.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/5609","number":5609,"state":"open","locked":false,"title":"[routing] [generator] A component to store road accessibility info.","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars3.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"body":"Дальнейший план такой:\r\n1. Запретить дороги с access=private в роутинге.\r\n2. Обработать остальные тэги (включая точечные типа barrier=gate).\r\n3. После того, как добавлены все тэги, очень может быть, что получится\r\nполностью избавиться от промежуточного слоя в виде OSM id. В случае\r\nс restrictions он необходим, т.к. там отношения, а здесь, возможно, всю информацию\r\nудастся сохранить в типах фичи.\r\nЭто не отменит необходимости в промежуточной структуре типа RoadAccess, \r\nзаполняемой на этапе генерации.\r\n4. Более аккуратно обращаться с access=private в роутинге.","created_at":"2017-03-15T18:03:09Z","updated_at":"2017-03-17T13:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d8c43b7c875b0548942ae1f8592d0d72f26aeb5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/5609/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/5609/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/5609/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/e84da04815477129f9c2d88279ae121e66ef831d","head":{"label":"mpimenov:barriers","ref":"barriers","sha":"e84da04815477129f9c2d88279ae121e66ef831d","user":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars3.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"repo":{"id":43427925,"name":"omim","full_name":"mpimenov/omim","owner":{"login":"mpimenov","id":10366009,"avatar_url":"https://avatars3.githubusercontent.com/u/10366009?v=3","gravatar_id":"","url":"https://api.github.com/users/mpimenov","html_url":"https://github.com/mpimenov","followers_url":"https://api.github.com/users/mpimenov/followers","following_url":"https://api.github.com/users/mpimenov/following{/other_user}","gists_url":"https://api.github.com/users/mpimenov/gists{/gist_id}","starred_url":"https://api.github.com/users/mpimenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpimenov/subscriptions","organizations_url":"https://api.github.com/users/mpimenov/orgs","repos_url":"https://api.github.com/users/mpimenov/repos","events_url":"https://api.github.com/users/mpimenov/events{/privacy}","received_events_url":"https://api.github.com/users/mpimenov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpimenov/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/mpimenov/omim","forks_url":"https://api.github.com/repos/mpimenov/omim/forks","keys_url":"https://api.github.com/repos/mpimenov/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpimenov/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpimenov/omim/teams","hooks_url":"https://api.github.com/repos/mpimenov/omim/hooks","issue_events_url":"https://api.github.com/repos/mpimenov/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mpimenov/omim/events","assignees_url":"https://api.github.com/repos/mpimenov/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mpimenov/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mpimenov/omim/tags","blobs_url":"https://api.github.com/repos/mpimenov/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpimenov/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpimenov/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpimenov/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpimenov/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mpimenov/omim/languages","stargazers_url":"https://api.github.com/repos/mpimenov/omim/stargazers","contributors_url":"https://api.github.com/repos/mpimenov/omim/contributors","subscribers_url":"https://api.github.com/repos/mpimenov/omim/subscribers","subscription_url":"https://api.github.com/repos/mpimenov/omim/subscription","commits_url":"https://api.github.com/repos/mpimenov/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpimenov/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpimenov/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpimenov/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpimenov/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mpimenov/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpimenov/omim/merges","archive_url":"https://api.github.com/repos/mpimenov/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpimenov/omim/downloads","issues_url":"https://api.github.com/repos/mpimenov/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mpimenov/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mpimenov/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mpimenov/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpimenov/omim/labels{/name}","releases_url":"https://api.github.com/repos/mpimenov/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mpimenov/omim/deployments","created_at":"2015-09-30T10:55:18Z","updated_at":"2016-01-15T13:41:49Z","pushed_at":"2017-03-15T18:01:54Z","git_url":"git://github.com/mpimenov/omim.git","ssh_url":"git@github.com:mpimenov/omim.git","clone_url":"https://github.com/mpimenov/omim.git","svn_url":"https://github.com/mpimenov/omim","homepage":null,"size":2839181,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"d4219339e34ace124b4486591329b5b0c7eaf53b","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars2.githubusercontent.com/u/14185141?v=3","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-03-17T10:25:52Z","pushed_at":"2017-03-17T12:29:30Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":2976017,"stargazers_count":2186,"watchers_count":2186,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":440,"mirror_url":null,"open_issues_count":437,"forks":440,"open_issues":437,"watchers":2186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5609"},"html":{"href":"https://github.com/mapsme/omim/pull/5609"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/5609"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/5609/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5609/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/5609/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/e84da04815477129f9c2d88279ae121e66ef831d"}}}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 10366009,
"login": "mpimenov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10366009?",
"url": "https://api.github.com/users/mpimenov"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-03-17T13:01:35 |
5513581731
|
{"actor":{"display_login":"mpimenov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/129802256","pull_request_review_id":52611454,"id":129802256,"diff_hunk":"@@ -152,6 +152,48 @@ void PushPassedSubroutes(Checkpoints const & checkpoints, vector<Route::Subroute\n \n namespace routing\n {\n+// IndexRouter::BestEdgeComparator ----------------------------------------------------------------\n+IndexRouter::BestEdgeComparator::BestEdgeComparator(m2::PointD const & point, m2::PointD const & direction)\n+ : m_point(point), m_direction(direction)\n+{\n+}\n+\n+bool IndexRouter::BestEdgeComparator::Compare(Edge const & edge1, Edge const & edge2) const\n+{\n+ if (!m_direction.IsAlmostZero())\n+ {\n+ bool const isEdge1Parallel = IsAlmostParallel(edge1);\n+ if (isEdge1Parallel != IsAlmostParallel(edge2))\n+ return isEdge1Parallel;\n+ }\n+\n+ return GetSquaredDist(edge1) < GetSquaredDist(edge2);\n+}\n+\n+bool IndexRouter::BestEdgeComparator::IsAlmostParallel(Edge const & edge) const\n+{\n+ CHECK(!m_direction.IsAlmostZero(), ());\n+\n+ m2::PointD const edgeDirection =\n+ edge.GetEndJunction().GetPoint() - edge.GetStartJunction().GetPoint();\n+ if (edgeDirection.IsAlmostZero())\n+ return false;\n+\n+ double const cosAng =\n+ m2::DotProduct(m_direction.Normalize(), edgeDirection.Normalize());\n+ // Note. acos(0.97) ≈ 14 degrees.\n+ double constexpr kMinCosAngForAlmostParallelVectors = 0.97;","path":"routing/index_router.cpp","position":34,"original_position":34,"commit_id":"20f4ce3ee1196238463cd050306192e186aae2dc","original_commit_id":"0815534672aa389649d933b6e2de91b7fb9d2930","user":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"В общем предлагаю оставить как сейчас","created_at":"2017-07-27T10:06:08Z","updated_at":"2017-07-27T10:06:08Z","html_url":"https://github.com/mapsme/omim/pull/6715#discussion_r129802256","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/6715","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/129802256"},"html":{"href":"https://github.com/mapsme/omim/pull/6715#discussion_r129802256"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6715"}}},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/6715","id":132486651,"html_url":"https://github.com/mapsme/omim/pull/6715","diff_url":"https://github.com/mapsme/omim/pull/6715.diff","patch_url":"https://github.com/mapsme/omim/pull/6715.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/6715","number":6715,"state":"open","locked":false,"title":"[routing] Taking into account vector of user moving for choosing the best start edge.","user":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"body":"Выбор стартового сегмента с учетом направления движения.\r\nДля решения проблемы https://jira.mail.ru/browse/MAPSME-4919 необходимо было реализовать два тикета. Один из них (https://jira.mail.ru/browse/MAPSME-4945) реализован в этом PR. \r\n\r\nТеперь при выборе дуги для старта маршрута мы ищем ближайший сегмент среди тех, что почти параллельны вектору движения пользователя. А если таких не находится, то среди всех. Под почти параллельными понимаются сегменты, которые отличаются от вектора движения не более чем на 14 градусов.\r\n\r\n@dobriy-eeh @mpimenov PTAL\r\n","created_at":"2017-07-26T10:57:28Z","updated_at":"2017-07-27T10:06:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b156b18bd107b58c0f6f5e8809f1ca30276006","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/6715/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/6715/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/6715/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/20f4ce3ee1196238463cd050306192e186aae2dc","head":{"label":"bykoianko:release-74-route-rebuilt-direction","ref":"release-74-route-rebuilt-direction","sha":"20f4ce3ee1196238463cd050306192e186aae2dc","user":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"repo":{"id":43428862,"name":"omim","full_name":"bykoianko/omim","owner":{"login":"bykoianko","id":1768114,"avatar_url":"https://avatars0.githubusercontent.com/u/1768114?v=4","gravatar_id":"","url":"https://api.github.com/users/bykoianko","html_url":"https://github.com/bykoianko","followers_url":"https://api.github.com/users/bykoianko/followers","following_url":"https://api.github.com/users/bykoianko/following{/other_user}","gists_url":"https://api.github.com/users/bykoianko/gists{/gist_id}","starred_url":"https://api.github.com/users/bykoianko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bykoianko/subscriptions","organizations_url":"https://api.github.com/users/bykoianko/orgs","repos_url":"https://api.github.com/users/bykoianko/repos","events_url":"https://api.github.com/users/bykoianko/events{/privacy}","received_events_url":"https://api.github.com/users/bykoianko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bykoianko/omim","description":"MAPS.ME - Offline OpenStreetMap maps for iOS/Android/Mac/Linux/Windows","fork":true,"url":"https://api.github.com/repos/bykoianko/omim","forks_url":"https://api.github.com/repos/bykoianko/omim/forks","keys_url":"https://api.github.com/repos/bykoianko/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bykoianko/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bykoianko/omim/teams","hooks_url":"https://api.github.com/repos/bykoianko/omim/hooks","issue_events_url":"https://api.github.com/repos/bykoianko/omim/issues/events{/number}","events_url":"https://api.github.com/repos/bykoianko/omim/events","assignees_url":"https://api.github.com/repos/bykoianko/omim/assignees{/user}","branches_url":"https://api.github.com/repos/bykoianko/omim/branches{/branch}","tags_url":"https://api.github.com/repos/bykoianko/omim/tags","blobs_url":"https://api.github.com/repos/bykoianko/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bykoianko/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bykoianko/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bykoianko/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bykoianko/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/bykoianko/omim/languages","stargazers_url":"https://api.github.com/repos/bykoianko/omim/stargazers","contributors_url":"https://api.github.com/repos/bykoianko/omim/contributors","subscribers_url":"https://api.github.com/repos/bykoianko/omim/subscribers","subscription_url":"https://api.github.com/repos/bykoianko/omim/subscription","commits_url":"https://api.github.com/repos/bykoianko/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bykoianko/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bykoianko/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bykoianko/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bykoianko/omim/contents/{+path}","compare_url":"https://api.github.com/repos/bykoianko/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bykoianko/omim/merges","archive_url":"https://api.github.com/repos/bykoianko/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bykoianko/omim/downloads","issues_url":"https://api.github.com/repos/bykoianko/omim/issues{/number}","pulls_url":"https://api.github.com/repos/bykoianko/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/bykoianko/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/bykoianko/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bykoianko/omim/labels{/name}","releases_url":"https://api.github.com/repos/bykoianko/omim/releases{/id}","deployments_url":"https://api.github.com/repos/bykoianko/omim/deployments","created_at":"2015-09-30T11:21:20Z","updated_at":"2016-03-24T12:55:17Z","pushed_at":"2017-07-27T09:54:46Z","git_url":"git://github.com/bykoianko/omim.git","ssh_url":"git@github.com:bykoianko/omim.git","clone_url":"https://github.com/bykoianko/omim.git","svn_url":"https://github.com/bykoianko/omim","homepage":null,"size":3165930,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:release-74","ref":"release-74","sha":"fe641df515fbaabcee41277b5528b284e333af2a","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-07-27T03:29:54Z","pushed_at":"2017-07-27T10:04:43Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3267107,"stargazers_count":2346,"watchers_count":2346,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":481,"mirror_url":null,"open_issues_count":518,"forks":481,"open_issues":518,"watchers":2346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6715"},"html":{"href":"https://github.com/mapsme/omim/pull/6715"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/6715"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/6715/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6715/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/6715/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/20f4ce3ee1196238463cd050306192e186aae2dc"}}}}
|
{
"id": 42798033,
"name": "mapsme/omim",
"url": "https://api.github.com/repos/mapsme/omim"
}
|
{
"id": 1768114,
"login": "bykoianko",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1768114?",
"url": "https://api.github.com/users/bykoianko"
}
|
{
"id": 14185141,
"login": "mapsme",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14185141?",
"url": "https://api.github.com/orgs/mapsme"
}
| 2017-07-27T10:06:08 |
6340147192
|
{"actor":{"display_login":"bykoianko"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/metamx/server-metrics/pulls/comments/123122520","pull_request_review_id":45295858,"id":123122520,"diff_hunk":"@@ -0,0 +1,237 @@\n+/*\n+ * Copyright 2017 Metamarkets Group Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.metamx.metrics.cgroups;\n+\n+import com.google.common.annotations.VisibleForTesting;\n+import com.google.common.base.Charsets;\n+import com.google.common.base.Preconditions;\n+import com.google.common.base.Throwables;\n+import com.google.common.collect.ImmutableSet;\n+import com.google.common.io.Files;\n+import com.metamx.common.RE;\n+import com.metamx.common.StringUtils;\n+import com.metamx.metrics.CgroupUtil;\n+import java.io.File;\n+import java.io.IOException;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import java.util.Collection;\n+import java.util.List;\n+import java.util.Set;\n+import java.util.regex.Pattern;\n+\n+public class ProcCgroupDiscoverer implements CgroupDiscoverer\n+{\n+ private static final String CGROUP_TYPE = \"cgroup\";\n+ private static final String PROC_TYPE = \"getProc\";\n+\n+ @Override\n+ public Path discover(final String cgroup, long pid)\n+ {\n+ Preconditions.checkNotNull(cgroup, \"cgroup required\");\n+ // Wish List: find a way to cache these\n+ final File proc = getProc();\n+ final File procMounts = new File(proc, \"mounts\");\n+ final File procCgroups = new File(proc, \"cgroups\");\n+ final File pidCgroups = new File(new File(proc, Long.toString(pid)), \"cgroup\");\n+ final ProcCgroupsEntry procCgroupsEntry = getCgroupEntry(procCgroups, cgroup);\n+ final ProcMountsEntry procMountsEntry = getMountEntry(procMounts, cgroup);\n+ final ProcPidCgroupEntry procPidCgroupEntry = getPidCgroupEntry(pidCgroups, procCgroupsEntry.hierarchy);\n+ final File cgroupDir = new File(\n+ procMountsEntry.path.toFile(),\n+ procPidCgroupEntry.path\n+ );\n+ if (cgroupDir.exists() && cgroupDir.isDirectory()) {\n+ return cgroupDir.toPath();\n+ }\n+ throw new RE(\"Invalid cgroup directory [%s]\", cgroupDir);\n+ }\n+\n+ @VisibleForTesting\n+ public File getProc()\n+ {\n+ // Wish List: discover `/getProc` in a more reliable way\n+ final File proc = Paths.get(\"/proc\").toFile();\n+ Path foundProc = null;\n+ if (proc.exists() && proc.isDirectory()) {\n+ // Sanity check\n+ try {\n+ for (final String line : Files.readLines(new File(proc, \"mounts\"), Charsets.UTF_8)) {\n+ final ProcMountsEntry entry = ProcMountsEntry.parse(line);\n+ if (PROC_TYPE.equals(entry.type)) {\n+ if (proc.toPath().equals(entry.path)) {\n+ return proc;\n+ } else {\n+ foundProc = entry.path;\n+ }\n+ }\n+ }\n+ }\n+ catch (IOException e) {\n+ // Unlikely\n+ throw Throwables.propagate(e);\n+ }\n+ if (foundProc != null) {\n+ throw new RE(\"Expected proc to be mounted on /proc, but was on [%s]\", foundProc);\n+ } else {\n+ throw new RE(\"No proc entry found in /proc/mounts\");\n+ }\n+ } else {\n+ throw new RE(\"/proc is not a valid directory\");\n+ }\n+ }\n+\n+ private ProcPidCgroupEntry getPidCgroupEntry(final File pidCgroups, final int hierarchy)\n+ {\n+ final List<String> lines;\n+ try {\n+ lines = Files.readLines(pidCgroups, Charsets.UTF_8);\n+ }\n+ catch (IOException e) {\n+ throw Throwables.propagate(e);\n+ }\n+ for (final String line : lines) {\n+ final ProcPidCgroupEntry entry = ProcPidCgroupEntry.parse(line);\n+ if (hierarchy == entry.hierarchy) {\n+ return entry;\n+ }\n+ }\n+ throw new RuntimeException(StringUtils.safeFormat(\"No hierarchy found for [%d]\", hierarchy));\n+ }\n+\n+ private ProcCgroupsEntry getCgroupEntry(final File procCgroups, final String cgroup)\n+ {\n+ final List<String> lines;\n+ try {\n+ lines = Files.readLines(procCgroups, Charsets.UTF_8);\n+ }\n+ catch (IOException e) {\n+ throw Throwables.propagate(e);\n+ }\n+ for (final String line : lines) {\n+ if (line.startsWith(\"#\")) {\n+ continue;\n+ }\n+ final ProcCgroupsEntry entry = ProcCgroupsEntry.parse(line);\n+ if (entry.enabled && cgroup.equals(entry.subsystem_name)) {\n+ return entry;\n+ }\n+ }\n+ throw new RuntimeException(StringUtils.safeFormat(\"Hierarchy for [%s] not found\", cgroup));\n+ }\n+\n+ private ProcMountsEntry getMountEntry(final File procMounts, final String cgroup)\n+ {\n+ final List<String> lines;\n+ try {\n+ lines = Files.readLines(procMounts, Charsets.UTF_8);\n+ }\n+ catch (IOException e) {\n+ throw Throwables.propagate(e);\n+ }\n+\n+ for (final String line : lines) {\n+ final ProcMountsEntry entry = ProcMountsEntry.parse(line);\n+ if (CGROUP_TYPE.equals(entry.type) && entry.options.contains(cgroup)) {\n+ return entry;\n+ }\n+ }\n+ throw new RuntimeException(StringUtils.safeFormat(\"Cgroup [%s] not found\", cgroup));\n+ }\n+\n+ /**\n+ * Doesn't use the last two mount entries for priority/boot stuff\n+ */\n+ static class ProcMountsEntry\n+ {\n+ // Example: cgroup /sys/fs/cgroup/cpu,cpuacct cgroup rw,nosuid,nodev,noexec,relatime,cpu,cpuacct 0 0\n+ static ProcMountsEntry parse(String entry)\n+ {\n+ final String[] splits = entry.split(CgroupUtil.SPACE_MATCH, 6);\n+ Preconditions.checkArgument(splits.length == 6, \"Invalid entry: [%s]\", entry);\n+ return new ProcMountsEntry(\n+ splits[0],\n+ Paths.get(splits[1]),\n+ splits[2],\n+ ImmutableSet.copyOf(splits[3].split(CgroupUtil.COMMA_MATCH))\n+ );\n+ }\n+\n+ final String dev;","path":"src/main/java/com/metamx/metrics/cgroups/ProcCgroupDiscoverer.java","position":173,"original_position":174,"commit_id":"46326404e682fd8999505c7ac0ef806c52d2706d","original_commit_id":"1d51ffc3bab2fb595bcda7dd84f72a51a91045d5","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars1.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"body":"device (first field in `/proc/mounts`). Can be a `/dev` entry or a virtual fs","created_at":"2017-06-20T23:34:00Z","updated_at":"2017-06-20T23:34:00Z","html_url":"https://github.com/metamx/server-metrics/pull/30#discussion_r123122520","pull_request_url":"https://api.github.com/repos/metamx/server-metrics/pulls/30","_links":{"self":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/comments/123122520"},"html":{"href":"https://github.com/metamx/server-metrics/pull/30#discussion_r123122520"},"pull_request":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/metamx/server-metrics/pulls/30","id":126446970,"html_url":"https://github.com/metamx/server-metrics/pull/30","diff_url":"https://github.com/metamx/server-metrics/pull/30.diff","patch_url":"https://github.com/metamx/server-metrics/pull/30.patch","issue_url":"https://api.github.com/repos/metamx/server-metrics/issues/30","number":30,"state":"open","locked":false,"title":"Add CPU time monitor using cgroups","user":{"login":"drcrallen","id":8213081,"avatar_url":"https://avatars1.githubusercontent.com/u/8213081?v=3","gravatar_id":"","url":"https://api.github.com/users/drcrallen","html_url":"https://github.com/drcrallen","followers_url":"https://api.github.com/users/drcrallen/followers","following_url":"https://api.github.com/users/drcrallen/following{/other_user}","gists_url":"https://api.github.com/users/drcrallen/gists{/gist_id}","starred_url":"https://api.github.com/users/drcrallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drcrallen/subscriptions","organizations_url":"https://api.github.com/users/drcrallen/orgs","repos_url":"https://api.github.com/users/drcrallen/repos","events_url":"https://api.github.com/users/drcrallen/events{/privacy}","received_events_url":"https://api.github.com/users/drcrallen/received_events","type":"User","site_admin":false},"body":"Should be merged after https://github.com/metamx/server-metrics/pull/31","created_at":"2017-06-20T04:53:38Z","updated_at":"2017-06-20T23:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f327b145fa3577bd4cac119e8ee42cbd78b96caf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/metamx/server-metrics/pulls/30/commits","review_comments_url":"https://api.github.com/repos/metamx/server-metrics/pulls/30/comments","review_comment_url":"https://api.github.com/repos/metamx/server-metrics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metamx/server-metrics/issues/30/comments","statuses_url":"https://api.github.com/repos/metamx/server-metrics/statuses/46326404e682fd8999505c7ac0ef806c52d2706d","head":{"label":"metamx:cgroupCpuTime","ref":"cgroupCpuTime","sha":"46326404e682fd8999505c7ac0ef806c52d2706d","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars2.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":4576049,"name":"server-metrics","full_name":"metamx/server-metrics","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars2.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/server-metrics","description":"A library for emitting server-metrics","fork":false,"url":"https://api.github.com/repos/metamx/server-metrics","forks_url":"https://api.github.com/repos/metamx/server-metrics/forks","keys_url":"https://api.github.com/repos/metamx/server-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/server-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/server-metrics/teams","hooks_url":"https://api.github.com/repos/metamx/server-metrics/hooks","issue_events_url":"https://api.github.com/repos/metamx/server-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/server-metrics/events","assignees_url":"https://api.github.com/repos/metamx/server-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/server-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/server-metrics/tags","blobs_url":"https://api.github.com/repos/metamx/server-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/server-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/server-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/server-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/server-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/server-metrics/languages","stargazers_url":"https://api.github.com/repos/metamx/server-metrics/stargazers","contributors_url":"https://api.github.com/repos/metamx/server-metrics/contributors","subscribers_url":"https://api.github.com/repos/metamx/server-metrics/subscribers","subscription_url":"https://api.github.com/repos/metamx/server-metrics/subscription","commits_url":"https://api.github.com/repos/metamx/server-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/server-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/server-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/server-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/server-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/server-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/server-metrics/merges","archive_url":"https://api.github.com/repos/metamx/server-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/server-metrics/downloads","issues_url":"https://api.github.com/repos/metamx/server-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/server-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/server-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/server-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/server-metrics/labels{/name}","releases_url":"https://api.github.com/repos/metamx/server-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/server-metrics/deployments","created_at":"2012-06-06T18:02:46Z","updated_at":"2017-06-02T03:34:14Z","pushed_at":"2017-06-20T23:02:43Z","git_url":"git://github.com/metamx/server-metrics.git","ssh_url":"git@github.com:metamx/server-metrics.git","clone_url":"https://github.com/metamx/server-metrics.git","svn_url":"https://github.com/metamx/server-metrics","homepage":null,"size":648,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":8,"default_branch":"master"}},"base":{"label":"metamx:master","ref":"master","sha":"93dd83f11f1d7e65d2a75beb45db612e05f8970d","user":{"login":"metamx","id":299329,"avatar_url":"https://avatars2.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"repo":{"id":4576049,"name":"server-metrics","full_name":"metamx/server-metrics","owner":{"login":"metamx","id":299329,"avatar_url":"https://avatars2.githubusercontent.com/u/299329?v=3","gravatar_id":"","url":"https://api.github.com/users/metamx","html_url":"https://github.com/metamx","followers_url":"https://api.github.com/users/metamx/followers","following_url":"https://api.github.com/users/metamx/following{/other_user}","gists_url":"https://api.github.com/users/metamx/gists{/gist_id}","starred_url":"https://api.github.com/users/metamx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamx/subscriptions","organizations_url":"https://api.github.com/users/metamx/orgs","repos_url":"https://api.github.com/users/metamx/repos","events_url":"https://api.github.com/users/metamx/events{/privacy}","received_events_url":"https://api.github.com/users/metamx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metamx/server-metrics","description":"A library for emitting server-metrics","fork":false,"url":"https://api.github.com/repos/metamx/server-metrics","forks_url":"https://api.github.com/repos/metamx/server-metrics/forks","keys_url":"https://api.github.com/repos/metamx/server-metrics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metamx/server-metrics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metamx/server-metrics/teams","hooks_url":"https://api.github.com/repos/metamx/server-metrics/hooks","issue_events_url":"https://api.github.com/repos/metamx/server-metrics/issues/events{/number}","events_url":"https://api.github.com/repos/metamx/server-metrics/events","assignees_url":"https://api.github.com/repos/metamx/server-metrics/assignees{/user}","branches_url":"https://api.github.com/repos/metamx/server-metrics/branches{/branch}","tags_url":"https://api.github.com/repos/metamx/server-metrics/tags","blobs_url":"https://api.github.com/repos/metamx/server-metrics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metamx/server-metrics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metamx/server-metrics/git/refs{/sha}","trees_url":"https://api.github.com/repos/metamx/server-metrics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metamx/server-metrics/statuses/{sha}","languages_url":"https://api.github.com/repos/metamx/server-metrics/languages","stargazers_url":"https://api.github.com/repos/metamx/server-metrics/stargazers","contributors_url":"https://api.github.com/repos/metamx/server-metrics/contributors","subscribers_url":"https://api.github.com/repos/metamx/server-metrics/subscribers","subscription_url":"https://api.github.com/repos/metamx/server-metrics/subscription","commits_url":"https://api.github.com/repos/metamx/server-metrics/commits{/sha}","git_commits_url":"https://api.github.com/repos/metamx/server-metrics/git/commits{/sha}","comments_url":"https://api.github.com/repos/metamx/server-metrics/comments{/number}","issue_comment_url":"https://api.github.com/repos/metamx/server-metrics/issues/comments{/number}","contents_url":"https://api.github.com/repos/metamx/server-metrics/contents/{+path}","compare_url":"https://api.github.com/repos/metamx/server-metrics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metamx/server-metrics/merges","archive_url":"https://api.github.com/repos/metamx/server-metrics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metamx/server-metrics/downloads","issues_url":"https://api.github.com/repos/metamx/server-metrics/issues{/number}","pulls_url":"https://api.github.com/repos/metamx/server-metrics/pulls{/number}","milestones_url":"https://api.github.com/repos/metamx/server-metrics/milestones{/number}","notifications_url":"https://api.github.com/repos/metamx/server-metrics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metamx/server-metrics/labels{/name}","releases_url":"https://api.github.com/repos/metamx/server-metrics/releases{/id}","deployments_url":"https://api.github.com/repos/metamx/server-metrics/deployments","created_at":"2012-06-06T18:02:46Z","updated_at":"2017-06-02T03:34:14Z","pushed_at":"2017-06-20T23:02:43Z","git_url":"git://github.com/metamx/server-metrics.git","ssh_url":"git@github.com:metamx/server-metrics.git","clone_url":"https://github.com/metamx/server-metrics.git","svn_url":"https://github.com/metamx/server-metrics","homepage":null,"size":648,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":3,"forks":7,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/30"},"html":{"href":"https://github.com/metamx/server-metrics/pull/30"},"issue":{"href":"https://api.github.com/repos/metamx/server-metrics/issues/30"},"comments":{"href":"https://api.github.com/repos/metamx/server-metrics/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metamx/server-metrics/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/metamx/server-metrics/statuses/46326404e682fd8999505c7ac0ef806c52d2706d"}}}}
|
{
"id": 4576049,
"name": "metamx/server-metrics",
"url": "https://api.github.com/repos/metamx/server-metrics"
}
|
{
"id": 8213081,
"login": "drcrallen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8213081?",
"url": "https://api.github.com/users/drcrallen"
}
|
{
"id": 299329,
"login": "metamx",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/299329?",
"url": "https://api.github.com/orgs/metamx"
}
| 2017-06-20T23:34:00 |
6105373602
|
{"actor":{"display_login":"drcrallen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mirage/ocaml-github/pulls/comments/101988753","pull_request_review_id":22727909,"id":101988753,"diff_hunk":"@@ -339,10 +339,26 @@ module type Github = sig\n fires for responses with status [expected_code] and applies\n [parse]. *)\n \n+ (** The [Media_type] module exposes a range of HTTP [Accept]\n+ header values suitable for use in GitHub API requests *)\n+ module Media_type : sig\n+ val v3 : string\n+ (** [v3] corresponds to [application/vnd.github.v3+json], the\n+ media-type used by the\n+ {{:https://developer.github.com/v3/} GitHub API v3} *)\n+\n+ val experimental : string","path":"lib/github_s.mli","position":12,"original_position":12,"commit_id":"42fd1dcb685431dd7706520ae7ee4a113d23199f","original_commit_id":"42fd1dcb685431dd7706520ae7ee4a113d23199f","user":{"login":"dsheets","id":59918,"avatar_url":"https://avatars.githubusercontent.com/u/59918?v=3","gravatar_id":"","url":"https://api.github.com/users/dsheets","html_url":"https://github.com/dsheets","followers_url":"https://api.github.com/users/dsheets/followers","following_url":"https://api.github.com/users/dsheets/following{/other_user}","gists_url":"https://api.github.com/users/dsheets/gists{/gist_id}","starred_url":"https://api.github.com/users/dsheets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsheets/subscriptions","organizations_url":"https://api.github.com/users/dsheets/orgs","repos_url":"https://api.github.com/users/dsheets/repos","events_url":"https://api.github.com/users/dsheets/events{/privacy}","received_events_url":"https://api.github.com/users/dsheets/received_events","type":"User","site_admin":false},"body":"I'm not sure this should be exposed in the interface as a lot of these media types are temporary.","created_at":"2017-02-20T10:39:56Z","updated_at":"2017-02-20T10:41:24Z","html_url":"https://github.com/mirage/ocaml-github/pull/186#discussion_r101988753","pull_request_url":"https://api.github.com/repos/mirage/ocaml-github/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/comments/101988753"},"html":{"href":"https://github.com/mirage/ocaml-github/pull/186#discussion_r101988753"},"pull_request":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/mirage/ocaml-github/pulls/186","id":106954548,"html_url":"https://github.com/mirage/ocaml-github/pull/186","diff_url":"https://github.com/mirage/ocaml-github/pull/186.diff","patch_url":"https://github.com/mirage/ocaml-github/pull/186.patch","issue_url":"https://api.github.com/repos/mirage/ocaml-github/issues/186","number":186,"state":"open","locked":false,"title":"Add support for the Issue Timeline API","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"body":"This PR adds support for the experimental [Issue Timeline API](https://developer.github.com/v3/issues/timeline/), which exposes a variety of events not available in standard issue event streams, including repository cross-references.\r\n\r\nExperiments reveal that many of the fields, including `id`, are not returned in every case, and so the new types mark most of the fields as optional (17c9e5f).\r\n\r\nThe timeline API uses a distinct media-type (`application/vnd.github.mockingbird-preview`), and so the `get` function now accepts an additional optional argument (42fd1dc).","created_at":"2017-02-20T07:49:07Z","updated_at":"2017-02-20T10:41:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a172b9a30dfe09d64db49128c92f5528b3f33173","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mirage/ocaml-github/pulls/186/commits","review_comments_url":"https://api.github.com/repos/mirage/ocaml-github/pulls/186/comments","review_comment_url":"https://api.github.com/repos/mirage/ocaml-github/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mirage/ocaml-github/issues/186/comments","statuses_url":"https://api.github.com/repos/mirage/ocaml-github/statuses/42fd1dcb685431dd7706520ae7ee4a113d23199f","head":{"label":"yallop:timeline","ref":"timeline","sha":"42fd1dcb685431dd7706520ae7ee4a113d23199f","user":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"repo":{"id":67139674,"name":"ocaml-github","full_name":"yallop/ocaml-github","owner":{"login":"yallop","id":1736496,"avatar_url":"https://avatars.githubusercontent.com/u/1736496?v=3","gravatar_id":"","url":"https://api.github.com/users/yallop","html_url":"https://github.com/yallop","followers_url":"https://api.github.com/users/yallop/followers","following_url":"https://api.github.com/users/yallop/following{/other_user}","gists_url":"https://api.github.com/users/yallop/gists{/gist_id}","starred_url":"https://api.github.com/users/yallop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yallop/subscriptions","organizations_url":"https://api.github.com/users/yallop/orgs","repos_url":"https://api.github.com/users/yallop/repos","events_url":"https://api.github.com/users/yallop/events{/privacy}","received_events_url":"https://api.github.com/users/yallop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yallop/ocaml-github","description":"Github APIv3 OCaml bindings","fork":true,"url":"https://api.github.com/repos/yallop/ocaml-github","forks_url":"https://api.github.com/repos/yallop/ocaml-github/forks","keys_url":"https://api.github.com/repos/yallop/ocaml-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yallop/ocaml-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yallop/ocaml-github/teams","hooks_url":"https://api.github.com/repos/yallop/ocaml-github/hooks","issue_events_url":"https://api.github.com/repos/yallop/ocaml-github/issues/events{/number}","events_url":"https://api.github.com/repos/yallop/ocaml-github/events","assignees_url":"https://api.github.com/repos/yallop/ocaml-github/assignees{/user}","branches_url":"https://api.github.com/repos/yallop/ocaml-github/branches{/branch}","tags_url":"https://api.github.com/repos/yallop/ocaml-github/tags","blobs_url":"https://api.github.com/repos/yallop/ocaml-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yallop/ocaml-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yallop/ocaml-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/yallop/ocaml-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yallop/ocaml-github/statuses/{sha}","languages_url":"https://api.github.com/repos/yallop/ocaml-github/languages","stargazers_url":"https://api.github.com/repos/yallop/ocaml-github/stargazers","contributors_url":"https://api.github.com/repos/yallop/ocaml-github/contributors","subscribers_url":"https://api.github.com/repos/yallop/ocaml-github/subscribers","subscription_url":"https://api.github.com/repos/yallop/ocaml-github/subscription","commits_url":"https://api.github.com/repos/yallop/ocaml-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/yallop/ocaml-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/yallop/ocaml-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/yallop/ocaml-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/yallop/ocaml-github/contents/{+path}","compare_url":"https://api.github.com/repos/yallop/ocaml-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yallop/ocaml-github/merges","archive_url":"https://api.github.com/repos/yallop/ocaml-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yallop/ocaml-github/downloads","issues_url":"https://api.github.com/repos/yallop/ocaml-github/issues{/number}","pulls_url":"https://api.github.com/repos/yallop/ocaml-github/pulls{/number}","milestones_url":"https://api.github.com/repos/yallop/ocaml-github/milestones{/number}","notifications_url":"https://api.github.com/repos/yallop/ocaml-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yallop/ocaml-github/labels{/name}","releases_url":"https://api.github.com/repos/yallop/ocaml-github/releases{/id}","deployments_url":"https://api.github.com/repos/yallop/ocaml-github/deployments","created_at":"2016-09-01T14:43:29Z","updated_at":"2016-09-01T23:14:21Z","pushed_at":"2017-02-20T07:42:53Z","git_url":"git://github.com/yallop/ocaml-github.git","ssh_url":"git@github.com:yallop/ocaml-github.git","clone_url":"https://github.com/yallop/ocaml-github.git","svn_url":"https://github.com/yallop/ocaml-github","homepage":"","size":1375,"stargazers_count":1,"watchers_count":1,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mirage:master","ref":"master","sha":"aed3d351d4c2e345ab58cebeaf3363cbeba8a5cf","user":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"repo":{"id":3526998,"name":"ocaml-github","full_name":"mirage/ocaml-github","owner":{"login":"mirage","id":131943,"avatar_url":"https://avatars.githubusercontent.com/u/131943?v=3","gravatar_id":"","url":"https://api.github.com/users/mirage","html_url":"https://github.com/mirage","followers_url":"https://api.github.com/users/mirage/followers","following_url":"https://api.github.com/users/mirage/following{/other_user}","gists_url":"https://api.github.com/users/mirage/gists{/gist_id}","starred_url":"https://api.github.com/users/mirage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirage/subscriptions","organizations_url":"https://api.github.com/users/mirage/orgs","repos_url":"https://api.github.com/users/mirage/repos","events_url":"https://api.github.com/users/mirage/events{/privacy}","received_events_url":"https://api.github.com/users/mirage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mirage/ocaml-github","description":"GitHub APIv3 OCaml bindings","fork":false,"url":"https://api.github.com/repos/mirage/ocaml-github","forks_url":"https://api.github.com/repos/mirage/ocaml-github/forks","keys_url":"https://api.github.com/repos/mirage/ocaml-github/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirage/ocaml-github/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirage/ocaml-github/teams","hooks_url":"https://api.github.com/repos/mirage/ocaml-github/hooks","issue_events_url":"https://api.github.com/repos/mirage/ocaml-github/issues/events{/number}","events_url":"https://api.github.com/repos/mirage/ocaml-github/events","assignees_url":"https://api.github.com/repos/mirage/ocaml-github/assignees{/user}","branches_url":"https://api.github.com/repos/mirage/ocaml-github/branches{/branch}","tags_url":"https://api.github.com/repos/mirage/ocaml-github/tags","blobs_url":"https://api.github.com/repos/mirage/ocaml-github/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirage/ocaml-github/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirage/ocaml-github/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirage/ocaml-github/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirage/ocaml-github/statuses/{sha}","languages_url":"https://api.github.com/repos/mirage/ocaml-github/languages","stargazers_url":"https://api.github.com/repos/mirage/ocaml-github/stargazers","contributors_url":"https://api.github.com/repos/mirage/ocaml-github/contributors","subscribers_url":"https://api.github.com/repos/mirage/ocaml-github/subscribers","subscription_url":"https://api.github.com/repos/mirage/ocaml-github/subscription","commits_url":"https://api.github.com/repos/mirage/ocaml-github/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirage/ocaml-github/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirage/ocaml-github/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirage/ocaml-github/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirage/ocaml-github/contents/{+path}","compare_url":"https://api.github.com/repos/mirage/ocaml-github/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirage/ocaml-github/merges","archive_url":"https://api.github.com/repos/mirage/ocaml-github/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirage/ocaml-github/downloads","issues_url":"https://api.github.com/repos/mirage/ocaml-github/issues{/number}","pulls_url":"https://api.github.com/repos/mirage/ocaml-github/pulls{/number}","milestones_url":"https://api.github.com/repos/mirage/ocaml-github/milestones{/number}","notifications_url":"https://api.github.com/repos/mirage/ocaml-github/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirage/ocaml-github/labels{/name}","releases_url":"https://api.github.com/repos/mirage/ocaml-github/releases{/id}","deployments_url":"https://api.github.com/repos/mirage/ocaml-github/deployments","created_at":"2012-02-23T16:08:30Z","updated_at":"2017-01-31T20:47:03Z","pushed_at":"2017-02-20T07:49:08Z","git_url":"git://github.com/mirage/ocaml-github.git","ssh_url":"git@github.com:mirage/ocaml-github.git","clone_url":"https://github.com/mirage/ocaml-github.git","svn_url":"https://github.com/mirage/ocaml-github","homepage":"","size":1356,"stargazers_count":48,"watchers_count":48,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":20,"forks":34,"open_issues":20,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/186"},"html":{"href":"https://github.com/mirage/ocaml-github/pull/186"},"issue":{"href":"https://api.github.com/repos/mirage/ocaml-github/issues/186"},"comments":{"href":"https://api.github.com/repos/mirage/ocaml-github/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mirage/ocaml-github/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/mirage/ocaml-github/statuses/42fd1dcb685431dd7706520ae7ee4a113d23199f"}}}}
|
{
"id": 3526998,
"name": "mirage/ocaml-github",
"url": "https://api.github.com/repos/mirage/ocaml-github"
}
|
{
"id": 59918,
"login": "dsheets",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/59918?",
"url": "https://api.github.com/users/dsheets"
}
|
{
"id": 131943,
"login": "mirage",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/131943?",
"url": "https://api.github.com/orgs/mirage"
}
| 2017-02-20T10:39:56 |
5354707132
|
{"actor":{"display_login":"dsheets"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/121534086","pull_request_review_id":43570809,"id":121534086,"diff_hunk":"@@ -166,6 +175,7 @@ const mapDispatchToProps = {\n clearFilters: () => changeFilterTo(null),\n openModal: () => openModal(PRODUCT_LIST_FILTER_MODAL),\n sortChange: changeSort,\n+ setProduct: setCurrentProduct","path":"web/app/containers/product-list/partials/product-list-contents.jsx","position":63,"original_position":63,"commit_id":"74dee83959eaac7a7e4fd5c592afea261e38c4f1","original_commit_id":"4eecb052ad5657211248e73204a5b169e4ce9026","user":{"login":"jeremywiebe","id":77138,"avatar_url":"https://avatars2.githubusercontent.com/u/77138?v=3","gravatar_id":"","url":"https://api.github.com/users/jeremywiebe","html_url":"https://github.com/jeremywiebe","followers_url":"https://api.github.com/users/jeremywiebe/followers","following_url":"https://api.github.com/users/jeremywiebe/following{/other_user}","gists_url":"https://api.github.com/users/jeremywiebe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremywiebe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremywiebe/subscriptions","organizations_url":"https://api.github.com/users/jeremywiebe/orgs","repos_url":"https://api.github.com/users/jeremywiebe/repos","events_url":"https://api.github.com/users/jeremywiebe/events{/privacy}","received_events_url":"https://api.github.com/users/jeremywiebe/received_events","type":"User","site_admin":false},"body":"I'd recommend that we keep `Current` in this method name. It becomes less clear why we're attaching it to the `ResultList` above if it's just `setProduct`...","created_at":"2017-06-12T21:40:00Z","updated_at":"2017-06-12T22:02:25Z","html_url":"https://github.com/mobify/platform-scaffold/pull/711#discussion_r121534086","pull_request_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711","_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments/121534086"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/711#discussion_r121534086"},"pull_request":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711"}}},"pull_request":{"url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711","id":124491294,"html_url":"https://github.com/mobify/platform-scaffold/pull/711","diff_url":"https://github.com/mobify/platform-scaffold/pull/711.diff","patch_url":"https://github.com/mobify/platform-scaffold/pull/711.patch","issue_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/711","number":711,"state":"open","locked":false,"title":"[Refactor] Transition from urlToPathkeys -> product IDs for Products & Category keys","user":{"login":"Cdok","id":16109837,"avatar_url":"https://avatars3.githubusercontent.com/u/16109837?v=3","gravatar_id":"","url":"https://api.github.com/users/Cdok","html_url":"https://github.com/Cdok","followers_url":"https://api.github.com/users/Cdok/followers","following_url":"https://api.github.com/users/Cdok/following{/other_user}","gists_url":"https://api.github.com/users/Cdok/gists{/gist_id}","starred_url":"https://api.github.com/users/Cdok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cdok/subscriptions","organizations_url":"https://api.github.com/users/Cdok/orgs","repos_url":"https://api.github.com/users/Cdok/repos","events_url":"https://api.github.com/users/Cdok/events{/privacy}","received_events_url":"https://api.github.com/users/Cdok/received_events","type":"User","site_admin":false},"body":"# [Refactor] Transition from urlToPathkeys -> product IDs for Products & Category keys\r\n\r\n **JIRA**: https://mobify.atlassian.net/browse/WEBDATA-112\r\n**Linked PRs**: https://github.com/mobify/platform-scaffold/pull/704 and https://github.com/mobify/platform-scaffold/pull/733\r\n\r\n## Changes\r\n- Transition from urlToPathkeys -> product IDs across both connectors\r\n\r\n## How to test-drive this PR\r\n- Tests on both Connectors\r\n- Run `npm run dev`\r\n- Preview [Merlin's Potions](https://preview.mobify.com/?url=https%3A%2F%2Fwww.merlinspotions.com%2F&site_folder=https%3A%2F%2Flocalhost%3A8443%2Floader.js&disabled=0&domain=&scope=1)\r\n- Ensure things look good in the Redux store in terms of product-IDs as keys (under categories, cart, products, etc)\r\n- Refresh on PDP - ensure page still works landing directly on PDP\r\n- Try PLP -> PDP flows\r\n","created_at":"2017-06-07T18:46:51Z","updated_at":"2017-06-12T22:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a17cb557becab44e935ad63b8d0fad4d4030a9b3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711/commits","review_comments_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711/comments","review_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/711/comments","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/74dee83959eaac7a7e4fd5c592afea261e38c4f1","head":{"label":"mobify:merlins-product-ids-as-keys","ref":"merlins-product-ids-as-keys","sha":"74dee83959eaac7a7e4fd5c592afea261e38c4f1","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉 Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-06-12T21:50:16Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":44571,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":2,"default_branch":"develop"}},"base":{"label":"mobify:develop","ref":"develop","sha":"0b8155c9e5a7a8f1a301e8208a7a049dcd7f063a","user":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"repo":{"id":62259838,"name":"platform-scaffold","full_name":"mobify/platform-scaffold","owner":{"login":"mobify","id":73539,"avatar_url":"https://avatars3.githubusercontent.com/u/73539?v=3","gravatar_id":"","url":"https://api.github.com/users/mobify","html_url":"https://github.com/mobify","followers_url":"https://api.github.com/users/mobify/followers","following_url":"https://api.github.com/users/mobify/following{/other_user}","gists_url":"https://api.github.com/users/mobify/gists{/gist_id}","starred_url":"https://api.github.com/users/mobify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobify/subscriptions","organizations_url":"https://api.github.com/users/mobify/orgs","repos_url":"https://api.github.com/users/mobify/repos","events_url":"https://api.github.com/users/mobify/events{/privacy}","received_events_url":"https://api.github.com/users/mobify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mobify/platform-scaffold","description":"👉 Starter kit for the Mobify Platform","fork":false,"url":"https://api.github.com/repos/mobify/platform-scaffold","forks_url":"https://api.github.com/repos/mobify/platform-scaffold/forks","keys_url":"https://api.github.com/repos/mobify/platform-scaffold/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mobify/platform-scaffold/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mobify/platform-scaffold/teams","hooks_url":"https://api.github.com/repos/mobify/platform-scaffold/hooks","issue_events_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/events{/number}","events_url":"https://api.github.com/repos/mobify/platform-scaffold/events","assignees_url":"https://api.github.com/repos/mobify/platform-scaffold/assignees{/user}","branches_url":"https://api.github.com/repos/mobify/platform-scaffold/branches{/branch}","tags_url":"https://api.github.com/repos/mobify/platform-scaffold/tags","blobs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mobify/platform-scaffold/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mobify/platform-scaffold/git/refs{/sha}","trees_url":"https://api.github.com/repos/mobify/platform-scaffold/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mobify/platform-scaffold/statuses/{sha}","languages_url":"https://api.github.com/repos/mobify/platform-scaffold/languages","stargazers_url":"https://api.github.com/repos/mobify/platform-scaffold/stargazers","contributors_url":"https://api.github.com/repos/mobify/platform-scaffold/contributors","subscribers_url":"https://api.github.com/repos/mobify/platform-scaffold/subscribers","subscription_url":"https://api.github.com/repos/mobify/platform-scaffold/subscription","commits_url":"https://api.github.com/repos/mobify/platform-scaffold/commits{/sha}","git_commits_url":"https://api.github.com/repos/mobify/platform-scaffold/git/commits{/sha}","comments_url":"https://api.github.com/repos/mobify/platform-scaffold/comments{/number}","issue_comment_url":"https://api.github.com/repos/mobify/platform-scaffold/issues/comments{/number}","contents_url":"https://api.github.com/repos/mobify/platform-scaffold/contents/{+path}","compare_url":"https://api.github.com/repos/mobify/platform-scaffold/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mobify/platform-scaffold/merges","archive_url":"https://api.github.com/repos/mobify/platform-scaffold/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mobify/platform-scaffold/downloads","issues_url":"https://api.github.com/repos/mobify/platform-scaffold/issues{/number}","pulls_url":"https://api.github.com/repos/mobify/platform-scaffold/pulls{/number}","milestones_url":"https://api.github.com/repos/mobify/platform-scaffold/milestones{/number}","notifications_url":"https://api.github.com/repos/mobify/platform-scaffold/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mobify/platform-scaffold/labels{/name}","releases_url":"https://api.github.com/repos/mobify/platform-scaffold/releases{/id}","deployments_url":"https://api.github.com/repos/mobify/platform-scaffold/deployments","created_at":"2016-06-29T21:42:48Z","updated_at":"2017-05-10T17:51:05Z","pushed_at":"2017-06-12T21:50:16Z","git_url":"git://github.com/mobify/platform-scaffold.git","ssh_url":"git@github.com:mobify/platform-scaffold.git","clone_url":"https://github.com/mobify/platform-scaffold.git","svn_url":"https://github.com/mobify/platform-scaffold","homepage":"https://www.merlinspotions.com","size":44571,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711"},"html":{"href":"https://github.com/mobify/platform-scaffold/pull/711"},"issue":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/711"},"comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/issues/711/comments"},"review_comments":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711/comments"},"review_comment":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mobify/platform-scaffold/pulls/711/commits"},"statuses":{"href":"https://api.github.com/repos/mobify/platform-scaffold/statuses/74dee83959eaac7a7e4fd5c592afea261e38c4f1"}}}}
|
{
"id": 62259838,
"name": "mobify/platform-scaffold",
"url": "https://api.github.com/repos/mobify/platform-scaffold"
}
|
{
"id": 77138,
"login": "jeremywiebe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/77138?",
"url": "https://api.github.com/users/jeremywiebe"
}
|
{
"id": 73539,
"login": "mobify",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/73539?",
"url": "https://api.github.com/orgs/mobify"
}
| 2017-06-12T21:40:00 |
6050842712
|
{"actor":{"display_login":"jeremywiebe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/comments/145079839","pull_request_review_id":69824538,"id":145079839,"diff_hunk":"@@ -102,3 +106,29 @@ export function resetSoknad() {\n \t\tdispatch(resetFakta());\n \t};\n }\n+\n+export function avbrytSoknad() {\n+\treturn (dispatch: SoknadDispatch<any>) => {\n+\t\tdispatch({ type: SoknadActionTypeKeys.AVBRYT_SOKNAD });\n+\t};\n+}\n+\n+export function fortsettSoknad() {\n+\treturn (dispatch: SoknadDispatch<any>) => {\n+\t\tdispatch({ type: SoknadActionTypeKeys.FORTSETT_SOKNAD });\n+\t};\n+}\n+\n+export function slettSoknad(brukerBehandlingsId: string) {\n+\treturn (dispatch: SoknadDispatch<any>) => {\n+\t\treturn fetchDelete(\"soknader/\" + brukerBehandlingsId).then(() => {\n+\t\t\t//","path":"web/src/frontend/src/digisos/redux/soknad/soknadActions.ts","position":46,"original_position":46,"commit_id":"3b92fc35f0b545cfa2903dc89d53194d935e1fa2","original_commit_id":"3b92fc35f0b545cfa2903dc89d53194d935e1fa2","user":{"login":"thomasfl","id":1520,"avatar_url":"https://avatars3.githubusercontent.com/u/1520?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasfl","html_url":"https://github.com/thomasfl","followers_url":"https://api.github.com/users/thomasfl/followers","following_url":"https://api.github.com/users/thomasfl/following{/other_user}","gists_url":"https://api.github.com/users/thomasfl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfl/subscriptions","organizations_url":"https://api.github.com/users/thomasfl/orgs","repos_url":"https://api.github.com/users/thomasfl/repos","events_url":"https://api.github.com/users/thomasfl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfl/received_events","type":"User","site_admin":false},"body":"Fjernet .then gren","created_at":"2017-10-17T09:47:07Z","updated_at":"2017-10-17T09:47:07Z","html_url":"https://github.com/navikt/soknadsosialhjelp/pull/159#discussion_r145079839","pull_request_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/comments/145079839"},"html":{"href":"https://github.com/navikt/soknadsosialhjelp/pull/159#discussion_r145079839"},"pull_request":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159"}},"in_reply_to_id":145045173},"pull_request":{"url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159","id":146459415,"html_url":"https://github.com/navikt/soknadsosialhjelp/pull/159","diff_url":"https://github.com/navikt/soknadsosialhjelp/pull/159.diff","patch_url":"https://github.com/navikt/soknadsosialhjelp/pull/159.patch","issue_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/159","number":159,"state":"open","locked":false,"title":"Avbryt søknad funksjon","user":{"login":"thomasfl","id":1520,"avatar_url":"https://avatars3.githubusercontent.com/u/1520?v=4","gravatar_id":"","url":"https://api.github.com/users/thomasfl","html_url":"https://github.com/thomasfl","followers_url":"https://api.github.com/users/thomasfl/followers","following_url":"https://api.github.com/users/thomasfl/following{/other_user}","gists_url":"https://api.github.com/users/thomasfl/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasfl/subscriptions","organizations_url":"https://api.github.com/users/thomasfl/orgs","repos_url":"https://api.github.com/users/thomasfl/repos","events_url":"https://api.github.com/users/thomasfl/events{/privacy}","received_events_url":"https://api.github.com/users/thomasfl/received_events","type":"User","site_admin":false},"body":"- Avbrytfunksjon som viser en modal med valgene \"Ja\" og \"Nei\"\r\n- Sletter søknad på server\r\n- Ny reducer for å gjøre et restkall mot /miljovariabler som inneholder url til ditt-nav\r\n- Oppdatert mock backend for å ta imot slett søknad og returnere miljøvariabler","created_at":"2017-10-13T13:37:27Z","updated_at":"2017-10-17T09:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90e68928467f5401b8191694a212ecb99458b7a5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Matsemann","id":1030544,"avatar_url":"https://avatars3.githubusercontent.com/u/1030544?v=4","gravatar_id":"","url":"https://api.github.com/users/Matsemann","html_url":"https://github.com/Matsemann","followers_url":"https://api.github.com/users/Matsemann/followers","following_url":"https://api.github.com/users/Matsemann/following{/other_user}","gists_url":"https://api.github.com/users/Matsemann/gists{/gist_id}","starred_url":"https://api.github.com/users/Matsemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matsemann/subscriptions","organizations_url":"https://api.github.com/users/Matsemann/orgs","repos_url":"https://api.github.com/users/Matsemann/repos","events_url":"https://api.github.com/users/Matsemann/events{/privacy}","received_events_url":"https://api.github.com/users/Matsemann/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159/commits","review_comments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159/comments","review_comment_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/159/comments","statuses_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/statuses/3b92fc35f0b545cfa2903dc89d53194d935e1fa2","head":{"label":"navikt:feature/avbryt","ref":"feature/avbryt","sha":"3b92fc35f0b545cfa2903dc89d53194d935e1fa2","user":{"login":"navikt","id":11848947,"avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"repo":{"id":100021623,"name":"soknadsosialhjelp","full_name":"navikt/soknadsosialhjelp","owner":{"login":"navikt","id":11848947,"avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/navikt/soknadsosialhjelp","description":"Søknad for økonomisk sosialhjelp","fork":false,"url":"https://api.github.com/repos/navikt/soknadsosialhjelp","forks_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/forks","keys_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/teams","hooks_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/hooks","issue_events_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/events{/number}","events_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/events","assignees_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/assignees{/user}","branches_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/branches{/branch}","tags_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/tags","blobs_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/refs{/sha}","trees_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/statuses/{sha}","languages_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/languages","stargazers_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/stargazers","contributors_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/contributors","subscribers_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/subscribers","subscription_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/subscription","commits_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/commits{/sha}","git_commits_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/commits{/sha}","comments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/comments{/number}","issue_comment_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/comments{/number}","contents_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/contents/{+path}","compare_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/merges","archive_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/downloads","issues_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues{/number}","pulls_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls{/number}","milestones_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/milestones{/number}","notifications_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/labels{/name}","releases_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/releases{/id}","deployments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/deployments","created_at":"2017-08-11T10:40:17Z","updated_at":"2017-09-19T18:05:34Z","pushed_at":"2017-10-17T09:46:37Z","git_url":"git://github.com/navikt/soknadsosialhjelp.git","ssh_url":"git@github.com:navikt/soknadsosialhjelp.git","clone_url":"https://github.com/navikt/soknadsosialhjelp.git","svn_url":"https://github.com/navikt/soknadsosialhjelp","homepage":null,"size":80508,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"navikt:master","ref":"master","sha":"dd8c34a6035c67d65d93d666e5f932c7f0e598ef","user":{"login":"navikt","id":11848947,"avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"repo":{"id":100021623,"name":"soknadsosialhjelp","full_name":"navikt/soknadsosialhjelp","owner":{"login":"navikt","id":11848947,"avatar_url":"https://avatars3.githubusercontent.com/u/11848947?v=4","gravatar_id":"","url":"https://api.github.com/users/navikt","html_url":"https://github.com/navikt","followers_url":"https://api.github.com/users/navikt/followers","following_url":"https://api.github.com/users/navikt/following{/other_user}","gists_url":"https://api.github.com/users/navikt/gists{/gist_id}","starred_url":"https://api.github.com/users/navikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navikt/subscriptions","organizations_url":"https://api.github.com/users/navikt/orgs","repos_url":"https://api.github.com/users/navikt/repos","events_url":"https://api.github.com/users/navikt/events{/privacy}","received_events_url":"https://api.github.com/users/navikt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/navikt/soknadsosialhjelp","description":"Søknad for økonomisk sosialhjelp","fork":false,"url":"https://api.github.com/repos/navikt/soknadsosialhjelp","forks_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/forks","keys_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/teams","hooks_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/hooks","issue_events_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/events{/number}","events_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/events","assignees_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/assignees{/user}","branches_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/branches{/branch}","tags_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/tags","blobs_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/refs{/sha}","trees_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/statuses/{sha}","languages_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/languages","stargazers_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/stargazers","contributors_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/contributors","subscribers_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/subscribers","subscription_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/subscription","commits_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/commits{/sha}","git_commits_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/git/commits{/sha}","comments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/comments{/number}","issue_comment_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/comments{/number}","contents_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/contents/{+path}","compare_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/merges","archive_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/downloads","issues_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues{/number}","pulls_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls{/number}","milestones_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/milestones{/number}","notifications_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/labels{/name}","releases_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/releases{/id}","deployments_url":"https://api.github.com/repos/navikt/soknadsosialhjelp/deployments","created_at":"2017-08-11T10:40:17Z","updated_at":"2017-09-19T18:05:34Z","pushed_at":"2017-10-17T09:46:37Z","git_url":"git://github.com/navikt/soknadsosialhjelp.git","ssh_url":"git@github.com:navikt/soknadsosialhjelp.git","clone_url":"https://github.com/navikt/soknadsosialhjelp.git","svn_url":"https://github.com/navikt/soknadsosialhjelp","homepage":null,"size":80508,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159"},"html":{"href":"https://github.com/navikt/soknadsosialhjelp/pull/159"},"issue":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/159"},"comments":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/issues/159/comments"},"review_comments":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159/comments"},"review_comment":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/pulls/159/commits"},"statuses":{"href":"https://api.github.com/repos/navikt/soknadsosialhjelp/statuses/3b92fc35f0b545cfa2903dc89d53194d935e1fa2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 100021623,
"name": "navikt/soknadsosialhjelp",
"url": "https://api.github.com/repos/navikt/soknadsosialhjelp"
}
|
{
"id": 1520,
"login": "thomasfl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1520?",
"url": "https://api.github.com/users/thomasfl"
}
|
{
"id": 11848947,
"login": "navikt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11848947?",
"url": "https://api.github.com/orgs/navikt"
}
| 2017-10-17T09:47:07 |
6726413588
|
{"actor":{"display_login":"thomasfl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/neovim/neovim/pulls/comments/103426381","pull_request_review_id":24209985,"id":103426381,"diff_hunk":"@@ -413,5 +417,9 @@ of update.\n [\"popupmenu_hide\"]\n \tThe popupmenu is hidden.\n \n+[\"tabline_update\", curtab, tabs]\n+\tNvim will send this event when drawing tabline. curtab is the tab id\n+\tof the current tab. tabs is an arrays of the form [tabid, tabname].","path":"runtime/doc/msgpack_rpc.txt","position":17,"original_position":17,"commit_id":"d94023bf7c9fd434e90e5aeb17da9d11f46b6365","original_commit_id":"d94023bf7c9fd434e90e5aeb17da9d11f46b6365","user":{"login":"justinmk","id":1359421,"avatar_url":"https://avatars.githubusercontent.com/u/1359421?v=3","gravatar_id":"","url":"https://api.github.com/users/justinmk","html_url":"https://github.com/justinmk","followers_url":"https://api.github.com/users/justinmk/followers","following_url":"https://api.github.com/users/justinmk/following{/other_user}","gists_url":"https://api.github.com/users/justinmk/gists{/gist_id}","starred_url":"https://api.github.com/users/justinmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinmk/subscriptions","organizations_url":"https://api.github.com/users/justinmk/orgs","repos_url":"https://api.github.com/users/justinmk/repos","events_url":"https://api.github.com/users/justinmk/events{/privacy}","received_events_url":"https://api.github.com/users/justinmk/received_events","type":"User","site_admin":false},"body":" tabs is an arrays of the form [tabid, { \"name\": name } ].\r\n\r\nThen we can add new fields later.","created_at":"2017-02-28T10:48:25Z","updated_at":"2017-02-28T10:48:25Z","html_url":"https://github.com/neovim/neovim/pull/6170#discussion_r103426381","pull_request_url":"https://api.github.com/repos/neovim/neovim/pulls/6170","_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments/103426381"},"html":{"href":"https://github.com/neovim/neovim/pull/6170#discussion_r103426381"},"pull_request":{"href":"https://api.github.com/repos/neovim/neovim/pulls/6170"}}},"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/6170","id":107795520,"html_url":"https://github.com/neovim/neovim/pull/6170","diff_url":"https://github.com/neovim/neovim/pull/6170.diff","patch_url":"https://github.com/neovim/neovim/pull/6170.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/6170","number":6170,"state":"open","locked":false,"title":"[RFC] allow external ui to draw tabline","user":{"login":"dzhou121","id":1169480,"avatar_url":"https://avatars.githubusercontent.com/u/1169480?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhou121","html_url":"https://github.com/dzhou121","followers_url":"https://api.github.com/users/dzhou121/followers","following_url":"https://api.github.com/users/dzhou121/following{/other_user}","gists_url":"https://api.github.com/users/dzhou121/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhou121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhou121/subscriptions","organizations_url":"https://api.github.com/users/dzhou121/orgs","repos_url":"https://api.github.com/users/dzhou121/repos","events_url":"https://api.github.com/users/dzhou121/events{/privacy}","received_events_url":"https://api.github.com/users/dzhou121/received_events","type":"User","site_admin":false},"body":"Part of PR #5686","created_at":"2017-02-24T09:36:05Z","updated_at":"2017-02-28T10:48:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"140d23f9f8a9b1e6c51c002a8f83e63a9e3b1825","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/6170/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/6170/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/6170/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/d94023bf7c9fd434e90e5aeb17da9d11f46b6365","head":{"label":"dzhou121:external-tabline","ref":"external-tabline","sha":"d94023bf7c9fd434e90e5aeb17da9d11f46b6365","user":{"login":"dzhou121","id":1169480,"avatar_url":"https://avatars.githubusercontent.com/u/1169480?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhou121","html_url":"https://github.com/dzhou121","followers_url":"https://api.github.com/users/dzhou121/followers","following_url":"https://api.github.com/users/dzhou121/following{/other_user}","gists_url":"https://api.github.com/users/dzhou121/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhou121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhou121/subscriptions","organizations_url":"https://api.github.com/users/dzhou121/orgs","repos_url":"https://api.github.com/users/dzhou121/repos","events_url":"https://api.github.com/users/dzhou121/events{/privacy}","received_events_url":"https://api.github.com/users/dzhou121/received_events","type":"User","site_admin":false},"repo":{"id":60512341,"name":"neovim","full_name":"dzhou121/neovim","owner":{"login":"dzhou121","id":1169480,"avatar_url":"https://avatars.githubusercontent.com/u/1169480?v=3","gravatar_id":"","url":"https://api.github.com/users/dzhou121","html_url":"https://github.com/dzhou121","followers_url":"https://api.github.com/users/dzhou121/followers","following_url":"https://api.github.com/users/dzhou121/following{/other_user}","gists_url":"https://api.github.com/users/dzhou121/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhou121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhou121/subscriptions","organizations_url":"https://api.github.com/users/dzhou121/orgs","repos_url":"https://api.github.com/users/dzhou121/repos","events_url":"https://api.github.com/users/dzhou121/events{/privacy}","received_events_url":"https://api.github.com/users/dzhou121/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzhou121/neovim","description":"Vim-fork focused on extensibility and agility.","fork":true,"url":"https://api.github.com/repos/dzhou121/neovim","forks_url":"https://api.github.com/repos/dzhou121/neovim/forks","keys_url":"https://api.github.com/repos/dzhou121/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzhou121/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzhou121/neovim/teams","hooks_url":"https://api.github.com/repos/dzhou121/neovim/hooks","issue_events_url":"https://api.github.com/repos/dzhou121/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/dzhou121/neovim/events","assignees_url":"https://api.github.com/repos/dzhou121/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/dzhou121/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/dzhou121/neovim/tags","blobs_url":"https://api.github.com/repos/dzhou121/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzhou121/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzhou121/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzhou121/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzhou121/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/dzhou121/neovim/languages","stargazers_url":"https://api.github.com/repos/dzhou121/neovim/stargazers","contributors_url":"https://api.github.com/repos/dzhou121/neovim/contributors","subscribers_url":"https://api.github.com/repos/dzhou121/neovim/subscribers","subscription_url":"https://api.github.com/repos/dzhou121/neovim/subscription","commits_url":"https://api.github.com/repos/dzhou121/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzhou121/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzhou121/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzhou121/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzhou121/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/dzhou121/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzhou121/neovim/merges","archive_url":"https://api.github.com/repos/dzhou121/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzhou121/neovim/downloads","issues_url":"https://api.github.com/repos/dzhou121/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/dzhou121/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/dzhou121/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/dzhou121/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzhou121/neovim/labels{/name}","releases_url":"https://api.github.com/repos/dzhou121/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/dzhou121/neovim/deployments","created_at":"2016-06-06T08:38:46Z","updated_at":"2017-02-24T08:40:36Z","pushed_at":"2017-02-28T10:19:11Z","git_url":"git://github.com/dzhou121/neovim.git","ssh_url":"git@github.com:dzhou121/neovim.git","clone_url":"https://github.com/dzhou121/neovim.git","svn_url":"https://github.com/dzhou121/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":48787,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"9752a333c32c344eb0cd86b4a3bba4ce6cba3b23","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"Vim-fork focused on extensibility and usability.","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","deployments_url":"https://api.github.com/repos/neovim/neovim/deployments","created_at":"2014-01-31T13:39:22Z","updated_at":"2017-02-28T10:35:39Z","pushed_at":"2017-02-28T10:19:13Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"https://salt.bountysource.com/teams/neovim","size":49651,"stargazers_count":21747,"watchers_count":21747,"language":"Vim script","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1545,"mirror_url":null,"open_issues_count":754,"forks":1545,"open_issues":754,"watchers":21747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/6170"},"html":{"href":"https://github.com/neovim/neovim/pull/6170"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/6170"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/6170/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/6170/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/6170/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/d94023bf7c9fd434e90e5aeb17da9d11f46b6365"}}}}
|
{
"id": 16408992,
"name": "neovim/neovim",
"url": "https://api.github.com/repos/neovim/neovim"
}
|
{
"id": 1359421,
"login": "justinmk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1359421?",
"url": "https://api.github.com/users/justinmk"
}
|
{
"id": 6471485,
"login": "neovim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6471485?",
"url": "https://api.github.com/orgs/neovim"
}
| 2017-02-28T10:48:25 |
5403827138
|
{"actor":{"display_login":"justinmk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/151984207","pull_request_review_id":77775176,"id":151984207,"diff_hunk":"@@ -38,17 +76,20 @@ void PerIsolatePlatformData::FlushTasks(uv_async_t* handle) {\n platform_data->FlushForegroundTasksInternal();\n }\n \n-void PerIsolatePlatformData::CallOnForegroundThread(\n- std::unique_ptr<Task> task) {\n+void PerIsolatePlatformData::PostIdleTask(std::unique_ptr<v8::IdleTask> task) {\n+ CHECK(false && \"idle tasks not enabled\");","path":"src/node_platform.cc","position":52,"original_position":52,"commit_id":"5a3abae9542605ed297e2142220e941f70d1d897","original_commit_id":"5a3abae9542605ed297e2142220e941f70d1d897","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"Ditto.","created_at":"2017-11-20T13:02:31Z","updated_at":"2017-11-20T13:06:33Z","html_url":"https://github.com/nodejs/node/pull/17134#discussion_r151984207","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/17134","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/151984207"},"html":{"href":"https://github.com/nodejs/node/pull/17134#discussion_r151984207"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/17134"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17134","id":153496688,"html_url":"https://github.com/nodejs/node/pull/17134","diff_url":"https://github.com/nodejs/node/pull/17134.diff","patch_url":"https://github.com/nodejs/node/pull/17134.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/17134","number":17134,"state":"open","locked":false,"title":"src: implement v8::TaskRunner API in NodePlatform","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"body":"V8 is switching APIs for scheduling tasks. Implement the new APIs.\r\n\r\nFixes: nodejs/node-v8#24\r\nRefs: v8/v8@c690f54\r\n\r\nNote: This cherry-picks the API change itself (which is scheduled for V8 6.4) into this branch. We can wait for that release to perform the change if we like, but I’m not sure how we’d do node-canary coverage without this?\r\n\r\n/cc @nodejs/v8 @gahaas\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included (the WASM test fails without it, see the linked issue)\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n\r\nsrc/node_platform\r\n\r\n~~CI: https://ci.nodejs.org/job/node-test-commit/14146/~~\r\nCI: https://ci.nodejs.org/job/node-test-commit/14147/","created_at":"2017-11-19T13:42:12Z","updated_at":"2017-11-20T13:06:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"546ddcf84925c3f8f33d6f4e603d5be4520b6842","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/17134/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/17134/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17134/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/5a3abae9542605ed297e2142220e941f70d1d897","head":{"label":"addaleax:fix-platform","ref":"fix-platform","sha":"5a3abae9542605ed297e2142220e941f70d1d897","user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"repo":{"id":47707342,"name":"node","full_name":"addaleax/node","owner":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/addaleax/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/addaleax/node","forks_url":"https://api.github.com/repos/addaleax/node/forks","keys_url":"https://api.github.com/repos/addaleax/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addaleax/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addaleax/node/teams","hooks_url":"https://api.github.com/repos/addaleax/node/hooks","issue_events_url":"https://api.github.com/repos/addaleax/node/issues/events{/number}","events_url":"https://api.github.com/repos/addaleax/node/events","assignees_url":"https://api.github.com/repos/addaleax/node/assignees{/user}","branches_url":"https://api.github.com/repos/addaleax/node/branches{/branch}","tags_url":"https://api.github.com/repos/addaleax/node/tags","blobs_url":"https://api.github.com/repos/addaleax/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addaleax/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addaleax/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/addaleax/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addaleax/node/statuses/{sha}","languages_url":"https://api.github.com/repos/addaleax/node/languages","stargazers_url":"https://api.github.com/repos/addaleax/node/stargazers","contributors_url":"https://api.github.com/repos/addaleax/node/contributors","subscribers_url":"https://api.github.com/repos/addaleax/node/subscribers","subscription_url":"https://api.github.com/repos/addaleax/node/subscription","commits_url":"https://api.github.com/repos/addaleax/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/addaleax/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/addaleax/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/addaleax/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/addaleax/node/contents/{+path}","compare_url":"https://api.github.com/repos/addaleax/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addaleax/node/merges","archive_url":"https://api.github.com/repos/addaleax/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addaleax/node/downloads","issues_url":"https://api.github.com/repos/addaleax/node/issues{/number}","pulls_url":"https://api.github.com/repos/addaleax/node/pulls{/number}","milestones_url":"https://api.github.com/repos/addaleax/node/milestones{/number}","notifications_url":"https://api.github.com/repos/addaleax/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addaleax/node/labels{/name}","releases_url":"https://api.github.com/repos/addaleax/node/releases{/id}","deployments_url":"https://api.github.com/repos/addaleax/node/deployments","created_at":"2015-12-09T17:26:30Z","updated_at":"2016-03-24T02:52:12Z","pushed_at":"2017-11-20T12:03:53Z","git_url":"git://github.com/addaleax/node.git","ssh_url":"git@github.com:addaleax/node.git","clone_url":"https://github.com/addaleax/node.git","svn_url":"https://github.com/addaleax/node","homepage":"https://nodejs.org","size":319188,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"d61cd9d4fe4c434d689ae0553df24d538993f06b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-11-20T13:06:09Z","pushed_at":"2017-11-20T12:03:59Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":333874,"stargazers_count":42515,"watchers_count":42515,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8838,"mirror_url":null,"archived":false,"open_issues_count":801,"forks":8838,"open_issues":801,"watchers":42515,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/17134"},"html":{"href":"https://github.com/nodejs/node/pull/17134"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/17134"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/17134/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/17134/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/17134/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/5a3abae9542605ed297e2142220e941f70d1d897"}},"author_association":"OWNER"}}
|
{
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
}
|
{
"id": 275871,
"login": "bnoordhuis",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/275871?",
"url": "https://api.github.com/users/bnoordhuis"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2017-11-20T13:02:31 |
6878738423
|
{"actor":{"display_login":"bnoordhuis"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/105244088","pull_request_review_id":26114774,"id":105244088,"diff_hunk":"@@ -172,6 +167,11 @@ dns.lookupService('127.0.0.1', 22, (err, hostname, service) => {\n <!-- YAML\n added: v0.1.27\n -->\n+- `hostname` {string}\n+- `rrtype` {string}\n+- `callback(err, addresses)` {Function}\n+ - `err` {Error}\n+ - `addresses` {Array}","path":"doc/api/dns.md","position":84,"original_position":84,"commit_id":"afaf20654b6d20e65739024c54fb4743014f2260","original_commit_id":"afaf20654b6d20e65739024c54fb4743014f2260","user":{"login":"ameliavoncat","id":19511039,"avatar_url":"https://avatars3.githubusercontent.com/u/19511039?v=3","gravatar_id":"","url":"https://api.github.com/users/ameliavoncat","html_url":"https://github.com/ameliavoncat","followers_url":"https://api.github.com/users/ameliavoncat/followers","following_url":"https://api.github.com/users/ameliavoncat/following{/other_user}","gists_url":"https://api.github.com/users/ameliavoncat/gists{/gist_id}","starred_url":"https://api.github.com/users/ameliavoncat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameliavoncat/subscriptions","organizations_url":"https://api.github.com/users/ameliavoncat/orgs","repos_url":"https://api.github.com/users/ameliavoncat/repos","events_url":"https://api.github.com/users/ameliavoncat/events{/privacy}","received_events_url":"https://api.github.com/users/ameliavoncat/received_events","type":"User","site_admin":false},"body":"The type of the contents of this array depend on `rrtype`","created_at":"2017-03-09T19:03:43Z","updated_at":"2017-03-09T19:03:43Z","html_url":"https://github.com/nodejs/node/pull/11764#discussion_r105244088","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/11764","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/105244088"},"html":{"href":"https://github.com/nodejs/node/pull/11764#discussion_r105244088"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/11764"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/11764","id":109844541,"html_url":"https://github.com/nodejs/node/pull/11764","diff_url":"https://github.com/nodejs/node/pull/11764.diff","patch_url":"https://github.com/nodejs/node/pull/11764.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/11764","number":11764,"state":"open","locked":false,"title":"doc: argument types for dns methods","user":{"login":"ameliavoncat","id":19511039,"avatar_url":"https://avatars3.githubusercontent.com/u/19511039?v=3","gravatar_id":"","url":"https://api.github.com/users/ameliavoncat","html_url":"https://github.com/ameliavoncat","followers_url":"https://api.github.com/users/ameliavoncat/followers","following_url":"https://api.github.com/users/ameliavoncat/following{/other_user}","gists_url":"https://api.github.com/users/ameliavoncat/gists{/gist_id}","starred_url":"https://api.github.com/users/ameliavoncat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameliavoncat/subscriptions","organizations_url":"https://api.github.com/users/ameliavoncat/orgs","repos_url":"https://api.github.com/users/ameliavoncat/repos","events_url":"https://api.github.com/users/ameliavoncat/events{/privacy}","received_events_url":"https://api.github.com/users/ameliavoncat/received_events","type":"User","site_admin":false},"body":"##### Checklist\r\n- [x] documentation is changed or added\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ndocumentation\r\n\r\n##### Description of changes\r\nAdds argument data types to the docs for `dns` methods \r\n\r\n[Issue](https://github.com/nodejs/node/issues/9399)","created_at":"2017-03-09T05:45:17Z","updated_at":"2017-03-09T19:03:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc501246978379356d2bfad5e8e9ed9fac290a9d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/11764/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/11764/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/11764/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/afaf20654b6d20e65739024c54fb4743014f2260","head":{"label":"ameliavoncat:argument-types-for-dns","ref":"argument-types-for-dns","sha":"afaf20654b6d20e65739024c54fb4743014f2260","user":{"login":"ameliavoncat","id":19511039,"avatar_url":"https://avatars3.githubusercontent.com/u/19511039?v=3","gravatar_id":"","url":"https://api.github.com/users/ameliavoncat","html_url":"https://github.com/ameliavoncat","followers_url":"https://api.github.com/users/ameliavoncat/followers","following_url":"https://api.github.com/users/ameliavoncat/following{/other_user}","gists_url":"https://api.github.com/users/ameliavoncat/gists{/gist_id}","starred_url":"https://api.github.com/users/ameliavoncat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameliavoncat/subscriptions","organizations_url":"https://api.github.com/users/ameliavoncat/orgs","repos_url":"https://api.github.com/users/ameliavoncat/repos","events_url":"https://api.github.com/users/ameliavoncat/events{/privacy}","received_events_url":"https://api.github.com/users/ameliavoncat/received_events","type":"User","site_admin":false},"repo":{"id":82964154,"name":"node","full_name":"ameliavoncat/node","owner":{"login":"ameliavoncat","id":19511039,"avatar_url":"https://avatars3.githubusercontent.com/u/19511039?v=3","gravatar_id":"","url":"https://api.github.com/users/ameliavoncat","html_url":"https://github.com/ameliavoncat","followers_url":"https://api.github.com/users/ameliavoncat/followers","following_url":"https://api.github.com/users/ameliavoncat/following{/other_user}","gists_url":"https://api.github.com/users/ameliavoncat/gists{/gist_id}","starred_url":"https://api.github.com/users/ameliavoncat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ameliavoncat/subscriptions","organizations_url":"https://api.github.com/users/ameliavoncat/orgs","repos_url":"https://api.github.com/users/ameliavoncat/repos","events_url":"https://api.github.com/users/ameliavoncat/events{/privacy}","received_events_url":"https://api.github.com/users/ameliavoncat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ameliavoncat/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/ameliavoncat/node","forks_url":"https://api.github.com/repos/ameliavoncat/node/forks","keys_url":"https://api.github.com/repos/ameliavoncat/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ameliavoncat/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ameliavoncat/node/teams","hooks_url":"https://api.github.com/repos/ameliavoncat/node/hooks","issue_events_url":"https://api.github.com/repos/ameliavoncat/node/issues/events{/number}","events_url":"https://api.github.com/repos/ameliavoncat/node/events","assignees_url":"https://api.github.com/repos/ameliavoncat/node/assignees{/user}","branches_url":"https://api.github.com/repos/ameliavoncat/node/branches{/branch}","tags_url":"https://api.github.com/repos/ameliavoncat/node/tags","blobs_url":"https://api.github.com/repos/ameliavoncat/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ameliavoncat/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ameliavoncat/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ameliavoncat/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ameliavoncat/node/statuses/{sha}","languages_url":"https://api.github.com/repos/ameliavoncat/node/languages","stargazers_url":"https://api.github.com/repos/ameliavoncat/node/stargazers","contributors_url":"https://api.github.com/repos/ameliavoncat/node/contributors","subscribers_url":"https://api.github.com/repos/ameliavoncat/node/subscribers","subscription_url":"https://api.github.com/repos/ameliavoncat/node/subscription","commits_url":"https://api.github.com/repos/ameliavoncat/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ameliavoncat/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ameliavoncat/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ameliavoncat/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ameliavoncat/node/contents/{+path}","compare_url":"https://api.github.com/repos/ameliavoncat/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ameliavoncat/node/merges","archive_url":"https://api.github.com/repos/ameliavoncat/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ameliavoncat/node/downloads","issues_url":"https://api.github.com/repos/ameliavoncat/node/issues{/number}","pulls_url":"https://api.github.com/repos/ameliavoncat/node/pulls{/number}","milestones_url":"https://api.github.com/repos/ameliavoncat/node/milestones{/number}","notifications_url":"https://api.github.com/repos/ameliavoncat/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ameliavoncat/node/labels{/name}","releases_url":"https://api.github.com/repos/ameliavoncat/node/releases{/id}","deployments_url":"https://api.github.com/repos/ameliavoncat/node/deployments","created_at":"2017-02-23T19:38:15Z","updated_at":"2017-02-23T19:38:41Z","pushed_at":"2017-03-09T17:23:23Z","git_url":"git://github.com/ameliavoncat/node.git","ssh_url":"git@github.com:ameliavoncat/node.git","clone_url":"https://github.com/ameliavoncat/node.git","svn_url":"https://github.com/ameliavoncat/node","homepage":"https://nodejs.org","size":268823,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e4fbd8e244cafa4bbb76aeac52c96941156f61d6","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-03-09T18:58:28Z","pushed_at":"2017-03-09T18:32:28Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":270288,"stargazers_count":32532,"watchers_count":32532,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6112,"mirror_url":null,"open_issues_count":1030,"forks":6112,"open_issues":1030,"watchers":32532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/11764"},"html":{"href":"https://github.com/nodejs/node/pull/11764"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/11764"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/11764/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/11764/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/11764/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/afaf20654b6d20e65739024c54fb4743014f2260"}}}}
|
{
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
}
|
{
"id": 19511039,
"login": "ameliavoncat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19511039?",
"url": "https://api.github.com/users/ameliavoncat"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2017-03-09T19:03:43 |
5465277587
|
{"actor":{"display_login":"ameliavoncat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/129552364","pull_request_review_id":52336196,"id":129552364,"diff_hunk":"@@ -617,10 +637,29 @@ AsyncWrap::AsyncWrap(Environment* env,\n \n // Use AsyncReset() call to execute the init() callbacks.\n AsyncReset(silent);\n+\n+ switch (provider_type()) {\n+#define V(PROVIDER) \\\n+ case PROVIDER_ ## PROVIDER: \\\n+ TRACE_EVENT_NESTABLE_ASYNC_BEGIN0(\"node\", #PROVIDER, \\\n+ static_cast<int64_t>(get_id())); \\\n+ break;\n+ NODE_ASYNC_PROVIDER_TYPES(V)\n+#undef V\n+ }\n }\n \n \n AsyncWrap::~AsyncWrap() {\n+ switch (provider_type()) {\n+#define V(PROVIDER) \\","path":"src/async-wrap.cc","position":53,"original_position":53,"commit_id":"fab7b78b07319453bc8d0161fe30f7a47afa17c9","original_commit_id":"b7ab86582f0ff73187a11cfd019721dabe9c4aaa","user":{"login":"trevnorris","id":289174,"avatar_url":"https://avatars1.githubusercontent.com/u/289174?v=4","gravatar_id":"","url":"https://api.github.com/users/trevnorris","html_url":"https://github.com/trevnorris","followers_url":"https://api.github.com/users/trevnorris/followers","following_url":"https://api.github.com/users/trevnorris/following{/other_user}","gists_url":"https://api.github.com/users/trevnorris/gists{/gist_id}","starred_url":"https://api.github.com/users/trevnorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevnorris/subscriptions","organizations_url":"https://api.github.com/users/trevnorris/orgs","repos_url":"https://api.github.com/users/trevnorris/repos","events_url":"https://api.github.com/users/trevnorris/events{/privacy}","received_events_url":"https://api.github.com/users/trevnorris/received_events","type":"User","site_admin":false},"body":"> Just to make sure I understand, currently, no trace events will be reported for httpparser\r\n\r\nYou will get an `init()` every time an http `node::Parser` is initialized, and you'll get `before()`/`after()` for that one as well, but you won't get a `destroy()` for that parser if it's placed in the `freeParser()` pool.\r\n\r\nWhen the `Parser` is reused a new `async_id` is assigned, then you'll get a `before()`/`after()` call for the `async_id` that hasn't had `init()` called yet. Creating a broken call graph.\r\n\r\nThe `init()` call can be fixed by placing `TRACE_EVENT_NESTABLE_ASYNC_BEGIN0` in `node::Parser::Reinitialize()`, but there's no way to track when the `node::Parser` instance has been placed in the pool from C++. So it would require a JS call.\r\n\r\nThe `freeParser()` code path isn't hot, so it's not unreasonable to put a JS call in there to notify C++ that the parser is done and it can emit `destroy()`.","created_at":"2017-07-26T12:03:33Z","updated_at":"2017-07-26T12:03:33Z","html_url":"https://github.com/nodejs/node/pull/14347#discussion_r129552364","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14347","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/129552364"},"html":{"href":"https://github.com/nodejs/node/pull/14347#discussion_r129552364"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14347"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14347","id":131149206,"html_url":"https://github.com/nodejs/node/pull/14347","diff_url":"https://github.com/nodejs/node/pull/14347.diff","patch_url":"https://github.com/nodejs/node/pull/14347.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14347","number":14347,"state":"open","locked":false,"title":"async-hooks: add trace events to AsyncWrap","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"body":"This will allow trace event to record timing information for all\r\nasynchronous operations that are observed by AsyncWrap.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nasync-hooks, tracing","created_at":"2017-07-18T17:53:34Z","updated_at":"2017-07-26T12:03:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c4e0fe19a1894aba7beea6f5fcd260d19110c9c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"AndreasMadsen","id":505333,"avatar_url":"https://avatars0.githubusercontent.com/u/505333?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreasMadsen","html_url":"https://github.com/AndreasMadsen","followers_url":"https://api.github.com/users/AndreasMadsen/followers","following_url":"https://api.github.com/users/AndreasMadsen/following{/other_user}","gists_url":"https://api.github.com/users/AndreasMadsen/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreasMadsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreasMadsen/subscriptions","organizations_url":"https://api.github.com/users/AndreasMadsen/orgs","repos_url":"https://api.github.com/users/AndreasMadsen/repos","events_url":"https://api.github.com/users/AndreasMadsen/events{/privacy}","received_events_url":"https://api.github.com/users/AndreasMadsen/received_events","type":"User","site_admin":false},{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14347/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14347/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14347/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/fab7b78b07319453bc8d0161fe30f7a47afa17c9","head":{"label":"matthewloring:trace-inst","ref":"trace-inst","sha":"fab7b78b07319453bc8d0161fe30f7a47afa17c9","user":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"repo":{"id":38261750,"name":"node","full_name":"matthewloring/node","owner":{"login":"matthewloring","id":1485909,"avatar_url":"https://avatars3.githubusercontent.com/u/1485909?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewloring","html_url":"https://github.com/matthewloring","followers_url":"https://api.github.com/users/matthewloring/followers","following_url":"https://api.github.com/users/matthewloring/following{/other_user}","gists_url":"https://api.github.com/users/matthewloring/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewloring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewloring/subscriptions","organizations_url":"https://api.github.com/users/matthewloring/orgs","repos_url":"https://api.github.com/users/matthewloring/repos","events_url":"https://api.github.com/users/matthewloring/events{/privacy}","received_events_url":"https://api.github.com/users/matthewloring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewloring/node","description":"Node.js JavaScript runtime ✨🐢🚀✨","fork":true,"url":"https://api.github.com/repos/matthewloring/node","forks_url":"https://api.github.com/repos/matthewloring/node/forks","keys_url":"https://api.github.com/repos/matthewloring/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewloring/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewloring/node/teams","hooks_url":"https://api.github.com/repos/matthewloring/node/hooks","issue_events_url":"https://api.github.com/repos/matthewloring/node/issues/events{/number}","events_url":"https://api.github.com/repos/matthewloring/node/events","assignees_url":"https://api.github.com/repos/matthewloring/node/assignees{/user}","branches_url":"https://api.github.com/repos/matthewloring/node/branches{/branch}","tags_url":"https://api.github.com/repos/matthewloring/node/tags","blobs_url":"https://api.github.com/repos/matthewloring/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewloring/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewloring/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewloring/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewloring/node/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewloring/node/languages","stargazers_url":"https://api.github.com/repos/matthewloring/node/stargazers","contributors_url":"https://api.github.com/repos/matthewloring/node/contributors","subscribers_url":"https://api.github.com/repos/matthewloring/node/subscribers","subscription_url":"https://api.github.com/repos/matthewloring/node/subscription","commits_url":"https://api.github.com/repos/matthewloring/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewloring/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewloring/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewloring/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewloring/node/contents/{+path}","compare_url":"https://api.github.com/repos/matthewloring/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewloring/node/merges","archive_url":"https://api.github.com/repos/matthewloring/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewloring/node/downloads","issues_url":"https://api.github.com/repos/matthewloring/node/issues{/number}","pulls_url":"https://api.github.com/repos/matthewloring/node/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewloring/node/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewloring/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewloring/node/labels{/name}","releases_url":"https://api.github.com/repos/matthewloring/node/releases{/id}","deployments_url":"https://api.github.com/repos/matthewloring/node/deployments","created_at":"2015-06-29T17:49:00Z","updated_at":"2016-10-26T16:46:47Z","pushed_at":"2017-07-25T18:08:55Z","git_url":"git://github.com/matthewloring/node.git","ssh_url":"git@github.com:matthewloring/node.git","clone_url":"https://github.com/matthewloring/node.git","svn_url":"https://github.com/matthewloring/node","homepage":"https://nodejs.org","size":278384,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ac8126749cc643cf4ec73a41fddd8e10b55fd77c","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-07-26T10:53:59Z","pushed_at":"2017-07-26T12:03:15Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":300848,"stargazers_count":37430,"watchers_count":37430,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7368,"mirror_url":null,"open_issues_count":944,"forks":7368,"open_issues":944,"watchers":37430,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14347"},"html":{"href":"https://github.com/nodejs/node/pull/14347"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14347"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14347/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14347/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14347/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/fab7b78b07319453bc8d0161fe30f7a47afa17c9"}}}}
|
{
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
}
|
{
"id": 289174,
"login": "trevnorris",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/289174?",
"url": "https://api.github.com/users/trevnorris"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2017-07-26T12:03:33 |
6332200215
|
{"actor":{"display_login":"trevnorris"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments/150842502","pull_request_review_id":76451641,"id":150842502,"diff_hunk":"@@ -77,6 +77,66 @@ class ExternalData {\n }\n };\n \n+struct SetterGetterInterceptor\n+{\n+ NamedPropertyGetterCallback namedPropertyGetter;\n+ NamedPropertySetterCallback namedPropertySetter;\n+ NamedPropertyQueryCallback namedPropertyQuery;\n+ NamedPropertyDeleterCallback namedPropertyDeleter;\n+ NamedPropertyEnumeratorCallback namedPropertyEnumerator;\n+ NamedPropertyDefinerCallback namedPropertyDefiner;\n+ NamedPropertyDescriptorCallback namedPropertyDescriptor;\n+ Persistent<Value> namedPropertyInterceptorData;\n+ IndexedPropertyGetterCallback indexedPropertyGetter;\n+ IndexedPropertySetterCallback indexedPropertySetter;\n+ IndexedPropertyQueryCallback indexedPropertyQuery;\n+ IndexedPropertyDeleterCallback indexedPropertyDeleter;\n+ IndexedPropertyEnumeratorCallback indexedPropertyEnumerator;\n+ IndexedPropertyDefinerCallback indexedPropertyDefiner;\n+ IndexedPropertyDescriptorCallback indexedPropertyDescriptor;\n+ Persistent<Value> indexedPropertyInterceptorData;\n+\n+ SetterGetterInterceptor(SetterGetterInterceptor * setterGetterInterceptor):\n+ namedPropertyGetter(setterGetterInterceptor->namedPropertyGetter),\n+ namedPropertySetter(setterGetterInterceptor->namedPropertySetter),\n+ namedPropertyQuery(setterGetterInterceptor->namedPropertyQuery),\n+ namedPropertyDeleter(setterGetterInterceptor->namedPropertyDeleter),\n+ namedPropertyEnumerator(setterGetterInterceptor->namedPropertyEnumerator),\n+ namedPropertyDefiner(setterGetterInterceptor->namedPropertyDefiner),\n+ namedPropertyDescriptor(setterGetterInterceptor->namedPropertyDescriptor),\n+ namedPropertyInterceptorData(\n+ nullptr, setterGetterInterceptor->namedPropertyInterceptorData),\n+ indexedPropertyGetter(setterGetterInterceptor->indexedPropertyGetter),\n+ indexedPropertySetter(setterGetterInterceptor->indexedPropertySetter),\n+ indexedPropertyQuery(setterGetterInterceptor->indexedPropertyQuery),\n+ indexedPropertyDeleter(setterGetterInterceptor->indexedPropertyDeleter),\n+ indexedPropertyEnumerator(setterGetterInterceptor->indexedPropertyEnumerator),\n+ indexedPropertyDefiner(setterGetterInterceptor->indexedPropertyDefiner),\n+ indexedPropertyDescriptor(setterGetterInterceptor->indexedPropertyDescriptor),\n+ indexedPropertyInterceptorData(nullptr, setterGetterInterceptor->indexedPropertyInterceptorData)","path":"deps/chakrashim/src/v8chakra.h","position":null,"original_position":40,"commit_id":"73fb87dd86146d91a1be4bd26ab426ba1ae5b7b9","original_commit_id":"2c5ac4c93513df9aae54c984bd37e6b84ce1f9ba","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars1.githubusercontent.com/u/4390745?v=4","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-11-14T14:11:39Z","updated_at":"2017-11-14T14:11:39Z","html_url":"https://github.com/nodejs/node-chakracore/pull/424#discussion_r150842502","pull_request_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments/150842502"},"html":{"href":"https://github.com/nodejs/node-chakracore/pull/424#discussion_r150842502"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424"}},"in_reply_to_id":150651248},"pull_request":{"url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424","id":152309385,"html_url":"https://github.com/nodejs/node-chakracore/pull/424","diff_url":"https://github.com/nodejs/node-chakracore/pull/424.diff","patch_url":"https://github.com/nodejs/node-chakracore/pull/424.patch","issue_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/424","number":424,"state":"open","locked":false,"title":"chakrashim: ObjectTemplate, allocate interceptor stuff lazily","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars1.githubusercontent.com/u/4390745?v=4","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"body":"Interceptor related stuff is rarely used (i.e. 0 per each acme request), yet, consumes 144 extra bytes per each ObjectTemplate allocation.\r\n","created_at":"2017-11-13T18:13:58Z","updated_at":"2017-11-14T14:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4775c954f0107c0c4857292b99bd9128abef64cd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424/commits","review_comments_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424/comments","review_comment_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/424/comments","statuses_url":"https://api.github.com/repos/nodejs/node-chakracore/statuses/73fb87dd86146d91a1be4bd26ab426ba1ae5b7b9","head":{"label":"obastemur:imp_ot_mem","ref":"imp_ot_mem","sha":"73fb87dd86146d91a1be4bd26ab426ba1ae5b7b9","user":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars1.githubusercontent.com/u/4390745?v=4","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"repo":{"id":109764378,"name":"node-chakracore","full_name":"obastemur/node-chakracore","owner":{"login":"obastemur","id":4390745,"avatar_url":"https://avatars1.githubusercontent.com/u/4390745?v=4","gravatar_id":"","url":"https://api.github.com/users/obastemur","html_url":"https://github.com/obastemur","followers_url":"https://api.github.com/users/obastemur/followers","following_url":"https://api.github.com/users/obastemur/following{/other_user}","gists_url":"https://api.github.com/users/obastemur/gists{/gist_id}","starred_url":"https://api.github.com/users/obastemur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obastemur/subscriptions","organizations_url":"https://api.github.com/users/obastemur/orgs","repos_url":"https://api.github.com/users/obastemur/repos","events_url":"https://api.github.com/users/obastemur/events{/privacy}","received_events_url":"https://api.github.com/users/obastemur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obastemur/node-chakracore","description":"Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/obastemur/node-chakracore","forks_url":"https://api.github.com/repos/obastemur/node-chakracore/forks","keys_url":"https://api.github.com/repos/obastemur/node-chakracore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obastemur/node-chakracore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obastemur/node-chakracore/teams","hooks_url":"https://api.github.com/repos/obastemur/node-chakracore/hooks","issue_events_url":"https://api.github.com/repos/obastemur/node-chakracore/issues/events{/number}","events_url":"https://api.github.com/repos/obastemur/node-chakracore/events","assignees_url":"https://api.github.com/repos/obastemur/node-chakracore/assignees{/user}","branches_url":"https://api.github.com/repos/obastemur/node-chakracore/branches{/branch}","tags_url":"https://api.github.com/repos/obastemur/node-chakracore/tags","blobs_url":"https://api.github.com/repos/obastemur/node-chakracore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obastemur/node-chakracore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obastemur/node-chakracore/git/refs{/sha}","trees_url":"https://api.github.com/repos/obastemur/node-chakracore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obastemur/node-chakracore/statuses/{sha}","languages_url":"https://api.github.com/repos/obastemur/node-chakracore/languages","stargazers_url":"https://api.github.com/repos/obastemur/node-chakracore/stargazers","contributors_url":"https://api.github.com/repos/obastemur/node-chakracore/contributors","subscribers_url":"https://api.github.com/repos/obastemur/node-chakracore/subscribers","subscription_url":"https://api.github.com/repos/obastemur/node-chakracore/subscription","commits_url":"https://api.github.com/repos/obastemur/node-chakracore/commits{/sha}","git_commits_url":"https://api.github.com/repos/obastemur/node-chakracore/git/commits{/sha}","comments_url":"https://api.github.com/repos/obastemur/node-chakracore/comments{/number}","issue_comment_url":"https://api.github.com/repos/obastemur/node-chakracore/issues/comments{/number}","contents_url":"https://api.github.com/repos/obastemur/node-chakracore/contents/{+path}","compare_url":"https://api.github.com/repos/obastemur/node-chakracore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obastemur/node-chakracore/merges","archive_url":"https://api.github.com/repos/obastemur/node-chakracore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obastemur/node-chakracore/downloads","issues_url":"https://api.github.com/repos/obastemur/node-chakracore/issues{/number}","pulls_url":"https://api.github.com/repos/obastemur/node-chakracore/pulls{/number}","milestones_url":"https://api.github.com/repos/obastemur/node-chakracore/milestones{/number}","notifications_url":"https://api.github.com/repos/obastemur/node-chakracore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obastemur/node-chakracore/labels{/name}","releases_url":"https://api.github.com/repos/obastemur/node-chakracore/releases{/id}","deployments_url":"https://api.github.com/repos/obastemur/node-chakracore/deployments","created_at":"2017-11-07T00:02:21Z","updated_at":"2017-11-07T00:02:29Z","pushed_at":"2017-11-14T14:11:16Z","git_url":"git://github.com/obastemur/node-chakracore.git","ssh_url":"git@github.com:obastemur/node-chakracore.git","clone_url":"https://github.com/obastemur/node-chakracore.git","svn_url":"https://github.com/obastemur/node-chakracore","homepage":"","size":302816,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"c6863c08c69f8f2dfd6d25cc2e63615aab90ab5b","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":46881155,"name":"node-chakracore","full_name":"nodejs/node-chakracore","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node-chakracore","description":"Node.js on ChakraCore :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node-chakracore","forks_url":"https://api.github.com/repos/nodejs/node-chakracore/forks","keys_url":"https://api.github.com/repos/nodejs/node-chakracore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node-chakracore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node-chakracore/teams","hooks_url":"https://api.github.com/repos/nodejs/node-chakracore/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node-chakracore/events","assignees_url":"https://api.github.com/repos/nodejs/node-chakracore/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node-chakracore/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node-chakracore/tags","blobs_url":"https://api.github.com/repos/nodejs/node-chakracore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node-chakracore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node-chakracore/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node-chakracore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node-chakracore/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node-chakracore/languages","stargazers_url":"https://api.github.com/repos/nodejs/node-chakracore/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node-chakracore/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node-chakracore/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node-chakracore/subscription","commits_url":"https://api.github.com/repos/nodejs/node-chakracore/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node-chakracore/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node-chakracore/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node-chakracore/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node-chakracore/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node-chakracore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node-chakracore/merges","archive_url":"https://api.github.com/repos/nodejs/node-chakracore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node-chakracore/downloads","issues_url":"https://api.github.com/repos/nodejs/node-chakracore/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node-chakracore/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node-chakracore/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node-chakracore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node-chakracore/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node-chakracore/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node-chakracore/deployments","created_at":"2015-11-25T19:09:26Z","updated_at":"2017-11-14T03:27:45Z","pushed_at":"2017-11-14T14:11:18Z","git_url":"git://github.com/nodejs/node-chakracore.git","ssh_url":"git@github.com:nodejs/node-chakracore.git","clone_url":"https://github.com/nodejs/node-chakracore.git","svn_url":"https://github.com/nodejs/node-chakracore","homepage":"","size":293496,"stargazers_count":1314,"watchers_count":1314,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":62,"forks":142,"open_issues":62,"watchers":1314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424"},"html":{"href":"https://github.com/nodejs/node-chakracore/pull/424"},"issue":{"href":"https://api.github.com/repos/nodejs/node-chakracore/issues/424"},"comments":{"href":"https://api.github.com/repos/nodejs/node-chakracore/issues/424/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node-chakracore/pulls/424/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node-chakracore/statuses/73fb87dd86146d91a1be4bd26ab426ba1ae5b7b9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 46881155,
"name": "nodejs/node-chakracore",
"url": "https://api.github.com/repos/nodejs/node-chakracore"
}
|
{
"id": 4390745,
"login": "obastemur",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4390745?",
"url": "https://api.github.com/users/obastemur"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2017-11-14T14:11:39 |
6852878060
|
{"actor":{"display_login":"obastemur"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/127838973","pull_request_review_id":50462375,"id":127838973,"diff_hunk":"@@ -382,9 +381,9 @@ changes:\n * `uid` {number} Sets the user identity of the process. (See setuid(2).)\n * `gid` {number} Sets the group identity of the process. (See setgid(2).)\n * `shell` {boolean|string} If `true`, runs `command` inside of a shell. Uses\n- `'/bin/sh'` on UNIX, and `'cmd.exe'` on Windows. A different shell can be\n- specified as a string. The shell should understand the `-c` switch on UNIX,\n- or `/d /s /c` on Windows. Defaults to `false` (no shell).\n+ `'/bin/sh'` on UNIX, and `'process.env.ComSpec'` on Windows. A different ","path":"doc/api/child_process.md","position":25,"original_position":25,"commit_id":"33adbeb3dfae46e1dee3f89ef872ddd0bdcbdf57","original_commit_id":"33adbeb3dfae46e1dee3f89ef872ddd0bdcbdf57","user":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2017-07-17T22:08:06Z","updated_at":"2017-07-17T22:13:46Z","html_url":"https://github.com/nodejs/node/pull/14203#discussion_r127838973","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14203","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/127838973"},"html":{"href":"https://github.com/nodejs/node/pull/14203#discussion_r127838973"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14203"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14203","id":130217815,"html_url":"https://github.com/nodejs/node/pull/14203","diff_url":"https://github.com/nodejs/node/pull/14203.diff","patch_url":"https://github.com/nodejs/node/pull/14203.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14203","number":14203,"state":"open","locked":false,"title":"doc: fixes default shell in child_process.md","user":{"login":"henryzxu","id":23414112,"avatar_url":"https://avatars0.githubusercontent.com/u/23414112?v=4","gravatar_id":"","url":"https://api.github.com/users/henryzxu","html_url":"https://github.com/henryzxu","followers_url":"https://api.github.com/users/henryzxu/followers","following_url":"https://api.github.com/users/henryzxu/following{/other_user}","gists_url":"https://api.github.com/users/henryzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/henryzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryzxu/subscriptions","organizations_url":"https://api.github.com/users/henryzxu/orgs","repos_url":"https://api.github.com/users/henryzxu/repos","events_url":"https://api.github.com/users/henryzxu/events{/privacy}","received_events_url":"https://api.github.com/users/henryzxu/received_events","type":"User","site_admin":false},"body":"This PR clarifies that `'process.env.ComSpec'` is the default shell in \r\nWindows and that `'cmd.exe'` is only used as a fallback. \r\n\r\nFixes: https://github.com/nodejs/node/issues/14156\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndoc","created_at":"2017-07-12T19:30:19Z","updated_at":"2017-07-17T22:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e47572336786b579b13aa8def11cb0311c7a13d2","assignee":{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false},"assignees":[{"login":"tniessen","id":3109072,"avatar_url":"https://avatars3.githubusercontent.com/u/3109072?v=4","gravatar_id":"","url":"https://api.github.com/users/tniessen","html_url":"https://github.com/tniessen","followers_url":"https://api.github.com/users/tniessen/followers","following_url":"https://api.github.com/users/tniessen/following{/other_user}","gists_url":"https://api.github.com/users/tniessen/gists{/gist_id}","starred_url":"https://api.github.com/users/tniessen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tniessen/subscriptions","organizations_url":"https://api.github.com/users/tniessen/orgs","repos_url":"https://api.github.com/users/tniessen/repos","events_url":"https://api.github.com/users/tniessen/events{/privacy}","received_events_url":"https://api.github.com/users/tniessen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14203/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14203/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14203/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/33adbeb3dfae46e1dee3f89ef872ddd0bdcbdf57","head":{"label":"henryzxu:my-branch","ref":"my-branch","sha":"33adbeb3dfae46e1dee3f89ef872ddd0bdcbdf57","user":{"login":"henryzxu","id":23414112,"avatar_url":"https://avatars0.githubusercontent.com/u/23414112?v=4","gravatar_id":"","url":"https://api.github.com/users/henryzxu","html_url":"https://github.com/henryzxu","followers_url":"https://api.github.com/users/henryzxu/followers","following_url":"https://api.github.com/users/henryzxu/following{/other_user}","gists_url":"https://api.github.com/users/henryzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/henryzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryzxu/subscriptions","organizations_url":"https://api.github.com/users/henryzxu/orgs","repos_url":"https://api.github.com/users/henryzxu/repos","events_url":"https://api.github.com/users/henryzxu/events{/privacy}","received_events_url":"https://api.github.com/users/henryzxu/received_events","type":"User","site_admin":false},"repo":{"id":97040888,"name":"node","full_name":"henryzxu/node","owner":{"login":"henryzxu","id":23414112,"avatar_url":"https://avatars0.githubusercontent.com/u/23414112?v=4","gravatar_id":"","url":"https://api.github.com/users/henryzxu","html_url":"https://github.com/henryzxu","followers_url":"https://api.github.com/users/henryzxu/followers","following_url":"https://api.github.com/users/henryzxu/following{/other_user}","gists_url":"https://api.github.com/users/henryzxu/gists{/gist_id}","starred_url":"https://api.github.com/users/henryzxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henryzxu/subscriptions","organizations_url":"https://api.github.com/users/henryzxu/orgs","repos_url":"https://api.github.com/users/henryzxu/repos","events_url":"https://api.github.com/users/henryzxu/events{/privacy}","received_events_url":"https://api.github.com/users/henryzxu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henryzxu/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/henryzxu/node","forks_url":"https://api.github.com/repos/henryzxu/node/forks","keys_url":"https://api.github.com/repos/henryzxu/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henryzxu/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henryzxu/node/teams","hooks_url":"https://api.github.com/repos/henryzxu/node/hooks","issue_events_url":"https://api.github.com/repos/henryzxu/node/issues/events{/number}","events_url":"https://api.github.com/repos/henryzxu/node/events","assignees_url":"https://api.github.com/repos/henryzxu/node/assignees{/user}","branches_url":"https://api.github.com/repos/henryzxu/node/branches{/branch}","tags_url":"https://api.github.com/repos/henryzxu/node/tags","blobs_url":"https://api.github.com/repos/henryzxu/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henryzxu/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henryzxu/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/henryzxu/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henryzxu/node/statuses/{sha}","languages_url":"https://api.github.com/repos/henryzxu/node/languages","stargazers_url":"https://api.github.com/repos/henryzxu/node/stargazers","contributors_url":"https://api.github.com/repos/henryzxu/node/contributors","subscribers_url":"https://api.github.com/repos/henryzxu/node/subscribers","subscription_url":"https://api.github.com/repos/henryzxu/node/subscription","commits_url":"https://api.github.com/repos/henryzxu/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/henryzxu/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/henryzxu/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/henryzxu/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/henryzxu/node/contents/{+path}","compare_url":"https://api.github.com/repos/henryzxu/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henryzxu/node/merges","archive_url":"https://api.github.com/repos/henryzxu/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henryzxu/node/downloads","issues_url":"https://api.github.com/repos/henryzxu/node/issues{/number}","pulls_url":"https://api.github.com/repos/henryzxu/node/pulls{/number}","milestones_url":"https://api.github.com/repos/henryzxu/node/milestones{/number}","notifications_url":"https://api.github.com/repos/henryzxu/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henryzxu/node/labels{/name}","releases_url":"https://api.github.com/repos/henryzxu/node/releases{/id}","deployments_url":"https://api.github.com/repos/henryzxu/node/deployments","created_at":"2017-07-12T18:37:50Z","updated_at":"2017-07-12T18:38:23Z","pushed_at":"2017-07-17T18:19:58Z","git_url":"git://github.com/henryzxu/node.git","ssh_url":"git@github.com:henryzxu/node.git","clone_url":"https://github.com/henryzxu/node.git","svn_url":"https://github.com/henryzxu/node","homepage":"https://nodejs.org","size":298373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"1562fb9ea7b993382a4aef0433a10b1029419f17","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-07-17T21:43:53Z","pushed_at":"2017-07-17T21:18:43Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":299856,"stargazers_count":37081,"watchers_count":37081,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7273,"mirror_url":null,"open_issues_count":945,"forks":7273,"open_issues":945,"watchers":37081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14203"},"html":{"href":"https://github.com/nodejs/node/pull/14203"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14203"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14203/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14203/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14203/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/33adbeb3dfae46e1dee3f89ef872ddd0bdcbdf57"}}}}
|
{
"id": 27193779,
"name": "nodejs/node",
"url": "https://api.github.com/repos/nodejs/node"
}
|
{
"id": 3109072,
"login": "tniessen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3109072?",
"url": "https://api.github.com/users/tniessen"
}
|
{
"id": 9950313,
"login": "nodejs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9950313?",
"url": "https://api.github.com/orgs/nodejs"
}
| 2017-07-17T22:08:06 |
6273408816
|
{"actor":{"display_login":"tniessen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nuclio/nuclio/pulls/comments/145619145","pull_request_review_id":70443903,"id":145619145,"diff_hunk":"@@ -89,12 +89,11 @@ func (aes *AbstractEventSource) AllocateWorkerAndSubmitEvent(event nuclio.Event,\n \n \t\treturn nil, errors.Wrap(err, \"Failed to allocate worker\"), nil\n \t}\n+\t// release worker when we're done","path":"pkg/processor/eventsource/eventsource.go","position":4,"original_position":4,"commit_id":"7a4e882d24be7d09a04c5e1b971f56004b19653c","original_commit_id":"7a4e882d24be7d09a04c5e1b971f56004b19653c","user":{"login":"pavius","id":423987,"avatar_url":"https://avatars2.githubusercontent.com/u/423987?v=4","gravatar_id":"","url":"https://api.github.com/users/pavius","html_url":"https://github.com/pavius","followers_url":"https://api.github.com/users/pavius/followers","following_url":"https://api.github.com/users/pavius/following{/other_user}","gists_url":"https://api.github.com/users/pavius/gists{/gist_id}","starred_url":"https://api.github.com/users/pavius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavius/subscriptions","organizations_url":"https://api.github.com/users/pavius/orgs","repos_url":"https://api.github.com/users/pavius/repos","events_url":"https://api.github.com/users/pavius/events{/privacy}","received_events_url":"https://api.github.com/users/pavius/received_events","type":"User","site_admin":false},"body":"`handleSubmitPanic` releases the worker :)","created_at":"2017-10-19T07:35:44Z","updated_at":"2017-10-19T07:35:45Z","html_url":"https://github.com/nuclio/nuclio/pull/273#discussion_r145619145","pull_request_url":"https://api.github.com/repos/nuclio/nuclio/pulls/273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/comments/145619145"},"html":{"href":"https://github.com/nuclio/nuclio/pull/273#discussion_r145619145"},"pull_request":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/273"}},"in_reply_to_id":145198241},"pull_request":{"url":"https://api.github.com/repos/nuclio/nuclio/pulls/273","id":147071871,"html_url":"https://github.com/nuclio/nuclio/pull/273","diff_url":"https://github.com/nuclio/nuclio/pull/273.diff","patch_url":"https://github.com/nuclio/nuclio/pull/273.patch","issue_url":"https://api.github.com/repos/nuclio/nuclio/issues/273","number":273,"state":"open","locked":false,"title":"HTTP handler panic","user":{"login":"tebeka","id":87697,"avatar_url":"https://avatars1.githubusercontent.com/u/87697?v=4","gravatar_id":"","url":"https://api.github.com/users/tebeka","html_url":"https://github.com/tebeka","followers_url":"https://api.github.com/users/tebeka/followers","following_url":"https://api.github.com/users/tebeka/following{/other_user}","gists_url":"https://api.github.com/users/tebeka/gists{/gist_id}","starred_url":"https://api.github.com/users/tebeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tebeka/subscriptions","organizations_url":"https://api.github.com/users/tebeka/orgs","repos_url":"https://api.github.com/users/tebeka/repos","events_url":"https://api.github.com/users/tebeka/events{/privacy}","received_events_url":"https://api.github.com/users/tebeka/received_events","type":"User","site_admin":false},"body":"Partial fix for #272 - No error in the golang test docker, still error in the python one","created_at":"2017-10-17T15:21:21Z","updated_at":"2017-10-19T07:35:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61ed593d9fb4fcac71ea3238450d92b35d54f560","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bivas","id":530883,"avatar_url":"https://avatars0.githubusercontent.com/u/530883?v=4","gravatar_id":"","url":"https://api.github.com/users/bivas","html_url":"https://github.com/bivas","followers_url":"https://api.github.com/users/bivas/followers","following_url":"https://api.github.com/users/bivas/following{/other_user}","gists_url":"https://api.github.com/users/bivas/gists{/gist_id}","starred_url":"https://api.github.com/users/bivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bivas/subscriptions","organizations_url":"https://api.github.com/users/bivas/orgs","repos_url":"https://api.github.com/users/bivas/repos","events_url":"https://api.github.com/users/bivas/events{/privacy}","received_events_url":"https://api.github.com/users/bivas/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nuclio/nuclio/pulls/273/commits","review_comments_url":"https://api.github.com/repos/nuclio/nuclio/pulls/273/comments","review_comment_url":"https://api.github.com/repos/nuclio/nuclio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuclio/nuclio/issues/273/comments","statuses_url":"https://api.github.com/repos/nuclio/nuclio/statuses/7a4e882d24be7d09a04c5e1b971f56004b19653c","head":{"label":"tebeka:http-handler-panic","ref":"http-handler-panic","sha":"7a4e882d24be7d09a04c5e1b971f56004b19653c","user":{"login":"tebeka","id":87697,"avatar_url":"https://avatars1.githubusercontent.com/u/87697?v=4","gravatar_id":"","url":"https://api.github.com/users/tebeka","html_url":"https://github.com/tebeka","followers_url":"https://api.github.com/users/tebeka/followers","following_url":"https://api.github.com/users/tebeka/following{/other_user}","gists_url":"https://api.github.com/users/tebeka/gists{/gist_id}","starred_url":"https://api.github.com/users/tebeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tebeka/subscriptions","organizations_url":"https://api.github.com/users/tebeka/orgs","repos_url":"https://api.github.com/users/tebeka/repos","events_url":"https://api.github.com/users/tebeka/events{/privacy}","received_events_url":"https://api.github.com/users/tebeka/received_events","type":"User","site_admin":false},"repo":{"id":100927455,"name":"nuclio","full_name":"tebeka/nuclio","owner":{"login":"tebeka","id":87697,"avatar_url":"https://avatars1.githubusercontent.com/u/87697?v=4","gravatar_id":"","url":"https://api.github.com/users/tebeka","html_url":"https://github.com/tebeka","followers_url":"https://api.github.com/users/tebeka/followers","following_url":"https://api.github.com/users/tebeka/following{/other_user}","gists_url":"https://api.github.com/users/tebeka/gists{/gist_id}","starred_url":"https://api.github.com/users/tebeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tebeka/subscriptions","organizations_url":"https://api.github.com/users/tebeka/orgs","repos_url":"https://api.github.com/users/tebeka/repos","events_url":"https://api.github.com/users/tebeka/events{/privacy}","received_events_url":"https://api.github.com/users/tebeka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tebeka/nuclio","description":"High-Performance Serverless event and data processing framework ","fork":true,"url":"https://api.github.com/repos/tebeka/nuclio","forks_url":"https://api.github.com/repos/tebeka/nuclio/forks","keys_url":"https://api.github.com/repos/tebeka/nuclio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tebeka/nuclio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tebeka/nuclio/teams","hooks_url":"https://api.github.com/repos/tebeka/nuclio/hooks","issue_events_url":"https://api.github.com/repos/tebeka/nuclio/issues/events{/number}","events_url":"https://api.github.com/repos/tebeka/nuclio/events","assignees_url":"https://api.github.com/repos/tebeka/nuclio/assignees{/user}","branches_url":"https://api.github.com/repos/tebeka/nuclio/branches{/branch}","tags_url":"https://api.github.com/repos/tebeka/nuclio/tags","blobs_url":"https://api.github.com/repos/tebeka/nuclio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tebeka/nuclio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tebeka/nuclio/git/refs{/sha}","trees_url":"https://api.github.com/repos/tebeka/nuclio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tebeka/nuclio/statuses/{sha}","languages_url":"https://api.github.com/repos/tebeka/nuclio/languages","stargazers_url":"https://api.github.com/repos/tebeka/nuclio/stargazers","contributors_url":"https://api.github.com/repos/tebeka/nuclio/contributors","subscribers_url":"https://api.github.com/repos/tebeka/nuclio/subscribers","subscription_url":"https://api.github.com/repos/tebeka/nuclio/subscription","commits_url":"https://api.github.com/repos/tebeka/nuclio/commits{/sha}","git_commits_url":"https://api.github.com/repos/tebeka/nuclio/git/commits{/sha}","comments_url":"https://api.github.com/repos/tebeka/nuclio/comments{/number}","issue_comment_url":"https://api.github.com/repos/tebeka/nuclio/issues/comments{/number}","contents_url":"https://api.github.com/repos/tebeka/nuclio/contents/{+path}","compare_url":"https://api.github.com/repos/tebeka/nuclio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tebeka/nuclio/merges","archive_url":"https://api.github.com/repos/tebeka/nuclio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tebeka/nuclio/downloads","issues_url":"https://api.github.com/repos/tebeka/nuclio/issues{/number}","pulls_url":"https://api.github.com/repos/tebeka/nuclio/pulls{/number}","milestones_url":"https://api.github.com/repos/tebeka/nuclio/milestones{/number}","notifications_url":"https://api.github.com/repos/tebeka/nuclio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tebeka/nuclio/labels{/name}","releases_url":"https://api.github.com/repos/tebeka/nuclio/releases{/id}","deployments_url":"https://api.github.com/repos/tebeka/nuclio/deployments","created_at":"2017-08-21T07:54:13Z","updated_at":"2017-08-21T07:54:15Z","pushed_at":"2017-10-18T18:11:58Z","git_url":"git://github.com/tebeka/nuclio.git","ssh_url":"git@github.com:tebeka/nuclio.git","clone_url":"https://github.com/tebeka/nuclio.git","svn_url":"https://github.com/tebeka/nuclio","homepage":"","size":34943,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nuclio:development","ref":"development","sha":"a153bc1d351cdf032990cf704d66a02ffd4cd1a1","user":{"login":"nuclio","id":28734234,"avatar_url":"https://avatars3.githubusercontent.com/u/28734234?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclio","html_url":"https://github.com/nuclio","followers_url":"https://api.github.com/users/nuclio/followers","following_url":"https://api.github.com/users/nuclio/following{/other_user}","gists_url":"https://api.github.com/users/nuclio/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclio/subscriptions","organizations_url":"https://api.github.com/users/nuclio/orgs","repos_url":"https://api.github.com/users/nuclio/repos","events_url":"https://api.github.com/users/nuclio/events{/privacy}","received_events_url":"https://api.github.com/users/nuclio/received_events","type":"Organization","site_admin":false},"repo":{"id":91797088,"name":"nuclio","full_name":"nuclio/nuclio","owner":{"login":"nuclio","id":28734234,"avatar_url":"https://avatars3.githubusercontent.com/u/28734234?v=4","gravatar_id":"","url":"https://api.github.com/users/nuclio","html_url":"https://github.com/nuclio","followers_url":"https://api.github.com/users/nuclio/followers","following_url":"https://api.github.com/users/nuclio/following{/other_user}","gists_url":"https://api.github.com/users/nuclio/gists{/gist_id}","starred_url":"https://api.github.com/users/nuclio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuclio/subscriptions","organizations_url":"https://api.github.com/users/nuclio/orgs","repos_url":"https://api.github.com/users/nuclio/repos","events_url":"https://api.github.com/users/nuclio/events{/privacy}","received_events_url":"https://api.github.com/users/nuclio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuclio/nuclio","description":"High-Performance Serverless event and data processing framework ","fork":false,"url":"https://api.github.com/repos/nuclio/nuclio","forks_url":"https://api.github.com/repos/nuclio/nuclio/forks","keys_url":"https://api.github.com/repos/nuclio/nuclio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuclio/nuclio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuclio/nuclio/teams","hooks_url":"https://api.github.com/repos/nuclio/nuclio/hooks","issue_events_url":"https://api.github.com/repos/nuclio/nuclio/issues/events{/number}","events_url":"https://api.github.com/repos/nuclio/nuclio/events","assignees_url":"https://api.github.com/repos/nuclio/nuclio/assignees{/user}","branches_url":"https://api.github.com/repos/nuclio/nuclio/branches{/branch}","tags_url":"https://api.github.com/repos/nuclio/nuclio/tags","blobs_url":"https://api.github.com/repos/nuclio/nuclio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuclio/nuclio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuclio/nuclio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuclio/nuclio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuclio/nuclio/statuses/{sha}","languages_url":"https://api.github.com/repos/nuclio/nuclio/languages","stargazers_url":"https://api.github.com/repos/nuclio/nuclio/stargazers","contributors_url":"https://api.github.com/repos/nuclio/nuclio/contributors","subscribers_url":"https://api.github.com/repos/nuclio/nuclio/subscribers","subscription_url":"https://api.github.com/repos/nuclio/nuclio/subscription","commits_url":"https://api.github.com/repos/nuclio/nuclio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuclio/nuclio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuclio/nuclio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuclio/nuclio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuclio/nuclio/contents/{+path}","compare_url":"https://api.github.com/repos/nuclio/nuclio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuclio/nuclio/merges","archive_url":"https://api.github.com/repos/nuclio/nuclio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuclio/nuclio/downloads","issues_url":"https://api.github.com/repos/nuclio/nuclio/issues{/number}","pulls_url":"https://api.github.com/repos/nuclio/nuclio/pulls{/number}","milestones_url":"https://api.github.com/repos/nuclio/nuclio/milestones{/number}","notifications_url":"https://api.github.com/repos/nuclio/nuclio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuclio/nuclio/labels{/name}","releases_url":"https://api.github.com/repos/nuclio/nuclio/releases{/id}","deployments_url":"https://api.github.com/repos/nuclio/nuclio/deployments","created_at":"2017-05-19T10:55:09Z","updated_at":"2017-10-18T07:05:19Z","pushed_at":"2017-10-18T18:12:00Z","git_url":"git://github.com/nuclio/nuclio.git","ssh_url":"git@github.com:nuclio/nuclio.git","clone_url":"https://github.com/nuclio/nuclio.git","svn_url":"https://github.com/nuclio/nuclio","homepage":"","size":34413,"stargazers_count":134,"watchers_count":134,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":35,"forks":11,"open_issues":35,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/273"},"html":{"href":"https://github.com/nuclio/nuclio/pull/273"},"issue":{"href":"https://api.github.com/repos/nuclio/nuclio/issues/273"},"comments":{"href":"https://api.github.com/repos/nuclio/nuclio/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuclio/nuclio/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/nuclio/nuclio/statuses/7a4e882d24be7d09a04c5e1b971f56004b19653c"}},"author_association":"COLLABORATOR"}}
|
{
"id": 91797088,
"name": "nuclio/nuclio",
"url": "https://api.github.com/repos/nuclio/nuclio"
}
|
{
"id": 423987,
"login": "pavius",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/423987?",
"url": "https://api.github.com/users/pavius"
}
|
{
"id": 28734234,
"login": "nuclio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28734234?",
"url": "https://api.github.com/orgs/nuclio"
}
| 2017-10-19T07:35:44 |
6736975745
|
{"actor":{"display_login":"pavius"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/comments/115945148","pull_request_review_id":37518591,"id":115945148,"diff_hunk":"@@ -0,0 +1,93 @@\n+/**\n+ * This program is free software; you can redistribute it and/or\n+ * modify it under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation; under version 2\n+ * of the License (non-upgradable).\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.\n+ *\n+ * Copyright (c) 2016 (original work) Open Assessment Technologies SA ;","path":"views/js/runner/plugins/security/preventScreenshot.js","position":16,"original_position":16,"commit_id":"f0c8860e12e26e41438b461a8932ab110e117738","original_commit_id":"f0c8860e12e26e41438b461a8932ab110e117738","user":{"login":"no-chris","id":11467480,"avatar_url":"https://avatars3.githubusercontent.com/u/11467480?v=3","gravatar_id":"","url":"https://api.github.com/users/no-chris","html_url":"https://github.com/no-chris","followers_url":"https://api.github.com/users/no-chris/followers","following_url":"https://api.github.com/users/no-chris/following{/other_user}","gists_url":"https://api.github.com/users/no-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/no-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-chris/subscriptions","organizations_url":"https://api.github.com/users/no-chris/orgs","repos_url":"https://api.github.com/users/no-chris/repos","events_url":"https://api.github.com/users/no-chris/events{/privacy}","received_events_url":"https://api.github.com/users/no-chris/received_events","type":"User","site_admin":false},"body":"copyright year","created_at":"2017-05-11T09:34:01Z","updated_at":"2017-05-11T09:35:58Z","html_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10#discussion_r115945148","pull_request_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/comments/115945148"},"html":{"href":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10#discussion_r115945148"},"pull_request":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10","id":119806219,"html_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10","diff_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10.diff","patch_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10.patch","issue_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/10","number":10,"state":"open","locked":false,"title":"Fix/tao 4300 prevent print screen","user":{"login":"eacraft13","id":2172596,"avatar_url":"https://avatars0.githubusercontent.com/u/2172596?v=3","gravatar_id":"","url":"https://api.github.com/users/eacraft13","html_url":"https://github.com/eacraft13","followers_url":"https://api.github.com/users/eacraft13/followers","following_url":"https://api.github.com/users/eacraft13/following{/other_user}","gists_url":"https://api.github.com/users/eacraft13/gists{/gist_id}","starred_url":"https://api.github.com/users/eacraft13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eacraft13/subscriptions","organizations_url":"https://api.github.com/users/eacraft13/orgs","repos_url":"https://api.github.com/users/eacraft13/repos","events_url":"https://api.github.com/users/eacraft13/events{/privacy}","received_events_url":"https://api.github.com/users/eacraft13/received_events","type":"User","site_admin":false},"body":"[tao-4300](https://oat-sa.atlassian.net/browse/TAO-4300)\r\n\r\nCompanion [extension-tao-act pull request](https://github.com/oat-sa/extension-tao-act/pull/542)\r\n\r\nDue to print screen / screenshot being an OS level command, it is not possible to capture in the browser.\r\n\r\nFor mac, Cmd+Shift+[3|4] cannot be captured on keyup or keydown. So, to prevent screenshots, a blur is added on keydown of Cmd+Shift. And removed on keyup of any key when Cmd+Shift is still not pressed. This does have a bit of a shortcoming when Cmd+Shift+4 is used. To remove blur, the user will have to press any key that is not Cmd+Shift.\r\n\r\nFor pc, the solution is different due to the nature of PrtScn. PrtScn cannot be captured on keydown, so an unblurred screenshot cannot be prevented. But, PrtScn can be captured on keyup. So, on keyup of PrtScn, I chose to pause execution so that the proctor would be notified that a successful screenshot was taken.","created_at":"2017-05-10T05:39:51Z","updated_at":"2017-05-11T09:35:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ed574764b911154402261bfe0ddc783f7bf358a","assignee":{"login":"no-chris","id":11467480,"avatar_url":"https://avatars3.githubusercontent.com/u/11467480?v=3","gravatar_id":"","url":"https://api.github.com/users/no-chris","html_url":"https://github.com/no-chris","followers_url":"https://api.github.com/users/no-chris/followers","following_url":"https://api.github.com/users/no-chris/following{/other_user}","gists_url":"https://api.github.com/users/no-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/no-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-chris/subscriptions","organizations_url":"https://api.github.com/users/no-chris/orgs","repos_url":"https://api.github.com/users/no-chris/repos","events_url":"https://api.github.com/users/no-chris/events{/privacy}","received_events_url":"https://api.github.com/users/no-chris/received_events","type":"User","site_admin":false},"assignees":[{"login":"no-chris","id":11467480,"avatar_url":"https://avatars3.githubusercontent.com/u/11467480?v=3","gravatar_id":"","url":"https://api.github.com/users/no-chris","html_url":"https://github.com/no-chris","followers_url":"https://api.github.com/users/no-chris/followers","following_url":"https://api.github.com/users/no-chris/following{/other_user}","gists_url":"https://api.github.com/users/no-chris/gists{/gist_id}","starred_url":"https://api.github.com/users/no-chris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/no-chris/subscriptions","organizations_url":"https://api.github.com/users/no-chris/orgs","repos_url":"https://api.github.com/users/no-chris/repos","events_url":"https://api.github.com/users/no-chris/events{/privacy}","received_events_url":"https://api.github.com/users/no-chris/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10/commits","review_comments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10/comments","review_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/10/comments","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/statuses/f0c8860e12e26e41438b461a8932ab110e117738","head":{"label":"oat-sa:fix/tao-4300_prevent_print_screen","ref":"fix/tao-4300_prevent_print_screen","sha":"f0c8860e12e26e41438b461a8932ab110e117738","user":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars0.githubusercontent.com/u/7581081?v=3","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":63961759,"name":"extension-tao-test-runner-plugins","full_name":"oat-sa/extension-tao-test-runner-plugins","owner":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars0.githubusercontent.com/u/7581081?v=3","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins","description":"Manage Test Runner plugins","fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/deployments","created_at":"2016-07-22T14:58:33Z","updated_at":"2017-03-31T14:19:45Z","pushed_at":"2017-05-10T14:48:09Z","git_url":"git://github.com/oat-sa/extension-tao-test-runner-plugins.git","ssh_url":"git@github.com:oat-sa/extension-tao-test-runner-plugins.git","clone_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins.git","svn_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"oat-sa:develop","ref":"develop","sha":"f3769e578bd2352148297dcc96fa06b3072b8919","user":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars0.githubusercontent.com/u/7581081?v=3","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"repo":{"id":63961759,"name":"extension-tao-test-runner-plugins","full_name":"oat-sa/extension-tao-test-runner-plugins","owner":{"login":"oat-sa","id":7581081,"avatar_url":"https://avatars0.githubusercontent.com/u/7581081?v=3","gravatar_id":"","url":"https://api.github.com/users/oat-sa","html_url":"https://github.com/oat-sa","followers_url":"https://api.github.com/users/oat-sa/followers","following_url":"https://api.github.com/users/oat-sa/following{/other_user}","gists_url":"https://api.github.com/users/oat-sa/gists{/gist_id}","starred_url":"https://api.github.com/users/oat-sa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oat-sa/subscriptions","organizations_url":"https://api.github.com/users/oat-sa/orgs","repos_url":"https://api.github.com/users/oat-sa/repos","events_url":"https://api.github.com/users/oat-sa/events{/privacy}","received_events_url":"https://api.github.com/users/oat-sa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins","description":"Manage Test Runner plugins","fork":false,"url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins","forks_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/forks","keys_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/teams","hooks_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/hooks","issue_events_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/events","assignees_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/tags","blobs_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/languages","stargazers_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/stargazers","contributors_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/contributors","subscribers_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/subscribers","subscription_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/subscription","commits_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/merges","archive_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/downloads","issues_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/labels{/name}","releases_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/deployments","created_at":"2016-07-22T14:58:33Z","updated_at":"2017-03-31T14:19:45Z","pushed_at":"2017-05-10T14:48:09Z","git_url":"git://github.com/oat-sa/extension-tao-test-runner-plugins.git","ssh_url":"git@github.com:oat-sa/extension-tao-test-runner-plugins.git","clone_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins.git","svn_url":"https://github.com/oat-sa/extension-tao-test-runner-plugins","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10"},"html":{"href":"https://github.com/oat-sa/extension-tao-test-runner-plugins/pull/10"},"issue":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/10"},"comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins/statuses/f0c8860e12e26e41438b461a8932ab110e117738"}}}}
|
{
"id": 63961759,
"name": "oat-sa/extension-tao-test-runner-plugins",
"url": "https://api.github.com/repos/oat-sa/extension-tao-test-runner-plugins"
}
|
{
"id": 11467480,
"login": "no-chris",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11467480?",
"url": "https://api.github.com/users/no-chris"
}
|
{
"id": 7581081,
"login": "oat-sa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7581081?",
"url": "https://api.github.com/orgs/oat-sa"
}
| 2017-05-11T09:34:01 |
5851815954
|
{"actor":{"display_login":"no-chris"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/99684181","pull_request_review_id":20368566,"id":99684181,"diff_hunk":"@@ -1034,6 +1034,7 @@ require(\"../html5-common/js/utils/utils.js\");\n //These are required by Google for tracking purposes.\n google.ima.settings.setPlayerVersion(PLUGIN_VERSION);\n google.ima.settings.setPlayerType(PLAYER_TYPE);\n+ google.ima.settings.setLocale(OO.getLocale());","path":"js/google_ima.js","position":4,"original_position":4,"commit_id":"c86feea50f9ac83fada75801fd1cf281b6e88c6a","original_commit_id":"c86feea50f9ac83fada75801fd1cf281b6e88c6a","user":{"login":"dchauOoyala","id":15880169,"avatar_url":"https://avatars.githubusercontent.com/u/15880169?v=3","gravatar_id":"","url":"https://api.github.com/users/dchauOoyala","html_url":"https://github.com/dchauOoyala","followers_url":"https://api.github.com/users/dchauOoyala/followers","following_url":"https://api.github.com/users/dchauOoyala/following{/other_user}","gists_url":"https://api.github.com/users/dchauOoyala/gists{/gist_id}","starred_url":"https://api.github.com/users/dchauOoyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchauOoyala/subscriptions","organizations_url":"https://api.github.com/users/dchauOoyala/orgs","repos_url":"https://api.github.com/users/dchauOoyala/repos","events_url":"https://api.github.com/users/dchauOoyala/events{/privacy}","received_events_url":"https://api.github.com/users/dchauOoyala/received_events","type":"User","site_admin":false},"body":"getLocale(): `return (OO.locale || document.documentElement.lang || navigator.language || navigator.userLanguage || \"en\").substr(0,2).toUpperCase();`\r\n\r\nThe getLocale will default to `\"EN\"` if everything before it is falsey. \r\n","created_at":"2017-02-06T21:07:11Z","updated_at":"2017-02-06T21:07:11Z","html_url":"https://github.com/ooyala/html5-ad-plugins/pull/181#discussion_r99684181","pull_request_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments/99684181"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/181#discussion_r99684181"},"pull_request":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181"}}},"pull_request":{"url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181","id":104255772,"html_url":"https://github.com/ooyala/html5-ad-plugins/pull/181","diff_url":"https://github.com/ooyala/html5-ad-plugins/pull/181.diff","patch_url":"https://github.com/ooyala/html5-ad-plugins/pull/181.patch","issue_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/181","number":181,"state":"open","locked":false,"title":"[PLAYER-551] Set browser locale setting for google ima","user":{"login":"dchauOoyala","id":15880169,"avatar_url":"https://avatars.githubusercontent.com/u/15880169?v=3","gravatar_id":"","url":"https://api.github.com/users/dchauOoyala","html_url":"https://github.com/dchauOoyala","followers_url":"https://api.github.com/users/dchauOoyala/followers","following_url":"https://api.github.com/users/dchauOoyala/following{/other_user}","gists_url":"https://api.github.com/users/dchauOoyala/gists{/gist_id}","starred_url":"https://api.github.com/users/dchauOoyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchauOoyala/subscriptions","organizations_url":"https://api.github.com/users/dchauOoyala/orgs","repos_url":"https://api.github.com/users/dchauOoyala/repos","events_url":"https://api.github.com/users/dchauOoyala/events{/privacy}","received_events_url":"https://api.github.com/users/dchauOoyala/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-02T00:55:04Z","updated_at":"2017-02-06T21:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0262045777681fe59f103a636c6c366f3d5b0a46","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181/commits","review_comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181/comments","review_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/181/comments","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/c86feea50f9ac83fada75801fd1cf281b6e88c6a","head":{"label":"ooyala:PLAYER-551","ref":"PLAYER-551","sha":"c86feea50f9ac83fada75801fd1cf281b6e88c6a","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/deployments","created_at":"2015-04-13T18:37:19Z","updated_at":"2016-10-27T11:26:14Z","pushed_at":"2017-02-02T00:55:05Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":1067,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"ooyala:master","ref":"master","sha":"e5b652de0986c9063a0294484d6bce707d6316c6","user":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"repo":{"id":33886489,"name":"html5-ad-plugins","full_name":"ooyala/html5-ad-plugins","owner":{"login":"ooyala","id":365274,"avatar_url":"https://avatars.githubusercontent.com/u/365274?v=3","gravatar_id":"","url":"https://api.github.com/users/ooyala","html_url":"https://github.com/ooyala","followers_url":"https://api.github.com/users/ooyala/followers","following_url":"https://api.github.com/users/ooyala/following{/other_user}","gists_url":"https://api.github.com/users/ooyala/gists{/gist_id}","starred_url":"https://api.github.com/users/ooyala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooyala/subscriptions","organizations_url":"https://api.github.com/users/ooyala/orgs","repos_url":"https://api.github.com/users/ooyala/repos","events_url":"https://api.github.com/users/ooyala/events{/privacy}","received_events_url":"https://api.github.com/users/ooyala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ooyala/html5-ad-plugins","description":null,"fork":false,"url":"https://api.github.com/repos/ooyala/html5-ad-plugins","forks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/forks","keys_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/teams","hooks_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/hooks","issue_events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/events","assignees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/tags","blobs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/languages","stargazers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/stargazers","contributors_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contributors","subscribers_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscribers","subscription_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/subscription","commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/merges","archive_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/downloads","issues_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/labels{/name}","releases_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ooyala/html5-ad-plugins/deployments","created_at":"2015-04-13T18:37:19Z","updated_at":"2016-10-27T11:26:14Z","pushed_at":"2017-02-02T00:55:05Z","git_url":"git://github.com/ooyala/html5-ad-plugins.git","ssh_url":"git@github.com:ooyala/html5-ad-plugins.git","clone_url":"https://github.com/ooyala/html5-ad-plugins.git","svn_url":"https://github.com/ooyala/html5-ad-plugins","homepage":null,"size":1067,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181"},"html":{"href":"https://github.com/ooyala/html5-ad-plugins/pull/181"},"issue":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/181"},"comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/issues/181/comments"},"review_comments":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181/comments"},"review_comment":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/pulls/181/commits"},"statuses":{"href":"https://api.github.com/repos/ooyala/html5-ad-plugins/statuses/c86feea50f9ac83fada75801fd1cf281b6e88c6a"}}}}
|
{
"id": 33886489,
"name": "ooyala/html5-ad-plugins",
"url": "https://api.github.com/repos/ooyala/html5-ad-plugins"
}
|
{
"id": 15880169,
"login": "dchauOoyala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15880169?",
"url": "https://api.github.com/users/dchauOoyala"
}
|
{
"id": 365274,
"login": "ooyala",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365274?",
"url": "https://api.github.com/orgs/ooyala"
}
| 2017-02-06T21:07:11 |
5275639983
|
{"actor":{"display_login":"dchauOoyala"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/comments/124899197","pull_request_review_id":47235791,"id":124899197,"diff_hunk":"@@ -0,0 +1,156 @@\n+import React, { Component } from \"react\";\n+import {\n+ View,\n+ ListView,\n+ TouchableOpacity,\n+ Animated,\n+ StyleSheet\n+} from \"react-native\";\n+import Interactable from \"react-native-interactable\";\n+import Icon from \"react-native-vector-icons/MaterialIcons\";\n+\n+import Text from \"./text\";\n+import { baseStyles } from \"../styles\";\n+\n+const styles = StyleSheet.create({\n+ categoryList: {},\n+ category: {\n+ borderColor: \"#ccc\",\n+ borderWidth: 1,\n+ padding: 5,\n+ paddingLeft: 20,\n+ height: 40\n+ },\n+ categoryHeader: { padding: 5, height: 40 }\n+});\n+\n+class CategoryList extends Component {\n+ render() {\n+ const { navigation, categories } = this.props;\n+\n+ return (\n+ <View style={styles.categoryList}>\n+ {categories.map(category => {\n+ return (\n+ <CategoryView\n+ navigation={navigation}\n+ category={category}\n+ key={category.name}\n+ />\n+ );\n+ })}\n+ </View>\n+ );\n+ }\n+}\n+\n+class CategoryView extends Component {\n+ componentWillMount() {\n+ const { category } = this.props;\n+\n+ const ds = new ListView.DataSource({\n+ rowHasChanged: (r1, r2) => r1 !== r2\n+ });\n+\n+ this.setState({\n+ expanded: false,\n+ minHeight: null,\n+ maxHeight: null,\n+ animation: new Animated.Value(),\n+ categoryName: category.name,\n+ categories: ds.cloneWithRows(\n+ category.list.map(item => ({\n+ id: item.id,\n+ name: item.name\n+ }))\n+ )\n+ });\n+ }\n+\n+ _setMinHeight = e => {\n+ this.state.animation.setValue(20);\n+ if (!this.state.minHeight) {\n+ this.state.minHeight = 20;","path":"app/components/category-list.js","position":73,"original_position":73,"commit_id":"69bf3be2f73014432c99069060a4ebba84b9385b","original_commit_id":"69bf3be2f73014432c99069060a4ebba84b9385b","user":{"login":"mojodna","id":45,"avatar_url":"https://avatars1.githubusercontent.com/u/45?v=3","gravatar_id":"","url":"https://api.github.com/users/mojodna","html_url":"https://github.com/mojodna","followers_url":"https://api.github.com/users/mojodna/followers","following_url":"https://api.github.com/users/mojodna/following{/other_user}","gists_url":"https://api.github.com/users/mojodna/gists{/gist_id}","starred_url":"https://api.github.com/users/mojodna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojodna/subscriptions","organizations_url":"https://api.github.com/users/mojodna/orgs","repos_url":"https://api.github.com/users/mojodna/repos","events_url":"https://api.github.com/users/mojodna/events{/privacy}","received_events_url":"https://api.github.com/users/mojodna/received_events","type":"User","site_admin":false},"body":"Ditto for dimensions. (ESLint whines when `this.state` is manipulated directly, and when I tried adjusting for that with Mapbox GL dimensions on the main screen, bad things happened.)","created_at":"2017-06-29T20:03:03Z","updated_at":"2017-06-29T20:07:19Z","html_url":"https://github.com/osmlab/field-data-collection/pull/138#discussion_r124899197","pull_request_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138","_links":{"self":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/comments/124899197"},"html":{"href":"https://github.com/osmlab/field-data-collection/pull/138#discussion_r124899197"},"pull_request":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138","id":128233980,"html_url":"https://github.com/osmlab/field-data-collection/pull/138","diff_url":"https://github.com/osmlab/field-data-collection/pull/138.diff","patch_url":"https://github.com/osmlab/field-data-collection/pull/138.patch","issue_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/138","number":138,"state":"open","locked":false,"title":"initial categories list component","user":{"login":"sethvincent","id":164214,"avatar_url":"https://avatars2.githubusercontent.com/u/164214?v=3","gravatar_id":"","url":"https://api.github.com/users/sethvincent","html_url":"https://github.com/sethvincent","followers_url":"https://api.github.com/users/sethvincent/followers","following_url":"https://api.github.com/users/sethvincent/following{/other_user}","gists_url":"https://api.github.com/users/sethvincent/gists{/gist_id}","starred_url":"https://api.github.com/users/sethvincent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethvincent/subscriptions","organizations_url":"https://api.github.com/users/sethvincent/orgs","repos_url":"https://api.github.com/users/sethvincent/repos","events_url":"https://api.github.com/users/sethvincent/events{/privacy}","received_events_url":"https://api.github.com/users/sethvincent/received_events","type":"User","site_admin":false},"body":"Turns our previous category grid into a list that can be expanded/contracted.\r\n\r\nRight now it expects the shape of the categories input to be something like this:\r\n\r\n```js\r\n[{\r\n name: \"OSM\",\r\n categories: [\r\n { name: \"Buildings\" }\r\n ]\r\n}]\r\n```\r\n\r\nThis can be revised to better reflect the surveys in state.","created_at":"2017-06-29T19:56:09Z","updated_at":"2017-06-29T20:07:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8ed203a9dde66d594d81ce544cc54a2febe3951","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138/commits","review_comments_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138/comments","review_comment_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/138/comments","statuses_url":"https://api.github.com/repos/osmlab/field-data-collection/statuses/69bf3be2f73014432c99069060a4ebba84b9385b","head":{"label":"osmlab:category-list","ref":"category-list","sha":"69bf3be2f73014432c99069060a4ebba84b9385b","user":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars0.githubusercontent.com/u/3856374?v=3","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":90279908,"name":"field-data-collection","full_name":"osmlab/field-data-collection","owner":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars0.githubusercontent.com/u/3856374?v=3","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmlab/field-data-collection","description":"A mobile application built with react native for collecting data in the field.","fork":false,"url":"https://api.github.com/repos/osmlab/field-data-collection","forks_url":"https://api.github.com/repos/osmlab/field-data-collection/forks","keys_url":"https://api.github.com/repos/osmlab/field-data-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/field-data-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/field-data-collection/teams","hooks_url":"https://api.github.com/repos/osmlab/field-data-collection/hooks","issue_events_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/field-data-collection/events","assignees_url":"https://api.github.com/repos/osmlab/field-data-collection/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/field-data-collection/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/field-data-collection/tags","blobs_url":"https://api.github.com/repos/osmlab/field-data-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/field-data-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/field-data-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/field-data-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/field-data-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/field-data-collection/languages","stargazers_url":"https://api.github.com/repos/osmlab/field-data-collection/stargazers","contributors_url":"https://api.github.com/repos/osmlab/field-data-collection/contributors","subscribers_url":"https://api.github.com/repos/osmlab/field-data-collection/subscribers","subscription_url":"https://api.github.com/repos/osmlab/field-data-collection/subscription","commits_url":"https://api.github.com/repos/osmlab/field-data-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/field-data-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/field-data-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/field-data-collection/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/field-data-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/field-data-collection/merges","archive_url":"https://api.github.com/repos/osmlab/field-data-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/field-data-collection/downloads","issues_url":"https://api.github.com/repos/osmlab/field-data-collection/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/field-data-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/field-data-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/field-data-collection/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/field-data-collection/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/field-data-collection/deployments","created_at":"2017-05-04T15:32:42Z","updated_at":"2017-06-21T17:40:17Z","pushed_at":"2017-06-29T19:56:10Z","git_url":"git://github.com/osmlab/field-data-collection.git","ssh_url":"git@github.com:osmlab/field-data-collection.git","clone_url":"https://github.com/osmlab/field-data-collection.git","svn_url":"https://github.com/osmlab/field-data-collection","homepage":"","size":18223,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":2,"default_branch":"master"}},"base":{"label":"osmlab:master","ref":"master","sha":"f001d0b4328d2adee2708c4b1bc22c4b11593986","user":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars0.githubusercontent.com/u/3856374?v=3","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"repo":{"id":90279908,"name":"field-data-collection","full_name":"osmlab/field-data-collection","owner":{"login":"osmlab","id":3856374,"avatar_url":"https://avatars0.githubusercontent.com/u/3856374?v=3","gravatar_id":"","url":"https://api.github.com/users/osmlab","html_url":"https://github.com/osmlab","followers_url":"https://api.github.com/users/osmlab/followers","following_url":"https://api.github.com/users/osmlab/following{/other_user}","gists_url":"https://api.github.com/users/osmlab/gists{/gist_id}","starred_url":"https://api.github.com/users/osmlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osmlab/subscriptions","organizations_url":"https://api.github.com/users/osmlab/orgs","repos_url":"https://api.github.com/users/osmlab/repos","events_url":"https://api.github.com/users/osmlab/events{/privacy}","received_events_url":"https://api.github.com/users/osmlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osmlab/field-data-collection","description":"A mobile application built with react native for collecting data in the field.","fork":false,"url":"https://api.github.com/repos/osmlab/field-data-collection","forks_url":"https://api.github.com/repos/osmlab/field-data-collection/forks","keys_url":"https://api.github.com/repos/osmlab/field-data-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osmlab/field-data-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osmlab/field-data-collection/teams","hooks_url":"https://api.github.com/repos/osmlab/field-data-collection/hooks","issue_events_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/events{/number}","events_url":"https://api.github.com/repos/osmlab/field-data-collection/events","assignees_url":"https://api.github.com/repos/osmlab/field-data-collection/assignees{/user}","branches_url":"https://api.github.com/repos/osmlab/field-data-collection/branches{/branch}","tags_url":"https://api.github.com/repos/osmlab/field-data-collection/tags","blobs_url":"https://api.github.com/repos/osmlab/field-data-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osmlab/field-data-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osmlab/field-data-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/osmlab/field-data-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osmlab/field-data-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/osmlab/field-data-collection/languages","stargazers_url":"https://api.github.com/repos/osmlab/field-data-collection/stargazers","contributors_url":"https://api.github.com/repos/osmlab/field-data-collection/contributors","subscribers_url":"https://api.github.com/repos/osmlab/field-data-collection/subscribers","subscription_url":"https://api.github.com/repos/osmlab/field-data-collection/subscription","commits_url":"https://api.github.com/repos/osmlab/field-data-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/osmlab/field-data-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/osmlab/field-data-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/osmlab/field-data-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/osmlab/field-data-collection/contents/{+path}","compare_url":"https://api.github.com/repos/osmlab/field-data-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osmlab/field-data-collection/merges","archive_url":"https://api.github.com/repos/osmlab/field-data-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osmlab/field-data-collection/downloads","issues_url":"https://api.github.com/repos/osmlab/field-data-collection/issues{/number}","pulls_url":"https://api.github.com/repos/osmlab/field-data-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/osmlab/field-data-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/osmlab/field-data-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osmlab/field-data-collection/labels{/name}","releases_url":"https://api.github.com/repos/osmlab/field-data-collection/releases{/id}","deployments_url":"https://api.github.com/repos/osmlab/field-data-collection/deployments","created_at":"2017-05-04T15:32:42Z","updated_at":"2017-06-21T17:40:17Z","pushed_at":"2017-06-29T19:56:10Z","git_url":"git://github.com/osmlab/field-data-collection.git","ssh_url":"git@github.com:osmlab/field-data-collection.git","clone_url":"https://github.com/osmlab/field-data-collection.git","svn_url":"https://github.com/osmlab/field-data-collection","homepage":"","size":18223,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":41,"forks":1,"open_issues":41,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138"},"html":{"href":"https://github.com/osmlab/field-data-collection/pull/138"},"issue":{"href":"https://api.github.com/repos/osmlab/field-data-collection/issues/138"},"comments":{"href":"https://api.github.com/repos/osmlab/field-data-collection/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osmlab/field-data-collection/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/osmlab/field-data-collection/statuses/69bf3be2f73014432c99069060a4ebba84b9385b"}}}}
|
{
"id": 90279908,
"name": "osmlab/field-data-collection",
"url": "https://api.github.com/repos/osmlab/field-data-collection"
}
|
{
"id": 45,
"login": "mojodna",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45?",
"url": "https://api.github.com/users/mojodna"
}
|
{
"id": 3856374,
"login": "osmlab",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3856374?",
"url": "https://api.github.com/orgs/osmlab"
}
| 2017-06-29T20:03:03 |
6166398107
|
{"actor":{"display_login":"mojodna"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/otchoo/classy/pulls/comments/145014877","pull_request_review_id":69751678,"id":145014877,"diff_hunk":"@@ -0,0 +1,10 @@\n+<div class=\"info_content\">\n+ <%= image_tag branch.avatar, height: \"100\", width: \"100%\" %>\n+ <h3><%= link_to branch.name, \"http://localhost:3000/branches/\" + branch.slug %></h3>","path":"app/views/shared/_branch_info.html.erb","position":3,"original_position":3,"commit_id":"aa9b2a9eb80b5148cc433051601a02870999560d","original_commit_id":"aa9b2a9eb80b5148cc433051601a02870999560d","user":{"login":"lucnv","id":19769129,"avatar_url":"https://avatars0.githubusercontent.com/u/19769129?v=4","gravatar_id":"","url":"https://api.github.com/users/lucnv","html_url":"https://github.com/lucnv","followers_url":"https://api.github.com/users/lucnv/followers","following_url":"https://api.github.com/users/lucnv/following{/other_user}","gists_url":"https://api.github.com/users/lucnv/gists{/gist_id}","starred_url":"https://api.github.com/users/lucnv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucnv/subscriptions","organizations_url":"https://api.github.com/users/lucnv/orgs","repos_url":"https://api.github.com/users/lucnv/repos","events_url":"https://api.github.com/users/lucnv/events{/privacy}","received_events_url":"https://api.github.com/users/lucnv/received_events","type":"User","site_admin":false},"body":"sao ko dung url helper?","created_at":"2017-10-17T02:29:57Z","updated_at":"2017-10-17T02:33:16Z","html_url":"https://github.com/otchoo/classy/pull/17#discussion_r145014877","pull_request_url":"https://api.github.com/repos/otchoo/classy/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/otchoo/classy/pulls/comments/145014877"},"html":{"href":"https://github.com/otchoo/classy/pull/17#discussion_r145014877"},"pull_request":{"href":"https://api.github.com/repos/otchoo/classy/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/otchoo/classy/pulls/17","id":146747377,"html_url":"https://github.com/otchoo/classy/pull/17","diff_url":"https://github.com/otchoo/classy/pull/17.diff","patch_url":"https://github.com/otchoo/classy/pull/17.patch","issue_url":"https://api.github.com/repos/otchoo/classy/issues/17","number":17,"state":"open","locked":false,"title":"Task 9.3 View branches list on map","user":{"login":"oDoHongSon","id":22186548,"avatar_url":"https://avatars3.githubusercontent.com/u/22186548?v=4","gravatar_id":"","url":"https://api.github.com/users/oDoHongSon","html_url":"https://github.com/oDoHongSon","followers_url":"https://api.github.com/users/oDoHongSon/followers","following_url":"https://api.github.com/users/oDoHongSon/following{/other_user}","gists_url":"https://api.github.com/users/oDoHongSon/gists{/gist_id}","starred_url":"https://api.github.com/users/oDoHongSon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oDoHongSon/subscriptions","organizations_url":"https://api.github.com/users/oDoHongSon/orgs","repos_url":"https://api.github.com/users/oDoHongSon/repos","events_url":"https://api.github.com/users/oDoHongSon/events{/privacy}","received_events_url":"https://api.github.com/users/oDoHongSon/received_events","type":"User","site_admin":false},"body":"Task 9.3 View branches list on map","created_at":"2017-10-16T10:21:39Z","updated_at":"2017-10-17T02:33:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5d09eb5387419ed1e95e7a528eba77b954da3eb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/otchoo/classy/pulls/17/commits","review_comments_url":"https://api.github.com/repos/otchoo/classy/pulls/17/comments","review_comment_url":"https://api.github.com/repos/otchoo/classy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/otchoo/classy/issues/17/comments","statuses_url":"https://api.github.com/repos/otchoo/classy/statuses/aa9b2a9eb80b5148cc433051601a02870999560d","head":{"label":"oDoHongSon:view-branches-on-maps","ref":"view-branches-on-maps","sha":"aa9b2a9eb80b5148cc433051601a02870999560d","user":{"login":"oDoHongSon","id":22186548,"avatar_url":"https://avatars3.githubusercontent.com/u/22186548?v=4","gravatar_id":"","url":"https://api.github.com/users/oDoHongSon","html_url":"https://github.com/oDoHongSon","followers_url":"https://api.github.com/users/oDoHongSon/followers","following_url":"https://api.github.com/users/oDoHongSon/following{/other_user}","gists_url":"https://api.github.com/users/oDoHongSon/gists{/gist_id}","starred_url":"https://api.github.com/users/oDoHongSon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oDoHongSon/subscriptions","organizations_url":"https://api.github.com/users/oDoHongSon/orgs","repos_url":"https://api.github.com/users/oDoHongSon/repos","events_url":"https://api.github.com/users/oDoHongSon/events{/privacy}","received_events_url":"https://api.github.com/users/oDoHongSon/received_events","type":"User","site_admin":false},"repo":{"id":105913157,"name":"classy","full_name":"oDoHongSon/classy","owner":{"login":"oDoHongSon","id":22186548,"avatar_url":"https://avatars3.githubusercontent.com/u/22186548?v=4","gravatar_id":"","url":"https://api.github.com/users/oDoHongSon","html_url":"https://github.com/oDoHongSon","followers_url":"https://api.github.com/users/oDoHongSon/followers","following_url":"https://api.github.com/users/oDoHongSon/following{/other_user}","gists_url":"https://api.github.com/users/oDoHongSon/gists{/gist_id}","starred_url":"https://api.github.com/users/oDoHongSon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oDoHongSon/subscriptions","organizations_url":"https://api.github.com/users/oDoHongSon/orgs","repos_url":"https://api.github.com/users/oDoHongSon/repos","events_url":"https://api.github.com/users/oDoHongSon/events{/privacy}","received_events_url":"https://api.github.com/users/oDoHongSon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oDoHongSon/classy","description":"Search and Review System for Foreign Language Center","fork":true,"url":"https://api.github.com/repos/oDoHongSon/classy","forks_url":"https://api.github.com/repos/oDoHongSon/classy/forks","keys_url":"https://api.github.com/repos/oDoHongSon/classy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oDoHongSon/classy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oDoHongSon/classy/teams","hooks_url":"https://api.github.com/repos/oDoHongSon/classy/hooks","issue_events_url":"https://api.github.com/repos/oDoHongSon/classy/issues/events{/number}","events_url":"https://api.github.com/repos/oDoHongSon/classy/events","assignees_url":"https://api.github.com/repos/oDoHongSon/classy/assignees{/user}","branches_url":"https://api.github.com/repos/oDoHongSon/classy/branches{/branch}","tags_url":"https://api.github.com/repos/oDoHongSon/classy/tags","blobs_url":"https://api.github.com/repos/oDoHongSon/classy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oDoHongSon/classy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oDoHongSon/classy/git/refs{/sha}","trees_url":"https://api.github.com/repos/oDoHongSon/classy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oDoHongSon/classy/statuses/{sha}","languages_url":"https://api.github.com/repos/oDoHongSon/classy/languages","stargazers_url":"https://api.github.com/repos/oDoHongSon/classy/stargazers","contributors_url":"https://api.github.com/repos/oDoHongSon/classy/contributors","subscribers_url":"https://api.github.com/repos/oDoHongSon/classy/subscribers","subscription_url":"https://api.github.com/repos/oDoHongSon/classy/subscription","commits_url":"https://api.github.com/repos/oDoHongSon/classy/commits{/sha}","git_commits_url":"https://api.github.com/repos/oDoHongSon/classy/git/commits{/sha}","comments_url":"https://api.github.com/repos/oDoHongSon/classy/comments{/number}","issue_comment_url":"https://api.github.com/repos/oDoHongSon/classy/issues/comments{/number}","contents_url":"https://api.github.com/repos/oDoHongSon/classy/contents/{+path}","compare_url":"https://api.github.com/repos/oDoHongSon/classy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oDoHongSon/classy/merges","archive_url":"https://api.github.com/repos/oDoHongSon/classy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oDoHongSon/classy/downloads","issues_url":"https://api.github.com/repos/oDoHongSon/classy/issues{/number}","pulls_url":"https://api.github.com/repos/oDoHongSon/classy/pulls{/number}","milestones_url":"https://api.github.com/repos/oDoHongSon/classy/milestones{/number}","notifications_url":"https://api.github.com/repos/oDoHongSon/classy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oDoHongSon/classy/labels{/name}","releases_url":"https://api.github.com/repos/oDoHongSon/classy/releases{/id}","deployments_url":"https://api.github.com/repos/oDoHongSon/classy/deployments","created_at":"2017-10-05T16:23:24Z","updated_at":"2017-10-05T16:23:26Z","pushed_at":"2017-10-17T02:23:18Z","git_url":"git://github.com/oDoHongSon/classy.git","ssh_url":"git@github.com:oDoHongSon/classy.git","clone_url":"https://github.com/oDoHongSon/classy.git","svn_url":"https://github.com/oDoHongSon/classy","homepage":null,"size":145,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"otchoo:develop","ref":"develop","sha":"444eaa33482e74383c7284593b2e26d9b8a810ad","user":{"login":"otchoo","id":26502750,"avatar_url":"https://avatars0.githubusercontent.com/u/26502750?v=4","gravatar_id":"","url":"https://api.github.com/users/otchoo","html_url":"https://github.com/otchoo","followers_url":"https://api.github.com/users/otchoo/followers","following_url":"https://api.github.com/users/otchoo/following{/other_user}","gists_url":"https://api.github.com/users/otchoo/gists{/gist_id}","starred_url":"https://api.github.com/users/otchoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otchoo/subscriptions","organizations_url":"https://api.github.com/users/otchoo/orgs","repos_url":"https://api.github.com/users/otchoo/repos","events_url":"https://api.github.com/users/otchoo/events{/privacy}","received_events_url":"https://api.github.com/users/otchoo/received_events","type":"Organization","site_admin":false},"repo":{"id":105848186,"name":"classy","full_name":"otchoo/classy","owner":{"login":"otchoo","id":26502750,"avatar_url":"https://avatars0.githubusercontent.com/u/26502750?v=4","gravatar_id":"","url":"https://api.github.com/users/otchoo","html_url":"https://github.com/otchoo","followers_url":"https://api.github.com/users/otchoo/followers","following_url":"https://api.github.com/users/otchoo/following{/other_user}","gists_url":"https://api.github.com/users/otchoo/gists{/gist_id}","starred_url":"https://api.github.com/users/otchoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otchoo/subscriptions","organizations_url":"https://api.github.com/users/otchoo/orgs","repos_url":"https://api.github.com/users/otchoo/repos","events_url":"https://api.github.com/users/otchoo/events{/privacy}","received_events_url":"https://api.github.com/users/otchoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/otchoo/classy","description":"Search and Review System for Foreign Language Center","fork":false,"url":"https://api.github.com/repos/otchoo/classy","forks_url":"https://api.github.com/repos/otchoo/classy/forks","keys_url":"https://api.github.com/repos/otchoo/classy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otchoo/classy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otchoo/classy/teams","hooks_url":"https://api.github.com/repos/otchoo/classy/hooks","issue_events_url":"https://api.github.com/repos/otchoo/classy/issues/events{/number}","events_url":"https://api.github.com/repos/otchoo/classy/events","assignees_url":"https://api.github.com/repos/otchoo/classy/assignees{/user}","branches_url":"https://api.github.com/repos/otchoo/classy/branches{/branch}","tags_url":"https://api.github.com/repos/otchoo/classy/tags","blobs_url":"https://api.github.com/repos/otchoo/classy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otchoo/classy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otchoo/classy/git/refs{/sha}","trees_url":"https://api.github.com/repos/otchoo/classy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otchoo/classy/statuses/{sha}","languages_url":"https://api.github.com/repos/otchoo/classy/languages","stargazers_url":"https://api.github.com/repos/otchoo/classy/stargazers","contributors_url":"https://api.github.com/repos/otchoo/classy/contributors","subscribers_url":"https://api.github.com/repos/otchoo/classy/subscribers","subscription_url":"https://api.github.com/repos/otchoo/classy/subscription","commits_url":"https://api.github.com/repos/otchoo/classy/commits{/sha}","git_commits_url":"https://api.github.com/repos/otchoo/classy/git/commits{/sha}","comments_url":"https://api.github.com/repos/otchoo/classy/comments{/number}","issue_comment_url":"https://api.github.com/repos/otchoo/classy/issues/comments{/number}","contents_url":"https://api.github.com/repos/otchoo/classy/contents/{+path}","compare_url":"https://api.github.com/repos/otchoo/classy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otchoo/classy/merges","archive_url":"https://api.github.com/repos/otchoo/classy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otchoo/classy/downloads","issues_url":"https://api.github.com/repos/otchoo/classy/issues{/number}","pulls_url":"https://api.github.com/repos/otchoo/classy/pulls{/number}","milestones_url":"https://api.github.com/repos/otchoo/classy/milestones{/number}","notifications_url":"https://api.github.com/repos/otchoo/classy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otchoo/classy/labels{/name}","releases_url":"https://api.github.com/repos/otchoo/classy/releases{/id}","deployments_url":"https://api.github.com/repos/otchoo/classy/deployments","created_at":"2017-10-05T04:11:38Z","updated_at":"2017-10-05T05:29:33Z","pushed_at":"2017-10-17T02:23:19Z","git_url":"git://github.com/otchoo/classy.git","ssh_url":"git@github.com:otchoo/classy.git","clone_url":"https://github.com/otchoo/classy.git","svn_url":"https://github.com/otchoo/classy","homepage":null,"size":128,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":2,"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/otchoo/classy/pulls/17"},"html":{"href":"https://github.com/otchoo/classy/pull/17"},"issue":{"href":"https://api.github.com/repos/otchoo/classy/issues/17"},"comments":{"href":"https://api.github.com/repos/otchoo/classy/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/otchoo/classy/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/otchoo/classy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/otchoo/classy/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/otchoo/classy/statuses/aa9b2a9eb80b5148cc433051601a02870999560d"}},"author_association":"NONE"}}
|
{
"id": 105848186,
"name": "otchoo/classy",
"url": "https://api.github.com/repos/otchoo/classy"
}
|
{
"id": 19769129,
"login": "lucnv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19769129?",
"url": "https://api.github.com/users/lucnv"
}
|
{
"id": 26502750,
"login": "otchoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26502750?",
"url": "https://api.github.com/orgs/otchoo"
}
| 2017-10-17T02:29:57 |
6725042867
|
{"actor":{"display_login":"lucnv"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments/129115786","pull_request_review_id":51855979,"id":129115786,"diff_hunk":"@@ -450,11 +450,52 @@ Parameters:\n \n ## Counters\n \n-Counters are a simple mechanism for keeping statistics about the\n-packets that trigger a table in a Match Action unit.\n-\n-Direct counters fire when the count method is invoked in an action, and\n-have an instance for each entry in the table.\n+Counters are a mechanism for keeping statistics. The control plane\n+can read counter values. A P4 program cannot read counter values,\n+only update them. If you wish to implement a feature involving\n+sequence numbers in packets, for example, use Registers instead\n+(Section [#sec-registers]).\n+\n+Direct counters are counters associated with a particular P4 table,\n+and are implemented by the extern `DirectCounter`. There are also\n+indirect counters, which are implemented by the extern `Counter` (the\n+name 'indirect' does not imply that there is any indirection involved\n+in the implementation, only that they are not direct counters). The\n+primary differences between direct counters and indirect counters are:\n+\n+- Number of independently updatable counter values:\n+ - A single instantiation of a direct counter always contains as many\n+ independent counter values as the number of entries in the table\n+ with which it is associated (TBD: see below for what this means\n+ for tables that use action profiles).\n+ - You must specify the number of independent counter values for an\n+ indirect counter when instantiating it. This number of counters\n+ need not be the same as the size of any table.\n+- Where counter updates are allowed in the P4 program:\n+ - For a direct counter, you may only invoke its `count` method from\n+ inside the actions of the table with which it is associated, and\n+ this always updates the counter value associated with the matching\n+ table entry.\n+ - For an indirect counter, you may invoke its `count` method\n+ anywhere in the P4 program where extern object method invocations\n+ are permitted (e.g. inside actions, or directly inside a control's\n+ `apply` block), and every such invocation must specify the index\n+ of the counter value to be updated.\n+\n+Counters are only intended to support packet counters and byte","path":"p4-16/psa/PSA.mdk","position":41,"original_position":41,"commit_id":"75c2b323c6ed0d8bb012d812eee1179953da4ec3","original_commit_id":"75c2b323c6ed0d8bb012d812eee1179953da4ec3","user":{"login":"samar-abdi","id":24684223,"avatar_url":"https://avatars2.githubusercontent.com/u/24684223?v=4","gravatar_id":"","url":"https://api.github.com/users/samar-abdi","html_url":"https://github.com/samar-abdi","followers_url":"https://api.github.com/users/samar-abdi/followers","following_url":"https://api.github.com/users/samar-abdi/following{/other_user}","gists_url":"https://api.github.com/users/samar-abdi/gists{/gist_id}","starred_url":"https://api.github.com/users/samar-abdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samar-abdi/subscriptions","organizations_url":"https://api.github.com/users/samar-abdi/orgs","repos_url":"https://api.github.com/users/samar-abdi/repos","events_url":"https://api.github.com/users/samar-abdi/events{/privacy}","received_events_url":"https://api.github.com/users/samar-abdi/received_events","type":"User","site_admin":false},"body":"Are we mandating the bitwidth of a counter? If not, should it be a parameter of the extern constructor?","created_at":"2017-07-24T18:25:16Z","updated_at":"2017-07-24T18:25:17Z","html_url":"https://github.com/p4lang/p4-spec/pull/352#discussion_r129115786","pull_request_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments/129115786"},"html":{"href":"https://github.com/p4lang/p4-spec/pull/352#discussion_r129115786"},"pull_request":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/p4lang/p4-spec/pulls/352","id":130999804,"html_url":"https://github.com/p4lang/p4-spec/pull/352","diff_url":"https://github.com/p4lang/p4-spec/pull/352.diff","patch_url":"https://github.com/p4lang/p4-spec/pull/352.patch","issue_url":"https://api.github.com/repos/p4lang/p4-spec/issues/352","number":352,"state":"open","locked":false,"title":"Proposed updates for Counter and DirectCounter section","user":{"login":"jafingerhut","id":109629,"avatar_url":"https://avatars2.githubusercontent.com/u/109629?v=4","gravatar_id":"","url":"https://api.github.com/users/jafingerhut","html_url":"https://github.com/jafingerhut","followers_url":"https://api.github.com/users/jafingerhut/followers","following_url":"https://api.github.com/users/jafingerhut/following{/other_user}","gists_url":"https://api.github.com/users/jafingerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/jafingerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafingerhut/subscriptions","organizations_url":"https://api.github.com/users/jafingerhut/orgs","repos_url":"https://api.github.com/users/jafingerhut/repos","events_url":"https://api.github.com/users/jafingerhut/events{/privacy}","received_events_url":"https://api.github.com/users/jafingerhut/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-18T04:20:52Z","updated_at":"2017-07-24T18:25:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c23ef9b71e92ff5e5591de7436bd9a3e075adbf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/352/commits","review_comments_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/352/comments","review_comment_url":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/issues/352/comments","statuses_url":"https://api.github.com/repos/p4lang/p4-spec/statuses/75c2b323c6ed0d8bb012d812eee1179953da4ec3","head":{"label":"jafingerhut:psa-new-counter-section-try3","ref":"psa-new-counter-section-try3","sha":"75c2b323c6ed0d8bb012d812eee1179953da4ec3","user":{"login":"jafingerhut","id":109629,"avatar_url":"https://avatars2.githubusercontent.com/u/109629?v=4","gravatar_id":"","url":"https://api.github.com/users/jafingerhut","html_url":"https://github.com/jafingerhut","followers_url":"https://api.github.com/users/jafingerhut/followers","following_url":"https://api.github.com/users/jafingerhut/following{/other_user}","gists_url":"https://api.github.com/users/jafingerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/jafingerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafingerhut/subscriptions","organizations_url":"https://api.github.com/users/jafingerhut/orgs","repos_url":"https://api.github.com/users/jafingerhut/repos","events_url":"https://api.github.com/users/jafingerhut/events{/privacy}","received_events_url":"https://api.github.com/users/jafingerhut/received_events","type":"User","site_admin":false},"repo":{"id":90683714,"name":"p4-spec-1","full_name":"jafingerhut/p4-spec-1","owner":{"login":"jafingerhut","id":109629,"avatar_url":"https://avatars2.githubusercontent.com/u/109629?v=4","gravatar_id":"","url":"https://api.github.com/users/jafingerhut","html_url":"https://github.com/jafingerhut","followers_url":"https://api.github.com/users/jafingerhut/followers","following_url":"https://api.github.com/users/jafingerhut/following{/other_user}","gists_url":"https://api.github.com/users/jafingerhut/gists{/gist_id}","starred_url":"https://api.github.com/users/jafingerhut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jafingerhut/subscriptions","organizations_url":"https://api.github.com/users/jafingerhut/orgs","repos_url":"https://api.github.com/users/jafingerhut/repos","events_url":"https://api.github.com/users/jafingerhut/events{/privacy}","received_events_url":"https://api.github.com/users/jafingerhut/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jafingerhut/p4-spec-1","description":null,"fork":true,"url":"https://api.github.com/repos/jafingerhut/p4-spec-1","forks_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/forks","keys_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/teams","hooks_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/hooks","issue_events_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/issues/events{/number}","events_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/events","assignees_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/assignees{/user}","branches_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/branches{/branch}","tags_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/tags","blobs_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/statuses/{sha}","languages_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/languages","stargazers_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/stargazers","contributors_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/contributors","subscribers_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/subscribers","subscription_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/subscription","commits_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/contents/{+path}","compare_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/merges","archive_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/downloads","issues_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/issues{/number}","pulls_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/pulls{/number}","milestones_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/milestones{/number}","notifications_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/labels{/name}","releases_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/releases{/id}","deployments_url":"https://api.github.com/repos/jafingerhut/p4-spec-1/deployments","created_at":"2017-05-09T00:10:36Z","updated_at":"2017-05-09T00:10:38Z","pushed_at":"2017-07-21T06:52:18Z","git_url":"git://github.com/jafingerhut/p4-spec-1.git","ssh_url":"git@github.com:jafingerhut/p4-spec-1.git","clone_url":"https://github.com/jafingerhut/p4-spec-1.git","svn_url":"https://github.com/jafingerhut/p4-spec-1","homepage":null,"size":22902,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"f2a35189baa7d92b20c9a227ac6916f4bd9d3b49","user":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":40704988,"name":"p4-spec","full_name":"p4lang/p4-spec","owner":{"login":"p4lang","id":10765181,"avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4-spec","description":null,"fork":false,"url":"https://api.github.com/repos/p4lang/p4-spec","forks_url":"https://api.github.com/repos/p4lang/p4-spec/forks","keys_url":"https://api.github.com/repos/p4lang/p4-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4-spec/teams","hooks_url":"https://api.github.com/repos/p4lang/p4-spec/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4-spec/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4-spec/events","assignees_url":"https://api.github.com/repos/p4lang/p4-spec/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4-spec/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4-spec/tags","blobs_url":"https://api.github.com/repos/p4lang/p4-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4-spec/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4-spec/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4-spec/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4-spec/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4-spec/subscription","commits_url":"https://api.github.com/repos/p4lang/p4-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4-spec/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4-spec/merges","archive_url":"https://api.github.com/repos/p4lang/p4-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4-spec/downloads","issues_url":"https://api.github.com/repos/p4lang/p4-spec/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4-spec/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4-spec/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4-spec/deployments","created_at":"2015-08-14T08:45:53Z","updated_at":"2017-06-20T16:46:19Z","pushed_at":"2017-07-21T06:52:19Z","git_url":"git://github.com/p4lang/p4-spec.git","ssh_url":"git@github.com:p4lang/p4-spec.git","clone_url":"https://github.com/p4lang/p4-spec.git","svn_url":"https://github.com/p4lang/p4-spec","homepage":null,"size":41763,"stargazers_count":15,"watchers_count":15,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":56,"forks":8,"open_issues":56,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/352"},"html":{"href":"https://github.com/p4lang/p4-spec/pull/352"},"issue":{"href":"https://api.github.com/repos/p4lang/p4-spec/issues/352"},"comments":{"href":"https://api.github.com/repos/p4lang/p4-spec/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/p4-spec/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/p4-spec/statuses/75c2b323c6ed0d8bb012d812eee1179953da4ec3"}}}}
|
{
"id": 40704988,
"name": "p4lang/p4-spec",
"url": "https://api.github.com/repos/p4lang/p4-spec"
}
|
{
"id": 24684223,
"login": "samar-abdi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24684223?",
"url": "https://api.github.com/users/samar-abdi"
}
|
{
"id": 10765181,
"login": "p4lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10765181?",
"url": "https://api.github.com/orgs/p4lang"
}
| 2017-07-24T18:25:16 |
6317795310
|
{"actor":{"display_login":"samar-abdi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/panter/aoz-003/pulls/comments/143410995","pull_request_review_id":67917570,"id":143410995,"diff_hunk":"@@ -3,13 +3,14 @@\n .table-responsive\n table.table.table-no-border-top\n tbody\n- tr\n- - if current_user.superadmin?\n+ - if current_user.superadmin?\n+ tr\n td= t_model(Volunteer)\n td= @hour.volunteer.contact.full_name\n- tr\n- td= t_model(Client)\n- td= @hour.assignment.client.contact.full_name\n+ - if @hour.assignment?\n+ tr\n+ td= t_model(Client)\n+ td= @hour.hourable.client.contact.full_name","path":"app/views/hours/show.html.slim","position":16,"original_position":16,"commit_id":"3bd5cde76c970502c09339067c2cdbda1688ce86","original_commit_id":"4e668cf4ce2aca7fb3f34f2deecb347b29d575aa","user":{"login":"nuritnt","id":11731325,"avatar_url":"https://avatars3.githubusercontent.com/u/11731325?v=4","gravatar_id":"","url":"https://api.github.com/users/nuritnt","html_url":"https://github.com/nuritnt","followers_url":"https://api.github.com/users/nuritnt/followers","following_url":"https://api.github.com/users/nuritnt/following{/other_user}","gists_url":"https://api.github.com/users/nuritnt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuritnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuritnt/subscriptions","organizations_url":"https://api.github.com/users/nuritnt/orgs","repos_url":"https://api.github.com/users/nuritnt/repos","events_url":"https://api.github.com/users/nuritnt/events{/privacy}","received_events_url":"https://api.github.com/users/nuritnt/received_events","type":"User","site_admin":false},"body":"added :)","created_at":"2017-10-09T08:50:07Z","updated_at":"2017-10-09T08:50:07Z","html_url":"https://github.com/panter/aoz-003/pull/256#discussion_r143410995","pull_request_url":"https://api.github.com/repos/panter/aoz-003/pulls/256","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/comments/143410995"},"html":{"href":"https://github.com/panter/aoz-003/pull/256#discussion_r143410995"},"pull_request":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/256"}},"in_reply_to_id":143179920},"pull_request":{"url":"https://api.github.com/repos/panter/aoz-003/pulls/256","id":144876109,"html_url":"https://github.com/panter/aoz-003/pull/256","diff_url":"https://github.com/panter/aoz-003/pull/256.diff","patch_url":"https://github.com/panter/aoz-003/pull/256.patch","issue_url":"https://api.github.com/repos/panter/aoz-003/issues/256","number":256,"state":"open","locked":false,"title":"Hours for GroupOffers and Assignments (Polymorphic)","user":{"login":"casaper","id":5822656,"avatar_url":"https://avatars3.githubusercontent.com/u/5822656?v=4","gravatar_id":"","url":"https://api.github.com/users/casaper","html_url":"https://github.com/casaper","followers_url":"https://api.github.com/users/casaper/followers","following_url":"https://api.github.com/users/casaper/following{/other_user}","gists_url":"https://api.github.com/users/casaper/gists{/gist_id}","starred_url":"https://api.github.com/users/casaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casaper/subscriptions","organizations_url":"https://api.github.com/users/casaper/orgs","repos_url":"https://api.github.com/users/casaper/repos","events_url":"https://api.github.com/users/casaper/events{/privacy}","received_events_url":"https://api.github.com/users/casaper/received_events","type":"User","site_admin":false},"body":"# [Story in Trello](https://trello.com/c/USUUVKd9/14-2-als-freiwillige-r-m%C3%B6chte-ich-meine-stunden-f%C3%BCr-einen-gruppeneinsatz-erfassen)\r\n\r\n## Done?\r\n\r\n### Done for approval?\r\n\r\n* [ ] Acceptance criteria are met\r\n* [ ] Code quality checks are green\r\n* [ ] Readme updated if needed\r\n* [ ] Story under test\r\n* [ ] Mobile works\r\n* [ ] Seeds created\r\n* [ ] Translated\r\n* [ ] Code is reviewed\r\n\r\n### Done after the merge?\r\n\r\n* [ ] Deployed to staging after the merge\r\n* [ ] Tested manually on staging\r\n","created_at":"2017-10-05T10:11:48Z","updated_at":"2017-10-09T08:50:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f53f49819e75afb984e8a2ca045feccc66565726","assignee":{"login":"casaper","id":5822656,"avatar_url":"https://avatars3.githubusercontent.com/u/5822656?v=4","gravatar_id":"","url":"https://api.github.com/users/casaper","html_url":"https://github.com/casaper","followers_url":"https://api.github.com/users/casaper/followers","following_url":"https://api.github.com/users/casaper/following{/other_user}","gists_url":"https://api.github.com/users/casaper/gists{/gist_id}","starred_url":"https://api.github.com/users/casaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casaper/subscriptions","organizations_url":"https://api.github.com/users/casaper/orgs","repos_url":"https://api.github.com/users/casaper/repos","events_url":"https://api.github.com/users/casaper/events{/privacy}","received_events_url":"https://api.github.com/users/casaper/received_events","type":"User","site_admin":false},"assignees":[{"login":"casaper","id":5822656,"avatar_url":"https://avatars3.githubusercontent.com/u/5822656?v=4","gravatar_id":"","url":"https://api.github.com/users/casaper","html_url":"https://github.com/casaper","followers_url":"https://api.github.com/users/casaper/followers","following_url":"https://api.github.com/users/casaper/following{/other_user}","gists_url":"https://api.github.com/users/casaper/gists{/gist_id}","starred_url":"https://api.github.com/users/casaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casaper/subscriptions","organizations_url":"https://api.github.com/users/casaper/orgs","repos_url":"https://api.github.com/users/casaper/repos","events_url":"https://api.github.com/users/casaper/events{/privacy}","received_events_url":"https://api.github.com/users/casaper/received_events","type":"User","site_admin":false},{"login":"nuritnt","id":11731325,"avatar_url":"https://avatars3.githubusercontent.com/u/11731325?v=4","gravatar_id":"","url":"https://api.github.com/users/nuritnt","html_url":"https://github.com/nuritnt","followers_url":"https://api.github.com/users/nuritnt/followers","following_url":"https://api.github.com/users/nuritnt/following{/other_user}","gists_url":"https://api.github.com/users/nuritnt/gists{/gist_id}","starred_url":"https://api.github.com/users/nuritnt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuritnt/subscriptions","organizations_url":"https://api.github.com/users/nuritnt/orgs","repos_url":"https://api.github.com/users/nuritnt/repos","events_url":"https://api.github.com/users/nuritnt/events{/privacy}","received_events_url":"https://api.github.com/users/nuritnt/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"toupeira","id":6501,"avatar_url":"https://avatars1.githubusercontent.com/u/6501?v=4","gravatar_id":"","url":"https://api.github.com/users/toupeira","html_url":"https://github.com/toupeira","followers_url":"https://api.github.com/users/toupeira/followers","following_url":"https://api.github.com/users/toupeira/following{/other_user}","gists_url":"https://api.github.com/users/toupeira/gists{/gist_id}","starred_url":"https://api.github.com/users/toupeira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toupeira/subscriptions","organizations_url":"https://api.github.com/users/toupeira/orgs","repos_url":"https://api.github.com/users/toupeira/repos","events_url":"https://api.github.com/users/toupeira/events{/privacy}","received_events_url":"https://api.github.com/users/toupeira/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/panter/aoz-003/pulls/256/commits","review_comments_url":"https://api.github.com/repos/panter/aoz-003/pulls/256/comments","review_comment_url":"https://api.github.com/repos/panter/aoz-003/pulls/comments{/number}","comments_url":"https://api.github.com/repos/panter/aoz-003/issues/256/comments","statuses_url":"https://api.github.com/repos/panter/aoz-003/statuses/3bd5cde76c970502c09339067c2cdbda1688ce86","head":{"label":"panter:features/group_offers_assignments_polymorpic_to_hours","ref":"features/group_offers_assignments_polymorpic_to_hours","sha":"3bd5cde76c970502c09339067c2cdbda1688ce86","user":{"login":"panter","id":157435,"avatar_url":"https://avatars2.githubusercontent.com/u/157435?v=4","gravatar_id":"","url":"https://api.github.com/users/panter","html_url":"https://github.com/panter","followers_url":"https://api.github.com/users/panter/followers","following_url":"https://api.github.com/users/panter/following{/other_user}","gists_url":"https://api.github.com/users/panter/gists{/gist_id}","starred_url":"https://api.github.com/users/panter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panter/subscriptions","organizations_url":"https://api.github.com/users/panter/orgs","repos_url":"https://api.github.com/users/panter/repos","events_url":"https://api.github.com/users/panter/events{/privacy}","received_events_url":"https://api.github.com/users/panter/received_events","type":"Organization","site_admin":false},"repo":{"id":87311463,"name":"aoz-003","full_name":"panter/aoz-003","owner":{"login":"panter","id":157435,"avatar_url":"https://avatars2.githubusercontent.com/u/157435?v=4","gravatar_id":"","url":"https://api.github.com/users/panter","html_url":"https://github.com/panter","followers_url":"https://api.github.com/users/panter/followers","following_url":"https://api.github.com/users/panter/following{/other_user}","gists_url":"https://api.github.com/users/panter/gists{/gist_id}","starred_url":"https://api.github.com/users/panter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panter/subscriptions","organizations_url":"https://api.github.com/users/panter/orgs","repos_url":"https://api.github.com/users/panter/repos","events_url":"https://api.github.com/users/panter/events{/privacy}","received_events_url":"https://api.github.com/users/panter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/panter/aoz-003","description":"AOZ Voluntary platform","fork":false,"url":"https://api.github.com/repos/panter/aoz-003","forks_url":"https://api.github.com/repos/panter/aoz-003/forks","keys_url":"https://api.github.com/repos/panter/aoz-003/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panter/aoz-003/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panter/aoz-003/teams","hooks_url":"https://api.github.com/repos/panter/aoz-003/hooks","issue_events_url":"https://api.github.com/repos/panter/aoz-003/issues/events{/number}","events_url":"https://api.github.com/repos/panter/aoz-003/events","assignees_url":"https://api.github.com/repos/panter/aoz-003/assignees{/user}","branches_url":"https://api.github.com/repos/panter/aoz-003/branches{/branch}","tags_url":"https://api.github.com/repos/panter/aoz-003/tags","blobs_url":"https://api.github.com/repos/panter/aoz-003/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panter/aoz-003/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panter/aoz-003/git/refs{/sha}","trees_url":"https://api.github.com/repos/panter/aoz-003/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panter/aoz-003/statuses/{sha}","languages_url":"https://api.github.com/repos/panter/aoz-003/languages","stargazers_url":"https://api.github.com/repos/panter/aoz-003/stargazers","contributors_url":"https://api.github.com/repos/panter/aoz-003/contributors","subscribers_url":"https://api.github.com/repos/panter/aoz-003/subscribers","subscription_url":"https://api.github.com/repos/panter/aoz-003/subscription","commits_url":"https://api.github.com/repos/panter/aoz-003/commits{/sha}","git_commits_url":"https://api.github.com/repos/panter/aoz-003/git/commits{/sha}","comments_url":"https://api.github.com/repos/panter/aoz-003/comments{/number}","issue_comment_url":"https://api.github.com/repos/panter/aoz-003/issues/comments{/number}","contents_url":"https://api.github.com/repos/panter/aoz-003/contents/{+path}","compare_url":"https://api.github.com/repos/panter/aoz-003/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panter/aoz-003/merges","archive_url":"https://api.github.com/repos/panter/aoz-003/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panter/aoz-003/downloads","issues_url":"https://api.github.com/repos/panter/aoz-003/issues{/number}","pulls_url":"https://api.github.com/repos/panter/aoz-003/pulls{/number}","milestones_url":"https://api.github.com/repos/panter/aoz-003/milestones{/number}","notifications_url":"https://api.github.com/repos/panter/aoz-003/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panter/aoz-003/labels{/name}","releases_url":"https://api.github.com/repos/panter/aoz-003/releases{/id}","deployments_url":"https://api.github.com/repos/panter/aoz-003/deployments","created_at":"2017-04-05T13:17:25Z","updated_at":"2017-04-06T07:25:36Z","pushed_at":"2017-10-09T08:49:47Z","git_url":"git://github.com/panter/aoz-003.git","ssh_url":"git@github.com:panter/aoz-003.git","clone_url":"https://github.com/panter/aoz-003.git","svn_url":"https://github.com/panter/aoz-003","homepage":"","size":1814,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"base":{"label":"panter:develop","ref":"develop","sha":"4b1421a1ed33310479e209b3f15060f99de603d3","user":{"login":"panter","id":157435,"avatar_url":"https://avatars2.githubusercontent.com/u/157435?v=4","gravatar_id":"","url":"https://api.github.com/users/panter","html_url":"https://github.com/panter","followers_url":"https://api.github.com/users/panter/followers","following_url":"https://api.github.com/users/panter/following{/other_user}","gists_url":"https://api.github.com/users/panter/gists{/gist_id}","starred_url":"https://api.github.com/users/panter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panter/subscriptions","organizations_url":"https://api.github.com/users/panter/orgs","repos_url":"https://api.github.com/users/panter/repos","events_url":"https://api.github.com/users/panter/events{/privacy}","received_events_url":"https://api.github.com/users/panter/received_events","type":"Organization","site_admin":false},"repo":{"id":87311463,"name":"aoz-003","full_name":"panter/aoz-003","owner":{"login":"panter","id":157435,"avatar_url":"https://avatars2.githubusercontent.com/u/157435?v=4","gravatar_id":"","url":"https://api.github.com/users/panter","html_url":"https://github.com/panter","followers_url":"https://api.github.com/users/panter/followers","following_url":"https://api.github.com/users/panter/following{/other_user}","gists_url":"https://api.github.com/users/panter/gists{/gist_id}","starred_url":"https://api.github.com/users/panter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panter/subscriptions","organizations_url":"https://api.github.com/users/panter/orgs","repos_url":"https://api.github.com/users/panter/repos","events_url":"https://api.github.com/users/panter/events{/privacy}","received_events_url":"https://api.github.com/users/panter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/panter/aoz-003","description":"AOZ Voluntary platform","fork":false,"url":"https://api.github.com/repos/panter/aoz-003","forks_url":"https://api.github.com/repos/panter/aoz-003/forks","keys_url":"https://api.github.com/repos/panter/aoz-003/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panter/aoz-003/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panter/aoz-003/teams","hooks_url":"https://api.github.com/repos/panter/aoz-003/hooks","issue_events_url":"https://api.github.com/repos/panter/aoz-003/issues/events{/number}","events_url":"https://api.github.com/repos/panter/aoz-003/events","assignees_url":"https://api.github.com/repos/panter/aoz-003/assignees{/user}","branches_url":"https://api.github.com/repos/panter/aoz-003/branches{/branch}","tags_url":"https://api.github.com/repos/panter/aoz-003/tags","blobs_url":"https://api.github.com/repos/panter/aoz-003/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panter/aoz-003/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panter/aoz-003/git/refs{/sha}","trees_url":"https://api.github.com/repos/panter/aoz-003/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panter/aoz-003/statuses/{sha}","languages_url":"https://api.github.com/repos/panter/aoz-003/languages","stargazers_url":"https://api.github.com/repos/panter/aoz-003/stargazers","contributors_url":"https://api.github.com/repos/panter/aoz-003/contributors","subscribers_url":"https://api.github.com/repos/panter/aoz-003/subscribers","subscription_url":"https://api.github.com/repos/panter/aoz-003/subscription","commits_url":"https://api.github.com/repos/panter/aoz-003/commits{/sha}","git_commits_url":"https://api.github.com/repos/panter/aoz-003/git/commits{/sha}","comments_url":"https://api.github.com/repos/panter/aoz-003/comments{/number}","issue_comment_url":"https://api.github.com/repos/panter/aoz-003/issues/comments{/number}","contents_url":"https://api.github.com/repos/panter/aoz-003/contents/{+path}","compare_url":"https://api.github.com/repos/panter/aoz-003/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panter/aoz-003/merges","archive_url":"https://api.github.com/repos/panter/aoz-003/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panter/aoz-003/downloads","issues_url":"https://api.github.com/repos/panter/aoz-003/issues{/number}","pulls_url":"https://api.github.com/repos/panter/aoz-003/pulls{/number}","milestones_url":"https://api.github.com/repos/panter/aoz-003/milestones{/number}","notifications_url":"https://api.github.com/repos/panter/aoz-003/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panter/aoz-003/labels{/name}","releases_url":"https://api.github.com/repos/panter/aoz-003/releases{/id}","deployments_url":"https://api.github.com/repos/panter/aoz-003/deployments","created_at":"2017-04-05T13:17:25Z","updated_at":"2017-04-06T07:25:36Z","pushed_at":"2017-10-09T08:49:47Z","git_url":"git://github.com/panter/aoz-003.git","ssh_url":"git@github.com:panter/aoz-003.git","clone_url":"https://github.com/panter/aoz-003.git","svn_url":"https://github.com/panter/aoz-003","homepage":"","size":1814,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":8,"forks":0,"open_issues":8,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/256"},"html":{"href":"https://github.com/panter/aoz-003/pull/256"},"issue":{"href":"https://api.github.com/repos/panter/aoz-003/issues/256"},"comments":{"href":"https://api.github.com/repos/panter/aoz-003/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/panter/aoz-003/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/panter/aoz-003/statuses/3bd5cde76c970502c09339067c2cdbda1688ce86"}},"author_association":"COLLABORATOR"}}
|
{
"id": 87311463,
"name": "panter/aoz-003",
"url": "https://api.github.com/repos/panter/aoz-003"
}
|
{
"id": 11731325,
"login": "nuritnt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11731325?",
"url": "https://api.github.com/users/nuritnt"
}
|
{
"id": 157435,
"login": "panter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/157435?",
"url": "https://api.github.com/orgs/panter"
}
| 2017-10-09T08:50:07 |
6690367819
|
{"actor":{"display_login":"nuritnt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/squbs/pulls/comments/153910694","pull_request_review_id":79991875,"id":153910694,"diff_hunk":"@@ -0,0 +1,85 @@\n+package org.squbs.lifecycle;\n+\n+import akka.actor.ActorRef;\n+import akka.actor.ActorSystem;\n+import akka.actor.Props;\n+import akka.testkit.javadsl.TestKit;\n+import org.junit.AfterClass;\n+import org.junit.BeforeClass;\n+import org.junit.Test;\n+\n+import java.util.Collections;\n+import java.util.concurrent.CompletableFuture;\n+import java.util.concurrent.CompletionStage;\n+import java.util.concurrent.TimeUnit;\n+\n+public class GracefulStopHelperTest {\n+\n+ static ActorSystem system;\n+\n+ @BeforeClass\n+ public static void setUp() {\n+ system = ActorSystem.create(\"GracefulStopHelperTest\");\n+ }\n+\n+ @AfterClass\n+ public static void tearDown() {\n+ TestKit.shutdownActorSystem(system);\n+ system = null;\n+ }\n+\n+\n+ @Test\n+ public void testStopFailed() {\n+ new TestKit(system) {{\n+ ActorRef actor = system.actorOf(Props.create(BadShutdownActor.class));\n+ actor.tell(\"Stop\", getRef());\n+ expectMsgEquals(\"Done\");\n+ }};\n+ }\n+\n+ @Test\n+ public void testStopSuccess() {","path":"squbs-unicomplex/src/test/java/org/squbs/lifecycle/GracefulStopHelperTest.java","position":42,"original_position":42,"commit_id":"f30d1174d4a08e0e2638e4e7d1c105eaa962ac28","original_commit_id":"f30d1174d4a08e0e2638e4e7d1c105eaa962ac28","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [JUnit tests should include assert() or fail()](https://www.codacy.com/app/akara-sucharitakul/squbs/pullRequest?prid=1083248)","created_at":"2017-11-29T20:48:43Z","updated_at":"2017-11-29T20:48:43Z","html_url":"https://github.com/paypal/squbs/pull/541#discussion_r153910694","pull_request_url":"https://api.github.com/repos/paypal/squbs/pulls/541","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/paypal/squbs/pulls/comments/153910694"},"html":{"href":"https://github.com/paypal/squbs/pull/541#discussion_r153910694"},"pull_request":{"href":"https://api.github.com/repos/paypal/squbs/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/squbs/pulls/541","id":153112879,"html_url":"https://github.com/paypal/squbs/pull/541","diff_url":"https://github.com/paypal/squbs/pull/541.diff","patch_url":"https://github.com/paypal/squbs/pull/541.patch","issue_url":"https://api.github.com/repos/paypal/squbs/issues/541","number":541,"state":"open","locked":false,"title":"#538: Added PerpetualStream Java API ","user":{"login":"akara","id":77111,"avatar_url":"https://avatars3.githubusercontent.com/u/77111?v=4","gravatar_id":"","url":"https://api.github.com/users/akara","html_url":"https://github.com/akara","followers_url":"https://api.github.com/users/akara/followers","following_url":"https://api.github.com/users/akara/following{/other_user}","gists_url":"https://api.github.com/users/akara/gists{/gist_id}","starred_url":"https://api.github.com/users/akara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akara/subscriptions","organizations_url":"https://api.github.com/users/akara/orgs","repos_url":"https://api.github.com/users/akara/repos","events_url":"https://api.github.com/users/akara/events{/privacy}","received_events_url":"https://api.github.com/users/akara/received_events","type":"User","site_admin":false},"body":"And beefed up Java support around the API usage.\r\n\r\n\r\nThanks for your pull request. Please review the following guidelines.\r\n\r\n- [X] Title includes issue id.\r\n- [X] Description of the change added.\r\n- [x] Commits are squashed.\r\n- [X] Tests added.\r\n- [x] Documentation added/updated.\r\n- [X] Also please review [CONTRIBUTING.md](https://github.com/paypal/squbs/blob/master/CONTRIBUTING.md).\r\n","created_at":"2017-11-16T18:11:48Z","updated_at":"2017-11-29T20:48:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1befa6df24aa8d14bbeb4585a4e83fa009b364ed","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/squbs/pulls/541/commits","review_comments_url":"https://api.github.com/repos/paypal/squbs/pulls/541/comments","review_comment_url":"https://api.github.com/repos/paypal/squbs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/squbs/issues/541/comments","statuses_url":"https://api.github.com/repos/paypal/squbs/statuses/f30d1174d4a08e0e2638e4e7d1c105eaa962ac28","head":{"label":"akara:issue538","ref":"issue538","sha":"f30d1174d4a08e0e2638e4e7d1c105eaa962ac28","user":{"login":"akara","id":77111,"avatar_url":"https://avatars3.githubusercontent.com/u/77111?v=4","gravatar_id":"","url":"https://api.github.com/users/akara","html_url":"https://github.com/akara","followers_url":"https://api.github.com/users/akara/followers","following_url":"https://api.github.com/users/akara/following{/other_user}","gists_url":"https://api.github.com/users/akara/gists{/gist_id}","starred_url":"https://api.github.com/users/akara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akara/subscriptions","organizations_url":"https://api.github.com/users/akara/orgs","repos_url":"https://api.github.com/users/akara/repos","events_url":"https://api.github.com/users/akara/events{/privacy}","received_events_url":"https://api.github.com/users/akara/received_events","type":"User","site_admin":false},"repo":{"id":40934086,"name":"squbs","full_name":"akara/squbs","owner":{"login":"akara","id":77111,"avatar_url":"https://avatars3.githubusercontent.com/u/77111?v=4","gravatar_id":"","url":"https://api.github.com/users/akara","html_url":"https://github.com/akara","followers_url":"https://api.github.com/users/akara/followers","following_url":"https://api.github.com/users/akara/following{/other_user}","gists_url":"https://api.github.com/users/akara/gists{/gist_id}","starred_url":"https://api.github.com/users/akara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akara/subscriptions","organizations_url":"https://api.github.com/users/akara/orgs","repos_url":"https://api.github.com/users/akara/repos","events_url":"https://api.github.com/users/akara/events{/privacy}","received_events_url":"https://api.github.com/users/akara/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akara/squbs","description":null,"fork":true,"url":"https://api.github.com/repos/akara/squbs","forks_url":"https://api.github.com/repos/akara/squbs/forks","keys_url":"https://api.github.com/repos/akara/squbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akara/squbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akara/squbs/teams","hooks_url":"https://api.github.com/repos/akara/squbs/hooks","issue_events_url":"https://api.github.com/repos/akara/squbs/issues/events{/number}","events_url":"https://api.github.com/repos/akara/squbs/events","assignees_url":"https://api.github.com/repos/akara/squbs/assignees{/user}","branches_url":"https://api.github.com/repos/akara/squbs/branches{/branch}","tags_url":"https://api.github.com/repos/akara/squbs/tags","blobs_url":"https://api.github.com/repos/akara/squbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akara/squbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akara/squbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/akara/squbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akara/squbs/statuses/{sha}","languages_url":"https://api.github.com/repos/akara/squbs/languages","stargazers_url":"https://api.github.com/repos/akara/squbs/stargazers","contributors_url":"https://api.github.com/repos/akara/squbs/contributors","subscribers_url":"https://api.github.com/repos/akara/squbs/subscribers","subscription_url":"https://api.github.com/repos/akara/squbs/subscription","commits_url":"https://api.github.com/repos/akara/squbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/akara/squbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/akara/squbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/akara/squbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/akara/squbs/contents/{+path}","compare_url":"https://api.github.com/repos/akara/squbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akara/squbs/merges","archive_url":"https://api.github.com/repos/akara/squbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akara/squbs/downloads","issues_url":"https://api.github.com/repos/akara/squbs/issues{/number}","pulls_url":"https://api.github.com/repos/akara/squbs/pulls{/number}","milestones_url":"https://api.github.com/repos/akara/squbs/milestones{/number}","notifications_url":"https://api.github.com/repos/akara/squbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akara/squbs/labels{/name}","releases_url":"https://api.github.com/repos/akara/squbs/releases{/id}","deployments_url":"https://api.github.com/repos/akara/squbs/deployments","created_at":"2015-08-17T22:35:29Z","updated_at":"2016-05-05T19:23:24Z","pushed_at":"2017-11-29T20:44:13Z","git_url":"git://github.com/akara/squbs.git","ssh_url":"git@github.com:akara/squbs.git","clone_url":"https://github.com/akara/squbs.git","svn_url":"https://github.com/akara/squbs","homepage":null,"size":6963,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"71d306afd73b56dbd5121c69512495f98500f727","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":38714007,"name":"squbs","full_name":"paypal/squbs","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/squbs","description":"Akka/Akka HTTP for Large-Scale Production Deployments","fork":false,"url":"https://api.github.com/repos/paypal/squbs","forks_url":"https://api.github.com/repos/paypal/squbs/forks","keys_url":"https://api.github.com/repos/paypal/squbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/squbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/squbs/teams","hooks_url":"https://api.github.com/repos/paypal/squbs/hooks","issue_events_url":"https://api.github.com/repos/paypal/squbs/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/squbs/events","assignees_url":"https://api.github.com/repos/paypal/squbs/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/squbs/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/squbs/tags","blobs_url":"https://api.github.com/repos/paypal/squbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/squbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/squbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/squbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/squbs/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/squbs/languages","stargazers_url":"https://api.github.com/repos/paypal/squbs/stargazers","contributors_url":"https://api.github.com/repos/paypal/squbs/contributors","subscribers_url":"https://api.github.com/repos/paypal/squbs/subscribers","subscription_url":"https://api.github.com/repos/paypal/squbs/subscription","commits_url":"https://api.github.com/repos/paypal/squbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/squbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/squbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/squbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/squbs/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/squbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/squbs/merges","archive_url":"https://api.github.com/repos/paypal/squbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/squbs/downloads","issues_url":"https://api.github.com/repos/paypal/squbs/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/squbs/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/squbs/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/squbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/squbs/labels{/name}","releases_url":"https://api.github.com/repos/paypal/squbs/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/squbs/deployments","created_at":"2015-07-07T20:48:12Z","updated_at":"2017-11-29T20:28:59Z","pushed_at":"2017-11-29T20:44:15Z","git_url":"git://github.com/paypal/squbs.git","ssh_url":"git@github.com:paypal/squbs.git","clone_url":"https://github.com/paypal/squbs.git","svn_url":"https://github.com/paypal/squbs","homepage":"http://paypal.github.io/squbs","size":7011,"stargazers_count":981,"watchers_count":981,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":174,"open_issues":59,"watchers":981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/squbs/pulls/541"},"html":{"href":"https://github.com/paypal/squbs/pull/541"},"issue":{"href":"https://api.github.com/repos/paypal/squbs/issues/541"},"comments":{"href":"https://api.github.com/repos/paypal/squbs/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/squbs/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/squbs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/squbs/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/squbs/statuses/f30d1174d4a08e0e2638e4e7d1c105eaa962ac28"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38714007,
"name": "paypal/squbs",
"url": "https://api.github.com/repos/paypal/squbs"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 476675,
"login": "paypal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/476675?",
"url": "https://api.github.com/orgs/paypal"
}
| 2017-11-29T20:48:43 |
6921095721
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pol-is/polisServer/pulls/comments/142056378","pull_request_review_id":66363433,"id":142056378,"diff_hunk":"@@ -4,3 +4,52 @@ pol.is an AI powered sentiment gathering platform. More organic than surveys, le\n If you don't want to deploy your own instance of Polis, you can use our SaaS version [here](https://pol.is/home)\n Polis [can be easily embedded](http://docs.pol.is/usage/Embedding.html) on your page as an iframe.\n \n+## Installation\n+\n+### Dependencies\n+\n+* PostgreSql `(>= 9.5.4.1)`\n+* Node `6.11.1`\n+We recommend installing [nvm](https://github.com/creationix/nvm) so you can easily switch between your favorite flavors of node.\n+* NPM `3.3.8`\n+\n+### Setup\n+\n+1. Create a new datbase. You can name it whatever you please.\n+ ```sh\n+ create database polis;","path":"README.md","position":17,"original_position":17,"commit_id":"3ed7eb3b79fb56c2e525ab4f56ac336bd8c2a6ed","original_commit_id":"3ed7eb3b79fb56c2e525ab4f56ac336bd8c2a6ed","user":{"login":"crkrenn","id":6069975,"avatar_url":"https://avatars2.githubusercontent.com/u/6069975?v=4","gravatar_id":"","url":"https://api.github.com/users/crkrenn","html_url":"https://github.com/crkrenn","followers_url":"https://api.github.com/users/crkrenn/followers","following_url":"https://api.github.com/users/crkrenn/following{/other_user}","gists_url":"https://api.github.com/users/crkrenn/gists{/gist_id}","starred_url":"https://api.github.com/users/crkrenn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crkrenn/subscriptions","organizations_url":"https://api.github.com/users/crkrenn/orgs","repos_url":"https://api.github.com/users/crkrenn/repos","events_url":"https://api.github.com/users/crkrenn/events{/privacy}","received_events_url":"https://api.github.com/users/crkrenn/received_events","type":"User","site_admin":false},"body":"With postgres 9.5, the following worked for me: \r\n sudo -u postgres createdb polis\r\n","created_at":"2017-10-02T04:23:52Z","updated_at":"2017-10-02T04:23:52Z","html_url":"https://github.com/pol-is/polisServer/pull/11#discussion_r142056378","pull_request_url":"https://api.github.com/repos/pol-is/polisServer/pulls/11","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/comments/142056378"},"html":{"href":"https://github.com/pol-is/polisServer/pull/11#discussion_r142056378"},"pull_request":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/11"}},"in_reply_to_id":141513418},"pull_request":{"url":"https://api.github.com/repos/pol-is/polisServer/pulls/11","id":143540735,"html_url":"https://github.com/pol-is/polisServer/pull/11","diff_url":"https://github.com/pol-is/polisServer/pull/11.diff","patch_url":"https://github.com/pol-is/polisServer/pull/11.patch","issue_url":"https://api.github.com/repos/pol-is/polisServer/issues/11","number":11,"state":"open","locked":false,"title":"[WIP] Update readme","user":{"login":"misscs","id":51812,"avatar_url":"https://avatars1.githubusercontent.com/u/51812?v=4","gravatar_id":"","url":"https://api.github.com/users/misscs","html_url":"https://github.com/misscs","followers_url":"https://api.github.com/users/misscs/followers","following_url":"https://api.github.com/users/misscs/following{/other_user}","gists_url":"https://api.github.com/users/misscs/gists{/gist_id}","starred_url":"https://api.github.com/users/misscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misscs/subscriptions","organizations_url":"https://api.github.com/users/misscs/orgs","repos_url":"https://api.github.com/users/misscs/repos","events_url":"https://api.github.com/users/misscs/events{/privacy}","received_events_url":"https://api.github.com/users/misscs/received_events","type":"User","site_admin":false},"body":"### Issues(s)\r\n\r\nUpdate project README to include instructions for setting up a local instance of the server\r\n\r\n### Outstanding tasks\r\n\r\n- [ ] Proof-read\r\n- [ ] Have someone (@patcon, perhaps) test out the direction and leave feedback\r\n- [ ] Update README \r\n\r\n","created_at":"2017-09-28T02:16:38Z","updated_at":"2017-10-02T04:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b1028c844e8438a0f5b975b175a810a521c5ee8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pol-is/polisServer/pulls/11/commits","review_comments_url":"https://api.github.com/repos/pol-is/polisServer/pulls/11/comments","review_comment_url":"https://api.github.com/repos/pol-is/polisServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pol-is/polisServer/issues/11/comments","statuses_url":"https://api.github.com/repos/pol-is/polisServer/statuses/3ed7eb3b79fb56c2e525ab4f56ac336bd8c2a6ed","head":{"label":"misscs:update-readme","ref":"update-readme","sha":"3ed7eb3b79fb56c2e525ab4f56ac336bd8c2a6ed","user":{"login":"misscs","id":51812,"avatar_url":"https://avatars1.githubusercontent.com/u/51812?v=4","gravatar_id":"","url":"https://api.github.com/users/misscs","html_url":"https://github.com/misscs","followers_url":"https://api.github.com/users/misscs/followers","following_url":"https://api.github.com/users/misscs/following{/other_user}","gists_url":"https://api.github.com/users/misscs/gists{/gist_id}","starred_url":"https://api.github.com/users/misscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misscs/subscriptions","organizations_url":"https://api.github.com/users/misscs/orgs","repos_url":"https://api.github.com/users/misscs/repos","events_url":"https://api.github.com/users/misscs/events{/privacy}","received_events_url":"https://api.github.com/users/misscs/received_events","type":"User","site_admin":false},"repo":{"id":105080214,"name":"polisServer","full_name":"misscs/polisServer","owner":{"login":"misscs","id":51812,"avatar_url":"https://avatars1.githubusercontent.com/u/51812?v=4","gravatar_id":"","url":"https://api.github.com/users/misscs","html_url":"https://github.com/misscs","followers_url":"https://api.github.com/users/misscs/followers","following_url":"https://api.github.com/users/misscs/following{/other_user}","gists_url":"https://api.github.com/users/misscs/gists{/gist_id}","starred_url":"https://api.github.com/users/misscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misscs/subscriptions","organizations_url":"https://api.github.com/users/misscs/orgs","repos_url":"https://api.github.com/users/misscs/repos","events_url":"https://api.github.com/users/misscs/events{/privacy}","received_events_url":"https://api.github.com/users/misscs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misscs/polisServer","description":null,"fork":true,"url":"https://api.github.com/repos/misscs/polisServer","forks_url":"https://api.github.com/repos/misscs/polisServer/forks","keys_url":"https://api.github.com/repos/misscs/polisServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misscs/polisServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misscs/polisServer/teams","hooks_url":"https://api.github.com/repos/misscs/polisServer/hooks","issue_events_url":"https://api.github.com/repos/misscs/polisServer/issues/events{/number}","events_url":"https://api.github.com/repos/misscs/polisServer/events","assignees_url":"https://api.github.com/repos/misscs/polisServer/assignees{/user}","branches_url":"https://api.github.com/repos/misscs/polisServer/branches{/branch}","tags_url":"https://api.github.com/repos/misscs/polisServer/tags","blobs_url":"https://api.github.com/repos/misscs/polisServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misscs/polisServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misscs/polisServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/misscs/polisServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misscs/polisServer/statuses/{sha}","languages_url":"https://api.github.com/repos/misscs/polisServer/languages","stargazers_url":"https://api.github.com/repos/misscs/polisServer/stargazers","contributors_url":"https://api.github.com/repos/misscs/polisServer/contributors","subscribers_url":"https://api.github.com/repos/misscs/polisServer/subscribers","subscription_url":"https://api.github.com/repos/misscs/polisServer/subscription","commits_url":"https://api.github.com/repos/misscs/polisServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/misscs/polisServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/misscs/polisServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/misscs/polisServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/misscs/polisServer/contents/{+path}","compare_url":"https://api.github.com/repos/misscs/polisServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misscs/polisServer/merges","archive_url":"https://api.github.com/repos/misscs/polisServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misscs/polisServer/downloads","issues_url":"https://api.github.com/repos/misscs/polisServer/issues{/number}","pulls_url":"https://api.github.com/repos/misscs/polisServer/pulls{/number}","milestones_url":"https://api.github.com/repos/misscs/polisServer/milestones{/number}","notifications_url":"https://api.github.com/repos/misscs/polisServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misscs/polisServer/labels{/name}","releases_url":"https://api.github.com/repos/misscs/polisServer/releases{/id}","deployments_url":"https://api.github.com/repos/misscs/polisServer/deployments","created_at":"2017-09-27T23:36:24Z","updated_at":"2017-09-27T23:36:25Z","pushed_at":"2017-09-28T02:14:39Z","git_url":"git://github.com/misscs/polisServer.git","ssh_url":"git@github.com:misscs/polisServer.git","clone_url":"https://github.com/misscs/polisServer.git","svn_url":"https://github.com/misscs/polisServer","homepage":null,"size":15390,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pol-is:master","ref":"master","sha":"765e77c13c92506ca2d3d5754aac9b0314166ea3","user":{"login":"pol-is","id":19353909,"avatar_url":"https://avatars3.githubusercontent.com/u/19353909?v=4","gravatar_id":"","url":"https://api.github.com/users/pol-is","html_url":"https://github.com/pol-is","followers_url":"https://api.github.com/users/pol-is/followers","following_url":"https://api.github.com/users/pol-is/following{/other_user}","gists_url":"https://api.github.com/users/pol-is/gists{/gist_id}","starred_url":"https://api.github.com/users/pol-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pol-is/subscriptions","organizations_url":"https://api.github.com/users/pol-is/orgs","repos_url":"https://api.github.com/users/pol-is/repos","events_url":"https://api.github.com/users/pol-is/events{/privacy}","received_events_url":"https://api.github.com/users/pol-is/received_events","type":"Organization","site_admin":false},"repo":{"id":75125125,"name":"polisServer","full_name":"pol-is/polisServer","owner":{"login":"pol-is","id":19353909,"avatar_url":"https://avatars3.githubusercontent.com/u/19353909?v=4","gravatar_id":"","url":"https://api.github.com/users/pol-is","html_url":"https://github.com/pol-is","followers_url":"https://api.github.com/users/pol-is/followers","following_url":"https://api.github.com/users/pol-is/following{/other_user}","gists_url":"https://api.github.com/users/pol-is/gists{/gist_id}","starred_url":"https://api.github.com/users/pol-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pol-is/subscriptions","organizations_url":"https://api.github.com/users/pol-is/orgs","repos_url":"https://api.github.com/users/pol-is/repos","events_url":"https://api.github.com/users/pol-is/events{/privacy}","received_events_url":"https://api.github.com/users/pol-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pol-is/polisServer","description":null,"fork":false,"url":"https://api.github.com/repos/pol-is/polisServer","forks_url":"https://api.github.com/repos/pol-is/polisServer/forks","keys_url":"https://api.github.com/repos/pol-is/polisServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pol-is/polisServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pol-is/polisServer/teams","hooks_url":"https://api.github.com/repos/pol-is/polisServer/hooks","issue_events_url":"https://api.github.com/repos/pol-is/polisServer/issues/events{/number}","events_url":"https://api.github.com/repos/pol-is/polisServer/events","assignees_url":"https://api.github.com/repos/pol-is/polisServer/assignees{/user}","branches_url":"https://api.github.com/repos/pol-is/polisServer/branches{/branch}","tags_url":"https://api.github.com/repos/pol-is/polisServer/tags","blobs_url":"https://api.github.com/repos/pol-is/polisServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pol-is/polisServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pol-is/polisServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/pol-is/polisServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pol-is/polisServer/statuses/{sha}","languages_url":"https://api.github.com/repos/pol-is/polisServer/languages","stargazers_url":"https://api.github.com/repos/pol-is/polisServer/stargazers","contributors_url":"https://api.github.com/repos/pol-is/polisServer/contributors","subscribers_url":"https://api.github.com/repos/pol-is/polisServer/subscribers","subscription_url":"https://api.github.com/repos/pol-is/polisServer/subscription","commits_url":"https://api.github.com/repos/pol-is/polisServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/pol-is/polisServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/pol-is/polisServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/pol-is/polisServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/pol-is/polisServer/contents/{+path}","compare_url":"https://api.github.com/repos/pol-is/polisServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pol-is/polisServer/merges","archive_url":"https://api.github.com/repos/pol-is/polisServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pol-is/polisServer/downloads","issues_url":"https://api.github.com/repos/pol-is/polisServer/issues{/number}","pulls_url":"https://api.github.com/repos/pol-is/polisServer/pulls{/number}","milestones_url":"https://api.github.com/repos/pol-is/polisServer/milestones{/number}","notifications_url":"https://api.github.com/repos/pol-is/polisServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pol-is/polisServer/labels{/name}","releases_url":"https://api.github.com/repos/pol-is/polisServer/releases{/id}","deployments_url":"https://api.github.com/repos/pol-is/polisServer/deployments","created_at":"2016-11-29T21:47:47Z","updated_at":"2017-09-20T21:35:14Z","pushed_at":"2017-09-29T00:47:11Z","git_url":"git://github.com/pol-is/polisServer.git","ssh_url":"git@github.com:pol-is/polisServer.git","clone_url":"https://github.com/pol-is/polisServer.git","svn_url":"https://github.com/pol-is/polisServer","homepage":null,"size":15389,"stargazers_count":28,"watchers_count":28,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/11"},"html":{"href":"https://github.com/pol-is/polisServer/pull/11"},"issue":{"href":"https://api.github.com/repos/pol-is/polisServer/issues/11"},"comments":{"href":"https://api.github.com/repos/pol-is/polisServer/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pol-is/polisServer/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/pol-is/polisServer/statuses/3ed7eb3b79fb56c2e525ab4f56ac336bd8c2a6ed"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 75125125,
"name": "pol-is/polisServer",
"url": "https://api.github.com/repos/pol-is/polisServer"
}
|
{
"id": 6069975,
"login": "crkrenn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6069975?",
"url": "https://api.github.com/users/crkrenn"
}
|
{
"id": 19353909,
"login": "pol-is",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19353909?",
"url": "https://api.github.com/orgs/pol-is"
}
| 2017-10-02T04:23:52 |
6660853759
|
{"actor":{"display_login":"crkrenn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/python/typeshed/pulls/comments/113014631","pull_request_review_id":34372110,"id":113014631,"diff_hunk":"@@ -0,0 +1,193 @@\n+# Stubs for xmlrpclib (Python 2)\n+\n+from typing import Any, AnyStr, Callable, IO, Iterable, List, Mapping, MutableMapping, Optional, Tuple, Type, TypeVar, Union\n+from datetime import datetime\n+from time import struct_time\n+from httplib import HTTPConnection, HTTPResponse, HTTPSConnection\n+from ssl import SSLContext\n+from StringIO import StringIO\n+\n+_Unmarshaller = TypeVar('_Unmarshaller')\n+_timeTuple = Tuple[int, int, int, int, int, int, int, int, int]\n+# Represents types that can be compared against a DateTime object\n+_dateTimeComp = Union[AnyStr, DateTime, datetime, _timeTuple]\n+# A \"host description\" used by Transport factories\n+_hostDesc = Union[str, Tuple[str, Mapping[Any, Any]]]\n+\n+def escape(s: AnyStr, replace: Callable[[AnyStr, AnyStr, AnyStr], AnyStr] = ...) -> AnyStr: ...\n+\n+MAXINT = ... # type: int\n+MININT = ... # type: int\n+PARSE_ERROR = ... # type: int\n+SERVER_ERROR = ... # type: int\n+APPLICATION_ERROR = ... # type: int\n+SYSTEM_ERROR = ... # type: int\n+TRANSPORT_ERROR = ... # type: int\n+NOT_WELLFORMED_ERROR = ... # type: int\n+UNSUPPORTED_ENCODING = ... # type: int\n+INVALID_ENCODING_CHAR = ... # type: int\n+INVALID_XMLRPC = ... # type: int\n+METHOD_NOT_FOUND = ... # type: int\n+INVALID_METHOD_PARAMS = ... # type: int\n+INTERNAL_ERROR = ... # type: int\n+\n+class Error(Exception): ...\n+\n+class ProtocolError(Error):\n+ url = ... # type: str\n+ errcode = ... # type: int\n+ errmsg = ... # type: str\n+ headers = ... # type: Mapping[str, str]\n+ def __init__(self, url, errcode, errmsg, headers) -> None: ...\n+\n+class ResponseError(Error): ...\n+\n+class Fault(Error):\n+ faultCode = ... # type: Any\n+ faultString = ... # type: str\n+ def __init__(self, faultCode: Any, faultString: str, **extra: Any) -> None: ...\n+\n+boolean = ... # type: Type[bool]\n+Boolean = ... # type: Type[bool]\n+\n+class DateTime:\n+ value = ... # type: str\n+ def __init__(self, value: Union[AnyStr, datetime, float, int, _timeTuple] = ...) -> None: ...\n+ def make_comparable(self, other: _dateTimeComp) -> Tuple[_dateTimeComp, _dateTimeComp]: ...\n+ def __lt__(self, other: _dateTimeComp) -> bool: ...\n+ def __le__(self, other: _dateTimeComp) -> bool: ...\n+ def __gt__(self, other: _dateTimeComp) -> bool: ...\n+ def __ge__(self, other: _dateTimeComp) -> bool: ...\n+ def __eq__(self, other: _dateTimeComp) -> bool: ...\n+ def __ne__(self, other: _dateTimeComp) -> bool: ...\n+ def timetuple(self) -> struct_time: ...\n+ def __cmp__(self, other: _dateTimeComp) -> int: ...\n+ def decode(self, data: Any) -> None: ...\n+ def encode(self, out: IO) -> None: ...\n+\n+class Binary:\n+ data = ... # type: str\n+ def __init__(self, data: Optional[str] = ...) -> None: ...\n+ def __cmp__(self, other: Any) -> int: ...\n+ def decode(self, data: str) -> None: ...\n+ def encode(self, out: IO) -> None: ...\n+\n+WRAPPERS = ... # type: tuple\n+\n+# Still part of the public API, but see http://bugs.python.org/issue1773632\n+FastParser = ... # type: None\n+FastUnmarshaller = ... # type: None\n+FastMarshaller = ... # type: None\n+\n+# I'm going to assume, quite reasonably, that we'll have xml.parsers.expat\n+# available.\n+class ExpatParser:\n+ def __init__(self, target: _Unmarshaller) -> None: ...\n+ def feed(self, data: str): ...\n+ def close(self): ...\n+\n+class SlowParser:\n+ handle_xml = ... # type: Callable[[str, bool], None]\n+ unknown_starttag = ... # type: Callable[[str, Any], None]\n+ handle_data = ... # type: Callable[[str], None]\n+ handle_cdata = ... # type: Callable[[str], None]\n+ unknown_endtag = ... # type: Callable[[str, Callable[[Iterable[str], str], str]], None]\n+ def __init__(self, target: _Unmarshaller) -> None: ...\n+\n+class Marshaller:\n+ memo = ... # type: MutableMapping[int, Any]\n+ data = ... # type: str\n+ encoding = ... # type: Optional[str]\n+ allow_none = ... # type: bool\n+ def __init__(self, encoding: Optional[str] = ..., allow_none: bool = ...) -> None: ...\n+ dispatch = ... # type: Mapping[type, Callable[[Marshaller, str, Callable[[str], None]], None]]\n+ def dumps(self, values: Iterable[str]) -> str: ...\n+ def dump_nil(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_int(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_bool(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_long(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_double(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_string(self, value: str, write: Callable[[str], None], escape: Callable[[AnyStr, Callable[[AnyStr, AnyStr, AnyStr], AnyStr]], AnyStr] = ...) -> None: ...\n+ def dump_unicode(self, value: str, write: Callable[[str], None], escape: Callable[[AnyStr, Callable[[AnyStr, AnyStr, AnyStr], AnyStr]], AnyStr] = ...) -> None: ...\n+ def dump_array(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_struct(self, value: str, write: Callable[[str], None], escape: Callable[[AnyStr, Callable[[AnyStr, AnyStr, AnyStr], AnyStr]], AnyStr] = ...) -> None: ...\n+ def dump_datetime(self, value: str, write: Callable[[str], None]) -> None: ...\n+ def dump_instance(self, value: str, write: Callable[[str], None]) -> None: ...\n+\n+class Unmarshaller:\n+ def append(self, object: Any) -> None: ...\n+ def __init__(self, use_datetime: bool = ...) -> None: ...\n+ def close(self) -> tuple: ...\n+ def getmethodname(self) -> Optional[str]: ...\n+ def xml(self, encoding: str, standalone: bool) -> None: ...\n+ def start(self, tag: str, attrs: Any) -> None: ...\n+ def data(self, text: str) -> None: ...\n+ def end(self, tag: str, join: Callable[[Iterable[str], str], str] = ...) -> None: ...\n+ def end_dispatch(self, tag: str, data: str) -> None: ...\n+ dispatch = ... # type: Mapping[str, Callable[[Unmarshaller, str], None]]\n+ def end_nil(self, data: str): ...\n+ def end_boolean(self, data: str) -> None: ...\n+ def end_int(self, data: str) -> None: ...\n+ def end_double(self, data: str) -> None: ...\n+ def end_string(self, data: str) -> None: ...\n+ def end_array(self, data: str) -> None: ...\n+ def end_struct(self, data: str) -> None: ...\n+ def end_base64(self, data: str) -> None: ...\n+ def end_dateTime(self, data: str) -> None: ...\n+ def end_value(self, data: str) -> None: ...\n+ def end_params(self, data: str) -> None: ...\n+ def end_fault(self, data: str) -> None: ...\n+ def end_methodName(self, data: str) -> None: ...\n+\n+class _MultiCallMethod: ...\n+class MultiCallIterator: ...\n+\n+class MultiCall:\n+ def __init__(self, server: ServerProxy) -> None: ...\n+ def __getattr__(self, name: str) -> _MultiCallMethod: ...\n+ def __call__(self) -> MultiCallIterator: ...\n+\n+def getparser(use_datetime: bool = ...) -> Tuple[Union[ExpatParser, SlowParser], Unmarshaller]: ...\n+def dumps(params: Union[tuple, Fault], methodname: Optional[str] = ..., methodresponse: Optional[bool] = ..., encoding: Optional[str] = ..., allow_none: bool = ...) -> str: ...\n+def loads(data: str, use_datetime: bool = ...) -> Tuple[tuple, str]: ...\n+\n+def gzip_encode(data: str) -> str: ...\n+def gzip_decode(data: str, max_decode: int = ...) -> str: ...\n+\n+class GzipDecodedResponse:\n+ stringio = ... # type: StringIO\n+ def __init__(self, response: HTTPResponse) -> None: ...\n+ def close(self): ...\n+\n+class _Method:\n+ def __init__(self, send: Callable[[str, tuple], Any], name: str) -> None: ...\n+ def __getattr__(self, name: str) -> _Method: ...\n+ def __call__(self, *args: tuple) -> Any: ...\n+\n+class Transport:\n+ user_agent = ... # type: str\n+ accept_gzip_encoding = ... # type: bool\n+ encode_threshold = ... # type: Optional[int]\n+ def __init__(self, use_datetime: bool = ...) -> None: ...\n+ def request(self, host: _hostDesc, handler, request_body: str, verbose: bool = ...) -> tuple: ...\n+ verbose = ... # type: bool\n+ def single_request(self, host: _hostDesc, handler, request_body: str, verbose: bool = ...) -> tuple: ...\n+ def getparser(self) -> Tuple[Union[ExpatParser, SlowParser], Unmarshaller]: ...\n+ def get_host_info(self, host: _hostDesc) -> Tuple[str, Optional[List[tuple]], Optional[Mapping[Any, Any]]]: ...\n+ def make_connection(self, host: _hostDesc) -> HTTPConnection: ...\n+ def close(self) -> None: ...\n+ def send_request(self, connection: HTTPConnection, handler, request_body: str) -> None: ...\n+ def send_host(self, connection: HTTPConnection, host: str) -> None: ...\n+ def send_user_agent(self, connection: HTTPConnection) -> None: ...\n+ def send_content(self, connection: HTTPConnection, request_body: str) -> None: ...\n+ def parse_response(self, response: HTTPResponse) -> tuple: ...\n+\n+class SafeTransport(Transport):\n+ def __init__(self, use_datetime: bool = ..., context: Optional[SSLContext] = ...) -> None: ...\n+ def make_connection(self, host: _hostDesc) -> HTTPSConnection: ...\n+\n+class ServerProxy:\n+ def __init__(self, uri: str, transport: Optional[Union[Transport, SafeTransport]] = ..., encoding: Optional[str] = ..., verbose: bool = ..., allow_none: bool = ..., use_datetime: bool = ...) -> None: ...\n+ def __getattr__(self, name: str) -> _Method: ...","path":"stdlib/2/xmlrpclib.pyi","position":191,"original_position":191,"commit_id":"91a692db5d3f1b86116cd23379d8f40486d37042","original_commit_id":"91a692db5d3f1b86116cd23379d8f40486d37042","user":{"login":"Solumin","id":930857,"avatar_url":"https://avatars3.githubusercontent.com/u/930857?v=3","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-04-24T17:59:43Z","updated_at":"2017-04-24T17:59:43Z","html_url":"https://github.com/python/typeshed/pull/1185#discussion_r113014631","pull_request_url":"https://api.github.com/repos/python/typeshed/pulls/1185","_links":{"self":{"href":"https://api.github.com/repos/python/typeshed/pulls/comments/113014631"},"html":{"href":"https://github.com/python/typeshed/pull/1185#discussion_r113014631"},"pull_request":{"href":"https://api.github.com/repos/python/typeshed/pulls/1185"}}},"pull_request":{"url":"https://api.github.com/repos/python/typeshed/pulls/1185","id":117019723,"html_url":"https://github.com/python/typeshed/pull/1185","diff_url":"https://github.com/python/typeshed/pull/1185.diff","patch_url":"https://github.com/python/typeshed/pull/1185.patch","issue_url":"https://api.github.com/repos/python/typeshed/issues/1185","number":1185,"state":"open","locked":false,"title":"Created stubs for xmlrpclib [Python 2.7]","user":{"login":"Solumin","id":930857,"avatar_url":"https://avatars3.githubusercontent.com/u/930857?v=3","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-21T16:14:59Z","updated_at":"2017-04-24T17:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e29467fbaa92c9a360410d5ddd78f6865d8c02f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/typeshed/pulls/1185/commits","review_comments_url":"https://api.github.com/repos/python/typeshed/pulls/1185/comments","review_comment_url":"https://api.github.com/repos/python/typeshed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/typeshed/issues/1185/comments","statuses_url":"https://api.github.com/repos/python/typeshed/statuses/91a692db5d3f1b86116cd23379d8f40486d37042","head":{"label":"Solumin:xmlrpclib","ref":"xmlrpclib","sha":"91a692db5d3f1b86116cd23379d8f40486d37042","user":{"login":"Solumin","id":930857,"avatar_url":"https://avatars3.githubusercontent.com/u/930857?v=3","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"repo":{"id":88535760,"name":"typeshed","full_name":"Solumin/typeshed","owner":{"login":"Solumin","id":930857,"avatar_url":"https://avatars3.githubusercontent.com/u/930857?v=3","gravatar_id":"","url":"https://api.github.com/users/Solumin","html_url":"https://github.com/Solumin","followers_url":"https://api.github.com/users/Solumin/followers","following_url":"https://api.github.com/users/Solumin/following{/other_user}","gists_url":"https://api.github.com/users/Solumin/gists{/gist_id}","starred_url":"https://api.github.com/users/Solumin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Solumin/subscriptions","organizations_url":"https://api.github.com/users/Solumin/orgs","repos_url":"https://api.github.com/users/Solumin/repos","events_url":"https://api.github.com/users/Solumin/events{/privacy}","received_events_url":"https://api.github.com/users/Solumin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Solumin/typeshed","description":"Collection of library stubs for Python, with static types","fork":true,"url":"https://api.github.com/repos/Solumin/typeshed","forks_url":"https://api.github.com/repos/Solumin/typeshed/forks","keys_url":"https://api.github.com/repos/Solumin/typeshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Solumin/typeshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Solumin/typeshed/teams","hooks_url":"https://api.github.com/repos/Solumin/typeshed/hooks","issue_events_url":"https://api.github.com/repos/Solumin/typeshed/issues/events{/number}","events_url":"https://api.github.com/repos/Solumin/typeshed/events","assignees_url":"https://api.github.com/repos/Solumin/typeshed/assignees{/user}","branches_url":"https://api.github.com/repos/Solumin/typeshed/branches{/branch}","tags_url":"https://api.github.com/repos/Solumin/typeshed/tags","blobs_url":"https://api.github.com/repos/Solumin/typeshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Solumin/typeshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Solumin/typeshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/Solumin/typeshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Solumin/typeshed/statuses/{sha}","languages_url":"https://api.github.com/repos/Solumin/typeshed/languages","stargazers_url":"https://api.github.com/repos/Solumin/typeshed/stargazers","contributors_url":"https://api.github.com/repos/Solumin/typeshed/contributors","subscribers_url":"https://api.github.com/repos/Solumin/typeshed/subscribers","subscription_url":"https://api.github.com/repos/Solumin/typeshed/subscription","commits_url":"https://api.github.com/repos/Solumin/typeshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/Solumin/typeshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/Solumin/typeshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/Solumin/typeshed/issues/comments{/number}","contents_url":"https://api.github.com/repos/Solumin/typeshed/contents/{+path}","compare_url":"https://api.github.com/repos/Solumin/typeshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Solumin/typeshed/merges","archive_url":"https://api.github.com/repos/Solumin/typeshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Solumin/typeshed/downloads","issues_url":"https://api.github.com/repos/Solumin/typeshed/issues{/number}","pulls_url":"https://api.github.com/repos/Solumin/typeshed/pulls{/number}","milestones_url":"https://api.github.com/repos/Solumin/typeshed/milestones{/number}","notifications_url":"https://api.github.com/repos/Solumin/typeshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Solumin/typeshed/labels{/name}","releases_url":"https://api.github.com/repos/Solumin/typeshed/releases{/id}","deployments_url":"https://api.github.com/repos/Solumin/typeshed/deployments","created_at":"2017-04-17T18:06:47Z","updated_at":"2017-04-17T18:06:50Z","pushed_at":"2017-04-24T16:41:57Z","git_url":"git://github.com/Solumin/typeshed.git","ssh_url":"git@github.com:Solumin/typeshed.git","clone_url":"https://github.com/Solumin/typeshed.git","svn_url":"https://github.com/Solumin/typeshed","homepage":null,"size":2232,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"55dc338bbf7c307c1d614724942aa2dad349f656","user":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":31696383,"name":"typeshed","full_name":"python/typeshed","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars0.githubusercontent.com/u/1525981?v=3","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/typeshed","description":"Collection of library stubs for Python, with static types","fork":false,"url":"https://api.github.com/repos/python/typeshed","forks_url":"https://api.github.com/repos/python/typeshed/forks","keys_url":"https://api.github.com/repos/python/typeshed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/typeshed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/typeshed/teams","hooks_url":"https://api.github.com/repos/python/typeshed/hooks","issue_events_url":"https://api.github.com/repos/python/typeshed/issues/events{/number}","events_url":"https://api.github.com/repos/python/typeshed/events","assignees_url":"https://api.github.com/repos/python/typeshed/assignees{/user}","branches_url":"https://api.github.com/repos/python/typeshed/branches{/branch}","tags_url":"https://api.github.com/repos/python/typeshed/tags","blobs_url":"https://api.github.com/repos/python/typeshed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/typeshed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/typeshed/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/typeshed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/typeshed/statuses/{sha}","languages_url":"https://api.github.com/repos/python/typeshed/languages","stargazers_url":"https://api.github.com/repos/python/typeshed/stargazers","contributors_url":"https://api.github.com/repos/python/typeshed/contributors","subscribers_url":"https://api.github.com/repos/python/typeshed/subscribers","subscription_url":"https://api.github.com/repos/python/typeshed/subscription","commits_url":"https://api.github.com/repos/python/typeshed/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/typeshed/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/typeshed/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/typeshed/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/typeshed/contents/{+path}","compare_url":"https://api.github.com/repos/python/typeshed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/typeshed/merges","archive_url":"https://api.github.com/repos/python/typeshed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/typeshed/downloads","issues_url":"https://api.github.com/repos/python/typeshed/issues{/number}","pulls_url":"https://api.github.com/repos/python/typeshed/pulls{/number}","milestones_url":"https://api.github.com/repos/python/typeshed/milestones{/number}","notifications_url":"https://api.github.com/repos/python/typeshed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/typeshed/labels{/name}","releases_url":"https://api.github.com/repos/python/typeshed/releases{/id}","deployments_url":"https://api.github.com/repos/python/typeshed/deployments","created_at":"2015-03-05T04:51:28Z","updated_at":"2017-04-24T11:33:44Z","pushed_at":"2017-04-24T16:41:59Z","git_url":"git://github.com/python/typeshed.git","ssh_url":"git@github.com:python/typeshed.git","clone_url":"https://github.com/python/typeshed.git","svn_url":"https://github.com/python/typeshed","homepage":null,"size":2242,"stargazers_count":401,"watchers_count":401,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":235,"mirror_url":null,"open_issues_count":80,"forks":235,"open_issues":80,"watchers":401,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/typeshed/pulls/1185"},"html":{"href":"https://github.com/python/typeshed/pull/1185"},"issue":{"href":"https://api.github.com/repos/python/typeshed/issues/1185"},"comments":{"href":"https://api.github.com/repos/python/typeshed/issues/1185/comments"},"review_comments":{"href":"https://api.github.com/repos/python/typeshed/pulls/1185/comments"},"review_comment":{"href":"https://api.github.com/repos/python/typeshed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/typeshed/pulls/1185/commits"},"statuses":{"href":"https://api.github.com/repos/python/typeshed/statuses/91a692db5d3f1b86116cd23379d8f40486d37042"}}}}
|
{
"id": 31696383,
"name": "python/typeshed",
"url": "https://api.github.com/repos/python/typeshed"
}
|
{
"id": 930857,
"login": "Solumin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/930857?",
"url": "https://api.github.com/users/Solumin"
}
|
{
"id": 1525981,
"login": "python",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1525981?",
"url": "https://api.github.com/orgs/python"
}
| 2017-04-24T17:59:43 |
5746077022
|
{"actor":{"display_login":"Solumin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pywbem/pywbem/pulls/comments/133587271","pull_request_review_id":56786964,"id":133587271,"diff_hunk":"@@ -0,0 +1,402 @@\n+# Copyright 2017 InovaDevelopment Inc. All Rights Reserved.\n+\n+#\n+# This library is free software; you can redistribute it and/or\n+# modify it under the terms of the GNU Lesser General Public\n+# License as published by the Free Software Foundation; either\n+# version 2.1 of the License, or (at your option) any later version.\n+#\n+# This program is distributed in the hope that it will be useful, but\n+# WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+# Lesser General Public License for more details.\n+#\n+# You should have received a copy of the GNU Lesser General Public\n+# License along with this program; if not, write to the Free Software\n+# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.\n+\n+\"\"\"\n+This package supports logging using the standard Python :mod:`py:logging`\n+module. The logging support for multiple :class:`~py:logging.Logger` objects\n+(named loggers):\n+\n+Currently there are two defined in this code:\n+\n+* 'pywbem.ops' for user-issued calls to pywbem CIM OperationsAPI functions, at\n+ the info level. Internal calls to API functions are not logged.\n+\n+* 'pywbem.http' for http level information, at the info level.\n+\n+In addition, there may be loggers for pywbem modules with the module name, for\n+situations like errors or warnings.\n+\n+All these loggers have a null-handler (see :class:`~py:logging.NullHandler`)\n+and have no log formatter (see :class:`~py:logging.Formatter`).\n+\n+As a result, the loggers are silent by default. To turn on logging,\n+add a log handler (see :meth:`~py:logging.Logger.addHandler`, and\n+:mod:`py:logging.handlers` for the handlers included with Python) and set the\n+log level (see :meth:`~py:logging.Logger.setLevel`, and :ref:`py:levels` for\n+the defined levels).\n+\n+If you want to change the default log message format, use\n+:meth:`~py:logging.Handler.setFormatter`. Its ``form`` parameter is a format\n+string with %-style placeholders for the log record attributes (see Python\n+section :ref:`py:logrecord-attributes`).\n+\n+Examples:\n+\n+* To output log records for one of the defined named loggers, either the\n+ PywbemLogger.create_loggers or the Pywbem.create_logger can be used.\n+\n+ create_loggers creates one or more loggers from a string input that\n+ defines the component name and characteristics of each logger. This allows\n+ other tools like clis to create the pywbem known logs with minimal work","path":"pywbem/_logging.py","position":54,"original_position":54,"commit_id":"e1c775826bc785b1dff2008d6bc8967131531554","original_commit_id":"e1c775826bc785b1dff2008d6bc8967131531554","user":{"login":"KSchopmeyer","id":2340817,"avatar_url":"https://avatars3.githubusercontent.com/u/2340817?v=4","gravatar_id":"","url":"https://api.github.com/users/KSchopmeyer","html_url":"https://github.com/KSchopmeyer","followers_url":"https://api.github.com/users/KSchopmeyer/followers","following_url":"https://api.github.com/users/KSchopmeyer/following{/other_user}","gists_url":"https://api.github.com/users/KSchopmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/KSchopmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSchopmeyer/subscriptions","organizations_url":"https://api.github.com/users/KSchopmeyer/orgs","repos_url":"https://api.github.com/users/KSchopmeyer/repos","events_url":"https://api.github.com/users/KSchopmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/KSchopmeyer/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-08-16T22:53:37Z","updated_at":"2017-08-16T22:53:37Z","html_url":"https://github.com/pywbem/pywbem/pull/737#discussion_r133587271","pull_request_url":"https://api.github.com/repos/pywbem/pywbem/pulls/737","_links":{"self":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/comments/133587271"},"html":{"href":"https://github.com/pywbem/pywbem/pull/737#discussion_r133587271"},"pull_request":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/737"}}},"pull_request":{"url":"https://api.github.com/repos/pywbem/pywbem/pulls/737","id":132967291,"html_url":"https://github.com/pywbem/pywbem/pull/737","diff_url":"https://github.com/pywbem/pywbem/pull/737.diff","patch_url":"https://github.com/pywbem/pywbem/pull/737.patch","issue_url":"https://api.github.com/repos/pywbem/pywbem/issues/737","number":737,"state":"open","locked":false,"title":"Ks/#691 part1 define logger","user":{"login":"KSchopmeyer","id":2340817,"avatar_url":"https://avatars3.githubusercontent.com/u/2340817?v=4","gravatar_id":"","url":"https://api.github.com/users/KSchopmeyer","html_url":"https://github.com/KSchopmeyer","followers_url":"https://api.github.com/users/KSchopmeyer/followers","following_url":"https://api.github.com/users/KSchopmeyer/following{/other_user}","gists_url":"https://api.github.com/users/KSchopmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/KSchopmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSchopmeyer/subscriptions","organizations_url":"https://api.github.com/users/KSchopmeyer/orgs","repos_url":"https://api.github.com/users/KSchopmeyer/repos","events_url":"https://api.github.com/users/KSchopmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/KSchopmeyer/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-28T13:21:12Z","updated_at":"2017-08-16T22:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aed39ae31a6eb158f3ce401d8d704ce1e3970bfe","assignee":{"login":"KSchopmeyer","id":2340817,"avatar_url":"https://avatars3.githubusercontent.com/u/2340817?v=4","gravatar_id":"","url":"https://api.github.com/users/KSchopmeyer","html_url":"https://github.com/KSchopmeyer","followers_url":"https://api.github.com/users/KSchopmeyer/followers","following_url":"https://api.github.com/users/KSchopmeyer/following{/other_user}","gists_url":"https://api.github.com/users/KSchopmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/KSchopmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSchopmeyer/subscriptions","organizations_url":"https://api.github.com/users/KSchopmeyer/orgs","repos_url":"https://api.github.com/users/KSchopmeyer/repos","events_url":"https://api.github.com/users/KSchopmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/KSchopmeyer/received_events","type":"User","site_admin":false},"assignees":[{"login":"KSchopmeyer","id":2340817,"avatar_url":"https://avatars3.githubusercontent.com/u/2340817?v=4","gravatar_id":"","url":"https://api.github.com/users/KSchopmeyer","html_url":"https://github.com/KSchopmeyer","followers_url":"https://api.github.com/users/KSchopmeyer/followers","following_url":"https://api.github.com/users/KSchopmeyer/following{/other_user}","gists_url":"https://api.github.com/users/KSchopmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/KSchopmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSchopmeyer/subscriptions","organizations_url":"https://api.github.com/users/KSchopmeyer/orgs","repos_url":"https://api.github.com/users/KSchopmeyer/repos","events_url":"https://api.github.com/users/KSchopmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/KSchopmeyer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/pywbem/pywbem/milestones/9","html_url":"https://github.com/pywbem/pywbem/milestone/9","labels_url":"https://api.github.com/repos/pywbem/pywbem/milestones/9/labels","id":2205920,"number":9,"title":"0.11.0","description":"","creator":{"login":"andy-maier","id":8939758,"avatar_url":"https://avatars2.githubusercontent.com/u/8939758?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-maier","html_url":"https://github.com/andy-maier","followers_url":"https://api.github.com/users/andy-maier/followers","following_url":"https://api.github.com/users/andy-maier/following{/other_user}","gists_url":"https://api.github.com/users/andy-maier/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-maier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-maier/subscriptions","organizations_url":"https://api.github.com/users/andy-maier/orgs","repos_url":"https://api.github.com/users/andy-maier/repos","events_url":"https://api.github.com/users/andy-maier/events{/privacy}","received_events_url":"https://api.github.com/users/andy-maier/received_events","type":"User","site_admin":false},"open_issues":50,"closed_issues":95,"state":"open","created_at":"2016-12-19T22:15:19Z","updated_at":"2017-08-16T15:43:00Z","due_on":"2017-05-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/pywbem/pywbem/pulls/737/commits","review_comments_url":"https://api.github.com/repos/pywbem/pywbem/pulls/737/comments","review_comment_url":"https://api.github.com/repos/pywbem/pywbem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pywbem/pywbem/issues/737/comments","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/e1c775826bc785b1dff2008d6bc8967131531554","head":{"label":"pywbem:ks/#691-part1-define_logger","ref":"ks/#691-part1-define_logger","sha":"e1c775826bc785b1dff2008d6bc8967131531554","user":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"repo":{"id":43776349,"name":"pywbem","full_name":"pywbem/pywbem","owner":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywbem/pywbem","description":"Pywbem - A WBEM client and related utilities, written in pure Python.","fork":false,"url":"https://api.github.com/repos/pywbem/pywbem","forks_url":"https://api.github.com/repos/pywbem/pywbem/forks","keys_url":"https://api.github.com/repos/pywbem/pywbem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywbem/pywbem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywbem/pywbem/teams","hooks_url":"https://api.github.com/repos/pywbem/pywbem/hooks","issue_events_url":"https://api.github.com/repos/pywbem/pywbem/issues/events{/number}","events_url":"https://api.github.com/repos/pywbem/pywbem/events","assignees_url":"https://api.github.com/repos/pywbem/pywbem/assignees{/user}","branches_url":"https://api.github.com/repos/pywbem/pywbem/branches{/branch}","tags_url":"https://api.github.com/repos/pywbem/pywbem/tags","blobs_url":"https://api.github.com/repos/pywbem/pywbem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywbem/pywbem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywbem/pywbem/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywbem/pywbem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/{sha}","languages_url":"https://api.github.com/repos/pywbem/pywbem/languages","stargazers_url":"https://api.github.com/repos/pywbem/pywbem/stargazers","contributors_url":"https://api.github.com/repos/pywbem/pywbem/contributors","subscribers_url":"https://api.github.com/repos/pywbem/pywbem/subscribers","subscription_url":"https://api.github.com/repos/pywbem/pywbem/subscription","commits_url":"https://api.github.com/repos/pywbem/pywbem/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywbem/pywbem/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywbem/pywbem/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywbem/pywbem/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywbem/pywbem/contents/{+path}","compare_url":"https://api.github.com/repos/pywbem/pywbem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywbem/pywbem/merges","archive_url":"https://api.github.com/repos/pywbem/pywbem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywbem/pywbem/downloads","issues_url":"https://api.github.com/repos/pywbem/pywbem/issues{/number}","pulls_url":"https://api.github.com/repos/pywbem/pywbem/pulls{/number}","milestones_url":"https://api.github.com/repos/pywbem/pywbem/milestones{/number}","notifications_url":"https://api.github.com/repos/pywbem/pywbem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywbem/pywbem/labels{/name}","releases_url":"https://api.github.com/repos/pywbem/pywbem/releases{/id}","deployments_url":"https://api.github.com/repos/pywbem/pywbem/deployments","created_at":"2015-10-06T20:22:46Z","updated_at":"2017-07-17T05:36:38Z","pushed_at":"2017-08-16T12:41:21Z","git_url":"git://github.com/pywbem/pywbem.git","ssh_url":"git@github.com:pywbem/pywbem.git","clone_url":"https://github.com/pywbem/pywbem.git","svn_url":"https://github.com/pywbem/pywbem","homepage":"http://pywbem.github.io","size":32943,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":73,"forks":10,"open_issues":73,"watchers":16,"default_branch":"master"}},"base":{"label":"pywbem:master","ref":"master","sha":"9187d6fd7e1e503e4764380382f813ecdc44f67e","user":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"repo":{"id":43776349,"name":"pywbem","full_name":"pywbem/pywbem","owner":{"login":"pywbem","id":15003592,"avatar_url":"https://avatars1.githubusercontent.com/u/15003592?v=4","gravatar_id":"","url":"https://api.github.com/users/pywbem","html_url":"https://github.com/pywbem","followers_url":"https://api.github.com/users/pywbem/followers","following_url":"https://api.github.com/users/pywbem/following{/other_user}","gists_url":"https://api.github.com/users/pywbem/gists{/gist_id}","starred_url":"https://api.github.com/users/pywbem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pywbem/subscriptions","organizations_url":"https://api.github.com/users/pywbem/orgs","repos_url":"https://api.github.com/users/pywbem/repos","events_url":"https://api.github.com/users/pywbem/events{/privacy}","received_events_url":"https://api.github.com/users/pywbem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pywbem/pywbem","description":"Pywbem - A WBEM client and related utilities, written in pure Python.","fork":false,"url":"https://api.github.com/repos/pywbem/pywbem","forks_url":"https://api.github.com/repos/pywbem/pywbem/forks","keys_url":"https://api.github.com/repos/pywbem/pywbem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pywbem/pywbem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pywbem/pywbem/teams","hooks_url":"https://api.github.com/repos/pywbem/pywbem/hooks","issue_events_url":"https://api.github.com/repos/pywbem/pywbem/issues/events{/number}","events_url":"https://api.github.com/repos/pywbem/pywbem/events","assignees_url":"https://api.github.com/repos/pywbem/pywbem/assignees{/user}","branches_url":"https://api.github.com/repos/pywbem/pywbem/branches{/branch}","tags_url":"https://api.github.com/repos/pywbem/pywbem/tags","blobs_url":"https://api.github.com/repos/pywbem/pywbem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pywbem/pywbem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pywbem/pywbem/git/refs{/sha}","trees_url":"https://api.github.com/repos/pywbem/pywbem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pywbem/pywbem/statuses/{sha}","languages_url":"https://api.github.com/repos/pywbem/pywbem/languages","stargazers_url":"https://api.github.com/repos/pywbem/pywbem/stargazers","contributors_url":"https://api.github.com/repos/pywbem/pywbem/contributors","subscribers_url":"https://api.github.com/repos/pywbem/pywbem/subscribers","subscription_url":"https://api.github.com/repos/pywbem/pywbem/subscription","commits_url":"https://api.github.com/repos/pywbem/pywbem/commits{/sha}","git_commits_url":"https://api.github.com/repos/pywbem/pywbem/git/commits{/sha}","comments_url":"https://api.github.com/repos/pywbem/pywbem/comments{/number}","issue_comment_url":"https://api.github.com/repos/pywbem/pywbem/issues/comments{/number}","contents_url":"https://api.github.com/repos/pywbem/pywbem/contents/{+path}","compare_url":"https://api.github.com/repos/pywbem/pywbem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pywbem/pywbem/merges","archive_url":"https://api.github.com/repos/pywbem/pywbem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pywbem/pywbem/downloads","issues_url":"https://api.github.com/repos/pywbem/pywbem/issues{/number}","pulls_url":"https://api.github.com/repos/pywbem/pywbem/pulls{/number}","milestones_url":"https://api.github.com/repos/pywbem/pywbem/milestones{/number}","notifications_url":"https://api.github.com/repos/pywbem/pywbem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pywbem/pywbem/labels{/name}","releases_url":"https://api.github.com/repos/pywbem/pywbem/releases{/id}","deployments_url":"https://api.github.com/repos/pywbem/pywbem/deployments","created_at":"2015-10-06T20:22:46Z","updated_at":"2017-07-17T05:36:38Z","pushed_at":"2017-08-16T12:41:21Z","git_url":"git://github.com/pywbem/pywbem.git","ssh_url":"git@github.com:pywbem/pywbem.git","clone_url":"https://github.com/pywbem/pywbem.git","svn_url":"https://github.com/pywbem/pywbem","homepage":"http://pywbem.github.io","size":32943,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":73,"forks":10,"open_issues":73,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/737"},"html":{"href":"https://github.com/pywbem/pywbem/pull/737"},"issue":{"href":"https://api.github.com/repos/pywbem/pywbem/issues/737"},"comments":{"href":"https://api.github.com/repos/pywbem/pywbem/issues/737/comments"},"review_comments":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/737/comments"},"review_comment":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pywbem/pywbem/pulls/737/commits"},"statuses":{"href":"https://api.github.com/repos/pywbem/pywbem/statuses/e1c775826bc785b1dff2008d6bc8967131531554"}}}}
|
{
"id": 43776349,
"name": "pywbem/pywbem",
"url": "https://api.github.com/repos/pywbem/pywbem"
}
|
{
"id": 2340817,
"login": "KSchopmeyer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2340817?",
"url": "https://api.github.com/users/KSchopmeyer"
}
|
{
"id": 15003592,
"login": "pywbem",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15003592?",
"url": "https://api.github.com/orgs/pywbem"
}
| 2017-08-16T22:53:37 |
6467862217
|
{"actor":{"display_login":"KSchopmeyer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/124808703","pull_request_review_id":47133896,"id":124808703,"diff_hunk":"@@ -1483,10 +1483,13 @@ subsequent sections.\n ## STREAM Frame {#frame-stream}\n \n STREAM frames implicitly create a stream and carry stream data. The type byte\n-for a STREAM frame contains embedded flags, and is formatted as `11FSSOOD`.\n+for a STREAM frame contains embedded flags, and is formatted as `1UFSSOOD`.\n These bits are parsed as follows:\n \n-* The first two bits must be set to 11, indicating that this is a STREAM frame.\n+* The first bit must be set to 1, indicating that this is a STREAM frame.\n+\n+* 'U' is the UNI bit, which is used to indicate this is a unidirectional\n+ stream, and no stream frames may be sent in response.","path":"draft-ietf-quic-transport.md","position":23,"original_position":12,"commit_id":"0dbd1f805c412cb694c26a3b50bc7b3e6b647666","original_commit_id":"ddb9802b899ae8365753185ed8387db7d8a6f2f8","user":{"login":"RyanAtGoogle","id":19561162,"avatar_url":"https://avatars0.githubusercontent.com/u/19561162?v=3","gravatar_id":"","url":"https://api.github.com/users/RyanAtGoogle","html_url":"https://github.com/RyanAtGoogle","followers_url":"https://api.github.com/users/RyanAtGoogle/followers","following_url":"https://api.github.com/users/RyanAtGoogle/following{/other_user}","gists_url":"https://api.github.com/users/RyanAtGoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanAtGoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanAtGoogle/subscriptions","organizations_url":"https://api.github.com/users/RyanAtGoogle/orgs","repos_url":"https://api.github.com/users/RyanAtGoogle/repos","events_url":"https://api.github.com/users/RyanAtGoogle/events{/privacy}","received_events_url":"https://api.github.com/users/RyanAtGoogle/received_events","type":"User","site_admin":false},"body":"One complication with using Stream ID is how it relates to stream limits. Using stream ID would probably imply that there be different limits for unidirectional streams vs bidirectional streams since a given application may well have an asymmetric stream distribution.","created_at":"2017-06-29T14:04:58Z","updated_at":"2017-06-29T14:04:58Z","html_url":"https://github.com/quicwg/base-drafts/pull/656#discussion_r124808703","pull_request_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/656","_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments/124808703"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/656#discussion_r124808703"},"pull_request":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/656"}}},"pull_request":{"url":"https://api.github.com/repos/quicwg/base-drafts/pulls/656","id":127112501,"html_url":"https://github.com/quicwg/base-drafts/pull/656","diff_url":"https://github.com/quicwg/base-drafts/pull/656.diff","patch_url":"https://github.com/quicwg/base-drafts/pull/656.patch","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/656","number":656,"state":"open","locked":false,"title":"Adding unidirectional streams","user":{"login":"ianswett","id":20072817,"avatar_url":"https://avatars2.githubusercontent.com/u/20072817?v=3","gravatar_id":"","url":"https://api.github.com/users/ianswett","html_url":"https://github.com/ianswett","followers_url":"https://api.github.com/users/ianswett/followers","following_url":"https://api.github.com/users/ianswett/following{/other_user}","gists_url":"https://api.github.com/users/ianswett/gists{/gist_id}","starred_url":"https://api.github.com/users/ianswett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianswett/subscriptions","organizations_url":"https://api.github.com/users/ianswett/orgs","repos_url":"https://api.github.com/users/ianswett/repos","events_url":"https://api.github.com/users/ianswett/events{/privacy}","received_events_url":"https://api.github.com/users/ianswett/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-23T00:11:05Z","updated_at":"2017-06-29T14:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2539acf52333a85f6657af15a26d727d612adaad","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/656/commits","review_comments_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/656/comments","review_comment_url":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/656/comments","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/0dbd1f805c412cb694c26a3b50bc7b3e6b647666","head":{"label":"quicwg:ianswett-uni","ref":"ianswett-uni","sha":"0dbd1f805c412cb694c26a3b50bc7b3e6b647666","user":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars0.githubusercontent.com/u/22631371?v=3","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars0.githubusercontent.com/u/22631371?v=3","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2017-06-29T13:30:08Z","pushed_at":"2017-06-29T00:45:30Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":17434,"stargazers_count":105,"watchers_count":105,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":155,"forks":21,"open_issues":155,"watchers":105,"default_branch":"master"}},"base":{"label":"quicwg:master","ref":"master","sha":"05d6c971869534129ce6293e94b9b51a644e5804","user":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars0.githubusercontent.com/u/22631371?v=3","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"repo":{"id":73779599,"name":"base-drafts","full_name":"quicwg/base-drafts","owner":{"login":"quicwg","id":22631371,"avatar_url":"https://avatars0.githubusercontent.com/u/22631371?v=3","gravatar_id":"","url":"https://api.github.com/users/quicwg","html_url":"https://github.com/quicwg","followers_url":"https://api.github.com/users/quicwg/followers","following_url":"https://api.github.com/users/quicwg/following{/other_user}","gists_url":"https://api.github.com/users/quicwg/gists{/gist_id}","starred_url":"https://api.github.com/users/quicwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quicwg/subscriptions","organizations_url":"https://api.github.com/users/quicwg/orgs","repos_url":"https://api.github.com/users/quicwg/repos","events_url":"https://api.github.com/users/quicwg/events{/privacy}","received_events_url":"https://api.github.com/users/quicwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quicwg/base-drafts","description":" Internet-Drafts that make up the base QUIC specification","fork":false,"url":"https://api.github.com/repos/quicwg/base-drafts","forks_url":"https://api.github.com/repos/quicwg/base-drafts/forks","keys_url":"https://api.github.com/repos/quicwg/base-drafts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quicwg/base-drafts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quicwg/base-drafts/teams","hooks_url":"https://api.github.com/repos/quicwg/base-drafts/hooks","issue_events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/events{/number}","events_url":"https://api.github.com/repos/quicwg/base-drafts/events","assignees_url":"https://api.github.com/repos/quicwg/base-drafts/assignees{/user}","branches_url":"https://api.github.com/repos/quicwg/base-drafts/branches{/branch}","tags_url":"https://api.github.com/repos/quicwg/base-drafts/tags","blobs_url":"https://api.github.com/repos/quicwg/base-drafts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quicwg/base-drafts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quicwg/base-drafts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quicwg/base-drafts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quicwg/base-drafts/statuses/{sha}","languages_url":"https://api.github.com/repos/quicwg/base-drafts/languages","stargazers_url":"https://api.github.com/repos/quicwg/base-drafts/stargazers","contributors_url":"https://api.github.com/repos/quicwg/base-drafts/contributors","subscribers_url":"https://api.github.com/repos/quicwg/base-drafts/subscribers","subscription_url":"https://api.github.com/repos/quicwg/base-drafts/subscription","commits_url":"https://api.github.com/repos/quicwg/base-drafts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quicwg/base-drafts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quicwg/base-drafts/contents/{+path}","compare_url":"https://api.github.com/repos/quicwg/base-drafts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quicwg/base-drafts/merges","archive_url":"https://api.github.com/repos/quicwg/base-drafts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quicwg/base-drafts/downloads","issues_url":"https://api.github.com/repos/quicwg/base-drafts/issues{/number}","pulls_url":"https://api.github.com/repos/quicwg/base-drafts/pulls{/number}","milestones_url":"https://api.github.com/repos/quicwg/base-drafts/milestones{/number}","notifications_url":"https://api.github.com/repos/quicwg/base-drafts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quicwg/base-drafts/labels{/name}","releases_url":"https://api.github.com/repos/quicwg/base-drafts/releases{/id}","deployments_url":"https://api.github.com/repos/quicwg/base-drafts/deployments","created_at":"2016-11-15T05:30:30Z","updated_at":"2017-06-29T13:30:08Z","pushed_at":"2017-06-29T00:45:30Z","git_url":"git://github.com/quicwg/base-drafts.git","ssh_url":"git@github.com:quicwg/base-drafts.git","clone_url":"https://github.com/quicwg/base-drafts.git","svn_url":"https://github.com/quicwg/base-drafts","homepage":"https://quicwg.github.io/","size":17434,"stargazers_count":105,"watchers_count":105,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":155,"forks":21,"open_issues":155,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/656"},"html":{"href":"https://github.com/quicwg/base-drafts/pull/656"},"issue":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/656"},"comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quicwg/base-drafts/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/quicwg/base-drafts/statuses/0dbd1f805c412cb694c26a3b50bc7b3e6b647666"}}}}
|
{
"id": 73779599,
"name": "quicwg/base-drafts",
"url": "https://api.github.com/repos/quicwg/base-drafts"
}
|
{
"id": 19561162,
"login": "RyanAtGoogle",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19561162?",
"url": "https://api.github.com/users/RyanAtGoogle"
}
|
{
"id": 22631371,
"login": "quicwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22631371?",
"url": "https://api.github.com/orgs/quicwg"
}
| 2017-06-29T14:04:58 |
6163537973
|
{"actor":{"display_login":"RyanAtGoogle"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/comments/105974323","pull_request_review_id":26876795,"id":105974323,"diff_hunk":"@@ -0,0 +1,68 @@\n+- job:\n+ name: 'Sync-Credential-Store'\n+ project-type: workflow\n+ concurrent: false\n+ parameters:\n+ - rpc_gating_params\n+ - string:\n+ name: \"PWSAFE_PROJECT_ID\"\n+ description: |\n+ PasswordSafe Project ID\n+ - password:\n+ name: \"SSO_USERNAME\"\n+ description: |\n+ SSO username to connect to PasswordSafe with\n+ - password:\n+ name: \"SSO_PASSWORD\"\n+ description: |\n+ SSO password to connect to PasswordSafe with\n+ - password:\n+ name: \"PIP_PWSAFE_LOCATION\"\n+ description: |\n+ pip location to install pwsafe library from,\n+ eg. git+ssh://git@repo_url/user/pwsafe.git\n+\n+ dsl: |\n+ node(){ // CIT slave node\n+ withCredentials([\n+ file(\n+ credentialsId: 'service_account_jenkins_ssh_key',\n+ variable: 'JENKINS_SSH_KEY'\n+ )\n+ ]){\n+ dir(\"rpc-gating\"){\n+ git branch: env.RPC_GATING_BRANCH, url: env.RPC_GATING_REPO\n+ dir(\"scripts\"){\n+ TMP_DIR = pwd(tmp:true)\n+ withEnv([\n+ \"TMP_DIR=${TMP_DIR}\",\n+ \"PWSAFE_PROJECT_ID=${PWSAFE_PROJECT_ID}\",\n+ \"JENKINS_URL=${JENKINS_URL}\",\n+ \"JENKINS_SSH_KEY=${JENKINS_SSH_KEY}\",\n+ \"SSO_USERNAME=${SSO_USERNAME}\",\n+ \"SSO_PASSWORD=${SSO_PASSWORD}\"])\n+ {\n+ sshagent (credentials: ['rpc-jenkins-svc-github-key']) {\n+ sh \"\"\"#!/bin/bash\n+ scl enable python27 bash","path":"rpc-jobs/sync-credential-store.yml","position":47,"original_position":47,"commit_id":"79c7691d082bb4862c14356c6827738b0c7ae5fc","original_commit_id":"79c7691d082bb4862c14356c6827738b0c7ae5fc","user":{"login":"mattt416","id":16207,"avatar_url":"https://avatars0.githubusercontent.com/u/16207?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt416","html_url":"https://github.com/mattt416","followers_url":"https://api.github.com/users/mattt416/followers","following_url":"https://api.github.com/users/mattt416/following{/other_user}","gists_url":"https://api.github.com/users/mattt416/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt416/subscriptions","organizations_url":"https://api.github.com/users/mattt416/orgs","repos_url":"https://api.github.com/users/mattt416/repos","events_url":"https://api.github.com/users/mattt416/events{/privacy}","received_events_url":"https://api.github.com/users/mattt416/received_events","type":"User","site_admin":false},"body":"I actually copied this from the Jenkins-Job-Builder job, but to answer your question I think that is the documented way of enabling the software collection. It does work, I can change to sourcing instead -- either works for me.","created_at":"2017-03-14T17:26:28Z","updated_at":"2017-03-14T17:26:28Z","html_url":"https://github.com/rcbops/rpc-gating/pull/55#discussion_r105974323","pull_request_url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/comments/105974323"},"html":{"href":"https://github.com/rcbops/rpc-gating/pull/55#discussion_r105974323"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55","id":109011701,"html_url":"https://github.com/rcbops/rpc-gating/pull/55","diff_url":"https://github.com/rcbops/rpc-gating/pull/55.diff","patch_url":"https://github.com/rcbops/rpc-gating/pull/55.patch","issue_url":"https://api.github.com/repos/rcbops/rpc-gating/issues/55","number":55,"state":"open","locked":false,"title":"Password syncing","user":{"login":"mattt416","id":16207,"avatar_url":"https://avatars0.githubusercontent.com/u/16207?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt416","html_url":"https://github.com/mattt416","followers_url":"https://api.github.com/users/mattt416/followers","following_url":"https://api.github.com/users/mattt416/following{/other_user}","gists_url":"https://api.github.com/users/mattt416/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt416/subscriptions","organizations_url":"https://api.github.com/users/mattt416/orgs","repos_url":"https://api.github.com/users/mattt416/repos","events_url":"https://api.github.com/users/mattt416/events{/privacy}","received_events_url":"https://api.github.com/users/mattt416/received_events","type":"User","site_admin":false},"body":"This commit adds a job which is intended to run on a clean jenkins\r\ndeployment to sync passwords from the safe to jenkins' credential\r\nstore. The list of passwords to sync is hard-coded in\r\npull_passwords.py and will need to be pulled out at a later date.\r\n\r\nAt time of writing add_jenkins_cred.groovy supports text or file\r\ncredential types.\r\n\r\nAs this is a bootstrap job, we have tried to limit the amount of\r\ncredentials that already need to be in place before this runs. The\r\nonly one that will need to be manually created are\r\nservice_account_jenkins_ssh_key and rpc-jenkins-svc-github-key.\r\nThe former is the ssh key assigned to the service account jenkins user\r\n(in jenkins itself) which gets used when running jenkins-cli.jar, and\r\nthe latter is the GitHub private key to install pwsafe.\r\n\r\nConnects https://github.com/rcbops/u-suk-dev/issues/801","created_at":"2017-03-03T16:50:40Z","updated_at":"2017-03-14T17:26:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c237623f00d62f54a07084db09e04bea20be3222","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc-gating/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc-gating/issues/55/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc-gating/statuses/79c7691d082bb4862c14356c6827738b0c7ae5fc","head":{"label":"mattt416:password_sync","ref":"password_sync","sha":"79c7691d082bb4862c14356c6827738b0c7ae5fc","user":{"login":"mattt416","id":16207,"avatar_url":"https://avatars0.githubusercontent.com/u/16207?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt416","html_url":"https://github.com/mattt416","followers_url":"https://api.github.com/users/mattt416/followers","following_url":"https://api.github.com/users/mattt416/following{/other_user}","gists_url":"https://api.github.com/users/mattt416/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt416/subscriptions","organizations_url":"https://api.github.com/users/mattt416/orgs","repos_url":"https://api.github.com/users/mattt416/repos","events_url":"https://api.github.com/users/mattt416/events{/privacy}","received_events_url":"https://api.github.com/users/mattt416/received_events","type":"User","site_admin":false},"repo":{"id":79368000,"name":"rpc-gating","full_name":"mattt416/rpc-gating","owner":{"login":"mattt416","id":16207,"avatar_url":"https://avatars0.githubusercontent.com/u/16207?v=3","gravatar_id":"","url":"https://api.github.com/users/mattt416","html_url":"https://github.com/mattt416","followers_url":"https://api.github.com/users/mattt416/followers","following_url":"https://api.github.com/users/mattt416/following{/other_user}","gists_url":"https://api.github.com/users/mattt416/gists{/gist_id}","starred_url":"https://api.github.com/users/mattt416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattt416/subscriptions","organizations_url":"https://api.github.com/users/mattt416/orgs","repos_url":"https://api.github.com/users/mattt416/repos","events_url":"https://api.github.com/users/mattt416/events{/privacy}","received_events_url":"https://api.github.com/users/mattt416/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattt416/rpc-gating","description":"Unified Gating Repository","fork":true,"url":"https://api.github.com/repos/mattt416/rpc-gating","forks_url":"https://api.github.com/repos/mattt416/rpc-gating/forks","keys_url":"https://api.github.com/repos/mattt416/rpc-gating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattt416/rpc-gating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattt416/rpc-gating/teams","hooks_url":"https://api.github.com/repos/mattt416/rpc-gating/hooks","issue_events_url":"https://api.github.com/repos/mattt416/rpc-gating/issues/events{/number}","events_url":"https://api.github.com/repos/mattt416/rpc-gating/events","assignees_url":"https://api.github.com/repos/mattt416/rpc-gating/assignees{/user}","branches_url":"https://api.github.com/repos/mattt416/rpc-gating/branches{/branch}","tags_url":"https://api.github.com/repos/mattt416/rpc-gating/tags","blobs_url":"https://api.github.com/repos/mattt416/rpc-gating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattt416/rpc-gating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattt416/rpc-gating/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattt416/rpc-gating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattt416/rpc-gating/statuses/{sha}","languages_url":"https://api.github.com/repos/mattt416/rpc-gating/languages","stargazers_url":"https://api.github.com/repos/mattt416/rpc-gating/stargazers","contributors_url":"https://api.github.com/repos/mattt416/rpc-gating/contributors","subscribers_url":"https://api.github.com/repos/mattt416/rpc-gating/subscribers","subscription_url":"https://api.github.com/repos/mattt416/rpc-gating/subscription","commits_url":"https://api.github.com/repos/mattt416/rpc-gating/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattt416/rpc-gating/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattt416/rpc-gating/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattt416/rpc-gating/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattt416/rpc-gating/contents/{+path}","compare_url":"https://api.github.com/repos/mattt416/rpc-gating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattt416/rpc-gating/merges","archive_url":"https://api.github.com/repos/mattt416/rpc-gating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattt416/rpc-gating/downloads","issues_url":"https://api.github.com/repos/mattt416/rpc-gating/issues{/number}","pulls_url":"https://api.github.com/repos/mattt416/rpc-gating/pulls{/number}","milestones_url":"https://api.github.com/repos/mattt416/rpc-gating/milestones{/number}","notifications_url":"https://api.github.com/repos/mattt416/rpc-gating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattt416/rpc-gating/labels{/name}","releases_url":"https://api.github.com/repos/mattt416/rpc-gating/releases{/id}","deployments_url":"https://api.github.com/repos/mattt416/rpc-gating/deployments","created_at":"2017-01-18T18:02:42Z","updated_at":"2017-01-18T17:27:57Z","pushed_at":"2017-03-14T15:47:52Z","git_url":"git://github.com/mattt416/rpc-gating.git","ssh_url":"git@github.com:mattt416/rpc-gating.git","clone_url":"https://github.com/mattt416/rpc-gating.git","svn_url":"https://github.com/mattt416/rpc-gating","homepage":null,"size":139,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"e4241e14896be65ca22b152f20d84c5e56405928","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars2.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":79365088,"name":"rpc-gating","full_name":"rcbops/rpc-gating","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars2.githubusercontent.com/u/1153548?v=3","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-gating","description":"Unified Gating Repository","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-gating","forks_url":"https://api.github.com/repos/rcbops/rpc-gating/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-gating/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-gating/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-gating/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-gating/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-gating/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-gating/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-gating/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-gating/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-gating/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-gating/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-gating/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-gating/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-gating/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-gating/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-gating/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-gating/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-gating/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-gating/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-gating/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-gating/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-gating/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-gating/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-gating/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-gating/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-gating/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-gating/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-gating/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-gating/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-gating/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-gating/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-gating/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-gating/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-gating/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-gating/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-gating/deployments","created_at":"2017-01-18T17:27:57Z","updated_at":"2017-02-14T15:28:28Z","pushed_at":"2017-03-14T16:44:31Z","git_url":"git://github.com/rcbops/rpc-gating.git","ssh_url":"git@github.com:rcbops/rpc-gating.git","clone_url":"https://github.com/rcbops/rpc-gating.git","svn_url":"https://github.com/rcbops/rpc-gating","homepage":null,"size":156,"stargazers_count":3,"watchers_count":3,"language":"Groovy","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":3,"forks":8,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55"},"html":{"href":"https://github.com/rcbops/rpc-gating/pull/55"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc-gating/issues/55"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc-gating/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc-gating/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc-gating/statuses/79c7691d082bb4862c14356c6827738b0c7ae5fc"}}}}
|
{
"id": 79365088,
"name": "rcbops/rpc-gating",
"url": "https://api.github.com/repos/rcbops/rpc-gating"
}
|
{
"id": 16207,
"login": "mattt416",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16207?",
"url": "https://api.github.com/users/mattt416"
}
|
{
"id": 1153548,
"login": "rcbops",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1153548?",
"url": "https://api.github.com/orgs/rcbops"
}
| 2017-03-14T17:26:28 |
5491976634
|
{"actor":{"display_login":"mattt416"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ripple/rippled/pulls/comments/126784236","pull_request_review_id":49297078,"id":126784236,"diff_hunk":"@@ -343,6 +344,8 @@ class LedgerMaster\n \n std::uint32_t fetch_seq_;\n \n+ LedgerIndex const max_ledger_difference_ {1000000};","path":"src/ripple/app/ledger/LedgerMaster.h","position":26,"original_position":26,"commit_id":"22536534936b9508f8b4dfc54d5abae869579e8e","original_commit_id":"22536534936b9508f8b4dfc54d5abae869579e8e","user":{"login":"bachase","id":14430,"avatar_url":"https://avatars1.githubusercontent.com/u/14430?v=3","gravatar_id":"","url":"https://api.github.com/users/bachase","html_url":"https://github.com/bachase","followers_url":"https://api.github.com/users/bachase/followers","following_url":"https://api.github.com/users/bachase/following{/other_user}","gists_url":"https://api.github.com/users/bachase/gists{/gist_id}","starred_url":"https://api.github.com/users/bachase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachase/subscriptions","organizations_url":"https://api.github.com/users/bachase/orgs","repos_url":"https://api.github.com/users/bachase/repos","events_url":"https://api.github.com/users/bachase/events{/privacy}","received_events_url":"https://api.github.com/users/bachase/received_events","type":"User","site_admin":false},"body":"Add a comment on the purpose?","created_at":"2017-07-11T19:23:47Z","updated_at":"2017-07-11T19:33:14Z","html_url":"https://github.com/ripple/rippled/pull/2167#discussion_r126784236","pull_request_url":"https://api.github.com/repos/ripple/rippled/pulls/2167","_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments/126784236"},"html":{"href":"https://github.com/ripple/rippled/pull/2167#discussion_r126784236"},"pull_request":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2167"}}},"pull_request":{"url":"https://api.github.com/repos/ripple/rippled/pulls/2167","id":129862877,"html_url":"https://github.com/ripple/rippled/pull/2167","diff_url":"https://github.com/ripple/rippled/pull/2167.diff","patch_url":"https://github.com/ripple/rippled/pull/2167.patch","issue_url":"https://api.github.com/repos/ripple/rippled/issues/2167","number":2167,"state":"open","locked":false,"title":"Allow a newly-started validator to participate","user":{"login":"mtrippled","id":7728157,"avatar_url":"https://avatars2.githubusercontent.com/u/7728157?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrippled","html_url":"https://github.com/mtrippled","followers_url":"https://api.github.com/users/mtrippled/followers","following_url":"https://api.github.com/users/mtrippled/following{/other_user}","gists_url":"https://api.github.com/users/mtrippled/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrippled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrippled/subscriptions","organizations_url":"https://api.github.com/users/mtrippled/orgs","repos_url":"https://api.github.com/users/mtrippled/repos","events_url":"https://api.github.com/users/mtrippled/events{/privacy}","received_events_url":"https://api.github.com/users/mtrippled/received_events","type":"User","site_admin":false},"body":"in consensus.","created_at":"2017-07-11T09:33:40Z","updated_at":"2017-07-11T19:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fa7ffbf24e8999f4b6db7a75ac438e8b1542025","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JoelKatz","id":877549,"avatar_url":"https://avatars0.githubusercontent.com/u/877549?v=3","gravatar_id":"","url":"https://api.github.com/users/JoelKatz","html_url":"https://github.com/JoelKatz","followers_url":"https://api.github.com/users/JoelKatz/followers","following_url":"https://api.github.com/users/JoelKatz/following{/other_user}","gists_url":"https://api.github.com/users/JoelKatz/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelKatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelKatz/subscriptions","organizations_url":"https://api.github.com/users/JoelKatz/orgs","repos_url":"https://api.github.com/users/JoelKatz/repos","events_url":"https://api.github.com/users/JoelKatz/events{/privacy}","received_events_url":"https://api.github.com/users/JoelKatz/received_events","type":"User","site_admin":false},{"login":"wilsonianb","id":5885521,"avatar_url":"https://avatars2.githubusercontent.com/u/5885521?v=3","gravatar_id":"","url":"https://api.github.com/users/wilsonianb","html_url":"https://github.com/wilsonianb","followers_url":"https://api.github.com/users/wilsonianb/followers","following_url":"https://api.github.com/users/wilsonianb/following{/other_user}","gists_url":"https://api.github.com/users/wilsonianb/gists{/gist_id}","starred_url":"https://api.github.com/users/wilsonianb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilsonianb/subscriptions","organizations_url":"https://api.github.com/users/wilsonianb/orgs","repos_url":"https://api.github.com/users/wilsonianb/repos","events_url":"https://api.github.com/users/wilsonianb/events{/privacy}","received_events_url":"https://api.github.com/users/wilsonianb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ripple/rippled/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/ripple/rippled/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2167/comments","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/22536534936b9508f8b4dfc54d5abae869579e8e","head":{"label":"mtrippled:recover","ref":"recover","sha":"22536534936b9508f8b4dfc54d5abae869579e8e","user":{"login":"mtrippled","id":7728157,"avatar_url":"https://avatars2.githubusercontent.com/u/7728157?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrippled","html_url":"https://github.com/mtrippled","followers_url":"https://api.github.com/users/mtrippled/followers","following_url":"https://api.github.com/users/mtrippled/following{/other_user}","gists_url":"https://api.github.com/users/mtrippled/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrippled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrippled/subscriptions","organizations_url":"https://api.github.com/users/mtrippled/orgs","repos_url":"https://api.github.com/users/mtrippled/repos","events_url":"https://api.github.com/users/mtrippled/events{/privacy}","received_events_url":"https://api.github.com/users/mtrippled/received_events","type":"User","site_admin":false},"repo":{"id":21549222,"name":"rippled","full_name":"mtrippled/rippled","owner":{"login":"mtrippled","id":7728157,"avatar_url":"https://avatars2.githubusercontent.com/u/7728157?v=3","gravatar_id":"","url":"https://api.github.com/users/mtrippled","html_url":"https://github.com/mtrippled","followers_url":"https://api.github.com/users/mtrippled/followers","following_url":"https://api.github.com/users/mtrippled/following{/other_user}","gists_url":"https://api.github.com/users/mtrippled/gists{/gist_id}","starred_url":"https://api.github.com/users/mtrippled/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtrippled/subscriptions","organizations_url":"https://api.github.com/users/mtrippled/orgs","repos_url":"https://api.github.com/users/mtrippled/repos","events_url":"https://api.github.com/users/mtrippled/events{/privacy}","received_events_url":"https://api.github.com/users/mtrippled/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtrippled/rippled","description":"Ripple peer-to-peer network daemon","fork":true,"url":"https://api.github.com/repos/mtrippled/rippled","forks_url":"https://api.github.com/repos/mtrippled/rippled/forks","keys_url":"https://api.github.com/repos/mtrippled/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtrippled/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtrippled/rippled/teams","hooks_url":"https://api.github.com/repos/mtrippled/rippled/hooks","issue_events_url":"https://api.github.com/repos/mtrippled/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/mtrippled/rippled/events","assignees_url":"https://api.github.com/repos/mtrippled/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/mtrippled/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/mtrippled/rippled/tags","blobs_url":"https://api.github.com/repos/mtrippled/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtrippled/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtrippled/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtrippled/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtrippled/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/mtrippled/rippled/languages","stargazers_url":"https://api.github.com/repos/mtrippled/rippled/stargazers","contributors_url":"https://api.github.com/repos/mtrippled/rippled/contributors","subscribers_url":"https://api.github.com/repos/mtrippled/rippled/subscribers","subscription_url":"https://api.github.com/repos/mtrippled/rippled/subscription","commits_url":"https://api.github.com/repos/mtrippled/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtrippled/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtrippled/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtrippled/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtrippled/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/mtrippled/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtrippled/rippled/merges","archive_url":"https://api.github.com/repos/mtrippled/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtrippled/rippled/downloads","issues_url":"https://api.github.com/repos/mtrippled/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/mtrippled/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/mtrippled/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/mtrippled/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtrippled/rippled/labels{/name}","releases_url":"https://api.github.com/repos/mtrippled/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/mtrippled/rippled/deployments","created_at":"2014-07-06T21:44:01Z","updated_at":"2015-01-01T00:44:40Z","pushed_at":"2017-07-11T18:09:04Z","git_url":"git://github.com/mtrippled/rippled.git","ssh_url":"git@github.com:mtrippled/rippled.git","clone_url":"https://github.com/mtrippled/rippled.git","svn_url":"https://github.com/mtrippled/rippled","homepage":"https://ripple.com","size":85398,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ripple:develop","ref":"develop","sha":"3bfd9de6779994e5bbbba864791429e2f7360947","user":{"login":"ripple","id":3165523,"avatar_url":"https://avatars1.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"repo":{"id":2724167,"name":"rippled","full_name":"ripple/rippled","owner":{"login":"ripple","id":3165523,"avatar_url":"https://avatars1.githubusercontent.com/u/3165523?v=3","gravatar_id":"","url":"https://api.github.com/users/ripple","html_url":"https://github.com/ripple","followers_url":"https://api.github.com/users/ripple/followers","following_url":"https://api.github.com/users/ripple/following{/other_user}","gists_url":"https://api.github.com/users/ripple/gists{/gist_id}","starred_url":"https://api.github.com/users/ripple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ripple/subscriptions","organizations_url":"https://api.github.com/users/ripple/orgs","repos_url":"https://api.github.com/users/ripple/repos","events_url":"https://api.github.com/users/ripple/events{/privacy}","received_events_url":"https://api.github.com/users/ripple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ripple/rippled","description":"Decentralized cryptocurrency blockchain daemon implementing the Ripple Consensus Ledger in C++","fork":false,"url":"https://api.github.com/repos/ripple/rippled","forks_url":"https://api.github.com/repos/ripple/rippled/forks","keys_url":"https://api.github.com/repos/ripple/rippled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ripple/rippled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ripple/rippled/teams","hooks_url":"https://api.github.com/repos/ripple/rippled/hooks","issue_events_url":"https://api.github.com/repos/ripple/rippled/issues/events{/number}","events_url":"https://api.github.com/repos/ripple/rippled/events","assignees_url":"https://api.github.com/repos/ripple/rippled/assignees{/user}","branches_url":"https://api.github.com/repos/ripple/rippled/branches{/branch}","tags_url":"https://api.github.com/repos/ripple/rippled/tags","blobs_url":"https://api.github.com/repos/ripple/rippled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ripple/rippled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ripple/rippled/git/refs{/sha}","trees_url":"https://api.github.com/repos/ripple/rippled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ripple/rippled/statuses/{sha}","languages_url":"https://api.github.com/repos/ripple/rippled/languages","stargazers_url":"https://api.github.com/repos/ripple/rippled/stargazers","contributors_url":"https://api.github.com/repos/ripple/rippled/contributors","subscribers_url":"https://api.github.com/repos/ripple/rippled/subscribers","subscription_url":"https://api.github.com/repos/ripple/rippled/subscription","commits_url":"https://api.github.com/repos/ripple/rippled/commits{/sha}","git_commits_url":"https://api.github.com/repos/ripple/rippled/git/commits{/sha}","comments_url":"https://api.github.com/repos/ripple/rippled/comments{/number}","issue_comment_url":"https://api.github.com/repos/ripple/rippled/issues/comments{/number}","contents_url":"https://api.github.com/repos/ripple/rippled/contents/{+path}","compare_url":"https://api.github.com/repos/ripple/rippled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ripple/rippled/merges","archive_url":"https://api.github.com/repos/ripple/rippled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ripple/rippled/downloads","issues_url":"https://api.github.com/repos/ripple/rippled/issues{/number}","pulls_url":"https://api.github.com/repos/ripple/rippled/pulls{/number}","milestones_url":"https://api.github.com/repos/ripple/rippled/milestones{/number}","notifications_url":"https://api.github.com/repos/ripple/rippled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ripple/rippled/labels{/name}","releases_url":"https://api.github.com/repos/ripple/rippled/releases{/id}","deployments_url":"https://api.github.com/repos/ripple/rippled/deployments","created_at":"2011-11-07T04:40:15Z","updated_at":"2017-07-11T14:28:57Z","pushed_at":"2017-07-11T19:31:16Z","git_url":"git://github.com/ripple/rippled.git","ssh_url":"git@github.com:ripple/rippled.git","clone_url":"https://github.com/ripple/rippled.git","svn_url":"https://github.com/ripple/rippled","homepage":"https://ripple.com","size":85169,"stargazers_count":1439,"watchers_count":1439,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":438,"mirror_url":null,"open_issues_count":87,"forks":438,"open_issues":87,"watchers":1439,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2167"},"html":{"href":"https://github.com/ripple/rippled/pull/2167"},"issue":{"href":"https://api.github.com/repos/ripple/rippled/issues/2167"},"comments":{"href":"https://api.github.com/repos/ripple/rippled/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/ripple/rippled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ripple/rippled/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/ripple/rippled/statuses/22536534936b9508f8b4dfc54d5abae869579e8e"}}}}
|
{
"id": 2724167,
"name": "ripple/rippled",
"url": "https://api.github.com/repos/ripple/rippled"
}
|
{
"id": 14430,
"login": "bachase",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14430?",
"url": "https://api.github.com/users/bachase"
}
|
{
"id": 3165523,
"login": "ripple",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3165523?",
"url": "https://api.github.com/orgs/ripple"
}
| 2017-07-11T19:23:47 |
6235471879
|
{"actor":{"display_login":"bachase"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/comments/155458800","pull_request_review_id":81778948,"id":155458800,"diff_hunk":"@@ -558,6 +561,60 @@ run_doc_test() {\n echo\n }\n \n+_s2i_test_image() {\n+ local container_name=\"$1\"\n+ local mount_opts=\"$2\"\n+ echo \" Testing s2i app image with invalid configuration\"\n+ assert_container_creation_fails -e POSTGRESQL_PASSWORD=pass -e POSTGRESQL_DATABASE=db\n+ echo \" Testing s2i app image with correct configuration\"\n+\n+ DOCKER_ARGS=\"\n+-e POSTGRESQL_DATABASE=db\n+-e POSTGRESQL_USER=user\n+-e POSTGRESQL_PASSWORD=password\n+-e POSTGRESQL_ADMIN_PASSWORD=password\n+-e POSTGRESQL_BACKUP_USER=backuser\n+-e POSTGRESQL_BACKUP_PASSWORD=pass\n+\"\n+ create_container \"$container_name\" ${mount_opts}\n+\n+\n+ # need to set these because `postgresql_cmd` relies on global variables\n+ PGUSER=user\n+ PASS=password\n+\n+ # need this to wait for the container to start up\n+ CONTAINER_IP=$(get_container_ip ${container_name})\n+ test_connection \"$container_name\"\n+\n+ configuration=\"$(docker exec -t \"$(get_cid $container_name)\" bash -c 'set +f; shopt -s nullglob; egrep -hv \"^(#|\\!|\\[|$)\" /etc/my.cnf /etc/my.cnf.d/* /opt/rh/mysql*/root/etc/my.cnf /opt/rh/mysql*/root/etc/my.cnf.d/*' | sed 's,\\(^[[:space:]]\\+\\|[[:space:]]\\+$\\),,' | sort -u)\"","path":"test/run_test","position":56,"original_position":56,"commit_id":"55617a60f1decb880a61f23bdfd072493f72d4e2","original_commit_id":"55617a60f1decb880a61f23bdfd072493f72d4e2","user":{"login":"praiskup","id":3277839,"avatar_url":"https://avatars3.githubusercontent.com/u/3277839?v=4","gravatar_id":"","url":"https://api.github.com/users/praiskup","html_url":"https://github.com/praiskup","followers_url":"https://api.github.com/users/praiskup/followers","following_url":"https://api.github.com/users/praiskup/following{/other_user}","gists_url":"https://api.github.com/users/praiskup/gists{/gist_id}","starred_url":"https://api.github.com/users/praiskup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praiskup/subscriptions","organizations_url":"https://api.github.com/users/praiskup/orgs","repos_url":"https://api.github.com/users/praiskup/repos","events_url":"https://api.github.com/users/praiskup/events{/privacy}","received_events_url":"https://api.github.com/users/praiskup/received_events","type":"User","site_admin":false},"body":"I'm bit lost here :)","created_at":"2017-12-07T08:44:04Z","updated_at":"2017-12-07T08:44:04Z","html_url":"https://github.com/sclorg/postgresql-container/pull/208#discussion_r155458800","pull_request_url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/comments/155458800"},"html":{"href":"https://github.com/sclorg/postgresql-container/pull/208#discussion_r155458800"},"pull_request":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208"}}},"pull_request":{"url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208","id":153016142,"html_url":"https://github.com/sclorg/postgresql-container/pull/208","diff_url":"https://github.com/sclorg/postgresql-container/pull/208.diff","patch_url":"https://github.com/sclorg/postgresql-container/pull/208.patch","issue_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/208","number":208,"state":"open","locked":false,"title":"Source to image","user":{"login":"dhodovsk","id":31201372,"avatar_url":"https://avatars2.githubusercontent.com/u/31201372?v=4","gravatar_id":"","url":"https://api.github.com/users/dhodovsk","html_url":"https://github.com/dhodovsk","followers_url":"https://api.github.com/users/dhodovsk/followers","following_url":"https://api.github.com/users/dhodovsk/following{/other_user}","gists_url":"https://api.github.com/users/dhodovsk/gists{/gist_id}","starred_url":"https://api.github.com/users/dhodovsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhodovsk/subscriptions","organizations_url":"https://api.github.com/users/dhodovsk/orgs","repos_url":"https://api.github.com/users/dhodovsk/repos","events_url":"https://api.github.com/users/dhodovsk/events{/privacy}","received_events_url":"https://api.github.com/users/dhodovsk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-16T11:29:00Z","updated_at":"2017-12-07T08:44:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bd7895b67dbd9d82e71e3decda931c7d7617757","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208/commits","review_comments_url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208/comments","review_comment_url":"https://api.github.com/repos/sclorg/postgresql-container/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/208/comments","statuses_url":"https://api.github.com/repos/sclorg/postgresql-container/statuses/55617a60f1decb880a61f23bdfd072493f72d4e2","head":{"label":"dhodovsk:source-to-image","ref":"source-to-image","sha":"55617a60f1decb880a61f23bdfd072493f72d4e2","user":{"login":"dhodovsk","id":31201372,"avatar_url":"https://avatars2.githubusercontent.com/u/31201372?v=4","gravatar_id":"","url":"https://api.github.com/users/dhodovsk","html_url":"https://github.com/dhodovsk","followers_url":"https://api.github.com/users/dhodovsk/followers","following_url":"https://api.github.com/users/dhodovsk/following{/other_user}","gists_url":"https://api.github.com/users/dhodovsk/gists{/gist_id}","starred_url":"https://api.github.com/users/dhodovsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhodovsk/subscriptions","organizations_url":"https://api.github.com/users/dhodovsk/orgs","repos_url":"https://api.github.com/users/dhodovsk/repos","events_url":"https://api.github.com/users/dhodovsk/events{/privacy}","received_events_url":"https://api.github.com/users/dhodovsk/received_events","type":"User","site_admin":false},"repo":{"id":107375167,"name":"postgresql-container","full_name":"dhodovsk/postgresql-container","owner":{"login":"dhodovsk","id":31201372,"avatar_url":"https://avatars2.githubusercontent.com/u/31201372?v=4","gravatar_id":"","url":"https://api.github.com/users/dhodovsk","html_url":"https://github.com/dhodovsk","followers_url":"https://api.github.com/users/dhodovsk/followers","following_url":"https://api.github.com/users/dhodovsk/following{/other_user}","gists_url":"https://api.github.com/users/dhodovsk/gists{/gist_id}","starred_url":"https://api.github.com/users/dhodovsk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhodovsk/subscriptions","organizations_url":"https://api.github.com/users/dhodovsk/orgs","repos_url":"https://api.github.com/users/dhodovsk/repos","events_url":"https://api.github.com/users/dhodovsk/events{/privacy}","received_events_url":"https://api.github.com/users/dhodovsk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhodovsk/postgresql-container","description":"PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.","fork":true,"url":"https://api.github.com/repos/dhodovsk/postgresql-container","forks_url":"https://api.github.com/repos/dhodovsk/postgresql-container/forks","keys_url":"https://api.github.com/repos/dhodovsk/postgresql-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhodovsk/postgresql-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhodovsk/postgresql-container/teams","hooks_url":"https://api.github.com/repos/dhodovsk/postgresql-container/hooks","issue_events_url":"https://api.github.com/repos/dhodovsk/postgresql-container/issues/events{/number}","events_url":"https://api.github.com/repos/dhodovsk/postgresql-container/events","assignees_url":"https://api.github.com/repos/dhodovsk/postgresql-container/assignees{/user}","branches_url":"https://api.github.com/repos/dhodovsk/postgresql-container/branches{/branch}","tags_url":"https://api.github.com/repos/dhodovsk/postgresql-container/tags","blobs_url":"https://api.github.com/repos/dhodovsk/postgresql-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhodovsk/postgresql-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhodovsk/postgresql-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhodovsk/postgresql-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhodovsk/postgresql-container/statuses/{sha}","languages_url":"https://api.github.com/repos/dhodovsk/postgresql-container/languages","stargazers_url":"https://api.github.com/repos/dhodovsk/postgresql-container/stargazers","contributors_url":"https://api.github.com/repos/dhodovsk/postgresql-container/contributors","subscribers_url":"https://api.github.com/repos/dhodovsk/postgresql-container/subscribers","subscription_url":"https://api.github.com/repos/dhodovsk/postgresql-container/subscription","commits_url":"https://api.github.com/repos/dhodovsk/postgresql-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhodovsk/postgresql-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhodovsk/postgresql-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhodovsk/postgresql-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhodovsk/postgresql-container/contents/{+path}","compare_url":"https://api.github.com/repos/dhodovsk/postgresql-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhodovsk/postgresql-container/merges","archive_url":"https://api.github.com/repos/dhodovsk/postgresql-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhodovsk/postgresql-container/downloads","issues_url":"https://api.github.com/repos/dhodovsk/postgresql-container/issues{/number}","pulls_url":"https://api.github.com/repos/dhodovsk/postgresql-container/pulls{/number}","milestones_url":"https://api.github.com/repos/dhodovsk/postgresql-container/milestones{/number}","notifications_url":"https://api.github.com/repos/dhodovsk/postgresql-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhodovsk/postgresql-container/labels{/name}","releases_url":"https://api.github.com/repos/dhodovsk/postgresql-container/releases{/id}","deployments_url":"https://api.github.com/repos/dhodovsk/postgresql-container/deployments","created_at":"2017-10-18T07:44:44Z","updated_at":"2017-10-18T07:44:46Z","pushed_at":"2017-12-04T15:19:46Z","git_url":"git://github.com/dhodovsk/postgresql-container.git","ssh_url":"git@github.com:dhodovsk/postgresql-container.git","clone_url":"https://github.com/dhodovsk/postgresql-container.git","svn_url":"https://github.com/dhodovsk/postgresql-container","homepage":"http://softwarecollections.org","size":354,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sclorg:master","ref":"master","sha":"036810abbc093c0fa3fad6f5b1037164df0e896e","user":{"login":"sclorg","id":9047960,"avatar_url":"https://avatars1.githubusercontent.com/u/9047960?v=4","gravatar_id":"","url":"https://api.github.com/users/sclorg","html_url":"https://github.com/sclorg","followers_url":"https://api.github.com/users/sclorg/followers","following_url":"https://api.github.com/users/sclorg/following{/other_user}","gists_url":"https://api.github.com/users/sclorg/gists{/gist_id}","starred_url":"https://api.github.com/users/sclorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sclorg/subscriptions","organizations_url":"https://api.github.com/users/sclorg/orgs","repos_url":"https://api.github.com/users/sclorg/repos","events_url":"https://api.github.com/users/sclorg/events{/privacy}","received_events_url":"https://api.github.com/users/sclorg/received_events","type":"Organization","site_admin":false},"repo":{"id":32466378,"name":"postgresql-container","full_name":"sclorg/postgresql-container","owner":{"login":"sclorg","id":9047960,"avatar_url":"https://avatars1.githubusercontent.com/u/9047960?v=4","gravatar_id":"","url":"https://api.github.com/users/sclorg","html_url":"https://github.com/sclorg","followers_url":"https://api.github.com/users/sclorg/followers","following_url":"https://api.github.com/users/sclorg/following{/other_user}","gists_url":"https://api.github.com/users/sclorg/gists{/gist_id}","starred_url":"https://api.github.com/users/sclorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sclorg/subscriptions","organizations_url":"https://api.github.com/users/sclorg/orgs","repos_url":"https://api.github.com/users/sclorg/repos","events_url":"https://api.github.com/users/sclorg/events{/privacy}","received_events_url":"https://api.github.com/users/sclorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sclorg/postgresql-container","description":"PostgreSQL container images based on Red Hat Software Collections and intended for OpenShift and general usage. Users can choose between Red Hat Enterprise Linux, Fedora, and CentOS based images.","fork":false,"url":"https://api.github.com/repos/sclorg/postgresql-container","forks_url":"https://api.github.com/repos/sclorg/postgresql-container/forks","keys_url":"https://api.github.com/repos/sclorg/postgresql-container/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sclorg/postgresql-container/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sclorg/postgresql-container/teams","hooks_url":"https://api.github.com/repos/sclorg/postgresql-container/hooks","issue_events_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/events{/number}","events_url":"https://api.github.com/repos/sclorg/postgresql-container/events","assignees_url":"https://api.github.com/repos/sclorg/postgresql-container/assignees{/user}","branches_url":"https://api.github.com/repos/sclorg/postgresql-container/branches{/branch}","tags_url":"https://api.github.com/repos/sclorg/postgresql-container/tags","blobs_url":"https://api.github.com/repos/sclorg/postgresql-container/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sclorg/postgresql-container/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sclorg/postgresql-container/git/refs{/sha}","trees_url":"https://api.github.com/repos/sclorg/postgresql-container/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sclorg/postgresql-container/statuses/{sha}","languages_url":"https://api.github.com/repos/sclorg/postgresql-container/languages","stargazers_url":"https://api.github.com/repos/sclorg/postgresql-container/stargazers","contributors_url":"https://api.github.com/repos/sclorg/postgresql-container/contributors","subscribers_url":"https://api.github.com/repos/sclorg/postgresql-container/subscribers","subscription_url":"https://api.github.com/repos/sclorg/postgresql-container/subscription","commits_url":"https://api.github.com/repos/sclorg/postgresql-container/commits{/sha}","git_commits_url":"https://api.github.com/repos/sclorg/postgresql-container/git/commits{/sha}","comments_url":"https://api.github.com/repos/sclorg/postgresql-container/comments{/number}","issue_comment_url":"https://api.github.com/repos/sclorg/postgresql-container/issues/comments{/number}","contents_url":"https://api.github.com/repos/sclorg/postgresql-container/contents/{+path}","compare_url":"https://api.github.com/repos/sclorg/postgresql-container/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sclorg/postgresql-container/merges","archive_url":"https://api.github.com/repos/sclorg/postgresql-container/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sclorg/postgresql-container/downloads","issues_url":"https://api.github.com/repos/sclorg/postgresql-container/issues{/number}","pulls_url":"https://api.github.com/repos/sclorg/postgresql-container/pulls{/number}","milestones_url":"https://api.github.com/repos/sclorg/postgresql-container/milestones{/number}","notifications_url":"https://api.github.com/repos/sclorg/postgresql-container/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sclorg/postgresql-container/labels{/name}","releases_url":"https://api.github.com/repos/sclorg/postgresql-container/releases{/id}","deployments_url":"https://api.github.com/repos/sclorg/postgresql-container/deployments","created_at":"2015-03-18T15:15:33Z","updated_at":"2017-12-05T13:26:43Z","pushed_at":"2017-12-05T14:25:39Z","git_url":"git://github.com/sclorg/postgresql-container.git","ssh_url":"git@github.com:sclorg/postgresql-container.git","clone_url":"https://github.com/sclorg/postgresql-container.git","svn_url":"https://github.com/sclorg/postgresql-container","homepage":"http://softwarecollections.org","size":334,"stargazers_count":59,"watchers_count":59,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":75,"open_issues":28,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208"},"html":{"href":"https://github.com/sclorg/postgresql-container/pull/208"},"issue":{"href":"https://api.github.com/repos/sclorg/postgresql-container/issues/208"},"comments":{"href":"https://api.github.com/repos/sclorg/postgresql-container/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sclorg/postgresql-container/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/sclorg/postgresql-container/statuses/55617a60f1decb880a61f23bdfd072493f72d4e2"}},"author_association":"MEMBER"}}
|
{
"id": 32466378,
"name": "sclorg/postgresql-container",
"url": "https://api.github.com/repos/sclorg/postgresql-container"
}
|
{
"id": 3277839,
"login": "praiskup",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3277839?",
"url": "https://api.github.com/users/praiskup"
}
|
{
"id": 9047960,
"login": "sclorg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9047960?",
"url": "https://api.github.com/orgs/sclorg"
}
| 2017-12-07T08:44:04 |
6955669682
|
{"actor":{"display_login":"praiskup"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/comments/116376815","pull_request_review_id":37996285,"id":116376815,"diff_hunk":"@@ -13,34 +13,34 @@\n <attr name=\"fillStrokes\" format=\"boolean\"/>\n <attr name=\"randomColoring\" format=\"boolean\"/>\n <attr name=\"palette\" format=\"enum\">\n- <enum name=\"YlGn\" value=\"0\"/>\n- <enum name=\"YlGnBu\" value=\"1\"/>\n- <enum name=\"GnBu\" value=\"2\"/>\n- <enum name=\"BuGn\" value=\"3\"/>\n- <enum name=\"PuBuGn\" value=\"4\"/>\n- <enum name=\"PuBu\" value=\"5\"/>\n- <enum name=\"BuPu\" value=\"6\"/>\n- <enum name=\"RdPu\" value=\"7\"/>\n- <enum name=\"PuRd\" value=\"8\"/>\n- <enum name=\"OrRd\" value=\"9\"/>\n- <enum name=\"YlOrRd\" value=\"10\"/>\n- <enum name=\"YlOrBr\" value=\"11\"/>\n- <enum name=\"Purples\" value=\"12\"/>\n- <enum name=\"Blues\" value=\"13\"/>\n- <enum name=\"Greens\" value=\"14\"/>\n- <enum name=\"Oranges\" value=\"15\"/>\n- <enum name=\"Reds\" value=\"16\"/>\n- <enum name=\"Greys\" value=\"17\"/>\n- <enum name=\"PuOr\" value=\"18\"/>\n- <enum name=\"BrBG\" value=\"19\"/>\n- <enum name=\"PRGn\" value=\"20\"/>\n- <enum name=\"PiYG\" value=\"21\"/>\n- <enum name=\"RdBu\" value=\"22\"/>\n- <enum name=\"RdGy\" value=\"23\"/>\n- <enum name=\"RdYlBu\" value=\"24\"/>\n- <enum name=\"Spectral\" value=\"25\"/>\n- <enum name=\"RdYlGn\" value=\"26\"/>\n- <enum name=\"YL\" value=\"27\"/>\n+ <enum name=\"Yl\" value=\"0\"/>","path":"trianglify/src/main/res/values/attrs.xml","position":32,"original_position":32,"commit_id":"350233348239b1438a8579830c085d6a07cd7f83","original_commit_id":"350233348239b1438a8579830c085d6a07cd7f83","user":{"login":"suyashmahar","id":21097167,"avatar_url":"https://avatars3.githubusercontent.com/u/21097167?v=3","gravatar_id":"","url":"https://api.github.com/users/suyashmahar","html_url":"https://github.com/suyashmahar","followers_url":"https://api.github.com/users/suyashmahar/followers","following_url":"https://api.github.com/users/suyashmahar/following{/other_user}","gists_url":"https://api.github.com/users/suyashmahar/gists{/gist_id}","starred_url":"https://api.github.com/users/suyashmahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyashmahar/subscriptions","organizations_url":"https://api.github.com/users/suyashmahar/orgs","repos_url":"https://api.github.com/users/suyashmahar/repos","events_url":"https://api.github.com/users/suyashmahar/events{/privacy}","received_events_url":"https://api.github.com/users/suyashmahar/received_events","type":"User","site_admin":false},"body":"Can you please explain it a bit?","created_at":"2017-05-14T09:46:53Z","updated_at":"2017-05-14T09:46:53Z","html_url":"https://github.com/sdsmdg/trianglify/pull/26#discussion_r116376815","pull_request_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/comments/116376815"},"html":{"href":"https://github.com/sdsmdg/trianglify/pull/26#discussion_r116376815"},"pull_request":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26","id":120479202,"html_url":"https://github.com/sdsmdg/trianglify/pull/26","diff_url":"https://github.com/sdsmdg/trianglify/pull/26.diff","patch_url":"https://github.com/sdsmdg/trianglify/pull/26.patch","issue_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/26","number":26,"state":"open","locked":false,"title":"Colorizer fix","user":{"login":"suyashmahar","id":21097167,"avatar_url":"https://avatars3.githubusercontent.com/u/21097167?v=3","gravatar_id":"","url":"https://api.github.com/users/suyashmahar","html_url":"https://github.com/suyashmahar","followers_url":"https://api.github.com/users/suyashmahar/followers","following_url":"https://api.github.com/users/suyashmahar/following{/other_user}","gists_url":"https://api.github.com/users/suyashmahar/gists{/gist_id}","starred_url":"https://api.github.com/users/suyashmahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suyashmahar/subscriptions","organizations_url":"https://api.github.com/users/suyashmahar/orgs","repos_url":"https://api.github.com/users/suyashmahar/repos","events_url":"https://api.github.com/users/suyashmahar/events{/privacy}","received_events_url":"https://api.github.com/users/suyashmahar/received_events","type":"User","site_admin":false},"body":"This PR:\r\n* Fixes #18 *Incorrect colorization of view* \r\n* Updates demo app to incorporate changes to colorizer.","created_at":"2017-05-14T09:24:21Z","updated_at":"2017-05-14T09:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f82a882bd0c4eb3725fd032da6453875c1786db4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26/commits","review_comments_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26/comments","review_comment_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/26/comments","statuses_url":"https://api.github.com/repos/sdsmdg/trianglify/statuses/350233348239b1438a8579830c085d6a07cd7f83","head":{"label":"sdsmdg:colorizer-fix","ref":"colorizer-fix","sha":"350233348239b1438a8579830c085d6a07cd7f83","user":{"login":"sdsmdg","id":6321651,"avatar_url":"https://avatars1.githubusercontent.com/u/6321651?v=3","gravatar_id":"","url":"https://api.github.com/users/sdsmdg","html_url":"https://github.com/sdsmdg","followers_url":"https://api.github.com/users/sdsmdg/followers","following_url":"https://api.github.com/users/sdsmdg/following{/other_user}","gists_url":"https://api.github.com/users/sdsmdg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdsmdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdsmdg/subscriptions","organizations_url":"https://api.github.com/users/sdsmdg/orgs","repos_url":"https://api.github.com/users/sdsmdg/repos","events_url":"https://api.github.com/users/sdsmdg/events{/privacy}","received_events_url":"https://api.github.com/users/sdsmdg/received_events","type":"Organization","site_admin":false},"repo":{"id":80398289,"name":"trianglify","full_name":"sdsmdg/trianglify","owner":{"login":"sdsmdg","id":6321651,"avatar_url":"https://avatars1.githubusercontent.com/u/6321651?v=3","gravatar_id":"","url":"https://api.github.com/users/sdsmdg","html_url":"https://github.com/sdsmdg","followers_url":"https://api.github.com/users/sdsmdg/followers","following_url":"https://api.github.com/users/sdsmdg/following{/other_user}","gists_url":"https://api.github.com/users/sdsmdg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdsmdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdsmdg/subscriptions","organizations_url":"https://api.github.com/users/sdsmdg/orgs","repos_url":"https://api.github.com/users/sdsmdg/repos","events_url":"https://api.github.com/users/sdsmdg/events{/privacy}","received_events_url":"https://api.github.com/users/sdsmdg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdsmdg/trianglify","description":"Android library to provide custom Views with algorithmic generation of triangular patterns.","fork":false,"url":"https://api.github.com/repos/sdsmdg/trianglify","forks_url":"https://api.github.com/repos/sdsmdg/trianglify/forks","keys_url":"https://api.github.com/repos/sdsmdg/trianglify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdsmdg/trianglify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdsmdg/trianglify/teams","hooks_url":"https://api.github.com/repos/sdsmdg/trianglify/hooks","issue_events_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/events{/number}","events_url":"https://api.github.com/repos/sdsmdg/trianglify/events","assignees_url":"https://api.github.com/repos/sdsmdg/trianglify/assignees{/user}","branches_url":"https://api.github.com/repos/sdsmdg/trianglify/branches{/branch}","tags_url":"https://api.github.com/repos/sdsmdg/trianglify/tags","blobs_url":"https://api.github.com/repos/sdsmdg/trianglify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdsmdg/trianglify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdsmdg/trianglify/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdsmdg/trianglify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdsmdg/trianglify/statuses/{sha}","languages_url":"https://api.github.com/repos/sdsmdg/trianglify/languages","stargazers_url":"https://api.github.com/repos/sdsmdg/trianglify/stargazers","contributors_url":"https://api.github.com/repos/sdsmdg/trianglify/contributors","subscribers_url":"https://api.github.com/repos/sdsmdg/trianglify/subscribers","subscription_url":"https://api.github.com/repos/sdsmdg/trianglify/subscription","commits_url":"https://api.github.com/repos/sdsmdg/trianglify/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdsmdg/trianglify/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdsmdg/trianglify/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdsmdg/trianglify/contents/{+path}","compare_url":"https://api.github.com/repos/sdsmdg/trianglify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdsmdg/trianglify/merges","archive_url":"https://api.github.com/repos/sdsmdg/trianglify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdsmdg/trianglify/downloads","issues_url":"https://api.github.com/repos/sdsmdg/trianglify/issues{/number}","pulls_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls{/number}","milestones_url":"https://api.github.com/repos/sdsmdg/trianglify/milestones{/number}","notifications_url":"https://api.github.com/repos/sdsmdg/trianglify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdsmdg/trianglify/labels{/name}","releases_url":"https://api.github.com/repos/sdsmdg/trianglify/releases{/id}","deployments_url":"https://api.github.com/repos/sdsmdg/trianglify/deployments","created_at":"2017-01-30T06:18:31Z","updated_at":"2017-05-14T08:46:24Z","pushed_at":"2017-05-14T09:46:39Z","git_url":"git://github.com/sdsmdg/trianglify.git","ssh_url":"git@github.com:sdsmdg/trianglify.git","clone_url":"https://github.com/sdsmdg/trianglify.git","svn_url":"https://github.com/sdsmdg/trianglify","homepage":null,"size":566,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":17,"default_branch":"develop"}},"base":{"label":"sdsmdg:develop","ref":"develop","sha":"b835f53b8cef4888c2bfea10ea3d92faea41580c","user":{"login":"sdsmdg","id":6321651,"avatar_url":"https://avatars1.githubusercontent.com/u/6321651?v=3","gravatar_id":"","url":"https://api.github.com/users/sdsmdg","html_url":"https://github.com/sdsmdg","followers_url":"https://api.github.com/users/sdsmdg/followers","following_url":"https://api.github.com/users/sdsmdg/following{/other_user}","gists_url":"https://api.github.com/users/sdsmdg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdsmdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdsmdg/subscriptions","organizations_url":"https://api.github.com/users/sdsmdg/orgs","repos_url":"https://api.github.com/users/sdsmdg/repos","events_url":"https://api.github.com/users/sdsmdg/events{/privacy}","received_events_url":"https://api.github.com/users/sdsmdg/received_events","type":"Organization","site_admin":false},"repo":{"id":80398289,"name":"trianglify","full_name":"sdsmdg/trianglify","owner":{"login":"sdsmdg","id":6321651,"avatar_url":"https://avatars1.githubusercontent.com/u/6321651?v=3","gravatar_id":"","url":"https://api.github.com/users/sdsmdg","html_url":"https://github.com/sdsmdg","followers_url":"https://api.github.com/users/sdsmdg/followers","following_url":"https://api.github.com/users/sdsmdg/following{/other_user}","gists_url":"https://api.github.com/users/sdsmdg/gists{/gist_id}","starred_url":"https://api.github.com/users/sdsmdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdsmdg/subscriptions","organizations_url":"https://api.github.com/users/sdsmdg/orgs","repos_url":"https://api.github.com/users/sdsmdg/repos","events_url":"https://api.github.com/users/sdsmdg/events{/privacy}","received_events_url":"https://api.github.com/users/sdsmdg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sdsmdg/trianglify","description":"Android library to provide custom Views with algorithmic generation of triangular patterns.","fork":false,"url":"https://api.github.com/repos/sdsmdg/trianglify","forks_url":"https://api.github.com/repos/sdsmdg/trianglify/forks","keys_url":"https://api.github.com/repos/sdsmdg/trianglify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdsmdg/trianglify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdsmdg/trianglify/teams","hooks_url":"https://api.github.com/repos/sdsmdg/trianglify/hooks","issue_events_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/events{/number}","events_url":"https://api.github.com/repos/sdsmdg/trianglify/events","assignees_url":"https://api.github.com/repos/sdsmdg/trianglify/assignees{/user}","branches_url":"https://api.github.com/repos/sdsmdg/trianglify/branches{/branch}","tags_url":"https://api.github.com/repos/sdsmdg/trianglify/tags","blobs_url":"https://api.github.com/repos/sdsmdg/trianglify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdsmdg/trianglify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdsmdg/trianglify/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdsmdg/trianglify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdsmdg/trianglify/statuses/{sha}","languages_url":"https://api.github.com/repos/sdsmdg/trianglify/languages","stargazers_url":"https://api.github.com/repos/sdsmdg/trianglify/stargazers","contributors_url":"https://api.github.com/repos/sdsmdg/trianglify/contributors","subscribers_url":"https://api.github.com/repos/sdsmdg/trianglify/subscribers","subscription_url":"https://api.github.com/repos/sdsmdg/trianglify/subscription","commits_url":"https://api.github.com/repos/sdsmdg/trianglify/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdsmdg/trianglify/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdsmdg/trianglify/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdsmdg/trianglify/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdsmdg/trianglify/contents/{+path}","compare_url":"https://api.github.com/repos/sdsmdg/trianglify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdsmdg/trianglify/merges","archive_url":"https://api.github.com/repos/sdsmdg/trianglify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdsmdg/trianglify/downloads","issues_url":"https://api.github.com/repos/sdsmdg/trianglify/issues{/number}","pulls_url":"https://api.github.com/repos/sdsmdg/trianglify/pulls{/number}","milestones_url":"https://api.github.com/repos/sdsmdg/trianglify/milestones{/number}","notifications_url":"https://api.github.com/repos/sdsmdg/trianglify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdsmdg/trianglify/labels{/name}","releases_url":"https://api.github.com/repos/sdsmdg/trianglify/releases{/id}","deployments_url":"https://api.github.com/repos/sdsmdg/trianglify/deployments","created_at":"2017-01-30T06:18:31Z","updated_at":"2017-05-14T08:46:24Z","pushed_at":"2017-05-14T09:46:39Z","git_url":"git://github.com/sdsmdg/trianglify.git","ssh_url":"git@github.com:sdsmdg/trianglify.git","clone_url":"https://github.com/sdsmdg/trianglify.git","svn_url":"https://github.com/sdsmdg/trianglify","homepage":null,"size":566,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":10,"forks":1,"open_issues":10,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26"},"html":{"href":"https://github.com/sdsmdg/trianglify/pull/26"},"issue":{"href":"https://api.github.com/repos/sdsmdg/trianglify/issues/26"},"comments":{"href":"https://api.github.com/repos/sdsmdg/trianglify/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sdsmdg/trianglify/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/sdsmdg/trianglify/statuses/350233348239b1438a8579830c085d6a07cd7f83"}}}}
|
{
"id": 80398289,
"name": "sdsmdg/trianglify",
"url": "https://api.github.com/repos/sdsmdg/trianglify"
}
|
{
"id": 21097167,
"login": "suyashmahar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21097167?",
"url": "https://api.github.com/users/suyashmahar"
}
|
{
"id": 6321651,
"login": "sdsmdg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6321651?",
"url": "https://api.github.com/orgs/sdsmdg"
}
| 2017-05-14T09:46:53 |
5868147901
|
{"actor":{"display_login":"suyashmahar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/skillz/netcode.io/pulls/comments/142508663","pull_request_review_id":66881393,"id":142508663,"diff_hunk":"@@ -8085,7 +8153,7 @@ void test_skillz_add_two_clients_to_match()\n {\n netcode_network_simulator_update( network_simulator, time );\n \n- for ( int j = 0; j < num_clients; ++j)\n+ for ( j = 0; j < num_clients; ++j )","path":"netcode.c","position":178,"original_position":178,"commit_id":"fe036c9a386f51e6102ecdcf2c2b321f1dd0e7f7","original_commit_id":"fe036c9a386f51e6102ecdcf2c2b321f1dd0e7f7","user":{"login":"kkaminski","id":11036495,"avatar_url":"https://avatars2.githubusercontent.com/u/11036495?v=4","gravatar_id":"","url":"https://api.github.com/users/kkaminski","html_url":"https://github.com/kkaminski","followers_url":"https://api.github.com/users/kkaminski/followers","following_url":"https://api.github.com/users/kkaminski/following{/other_user}","gists_url":"https://api.github.com/users/kkaminski/gists{/gist_id}","starred_url":"https://api.github.com/users/kkaminski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkaminski/subscriptions","organizations_url":"https://api.github.com/users/kkaminski/orgs","repos_url":"https://api.github.com/users/kkaminski/repos","events_url":"https://api.github.com/users/kkaminski/events{/privacy}","received_events_url":"https://api.github.com/users/kkaminski/received_events","type":"User","site_admin":false},"body":"Nit but it looks like you're out of the `for( i...` loop so I'd use `i` here. Not even sure you need `j` defined?","created_at":"2017-10-03T20:09:28Z","updated_at":"2017-10-03T20:09:28Z","html_url":"https://github.com/skillz/netcode.io/pull/7#discussion_r142508663","pull_request_url":"https://api.github.com/repos/skillz/netcode.io/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/comments/142508663"},"html":{"href":"https://github.com/skillz/netcode.io/pull/7#discussion_r142508663"},"pull_request":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/skillz/netcode.io/pulls/7","id":144473559,"html_url":"https://github.com/skillz/netcode.io/pull/7","diff_url":"https://github.com/skillz/netcode.io/pull/7.diff","patch_url":"https://github.com/skillz/netcode.io/pull/7.patch","issue_url":"https://api.github.com/repos/skillz/netcode.io/issues/7","number":7,"state":"open","locked":false,"title":"[#151563071] Feature match expiration","user":{"login":"mpope9","id":10855578,"avatar_url":"https://avatars2.githubusercontent.com/u/10855578?v=4","gravatar_id":"","url":"https://api.github.com/users/mpope9","html_url":"https://github.com/mpope9","followers_url":"https://api.github.com/users/mpope9/followers","following_url":"https://api.github.com/users/mpope9/following{/other_user}","gists_url":"https://api.github.com/users/mpope9/gists{/gist_id}","starred_url":"https://api.github.com/users/mpope9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpope9/subscriptions","organizations_url":"https://api.github.com/users/mpope9/orgs","repos_url":"https://api.github.com/users/mpope9/repos","events_url":"https://api.github.com/users/mpope9/events{/privacy}","received_events_url":"https://api.github.com/users/mpope9/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n\r\nNew variables in skillz_match_t to track max disconnect time and amount, match start, and last restart. On connection these vars are initialized. On a disconnect a client is now removed from the match, and the match persists. In netcode_server_update a method has been added to sweep matches from the server. This runs at n = # of connected matches. So hopefully we don't have an obscene number of matches connected. When a match has expired the client who was once connected gets disconnected from the server.\r\n\r\nPasses valgrind and ccpcheck netcode.c --force\r\n\r\n2 Tests added, to test if sweeping is successful and if re-connection is successful. Also changed the behavior of a test to reflect these changes.\r\n\r\n@cchung89 First round\r\n@kkaminski Second round","created_at":"2017-10-03T16:50:39Z","updated_at":"2017-10-03T20:09:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97496a21c18aa4da32c288cb18debdb17af34451","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/skillz/netcode.io/pulls/7/commits","review_comments_url":"https://api.github.com/repos/skillz/netcode.io/pulls/7/comments","review_comment_url":"https://api.github.com/repos/skillz/netcode.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/skillz/netcode.io/issues/7/comments","statuses_url":"https://api.github.com/repos/skillz/netcode.io/statuses/fe036c9a386f51e6102ecdcf2c2b321f1dd0e7f7","head":{"label":"skillz:feature-match-expiration","ref":"feature-match-expiration","sha":"fe036c9a386f51e6102ecdcf2c2b321f1dd0e7f7","user":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"repo":{"id":104514581,"name":"netcode.io","full_name":"skillz/netcode.io","owner":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skillz/netcode.io","description":"A simple protocol for secure client/server connections over UDP","fork":true,"url":"https://api.github.com/repos/skillz/netcode.io","forks_url":"https://api.github.com/repos/skillz/netcode.io/forks","keys_url":"https://api.github.com/repos/skillz/netcode.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skillz/netcode.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skillz/netcode.io/teams","hooks_url":"https://api.github.com/repos/skillz/netcode.io/hooks","issue_events_url":"https://api.github.com/repos/skillz/netcode.io/issues/events{/number}","events_url":"https://api.github.com/repos/skillz/netcode.io/events","assignees_url":"https://api.github.com/repos/skillz/netcode.io/assignees{/user}","branches_url":"https://api.github.com/repos/skillz/netcode.io/branches{/branch}","tags_url":"https://api.github.com/repos/skillz/netcode.io/tags","blobs_url":"https://api.github.com/repos/skillz/netcode.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skillz/netcode.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skillz/netcode.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/skillz/netcode.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skillz/netcode.io/statuses/{sha}","languages_url":"https://api.github.com/repos/skillz/netcode.io/languages","stargazers_url":"https://api.github.com/repos/skillz/netcode.io/stargazers","contributors_url":"https://api.github.com/repos/skillz/netcode.io/contributors","subscribers_url":"https://api.github.com/repos/skillz/netcode.io/subscribers","subscription_url":"https://api.github.com/repos/skillz/netcode.io/subscription","commits_url":"https://api.github.com/repos/skillz/netcode.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/skillz/netcode.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/skillz/netcode.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/skillz/netcode.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/skillz/netcode.io/contents/{+path}","compare_url":"https://api.github.com/repos/skillz/netcode.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skillz/netcode.io/merges","archive_url":"https://api.github.com/repos/skillz/netcode.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skillz/netcode.io/downloads","issues_url":"https://api.github.com/repos/skillz/netcode.io/issues{/number}","pulls_url":"https://api.github.com/repos/skillz/netcode.io/pulls{/number}","milestones_url":"https://api.github.com/repos/skillz/netcode.io/milestones{/number}","notifications_url":"https://api.github.com/repos/skillz/netcode.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skillz/netcode.io/labels{/name}","releases_url":"https://api.github.com/repos/skillz/netcode.io/releases{/id}","deployments_url":"https://api.github.com/repos/skillz/netcode.io/deployments","created_at":"2017-09-22T20:09:37Z","updated_at":"2017-09-22T20:09:39Z","pushed_at":"2017-10-03T19:01:52Z","git_url":"git://github.com/skillz/netcode.io.git","ssh_url":"git@github.com:skillz/netcode.io.git","clone_url":"https://github.com/skillz/netcode.io.git","svn_url":"https://github.com/skillz/netcode.io","homepage":"","size":4555,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"skillz:development","ref":"development","sha":"86f0f9907df76e3e61612b5d75f2a53aa41a6964","user":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"repo":{"id":104514581,"name":"netcode.io","full_name":"skillz/netcode.io","owner":{"login":"skillz","id":2835552,"avatar_url":"https://avatars3.githubusercontent.com/u/2835552?v=4","gravatar_id":"","url":"https://api.github.com/users/skillz","html_url":"https://github.com/skillz","followers_url":"https://api.github.com/users/skillz/followers","following_url":"https://api.github.com/users/skillz/following{/other_user}","gists_url":"https://api.github.com/users/skillz/gists{/gist_id}","starred_url":"https://api.github.com/users/skillz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skillz/subscriptions","organizations_url":"https://api.github.com/users/skillz/orgs","repos_url":"https://api.github.com/users/skillz/repos","events_url":"https://api.github.com/users/skillz/events{/privacy}","received_events_url":"https://api.github.com/users/skillz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/skillz/netcode.io","description":"A simple protocol for secure client/server connections over UDP","fork":true,"url":"https://api.github.com/repos/skillz/netcode.io","forks_url":"https://api.github.com/repos/skillz/netcode.io/forks","keys_url":"https://api.github.com/repos/skillz/netcode.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skillz/netcode.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skillz/netcode.io/teams","hooks_url":"https://api.github.com/repos/skillz/netcode.io/hooks","issue_events_url":"https://api.github.com/repos/skillz/netcode.io/issues/events{/number}","events_url":"https://api.github.com/repos/skillz/netcode.io/events","assignees_url":"https://api.github.com/repos/skillz/netcode.io/assignees{/user}","branches_url":"https://api.github.com/repos/skillz/netcode.io/branches{/branch}","tags_url":"https://api.github.com/repos/skillz/netcode.io/tags","blobs_url":"https://api.github.com/repos/skillz/netcode.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skillz/netcode.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skillz/netcode.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/skillz/netcode.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skillz/netcode.io/statuses/{sha}","languages_url":"https://api.github.com/repos/skillz/netcode.io/languages","stargazers_url":"https://api.github.com/repos/skillz/netcode.io/stargazers","contributors_url":"https://api.github.com/repos/skillz/netcode.io/contributors","subscribers_url":"https://api.github.com/repos/skillz/netcode.io/subscribers","subscription_url":"https://api.github.com/repos/skillz/netcode.io/subscription","commits_url":"https://api.github.com/repos/skillz/netcode.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/skillz/netcode.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/skillz/netcode.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/skillz/netcode.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/skillz/netcode.io/contents/{+path}","compare_url":"https://api.github.com/repos/skillz/netcode.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skillz/netcode.io/merges","archive_url":"https://api.github.com/repos/skillz/netcode.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skillz/netcode.io/downloads","issues_url":"https://api.github.com/repos/skillz/netcode.io/issues{/number}","pulls_url":"https://api.github.com/repos/skillz/netcode.io/pulls{/number}","milestones_url":"https://api.github.com/repos/skillz/netcode.io/milestones{/number}","notifications_url":"https://api.github.com/repos/skillz/netcode.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skillz/netcode.io/labels{/name}","releases_url":"https://api.github.com/repos/skillz/netcode.io/releases{/id}","deployments_url":"https://api.github.com/repos/skillz/netcode.io/deployments","created_at":"2017-09-22T20:09:37Z","updated_at":"2017-09-22T20:09:39Z","pushed_at":"2017-10-03T19:01:52Z","git_url":"git://github.com/skillz/netcode.io.git","ssh_url":"git@github.com:skillz/netcode.io.git","clone_url":"https://github.com/skillz/netcode.io.git","svn_url":"https://github.com/skillz/netcode.io","homepage":"","size":4555,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/7"},"html":{"href":"https://github.com/skillz/netcode.io/pull/7"},"issue":{"href":"https://api.github.com/repos/skillz/netcode.io/issues/7"},"comments":{"href":"https://api.github.com/repos/skillz/netcode.io/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/skillz/netcode.io/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/skillz/netcode.io/statuses/fe036c9a386f51e6102ecdcf2c2b321f1dd0e7f7"}},"author_association":"NONE"}}
|
{
"id": 104514581,
"name": "skillz/netcode.io",
"url": "https://api.github.com/repos/skillz/netcode.io"
}
|
{
"id": 11036495,
"login": "kkaminski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11036495?",
"url": "https://api.github.com/users/kkaminski"
}
|
{
"id": 2835552,
"login": "skillz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2835552?",
"url": "https://api.github.com/orgs/skillz"
}
| 2017-10-03T20:09:28 |
6669652303
|
{"actor":{"display_login":"kkaminski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/comments/128004500","pull_request_review_id":50643089,"id":128004500,"diff_hunk":"@@ -67,61 +73,103 @@ public function it_can_be_constructed()\n \n /**\n * @test\n+ * @expectedException Exception\n+ * @expectedExceptionCode 403\n */\n- public function it_uses_the_configured_secret_with_the_helper()\n+ public function it_aborts_if_the_paylod_is_invalid()","path":"tests/Controllers/SsoControllerTest.php","position":57,"original_position":57,"commit_id":"307b85600f58b1dd12e388bc36466cdb91ded767","original_commit_id":"307b85600f58b1dd12e388bc36466cdb91ded767","user":{"login":"ssfinney","id":1596394,"avatar_url":"https://avatars2.githubusercontent.com/u/1596394?v=4","gravatar_id":"","url":"https://api.github.com/users/ssfinney","html_url":"https://github.com/ssfinney","followers_url":"https://api.github.com/users/ssfinney/followers","following_url":"https://api.github.com/users/ssfinney/following{/other_user}","gists_url":"https://api.github.com/users/ssfinney/gists{/gist_id}","starred_url":"https://api.github.com/users/ssfinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssfinney/subscriptions","organizations_url":"https://api.github.com/users/ssfinney/orgs","repos_url":"https://api.github.com/users/ssfinney/repos","events_url":"https://api.github.com/users/ssfinney/events{/privacy}","received_events_url":"https://api.github.com/users/ssfinney/received_events","type":"User","site_admin":false},"body":"\"paylod\" -> \"payload\"","created_at":"2017-07-18T15:09:59Z","updated_at":"2017-07-18T15:10:00Z","html_url":"https://github.com/spinen/laravel-discourse-sso/pull/5#discussion_r128004500","pull_request_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/comments/128004500"},"html":{"href":"https://github.com/spinen/laravel-discourse-sso/pull/5#discussion_r128004500"},"pull_request":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5","id":131111584,"html_url":"https://github.com/spinen/laravel-discourse-sso/pull/5","diff_url":"https://github.com/spinen/laravel-discourse-sso/pull/5.diff","patch_url":"https://github.com/spinen/laravel-discourse-sso/pull/5.patch","issue_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/5","number":5,"state":"open","locked":false,"title":"Feature/allow specifing users withaccess","user":{"login":"jimmypuckett","id":3220069,"avatar_url":"https://avatars1.githubusercontent.com/u/3220069?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmypuckett","html_url":"https://github.com/jimmypuckett","followers_url":"https://api.github.com/users/jimmypuckett/followers","following_url":"https://api.github.com/users/jimmypuckett/following{/other_user}","gists_url":"https://api.github.com/users/jimmypuckett/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmypuckett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmypuckett/subscriptions","organizations_url":"https://api.github.com/users/jimmypuckett/orgs","repos_url":"https://api.github.com/users/jimmypuckett/repos","events_url":"https://api.github.com/users/jimmypuckett/events{/privacy}","received_events_url":"https://api.github.com/users/jimmypuckett/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-18T15:03:38Z","updated_at":"2017-07-18T15:10:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4368bd5ece503d2ee0f5b671d67cc6d8dc0bc423","assignee":{"login":"ssfinney","id":1596394,"avatar_url":"https://avatars2.githubusercontent.com/u/1596394?v=4","gravatar_id":"","url":"https://api.github.com/users/ssfinney","html_url":"https://github.com/ssfinney","followers_url":"https://api.github.com/users/ssfinney/followers","following_url":"https://api.github.com/users/ssfinney/following{/other_user}","gists_url":"https://api.github.com/users/ssfinney/gists{/gist_id}","starred_url":"https://api.github.com/users/ssfinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssfinney/subscriptions","organizations_url":"https://api.github.com/users/ssfinney/orgs","repos_url":"https://api.github.com/users/ssfinney/repos","events_url":"https://api.github.com/users/ssfinney/events{/privacy}","received_events_url":"https://api.github.com/users/ssfinney/received_events","type":"User","site_admin":false},"assignees":[{"login":"ssfinney","id":1596394,"avatar_url":"https://avatars2.githubusercontent.com/u/1596394?v=4","gravatar_id":"","url":"https://api.github.com/users/ssfinney","html_url":"https://github.com/ssfinney","followers_url":"https://api.github.com/users/ssfinney/followers","following_url":"https://api.github.com/users/ssfinney/following{/other_user}","gists_url":"https://api.github.com/users/ssfinney/gists{/gist_id}","starred_url":"https://api.github.com/users/ssfinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssfinney/subscriptions","organizations_url":"https://api.github.com/users/ssfinney/orgs","repos_url":"https://api.github.com/users/ssfinney/repos","events_url":"https://api.github.com/users/ssfinney/events{/privacy}","received_events_url":"https://api.github.com/users/ssfinney/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5/commits","review_comments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5/comments","review_comment_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/5/comments","statuses_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/statuses/307b85600f58b1dd12e388bc36466cdb91ded767","head":{"label":"spinen:feature/allowSpecifingUsersWithaccess","ref":"feature/allowSpecifingUsersWithaccess","sha":"307b85600f58b1dd12e388bc36466cdb91ded767","user":{"login":"spinen","id":4213709,"avatar_url":"https://avatars3.githubusercontent.com/u/4213709?v=4","gravatar_id":"","url":"https://api.github.com/users/spinen","html_url":"https://github.com/spinen","followers_url":"https://api.github.com/users/spinen/followers","following_url":"https://api.github.com/users/spinen/following{/other_user}","gists_url":"https://api.github.com/users/spinen/gists{/gist_id}","starred_url":"https://api.github.com/users/spinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinen/subscriptions","organizations_url":"https://api.github.com/users/spinen/orgs","repos_url":"https://api.github.com/users/spinen/repos","events_url":"https://api.github.com/users/spinen/events{/privacy}","received_events_url":"https://api.github.com/users/spinen/received_events","type":"Organization","site_admin":false},"repo":{"id":96646752,"name":"laravel-discourse-sso","full_name":"spinen/laravel-discourse-sso","owner":{"login":"spinen","id":4213709,"avatar_url":"https://avatars3.githubusercontent.com/u/4213709?v=4","gravatar_id":"","url":"https://api.github.com/users/spinen","html_url":"https://github.com/spinen","followers_url":"https://api.github.com/users/spinen/followers","following_url":"https://api.github.com/users/spinen/following{/other_user}","gists_url":"https://api.github.com/users/spinen/gists{/gist_id}","starred_url":"https://api.github.com/users/spinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinen/subscriptions","organizations_url":"https://api.github.com/users/spinen/orgs","repos_url":"https://api.github.com/users/spinen/repos","events_url":"https://api.github.com/users/spinen/events{/privacy}","received_events_url":"https://api.github.com/users/spinen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinen/laravel-discourse-sso","description":"Integrate Discourse SSO into Laravel","fork":false,"url":"https://api.github.com/repos/spinen/laravel-discourse-sso","forks_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/forks","keys_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/teams","hooks_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/hooks","issue_events_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/events{/number}","events_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/events","assignees_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/assignees{/user}","branches_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/branches{/branch}","tags_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/tags","blobs_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/statuses/{sha}","languages_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/languages","stargazers_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/stargazers","contributors_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/contributors","subscribers_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/subscribers","subscription_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/subscription","commits_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/contents/{+path}","compare_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/merges","archive_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/downloads","issues_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues{/number}","pulls_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls{/number}","milestones_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/milestones{/number}","notifications_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/labels{/name}","releases_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/releases{/id}","deployments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/deployments","created_at":"2017-07-08T22:07:59Z","updated_at":"2017-07-11T14:40:59Z","pushed_at":"2017-07-18T15:03:38Z","git_url":"git://github.com/spinen/laravel-discourse-sso.git","ssh_url":"git@github.com:spinen/laravel-discourse-sso.git","clone_url":"https://github.com/spinen/laravel-discourse-sso.git","svn_url":"https://github.com/spinen/laravel-discourse-sso","homepage":"","size":40,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"base":{"label":"spinen:develop","ref":"develop","sha":"80a0047568120a3531be132f0be844096a8aec3f","user":{"login":"spinen","id":4213709,"avatar_url":"https://avatars3.githubusercontent.com/u/4213709?v=4","gravatar_id":"","url":"https://api.github.com/users/spinen","html_url":"https://github.com/spinen","followers_url":"https://api.github.com/users/spinen/followers","following_url":"https://api.github.com/users/spinen/following{/other_user}","gists_url":"https://api.github.com/users/spinen/gists{/gist_id}","starred_url":"https://api.github.com/users/spinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinen/subscriptions","organizations_url":"https://api.github.com/users/spinen/orgs","repos_url":"https://api.github.com/users/spinen/repos","events_url":"https://api.github.com/users/spinen/events{/privacy}","received_events_url":"https://api.github.com/users/spinen/received_events","type":"Organization","site_admin":false},"repo":{"id":96646752,"name":"laravel-discourse-sso","full_name":"spinen/laravel-discourse-sso","owner":{"login":"spinen","id":4213709,"avatar_url":"https://avatars3.githubusercontent.com/u/4213709?v=4","gravatar_id":"","url":"https://api.github.com/users/spinen","html_url":"https://github.com/spinen","followers_url":"https://api.github.com/users/spinen/followers","following_url":"https://api.github.com/users/spinen/following{/other_user}","gists_url":"https://api.github.com/users/spinen/gists{/gist_id}","starred_url":"https://api.github.com/users/spinen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinen/subscriptions","organizations_url":"https://api.github.com/users/spinen/orgs","repos_url":"https://api.github.com/users/spinen/repos","events_url":"https://api.github.com/users/spinen/events{/privacy}","received_events_url":"https://api.github.com/users/spinen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinen/laravel-discourse-sso","description":"Integrate Discourse SSO into Laravel","fork":false,"url":"https://api.github.com/repos/spinen/laravel-discourse-sso","forks_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/forks","keys_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/teams","hooks_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/hooks","issue_events_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/events{/number}","events_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/events","assignees_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/assignees{/user}","branches_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/branches{/branch}","tags_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/tags","blobs_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/statuses/{sha}","languages_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/languages","stargazers_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/stargazers","contributors_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/contributors","subscribers_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/subscribers","subscription_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/subscription","commits_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/contents/{+path}","compare_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/merges","archive_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/downloads","issues_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues{/number}","pulls_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls{/number}","milestones_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/milestones{/number}","notifications_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/labels{/name}","releases_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/releases{/id}","deployments_url":"https://api.github.com/repos/spinen/laravel-discourse-sso/deployments","created_at":"2017-07-08T22:07:59Z","updated_at":"2017-07-11T14:40:59Z","pushed_at":"2017-07-18T15:03:38Z","git_url":"git://github.com/spinen/laravel-discourse-sso.git","ssh_url":"git@github.com:spinen/laravel-discourse-sso.git","clone_url":"https://github.com/spinen/laravel-discourse-sso.git","svn_url":"https://github.com/spinen/laravel-discourse-sso","homepage":"","size":40,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5"},"html":{"href":"https://github.com/spinen/laravel-discourse-sso/pull/5"},"issue":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/5"},"comments":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/spinen/laravel-discourse-sso/statuses/307b85600f58b1dd12e388bc36466cdb91ded767"}}}}
|
{
"id": 96646752,
"name": "spinen/laravel-discourse-sso",
"url": "https://api.github.com/repos/spinen/laravel-discourse-sso"
}
|
{
"id": 1596394,
"login": "ssfinney",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1596394?",
"url": "https://api.github.com/users/ssfinney"
}
|
{
"id": 4213709,
"login": "spinen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4213709?",
"url": "https://api.github.com/orgs/spinen"
}
| 2017-07-18T15:09:59 |
6278872444
|
{"actor":{"display_login":"ssfinney"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/stripe/stripe-android/pulls/comments/157289011","pull_request_review_id":83912400,"id":157289011,"diff_hunk":"@@ -543,6 +544,68 @@ public Token createPiiTokenSynchronous(@NonNull String personalId, String publis\n mLoggingResponseListener);\n }\n \n+ /**\n+ * Blocking method to create a {@link Token} for a Connect Account. Do not call this on the UI\n+ * thread or your app will crash. The method uses the currently set\n+ * {@link #mDefaultPublishableKey}.\n+ *\n+ * @param accountParams params to use for this token.\n+ * @return a {@link Token} that can be used for this account.\n+ *\n+ * @throws AuthenticationException failure to properly authenticate yourself (check your key)\n+ * @throws InvalidRequestException your request has invalid parameters\n+ * @throws APIConnectionException failure to connect to Stripe's API\n+ * @throws APIException any other type of problem (for instance, a temporary issue with\n+ * Stripe's servers)\n+ */\n+ public Token createAccountTokenSynchronous(@NonNull final AccountParams accountParams)\n+ throws AuthenticationException,\n+ InvalidRequestException,\n+ APIConnectionException,\n+ CardException,\n+ APIException {\n+ return createAccountTokenSynchronous(accountParams, mDefaultPublishableKey);\n+ }\n+\n+ /**\n+ * Blocking method to create a {@link Token} for a Connect Account. Do not call this on the UI\n+ * thread.\n+ *\n+ * @param accountParams params to use for this token.\n+ * @param publishableKey the publishable key to use with this request\n+ * @return a {@link Token} that can be used for this account.\n+ *\n+ * @throws AuthenticationException failure to properly authenticate yourself (check your key)\n+ * @throws InvalidRequestException your request has invalid parameters\n+ * @throws APIConnectionException failure to connect to Stripe's API\n+ * @throws APIException any other type of problem (for instance, a temporary issue with\n+ * Stripe's servers)\n+ */\n+ public Token createAccountTokenSynchronous(\n+ @NonNull final AccountParams accountParams,\n+ @Nullable String publishableKey)","path":"stripe/src/main/java/com/stripe/android/Stripe.java","position":60,"original_position":60,"commit_id":"0086c36d02606b64d9d20e01a25ef0c7952505ad","original_commit_id":"0086c36d02606b64d9d20e01a25ef0c7952505ad","user":{"login":"danj-stripe","id":30532866,"avatar_url":"https://avatars2.githubusercontent.com/u/30532866?v=4","gravatar_id":"","url":"https://api.github.com/users/danj-stripe","html_url":"https://github.com/danj-stripe","followers_url":"https://api.github.com/users/danj-stripe/followers","following_url":"https://api.github.com/users/danj-stripe/following{/other_user}","gists_url":"https://api.github.com/users/danj-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/danj-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danj-stripe/subscriptions","organizations_url":"https://api.github.com/users/danj-stripe/orgs","repos_url":"https://api.github.com/users/danj-stripe/repos","events_url":"https://api.github.com/users/danj-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/danj-stripe/received_events","type":"User","site_admin":false},"body":"You might document what this does if `publishableKey` is `null`. ","created_at":"2017-12-15T20:08:02Z","updated_at":"2017-12-15T21:01:03Z","html_url":"https://github.com/stripe/stripe-android/pull/492#discussion_r157289011","pull_request_url":"https://api.github.com/repos/stripe/stripe-android/pulls/492","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/comments/157289011"},"html":{"href":"https://github.com/stripe/stripe-android/pull/492#discussion_r157289011"},"pull_request":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/492"}}},"pull_request":{"url":"https://api.github.com/repos/stripe/stripe-android/pulls/492","id":158495422,"html_url":"https://github.com/stripe/stripe-android/pull/492","diff_url":"https://github.com/stripe/stripe-android/pull/492.diff","patch_url":"https://github.com/stripe/stripe-android/pull/492.patch","issue_url":"https://api.github.com/repos/stripe/stripe-android/issues/492","number":492,"state":"open","locked":false,"title":"Bindings to support Custom Connect onboarding in Europe","user":{"login":"ksun-stripe","id":30061905,"avatar_url":"https://avatars3.githubusercontent.com/u/30061905?v=4","gravatar_id":"","url":"https://api.github.com/users/ksun-stripe","html_url":"https://github.com/ksun-stripe","followers_url":"https://api.github.com/users/ksun-stripe/followers","following_url":"https://api.github.com/users/ksun-stripe/following{/other_user}","gists_url":"https://api.github.com/users/ksun-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/ksun-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksun-stripe/subscriptions","organizations_url":"https://api.github.com/users/ksun-stripe/orgs","repos_url":"https://api.github.com/users/ksun-stripe/repos","events_url":"https://api.github.com/users/ksun-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/ksun-stripe/received_events","type":"User","site_admin":false},"body":"Add bindings to support custom connect onboarding in Europe. I opted against creating a custom object for legal entity because of longer term maintainability concerns. \r\n\r\nr? @danj-stripe \r\ncc: @basta-stripe @timpeacock-stripe @bg-stripe ","created_at":"2017-12-15T00:13:51Z","updated_at":"2017-12-15T21:01:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b53de721366f91bb6b19237e30901c20cc90657","assignee":{"login":"danj-stripe","id":30532866,"avatar_url":"https://avatars2.githubusercontent.com/u/30532866?v=4","gravatar_id":"","url":"https://api.github.com/users/danj-stripe","html_url":"https://github.com/danj-stripe","followers_url":"https://api.github.com/users/danj-stripe/followers","following_url":"https://api.github.com/users/danj-stripe/following{/other_user}","gists_url":"https://api.github.com/users/danj-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/danj-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danj-stripe/subscriptions","organizations_url":"https://api.github.com/users/danj-stripe/orgs","repos_url":"https://api.github.com/users/danj-stripe/repos","events_url":"https://api.github.com/users/danj-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/danj-stripe/received_events","type":"User","site_admin":false},"assignees":[{"login":"danj-stripe","id":30532866,"avatar_url":"https://avatars2.githubusercontent.com/u/30532866?v=4","gravatar_id":"","url":"https://api.github.com/users/danj-stripe","html_url":"https://github.com/danj-stripe","followers_url":"https://api.github.com/users/danj-stripe/followers","following_url":"https://api.github.com/users/danj-stripe/following{/other_user}","gists_url":"https://api.github.com/users/danj-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/danj-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danj-stripe/subscriptions","organizations_url":"https://api.github.com/users/danj-stripe/orgs","repos_url":"https://api.github.com/users/danj-stripe/repos","events_url":"https://api.github.com/users/danj-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/danj-stripe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stripe/stripe-android/pulls/492/commits","review_comments_url":"https://api.github.com/repos/stripe/stripe-android/pulls/492/comments","review_comment_url":"https://api.github.com/repos/stripe/stripe-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stripe/stripe-android/issues/492/comments","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/0086c36d02606b64d9d20e01a25ef0c7952505ad","head":{"label":"stripe:ksun-connect-bindings","ref":"ksun-connect-bindings","sha":"0086c36d02606b64d9d20e01a25ef0c7952505ad","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6926049,"name":"stripe-android","full_name":"stripe/stripe-android","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-android","description":"Stripe Android SDK ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-android","forks_url":"https://api.github.com/repos/stripe/stripe-android/forks","keys_url":"https://api.github.com/repos/stripe/stripe-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-android/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-android/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-android/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-android/events","assignees_url":"https://api.github.com/repos/stripe/stripe-android/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-android/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-android/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-android/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-android/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-android/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-android/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-android/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-android/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-android/merges","archive_url":"https://api.github.com/repos/stripe/stripe-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-android/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-android/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-android/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-android/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-android/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-android/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-android/deployments","created_at":"2012-11-29T18:11:30Z","updated_at":"2017-12-13T09:43:35Z","pushed_at":"2017-12-15T00:15:52Z","git_url":"git://github.com/stripe/stripe-android.git","ssh_url":"git@github.com:stripe/stripe-android.git","clone_url":"https://github.com/stripe/stripe-android.git","svn_url":"https://github.com/stripe/stripe-android","homepage":"https://stripe.com","size":10034,"stargazers_count":346,"watchers_count":346,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":233,"open_issues":7,"watchers":346,"default_branch":"master"}},"base":{"label":"stripe:master","ref":"master","sha":"4163e57c1f431c85ca96190af0901ef15e4d0fe4","user":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"repo":{"id":6926049,"name":"stripe-android","full_name":"stripe/stripe-android","owner":{"login":"stripe","id":856813,"avatar_url":"https://avatars1.githubusercontent.com/u/856813?v=4","gravatar_id":"","url":"https://api.github.com/users/stripe","html_url":"https://github.com/stripe","followers_url":"https://api.github.com/users/stripe/followers","following_url":"https://api.github.com/users/stripe/following{/other_user}","gists_url":"https://api.github.com/users/stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stripe/subscriptions","organizations_url":"https://api.github.com/users/stripe/orgs","repos_url":"https://api.github.com/users/stripe/repos","events_url":"https://api.github.com/users/stripe/events{/privacy}","received_events_url":"https://api.github.com/users/stripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stripe/stripe-android","description":"Stripe Android SDK ","fork":false,"url":"https://api.github.com/repos/stripe/stripe-android","forks_url":"https://api.github.com/repos/stripe/stripe-android/forks","keys_url":"https://api.github.com/repos/stripe/stripe-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stripe/stripe-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stripe/stripe-android/teams","hooks_url":"https://api.github.com/repos/stripe/stripe-android/hooks","issue_events_url":"https://api.github.com/repos/stripe/stripe-android/issues/events{/number}","events_url":"https://api.github.com/repos/stripe/stripe-android/events","assignees_url":"https://api.github.com/repos/stripe/stripe-android/assignees{/user}","branches_url":"https://api.github.com/repos/stripe/stripe-android/branches{/branch}","tags_url":"https://api.github.com/repos/stripe/stripe-android/tags","blobs_url":"https://api.github.com/repos/stripe/stripe-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stripe/stripe-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stripe/stripe-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/stripe/stripe-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stripe/stripe-android/statuses/{sha}","languages_url":"https://api.github.com/repos/stripe/stripe-android/languages","stargazers_url":"https://api.github.com/repos/stripe/stripe-android/stargazers","contributors_url":"https://api.github.com/repos/stripe/stripe-android/contributors","subscribers_url":"https://api.github.com/repos/stripe/stripe-android/subscribers","subscription_url":"https://api.github.com/repos/stripe/stripe-android/subscription","commits_url":"https://api.github.com/repos/stripe/stripe-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/stripe/stripe-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/stripe/stripe-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/stripe/stripe-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/stripe/stripe-android/contents/{+path}","compare_url":"https://api.github.com/repos/stripe/stripe-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stripe/stripe-android/merges","archive_url":"https://api.github.com/repos/stripe/stripe-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stripe/stripe-android/downloads","issues_url":"https://api.github.com/repos/stripe/stripe-android/issues{/number}","pulls_url":"https://api.github.com/repos/stripe/stripe-android/pulls{/number}","milestones_url":"https://api.github.com/repos/stripe/stripe-android/milestones{/number}","notifications_url":"https://api.github.com/repos/stripe/stripe-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stripe/stripe-android/labels{/name}","releases_url":"https://api.github.com/repos/stripe/stripe-android/releases{/id}","deployments_url":"https://api.github.com/repos/stripe/stripe-android/deployments","created_at":"2012-11-29T18:11:30Z","updated_at":"2017-12-13T09:43:35Z","pushed_at":"2017-12-15T00:15:52Z","git_url":"git://github.com/stripe/stripe-android.git","ssh_url":"git@github.com:stripe/stripe-android.git","clone_url":"https://github.com/stripe/stripe-android.git","svn_url":"https://github.com/stripe/stripe-android","homepage":"https://stripe.com","size":10034,"stargazers_count":346,"watchers_count":346,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":233,"open_issues":7,"watchers":346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/492"},"html":{"href":"https://github.com/stripe/stripe-android/pull/492"},"issue":{"href":"https://api.github.com/repos/stripe/stripe-android/issues/492"},"comments":{"href":"https://api.github.com/repos/stripe/stripe-android/issues/492/comments"},"review_comments":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/492/comments"},"review_comment":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stripe/stripe-android/pulls/492/commits"},"statuses":{"href":"https://api.github.com/repos/stripe/stripe-android/statuses/0086c36d02606b64d9d20e01a25ef0c7952505ad"}},"author_association":"COLLABORATOR"}}
|
{
"id": 6926049,
"name": "stripe/stripe-android",
"url": "https://api.github.com/repos/stripe/stripe-android"
}
|
{
"id": 30532866,
"login": "danj-stripe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30532866?",
"url": "https://api.github.com/users/danj-stripe"
}
|
{
"id": 856813,
"login": "stripe",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/856813?",
"url": "https://api.github.com/orgs/stripe"
}
| 2017-12-15T20:08:02 |
6995822496
|
{"actor":{"display_login":"danj-stripe"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tuenti/python-repoman/pulls/comments/135028273","pull_request_review_id":58393162,"id":135028273,"diff_hunk":"@@ -50,24 +50,31 @@ def grab_changesets(self, path, url, changesets):\n logger.debug('Grabbing changesets from %s to %s' % (url, path))\n git_repo = pygit2.Repository(path)\n try:\n- origin = self._set_origin_source(git_repo, url)\n- #this may fail against github\n- result = origin.fetch()\n- logger.debug('GIT Done grabbing changesets (%s)' % (result))\n- except (pygit2.GitError, OSError) as e:\n- logger.exception('Error Grabbing changesets: %s' % e)\n- logger.info(\"Retrying using process\")\n- try:\n+ self._set_origin_source(git_repo, url)","path":"repoman/git/depot_operations.py","position":12,"original_position":12,"commit_id":"0f4d29443fe41debe071f738e09f808f5d9195dc","original_commit_id":"8f272aab3a7bd0abb2d9168f506068ef6a7c53f8","user":{"login":"jsoriano","id":15763,"avatar_url":"https://avatars2.githubusercontent.com/u/15763?v=4","gravatar_id":"","url":"https://api.github.com/users/jsoriano","html_url":"https://github.com/jsoriano","followers_url":"https://api.github.com/users/jsoriano/followers","following_url":"https://api.github.com/users/jsoriano/following{/other_user}","gists_url":"https://api.github.com/users/jsoriano/gists{/gist_id}","starred_url":"https://api.github.com/users/jsoriano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsoriano/subscriptions","organizations_url":"https://api.github.com/users/jsoriano/orgs","repos_url":"https://api.github.com/users/jsoriano/repos","events_url":"https://api.github.com/users/jsoriano/events{/privacy}","received_events_url":"https://api.github.com/users/jsoriano/received_events","type":"User","site_admin":false},"body":"Ok","created_at":"2017-08-24T14:22:10Z","updated_at":"2017-08-24T14:22:11Z","html_url":"https://github.com/tuenti/python-repoman/pull/14#discussion_r135028273","pull_request_url":"https://api.github.com/repos/tuenti/python-repoman/pulls/14","_links":{"self":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/comments/135028273"},"html":{"href":"https://github.com/tuenti/python-repoman/pull/14#discussion_r135028273"},"pull_request":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/tuenti/python-repoman/pulls/14","id":137439153,"html_url":"https://github.com/tuenti/python-repoman/pull/14","diff_url":"https://github.com/tuenti/python-repoman/pull/14.diff","patch_url":"https://github.com/tuenti/python-repoman/pull/14.patch","issue_url":"https://api.github.com/repos/tuenti/python-repoman/issues/14","number":14,"state":"open","locked":false,"title":"grab_changesets method in git repository changed to use shell commands","user":{"login":"mrodm","id":5330827,"avatar_url":"https://avatars3.githubusercontent.com/u/5330827?v=4","gravatar_id":"","url":"https://api.github.com/users/mrodm","html_url":"https://github.com/mrodm","followers_url":"https://api.github.com/users/mrodm/followers","following_url":"https://api.github.com/users/mrodm/following{/other_user}","gists_url":"https://api.github.com/users/mrodm/gists{/gist_id}","starred_url":"https://api.github.com/users/mrodm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrodm/subscriptions","organizations_url":"https://api.github.com/users/mrodm/orgs","repos_url":"https://api.github.com/users/mrodm/repos","events_url":"https://api.github.com/users/mrodm/events{/privacy}","received_events_url":"https://api.github.com/users/mrodm/received_events","type":"User","site_admin":false},"body":"There are some operations of fetch that are failing due to some files are untracked. \r\nAs example:\r\n\r\n```Exception: \r\n\r\n RAN: '/usr/bin/git checkout a4ad7777e66c39abe6bb237ab647a9370e8eb15f'\r\n\r\n STDOUT:\r\n\r\n STDERR:\r\nerror: The following untracked working tree files would be overwritten by checkout:\r\n\tapp/src/androidTest/java/com/tuenti/messenger/test/core/espresso/matcher/ChatMessageMatcher.java\r\n\tapp/src/main/java/com/tuenti/messenger/conversations/conversationscreen/ioc/GetUIChatMessagesInteractor.java\r\n\tapp/src/main/java/com/tuenti/messenger/conversations/conversationscreen/ioc/GetUIChatMessagesProvider.java\r\n\tapp/src/main/java/com/tuenti/messenger/conversations/conversationscreen/ioc/... (3362 more, please see e.stderr)\r\n```\r\n\r\nChecking `fetch` method in git/depot_operations.py , origin.fetch() method from pygit updates the current working copy from changeset A to the origin HEAD. However, it also leaves all the files modified between A and HEAD in the git stage. Example:\r\n\r\n```\r\nuser@localhost:~/.repo/workspacean_aHy$ git log -n 1 --format=\"%H\"\r\n21d1fa3ffa12201b2aafc8888759d62644d126c6 # <-- current changeset in working copy\r\nuser@localhost:~/.repo/workspacean_aHy$ git status\r\n# On branch integration\r\nnothing to commit (working directory clean)\r\nuser@localhost:~/.repo/workspacean_aHy$ # after origin.fetch()\r\nuser@localhost:~/.repo/workspacean_aHy$ git log -n 1 --oneline\r\n570c52c326fb13b5b6d2a43144a7da53d79016b8 # <--- changeset fetched from origin\r\nuser@localhost:~/.repo/workspacean_aHy$ git status\r\n# On branch integration\r\n# Changes to be committed:\r\n# (use \"git reset HEAD <file>...\" to unstage)\r\n#\r\n#\tmodified: .ci.yml\r\n#\tmodified: Makefile\r\n#\tmodified: app/app_version.properties\r\n#\tmodified: app/build.gradle\r\n....\r\n```\r\n\r\nWith those changes, when doing an `update()` operation using repoman, it failed due to some of those files in stage cannot be clean since in origin do not exist anymore. The clean method does these steps to ensure that working copy is not dirty:\r\n```\r\ngit read-tree --empty\r\ngit reset --hard\r\ngit clean -d -fx \"\"\r\n```\r\n\r\nIn this PR, grab_changesets method has been modified in order to use shell commads as well as to ensure no files remain in the stage after fetch operation.","created_at":"2017-08-24T12:12:30Z","updated_at":"2017-08-24T14:22:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49522c9f2d1b3fe8393440c997c98549888e6df1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"oscarsj","id":1410188,"avatar_url":"https://avatars2.githubusercontent.com/u/1410188?v=4","gravatar_id":"","url":"https://api.github.com/users/oscarsj","html_url":"https://github.com/oscarsj","followers_url":"https://api.github.com/users/oscarsj/followers","following_url":"https://api.github.com/users/oscarsj/following{/other_user}","gists_url":"https://api.github.com/users/oscarsj/gists{/gist_id}","starred_url":"https://api.github.com/users/oscarsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oscarsj/subscriptions","organizations_url":"https://api.github.com/users/oscarsj/orgs","repos_url":"https://api.github.com/users/oscarsj/repos","events_url":"https://api.github.com/users/oscarsj/events{/privacy}","received_events_url":"https://api.github.com/users/oscarsj/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tuenti/python-repoman/pulls/14/commits","review_comments_url":"https://api.github.com/repos/tuenti/python-repoman/pulls/14/comments","review_comment_url":"https://api.github.com/repos/tuenti/python-repoman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tuenti/python-repoman/issues/14/comments","statuses_url":"https://api.github.com/repos/tuenti/python-repoman/statuses/0f4d29443fe41debe071f738e09f808f5d9195dc","head":{"label":"tuenti:operation_fetch_using_git_commands","ref":"operation_fetch_using_git_commands","sha":"0f4d29443fe41debe071f738e09f808f5d9195dc","user":{"login":"tuenti","id":623205,"avatar_url":"https://avatars0.githubusercontent.com/u/623205?v=4","gravatar_id":"","url":"https://api.github.com/users/tuenti","html_url":"https://github.com/tuenti","followers_url":"https://api.github.com/users/tuenti/followers","following_url":"https://api.github.com/users/tuenti/following{/other_user}","gists_url":"https://api.github.com/users/tuenti/gists{/gist_id}","starred_url":"https://api.github.com/users/tuenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuenti/subscriptions","organizations_url":"https://api.github.com/users/tuenti/orgs","repos_url":"https://api.github.com/users/tuenti/repos","events_url":"https://api.github.com/users/tuenti/events{/privacy}","received_events_url":"https://api.github.com/users/tuenti/received_events","type":"Organization","site_admin":false},"repo":{"id":22340399,"name":"python-repoman","full_name":"tuenti/python-repoman","owner":{"login":"tuenti","id":623205,"avatar_url":"https://avatars0.githubusercontent.com/u/623205?v=4","gravatar_id":"","url":"https://api.github.com/users/tuenti","html_url":"https://github.com/tuenti","followers_url":"https://api.github.com/users/tuenti/followers","following_url":"https://api.github.com/users/tuenti/following{/other_user}","gists_url":"https://api.github.com/users/tuenti/gists{/gist_id}","starred_url":"https://api.github.com/users/tuenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuenti/subscriptions","organizations_url":"https://api.github.com/users/tuenti/orgs","repos_url":"https://api.github.com/users/tuenti/repos","events_url":"https://api.github.com/users/tuenti/events{/privacy}","received_events_url":"https://api.github.com/users/tuenti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tuenti/python-repoman","description":"Repoman is a python library designed to automate repository operations in release processes.","fork":false,"url":"https://api.github.com/repos/tuenti/python-repoman","forks_url":"https://api.github.com/repos/tuenti/python-repoman/forks","keys_url":"https://api.github.com/repos/tuenti/python-repoman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuenti/python-repoman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuenti/python-repoman/teams","hooks_url":"https://api.github.com/repos/tuenti/python-repoman/hooks","issue_events_url":"https://api.github.com/repos/tuenti/python-repoman/issues/events{/number}","events_url":"https://api.github.com/repos/tuenti/python-repoman/events","assignees_url":"https://api.github.com/repos/tuenti/python-repoman/assignees{/user}","branches_url":"https://api.github.com/repos/tuenti/python-repoman/branches{/branch}","tags_url":"https://api.github.com/repos/tuenti/python-repoman/tags","blobs_url":"https://api.github.com/repos/tuenti/python-repoman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuenti/python-repoman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuenti/python-repoman/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuenti/python-repoman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuenti/python-repoman/statuses/{sha}","languages_url":"https://api.github.com/repos/tuenti/python-repoman/languages","stargazers_url":"https://api.github.com/repos/tuenti/python-repoman/stargazers","contributors_url":"https://api.github.com/repos/tuenti/python-repoman/contributors","subscribers_url":"https://api.github.com/repos/tuenti/python-repoman/subscribers","subscription_url":"https://api.github.com/repos/tuenti/python-repoman/subscription","commits_url":"https://api.github.com/repos/tuenti/python-repoman/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuenti/python-repoman/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuenti/python-repoman/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuenti/python-repoman/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuenti/python-repoman/contents/{+path}","compare_url":"https://api.github.com/repos/tuenti/python-repoman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuenti/python-repoman/merges","archive_url":"https://api.github.com/repos/tuenti/python-repoman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuenti/python-repoman/downloads","issues_url":"https://api.github.com/repos/tuenti/python-repoman/issues{/number}","pulls_url":"https://api.github.com/repos/tuenti/python-repoman/pulls{/number}","milestones_url":"https://api.github.com/repos/tuenti/python-repoman/milestones{/number}","notifications_url":"https://api.github.com/repos/tuenti/python-repoman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuenti/python-repoman/labels{/name}","releases_url":"https://api.github.com/repos/tuenti/python-repoman/releases{/id}","deployments_url":"https://api.github.com/repos/tuenti/python-repoman/deployments","created_at":"2014-07-28T11:33:20Z","updated_at":"2017-08-24T12:21:04Z","pushed_at":"2017-08-24T13:07:38Z","git_url":"git://github.com/tuenti/python-repoman.git","ssh_url":"git@github.com:tuenti/python-repoman.git","clone_url":"https://github.com/tuenti/python-repoman.git","svn_url":"https://github.com/tuenti/python-repoman","homepage":null,"size":282,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":10,"default_branch":"master"}},"base":{"label":"tuenti:fix_merge_exception","ref":"fix_merge_exception","sha":"839be7a15f64ae3597bacb584c82633cb5545202","user":{"login":"tuenti","id":623205,"avatar_url":"https://avatars0.githubusercontent.com/u/623205?v=4","gravatar_id":"","url":"https://api.github.com/users/tuenti","html_url":"https://github.com/tuenti","followers_url":"https://api.github.com/users/tuenti/followers","following_url":"https://api.github.com/users/tuenti/following{/other_user}","gists_url":"https://api.github.com/users/tuenti/gists{/gist_id}","starred_url":"https://api.github.com/users/tuenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuenti/subscriptions","organizations_url":"https://api.github.com/users/tuenti/orgs","repos_url":"https://api.github.com/users/tuenti/repos","events_url":"https://api.github.com/users/tuenti/events{/privacy}","received_events_url":"https://api.github.com/users/tuenti/received_events","type":"Organization","site_admin":false},"repo":{"id":22340399,"name":"python-repoman","full_name":"tuenti/python-repoman","owner":{"login":"tuenti","id":623205,"avatar_url":"https://avatars0.githubusercontent.com/u/623205?v=4","gravatar_id":"","url":"https://api.github.com/users/tuenti","html_url":"https://github.com/tuenti","followers_url":"https://api.github.com/users/tuenti/followers","following_url":"https://api.github.com/users/tuenti/following{/other_user}","gists_url":"https://api.github.com/users/tuenti/gists{/gist_id}","starred_url":"https://api.github.com/users/tuenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuenti/subscriptions","organizations_url":"https://api.github.com/users/tuenti/orgs","repos_url":"https://api.github.com/users/tuenti/repos","events_url":"https://api.github.com/users/tuenti/events{/privacy}","received_events_url":"https://api.github.com/users/tuenti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tuenti/python-repoman","description":"Repoman is a python library designed to automate repository operations in release processes.","fork":false,"url":"https://api.github.com/repos/tuenti/python-repoman","forks_url":"https://api.github.com/repos/tuenti/python-repoman/forks","keys_url":"https://api.github.com/repos/tuenti/python-repoman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tuenti/python-repoman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tuenti/python-repoman/teams","hooks_url":"https://api.github.com/repos/tuenti/python-repoman/hooks","issue_events_url":"https://api.github.com/repos/tuenti/python-repoman/issues/events{/number}","events_url":"https://api.github.com/repos/tuenti/python-repoman/events","assignees_url":"https://api.github.com/repos/tuenti/python-repoman/assignees{/user}","branches_url":"https://api.github.com/repos/tuenti/python-repoman/branches{/branch}","tags_url":"https://api.github.com/repos/tuenti/python-repoman/tags","blobs_url":"https://api.github.com/repos/tuenti/python-repoman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tuenti/python-repoman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tuenti/python-repoman/git/refs{/sha}","trees_url":"https://api.github.com/repos/tuenti/python-repoman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tuenti/python-repoman/statuses/{sha}","languages_url":"https://api.github.com/repos/tuenti/python-repoman/languages","stargazers_url":"https://api.github.com/repos/tuenti/python-repoman/stargazers","contributors_url":"https://api.github.com/repos/tuenti/python-repoman/contributors","subscribers_url":"https://api.github.com/repos/tuenti/python-repoman/subscribers","subscription_url":"https://api.github.com/repos/tuenti/python-repoman/subscription","commits_url":"https://api.github.com/repos/tuenti/python-repoman/commits{/sha}","git_commits_url":"https://api.github.com/repos/tuenti/python-repoman/git/commits{/sha}","comments_url":"https://api.github.com/repos/tuenti/python-repoman/comments{/number}","issue_comment_url":"https://api.github.com/repos/tuenti/python-repoman/issues/comments{/number}","contents_url":"https://api.github.com/repos/tuenti/python-repoman/contents/{+path}","compare_url":"https://api.github.com/repos/tuenti/python-repoman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tuenti/python-repoman/merges","archive_url":"https://api.github.com/repos/tuenti/python-repoman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tuenti/python-repoman/downloads","issues_url":"https://api.github.com/repos/tuenti/python-repoman/issues{/number}","pulls_url":"https://api.github.com/repos/tuenti/python-repoman/pulls{/number}","milestones_url":"https://api.github.com/repos/tuenti/python-repoman/milestones{/number}","notifications_url":"https://api.github.com/repos/tuenti/python-repoman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tuenti/python-repoman/labels{/name}","releases_url":"https://api.github.com/repos/tuenti/python-repoman/releases{/id}","deployments_url":"https://api.github.com/repos/tuenti/python-repoman/deployments","created_at":"2014-07-28T11:33:20Z","updated_at":"2017-08-24T12:21:04Z","pushed_at":"2017-08-24T13:07:38Z","git_url":"git://github.com/tuenti/python-repoman.git","ssh_url":"git@github.com:tuenti/python-repoman.git","clone_url":"https://github.com/tuenti/python-repoman.git","svn_url":"https://github.com/tuenti/python-repoman","homepage":null,"size":282,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":1,"forks":7,"open_issues":1,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/14"},"html":{"href":"https://github.com/tuenti/python-repoman/pull/14"},"issue":{"href":"https://api.github.com/repos/tuenti/python-repoman/issues/14"},"comments":{"href":"https://api.github.com/repos/tuenti/python-repoman/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tuenti/python-repoman/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/tuenti/python-repoman/statuses/0f4d29443fe41debe071f738e09f808f5d9195dc"}}}}
|
{
"id": 22340399,
"name": "tuenti/python-repoman",
"url": "https://api.github.com/repos/tuenti/python-repoman"
}
|
{
"id": 15763,
"login": "jsoriano",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15763?",
"url": "https://api.github.com/users/jsoriano"
}
|
{
"id": 623205,
"login": "tuenti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/623205?",
"url": "https://api.github.com/orgs/tuenti"
}
| 2017-08-24T14:22:10 |
6507748463
|
{"actor":{"display_login":"jsoriano"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/txamqp/txamqp/pulls/comments/125622621","pull_request_review_id":48028319,"id":125622621,"diff_hunk":"@@ -2,7 +2,12 @@ sudo: false\n dist: trusty\n language: python\n python:\n- - 2.7\n-services: rabbitmq\n-install: pip install -r requirements.txt\n-script: cd src; TXAMQP_BROKER=RABBITMQ trial txamqp\n+ - \"2.7\"\n+ - \"3.3\"\n+ - \"3.4\"","path":".travis.yml","position":10,"original_position":10,"commit_id":"10e0e63c68404bb98edc3122a3deddfc53c65b13","original_commit_id":"10e0e63c68404bb98edc3122a3deddfc53c65b13","user":{"login":"terrycain","id":1986397,"avatar_url":"https://avatars0.githubusercontent.com/u/1986397?v=3","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"body":"Sure and I definitely agree, will commit the change later.","created_at":"2017-07-05T11:55:19Z","updated_at":"2017-07-05T11:55:19Z","html_url":"https://github.com/txamqp/txamqp/pull/1#discussion_r125622621","pull_request_url":"https://api.github.com/repos/txamqp/txamqp/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/comments/125622621"},"html":{"href":"https://github.com/txamqp/txamqp/pull/1#discussion_r125622621"},"pull_request":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/txamqp/txamqp/pulls/1","id":128861799,"html_url":"https://github.com/txamqp/txamqp/pull/1","diff_url":"https://github.com/txamqp/txamqp/pull/1.diff","patch_url":"https://github.com/txamqp/txamqp/pull/1.patch","issue_url":"https://api.github.com/repos/txamqp/txamqp/issues/1","number":1,"state":"open","locked":false,"title":"Add Python3 Compatibility","user":{"login":"terrycain","id":1986397,"avatar_url":"https://avatars0.githubusercontent.com/u/1986397?v=3","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"body":"Hey, I thought seeing as Twisted has ported a large majority of code to Python3 this library could benefit from it as well.\r\n\r\nFirst of all, sorry for the large patch of small changes. I've converted the main library to be compatible with both Python2 and Python3, hope that's OK :wink:. I haven't updated the `examples`, `setup.py` to include the six dependancy (though Twisted also depends on it) or the `.travis.yml` to run both Python2 and Python3 tests, if your happy with this PR I'll also commit those changes.\r\n\r\nHave run the test cases for both Python2 and Python3, all unit tests that use RabbitMQ pass (the other ones were skipped.\r\n\r\n## Test Results: \r\n[txamqp-test-python2.txt](https://github.com/txamqp/txamqp/files/1123133/txamqp-test-python2.txt)\r\n[txamqp-test-python3.txt](https://github.com/txamqp/txamqp/files/1123135/txamqp-test-python3.txt)\r\n\r\nAs far as I'm aware the code has not changed functionally (excluding the 2 method that handle actual binary data), from the end users view it should act exactly as expected.\r\n\r\n## File by file change overview:\r\n### codec.py\r\n* Swapped out StringIO with BytesIO\r\n* Created dedicated enc/dec functions to handle actual binary data, then the current enc/dec string methods take care of strings\r\n* Changed some strings in enc/dec table methods to byte strings for byte == byte comparisons\r\n* Swapped out xrange for range (could of used six.moves.range)\r\n\r\n### connection.py\r\n* Swapped out StringIO with BytesIO\r\n* Changed relative import syntax\r\n* Used six's cross version metaclass compatibility\r\n* Changed the enc/dec methods in Method to use encode_longbytes and decode_longbytes\r\n\r\n### delegate.py\r\n* Changed relative import syntax\r\n\r\n### endpoint.py\r\n* URI.fromBytes really wants bytes not unicode so did some .encodes and .decodes to keep it happy\r\n\r\n### protocol.py\r\n* Swapped out StringIO with BytesIO\r\n* Changed except syntax to except as\r\n* Swapped out xrange for range (could of used six.moves.range)\r\n* Changed FrameReceiver.__buffer to a bytestring so then += still works\r\n* Changed \"AMQP\" to a bytestring b\"AMQP\"\r\n* In readContent I replaced StringIO with six.StringIO as io.StringIO is not the same as StringIO.StringIO in Python2 and this retains expected behaviour\r\n\r\n### spec.py\r\n* Replaced module creation code with the types.ModuleType way which is cross version\r\n* Replaced \"dict.has_key\" with \"key in dict\"\r\n* Changed exec to its functional equivelent\r\n* Changed print to its functional equivelent\r\n\r\n### testing.py\r\n* Changed iteritems to items\r\n* Changed print to its functional equivelent\r\n* Changed except syntax to except as\r\n\r\n### testlib.py\r\n* Surrounded filter with list as the result gets indexed and Python3's filter returns an iterator\r\n\r\n### test/test_queue.py\r\n* Changed print to its functional equivelent, arguably the print in this file is unnecessary\r\n\r\n### test/test_testlib.py\r\n* Changed print to its functional equivelent, arguably the print in this file is unnecessary","created_at":"2017-07-04T22:28:33Z","updated_at":"2017-07-05T11:55:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b5754b1dd4a1783258570291d88404d48662358","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/txamqp/txamqp/pulls/1/commits","review_comments_url":"https://api.github.com/repos/txamqp/txamqp/pulls/1/comments","review_comment_url":"https://api.github.com/repos/txamqp/txamqp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/txamqp/txamqp/issues/1/comments","statuses_url":"https://api.github.com/repos/txamqp/txamqp/statuses/10e0e63c68404bb98edc3122a3deddfc53c65b13","head":{"label":"terrycain:python3","ref":"python3","sha":"10e0e63c68404bb98edc3122a3deddfc53c65b13","user":{"login":"terrycain","id":1986397,"avatar_url":"https://avatars0.githubusercontent.com/u/1986397?v=3","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"repo":{"id":96232194,"name":"txamqp","full_name":"terrycain/txamqp","owner":{"login":"terrycain","id":1986397,"avatar_url":"https://avatars0.githubusercontent.com/u/1986397?v=3","gravatar_id":"","url":"https://api.github.com/users/terrycain","html_url":"https://github.com/terrycain","followers_url":"https://api.github.com/users/terrycain/followers","following_url":"https://api.github.com/users/terrycain/following{/other_user}","gists_url":"https://api.github.com/users/terrycain/gists{/gist_id}","starred_url":"https://api.github.com/users/terrycain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terrycain/subscriptions","organizations_url":"https://api.github.com/users/terrycain/orgs","repos_url":"https://api.github.com/users/terrycain/repos","events_url":"https://api.github.com/users/terrycain/events{/privacy}","received_events_url":"https://api.github.com/users/terrycain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/terrycain/txamqp","description":null,"fork":true,"url":"https://api.github.com/repos/terrycain/txamqp","forks_url":"https://api.github.com/repos/terrycain/txamqp/forks","keys_url":"https://api.github.com/repos/terrycain/txamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terrycain/txamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terrycain/txamqp/teams","hooks_url":"https://api.github.com/repos/terrycain/txamqp/hooks","issue_events_url":"https://api.github.com/repos/terrycain/txamqp/issues/events{/number}","events_url":"https://api.github.com/repos/terrycain/txamqp/events","assignees_url":"https://api.github.com/repos/terrycain/txamqp/assignees{/user}","branches_url":"https://api.github.com/repos/terrycain/txamqp/branches{/branch}","tags_url":"https://api.github.com/repos/terrycain/txamqp/tags","blobs_url":"https://api.github.com/repos/terrycain/txamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terrycain/txamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terrycain/txamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/terrycain/txamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terrycain/txamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/terrycain/txamqp/languages","stargazers_url":"https://api.github.com/repos/terrycain/txamqp/stargazers","contributors_url":"https://api.github.com/repos/terrycain/txamqp/contributors","subscribers_url":"https://api.github.com/repos/terrycain/txamqp/subscribers","subscription_url":"https://api.github.com/repos/terrycain/txamqp/subscription","commits_url":"https://api.github.com/repos/terrycain/txamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/terrycain/txamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/terrycain/txamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/terrycain/txamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/terrycain/txamqp/contents/{+path}","compare_url":"https://api.github.com/repos/terrycain/txamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terrycain/txamqp/merges","archive_url":"https://api.github.com/repos/terrycain/txamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terrycain/txamqp/downloads","issues_url":"https://api.github.com/repos/terrycain/txamqp/issues{/number}","pulls_url":"https://api.github.com/repos/terrycain/txamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/terrycain/txamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/terrycain/txamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terrycain/txamqp/labels{/name}","releases_url":"https://api.github.com/repos/terrycain/txamqp/releases{/id}","deployments_url":"https://api.github.com/repos/terrycain/txamqp/deployments","created_at":"2017-07-04T15:32:30Z","updated_at":"2017-07-04T15:32:31Z","pushed_at":"2017-07-05T09:14:58Z","git_url":"git://github.com/terrycain/txamqp.git","ssh_url":"git@github.com:terrycain/txamqp.git","clone_url":"https://github.com/terrycain/txamqp.git","svn_url":"https://github.com/terrycain/txamqp","homepage":null,"size":588,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"txamqp:master","ref":"master","sha":"8669f216c36fd39c99e5b0a866d39cbac27453cd","user":{"login":"txamqp","id":19798942,"avatar_url":"https://avatars3.githubusercontent.com/u/19798942?v=3","gravatar_id":"","url":"https://api.github.com/users/txamqp","html_url":"https://github.com/txamqp","followers_url":"https://api.github.com/users/txamqp/followers","following_url":"https://api.github.com/users/txamqp/following{/other_user}","gists_url":"https://api.github.com/users/txamqp/gists{/gist_id}","starred_url":"https://api.github.com/users/txamqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txamqp/subscriptions","organizations_url":"https://api.github.com/users/txamqp/orgs","repos_url":"https://api.github.com/users/txamqp/repos","events_url":"https://api.github.com/users/txamqp/events{/privacy}","received_events_url":"https://api.github.com/users/txamqp/received_events","type":"Organization","site_admin":false},"repo":{"id":71566482,"name":"txamqp","full_name":"txamqp/txamqp","owner":{"login":"txamqp","id":19798942,"avatar_url":"https://avatars3.githubusercontent.com/u/19798942?v=3","gravatar_id":"","url":"https://api.github.com/users/txamqp","html_url":"https://github.com/txamqp","followers_url":"https://api.github.com/users/txamqp/followers","following_url":"https://api.github.com/users/txamqp/following{/other_user}","gists_url":"https://api.github.com/users/txamqp/gists{/gist_id}","starred_url":"https://api.github.com/users/txamqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/txamqp/subscriptions","organizations_url":"https://api.github.com/users/txamqp/orgs","repos_url":"https://api.github.com/users/txamqp/repos","events_url":"https://api.github.com/users/txamqp/events{/privacy}","received_events_url":"https://api.github.com/users/txamqp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/txamqp/txamqp","description":null,"fork":false,"url":"https://api.github.com/repos/txamqp/txamqp","forks_url":"https://api.github.com/repos/txamqp/txamqp/forks","keys_url":"https://api.github.com/repos/txamqp/txamqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/txamqp/txamqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/txamqp/txamqp/teams","hooks_url":"https://api.github.com/repos/txamqp/txamqp/hooks","issue_events_url":"https://api.github.com/repos/txamqp/txamqp/issues/events{/number}","events_url":"https://api.github.com/repos/txamqp/txamqp/events","assignees_url":"https://api.github.com/repos/txamqp/txamqp/assignees{/user}","branches_url":"https://api.github.com/repos/txamqp/txamqp/branches{/branch}","tags_url":"https://api.github.com/repos/txamqp/txamqp/tags","blobs_url":"https://api.github.com/repos/txamqp/txamqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/txamqp/txamqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/txamqp/txamqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/txamqp/txamqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/txamqp/txamqp/statuses/{sha}","languages_url":"https://api.github.com/repos/txamqp/txamqp/languages","stargazers_url":"https://api.github.com/repos/txamqp/txamqp/stargazers","contributors_url":"https://api.github.com/repos/txamqp/txamqp/contributors","subscribers_url":"https://api.github.com/repos/txamqp/txamqp/subscribers","subscription_url":"https://api.github.com/repos/txamqp/txamqp/subscription","commits_url":"https://api.github.com/repos/txamqp/txamqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/txamqp/txamqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/txamqp/txamqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/txamqp/txamqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/txamqp/txamqp/contents/{+path}","compare_url":"https://api.github.com/repos/txamqp/txamqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/txamqp/txamqp/merges","archive_url":"https://api.github.com/repos/txamqp/txamqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/txamqp/txamqp/downloads","issues_url":"https://api.github.com/repos/txamqp/txamqp/issues{/number}","pulls_url":"https://api.github.com/repos/txamqp/txamqp/pulls{/number}","milestones_url":"https://api.github.com/repos/txamqp/txamqp/milestones{/number}","notifications_url":"https://api.github.com/repos/txamqp/txamqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/txamqp/txamqp/labels{/name}","releases_url":"https://api.github.com/repos/txamqp/txamqp/releases{/id}","deployments_url":"https://api.github.com/repos/txamqp/txamqp/deployments","created_at":"2016-10-21T13:19:45Z","updated_at":"2017-05-16T18:44:43Z","pushed_at":"2017-07-05T09:14:59Z","git_url":"git://github.com/txamqp/txamqp.git","ssh_url":"git@github.com:txamqp/txamqp.git","clone_url":"https://github.com/txamqp/txamqp.git","svn_url":"https://github.com/txamqp/txamqp","homepage":null,"size":576,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/1"},"html":{"href":"https://github.com/txamqp/txamqp/pull/1"},"issue":{"href":"https://api.github.com/repos/txamqp/txamqp/issues/1"},"comments":{"href":"https://api.github.com/repos/txamqp/txamqp/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/txamqp/txamqp/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/txamqp/txamqp/statuses/10e0e63c68404bb98edc3122a3deddfc53c65b13"}}}}
|
{
"id": 71566482,
"name": "txamqp/txamqp",
"url": "https://api.github.com/repos/txamqp/txamqp"
}
|
{
"id": 1986397,
"login": "terrycain",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1986397?",
"url": "https://api.github.com/users/terrycain"
}
|
{
"id": 19798942,
"login": "txamqp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19798942?",
"url": "https://api.github.com/orgs/txamqp"
}
| 2017-07-05T11:55:19 |
6195172607
|
{"actor":{"display_login":"terrycain"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/u-root/u-root/pulls/comments/133098136","pull_request_review_id":56242577,"id":133098136,"diff_hunk":"@@ -46,17 +47,27 @@ var (\n )\n \n func ifup(ifname string) (netlink.Link, error) {\n-\tiface, err := netlink.LinkByName(ifname)\n-\tif err != nil {\n-\t\treturn nil, fmt.Errorf(\"cannot get interface by name %v: %v\", ifname, err)\n-\t}\n-\n-\tif err := netlink.LinkSetUp(iface); err != nil {\n-\t\treturn nil, fmt.Errorf(\"%v: %v can't make it up: %v\", ifname, iface, err)\n-\t}\n+\tstart := time.Now().Second()\n+\tfor time.Now().Second() - start < linkUpAttempt {\n+\t\t// Note that it may seem odd to keep trying the\n+\t\t// LinkByName operation, by consider that a hotplug\n+\t\t// device such as USB ethernet can just vanish.\n+\t\tiface, err := netlink.LinkByName(ifname)\n+\t\tif err != nil {\n+\t\t\treturn nil, fmt.Errorf(\"cannot get interface by name %v: %v\", ifname, err)\n+\t\t}\n \n-\treturn iface, nil\n+\t\tif iface.Attrs().OperState == netlink.OperUp {\n+\t\t\tdebug(\"Link %v is up\", ifname)\n+\t\t\treturn iface, nil\n+\t\t}\n \n+\t\tif err := netlink.LinkSetUp(iface); err != nil {","path":"cmds/dhclient/dhclient.go","position":36,"original_position":36,"commit_id":"84e67d07d11bcdda933fe95263a6fade02445ad8","original_commit_id":"84e67d07d11bcdda933fe95263a6fade02445ad8","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"body":"I think it's best to see if it's up before trying to do something to it, since some script or other action might have already set it up. I've observed we only go through the loop at 1.5 times (we bail on the second iteration when it is in OperUp state) so I think it's ok to do it this way. Thanks.","created_at":"2017-08-15T01:01:16Z","updated_at":"2017-08-15T01:01:17Z","html_url":"https://github.com/u-root/u-root/pull/331#discussion_r133098136","pull_request_url":"https://api.github.com/repos/u-root/u-root/pulls/331","_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments/133098136"},"html":{"href":"https://github.com/u-root/u-root/pull/331#discussion_r133098136"},"pull_request":{"href":"https://api.github.com/repos/u-root/u-root/pulls/331"}}},"pull_request":{"url":"https://api.github.com/repos/u-root/u-root/pulls/331","id":135480578,"html_url":"https://github.com/u-root/u-root/pull/331","diff_url":"https://github.com/u-root/u-root/pull/331.diff","patch_url":"https://github.com/u-root/u-root/pull/331.patch","issue_url":"https://api.github.com/repos/u-root/u-root/issues/331","number":331,"state":"open","locked":false,"title":"dhclient: improve ifup code","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"body":"The code should see if the link is up, and if so return immediately.\nIt should not return until the link is up.\n30 seconds is about as long as one should try.\n\nThis will make it so you no longer have to hit ^C on the\nfirst dhclient :-)\n\nSigned-off-by: Ronald G. Minnich <rminnich@gmail.com>","created_at":"2017-08-13T03:28:08Z","updated_at":"2017-08-15T01:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"102a514c90571e618248e8da8fc97910d2293f63","assignee":null,"assignees":[],"requested_reviewers":[{"login":"floren","id":93811,"avatar_url":"https://avatars0.githubusercontent.com/u/93811?v=4","gravatar_id":"","url":"https://api.github.com/users/floren","html_url":"https://github.com/floren","followers_url":"https://api.github.com/users/floren/followers","following_url":"https://api.github.com/users/floren/following{/other_user}","gists_url":"https://api.github.com/users/floren/gists{/gist_id}","starred_url":"https://api.github.com/users/floren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floren/subscriptions","organizations_url":"https://api.github.com/users/floren/orgs","repos_url":"https://api.github.com/users/floren/repos","events_url":"https://api.github.com/users/floren/events{/privacy}","received_events_url":"https://api.github.com/users/floren/received_events","type":"User","site_admin":false},{"login":"GanShun","id":3449939,"avatar_url":"https://avatars3.githubusercontent.com/u/3449939?v=4","gravatar_id":"","url":"https://api.github.com/users/GanShun","html_url":"https://github.com/GanShun","followers_url":"https://api.github.com/users/GanShun/followers","following_url":"https://api.github.com/users/GanShun/following{/other_user}","gists_url":"https://api.github.com/users/GanShun/gists{/gist_id}","starred_url":"https://api.github.com/users/GanShun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GanShun/subscriptions","organizations_url":"https://api.github.com/users/GanShun/orgs","repos_url":"https://api.github.com/users/GanShun/repos","events_url":"https://api.github.com/users/GanShun/events{/privacy}","received_events_url":"https://api.github.com/users/GanShun/received_events","type":"User","site_admin":false},{"login":"djfritz","id":4811604,"avatar_url":"https://avatars2.githubusercontent.com/u/4811604?v=4","gravatar_id":"","url":"https://api.github.com/users/djfritz","html_url":"https://github.com/djfritz","followers_url":"https://api.github.com/users/djfritz/followers","following_url":"https://api.github.com/users/djfritz/following{/other_user}","gists_url":"https://api.github.com/users/djfritz/gists{/gist_id}","starred_url":"https://api.github.com/users/djfritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djfritz/subscriptions","organizations_url":"https://api.github.com/users/djfritz/orgs","repos_url":"https://api.github.com/users/djfritz/repos","events_url":"https://api.github.com/users/djfritz/events{/privacy}","received_events_url":"https://api.github.com/users/djfritz/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/u-root/u-root/pulls/331/commits","review_comments_url":"https://api.github.com/repos/u-root/u-root/pulls/331/comments","review_comment_url":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/u-root/u-root/issues/331/comments","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/84e67d07d11bcdda933fe95263a6fade02445ad8","head":{"label":"rminnich:fixdhclientifup","ref":"fixdhclientifup","sha":"84e67d07d11bcdda933fe95263a6fade02445ad8","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"repo":{"id":53349408,"name":"u-root","full_name":"rminnich/u-root","owner":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rminnich/u-root","description":"A universal root. You mount it, and it's mostly Go source with the exception of 5 binaries. ","fork":true,"url":"https://api.github.com/repos/rminnich/u-root","forks_url":"https://api.github.com/repos/rminnich/u-root/forks","keys_url":"https://api.github.com/repos/rminnich/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rminnich/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rminnich/u-root/teams","hooks_url":"https://api.github.com/repos/rminnich/u-root/hooks","issue_events_url":"https://api.github.com/repos/rminnich/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/rminnich/u-root/events","assignees_url":"https://api.github.com/repos/rminnich/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/rminnich/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/rminnich/u-root/tags","blobs_url":"https://api.github.com/repos/rminnich/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rminnich/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rminnich/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/rminnich/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rminnich/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/rminnich/u-root/languages","stargazers_url":"https://api.github.com/repos/rminnich/u-root/stargazers","contributors_url":"https://api.github.com/repos/rminnich/u-root/contributors","subscribers_url":"https://api.github.com/repos/rminnich/u-root/subscribers","subscription_url":"https://api.github.com/repos/rminnich/u-root/subscription","commits_url":"https://api.github.com/repos/rminnich/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/rminnich/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/rminnich/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/rminnich/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/rminnich/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/rminnich/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rminnich/u-root/merges","archive_url":"https://api.github.com/repos/rminnich/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rminnich/u-root/downloads","issues_url":"https://api.github.com/repos/rminnich/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/rminnich/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/rminnich/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/rminnich/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rminnich/u-root/labels{/name}","releases_url":"https://api.github.com/repos/rminnich/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/rminnich/u-root/deployments","created_at":"2016-03-07T18:40:47Z","updated_at":"2017-07-12T10:24:25Z","pushed_at":"2017-08-13T20:22:46Z","git_url":"git://github.com/rminnich/u-root.git","ssh_url":"git@github.com:rminnich/u-root.git","clone_url":"https://github.com/rminnich/u-root.git","svn_url":"https://github.com/rminnich/u-root","homepage":null,"size":21440,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"u-root:master","ref":"master","sha":"7244477489647a66bba04c23fb0a17dfb2f3634b","user":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"repo":{"id":46462030,"name":"u-root","full_name":"u-root/u-root","owner":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/u-root/u-root","description":"A universal root. You mount it, and it's mostly Go source with the exception of 4 binaries. ","fork":false,"url":"https://api.github.com/repos/u-root/u-root","forks_url":"https://api.github.com/repos/u-root/u-root/forks","keys_url":"https://api.github.com/repos/u-root/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u-root/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u-root/u-root/teams","hooks_url":"https://api.github.com/repos/u-root/u-root/hooks","issue_events_url":"https://api.github.com/repos/u-root/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/u-root/u-root/events","assignees_url":"https://api.github.com/repos/u-root/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/u-root/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/u-root/u-root/tags","blobs_url":"https://api.github.com/repos/u-root/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u-root/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u-root/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/u-root/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/u-root/u-root/languages","stargazers_url":"https://api.github.com/repos/u-root/u-root/stargazers","contributors_url":"https://api.github.com/repos/u-root/u-root/contributors","subscribers_url":"https://api.github.com/repos/u-root/u-root/subscribers","subscription_url":"https://api.github.com/repos/u-root/u-root/subscription","commits_url":"https://api.github.com/repos/u-root/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/u-root/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/u-root/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/u-root/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/u-root/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/u-root/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u-root/u-root/merges","archive_url":"https://api.github.com/repos/u-root/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u-root/u-root/downloads","issues_url":"https://api.github.com/repos/u-root/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/u-root/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/u-root/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/u-root/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u-root/u-root/labels{/name}","releases_url":"https://api.github.com/repos/u-root/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/u-root/u-root/deployments","created_at":"2015-11-19T02:28:59Z","updated_at":"2017-08-02T17:49:41Z","pushed_at":"2017-08-15T00:54:51Z","git_url":"git://github.com/u-root/u-root.git","ssh_url":"git@github.com:u-root/u-root.git","clone_url":"https://github.com/u-root/u-root.git","svn_url":"https://github.com/u-root/u-root","homepage":"http://u-root.tk","size":21464,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":31,"forks":19,"open_issues":31,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/331"},"html":{"href":"https://github.com/u-root/u-root/pull/331"},"issue":{"href":"https://api.github.com/repos/u-root/u-root/issues/331"},"comments":{"href":"https://api.github.com/repos/u-root/u-root/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/u-root/u-root/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/u-root/u-root/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/u-root/u-root/statuses/84e67d07d11bcdda933fe95263a6fade02445ad8"}}}}
|
{
"id": 46462030,
"name": "u-root/u-root",
"url": "https://api.github.com/repos/u-root/u-root"
}
|
{
"id": 74928,
"login": "rminnich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/74928?",
"url": "https://api.github.com/users/rminnich"
}
|
{
"id": 13317538,
"login": "u-root",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13317538?",
"url": "https://api.github.com/orgs/u-root"
}
| 2017-08-15T01:01:16 |
6451911223
|
{"actor":{"display_login":"rminnich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/u-root/u-root/pulls/comments/142172271","pull_request_review_id":66494856,"id":142172271,"diff_hunk":"@@ -0,0 +1,224 @@\n+// Copyright 2009-2017 The Go Authors. All rights reserved.\n+// Use of this source code is governed by a BSD-style\n+// license that can be found in the LICENSE file.\n+\n+// gpt implements reading and writing of GUID Partition tables.\n+// GPTs are dumped in JSON format and written in same.\n+// One complication is that we frequently only want to\n+// write a very small subset of a GPT. For example,\n+// we might only want to change the GUID. As it happens\n+// it is simpler (and more useful) just to read and write\n+// the whole thing. In for a penny, in for a pound.\n+package gpt\n+\n+import (\n+\t\"bytes\"\n+\t\"encoding/binary\"\n+\t\"encoding/json\"\n+\t\"fmt\"\n+\t\"hash/crc32\"\n+\t\"io\"\n+\t\"log\"\n+\t\"reflect\"\n+\n+\t\"github.com/google/uuid\"\n+)\n+\n+const (\n+\tBlockSize = 512\n+\tHeaderOff = 0x200\n+\tHeaderSize = 0x5c // They claim it can vary. Give me a break.\n+\tSignature = 0x5452415020494645\n+\tRevision = 0x10000\n+\tMaxNPart = 0x80\n+)\n+\n+type Header struct {\n+\tSignature uint64 // (\"EFI PART\", 45h 46h 49h 20h 50h 41h 52h 54h or 0x5452415020494645ULL[a] on little-endian machines)\n+\tRevision uint32 // (for GPT version 1.0 (through at least UEFI version 2.7 (May 2017)), the value is 00h 00h 01h 00h)\n+\tHeaderSize uint32 // size in little endian (in bytes, usually 5Ch 00h 00h 00h or 92 bytes)\n+\tCRC uint32 // CRC32/zlib of header (offset +0 up to header size) in little endian, with this field zeroed during calculation\n+\tReserved uint32 // ; must be zero\n+\tCurrentLBA uint64 // (location of this header copy)\n+\tBackupLBA uint64 // (location of the other header copy)\n+\tFirstLBA uint64 // usable LBA for partitions (primary partition table last LBA + 1)\n+\tLastLBA uint64 // usable LBA (secondary partition table first LBA - 1)\n+\tDiskGUID uuid.UUID // (also referred as UUID on UNIXes)\n+\tPartStart uint64 // LBA of array of partition entries (always 2 in primary copy)\n+\tNPart uint32 // Number of partition entries in array\n+\tPartSize uint32 // Size of a single partition entry (usually 80h or 128)\n+\tPartCRC uint32 // CRC32/zlib of partition array in little endian\n+}\n+\n+type PartAttr uint64\n+type PartName [72]byte\n+type Part struct {\n+\tPartGUID uuid.UUID // Partition type GUID\n+\tUniqueGUID uuid.UUID // Unique partition GUID\n+\tFirstLBA uint64 // LBA (little endian)\n+\tLastLBA uint64 // LBA (inclusive, usually odd)\n+\tAttribute PartAttr // flags (e.g. bit 60 denotes read-only)\n+\tName PartName // Partition name (36 UTF-16LE code units)\n+}\n+\n+func (g *GPT) String() string {\n+\tb, err := json.MarshalIndent(g, \"\", \"\\t\")\n+\tif err != nil {\n+\t\tlog.Fatalf(\"Can't marshal %v\", *g)\n+\t}\n+\treturn string(b)\n+}\n+\n+type GPT struct {\n+\tHeader\n+\tParts []Part\n+}\n+\n+// EqualHeader compares two headers and returns true if they match.\n+// Those fields which by definition must differ are ignored.\n+func EqualHeader(p, b Header) bool {\n+\treturn p.Signature == b.Signature &&\n+\t\tp.Revision == b.Revision &&\n+\t\tp.HeaderSize == b.HeaderSize &&\n+\t\tp.CurrentLBA == b.BackupLBA &&\n+\t\tp.BackupLBA == b.CurrentLBA &&\n+\t\tp.FirstLBA == b.FirstLBA &&\n+\t\tp.LastLBA == b.LastLBA &&\n+\t\tp.DiskGUID == b.DiskGUID &&\n+\t\tp.NPart == b.NPart &&\n+\t\tp.PartSize == b.PartSize &&\n+\t\tp.PartCRC == b.PartCRC\n+}\n+\n+// Table reads on gpt table at the passed in offset. It checks that\n+// the Signature, Revision, HeaderSize, and MaxPart are reasonable. It\n+// also verifies the header and partition table CRC32 values.\n+func Table(r io.ReaderAt, off int64) (*GPT, error) {\n+\twhich := \"Primary\"\n+\tif off != BlockSize {\n+\t\twhich = \"Backup\"\n+\t}\n+\tvar g = &GPT{}\n+\tif err := binary.Read(io.NewSectionReader(r, off, HeaderSize), binary.LittleEndian, &g.Header); err != nil {\n+\t\treturn nil, err\n+\t}\n+\n+\tif g.Signature != Signature {\n+\t\treturn nil, fmt.Errorf(\"%s GPT signature invalid (%x), needs to be %x\", which, g.Signature, Signature)\n+\t}\n+\tif g.Revision != Revision {\n+\t\treturn nil, fmt.Errorf(\"%s GPT revision (%x) is not supported value (%x)\", which, g.Revision, Revision)\n+\t}\n+\tif g.HeaderSize != HeaderSize {\n+\t\treturn nil, fmt.Errorf(\"%s GPT HeaderSize (%x) is not supported value (%x)\", which, g.HeaderSize, HeaderSize)\n+\t}\n+\tif g.NPart > MaxNPart {\n+\t\treturn nil, fmt.Errorf(\"%s GPT MaxNPart (%x) is above maximum of %x\", which, g.NPart, MaxNPart)\n+\t}\n+\n+\t// Read in all the partition data and check the hash.\n+\t// Since the partition hash is included in the header CRC,\n+\t// it's sensible to check it first.\n+\ts := int64(g.PartSize)\n+\tpartBlocks := make([]byte, int64(g.NPart)*s)\n+\tn, err := r.ReadAt(partBlocks, int64(g.PartStart)*BlockSize)\n+\tif n != len(partBlocks) || err != nil {\n+\t\treturn nil, fmt.Errorf(\"%s Reading partitions: Wanted %d bytes, got %d: %v\", which, n, len(partBlocks), err)\n+\t}\n+\tif h := crc32.ChecksumIEEE(partBlocks); h != g.PartCRC {\n+\t\treturn g, fmt.Errorf(\"%s Partition CRC: Header %v, computed checksum is %08x, header has %08x\", which, g, h, g.PartCRC)\n+\t}\n+\n+\thdr := make([]byte, g.HeaderSize)\n+\tn, err = r.ReadAt(hdr, off)\n+\tif n != len(hdr) || err != nil {\n+\t\treturn nil, fmt.Errorf(\"%s Reading Header: Wanted %d bytes, got %d: %v\", which, n, len(hdr), err)\n+\t}\n+\t// Zap the checksum in the header to 0.\n+\tcopy(hdr[16:], []byte{0, 0, 0, 0})\n+\tif h := crc32.ChecksumIEEE(hdr); h != g.CRC {\n+\t\treturn g, fmt.Errorf(\"%s Header CRC: computed checksum is %08x, header has %08x\", which, h, g.CRC)\n+\t}\n+\n+\t// Now read in the partition table entries.\n+\tg.Parts = make([]Part, g.NPart)\n+\n+\tfor i := int64(0); i < int64(g.NPart); i++ {\n+\t\tif err := binary.Read(io.NewSectionReader(r, int64(g.PartStart*BlockSize)+i*s, s), binary.LittleEndian, &g.Parts[i]); err != nil {\n+\t\t\treturn nil, fmt.Errorf(\"%s GPT partition %d failed: %v\", which, i, err)\n+\t\t}\n+\t}\n+\n+\treturn g, nil\n+\n+}\n+\n+// Write writes the GPT to w, both primary and backup. It generates the CRCs before writing.\n+// It takes an io.Writer and assumes that you are correctly positioned in the output stream.\n+// This means we must adjust partition numbers by subtracting one from them.\n+func Write(w io.WriterAt, g *GPT) error {\n+\tps := int64(g.PartStart * BlockSize)\n+\t// The maximum extent is ps + NPart * PartSize\n+\tvar h = make([]byte, uint64(g.NPart*g.PartSize))\n+\ts := int64(g.PartSize)\n+\tfor i := int64(0); i < int64(g.NPart); i++ {\n+\t\tvar b bytes.Buffer\n+\t\tif err := binary.Write(&b, binary.LittleEndian, &g.Parts[i]); err != nil {\n+\t\t\treturn err\n+\t\t}\n+\t\tcopy(h[i*s:], b.Bytes())\n+\t}\n+\tif _, err := w.WriteAt(h, ps); err != nil {\n+\t\treturn fmt.Errorf(\"Writing %d bytes of partition table at %v: %v\", len(h), ps, err)\n+\t}\n+\n+\tg.PartCRC = crc32.ChecksumIEEE(h[:])\n+\tg.CRC = 0\n+\tvar b bytes.Buffer\n+\tif err := binary.Write(&b, binary.LittleEndian, &g.Header); err != nil {\n+\t\treturn err\n+\t}\n+\th = make([]byte, g.HeaderSize)\n+\tcopy(h, b.Bytes())\n+\tg.CRC = crc32.ChecksumIEEE(h[:])\n+\tb.Reset()\n+\tif err := binary.Write(&b, binary.LittleEndian, g.CRC); err != nil {\n+\t\treturn err\n+\t}\n+\tcopy(h[16:], b.Bytes())\n+\n+\t_, err := w.WriteAt(h, int64(g.CurrentLBA * BlockSize))\n+\treturn err\n+}\n+\n+// New reads in the primary and backup GPT from a disk and returns a pointer to them.\n+// There are some checks it can apply. It can return with a\n+// one or more headers AND an error. Sorry. Experience with some real USB sticks\n+// is showing that we need to return data even if there are some things wrong.\n+func New(r io.ReaderAt) (*GPT, *GPT, error) {\n+\tg, err := Table(r, HeaderOff)\n+\t// If we can't read the table it's kinda hard to find the backup.\n+\t// Bit of a flaw in the design, eh?\n+\tif err != nil {\n+\t\treturn nil, nil, err\n+\t}\n+\n+\tb, err := Table(r, int64(g.BackupLBA*BlockSize))\n+\tif err != nil {\n+\t\t// you go to war with the army you have","path":"pkg/gpt/gpt.go","position":208,"original_position":208,"commit_id":"5224698631d90e68ec418a54c34d83c896634fa7","original_commit_id":"5224698631d90e68ec418a54c34d83c896634fa7","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"body":"?? I do. What am I missing?","created_at":"2017-10-02T15:29:03Z","updated_at":"2017-10-02T15:29:03Z","html_url":"https://github.com/u-root/u-root/pull/372#discussion_r142172271","pull_request_url":"https://api.github.com/repos/u-root/u-root/pulls/372","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments/142172271"},"html":{"href":"https://github.com/u-root/u-root/pull/372#discussion_r142172271"},"pull_request":{"href":"https://api.github.com/repos/u-root/u-root/pulls/372"}},"in_reply_to_id":142047429},"pull_request":{"url":"https://api.github.com/repos/u-root/u-root/pulls/372","id":143562560,"html_url":"https://github.com/u-root/u-root/pull/372","diff_url":"https://github.com/u-root/u-root/pull/372.diff","patch_url":"https://github.com/u-root/u-root/pull/372.patch","issue_url":"https://api.github.com/repos/u-root/u-root/issues/372","number":372,"state":"open","locked":false,"title":"GPT package and sample program","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"body":"This is needed for NiChrome so it can rewrite partition UUIDs.\n\nI am expecting to get lots of comments so go for it.","created_at":"2017-09-28T06:09:53Z","updated_at":"2017-10-02T15:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da1760cd524dbbe9b52e4f85cc34b608616b117","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rafaelcn","id":3271143,"avatar_url":"https://avatars2.githubusercontent.com/u/3271143?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaelcn","html_url":"https://github.com/rafaelcn","followers_url":"https://api.github.com/users/rafaelcn/followers","following_url":"https://api.github.com/users/rafaelcn/following{/other_user}","gists_url":"https://api.github.com/users/rafaelcn/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelcn/subscriptions","organizations_url":"https://api.github.com/users/rafaelcn/orgs","repos_url":"https://api.github.com/users/rafaelcn/repos","events_url":"https://api.github.com/users/rafaelcn/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelcn/received_events","type":"User","site_admin":false},{"login":"LaconicPneumonic","id":6172844,"avatar_url":"https://avatars3.githubusercontent.com/u/6172844?v=4","gravatar_id":"","url":"https://api.github.com/users/LaconicPneumonic","html_url":"https://github.com/LaconicPneumonic","followers_url":"https://api.github.com/users/LaconicPneumonic/followers","following_url":"https://api.github.com/users/LaconicPneumonic/following{/other_user}","gists_url":"https://api.github.com/users/LaconicPneumonic/gists{/gist_id}","starred_url":"https://api.github.com/users/LaconicPneumonic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaconicPneumonic/subscriptions","organizations_url":"https://api.github.com/users/LaconicPneumonic/orgs","repos_url":"https://api.github.com/users/LaconicPneumonic/repos","events_url":"https://api.github.com/users/LaconicPneumonic/events{/privacy}","received_events_url":"https://api.github.com/users/LaconicPneumonic/received_events","type":"User","site_admin":false},{"login":"ananion-cation","id":11541884,"avatar_url":"https://avatars3.githubusercontent.com/u/11541884?v=4","gravatar_id":"","url":"https://api.github.com/users/ananion-cation","html_url":"https://github.com/ananion-cation","followers_url":"https://api.github.com/users/ananion-cation/followers","following_url":"https://api.github.com/users/ananion-cation/following{/other_user}","gists_url":"https://api.github.com/users/ananion-cation/gists{/gist_id}","starred_url":"https://api.github.com/users/ananion-cation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananion-cation/subscriptions","organizations_url":"https://api.github.com/users/ananion-cation/orgs","repos_url":"https://api.github.com/users/ananion-cation/repos","events_url":"https://api.github.com/users/ananion-cation/events{/privacy}","received_events_url":"https://api.github.com/users/ananion-cation/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/u-root/u-root/pulls/372/commits","review_comments_url":"https://api.github.com/repos/u-root/u-root/pulls/372/comments","review_comment_url":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/u-root/u-root/issues/372/comments","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/5224698631d90e68ec418a54c34d83c896634fa7","head":{"label":"rminnich:gpt","ref":"gpt","sha":"5224698631d90e68ec418a54c34d83c896634fa7","user":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"repo":{"id":53349408,"name":"u-root","full_name":"rminnich/u-root","owner":{"login":"rminnich","id":74928,"avatar_url":"https://avatars0.githubusercontent.com/u/74928?v=4","gravatar_id":"","url":"https://api.github.com/users/rminnich","html_url":"https://github.com/rminnich","followers_url":"https://api.github.com/users/rminnich/followers","following_url":"https://api.github.com/users/rminnich/following{/other_user}","gists_url":"https://api.github.com/users/rminnich/gists{/gist_id}","starred_url":"https://api.github.com/users/rminnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rminnich/subscriptions","organizations_url":"https://api.github.com/users/rminnich/orgs","repos_url":"https://api.github.com/users/rminnich/repos","events_url":"https://api.github.com/users/rminnich/events{/privacy}","received_events_url":"https://api.github.com/users/rminnich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rminnich/u-root","description":"A universal root. You mount it, and it's mostly Go source with the exception of 5 binaries. ","fork":true,"url":"https://api.github.com/repos/rminnich/u-root","forks_url":"https://api.github.com/repos/rminnich/u-root/forks","keys_url":"https://api.github.com/repos/rminnich/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rminnich/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rminnich/u-root/teams","hooks_url":"https://api.github.com/repos/rminnich/u-root/hooks","issue_events_url":"https://api.github.com/repos/rminnich/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/rminnich/u-root/events","assignees_url":"https://api.github.com/repos/rminnich/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/rminnich/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/rminnich/u-root/tags","blobs_url":"https://api.github.com/repos/rminnich/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rminnich/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rminnich/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/rminnich/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rminnich/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/rminnich/u-root/languages","stargazers_url":"https://api.github.com/repos/rminnich/u-root/stargazers","contributors_url":"https://api.github.com/repos/rminnich/u-root/contributors","subscribers_url":"https://api.github.com/repos/rminnich/u-root/subscribers","subscription_url":"https://api.github.com/repos/rminnich/u-root/subscription","commits_url":"https://api.github.com/repos/rminnich/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/rminnich/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/rminnich/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/rminnich/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/rminnich/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/rminnich/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rminnich/u-root/merges","archive_url":"https://api.github.com/repos/rminnich/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rminnich/u-root/downloads","issues_url":"https://api.github.com/repos/rminnich/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/rminnich/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/rminnich/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/rminnich/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rminnich/u-root/labels{/name}","releases_url":"https://api.github.com/repos/rminnich/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/rminnich/u-root/deployments","created_at":"2016-03-07T18:40:47Z","updated_at":"2017-08-15T12:20:23Z","pushed_at":"2017-09-30T05:14:30Z","git_url":"git://github.com/rminnich/u-root.git","ssh_url":"git@github.com:rminnich/u-root.git","clone_url":"https://github.com/rminnich/u-root.git","svn_url":"https://github.com/rminnich/u-root","homepage":null,"size":21663,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"u-root:master","ref":"master","sha":"350141b8c029095b4da0b9b2e58caa790ff4f95c","user":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"repo":{"id":46462030,"name":"u-root","full_name":"u-root/u-root","owner":{"login":"u-root","id":13317538,"avatar_url":"https://avatars3.githubusercontent.com/u/13317538?v=4","gravatar_id":"","url":"https://api.github.com/users/u-root","html_url":"https://github.com/u-root","followers_url":"https://api.github.com/users/u-root/followers","following_url":"https://api.github.com/users/u-root/following{/other_user}","gists_url":"https://api.github.com/users/u-root/gists{/gist_id}","starred_url":"https://api.github.com/users/u-root/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u-root/subscriptions","organizations_url":"https://api.github.com/users/u-root/orgs","repos_url":"https://api.github.com/users/u-root/repos","events_url":"https://api.github.com/users/u-root/events{/privacy}","received_events_url":"https://api.github.com/users/u-root/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/u-root/u-root","description":"A universal root. You mount it, and it's mostly Go source with the exception of 4 binaries. ","fork":false,"url":"https://api.github.com/repos/u-root/u-root","forks_url":"https://api.github.com/repos/u-root/u-root/forks","keys_url":"https://api.github.com/repos/u-root/u-root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u-root/u-root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u-root/u-root/teams","hooks_url":"https://api.github.com/repos/u-root/u-root/hooks","issue_events_url":"https://api.github.com/repos/u-root/u-root/issues/events{/number}","events_url":"https://api.github.com/repos/u-root/u-root/events","assignees_url":"https://api.github.com/repos/u-root/u-root/assignees{/user}","branches_url":"https://api.github.com/repos/u-root/u-root/branches{/branch}","tags_url":"https://api.github.com/repos/u-root/u-root/tags","blobs_url":"https://api.github.com/repos/u-root/u-root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u-root/u-root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u-root/u-root/git/refs{/sha}","trees_url":"https://api.github.com/repos/u-root/u-root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u-root/u-root/statuses/{sha}","languages_url":"https://api.github.com/repos/u-root/u-root/languages","stargazers_url":"https://api.github.com/repos/u-root/u-root/stargazers","contributors_url":"https://api.github.com/repos/u-root/u-root/contributors","subscribers_url":"https://api.github.com/repos/u-root/u-root/subscribers","subscription_url":"https://api.github.com/repos/u-root/u-root/subscription","commits_url":"https://api.github.com/repos/u-root/u-root/commits{/sha}","git_commits_url":"https://api.github.com/repos/u-root/u-root/git/commits{/sha}","comments_url":"https://api.github.com/repos/u-root/u-root/comments{/number}","issue_comment_url":"https://api.github.com/repos/u-root/u-root/issues/comments{/number}","contents_url":"https://api.github.com/repos/u-root/u-root/contents/{+path}","compare_url":"https://api.github.com/repos/u-root/u-root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u-root/u-root/merges","archive_url":"https://api.github.com/repos/u-root/u-root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u-root/u-root/downloads","issues_url":"https://api.github.com/repos/u-root/u-root/issues{/number}","pulls_url":"https://api.github.com/repos/u-root/u-root/pulls{/number}","milestones_url":"https://api.github.com/repos/u-root/u-root/milestones{/number}","notifications_url":"https://api.github.com/repos/u-root/u-root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u-root/u-root/labels{/name}","releases_url":"https://api.github.com/repos/u-root/u-root/releases{/id}","deployments_url":"https://api.github.com/repos/u-root/u-root/deployments","created_at":"2015-11-19T02:28:59Z","updated_at":"2017-10-02T14:47:49Z","pushed_at":"2017-10-02T13:57:34Z","git_url":"git://github.com/u-root/u-root.git","ssh_url":"git@github.com:u-root/u-root.git","clone_url":"https://github.com/u-root/u-root.git","svn_url":"https://github.com/u-root/u-root","homepage":"http://u-root.tk","size":21661,"stargazers_count":48,"watchers_count":48,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":29,"forks":23,"open_issues":29,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/u-root/u-root/pulls/372"},"html":{"href":"https://github.com/u-root/u-root/pull/372"},"issue":{"href":"https://api.github.com/repos/u-root/u-root/issues/372"},"comments":{"href":"https://api.github.com/repos/u-root/u-root/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/u-root/u-root/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/u-root/u-root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/u-root/u-root/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/u-root/u-root/statuses/5224698631d90e68ec418a54c34d83c896634fa7"}},"author_association":"OWNER"}}
|
{
"id": 46462030,
"name": "u-root/u-root",
"url": "https://api.github.com/repos/u-root/u-root"
}
|
{
"id": 74928,
"login": "rminnich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/74928?",
"url": "https://api.github.com/users/rminnich"
}
|
{
"id": 13317538,
"login": "u-root",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13317538?",
"url": "https://api.github.com/orgs/u-root"
}
| 2017-10-02T15:29:03 |
6663166032
|
{"actor":{"display_login":"rminnich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vmware/vic/pulls/comments/101113819","pull_request_review_id":21834077,"id":101113819,"diff_hunk":"@@ -0,0 +1,159 @@\n+// Copyright 2017 VMware, Inc. All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package vsan\n+\n+import (\n+\t\"context\"\n+\t\"encoding/json\"\n+\n+\tlog \"github.com/Sirupsen/logrus\"\n+\n+\t\"github.com/vmware/govmomi/object\"\n+\t\"github.com/vmware/govmomi/vim25\"\n+\t\"github.com/vmware/govmomi/vim25/methods\"\n+\t//\t\"github.com/vmware/govmomi/vim25/mo\"","path":"pkg/vsphere/vsan/host_vsan_internal_system.go","position":26,"original_position":26,"commit_id":"62d78daa3747817fb55669798184be09e16fe227","original_commit_id":"62d78daa3747817fb55669798184be09e16fe227","user":{"login":"vburenin","id":4350891,"avatar_url":"https://avatars.githubusercontent.com/u/4350891?v=3","gravatar_id":"","url":"https://api.github.com/users/vburenin","html_url":"https://github.com/vburenin","followers_url":"https://api.github.com/users/vburenin/followers","following_url":"https://api.github.com/users/vburenin/following{/other_user}","gists_url":"https://api.github.com/users/vburenin/gists{/gist_id}","starred_url":"https://api.github.com/users/vburenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vburenin/subscriptions","organizations_url":"https://api.github.com/users/vburenin/orgs","repos_url":"https://api.github.com/users/vburenin/repos","events_url":"https://api.github.com/users/vburenin/events{/privacy}","received_events_url":"https://api.github.com/users/vburenin/received_events","type":"User","site_admin":false},"body":"Do you keep these imports on purpose?","created_at":"2017-02-14T18:59:18Z","updated_at":"2017-02-14T18:59:18Z","html_url":"https://github.com/vmware/vic/pull/3929#discussion_r101113819","pull_request_url":"https://api.github.com/repos/vmware/vic/pulls/3929","_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments/101113819"},"html":{"href":"https://github.com/vmware/vic/pull/3929#discussion_r101113819"},"pull_request":{"href":"https://api.github.com/repos/vmware/vic/pulls/3929"}}},"pull_request":{"url":"https://api.github.com/repos/vmware/vic/pulls/3929","id":105996824,"html_url":"https://github.com/vmware/vic/pull/3929","diff_url":"https://github.com/vmware/vic/pull/3929.diff","patch_url":"https://github.com/vmware/vic/pull/3929.patch","issue_url":"https://api.github.com/repos/vmware/vic/issues/3929","number":3929,"state":"open","locked":false,"title":"Add vsan dom cache, and concurrent access interface","user":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"body":" This is the vsan dom sync up code. Based on this, vic-machine delete, docker rmi, and docker volume rm should call this to delete\r\n vsan dom object\r\n\r\n The code in vic-machine and storage portlayer will be in other PRs\r\nRelated to #3787","created_at":"2017-02-13T22:49:57Z","updated_at":"2017-02-14T18:59:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4985f38edce0418b9734feca8ebaff973d1260f7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vmware/vic/pulls/3929/commits","review_comments_url":"https://api.github.com/repos/vmware/vic/pulls/3929/comments","review_comment_url":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vmware/vic/issues/3929/comments","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/62d78daa3747817fb55669798184be09e16fe227","head":{"label":"emlin:3787","ref":"3787","sha":"62d78daa3747817fb55669798184be09e16fe227","user":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"repo":{"id":55440951,"name":"vic","full_name":"emlin/vic","owner":{"login":"emlin","id":1091772,"avatar_url":"https://avatars.githubusercontent.com/u/1091772?v=3","gravatar_id":"","url":"https://api.github.com/users/emlin","html_url":"https://github.com/emlin","followers_url":"https://api.github.com/users/emlin/followers","following_url":"https://api.github.com/users/emlin/following{/other_user}","gists_url":"https://api.github.com/users/emlin/gists{/gist_id}","starred_url":"https://api.github.com/users/emlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emlin/subscriptions","organizations_url":"https://api.github.com/users/emlin/orgs","repos_url":"https://api.github.com/users/emlin/repos","events_url":"https://api.github.com/users/emlin/events{/privacy}","received_events_url":"https://api.github.com/users/emlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emlin/vic","description":"Integrated containers on vSphere","fork":true,"url":"https://api.github.com/repos/emlin/vic","forks_url":"https://api.github.com/repos/emlin/vic/forks","keys_url":"https://api.github.com/repos/emlin/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emlin/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emlin/vic/teams","hooks_url":"https://api.github.com/repos/emlin/vic/hooks","issue_events_url":"https://api.github.com/repos/emlin/vic/issues/events{/number}","events_url":"https://api.github.com/repos/emlin/vic/events","assignees_url":"https://api.github.com/repos/emlin/vic/assignees{/user}","branches_url":"https://api.github.com/repos/emlin/vic/branches{/branch}","tags_url":"https://api.github.com/repos/emlin/vic/tags","blobs_url":"https://api.github.com/repos/emlin/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emlin/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emlin/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/emlin/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emlin/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/emlin/vic/languages","stargazers_url":"https://api.github.com/repos/emlin/vic/stargazers","contributors_url":"https://api.github.com/repos/emlin/vic/contributors","subscribers_url":"https://api.github.com/repos/emlin/vic/subscribers","subscription_url":"https://api.github.com/repos/emlin/vic/subscription","commits_url":"https://api.github.com/repos/emlin/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/emlin/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/emlin/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/emlin/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/emlin/vic/contents/{+path}","compare_url":"https://api.github.com/repos/emlin/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emlin/vic/merges","archive_url":"https://api.github.com/repos/emlin/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emlin/vic/downloads","issues_url":"https://api.github.com/repos/emlin/vic/issues{/number}","pulls_url":"https://api.github.com/repos/emlin/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/emlin/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/emlin/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emlin/vic/labels{/name}","releases_url":"https://api.github.com/repos/emlin/vic/releases{/id}","deployments_url":"https://api.github.com/repos/emlin/vic/deployments","created_at":"2016-04-04T20:04:54Z","updated_at":"2016-04-04T20:04:55Z","pushed_at":"2017-02-14T18:42:01Z","git_url":"git://github.com/emlin/vic.git","ssh_url":"git@github.com:emlin/vic.git","clone_url":"https://github.com/emlin/vic.git","svn_url":"https://github.com/emlin/vic","homepage":null,"size":40137,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vmware:master","ref":"master","sha":"cbe8e49a27ead86636eede07333ebb7c52a5538f","user":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"repo":{"id":49597898,"name":"vic","full_name":"vmware/vic","owner":{"login":"vmware","id":473334,"avatar_url":"https://avatars.githubusercontent.com/u/473334?v=3","gravatar_id":"","url":"https://api.github.com/users/vmware","html_url":"https://github.com/vmware","followers_url":"https://api.github.com/users/vmware/followers","following_url":"https://api.github.com/users/vmware/following{/other_user}","gists_url":"https://api.github.com/users/vmware/gists{/gist_id}","starred_url":"https://api.github.com/users/vmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmware/subscriptions","organizations_url":"https://api.github.com/users/vmware/orgs","repos_url":"https://api.github.com/users/vmware/repos","events_url":"https://api.github.com/users/vmware/events{/privacy}","received_events_url":"https://api.github.com/users/vmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vmware/vic","description":"Integrated containers engine on vSphere","fork":false,"url":"https://api.github.com/repos/vmware/vic","forks_url":"https://api.github.com/repos/vmware/vic/forks","keys_url":"https://api.github.com/repos/vmware/vic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmware/vic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmware/vic/teams","hooks_url":"https://api.github.com/repos/vmware/vic/hooks","issue_events_url":"https://api.github.com/repos/vmware/vic/issues/events{/number}","events_url":"https://api.github.com/repos/vmware/vic/events","assignees_url":"https://api.github.com/repos/vmware/vic/assignees{/user}","branches_url":"https://api.github.com/repos/vmware/vic/branches{/branch}","tags_url":"https://api.github.com/repos/vmware/vic/tags","blobs_url":"https://api.github.com/repos/vmware/vic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmware/vic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmware/vic/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmware/vic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmware/vic/statuses/{sha}","languages_url":"https://api.github.com/repos/vmware/vic/languages","stargazers_url":"https://api.github.com/repos/vmware/vic/stargazers","contributors_url":"https://api.github.com/repos/vmware/vic/contributors","subscribers_url":"https://api.github.com/repos/vmware/vic/subscribers","subscription_url":"https://api.github.com/repos/vmware/vic/subscription","commits_url":"https://api.github.com/repos/vmware/vic/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmware/vic/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmware/vic/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmware/vic/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmware/vic/contents/{+path}","compare_url":"https://api.github.com/repos/vmware/vic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmware/vic/merges","archive_url":"https://api.github.com/repos/vmware/vic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmware/vic/downloads","issues_url":"https://api.github.com/repos/vmware/vic/issues{/number}","pulls_url":"https://api.github.com/repos/vmware/vic/pulls{/number}","milestones_url":"https://api.github.com/repos/vmware/vic/milestones{/number}","notifications_url":"https://api.github.com/repos/vmware/vic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmware/vic/labels{/name}","releases_url":"https://api.github.com/repos/vmware/vic/releases{/id}","deployments_url":"https://api.github.com/repos/vmware/vic/deployments","created_at":"2016-01-13T19:53:57Z","updated_at":"2017-02-14T10:09:22Z","pushed_at":"2017-02-14T18:44:48Z","git_url":"git://github.com/vmware/vic.git","ssh_url":"git@github.com:vmware/vic.git","clone_url":"https://github.com/vmware/vic.git","svn_url":"https://github.com/vmware/vic","homepage":"http://vmware.github.io/vic","size":49289,"stargazers_count":189,"watchers_count":189,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":75,"mirror_url":null,"open_issues_count":619,"forks":75,"open_issues":619,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vmware/vic/pulls/3929"},"html":{"href":"https://github.com/vmware/vic/pull/3929"},"issue":{"href":"https://api.github.com/repos/vmware/vic/issues/3929"},"comments":{"href":"https://api.github.com/repos/vmware/vic/issues/3929/comments"},"review_comments":{"href":"https://api.github.com/repos/vmware/vic/pulls/3929/comments"},"review_comment":{"href":"https://api.github.com/repos/vmware/vic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vmware/vic/pulls/3929/commits"},"statuses":{"href":"https://api.github.com/repos/vmware/vic/statuses/62d78daa3747817fb55669798184be09e16fe227"}}}}
|
{
"id": 49597898,
"name": "vmware/vic",
"url": "https://api.github.com/repos/vmware/vic"
}
|
{
"id": 4350891,
"login": "vburenin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4350891?",
"url": "https://api.github.com/users/vburenin"
}
|
{
"id": 473334,
"login": "vmware",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/473334?",
"url": "https://api.github.com/orgs/vmware"
}
| 2017-02-14T18:59:18 |
5323715897
|
{"actor":{"display_login":"vburenin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/whatwg/html/pulls/comments/118892655","pull_request_review_id":40726723,"id":118892655,"diff_hunk":"@@ -99960,6 +99945,491 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> {\n \n <div w-nodev>\n \n+ <h4><dfn data-x=\"parse error\">Parse errors</dfn></h4>\n+\n+ <p>This specification defines the parsing rules for HTML documents, whether they are syntactically\n+ correct or not. Certain points in the parsing algorithm are said to be <span data-x=\"parse\n+ error\">parse errors</span>. The error handling for parse errors is well-defined (that's the\n+ processing rules described throughout this specification), but user agents, while parsing an HTML\n+ document, may <span data-x=\"abort a parser\">abort the parser</span> at the first <span>parse\n+ error</span> that they encounter for which they do not wish to apply the rules described in this\n+ specification.</p>\n+\n+ <p>Conformance checkers must report at least one parse error condition to the user if one or more\n+ parse error conditions exist in the document and must not report parse error conditions if none\n+ exist in the document. Conformance checkers may report more than one parse error condition if more\n+ than one parse error condition exists in the document.</p>\n+\n+ <p class=\"note\">Parse errors are only errors with the <em>syntax</em> of HTML. In addition to\n+ checking for parse errors, conformance checkers will also verify that the document obeys all the\n+ other conformance requirements described in this specification.</p>\n+\n+ <p>Some parse errors have dedicated codes outlined in the table below that should be used by\n+ conformance checkers in reports.</p>\n+\n+ <p><i>Error descriptions in the table below are non-normative.</i></p>\n+\n+ <table class=\"parse-error-table\">\n+ <thead>\n+ <tr>\n+ <th>Code\n+ <th>Description\n+ <tbody>\n+ <tr>\n+ <td>\n+ <dfn data-x=\"parse-error-abrupt-closing-of-comment\">abrupt-closing-of-comment</dfn>","path":"source","position":69,"original_position":69,"commit_id":"af5dbea896f59d9ba4e008b9cba35244025dc7a3","original_commit_id":"af5dbea896f59d9ba4e008b9cba35244025dc7a3","user":{"login":"zcorpan","id":244772,"avatar_url":"https://avatars1.githubusercontent.com/u/244772?v=3","gravatar_id":"","url":"https://api.github.com/users/zcorpan","html_url":"https://github.com/zcorpan","followers_url":"https://api.github.com/users/zcorpan/followers","following_url":"https://api.github.com/users/zcorpan/following{/other_user}","gists_url":"https://api.github.com/users/zcorpan/gists{/gist_id}","starred_url":"https://api.github.com/users/zcorpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcorpan/subscriptions","organizations_url":"https://api.github.com/users/zcorpan/orgs","repos_url":"https://api.github.com/users/zcorpan/repos","events_url":"https://api.github.com/users/zcorpan/events{/privacy}","received_events_url":"https://api.github.com/users/zcorpan/received_events","type":"User","site_admin":false},"body":"It ends up as a comment node in the DOM, but yeah. The biology meaning of rudimentary could work, but it's not immediately obvious what it's referring to. Maybe clearer with `empty-comment-overlapping-dashes`?","created_at":"2017-05-29T08:47:35Z","updated_at":"2017-05-29T08:47:35Z","html_url":"https://github.com/whatwg/html/pull/2701#discussion_r118892655","pull_request_url":"https://api.github.com/repos/whatwg/html/pulls/2701","_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments/118892655"},"html":{"href":"https://github.com/whatwg/html/pull/2701#discussion_r118892655"},"pull_request":{"href":"https://api.github.com/repos/whatwg/html/pulls/2701"}}},"pull_request":{"url":"https://api.github.com/repos/whatwg/html/pulls/2701","id":121676038,"html_url":"https://github.com/whatwg/html/pull/2701","diff_url":"https://github.com/whatwg/html/pull/2701.diff","patch_url":"https://github.com/whatwg/html/pull/2701.patch","issue_url":"https://api.github.com/repos/whatwg/html/issues/2701","number":2701,"state":"open","locked":false,"title":"Assign unique IDs to tokenization errors (#1339 part1)","user":{"login":"inikulin","id":453071,"avatar_url":"https://avatars2.githubusercontent.com/u/453071?v=3","gravatar_id":"","url":"https://api.github.com/users/inikulin","html_url":"https://github.com/inikulin","followers_url":"https://api.github.com/users/inikulin/followers","following_url":"https://api.github.com/users/inikulin/following{/other_user}","gists_url":"https://api.github.com/users/inikulin/gists{/gist_id}","starred_url":"https://api.github.com/users/inikulin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikulin/subscriptions","organizations_url":"https://api.github.com/users/inikulin/orgs","repos_url":"https://api.github.com/users/inikulin/repos","events_url":"https://api.github.com/users/inikulin/events{/privacy}","received_events_url":"https://api.github.com/users/inikulin/received_events","type":"User","site_admin":false},"body":"PR for tests: https://github.com/html5lib/html5lib-tests/pull/92\r\nReference implementation: https://github.com/HTMLParseErrorWG/parse5\r\nPreview: https://htmlparseerrorwg.github.io/html-build/output/multipage/syntax.html","created_at":"2017-05-21T21:05:42Z","updated_at":"2017-05-29T08:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fcd29a69cfa6c911accd6c86474db9f217702e09","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/whatwg/html/pulls/2701/commits","review_comments_url":"https://api.github.com/repos/whatwg/html/pulls/2701/comments","review_comment_url":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whatwg/html/issues/2701/comments","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/af5dbea896f59d9ba4e008b9cba35244025dc7a3","head":{"label":"HTMLParseErrorWG:to-upstream","ref":"to-upstream","sha":"af5dbea896f59d9ba4e008b9cba35244025dc7a3","user":{"login":"HTMLParseErrorWG","id":26457106,"avatar_url":"https://avatars3.githubusercontent.com/u/26457106?v=3","gravatar_id":"","url":"https://api.github.com/users/HTMLParseErrorWG","html_url":"https://github.com/HTMLParseErrorWG","followers_url":"https://api.github.com/users/HTMLParseErrorWG/followers","following_url":"https://api.github.com/users/HTMLParseErrorWG/following{/other_user}","gists_url":"https://api.github.com/users/HTMLParseErrorWG/gists{/gist_id}","starred_url":"https://api.github.com/users/HTMLParseErrorWG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTMLParseErrorWG/subscriptions","organizations_url":"https://api.github.com/users/HTMLParseErrorWG/orgs","repos_url":"https://api.github.com/users/HTMLParseErrorWG/repos","events_url":"https://api.github.com/users/HTMLParseErrorWG/events{/privacy}","received_events_url":"https://api.github.com/users/HTMLParseErrorWG/received_events","type":"Organization","site_admin":false},"repo":{"id":85179197,"name":"html","full_name":"HTMLParseErrorWG/html","owner":{"login":"HTMLParseErrorWG","id":26457106,"avatar_url":"https://avatars3.githubusercontent.com/u/26457106?v=3","gravatar_id":"","url":"https://api.github.com/users/HTMLParseErrorWG","html_url":"https://github.com/HTMLParseErrorWG","followers_url":"https://api.github.com/users/HTMLParseErrorWG/followers","following_url":"https://api.github.com/users/HTMLParseErrorWG/following{/other_user}","gists_url":"https://api.github.com/users/HTMLParseErrorWG/gists{/gist_id}","starred_url":"https://api.github.com/users/HTMLParseErrorWG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTMLParseErrorWG/subscriptions","organizations_url":"https://api.github.com/users/HTMLParseErrorWG/orgs","repos_url":"https://api.github.com/users/HTMLParseErrorWG/repos","events_url":"https://api.github.com/users/HTMLParseErrorWG/events{/privacy}","received_events_url":"https://api.github.com/users/HTMLParseErrorWG/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HTMLParseErrorWG/html","description":"HTML Standard","fork":true,"url":"https://api.github.com/repos/HTMLParseErrorWG/html","forks_url":"https://api.github.com/repos/HTMLParseErrorWG/html/forks","keys_url":"https://api.github.com/repos/HTMLParseErrorWG/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HTMLParseErrorWG/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HTMLParseErrorWG/html/teams","hooks_url":"https://api.github.com/repos/HTMLParseErrorWG/html/hooks","issue_events_url":"https://api.github.com/repos/HTMLParseErrorWG/html/issues/events{/number}","events_url":"https://api.github.com/repos/HTMLParseErrorWG/html/events","assignees_url":"https://api.github.com/repos/HTMLParseErrorWG/html/assignees{/user}","branches_url":"https://api.github.com/repos/HTMLParseErrorWG/html/branches{/branch}","tags_url":"https://api.github.com/repos/HTMLParseErrorWG/html/tags","blobs_url":"https://api.github.com/repos/HTMLParseErrorWG/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HTMLParseErrorWG/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HTMLParseErrorWG/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/HTMLParseErrorWG/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HTMLParseErrorWG/html/statuses/{sha}","languages_url":"https://api.github.com/repos/HTMLParseErrorWG/html/languages","stargazers_url":"https://api.github.com/repos/HTMLParseErrorWG/html/stargazers","contributors_url":"https://api.github.com/repos/HTMLParseErrorWG/html/contributors","subscribers_url":"https://api.github.com/repos/HTMLParseErrorWG/html/subscribers","subscription_url":"https://api.github.com/repos/HTMLParseErrorWG/html/subscription","commits_url":"https://api.github.com/repos/HTMLParseErrorWG/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/HTMLParseErrorWG/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/HTMLParseErrorWG/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/HTMLParseErrorWG/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/HTMLParseErrorWG/html/contents/{+path}","compare_url":"https://api.github.com/repos/HTMLParseErrorWG/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HTMLParseErrorWG/html/merges","archive_url":"https://api.github.com/repos/HTMLParseErrorWG/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HTMLParseErrorWG/html/downloads","issues_url":"https://api.github.com/repos/HTMLParseErrorWG/html/issues{/number}","pulls_url":"https://api.github.com/repos/HTMLParseErrorWG/html/pulls{/number}","milestones_url":"https://api.github.com/repos/HTMLParseErrorWG/html/milestones{/number}","notifications_url":"https://api.github.com/repos/HTMLParseErrorWG/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HTMLParseErrorWG/html/labels{/name}","releases_url":"https://api.github.com/repos/HTMLParseErrorWG/html/releases{/id}","deployments_url":"https://api.github.com/repos/HTMLParseErrorWG/html/deployments","created_at":"2017-03-16T09:45:25Z","updated_at":"2017-03-16T09:45:27Z","pushed_at":"2017-05-25T21:35:12Z","git_url":"git://github.com/HTMLParseErrorWG/html.git","ssh_url":"git@github.com:HTMLParseErrorWG/html.git","clone_url":"https://github.com/HTMLParseErrorWG/html.git","svn_url":"https://github.com/HTMLParseErrorWG/html","homepage":"https://html.spec.whatwg.org/multipage/","size":203872,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"whatwg:master","ref":"master","sha":"eddf2498d5e589baed007a9a5250a0a83a41c426","user":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"repo":{"id":11969507,"name":"html","full_name":"whatwg/html","owner":{"login":"whatwg","id":2226336,"avatar_url":"https://avatars2.githubusercontent.com/u/2226336?v=3","gravatar_id":"","url":"https://api.github.com/users/whatwg","html_url":"https://github.com/whatwg","followers_url":"https://api.github.com/users/whatwg/followers","following_url":"https://api.github.com/users/whatwg/following{/other_user}","gists_url":"https://api.github.com/users/whatwg/gists{/gist_id}","starred_url":"https://api.github.com/users/whatwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whatwg/subscriptions","organizations_url":"https://api.github.com/users/whatwg/orgs","repos_url":"https://api.github.com/users/whatwg/repos","events_url":"https://api.github.com/users/whatwg/events{/privacy}","received_events_url":"https://api.github.com/users/whatwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/whatwg/html","description":"HTML Standard","fork":false,"url":"https://api.github.com/repos/whatwg/html","forks_url":"https://api.github.com/repos/whatwg/html/forks","keys_url":"https://api.github.com/repos/whatwg/html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whatwg/html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whatwg/html/teams","hooks_url":"https://api.github.com/repos/whatwg/html/hooks","issue_events_url":"https://api.github.com/repos/whatwg/html/issues/events{/number}","events_url":"https://api.github.com/repos/whatwg/html/events","assignees_url":"https://api.github.com/repos/whatwg/html/assignees{/user}","branches_url":"https://api.github.com/repos/whatwg/html/branches{/branch}","tags_url":"https://api.github.com/repos/whatwg/html/tags","blobs_url":"https://api.github.com/repos/whatwg/html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whatwg/html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whatwg/html/git/refs{/sha}","trees_url":"https://api.github.com/repos/whatwg/html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whatwg/html/statuses/{sha}","languages_url":"https://api.github.com/repos/whatwg/html/languages","stargazers_url":"https://api.github.com/repos/whatwg/html/stargazers","contributors_url":"https://api.github.com/repos/whatwg/html/contributors","subscribers_url":"https://api.github.com/repos/whatwg/html/subscribers","subscription_url":"https://api.github.com/repos/whatwg/html/subscription","commits_url":"https://api.github.com/repos/whatwg/html/commits{/sha}","git_commits_url":"https://api.github.com/repos/whatwg/html/git/commits{/sha}","comments_url":"https://api.github.com/repos/whatwg/html/comments{/number}","issue_comment_url":"https://api.github.com/repos/whatwg/html/issues/comments{/number}","contents_url":"https://api.github.com/repos/whatwg/html/contents/{+path}","compare_url":"https://api.github.com/repos/whatwg/html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whatwg/html/merges","archive_url":"https://api.github.com/repos/whatwg/html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whatwg/html/downloads","issues_url":"https://api.github.com/repos/whatwg/html/issues{/number}","pulls_url":"https://api.github.com/repos/whatwg/html/pulls{/number}","milestones_url":"https://api.github.com/repos/whatwg/html/milestones{/number}","notifications_url":"https://api.github.com/repos/whatwg/html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whatwg/html/labels{/name}","releases_url":"https://api.github.com/repos/whatwg/html/releases{/id}","deployments_url":"https://api.github.com/repos/whatwg/html/deployments","created_at":"2013-08-08T06:26:07Z","updated_at":"2017-05-29T00:10:05Z","pushed_at":"2017-05-26T05:27:03Z","git_url":"git://github.com/whatwg/html.git","ssh_url":"git@github.com:whatwg/html.git","clone_url":"https://github.com/whatwg/html.git","svn_url":"https://github.com/whatwg/html","homepage":"https://html.spec.whatwg.org/multipage/","size":203164,"stargazers_count":1178,"watchers_count":1178,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":380,"mirror_url":null,"open_issues_count":563,"forks":380,"open_issues":563,"watchers":1178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whatwg/html/pulls/2701"},"html":{"href":"https://github.com/whatwg/html/pull/2701"},"issue":{"href":"https://api.github.com/repos/whatwg/html/issues/2701"},"comments":{"href":"https://api.github.com/repos/whatwg/html/issues/2701/comments"},"review_comments":{"href":"https://api.github.com/repos/whatwg/html/pulls/2701/comments"},"review_comment":{"href":"https://api.github.com/repos/whatwg/html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whatwg/html/pulls/2701/commits"},"statuses":{"href":"https://api.github.com/repos/whatwg/html/statuses/af5dbea896f59d9ba4e008b9cba35244025dc7a3"}}}}
|
{
"id": 11969507,
"name": "whatwg/html",
"url": "https://api.github.com/repos/whatwg/html"
}
|
{
"id": 244772,
"login": "zcorpan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/244772?",
"url": "https://api.github.com/users/zcorpan"
}
|
{
"id": 2226336,
"login": "whatwg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2226336?",
"url": "https://api.github.com/orgs/whatwg"
}
| 2017-05-29T08:47:35 |
5958706652
|
{"actor":{"display_login":"zcorpan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/comments/151648743","pull_request_review_id":77383167,"id":151648743,"diff_hunk":"@@ -495,15 +559,13 @@ const renderIndex = (legacyApp) => {\n AFTER_RESPONSES: getAfterResponses(legacyApp),\n };\n \n- return renderAuth(legacyApp)\n- .then((auth) => {\n- templateContext.AUTHENTICATION = auth;\n- return getHeader(legacyApp);\n- })\n+ return getHeader(legacyApp)\n .then((header) => {\n templateContext.HEADER = header;\n \n- const importLines = [];\n+ const importLines = [\n+ \"const authentication = require('./authentication');\"","path":"src/utils/convert.js","position":207,"original_position":207,"commit_id":"33ac7cefee85422aa702b58f341873eacaf040f0","original_commit_id":"33ac7cefee85422aa702b58f341873eacaf040f0","user":{"login":"BrunoBernardino","id":1239616,"avatar_url":"https://avatars3.githubusercontent.com/u/1239616?v=4","gravatar_id":"","url":"https://api.github.com/users/BrunoBernardino","html_url":"https://github.com/BrunoBernardino","followers_url":"https://api.github.com/users/BrunoBernardino/followers","following_url":"https://api.github.com/users/BrunoBernardino/following{/other_user}","gists_url":"https://api.github.com/users/BrunoBernardino/gists{/gist_id}","starred_url":"https://api.github.com/users/BrunoBernardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrunoBernardino/subscriptions","organizations_url":"https://api.github.com/users/BrunoBernardino/orgs","repos_url":"https://api.github.com/users/BrunoBernardino/repos","events_url":"https://api.github.com/users/BrunoBernardino/events{/privacy}","received_events_url":"https://api.github.com/users/BrunoBernardino/received_events","type":"User","site_admin":false},"body":"Like I mentioned above, we should only do this if the app has auth.","created_at":"2017-11-17T10:18:46Z","updated_at":"2017-11-17T10:28:02Z","html_url":"https://github.com/zapier/zapier-platform-cli/pull/185#discussion_r151648743","pull_request_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/comments/151648743"},"html":{"href":"https://github.com/zapier/zapier-platform-cli/pull/185#discussion_r151648743"},"pull_request":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185"}}},"pull_request":{"url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185","id":152778427,"html_url":"https://github.com/zapier/zapier-platform-cli/pull/185","diff_url":"https://github.com/zapier/zapier-platform-cli/pull/185.diff","patch_url":"https://github.com/zapier/zapier-platform-cli/pull/185.patch","issue_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/185","number":185,"state":"open","locked":false,"title":"zapier convert: Generate different auth code based on scripting","user":{"login":"eliangcs","id":740461,"avatar_url":"https://avatars0.githubusercontent.com/u/740461?v=4","gravatar_id":"","url":"https://api.github.com/users/eliangcs","html_url":"https://github.com/eliangcs","followers_url":"https://api.github.com/users/eliangcs/followers","following_url":"https://api.github.com/users/eliangcs/following{/other_user}","gists_url":"https://api.github.com/users/eliangcs/gists{/gist_id}","starred_url":"https://api.github.com/users/eliangcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliangcs/subscriptions","organizations_url":"https://api.github.com/users/eliangcs/orgs","repos_url":"https://api.github.com/users/eliangcs/repos","events_url":"https://api.github.com/users/eliangcs/events{/privacy}","received_events_url":"https://api.github.com/users/eliangcs/received_events","type":"User","site_admin":false},"body":"Summary:\r\n\r\n* Move authentication code from `index.js` to its own separate file `authentication.js`\r\n* Generate different auth code based on scripting, including:\r\n - OAuth: generate a `getAccessToken()` if `pre_oauthv2_token` or `post_oauthv2_token` method exists\r\n - OAuth: generate a `refreshAccessToken()` if `pre_oauthv2_refresh` method exists\r\n - Session: generate a `getSessionKey()` that invokes `get_session_info` method\r\n - Generate a `getConnectionLabel()` if `get_connection_label` method exists\r\n\r\nSee more detail in the following comments.","created_at":"2017-11-15T13:47:09Z","updated_at":"2017-11-17T10:28:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49d75ec213cad1bd1ac627b0ba6b5e3238567776","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185/commits","review_comments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185/comments","review_comment_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/185/comments","statuses_url":"https://api.github.com/repos/zapier/zapier-platform-cli/statuses/33ac7cefee85422aa702b58f341873eacaf040f0","head":{"label":"zapier:convert-auth-scripting","ref":"convert-auth-scripting","sha":"33ac7cefee85422aa702b58f341873eacaf040f0","user":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"repo":{"id":72045868,"name":"zapier-platform-cli","full_name":"zapier/zapier-platform-cli","owner":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zapier/zapier-platform-cli","description":"Build Zapier integrations and test locally using the JavaScript tools you already know.","fork":false,"url":"https://api.github.com/repos/zapier/zapier-platform-cli","forks_url":"https://api.github.com/repos/zapier/zapier-platform-cli/forks","keys_url":"https://api.github.com/repos/zapier/zapier-platform-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zapier/zapier-platform-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zapier/zapier-platform-cli/teams","hooks_url":"https://api.github.com/repos/zapier/zapier-platform-cli/hooks","issue_events_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/events{/number}","events_url":"https://api.github.com/repos/zapier/zapier-platform-cli/events","assignees_url":"https://api.github.com/repos/zapier/zapier-platform-cli/assignees{/user}","branches_url":"https://api.github.com/repos/zapier/zapier-platform-cli/branches{/branch}","tags_url":"https://api.github.com/repos/zapier/zapier-platform-cli/tags","blobs_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zapier/zapier-platform-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/zapier/zapier-platform-cli/languages","stargazers_url":"https://api.github.com/repos/zapier/zapier-platform-cli/stargazers","contributors_url":"https://api.github.com/repos/zapier/zapier-platform-cli/contributors","subscribers_url":"https://api.github.com/repos/zapier/zapier-platform-cli/subscribers","subscription_url":"https://api.github.com/repos/zapier/zapier-platform-cli/subscription","commits_url":"https://api.github.com/repos/zapier/zapier-platform-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/zapier/zapier-platform-cli/contents/{+path}","compare_url":"https://api.github.com/repos/zapier/zapier-platform-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zapier/zapier-platform-cli/merges","archive_url":"https://api.github.com/repos/zapier/zapier-platform-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zapier/zapier-platform-cli/downloads","issues_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues{/number}","pulls_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/zapier/zapier-platform-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/zapier/zapier-platform-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zapier/zapier-platform-cli/labels{/name}","releases_url":"https://api.github.com/repos/zapier/zapier-platform-cli/releases{/id}","deployments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/deployments","created_at":"2016-10-26T21:27:01Z","updated_at":"2017-11-16T18:42:20Z","pushed_at":"2017-11-17T09:42:00Z","git_url":"git://github.com/zapier/zapier-platform-cli.git","ssh_url":"git@github.com:zapier/zapier-platform-cli.git","clone_url":"https://github.com/zapier/zapier-platform-cli.git","svn_url":"https://github.com/zapier/zapier-platform-cli","homepage":"https://zapier.github.io/zapier-platform-cli/","size":1603,"stargazers_count":107,"watchers_count":107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":29,"open_issues":44,"watchers":107,"default_branch":"master"}},"base":{"label":"zapier:master","ref":"master","sha":"17d081232186eae60548289f699c507bac43a71a","user":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"repo":{"id":72045868,"name":"zapier-platform-cli","full_name":"zapier/zapier-platform-cli","owner":{"login":"zapier","id":1261889,"avatar_url":"https://avatars1.githubusercontent.com/u/1261889?v=4","gravatar_id":"","url":"https://api.github.com/users/zapier","html_url":"https://github.com/zapier","followers_url":"https://api.github.com/users/zapier/followers","following_url":"https://api.github.com/users/zapier/following{/other_user}","gists_url":"https://api.github.com/users/zapier/gists{/gist_id}","starred_url":"https://api.github.com/users/zapier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapier/subscriptions","organizations_url":"https://api.github.com/users/zapier/orgs","repos_url":"https://api.github.com/users/zapier/repos","events_url":"https://api.github.com/users/zapier/events{/privacy}","received_events_url":"https://api.github.com/users/zapier/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zapier/zapier-platform-cli","description":"Build Zapier integrations and test locally using the JavaScript tools you already know.","fork":false,"url":"https://api.github.com/repos/zapier/zapier-platform-cli","forks_url":"https://api.github.com/repos/zapier/zapier-platform-cli/forks","keys_url":"https://api.github.com/repos/zapier/zapier-platform-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zapier/zapier-platform-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zapier/zapier-platform-cli/teams","hooks_url":"https://api.github.com/repos/zapier/zapier-platform-cli/hooks","issue_events_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/events{/number}","events_url":"https://api.github.com/repos/zapier/zapier-platform-cli/events","assignees_url":"https://api.github.com/repos/zapier/zapier-platform-cli/assignees{/user}","branches_url":"https://api.github.com/repos/zapier/zapier-platform-cli/branches{/branch}","tags_url":"https://api.github.com/repos/zapier/zapier-platform-cli/tags","blobs_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zapier/zapier-platform-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/zapier/zapier-platform-cli/languages","stargazers_url":"https://api.github.com/repos/zapier/zapier-platform-cli/stargazers","contributors_url":"https://api.github.com/repos/zapier/zapier-platform-cli/contributors","subscribers_url":"https://api.github.com/repos/zapier/zapier-platform-cli/subscribers","subscription_url":"https://api.github.com/repos/zapier/zapier-platform-cli/subscription","commits_url":"https://api.github.com/repos/zapier/zapier-platform-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/zapier/zapier-platform-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/zapier/zapier-platform-cli/contents/{+path}","compare_url":"https://api.github.com/repos/zapier/zapier-platform-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zapier/zapier-platform-cli/merges","archive_url":"https://api.github.com/repos/zapier/zapier-platform-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zapier/zapier-platform-cli/downloads","issues_url":"https://api.github.com/repos/zapier/zapier-platform-cli/issues{/number}","pulls_url":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/zapier/zapier-platform-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/zapier/zapier-platform-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zapier/zapier-platform-cli/labels{/name}","releases_url":"https://api.github.com/repos/zapier/zapier-platform-cli/releases{/id}","deployments_url":"https://api.github.com/repos/zapier/zapier-platform-cli/deployments","created_at":"2016-10-26T21:27:01Z","updated_at":"2017-11-16T18:42:20Z","pushed_at":"2017-11-17T09:42:00Z","git_url":"git://github.com/zapier/zapier-platform-cli.git","ssh_url":"git@github.com:zapier/zapier-platform-cli.git","clone_url":"https://github.com/zapier/zapier-platform-cli.git","svn_url":"https://github.com/zapier/zapier-platform-cli","homepage":"https://zapier.github.io/zapier-platform-cli/","size":1603,"stargazers_count":107,"watchers_count":107,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":29,"open_issues":44,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185"},"html":{"href":"https://github.com/zapier/zapier-platform-cli/pull/185"},"issue":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/185"},"comments":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/zapier/zapier-platform-cli/statuses/33ac7cefee85422aa702b58f341873eacaf040f0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 72045868,
"name": "zapier/zapier-platform-cli",
"url": "https://api.github.com/repos/zapier/zapier-platform-cli"
}
|
{
"id": 1239616,
"login": "BrunoBernardino",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1239616?",
"url": "https://api.github.com/users/BrunoBernardino"
}
|
{
"id": 1261889,
"login": "zapier",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1261889?",
"url": "https://api.github.com/orgs/zapier"
}
| 2017-11-17T10:18:46 |
6869232551
|
{"actor":{"display_login":"BrunoBernardino"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/150388025","pull_request_review_id":75936510,"id":150388025,"diff_hunk":"@@ -0,0 +1,392 @@\n+/*\n+ * Silicon Labs CRYPTO device management interface.\n+ *\n+ * Copyright (C) 2016, Silicon Labs, http://www.silabs.com\n+ * SPDX-License-Identifier: Apache-2.0\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+#include \"crypto_management.h\"\n+#include \"em_core.h\"\n+#include \"em_bus.h\"\n+\n+#if defined( CRYPTO_PRESENT )\n+#if defined( MBEDTLS_THREADING_C )\n+#include \"mbedtls/threading.h\"\n+static mbedtls_threading_mutex_t crypto_locks[CRYPTO_COUNT];\n+static volatile bool crypto_locks_initialized = false;\n+static unsigned int acquire_count = 0U;\n+#endif /* MBEDTLS_THREADING_C */\n+\n+#if defined( MBEDTLS_CRYPTO_DEVICE_PREEMPTION )\n+/** Preemptable context of CRYPTO hardware module. */\n+typedef struct\n+{\n+ uint32_t CTRL; /*!< Control Register */\n+ uint32_t WAC; /*!< Wide Arithmetic Configuration */\n+ uint32_t SEQCTRL; /*!< Sequence Control */\n+ uint32_t SEQCTRLB; /*!< Sequence Control B */\n+ uint32_t IEN; /*!< Interrupt Enable Register */\n+ uint32_t SEQ[5]; /*!< Instruction Sequence registers */\n+ CRYPTO_Data260_TypeDef DDATA[5]; /*!< DDATA registers. Covers all data\n+ registers\n+ of CRYPTO, including DATA(128 bit),\n+ DDATA (256bit/260bit),\n+ QDATA (512bit) registers. */\n+ uint32_t regmask; /*!< Bitmask for which registers to save */\n+ uint32_t operands; /*!< Saving the currently selected operands */\n+ bool carry; /*!< Saving the status of the carry flag */\n+} crypto_context_t;\n+\n+static crypto_context_t preemption_context;\n+static bool is_preempted = false;\n+static CORE_DECLARE_IRQ_STATE;\n+#endif /* MBEDTLS_CRYPTO_DEVICE_PREEMPTION */\n+\n+typedef enum\n+{\n+#if defined( CRYPTO0 )\n+ CRYPTO0_ID = 0,\n+#elif defined( CRYPTO )\n+ CRYPTO_ID = 0,\n+#endif\n+#if defined( CRYPTO1 )\n+ CRYPTO1_ID = 1,\n+#endif\n+} crypto_instance_number_t;\n+\n+typedef struct {\n+ CRYPTO_TypeDef *device;\n+ uint32_t clockMask;\n+} crypto_device_t;\n+\n+static const crypto_device_t crypto_devices[CRYPTO_COUNT] =\n+{\n+#if defined( CRYPTO0 )\n+ {\n+ CRYPTO0,\n+ _CMU_HFBUSCLKEN0_CRYPTO0_SHIFT\n+ },\n+#elif defined( CRYPTO )\n+ {\n+ CRYPTO,\n+ _CMU_HFBUSCLKEN0_CRYPTO_SHIFT\n+ },\n+#endif\n+#if defined( CRYPTO1 )\n+ {\n+ CRYPTO1,\n+ _CMU_HFBUSCLKEN0_CRYPTO1_SHIFT\n+ },\n+#endif\n+};\n+\n+static inline int crypto_management_index_by_device( CRYPTO_TypeDef *device )\n+{\n+#if defined( CRYPTO0 )\n+ if ( device == CRYPTO0 ) return 0;\n+#elif defined( CRYPTO )\n+ if ( device == CRYPTO ) return 0;\n+#endif\n+#if defined( CRYPTO1 )\n+ if ( device == CRYPTO1 ) return 1;\n+#endif\n+ return -1;\n+}\n+\n+/* Use bitband for clock enable/disable operations, such that they are atomic */\n+#define CRYPTO_CLOCK_ENABLE(clk) BUS_RegBitWrite(&(CMU->HFBUSCLKEN0), clk, 1)\n+#define CRYPTO_CLOCK_DISABLE(clk) BUS_RegBitWrite(&(CMU->HFBUSCLKEN0), clk, 0)\n+#define CRYPTO_CLOCK_ENABLED(clk) BUS_RegBitRead(&(CMU->HFBUSCLKEN0), clk)","path":"features/mbedtls/targets/TARGET_Silicon_Labs/crypto_management.c","position":111,"original_position":111,"commit_id":"2f02a23ac045d2eadc0495e90424ce97288b7bcb","original_commit_id":"2f02a23ac045d2eadc0495e90424ce97288b7bcb","user":{"login":"stevew817","id":4510034,"avatar_url":"https://avatars0.githubusercontent.com/u/4510034?v=4","gravatar_id":"","url":"https://api.github.com/users/stevew817","html_url":"https://github.com/stevew817","followers_url":"https://api.github.com/users/stevew817/followers","following_url":"https://api.github.com/users/stevew817/following{/other_user}","gists_url":"https://api.github.com/users/stevew817/gists{/gist_id}","starred_url":"https://api.github.com/users/stevew817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevew817/subscriptions","organizations_url":"https://api.github.com/users/stevew817/orgs","repos_url":"https://api.github.com/users/stevew817/repos","events_url":"https://api.github.com/users/stevew817/events{/privacy}","received_events_url":"https://api.github.com/users/stevew817/received_events","type":"User","site_admin":false},"body":"okay","created_at":"2017-11-11T16:59:47Z","updated_at":"2017-11-11T16:59:47Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/4825#discussion_r150388025","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/150388025"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/4825#discussion_r150388025"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825"}},"in_reply_to_id":150216160},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825","id":133016587,"html_url":"https://github.com/ARMmbed/mbed-os/pull/4825","diff_url":"https://github.com/ARMmbed/mbed-os/pull/4825.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/4825.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4825","number":4825,"state":"open","locked":false,"title":"Silicon Labs: Add cryptographic acceleration support","user":{"login":"stevew817","id":4510034,"avatar_url":"https://avatars0.githubusercontent.com/u/4510034?v=4","gravatar_id":"","url":"https://api.github.com/users/stevew817","html_url":"https://github.com/stevew817","followers_url":"https://api.github.com/users/stevew817/followers","following_url":"https://api.github.com/users/stevew817/following{/other_user}","gists_url":"https://api.github.com/users/stevew817/gists{/gist_id}","starred_url":"https://api.github.com/users/stevew817/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevew817/subscriptions","organizations_url":"https://api.github.com/users/stevew817/orgs","repos_url":"https://api.github.com/users/stevew817/repos","events_url":"https://api.github.com/users/stevew817/events{/privacy}","received_events_url":"https://api.github.com/users/stevew817/received_events","type":"User","site_admin":false},"body":"Initial commit of mbed TLS hardware acceleration drivers for Silicon Labs parts\r\n\r\n## Description\r\nThis commit adds HW acceleration drivers for mbed TLS on Silicon Labs parts.\r\n\r\nHardware support:\r\nEFM32ZG/HG/WG/GG/LG: \r\n* support for AES-128 and AES-256\r\n\r\nEFR32MG1/EFM32PG1:\r\n* support for AES-128 and AES-256\r\n* support for ECP acceleration on secp192r1, secp224r1 and secp256r1\r\n* support for SHA1 and SHA-256\r\n\r\nEFR32MG12/EFM32PG12:\r\n* two accelerator units available when in threaded mode\r\n* support for hardware TRNG\r\n* support for AES-128 and AES-256\r\n* support for ECP acceleration on secp192r1, secp224r1 and secp256r1\r\n* support for SHA1 and SHA-256\r\n\r\n## Status\r\n**READY**\r\n\r\n* Tested with TESTS/mbedtls/* on mbed-os master\r\n\r\n```mbedgt: test case report:\r\n+---------------------------+-------------------+------------------------+---------------------------+--------+--------+--------+--------------------+\r\n| target | platform_name | test suite | test case | passed | failed | result | elapsed_time (sec) |\r\n+---------------------------+-------------------+------------------------+---------------------------+--------+--------+--------+--------------------+\r\n| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | tests-mbedtls-multi | Crypto: sha256_multi | 1 | 0 | OK | 0.08 |\r\n| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | tests-mbedtls-multi | Crypto: sha256_split | 1 | 0 | OK | 0.04 |\r\n| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | tests-mbedtls-selftest | mbedtls_entropy_self_test | 1 | 0 | OK | 0.04 |\r\n| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | tests-mbedtls-selftest | mbedtls_sha256_self_test | 1 | 0 | OK | 0.12 |\r\n| EFM32PG12_STK3402-GCC_ARM | EFM32PG12_STK3402 | tests-mbedtls-selftest | mbedtls_sha512_self_test | 1 | 0 | OK | 8.27 |\r\n+---------------------------+-------------------+------------------------+---------------------------+--------+--------+--------+--------------------+\r\nmbedgt: test case results: 5 OK\r\n```\r\n* Underlying drivers have been tested on the full mbed TLS test suite\r\n* Effect of hardware acceleration with mbed-os-example-tls / benchmark on EFM32PG12, single threaded.\r\n```\r\n SHA-256 : 12871 KB/s\r\n SHA-512 : 209 KB/s\r\n AES-CBC-128 : 4254 KB/s\r\n AES-CBC-192 : 560329 KB/s\r\n AES-CBC-256 : 3740 KB/s\r\n AES-GCM-128 : 210 KB/s\r\n AES-GCM-192 : 100927 KB/s\r\n AES-GCM-256 : 208 KB/s\r\n AES-CCM-128 : 459 KB/s\r\n AES-CCM-192 : 69031 KB/s\r\n AES-CCM-256 : 440 KB/s\r\n CTR_DRBG (NOPR) : 1497 KB/s\r\n CTR_DRBG (PR) : 1008 KB/s\r\n HMAC_DRBG SHA-256 (NOPR) : 452 KB/s\r\n HMAC_DRBG SHA-256 (PR) : 387 KB/s\r\n RSA-2048 : 85 ms/ public\r\n RSA-2048 : 3253 ms/private\r\n RSA-4096 : 287 ms/ public\r\n RSA-4096 : 17465 ms/private\r\n ECDHE-secp384r1 : 2683 ms/handshake\r\n ECDHE-secp256r1 : 94 ms/handshake\r\n ECDHE-Curve25519 : 1433 ms/handshake\r\n ECDH-secp384r1 : 1320 ms/handshake\r\n ECDH-secp256r1 : 45 ms/handshake\r\n ECDH-Curve25519 : 741 ms/handshake\r\n\r\nDONE\r\n```\r\n\r\n## Todos\r\n- [X] Tests\r\n- [X] Documentation\r\n\r\n## Deploy notes\r\nNone\r\n","created_at":"2017-07-28T17:31:40Z","updated_at":"2017-11-11T16:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300090112146037c732dcab9bb067f731476e8ca","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4825/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/2f02a23ac045d2eadc0495e90424ce97288b7bcb","head":{"label":"SiliconLabs:feature/mbedtls-hw-accel","ref":"feature/mbedtls-hw-accel","sha":"2f02a23ac045d2eadc0495e90424ce97288b7bcb","user":{"login":"SiliconLabs","id":7750191,"avatar_url":"https://avatars2.githubusercontent.com/u/7750191?v=4","gravatar_id":"","url":"https://api.github.com/users/SiliconLabs","html_url":"https://github.com/SiliconLabs","followers_url":"https://api.github.com/users/SiliconLabs/followers","following_url":"https://api.github.com/users/SiliconLabs/following{/other_user}","gists_url":"https://api.github.com/users/SiliconLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SiliconLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiliconLabs/subscriptions","organizations_url":"https://api.github.com/users/SiliconLabs/orgs","repos_url":"https://api.github.com/users/SiliconLabs/repos","events_url":"https://api.github.com/users/SiliconLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SiliconLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":71642078,"name":"mbed-os","full_name":"SiliconLabs/mbed-os","owner":{"login":"SiliconLabs","id":7750191,"avatar_url":"https://avatars2.githubusercontent.com/u/7750191?v=4","gravatar_id":"","url":"https://api.github.com/users/SiliconLabs","html_url":"https://github.com/SiliconLabs","followers_url":"https://api.github.com/users/SiliconLabs/followers","following_url":"https://api.github.com/users/SiliconLabs/following{/other_user}","gists_url":"https://api.github.com/users/SiliconLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/SiliconLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SiliconLabs/subscriptions","organizations_url":"https://api.github.com/users/SiliconLabs/orgs","repos_url":"https://api.github.com/users/SiliconLabs/repos","events_url":"https://api.github.com/users/SiliconLabs/events{/privacy}","received_events_url":"https://api.github.com/users/SiliconLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SiliconLabs/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/SiliconLabs/mbed-os","forks_url":"https://api.github.com/repos/SiliconLabs/mbed-os/forks","keys_url":"https://api.github.com/repos/SiliconLabs/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SiliconLabs/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SiliconLabs/mbed-os/teams","hooks_url":"https://api.github.com/repos/SiliconLabs/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/SiliconLabs/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/SiliconLabs/mbed-os/events","assignees_url":"https://api.github.com/repos/SiliconLabs/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/SiliconLabs/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/SiliconLabs/mbed-os/tags","blobs_url":"https://api.github.com/repos/SiliconLabs/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SiliconLabs/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SiliconLabs/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/SiliconLabs/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SiliconLabs/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/SiliconLabs/mbed-os/languages","stargazers_url":"https://api.github.com/repos/SiliconLabs/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/SiliconLabs/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/SiliconLabs/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/SiliconLabs/mbed-os/subscription","commits_url":"https://api.github.com/repos/SiliconLabs/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/SiliconLabs/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/SiliconLabs/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/SiliconLabs/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/SiliconLabs/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/SiliconLabs/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SiliconLabs/mbed-os/merges","archive_url":"https://api.github.com/repos/SiliconLabs/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SiliconLabs/mbed-os/downloads","issues_url":"https://api.github.com/repos/SiliconLabs/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/SiliconLabs/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/SiliconLabs/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/SiliconLabs/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SiliconLabs/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/SiliconLabs/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/SiliconLabs/mbed-os/deployments","created_at":"2016-10-22T13:51:20Z","updated_at":"2016-10-22T13:52:34Z","pushed_at":"2017-11-08T08:42:13Z","git_url":"git://github.com/SiliconLabs/mbed-os.git","ssh_url":"git@github.com:SiliconLabs/mbed-os.git","clone_url":"https://github.com/SiliconLabs/mbed-os.git","svn_url":"https://github.com/SiliconLabs/mbed-os","homepage":"https://mbed.com","size":174500,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"2305a8c7e4c2651dafdf5477f1b1d649bee35723","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2017-11-11T14:09:19Z","pushed_at":"2017-11-10T21:24:10Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":176752,"stargazers_count":1303,"watchers_count":1303,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1220,"mirror_url":null,"archived":false,"open_issues_count":358,"forks":1220,"open_issues":358,"watchers":1303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/4825"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4825"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4825/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4825/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/2f02a23ac045d2eadc0495e90424ce97288b7bcb"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 8270972,
"name": "ARMmbed/mbed-os",
"url": "https://api.github.com/repos/ARMmbed/mbed-os"
}
|
{
"id": 4510034,
"login": "stevew817",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4510034?",
"url": "https://api.github.com/users/stevew817"
}
|
{
"id": 8916057,
"login": "ARMmbed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8916057?",
"url": "https://api.github.com/orgs/ARMmbed"
}
| 2017-11-11T16:59:47 |
6841724584
|
{"actor":{"display_login":"stevew817"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/137943179","pull_request_review_id":61678621,"id":137943179,"diff_hunk":"@@ -311,6 +311,22 @@ int mbedtls_cipher_update( mbedtls_cipher_context_t *ctx, const unsigned char *i\n return MBEDTLS_ERR_CIPHER_INVALID_CONTEXT;\n }\n \n+#if defined(MBEDTLS_CIPHER_MODE_CTR)\n+ if( ctx->cipher_info->mode == MBEDTLS_MODE_CTR )\n+ {\n+ if( 0 != ( ret = ctx->cipher_info->base->ctr_func( ctx->cipher_ctx,\n+ ilen, &ctx->unprocessed_len, ctx->iv,\n+ ctx->unprocessed_data, input, output ) ) )\n+ {\n+ return( ret );\n+ }\n+\n+ *olen = ilen;\n+\n+ return( 0 );\n+ }\n+#endif /* MBEDTLS_CIPHER_MODE_CTR */\n+\n if( input == output &&","path":"library/cipher.c","position":20,"original_position":20,"commit_id":"b16709afc447c279f830f15043a99fd2831db228","original_commit_id":"b16709afc447c279f830f15043a99fd2831db228","user":{"login":"RonEld","id":22030476,"avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"why not add here a check that the mode is not CTR? It is much more cleaner to first do parameter checks, and then do the operations:\r\n~~~\r\n#if defined(MBEDTLS_CIPHER_MODE_CTR)\r\n( ctx->cipher_info->mode != MBEDTLS_MODE_CTR ) &&\r\n~~~\r\n","created_at":"2017-09-10T07:56:44Z","updated_at":"2017-09-10T07:56:44Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1084#discussion_r137943179","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/137943179"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1084#discussion_r137943179"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084","id":140174307,"html_url":"https://github.com/ARMmbed/mbedtls/pull/1084","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1084.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1084.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1084","number":1084,"state":"open","locked":false,"title":"cipher: allow inplace AES-CTR on buffers not multiple of block size","user":{"login":"ordex","id":3433035,"avatar_url":"https://avatars0.githubusercontent.com/u/3433035?v=4","gravatar_id":"","url":"https://api.github.com/users/ordex","html_url":"https://github.com/ordex","followers_url":"https://api.github.com/users/ordex/followers","following_url":"https://api.github.com/users/ordex/following{/other_user}","gists_url":"https://api.github.com/users/ordex/gists{/gist_id}","starred_url":"https://api.github.com/users/ordex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordex/subscriptions","organizations_url":"https://api.github.com/users/ordex/orgs","repos_url":"https://api.github.com/users/ordex/repos","events_url":"https://api.github.com/users/ordex/events{/privacy}","received_events_url":"https://api.github.com/users/ordex/received_events","type":"User","site_admin":false},"body":"AES-CTR should be allowed also when performed inplace and\r\non buffers of length not multiple of the AES block size.\r\n\r\nFor this reason, move the invocation of the CTR wrapper\r\nfunction above the block-size check.\r\n\r\nFixes: https://github.com/ARMmbed/mbedtls/issues/1076\r\nSigned-off-by: Antonio Quartulli <a@unstable.cc>\r\n\r\nNotes:\r\n* Pull requests cannot be accepted until:\r\n- The submitter has [accepted the online agreement here with a click through](https://developer.mbed.org/contributor_agreement/) - ACCEPTED\r\n or for companies or those that do not wish to create an mbed account, a slightly different agreement can be found [here](https://www.mbed.com/en/about-mbed/contributor-license-agreements/)\r\n- The PR follows the [mbed TLS coding standards](https://tls.mbed.org/kb/development/mbedtls-coding-standards)\r\n* This is just a template, so feel free to use/remove the unnecessary things\r\n## Description\r\nA few sentences describing the overall goals of the pull request's commits.\r\n\r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\nWhen there is a bug fix, it should be backported to all maintained and supported branches.\r\nChanges do not have to be backported if:\r\n- This PR is a new feature\\enhancement\r\n- This PR contains changes in the API. If this is true, and there is a need for the fix to be backported, the fix should be handled differently in the legacy branch\r\n\r\nYes\r\nWhich branch?\r\n\r\n## Migrations\r\nIf there is any API change, what's the incentive and logic for it.\r\n\r\nNO\r\n\r\n## Additional comments\r\nAny additional information that could be of interest\r\n\r\n## Todos\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Changelog updated\r\n- [ ] Backported\r\n\r\n\r\n## Steps to test or reproduce\r\nOutline the steps to test or reproduce the PR here.\r\n","created_at":"2017-09-09T15:47:29Z","updated_at":"2017-09-10T07:56:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"626fad507994d625a8ed92d8e8fb5e9e635c9d71","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andresag01","id":3746901,"avatar_url":"https://avatars3.githubusercontent.com/u/3746901?v=4","gravatar_id":"","url":"https://api.github.com/users/andresag01","html_url":"https://github.com/andresag01","followers_url":"https://api.github.com/users/andresag01/followers","following_url":"https://api.github.com/users/andresag01/following{/other_user}","gists_url":"https://api.github.com/users/andresag01/gists{/gist_id}","starred_url":"https://api.github.com/users/andresag01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresag01/subscriptions","organizations_url":"https://api.github.com/users/andresag01/orgs","repos_url":"https://api.github.com/users/andresag01/repos","events_url":"https://api.github.com/users/andresag01/events{/privacy}","received_events_url":"https://api.github.com/users/andresag01/received_events","type":"User","site_admin":false},{"login":"hanno-arm","id":26892988,"avatar_url":"https://avatars1.githubusercontent.com/u/26892988?v=4","gravatar_id":"","url":"https://api.github.com/users/hanno-arm","html_url":"https://github.com/hanno-arm","followers_url":"https://api.github.com/users/hanno-arm/followers","following_url":"https://api.github.com/users/hanno-arm/following{/other_user}","gists_url":"https://api.github.com/users/hanno-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/hanno-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanno-arm/subscriptions","organizations_url":"https://api.github.com/users/hanno-arm/orgs","repos_url":"https://api.github.com/users/hanno-arm/repos","events_url":"https://api.github.com/users/hanno-arm/events{/privacy}","received_events_url":"https://api.github.com/users/hanno-arm/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1084/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/b16709afc447c279f830f15043a99fd2831db228","head":{"label":"ordex:fix-aes-ctr-generic","ref":"fix-aes-ctr-generic","sha":"b16709afc447c279f830f15043a99fd2831db228","user":{"login":"ordex","id":3433035,"avatar_url":"https://avatars0.githubusercontent.com/u/3433035?v=4","gravatar_id":"","url":"https://api.github.com/users/ordex","html_url":"https://github.com/ordex","followers_url":"https://api.github.com/users/ordex/followers","following_url":"https://api.github.com/users/ordex/following{/other_user}","gists_url":"https://api.github.com/users/ordex/gists{/gist_id}","starred_url":"https://api.github.com/users/ordex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordex/subscriptions","organizations_url":"https://api.github.com/users/ordex/orgs","repos_url":"https://api.github.com/users/ordex/repos","events_url":"https://api.github.com/users/ordex/events{/privacy}","received_events_url":"https://api.github.com/users/ordex/received_events","type":"User","site_admin":false},"repo":{"id":71374668,"name":"mbedtls","full_name":"ordex/mbedtls","owner":{"login":"ordex","id":3433035,"avatar_url":"https://avatars0.githubusercontent.com/u/3433035?v=4","gravatar_id":"","url":"https://api.github.com/users/ordex","html_url":"https://github.com/ordex","followers_url":"https://api.github.com/users/ordex/followers","following_url":"https://api.github.com/users/ordex/following{/other_user}","gists_url":"https://api.github.com/users/ordex/gists{/gist_id}","starred_url":"https://api.github.com/users/ordex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordex/subscriptions","organizations_url":"https://api.github.com/users/ordex/orgs","repos_url":"https://api.github.com/users/ordex/repos","events_url":"https://api.github.com/users/ordex/events{/privacy}","received_events_url":"https://api.github.com/users/ordex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ordex/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/ordex/mbedtls","forks_url":"https://api.github.com/repos/ordex/mbedtls/forks","keys_url":"https://api.github.com/repos/ordex/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordex/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordex/mbedtls/teams","hooks_url":"https://api.github.com/repos/ordex/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ordex/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ordex/mbedtls/events","assignees_url":"https://api.github.com/repos/ordex/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ordex/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ordex/mbedtls/tags","blobs_url":"https://api.github.com/repos/ordex/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordex/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordex/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordex/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordex/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ordex/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ordex/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ordex/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ordex/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ordex/mbedtls/subscription","commits_url":"https://api.github.com/repos/ordex/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordex/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordex/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordex/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordex/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ordex/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordex/mbedtls/merges","archive_url":"https://api.github.com/repos/ordex/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordex/mbedtls/downloads","issues_url":"https://api.github.com/repos/ordex/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ordex/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ordex/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ordex/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordex/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ordex/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ordex/mbedtls/deployments","created_at":"2016-10-19T16:01:01Z","updated_at":"2016-10-19T16:01:06Z","pushed_at":"2017-09-09T15:46:52Z","git_url":"git://github.com/ordex/mbedtls.git","ssh_url":"git@github.com:ordex/mbedtls.git","clone_url":"https://github.com/ordex/mbedtls.git","svn_url":"https://github.com/ordex/mbedtls","homepage":"https://tls.mbed.org","size":21490,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"72ea31b026e1fc61b01662474aa5125817b968bc","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"name":"mbedtls","full_name":"ARMmbed/mbedtls","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2017-09-08T07:34:18Z","pushed_at":"2017-09-09T15:47:30Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":22188,"stargazers_count":1077,"watchers_count":1077,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":645,"mirror_url":null,"open_issues_count":362,"forks":645,"open_issues":362,"watchers":1077,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1084"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1084"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/b16709afc447c279f830f15043a99fd2831db228"}},"author_association":"NONE"}}
|
{
"id": 6687936,
"name": "ARMmbed/mbedtls",
"url": "https://api.github.com/repos/ARMmbed/mbedtls"
}
|
{
"id": 22030476,
"login": "RonEld",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22030476?",
"url": "https://api.github.com/users/RonEld"
}
|
{
"id": 8916057,
"login": "ARMmbed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8916057?",
"url": "https://api.github.com/orgs/ARMmbed"
}
| 2017-09-10T07:56:44 |
6570972204
|
{"actor":{"display_login":"RonEld"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/112589912","pull_request_review_id":33917518,"id":112589912,"diff_hunk":"@@ -144,12 +146,25 @@ public IOException toIOException() {\n /**\n * Converts an Alluxio exception from Thrift representation to native representation.\n *\n- * @param e the Alluxio Thrift exception\n+ * @param e the Thrift exception\n * @return the native Alluxio exception\n */\n public static AlluxioStatusException fromThrift(AlluxioTException e) {\n- String m = e.getMessage();\n- switch (e.getStatus()) {\n+ return fromStatusAndMessage(Status.fromThrift(e.getStatus()), e.getMessage());\n+ }\n+\n+ /**\n+ * Converts an Alluxio exception from status and message representation to native representation.\n+ * The status must not be null or {@link Status#OK}.\n+ *\n+ * @param status the status\n+ * @param m the message\n+ * @return the native Alluxio exception\n+ */\n+ public static AlluxioStatusException fromStatusAndMessage(Status status, String m) {","path":"core/common/src/main/java/alluxio/exception/status/AlluxioStatusException.java","position":85,"original_position":85,"commit_id":"73ab9a731d82cebeab8d10f26d83fac52d834b4a","original_commit_id":"73ab9a731d82cebeab8d10f26d83fac52d834b4a","user":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars1.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"body":"why not just `from`?","created_at":"2017-04-21T00:49:26Z","updated_at":"2017-04-21T00:49:26Z","html_url":"https://github.com/Alluxio/alluxio/pull/5214#discussion_r112589912","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/112589912"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5214#discussion_r112589912"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214","id":116709184,"html_url":"https://github.com/Alluxio/alluxio/pull/5214","diff_url":"https://github.com/Alluxio/alluxio/pull/5214.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/5214.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5214","number":5214,"state":"open","locked":false,"title":"[ALLUXIO-2815] Use status exceptions in Netty","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars0.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2815","created_at":"2017-04-20T07:44:49Z","updated_at":"2017-04-21T00:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0093243f774c11e58d58ae516e67d65e4de8acbf","assignee":{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars1.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsimsa","id":1072079,"avatar_url":"https://avatars1.githubusercontent.com/u/1072079?v=3","gravatar_id":"","url":"https://api.github.com/users/jsimsa","html_url":"https://github.com/jsimsa","followers_url":"https://api.github.com/users/jsimsa/followers","following_url":"https://api.github.com/users/jsimsa/following{/other_user}","gists_url":"https://api.github.com/users/jsimsa/gists{/gist_id}","starred_url":"https://api.github.com/users/jsimsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsimsa/subscriptions","organizations_url":"https://api.github.com/users/jsimsa/orgs","repos_url":"https://api.github.com/users/jsimsa/repos","events_url":"https://api.github.com/users/jsimsa/events{/privacy}","received_events_url":"https://api.github.com/users/jsimsa/received_events","type":"User","site_admin":false},{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars3.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},{"login":"peisun1115","id":18294241,"avatar_url":"https://avatars2.githubusercontent.com/u/18294241?v=3","gravatar_id":"","url":"https://api.github.com/users/peisun1115","html_url":"https://github.com/peisun1115","followers_url":"https://api.github.com/users/peisun1115/followers","following_url":"https://api.github.com/users/peisun1115/following{/other_user}","gists_url":"https://api.github.com/users/peisun1115/gists{/gist_id}","starred_url":"https://api.github.com/users/peisun1115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peisun1115/subscriptions","organizations_url":"https://api.github.com/users/peisun1115/orgs","repos_url":"https://api.github.com/users/peisun1115/repos","events_url":"https://api.github.com/users/peisun1115/events{/privacy}","received_events_url":"https://api.github.com/users/peisun1115/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5214/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/73ab9a731d82cebeab8d10f26d83fac52d834b4a","head":{"label":"aaudiber:netty-exceptions","ref":"netty-exceptions","sha":"73ab9a731d82cebeab8d10f26d83fac52d834b4a","user":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars0.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"repo":{"id":52421920,"name":"alluxio","full_name":"aaudiber/alluxio","owner":{"login":"aaudiber","id":3455177,"avatar_url":"https://avatars0.githubusercontent.com/u/3455177?v=3","gravatar_id":"","url":"https://api.github.com/users/aaudiber","html_url":"https://github.com/aaudiber","followers_url":"https://api.github.com/users/aaudiber/followers","following_url":"https://api.github.com/users/aaudiber/following{/other_user}","gists_url":"https://api.github.com/users/aaudiber/gists{/gist_id}","starred_url":"https://api.github.com/users/aaudiber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaudiber/subscriptions","organizations_url":"https://api.github.com/users/aaudiber/orgs","repos_url":"https://api.github.com/users/aaudiber/repos","events_url":"https://api.github.com/users/aaudiber/events{/privacy}","received_events_url":"https://api.github.com/users/aaudiber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaudiber/alluxio","description":"Memory-Centric Virtual Distributed Storage System","fork":true,"url":"https://api.github.com/repos/aaudiber/alluxio","forks_url":"https://api.github.com/repos/aaudiber/alluxio/forks","keys_url":"https://api.github.com/repos/aaudiber/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaudiber/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaudiber/alluxio/teams","hooks_url":"https://api.github.com/repos/aaudiber/alluxio/hooks","issue_events_url":"https://api.github.com/repos/aaudiber/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/aaudiber/alluxio/events","assignees_url":"https://api.github.com/repos/aaudiber/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/aaudiber/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/aaudiber/alluxio/tags","blobs_url":"https://api.github.com/repos/aaudiber/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaudiber/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaudiber/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaudiber/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaudiber/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/aaudiber/alluxio/languages","stargazers_url":"https://api.github.com/repos/aaudiber/alluxio/stargazers","contributors_url":"https://api.github.com/repos/aaudiber/alluxio/contributors","subscribers_url":"https://api.github.com/repos/aaudiber/alluxio/subscribers","subscription_url":"https://api.github.com/repos/aaudiber/alluxio/subscription","commits_url":"https://api.github.com/repos/aaudiber/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaudiber/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaudiber/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaudiber/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaudiber/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/aaudiber/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaudiber/alluxio/merges","archive_url":"https://api.github.com/repos/aaudiber/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaudiber/alluxio/downloads","issues_url":"https://api.github.com/repos/aaudiber/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/aaudiber/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/aaudiber/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/aaudiber/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaudiber/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/aaudiber/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/aaudiber/alluxio/deployments","created_at":"2016-02-24T07:07:15Z","updated_at":"2017-02-08T21:57:09Z","pushed_at":"2017-04-20T23:41:00Z","git_url":"git://github.com/aaudiber/alluxio.git","ssh_url":"git@github.com:aaudiber/alluxio.git","clone_url":"https://github.com/aaudiber/alluxio.git","svn_url":"https://github.com/aaudiber/alluxio","homepage":"http://www.alluxio.org/","size":69026,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Alluxio:post-5206","ref":"post-5206","sha":"9583dd04145d0bc1b5c7e0ecdd5daaaa00700ba5","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2017-04-20T23:18:52Z","pushed_at":"2017-04-21T00:05:42Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":69084,"stargazers_count":2932,"watchers_count":2932,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1452,"mirror_url":null,"open_issues_count":55,"forks":1452,"open_issues":55,"watchers":2932,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5214"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5214"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5214/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5214/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/73ab9a731d82cebeab8d10f26d83fac52d834b4a"}}}}
|
{
"id": 7276954,
"name": "Alluxio/alluxio",
"url": "https://api.github.com/repos/Alluxio/alluxio"
}
|
{
"id": 1072079,
"login": "jsimsa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1072079?",
"url": "https://api.github.com/users/jsimsa"
}
|
{
"id": 16203694,
"login": "Alluxio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16203694?",
"url": "https://api.github.com/orgs/Alluxio"
}
| 2017-04-21T00:49:26 |
5728403340
|
{"actor":{"display_login":"jsimsa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/110282264","pull_request_review_id":31446262,"id":110282264,"diff_hunk":"@@ -103,6 +111,27 @@ public void lsNoAcl() throws IOException, AlluxioException {\n }\n \n /**\n+ * Tests ls -h command when security is not enabled.\n+ */\n+ @Test\n+ @LocalAlluxioClusterResource.Config(\n+ confParams = {PropertyKey.Name.SECURITY_AUTHORIZATION_PERMISSION_ENABLED, \"false\",","path":"tests/src/test/java/alluxio/shell/command/LsCommandTest.java","position":37,"original_position":37,"commit_id":"31957ed232b3d487f40b28948dbcb15ad315986d","original_commit_id":"31957ed232b3d487f40b28948dbcb15ad315986d","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars3.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"check the indent for the other test cases","created_at":"2017-04-06T22:30:32Z","updated_at":"2017-04-06T22:30:32Z","html_url":"https://github.com/Alluxio/alluxio/pull/5043#discussion_r110282264","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/110282264"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5043#discussion_r110282264"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043","id":113871823,"html_url":"https://github.com/Alluxio/alluxio/pull/5043","diff_url":"https://github.com/Alluxio/alluxio/pull/5043.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/5043.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5043","number":5043,"state":"open","locked":false,"title":"[ALLUXIO-2571]Add \"-h\" (HumanReadable) option for Shell Command “bin/alluxio fs ls”","user":{"login":"jiaosummer","id":23270032,"avatar_url":"https://avatars3.githubusercontent.com/u/23270032?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaosummer","html_url":"https://github.com/jiaosummer","followers_url":"https://api.github.com/users/jiaosummer/followers","following_url":"https://api.github.com/users/jiaosummer/following{/other_user}","gists_url":"https://api.github.com/users/jiaosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaosummer/subscriptions","organizations_url":"https://api.github.com/users/jiaosummer/orgs","repos_url":"https://api.github.com/users/jiaosummer/repos","events_url":"https://api.github.com/users/jiaosummer/events{/privacy}","received_events_url":"https://api.github.com/users/jiaosummer/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2571\r\n\r\nCurrently \"bin/alluxio fs ls <path>\" command works like normal \"ls\" command on Linux shell, it shows the information of files or directories, including the size of a file.\r\nThis JIRA aims to add a “-h” option like linux \"ls\" command by which user can specify the format of file sizes in a human-readable fashion (eg 1K instead of 1024). To be more specific \r\nwhen used with the -l option, the size part of ls output use unit suffixes: Byte, Kilobyte, Megabyte, Gigabyte, Terabyte and Petabyte, like \"204B\", \"35K\", \"1M\", \"23G\" depends on the actual file size. Right now, this is enabled by default and you have to use -raw option to show the raw size. This JIRA aims to switch this by displaying the size in raw bytes by default, and only shows human-readable when \"-h\" is specified.","created_at":"2017-04-03T07:32:07Z","updated_at":"2017-04-06T22:30:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"652725b5877ff6f4e0760948b3de33e97bf2860b","assignee":{"login":"uronce-cc","id":3663941,"avatar_url":"https://avatars2.githubusercontent.com/u/3663941?v=3","gravatar_id":"","url":"https://api.github.com/users/uronce-cc","html_url":"https://github.com/uronce-cc","followers_url":"https://api.github.com/users/uronce-cc/followers","following_url":"https://api.github.com/users/uronce-cc/following{/other_user}","gists_url":"https://api.github.com/users/uronce-cc/gists{/gist_id}","starred_url":"https://api.github.com/users/uronce-cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uronce-cc/subscriptions","organizations_url":"https://api.github.com/users/uronce-cc/orgs","repos_url":"https://api.github.com/users/uronce-cc/repos","events_url":"https://api.github.com/users/uronce-cc/events{/privacy}","received_events_url":"https://api.github.com/users/uronce-cc/received_events","type":"User","site_admin":false},"assignees":[{"login":"uronce-cc","id":3663941,"avatar_url":"https://avatars2.githubusercontent.com/u/3663941?v=3","gravatar_id":"","url":"https://api.github.com/users/uronce-cc","html_url":"https://github.com/uronce-cc","followers_url":"https://api.github.com/users/uronce-cc/followers","following_url":"https://api.github.com/users/uronce-cc/following{/other_user}","gists_url":"https://api.github.com/users/uronce-cc/gists{/gist_id}","starred_url":"https://api.github.com/users/uronce-cc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uronce-cc/subscriptions","organizations_url":"https://api.github.com/users/uronce-cc/orgs","repos_url":"https://api.github.com/users/uronce-cc/repos","events_url":"https://api.github.com/users/uronce-cc/events{/privacy}","received_events_url":"https://api.github.com/users/uronce-cc/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5043/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/31957ed232b3d487f40b28948dbcb15ad315986d","head":{"label":"jiaosummer:ALLUXIO-2571","ref":"ALLUXIO-2571","sha":"31957ed232b3d487f40b28948dbcb15ad315986d","user":{"login":"jiaosummer","id":23270032,"avatar_url":"https://avatars3.githubusercontent.com/u/23270032?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaosummer","html_url":"https://github.com/jiaosummer","followers_url":"https://api.github.com/users/jiaosummer/followers","following_url":"https://api.github.com/users/jiaosummer/following{/other_user}","gists_url":"https://api.github.com/users/jiaosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaosummer/subscriptions","organizations_url":"https://api.github.com/users/jiaosummer/orgs","repos_url":"https://api.github.com/users/jiaosummer/repos","events_url":"https://api.github.com/users/jiaosummer/events{/privacy}","received_events_url":"https://api.github.com/users/jiaosummer/received_events","type":"User","site_admin":false},"repo":{"id":85497508,"name":"alluxio","full_name":"jiaosummer/alluxio","owner":{"login":"jiaosummer","id":23270032,"avatar_url":"https://avatars3.githubusercontent.com/u/23270032?v=3","gravatar_id":"","url":"https://api.github.com/users/jiaosummer","html_url":"https://github.com/jiaosummer","followers_url":"https://api.github.com/users/jiaosummer/followers","following_url":"https://api.github.com/users/jiaosummer/following{/other_user}","gists_url":"https://api.github.com/users/jiaosummer/gists{/gist_id}","starred_url":"https://api.github.com/users/jiaosummer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiaosummer/subscriptions","organizations_url":"https://api.github.com/users/jiaosummer/orgs","repos_url":"https://api.github.com/users/jiaosummer/repos","events_url":"https://api.github.com/users/jiaosummer/events{/privacy}","received_events_url":"https://api.github.com/users/jiaosummer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiaosummer/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/jiaosummer/alluxio","forks_url":"https://api.github.com/repos/jiaosummer/alluxio/forks","keys_url":"https://api.github.com/repos/jiaosummer/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiaosummer/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiaosummer/alluxio/teams","hooks_url":"https://api.github.com/repos/jiaosummer/alluxio/hooks","issue_events_url":"https://api.github.com/repos/jiaosummer/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/jiaosummer/alluxio/events","assignees_url":"https://api.github.com/repos/jiaosummer/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/jiaosummer/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/jiaosummer/alluxio/tags","blobs_url":"https://api.github.com/repos/jiaosummer/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiaosummer/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiaosummer/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiaosummer/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiaosummer/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/jiaosummer/alluxio/languages","stargazers_url":"https://api.github.com/repos/jiaosummer/alluxio/stargazers","contributors_url":"https://api.github.com/repos/jiaosummer/alluxio/contributors","subscribers_url":"https://api.github.com/repos/jiaosummer/alluxio/subscribers","subscription_url":"https://api.github.com/repos/jiaosummer/alluxio/subscription","commits_url":"https://api.github.com/repos/jiaosummer/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiaosummer/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiaosummer/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiaosummer/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiaosummer/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/jiaosummer/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiaosummer/alluxio/merges","archive_url":"https://api.github.com/repos/jiaosummer/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiaosummer/alluxio/downloads","issues_url":"https://api.github.com/repos/jiaosummer/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/jiaosummer/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/jiaosummer/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/jiaosummer/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiaosummer/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/jiaosummer/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/jiaosummer/alluxio/deployments","created_at":"2017-03-19T18:03:09Z","updated_at":"2017-03-19T18:03:16Z","pushed_at":"2017-04-06T04:56:11Z","git_url":"git://github.com/jiaosummer/alluxio.git","ssh_url":"git@github.com:jiaosummer/alluxio.git","clone_url":"https://github.com/jiaosummer/alluxio.git","svn_url":"https://github.com/jiaosummer/alluxio","homepage":"http://www.alluxio.org/","size":67708,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"5da7637e7bb65971f073df07d2d82d00a2d52383","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2017-04-06T20:48:48Z","pushed_at":"2017-04-06T22:23:50Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":68040,"stargazers_count":2916,"watchers_count":2916,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1407,"mirror_url":null,"open_issues_count":38,"forks":1407,"open_issues":38,"watchers":2916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5043"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5043"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5043/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5043/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/31957ed232b3d487f40b28948dbcb15ad315986d"}}}}
|
{
"id": 7276954,
"name": "Alluxio/alluxio",
"url": "https://api.github.com/repos/Alluxio/alluxio"
}
|
{
"id": 1413748,
"login": "apc999",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1413748?",
"url": "https://api.github.com/users/apc999"
}
|
{
"id": 16203694,
"login": "Alluxio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16203694?",
"url": "https://api.github.com/orgs/Alluxio"
}
| 2017-04-06T22:30:32 |
5642949797
|
{"actor":{"display_login":"apc999"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CCI-MOC/ims/pulls/comments/153689992","pull_request_review_id":79731120,"id":153689992,"diff_hunk":"@@ -0,0 +1,199 @@\n+**ASSUMPTION:** A reliable underlying technology that provides 100% availablity of the database, following are some examples of the relations between different tables. \r\n+\r\n+\r\n+All the tables in the BMI database are listed bellow: \r\n+\r\n+## User \r\n+\r\n+1. An entity using BMI. \r\n+2. Users will be registered to BMI by an admin via the API after BMI has been deployed. \r\n+\r\n+* id : Id of the user (primary key)\r\n+* name : Name of the user (unique key) \r\n+* type : Type of user (ordinary user or admin)\r\n+* quota : Quantity of datastore disk-space allocated to a user (GB)\r\n+* status : Current status of user (e.g. active, inactive, disabled, etc.)\r\n+* autheticationId : Id of the authentication service using which a user will be verified in a multi-tenant setup. A user will specify a token (obtained from the authentication service) while invoking the REST API.\r\n+\r\n+****\r\n+\r\n+## AccessControlList\r\n+\r\n+1. List of users who can be given access to a particular resource (currently only for images). \r\n+2. An access control list (ACL) can be created by any user (a.k.a. the user creating the access control list will be its owner). \r\n+3. Owner of an access control list can add/remove user from the access control list. \r\n+4. Owner can transfer the ownership of the access control list to another user. \r\n+5. Owner can share an access control list with another user. \r\n+6. Owner can attach/detach an access control list (owned/shared by/to him) to a resource.\r\n+7. Shared access control lists can be modified by their owner w/o approval from the user with whom the access control list was shared with.\r\n+\r\n+* id : Id of the access control list (primary key)\r\n+* name : Name of the access control list \r\n+* ownerUserId : Id of the user who owns the ACL\r\n+\r\n+**NOTE:** `(name, ownerUserId) pair is unique key.`\r\n+\r\n+****\r\n+\r\n+## Image/Snapshot\r\n+\r\n+1. A virtual disk (a.k.a. golden image) whose clone (linked clone) is used to provision a node. \r\n+2. Users can upload images. \r\n+3. The user uploading the image will be the owner of the uploaded image.\r\n+4. Snapshot is a special type of image that is created by deep copying the existing state of a provisioned node's image. \r\n+5. Image/Snapshot owner can be different from the owner of an ACL. \r\n+6. Ownership of the image/snapshot can be transfered to another user.\r\n+7. Image/Snapshot can be shared to a set of users.\r\n+8. Image/Snapshot can be made publically available to all exisiting users.\r\n+\r\n+* id : Id of the image (primary key)\r\n+* name : Name of the image\r\n+* ownerUserId : Id of the user who owns the image.\r\n+* type : Type of image (e.g. RAW, QCOW2, etc.)\r\n+* visibility : Access level of image (e.g. private, public, shared, etc.)\r\n+* isSnapshot : This flag is `true` in case of snapshot and not an uploaded image\r\n+* dataStoreId : Id of the DataStore that gives information about where this image is stored. \r\n+\r\n+**NOTE:** `(name, ownerUserId) pair is unique key.`\r\n+\r\n+***\r\n+\r\n+## ProvisionedNode\r\n+\r\n+1. Node running an operating system from the associated clone of a parent image (aka golden image). \r\n+2. A user can provision multiple nodes.\r\n+3. A clone (shallow or deep copy depending on the underlying data store's capabilities) of the parent image is created and used to provision a node.\r\n+4. Nodes are provisioned using a provisioning engine over a network owned by the user.\r\n+5. BMI creates an interface (physical or virtual) on the provisioning engine for the users' provisioning network.\r\n+\r\n+* id : Id of the provisioned node (primary key)\r\n+* macAddress : Mac address of the provisioned node (unique key)\r\n+* parentImageId : Id of the golden image.\r\n+* cloneName : Name of the cloned image (unique key)\r\n+* nic : NIC of the provisioned node \r\n+* ownerUserId : Id of the user who owns the provisioned node \r\n+* provisionEngineVlanId: Id of the provisionEngineVlan. This column represents the `(provisioning engine, vlan interface)` pair that is used to provision the given node.\r\n+\r\n+***\r\n+\r\n+## Tag\r\n+\r\n+1. Restore points of an exisitng provisioned image created by the user in time.\r\n+2. Performance of Tag creation will depend on the data stores' capabilities.\r\n+3. All tag must be deleted before de-provisioning. \r\n+\r\n+* id : Id of the tag (primary key)\r\n+* name : Name of the tag\r\n+* nodeId :Id of the node of which this tag is created.\r\n+\r\n+***\r\n+\r\n+## UserAccessControlList \r\n+\r\n+1. Mapping between access control list and user.\r\n+2. A user can be assosiated to multiple access control lists.\r\n+3. An access control list can have multiple user in it.\r\n+\r\n+* id: Id of the User-AceesControlList mapping (primary key)\r\n+* ACLId : Id of the ACL.\r\n+* userId: Id of the user.\r\n+\r\n+**NOTE:** `(ACLId, userId) pair is unique key.`\r\n+\r\n+***\r\n+\r\n+## ImageAccessControlList \r\n+\r\n+1. Mapping between access control list and image. \r\n+2. An access control list can be attached to multiple images.\r\n+3. An image can be accessed by multple access control lists.\r\n+\r\n+* id: Id of the Image-AccessControlList mapping (primary key)\r\n+* ACLId: Id of the ACL. \r\n+* imageId : Id of the image table.\r\n+\r\n+**NOTE:** `(ACLId, imageId) pair is unique key.`\r\n+\r\n+***\r\n+\r\n+## External Service Table (Authention/DataStore/ProvisionEngine) \r\n+\r\n+1. Authentication: A service used to authenticate the legitimacy of a user request.\r\n+2. DataStore: A filesystem service where images are stored.\r\n+3. ProvisionEngine: A service used to (de)-provision a node.\r\n+\r\n+* The three above tables have `<id>` (primary key), `<name>` (unique key), `<type>`, `<url>` (unique key), `<ip>`, and `<port>`\r\n+\r\n+**NOTE:** `(ip, port) pair is unique key.`\r\n+\r\n+***\r\n+\r\n+## Vlan \r","path":"docs/redesign-specs/DB_Schema/database.md","position":131,"original_position":131,"commit_id":"6d18d3305ac20d7019fc63363772edd581f93426","original_commit_id":"6d18d3305ac20d7019fc63363772edd581f93426","user":{"login":"knikolla","id":4123322,"avatar_url":"https://avatars0.githubusercontent.com/u/4123322?v=4","gravatar_id":"","url":"https://api.github.com/users/knikolla","html_url":"https://github.com/knikolla","followers_url":"https://api.github.com/users/knikolla/followers","following_url":"https://api.github.com/users/knikolla/following{/other_user}","gists_url":"https://api.github.com/users/knikolla/gists{/gist_id}","starred_url":"https://api.github.com/users/knikolla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knikolla/subscriptions","organizations_url":"https://api.github.com/users/knikolla/orgs","repos_url":"https://api.github.com/users/knikolla/repos","events_url":"https://api.github.com/users/knikolla/events{/privacy}","received_events_url":"https://api.github.com/users/knikolla/received_events","type":"User","site_admin":false},"body":"A driver which supports multiple technologies will not work if you settle on only VLANs.","created_at":"2017-11-29T04:10:06Z","updated_at":"2017-11-29T04:24:00Z","html_url":"https://github.com/CCI-MOC/ims/pull/154#discussion_r153689992","pull_request_url":"https://api.github.com/repos/CCI-MOC/ims/pulls/154","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/comments/153689992"},"html":{"href":"https://github.com/CCI-MOC/ims/pull/154#discussion_r153689992"},"pull_request":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/CCI-MOC/ims/pulls/154","id":150997666,"html_url":"https://github.com/CCI-MOC/ims/pull/154","diff_url":"https://github.com/CCI-MOC/ims/pull/154.diff","patch_url":"https://github.com/CCI-MOC/ims/pull/154.patch","issue_url":"https://api.github.com/repos/CCI-MOC/ims/issues/154","number":154,"state":"open","locked":false,"title":"Redesign Specs","user":{"login":"chemistry-sourabh","id":10385794,"avatar_url":"https://avatars2.githubusercontent.com/u/10385794?v=4","gravatar_id":"","url":"https://api.github.com/users/chemistry-sourabh","html_url":"https://github.com/chemistry-sourabh","followers_url":"https://api.github.com/users/chemistry-sourabh/followers","following_url":"https://api.github.com/users/chemistry-sourabh/following{/other_user}","gists_url":"https://api.github.com/users/chemistry-sourabh/gists{/gist_id}","starred_url":"https://api.github.com/users/chemistry-sourabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemistry-sourabh/subscriptions","organizations_url":"https://api.github.com/users/chemistry-sourabh/orgs","repos_url":"https://api.github.com/users/chemistry-sourabh/repos","events_url":"https://api.github.com/users/chemistry-sourabh/events{/privacy}","received_events_url":"https://api.github.com/users/chemistry-sourabh/received_events","type":"User","site_admin":false},"body":"First Draft of BMI Redesign specs","created_at":"2017-11-07T00:41:22Z","updated_at":"2017-11-29T04:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d85d303b5f509ca4cdf1f8312595a6a3007e489","assignee":{"login":"apoorvemohan","id":3013622,"avatar_url":"https://avatars3.githubusercontent.com/u/3013622?v=4","gravatar_id":"","url":"https://api.github.com/users/apoorvemohan","html_url":"https://github.com/apoorvemohan","followers_url":"https://api.github.com/users/apoorvemohan/followers","following_url":"https://api.github.com/users/apoorvemohan/following{/other_user}","gists_url":"https://api.github.com/users/apoorvemohan/gists{/gist_id}","starred_url":"https://api.github.com/users/apoorvemohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoorvemohan/subscriptions","organizations_url":"https://api.github.com/users/apoorvemohan/orgs","repos_url":"https://api.github.com/users/apoorvemohan/repos","events_url":"https://api.github.com/users/apoorvemohan/events{/privacy}","received_events_url":"https://api.github.com/users/apoorvemohan/received_events","type":"User","site_admin":false},"assignees":[{"login":"apoorvemohan","id":3013622,"avatar_url":"https://avatars3.githubusercontent.com/u/3013622?v=4","gravatar_id":"","url":"https://api.github.com/users/apoorvemohan","html_url":"https://github.com/apoorvemohan","followers_url":"https://api.github.com/users/apoorvemohan/followers","following_url":"https://api.github.com/users/apoorvemohan/following{/other_user}","gists_url":"https://api.github.com/users/apoorvemohan/gists{/gist_id}","starred_url":"https://api.github.com/users/apoorvemohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apoorvemohan/subscriptions","organizations_url":"https://api.github.com/users/apoorvemohan/orgs","repos_url":"https://api.github.com/users/apoorvemohan/repos","events_url":"https://api.github.com/users/apoorvemohan/events{/privacy}","received_events_url":"https://api.github.com/users/apoorvemohan/received_events","type":"User","site_admin":false},{"login":"chemistry-sourabh","id":10385794,"avatar_url":"https://avatars2.githubusercontent.com/u/10385794?v=4","gravatar_id":"","url":"https://api.github.com/users/chemistry-sourabh","html_url":"https://github.com/chemistry-sourabh","followers_url":"https://api.github.com/users/chemistry-sourabh/followers","following_url":"https://api.github.com/users/chemistry-sourabh/following{/other_user}","gists_url":"https://api.github.com/users/chemistry-sourabh/gists{/gist_id}","starred_url":"https://api.github.com/users/chemistry-sourabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemistry-sourabh/subscriptions","organizations_url":"https://api.github.com/users/chemistry-sourabh/orgs","repos_url":"https://api.github.com/users/chemistry-sourabh/repos","events_url":"https://api.github.com/users/chemistry-sourabh/events{/privacy}","received_events_url":"https://api.github.com/users/chemistry-sourabh/received_events","type":"User","site_admin":false},{"login":"nasibehteimouri","id":31547724,"avatar_url":"https://avatars0.githubusercontent.com/u/31547724?v=4","gravatar_id":"","url":"https://api.github.com/users/nasibehteimouri","html_url":"https://github.com/nasibehteimouri","followers_url":"https://api.github.com/users/nasibehteimouri/followers","following_url":"https://api.github.com/users/nasibehteimouri/following{/other_user}","gists_url":"https://api.github.com/users/nasibehteimouri/gists{/gist_id}","starred_url":"https://api.github.com/users/nasibehteimouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasibehteimouri/subscriptions","organizations_url":"https://api.github.com/users/nasibehteimouri/orgs","repos_url":"https://api.github.com/users/nasibehteimouri/repos","events_url":"https://api.github.com/users/nasibehteimouri/events{/privacy}","received_events_url":"https://api.github.com/users/nasibehteimouri/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CCI-MOC/ims/pulls/154/commits","review_comments_url":"https://api.github.com/repos/CCI-MOC/ims/pulls/154/comments","review_comment_url":"https://api.github.com/repos/CCI-MOC/ims/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CCI-MOC/ims/issues/154/comments","statuses_url":"https://api.github.com/repos/CCI-MOC/ims/statuses/6d18d3305ac20d7019fc63363772edd581f93426","head":{"label":"chemistry-sourabh:redesign-specs","ref":"redesign-specs","sha":"6d18d3305ac20d7019fc63363772edd581f93426","user":{"login":"chemistry-sourabh","id":10385794,"avatar_url":"https://avatars2.githubusercontent.com/u/10385794?v=4","gravatar_id":"","url":"https://api.github.com/users/chemistry-sourabh","html_url":"https://github.com/chemistry-sourabh","followers_url":"https://api.github.com/users/chemistry-sourabh/followers","following_url":"https://api.github.com/users/chemistry-sourabh/following{/other_user}","gists_url":"https://api.github.com/users/chemistry-sourabh/gists{/gist_id}","starred_url":"https://api.github.com/users/chemistry-sourabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemistry-sourabh/subscriptions","organizations_url":"https://api.github.com/users/chemistry-sourabh/orgs","repos_url":"https://api.github.com/users/chemistry-sourabh/repos","events_url":"https://api.github.com/users/chemistry-sourabh/events{/privacy}","received_events_url":"https://api.github.com/users/chemistry-sourabh/received_events","type":"User","site_admin":false},"repo":{"id":58402095,"name":"ims","full_name":"chemistry-sourabh/ims","owner":{"login":"chemistry-sourabh","id":10385794,"avatar_url":"https://avatars2.githubusercontent.com/u/10385794?v=4","gravatar_id":"","url":"https://api.github.com/users/chemistry-sourabh","html_url":"https://github.com/chemistry-sourabh","followers_url":"https://api.github.com/users/chemistry-sourabh/followers","following_url":"https://api.github.com/users/chemistry-sourabh/following{/other_user}","gists_url":"https://api.github.com/users/chemistry-sourabh/gists{/gist_id}","starred_url":"https://api.github.com/users/chemistry-sourabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chemistry-sourabh/subscriptions","organizations_url":"https://api.github.com/users/chemistry-sourabh/orgs","repos_url":"https://api.github.com/users/chemistry-sourabh/repos","events_url":"https://api.github.com/users/chemistry-sourabh/events{/privacy}","received_events_url":"https://api.github.com/users/chemistry-sourabh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chemistry-sourabh/ims","description":null,"fork":true,"url":"https://api.github.com/repos/chemistry-sourabh/ims","forks_url":"https://api.github.com/repos/chemistry-sourabh/ims/forks","keys_url":"https://api.github.com/repos/chemistry-sourabh/ims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chemistry-sourabh/ims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chemistry-sourabh/ims/teams","hooks_url":"https://api.github.com/repos/chemistry-sourabh/ims/hooks","issue_events_url":"https://api.github.com/repos/chemistry-sourabh/ims/issues/events{/number}","events_url":"https://api.github.com/repos/chemistry-sourabh/ims/events","assignees_url":"https://api.github.com/repos/chemistry-sourabh/ims/assignees{/user}","branches_url":"https://api.github.com/repos/chemistry-sourabh/ims/branches{/branch}","tags_url":"https://api.github.com/repos/chemistry-sourabh/ims/tags","blobs_url":"https://api.github.com/repos/chemistry-sourabh/ims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chemistry-sourabh/ims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chemistry-sourabh/ims/git/refs{/sha}","trees_url":"https://api.github.com/repos/chemistry-sourabh/ims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chemistry-sourabh/ims/statuses/{sha}","languages_url":"https://api.github.com/repos/chemistry-sourabh/ims/languages","stargazers_url":"https://api.github.com/repos/chemistry-sourabh/ims/stargazers","contributors_url":"https://api.github.com/repos/chemistry-sourabh/ims/contributors","subscribers_url":"https://api.github.com/repos/chemistry-sourabh/ims/subscribers","subscription_url":"https://api.github.com/repos/chemistry-sourabh/ims/subscription","commits_url":"https://api.github.com/repos/chemistry-sourabh/ims/commits{/sha}","git_commits_url":"https://api.github.com/repos/chemistry-sourabh/ims/git/commits{/sha}","comments_url":"https://api.github.com/repos/chemistry-sourabh/ims/comments{/number}","issue_comment_url":"https://api.github.com/repos/chemistry-sourabh/ims/issues/comments{/number}","contents_url":"https://api.github.com/repos/chemistry-sourabh/ims/contents/{+path}","compare_url":"https://api.github.com/repos/chemistry-sourabh/ims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chemistry-sourabh/ims/merges","archive_url":"https://api.github.com/repos/chemistry-sourabh/ims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chemistry-sourabh/ims/downloads","issues_url":"https://api.github.com/repos/chemistry-sourabh/ims/issues{/number}","pulls_url":"https://api.github.com/repos/chemistry-sourabh/ims/pulls{/number}","milestones_url":"https://api.github.com/repos/chemistry-sourabh/ims/milestones{/number}","notifications_url":"https://api.github.com/repos/chemistry-sourabh/ims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chemistry-sourabh/ims/labels{/name}","releases_url":"https://api.github.com/repos/chemistry-sourabh/ims/releases{/id}","deployments_url":"https://api.github.com/repos/chemistry-sourabh/ims/deployments","created_at":"2016-05-09T19:23:42Z","updated_at":"2016-05-09T19:23:43Z","pushed_at":"2017-11-28T22:29:11Z","git_url":"git://github.com/chemistry-sourabh/ims.git","ssh_url":"git@github.com:chemistry-sourabh/ims.git","clone_url":"https://github.com/chemistry-sourabh/ims.git","svn_url":"https://github.com/chemistry-sourabh/ims","homepage":null,"size":925,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CCI-MOC:master","ref":"master","sha":"8e42c0c2bd0f5abdbe6b5a4e44a5c074e8247808","user":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars1.githubusercontent.com/u/3578683?v=4","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"repo":{"id":49087722,"name":"ims","full_name":"CCI-MOC/ims","owner":{"login":"CCI-MOC","id":3578683,"avatar_url":"https://avatars1.githubusercontent.com/u/3578683?v=4","gravatar_id":"","url":"https://api.github.com/users/CCI-MOC","html_url":"https://github.com/CCI-MOC","followers_url":"https://api.github.com/users/CCI-MOC/followers","following_url":"https://api.github.com/users/CCI-MOC/following{/other_user}","gists_url":"https://api.github.com/users/CCI-MOC/gists{/gist_id}","starred_url":"https://api.github.com/users/CCI-MOC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CCI-MOC/subscriptions","organizations_url":"https://api.github.com/users/CCI-MOC/orgs","repos_url":"https://api.github.com/users/CCI-MOC/repos","events_url":"https://api.github.com/users/CCI-MOC/events{/privacy}","received_events_url":"https://api.github.com/users/CCI-MOC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CCI-MOC/ims","description":null,"fork":false,"url":"https://api.github.com/repos/CCI-MOC/ims","forks_url":"https://api.github.com/repos/CCI-MOC/ims/forks","keys_url":"https://api.github.com/repos/CCI-MOC/ims/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CCI-MOC/ims/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CCI-MOC/ims/teams","hooks_url":"https://api.github.com/repos/CCI-MOC/ims/hooks","issue_events_url":"https://api.github.com/repos/CCI-MOC/ims/issues/events{/number}","events_url":"https://api.github.com/repos/CCI-MOC/ims/events","assignees_url":"https://api.github.com/repos/CCI-MOC/ims/assignees{/user}","branches_url":"https://api.github.com/repos/CCI-MOC/ims/branches{/branch}","tags_url":"https://api.github.com/repos/CCI-MOC/ims/tags","blobs_url":"https://api.github.com/repos/CCI-MOC/ims/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CCI-MOC/ims/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CCI-MOC/ims/git/refs{/sha}","trees_url":"https://api.github.com/repos/CCI-MOC/ims/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CCI-MOC/ims/statuses/{sha}","languages_url":"https://api.github.com/repos/CCI-MOC/ims/languages","stargazers_url":"https://api.github.com/repos/CCI-MOC/ims/stargazers","contributors_url":"https://api.github.com/repos/CCI-MOC/ims/contributors","subscribers_url":"https://api.github.com/repos/CCI-MOC/ims/subscribers","subscription_url":"https://api.github.com/repos/CCI-MOC/ims/subscription","commits_url":"https://api.github.com/repos/CCI-MOC/ims/commits{/sha}","git_commits_url":"https://api.github.com/repos/CCI-MOC/ims/git/commits{/sha}","comments_url":"https://api.github.com/repos/CCI-MOC/ims/comments{/number}","issue_comment_url":"https://api.github.com/repos/CCI-MOC/ims/issues/comments{/number}","contents_url":"https://api.github.com/repos/CCI-MOC/ims/contents/{+path}","compare_url":"https://api.github.com/repos/CCI-MOC/ims/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CCI-MOC/ims/merges","archive_url":"https://api.github.com/repos/CCI-MOC/ims/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CCI-MOC/ims/downloads","issues_url":"https://api.github.com/repos/CCI-MOC/ims/issues{/number}","pulls_url":"https://api.github.com/repos/CCI-MOC/ims/pulls{/number}","milestones_url":"https://api.github.com/repos/CCI-MOC/ims/milestones{/number}","notifications_url":"https://api.github.com/repos/CCI-MOC/ims/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CCI-MOC/ims/labels{/name}","releases_url":"https://api.github.com/repos/CCI-MOC/ims/releases{/id}","deployments_url":"https://api.github.com/repos/CCI-MOC/ims/deployments","created_at":"2016-01-05T19:26:58Z","updated_at":"2017-10-11T00:20:47Z","pushed_at":"2017-11-28T22:29:12Z","git_url":"git://github.com/CCI-MOC/ims.git","ssh_url":"git@github.com:CCI-MOC/ims.git","clone_url":"https://github.com/CCI-MOC/ims.git","svn_url":"https://github.com/CCI-MOC/ims","homepage":null,"size":577,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":56,"license":null,"forks":12,"open_issues":56,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/154"},"html":{"href":"https://github.com/CCI-MOC/ims/pull/154"},"issue":{"href":"https://api.github.com/repos/CCI-MOC/ims/issues/154"},"comments":{"href":"https://api.github.com/repos/CCI-MOC/ims/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CCI-MOC/ims/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/CCI-MOC/ims/statuses/6d18d3305ac20d7019fc63363772edd581f93426"}},"author_association":"MEMBER"}}
|
{
"id": 49087722,
"name": "CCI-MOC/ims",
"url": "https://api.github.com/repos/CCI-MOC/ims"
}
|
{
"id": 4123322,
"login": "knikolla",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4123322?",
"url": "https://api.github.com/users/knikolla"
}
|
{
"id": 3578683,
"login": "CCI-MOC",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3578683?",
"url": "https://api.github.com/orgs/CCI-MOC"
}
| 2017-11-29T04:10:06 |
6916726421
|
{"actor":{"display_login":"knikolla"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/comments/100519213","pull_request_review_id":21229687,"id":100519213,"diff_hunk":"@@ -181,6 +181,9 @@ def upgrade_all(up_tyr=True, up_confs=True, check_version=True, send_mail='no',\n execute(enable_all_nodes, env.eng_hosts, env.ws_hosts_1, env.ws_hosts_2)\n env.roledefs['eng'] = env.eng_hosts\n \n+ # restart for jormun\n+ execute(jormungandr.reload_jormun_safe_all)","path":"fabfile/tasks.py","position":5,"original_position":5,"commit_id":"0c07a7b0e8d4d6375f3b60d4e53561074d051855","original_commit_id":"0c07a7b0e8d4d6375f3b60d4e53561074d051855","user":{"login":"Hoshiyo","id":6684925,"avatar_url":"https://avatars.githubusercontent.com/u/6684925?v=3","gravatar_id":"","url":"https://api.github.com/users/Hoshiyo","html_url":"https://github.com/Hoshiyo","followers_url":"https://api.github.com/users/Hoshiyo/followers","following_url":"https://api.github.com/users/Hoshiyo/following{/other_user}","gists_url":"https://api.github.com/users/Hoshiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoshiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoshiyo/subscriptions","organizations_url":"https://api.github.com/users/Hoshiyo/orgs","repos_url":"https://api.github.com/users/Hoshiyo/repos","events_url":"https://api.github.com/users/Hoshiyo/events{/privacy}","received_events_url":"https://api.github.com/users/Hoshiyo/received_events","type":"User","site_admin":false},"body":"not after jormun conf","created_at":"2017-02-10T11:43:48Z","updated_at":"2017-02-10T11:43:48Z","html_url":"https://github.com/CanalTP/fabric_navitia/pull/219#discussion_r100519213","pull_request_url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219","_links":{"self":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/comments/100519213"},"html":{"href":"https://github.com/CanalTP/fabric_navitia/pull/219#discussion_r100519213"},"pull_request":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219","id":105611485,"html_url":"https://github.com/CanalTP/fabric_navitia/pull/219","diff_url":"https://github.com/CanalTP/fabric_navitia/pull/219.diff","patch_url":"https://github.com/CanalTP/fabric_navitia/pull/219.patch","issue_url":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/219","number":219,"state":"open","locked":false,"title":"restart apache for jormun conf","user":{"login":"Hoshiyo","id":6684925,"avatar_url":"https://avatars.githubusercontent.com/u/6684925?v=3","gravatar_id":"","url":"https://api.github.com/users/Hoshiyo","html_url":"https://github.com/Hoshiyo","followers_url":"https://api.github.com/users/Hoshiyo/followers","following_url":"https://api.github.com/users/Hoshiyo/following{/other_user}","gists_url":"https://api.github.com/users/Hoshiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoshiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoshiyo/subscriptions","organizations_url":"https://api.github.com/users/Hoshiyo/orgs","repos_url":"https://api.github.com/users/Hoshiyo/repos","events_url":"https://api.github.com/users/Hoshiyo/events{/privacy}","received_events_url":"https://api.github.com/users/Hoshiyo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-10T11:28:42Z","updated_at":"2017-02-10T11:43:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e6061748a7d39f4bc0fca8dad24e3eb43bd6a0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219/commits","review_comments_url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219/comments","review_comment_url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/219/comments","statuses_url":"https://api.github.com/repos/CanalTP/fabric_navitia/statuses/0c07a7b0e8d4d6375f3b60d4e53561074d051855","head":{"label":"Hoshiyo:restart_apache_for_jormun","ref":"restart_apache_for_jormun","sha":"0c07a7b0e8d4d6375f3b60d4e53561074d051855","user":{"login":"Hoshiyo","id":6684925,"avatar_url":"https://avatars.githubusercontent.com/u/6684925?v=3","gravatar_id":"","url":"https://api.github.com/users/Hoshiyo","html_url":"https://github.com/Hoshiyo","followers_url":"https://api.github.com/users/Hoshiyo/followers","following_url":"https://api.github.com/users/Hoshiyo/following{/other_user}","gists_url":"https://api.github.com/users/Hoshiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoshiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoshiyo/subscriptions","organizations_url":"https://api.github.com/users/Hoshiyo/orgs","repos_url":"https://api.github.com/users/Hoshiyo/repos","events_url":"https://api.github.com/users/Hoshiyo/events{/privacy}","received_events_url":"https://api.github.com/users/Hoshiyo/received_events","type":"User","site_admin":false},"repo":{"id":42715416,"name":"fabric_navitia","full_name":"Hoshiyo/fabric_navitia","owner":{"login":"Hoshiyo","id":6684925,"avatar_url":"https://avatars.githubusercontent.com/u/6684925?v=3","gravatar_id":"","url":"https://api.github.com/users/Hoshiyo","html_url":"https://github.com/Hoshiyo","followers_url":"https://api.github.com/users/Hoshiyo/followers","following_url":"https://api.github.com/users/Hoshiyo/following{/other_user}","gists_url":"https://api.github.com/users/Hoshiyo/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoshiyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoshiyo/subscriptions","organizations_url":"https://api.github.com/users/Hoshiyo/orgs","repos_url":"https://api.github.com/users/Hoshiyo/repos","events_url":"https://api.github.com/users/Hoshiyo/events{/privacy}","received_events_url":"https://api.github.com/users/Hoshiyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Hoshiyo/fabric_navitia","description":"Navitia's deployment mechanisms","fork":true,"url":"https://api.github.com/repos/Hoshiyo/fabric_navitia","forks_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/forks","keys_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/teams","hooks_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/hooks","issue_events_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/issues/events{/number}","events_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/events","assignees_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/assignees{/user}","branches_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/branches{/branch}","tags_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/tags","blobs_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/languages","stargazers_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/stargazers","contributors_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/contributors","subscribers_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/subscribers","subscription_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/subscription","commits_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/contents/{+path}","compare_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/merges","archive_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/downloads","issues_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/issues{/number}","pulls_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/labels{/name}","releases_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/releases{/id}","deployments_url":"https://api.github.com/repos/Hoshiyo/fabric_navitia/deployments","created_at":"2015-09-18T10:34:09Z","updated_at":"2015-09-18T10:34:09Z","pushed_at":"2017-02-10T11:28:07Z","git_url":"git://github.com/Hoshiyo/fabric_navitia.git","ssh_url":"git@github.com:Hoshiyo/fabric_navitia.git","clone_url":"https://github.com/Hoshiyo/fabric_navitia.git","svn_url":"https://github.com/Hoshiyo/fabric_navitia","homepage":null,"size":701,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CanalTP:master","ref":"master","sha":"6843b60e58947e36929826b73d88c2f17856734d","user":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"repo":{"id":39951929,"name":"fabric_navitia","full_name":"CanalTP/fabric_navitia","owner":{"login":"CanalTP","id":2743985,"avatar_url":"https://avatars.githubusercontent.com/u/2743985?v=3","gravatar_id":"","url":"https://api.github.com/users/CanalTP","html_url":"https://github.com/CanalTP","followers_url":"https://api.github.com/users/CanalTP/followers","following_url":"https://api.github.com/users/CanalTP/following{/other_user}","gists_url":"https://api.github.com/users/CanalTP/gists{/gist_id}","starred_url":"https://api.github.com/users/CanalTP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CanalTP/subscriptions","organizations_url":"https://api.github.com/users/CanalTP/orgs","repos_url":"https://api.github.com/users/CanalTP/repos","events_url":"https://api.github.com/users/CanalTP/events{/privacy}","received_events_url":"https://api.github.com/users/CanalTP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CanalTP/fabric_navitia","description":"Navitia's deployment mechanisms","fork":false,"url":"https://api.github.com/repos/CanalTP/fabric_navitia","forks_url":"https://api.github.com/repos/CanalTP/fabric_navitia/forks","keys_url":"https://api.github.com/repos/CanalTP/fabric_navitia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CanalTP/fabric_navitia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CanalTP/fabric_navitia/teams","hooks_url":"https://api.github.com/repos/CanalTP/fabric_navitia/hooks","issue_events_url":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/events{/number}","events_url":"https://api.github.com/repos/CanalTP/fabric_navitia/events","assignees_url":"https://api.github.com/repos/CanalTP/fabric_navitia/assignees{/user}","branches_url":"https://api.github.com/repos/CanalTP/fabric_navitia/branches{/branch}","tags_url":"https://api.github.com/repos/CanalTP/fabric_navitia/tags","blobs_url":"https://api.github.com/repos/CanalTP/fabric_navitia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CanalTP/fabric_navitia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CanalTP/fabric_navitia/git/refs{/sha}","trees_url":"https://api.github.com/repos/CanalTP/fabric_navitia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CanalTP/fabric_navitia/statuses/{sha}","languages_url":"https://api.github.com/repos/CanalTP/fabric_navitia/languages","stargazers_url":"https://api.github.com/repos/CanalTP/fabric_navitia/stargazers","contributors_url":"https://api.github.com/repos/CanalTP/fabric_navitia/contributors","subscribers_url":"https://api.github.com/repos/CanalTP/fabric_navitia/subscribers","subscription_url":"https://api.github.com/repos/CanalTP/fabric_navitia/subscription","commits_url":"https://api.github.com/repos/CanalTP/fabric_navitia/commits{/sha}","git_commits_url":"https://api.github.com/repos/CanalTP/fabric_navitia/git/commits{/sha}","comments_url":"https://api.github.com/repos/CanalTP/fabric_navitia/comments{/number}","issue_comment_url":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/comments{/number}","contents_url":"https://api.github.com/repos/CanalTP/fabric_navitia/contents/{+path}","compare_url":"https://api.github.com/repos/CanalTP/fabric_navitia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CanalTP/fabric_navitia/merges","archive_url":"https://api.github.com/repos/CanalTP/fabric_navitia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CanalTP/fabric_navitia/downloads","issues_url":"https://api.github.com/repos/CanalTP/fabric_navitia/issues{/number}","pulls_url":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls{/number}","milestones_url":"https://api.github.com/repos/CanalTP/fabric_navitia/milestones{/number}","notifications_url":"https://api.github.com/repos/CanalTP/fabric_navitia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CanalTP/fabric_navitia/labels{/name}","releases_url":"https://api.github.com/repos/CanalTP/fabric_navitia/releases{/id}","deployments_url":"https://api.github.com/repos/CanalTP/fabric_navitia/deployments","created_at":"2015-07-30T13:26:24Z","updated_at":"2016-11-02T10:24:44Z","pushed_at":"2017-02-10T11:28:43Z","git_url":"git://github.com/CanalTP/fabric_navitia.git","ssh_url":"git@github.com:CanalTP/fabric_navitia.git","clone_url":"https://github.com/CanalTP/fabric_navitia.git","svn_url":"https://github.com/CanalTP/fabric_navitia","homepage":null,"size":693,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219"},"html":{"href":"https://github.com/CanalTP/fabric_navitia/pull/219"},"issue":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/219"},"comments":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/CanalTP/fabric_navitia/statuses/0c07a7b0e8d4d6375f3b60d4e53561074d051855"}}}}
|
{
"id": 39951929,
"name": "CanalTP/fabric_navitia",
"url": "https://api.github.com/repos/CanalTP/fabric_navitia"
}
|
{
"id": 6684925,
"login": "Hoshiyo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6684925?",
"url": "https://api.github.com/users/Hoshiyo"
}
|
{
"id": 2743985,
"login": "CanalTP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2743985?",
"url": "https://api.github.com/orgs/CanalTP"
}
| 2017-02-10T11:43:48 |
5302084898
|
{"actor":{"display_login":"Hoshiyo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/156044329","pull_request_review_id":82455776,"id":156044329,"diff_hunk":"@@ -5,21 +5,23 @@\n // --------------------------------------------------\n \n .ContentController {\n- position: relative;\n display: block;\n+ position: relative;","path":"app/assets/stylesheets/dashboard/content-controller.css.scss","position":6,"original_position":6,"commit_id":"12cda0e539711b08a2246575c3bca63a3e8b2eec","original_commit_id":"12cda0e539711b08a2246575c3bca63a3e8b2eec","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Properties should be ordered display, -moz-font-smoothing, -webkit-font-smoothing, margin, min-height, padding-top, position","created_at":"2017-12-11T11:11:31Z","updated_at":"2017-12-11T11:11:32Z","html_url":"https://github.com/CartoDB/cartodb/pull/13165#discussion_r156044329","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/156044329"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13165#discussion_r156044329"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165","id":155919406,"html_url":"https://github.com/CartoDB/cartodb/pull/13165","diff_url":"https://github.com/CartoDB/cartodb/pull/13165.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/13165.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13165","number":13165,"state":"open","locked":false,"title":"Replace SCSS-Lint with Stylelint","user":{"login":"rubenmoya","id":905225,"avatar_url":"https://avatars3.githubusercontent.com/u/905225?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenmoya","html_url":"https://github.com/rubenmoya","followers_url":"https://api.github.com/users/rubenmoya/followers","following_url":"https://api.github.com/users/rubenmoya/following{/other_user}","gists_url":"https://api.github.com/users/rubenmoya/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenmoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenmoya/subscriptions","organizations_url":"https://api.github.com/users/rubenmoya/orgs","repos_url":"https://api.github.com/users/rubenmoya/repos","events_url":"https://api.github.com/users/rubenmoya/events{/privacy}","received_events_url":"https://api.github.com/users/rubenmoya/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-01T17:47:52Z","updated_at":"2017-12-11T11:11:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8d2e2362ebd78b5787537fc7a292f00f90224c6","assignee":{"login":"rjimenezda","id":446970,"avatar_url":"https://avatars1.githubusercontent.com/u/446970?v=4","gravatar_id":"","url":"https://api.github.com/users/rjimenezda","html_url":"https://github.com/rjimenezda","followers_url":"https://api.github.com/users/rjimenezda/followers","following_url":"https://api.github.com/users/rjimenezda/following{/other_user}","gists_url":"https://api.github.com/users/rjimenezda/gists{/gist_id}","starred_url":"https://api.github.com/users/rjimenezda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjimenezda/subscriptions","organizations_url":"https://api.github.com/users/rjimenezda/orgs","repos_url":"https://api.github.com/users/rjimenezda/repos","events_url":"https://api.github.com/users/rjimenezda/events{/privacy}","received_events_url":"https://api.github.com/users/rjimenezda/received_events","type":"User","site_admin":false},"assignees":[{"login":"rjimenezda","id":446970,"avatar_url":"https://avatars1.githubusercontent.com/u/446970?v=4","gravatar_id":"","url":"https://api.github.com/users/rjimenezda","html_url":"https://github.com/rjimenezda","followers_url":"https://api.github.com/users/rjimenezda/followers","following_url":"https://api.github.com/users/rjimenezda/following{/other_user}","gists_url":"https://api.github.com/users/rjimenezda/gists{/gist_id}","starred_url":"https://api.github.com/users/rjimenezda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjimenezda/subscriptions","organizations_url":"https://api.github.com/users/rjimenezda/orgs","repos_url":"https://api.github.com/users/rjimenezda/repos","events_url":"https://api.github.com/users/rjimenezda/events{/privacy}","received_events_url":"https://api.github.com/users/rjimenezda/received_events","type":"User","site_admin":false},{"login":"rubenmoya","id":905225,"avatar_url":"https://avatars3.githubusercontent.com/u/905225?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenmoya","html_url":"https://github.com/rubenmoya","followers_url":"https://api.github.com/users/rubenmoya/followers","following_url":"https://api.github.com/users/rubenmoya/following{/other_user}","gists_url":"https://api.github.com/users/rubenmoya/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenmoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenmoya/subscriptions","organizations_url":"https://api.github.com/users/rubenmoya/orgs","repos_url":"https://api.github.com/users/rubenmoya/repos","events_url":"https://api.github.com/users/rubenmoya/events{/privacy}","received_events_url":"https://api.github.com/users/rubenmoya/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/13165/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/12cda0e539711b08a2246575c3bca63a3e8b2eec","head":{"label":"CartoDB:stylelint","ref":"stylelint","sha":"12cda0e539711b08a2246575c3bca63a3e8b2eec","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2017-12-11T04:43:32Z","pushed_at":"2017-12-11T11:10:04Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":365648,"stargazers_count":1664,"watchers_count":1664,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":777,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":469,"open_issues":777,"watchers":1664,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"2ffa59690cc76cf7a1e3e702fdc3f6d8f685ac30","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"name":"cartodb","full_name":"CartoDB/cartodb","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2017-12-11T04:43:32Z","pushed_at":"2017-12-11T11:10:04Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":365648,"stargazers_count":1664,"watchers_count":1664,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"archived":false,"open_issues_count":777,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":469,"open_issues":777,"watchers":1664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/13165"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13165"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/13165/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/13165/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/12cda0e539711b08a2246575c3bca63a3e8b2eec"}},"author_association":"MEMBER"}}
|
{
"id": 4909355,
"name": "CartoDB/cartodb",
"url": "https://api.github.com/repos/CartoDB/cartodb"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
}
| 2017-12-11T11:11:31 |
6970683735
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/102035343","pull_request_review_id":22778424,"id":102035343,"diff_hunk":"@@ -1,69 +0,0 @@\n-var DEFAULT_MAP_STYLE = [{","path":"src/geo/gmaps/gmaps-default-map-style.js","position":1,"original_position":1,"commit_id":"ff9d12ad6f78035d42dd224cc37c268346e7a159","original_commit_id":"ff9d12ad6f78035d42dd224cc37c268346e7a159","user":{"login":"alonsogarciapablo","id":390398,"avatar_url":"https://avatars.githubusercontent.com/u/390398?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsogarciapablo","html_url":"https://github.com/alonsogarciapablo","followers_url":"https://api.github.com/users/alonsogarciapablo/followers","following_url":"https://api.github.com/users/alonsogarciapablo/following{/other_user}","gists_url":"https://api.github.com/users/alonsogarciapablo/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsogarciapablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsogarciapablo/subscriptions","organizations_url":"https://api.github.com/users/alonsogarciapablo/orgs","repos_url":"https://api.github.com/users/alonsogarciapablo/repos","events_url":"https://api.github.com/users/alonsogarciapablo/events{/privacy}","received_events_url":"https://api.github.com/users/alonsogarciapablo/received_events","type":"User","site_admin":false},"body":"That's something we'll have to think we work on the API. Anyway, if someone wanted to create a map from a custom viz.json for example, they [should be able to specify the `baseType` and `style` attributes](https://github.com/CartoDB/cartodb.js/blob/ff9d12ad6f78035d42dd224cc37c268346e7a159/src/geo/gmaps/gmaps-base-layer-view.js#L31-L40) to customise their maps. And, [they will get the default style if they use any of the default map types](https://github.com/CartoDB/cartodb.js/blob/ff9d12ad6f78035d42dd224cc37c268346e7a159/src/geo/gmaps/gmaps-base-layer-view.js#L6-L11).","created_at":"2017-02-20T14:59:16Z","updated_at":"2017-02-20T14:59:16Z","html_url":"https://github.com/CartoDB/cartodb.js/pull/1584#discussion_r102035343","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/102035343"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1584#discussion_r102035343"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584"}}},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584","id":107015740,"html_url":"https://github.com/CartoDB/cartodb.js/pull/1584","diff_url":"https://github.com/CartoDB/cartodb.js/pull/1584.diff","patch_url":"https://github.com/CartoDB/cartodb.js/pull/1584.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1584","number":1584,"state":"open","locked":false,"title":"Adds support for Google Maps basemaps","user":{"login":"alonsogarciapablo","id":390398,"avatar_url":"https://avatars.githubusercontent.com/u/390398?v=3","gravatar_id":"","url":"https://api.github.com/users/alonsogarciapablo","html_url":"https://github.com/alonsogarciapablo","followers_url":"https://api.github.com/users/alonsogarciapablo/followers","following_url":"https://api.github.com/users/alonsogarciapablo/following{/other_user}","gists_url":"https://api.github.com/users/alonsogarciapablo/gists{/gist_id}","starred_url":"https://api.github.com/users/alonsogarciapablo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonsogarciapablo/subscriptions","organizations_url":"https://api.github.com/users/alonsogarciapablo/orgs","repos_url":"https://api.github.com/users/alonsogarciapablo/repos","events_url":"https://api.github.com/users/alonsogarciapablo/events{/privacy}","received_events_url":"https://api.github.com/users/alonsogarciapablo/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-20T14:25:31Z","updated_at":"2017-02-20T14:59:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a0560fd0ef35d2196183a092e17d1f265252d13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1584/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/ff9d12ad6f78035d42dd224cc37c268346e7a159","head":{"label":"CartoDB:google-maps","ref":"google-maps","sha":"ff9d12ad6f78035d42dd224cc37c268346e7a159","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2017-02-16T13:33:23Z","pushed_at":"2017-02-20T14:25:32Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":29363,"stargazers_count":305,"watchers_count":305,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":227,"mirror_url":null,"open_issues_count":81,"forks":227,"open_issues":81,"watchers":305,"default_branch":"develop"}},"base":{"label":"CartoDB:v4","ref":"v4","sha":"6cf81ed86ade4e44fea91b2f185ee5f7a2a24c38","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars.githubusercontent.com/u/1799254?v=3","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2017-02-16T13:33:23Z","pushed_at":"2017-02-20T14:25:32Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":29363,"stargazers_count":305,"watchers_count":305,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":227,"mirror_url":null,"open_issues_count":81,"forks":227,"open_issues":81,"watchers":305,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1584"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1584"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1584/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1584/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/ff9d12ad6f78035d42dd224cc37c268346e7a159"}}}}
|
{
"id": 4871551,
"name": "CartoDB/cartodb.js",
"url": "https://api.github.com/repos/CartoDB/cartodb.js"
}
|
{
"id": 390398,
"login": "alonsogarciapablo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/390398?",
"url": "https://api.github.com/users/alonsogarciapablo"
}
|
{
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
}
| 2017-02-20T14:59:16 |
5356163302
|
{"actor":{"display_login":"alonsogarciapablo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/140539995","pull_request_review_id":64633024,"id":140539995,"diff_hunk":"@@ -21,41 +19,35 @@ var LegendViewBase = Backbone.View.extend({\n \n this._loadImages();\n \n- if (this.model.isVisible()) {\n- this.$el.show();\n- } else {\n- this.$el.hide();\n- }\n+ this.model.isVisible()\n+ ? this.$el.show()","path":"src/geo/ui/legends/base/legend-view-base.js","position":29,"original_position":29,"commit_id":"87e58e6e705db41efe37b3b3fe6555c3818aae89","original_commit_id":"cc60c7cc5dfa0c86686c0bd7d83e3f1d0a58f850","user":{"login":"nobuti","id":1366843,"avatar_url":"https://avatars0.githubusercontent.com/u/1366843?v=4","gravatar_id":"","url":"https://api.github.com/users/nobuti","html_url":"https://github.com/nobuti","followers_url":"https://api.github.com/users/nobuti/followers","following_url":"https://api.github.com/users/nobuti/following{/other_user}","gists_url":"https://api.github.com/users/nobuti/gists{/gist_id}","starred_url":"https://api.github.com/users/nobuti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobuti/subscriptions","organizations_url":"https://api.github.com/users/nobuti/orgs","repos_url":"https://api.github.com/users/nobuti/repos","events_url":"https://api.github.com/users/nobuti/events{/privacy}","received_events_url":"https://api.github.com/users/nobuti/received_events","type":"User","site_admin":false},"body":"Or `this.$el.toggle(this.model.isVisible())` but I prefer the way you implemented.","created_at":"2017-09-22T16:35:39Z","updated_at":"2017-09-22T16:35:39Z","html_url":"https://github.com/CartoDB/cartodb.js/pull/1758#discussion_r140539995","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments/140539995"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1758#discussion_r140539995"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758"}},"in_reply_to_id":139629810},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758","id":141786804,"html_url":"https://github.com/CartoDB/cartodb.js/pull/1758","diff_url":"https://github.com/CartoDB/cartodb.js/pull/1758.diff","patch_url":"https://github.com/CartoDB/cartodb.js/pull/1758.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1758","number":1758,"state":"open","locked":false,"title":"Improve legend error","user":{"login":"rubenmoya","id":905225,"avatar_url":"https://avatars3.githubusercontent.com/u/905225?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenmoya","html_url":"https://github.com/rubenmoya","followers_url":"https://api.github.com/users/rubenmoya/followers","following_url":"https://api.github.com/users/rubenmoya/following{/other_user}","gists_url":"https://api.github.com/users/rubenmoya/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenmoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenmoya/subscriptions","organizations_url":"https://api.github.com/users/rubenmoya/orgs","repos_url":"https://api.github.com/users/rubenmoya/repos","events_url":"https://api.github.com/users/rubenmoya/events{/privacy}","received_events_url":"https://api.github.com/users/rubenmoya/received_events","type":"User","site_admin":false},"body":"Related to: #1715\r\n\r\nThe goal was to add an error message related to limits. After some research we realised we can't have limits errors here, since the legends come from `viz.json`, it could only fail when instantiating the map or when parsing CartoCSS, and we're already covered.\r\n\r\nThe only change introduced by this PR is changing the `No data available` styles, and refactor the `legend-view-base.js`.\r\n\r\n\r\n\r\n\r\n","created_at":"2017-09-19T08:30:02Z","updated_at":"2017-09-22T16:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abb69036830c0df000bf6c4842920a8e1f9f20d6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1758/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/87e58e6e705db41efe37b3b3fe6555c3818aae89","head":{"label":"CartoDB:1715-improve-legend-error","ref":"1715-improve-legend-error","sha":"87e58e6e705db41efe37b3b3fe6555c3818aae89","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2017-09-20T16:41:22Z","pushed_at":"2017-09-22T15:57:19Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":30797,"stargazers_count":332,"watchers_count":332,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":245,"mirror_url":null,"open_issues_count":113,"forks":245,"open_issues":113,"watchers":332,"default_branch":"develop"}},"base":{"label":"CartoDB:v4","ref":"v4","sha":"c4a476bdaa7d2df6cc9f9ed2d443ba5d998a2a48","user":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4871551,"name":"cartodb.js","full_name":"CartoDB/cartodb.js","owner":{"login":"CartoDB","id":1799254,"avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/cartodb.js","description":"CartoDB javascript library","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb.js","forks_url":"https://api.github.com/repos/CartoDB/cartodb.js/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb.js/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb.js/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb.js/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb.js/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb.js/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb.js/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb.js/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb.js/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb.js/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb.js/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb.js/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb.js/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb.js/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb.js/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb.js/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb.js/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb.js/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb.js/deployments","created_at":"2012-07-03T11:44:29Z","updated_at":"2017-09-20T16:41:22Z","pushed_at":"2017-09-22T15:57:19Z","git_url":"git://github.com/CartoDB/cartodb.js.git","ssh_url":"git@github.com:CartoDB/cartodb.js.git","clone_url":"https://github.com/CartoDB/cartodb.js.git","svn_url":"https://github.com/CartoDB/cartodb.js","homepage":"","size":30797,"stargazers_count":332,"watchers_count":332,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":245,"mirror_url":null,"open_issues_count":113,"forks":245,"open_issues":113,"watchers":332,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758"},"html":{"href":"https://github.com/CartoDB/cartodb.js/pull/1758"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1758"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/issues/1758/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/pulls/1758/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb.js/statuses/87e58e6e705db41efe37b3b3fe6555c3818aae89"}},"author_association":"MEMBER"}}
|
{
"id": 4871551,
"name": "CartoDB/cartodb.js",
"url": "https://api.github.com/repos/CartoDB/cartodb.js"
}
|
{
"id": 1366843,
"login": "nobuti",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1366843?",
"url": "https://api.github.com/users/nobuti"
}
|
{
"id": 1799254,
"login": "CartoDB",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1799254?",
"url": "https://api.github.com/orgs/CartoDB"
}
| 2017-09-22T16:35:39 |
6625744879
|
{"actor":{"display_login":"nobuti"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DCC-org/documents/pulls/comments/105537274","pull_request_review_id":26426426,"id":105537274,"diff_hunk":"@@ -34,3 +34,19 @@\n \\label{figure:draft2}\n \\end{figure}\n \\FloatBarrier{}\n+\n+\\begin{figure}[tbp]\n+ \\centering\n+ \\includegraphics[width=1.0\\textwidth]{../figures/grafana_dashboard_l.png}","path":"figures.tex","position":7,"original_position":7,"commit_id":"ef42319a953cf3e503cd7e924b97353f5aa9387b","original_commit_id":"ef42319a953cf3e503cd7e924b97353f5aa9387b","user":{"login":"bastelfreak","id":341866,"avatar_url":"https://avatars3.githubusercontent.com/u/341866?v=3","gravatar_id":"","url":"https://api.github.com/users/bastelfreak","html_url":"https://github.com/bastelfreak","followers_url":"https://api.github.com/users/bastelfreak/followers","following_url":"https://api.github.com/users/bastelfreak/following{/other_user}","gists_url":"https://api.github.com/users/bastelfreak/gists{/gist_id}","starred_url":"https://api.github.com/users/bastelfreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bastelfreak/subscriptions","organizations_url":"https://api.github.com/users/bastelfreak/orgs","repos_url":"https://api.github.com/users/bastelfreak/repos","events_url":"https://api.github.com/users/bastelfreak/events{/privacy}","received_events_url":"https://api.github.com/users/bastelfreak/received_events","type":"User","site_admin":false},"body":"[width=1.0\\textwidth] würd ich komplett weglassen. sonst streckt der das auf die breite. gerade bei dem kleinen bild eher doof","created_at":"2017-03-11T16:52:04Z","updated_at":"2017-03-11T16:52:04Z","html_url":"https://github.com/DCC-org/documents/pull/156#discussion_r105537274","pull_request_url":"https://api.github.com/repos/DCC-org/documents/pulls/156","_links":{"self":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/comments/105537274"},"html":{"href":"https://github.com/DCC-org/documents/pull/156#discussion_r105537274"},"pull_request":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/156"}}},"pull_request":{"url":"https://api.github.com/repos/DCC-org/documents/pulls/156","id":110261815,"html_url":"https://github.com/DCC-org/documents/pull/156","diff_url":"https://github.com/DCC-org/documents/pull/156.diff","patch_url":"https://github.com/DCC-org/documents/pull/156.patch","issue_url":"https://api.github.com/repos/DCC-org/documents/issues/156","number":156,"state":"open","locked":false,"title":"add some pictures for section implementation","user":{"login":"Marcellii","id":20370596,"avatar_url":"https://avatars1.githubusercontent.com/u/20370596?v=3","gravatar_id":"","url":"https://api.github.com/users/Marcellii","html_url":"https://github.com/Marcellii","followers_url":"https://api.github.com/users/Marcellii/followers","following_url":"https://api.github.com/users/Marcellii/following{/other_user}","gists_url":"https://api.github.com/users/Marcellii/gists{/gist_id}","starred_url":"https://api.github.com/users/Marcellii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marcellii/subscriptions","organizations_url":"https://api.github.com/users/Marcellii/orgs","repos_url":"https://api.github.com/users/Marcellii/repos","events_url":"https://api.github.com/users/Marcellii/events{/privacy}","received_events_url":"https://api.github.com/users/Marcellii/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-11T14:50:45Z","updated_at":"2017-03-11T16:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8242288ec01e87f46f8cfe8c65a0e034d22014c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DCC-org/documents/pulls/156/commits","review_comments_url":"https://api.github.com/repos/DCC-org/documents/pulls/156/comments","review_comment_url":"https://api.github.com/repos/DCC-org/documents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DCC-org/documents/issues/156/comments","statuses_url":"https://api.github.com/repos/DCC-org/documents/statuses/ef42319a953cf3e503cd7e924b97353f5aa9387b","head":{"label":"DCC-org:automated_installation_grafana","ref":"automated_installation_grafana","sha":"ef42319a953cf3e503cd7e924b97353f5aa9387b","user":{"login":"DCC-org","id":22254761,"avatar_url":"https://avatars2.githubusercontent.com/u/22254761?v=3","gravatar_id":"","url":"https://api.github.com/users/DCC-org","html_url":"https://github.com/DCC-org","followers_url":"https://api.github.com/users/DCC-org/followers","following_url":"https://api.github.com/users/DCC-org/following{/other_user}","gists_url":"https://api.github.com/users/DCC-org/gists{/gist_id}","starred_url":"https://api.github.com/users/DCC-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DCC-org/subscriptions","organizations_url":"https://api.github.com/users/DCC-org/orgs","repos_url":"https://api.github.com/users/DCC-org/repos","events_url":"https://api.github.com/users/DCC-org/events{/privacy}","received_events_url":"https://api.github.com/users/DCC-org/received_events","type":"Organization","site_admin":false},"repo":{"id":68450191,"name":"documents","full_name":"DCC-org/documents","owner":{"login":"DCC-org","id":22254761,"avatar_url":"https://avatars2.githubusercontent.com/u/22254761?v=3","gravatar_id":"","url":"https://api.github.com/users/DCC-org","html_url":"https://github.com/DCC-org","followers_url":"https://api.github.com/users/DCC-org/followers","following_url":"https://api.github.com/users/DCC-org/following{/other_user}","gists_url":"https://api.github.com/users/DCC-org/gists{/gist_id}","starred_url":"https://api.github.com/users/DCC-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DCC-org/subscriptions","organizations_url":"https://api.github.com/users/DCC-org/orgs","repos_url":"https://api.github.com/users/DCC-org/repos","events_url":"https://api.github.com/users/DCC-org/events{/privacy}","received_events_url":"https://api.github.com/users/DCC-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DCC-org/documents","description":null,"fork":false,"url":"https://api.github.com/repos/DCC-org/documents","forks_url":"https://api.github.com/repos/DCC-org/documents/forks","keys_url":"https://api.github.com/repos/DCC-org/documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DCC-org/documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DCC-org/documents/teams","hooks_url":"https://api.github.com/repos/DCC-org/documents/hooks","issue_events_url":"https://api.github.com/repos/DCC-org/documents/issues/events{/number}","events_url":"https://api.github.com/repos/DCC-org/documents/events","assignees_url":"https://api.github.com/repos/DCC-org/documents/assignees{/user}","branches_url":"https://api.github.com/repos/DCC-org/documents/branches{/branch}","tags_url":"https://api.github.com/repos/DCC-org/documents/tags","blobs_url":"https://api.github.com/repos/DCC-org/documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DCC-org/documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DCC-org/documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/DCC-org/documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DCC-org/documents/statuses/{sha}","languages_url":"https://api.github.com/repos/DCC-org/documents/languages","stargazers_url":"https://api.github.com/repos/DCC-org/documents/stargazers","contributors_url":"https://api.github.com/repos/DCC-org/documents/contributors","subscribers_url":"https://api.github.com/repos/DCC-org/documents/subscribers","subscription_url":"https://api.github.com/repos/DCC-org/documents/subscription","commits_url":"https://api.github.com/repos/DCC-org/documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/DCC-org/documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/DCC-org/documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/DCC-org/documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/DCC-org/documents/contents/{+path}","compare_url":"https://api.github.com/repos/DCC-org/documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DCC-org/documents/merges","archive_url":"https://api.github.com/repos/DCC-org/documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DCC-org/documents/downloads","issues_url":"https://api.github.com/repos/DCC-org/documents/issues{/number}","pulls_url":"https://api.github.com/repos/DCC-org/documents/pulls{/number}","milestones_url":"https://api.github.com/repos/DCC-org/documents/milestones{/number}","notifications_url":"https://api.github.com/repos/DCC-org/documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DCC-org/documents/labels{/name}","releases_url":"https://api.github.com/repos/DCC-org/documents/releases{/id}","deployments_url":"https://api.github.com/repos/DCC-org/documents/deployments","created_at":"2016-09-17T12:14:34Z","updated_at":"2016-09-17T12:53:09Z","pushed_at":"2017-03-11T16:46:16Z","git_url":"git://github.com/DCC-org/documents.git","ssh_url":"git@github.com:DCC-org/documents.git","clone_url":"https://github.com/DCC-org/documents.git","svn_url":"https://github.com/DCC-org/documents","homepage":null,"size":1310,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"DCC-org:master","ref":"master","sha":"d3577e6c13651f86b18d1c14fc6a44a8849f5bb4","user":{"login":"DCC-org","id":22254761,"avatar_url":"https://avatars2.githubusercontent.com/u/22254761?v=3","gravatar_id":"","url":"https://api.github.com/users/DCC-org","html_url":"https://github.com/DCC-org","followers_url":"https://api.github.com/users/DCC-org/followers","following_url":"https://api.github.com/users/DCC-org/following{/other_user}","gists_url":"https://api.github.com/users/DCC-org/gists{/gist_id}","starred_url":"https://api.github.com/users/DCC-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DCC-org/subscriptions","organizations_url":"https://api.github.com/users/DCC-org/orgs","repos_url":"https://api.github.com/users/DCC-org/repos","events_url":"https://api.github.com/users/DCC-org/events{/privacy}","received_events_url":"https://api.github.com/users/DCC-org/received_events","type":"Organization","site_admin":false},"repo":{"id":68450191,"name":"documents","full_name":"DCC-org/documents","owner":{"login":"DCC-org","id":22254761,"avatar_url":"https://avatars2.githubusercontent.com/u/22254761?v=3","gravatar_id":"","url":"https://api.github.com/users/DCC-org","html_url":"https://github.com/DCC-org","followers_url":"https://api.github.com/users/DCC-org/followers","following_url":"https://api.github.com/users/DCC-org/following{/other_user}","gists_url":"https://api.github.com/users/DCC-org/gists{/gist_id}","starred_url":"https://api.github.com/users/DCC-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DCC-org/subscriptions","organizations_url":"https://api.github.com/users/DCC-org/orgs","repos_url":"https://api.github.com/users/DCC-org/repos","events_url":"https://api.github.com/users/DCC-org/events{/privacy}","received_events_url":"https://api.github.com/users/DCC-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DCC-org/documents","description":null,"fork":false,"url":"https://api.github.com/repos/DCC-org/documents","forks_url":"https://api.github.com/repos/DCC-org/documents/forks","keys_url":"https://api.github.com/repos/DCC-org/documents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DCC-org/documents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DCC-org/documents/teams","hooks_url":"https://api.github.com/repos/DCC-org/documents/hooks","issue_events_url":"https://api.github.com/repos/DCC-org/documents/issues/events{/number}","events_url":"https://api.github.com/repos/DCC-org/documents/events","assignees_url":"https://api.github.com/repos/DCC-org/documents/assignees{/user}","branches_url":"https://api.github.com/repos/DCC-org/documents/branches{/branch}","tags_url":"https://api.github.com/repos/DCC-org/documents/tags","blobs_url":"https://api.github.com/repos/DCC-org/documents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DCC-org/documents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DCC-org/documents/git/refs{/sha}","trees_url":"https://api.github.com/repos/DCC-org/documents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DCC-org/documents/statuses/{sha}","languages_url":"https://api.github.com/repos/DCC-org/documents/languages","stargazers_url":"https://api.github.com/repos/DCC-org/documents/stargazers","contributors_url":"https://api.github.com/repos/DCC-org/documents/contributors","subscribers_url":"https://api.github.com/repos/DCC-org/documents/subscribers","subscription_url":"https://api.github.com/repos/DCC-org/documents/subscription","commits_url":"https://api.github.com/repos/DCC-org/documents/commits{/sha}","git_commits_url":"https://api.github.com/repos/DCC-org/documents/git/commits{/sha}","comments_url":"https://api.github.com/repos/DCC-org/documents/comments{/number}","issue_comment_url":"https://api.github.com/repos/DCC-org/documents/issues/comments{/number}","contents_url":"https://api.github.com/repos/DCC-org/documents/contents/{+path}","compare_url":"https://api.github.com/repos/DCC-org/documents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DCC-org/documents/merges","archive_url":"https://api.github.com/repos/DCC-org/documents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DCC-org/documents/downloads","issues_url":"https://api.github.com/repos/DCC-org/documents/issues{/number}","pulls_url":"https://api.github.com/repos/DCC-org/documents/pulls{/number}","milestones_url":"https://api.github.com/repos/DCC-org/documents/milestones{/number}","notifications_url":"https://api.github.com/repos/DCC-org/documents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DCC-org/documents/labels{/name}","releases_url":"https://api.github.com/repos/DCC-org/documents/releases{/id}","deployments_url":"https://api.github.com/repos/DCC-org/documents/deployments","created_at":"2016-09-17T12:14:34Z","updated_at":"2016-09-17T12:53:09Z","pushed_at":"2017-03-11T16:46:16Z","git_url":"git://github.com/DCC-org/documents.git","ssh_url":"git@github.com:DCC-org/documents.git","clone_url":"https://github.com/DCC-org/documents.git","svn_url":"https://github.com/DCC-org/documents","homepage":null,"size":1310,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/156"},"html":{"href":"https://github.com/DCC-org/documents/pull/156"},"issue":{"href":"https://api.github.com/repos/DCC-org/documents/issues/156"},"comments":{"href":"https://api.github.com/repos/DCC-org/documents/issues/156/comments"},"review_comments":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/156/comments"},"review_comment":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DCC-org/documents/pulls/156/commits"},"statuses":{"href":"https://api.github.com/repos/DCC-org/documents/statuses/ef42319a953cf3e503cd7e924b97353f5aa9387b"}}}}
|
{
"id": 68450191,
"name": "DCC-org/documents",
"url": "https://api.github.com/repos/DCC-org/documents"
}
|
{
"id": 341866,
"login": "bastelfreak",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/341866?",
"url": "https://api.github.com/users/bastelfreak"
}
|
{
"id": 22254761,
"login": "DCC-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22254761?",
"url": "https://api.github.com/orgs/DCC-org"
}
| 2017-03-11T16:52:04 |
5476019262
|
{"actor":{"display_login":"bastelfreak"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/95211727","pull_request_review_id":15759631,"id":95211727,"diff_hunk":"@@ -0,0 +1,10 @@\n+{\n+ \"maintainer\": \"help@datadoghq.com\",\n+ \"manifest_version\": \"0.1.0\",","path":"etcd/manifest.json","position":3,"original_position":3,"commit_id":"af6f7b902e8562546e936aa2890f6f2b7c6929c7","original_commit_id":"d13557cf76d08d4b450d254492f33594da621112","user":{"login":"hkaj","id":5287287,"avatar_url":"https://avatars.githubusercontent.com/u/5287287?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaj","html_url":"https://github.com/hkaj","followers_url":"https://api.github.com/users/hkaj/followers","following_url":"https://api.github.com/users/hkaj/following{/other_user}","gists_url":"https://api.github.com/users/hkaj/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaj/subscriptions","organizations_url":"https://api.github.com/users/hkaj/orgs","repos_url":"https://api.github.com/users/hkaj/repos","events_url":"https://api.github.com/users/hkaj/events{/privacy}","received_events_url":"https://api.github.com/users/hkaj/received_events","type":"User","site_admin":false},"body":"OK, then my comment on the apache manifest is on the wrong line, \"manifest_version\": 1` should be removed instead.","created_at":"2017-01-09T18:12:18Z","updated_at":"2017-01-09T18:12:18Z","html_url":"https://github.com/DataDog/integrations-core/pull/41#discussion_r95211727","pull_request_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments/95211727"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/41#discussion_r95211727"},"pull_request":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/41"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/41","id":92424464,"html_url":"https://github.com/DataDog/integrations-core/pull/41","diff_url":"https://github.com/DataDog/integrations-core/pull/41.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/41.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/41","number":41,"state":"open","locked":false,"title":"[etcd] adds etcd","user":{"login":"gmmeyer","id":3253673,"avatar_url":"https://avatars.githubusercontent.com/u/3253673?v=3","gravatar_id":"","url":"https://api.github.com/users/gmmeyer","html_url":"https://github.com/gmmeyer","followers_url":"https://api.github.com/users/gmmeyer/followers","following_url":"https://api.github.com/users/gmmeyer/following{/other_user}","gists_url":"https://api.github.com/users/gmmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/gmmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmmeyer/subscriptions","organizations_url":"https://api.github.com/users/gmmeyer/orgs","repos_url":"https://api.github.com/users/gmmeyer/repos","events_url":"https://api.github.com/users/gmmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/gmmeyer/received_events","type":"User","site_admin":false},"body":"","created_at":"2016-11-04T22:15:55Z","updated_at":"2017-01-09T18:12:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"293e3b552278fb4c4ededf36d2975124cd8313a3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/41/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/41/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/41/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/af6f7b902e8562546e936aa2890f6f2b7c6929c7","head":{"label":"DataDog:greg/etcd","ref":"greg/etcd","sha":"af6f7b902e8562546e936aa2890f6f2b7c6929c7","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2016-12-19T21:27:11Z","pushed_at":"2017-01-09T18:10:13Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":797,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":42,"forks":0,"open_issues":42,"watchers":5,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"4e115e0963407f06ce9ba5cf9c53f4eb21fa4b52","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars.githubusercontent.com/u/365230?v=3","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2016-12-19T21:27:11Z","pushed_at":"2017-01-09T18:10:13Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":797,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":42,"forks":0,"open_issues":42,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/41"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/41"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/41"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/af6f7b902e8562546e936aa2890f6f2b7c6929c7"}}}}
|
{
"id": 47203045,
"name": "DataDog/integrations-core",
"url": "https://api.github.com/repos/DataDog/integrations-core"
}
|
{
"id": 5287287,
"login": "hkaj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5287287?",
"url": "https://api.github.com/users/hkaj"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2017-01-09T18:12:18 |
5124125636
|
{"actor":{"display_login":"hkaj"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/documentation/pulls/comments/158826217","pull_request_review_id":85687017,"id":158826217,"diff_hunk":"@@ -235,10 +237,12 @@ logs:\n \n ### Multi-line\n \n-If your logs are not sent in JSON and you want to aggregate several lines into one single log, you can configure the agent to detect a new log using a specific regex pattern instead of having one log per line. This is accomplished by using the `log_processing_rules` parameter in your configuration file with the **multi_line** `type`.\n+If your logs are not sent in JSON and you want to aggregate several lines into one single log, configure the Datadog Agent to detect a new log using a specific regex pattern instead of having one log per line. \n+\n+This is accomplished by using the `log_processing_rules` parameter in your configuration file with the **multi_line** `type`.\n \n This aggregates all lines into one single log until the given pattern is detected again. This is especially useful for database logs and stack traces.\n-Example: Every postgres log line starts with a timestamp in `YYYY-dd-mm` format. The below lines would be sent as two logs.\n+Example: Every Postgres log line starts with a timestamp with `YYYY-dd-mm` format. The below lines would be sent as two logs.","path":"content/logs/_index.md","position":29,"original_position":29,"commit_id":"f0b65b229fecef3267315a2908b4785568cacab4","original_commit_id":"7fa02a847dd790925acf54a8da1fd23d5dd854f6","user":{"login":"l0k0ms","id":3624790,"avatar_url":"https://avatars3.githubusercontent.com/u/3624790?v=4","gravatar_id":"","url":"https://api.github.com/users/l0k0ms","html_url":"https://github.com/l0k0ms","followers_url":"https://api.github.com/users/l0k0ms/followers","following_url":"https://api.github.com/users/l0k0ms/following{/other_user}","gists_url":"https://api.github.com/users/l0k0ms/gists{/gist_id}","starred_url":"https://api.github.com/users/l0k0ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0k0ms/subscriptions","organizations_url":"https://api.github.com/users/l0k0ms/orgs","repos_url":"https://api.github.com/users/l0k0ms/repos","events_url":"https://api.github.com/users/l0k0ms/events{/privacy}","received_events_url":"https://api.github.com/users/l0k0ms/received_events","type":"User","site_admin":false},"body":"👍 ","created_at":"2017-12-27T15:13:10Z","updated_at":"2017-12-27T15:13:10Z","html_url":"https://github.com/DataDog/documentation/pull/1879#discussion_r158826217","pull_request_url":"https://api.github.com/repos/DataDog/documentation/pulls/1879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/comments/158826217"},"html":{"href":"https://github.com/DataDog/documentation/pull/1879#discussion_r158826217"},"pull_request":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/1879"}},"in_reply_to_id":158823868},"pull_request":{"url":"https://api.github.com/repos/DataDog/documentation/pulls/1879","id":160255851,"html_url":"https://github.com/DataDog/documentation/pull/1879","diff_url":"https://github.com/DataDog/documentation/pull/1879.diff","patch_url":"https://github.com/DataDog/documentation/pull/1879.patch","issue_url":"https://api.github.com/repos/DataDog/documentation/issues/1879","number":1879,"state":"open","locked":false,"title":"add wildcard section in the log documentation","user":{"login":"NBParis","id":26930812,"avatar_url":"https://avatars1.githubusercontent.com/u/26930812?v=4","gravatar_id":"","url":"https://api.github.com/users/NBParis","html_url":"https://github.com/NBParis","followers_url":"https://api.github.com/users/NBParis/followers","following_url":"https://api.github.com/users/NBParis/following{/other_user}","gists_url":"https://api.github.com/users/NBParis/gists{/gist_id}","starred_url":"https://api.github.com/users/NBParis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NBParis/subscriptions","organizations_url":"https://api.github.com/users/NBParis/orgs","repos_url":"https://api.github.com/users/NBParis/repos","events_url":"https://api.github.com/users/NBParis/events{/privacy}","received_events_url":"https://api.github.com/users/NBParis/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nNew wildcard section and a couple grammar fix on similar functionnalities\r\n### Motivation\r\n\r\nNew feature implies new documentation section.\r\n\r\n","created_at":"2017-12-27T14:21:13Z","updated_at":"2017-12-27T15:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f052c1a0f722f5af33958de718b73a790dfa287e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"l0k0ms","id":3624790,"avatar_url":"https://avatars3.githubusercontent.com/u/3624790?v=4","gravatar_id":"","url":"https://api.github.com/users/l0k0ms","html_url":"https://github.com/l0k0ms","followers_url":"https://api.github.com/users/l0k0ms/followers","following_url":"https://api.github.com/users/l0k0ms/following{/other_user}","gists_url":"https://api.github.com/users/l0k0ms/gists{/gist_id}","starred_url":"https://api.github.com/users/l0k0ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0k0ms/subscriptions","organizations_url":"https://api.github.com/users/l0k0ms/orgs","repos_url":"https://api.github.com/users/l0k0ms/repos","events_url":"https://api.github.com/users/l0k0ms/events{/privacy}","received_events_url":"https://api.github.com/users/l0k0ms/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/documentation/pulls/1879/commits","review_comments_url":"https://api.github.com/repos/DataDog/documentation/pulls/1879/comments","review_comment_url":"https://api.github.com/repos/DataDog/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/documentation/issues/1879/comments","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/f0b65b229fecef3267315a2908b4785568cacab4","head":{"label":"DataDog:nils/log-wildcard","ref":"nils/log-wildcard","sha":"f0b65b229fecef3267315a2908b4785568cacab4","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":2967233,"name":"documentation","full_name":"DataDog/documentation","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/documentation","description":"The source for Datadog's documentation site.","fork":false,"url":"https://api.github.com/repos/DataDog/documentation","forks_url":"https://api.github.com/repos/DataDog/documentation/forks","keys_url":"https://api.github.com/repos/DataDog/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/documentation/teams","hooks_url":"https://api.github.com/repos/DataDog/documentation/hooks","issue_events_url":"https://api.github.com/repos/DataDog/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/documentation/events","assignees_url":"https://api.github.com/repos/DataDog/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/documentation/tags","blobs_url":"https://api.github.com/repos/DataDog/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/documentation/languages","stargazers_url":"https://api.github.com/repos/DataDog/documentation/stargazers","contributors_url":"https://api.github.com/repos/DataDog/documentation/contributors","subscribers_url":"https://api.github.com/repos/DataDog/documentation/subscribers","subscription_url":"https://api.github.com/repos/DataDog/documentation/subscription","commits_url":"https://api.github.com/repos/DataDog/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/documentation/merges","archive_url":"https://api.github.com/repos/DataDog/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/documentation/downloads","issues_url":"https://api.github.com/repos/DataDog/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/documentation/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/documentation/deployments","created_at":"2011-12-12T20:32:29Z","updated_at":"2017-12-27T08:54:40Z","pushed_at":"2017-12-27T14:54:51Z","git_url":"git://github.com/DataDog/documentation.git","ssh_url":"git@github.com:DataDog/documentation.git","clone_url":"https://github.com/DataDog/documentation.git","svn_url":"https://github.com/DataDog/documentation","homepage":"http://docs.datadoghq.com","size":188441,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":87,"open_issues":6,"watchers":38,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"54dd6f02e6a0bc75a5da28f8a79c59b8b3d06596","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":2967233,"name":"documentation","full_name":"DataDog/documentation","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/documentation","description":"The source for Datadog's documentation site.","fork":false,"url":"https://api.github.com/repos/DataDog/documentation","forks_url":"https://api.github.com/repos/DataDog/documentation/forks","keys_url":"https://api.github.com/repos/DataDog/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/documentation/teams","hooks_url":"https://api.github.com/repos/DataDog/documentation/hooks","issue_events_url":"https://api.github.com/repos/DataDog/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/documentation/events","assignees_url":"https://api.github.com/repos/DataDog/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/documentation/tags","blobs_url":"https://api.github.com/repos/DataDog/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/documentation/languages","stargazers_url":"https://api.github.com/repos/DataDog/documentation/stargazers","contributors_url":"https://api.github.com/repos/DataDog/documentation/contributors","subscribers_url":"https://api.github.com/repos/DataDog/documentation/subscribers","subscription_url":"https://api.github.com/repos/DataDog/documentation/subscription","commits_url":"https://api.github.com/repos/DataDog/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/documentation/merges","archive_url":"https://api.github.com/repos/DataDog/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/documentation/downloads","issues_url":"https://api.github.com/repos/DataDog/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/documentation/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/documentation/deployments","created_at":"2011-12-12T20:32:29Z","updated_at":"2017-12-27T08:54:40Z","pushed_at":"2017-12-27T14:54:51Z","git_url":"git://github.com/DataDog/documentation.git","ssh_url":"git@github.com:DataDog/documentation.git","clone_url":"https://github.com/DataDog/documentation.git","svn_url":"https://github.com/DataDog/documentation","homepage":"http://docs.datadoghq.com","size":188441,"stargazers_count":38,"watchers_count":38,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":87,"open_issues":6,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/1879"},"html":{"href":"https://github.com/DataDog/documentation/pull/1879"},"issue":{"href":"https://api.github.com/repos/DataDog/documentation/issues/1879"},"comments":{"href":"https://api.github.com/repos/DataDog/documentation/issues/1879/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/1879/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/documentation/pulls/1879/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/documentation/statuses/f0b65b229fecef3267315a2908b4785568cacab4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2967233,
"name": "DataDog/documentation",
"url": "https://api.github.com/repos/DataDog/documentation"
}
|
{
"id": 3624790,
"login": "l0k0ms",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3624790?",
"url": "https://api.github.com/users/l0k0ms"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2017-12-27T15:13:10 |
7034157547
|
{"actor":{"display_login":"l0k0ms"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/144296682","pull_request_review_id":68933395,"id":144296682,"diff_hunk":"@@ -53,7 +53,10 @@ func GetPayload() (metadata.Payload, error) {\n \tif ok && apiErr.Code == http.StatusNotFound {\n \t\tdr = &appsv1beta1.DeploymentList{}\n \t} else if err != nil {\n-\t\treturn nil, fmt.Errorf(\"failed to get deployments: %s\", err)\n+\t\t// Allow Deployments API to fail, it's not available in all version and we\n+\t\t// can also parse this data from the replica-set name on the backend.\n+\t\tlog.Warnf(\"Failed to retrieve Kubernetes deployments: %s\", err)","path":"pkg/metadata/kubernetes/kubernetes.go","position":7,"original_position":7,"commit_id":"c451337e220b1f2c3b9d12f0b6adc4f958e95c88","original_commit_id":"c451337e220b1f2c3b9d12f0b6adc4f958e95c88","user":{"login":"masci","id":7241,"avatar_url":"https://avatars3.githubusercontent.com/u/7241?v=4","gravatar_id":"","url":"https://api.github.com/users/masci","html_url":"https://github.com/masci","followers_url":"https://api.github.com/users/masci/followers","following_url":"https://api.github.com/users/masci/following{/other_user}","gists_url":"https://api.github.com/users/masci/gists{/gist_id}","starred_url":"https://api.github.com/users/masci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masci/subscriptions","organizations_url":"https://api.github.com/users/masci/orgs","repos_url":"https://api.github.com/users/masci/repos","events_url":"https://api.github.com/users/masci/events{/privacy}","received_events_url":"https://api.github.com/users/masci/received_events","type":"User","site_admin":false},"body":"didn't notice but `log` package was not imported","created_at":"2017-10-12T13:59:08Z","updated_at":"2017-10-12T13:59:14Z","html_url":"https://github.com/DataDog/datadog-agent/pull/695#discussion_r144296682","pull_request_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments/144296682"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/695#discussion_r144296682"},"pull_request":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695"}}},"pull_request":{"url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695","id":145817974,"html_url":"https://github.com/DataDog/datadog-agent/pull/695","diff_url":"https://github.com/DataDog/datadog-agent/pull/695.diff","patch_url":"https://github.com/DataDog/datadog-agent/pull/695.patch","issue_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/695","number":695,"state":"open","locked":false,"title":"[k8s] Update library, allow deployment API to fail","user":{"login":"conorbranagan","id":472446,"avatar_url":"https://avatars0.githubusercontent.com/u/472446?v=4","gravatar_id":"","url":"https://api.github.com/users/conorbranagan","html_url":"https://github.com/conorbranagan","followers_url":"https://api.github.com/users/conorbranagan/followers","following_url":"https://api.github.com/users/conorbranagan/following{/other_user}","gists_url":"https://api.github.com/users/conorbranagan/gists{/gist_id}","starred_url":"https://api.github.com/users/conorbranagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conorbranagan/subscriptions","organizations_url":"https://api.github.com/users/conorbranagan/orgs","repos_url":"https://api.github.com/users/conorbranagan/repos","events_url":"https://api.github.com/users/conorbranagan/events{/privacy}","received_events_url":"https://api.github.com/users/conorbranagan/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nUpdate k8s library, allow deployment API to fail.\r\n\r\n* The latest version of the library includes better logging for errors\r\nwhich include the status code. See https://github.com/ericchiang/k8s/pull/58\r\n* The deployment API is unavailable in older versions of Kubernetes. We\r\ndon't really _need_ this information since we can parse it from the\r\nReplicaSet name.\r\n\r\n### Motivation\r\n\r\nWe've had a couple users (https://trello.com/c/5VjK5smo/560-braintree-having-trouble-with-custom-api-server-port-for-kubernetes, https://trello.com/c/gMllhQNi/605-k8-side-bar-filters) who hit an error in deployments API. Right now the first case at least ended up being an issue with missing RBAC configuration. The update to the library should provide some additional context here.\r\n","created_at":"2017-10-10T22:35:30Z","updated_at":"2017-10-12T13:59:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef0a3aecacf24fc28d817ee5f4c51dda1fdbb795","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695/commits","review_comments_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695/comments","review_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/695/comments","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/c451337e220b1f2c3b9d12f0b6adc4f958e95c88","head":{"label":"DataDog:conor/k8s-deployments","ref":"conor/k8s-deployments","sha":"c451337e220b1f2c3b9d12f0b6adc4f958e95c88","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2017-10-04T15:34:06Z","pushed_at":"2017-10-12T13:11:05Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":14444,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":20,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"543bdc8ee7e27692e5b632688304040b31d9b6f2","user":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":49970739,"name":"datadog-agent","full_name":"DataDog/datadog-agent","owner":{"login":"DataDog","id":365230,"avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/datadog-agent","description":"Datadog Agent ","fork":false,"url":"https://api.github.com/repos/DataDog/datadog-agent","forks_url":"https://api.github.com/repos/DataDog/datadog-agent/forks","keys_url":"https://api.github.com/repos/DataDog/datadog-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/datadog-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/datadog-agent/teams","hooks_url":"https://api.github.com/repos/DataDog/datadog-agent/hooks","issue_events_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/datadog-agent/events","assignees_url":"https://api.github.com/repos/DataDog/datadog-agent/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/datadog-agent/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/datadog-agent/tags","blobs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/datadog-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/datadog-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/datadog-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/datadog-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/datadog-agent/languages","stargazers_url":"https://api.github.com/repos/DataDog/datadog-agent/stargazers","contributors_url":"https://api.github.com/repos/DataDog/datadog-agent/contributors","subscribers_url":"https://api.github.com/repos/DataDog/datadog-agent/subscribers","subscription_url":"https://api.github.com/repos/DataDog/datadog-agent/subscription","commits_url":"https://api.github.com/repos/DataDog/datadog-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/datadog-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/datadog-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/datadog-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/datadog-agent/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/datadog-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/datadog-agent/merges","archive_url":"https://api.github.com/repos/DataDog/datadog-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/datadog-agent/downloads","issues_url":"https://api.github.com/repos/DataDog/datadog-agent/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/datadog-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/datadog-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/datadog-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/datadog-agent/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/datadog-agent/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/datadog-agent/deployments","created_at":"2016-01-19T17:40:41Z","updated_at":"2017-10-04T15:34:06Z","pushed_at":"2017-10-12T13:11:05Z","git_url":"git://github.com/DataDog/datadog-agent.git","ssh_url":"git@github.com:DataDog/datadog-agent.git","clone_url":"https://github.com/DataDog/datadog-agent.git","svn_url":"https://github.com/DataDog/datadog-agent","homepage":"https://docs.datadoghq.com/","size":14444,"stargazers_count":20,"watchers_count":20,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695"},"html":{"href":"https://github.com/DataDog/datadog-agent/pull/695"},"issue":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/695"},"comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/issues/695/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/datadog-agent/pulls/695/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/datadog-agent/statuses/c451337e220b1f2c3b9d12f0b6adc4f958e95c88"}},"author_association":"MEMBER"}}
|
{
"id": 49970739,
"name": "DataDog/datadog-agent",
"url": "https://api.github.com/repos/DataDog/datadog-agent"
}
|
{
"id": 7241,
"login": "masci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7241?",
"url": "https://api.github.com/users/masci"
}
|
{
"id": 365230,
"login": "DataDog",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/365230?",
"url": "https://api.github.com/orgs/DataDog"
}
| 2017-10-12T13:59:08 |
6708248242
|
{"actor":{"display_login":"masci"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/IserveU/IserveU/pulls/comments/114123282","pull_request_review_id":35564557,"id":114123282,"diff_hunk":"@@ -0,0 +1,69 @@\n+'use strict';\n+(function(window, angular, undefined) {\n+\n+ angular\n+ .module('iserveu')\n+ .service('localStorageManager', ['$http', localStorageManager]);\n+\n+ /** @ngInject */\n+ function localStorageManager($http) {\n+ \n+ var vm = this;\n+\n+\n+ this.clear = function() {\n+\n+\n+ console.log(\"clear\");\n+ localStorage.clear();\n+ };\n+ \n+ /* Create a function that clears customized stuff.\n+ */\n+ this.logout = function (){\n+ console.log('logout');","path":"public/app/shared/services/localstoragemanager.svc.js","position":24,"original_position":24,"commit_id":"331672d981041a89af5c1656db71d688642f4fdf","original_commit_id":"331672d981041a89af5c1656db71d688642f4fdf","user":{"login":"jessicaquynh","id":12400507,"avatar_url":"https://avatars0.githubusercontent.com/u/12400507?v=3","gravatar_id":"","url":"https://api.github.com/users/jessicaquynh","html_url":"https://github.com/jessicaquynh","followers_url":"https://api.github.com/users/jessicaquynh/followers","following_url":"https://api.github.com/users/jessicaquynh/following{/other_user}","gists_url":"https://api.github.com/users/jessicaquynh/gists{/gist_id}","starred_url":"https://api.github.com/users/jessicaquynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessicaquynh/subscriptions","organizations_url":"https://api.github.com/users/jessicaquynh/orgs","repos_url":"https://api.github.com/users/jessicaquynh/repos","events_url":"https://api.github.com/users/jessicaquynh/events{/privacy}","received_events_url":"https://api.github.com/users/jessicaquynh/received_events","type":"User","site_admin":false},"body":"^","created_at":"2017-05-01T13:06:35Z","updated_at":"2017-05-01T13:20:41Z","html_url":"https://github.com/IserveU/IserveU/pull/754#discussion_r114123282","pull_request_url":"https://api.github.com/repos/IserveU/IserveU/pulls/754","_links":{"self":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/comments/114123282"},"html":{"href":"https://github.com/IserveU/IserveU/pull/754#discussion_r114123282"},"pull_request":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/754"}}},"pull_request":{"url":"https://api.github.com/repos/IserveU/IserveU/pulls/754","id":118326291,"html_url":"https://github.com/IserveU/IserveU/pull/754","diff_url":"https://github.com/IserveU/IserveU/pull/754.diff","patch_url":"https://github.com/IserveU/IserveU/pull/754.patch","issue_url":"https://api.github.com/repos/IserveU/IserveU/issues/754","number":754,"state":"open","locked":false,"title":"Setup local storage manager","user":{"login":"psaunders","id":424956,"avatar_url":"https://avatars2.githubusercontent.com/u/424956?v=3","gravatar_id":"","url":"https://api.github.com/users/psaunders","html_url":"https://github.com/psaunders","followers_url":"https://api.github.com/users/psaunders/followers","following_url":"https://api.github.com/users/psaunders/following{/other_user}","gists_url":"https://api.github.com/users/psaunders/gists{/gist_id}","starred_url":"https://api.github.com/users/psaunders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psaunders/subscriptions","organizations_url":"https://api.github.com/users/psaunders/orgs","repos_url":"https://api.github.com/users/psaunders/repos","events_url":"https://api.github.com/users/psaunders/events{/privacy}","received_events_url":"https://api.github.com/users/psaunders/received_events","type":"User","site_admin":false},"body":"Creates a local storage manager\r\nFixes bugs with the terms coming up","created_at":"2017-04-30T20:47:29Z","updated_at":"2017-05-01T13:20:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24b2909952fd67d7ce8fcfcc3e8e30b949a8b2fc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/IserveU/IserveU/pulls/754/commits","review_comments_url":"https://api.github.com/repos/IserveU/IserveU/pulls/754/comments","review_comment_url":"https://api.github.com/repos/IserveU/IserveU/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IserveU/IserveU/issues/754/comments","statuses_url":"https://api.github.com/repos/IserveU/IserveU/statuses/331672d981041a89af5c1656db71d688642f4fdf","head":{"label":"IserveU:accept_terms_and_conditions","ref":"accept_terms_and_conditions","sha":"331672d981041a89af5c1656db71d688642f4fdf","user":{"login":"IserveU","id":11811366,"avatar_url":"https://avatars1.githubusercontent.com/u/11811366?v=3","gravatar_id":"","url":"https://api.github.com/users/IserveU","html_url":"https://github.com/IserveU","followers_url":"https://api.github.com/users/IserveU/followers","following_url":"https://api.github.com/users/IserveU/following{/other_user}","gists_url":"https://api.github.com/users/IserveU/gists{/gist_id}","starred_url":"https://api.github.com/users/IserveU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IserveU/subscriptions","organizations_url":"https://api.github.com/users/IserveU/orgs","repos_url":"https://api.github.com/users/IserveU/repos","events_url":"https://api.github.com/users/IserveU/events{/privacy}","received_events_url":"https://api.github.com/users/IserveU/received_events","type":"Organization","site_admin":false},"repo":{"id":33411957,"name":"IserveU","full_name":"IserveU/IserveU","owner":{"login":"IserveU","id":11811366,"avatar_url":"https://avatars1.githubusercontent.com/u/11811366?v=3","gravatar_id":"","url":"https://api.github.com/users/IserveU","html_url":"https://github.com/IserveU","followers_url":"https://api.github.com/users/IserveU/followers","following_url":"https://api.github.com/users/IserveU/following{/other_user}","gists_url":"https://api.github.com/users/IserveU/gists{/gist_id}","starred_url":"https://api.github.com/users/IserveU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IserveU/subscriptions","organizations_url":"https://api.github.com/users/IserveU/orgs","repos_url":"https://api.github.com/users/IserveU/repos","events_url":"https://api.github.com/users/IserveU/events{/privacy}","received_events_url":"https://api.github.com/users/IserveU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IserveU/IserveU","description":"eDemocracy Tool","fork":false,"url":"https://api.github.com/repos/IserveU/IserveU","forks_url":"https://api.github.com/repos/IserveU/IserveU/forks","keys_url":"https://api.github.com/repos/IserveU/IserveU/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IserveU/IserveU/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IserveU/IserveU/teams","hooks_url":"https://api.github.com/repos/IserveU/IserveU/hooks","issue_events_url":"https://api.github.com/repos/IserveU/IserveU/issues/events{/number}","events_url":"https://api.github.com/repos/IserveU/IserveU/events","assignees_url":"https://api.github.com/repos/IserveU/IserveU/assignees{/user}","branches_url":"https://api.github.com/repos/IserveU/IserveU/branches{/branch}","tags_url":"https://api.github.com/repos/IserveU/IserveU/tags","blobs_url":"https://api.github.com/repos/IserveU/IserveU/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IserveU/IserveU/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IserveU/IserveU/git/refs{/sha}","trees_url":"https://api.github.com/repos/IserveU/IserveU/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IserveU/IserveU/statuses/{sha}","languages_url":"https://api.github.com/repos/IserveU/IserveU/languages","stargazers_url":"https://api.github.com/repos/IserveU/IserveU/stargazers","contributors_url":"https://api.github.com/repos/IserveU/IserveU/contributors","subscribers_url":"https://api.github.com/repos/IserveU/IserveU/subscribers","subscription_url":"https://api.github.com/repos/IserveU/IserveU/subscription","commits_url":"https://api.github.com/repos/IserveU/IserveU/commits{/sha}","git_commits_url":"https://api.github.com/repos/IserveU/IserveU/git/commits{/sha}","comments_url":"https://api.github.com/repos/IserveU/IserveU/comments{/number}","issue_comment_url":"https://api.github.com/repos/IserveU/IserveU/issues/comments{/number}","contents_url":"https://api.github.com/repos/IserveU/IserveU/contents/{+path}","compare_url":"https://api.github.com/repos/IserveU/IserveU/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IserveU/IserveU/merges","archive_url":"https://api.github.com/repos/IserveU/IserveU/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IserveU/IserveU/downloads","issues_url":"https://api.github.com/repos/IserveU/IserveU/issues{/number}","pulls_url":"https://api.github.com/repos/IserveU/IserveU/pulls{/number}","milestones_url":"https://api.github.com/repos/IserveU/IserveU/milestones{/number}","notifications_url":"https://api.github.com/repos/IserveU/IserveU/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IserveU/IserveU/labels{/name}","releases_url":"https://api.github.com/repos/IserveU/IserveU/releases{/id}","deployments_url":"https://api.github.com/repos/IserveU/IserveU/deployments","created_at":"2015-04-04T16:28:07Z","updated_at":"2017-04-30T16:35:55Z","pushed_at":"2017-05-01T00:51:10Z","git_url":"git://github.com/IserveU/IserveU.git","ssh_url":"git@github.com:IserveU/IserveU.git","clone_url":"https://github.com/IserveU/IserveU.git","svn_url":"https://github.com/IserveU/IserveU","homepage":null,"size":40905,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":9,"default_branch":"master"}},"base":{"label":"IserveU:master","ref":"master","sha":"d2f621f6d9a5f17478ca302464da5b59a2515e93","user":{"login":"IserveU","id":11811366,"avatar_url":"https://avatars1.githubusercontent.com/u/11811366?v=3","gravatar_id":"","url":"https://api.github.com/users/IserveU","html_url":"https://github.com/IserveU","followers_url":"https://api.github.com/users/IserveU/followers","following_url":"https://api.github.com/users/IserveU/following{/other_user}","gists_url":"https://api.github.com/users/IserveU/gists{/gist_id}","starred_url":"https://api.github.com/users/IserveU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IserveU/subscriptions","organizations_url":"https://api.github.com/users/IserveU/orgs","repos_url":"https://api.github.com/users/IserveU/repos","events_url":"https://api.github.com/users/IserveU/events{/privacy}","received_events_url":"https://api.github.com/users/IserveU/received_events","type":"Organization","site_admin":false},"repo":{"id":33411957,"name":"IserveU","full_name":"IserveU/IserveU","owner":{"login":"IserveU","id":11811366,"avatar_url":"https://avatars1.githubusercontent.com/u/11811366?v=3","gravatar_id":"","url":"https://api.github.com/users/IserveU","html_url":"https://github.com/IserveU","followers_url":"https://api.github.com/users/IserveU/followers","following_url":"https://api.github.com/users/IserveU/following{/other_user}","gists_url":"https://api.github.com/users/IserveU/gists{/gist_id}","starred_url":"https://api.github.com/users/IserveU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IserveU/subscriptions","organizations_url":"https://api.github.com/users/IserveU/orgs","repos_url":"https://api.github.com/users/IserveU/repos","events_url":"https://api.github.com/users/IserveU/events{/privacy}","received_events_url":"https://api.github.com/users/IserveU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IserveU/IserveU","description":"eDemocracy Tool","fork":false,"url":"https://api.github.com/repos/IserveU/IserveU","forks_url":"https://api.github.com/repos/IserveU/IserveU/forks","keys_url":"https://api.github.com/repos/IserveU/IserveU/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IserveU/IserveU/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IserveU/IserveU/teams","hooks_url":"https://api.github.com/repos/IserveU/IserveU/hooks","issue_events_url":"https://api.github.com/repos/IserveU/IserveU/issues/events{/number}","events_url":"https://api.github.com/repos/IserveU/IserveU/events","assignees_url":"https://api.github.com/repos/IserveU/IserveU/assignees{/user}","branches_url":"https://api.github.com/repos/IserveU/IserveU/branches{/branch}","tags_url":"https://api.github.com/repos/IserveU/IserveU/tags","blobs_url":"https://api.github.com/repos/IserveU/IserveU/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IserveU/IserveU/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IserveU/IserveU/git/refs{/sha}","trees_url":"https://api.github.com/repos/IserveU/IserveU/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IserveU/IserveU/statuses/{sha}","languages_url":"https://api.github.com/repos/IserveU/IserveU/languages","stargazers_url":"https://api.github.com/repos/IserveU/IserveU/stargazers","contributors_url":"https://api.github.com/repos/IserveU/IserveU/contributors","subscribers_url":"https://api.github.com/repos/IserveU/IserveU/subscribers","subscription_url":"https://api.github.com/repos/IserveU/IserveU/subscription","commits_url":"https://api.github.com/repos/IserveU/IserveU/commits{/sha}","git_commits_url":"https://api.github.com/repos/IserveU/IserveU/git/commits{/sha}","comments_url":"https://api.github.com/repos/IserveU/IserveU/comments{/number}","issue_comment_url":"https://api.github.com/repos/IserveU/IserveU/issues/comments{/number}","contents_url":"https://api.github.com/repos/IserveU/IserveU/contents/{+path}","compare_url":"https://api.github.com/repos/IserveU/IserveU/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IserveU/IserveU/merges","archive_url":"https://api.github.com/repos/IserveU/IserveU/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IserveU/IserveU/downloads","issues_url":"https://api.github.com/repos/IserveU/IserveU/issues{/number}","pulls_url":"https://api.github.com/repos/IserveU/IserveU/pulls{/number}","milestones_url":"https://api.github.com/repos/IserveU/IserveU/milestones{/number}","notifications_url":"https://api.github.com/repos/IserveU/IserveU/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IserveU/IserveU/labels{/name}","releases_url":"https://api.github.com/repos/IserveU/IserveU/releases{/id}","deployments_url":"https://api.github.com/repos/IserveU/IserveU/deployments","created_at":"2015-04-04T16:28:07Z","updated_at":"2017-04-30T16:35:55Z","pushed_at":"2017-05-01T00:51:10Z","git_url":"git://github.com/IserveU/IserveU.git","ssh_url":"git@github.com:IserveU/IserveU.git","clone_url":"https://github.com/IserveU/IserveU.git","svn_url":"https://github.com/IserveU/IserveU","homepage":null,"size":40905,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":31,"forks":5,"open_issues":31,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/754"},"html":{"href":"https://github.com/IserveU/IserveU/pull/754"},"issue":{"href":"https://api.github.com/repos/IserveU/IserveU/issues/754"},"comments":{"href":"https://api.github.com/repos/IserveU/IserveU/issues/754/comments"},"review_comments":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/754/comments"},"review_comment":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IserveU/IserveU/pulls/754/commits"},"statuses":{"href":"https://api.github.com/repos/IserveU/IserveU/statuses/331672d981041a89af5c1656db71d688642f4fdf"}}}}
|
{
"id": 33411957,
"name": "IserveU/IserveU",
"url": "https://api.github.com/repos/IserveU/IserveU"
}
|
{
"id": 12400507,
"login": "jessicaquynh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12400507?",
"url": "https://api.github.com/users/jessicaquynh"
}
|
{
"id": 11811366,
"login": "IserveU",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11811366?",
"url": "https://api.github.com/orgs/IserveU"
}
| 2017-05-01T13:06:35 |
5786862551
|
{"actor":{"display_login":"jessicaquynh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/comments/105288751","pull_request_review_id":26163333,"id":105288751,"diff_hunk":"@@ -1258,6 +1258,13 @@ function read{A<:FixedArray}(obj::DatasetOrAttribute, ::Type{Array{A}})\n ret\n end\n \n+# Read a scalar reference objected from an attribute\n+function read{T<:HDF5ReferenceObj}(obj::HDF5Attribute, ::Type{T})\n+ refs = Array{T}(1)","path":"src/HDF5.jl","position":6,"original_position":6,"commit_id":"9334f9d447e5455ae220658679710f9fab9bc7dd","original_commit_id":"9334f9d447e5455ae220658679710f9fab9bc7dd","user":{"login":"simonster","id":470884,"avatar_url":"https://avatars1.githubusercontent.com/u/470884?v=3","gravatar_id":"","url":"https://api.github.com/users/simonster","html_url":"https://github.com/simonster","followers_url":"https://api.github.com/users/simonster/followers","following_url":"https://api.github.com/users/simonster/following{/other_user}","gists_url":"https://api.github.com/users/simonster/gists{/gist_id}","starred_url":"https://api.github.com/users/simonster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonster/subscriptions","organizations_url":"https://api.github.com/users/simonster/orgs","repos_url":"https://api.github.com/users/simonster/repos","events_url":"https://api.github.com/users/simonster/events{/privacy}","received_events_url":"https://api.github.com/users/simonster/received_events","type":"User","site_admin":false},"body":"You can use `ref[]` to get the contents of a `Ref`.","created_at":"2017-03-09T22:38:42Z","updated_at":"2017-03-09T22:38:42Z","html_url":"https://github.com/JuliaIO/HDF5.jl/pull/371#discussion_r105288751","pull_request_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371","_links":{"self":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/comments/105288751"},"html":{"href":"https://github.com/JuliaIO/HDF5.jl/pull/371#discussion_r105288751"},"pull_request":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371","id":109984025,"html_url":"https://github.com/JuliaIO/HDF5.jl/pull/371","diff_url":"https://github.com/JuliaIO/HDF5.jl/pull/371.diff","patch_url":"https://github.com/JuliaIO/HDF5.jl/pull/371.patch","issue_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/371","number":371,"state":"open","locked":false,"title":"Add scalar reference reading for attributes","user":{"login":"grahamrow","id":1561741,"avatar_url":"https://avatars0.githubusercontent.com/u/1561741?v=3","gravatar_id":"","url":"https://api.github.com/users/grahamrow","html_url":"https://github.com/grahamrow","followers_url":"https://api.github.com/users/grahamrow/followers","following_url":"https://api.github.com/users/grahamrow/following{/other_user}","gists_url":"https://api.github.com/users/grahamrow/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamrow/subscriptions","organizations_url":"https://api.github.com/users/grahamrow/orgs","repos_url":"https://api.github.com/users/grahamrow/repos","events_url":"https://api.github.com/users/grahamrow/events{/privacy}","received_events_url":"https://api.github.com/users/grahamrow/received_events","type":"User","site_admin":false},"body":"Wasn't able to read a single reference object from an attribute (only arrays) — quick fix.","created_at":"2017-03-09T19:09:41Z","updated_at":"2017-03-09T22:38:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e910cfdec2da751814a4bf72d891d2d4a95c2dd4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371/commits","review_comments_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371/comments","review_comment_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/371/comments","statuses_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/statuses/9334f9d447e5455ae220658679710f9fab9bc7dd","head":{"label":"BBN-Q:fix/read-scalar-ref-attr","ref":"fix/read-scalar-ref-attr","sha":"9334f9d447e5455ae220658679710f9fab9bc7dd","user":{"login":"BBN-Q","id":1385056,"avatar_url":"https://avatars0.githubusercontent.com/u/1385056?v=3","gravatar_id":"","url":"https://api.github.com/users/BBN-Q","html_url":"https://github.com/BBN-Q","followers_url":"https://api.github.com/users/BBN-Q/followers","following_url":"https://api.github.com/users/BBN-Q/following{/other_user}","gists_url":"https://api.github.com/users/BBN-Q/gists{/gist_id}","starred_url":"https://api.github.com/users/BBN-Q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBN-Q/subscriptions","organizations_url":"https://api.github.com/users/BBN-Q/orgs","repos_url":"https://api.github.com/users/BBN-Q/repos","events_url":"https://api.github.com/users/BBN-Q/events{/privacy}","received_events_url":"https://api.github.com/users/BBN-Q/received_events","type":"Organization","site_admin":false},"repo":{"id":81096543,"name":"HDF5.jl","full_name":"BBN-Q/HDF5.jl","owner":{"login":"BBN-Q","id":1385056,"avatar_url":"https://avatars0.githubusercontent.com/u/1385056?v=3","gravatar_id":"","url":"https://api.github.com/users/BBN-Q","html_url":"https://github.com/BBN-Q","followers_url":"https://api.github.com/users/BBN-Q/followers","following_url":"https://api.github.com/users/BBN-Q/following{/other_user}","gists_url":"https://api.github.com/users/BBN-Q/gists{/gist_id}","starred_url":"https://api.github.com/users/BBN-Q/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BBN-Q/subscriptions","organizations_url":"https://api.github.com/users/BBN-Q/orgs","repos_url":"https://api.github.com/users/BBN-Q/repos","events_url":"https://api.github.com/users/BBN-Q/events{/privacy}","received_events_url":"https://api.github.com/users/BBN-Q/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BBN-Q/HDF5.jl","description":"Saving and loading data in the HDF5 file format","fork":true,"url":"https://api.github.com/repos/BBN-Q/HDF5.jl","forks_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/forks","keys_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/teams","hooks_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/hooks","issue_events_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/issues/events{/number}","events_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/events","assignees_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/assignees{/user}","branches_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/branches{/branch}","tags_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/tags","blobs_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/languages","stargazers_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/stargazers","contributors_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/contributors","subscribers_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/subscribers","subscription_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/subscription","commits_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/contents/{+path}","compare_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/merges","archive_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/downloads","issues_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/issues{/number}","pulls_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/labels{/name}","releases_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/releases{/id}","deployments_url":"https://api.github.com/repos/BBN-Q/HDF5.jl/deployments","created_at":"2017-02-06T14:39:58Z","updated_at":"2017-02-06T14:40:01Z","pushed_at":"2017-03-09T19:07:01Z","git_url":"git://github.com/BBN-Q/HDF5.jl.git","ssh_url":"git@github.com:BBN-Q/HDF5.jl.git","clone_url":"https://github.com/BBN-Q/HDF5.jl.git","svn_url":"https://github.com/BBN-Q/HDF5.jl","homepage":"","size":1264,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaIO:master","ref":"master","sha":"fd1c4ecfa5a093f335eb13a4ef28ebd3a43bbde9","user":{"login":"JuliaIO","id":11489324,"avatar_url":"https://avatars3.githubusercontent.com/u/11489324?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaIO","html_url":"https://github.com/JuliaIO","followers_url":"https://api.github.com/users/JuliaIO/followers","following_url":"https://api.github.com/users/JuliaIO/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIO/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIO/subscriptions","organizations_url":"https://api.github.com/users/JuliaIO/orgs","repos_url":"https://api.github.com/users/JuliaIO/repos","events_url":"https://api.github.com/users/JuliaIO/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIO/received_events","type":"Organization","site_admin":false},"repo":{"id":6024027,"name":"HDF5.jl","full_name":"JuliaIO/HDF5.jl","owner":{"login":"JuliaIO","id":11489324,"avatar_url":"https://avatars3.githubusercontent.com/u/11489324?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaIO","html_url":"https://github.com/JuliaIO","followers_url":"https://api.github.com/users/JuliaIO/followers","following_url":"https://api.github.com/users/JuliaIO/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIO/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIO/subscriptions","organizations_url":"https://api.github.com/users/JuliaIO/orgs","repos_url":"https://api.github.com/users/JuliaIO/repos","events_url":"https://api.github.com/users/JuliaIO/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaIO/HDF5.jl","description":"Saving and loading data in the HDF5 file format","fork":false,"url":"https://api.github.com/repos/JuliaIO/HDF5.jl","forks_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/forks","keys_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/teams","hooks_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/events","assignees_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/tags","blobs_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/subscription","commits_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/merges","archive_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/downloads","issues_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaIO/HDF5.jl/deployments","created_at":"2012-10-01T01:08:41Z","updated_at":"2017-02-27T13:33:20Z","pushed_at":"2017-03-09T19:09:42Z","git_url":"git://github.com/JuliaIO/HDF5.jl.git","ssh_url":"git@github.com:JuliaIO/HDF5.jl.git","clone_url":"https://github.com/JuliaIO/HDF5.jl.git","svn_url":"https://github.com/JuliaIO/HDF5.jl","homepage":"","size":1255,"stargazers_count":113,"watchers_count":113,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":73,"mirror_url":null,"open_issues_count":77,"forks":73,"open_issues":77,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371"},"html":{"href":"https://github.com/JuliaIO/HDF5.jl/pull/371"},"issue":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/371"},"comments":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaIO/HDF5.jl/statuses/9334f9d447e5455ae220658679710f9fab9bc7dd"}}}}
|
{
"id": 6024027,
"name": "JuliaIO/HDF5.jl",
"url": "https://api.github.com/repos/JuliaIO/HDF5.jl"
}
|
{
"id": 470884,
"login": "simonster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/470884?",
"url": "https://api.github.com/users/simonster"
}
|
{
"id": 11489324,
"login": "JuliaIO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11489324?",
"url": "https://api.github.com/orgs/JuliaIO"
}
| 2017-03-09T22:38:42 |
5466680781
|
{"actor":{"display_login":"simonster"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/119542716","pull_request_review_id":41429894,"id":119542716,"diff_hunk":"@@ -94,6 +102,48 @@\n pageContext.setAttribute(\"addBeforeFilter\", \"<i class=\\\"fa fa-toggle-right\\\"></i>\");\n pageContext.setAttribute(\"addAfterFilter\", \"<i class=\\\"fa fa-toggle-left\\\"></i>\");\n pageContext.setAttribute(\"filterFavoriteSelectTagHandler\", new FilterFavoriteSelectTagHandler(\"All Alarms\"));\n+ \n+ // get sound constants from session, request or opennms.properties\n+\tString soundEnabledStr = System.getProperty(\"opennms.alarmlist.sound.enable\");","path":"opennms-webapp/src/main/webapp/WEB-INF/jsp/alarm/list.jsp","position":53,"original_position":53,"commit_id":"9f3d893c76bc166752ee82b907408f9d65fcabab","original_commit_id":"9f3d893c76bc166752ee82b907408f9d65fcabab","user":{"login":"indigo423","id":1095181,"avatar_url":"https://avatars2.githubusercontent.com/u/1095181?v=3","gravatar_id":"","url":"https://api.github.com/users/indigo423","html_url":"https://github.com/indigo423","followers_url":"https://api.github.com/users/indigo423/followers","following_url":"https://api.github.com/users/indigo423/following{/other_user}","gists_url":"https://api.github.com/users/indigo423/gists{/gist_id}","starred_url":"https://api.github.com/users/indigo423/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indigo423/subscriptions","organizations_url":"https://api.github.com/users/indigo423/orgs","repos_url":"https://api.github.com/users/indigo423/repos","events_url":"https://api.github.com/users/indigo423/events{/privacy}","received_events_url":"https://api.github.com/users/indigo423/received_events","type":"User","site_admin":false},"body":"Indentation issues here L107 - L146","created_at":"2017-06-01T07:16:18Z","updated_at":"2017-06-01T07:25:11Z","html_url":"https://github.com/OpenNMS/opennms/pull/1515#discussion_r119542716","pull_request_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515","_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments/119542716"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/1515#discussion_r119542716"},"pull_request":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515"}}},"pull_request":{"url":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515","id":123037072,"html_url":"https://github.com/OpenNMS/opennms/pull/1515","diff_url":"https://github.com/OpenNMS/opennms/pull/1515.diff","patch_url":"https://github.com/OpenNMS/opennms/pull/1515.patch","issue_url":"https://api.github.com/repos/OpenNMS/opennms/issues/1515","number":1515,"state":"open","locked":false,"title":"NMS-9375: Sound and Flashing enhancements to Alarm list","user":{"login":"gallenc","id":5718808,"avatar_url":"https://avatars3.githubusercontent.com/u/5718808?v=3","gravatar_id":"","url":"https://api.github.com/users/gallenc","html_url":"https://github.com/gallenc","followers_url":"https://api.github.com/users/gallenc/followers","following_url":"https://api.github.com/users/gallenc/following{/other_user}","gists_url":"https://api.github.com/users/gallenc/gists{/gist_id}","starred_url":"https://api.github.com/users/gallenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallenc/subscriptions","organizations_url":"https://api.github.com/users/gallenc/orgs","repos_url":"https://api.github.com/users/gallenc/repos","events_url":"https://api.github.com/users/gallenc/events{/privacy}","received_events_url":"https://api.github.com/users/gallenc/received_events","type":"User","site_admin":false},"body":"* JIRA: https://issues.opennms.org/browse/NMS-9375\r\n\r\nThis patch provides 2 new features for the alarm list page: \r\n1. Simple Sound Enhancements to alarms list page to allow new alarms to create a sound. \r\nThis is based upon work originally done by Ian Jarret at Arqiva. The basic sound feature has been in operation at Arqiva for a number of years. This is also needed for BT to replace a patch which Jeff did a number of years ago.\r\n\r\n2. Allow acknowledged and unacknowledged alarms to be displayed at the same time but unacknowledged alarms flash until they are acknowledged. This matches a normal operations practice which allows for the status of all alarms to be shared between users and for users to see where an alarm has not been processed by the team. This is also based upon an early list.jsp patch developed and used at Arqiva.\r\n\r\nThe feature uses a switch in opennms.properties to enable or disable the sound or flashing. This modifies the flow in /alarms/list.jsp. When disabled, OpenNMS should behave identically to Foundation 2017 as all the new code is bypassed in the JSP. When enabled, the new code renders a drop down to select 'sound on new alarm' or 'sound on new alarm count'. \r\n\r\nDocumentation has been added to the user documentation\r\n\r\nThe new features work in firefox and chrome but do not work in IE. There appear to be pre-existing issues in the Alarms jsp which cause problems in IE and these have not been addressed.\r\n\r\n\r\n","created_at":"2017-05-30T12:23:29Z","updated_at":"2017-06-01T07:25:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e895a3ca52d98d410dbed6b0c31d566aeaf9a49","assignee":{"login":"gallenc","id":5718808,"avatar_url":"https://avatars3.githubusercontent.com/u/5718808?v=3","gravatar_id":"","url":"https://api.github.com/users/gallenc","html_url":"https://github.com/gallenc","followers_url":"https://api.github.com/users/gallenc/followers","following_url":"https://api.github.com/users/gallenc/following{/other_user}","gists_url":"https://api.github.com/users/gallenc/gists{/gist_id}","starred_url":"https://api.github.com/users/gallenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallenc/subscriptions","organizations_url":"https://api.github.com/users/gallenc/orgs","repos_url":"https://api.github.com/users/gallenc/repos","events_url":"https://api.github.com/users/gallenc/events{/privacy}","received_events_url":"https://api.github.com/users/gallenc/received_events","type":"User","site_admin":false},"assignees":[{"login":"gallenc","id":5718808,"avatar_url":"https://avatars3.githubusercontent.com/u/5718808?v=3","gravatar_id":"","url":"https://api.github.com/users/gallenc","html_url":"https://github.com/gallenc","followers_url":"https://api.github.com/users/gallenc/followers","following_url":"https://api.github.com/users/gallenc/following{/other_user}","gists_url":"https://api.github.com/users/gallenc/gists{/gist_id}","starred_url":"https://api.github.com/users/gallenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gallenc/subscriptions","organizations_url":"https://api.github.com/users/gallenc/orgs","repos_url":"https://api.github.com/users/gallenc/repos","events_url":"https://api.github.com/users/gallenc/events{/privacy}","received_events_url":"https://api.github.com/users/gallenc/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515/commits","review_comments_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515/comments","review_comment_url":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/issues/1515/comments","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/9f3d893c76bc166752ee82b907408f9d65fcabab","head":{"label":"OpenNMS:jira/NMS-9375","ref":"jira/NMS-9375","sha":"9f3d893c76bc166752ee82b907408f9d65fcabab","user":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars1.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"name":"opennms","full_name":"OpenNMS/opennms","owner":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars1.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNMS/opennms","description":"Enterprise-Grade Open-Source Network Management Platform","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2017-06-01T01:42:40Z","pushed_at":"2017-06-01T06:47:53Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":463012,"stargazers_count":227,"watchers_count":227,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":25,"forks":314,"open_issues":25,"watchers":227,"default_branch":"develop"}},"base":{"label":"OpenNMS:foundation-2017","ref":"foundation-2017","sha":"ba0ed6a861d6d9ff52e0e5a2671e94cb0ab2e1a5","user":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars1.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"repo":{"id":9377198,"name":"opennms","full_name":"OpenNMS/opennms","owner":{"login":"OpenNMS","id":2972482,"avatar_url":"https://avatars1.githubusercontent.com/u/2972482?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenNMS","html_url":"https://github.com/OpenNMS","followers_url":"https://api.github.com/users/OpenNMS/followers","following_url":"https://api.github.com/users/OpenNMS/following{/other_user}","gists_url":"https://api.github.com/users/OpenNMS/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenNMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenNMS/subscriptions","organizations_url":"https://api.github.com/users/OpenNMS/orgs","repos_url":"https://api.github.com/users/OpenNMS/repos","events_url":"https://api.github.com/users/OpenNMS/events{/privacy}","received_events_url":"https://api.github.com/users/OpenNMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenNMS/opennms","description":"Enterprise-Grade Open-Source Network Management Platform","fork":false,"url":"https://api.github.com/repos/OpenNMS/opennms","forks_url":"https://api.github.com/repos/OpenNMS/opennms/forks","keys_url":"https://api.github.com/repos/OpenNMS/opennms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenNMS/opennms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenNMS/opennms/teams","hooks_url":"https://api.github.com/repos/OpenNMS/opennms/hooks","issue_events_url":"https://api.github.com/repos/OpenNMS/opennms/issues/events{/number}","events_url":"https://api.github.com/repos/OpenNMS/opennms/events","assignees_url":"https://api.github.com/repos/OpenNMS/opennms/assignees{/user}","branches_url":"https://api.github.com/repos/OpenNMS/opennms/branches{/branch}","tags_url":"https://api.github.com/repos/OpenNMS/opennms/tags","blobs_url":"https://api.github.com/repos/OpenNMS/opennms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenNMS/opennms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenNMS/opennms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenNMS/opennms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenNMS/opennms/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenNMS/opennms/languages","stargazers_url":"https://api.github.com/repos/OpenNMS/opennms/stargazers","contributors_url":"https://api.github.com/repos/OpenNMS/opennms/contributors","subscribers_url":"https://api.github.com/repos/OpenNMS/opennms/subscribers","subscription_url":"https://api.github.com/repos/OpenNMS/opennms/subscription","commits_url":"https://api.github.com/repos/OpenNMS/opennms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenNMS/opennms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenNMS/opennms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenNMS/opennms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenNMS/opennms/contents/{+path}","compare_url":"https://api.github.com/repos/OpenNMS/opennms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenNMS/opennms/merges","archive_url":"https://api.github.com/repos/OpenNMS/opennms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenNMS/opennms/downloads","issues_url":"https://api.github.com/repos/OpenNMS/opennms/issues{/number}","pulls_url":"https://api.github.com/repos/OpenNMS/opennms/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenNMS/opennms/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenNMS/opennms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenNMS/opennms/labels{/name}","releases_url":"https://api.github.com/repos/OpenNMS/opennms/releases{/id}","deployments_url":"https://api.github.com/repos/OpenNMS/opennms/deployments","created_at":"2013-04-11T18:22:33Z","updated_at":"2017-06-01T01:42:40Z","pushed_at":"2017-06-01T06:47:53Z","git_url":"git://github.com/OpenNMS/opennms.git","ssh_url":"git@github.com:OpenNMS/opennms.git","clone_url":"https://github.com/OpenNMS/opennms.git","svn_url":"https://github.com/OpenNMS/opennms","homepage":"http://www.opennms.org/","size":463012,"stargazers_count":227,"watchers_count":227,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":314,"mirror_url":null,"open_issues_count":25,"forks":314,"open_issues":25,"watchers":227,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515"},"html":{"href":"https://github.com/OpenNMS/opennms/pull/1515"},"issue":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/1515"},"comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/issues/1515/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenNMS/opennms/pulls/1515/commits"},"statuses":{"href":"https://api.github.com/repos/OpenNMS/opennms/statuses/9f3d893c76bc166752ee82b907408f9d65fcabab"}}}}
|
{
"id": 9377198,
"name": "OpenNMS/opennms",
"url": "https://api.github.com/repos/OpenNMS/opennms"
}
|
{
"id": 1095181,
"login": "indigo423",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1095181?",
"url": "https://api.github.com/users/indigo423"
}
|
{
"id": 2972482,
"login": "OpenNMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2972482?",
"url": "https://api.github.com/orgs/OpenNMS"
}
| 2017-06-01T07:16:18 |
5980840047
|
{"actor":{"display_login":"indigo423"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/comments/158215296","pull_request_review_id":84988797,"id":158215296,"diff_hunk":"@@ -32,10 +28,13 @@\n import org.smartregister.view.contract.Villages;\n import org.smartregister.view.controller.ECSmartRegisterController;\n import org.smartregister.view.controller.VillageController;\n-import org.smartregister.view.viewholder.NativeECSmartRegisterViewHolder;\n \n-import static org.junit.Assert.*;\n-import static org.smartregister.AllConstants.ENTITY_ID_PARAM;\n+import static org.junit.Assert.assertEquals;\n+import static org.junit.Assert.assertFalse;","path":"opensrp-app/src/test/java/org/smartregister/view/activity/NativeECSmartRegisterActivityTest.java","position":26,"original_position":26,"commit_id":"abe2e4260e01cbd7c851294f185a4075534f04cc","original_commit_id":"abe2e4260e01cbd7c851294f185a4075534f04cc","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [Using a static member import should be avoided - org.junit.Assert.assertFalse.](https://www.codacy.com/app/OpenSRP/opensrp-client-core/pullRequest?prid=1115080)","created_at":"2017-12-21T08:00:50Z","updated_at":"2017-12-21T08:00:50Z","html_url":"https://github.com/OpenSRP/opensrp-client-core/pull/34#discussion_r158215296","pull_request_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/comments/158215296"},"html":{"href":"https://github.com/OpenSRP/opensrp-client-core/pull/34#discussion_r158215296"},"pull_request":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34","id":155266105,"html_url":"https://github.com/OpenSRP/opensrp-client-core/pull/34","diff_url":"https://github.com/OpenSRP/opensrp-client-core/pull/34.diff","patch_url":"https://github.com/OpenSRP/opensrp-client-core/pull/34.patch","issue_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/34","number":34,"state":"open","locked":false,"title":"Issue17","user":{"login":"kaderchowdhury","id":710158,"avatar_url":"https://avatars3.githubusercontent.com/u/710158?v=4","gravatar_id":"","url":"https://api.github.com/users/kaderchowdhury","html_url":"https://github.com/kaderchowdhury","followers_url":"https://api.github.com/users/kaderchowdhury/followers","following_url":"https://api.github.com/users/kaderchowdhury/following{/other_user}","gists_url":"https://api.github.com/users/kaderchowdhury/gists{/gist_id}","starred_url":"https://api.github.com/users/kaderchowdhury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaderchowdhury/subscriptions","organizations_url":"https://api.github.com/users/kaderchowdhury/orgs","repos_url":"https://api.github.com/users/kaderchowdhury/repos","events_url":"https://api.github.com/users/kaderchowdhury/events{/privacy}","received_events_url":"https://api.github.com/users/kaderchowdhury/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-29T07:19:58Z","updated_at":"2017-12-21T08:00:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e90bed2e2cfe279af68cd38ca6f83dd9728d176","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34/commits","review_comments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34/comments","review_comment_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/34/comments","statuses_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/statuses/abe2e4260e01cbd7c851294f185a4075534f04cc","head":{"label":"OpenSRP:issue17-kk","ref":"issue17-kk","sha":"abe2e4260e01cbd7c851294f185a4075534f04cc","user":{"login":"OpenSRP","id":7898027,"avatar_url":"https://avatars1.githubusercontent.com/u/7898027?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSRP","html_url":"https://github.com/OpenSRP","followers_url":"https://api.github.com/users/OpenSRP/followers","following_url":"https://api.github.com/users/OpenSRP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSRP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSRP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSRP/subscriptions","organizations_url":"https://api.github.com/users/OpenSRP/orgs","repos_url":"https://api.github.com/users/OpenSRP/repos","events_url":"https://api.github.com/users/OpenSRP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSRP/received_events","type":"Organization","site_admin":false},"repo":{"id":97621321,"name":"opensrp-client-core","full_name":"OpenSRP/opensrp-client-core","owner":{"login":"OpenSRP","id":7898027,"avatar_url":"https://avatars1.githubusercontent.com/u/7898027?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSRP","html_url":"https://github.com/OpenSRP","followers_url":"https://api.github.com/users/OpenSRP/followers","following_url":"https://api.github.com/users/OpenSRP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSRP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSRP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSRP/subscriptions","organizations_url":"https://api.github.com/users/OpenSRP/orgs","repos_url":"https://api.github.com/users/OpenSRP/repos","events_url":"https://api.github.com/users/OpenSRP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSRP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSRP/opensrp-client-core","description":"Core OpenSRP Android client library","fork":false,"url":"https://api.github.com/repos/OpenSRP/opensrp-client-core","forks_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/forks","keys_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/teams","hooks_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/hooks","issue_events_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/events","assignees_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/tags","blobs_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/languages","stargazers_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/stargazers","contributors_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/contributors","subscribers_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/subscribers","subscription_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/subscription","commits_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/merges","archive_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/downloads","issues_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/labels{/name}","releases_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/deployments","created_at":"2017-07-18T16:34:57Z","updated_at":"2017-12-13T09:31:07Z","pushed_at":"2017-12-21T07:54:36Z","git_url":"git://github.com/OpenSRP/opensrp-client-core.git","ssh_url":"git@github.com:OpenSRP/opensrp-client-core.git","clone_url":"https://github.com/OpenSRP/opensrp-client-core.git","svn_url":"https://github.com/OpenSRP/opensrp-client-core","homepage":"http://smartregister.org/","size":12008,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"base":{"label":"OpenSRP:master","ref":"master","sha":"2903fa5aeb2a8cccc5f9180483d2882a54a76ef1","user":{"login":"OpenSRP","id":7898027,"avatar_url":"https://avatars1.githubusercontent.com/u/7898027?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSRP","html_url":"https://github.com/OpenSRP","followers_url":"https://api.github.com/users/OpenSRP/followers","following_url":"https://api.github.com/users/OpenSRP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSRP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSRP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSRP/subscriptions","organizations_url":"https://api.github.com/users/OpenSRP/orgs","repos_url":"https://api.github.com/users/OpenSRP/repos","events_url":"https://api.github.com/users/OpenSRP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSRP/received_events","type":"Organization","site_admin":false},"repo":{"id":97621321,"name":"opensrp-client-core","full_name":"OpenSRP/opensrp-client-core","owner":{"login":"OpenSRP","id":7898027,"avatar_url":"https://avatars1.githubusercontent.com/u/7898027?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSRP","html_url":"https://github.com/OpenSRP","followers_url":"https://api.github.com/users/OpenSRP/followers","following_url":"https://api.github.com/users/OpenSRP/following{/other_user}","gists_url":"https://api.github.com/users/OpenSRP/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSRP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSRP/subscriptions","organizations_url":"https://api.github.com/users/OpenSRP/orgs","repos_url":"https://api.github.com/users/OpenSRP/repos","events_url":"https://api.github.com/users/OpenSRP/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSRP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenSRP/opensrp-client-core","description":"Core OpenSRP Android client library","fork":false,"url":"https://api.github.com/repos/OpenSRP/opensrp-client-core","forks_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/forks","keys_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/teams","hooks_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/hooks","issue_events_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/events","assignees_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/tags","blobs_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/languages","stargazers_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/stargazers","contributors_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/contributors","subscribers_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/subscribers","subscription_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/subscription","commits_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/merges","archive_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/downloads","issues_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/labels{/name}","releases_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSRP/opensrp-client-core/deployments","created_at":"2017-07-18T16:34:57Z","updated_at":"2017-12-13T09:31:07Z","pushed_at":"2017-12-21T07:54:36Z","git_url":"git://github.com/OpenSRP/opensrp-client-core.git","ssh_url":"git@github.com:OpenSRP/opensrp-client-core.git","clone_url":"https://github.com/OpenSRP/opensrp-client-core.git","svn_url":"https://github.com/OpenSRP/opensrp-client-core","homepage":"http://smartregister.org/","size":12008,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34"},"html":{"href":"https://github.com/OpenSRP/opensrp-client-core/pull/34"},"issue":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/34"},"comments":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSRP/opensrp-client-core/statuses/abe2e4260e01cbd7c851294f185a4075534f04cc"}},"author_association":"MEMBER"}}
|
{
"id": 97621321,
"name": "OpenSRP/opensrp-client-core",
"url": "https://api.github.com/repos/OpenSRP/opensrp-client-core"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": 7898027,
"login": "OpenSRP",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7898027?",
"url": "https://api.github.com/orgs/OpenSRP"
}
| 2017-12-21T08:00:50 |
7017066153
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/comments/101171729","pull_request_review_id":21893090,"id":101171729,"diff_hunk":"@@ -65,7 +65,7 @@\n \"polymer-analyzer\": \"2.0.0-alpha.20\",\n \"polymer-build\": \"^0.7.1\",\n \"polymer-project-config\": \"^1.2.0\",\n- \"polyserve\": \"0.16.0-prerelease.9\",\n+ \"polyserve\": \"0.16.0\",","path":"package.json","position":5,"original_position":5,"commit_id":"351669bd24f96d5134797b106b3b54da4a4df729","original_commit_id":"351669bd24f96d5134797b106b3b54da4a4df729","user":{"login":"rictic","id":1659,"avatar_url":"https://avatars.githubusercontent.com/u/1659?v=3","gravatar_id":"","url":"https://api.github.com/users/rictic","html_url":"https://github.com/rictic","followers_url":"https://api.github.com/users/rictic/followers","following_url":"https://api.github.com/users/rictic/following{/other_user}","gists_url":"https://api.github.com/users/rictic/gists{/gist_id}","starred_url":"https://api.github.com/users/rictic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rictic/subscriptions","organizations_url":"https://api.github.com/users/rictic/orgs","repos_url":"https://api.github.com/users/rictic/repos","events_url":"https://api.github.com/users/rictic/events{/privacy}","received_events_url":"https://api.github.com/users/rictic/received_events","type":"User","site_admin":false},"body":"^0.16.0 instead, so that we can get semver?","created_at":"2017-02-14T23:36:55Z","updated_at":"2017-02-14T23:36:58Z","html_url":"https://github.com/Polymer/polymer-cli/pull/567#discussion_r101171729","pull_request_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/comments/101171729"},"html":{"href":"https://github.com/Polymer/polymer-cli/pull/567#discussion_r101171729"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567","id":106210221,"html_url":"https://github.com/Polymer/polymer-cli/pull/567","diff_url":"https://github.com/Polymer/polymer-cli/pull/567.diff","patch_url":"https://github.com/Polymer/polymer-cli/pull/567.patch","issue_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/567","number":567,"state":"open","locked":false,"title":"Update polyserve dep to 0.16.0","user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars.githubusercontent.com/u/522948?v=3","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"body":"<!--\r\n Thanks for the PR!\r\n\r\n If this change has a user visible change (including\r\n bug fixes, new features, etc) please describe the change in\r\n CHANGELOG.md.\r\n\r\n If the change is an entirely package-internal reshuffling/refactoring\r\n should the change not be described in the CHANGELOG.\r\n\r\n Consider also updating the README.\r\n\r\n More info: http://keepachangelog.com/en/0.3.0/\r\n -->\r\n\r\n - [ ] CHANGELOG.md has been updated\r\n","created_at":"2017-02-14T22:56:19Z","updated_at":"2017-02-14T23:36:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4265292fae8076a392166a455d5afaa00fdba1b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/567/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer-cli/statuses/351669bd24f96d5134797b106b3b54da4a4df729","head":{"label":"Polymer:update-polyserve","ref":"update-polyserve","sha":"351669bd24f96d5134797b106b3b54da4a4df729","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":51951003,"name":"polymer-cli","full_name":"Polymer/polymer-cli","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-cli","description":"A command-line tool for Polymer projects","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-cli","forks_url":"https://api.github.com/repos/Polymer/polymer-cli/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-cli/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-cli/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-cli/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-cli/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-cli/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-cli/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-cli/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-cli/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-cli/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-cli/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-cli/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-cli/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-cli/deployments","created_at":"2016-02-17T19:57:15Z","updated_at":"2017-02-13T08:06:29Z","pushed_at":"2017-02-14T23:18:54Z","git_url":"git://github.com/Polymer/polymer-cli.git","ssh_url":"git@github.com:Polymer/polymer-cli.git","clone_url":"https://github.com/Polymer/polymer-cli.git","svn_url":"https://github.com/Polymer/polymer-cli","homepage":null,"size":793,"stargazers_count":252,"watchers_count":252,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":112,"forks":63,"open_issues":112,"watchers":252,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"52cda8beee53424d041115a7fd3d69cc18e191de","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":51951003,"name":"polymer-cli","full_name":"Polymer/polymer-cli","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer-cli","description":"A command-line tool for Polymer projects","fork":false,"url":"https://api.github.com/repos/Polymer/polymer-cli","forks_url":"https://api.github.com/repos/Polymer/polymer-cli/forks","keys_url":"https://api.github.com/repos/Polymer/polymer-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer-cli/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer-cli/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer-cli/events","assignees_url":"https://api.github.com/repos/Polymer/polymer-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer-cli/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer-cli/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer-cli/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer-cli/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer-cli/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer-cli/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer-cli/merges","archive_url":"https://api.github.com/repos/Polymer/polymer-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer-cli/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer-cli/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer-cli/deployments","created_at":"2016-02-17T19:57:15Z","updated_at":"2017-02-13T08:06:29Z","pushed_at":"2017-02-14T23:18:54Z","git_url":"git://github.com/Polymer/polymer-cli.git","ssh_url":"git@github.com:Polymer/polymer-cli.git","clone_url":"https://github.com/Polymer/polymer-cli.git","svn_url":"https://github.com/Polymer/polymer-cli","homepage":null,"size":793,"stargazers_count":252,"watchers_count":252,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":112,"forks":63,"open_issues":112,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567"},"html":{"href":"https://github.com/Polymer/polymer-cli/pull/567"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer-cli/issues/567"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer-cli/issues/567/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer-cli/pulls/567/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer-cli/statuses/351669bd24f96d5134797b106b3b54da4a4df729"}}}}
|
{
"id": 51951003,
"name": "Polymer/polymer-cli",
"url": "https://api.github.com/repos/Polymer/polymer-cli"
}
|
{
"id": 1659,
"login": "rictic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1659?",
"url": "https://api.github.com/users/rictic"
}
|
{
"id": 2159051,
"login": "Polymer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2159051?",
"url": "https://api.github.com/orgs/Polymer"
}
| 2017-02-14T23:36:55 |
5325415053
|
{"actor":{"display_login":"rictic"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/docs/pulls/comments/112344148","pull_request_review_id":33652051,"id":112344148,"diff_hunk":"@@ -274,54 +274,49 @@ Styling with the `:host` selector is one of two instances where rules inside a s\n \n ### Style slotted content (distributed children)\n \n-You can create slots in an element's template that are populated at runtime using this syntax:\n+You can create **slots** in an element's template that are populated at runtime. For more information on slots, see the documentation on [/2.0/docs/devguide/shadow-dom#shadow-dom-and-composition](shadow DOM and composition). ","path":"app/2.0/docs/devguide/style-shadow-dom.md","position":5,"original_position":5,"commit_id":"7d97284b6f05f82b6a223eb649d292aa025808df","original_commit_id":"7d97284b6f05f82b6a223eb649d292aa025808df","user":{"login":"arthurevans","id":1149422,"avatar_url":"https://avatars1.githubusercontent.com/u/1149422?v=3","gravatar_id":"","url":"https://api.github.com/users/arthurevans","html_url":"https://github.com/arthurevans","followers_url":"https://api.github.com/users/arthurevans/followers","following_url":"https://api.github.com/users/arthurevans/following{/other_user}","gists_url":"https://api.github.com/users/arthurevans/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurevans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurevans/subscriptions","organizations_url":"https://api.github.com/users/arthurevans/orgs","repos_url":"https://api.github.com/users/arthurevans/repos","events_url":"https://api.github.com/users/arthurevans/events{/privacy}","received_events_url":"https://api.github.com/users/arthurevans/received_events","type":"User","site_admin":false},"body":"Ack sorry one more fix—this link has the text & url reversed.","created_at":"2017-04-20T00:35:40Z","updated_at":"2017-04-20T00:35:40Z","html_url":"https://github.com/Polymer/docs/pull/1987#discussion_r112344148","pull_request_url":"https://api.github.com/repos/Polymer/docs/pulls/1987","_links":{"self":{"href":"https://api.github.com/repos/Polymer/docs/pulls/comments/112344148"},"html":{"href":"https://github.com/Polymer/docs/pull/1987#discussion_r112344148"},"pull_request":{"href":"https://api.github.com/repos/Polymer/docs/pulls/1987"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/docs/pulls/1987","id":113332219,"html_url":"https://github.com/Polymer/docs/pull/1987","diff_url":"https://github.com/Polymer/docs/pull/1987.diff","patch_url":"https://github.com/Polymer/docs/pull/1987.patch","issue_url":"https://api.github.com/repos/Polymer/docs/issues/1987","number":1987,"state":"open","locked":false,"title":"Addressing https://github.com/Polymer/polymer/issues/4463","user":{"login":"katejeffreys","id":22203617,"avatar_url":"https://avatars0.githubusercontent.com/u/22203617?v=3","gravatar_id":"","url":"https://api.github.com/users/katejeffreys","html_url":"https://github.com/katejeffreys","followers_url":"https://api.github.com/users/katejeffreys/followers","following_url":"https://api.github.com/users/katejeffreys/following{/other_user}","gists_url":"https://api.github.com/users/katejeffreys/gists{/gist_id}","starred_url":"https://api.github.com/users/katejeffreys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katejeffreys/subscriptions","organizations_url":"https://api.github.com/users/katejeffreys/orgs","repos_url":"https://api.github.com/users/katejeffreys/repos","events_url":"https://api.github.com/users/katejeffreys/events{/privacy}","received_events_url":"https://api.github.com/users/katejeffreys/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-30T02:08:27Z","updated_at":"2017-04-20T00:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f787047365680828bd65313ad1a0893fe29ccbcf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/docs/pulls/1987/commits","review_comments_url":"https://api.github.com/repos/Polymer/docs/pulls/1987/comments","review_comment_url":"https://api.github.com/repos/Polymer/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/docs/issues/1987/comments","statuses_url":"https://api.github.com/repos/Polymer/docs/statuses/7d97284b6f05f82b6a223eb649d292aa025808df","head":{"label":"Polymer:4463","ref":"4463","sha":"7d97284b6f05f82b6a223eb649d292aa025808df","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":7804910,"name":"docs","full_name":"Polymer/docs","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/docs","description":"Documentation for Polymer","fork":false,"url":"https://api.github.com/repos/Polymer/docs","forks_url":"https://api.github.com/repos/Polymer/docs/forks","keys_url":"https://api.github.com/repos/Polymer/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/docs/teams","hooks_url":"https://api.github.com/repos/Polymer/docs/hooks","issue_events_url":"https://api.github.com/repos/Polymer/docs/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/docs/events","assignees_url":"https://api.github.com/repos/Polymer/docs/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/docs/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/docs/tags","blobs_url":"https://api.github.com/repos/Polymer/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/docs/languages","stargazers_url":"https://api.github.com/repos/Polymer/docs/stargazers","contributors_url":"https://api.github.com/repos/Polymer/docs/contributors","subscribers_url":"https://api.github.com/repos/Polymer/docs/subscribers","subscription_url":"https://api.github.com/repos/Polymer/docs/subscription","commits_url":"https://api.github.com/repos/Polymer/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/docs/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/docs/merges","archive_url":"https://api.github.com/repos/Polymer/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/docs/downloads","issues_url":"https://api.github.com/repos/Polymer/docs/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/docs/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/docs/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/docs/deployments","created_at":"2013-01-24T19:11:00Z","updated_at":"2017-04-19T11:54:32Z","pushed_at":"2017-04-20T00:33:22Z","git_url":"git://github.com/Polymer/docs.git","ssh_url":"git@github.com:Polymer/docs.git","clone_url":"https://github.com/Polymer/docs.git","svn_url":"https://github.com/Polymer/docs","homepage":"https://www.polymer-project.org","size":113483,"stargazers_count":1005,"watchers_count":1005,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2619,"mirror_url":null,"open_issues_count":198,"forks":2619,"open_issues":198,"watchers":1005,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"cef6753e9ed31299161c61ddaf3225e320adfcfe","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":7804910,"name":"docs","full_name":"Polymer/docs","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars0.githubusercontent.com/u/2159051?v=3","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/docs","description":"Documentation for Polymer","fork":false,"url":"https://api.github.com/repos/Polymer/docs","forks_url":"https://api.github.com/repos/Polymer/docs/forks","keys_url":"https://api.github.com/repos/Polymer/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/docs/teams","hooks_url":"https://api.github.com/repos/Polymer/docs/hooks","issue_events_url":"https://api.github.com/repos/Polymer/docs/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/docs/events","assignees_url":"https://api.github.com/repos/Polymer/docs/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/docs/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/docs/tags","blobs_url":"https://api.github.com/repos/Polymer/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/docs/languages","stargazers_url":"https://api.github.com/repos/Polymer/docs/stargazers","contributors_url":"https://api.github.com/repos/Polymer/docs/contributors","subscribers_url":"https://api.github.com/repos/Polymer/docs/subscribers","subscription_url":"https://api.github.com/repos/Polymer/docs/subscription","commits_url":"https://api.github.com/repos/Polymer/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/docs/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/docs/merges","archive_url":"https://api.github.com/repos/Polymer/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/docs/downloads","issues_url":"https://api.github.com/repos/Polymer/docs/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/docs/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/docs/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/docs/deployments","created_at":"2013-01-24T19:11:00Z","updated_at":"2017-04-19T11:54:32Z","pushed_at":"2017-04-20T00:33:22Z","git_url":"git://github.com/Polymer/docs.git","ssh_url":"git@github.com:Polymer/docs.git","clone_url":"https://github.com/Polymer/docs.git","svn_url":"https://github.com/Polymer/docs","homepage":"https://www.polymer-project.org","size":113483,"stargazers_count":1005,"watchers_count":1005,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2619,"mirror_url":null,"open_issues_count":198,"forks":2619,"open_issues":198,"watchers":1005,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/docs/pulls/1987"},"html":{"href":"https://github.com/Polymer/docs/pull/1987"},"issue":{"href":"https://api.github.com/repos/Polymer/docs/issues/1987"},"comments":{"href":"https://api.github.com/repos/Polymer/docs/issues/1987/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/docs/pulls/1987/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/docs/pulls/1987/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/docs/statuses/7d97284b6f05f82b6a223eb649d292aa025808df"}}}}
|
{
"id": 7804910,
"name": "Polymer/docs",
"url": "https://api.github.com/repos/Polymer/docs"
}
|
{
"id": 1149422,
"login": "arthurevans",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1149422?",
"url": "https://api.github.com/users/arthurevans"
}
|
{
"id": 2159051,
"login": "Polymer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2159051?",
"url": "https://api.github.com/orgs/Polymer"
}
| 2017-04-20T00:35:40 |
5720169922
|
{"actor":{"display_login":"arthurevans"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/141825506","pull_request_review_id":66100367,"id":141825506,"diff_hunk":"@@ -167,6 +167,11 @@ typedef struct {\n uint8_t pending_tx; /**< keep track of pending TX calls\n this is required to know when to\n return to @ref at86rf2xx_t::idle_state */\n+#if defined(MODULE_AT86RF232) || defined(MODULE_AT86RF233)","path":"drivers/include/at86rf2xx.h","position":4,"original_position":4,"commit_id":"1e87453a738ca1a31156cbad90f5dca95006e731","original_commit_id":"1e87453a738ca1a31156cbad90f5dca95006e731","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"body":"Missed that one :(","created_at":"2017-09-29T09:24:56Z","updated_at":"2017-09-29T09:24:56Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/7484#discussion_r141825506","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/141825506"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/7484#discussion_r141825506"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484"}},"in_reply_to_id":141824897},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484","id":136461916,"html_url":"https://github.com/RIOT-OS/RIOT/pull/7484","diff_url":"https://github.com/RIOT-OS/RIOT/pull/7484.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/7484.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7484","number":7484,"state":"open","locked":false,"title":"at86rf2xx: add NETOPT_TX_RETRIES_NEEDED support","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"body":"Support for `NETOPT_TX_RETRIES_NEEDED` for the at86rf233. As far as I've found, only the at86rf233 supports reporting no ack retransmissions. This is based on #7448.\r\n\r\nThe code compiles, but as I don't have access to an at86rf233, I have no way to check if the code is functionally correct.","created_at":"2017-08-18T11:51:17Z","updated_at":"2017-09-29T09:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12b27bf4d7b393a94e940272846a6a4b87c4fc4e","assignee":{"login":"gebart","id":317506,"avatar_url":"https://avatars1.githubusercontent.com/u/317506?v=4","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false},"assignees":[{"login":"gebart","id":317506,"avatar_url":"https://avatars1.githubusercontent.com/u/317506?v=4","gravatar_id":"","url":"https://api.github.com/users/gebart","html_url":"https://github.com/gebart","followers_url":"https://api.github.com/users/gebart/followers","following_url":"https://api.github.com/users/gebart/following{/other_user}","gists_url":"https://api.github.com/users/gebart/gists{/gist_id}","starred_url":"https://api.github.com/users/gebart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gebart/subscriptions","organizations_url":"https://api.github.com/users/gebart/orgs","repos_url":"https://api.github.com/users/gebart/repos","events_url":"https://api.github.com/users/gebart/events{/privacy}","received_events_url":"https://api.github.com/users/gebart/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/20","html_url":"https://github.com/RIOT-OS/RIOT/milestone/20","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones/20/labels","id":2596648,"number":20,"title":"Release 2017.10","description":"","creator":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"open_issues":269,"closed_issues":162,"state":"open","created_at":"2017-06-21T16:50:03Z","updated_at":"2017-09-29T07:46:33Z","due_on":"2017-10-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7484/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/1e87453a738ca1a31156cbad90f5dca95006e731","head":{"label":"bergzand:at86rf2xx/tx-retries","ref":"at86rf2xx/tx-retries","sha":"1e87453a738ca1a31156cbad90f5dca95006e731","user":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"repo":{"id":73482253,"name":"RIOT","full_name":"bergzand/RIOT","owner":{"login":"bergzand","id":5160052,"avatar_url":"https://avatars2.githubusercontent.com/u/5160052?v=4","gravatar_id":"","url":"https://api.github.com/users/bergzand","html_url":"https://github.com/bergzand","followers_url":"https://api.github.com/users/bergzand/followers","following_url":"https://api.github.com/users/bergzand/following{/other_user}","gists_url":"https://api.github.com/users/bergzand/gists{/gist_id}","starred_url":"https://api.github.com/users/bergzand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergzand/subscriptions","organizations_url":"https://api.github.com/users/bergzand/orgs","repos_url":"https://api.github.com/users/bergzand/repos","events_url":"https://api.github.com/users/bergzand/events{/privacy}","received_events_url":"https://api.github.com/users/bergzand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bergzand/RIOT","description":"RIOT - The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/bergzand/RIOT","forks_url":"https://api.github.com/repos/bergzand/RIOT/forks","keys_url":"https://api.github.com/repos/bergzand/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bergzand/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bergzand/RIOT/teams","hooks_url":"https://api.github.com/repos/bergzand/RIOT/hooks","issue_events_url":"https://api.github.com/repos/bergzand/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/bergzand/RIOT/events","assignees_url":"https://api.github.com/repos/bergzand/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/bergzand/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/bergzand/RIOT/tags","blobs_url":"https://api.github.com/repos/bergzand/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bergzand/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bergzand/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/bergzand/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bergzand/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/bergzand/RIOT/languages","stargazers_url":"https://api.github.com/repos/bergzand/RIOT/stargazers","contributors_url":"https://api.github.com/repos/bergzand/RIOT/contributors","subscribers_url":"https://api.github.com/repos/bergzand/RIOT/subscribers","subscription_url":"https://api.github.com/repos/bergzand/RIOT/subscription","commits_url":"https://api.github.com/repos/bergzand/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/bergzand/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/bergzand/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/bergzand/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/bergzand/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/bergzand/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bergzand/RIOT/merges","archive_url":"https://api.github.com/repos/bergzand/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bergzand/RIOT/downloads","issues_url":"https://api.github.com/repos/bergzand/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/bergzand/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/bergzand/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/bergzand/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bergzand/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/bergzand/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/bergzand/RIOT/deployments","created_at":"2016-11-11T14:02:28Z","updated_at":"2016-11-11T14:02:49Z","pushed_at":"2017-09-29T09:18:36Z","git_url":"git://github.com/bergzand/RIOT.git","ssh_url":"git@github.com:bergzand/RIOT.git","clone_url":"https://github.com/bergzand/RIOT.git","svn_url":"https://github.com/bergzand/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":43588,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"4ff174dd02767ec357eeb8b2b64b629926d4a24a","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT - The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-09-29T07:39:52Z","pushed_at":"2017-09-29T09:18:38Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":43186,"stargazers_count":1403,"watchers_count":1403,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":843,"mirror_url":null,"open_issues_count":690,"forks":843,"open_issues":690,"watchers":1403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/7484"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7484"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/7484/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/7484/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/1e87453a738ca1a31156cbad90f5dca95006e731"}},"author_association":"MEMBER"}}
|
{
"id": 7370241,
"name": "RIOT-OS/RIOT",
"url": "https://api.github.com/repos/RIOT-OS/RIOT"
}
|
{
"id": 5160052,
"login": "bergzand",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5160052?",
"url": "https://api.github.com/users/bergzand"
}
|
{
"id": 3079480,
"login": "RIOT-OS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3079480?",
"url": "https://api.github.com/orgs/RIOT-OS"
}
| 2017-09-29T09:24:56 |
6653681431
|
{"actor":{"display_login":"bergzand"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/155709614","pull_request_review_id":82073578,"id":155709614,"diff_hunk":"@@ -74,241 +63,754 @@ static void clean_all_data(int fd, char *buffer)\n }\n \n /**\n-* @testcase audio_pcm_open_close_tc_p\n+* @testcase itc_audio_pcm_open_close_p\n * @brief open and initlaize pcm structure\n * @scenario Open pcm and check its validation\n * @apicovered pcm_open, pcm_close\n * @precondition NA\n * @postcondition NA\n */\n-static void itc_audio_pcm_open_close_tc_p(void)\n+static void itc_audio_pcm_open_close_p(void)\n {\n+\tg_pcm = NULL;\n \tg_pcm = pcm_open(0, 0, PCM_IN, NULL);\n+\tTC_ASSERT_NEQ(\"pcm_open\", g_pcm, NULL);\n \tTC_ASSERT_GT(\"pcm_open\", pcm_get_file_descriptor(g_pcm), 0);","path":"apps/examples/testcase/ta_tc/audio/itc/itc_audio_main.c","position":57,"original_position":57,"commit_id":"5174180b9e54d2bab3cd1285c2c043a8484923d8","original_commit_id":"5174180b9e54d2bab3cd1285c2c043a8484923d8","user":{"login":"arvinmittal","id":31839140,"avatar_url":"https://avatars0.githubusercontent.com/u/31839140?v=4","gravatar_id":"","url":"https://api.github.com/users/arvinmittal","html_url":"https://github.com/arvinmittal","followers_url":"https://api.github.com/users/arvinmittal/followers","following_url":"https://api.github.com/users/arvinmittal/following{/other_user}","gists_url":"https://api.github.com/users/arvinmittal/gists{/gist_id}","starred_url":"https://api.github.com/users/arvinmittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvinmittal/subscriptions","organizations_url":"https://api.github.com/users/arvinmittal/orgs","repos_url":"https://api.github.com/users/arvinmittal/repos","events_url":"https://api.github.com/users/arvinmittal/events{/privacy}","received_events_url":"https://api.github.com/users/arvinmittal/received_events","type":"User","site_admin":false},"body":"okay I will close g_pcm in cleanup function","created_at":"2017-12-08T06:13:10Z","updated_at":"2017-12-08T06:13:10Z","html_url":"https://github.com/Samsung/TizenRT/pull/1083#discussion_r155709614","pull_request_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments/155709614"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1083#discussion_r155709614"},"pull_request":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083"}},"in_reply_to_id":155703625},"pull_request":{"url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083","id":156982425,"html_url":"https://github.com/Samsung/TizenRT/pull/1083","diff_url":"https://github.com/Samsung/TizenRT/pull/1083.diff","patch_url":"https://github.com/Samsung/TizenRT/pull/1083.patch","issue_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1083","number":1083,"state":"open","locked":false,"title":"testcase/ta_tc/Audio : add ITCs for Audio APIs","user":{"login":"arvinmittal","id":31839140,"avatar_url":"https://avatars0.githubusercontent.com/u/31839140?v=4","gravatar_id":"","url":"https://api.github.com/users/arvinmittal","html_url":"https://github.com/arvinmittal","followers_url":"https://api.github.com/users/arvinmittal/followers","following_url":"https://api.github.com/users/arvinmittal/following{/other_user}","gists_url":"https://api.github.com/users/arvinmittal/gists{/gist_id}","starred_url":"https://api.github.com/users/arvinmittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvinmittal/subscriptions","organizations_url":"https://api.github.com/users/arvinmittal/orgs","repos_url":"https://api.github.com/users/arvinmittal/repos","events_url":"https://api.github.com/users/arvinmittal/events{/privacy}","received_events_url":"https://api.github.com/users/arvinmittal/received_events","type":"User","site_admin":false},"body":"Scenarios ITCs perform below tests:\r\nitc_audio_pcm_open_p_with_different_flag : open pcm with different flag and check its validation\r\nitc_audio_pcm_open_p_reopen : reopen pcm_open after opening\r\nitc_audio_pcm_open_n : pcm_open with invalid argument\r\nitc_audio_pcm_close_n : pcm_close with invalid argument\r\nitc_audio_pcm_is_ready_n_after_close : check pcm_is_ready after pcm_close\r\nitc_audio_pcm_is_ready_n : check pcm_is_ready with invalid argument\r\nitc_audio_pcm_prepare_n_after_close : pcm_prepare after pcm_close\r\nitc_audio_pcm_open_by_name_n : pcm_open_by_name with invalid argument\r\nitc_audio_pcm_get_config_n_after_close : pcm_get_config afetr pcm_close\r\nitc_audio_pcm_get_config_n : pcm_get_config after pcm_close\r\nitc_audio_pcm_get_channels_n_after_close : pcm_get_channels after pcm_close\r\nitc_audio_pcm_get_channels_n : pcm_get_channels with invalid argument\r\nitc_audio_pcm_get_rate_n_after_close : pcm_get_rate after pcm_close\r\nitc_audio_pcm_get_rate_n : pcm_get_rate with invalid argument\r\nitc_audio_pcm_get_format_n_after_close : pcm_get_format after pcm_close\r\nitc_audio_pcm_get_format_n : pcm_get_format with invalid argument\r\nitc_audio_pcm_get_file_descriptor_n_after_close : pcm_get_file_descriptor after pcm_close\r\nitc_audio_pcm_get_file_descriptor_n : pcm_get_file_descriptor with invalid argument\r\nitc_audio_pcm_get_error_n : pcm_get_error with invalid argument\r\nitc_audio_pcm_get_buffer_size_n_after_close : pcm_get_buffer_size after pcm_close\r\nitc_audio_pcm_get_buffer_size_n : pcm_get_buffer_size with invalid argument\r\nitc_audio_pcm_get_subdevice_n_after_close : pcm_get_subdevice after pcm_close\r\nitc_audio_pcm_get_subdevice_n : pcm_get_subdevice after pcm_close\r\nitc_audio_pcm_frames_to_bytes_n_after_close : pcm_frames_to_bytes after pcm_close\r\nitc_audio_pcm_frames_to_bytes_n : pcm_frames_to_bytes with invalid argument\r\nitc_audio_pcm_bytes_to_frames_n_after_close : pcm_bytes_to_frames after pcm_close\r\nitc_audio_pcm_bytes_to_frames_n : pcm_bytes_to_frames with invalid argument\r\nitc_audio_pcm_format_to_bits_n : pcm_format_to_bits with invalid argument\r\nitc_audio_pcm_readi_n : pcm_readi with invalid argument\r\nitc_audio_pcm_writei_n : pcm_writei with invalid argument\r\n\r\nSigned-off-by: Arvin Mittal <arvin.mittal@samsung.com>","created_at":"2017-12-07T12:34:22Z","updated_at":"2017-12-08T06:13:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a76d7f5e2ca11a855c75763b74fb5bef78b1dc18","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/issues/1083/comments","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/5174180b9e54d2bab3cd1285c2c043a8484923d8","head":{"label":"arvinmittal:add_audio_itc","ref":"add_audio_itc","sha":"5174180b9e54d2bab3cd1285c2c043a8484923d8","user":{"login":"arvinmittal","id":31839140,"avatar_url":"https://avatars0.githubusercontent.com/u/31839140?v=4","gravatar_id":"","url":"https://api.github.com/users/arvinmittal","html_url":"https://github.com/arvinmittal","followers_url":"https://api.github.com/users/arvinmittal/followers","following_url":"https://api.github.com/users/arvinmittal/following{/other_user}","gists_url":"https://api.github.com/users/arvinmittal/gists{/gist_id}","starred_url":"https://api.github.com/users/arvinmittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvinmittal/subscriptions","organizations_url":"https://api.github.com/users/arvinmittal/orgs","repos_url":"https://api.github.com/users/arvinmittal/repos","events_url":"https://api.github.com/users/arvinmittal/events{/privacy}","received_events_url":"https://api.github.com/users/arvinmittal/received_events","type":"User","site_admin":false},"repo":{"id":104035142,"name":"TizenRT","full_name":"arvinmittal/TizenRT","owner":{"login":"arvinmittal","id":31839140,"avatar_url":"https://avatars0.githubusercontent.com/u/31839140?v=4","gravatar_id":"","url":"https://api.github.com/users/arvinmittal","html_url":"https://github.com/arvinmittal","followers_url":"https://api.github.com/users/arvinmittal/followers","following_url":"https://api.github.com/users/arvinmittal/following{/other_user}","gists_url":"https://api.github.com/users/arvinmittal/gists{/gist_id}","starred_url":"https://api.github.com/users/arvinmittal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvinmittal/subscriptions","organizations_url":"https://api.github.com/users/arvinmittal/orgs","repos_url":"https://api.github.com/users/arvinmittal/repos","events_url":"https://api.github.com/users/arvinmittal/events{/privacy}","received_events_url":"https://api.github.com/users/arvinmittal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvinmittal/TizenRT","description":"Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices","fork":true,"url":"https://api.github.com/repos/arvinmittal/TizenRT","forks_url":"https://api.github.com/repos/arvinmittal/TizenRT/forks","keys_url":"https://api.github.com/repos/arvinmittal/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvinmittal/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvinmittal/TizenRT/teams","hooks_url":"https://api.github.com/repos/arvinmittal/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/arvinmittal/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/arvinmittal/TizenRT/events","assignees_url":"https://api.github.com/repos/arvinmittal/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/arvinmittal/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/arvinmittal/TizenRT/tags","blobs_url":"https://api.github.com/repos/arvinmittal/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvinmittal/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvinmittal/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvinmittal/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvinmittal/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/arvinmittal/TizenRT/languages","stargazers_url":"https://api.github.com/repos/arvinmittal/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/arvinmittal/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/arvinmittal/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/arvinmittal/TizenRT/subscription","commits_url":"https://api.github.com/repos/arvinmittal/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvinmittal/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvinmittal/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvinmittal/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvinmittal/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/arvinmittal/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvinmittal/TizenRT/merges","archive_url":"https://api.github.com/repos/arvinmittal/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvinmittal/TizenRT/downloads","issues_url":"https://api.github.com/repos/arvinmittal/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/arvinmittal/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/arvinmittal/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/arvinmittal/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvinmittal/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/arvinmittal/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/arvinmittal/TizenRT/deployments","created_at":"2017-09-19T06:25:35Z","updated_at":"2017-09-19T06:25:50Z","pushed_at":"2017-12-07T16:09:23Z","git_url":"git://github.com/arvinmittal/TizenRT.git","ssh_url":"git@github.com:arvinmittal/TizenRT.git","clone_url":"https://github.com/arvinmittal/TizenRT.git","svn_url":"https://github.com/arvinmittal/TizenRT","homepage":"","size":76947,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"b7c2770cc49c0371a7fe79ecc331836e13a51161","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":82517252,"name":"TizenRT","full_name":"Samsung/TizenRT","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/TizenRT","description":"Tizen RT is a lightweight RTOS-based platform to support low-end IoT devices","fork":false,"url":"https://api.github.com/repos/Samsung/TizenRT","forks_url":"https://api.github.com/repos/Samsung/TizenRT/forks","keys_url":"https://api.github.com/repos/Samsung/TizenRT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/TizenRT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/TizenRT/teams","hooks_url":"https://api.github.com/repos/Samsung/TizenRT/hooks","issue_events_url":"https://api.github.com/repos/Samsung/TizenRT/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/TizenRT/events","assignees_url":"https://api.github.com/repos/Samsung/TizenRT/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/TizenRT/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/TizenRT/tags","blobs_url":"https://api.github.com/repos/Samsung/TizenRT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/TizenRT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/TizenRT/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/TizenRT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/TizenRT/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/TizenRT/languages","stargazers_url":"https://api.github.com/repos/Samsung/TizenRT/stargazers","contributors_url":"https://api.github.com/repos/Samsung/TizenRT/contributors","subscribers_url":"https://api.github.com/repos/Samsung/TizenRT/subscribers","subscription_url":"https://api.github.com/repos/Samsung/TizenRT/subscription","commits_url":"https://api.github.com/repos/Samsung/TizenRT/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/TizenRT/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/TizenRT/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/TizenRT/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/TizenRT/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/TizenRT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/TizenRT/merges","archive_url":"https://api.github.com/repos/Samsung/TizenRT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/TizenRT/downloads","issues_url":"https://api.github.com/repos/Samsung/TizenRT/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/TizenRT/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/TizenRT/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/TizenRT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/TizenRT/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/TizenRT/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/TizenRT/deployments","created_at":"2017-02-20T04:38:30Z","updated_at":"2017-12-08T04:59:24Z","pushed_at":"2017-12-08T05:53:48Z","git_url":"git://github.com/Samsung/TizenRT.git","ssh_url":"git@github.com:Samsung/TizenRT.git","clone_url":"https://github.com/Samsung/TizenRT.git","svn_url":"https://github.com/Samsung/TizenRT","homepage":"","size":76908,"stargazers_count":103,"watchers_count":103,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":134,"open_issues":53,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083"},"html":{"href":"https://github.com/Samsung/TizenRT/pull/1083"},"issue":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1083"},"comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/TizenRT/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/TizenRT/statuses/5174180b9e54d2bab3cd1285c2c043a8484923d8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 82517252,
"name": "Samsung/TizenRT",
"url": "https://api.github.com/repos/Samsung/TizenRT"
}
|
{
"id": 31839140,
"login": "arvinmittal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/31839140?",
"url": "https://api.github.com/users/arvinmittal"
}
|
{
"id": 6210390,
"login": "Samsung",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6210390?",
"url": "https://api.github.com/orgs/Samsung"
}
| 2017-12-08T06:13:10 |
6960810085
|
{"actor":{"display_login":"arvinmittal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/comments/114512571","pull_request_review_id":35982989,"id":114512571,"diff_hunk":"@@ -0,0 +1,262 @@\n+{-# LANGUAGE ConstraintKinds #-}\n+{-# LANGUAGE DataKinds #-}\n+{-# LANGUAGE FlexibleContexts #-}\n+{-# LANGUAGE FlexibleInstances #-}\n+{-# LANGUAGE GADTs #-}\n+{-# LANGUAGE MultiParamTypeClasses #-}\n+{-# LANGUAGE PolyKinds #-}\n+{-# LANGUAGE RankNTypes #-}\n+{-# LANGUAGE ScopedTypeVariables #-}\n+{-# LANGUAGE TypeApplications #-}\n+{-# LANGUAGE TypeFamilies #-}\n+{-# LANGUAGE TypeOperators #-}\n+{-# LANGUAGE UndecidableInstances #-}\n+{-# OPTIONS_GHC -fno-warn-redundant-constraints #-}\n+\n+module Control.Monad.Freer.Resource\n+ ( SafeForRegion\n+ , Resource (..)\n+ , HiddenResource\n+ , ResourceCtor\n+ , catchNothing\n+ , acquire\n+ , acquire'\n+ , handleRegionRelay\n+ , fileHandleRegion\n+ , give\n+ , thisRegion\n+ , parentRegion\n+ , gparentRegion\n+ ) where\n+\n+import Control.Exception (SomeException, catch)\n+import Control.Monad.Freer\n+import Control.Monad.Freer.Exception (Exc (..), throwError)\n+import Control.Monad.Freer.Internal (Union, Eff (..), qComp, tsingleton, prj, decomp)\n+import Data.Bool (bool)\n+import Data.List (delete)\n+import Data.Proxy (Proxy (..))\n+import GHC.TypeLits (Nat, type (+), type (-), type (<=))\n+import System.IO\n+\n+\n+------------------------------------------------------------------------------\n+-- | Instances of this typeclass describe which effects 'r' are allowed to be\n+-- present inside of a region for 'res'.\n+class SafeForRegion res (r :: [* -> *])\n+\n+instance SafeForRegion res '[]\n+instance SafeForRegion res r => SafeForRegion res (RegionEff res s ': r)\n+\n+instance SafeForRegion Handle r => SafeForRegion Handle (Exc SomeException ': r)\n+instance SafeForRegion Handle '[IO]\n+-- instance SafeForRegion r => SafeForRegion (Reader a ': r)\n+-- instance SafeForRegion r => SafeForRegion (State a ': r)\n+\n+\n+------------------------------------------------------------------------------\n+-- | A data family that should always be a newtype over 'res', but the\n+-- constructors should never be exported. This type exists in order to hide the\n+-- internals of a resource from end-users, but allow library authors to get\n+-- a handle on their resources.\n+data family HiddenResource res\n+\n+\n+------------------------------------------------------------------------------\n+-- | A wrapper around a 'res', with an eigenvariable to prevent this type from\n+-- exiting the region its lifetime is scoped by.\n+newtype Resource res s = Resource\n+ { getHiddenResource :: HiddenResource res\n+ }\n+\n+\n+------------------------------------------------------------------------------\n+-- | Type family for describing the data necessary to construct a request to\n+-- acquire a 'res'.\n+type family ResourceCtor res\n+\n+newtype instance HiddenResource Handle = HandleResource\n+ { unHandleResource :: Handle\n+ } deriving Eq\n+type instance ResourceCtor Handle = (FilePath, IOMode)\n+\n+\n+------------------------------------------------------------------------------\n+-- | Underlying effect for managing regions.\n+data RegionEff res s a where\n+ -- | Create a new 'res'.\n+ RENew :: ResourceCtor res -> RegionEff res s (Resource res s)\n+ -- | Forget about a 'res' (because it's been 'give'n to another region).\n+ REForget :: Resource res s -> RegionEff res s ()\n+ -- | Acquire a 'res' from another region.\n+ REAcquire :: Resource res s' -> RegionEff res s (Resource res s)\n+\n+\n+------------------------------------------------------------------------------\n+-- | Finds the 'n'th occurrence of a RegionEff, which must exist.\n+type family Ancestor (n::Nat) (lst :: [* -> *]) :: * where\n+ Ancestor 0 (RegionEff res s ': lst) = s\n+ Ancestor n (RegionEff res s ': lst) = Ancestor (n - 1) lst\n+ Ancestor n (t ': lst) = Ancestor n lst\n+\n+\n+------------------------------------------------------------------------------\n+-- | Helper value to describe 'acquire'ing a resource in this region.\n+thisRegion :: Proxy 0\n+thisRegion = Proxy\n+\n+\n+------------------------------------------------------------------------------\n+-- | Helper value to describe 'acquire'ing a resource in the parent region.\n+parentRegion :: Proxy 1\n+parentRegion = Proxy\n+\n+\n+------------------------------------------------------------------------------\n+-- | Helper value to describe 'acquire'ing a resource in the grandparent region.\n+gparentRegion :: Proxy 2\n+gparentRegion = Proxy\n+\n+\n+------------------------------------------------------------------------------\n+-- | Acquire a 'res' scoped in the current region.\n+acquire :: forall res r s\n+ . ( s ~ Ancestor 0 r\n+ , Member (RegionEff res s) r\n+ )\n+ => ResourceCtor res\n+ -> Eff r (Resource res s)\n+acquire = acquire' thisRegion\n+\n+\n+------------------------------------------------------------------------------\n+-- | Acquire a 'res' scoped in an ancestor region.\n+acquire' :: ( s ~ Ancestor n r\n+ , Member (RegionEff res s) r\n+ )\n+ => Proxy n\n+ -> ResourceCtor res\n+ -> Eff r (Resource res s)\n+acquire' _ ctor = send $ RENew ctor\n+\n+\n+------------------------------------------------------------------------------\n+-- | Count how many 'RegionEff's there are in an effect stack.\n+type family Length (lst :: [* -> *]) :: Nat where\n+ Length '[] = 0\n+ Length (RegionEff res x ': t) = 1 + (Length t)\n+ Length (h ': t) = Length t\n+\n+\n+------------------------------------------------------------------------------\n+-- | Internal type to create eigenvariables around, in order to protect\n+-- resources from exiting their region scope.\n+data L (n :: Nat) k\n+\n+\n+------------------------------------------------------------------------------\n+-- | Helper function to build region constructs for resources of type 'res'.\n+handleRegionRelay :: forall res effs a\n+ . ( SafeForRegion res effs\n+ , Eq (HiddenResource res)\n+ )\n+ => -- | Strategy to acquire a 'res'.\n+ (ResourceCtor res -> Eff effs (HiddenResource res))\n+ -- | Strategy to release a 'res'.\n+ -> (HiddenResource res -> Eff effs ())\n+ -- | Strategy for catching other effects.\n+ -> (forall (b :: *)\n+ . -- | Action to release all resources.\n+ Eff effs ()\n+ -- | Action to ignore this effect.\n+ -> (Union effs b -> Eff effs a)\n+ -- | The effect being caught.\n+ -> Union effs b\n+ -> Eff effs a\n+ )\n+ -- | A region in which we can allocate 'res's.\n+ -> (forall s. Eff (RegionEff res (L (Length effs) s) ': effs) a)\n+ -> Eff effs a\n+handleRegionRelay acquireM releaseM catchM = loop []\n+ where\n+ releaseAll = mapM_ releaseM\n+\n+ loop :: [HiddenResource res]\n+ -> Eff (RegionEff res (L (Length effs) s) ': effs) a\n+ -> Eff effs a\n+ loop rs (Val x) = releaseAll rs >> return x\n+ loop rs (E u q) =\n+ case decomp u of\n+ Right (RENew ctor) -> do\n+ r <- acquireM ctor\n+ k (r : rs) $ Resource r\n+\n+ Right (REForget (Resource r)) ->\n+ k (delete r rs) ()\n+\n+ Right (REAcquire (Resource r)) ->\n+ k (bool (r : rs) rs $ elem r rs) $ Resource r\n+\n+ Left u' ->\n+ catchM (releaseAll rs) ignore u'\n+\n+ where\n+ ignore u' = E u' . tsingleton $ k rs\n+ k s = qComp q (loop s)\n+\n+\n+------------------------------------------------------------------------------\n+-- | Combinator to be used with 'handleRegionRelay' describing that no extra\n+-- effects need being caught.\n+catchNothing :: Eff effs ()\n+ -> (Union effs b -> Eff effs a)\n+ -> Union effs b\n+ -> Eff effs a\n+catchNothing = const id\n+\n+\n+------------------------------------------------------------------------------\n+-- | Example region for acquiring file 'Handle's.\n+fileHandleRegion :: forall r a\n+ . ( Member IO r\n+ , SafeForRegion Handle r\n+ , Member (Exc SomeException) r\n+ )\n+ => (forall s. Eff (RegionEff Handle (L (Length r) s) ': r) a)\n+ -> Eff r a\n+fileHandleRegion = handleRegionRelay (send . fmap HandleResource . uncurry openFile)\n+ (send . close . unHandleResource)","path":"src/Control/Monad/Freer/Resource.hs","position":228,"original_position":228,"commit_id":"2731b436d41561f96cce13626b41cb58155d5637","original_commit_id":"2731b436d41561f96cce13626b41cb58155d5637","user":{"login":"shlevy","id":487050,"avatar_url":"https://avatars0.githubusercontent.com/u/487050?v=3","gravatar_id":"","url":"https://api.github.com/users/shlevy","html_url":"https://github.com/shlevy","followers_url":"https://api.github.com/users/shlevy/followers","following_url":"https://api.github.com/users/shlevy/following{/other_user}","gists_url":"https://api.github.com/users/shlevy/gists{/gist_id}","starred_url":"https://api.github.com/users/shlevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shlevy/subscriptions","organizations_url":"https://api.github.com/users/shlevy/orgs","repos_url":"https://api.github.com/users/shlevy/repos","events_url":"https://api.github.com/users/shlevy/events{/privacy}","received_events_url":"https://api.github.com/users/shlevy/received_events","type":"User","site_admin":false},"body":"Haven't yet had a chance to walk through this whole file... what happens if an async exception is thrown to this thread while within the region?","created_at":"2017-05-03T10:19:38Z","updated_at":"2017-05-03T10:19:38Z","html_url":"https://github.com/TaktInc/freer-effects/pull/2#discussion_r114512571","pull_request_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/comments/114512571"},"html":{"href":"https://github.com/TaktInc/freer-effects/pull/2#discussion_r114512571"},"pull_request":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2","id":118684570,"html_url":"https://github.com/TaktInc/freer-effects/pull/2","diff_url":"https://github.com/TaktInc/freer-effects/pull/2.diff","patch_url":"https://github.com/TaktInc/freer-effects/pull/2.patch","issue_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/2","number":2,"state":"open","locked":false,"title":"Typesafe effects for acquiring resources","user":{"login":"isovector","id":307223,"avatar_url":"https://avatars0.githubusercontent.com/u/307223?v=3","gravatar_id":"","url":"https://api.github.com/users/isovector","html_url":"https://github.com/isovector","followers_url":"https://api.github.com/users/isovector/followers","following_url":"https://api.github.com/users/isovector/following{/other_user}","gists_url":"https://api.github.com/users/isovector/gists{/gist_id}","starred_url":"https://api.github.com/users/isovector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isovector/subscriptions","organizations_url":"https://api.github.com/users/isovector/orgs","repos_url":"https://api.github.com/users/isovector/repos","events_url":"https://api.github.com/users/isovector/events{/privacy}","received_events_url":"https://api.github.com/users/isovector/received_events","type":"User","site_admin":false},"body":"This PR is an implementation and subsequent generalization of the `SHandle` region construction from the paper 'Freer Monads, More Extensible Effects'. \r\n\r\nIt provides a function `handleRegionRelay` which can be used to implement regions which are capable of acquiring resources, and automatically releasing them at the end of its scope. The type system guarantees that these resources cannot escape their scope, and can also limit which effects are allowed to be available in the same scope (non-determinism, for example, would break the invariants provided by regions, so we can exclude them by this mechanism). Due to this closed world, `handleRegionRelay` can deal with short-circuiting interpreters by intercepting their requests before the short-circuiting one would.\r\n\r\nI wish I had thought of most of this stuff :)","created_at":"2017-05-03T03:08:46Z","updated_at":"2017-05-03T10:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a098c658a7800f6ef4449dbf4e1063b9c6786c2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2/commits","review_comments_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2/comments","review_comment_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/2/comments","statuses_url":"https://api.github.com/repos/TaktInc/freer-effects/statuses/2731b436d41561f96cce13626b41cb58155d5637","head":{"label":"TaktInc:feature/region","ref":"feature/region","sha":"2731b436d41561f96cce13626b41cb58155d5637","user":{"login":"TaktInc","id":17728930,"avatar_url":"https://avatars0.githubusercontent.com/u/17728930?v=3","gravatar_id":"","url":"https://api.github.com/users/TaktInc","html_url":"https://github.com/TaktInc","followers_url":"https://api.github.com/users/TaktInc/followers","following_url":"https://api.github.com/users/TaktInc/following{/other_user}","gists_url":"https://api.github.com/users/TaktInc/gists{/gist_id}","starred_url":"https://api.github.com/users/TaktInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TaktInc/subscriptions","organizations_url":"https://api.github.com/users/TaktInc/orgs","repos_url":"https://api.github.com/users/TaktInc/repos","events_url":"https://api.github.com/users/TaktInc/events{/privacy}","received_events_url":"https://api.github.com/users/TaktInc/received_events","type":"Organization","site_admin":false},"repo":{"id":85000106,"name":"freer-effects","full_name":"TaktInc/freer-effects","owner":{"login":"TaktInc","id":17728930,"avatar_url":"https://avatars0.githubusercontent.com/u/17728930?v=3","gravatar_id":"","url":"https://api.github.com/users/TaktInc","html_url":"https://github.com/TaktInc","followers_url":"https://api.github.com/users/TaktInc/followers","following_url":"https://api.github.com/users/TaktInc/following{/other_user}","gists_url":"https://api.github.com/users/TaktInc/gists{/gist_id}","starred_url":"https://api.github.com/users/TaktInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TaktInc/subscriptions","organizations_url":"https://api.github.com/users/TaktInc/orgs","repos_url":"https://api.github.com/users/TaktInc/repos","events_url":"https://api.github.com/users/TaktInc/events{/privacy}","received_events_url":"https://api.github.com/users/TaktInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TaktInc/freer-effects","description":"An implementation of \"Freer Monads, More Extensible Effects\".","fork":true,"url":"https://api.github.com/repos/TaktInc/freer-effects","forks_url":"https://api.github.com/repos/TaktInc/freer-effects/forks","keys_url":"https://api.github.com/repos/TaktInc/freer-effects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TaktInc/freer-effects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TaktInc/freer-effects/teams","hooks_url":"https://api.github.com/repos/TaktInc/freer-effects/hooks","issue_events_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/events{/number}","events_url":"https://api.github.com/repos/TaktInc/freer-effects/events","assignees_url":"https://api.github.com/repos/TaktInc/freer-effects/assignees{/user}","branches_url":"https://api.github.com/repos/TaktInc/freer-effects/branches{/branch}","tags_url":"https://api.github.com/repos/TaktInc/freer-effects/tags","blobs_url":"https://api.github.com/repos/TaktInc/freer-effects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TaktInc/freer-effects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TaktInc/freer-effects/git/refs{/sha}","trees_url":"https://api.github.com/repos/TaktInc/freer-effects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TaktInc/freer-effects/statuses/{sha}","languages_url":"https://api.github.com/repos/TaktInc/freer-effects/languages","stargazers_url":"https://api.github.com/repos/TaktInc/freer-effects/stargazers","contributors_url":"https://api.github.com/repos/TaktInc/freer-effects/contributors","subscribers_url":"https://api.github.com/repos/TaktInc/freer-effects/subscribers","subscription_url":"https://api.github.com/repos/TaktInc/freer-effects/subscription","commits_url":"https://api.github.com/repos/TaktInc/freer-effects/commits{/sha}","git_commits_url":"https://api.github.com/repos/TaktInc/freer-effects/git/commits{/sha}","comments_url":"https://api.github.com/repos/TaktInc/freer-effects/comments{/number}","issue_comment_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/comments{/number}","contents_url":"https://api.github.com/repos/TaktInc/freer-effects/contents/{+path}","compare_url":"https://api.github.com/repos/TaktInc/freer-effects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TaktInc/freer-effects/merges","archive_url":"https://api.github.com/repos/TaktInc/freer-effects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TaktInc/freer-effects/downloads","issues_url":"https://api.github.com/repos/TaktInc/freer-effects/issues{/number}","pulls_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls{/number}","milestones_url":"https://api.github.com/repos/TaktInc/freer-effects/milestones{/number}","notifications_url":"https://api.github.com/repos/TaktInc/freer-effects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TaktInc/freer-effects/labels{/name}","releases_url":"https://api.github.com/repos/TaktInc/freer-effects/releases{/id}","deployments_url":"https://api.github.com/repos/TaktInc/freer-effects/deployments","created_at":"2017-03-14T21:43:19Z","updated_at":"2017-03-14T21:43:20Z","pushed_at":"2017-05-03T03:42:01Z","git_url":"git://github.com/TaktInc/freer-effects.git","ssh_url":"git@github.com:TaktInc/freer-effects.git","clone_url":"https://github.com/TaktInc/freer-effects.git","svn_url":"https://github.com/TaktInc/freer-effects","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"TaktInc:master","ref":"master","sha":"84762417b7f8b727b9f0ffc64ffdfc0d69e2d8f7","user":{"login":"TaktInc","id":17728930,"avatar_url":"https://avatars0.githubusercontent.com/u/17728930?v=3","gravatar_id":"","url":"https://api.github.com/users/TaktInc","html_url":"https://github.com/TaktInc","followers_url":"https://api.github.com/users/TaktInc/followers","following_url":"https://api.github.com/users/TaktInc/following{/other_user}","gists_url":"https://api.github.com/users/TaktInc/gists{/gist_id}","starred_url":"https://api.github.com/users/TaktInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TaktInc/subscriptions","organizations_url":"https://api.github.com/users/TaktInc/orgs","repos_url":"https://api.github.com/users/TaktInc/repos","events_url":"https://api.github.com/users/TaktInc/events{/privacy}","received_events_url":"https://api.github.com/users/TaktInc/received_events","type":"Organization","site_admin":false},"repo":{"id":85000106,"name":"freer-effects","full_name":"TaktInc/freer-effects","owner":{"login":"TaktInc","id":17728930,"avatar_url":"https://avatars0.githubusercontent.com/u/17728930?v=3","gravatar_id":"","url":"https://api.github.com/users/TaktInc","html_url":"https://github.com/TaktInc","followers_url":"https://api.github.com/users/TaktInc/followers","following_url":"https://api.github.com/users/TaktInc/following{/other_user}","gists_url":"https://api.github.com/users/TaktInc/gists{/gist_id}","starred_url":"https://api.github.com/users/TaktInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TaktInc/subscriptions","organizations_url":"https://api.github.com/users/TaktInc/orgs","repos_url":"https://api.github.com/users/TaktInc/repos","events_url":"https://api.github.com/users/TaktInc/events{/privacy}","received_events_url":"https://api.github.com/users/TaktInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TaktInc/freer-effects","description":"An implementation of \"Freer Monads, More Extensible Effects\".","fork":true,"url":"https://api.github.com/repos/TaktInc/freer-effects","forks_url":"https://api.github.com/repos/TaktInc/freer-effects/forks","keys_url":"https://api.github.com/repos/TaktInc/freer-effects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TaktInc/freer-effects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TaktInc/freer-effects/teams","hooks_url":"https://api.github.com/repos/TaktInc/freer-effects/hooks","issue_events_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/events{/number}","events_url":"https://api.github.com/repos/TaktInc/freer-effects/events","assignees_url":"https://api.github.com/repos/TaktInc/freer-effects/assignees{/user}","branches_url":"https://api.github.com/repos/TaktInc/freer-effects/branches{/branch}","tags_url":"https://api.github.com/repos/TaktInc/freer-effects/tags","blobs_url":"https://api.github.com/repos/TaktInc/freer-effects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TaktInc/freer-effects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TaktInc/freer-effects/git/refs{/sha}","trees_url":"https://api.github.com/repos/TaktInc/freer-effects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TaktInc/freer-effects/statuses/{sha}","languages_url":"https://api.github.com/repos/TaktInc/freer-effects/languages","stargazers_url":"https://api.github.com/repos/TaktInc/freer-effects/stargazers","contributors_url":"https://api.github.com/repos/TaktInc/freer-effects/contributors","subscribers_url":"https://api.github.com/repos/TaktInc/freer-effects/subscribers","subscription_url":"https://api.github.com/repos/TaktInc/freer-effects/subscription","commits_url":"https://api.github.com/repos/TaktInc/freer-effects/commits{/sha}","git_commits_url":"https://api.github.com/repos/TaktInc/freer-effects/git/commits{/sha}","comments_url":"https://api.github.com/repos/TaktInc/freer-effects/comments{/number}","issue_comment_url":"https://api.github.com/repos/TaktInc/freer-effects/issues/comments{/number}","contents_url":"https://api.github.com/repos/TaktInc/freer-effects/contents/{+path}","compare_url":"https://api.github.com/repos/TaktInc/freer-effects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TaktInc/freer-effects/merges","archive_url":"https://api.github.com/repos/TaktInc/freer-effects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TaktInc/freer-effects/downloads","issues_url":"https://api.github.com/repos/TaktInc/freer-effects/issues{/number}","pulls_url":"https://api.github.com/repos/TaktInc/freer-effects/pulls{/number}","milestones_url":"https://api.github.com/repos/TaktInc/freer-effects/milestones{/number}","notifications_url":"https://api.github.com/repos/TaktInc/freer-effects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TaktInc/freer-effects/labels{/name}","releases_url":"https://api.github.com/repos/TaktInc/freer-effects/releases{/id}","deployments_url":"https://api.github.com/repos/TaktInc/freer-effects/deployments","created_at":"2017-03-14T21:43:19Z","updated_at":"2017-03-14T21:43:20Z","pushed_at":"2017-05-03T03:42:01Z","git_url":"git://github.com/TaktInc/freer-effects.git","ssh_url":"git@github.com:TaktInc/freer-effects.git","clone_url":"https://github.com/TaktInc/freer-effects.git","svn_url":"https://github.com/TaktInc/freer-effects","homepage":null,"size":242,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2"},"html":{"href":"https://github.com/TaktInc/freer-effects/pull/2"},"issue":{"href":"https://api.github.com/repos/TaktInc/freer-effects/issues/2"},"comments":{"href":"https://api.github.com/repos/TaktInc/freer-effects/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TaktInc/freer-effects/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/TaktInc/freer-effects/statuses/2731b436d41561f96cce13626b41cb58155d5637"}}}}
|
{
"id": 85000106,
"name": "TaktInc/freer-effects",
"url": "https://api.github.com/repos/TaktInc/freer-effects"
}
|
{
"id": 487050,
"login": "shlevy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/487050?",
"url": "https://api.github.com/users/shlevy"
}
|
{
"id": 17728930,
"login": "TaktInc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17728930?",
"url": "https://api.github.com/orgs/TaktInc"
}
| 2017-05-03T10:19:38 |
5800449543
|
{"actor":{"display_login":"shlevy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Unidata/MetPy/pulls/comments/101149511","pull_request_review_id":21870576,"id":101149511,"diff_hunk":"@@ -222,8 +222,8 @@ def lfc(pressure, temperature, dewpt):\n parcel_profile\n \"\"\"\n ideal_profile = parcel_profile(pressure, temperature[0], dewpt[0]).to('degC')\n- x, y = find_intersections(pressure, ideal_profile, temperature)\n- return x[0], y[0]\n+ x, y = find_intersections(pressure[1:], ideal_profile[1:], temperature[1:])\n+ return (x[0], y[0])","path":"metpy/calc/thermo.py","position":7,"original_position":7,"commit_id":"94eafffd9b9ae2feb4422e3f3f6be06cec7fe65d","original_commit_id":"94eafffd9b9ae2feb4422e3f3f6be06cec7fe65d","user":{"login":"jrleeman","id":325269,"avatar_url":"https://avatars.githubusercontent.com/u/325269?v=3","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false},"body":"Should we settle on a style? For example in `lcl` we `return (new_p, td)`","created_at":"2017-02-14T21:37:29Z","updated_at":"2017-02-14T21:37:29Z","html_url":"https://github.com/Unidata/MetPy/pull/320#discussion_r101149511","pull_request_url":"https://api.github.com/repos/Unidata/MetPy/pulls/320","_links":{"self":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/comments/101149511"},"html":{"href":"https://github.com/Unidata/MetPy/pull/320#discussion_r101149511"},"pull_request":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/320"}}},"pull_request":{"url":"https://api.github.com/repos/Unidata/MetPy/pulls/320","id":106195949,"html_url":"https://github.com/Unidata/MetPy/pull/320","diff_url":"https://github.com/Unidata/MetPy/pull/320.diff","patch_url":"https://github.com/Unidata/MetPy/pull/320.patch","issue_url":"https://api.github.com/repos/Unidata/MetPy/issues/320","number":320,"state":"open","locked":false,"title":"LFC fix","user":{"login":"jrleeman","id":325269,"avatar_url":"https://avatars.githubusercontent.com/u/325269?v=3","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false},"body":"Fixes the LFC calculation bug #319 ","created_at":"2017-02-14T21:29:32Z","updated_at":"2017-02-14T21:37:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5575c24eff04a41e6ea75986b06be5c9df0ae391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unidata/MetPy/pulls/320/commits","review_comments_url":"https://api.github.com/repos/Unidata/MetPy/pulls/320/comments","review_comment_url":"https://api.github.com/repos/Unidata/MetPy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unidata/MetPy/issues/320/comments","statuses_url":"https://api.github.com/repos/Unidata/MetPy/statuses/94eafffd9b9ae2feb4422e3f3f6be06cec7fe65d","head":{"label":"jrleeman:LFC_Fix","ref":"LFC_Fix","sha":"94eafffd9b9ae2feb4422e3f3f6be06cec7fe65d","user":{"login":"jrleeman","id":325269,"avatar_url":"https://avatars.githubusercontent.com/u/325269?v=3","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false},"repo":{"id":52739703,"name":"MetPy","full_name":"jrleeman/MetPy","owner":{"login":"jrleeman","id":325269,"avatar_url":"https://avatars.githubusercontent.com/u/325269?v=3","gravatar_id":"","url":"https://api.github.com/users/jrleeman","html_url":"https://github.com/jrleeman","followers_url":"https://api.github.com/users/jrleeman/followers","following_url":"https://api.github.com/users/jrleeman/following{/other_user}","gists_url":"https://api.github.com/users/jrleeman/gists{/gist_id}","starred_url":"https://api.github.com/users/jrleeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrleeman/subscriptions","organizations_url":"https://api.github.com/users/jrleeman/orgs","repos_url":"https://api.github.com/users/jrleeman/repos","events_url":"https://api.github.com/users/jrleeman/events{/privacy}","received_events_url":"https://api.github.com/users/jrleeman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrleeman/MetPy","description":"A Python Package for Meteorological Data","fork":true,"url":"https://api.github.com/repos/jrleeman/MetPy","forks_url":"https://api.github.com/repos/jrleeman/MetPy/forks","keys_url":"https://api.github.com/repos/jrleeman/MetPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrleeman/MetPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrleeman/MetPy/teams","hooks_url":"https://api.github.com/repos/jrleeman/MetPy/hooks","issue_events_url":"https://api.github.com/repos/jrleeman/MetPy/issues/events{/number}","events_url":"https://api.github.com/repos/jrleeman/MetPy/events","assignees_url":"https://api.github.com/repos/jrleeman/MetPy/assignees{/user}","branches_url":"https://api.github.com/repos/jrleeman/MetPy/branches{/branch}","tags_url":"https://api.github.com/repos/jrleeman/MetPy/tags","blobs_url":"https://api.github.com/repos/jrleeman/MetPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrleeman/MetPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrleeman/MetPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrleeman/MetPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrleeman/MetPy/statuses/{sha}","languages_url":"https://api.github.com/repos/jrleeman/MetPy/languages","stargazers_url":"https://api.github.com/repos/jrleeman/MetPy/stargazers","contributors_url":"https://api.github.com/repos/jrleeman/MetPy/contributors","subscribers_url":"https://api.github.com/repos/jrleeman/MetPy/subscribers","subscription_url":"https://api.github.com/repos/jrleeman/MetPy/subscription","commits_url":"https://api.github.com/repos/jrleeman/MetPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrleeman/MetPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrleeman/MetPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrleeman/MetPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrleeman/MetPy/contents/{+path}","compare_url":"https://api.github.com/repos/jrleeman/MetPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrleeman/MetPy/merges","archive_url":"https://api.github.com/repos/jrleeman/MetPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrleeman/MetPy/downloads","issues_url":"https://api.github.com/repos/jrleeman/MetPy/issues{/number}","pulls_url":"https://api.github.com/repos/jrleeman/MetPy/pulls{/number}","milestones_url":"https://api.github.com/repos/jrleeman/MetPy/milestones{/number}","notifications_url":"https://api.github.com/repos/jrleeman/MetPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrleeman/MetPy/labels{/name}","releases_url":"https://api.github.com/repos/jrleeman/MetPy/releases{/id}","deployments_url":"https://api.github.com/repos/jrleeman/MetPy/deployments","created_at":"2016-02-28T19:41:32Z","updated_at":"2016-02-28T19:41:33Z","pushed_at":"2017-02-14T21:29:13Z","git_url":"git://github.com/jrleeman/MetPy.git","ssh_url":"git@github.com:jrleeman/MetPy.git","clone_url":"https://github.com/jrleeman/MetPy.git","svn_url":"https://github.com/jrleeman/MetPy","homepage":"","size":83963,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unidata:master","ref":"master","sha":"306419c59c3a0e571ad9031658548199093faaa0","user":{"login":"Unidata","id":613345,"avatar_url":"https://avatars.githubusercontent.com/u/613345?v=3","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"repo":{"id":1409621,"name":"MetPy","full_name":"Unidata/MetPy","owner":{"login":"Unidata","id":613345,"avatar_url":"https://avatars.githubusercontent.com/u/613345?v=3","gravatar_id":"","url":"https://api.github.com/users/Unidata","html_url":"https://github.com/Unidata","followers_url":"https://api.github.com/users/Unidata/followers","following_url":"https://api.github.com/users/Unidata/following{/other_user}","gists_url":"https://api.github.com/users/Unidata/gists{/gist_id}","starred_url":"https://api.github.com/users/Unidata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unidata/subscriptions","organizations_url":"https://api.github.com/users/Unidata/orgs","repos_url":"https://api.github.com/users/Unidata/repos","events_url":"https://api.github.com/users/Unidata/events{/privacy}","received_events_url":"https://api.github.com/users/Unidata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unidata/MetPy","description":"A Python Package for Meteorological Data","fork":false,"url":"https://api.github.com/repos/Unidata/MetPy","forks_url":"https://api.github.com/repos/Unidata/MetPy/forks","keys_url":"https://api.github.com/repos/Unidata/MetPy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unidata/MetPy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unidata/MetPy/teams","hooks_url":"https://api.github.com/repos/Unidata/MetPy/hooks","issue_events_url":"https://api.github.com/repos/Unidata/MetPy/issues/events{/number}","events_url":"https://api.github.com/repos/Unidata/MetPy/events","assignees_url":"https://api.github.com/repos/Unidata/MetPy/assignees{/user}","branches_url":"https://api.github.com/repos/Unidata/MetPy/branches{/branch}","tags_url":"https://api.github.com/repos/Unidata/MetPy/tags","blobs_url":"https://api.github.com/repos/Unidata/MetPy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unidata/MetPy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unidata/MetPy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unidata/MetPy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unidata/MetPy/statuses/{sha}","languages_url":"https://api.github.com/repos/Unidata/MetPy/languages","stargazers_url":"https://api.github.com/repos/Unidata/MetPy/stargazers","contributors_url":"https://api.github.com/repos/Unidata/MetPy/contributors","subscribers_url":"https://api.github.com/repos/Unidata/MetPy/subscribers","subscription_url":"https://api.github.com/repos/Unidata/MetPy/subscription","commits_url":"https://api.github.com/repos/Unidata/MetPy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unidata/MetPy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unidata/MetPy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unidata/MetPy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unidata/MetPy/contents/{+path}","compare_url":"https://api.github.com/repos/Unidata/MetPy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unidata/MetPy/merges","archive_url":"https://api.github.com/repos/Unidata/MetPy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unidata/MetPy/downloads","issues_url":"https://api.github.com/repos/Unidata/MetPy/issues{/number}","pulls_url":"https://api.github.com/repos/Unidata/MetPy/pulls{/number}","milestones_url":"https://api.github.com/repos/Unidata/MetPy/milestones{/number}","notifications_url":"https://api.github.com/repos/Unidata/MetPy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unidata/MetPy/labels{/name}","releases_url":"https://api.github.com/repos/Unidata/MetPy/releases{/id}","deployments_url":"https://api.github.com/repos/Unidata/MetPy/deployments","created_at":"2011-02-25T04:20:25Z","updated_at":"2017-02-06T23:43:42Z","pushed_at":"2017-02-14T21:29:32Z","git_url":"git://github.com/Unidata/MetPy.git","ssh_url":"git@github.com:Unidata/MetPy.git","clone_url":"https://github.com/Unidata/MetPy.git","svn_url":"https://github.com/Unidata/MetPy","homepage":"https://unidata.github.io/MetPy","size":92464,"stargazers_count":118,"watchers_count":118,"language":"Jupyter Notebook","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"open_issues_count":87,"forks":67,"open_issues":87,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/320"},"html":{"href":"https://github.com/Unidata/MetPy/pull/320"},"issue":{"href":"https://api.github.com/repos/Unidata/MetPy/issues/320"},"comments":{"href":"https://api.github.com/repos/Unidata/MetPy/issues/320/comments"},"review_comments":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/320/comments"},"review_comment":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unidata/MetPy/pulls/320/commits"},"statuses":{"href":"https://api.github.com/repos/Unidata/MetPy/statuses/94eafffd9b9ae2feb4422e3f3f6be06cec7fe65d"}}}}
|
{
"id": 1409621,
"name": "Unidata/MetPy",
"url": "https://api.github.com/repos/Unidata/MetPy"
}
|
{
"id": 325269,
"login": "jrleeman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/325269?",
"url": "https://api.github.com/users/jrleeman"
}
|
{
"id": 613345,
"login": "Unidata",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/613345?",
"url": "https://api.github.com/orgs/Unidata"
}
| 2017-02-14T21:37:29 |
5324728412
|
{"actor":{"display_login":"jrleeman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/132216136","pull_request_review_id":55272604,"id":132216136,"diff_hunk":"@@ -2,7 +2,61 @@\n [](https://codecov.io/gh/allenai/allennlp)\n # AllenNLP\n \n-A [Apache 2.0](https://github.com/allenai/allennlp/blob/master/LICENSE) natural language processing toolkit using state-of-the-art deep learning models.\n+An [Apache 2.0](https://github.com/allenai/allennlp/blob/master/LICENSE) NLP research library, built on PyTorch,\n+for developing state-of-the-art deep learning models.","path":"README.md","position":6,"original_position":6,"commit_id":"e99b139aa8f7a81f63a8af93f01914441830c03c","original_commit_id":"a00c91640ca0efdf0349b5f30745ac731adee1f9","user":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"body":"\"for developing state-of-the-art NLP models using deep learning on a wide variety of linguistic tasks.\"","created_at":"2017-08-09T15:18:39Z","updated_at":"2017-08-09T15:37:50Z","html_url":"https://github.com/allenai/allennlp/pull/108#discussion_r132216136","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/132216136"},"html":{"href":"https://github.com/allenai/allennlp/pull/108#discussion_r132216136"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/108","id":134784128,"html_url":"https://github.com/allenai/allennlp/pull/108","diff_url":"https://github.com/allenai/allennlp/pull/108.diff","patch_url":"https://github.com/allenai/allennlp/pull/108.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/108","number":108,"state":"open","locked":false,"title":"Add content to README.","user":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-08T23:58:45Z","updated_at":"2017-08-09T15:37:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d66e979e90cbe3a2142b53d4fe330a3bc097e1d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joelgrus","id":1308313,"avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/108/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/108/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/108/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/e99b139aa8f7a81f63a8af93f01914441830c03c","head":{"label":"schmmd:readme","ref":"readme","sha":"e99b139aa8f7a81f63a8af93f01914441830c03c","user":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"repo":{"id":95493347,"name":"allennlp","full_name":"schmmd/allennlp","owner":{"login":"schmmd","id":954798,"avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/schmmd/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/schmmd/allennlp","forks_url":"https://api.github.com/repos/schmmd/allennlp/forks","keys_url":"https://api.github.com/repos/schmmd/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmmd/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmmd/allennlp/teams","hooks_url":"https://api.github.com/repos/schmmd/allennlp/hooks","issue_events_url":"https://api.github.com/repos/schmmd/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/schmmd/allennlp/events","assignees_url":"https://api.github.com/repos/schmmd/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/schmmd/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/schmmd/allennlp/tags","blobs_url":"https://api.github.com/repos/schmmd/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmmd/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmmd/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmmd/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmmd/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/schmmd/allennlp/languages","stargazers_url":"https://api.github.com/repos/schmmd/allennlp/stargazers","contributors_url":"https://api.github.com/repos/schmmd/allennlp/contributors","subscribers_url":"https://api.github.com/repos/schmmd/allennlp/subscribers","subscription_url":"https://api.github.com/repos/schmmd/allennlp/subscription","commits_url":"https://api.github.com/repos/schmmd/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmmd/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmmd/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmmd/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmmd/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/schmmd/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmmd/allennlp/merges","archive_url":"https://api.github.com/repos/schmmd/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmmd/allennlp/downloads","issues_url":"https://api.github.com/repos/schmmd/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/schmmd/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/schmmd/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/schmmd/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmmd/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/schmmd/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/schmmd/allennlp/deployments","created_at":"2017-06-26T22:04:12Z","updated_at":"2017-06-26T22:04:13Z","pushed_at":"2017-08-09T15:28:51Z","git_url":"git://github.com/schmmd/allennlp.git","ssh_url":"git@github.com:schmmd/allennlp.git","clone_url":"https://github.com/schmmd/allennlp.git","svn_url":"https://github.com/schmmd/allennlp","homepage":null,"size":606,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"d9e2565f8a8ba055cd80ca50fddc73f28cf7dbd1","user":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2017-08-09T15:16:05Z","pushed_at":"2017-08-09T15:28:52Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"","size":1715,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/108"},"html":{"href":"https://github.com/allenai/allennlp/pull/108"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/108"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/e99b139aa8f7a81f63a8af93f01914441830c03c"}}}}
|
{
"id": 91356408,
"name": "allenai/allennlp",
"url": "https://api.github.com/repos/allenai/allennlp"
}
|
{
"id": 16001974,
"login": "DeNeutoy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16001974?",
"url": "https://api.github.com/users/DeNeutoy"
}
|
{
"id": 5667695,
"login": "allenai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5667695?",
"url": "https://api.github.com/orgs/allenai"
}
| 2017-08-09T15:18:39 |
6425559157
|
{"actor":{"display_login":"DeNeutoy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/153706105","pull_request_review_id":79742566,"id":153706105,"diff_hunk":"@@ -0,0 +1,268 @@\n+from typing import Tuple, Union, Optional, Callable\n+import torch\n+\n+from torch.nn.utils.rnn import pack_padded_sequence, PackedSequence\n+from allennlp.nn.util import get_lengths_from_binary_sequence_mask, sort_batch_by_length\n+\n+# We have two types here for the state, because storing the state in something\n+# which is Iterable (like a tuple, below), is helpful for internal manipulation\n+# - however, the states are consumed as either Tensors or a Tuple of Tensors, so\n+# returning them in this format is unhelpful.\n+RnnState = Union[torch.Tensor, Tuple[torch.Tensor, torch.Tensor]] # pylint: disable=invalid-name\n+RnnStateStorage = Tuple[torch.Tensor, ...] # pylint: disable=invalid-name\n+\n+\n+class _EncoderBase(torch.nn.Module):\n+ # pylint: disable=abstract-method\n+ \"\"\"\n+ This abstract class serves as a base for the 3 ``Encoder`` abstractions in AllenNLP.\n+ - :class:`~allennlp.modules.seq2seq_encoders.Seq2SeqEncoders`\n+ - :class:`~allennlp.modules.seq2vec_encoders.Seq2VecEncoders`\n+ - :class:`~allennlp.modules.seq2stack_encoders.Seq2StackEncoders`\n+\n+ These classes can be inherited by any :class:`~torch.nn.Module` which implements\n+ one of these APIs.\n+\n+ Additionally, this class provides functionality for sorting sequences by length\n+ so they can be consumed by Pytorch RNN classes, which require their inputs to be\n+ sorted by length. Finally, it also provides optional statefulness to all of it's\n+ subclasses by allowing the caching and retrieving of the hidden states of RNNs.\n+ \"\"\"\n+ def __init__(self, stateful: bool = False) -> None:\n+ super(_EncoderBase, self).__init__()\n+ self._stateful = stateful\n+ self._states: Optional[RnnStateStorage] = None\n+\n+ def sort_and_run_forward(self,\n+ module: Callable[[PackedSequence, Optional[RnnState]],\n+ Tuple[Union[PackedSequence, torch.Tensor], RnnState]],\n+ inputs: torch.Tensor,\n+ mask: torch.Tensor,\n+ hidden_state: Optional[RnnState] = None):\n+ \"\"\"\n+ This function exists because Pytorch RNNs require that their inputs are sorted\n+ before being passed as input. As all of our Seq2xxxEncoders use this functionality,\n+ it is provided in a base class. This method can be called on any module which\n+ takes as input a ``PackedSequence`` and some hidden_state, which can either be a\n+ tuple of tensors or a tensor.\n+\n+ As all of our Seq2xxxEncoders have different return types, we return `sorted`\n+ outputs from the module which is called directly. Additionally, we return the\n+ indices into the batch dimension required to restore the tensor to it's correct,\n+ unsorted order and the number of valid batch elements (i.e the number of elements\n+ in the batch which are not completely masked). This un-sorting and re-padding\n+ of the module outputs is left to the subclasses because their outputs have different\n+ types and handling them smoothly here is difficult.\n+\n+ Parameters\n+ ----------\n+ module : ``Callable[[PackedSequence, Optional[RnnState]],\n+ Tuple[Union[PackedSequence, torch.Tensor], RnnState]]``, required.\n+ A function to run on the inputs. In most cases, this is a ``torch.nn.Module``.\n+ inputs : ``torch.Tensor``, required.\n+ A tensor of shape ``(batch_size, sequence_length, embedding_size)`` representing\n+ the inputs to the Encoder.\n+ mask : ``torch.Tensor``, required.\n+ A tensor of shape ``(batch_size, sequence_length)``, representing masked and\n+ non-masked elements of the sequence for each element in the batch.\n+ hidden_state : ``Optional[RnnState]``, (default = None).\n+\n+ Returns\n+ -------\n+ module_output : ``Union[torch.Tensor, PackedSequence]``.\n+ A Tensor or PackedSequence representing the output of the Pytorch Module.\n+ final_states : ``Optional[RnnState]``\n+ A Tensor representing the hidden state of the Pytorch Module. This can either\n+ be a single tensor of shape (num_layers, batch_size, encoding_size), for instance in\n+ the case of a GRU, or a tuple of tensors, such as those required for an LSTM.\n+ restoration_indices : ``torch.LongTensor``\n+ A tensor of shape ``(batch_size,)``, describing the re-indexing required to transform\n+ the outputs back to their original batch order.\n+ num_valid : ``int``\n+ The number of valid batches used in the call to the module. This is returned so\n+ that the outputs of the module can be padded back to their original batch shape,\n+ if we altered it due to fully padded batch elements.\n+ \"\"\"\n+ # In some circumstances you may have sequences of zero length. ``pack_padded_sequence``\n+ # requires all sequence lengths to be > 0, so remove sequences of zero length before\n+ # calling self._module, then fill with zeros.\n+\n+ # First count how many sequences are empty.\n+ batch_size, _ = mask.size()\n+ num_valid = torch.sum(mask[:, 0]).int().data[0]\n+\n+ sequence_lengths = get_lengths_from_binary_sequence_mask(mask)\n+ sorted_inputs, sorted_sequence_lengths, restoration_indices, sorting_indices =\\\n+ sort_batch_by_length(inputs, sequence_lengths)\n+\n+ # Now create a PackedSequence with only the non-empty, sorted sequences.\n+ packed_sequence_input = pack_padded_sequence(sorted_inputs[:num_valid, :, :],\n+ sorted_sequence_lengths[:num_valid].data.tolist(),\n+ batch_first=True)\n+ # Prepare the initial states.\n+ if not self._stateful:\n+ initial_states = hidden_state\n+ else:\n+ initial_states = self._get_initial_states(batch_size, num_valid, sorting_indices)\n+\n+ # Actually call the module on the sorted PackedSequence.\n+ module_output, final_states = module(packed_sequence_input, initial_states)\n+\n+ return module_output, final_states, restoration_indices, num_valid\n+\n+ def _get_initial_states(self,\n+ batch_size: int,\n+ num_valid: int,\n+ sorting_indices: torch.LongTensor) -> Optional[RnnState]:\n+ \"\"\"\n+ Parameters\n+ ----------\n+ batch_size : ``int``, required.\n+ The batch size can change size across calls to stateful RNNs, so we need\n+ to know if we need to expand or shrink the states before returning them.\n+ Expanded states will be set to zero.\n+ num_valid : ``int``, required.\n+ The batch may contain completely padded sequences which get removed before\n+ the sequence is passed through the encoder. We also need to clip these off\n+ of the state too.\n+ sorting_indices ``torch.LongTensor``, required.\n+ Pytorch RNNs take sequences sorted by length. When we return the states to be\n+ used for a given call to ``module.forward``, we need the states to match up to\n+ the sorted sequences, so before returning them, we sort the states using the\n+ same indices used to sort the sequences.\n+\n+ Returns\n+ -------\n+ This method has a complex return type because it has to deal with the first time it\n+ is called, when it has no state, and the fact that types of RNN have heterogeneous\n+ states.\n+\n+ If it is the first time the module has been called, it returns ``None``, regardless\n+ of the type of the ``Module``.\n+\n+ Otherwise, for LSTMs, it returns a tuple of ``torch.Tensors`` with shape\n+ ``(num_layers, num_valid, state_size)`` and ``(num_layers, num_valid, memory_size)``","path":"allennlp/modules/encoder_base.py","position":144,"original_position":144,"commit_id":"98a168f24793004f8e37f976d9508b5a4d05bfd3","original_commit_id":"98a168f24793004f8e37f976d9508b5a4d05bfd3","user":{"login":"matt-gardner","id":3291951,"avatar_url":"https://avatars2.githubusercontent.com/u/3291951?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-gardner","html_url":"https://github.com/matt-gardner","followers_url":"https://api.github.com/users/matt-gardner/followers","following_url":"https://api.github.com/users/matt-gardner/following{/other_user}","gists_url":"https://api.github.com/users/matt-gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-gardner/subscriptions","organizations_url":"https://api.github.com/users/matt-gardner/orgs","repos_url":"https://api.github.com/users/matt-gardner/repos","events_url":"https://api.github.com/users/matt-gardner/events{/privacy}","received_events_url":"https://api.github.com/users/matt-gardner/received_events","type":"User","site_admin":false},"body":"An explanation for these shapes is in order, I think - why is `num_layers` first? This is particularly important because you can pass in an initial hidden state to the `forward` method. I suppose adding this explanation above, where the docs for the hidden state were missing, would be enough.","created_at":"2017-11-29T07:03:10Z","updated_at":"2017-11-29T07:46:47Z","html_url":"https://github.com/allenai/allennlp/pull/518#discussion_r153706105","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/153706105"},"html":{"href":"https://github.com/allenai/allennlp/pull/518#discussion_r153706105"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/518","id":153770527,"html_url":"https://github.com/allenai/allennlp/pull/518","diff_url":"https://github.com/allenai/allennlp/pull/518.diff","patch_url":"https://github.com/allenai/allennlp/pull/518.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/518","number":518,"state":"open","locked":false,"title":"Encoder abstractions","user":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"body":"- Adds a `Seq2StackEncoder` abstraction\r\n- Pulls out the sorting of the batch, forward pass through the model and statefulness for all encoders into a `_EncoderBase` class. \r\n- Refactors `Seq2SeqEncoders` and `Seq2StackEncoders` to allow them to be stateful.\r\n\r\nDepends on #509 \r\n","created_at":"2017-11-21T00:41:43Z","updated_at":"2017-11-29T07:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f32eb2ef40b6eb3bfa801d12d56e384988a7710c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/518/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/518/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/518/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/98a168f24793004f8e37f976d9508b5a4d05bfd3","head":{"label":"DeNeutoy:encoder-abstractions","ref":"encoder-abstractions","sha":"98a168f24793004f8e37f976d9508b5a4d05bfd3","user":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"repo":{"id":95490219,"name":"allennlp","full_name":"DeNeutoy/allennlp","owner":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DeNeutoy/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/DeNeutoy/allennlp","forks_url":"https://api.github.com/repos/DeNeutoy/allennlp/forks","keys_url":"https://api.github.com/repos/DeNeutoy/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeNeutoy/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeNeutoy/allennlp/teams","hooks_url":"https://api.github.com/repos/DeNeutoy/allennlp/hooks","issue_events_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/DeNeutoy/allennlp/events","assignees_url":"https://api.github.com/repos/DeNeutoy/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/DeNeutoy/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/DeNeutoy/allennlp/tags","blobs_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeNeutoy/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/DeNeutoy/allennlp/languages","stargazers_url":"https://api.github.com/repos/DeNeutoy/allennlp/stargazers","contributors_url":"https://api.github.com/repos/DeNeutoy/allennlp/contributors","subscribers_url":"https://api.github.com/repos/DeNeutoy/allennlp/subscribers","subscription_url":"https://api.github.com/repos/DeNeutoy/allennlp/subscription","commits_url":"https://api.github.com/repos/DeNeutoy/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeNeutoy/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeNeutoy/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/DeNeutoy/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeNeutoy/allennlp/merges","archive_url":"https://api.github.com/repos/DeNeutoy/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeNeutoy/allennlp/downloads","issues_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/DeNeutoy/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/DeNeutoy/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/DeNeutoy/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeNeutoy/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/DeNeutoy/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/DeNeutoy/allennlp/deployments","created_at":"2017-06-26T21:16:53Z","updated_at":"2017-06-26T21:16:54Z","pushed_at":"2017-11-28T00:21:25Z","git_url":"git://github.com/DeNeutoy/allennlp.git","ssh_url":"git@github.com:DeNeutoy/allennlp.git","clone_url":"https://github.com/DeNeutoy/allennlp.git","svn_url":"https://github.com/DeNeutoy/allennlp","homepage":null,"size":6275,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"e82f225d1ff157cd896092a9cf8ec414e9277282","user":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2017-11-28T21:02:09Z","pushed_at":"2017-11-29T05:37:31Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":5958,"stargazers_count":1091,"watchers_count":1091,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":125,"open_issues":54,"watchers":1091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518"},"html":{"href":"https://github.com/allenai/allennlp/pull/518"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/518"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/98a168f24793004f8e37f976d9508b5a4d05bfd3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 91356408,
"name": "allenai/allennlp",
"url": "https://api.github.com/repos/allenai/allennlp"
}
|
{
"id": 3291951,
"login": "matt-gardner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3291951?",
"url": "https://api.github.com/users/matt-gardner"
}
|
{
"id": 5667695,
"login": "allenai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5667695?",
"url": "https://api.github.com/orgs/allenai"
}
| 2017-11-29T07:03:10 |
6917275367
|
{"actor":{"display_login":"matt-gardner"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/almende/vis/pulls/comments/106787509","pull_request_review_id":27729916,"id":106787509,"diff_hunk":"@@ -0,0 +1,99 @@\n+# How we use github labels\n+\n+*Because only team-mermbers can add and change labels this document is mainly for maintainers, but also for users to understand how we use labels.*\n+\n+*It is important to also label old and closed issues uniformly to be able to export them later r.g. if the project gets separated into multiple components.*\n+\n+\n+## Issue Types\n+If an issue was created it always MUST be labeled as one of the following issue types:\n+\n+### `Question`\n+The author has a general or very specific question.<br>\n+If it is a general question how to use vis.js the issues should be closed immediately with a reference to [stackoverflow](https://stackoverflow.com/questions/tagged/vis.js).<br>\n+Specific question or hard problems should stay open.<br>\n+Questions should be closes within 3 month.\n+\n+### `Problem`\n+This issues points to a potential bug that needs to be confirmed.<br>\n+If the problem is probably in the users code it should be better labeled as `Question`.<br>\n+The support-Team should try to reproduce this issue and than close it or mark it as `Confirmed Bug`:<br>\n+`Problem` -> `Confirmed Bug` --> `Work In Progress` --> `Fixed awaiting release`\n+\n+### `Feature-Request`\n+This issue proposes a new feature or a change of existing functionality. Issues that are very very unlikely to get implemented should be closed.<br>\n+This label is often used together with `Requires breaking change`: <br>\n+`Feature-Request` --> `Work In Progress` --> `Fixed awaiting release`\n+\n+### `wontfix`\n+This issues is e.g. only for discussing a topic and is not handled in the usual issue process.\n+\n+\n+## Graph type\n+All issues MUST have one of the following type-labels. This labels usually are usually mutually exclusive:\n+\n+### `Network`\n+Concerns the Timeline-Graph implementation.\n+\n+### `Timeline`\n+Concerns the Timeline-Graph implementation.\n+\n+### `Graph2D`\n+Concerns the 2D-Graph implementation.\n+\n+### `Graph3D`\n+Concerns the 3D-Graph implementation.\n+\n+### `DataSet`\n+Concerns the DataSet implementation.\n+\n+### `Docs`\n+This issue concerns only the documentation.<br>\n+If an existing issue is documented wrongly this is a `Problem` in the component and not a `docs` issue.<br>\n+This can be used for typos or requests for a improvement of the docs.\n+\n+### `source/non-public API`\n+This issues is just for discussion or is concerning the build-process, the code-style or something similar.\n+\n+\n+## Additional labels\n+\n+### `Duplicate`\n+This issues is a duplicate of an existing issue. It should be closed naming the original issue it is a duplicate of.\n+\n+### `Confirmed Bug`\n+This issue was reported as `Problem` but the issue was reproducible and is now a confirmed bug.\n+\n+### `Work In Progress`\n+Someone is working on this issue or an PR already exists and needs to be reviewed.<br>\n+\n+### `Fixed awaiting release`\n+This Issues was fixed or implemented in the \"develop\" branch to mark issues that have been fixed in development but are not released yet and therefore should be still open.<br>\n+This issues should be closed if after the\n+\n+### `For everyone!`\n+This is a good issue to start working on if you are new to vis.js and want to help.<br>\n+This label is also used for labels that may concern a lot of vis.js users.\n+\n+### `IE / Edge`\n+This is issues concerns a problem in Microsoft Internet Explorer or the Edge browser.<br>\n+\n+### `Issue Inactive`\n+Issues marked as `question` or `problem` get marked as inactive if the author is not responsive or the topic is old.<br>\n+If an issues is marked as inactive for about 2 weeks it can be closed without any hesitation.\n+\n+### `PRIORITY`\n+Normally this is used for major Bugs. There should only exist one or two issues marked as PRIORITY at the same time.<br>\n+This issues need to be handled before all others.\n+\n+### `Requires breaking change`\n+A lot of code needs to be changed to implement this. This is maybe something for a major release or something for someone with a lot of time on their hands :-)\n+\n+### `invalid`\n+This is a non-issue.<br>\n+Maybe somebody just created an empty issue, picked the wrong project or something like this.<br>\n+This can also be used for pull-request to a non-develop branch oder something similar.<br>\n+This issue or PR should be closed immediately.","path":"misc/labels.md","position":96,"original_position":96,"commit_id":"fb071580dd35b7955cbc21281f98743ecda7020a","original_commit_id":"fb071580dd35b7955cbc21281f98743ecda7020a","user":{"login":"Tooa","id":5375334,"avatar_url":"https://avatars3.githubusercontent.com/u/5375334?v=3","gravatar_id":"","url":"https://api.github.com/users/Tooa","html_url":"https://github.com/Tooa","followers_url":"https://api.github.com/users/Tooa/followers","following_url":"https://api.github.com/users/Tooa/following{/other_user}","gists_url":"https://api.github.com/users/Tooa/gists{/gist_id}","starred_url":"https://api.github.com/users/Tooa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tooa/subscriptions","organizations_url":"https://api.github.com/users/Tooa/orgs","repos_url":"https://api.github.com/users/Tooa/repos","events_url":"https://api.github.com/users/Tooa/events{/privacy}","received_events_url":"https://api.github.com/users/Tooa/received_events","type":"User","site_admin":false},"body":"Either pull-request or pull request. Or pull request (PR) in the first place and then PR. ","created_at":"2017-03-18T18:19:47Z","updated_at":"2017-03-18T18:21:23Z","html_url":"https://github.com/almende/vis/pull/2873#discussion_r106787509","pull_request_url":"https://api.github.com/repos/almende/vis/pulls/2873","_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/comments/106787509"},"html":{"href":"https://github.com/almende/vis/pull/2873#discussion_r106787509"},"pull_request":{"href":"https://api.github.com/repos/almende/vis/pulls/2873"}}},"pull_request":{"url":"https://api.github.com/repos/almende/vis/pulls/2873","id":111408751,"html_url":"https://github.com/almende/vis/pull/2873","diff_url":"https://github.com/almende/vis/pull/2873.diff","patch_url":"https://github.com/almende/vis/pull/2873.patch","issue_url":"https://api.github.com/repos/almende/vis/issues/2873","number":2873,"state":"open","locked":false,"title":"added documentation on how labels are used","user":{"login":"mojoaxel","id":600565,"avatar_url":"https://avatars1.githubusercontent.com/u/600565?v=3","gravatar_id":"","url":"https://api.github.com/users/mojoaxel","html_url":"https://github.com/mojoaxel","followers_url":"https://api.github.com/users/mojoaxel/followers","following_url":"https://api.github.com/users/mojoaxel/following{/other_user}","gists_url":"https://api.github.com/users/mojoaxel/gists{/gist_id}","starred_url":"https://api.github.com/users/mojoaxel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojoaxel/subscriptions","organizations_url":"https://api.github.com/users/mojoaxel/orgs","repos_url":"https://api.github.com/users/mojoaxel/repos","events_url":"https://api.github.com/users/mojoaxel/events{/privacy}","received_events_url":"https://api.github.com/users/mojoaxel/received_events","type":"User","site_admin":false},"body":"This is meant as a basis for discussion and improvement.","created_at":"2017-03-18T12:31:11Z","updated_at":"2017-03-18T18:21:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19ba392ec62ad54c2941afb61c496f160cad3bc1","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/almende/vis/milestones/6","html_url":"https://github.com/almende/vis/milestone/6","labels_url":"https://api.github.com/repos/almende/vis/milestones/6/labels","id":2346986,"number":6,"title":"Minor Release v4.20","description":"","creator":{"login":"mojoaxel","id":600565,"avatar_url":"https://avatars1.githubusercontent.com/u/600565?v=3","gravatar_id":"","url":"https://api.github.com/users/mojoaxel","html_url":"https://github.com/mojoaxel","followers_url":"https://api.github.com/users/mojoaxel/followers","following_url":"https://api.github.com/users/mojoaxel/following{/other_user}","gists_url":"https://api.github.com/users/mojoaxel/gists{/gist_id}","starred_url":"https://api.github.com/users/mojoaxel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojoaxel/subscriptions","organizations_url":"https://api.github.com/users/mojoaxel/orgs","repos_url":"https://api.github.com/users/mojoaxel/repos","events_url":"https://api.github.com/users/mojoaxel/events{/privacy}","received_events_url":"https://api.github.com/users/mojoaxel/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":0,"state":"open","created_at":"2017-02-24T21:47:06Z","updated_at":"2017-03-18T16:04:12Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/almende/vis/pulls/2873/commits","review_comments_url":"https://api.github.com/repos/almende/vis/pulls/2873/comments","review_comment_url":"https://api.github.com/repos/almende/vis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almende/vis/issues/2873/comments","statuses_url":"https://api.github.com/repos/almende/vis/statuses/fb071580dd35b7955cbc21281f98743ecda7020a","head":{"label":"almende:labels","ref":"labels","sha":"fb071580dd35b7955cbc21281f98743ecda7020a","user":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"repo":{"id":9467421,"name":"vis","full_name":"almende/vis","owner":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almende/vis","description":"Dynamic, browser-based visualization library","fork":false,"url":"https://api.github.com/repos/almende/vis","forks_url":"https://api.github.com/repos/almende/vis/forks","keys_url":"https://api.github.com/repos/almende/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almende/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almende/vis/teams","hooks_url":"https://api.github.com/repos/almende/vis/hooks","issue_events_url":"https://api.github.com/repos/almende/vis/issues/events{/number}","events_url":"https://api.github.com/repos/almende/vis/events","assignees_url":"https://api.github.com/repos/almende/vis/assignees{/user}","branches_url":"https://api.github.com/repos/almende/vis/branches{/branch}","tags_url":"https://api.github.com/repos/almende/vis/tags","blobs_url":"https://api.github.com/repos/almende/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almende/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almende/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/almende/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almende/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/almende/vis/languages","stargazers_url":"https://api.github.com/repos/almende/vis/stargazers","contributors_url":"https://api.github.com/repos/almende/vis/contributors","subscribers_url":"https://api.github.com/repos/almende/vis/subscribers","subscription_url":"https://api.github.com/repos/almende/vis/subscription","commits_url":"https://api.github.com/repos/almende/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/almende/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/almende/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/almende/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/almende/vis/contents/{+path}","compare_url":"https://api.github.com/repos/almende/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almende/vis/merges","archive_url":"https://api.github.com/repos/almende/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almende/vis/downloads","issues_url":"https://api.github.com/repos/almende/vis/issues{/number}","pulls_url":"https://api.github.com/repos/almende/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/almende/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/almende/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almende/vis/labels{/name}","releases_url":"https://api.github.com/repos/almende/vis/releases{/id}","deployments_url":"https://api.github.com/repos/almende/vis/deployments","created_at":"2013-04-16T08:01:02Z","updated_at":"2017-03-18T13:06:10Z","pushed_at":"2017-03-18T16:04:30Z","git_url":"git://github.com/almende/vis.git","ssh_url":"git@github.com:almende/vis.git","clone_url":"https://github.com/almende/vis.git","svn_url":"https://github.com/almende/vis","homepage":"http://visjs.org","size":133202,"stargazers_count":4875,"watchers_count":4875,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":853,"mirror_url":null,"open_issues_count":314,"forks":853,"open_issues":314,"watchers":4875,"default_branch":"master"}},"base":{"label":"almende:develop","ref":"develop","sha":"4f97bc871c7803f5ab182f761715d0c876570842","user":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"repo":{"id":9467421,"name":"vis","full_name":"almende/vis","owner":{"login":"almende","id":1436571,"avatar_url":"https://avatars3.githubusercontent.com/u/1436571?v=3","gravatar_id":"","url":"https://api.github.com/users/almende","html_url":"https://github.com/almende","followers_url":"https://api.github.com/users/almende/followers","following_url":"https://api.github.com/users/almende/following{/other_user}","gists_url":"https://api.github.com/users/almende/gists{/gist_id}","starred_url":"https://api.github.com/users/almende/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almende/subscriptions","organizations_url":"https://api.github.com/users/almende/orgs","repos_url":"https://api.github.com/users/almende/repos","events_url":"https://api.github.com/users/almende/events{/privacy}","received_events_url":"https://api.github.com/users/almende/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almende/vis","description":"Dynamic, browser-based visualization library","fork":false,"url":"https://api.github.com/repos/almende/vis","forks_url":"https://api.github.com/repos/almende/vis/forks","keys_url":"https://api.github.com/repos/almende/vis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almende/vis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almende/vis/teams","hooks_url":"https://api.github.com/repos/almende/vis/hooks","issue_events_url":"https://api.github.com/repos/almende/vis/issues/events{/number}","events_url":"https://api.github.com/repos/almende/vis/events","assignees_url":"https://api.github.com/repos/almende/vis/assignees{/user}","branches_url":"https://api.github.com/repos/almende/vis/branches{/branch}","tags_url":"https://api.github.com/repos/almende/vis/tags","blobs_url":"https://api.github.com/repos/almende/vis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almende/vis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almende/vis/git/refs{/sha}","trees_url":"https://api.github.com/repos/almende/vis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almende/vis/statuses/{sha}","languages_url":"https://api.github.com/repos/almende/vis/languages","stargazers_url":"https://api.github.com/repos/almende/vis/stargazers","contributors_url":"https://api.github.com/repos/almende/vis/contributors","subscribers_url":"https://api.github.com/repos/almende/vis/subscribers","subscription_url":"https://api.github.com/repos/almende/vis/subscription","commits_url":"https://api.github.com/repos/almende/vis/commits{/sha}","git_commits_url":"https://api.github.com/repos/almende/vis/git/commits{/sha}","comments_url":"https://api.github.com/repos/almende/vis/comments{/number}","issue_comment_url":"https://api.github.com/repos/almende/vis/issues/comments{/number}","contents_url":"https://api.github.com/repos/almende/vis/contents/{+path}","compare_url":"https://api.github.com/repos/almende/vis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almende/vis/merges","archive_url":"https://api.github.com/repos/almende/vis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almende/vis/downloads","issues_url":"https://api.github.com/repos/almende/vis/issues{/number}","pulls_url":"https://api.github.com/repos/almende/vis/pulls{/number}","milestones_url":"https://api.github.com/repos/almende/vis/milestones{/number}","notifications_url":"https://api.github.com/repos/almende/vis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almende/vis/labels{/name}","releases_url":"https://api.github.com/repos/almende/vis/releases{/id}","deployments_url":"https://api.github.com/repos/almende/vis/deployments","created_at":"2013-04-16T08:01:02Z","updated_at":"2017-03-18T13:06:10Z","pushed_at":"2017-03-18T16:04:30Z","git_url":"git://github.com/almende/vis.git","ssh_url":"git@github.com:almende/vis.git","clone_url":"https://github.com/almende/vis.git","svn_url":"https://github.com/almende/vis","homepage":"http://visjs.org","size":133202,"stargazers_count":4875,"watchers_count":4875,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":853,"mirror_url":null,"open_issues_count":314,"forks":853,"open_issues":314,"watchers":4875,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almende/vis/pulls/2873"},"html":{"href":"https://github.com/almende/vis/pull/2873"},"issue":{"href":"https://api.github.com/repos/almende/vis/issues/2873"},"comments":{"href":"https://api.github.com/repos/almende/vis/issues/2873/comments"},"review_comments":{"href":"https://api.github.com/repos/almende/vis/pulls/2873/comments"},"review_comment":{"href":"https://api.github.com/repos/almende/vis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almende/vis/pulls/2873/commits"},"statuses":{"href":"https://api.github.com/repos/almende/vis/statuses/fb071580dd35b7955cbc21281f98743ecda7020a"}}}}
|
{
"id": 9467421,
"name": "almende/vis",
"url": "https://api.github.com/repos/almende/vis"
}
|
{
"id": 5375334,
"login": "Tooa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5375334?",
"url": "https://api.github.com/users/Tooa"
}
|
{
"id": 1436571,
"login": "almende",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1436571?",
"url": "https://api.github.com/orgs/almende"
}
| 2017-03-18T18:19:47 |
5519425161
|
{"actor":{"display_login":"Tooa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/100444832","pull_request_review_id":21152791,"id":100444832,"diff_hunk":"@@ -0,0 +1,333 @@\n+#!/usr/bin/python\n+# This file is part of Ansible\n+#\n+# Ansible is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# Ansible is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with Ansible. If not, see <http://www.gnu.org/licenses/>.\n+\n+ANSIBLE_METADATA = {'status': ['preview'],\n+ 'supported_by': 'community',\n+ 'version': '1.0'}\n+\n+DOCUMENTATION = \"\"\"\n+---\n+module: elasticache_group_parameter\n+short_description: Manage cache security groups in Amazon Elasticache.\n+description:\n+ - Manage cache security groups in Amazon Elasticache.\n+ - Returns information about the specified cache cluster.\n+version_added: \"2.3\"\n+author: \"Sloane Hertel (@s-hertel)\"\n+options:\n+ group_family:\n+ description:\n+ - The name of the cache parameter group family that the cache parameter group can be used with.\n+ choices: ['memcached1.4', 'redis2.6', 'redis2.8', 'redis3.2']\n+ required: yes\n+ type: string\n+ name:\n+ description:\n+ - A user-specified name for the cache parameter group.\n+ required: yes\n+ type: string\n+ description:\n+ description:\n+ - A user-specified description for the cache parameter group.\n+ state:\n+ description:\n+ - Idempotent actions that will create/modify, destroy, or reset a cache parameter group as needed.\n+ choices: ['present', 'absent', 'reset']\n+ required: true\n+ values:\n+ description:\n+ - A user-specified list of parameters to reset or modify for the cache parameter group.\n+ required: no\n+ type: dict\n+ default: None\n+\"\"\"\n+\n+EXAMPLES = \"\"\"\n+# Note: None of these examples set aws_access_key, aws_secret_key, or region.\n+# It is assumed that their matching environment variables are set.\n+---\n+- hosts: localhost\n+ connection: local\n+ tasks:\n+ - name: 'Create a test parameter group'\n+ elasticache_parameter_group:\n+ name: 'test-param-group'\n+ group_family: 'redis3.2'\n+ description: 'This is a cache parameter group'\n+ state: 'present'\n+ - name: 'Modify a test parameter group'\n+ elasticache_parameter_group:\n+ name: 'test-param-group'\n+ values:\n+ - ['activerehashing', 'yes']\n+ - ['client-output-buffer-limit-normal-hard-limit', 4]\n+ state: 'present'\n+ - name: 'Reset all modifiable parameters for the test parameter group'\n+ elasticache_parameter_group:\n+ name: 'test-param-group'\n+ state: reset\n+ - name: 'Delete a test parameter group'\n+ elasticache_parameter_group:\n+ name: 'test-param-group'\n+ state: 'absent'\n+\"\"\"\n+\n+RETURN = \"\"\"\n+elasticache:\n+ description: cache parameter group information and response metadata\n+ returned: always\n+ type: dict\n+ sample:\n+ cache_parameter_group:\n+ cache_parameter_group_family: redis3.2\n+ cache_parameter_group_name: test-please-delete\n+ description: \"initial description\"\n+ response_metadata:\n+ http_headers:\n+ content-length: \"562\"\n+ content-type: text/xml\n+ date: \"Mon, 06 Feb 2017 22:14:08 GMT\"\n+ x-amzn-requestid: 947291f9-ecb9-11e6-85bd-3baa4eca2cc1\n+ http_status_code: 200\n+ request_id: 947291f9-ecb9-11e6-85bd-3baa4eca2cc1\n+ retry_attempts: 0\n+changed:\n+ description: if the cache parameter group has changed\n+ returned: always\n+ type: bool\n+ sample:\n+ changed: true\n+\"\"\"\n+\n+from ansible.module_utils.ec2 import boto3_conn\n+from ansible.module_utils.six import text_type\n+import traceback\n+\n+try:\n+ import boto3\n+ import botocore\n+ HAS_BOTO3 = True\n+except ImportError:\n+ HAS_BOTO3 = False\n+\n+def create(module, conn, name, group_family, description):\n+ \"\"\" Create ElastiCache parameter group. \"\"\"\n+ try:\n+ response = conn.create_cache_parameter_group(CacheParameterGroupName=name, CacheParameterGroupFamily=group_family, Description=description)\n+ changed = True\n+ except boto.exception.BotoServerError as e:\n+ module.fail_json(msg=\"Unable to create cache parameter group.\", exception=traceback.format_exc(e))\n+ return response, changed\n+\n+def delete(module, conn, name):\n+ \"\"\" Delete ElastiCache parameter group. \"\"\"\n+ try:\n+ conn.delete_cache_parameter_group(CacheParameterGroupName=name)\n+ response = {}\n+ changed = True\n+ except boto.exception.BotoServerError as e:\n+ module.fail_json(msg=\"Unable to delete cache parameter group.\", exception=traceback.format_exc(e))\n+ return response, changed\n+\n+def make_current_modifiable_param_dict(module, conn, name):\n+ \"\"\" Gets the current state of the cache parameter group and creates a dict with the format: {ParameterName: [Allowed_Values, DataType, ParameterValue]}\"\"\"\n+ current_info = get_info(conn, name)\n+ if current_info is False:\n+ module.fail_json(msg=\"Could not connect to the cache parameter group %s.\" % name)\n+\n+ parameters = current_info[\"Parameters\"]\n+ modifiable_params = {}\n+\n+ for param in parameters:\n+ if param[\"IsModifiable\"] and (\"AllowedValues\" and \"ParameterValue\") in param:\n+ modifiable_params[param[\"ParameterName\"]] = [param[\"AllowedValues\"], param[\"DataType\"], param[\"ParameterValue\"]]\n+ return modifiable_params\n+\n+def check_valid_modification(module, values, modifiable_params):\n+ \"\"\" Check if the parameters and values in values are valid. \"\"\"\n+ changed_with_update = False\n+\n+ for parameter in values:\n+ new_value = values[parameter]\n+\n+ # check valid modifiable parameters\n+ if parameter not in modifiable_params:\n+ module.fail_json(\"%s is not a modifiable parameter. Valid parameters to modify are: %s.\" % (parameter, modifiable_params.keys()))\n+\n+ # check allowed datatype for modified parameters\n+ str_to_type = {\"integer\": int, \"string\": text_type}\n+ if not isinstance(new_value, str_to_type[modifiable_params[parameter][1]]):\n+ module.fail_json(msg=\"%s (type %s) is not an allowed value for the parameter %s. Expected a type %s.\" %\n+ (new_value, type(new_value), parameter, modifiable_params[parameter][1]))\n+\n+ # check allowed values for modifiable parameters\n+ if text_type(new_value) not in modifiable_params[parameter][0] and not isinstance(new_value, int):\n+ module.fail_json(msg=\"%s is not an allowed value for the parameter %s. Valid parameters are: %s.\" %\n+ (new_value, parameter, modifiable_params[parameter][0]))\n+\n+ # check if a new value is different from current value\n+ if text_type(new_value) != modifiable_params[parameter][2]:\n+ changed_with_update = True\n+\n+ return changed_with_update\n+\n+def check_changed_parameter_values(values, old_parameters, new_parameters):\n+ \"\"\" Checking if the new values are different than the old values. \"\"\"\n+ changed_with_update = False\n+\n+ # if the user specified parameters to reset, only check those for change\n+ if values:\n+ for parameter in values:\n+ if old_parameters[parameter] != new_parameters[parameter]:\n+ changed_with_update = True\n+ break\n+ # otherwise check all to find a change\n+ else:\n+ for parameter in old_parameters:\n+ if old_parameters[parameter] != new_parameters[parameter]:\n+ changed_with_update = True\n+ break\n+\n+ return changed_with_update\n+\n+def modify(module, conn, name, values):\n+ \"\"\" Modify ElastiCache parameter group to reflect the new information if it differs from the current. \"\"\"\n+ # compares current group parameters with the parameters we've specified to to a value to see if this will change the group\n+ format_parameters = []\n+ for key in values:\n+ value = text_type(values[key])\n+ format_parameters.append({'ParameterName': key, 'ParameterValue': value})\n+ try:\n+ response = conn.modify_cache_parameter_group(CacheParameterGroupName=name, ParameterNameValues=format_parameters)\n+ except boto.exception.BotoServerError as e:\n+ module.fail_json(msg=\"Unable to modify cache parameter group.\", exception=traceback.format_exc(e))\n+ return response\n+\n+def reset(module, conn, name, values):\n+ \"\"\" Reset ElastiCache parameter group if the current information is different from the new information. \"\"\"\n+ # used to compare with the reset parameters' dict to see if there have been changes\n+ old_parameters_dict = make_current_modifiable_param_dict(module, conn, name)\n+\n+ format_parameters = []\n+\n+ # determine whether to reset all or specific parameters\n+ if values:\n+ all_parameters = False\n+ format_parameters = []\n+ for key in values:\n+ value = text_type(values[key])\n+ format_parameters.append({'ParameterName': key, 'ParameterValue': value})\n+ else:\n+ all_parameters = True\n+\n+ try:\n+ response = conn.reset_cache_parameter_group(CacheParameterGroupName=name, ParameterNameValues=format_parameters, ResetAllParameters=all_parameters)\n+ except boto.exception.BotoServerError as e:\n+ module.fail_json(msg=\"Unable to reset cache parameter group.\", exception=traceback.format_exc(e))\n+\n+ # determine changed\n+ new_parameters_dict = make_current_modifiable_param_dict(module, conn, name)\n+ changed = check_changed_parameter_values(values, old_parameters_dict, new_parameters_dict)\n+\n+ return response, changed\n+\n+def get_info(conn, name):\n+ \"\"\" Gets info about the ElastiCache parameter group. Returns false if it doesn't exist or we don't have access. \"\"\"\n+ try:\n+ data = conn.describe_cache_parameters(CacheParameterGroupName=name)\n+ return data\n+ except botocore.exceptions.ClientError as e:\n+ return False\n+\n+\n+def main():\n+ argument_spec = ec2_argument_spec()\n+ argument_spec.update(dict(\n+ group_family = dict(required=False, type='str', choices=['memcached1.4', 'redis2.6', 'redis2.8', 'redis3.2']),\n+ name = dict(required=True, type='str'),\n+ description = dict(required=False),\n+ state = dict(required=True),\n+ values = dict(required=False, type='dict'),\n+ )\n+ )\n+ module = AnsibleModule(argument_spec=argument_spec)\n+\n+ if not HAS_BOTO3:\n+ module.fail_json(msg='boto required for this module')\n+\n+ parameter_group_family = module.params.get('group_family')\n+ parameter_group_name = module.params.get('name')\n+ group_description = module.params.get('description')\n+ state = module.params.get('state')\n+ values = module.params.get('values')\n+\n+ # Retrieve any AWS settings from the environment.\n+ region, ec2_url, aws_connect_kwargs = get_aws_connection_info(module, boto3=True)\n+ if not region:\n+ module.fail_json(msg=\"Either region or AWS_REGION or EC2_REGION environment variable or boto config aws_region or ec2_region must be set.\")\n+\n+ connection = boto3_conn(module, conn_type='client',\n+ resource='elasticache', region=region,\n+ endpoint=ec2_url, **aws_connect_kwargs)\n+\n+ exists = get_info(connection, parameter_group_name)\n+\n+ # check that the needed requirements are available\n+ if state == 'present' and not exists and not (parameter_group_family or group_description):\n+ module.fail_json(msg=\"Creating a group requires a family group and a description.\")\n+ elif state == 'reset' and not exists:\n+ module.fail_json(msg=\"No group %s to reset. Please create the group before using the state 'reset'.\" % parameter_group_name)\n+\n+ # Taking action\n+ changed = False\n+ if state == 'present':\n+ if exists:\n+ # confirm that the group exists without any actions\n+ if not values:\n+ response = exists\n+ changed = False\n+ # modify existing group\n+ else:\n+ modifiable_params = make_current_modifiable_param_dict(module, connection, parameter_group_name)\n+ changed = check_valid_modification(module, values, modifiable_params)\n+ response = modify(module, connection, parameter_group_name, values)\n+ # create group\n+ else:\n+ response, changed = create(module, connection, parameter_group_name, parameter_group_family, group_description)\n+ if values:\n+ modifiable_params = make_current_modifiable_param_dict(module, connection, parameter_group_name)\n+ changed = check_valid_modification(module, values, modifiable_params)\n+ response = modify(module, connection, parameter_group_name, values)\n+ elif state == 'absent':\n+ if exists:\n+ # delete group\n+ response, changed = delete(module, connection, parameter_group_name)\n+ else:\n+ response = {}\n+ changed = False\n+ elif state == 'reset':\n+ response, changed = reset(module, connection, parameter_group_name, values)\n+\n+ facts_result = dict(changed=changed, elasticache=camel_dict_to_snake_dict(response))\n+\n+ module.exit_json(**facts_result)\n+\n+# import module snippets\n+from ansible.module_utils.basic import *","path":"lib/ansible/modules/cloud/amazon/elasticache_parameter_group.py","position":329,"original_position":329,"commit_id":"ba88f263f157d3e04f493972b668fadeed0eaaa0","original_commit_id":"ba88f263f157d3e04f493972b668fadeed0eaaa0","user":{"login":"willthames","id":391807,"avatar_url":"https://avatars.githubusercontent.com/u/391807?v=3","gravatar_id":"","url":"https://api.github.com/users/willthames","html_url":"https://github.com/willthames","followers_url":"https://api.github.com/users/willthames/followers","following_url":"https://api.github.com/users/willthames/following{/other_user}","gists_url":"https://api.github.com/users/willthames/gists{/gist_id}","starred_url":"https://api.github.com/users/willthames/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willthames/subscriptions","organizations_url":"https://api.github.com/users/willthames/orgs","repos_url":"https://api.github.com/users/willthames/repos","events_url":"https://api.github.com/users/willthames/events{/privacy}","received_events_url":"https://api.github.com/users/willthames/received_events","type":"User","site_admin":false},"body":"These should be replaced along the lines of your existing imports earlier in the file (you'll need to add `get_aws_connection_info`, `ec2_argument_spec`, `camel_dict_to_snake_dict` and any others to the explicit import list)","created_at":"2017-02-10T00:05:34Z","updated_at":"2017-02-10T00:09:57Z","html_url":"https://github.com/ansible/ansible/pull/21023#discussion_r100444832","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/21023","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/100444832"},"html":{"href":"https://github.com/ansible/ansible/pull/21023#discussion_r100444832"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/21023"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/21023","id":104598710,"html_url":"https://github.com/ansible/ansible/pull/21023","diff_url":"https://github.com/ansible/ansible/pull/21023.diff","patch_url":"https://github.com/ansible/ansible/pull/21023.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/21023","number":21023,"state":"open","locked":false,"title":"New module: elasticache_parameter_group for modifying Elasticache cluster settings","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"body":"…ete/reset cache parameter groups.\r\n\r\n##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/modules/cloud/amazon/elasticache_parameter_group.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.3.0 (elasticache-parameter-group f06251c042) last updated 2017/02/03 14:33:10 (GMT -400)\r\n config file =\r\n configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nCreate, delete, modify, and reset cache parameter groups. #20842 showed interest in improved functionality of ElastiCache modules.\r\n\r\nSample playbook:\r\n```\r\n---\r\n- hosts: localhost\r\n connection: local\r\n tasks:\r\n - name: \"create a parameter group\"\r\n elasticache_parameter_group:\r\n name: \"test-group\"\r\n group_family: \"memcached1.4\"\r\n description: \"initial description\"\r\n state: \"present\"\r\n region: \"{{ region }}\"\r\n profile: \"{{ profile }}\"\r\n```\r\n\r\n```\r\n$ ansible-playbook my_playbooks/ec_create.yml -vv\r\n\r\nPLAYBOOK: ec_create.yml *********************************************************************\r\n1 plays in my_playbooks/ec_create.yml\r\n\r\nPLAY [localhost] ****************************************************************************\r\n\r\nTASK [Gathering Facts] **********************************************************************\r\nok: [localhost]\r\nMETA: ran handlers\r\n\r\nTASK [create test parameter group] **********************************************************\r\ntask path: /Users/.../ansible/my_playbooks/ec_create.yml:5\r\nchanged: [localhost] => {\"changed\": true, \"elasticache\": {\"DescribeCacheParametersResponse\": {\"DescribeCacheParametersResult\": {\"CacheNodeTypeSpecificParameters\": [{\"AllowedValues\": \"1-100000\", \"CacheNodeTypeSpecificValues\": [{\"CacheNodeType\": \"cache.c1.xlarge\", \"Value\": \"6600\"}, {\"CacheNodeType\": \"cache.m1.large\", \"Value\": \"7100\"}, {\"CacheNodeType\": \"cache.m1.medium\", \"Value\": \"3350\"}, {\"CacheNodeType\": \"cache.m1.small\", \"Value\": \"1300\"}, {\"CacheNodeType\": \"cache.m1.xlarge\", \"Value\": \"14600\"}, {\"CacheNodeType\": \"cache.m2.2xlarge\", \"Value\": \"33800\"}, {\"CacheNodeType\": \"cache.m2.4xlarge\", \"Value\": \"68000\"}, {\"CacheNodeType\": \"cache.m2.xlarge\", \"Value\": \"16700\"}, {\"CacheNodeType\": \"cache.m3.2xlarge\", \"Value\": \"28600\"}, {\"CacheNodeType\": \"cache.m3.large\", \"Value\": \"6200\"}, {\"CacheNodeType\": \"cache.m3.medium\", \"Value\": \"2850\"}, {\"CacheNodeType\": \"cache.m3.xlarge\", \"Value\": \"13600\"}, {\"CacheNodeType\": \"cache.m4.10xlarge\", \"Value\": \"158355\"}, {\"CacheNodeType\": \"cache.m4.2xlarge\", \"Value\": \"30412\"}, {\"CacheNodeType\": \"cache.m4.4xlarge\", \"Value\": \"62234\"}, {\"CacheNodeType\": \"cache.m4.large\", \"Value\": \"6573\"}, {\"CacheNodeType\": \"cache.m4.xlarge\", \"Value\": \"14618\"}, {\"CacheNodeType\": \"cache.r3.2xlarge\", \"Value\": \"59600\"}, {\"CacheNodeType\": \"cache.r3.4xlarge\", \"Value\": \"120600\"}, {\"CacheNodeType\": \"cache.r3.8xlarge\", \"Value\": \"242600\"}, {\"CacheNodeType\": \"cache.r3.large\", \"Value\": \"13800\"}, {\"CacheNodeType\": \"cache.r3.xlarge\", \"Value\": \"29100\"}, {\"CacheNodeType\": \"cache.t1.micro\", \"Value\": \"213\"}, {\"CacheNodeType\": \"cache.t2.medium\", \"Value\": \"3301\"}, {\"CacheNodeType\": \"cache.t2.micro\", \"Value\": \"555\"}, {\"CacheNodeType\": \"cache.t2.small\", \"Value\": \"1588\"}], \"DataType\": \"integer\", \"Description\": \"The maximum configurable amount of memory to use to store items, in megabytes.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"max_cache_memory\", \"Source\": \"system\"}, {\"AllowedValues\": \"1-8\", \"CacheNodeTypeSpecificValues\": [{\"CacheNodeType\": \"cache.c1.xlarge\", \"Value\": \"8\"}, {\"CacheNodeType\": \"cache.m1.large\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.m1.medium\", \"Value\": \"1\"}, {\"CacheNodeType\": \"cache.m1.small\", \"Value\": \"1\"}, {\"CacheNodeType\": \"cache.m1.xlarge\", \"Value\": \"4\"}, {\"CacheNodeType\": \"cache.m2.2xlarge\", \"Value\": \"4\"}, {\"CacheNodeType\": \"cache.m2.4xlarge\", \"Value\": \"8\"}, {\"CacheNodeType\": \"cache.m2.xlarge\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.m3.2xlarge\", \"Value\": \"8\"}, {\"CacheNodeType\": \"cache.m3.large\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.m3.medium\", \"Value\": \"1\"}, {\"CacheNodeType\": \"cache.m3.xlarge\", \"Value\": \"4\"}, {\"CacheNodeType\": \"cache.m4.10xlarge\", \"Value\": \"40\"}, {\"CacheNodeType\": \"cache.m4.2xlarge\", \"Value\": \"8\"}, {\"CacheNodeType\": \"cache.m4.4xlarge\", \"Value\": \"16\"}, {\"CacheNodeType\": \"cache.m4.large\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.m4.xlarge\", \"Value\": \"4\"}, {\"CacheNodeType\": \"cache.r3.2xlarge\", \"Value\": \"8\"}, {\"CacheNodeType\": \"cache.r3.4xlarge\", \"Value\": \"16\"}, {\"CacheNodeType\": \"cache.r3.8xlarge\", \"Value\": \"32\"}, {\"CacheNodeType\": \"cache.r3.large\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.r3.xlarge\", \"Value\": \"4\"}, {\"CacheNodeType\": \"cache.t1.micro\", \"Value\": \"1\"}, {\"CacheNodeType\": \"cache.t2.medium\", \"Value\": \"2\"}, {\"CacheNodeType\": \"cache.t2.micro\", \"Value\": \"1\"}, {\"CacheNodeType\": \"cache.t2.small\", \"Value\": \"1\"}], \"DataType\": \"integer\", \"Description\": \"The number of memcached threads to use.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"num_threads\", \"Source\": \"system\"}], \"Marker\": null, \"Parameters\": [{\"AllowedValues\": \"1-10000\", \"DataType\": \"integer\", \"Description\": \"The backlog queue limit.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"backlog_queue_limit\", \"ParameterValue\": \"1024\", \"Source\": \"system\"}, {\"AllowedValues\": \"auto,ascii\", \"DataType\": \"string\", \"Description\": \"Binding protocol.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"binding_protocol\", \"ParameterValue\": \"auto\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If supplied, CAS operations will be disabled, and items stored will consume 8 bytes less than with CAS enabled.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"cas_disabled\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"1-1024\", \"DataType\": \"integer\", \"Description\": \"The minimum amount of space to allocate for the smallest item's key + value + flags, in bytes.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"chunk_size\", \"ParameterValue\": \"48\", \"Source\": \"system\"}, {\"AllowedValues\": \"1.01-100.00\", \"DataType\": \"float\", \"Description\": \"The growth factor controlling the size of each successive memcached chunk - each chunk will be chunk_size_growth_factor times larger than the previous chunk.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"chunk_size_growth_factor\", \"ParameterValue\": \"1.25\", \"Source\": \"system\"}, {\"AllowedValues\": \"0-64\", \"DataType\": \"integer\", \"Description\": \"Maximum amount of configuration objects that can be stored at once.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"config_max\", \"ParameterValue\": \"16\", \"Source\": \"system\"}, {\"AllowedValues\": \"1024-1048576\", \"DataType\": \"integer\", \"Description\": \"Maximum size of a configuration object.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"config_size_max\", \"ParameterValue\": \"65536\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If enabled, flush_all command will be disabled. Applicable to 1.4.24 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.24\", \"ParameterName\": \"disable_flush_all\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If supplied, when there is no more memory to store items, memcached will return an error rather than evicting items.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"error_on_memory_exhausted\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If enabled and if lru_maintainer is enabled, will make items with an expiration time of 0 unevictable. Take caution as this will crowd out memory available for other evictable items. Will not work if lru_maintainer is not enabled. Applicable to 1.4.24 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.24\", \"ParameterName\": \"expirezero_does_not_evict\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"jenkins,murmur3\", \"DataType\": \"string\", \"Description\": \"Configure the hash algorithm. Currently jenkins and murmur3 are offered. Default is jenkins. Applicable to 1.4.24 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.24\", \"ParameterName\": \"hash_algorithm\", \"ParameterValue\": \"jenkins\", \"Source\": \"system\"}, {\"AllowedValues\": \"12-64\", \"DataType\": \"integer\", \"Description\": \"Integer multiplier for the initial size of the hash table.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"hashpower_init\", \"ParameterValue\": \"16\", \"Source\": \"system\"}, {\"AllowedValues\": \"0-86400\", \"DataType\": \"integer\", \"Description\": \"If value is set more than 0, connected clients that have idled for at least this long will be asked to close. Unit is in Seconds. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"idle_timeout\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"Try to use large memory pages.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"large_memory_pages\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"Lock down all paged memory.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"lock_down_paged_memory\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If enabled, will enable lru_crawler at launch time. LRU crawler can be enabled at run time too. See ElastiCache documentation. Applicable to 1.4.24 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.24\", \"ParameterName\": \"lru_crawler\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If enabled, will enable lru_maintainer. lru_maintainer will run a background thread which shuffles items between/within the LRU's as capacities are reached. Applicable to 1.4.24 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.24\", \"ParameterName\": \"lru_maintainer\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"1024-134217728\", \"DataType\": \"integer\", \"Description\": \"The size of the largest item storable in the cache, in bytes.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"max_item_size\", \"ParameterValue\": \"1048576\", \"Source\": \"system\"}, {\"AllowedValues\": \"3-65000\", \"DataType\": \"integer\", \"Description\": \"The maximum number of simultaneous connections.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"max_simultaneous_connections\", \"ParameterValue\": \"65000\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"Immediately close new connections if over maximum simultaneous connections limit.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"maxconns_fast\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"Maximize core file limit.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"maximize_core_file_limit\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0-100000\", \"DataType\": \"integer\", \"Description\": \"The amount of memory to reserve for memcached connections and other miscellaneous overhead.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"memcached_connections_overhead\", \"ParameterValue\": \"100\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"This is an alias for enabling slab_reassign, slab_automove, lru_crawler, lru_maintainer, maxconns_fast and setting hash_algorithm=murmur3. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"modern\", \"ParameterValue\": \"1\", \"Source\": \"system\"}, {\"AllowedValues\": \"1-1000\", \"DataType\": \"integer\", \"Description\": \"The maximum number of requests per event, limits the number of requests processed for a given connection to prevent starvation.\", \"IsModifiable\": false, \"MinimumEngineVersion\": \"1.4.5\", \"ParameterName\": \"requests_per_event\", \"ParameterValue\": \"20\", \"Source\": \"system\"}, {\"AllowedValues\": \"0-2\", \"DataType\": \"integer\", \"Description\": \"Controls the aggressiveness of the automatic memory reassignment algorithm.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"slab_automove\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"524288,1048576\", \"DataType\": \"integer\", \"Description\": \"Lets users choose 512KB or 1MB for slab_chunk_max. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"slab_chunk_max\", \"ParameterValue\": \"524288\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"Enables the ability to reassign memory.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.14\", \"ParameterName\": \"slab_reassign\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"0,1\", \"DataType\": \"boolean\", \"Description\": \"If enable, users can run \\\"stats sizes\\\" command. Not recommended in production environments. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"track_sizes\", \"ParameterValue\": \"0\", \"Source\": \"system\"}, {\"AllowedValues\": \"256-1024\", \"DataType\": \"integer\", \"Description\": \"Lets users change \\\"watch\\\" command's logging buffer size. Unit is in KB. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"watcher_logbuf_size\", \"ParameterValue\": \"256\", \"Source\": \"system\"}, {\"AllowedValues\": \"64-1024\", \"DataType\": \"integer\", \"Description\": \"Lets users change \\\"watch\\\" command's worker buffer size. Unit is in KB. Applicable to 1.4.33 and higher.\", \"IsModifiable\": true, \"MinimumEngineVersion\": \"1.4.33\", \"ParameterName\": \"worker_logbuf_size\", \"ParameterValue\": \"64\", \"Source\": \"system\"}]}, \"ResponseMetadata\": {\"RequestId\": \"98fad95f-ea48-11e6-aa93-a1e683c7f8af\"}}}}\r\nMETA: ran handlers\r\nMETA: ran handlers\r\n\r\nPLAY RECAP **********************************************************************************\r\nlocalhost : ok=2 changed=1 unreachable=0 failed=0\r\n\r\n```\r\n","created_at":"2017-02-03T19:44:16Z","updated_at":"2017-02-10T00:09:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46cebf6e0ef0609a746d1f91c8f42e1256a86972","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/21023/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/21023/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/21023/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/ba88f263f157d3e04f493972b668fadeed0eaaa0","head":{"label":"s-hertel:elasticache-parameter-group","ref":"elasticache-parameter-group","sha":"ba88f263f157d3e04f493972b668fadeed0eaaa0","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"repo":{"id":60099782,"name":"ansible","full_name":"s-hertel/ansible","owner":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-hertel/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/s-hertel/ansible","forks_url":"https://api.github.com/repos/s-hertel/ansible/forks","keys_url":"https://api.github.com/repos/s-hertel/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-hertel/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-hertel/ansible/teams","hooks_url":"https://api.github.com/repos/s-hertel/ansible/hooks","issue_events_url":"https://api.github.com/repos/s-hertel/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/s-hertel/ansible/events","assignees_url":"https://api.github.com/repos/s-hertel/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/s-hertel/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/s-hertel/ansible/tags","blobs_url":"https://api.github.com/repos/s-hertel/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-hertel/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-hertel/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-hertel/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-hertel/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/s-hertel/ansible/languages","stargazers_url":"https://api.github.com/repos/s-hertel/ansible/stargazers","contributors_url":"https://api.github.com/repos/s-hertel/ansible/contributors","subscribers_url":"https://api.github.com/repos/s-hertel/ansible/subscribers","subscription_url":"https://api.github.com/repos/s-hertel/ansible/subscription","commits_url":"https://api.github.com/repos/s-hertel/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-hertel/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-hertel/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-hertel/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-hertel/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/s-hertel/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-hertel/ansible/merges","archive_url":"https://api.github.com/repos/s-hertel/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-hertel/ansible/downloads","issues_url":"https://api.github.com/repos/s-hertel/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/s-hertel/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/s-hertel/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/s-hertel/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-hertel/ansible/labels{/name}","releases_url":"https://api.github.com/repos/s-hertel/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/s-hertel/ansible/deployments","created_at":"2016-05-31T15:07:40Z","updated_at":"2016-05-31T15:07:48Z","pushed_at":"2017-02-09T20:42:38Z","git_url":"git://github.com/s-hertel/ansible.git","ssh_url":"git@github.com:s-hertel/ansible.git","clone_url":"https://github.com/s-hertel/ansible.git","svn_url":"https://github.com/s-hertel/ansible","homepage":"http://ansible.com/","size":56489,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"43ae12757e2ed2adbbdcb4c3f11d13c36b7dcb01","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-02-09T23:49:35Z","pushed_at":"2017-02-10T00:06:27Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":65615,"stargazers_count":21303,"watchers_count":21303,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6807,"mirror_url":null,"open_issues_count":2369,"forks":6807,"open_issues":2369,"watchers":21303,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/21023"},"html":{"href":"https://github.com/ansible/ansible/pull/21023"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/21023"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/21023/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/21023/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/21023/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/ba88f263f157d3e04f493972b668fadeed0eaaa0"}}}}
|
{
"id": 3638964,
"name": "ansible/ansible",
"url": "https://api.github.com/repos/ansible/ansible"
}
|
{
"id": 391807,
"login": "willthames",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/391807?",
"url": "https://api.github.com/users/willthames"
}
|
{
"id": 1507452,
"login": "ansible",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1507452?",
"url": "https://api.github.com/orgs/ansible"
}
| 2017-02-10T00:05:34 |
5299441966
|
{"actor":{"display_login":"willthames"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/98952294","pull_request_review_id":19610994,"id":98952294,"diff_hunk":"@@ -46,7 +46,7 @@ The complete module metadata specification is here: https://github.com/ansible/p\n * For password / secret arguments no_log=True should be set.\n * Requirements should be documented, using the `requirements=[]` field.\n * Author should be set, with their name and their github id, at the least.\n- * Ensure that you make use of U() for urls, C() for files and options, I() for params, M() for modules.\n+ * Ensure that you make use of `U()` for URLs, `I()` for option names, `C()` for files and option values, `M()` for module names.","path":"docs/docsite/rst/dev_guide/developing_modules_checklist.rst","position":5,"original_position":5,"commit_id":"672468fd7970b871d33f33f6da57cbef1107bb08","original_commit_id":"672468fd7970b871d33f33f6da57cbef1107bb08","user":{"login":"abadger","id":209242,"avatar_url":"https://avatars.githubusercontent.com/u/209242?v=3","gravatar_id":"","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"body":"albertom pointed out that in the yaml, the field is called options so I see where that usage comes from now. that seems okay.","created_at":"2017-02-01T17:47:26Z","updated_at":"2017-02-01T17:47:26Z","html_url":"https://github.com/ansible/ansible/pull/20931#discussion_r98952294","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/20931","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/98952294"},"html":{"href":"https://github.com/ansible/ansible/pull/20931#discussion_r98952294"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20931"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/20931","id":104178493,"html_url":"https://github.com/ansible/ansible/pull/20931","diff_url":"https://github.com/ansible/ansible/pull/20931.diff","patch_url":"https://github.com/ansible/ansible/pull/20931.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/20931","number":20931,"state":"open","locked":false,"title":"Making the decoration more clear","user":{"login":"jtyr","id":3788909,"avatar_url":"https://avatars.githubusercontent.com/u/3788909?v=3","gravatar_id":"","url":"https://api.github.com/users/jtyr","html_url":"https://github.com/jtyr","followers_url":"https://api.github.com/users/jtyr/followers","following_url":"https://api.github.com/users/jtyr/following{/other_user}","gists_url":"https://api.github.com/users/jtyr/gists{/gist_id}","starred_url":"https://api.github.com/users/jtyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtyr/subscriptions","organizations_url":"https://api.github.com/users/jtyr/orgs","repos_url":"https://api.github.com/users/jtyr/repos","events_url":"https://api.github.com/users/jtyr/events{/privacy}","received_events_url":"https://api.github.com/users/jtyr/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n\r\nDocs Pull Request\r\n\r\n##### COMPONENT NAME\r\n\r\nThe [`developing_modules_checklist`](http://docs.ansible.com/ansible/dev_guide/developing_modules_checklist.html) page.\r\n\r\n##### ANSIBLE VERSION\r\n\r\n```\r\nansible 2.2.1.0\r\n config file = /etc/ansible/ansible.cfg\r\n configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\n\r\nThis doc PR is making the decoration option names and values more clear. Before it wasn't clear what's option and what's parameter.","created_at":"2017-02-01T17:04:15Z","updated_at":"2017-02-01T17:47:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af4434958aefa6fe64324d36984023d055acd95f","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/20931/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/20931/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/20931/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/672468fd7970b871d33f33f6da57cbef1107bb08","head":{"label":"jtyr:jtyr-modules_checklist","ref":"jtyr-modules_checklist","sha":"672468fd7970b871d33f33f6da57cbef1107bb08","user":{"login":"jtyr","id":3788909,"avatar_url":"https://avatars.githubusercontent.com/u/3788909?v=3","gravatar_id":"","url":"https://api.github.com/users/jtyr","html_url":"https://github.com/jtyr","followers_url":"https://api.github.com/users/jtyr/followers","following_url":"https://api.github.com/users/jtyr/following{/other_user}","gists_url":"https://api.github.com/users/jtyr/gists{/gist_id}","starred_url":"https://api.github.com/users/jtyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtyr/subscriptions","organizations_url":"https://api.github.com/users/jtyr/orgs","repos_url":"https://api.github.com/users/jtyr/repos","events_url":"https://api.github.com/users/jtyr/events{/privacy}","received_events_url":"https://api.github.com/users/jtyr/received_events","type":"User","site_admin":false},"repo":{"id":29291272,"name":"ansible","full_name":"jtyr/ansible","owner":{"login":"jtyr","id":3788909,"avatar_url":"https://avatars.githubusercontent.com/u/3788909?v=3","gravatar_id":"","url":"https://api.github.com/users/jtyr","html_url":"https://github.com/jtyr","followers_url":"https://api.github.com/users/jtyr/followers","following_url":"https://api.github.com/users/jtyr/following{/other_user}","gists_url":"https://api.github.com/users/jtyr/gists{/gist_id}","starred_url":"https://api.github.com/users/jtyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtyr/subscriptions","organizations_url":"https://api.github.com/users/jtyr/orgs","repos_url":"https://api.github.com/users/jtyr/repos","events_url":"https://api.github.com/users/jtyr/events{/privacy}","received_events_url":"https://api.github.com/users/jtyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jtyr/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/jtyr/ansible","forks_url":"https://api.github.com/repos/jtyr/ansible/forks","keys_url":"https://api.github.com/repos/jtyr/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jtyr/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jtyr/ansible/teams","hooks_url":"https://api.github.com/repos/jtyr/ansible/hooks","issue_events_url":"https://api.github.com/repos/jtyr/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/jtyr/ansible/events","assignees_url":"https://api.github.com/repos/jtyr/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/jtyr/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/jtyr/ansible/tags","blobs_url":"https://api.github.com/repos/jtyr/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jtyr/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jtyr/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/jtyr/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jtyr/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/jtyr/ansible/languages","stargazers_url":"https://api.github.com/repos/jtyr/ansible/stargazers","contributors_url":"https://api.github.com/repos/jtyr/ansible/contributors","subscribers_url":"https://api.github.com/repos/jtyr/ansible/subscribers","subscription_url":"https://api.github.com/repos/jtyr/ansible/subscription","commits_url":"https://api.github.com/repos/jtyr/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/jtyr/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/jtyr/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/jtyr/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/jtyr/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/jtyr/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jtyr/ansible/merges","archive_url":"https://api.github.com/repos/jtyr/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jtyr/ansible/downloads","issues_url":"https://api.github.com/repos/jtyr/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/jtyr/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/jtyr/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/jtyr/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jtyr/ansible/labels{/name}","releases_url":"https://api.github.com/repos/jtyr/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/jtyr/ansible/deployments","created_at":"2015-01-15T09:57:25Z","updated_at":"2016-11-07T11:25:11Z","pushed_at":"2017-02-01T17:24:19Z","git_url":"git://github.com/jtyr/ansible.git","ssh_url":"git@github.com:jtyr/ansible.git","clone_url":"https://github.com/jtyr/ansible.git","svn_url":"https://github.com/jtyr/ansible","homepage":"http://ansible.com/","size":53778,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"e401b4e424bf95c5fb62806909c6951160cadc8b","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-02-01T16:49:14Z","pushed_at":"2017-02-01T17:24:21Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":64980,"stargazers_count":21141,"watchers_count":21141,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6721,"mirror_url":null,"open_issues_count":2333,"forks":6721,"open_issues":2333,"watchers":21141,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20931"},"html":{"href":"https://github.com/ansible/ansible/pull/20931"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/20931"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/20931/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20931/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/20931/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/672468fd7970b871d33f33f6da57cbef1107bb08"}}}}
|
{
"id": 3638964,
"name": "ansible/ansible",
"url": "https://api.github.com/repos/ansible/ansible"
}
|
{
"id": 209242,
"login": "abadger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/209242?",
"url": "https://api.github.com/users/abadger"
}
|
{
"id": 1507452,
"login": "ansible",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1507452?",
"url": "https://api.github.com/orgs/ansible"
}
| 2017-02-01T17:47:26 |
5249307624
|
{"actor":{"display_login":"abadger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/116472206","pull_request_review_id":38090784,"id":116472206,"diff_hunk":"@@ -0,0 +1,275 @@\n+# (c) 2017 Red Hat Inc.\n+#\n+# This file is part of Ansible\n+#\n+# Ansible is free software: you can redistribute it and/or modify\n+# it under the terms of the GNU General Public License as published by\n+# the Free Software Foundation, either version 3 of the License, or\n+# (at your option) any later version.\n+#\n+# Ansible is distributed in the hope that it will be useful,\n+# but WITHOUT ANY WARRANTY; without even the implied warranty of\n+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+# GNU General Public License for more details.\n+#\n+# You should have received a copy of the GNU General Public License\n+# along with Ansible. If not, see <http://www.gnu.org/licenses/>.\n+\n+'''\n+ OUTLINE\n+ setup:\n+ get_object_from_s3\n+ setup_pipeline\n+ tests:\n+ test_define_pipeline\n+ test_deactivate_pipeline\n+ test_activate_pipeline\n+ test_create_pipeline\n+ test_create_pipeline_with_tags\n+ test_create_pipeline_already_exists\n+ test_delete_nonexistent_pipeline\n+ test_delete_pipeline\n+ test_build_unique_id_different\n+ test_build_unique_id_same\n+ test_build_unique_id_obj\n+ test_format_tags\n+ test_format_empty_tags\n+ test_pipeline_description\n+ test_pipeline_description_nonexistent\n+ test_pipeline_field\n+ test_check_dp_exists_true\n+ test_check_dp_exists_false\n+ test_check_dp_status\n+ cleanup:\n+ tear_down_pipeline\n+'''\n+\n+import pytest\n+import boto3\n+import os\n+import json\n+from . placebo_fixtures import placeboify, maybe_sleep\n+from ansible.modules.cloud.amazon import data_pipeline as dp\n+from ansible.modules.cloud.amazon import s3\n+from ansible.module_utils._text import to_text\n+\n+\n+class FakeModule(object):\n+ def __init__(self, **kwargs):\n+ self.params = kwargs\n+\n+ def fail_json(self, *args, **kwargs):\n+ self.exit_args = args\n+ self.exit_kwargs = kwargs\n+ raise Exception('FAIL')\n+\n+ def exit_json(self, *args, **kwargs):\n+ self.exit_args = args\n+ self.exit_kwargs = kwargs\n+\n+\n+def get_object_from_s3():\n+ if not os.getenv('PLACEBO_RECORD'):\n+ objects = [{\"name\": \"Every 1 day\",\n+ \"id\": \"DefaultSchedule\",\n+ \"fields\": []},\n+ {\"name\": \"Default\",\n+ \"id\": \"Default\",\n+ \"fields\": []}]\n+ return objects\n+ else:\n+ s3 = boto3.client('s3')\n+ data = s3.get_object(Bucket=\"ansible-test-datapipeline\", Key=\"pipeline-object/new.json\")\n+ objects = json.loads(to_text(data['Body'].read()))\n+ return objects\n+\n+\n+def setup_pipeline(placeboify, description='', objects=[], tags={}):\n+ connection = placeboify.client('datapipeline')\n+ params = {'name': 'ansible-test-create-pipeline',\n+ 'description': description,\n+ 'state': 'present',\n+ 'timeout': 300,\n+ 'objects': objects,\n+ 'tags': tags,\n+ 'parameters': [],\n+ 'values': []}\n+ m = FakeModule(**params)\n+ changed, result = dp.create_pipeline(connection, m)\n+ return m, connection, result['data_pipeline']['pipeline_id']\n+\n+\n+def tear_down_pipeline(connection, module):","path":"test/units/modules/cloud/amazon/test_data_pipeline.py","position":102,"original_position":102,"commit_id":"7324bdfc828eeb4996b745ab990e479da5b8c350","original_commit_id":"7324bdfc828eeb4996b745ab990e479da5b8c350","user":{"login":"ryansb","id":636610,"avatar_url":"https://avatars2.githubusercontent.com/u/636610?v=3","gravatar_id":"","url":"https://api.github.com/users/ryansb","html_url":"https://github.com/ryansb","followers_url":"https://api.github.com/users/ryansb/followers","following_url":"https://api.github.com/users/ryansb/following{/other_user}","gists_url":"https://api.github.com/users/ryansb/gists{/gist_id}","starred_url":"https://api.github.com/users/ryansb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryansb/subscriptions","organizations_url":"https://api.github.com/users/ryansb/orgs","repos_url":"https://api.github.com/users/ryansb/repos","events_url":"https://api.github.com/users/ryansb/events{/privacy}","received_events_url":"https://api.github.com/users/ryansb/received_events","type":"User","site_admin":false},"body":"This sort of work is best done as a pytest fixture. With [fixtures](https://docs.pytest.org/en/latest/fixture.html) you could write it such that one fixture would set up & tear down the whole setup. \r\n\r\n```\r\n@pytest.fixture\r\ndef pipeline_fixture(placeboify, objects, tags):\r\n connection = placeboify.client('datapipeline')\r\n [insert params stuff and FakeModule]\r\n _, result = db.create_pipeline(connection, m)\r\n yield {'module': m, 'connection': connection, 'pipeline_id': result['data_pipeline']['pipeline_id']}\r\n \r\n # this part runs after the test finishes, pass or fail\r\n dp.delete_pipeline({'name': 'ansible-test-create-pipeline', 'state': 'absent'})\r\n```\r\n\r\nAnd that would merge the setup/teardown functions into a fixture that you could use in tests like:\r\n\r\n```\r\ntest_define_pipeline(pipeline_fixture, maybe_sleep):\r\n pipeline_fixture['module'].[call a method or what have you](pipeline_fixture['pipeline_id'])\r\n```","created_at":"2017-05-15T12:01:32Z","updated_at":"2017-05-15T12:03:05Z","html_url":"https://github.com/ansible/ansible/pull/22878#discussion_r116472206","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/22878","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/116472206"},"html":{"href":"https://github.com/ansible/ansible/pull/22878#discussion_r116472206"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/22878"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/22878","id":112027209,"html_url":"https://github.com/ansible/ansible/pull/22878","diff_url":"https://github.com/ansible/ansible/pull/22878.diff","patch_url":"https://github.com/ansible/ansible/pull/22878.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/22878","number":22878,"state":"open","locked":false,"title":"New module for managing AWS Datapipelines","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars1.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"body":"##### ISSUE TYPE\r\n - New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\nlib/ansible/modules/cloud/amazon/data_pipeline.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.4.0 (ansible-modules-extras/pull/1547 8b8a039e4c) last updated 2017/03/28 13:22:30 (GMT -400)\r\n config file =\r\n configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\n- Supports create/activate/deactivate and deletion\r\n- Handles idempotent creation by hashing the options (except `objects`) given to the module\r\n- Waits for requested state to be reached, as Botocore doesn't\r\n have waiters yet for datapipelines\r\n","created_at":"2017-03-22T14:48:02Z","updated_at":"2017-05-15T12:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c875823901116cea3254d61fa81acfccf964421d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/22878/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/22878/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/22878/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/7324bdfc828eeb4996b745ab990e479da5b8c350","head":{"label":"s-hertel:ansible-modules-extras/pull/1547","ref":"ansible-modules-extras/pull/1547","sha":"7324bdfc828eeb4996b745ab990e479da5b8c350","user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars1.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"repo":{"id":60099782,"name":"ansible","full_name":"s-hertel/ansible","owner":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars1.githubusercontent.com/u/19572925?v=3","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s-hertel/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/s-hertel/ansible","forks_url":"https://api.github.com/repos/s-hertel/ansible/forks","keys_url":"https://api.github.com/repos/s-hertel/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s-hertel/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s-hertel/ansible/teams","hooks_url":"https://api.github.com/repos/s-hertel/ansible/hooks","issue_events_url":"https://api.github.com/repos/s-hertel/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/s-hertel/ansible/events","assignees_url":"https://api.github.com/repos/s-hertel/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/s-hertel/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/s-hertel/ansible/tags","blobs_url":"https://api.github.com/repos/s-hertel/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s-hertel/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s-hertel/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/s-hertel/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s-hertel/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/s-hertel/ansible/languages","stargazers_url":"https://api.github.com/repos/s-hertel/ansible/stargazers","contributors_url":"https://api.github.com/repos/s-hertel/ansible/contributors","subscribers_url":"https://api.github.com/repos/s-hertel/ansible/subscribers","subscription_url":"https://api.github.com/repos/s-hertel/ansible/subscription","commits_url":"https://api.github.com/repos/s-hertel/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/s-hertel/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/s-hertel/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/s-hertel/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/s-hertel/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/s-hertel/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s-hertel/ansible/merges","archive_url":"https://api.github.com/repos/s-hertel/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s-hertel/ansible/downloads","issues_url":"https://api.github.com/repos/s-hertel/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/s-hertel/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/s-hertel/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/s-hertel/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s-hertel/ansible/labels{/name}","releases_url":"https://api.github.com/repos/s-hertel/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/s-hertel/ansible/deployments","created_at":"2016-05-31T15:07:40Z","updated_at":"2017-04-21T13:44:13Z","pushed_at":"2017-05-12T20:12:46Z","git_url":"git://github.com/s-hertel/ansible.git","ssh_url":"git@github.com:s-hertel/ansible.git","clone_url":"https://github.com/s-hertel/ansible.git","svn_url":"https://github.com/s-hertel/ansible","homepage":"http://ansible.com/","size":63855,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"ba3295dd3f47fdf8d6364b2fa5d8519d0241e54b","user":{"login":"ansible","id":1507452,"avatar_url":"https://avatars1.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"avatar_url":"https://avatars1.githubusercontent.com/u/1507452?v=3","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2017-05-15T11:54:55Z","pushed_at":"2017-05-15T11:15:09Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"http://ansible.com/","size":73373,"stargazers_count":23114,"watchers_count":23114,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7693,"mirror_url":null,"open_issues_count":3136,"forks":7693,"open_issues":3136,"watchers":23114,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/22878"},"html":{"href":"https://github.com/ansible/ansible/pull/22878"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/22878"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/22878/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/22878/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/22878/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/7324bdfc828eeb4996b745ab990e479da5b8c350"}}}}
|
{
"id": 3638964,
"name": "ansible/ansible",
"url": "https://api.github.com/repos/ansible/ansible"
}
|
{
"id": 636610,
"login": "ryansb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/636610?",
"url": "https://api.github.com/users/ryansb"
}
|
{
"id": 1507452,
"login": "ansible",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1507452?",
"url": "https://api.github.com/orgs/ansible"
}
| 2017-05-15T12:01:32 |
5872616718
|
{"actor":{"display_login":"ryansb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astropy/pulls/comments/143514480","pull_request_review_id":68036817,"id":143514480,"diff_hunk":"@@ -843,8 +843,7 @@ def set(self, keyword, value=None, comment=None, before=None, after=None):\n created in the specified position, or appended to the end of the header\n if no position is specified.\n \n- This method is similar to :meth:`Header.update` prior to PyFITS 3.1","path":"astropy/io/fits/header.py","position":4,"original_position":4,"commit_id":"270be6398f8c4956ba1912abcda276edb85fb077","original_commit_id":"270be6398f8c4956ba1912abcda276edb85fb077","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars2.githubusercontent.com/u/14200878?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"body":"This has it's own documentation page http://docs.astropy.org/en/stable/io/fits/appendix/header_transition.html.","created_at":"2017-10-09T16:15:20Z","updated_at":"2017-10-09T16:15:21Z","html_url":"https://github.com/astropy/astropy/pull/6685#discussion_r143514480","pull_request_url":"https://api.github.com/repos/astropy/astropy/pulls/6685","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments/143514480"},"html":{"href":"https://github.com/astropy/astropy/pull/6685#discussion_r143514480"},"pull_request":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6685"}},"in_reply_to_id":143492684},"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/6685","id":145311206,"html_url":"https://github.com/astropy/astropy/pull/6685","diff_url":"https://github.com/astropy/astropy/pull/6685.diff","patch_url":"https://github.com/astropy/astropy/pull/6685.patch","issue_url":"https://api.github.com/repos/astropy/astropy/issues/6685","number":6685,"state":"open","locked":false,"title":"Remove more PyFITS references","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars2.githubusercontent.com/u/14200878?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"body":"There were some PyFITS mentions in the narrative docs. This PR removes (most) of them. The ones remaining are either in the \"appendix\" or in the start-section that contains a mention the `from astropy.io import fits as pyfits` that people wanting to migrate still often use.\r\n\r\nMilestoning as 2.0.3 but probably cannot be backported if #6664 isn't backported.","created_at":"2017-10-07T22:15:51Z","updated_at":"2017-10-09T16:15:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77fc07da62360970894327ec497b9579c3be91d0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/51","html_url":"https://github.com/astropy/astropy/milestone/51","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/51/labels","id":2751532,"number":51,"title":"v2.0.3","description":"","creator":{"login":"bsipocz","id":6788290,"avatar_url":"https://avatars1.githubusercontent.com/u/6788290?v=4","gravatar_id":"","url":"https://api.github.com/users/bsipocz","html_url":"https://github.com/bsipocz","followers_url":"https://api.github.com/users/bsipocz/followers","following_url":"https://api.github.com/users/bsipocz/following{/other_user}","gists_url":"https://api.github.com/users/bsipocz/gists{/gist_id}","starred_url":"https://api.github.com/users/bsipocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsipocz/subscriptions","organizations_url":"https://api.github.com/users/bsipocz/orgs","repos_url":"https://api.github.com/users/bsipocz/repos","events_url":"https://api.github.com/users/bsipocz/events{/privacy}","received_events_url":"https://api.github.com/users/bsipocz/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":49,"state":"open","created_at":"2017-09-07T20:16:28Z","updated_at":"2017-10-09T16:06:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/astropy/astropy/pulls/6685/commits","review_comments_url":"https://api.github.com/repos/astropy/astropy/pulls/6685/comments","review_comment_url":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/6685/comments","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/270be6398f8c4956ba1912abcda276edb85fb077","head":{"label":"MSeifert04:pyfits-removal-narrative-docs","ref":"pyfits-removal-narrative-docs","sha":"270be6398f8c4956ba1912abcda276edb85fb077","user":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars2.githubusercontent.com/u/14200878?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"repo":{"id":42801766,"name":"astropy","full_name":"MSeifert04/astropy","owner":{"login":"MSeifert04","id":14200878,"avatar_url":"https://avatars2.githubusercontent.com/u/14200878?v=4","gravatar_id":"","url":"https://api.github.com/users/MSeifert04","html_url":"https://github.com/MSeifert04","followers_url":"https://api.github.com/users/MSeifert04/followers","following_url":"https://api.github.com/users/MSeifert04/following{/other_user}","gists_url":"https://api.github.com/users/MSeifert04/gists{/gist_id}","starred_url":"https://api.github.com/users/MSeifert04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MSeifert04/subscriptions","organizations_url":"https://api.github.com/users/MSeifert04/orgs","repos_url":"https://api.github.com/users/MSeifert04/repos","events_url":"https://api.github.com/users/MSeifert04/events{/privacy}","received_events_url":"https://api.github.com/users/MSeifert04/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MSeifert04/astropy","description":"Repository for the Astropy core package","fork":true,"url":"https://api.github.com/repos/MSeifert04/astropy","forks_url":"https://api.github.com/repos/MSeifert04/astropy/forks","keys_url":"https://api.github.com/repos/MSeifert04/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MSeifert04/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MSeifert04/astropy/teams","hooks_url":"https://api.github.com/repos/MSeifert04/astropy/hooks","issue_events_url":"https://api.github.com/repos/MSeifert04/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/MSeifert04/astropy/events","assignees_url":"https://api.github.com/repos/MSeifert04/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/MSeifert04/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/MSeifert04/astropy/tags","blobs_url":"https://api.github.com/repos/MSeifert04/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MSeifert04/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MSeifert04/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/MSeifert04/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MSeifert04/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/MSeifert04/astropy/languages","stargazers_url":"https://api.github.com/repos/MSeifert04/astropy/stargazers","contributors_url":"https://api.github.com/repos/MSeifert04/astropy/contributors","subscribers_url":"https://api.github.com/repos/MSeifert04/astropy/subscribers","subscription_url":"https://api.github.com/repos/MSeifert04/astropy/subscription","commits_url":"https://api.github.com/repos/MSeifert04/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/MSeifert04/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/MSeifert04/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/MSeifert04/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/MSeifert04/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/MSeifert04/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MSeifert04/astropy/merges","archive_url":"https://api.github.com/repos/MSeifert04/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MSeifert04/astropy/downloads","issues_url":"https://api.github.com/repos/MSeifert04/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/MSeifert04/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/MSeifert04/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/MSeifert04/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MSeifert04/astropy/labels{/name}","releases_url":"https://api.github.com/repos/MSeifert04/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/MSeifert04/astropy/deployments","created_at":"2015-09-20T05:43:07Z","updated_at":"2016-04-12T23:47:32Z","pushed_at":"2017-10-09T16:02:15Z","git_url":"git://github.com/MSeifert04/astropy.git","ssh_url":"git@github.com:MSeifert04/astropy.git","clone_url":"https://github.com/MSeifert04/astropy.git","svn_url":"https://github.com/MSeifert04/astropy","homepage":"www.astropy.org","size":57324,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"astropy:master","ref":"master","sha":"308ea8f6cbd828325bda19a1cecf680ac9b3e567","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":2081289,"name":"astropy","full_name":"astropy/astropy","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars0.githubusercontent.com/u/847984?v=4","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astropy","description":"Repository for the Astropy core package","fork":false,"url":"https://api.github.com/repos/astropy/astropy","forks_url":"https://api.github.com/repos/astropy/astropy/forks","keys_url":"https://api.github.com/repos/astropy/astropy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astropy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astropy/teams","hooks_url":"https://api.github.com/repos/astropy/astropy/hooks","issue_events_url":"https://api.github.com/repos/astropy/astropy/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astropy/events","assignees_url":"https://api.github.com/repos/astropy/astropy/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astropy/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astropy/tags","blobs_url":"https://api.github.com/repos/astropy/astropy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astropy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astropy/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astropy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astropy/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astropy/languages","stargazers_url":"https://api.github.com/repos/astropy/astropy/stargazers","contributors_url":"https://api.github.com/repos/astropy/astropy/contributors","subscribers_url":"https://api.github.com/repos/astropy/astropy/subscribers","subscription_url":"https://api.github.com/repos/astropy/astropy/subscription","commits_url":"https://api.github.com/repos/astropy/astropy/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astropy/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astropy/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astropy/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astropy/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astropy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astropy/merges","archive_url":"https://api.github.com/repos/astropy/astropy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astropy/downloads","issues_url":"https://api.github.com/repos/astropy/astropy/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astropy/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astropy/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astropy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astropy/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astropy/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astropy/deployments","created_at":"2011-07-21T01:33:49Z","updated_at":"2017-10-09T12:32:33Z","pushed_at":"2017-10-09T16:14:37Z","git_url":"git://github.com/astropy/astropy.git","ssh_url":"git@github.com:astropy/astropy.git","clone_url":"https://github.com/astropy/astropy.git","svn_url":"https://github.com/astropy/astropy","homepage":"www.astropy.org","size":60805,"stargazers_count":1422,"watchers_count":1422,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":762,"mirror_url":null,"open_issues_count":786,"forks":762,"open_issues":786,"watchers":1422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6685"},"html":{"href":"https://github.com/astropy/astropy/pull/6685"},"issue":{"href":"https://api.github.com/repos/astropy/astropy/issues/6685"},"comments":{"href":"https://api.github.com/repos/astropy/astropy/issues/6685/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6685/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astropy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astropy/pulls/6685/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astropy/statuses/270be6398f8c4956ba1912abcda276edb85fb077"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2081289,
"name": "astropy/astropy",
"url": "https://api.github.com/repos/astropy/astropy"
}
|
{
"id": 14200878,
"login": "MSeifert04",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14200878?",
"url": "https://api.github.com/users/MSeifert04"
}
|
{
"id": 847984,
"login": "astropy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/847984?",
"url": "https://api.github.com/orgs/astropy"
}
| 2017-10-09T16:15:20 |
6692412004
|
{"actor":{"display_login":"MSeifert04"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/comments/121799230","pull_request_review_id":43857590,"id":121799230,"diff_hunk":"@@ -0,0 +1,371 @@\n+# Licensed under a 3-clause BSD style license - see LICENSE.rst\n+\"\"\"\n+MAST Portal\n+===========\n+\n+Module to query the Barbara A. Mikulski Archive for Space Telescopes (MAST).\n+\n+\"\"\"\n+\n+from __future__ import print_function, division\n+\n+import warnings\n+import json\n+import time\n+import os\n+\n+import numpy as np\n+\n+from requests import HTTPError\n+\n+import astropy.units as u\n+import astropy.coordinates as coord\n+\n+from astropy.table import Table, Row, vstack\n+from astropy.extern.six.moves.urllib.parse import quote as urlencode\n+\n+from ..query import BaseQuery\n+from ..utils import commons, async_to_sync\n+from ..utils.class_or_instance import class_or_instance\n+from ..exceptions import TimeoutError, InvalidQueryError\n+from . import conf\n+\n+\n+__all__ = ['Observations', 'ObservationsClass',\n+ 'Mast', 'MastClass']\n+\n+\n+class ResolverError(Exception):\n+ pass\n+\n+\n+def _prepare_service_request_string(json_obj):\n+ \"\"\"\n+ Takes a mashup JSON request object and turns it into a url-safe string.\n+\n+ Parameters\n+ ----------\n+ json_obj : dict\n+ A Mashup request JSON object (python dictionary).\n+\n+ Returns\n+ -------\n+ response : str\n+ URL encoded Mashup Request string.\n+ \"\"\"\n+ requestString = json.dumps(json_obj)\n+ requestString = urlencode(requestString)\n+ return \"request=\"+requestString\n+\n+\n+def _mashup_json_to_table(json_obj):\n+ \"\"\"\n+ Takes a JSON object as returned from a Mashup request and turns it into an `astropy.table.Table`.\n+\n+ Parameters\n+ ----------\n+ json_obj : dict\n+ A Mashup response JSON object (python dictionary)\n+\n+ Returns\n+ -------\n+ response: `astropy.table.Table`\n+ \"\"\"\n+\n+ dataTable = Table()\n+\n+ if not (json_obj.get('fields') and json_obj.get('data')):\n+ raise KeyError(\"Missing required key(s) 'data' and/or 'fields.'\")\n+\n+ for col, atype in [(x['name'], x['type']) for x in json_obj['fields']]:\n+ if atype == \"string\":\n+ atype = \"str\"\n+ if atype == \"boolean\":\n+ atype = \"bool\"\n+ dataTable[col] = np.array([x.get(col, None) for x in json_obj['data']], dtype=atype)\n+\n+ # Removing \"_selected_\" column\n+ if \"_selected_\" in dataTable.colnames:\n+ dataTable.remove_column(\"_selected_\")\n+\n+ return dataTable\n+\n+\n+@async_to_sync\n+class MastClass(BaseQuery):\n+ \"\"\"\n+ MAST query class.\n+\n+ Class that allows direct programatic access to the MAST Portal,\n+ more flexible but less user friendly than `ObservationsClass`.\n+ \"\"\"\n+\n+ def __init__(self):\n+\n+ super(MastClass, self).__init__()\n+\n+ self._SERVER = conf.server\n+ self.TIMEOUT = conf.timeout\n+ self.PAGESIZE = conf.pagesize\n+\n+ def _request(self, method, url, params=None, data=None, headers=None,\n+ files=None, stream=False, auth=None, retrieve_all=True):\n+ \"\"\"\n+ Override of the parent method:\n+ A generic HTTP request method, similar to ``requests.Session.request``\n+\n+ This is a low-level method not generally intended for use by astroquery\n+ end-users.\n+\n+ The main difference in this function is that it takes care of the long\n+ polling requirements of the mashup server.\n+ Thus the cache parameter of the parent method is hard coded to false\n+ (the mast server does it's own caching, no need to cache locally and it\n+ interferes with follow requests after an 'Executing' response was returned.)\n+ Also parameters that allow for file download through this method are removed\n+\n+\n+ Parameters\n+ ----------\n+ method : 'GET' or 'POST'\n+ url : str\n+ params : None or dict\n+ data : None or dict\n+ headers : None or dict\n+ auth : None or dict\n+ files : None or dict\n+ stream : bool\n+ See ``requests.request``\n+ retrieve_all : bool\n+ Default True. Retrieve all pages of data or just the one indicated in the params value.\n+\n+ Returns\n+ -------\n+ response : ``requests.Response``\n+ The response from the server.\n+ \"\"\"\n+\n+ startTime = time.time()\n+ allResponses = []\n+ totalPages = 1\n+ curPage = 0\n+\n+ while curPage < totalPages:\n+ status = \"EXECUTING\"\n+\n+ while status == \"EXECUTING\":\n+ response = super(MastClass, self)._request(method, url, params=params, data=data,\n+ headers=headers, files=files, cache=False,\n+ stream=stream, auth=auth)\n+\n+ if (time.time() - startTime) >= self.TIMEOUT:\n+ raise TimeoutError(\"Timeout limit of %f exceeded.\" % self.TIMEOUT)\n+\n+ result = response.json()\n+ status = result.get(\"status\")\n+\n+ allResponses.append(response)\n+\n+ if (status != \"COMPLETE\") or (not retrieve_all):\n+ break\n+\n+ paging = result.get(\"paging\")\n+ if paging is None:\n+ break\n+ totalPages = paging['pagesFiltered']\n+ curPage = paging['page']\n+\n+ data = data.replace(\"page%22%3A%20\"+str(curPage)+\"%2C\", \"page%22%3A%20\"+str(curPage+1)+\"%2C\")\n+\n+ return allResponses\n+\n+ def _parse_result(self, responses, verbose=False):\n+ \"\"\"\n+ Parse the results of a list of ``requests.Response`` objects and returns an `astropy.table.Table` of results.\n+\n+ Parameters\n+ ----------\n+ responses : list of ``requests.Response``\n+ List of ``requests.Response`` objects.\n+ verbose : bool\n+ Default False. Setting to True provides more extensive output.","path":"astroquery/mast/core.py","position":191,"original_position":191,"commit_id":"fecf4ecc39ab982421852e3ecb67dcfc92b53e7c","original_commit_id":"fecf4ecc39ab982421852e3ecb67dcfc92b53e7c","user":{"login":"keflavich","id":143715,"avatar_url":"https://avatars2.githubusercontent.com/u/143715?v=3","gravatar_id":"","url":"https://api.github.com/users/keflavich","html_url":"https://github.com/keflavich","followers_url":"https://api.github.com/users/keflavich/followers","following_url":"https://api.github.com/users/keflavich/following{/other_user}","gists_url":"https://api.github.com/users/keflavich/gists{/gist_id}","starred_url":"https://api.github.com/users/keflavich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keflavich/subscriptions","organizations_url":"https://api.github.com/users/keflavich/orgs","repos_url":"https://api.github.com/users/keflavich/repos","events_url":"https://api.github.com/users/keflavich/events{/privacy}","received_events_url":"https://api.github.com/users/keflavich/received_events","type":"User","site_admin":false},"body":"verbose actually does nothing here.","created_at":"2017-06-13T21:17:13Z","updated_at":"2017-06-13T21:23:23Z","html_url":"https://github.com/astropy/astroquery/pull/920#discussion_r121799230","pull_request_url":"https://api.github.com/repos/astropy/astroquery/pulls/920","_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments/121799230"},"html":{"href":"https://github.com/astropy/astroquery/pull/920#discussion_r121799230"},"pull_request":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/920"}}},"pull_request":{"url":"https://api.github.com/repos/astropy/astroquery/pulls/920","id":124027157,"html_url":"https://github.com/astropy/astroquery/pull/920","diff_url":"https://github.com/astropy/astroquery/pull/920.diff","patch_url":"https://github.com/astropy/astroquery/pull/920.patch","issue_url":"https://api.github.com/repos/astropy/astroquery/issues/920","number":920,"state":"open","locked":false,"title":"MAST Query","user":{"login":"ceb8","id":9406508,"avatar_url":"https://avatars2.githubusercontent.com/u/9406508?v=3","gravatar_id":"","url":"https://api.github.com/users/ceb8","html_url":"https://github.com/ceb8","followers_url":"https://api.github.com/users/ceb8/followers","following_url":"https://api.github.com/users/ceb8/following{/other_user}","gists_url":"https://api.github.com/users/ceb8/gists{/gist_id}","starred_url":"https://api.github.com/users/ceb8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceb8/subscriptions","organizations_url":"https://api.github.com/users/ceb8/orgs","repos_url":"https://api.github.com/users/ceb8/repos","events_url":"https://api.github.com/users/ceb8/events{/privacy}","received_events_url":"https://api.github.com/users/ceb8/received_events","type":"User","site_admin":false},"body":"This is the initial functionality for the astroquery.mast which will allow for querying the MAST archive (mast.stsci.edu).\r\n\r\nThe overall structure is a baseclass and two subclasses, only one of which is currently implemented. This is very bare bones functionality so that I can address any issues as soon as possible\r\n\r\nThe module specification is as follows, with the bolded functions being the ones currently implemented:\r\n\r\nEDIT by bsipocz: I've changed the format to use a checklist rather than bold/normal fonts.\r\n\r\n**MastClass:**\r\n\r\n* [x] service_request\\[_async](service,params): Astropy Table of mashup results\r\n\r\n**ObservationsClass(MastClass):**\r\n\r\n* [x] query_object\\[_async](objectname,radius,pagesize,page): Astropy Table of observations\r\n* [x] query_region\\[_async](coordinates,radius,pagesize,page): Astropy Table of observations\r\n* [ ] query_filter\\[_async](filters,objectname,coordinates,radius,pagesize,page): Astropy Table of observations\r\n\r\n* [ ] query_object_count(objectname,radius): Number of observations\r\n* [ ] query_region_count(coordinates,radius): Number of observations\r\n* [ ] query_filter_count(filters,objectname,coordinates,radius): Number of observations\r\n\r\n* [ ] get_product_list(obsidOrRow): Astropy Table of data products\r\n* [ ] filter_products(products,filters): Astropy Table of data products\r\n* [ ] download_products(obsidsOrProductRows,downloadDir,mrpOnly,filters,curlFlag): Astropy Table manifest of downloaded files\r\n\r\n**CatalogClass(MastClass):**\r\n\r\n* [ ] query_object_catalog(objectname,radius,resource,pagesize,page): Astropy Table of catalog entries\r\n* [ ] query_region_catalog(coordinates,radius,resource,pagesize,page): Astropy Table of catalog entries\r\n* [ ] Other functions TBD\r\n","created_at":"2017-06-05T18:01:03Z","updated_at":"2017-06-13T21:23:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffa259ea0f61588c9a45e3bf976ee33d8137bc9f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/astropy/astroquery/pulls/920/commits","review_comments_url":"https://api.github.com/repos/astropy/astroquery/pulls/920/comments","review_comment_url":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/astropy/astroquery/issues/920/comments","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/fecf4ecc39ab982421852e3ecb67dcfc92b53e7c","head":{"label":"ceb8:mastApi","ref":"mastApi","sha":"fecf4ecc39ab982421852e3ecb67dcfc92b53e7c","user":{"login":"ceb8","id":9406508,"avatar_url":"https://avatars2.githubusercontent.com/u/9406508?v=3","gravatar_id":"","url":"https://api.github.com/users/ceb8","html_url":"https://github.com/ceb8","followers_url":"https://api.github.com/users/ceb8/followers","following_url":"https://api.github.com/users/ceb8/following{/other_user}","gists_url":"https://api.github.com/users/ceb8/gists{/gist_id}","starred_url":"https://api.github.com/users/ceb8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceb8/subscriptions","organizations_url":"https://api.github.com/users/ceb8/orgs","repos_url":"https://api.github.com/users/ceb8/repos","events_url":"https://api.github.com/users/ceb8/events{/privacy}","received_events_url":"https://api.github.com/users/ceb8/received_events","type":"User","site_admin":false},"repo":{"id":85614867,"name":"astroquery","full_name":"ceb8/astroquery","owner":{"login":"ceb8","id":9406508,"avatar_url":"https://avatars2.githubusercontent.com/u/9406508?v=3","gravatar_id":"","url":"https://api.github.com/users/ceb8","html_url":"https://github.com/ceb8","followers_url":"https://api.github.com/users/ceb8/followers","following_url":"https://api.github.com/users/ceb8/following{/other_user}","gists_url":"https://api.github.com/users/ceb8/gists{/gist_id}","starred_url":"https://api.github.com/users/ceb8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceb8/subscriptions","organizations_url":"https://api.github.com/users/ceb8/orgs","repos_url":"https://api.github.com/users/ceb8/repos","events_url":"https://api.github.com/users/ceb8/events{/privacy}","received_events_url":"https://api.github.com/users/ceb8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ceb8/astroquery","description":"Functions and classes to access online data resources. Maintainer: @keflavich and @bsipocz","fork":true,"url":"https://api.github.com/repos/ceb8/astroquery","forks_url":"https://api.github.com/repos/ceb8/astroquery/forks","keys_url":"https://api.github.com/repos/ceb8/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceb8/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceb8/astroquery/teams","hooks_url":"https://api.github.com/repos/ceb8/astroquery/hooks","issue_events_url":"https://api.github.com/repos/ceb8/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/ceb8/astroquery/events","assignees_url":"https://api.github.com/repos/ceb8/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/ceb8/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/ceb8/astroquery/tags","blobs_url":"https://api.github.com/repos/ceb8/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceb8/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceb8/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceb8/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceb8/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/ceb8/astroquery/languages","stargazers_url":"https://api.github.com/repos/ceb8/astroquery/stargazers","contributors_url":"https://api.github.com/repos/ceb8/astroquery/contributors","subscribers_url":"https://api.github.com/repos/ceb8/astroquery/subscribers","subscription_url":"https://api.github.com/repos/ceb8/astroquery/subscription","commits_url":"https://api.github.com/repos/ceb8/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceb8/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceb8/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceb8/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceb8/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/ceb8/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceb8/astroquery/merges","archive_url":"https://api.github.com/repos/ceb8/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceb8/astroquery/downloads","issues_url":"https://api.github.com/repos/ceb8/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/ceb8/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/ceb8/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/ceb8/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceb8/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/ceb8/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/ceb8/astroquery/deployments","created_at":"2017-03-20T18:59:33Z","updated_at":"2017-03-20T18:59:36Z","pushed_at":"2017-06-09T14:09:35Z","git_url":"git://github.com/ceb8/astroquery.git","ssh_url":"git@github.com:ceb8/astroquery.git","clone_url":"https://github.com/ceb8/astroquery.git","svn_url":"https://github.com/ceb8/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":56621,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"astropy-0.2"}},"base":{"label":"astropy:master","ref":"master","sha":"2c27c472109167a7588237d8342f6f3e4af0c39e","user":{"login":"astropy","id":847984,"avatar_url":"https://avatars3.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"repo":{"id":4787269,"name":"astroquery","full_name":"astropy/astroquery","owner":{"login":"astropy","id":847984,"avatar_url":"https://avatars3.githubusercontent.com/u/847984?v=3","gravatar_id":"","url":"https://api.github.com/users/astropy","html_url":"https://github.com/astropy","followers_url":"https://api.github.com/users/astropy/followers","following_url":"https://api.github.com/users/astropy/following{/other_user}","gists_url":"https://api.github.com/users/astropy/gists{/gist_id}","starred_url":"https://api.github.com/users/astropy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astropy/subscriptions","organizations_url":"https://api.github.com/users/astropy/orgs","repos_url":"https://api.github.com/users/astropy/repos","events_url":"https://api.github.com/users/astropy/events{/privacy}","received_events_url":"https://api.github.com/users/astropy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/astropy/astroquery","description":"Functions and classes to access online data resources. Maintainer: @keflavich and @bsipocz","fork":false,"url":"https://api.github.com/repos/astropy/astroquery","forks_url":"https://api.github.com/repos/astropy/astroquery/forks","keys_url":"https://api.github.com/repos/astropy/astroquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astropy/astroquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astropy/astroquery/teams","hooks_url":"https://api.github.com/repos/astropy/astroquery/hooks","issue_events_url":"https://api.github.com/repos/astropy/astroquery/issues/events{/number}","events_url":"https://api.github.com/repos/astropy/astroquery/events","assignees_url":"https://api.github.com/repos/astropy/astroquery/assignees{/user}","branches_url":"https://api.github.com/repos/astropy/astroquery/branches{/branch}","tags_url":"https://api.github.com/repos/astropy/astroquery/tags","blobs_url":"https://api.github.com/repos/astropy/astroquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astropy/astroquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astropy/astroquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/astropy/astroquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astropy/astroquery/statuses/{sha}","languages_url":"https://api.github.com/repos/astropy/astroquery/languages","stargazers_url":"https://api.github.com/repos/astropy/astroquery/stargazers","contributors_url":"https://api.github.com/repos/astropy/astroquery/contributors","subscribers_url":"https://api.github.com/repos/astropy/astroquery/subscribers","subscription_url":"https://api.github.com/repos/astropy/astroquery/subscription","commits_url":"https://api.github.com/repos/astropy/astroquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/astropy/astroquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/astropy/astroquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/astropy/astroquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/astropy/astroquery/contents/{+path}","compare_url":"https://api.github.com/repos/astropy/astroquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astropy/astroquery/merges","archive_url":"https://api.github.com/repos/astropy/astroquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astropy/astroquery/downloads","issues_url":"https://api.github.com/repos/astropy/astroquery/issues{/number}","pulls_url":"https://api.github.com/repos/astropy/astroquery/pulls{/number}","milestones_url":"https://api.github.com/repos/astropy/astroquery/milestones{/number}","notifications_url":"https://api.github.com/repos/astropy/astroquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astropy/astroquery/labels{/name}","releases_url":"https://api.github.com/repos/astropy/astroquery/releases{/id}","deployments_url":"https://api.github.com/repos/astropy/astroquery/deployments","created_at":"2012-06-25T20:52:07Z","updated_at":"2017-05-12T12:32:37Z","pushed_at":"2017-06-09T14:09:37Z","git_url":"git://github.com/astropy/astroquery.git","ssh_url":"git@github.com:astropy/astroquery.git","clone_url":"https://github.com/astropy/astroquery.git","svn_url":"https://github.com/astropy/astroquery","homepage":"http://astroquery.readthedocs.org/en/latest/","size":56602,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"open_issues_count":144,"forks":110,"open_issues":144,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/920"},"html":{"href":"https://github.com/astropy/astroquery/pull/920"},"issue":{"href":"https://api.github.com/repos/astropy/astroquery/issues/920"},"comments":{"href":"https://api.github.com/repos/astropy/astroquery/issues/920/comments"},"review_comments":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/920/comments"},"review_comment":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/astropy/astroquery/pulls/920/commits"},"statuses":{"href":"https://api.github.com/repos/astropy/astroquery/statuses/fecf4ecc39ab982421852e3ecb67dcfc92b53e7c"}}}}
|
{
"id": 4787269,
"name": "astropy/astroquery",
"url": "https://api.github.com/repos/astropy/astroquery"
}
|
{
"id": 143715,
"login": "keflavich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/143715?",
"url": "https://api.github.com/users/keflavich"
}
|
{
"id": 847984,
"login": "astropy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/847984?",
"url": "https://api.github.com/orgs/astropy"
}
| 2017-06-13T21:17:13 |
6059169477
|
{"actor":{"display_login":"keflavich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/atomist/rug/pulls/comments/112390610","pull_request_review_id":33700092,"id":112390610,"diff_hunk":"@@ -1,29 +1,33 @@\n import { GraphNode, TreeNode, PathExpressionEngine, PathExpression, Match } from \"../tree/PathExpression\"\n import { Parameter } from \"./RugOperation\"\n \n-interface RugCoordinate {\n+export interface RugCoordinate {\n readonly name: string","path":"src/main/typescript/node_modules/@atomist/rug/operations/Handlers.ts","position":6,"original_position":6,"commit_id":"9ccba72ba609c27ff38e81d763e635f7b71cb6dd","original_commit_id":"9ccba72ba609c27ff38e81d763e635f7b71cb6dd","user":{"login":"kipz","id":1865026,"avatar_url":"https://avatars1.githubusercontent.com/u/1865026?v=3","gravatar_id":"","url":"https://api.github.com/users/kipz","html_url":"https://github.com/kipz","followers_url":"https://api.github.com/users/kipz/followers","following_url":"https://api.github.com/users/kipz/following{/other_user}","gists_url":"https://api.github.com/users/kipz/gists{/gist_id}","starred_url":"https://api.github.com/users/kipz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kipz/subscriptions","organizations_url":"https://api.github.com/users/kipz/orgs","repos_url":"https://api.github.com/users/kipz/repos","events_url":"https://api.github.com/users/kipz/events{/privacy}","received_events_url":"https://api.github.com/users/kipz/received_events","type":"User","site_admin":false},"body":"Me too! It's a pain to have to scroll around to figure out what's going on!","created_at":"2017-04-20T08:09:45Z","updated_at":"2017-04-20T08:09:45Z","html_url":"https://github.com/atomist/rug/pull/528#discussion_r112390610","pull_request_url":"https://api.github.com/repos/atomist/rug/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/atomist/rug/pulls/comments/112390610"},"html":{"href":"https://github.com/atomist/rug/pull/528#discussion_r112390610"},"pull_request":{"href":"https://api.github.com/repos/atomist/rug/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/atomist/rug/pulls/528","id":116592705,"html_url":"https://github.com/atomist/rug/pull/528","diff_url":"https://github.com/atomist/rug/pull/528.diff","patch_url":"https://github.com/atomist/rug/pull/528.patch","issue_url":"https://api.github.com/repos/atomist/rug/issues/528","number":528,"state":"open","locked":false,"title":"More specific typings for handler responses","user":{"login":"kipz","id":1865026,"avatar_url":"https://avatars1.githubusercontent.com/u/1865026?v=3","gravatar_id":"","url":"https://api.github.com/users/kipz","html_url":"https://github.com/kipz","followers_url":"https://api.github.com/users/kipz/followers","following_url":"https://api.github.com/users/kipz/following{/other_user}","gists_url":"https://api.github.com/users/kipz/gists{/gist_id}","starred_url":"https://api.github.com/users/kipz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kipz/subscriptions","organizations_url":"https://api.github.com/users/kipz/orgs","repos_url":"https://api.github.com/users/kipz/repos","events_url":"https://api.github.com/users/kipz/events{/privacy}","received_events_url":"https://api.github.com/users/kipz/received_events","type":"User","site_admin":false},"body":"**BREAKING at version uptake/compile time**\r\n\r\n* Plan -> AbstractPlan\r\n* EventPlan extends AbstractPlan and is returned from Event Handlers\r\n* CommandPlan extends AbstractPlan and is returned from Command Handlers\r\n* ResponseHandlers can now return EventPlan | CommandPlan (not ideal, but progress as it enforced a choice).\r\n","created_at":"2017-04-19T16:46:06Z","updated_at":"2017-04-20T08:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ddcd2a52e9b20d91dac7dd503520adc0a4ae086","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/atomist/rug/pulls/528/commits","review_comments_url":"https://api.github.com/repos/atomist/rug/pulls/528/comments","review_comment_url":"https://api.github.com/repos/atomist/rug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atomist/rug/issues/528/comments","statuses_url":"https://api.github.com/repos/atomist/rug/statuses/9ccba72ba609c27ff38e81d763e635f7b71cb6dd","head":{"label":"atomist:plans","ref":"plans","sha":"9ccba72ba609c27ff38e81d763e635f7b71cb6dd","user":{"login":"atomist","id":19392,"avatar_url":"https://avatars0.githubusercontent.com/u/19392?v=3","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":74643409,"name":"rug","full_name":"atomist/rug","owner":{"login":"atomist","id":19392,"avatar_url":"https://avatars0.githubusercontent.com/u/19392?v=3","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atomist/rug","description":"Runtime for Rugs","fork":false,"url":"https://api.github.com/repos/atomist/rug","forks_url":"https://api.github.com/repos/atomist/rug/forks","keys_url":"https://api.github.com/repos/atomist/rug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/rug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/rug/teams","hooks_url":"https://api.github.com/repos/atomist/rug/hooks","issue_events_url":"https://api.github.com/repos/atomist/rug/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/rug/events","assignees_url":"https://api.github.com/repos/atomist/rug/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/rug/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/rug/tags","blobs_url":"https://api.github.com/repos/atomist/rug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/rug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/rug/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/rug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/rug/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/rug/languages","stargazers_url":"https://api.github.com/repos/atomist/rug/stargazers","contributors_url":"https://api.github.com/repos/atomist/rug/contributors","subscribers_url":"https://api.github.com/repos/atomist/rug/subscribers","subscription_url":"https://api.github.com/repos/atomist/rug/subscription","commits_url":"https://api.github.com/repos/atomist/rug/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/rug/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/rug/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/rug/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/rug/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/rug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/rug/merges","archive_url":"https://api.github.com/repos/atomist/rug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/rug/downloads","issues_url":"https://api.github.com/repos/atomist/rug/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/rug/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/rug/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/rug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/rug/labels{/name}","releases_url":"https://api.github.com/repos/atomist/rug/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/rug/deployments","created_at":"2016-11-24T06:15:09Z","updated_at":"2017-04-16T11:13:47Z","pushed_at":"2017-04-20T07:34:33Z","git_url":"git://github.com/atomist/rug.git","ssh_url":"git@github.com:atomist/rug.git","clone_url":"https://github.com/atomist/rug.git","svn_url":"https://github.com/atomist/rug","homepage":"","size":6491,"stargazers_count":41,"watchers_count":41,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":44,"forks":12,"open_issues":44,"watchers":41,"default_branch":"master"}},"base":{"label":"atomist:master","ref":"master","sha":"a35bc360216370cb7ec92223f764465e8da25dad","user":{"login":"atomist","id":19392,"avatar_url":"https://avatars0.githubusercontent.com/u/19392?v=3","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"repo":{"id":74643409,"name":"rug","full_name":"atomist/rug","owner":{"login":"atomist","id":19392,"avatar_url":"https://avatars0.githubusercontent.com/u/19392?v=3","gravatar_id":"","url":"https://api.github.com/users/atomist","html_url":"https://github.com/atomist","followers_url":"https://api.github.com/users/atomist/followers","following_url":"https://api.github.com/users/atomist/following{/other_user}","gists_url":"https://api.github.com/users/atomist/gists{/gist_id}","starred_url":"https://api.github.com/users/atomist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atomist/subscriptions","organizations_url":"https://api.github.com/users/atomist/orgs","repos_url":"https://api.github.com/users/atomist/repos","events_url":"https://api.github.com/users/atomist/events{/privacy}","received_events_url":"https://api.github.com/users/atomist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atomist/rug","description":"Runtime for Rugs","fork":false,"url":"https://api.github.com/repos/atomist/rug","forks_url":"https://api.github.com/repos/atomist/rug/forks","keys_url":"https://api.github.com/repos/atomist/rug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atomist/rug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atomist/rug/teams","hooks_url":"https://api.github.com/repos/atomist/rug/hooks","issue_events_url":"https://api.github.com/repos/atomist/rug/issues/events{/number}","events_url":"https://api.github.com/repos/atomist/rug/events","assignees_url":"https://api.github.com/repos/atomist/rug/assignees{/user}","branches_url":"https://api.github.com/repos/atomist/rug/branches{/branch}","tags_url":"https://api.github.com/repos/atomist/rug/tags","blobs_url":"https://api.github.com/repos/atomist/rug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atomist/rug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atomist/rug/git/refs{/sha}","trees_url":"https://api.github.com/repos/atomist/rug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atomist/rug/statuses/{sha}","languages_url":"https://api.github.com/repos/atomist/rug/languages","stargazers_url":"https://api.github.com/repos/atomist/rug/stargazers","contributors_url":"https://api.github.com/repos/atomist/rug/contributors","subscribers_url":"https://api.github.com/repos/atomist/rug/subscribers","subscription_url":"https://api.github.com/repos/atomist/rug/subscription","commits_url":"https://api.github.com/repos/atomist/rug/commits{/sha}","git_commits_url":"https://api.github.com/repos/atomist/rug/git/commits{/sha}","comments_url":"https://api.github.com/repos/atomist/rug/comments{/number}","issue_comment_url":"https://api.github.com/repos/atomist/rug/issues/comments{/number}","contents_url":"https://api.github.com/repos/atomist/rug/contents/{+path}","compare_url":"https://api.github.com/repos/atomist/rug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atomist/rug/merges","archive_url":"https://api.github.com/repos/atomist/rug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atomist/rug/downloads","issues_url":"https://api.github.com/repos/atomist/rug/issues{/number}","pulls_url":"https://api.github.com/repos/atomist/rug/pulls{/number}","milestones_url":"https://api.github.com/repos/atomist/rug/milestones{/number}","notifications_url":"https://api.github.com/repos/atomist/rug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atomist/rug/labels{/name}","releases_url":"https://api.github.com/repos/atomist/rug/releases{/id}","deployments_url":"https://api.github.com/repos/atomist/rug/deployments","created_at":"2016-11-24T06:15:09Z","updated_at":"2017-04-16T11:13:47Z","pushed_at":"2017-04-20T07:34:33Z","git_url":"git://github.com/atomist/rug.git","ssh_url":"git@github.com:atomist/rug.git","clone_url":"https://github.com/atomist/rug.git","svn_url":"https://github.com/atomist/rug","homepage":"","size":6491,"stargazers_count":41,"watchers_count":41,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"open_issues_count":44,"forks":12,"open_issues":44,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atomist/rug/pulls/528"},"html":{"href":"https://github.com/atomist/rug/pull/528"},"issue":{"href":"https://api.github.com/repos/atomist/rug/issues/528"},"comments":{"href":"https://api.github.com/repos/atomist/rug/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/atomist/rug/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/atomist/rug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atomist/rug/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/atomist/rug/statuses/9ccba72ba609c27ff38e81d763e635f7b71cb6dd"}}}}
|
{
"id": 74643409,
"name": "atomist/rug",
"url": "https://api.github.com/repos/atomist/rug"
}
|
{
"id": 1865026,
"login": "kipz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1865026?",
"url": "https://api.github.com/users/kipz"
}
|
{
"id": 19392,
"login": "atomist",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19392?",
"url": "https://api.github.com/orgs/atomist"
}
| 2017-04-20T08:09:45 |
5721926434
|
{"actor":{"display_login":"kipz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/sockeye/pulls/comments/128783365","pull_request_review_id":51498820,"id":128783365,"diff_hunk":"@@ -630,12 +630,18 @@ def _beam_search(self,\n :return List of lists of word ids, list of attentions, array of accumulated length-normalized\n negative log-probs.\n \"\"\"\n+ # Length of encoded sequence (may differ from initial input length)\n+ encoded_source_length = self.models[0].encoder.get_encoded_seq_len(bucket_key)\n+ for m in self.models[1:]:\n+ utils.check_condition(m.get_encoded_seq_len(bucket_key) == encoded_source_length,","path":"sockeye/inference.py","position":null,"original_position":7,"commit_id":"5d9f8bc8597d4fe78f4984c5721aed755c8409a8","original_commit_id":"c7ee5cf1fb569e9b005cdd56b3e3d9d98dc965c3","user":{"login":"mjdenkowski","id":636653,"avatar_url":"https://avatars3.githubusercontent.com/u/636653?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenkowski","html_url":"https://github.com/mjdenkowski","followers_url":"https://api.github.com/users/mjdenkowski/followers","following_url":"https://api.github.com/users/mjdenkowski/following{/other_user}","gists_url":"https://api.github.com/users/mjdenkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenkowski/subscriptions","organizations_url":"https://api.github.com/users/mjdenkowski/orgs","repos_url":"https://api.github.com/users/mjdenkowski/repos","events_url":"https://api.github.com/users/mjdenkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenkowski/received_events","type":"User","site_admin":false},"body":"Good way to save a line!","created_at":"2017-07-21T14:58:07Z","updated_at":"2017-07-21T14:58:07Z","html_url":"https://github.com/awslabs/sockeye/pull/83#discussion_r128783365","pull_request_url":"https://api.github.com/repos/awslabs/sockeye/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/comments/128783365"},"html":{"href":"https://github.com/awslabs/sockeye/pull/83#discussion_r128783365"},"pull_request":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/sockeye/pulls/83","id":131676228,"html_url":"https://github.com/awslabs/sockeye/pull/83","diff_url":"https://github.com/awslabs/sockeye/pull/83.diff","patch_url":"https://github.com/awslabs/sockeye/pull/83.patch","issue_url":"https://api.github.com/repos/awslabs/sockeye/issues/83","number":83,"state":"open","locked":false,"title":"Propagate encoded sequence length during inference","user":{"login":"mjdenkowski","id":636653,"avatar_url":"https://avatars3.githubusercontent.com/u/636653?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenkowski","html_url":"https://github.com/mjdenkowski","followers_url":"https://api.github.com/users/mjdenkowski/followers","following_url":"https://api.github.com/users/mjdenkowski/following{/other_user}","gists_url":"https://api.github.com/users/mjdenkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenkowski/subscriptions","organizations_url":"https://api.github.com/users/mjdenkowski/orgs","repos_url":"https://api.github.com/users/mjdenkowski/repos","events_url":"https://api.github.com/users/mjdenkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenkowski/received_events","type":"User","site_admin":false},"body":"Looks like something may have gotten out of sync. Querying encoded sequence length here gets the ConvolutionalEmbeddingEncoder working again.\r\n\r\nThis might be a good time to think about some tiny end-to-end tests. I'll open an issue for discussion.","created_at":"2017-07-21T00:21:23Z","updated_at":"2017-07-21T14:58:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc66af157a96e849ba9803bbe4b069cfef7b7831","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tdomhan","id":363737,"avatar_url":"https://avatars1.githubusercontent.com/u/363737?v=4","gravatar_id":"","url":"https://api.github.com/users/tdomhan","html_url":"https://github.com/tdomhan","followers_url":"https://api.github.com/users/tdomhan/followers","following_url":"https://api.github.com/users/tdomhan/following{/other_user}","gists_url":"https://api.github.com/users/tdomhan/gists{/gist_id}","starred_url":"https://api.github.com/users/tdomhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdomhan/subscriptions","organizations_url":"https://api.github.com/users/tdomhan/orgs","repos_url":"https://api.github.com/users/tdomhan/repos","events_url":"https://api.github.com/users/tdomhan/events{/privacy}","received_events_url":"https://api.github.com/users/tdomhan/received_events","type":"User","site_admin":false},{"login":"davvil","id":683589,"avatar_url":"https://avatars0.githubusercontent.com/u/683589?v=4","gravatar_id":"","url":"https://api.github.com/users/davvil","html_url":"https://github.com/davvil","followers_url":"https://api.github.com/users/davvil/followers","following_url":"https://api.github.com/users/davvil/following{/other_user}","gists_url":"https://api.github.com/users/davvil/gists{/gist_id}","starred_url":"https://api.github.com/users/davvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davvil/subscriptions","organizations_url":"https://api.github.com/users/davvil/orgs","repos_url":"https://api.github.com/users/davvil/repos","events_url":"https://api.github.com/users/davvil/events{/privacy}","received_events_url":"https://api.github.com/users/davvil/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/sockeye/pulls/83/commits","review_comments_url":"https://api.github.com/repos/awslabs/sockeye/pulls/83/comments","review_comment_url":"https://api.github.com/repos/awslabs/sockeye/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/sockeye/issues/83/comments","statuses_url":"https://api.github.com/repos/awslabs/sockeye/statuses/5d9f8bc8597d4fe78f4984c5721aed755c8409a8","head":{"label":"mjdenkowski:master","ref":"master","sha":"5d9f8bc8597d4fe78f4984c5721aed755c8409a8","user":{"login":"mjdenkowski","id":636653,"avatar_url":"https://avatars3.githubusercontent.com/u/636653?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenkowski","html_url":"https://github.com/mjdenkowski","followers_url":"https://api.github.com/users/mjdenkowski/followers","following_url":"https://api.github.com/users/mjdenkowski/following{/other_user}","gists_url":"https://api.github.com/users/mjdenkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenkowski/subscriptions","organizations_url":"https://api.github.com/users/mjdenkowski/orgs","repos_url":"https://api.github.com/users/mjdenkowski/repos","events_url":"https://api.github.com/users/mjdenkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenkowski/received_events","type":"User","site_admin":false},"repo":{"id":94925272,"name":"sockeye","full_name":"mjdenkowski/sockeye","owner":{"login":"mjdenkowski","id":636653,"avatar_url":"https://avatars3.githubusercontent.com/u/636653?v=4","gravatar_id":"","url":"https://api.github.com/users/mjdenkowski","html_url":"https://github.com/mjdenkowski","followers_url":"https://api.github.com/users/mjdenkowski/followers","following_url":"https://api.github.com/users/mjdenkowski/following{/other_user}","gists_url":"https://api.github.com/users/mjdenkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mjdenkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjdenkowski/subscriptions","organizations_url":"https://api.github.com/users/mjdenkowski/orgs","repos_url":"https://api.github.com/users/mjdenkowski/repos","events_url":"https://api.github.com/users/mjdenkowski/events{/privacy}","received_events_url":"https://api.github.com/users/mjdenkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjdenkowski/sockeye","description":"Sequence-to-sequence framework with a focus on Neural Machine Translation based on MXNet","fork":true,"url":"https://api.github.com/repos/mjdenkowski/sockeye","forks_url":"https://api.github.com/repos/mjdenkowski/sockeye/forks","keys_url":"https://api.github.com/repos/mjdenkowski/sockeye/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjdenkowski/sockeye/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjdenkowski/sockeye/teams","hooks_url":"https://api.github.com/repos/mjdenkowski/sockeye/hooks","issue_events_url":"https://api.github.com/repos/mjdenkowski/sockeye/issues/events{/number}","events_url":"https://api.github.com/repos/mjdenkowski/sockeye/events","assignees_url":"https://api.github.com/repos/mjdenkowski/sockeye/assignees{/user}","branches_url":"https://api.github.com/repos/mjdenkowski/sockeye/branches{/branch}","tags_url":"https://api.github.com/repos/mjdenkowski/sockeye/tags","blobs_url":"https://api.github.com/repos/mjdenkowski/sockeye/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjdenkowski/sockeye/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjdenkowski/sockeye/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjdenkowski/sockeye/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjdenkowski/sockeye/statuses/{sha}","languages_url":"https://api.github.com/repos/mjdenkowski/sockeye/languages","stargazers_url":"https://api.github.com/repos/mjdenkowski/sockeye/stargazers","contributors_url":"https://api.github.com/repos/mjdenkowski/sockeye/contributors","subscribers_url":"https://api.github.com/repos/mjdenkowski/sockeye/subscribers","subscription_url":"https://api.github.com/repos/mjdenkowski/sockeye/subscription","commits_url":"https://api.github.com/repos/mjdenkowski/sockeye/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjdenkowski/sockeye/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjdenkowski/sockeye/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjdenkowski/sockeye/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjdenkowski/sockeye/contents/{+path}","compare_url":"https://api.github.com/repos/mjdenkowski/sockeye/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjdenkowski/sockeye/merges","archive_url":"https://api.github.com/repos/mjdenkowski/sockeye/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjdenkowski/sockeye/downloads","issues_url":"https://api.github.com/repos/mjdenkowski/sockeye/issues{/number}","pulls_url":"https://api.github.com/repos/mjdenkowski/sockeye/pulls{/number}","milestones_url":"https://api.github.com/repos/mjdenkowski/sockeye/milestones{/number}","notifications_url":"https://api.github.com/repos/mjdenkowski/sockeye/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjdenkowski/sockeye/labels{/name}","releases_url":"https://api.github.com/repos/mjdenkowski/sockeye/releases{/id}","deployments_url":"https://api.github.com/repos/mjdenkowski/sockeye/deployments","created_at":"2017-06-20T18:58:10Z","updated_at":"2017-06-20T18:58:12Z","pushed_at":"2017-07-21T14:56:43Z","git_url":"git://github.com/mjdenkowski/sockeye.git","ssh_url":"git@github.com:mjdenkowski/sockeye.git","clone_url":"https://github.com/mjdenkowski/sockeye.git","svn_url":"https://github.com/mjdenkowski/sockeye","homepage":"","size":284,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"4367ab9e9c6c3a2745e671cca675cc86528e8518","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":93721432,"name":"sockeye","full_name":"awslabs/sockeye","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/sockeye","description":"Sequence-to-sequence framework with a focus on Neural Machine Translation based on Apache MXNet","fork":false,"url":"https://api.github.com/repos/awslabs/sockeye","forks_url":"https://api.github.com/repos/awslabs/sockeye/forks","keys_url":"https://api.github.com/repos/awslabs/sockeye/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/sockeye/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/sockeye/teams","hooks_url":"https://api.github.com/repos/awslabs/sockeye/hooks","issue_events_url":"https://api.github.com/repos/awslabs/sockeye/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/sockeye/events","assignees_url":"https://api.github.com/repos/awslabs/sockeye/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/sockeye/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/sockeye/tags","blobs_url":"https://api.github.com/repos/awslabs/sockeye/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/sockeye/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/sockeye/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/sockeye/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/sockeye/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/sockeye/languages","stargazers_url":"https://api.github.com/repos/awslabs/sockeye/stargazers","contributors_url":"https://api.github.com/repos/awslabs/sockeye/contributors","subscribers_url":"https://api.github.com/repos/awslabs/sockeye/subscribers","subscription_url":"https://api.github.com/repos/awslabs/sockeye/subscription","commits_url":"https://api.github.com/repos/awslabs/sockeye/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/sockeye/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/sockeye/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/sockeye/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/sockeye/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/sockeye/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/sockeye/merges","archive_url":"https://api.github.com/repos/awslabs/sockeye/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/sockeye/downloads","issues_url":"https://api.github.com/repos/awslabs/sockeye/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/sockeye/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/sockeye/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/sockeye/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/sockeye/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/sockeye/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/sockeye/deployments","created_at":"2017-06-08T07:44:30Z","updated_at":"2017-07-21T13:55:19Z","pushed_at":"2017-07-21T14:56:44Z","git_url":"git://github.com/awslabs/sockeye.git","ssh_url":"git@github.com:awslabs/sockeye.git","clone_url":"https://github.com/awslabs/sockeye.git","svn_url":"https://github.com/awslabs/sockeye","homepage":"","size":348,"stargazers_count":153,"watchers_count":153,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":6,"forks":35,"open_issues":6,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/83"},"html":{"href":"https://github.com/awslabs/sockeye/pull/83"},"issue":{"href":"https://api.github.com/repos/awslabs/sockeye/issues/83"},"comments":{"href":"https://api.github.com/repos/awslabs/sockeye/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/sockeye/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/sockeye/statuses/5d9f8bc8597d4fe78f4984c5721aed755c8409a8"}}}}
|
{
"id": 93721432,
"name": "awslabs/sockeye",
"url": "https://api.github.com/repos/awslabs/sockeye"
}
|
{
"id": 636653,
"login": "mjdenkowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/636653?",
"url": "https://api.github.com/users/mjdenkowski"
}
|
{
"id": 3299148,
"login": "awslabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3299148?",
"url": "https://api.github.com/orgs/awslabs"
}
| 2017-07-21T14:58:07 |
6304002892
|
{"actor":{"display_login":"mjdenkowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/batfish/batfish/pulls/comments/133847219","pull_request_review_id":57075746,"id":133847219,"diff_hunk":"@@ -29,40 +27,39 @@\n @Path(CoordConsts.SVC_CFG_WORK_MGR2)\n @Produces(MediaType.APPLICATION_JSON)\n public class WorkMgrServiceV2 {\n+\n+ private BatfishLogger _logger = Main.getLogger();\n+\n+ @DefaultValue(CoordConsts.DEFAULT_API_KEY)\n+ @HeaderParam(CoordConsts.SVC_KEY_API_KEY)\n+ private String _apiKey;\n+\n /** Information on the URI of a request, injected by the server framework at runtime. */\n @Context private UriInfo _uriInfo;\n \n /** Returns the list of {@link Container containers} that the given API key may access. */\n @GET\n- @Path(\"/containers\")\n- public Response getContainers(\n- @DefaultValue(DEFAULT_API_KEY) @HeaderParam(SVC_KEY_API_KEY) String apiKey) {\n- List<Container> containers = Main.getWorkMgr().getContainers(apiKey);\n+ @Path(CoordConsts.SVC_KEY_CONTAINERS)\n+ public Response getContainers() {\n+ _logger.info(\"WMS:getContainers\\n\");\n+ List<Container> containers = Main.getWorkMgr().getContainers(_apiKey);","path":"projects/coordinator/src/main/java/org/batfish/coordinator/WorkMgrServiceV2.java","position":45,"original_position":45,"commit_id":"1bbb68c3343a43f429caa380e11d2ed7a76d8ef6","original_commit_id":"1bbb68c3343a43f429caa380e11d2ed7a76d8ef6","user":{"login":"kidsbear","id":26289653,"avatar_url":"https://avatars3.githubusercontent.com/u/26289653?v=4","gravatar_id":"","url":"https://api.github.com/users/kidsbear","html_url":"https://github.com/kidsbear","followers_url":"https://api.github.com/users/kidsbear/followers","following_url":"https://api.github.com/users/kidsbear/following{/other_user}","gists_url":"https://api.github.com/users/kidsbear/gists{/gist_id}","starred_url":"https://api.github.com/users/kidsbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidsbear/subscriptions","organizations_url":"https://api.github.com/users/kidsbear/orgs","repos_url":"https://api.github.com/users/kidsbear/repos","events_url":"https://api.github.com/users/kidsbear/events{/privacy}","received_events_url":"https://api.github.com/users/kidsbear/received_events","type":"User","site_admin":false},"body":"Should I return a sorted list for determinism? ","created_at":"2017-08-17T22:45:23Z","updated_at":"2017-08-17T22:45:24Z","html_url":"https://github.com/batfish/batfish/pull/341#discussion_r133847219","pull_request_url":"https://api.github.com/repos/batfish/batfish/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/batfish/batfish/pulls/comments/133847219"},"html":{"href":"https://github.com/batfish/batfish/pull/341#discussion_r133847219"},"pull_request":{"href":"https://api.github.com/repos/batfish/batfish/pulls/341"}}},"pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/341","id":136368352,"html_url":"https://github.com/batfish/batfish/pull/341","diff_url":"https://github.com/batfish/batfish/pull/341.diff","patch_url":"https://github.com/batfish/batfish/pull/341.patch","issue_url":"https://api.github.com/repos/batfish/batfish/issues/341","number":341,"state":"open","locked":false,"title":"add ContainerResource and tests","user":{"login":"kidsbear","id":26289653,"avatar_url":"https://avatars3.githubusercontent.com/u/26289653?v=4","gravatar_id":"","url":"https://api.github.com/users/kidsbear","html_url":"https://github.com/kidsbear","followers_url":"https://api.github.com/users/kidsbear/followers","following_url":"https://api.github.com/users/kidsbear/following{/other_user}","gists_url":"https://api.github.com/users/kidsbear/gists{/gist_id}","starred_url":"https://api.github.com/users/kidsbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidsbear/subscriptions","organizations_url":"https://api.github.com/users/kidsbear/orgs","repos_url":"https://api.github.com/users/kidsbear/repos","events_url":"https://api.github.com/users/kidsbear/events{/privacy}","received_events_url":"https://api.github.com/users/kidsbear/received_events","type":"User","site_admin":false},"body":"Add a subResource locator \"ContainerResource\" for WorkMgrServiceV2. ","created_at":"2017-08-17T22:37:09Z","updated_at":"2017-08-17T22:45:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea24207f4297b56e1524dcc103b54556a485dd1e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dhalperi","id":526415,"avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/batfish/batfish/pulls/341/commits","review_comments_url":"https://api.github.com/repos/batfish/batfish/pulls/341/comments","review_comment_url":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/341/comments","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/1bbb68c3343a43f429caa380e11d2ed7a76d8ef6","head":{"label":"kidsbear:add-container-SubResource","ref":"add-container-SubResource","sha":"1bbb68c3343a43f429caa380e11d2ed7a76d8ef6","user":{"login":"kidsbear","id":26289653,"avatar_url":"https://avatars3.githubusercontent.com/u/26289653?v=4","gravatar_id":"","url":"https://api.github.com/users/kidsbear","html_url":"https://github.com/kidsbear","followers_url":"https://api.github.com/users/kidsbear/followers","following_url":"https://api.github.com/users/kidsbear/following{/other_user}","gists_url":"https://api.github.com/users/kidsbear/gists{/gist_id}","starred_url":"https://api.github.com/users/kidsbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidsbear/subscriptions","organizations_url":"https://api.github.com/users/kidsbear/orgs","repos_url":"https://api.github.com/users/kidsbear/repos","events_url":"https://api.github.com/users/kidsbear/events{/privacy}","received_events_url":"https://api.github.com/users/kidsbear/received_events","type":"User","site_admin":false},"repo":{"id":95057752,"name":"batfish","full_name":"kidsbear/batfish","owner":{"login":"kidsbear","id":26289653,"avatar_url":"https://avatars3.githubusercontent.com/u/26289653?v=4","gravatar_id":"","url":"https://api.github.com/users/kidsbear","html_url":"https://github.com/kidsbear","followers_url":"https://api.github.com/users/kidsbear/followers","following_url":"https://api.github.com/users/kidsbear/following{/other_user}","gists_url":"https://api.github.com/users/kidsbear/gists{/gist_id}","starred_url":"https://api.github.com/users/kidsbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kidsbear/subscriptions","organizations_url":"https://api.github.com/users/kidsbear/orgs","repos_url":"https://api.github.com/users/kidsbear/repos","events_url":"https://api.github.com/users/kidsbear/events{/privacy}","received_events_url":"https://api.github.com/users/kidsbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kidsbear/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":true,"url":"https://api.github.com/repos/kidsbear/batfish","forks_url":"https://api.github.com/repos/kidsbear/batfish/forks","keys_url":"https://api.github.com/repos/kidsbear/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kidsbear/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kidsbear/batfish/teams","hooks_url":"https://api.github.com/repos/kidsbear/batfish/hooks","issue_events_url":"https://api.github.com/repos/kidsbear/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/kidsbear/batfish/events","assignees_url":"https://api.github.com/repos/kidsbear/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/kidsbear/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/kidsbear/batfish/tags","blobs_url":"https://api.github.com/repos/kidsbear/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kidsbear/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kidsbear/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/kidsbear/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kidsbear/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/kidsbear/batfish/languages","stargazers_url":"https://api.github.com/repos/kidsbear/batfish/stargazers","contributors_url":"https://api.github.com/repos/kidsbear/batfish/contributors","subscribers_url":"https://api.github.com/repos/kidsbear/batfish/subscribers","subscription_url":"https://api.github.com/repos/kidsbear/batfish/subscription","commits_url":"https://api.github.com/repos/kidsbear/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/kidsbear/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/kidsbear/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/kidsbear/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/kidsbear/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/kidsbear/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kidsbear/batfish/merges","archive_url":"https://api.github.com/repos/kidsbear/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kidsbear/batfish/downloads","issues_url":"https://api.github.com/repos/kidsbear/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/kidsbear/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/kidsbear/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/kidsbear/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kidsbear/batfish/labels{/name}","releases_url":"https://api.github.com/repos/kidsbear/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/kidsbear/batfish/deployments","created_at":"2017-06-22T00:22:28Z","updated_at":"2017-06-22T00:22:33Z","pushed_at":"2017-08-17T22:33:47Z","git_url":"git://github.com/kidsbear/batfish.git","ssh_url":"git@github.com:kidsbear/batfish.git","clone_url":"https://github.com/kidsbear/batfish.git","svn_url":"https://github.com/kidsbear/batfish","homepage":"http://www.batfish.org","size":100759,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"batfish:master","ref":"master","sha":"35afd57a6451d4a833a3d86fb9a5753b09c55cdc","user":{"login":"batfish","id":24584846,"avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":27507850,"name":"batfish","full_name":"batfish/batfish","owner":{"login":"batfish","id":24584846,"avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/batfish/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":false,"url":"https://api.github.com/repos/batfish/batfish","forks_url":"https://api.github.com/repos/batfish/batfish/forks","keys_url":"https://api.github.com/repos/batfish/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/batfish/teams","hooks_url":"https://api.github.com/repos/batfish/batfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/batfish/events","assignees_url":"https://api.github.com/repos/batfish/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/batfish/tags","blobs_url":"https://api.github.com/repos/batfish/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/batfish/languages","stargazers_url":"https://api.github.com/repos/batfish/batfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/batfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/batfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/batfish/subscription","commits_url":"https://api.github.com/repos/batfish/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/batfish/merges","archive_url":"https://api.github.com/repos/batfish/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/batfish/downloads","issues_url":"https://api.github.com/repos/batfish/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/batfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/batfish/deployments","created_at":"2014-12-03T21:10:18Z","updated_at":"2017-07-12T13:22:35Z","pushed_at":"2017-08-17T22:39:35Z","git_url":"git://github.com/batfish/batfish.git","ssh_url":"git@github.com:batfish/batfish.git","clone_url":"https://github.com/batfish/batfish.git","svn_url":"https://github.com/batfish/batfish","homepage":"http://www.batfish.org","size":100717,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":44,"forks":21,"open_issues":44,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/batfish/batfish/pulls/341"},"html":{"href":"https://github.com/batfish/batfish/pull/341"},"issue":{"href":"https://api.github.com/repos/batfish/batfish/issues/341"},"comments":{"href":"https://api.github.com/repos/batfish/batfish/issues/341/comments"},"review_comments":{"href":"https://api.github.com/repos/batfish/batfish/pulls/341/comments"},"review_comment":{"href":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/batfish/batfish/pulls/341/commits"},"statuses":{"href":"https://api.github.com/repos/batfish/batfish/statuses/1bbb68c3343a43f429caa380e11d2ed7a76d8ef6"}}}}
|
{
"id": 27507850,
"name": "batfish/batfish",
"url": "https://api.github.com/repos/batfish/batfish"
}
|
{
"id": 26289653,
"login": "kidsbear",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26289653?",
"url": "https://api.github.com/users/kidsbear"
}
|
{
"id": 24584846,
"login": "batfish",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24584846?",
"url": "https://api.github.com/orgs/batfish"
}
| 2017-08-17T22:45:23 |
6476378541
|
{"actor":{"display_login":"kidsbear"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/biocore/horizomer/pulls/comments/120021825","pull_request_review_id":41951856,"id":120021825,"diff_hunk":"@@ -48,14 +45,11 @@ mkdir -p input\n mkdir -p output\n mkdir -p temp\n ln -s ${phylophlan_install_dir}/data\n-ln -s ${input_faa_dir} input/genomes\n+ln -s ${input_faa_dir} input/all\n \n # command\n-cmd=\"${phylophlan_install_dir}/phylophlan.py -u input --nproc $threads --c_dat temp\"\n-if [ \"$verbose\" == \"true\" ]\n-then\n- echo \"Command:\"$'\\n'\" $cmd\"\n-fi\n+cmd=\"${phylophlan_install_dir}/phylophlan.py -u all --nproc $threads --c_dat temp\"","path":"horizomer/benchmark/run_phylophlan.sh","position":53,"original_position":53,"commit_id":"c92914b4194de2c9b2cc2308879bab44a9acc390","original_commit_id":"c92914b4194de2c9b2cc2308879bab44a9acc390","user":{"login":"qiyunzhu","id":4396343,"avatar_url":"https://avatars2.githubusercontent.com/u/4396343?v=3","gravatar_id":"","url":"https://api.github.com/users/qiyunzhu","html_url":"https://github.com/qiyunzhu","followers_url":"https://api.github.com/users/qiyunzhu/followers","following_url":"https://api.github.com/users/qiyunzhu/following{/other_user}","gists_url":"https://api.github.com/users/qiyunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiyunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiyunzhu/subscriptions","organizations_url":"https://api.github.com/users/qiyunzhu/orgs","repos_url":"https://api.github.com/users/qiyunzhu/repos","events_url":"https://api.github.com/users/qiyunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/qiyunzhu/received_events","type":"User","site_admin":false},"body":"This is but a naming preference. Here `all` or `input` is to describe the job. It is totally arbitrary.","created_at":"2017-06-04T21:47:57Z","updated_at":"2017-06-04T21:47:57Z","html_url":"https://github.com/biocore/horizomer/pull/70#discussion_r120021825","pull_request_url":"https://api.github.com/repos/biocore/horizomer/pulls/70","_links":{"self":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/comments/120021825"},"html":{"href":"https://github.com/biocore/horizomer/pull/70#discussion_r120021825"},"pull_request":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/biocore/horizomer/pulls/70","id":123859065,"html_url":"https://github.com/biocore/horizomer/pull/70","diff_url":"https://github.com/biocore/horizomer/pull/70.diff","patch_url":"https://github.com/biocore/horizomer/pull/70.patch","issue_url":"https://api.github.com/repos/biocore/horizomer/issues/70","number":70,"state":"closed","locked":false,"title":"fixed bug for PhyloPhlAn wrapper","user":{"login":"qiyunzhu","id":4396343,"avatar_url":"https://avatars2.githubusercontent.com/u/4396343?v=3","gravatar_id":"","url":"https://api.github.com/users/qiyunzhu","html_url":"https://github.com/qiyunzhu","followers_url":"https://api.github.com/users/qiyunzhu/followers","following_url":"https://api.github.com/users/qiyunzhu/following{/other_user}","gists_url":"https://api.github.com/users/qiyunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiyunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiyunzhu/subscriptions","organizations_url":"https://api.github.com/users/qiyunzhu/orgs","repos_url":"https://api.github.com/users/qiyunzhu/repos","events_url":"https://api.github.com/users/qiyunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/qiyunzhu/received_events","type":"User","site_admin":false},"body":"Just a simple fix.","created_at":"2017-06-03T22:58:35Z","updated_at":"2017-06-04T21:47:57Z","closed_at":"2017-06-04T19:09:28Z","merged_at":"2017-06-04T19:09:28Z","merge_commit_sha":"cbbb1bee6fd5d35044298c144567766d7de7cefe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/biocore/horizomer/pulls/70/commits","review_comments_url":"https://api.github.com/repos/biocore/horizomer/pulls/70/comments","review_comment_url":"https://api.github.com/repos/biocore/horizomer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biocore/horizomer/issues/70/comments","statuses_url":"https://api.github.com/repos/biocore/horizomer/statuses/c92914b4194de2c9b2cc2308879bab44a9acc390","head":{"label":"qiyunzhu:bash","ref":"bash","sha":"c92914b4194de2c9b2cc2308879bab44a9acc390","user":{"login":"qiyunzhu","id":4396343,"avatar_url":"https://avatars2.githubusercontent.com/u/4396343?v=3","gravatar_id":"","url":"https://api.github.com/users/qiyunzhu","html_url":"https://github.com/qiyunzhu","followers_url":"https://api.github.com/users/qiyunzhu/followers","following_url":"https://api.github.com/users/qiyunzhu/following{/other_user}","gists_url":"https://api.github.com/users/qiyunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiyunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiyunzhu/subscriptions","organizations_url":"https://api.github.com/users/qiyunzhu/orgs","repos_url":"https://api.github.com/users/qiyunzhu/repos","events_url":"https://api.github.com/users/qiyunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/qiyunzhu/received_events","type":"User","site_admin":false},"repo":{"id":61073127,"name":"horizomer","full_name":"qiyunzhu/horizomer","owner":{"login":"qiyunzhu","id":4396343,"avatar_url":"https://avatars2.githubusercontent.com/u/4396343?v=3","gravatar_id":"","url":"https://api.github.com/users/qiyunzhu","html_url":"https://github.com/qiyunzhu","followers_url":"https://api.github.com/users/qiyunzhu/followers","following_url":"https://api.github.com/users/qiyunzhu/following{/other_user}","gists_url":"https://api.github.com/users/qiyunzhu/gists{/gist_id}","starred_url":"https://api.github.com/users/qiyunzhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiyunzhu/subscriptions","organizations_url":"https://api.github.com/users/qiyunzhu/orgs","repos_url":"https://api.github.com/users/qiyunzhu/repos","events_url":"https://api.github.com/users/qiyunzhu/events{/privacy}","received_events_url":"https://api.github.com/users/qiyunzhu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qiyunzhu/horizomer","description":"Workflow for detecting genome-wide horizontal gene transfers","fork":true,"url":"https://api.github.com/repos/qiyunzhu/horizomer","forks_url":"https://api.github.com/repos/qiyunzhu/horizomer/forks","keys_url":"https://api.github.com/repos/qiyunzhu/horizomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qiyunzhu/horizomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qiyunzhu/horizomer/teams","hooks_url":"https://api.github.com/repos/qiyunzhu/horizomer/hooks","issue_events_url":"https://api.github.com/repos/qiyunzhu/horizomer/issues/events{/number}","events_url":"https://api.github.com/repos/qiyunzhu/horizomer/events","assignees_url":"https://api.github.com/repos/qiyunzhu/horizomer/assignees{/user}","branches_url":"https://api.github.com/repos/qiyunzhu/horizomer/branches{/branch}","tags_url":"https://api.github.com/repos/qiyunzhu/horizomer/tags","blobs_url":"https://api.github.com/repos/qiyunzhu/horizomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qiyunzhu/horizomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qiyunzhu/horizomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/qiyunzhu/horizomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qiyunzhu/horizomer/statuses/{sha}","languages_url":"https://api.github.com/repos/qiyunzhu/horizomer/languages","stargazers_url":"https://api.github.com/repos/qiyunzhu/horizomer/stargazers","contributors_url":"https://api.github.com/repos/qiyunzhu/horizomer/contributors","subscribers_url":"https://api.github.com/repos/qiyunzhu/horizomer/subscribers","subscription_url":"https://api.github.com/repos/qiyunzhu/horizomer/subscription","commits_url":"https://api.github.com/repos/qiyunzhu/horizomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/qiyunzhu/horizomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/qiyunzhu/horizomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/qiyunzhu/horizomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/qiyunzhu/horizomer/contents/{+path}","compare_url":"https://api.github.com/repos/qiyunzhu/horizomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qiyunzhu/horizomer/merges","archive_url":"https://api.github.com/repos/qiyunzhu/horizomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qiyunzhu/horizomer/downloads","issues_url":"https://api.github.com/repos/qiyunzhu/horizomer/issues{/number}","pulls_url":"https://api.github.com/repos/qiyunzhu/horizomer/pulls{/number}","milestones_url":"https://api.github.com/repos/qiyunzhu/horizomer/milestones{/number}","notifications_url":"https://api.github.com/repos/qiyunzhu/horizomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qiyunzhu/horizomer/labels{/name}","releases_url":"https://api.github.com/repos/qiyunzhu/horizomer/releases{/id}","deployments_url":"https://api.github.com/repos/qiyunzhu/horizomer/deployments","created_at":"2016-06-13T22:11:20Z","updated_at":"2017-06-01T21:50:06Z","pushed_at":"2017-06-04T00:10:55Z","git_url":"git://github.com/qiyunzhu/horizomer.git","ssh_url":"git@github.com:qiyunzhu/horizomer.git","clone_url":"https://github.com/qiyunzhu/horizomer.git","svn_url":"https://github.com/qiyunzhu/horizomer","homepage":null,"size":1282,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"biocore:master","ref":"master","sha":"17a63a9e7efd57df660959875cca68776458d91b","user":{"login":"biocore","id":6241857,"avatar_url":"https://avatars0.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"repo":{"id":41323398,"name":"horizomer","full_name":"biocore/horizomer","owner":{"login":"biocore","id":6241857,"avatar_url":"https://avatars0.githubusercontent.com/u/6241857?v=3","gravatar_id":"","url":"https://api.github.com/users/biocore","html_url":"https://github.com/biocore","followers_url":"https://api.github.com/users/biocore/followers","following_url":"https://api.github.com/users/biocore/following{/other_user}","gists_url":"https://api.github.com/users/biocore/gists{/gist_id}","starred_url":"https://api.github.com/users/biocore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biocore/subscriptions","organizations_url":"https://api.github.com/users/biocore/orgs","repos_url":"https://api.github.com/users/biocore/repos","events_url":"https://api.github.com/users/biocore/events{/privacy}","received_events_url":"https://api.github.com/users/biocore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biocore/horizomer","description":"Workflow for detecting genome-wide horizontal gene transfers","fork":false,"url":"https://api.github.com/repos/biocore/horizomer","forks_url":"https://api.github.com/repos/biocore/horizomer/forks","keys_url":"https://api.github.com/repos/biocore/horizomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biocore/horizomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biocore/horizomer/teams","hooks_url":"https://api.github.com/repos/biocore/horizomer/hooks","issue_events_url":"https://api.github.com/repos/biocore/horizomer/issues/events{/number}","events_url":"https://api.github.com/repos/biocore/horizomer/events","assignees_url":"https://api.github.com/repos/biocore/horizomer/assignees{/user}","branches_url":"https://api.github.com/repos/biocore/horizomer/branches{/branch}","tags_url":"https://api.github.com/repos/biocore/horizomer/tags","blobs_url":"https://api.github.com/repos/biocore/horizomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biocore/horizomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biocore/horizomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/biocore/horizomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biocore/horizomer/statuses/{sha}","languages_url":"https://api.github.com/repos/biocore/horizomer/languages","stargazers_url":"https://api.github.com/repos/biocore/horizomer/stargazers","contributors_url":"https://api.github.com/repos/biocore/horizomer/contributors","subscribers_url":"https://api.github.com/repos/biocore/horizomer/subscribers","subscription_url":"https://api.github.com/repos/biocore/horizomer/subscription","commits_url":"https://api.github.com/repos/biocore/horizomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/biocore/horizomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/biocore/horizomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/biocore/horizomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/biocore/horizomer/contents/{+path}","compare_url":"https://api.github.com/repos/biocore/horizomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biocore/horizomer/merges","archive_url":"https://api.github.com/repos/biocore/horizomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biocore/horizomer/downloads","issues_url":"https://api.github.com/repos/biocore/horizomer/issues{/number}","pulls_url":"https://api.github.com/repos/biocore/horizomer/pulls{/number}","milestones_url":"https://api.github.com/repos/biocore/horizomer/milestones{/number}","notifications_url":"https://api.github.com/repos/biocore/horizomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biocore/horizomer/labels{/name}","releases_url":"https://api.github.com/repos/biocore/horizomer/releases{/id}","deployments_url":"https://api.github.com/repos/biocore/horizomer/deployments","created_at":"2015-08-24T19:43:04Z","updated_at":"2017-06-01T21:49:21Z","pushed_at":"2017-06-04T19:09:28Z","git_url":"git://github.com/biocore/horizomer.git","ssh_url":"git@github.com:biocore/horizomer.git","clone_url":"https://github.com/biocore/horizomer.git","svn_url":"https://github.com/biocore/horizomer","homepage":null,"size":1277,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":19,"forks":8,"open_issues":19,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/70"},"html":{"href":"https://github.com/biocore/horizomer/pull/70"},"issue":{"href":"https://api.github.com/repos/biocore/horizomer/issues/70"},"comments":{"href":"https://api.github.com/repos/biocore/horizomer/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biocore/horizomer/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/biocore/horizomer/statuses/c92914b4194de2c9b2cc2308879bab44a9acc390"}}}}
|
{
"id": 41323398,
"name": "biocore/horizomer",
"url": "https://api.github.com/repos/biocore/horizomer"
}
|
{
"id": 4396343,
"login": "qiyunzhu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4396343?",
"url": "https://api.github.com/users/qiyunzhu"
}
|
{
"id": 6241857,
"login": "biocore",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6241857?",
"url": "https://api.github.com/orgs/biocore"
}
| 2017-06-04T21:47:57 |
5999497867
|
{"actor":{"display_login":"qiyunzhu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/96304722","pull_request_review_id":16882670,"id":96304722,"diff_hunk":"@@ -2315,17 +2316,20 @@ UniValue getwalletinfo(const JSONRPCRequest& request)\n LOCK2(cs_main, pwalletMain->cs_wallet);\n \n UniValue obj(UniValue::VOBJ);\n+ size_t kpExternalSize = (int)pwalletMain->KeypoolCountExternalKeys();\n obj.push_back(Pair(\"walletversion\", pwalletMain->GetVersion()));\n obj.push_back(Pair(\"balance\", ValueFromAmount(pwalletMain->GetBalance())));\n obj.push_back(Pair(\"unconfirmed_balance\", ValueFromAmount(pwalletMain->GetUnconfirmedBalance())));\n obj.push_back(Pair(\"immature_balance\", ValueFromAmount(pwalletMain->GetImmatureBalance())));\n obj.push_back(Pair(\"txcount\", (int)pwalletMain->mapWallet.size()));\n obj.push_back(Pair(\"keypoololdest\", pwalletMain->GetOldestKeyPoolTime()));","path":"src/wallet/rpcwallet.cpp","position":56,"original_position":47,"commit_id":"e34676ef42e265ff883c39cc10d6c1b16f2c8331","original_commit_id":"12fcde55b79d90edffda62a6568c52a9adef8498","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars.githubusercontent.com/u/649246?v=3","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"Not doing this would break some uses of walletbackup, I think, so I wouldnt be too happy with this slipping into a different release.","created_at":"2017-01-16T21:05:20Z","updated_at":"2017-01-16T21:05:20Z","html_url":"https://github.com/bitcoin/bitcoin/pull/9294#discussion_r96304722","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/96304722"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/9294#discussion_r96304722"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294","id":96694316,"html_url":"https://github.com/bitcoin/bitcoin/pull/9294","diff_url":"https://github.com/bitcoin/bitcoin/pull/9294.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/9294.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9294","number":9294,"state":"open","locked":false,"title":"Use internal HD chain for change outputs (hd split)","user":{"login":"jonasschnelli","id":178464,"avatar_url":"https://avatars.githubusercontent.com/u/178464?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasschnelli","html_url":"https://github.com/jonasschnelli","followers_url":"https://api.github.com/users/jonasschnelli/followers","following_url":"https://api.github.com/users/jonasschnelli/following{/other_user}","gists_url":"https://api.github.com/users/jonasschnelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasschnelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasschnelli/subscriptions","organizations_url":"https://api.github.com/users/jonasschnelli/orgs","repos_url":"https://api.github.com/users/jonasschnelli/repos","events_url":"https://api.github.com/users/jonasschnelli/events{/privacy}","received_events_url":"https://api.github.com/users/jonasschnelli/received_events","type":"User","site_admin":false},"body":"#### Main changes\r\nThis pull request will result in using `m/0'/1'/k'` for internal keys (change outputs) while keeping `m/0'/0'/k'` for external keys (`getnewaddress`).\r\n\r\n* There is still a single keypool. All keypool elements (`CKeyPool`) have now a flag (`fInternal`).\r\n* ~~The keypool will be filled with 80% external keys (round ceil).~~\r\n* The keypool will be filled with 100% external keys + 20% (round ceil) internal keys.\r\n* `getwalletinfo` additionally reports `keypoolsize_hd_internal` (amount of internal key in the \r\n\r\n#### Compatibility:\r\n* This hd split change will only affect new wallets. Current 0.13 HD wallets will continue to only use the external chain.\r\n* Using a 0.14 wallet in <0.14 is not possible (hd chain split requires 0.14)\r\n* Using a 0.13 wallet in 0.14 will result in continue using only the external chain (only `m/0'/0'/k'`).\r\n\r\nThis change also fixes the keypool +1 offset.","created_at":"2016-12-06T10:08:19Z","updated_at":"2017-01-16T21:05:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57b1792002ae58dd36e0be92b67664babd1346e7","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/21","html_url":"https://github.com/bitcoin/bitcoin/milestone/21","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/21/labels","id":1823680,"number":21,"title":"0.14.0","description":"","creator":{"login":"MarcoFalke","id":6399679,"avatar_url":"https://avatars.githubusercontent.com/u/6399679?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcoFalke","html_url":"https://github.com/MarcoFalke","followers_url":"https://api.github.com/users/MarcoFalke/followers","following_url":"https://api.github.com/users/MarcoFalke/following{/other_user}","gists_url":"https://api.github.com/users/MarcoFalke/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcoFalke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcoFalke/subscriptions","organizations_url":"https://api.github.com/users/MarcoFalke/orgs","repos_url":"https://api.github.com/users/MarcoFalke/repos","events_url":"https://api.github.com/users/MarcoFalke/events{/privacy}","received_events_url":"https://api.github.com/users/MarcoFalke/received_events","type":"User","site_admin":false},"open_issues":21,"closed_issues":67,"state":"open","created_at":"2016-06-13T14:18:51Z","updated_at":"2017-01-16T18:33:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/9294/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/e34676ef42e265ff883c39cc10d6c1b16f2c8331","head":{"label":"jonasschnelli:2016/12/hd_split","ref":"2016/12/hd_split","sha":"e34676ef42e265ff883c39cc10d6c1b16f2c8331","user":{"login":"jonasschnelli","id":178464,"avatar_url":"https://avatars.githubusercontent.com/u/178464?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasschnelli","html_url":"https://github.com/jonasschnelli","followers_url":"https://api.github.com/users/jonasschnelli/followers","following_url":"https://api.github.com/users/jonasschnelli/following{/other_user}","gists_url":"https://api.github.com/users/jonasschnelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasschnelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasschnelli/subscriptions","organizations_url":"https://api.github.com/users/jonasschnelli/orgs","repos_url":"https://api.github.com/users/jonasschnelli/repos","events_url":"https://api.github.com/users/jonasschnelli/events{/privacy}","received_events_url":"https://api.github.com/users/jonasschnelli/received_events","type":"User","site_admin":false},"repo":{"id":9264454,"name":"bitcoin","full_name":"jonasschnelli/bitcoin","owner":{"login":"jonasschnelli","id":178464,"avatar_url":"https://avatars.githubusercontent.com/u/178464?v=3","gravatar_id":"","url":"https://api.github.com/users/jonasschnelli","html_url":"https://github.com/jonasschnelli","followers_url":"https://api.github.com/users/jonasschnelli/followers","following_url":"https://api.github.com/users/jonasschnelli/following{/other_user}","gists_url":"https://api.github.com/users/jonasschnelli/gists{/gist_id}","starred_url":"https://api.github.com/users/jonasschnelli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonasschnelli/subscriptions","organizations_url":"https://api.github.com/users/jonasschnelli/orgs","repos_url":"https://api.github.com/users/jonasschnelli/repos","events_url":"https://api.github.com/users/jonasschnelli/events{/privacy}","received_events_url":"https://api.github.com/users/jonasschnelli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonasschnelli/bitcoin","description":"CoreWallet development branch - A better full node wallet for bitcoin-core","fork":true,"url":"https://api.github.com/repos/jonasschnelli/bitcoin","forks_url":"https://api.github.com/repos/jonasschnelli/bitcoin/forks","keys_url":"https://api.github.com/repos/jonasschnelli/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonasschnelli/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonasschnelli/bitcoin/teams","hooks_url":"https://api.github.com/repos/jonasschnelli/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/jonasschnelli/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/jonasschnelli/bitcoin/events","assignees_url":"https://api.github.com/repos/jonasschnelli/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/jonasschnelli/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/jonasschnelli/bitcoin/tags","blobs_url":"https://api.github.com/repos/jonasschnelli/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonasschnelli/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonasschnelli/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonasschnelli/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonasschnelli/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/jonasschnelli/bitcoin/languages","stargazers_url":"https://api.github.com/repos/jonasschnelli/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/jonasschnelli/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/jonasschnelli/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/jonasschnelli/bitcoin/subscription","commits_url":"https://api.github.com/repos/jonasschnelli/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonasschnelli/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonasschnelli/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonasschnelli/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonasschnelli/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/jonasschnelli/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonasschnelli/bitcoin/merges","archive_url":"https://api.github.com/repos/jonasschnelli/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonasschnelli/bitcoin/downloads","issues_url":"https://api.github.com/repos/jonasschnelli/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/jonasschnelli/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/jonasschnelli/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/jonasschnelli/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonasschnelli/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/jonasschnelli/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/jonasschnelli/bitcoin/deployments","created_at":"2013-04-06T18:21:51Z","updated_at":"2016-01-11T12:21:57Z","pushed_at":"2017-01-16T10:11:38Z","git_url":"git://github.com/jonasschnelli/bitcoin.git","ssh_url":"git@github.com:jonasschnelli/bitcoin.git","clone_url":"https://github.com/jonasschnelli/bitcoin.git","svn_url":"https://github.com/jonasschnelli/bitcoin","homepage":"http://www.bitcoin.org","size":79077,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":3,"default_branch":"2015/05/corewallet"}},"base":{"label":"bitcoin:master","ref":"master","sha":"8a445c5651edb9a1f51497055b7ddf4402be9188","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-01-16T20:07:23Z","pushed_at":"2017-01-16T20:33:06Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":79241,"stargazers_count":11074,"watchers_count":11074,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":7229,"mirror_url":null,"open_issues_count":584,"forks":7229,"open_issues":584,"watchers":11074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/9294"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/9294"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/9294/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/9294/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/e34676ef42e265ff883c39cc10d6c1b16f2c8331"}}}}
|
{
"id": 1181927,
"name": "bitcoin/bitcoin",
"url": "https://api.github.com/repos/bitcoin/bitcoin"
}
|
{
"id": 649246,
"login": "TheBlueMatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/649246?",
"url": "https://api.github.com/users/TheBlueMatt"
}
|
{
"id": 528860,
"login": "bitcoin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/528860?",
"url": "https://api.github.com/orgs/bitcoin"
}
| 2017-01-16T21:05:20 |
5161644041
|
{"actor":{"display_login":"TheBlueMatt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/121542143","pull_request_review_id":43579929,"id":121542143,"diff_hunk":"@@ -171,44 +171,32 @@ baseline.info:\n \t$(LCOV) -c -i -d $(abs_builddir)/src -o $@\n \n baseline_filtered.info: baseline.info\n-\t$(abs_builddir)/contrib/filter-lcov.py \"/usr/include/\" $< $@\n+\t$(abs_builddir)/contrib/filter-lcov.py -p \"/usr/include/\" -p \"src/leveldb/\" -p \"src/bench/\" -p \"src/univalue\" -p \"src/crypto/ctaes\" -p \"src/secp256k1\" $< $@","path":"Makefile.am","position":null,"original_position":19,"commit_id":"786b4a138490378d265412a8c6141db7719c4754","original_commit_id":"786b4a138490378d265412a8c6141db7719c4754","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars2.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"body":"Perhaps abstract out the list of things to filter into a variable, as it's used more than once?","created_at":"2017-06-12T22:26:26Z","updated_at":"2017-06-12T22:26:26Z","html_url":"https://github.com/bitcoin/bitcoin/pull/10565#discussion_r121542143","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/121542143"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10565#discussion_r121542143"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565","id":124779106,"html_url":"https://github.com/bitcoin/bitcoin/pull/10565","diff_url":"https://github.com/bitcoin/bitcoin/pull/10565.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10565.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10565","number":10565,"state":"open","locked":false,"title":"[coverage] Remove subtrees and benchmarks from coverage report","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars0.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"body":"Removes stats about leveldb, univalue, and benchmark coverage from the coverage reports. Since we don't test these three items specifically and thus don't care about test coverage for these items.\r\n\r\nThis builds on top of #10511 to use the faster `lcov -r` replacement.","created_at":"2017-06-09T02:13:52Z","updated_at":"2017-06-12T22:26:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11176f80f38e3bc5f1eba23e25c43308b0ef5bb0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10565/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/786b4a138490378d265412a8c6141db7719c4754","head":{"label":"achow101:lcov-remove-extra","ref":"lcov-remove-extra","sha":"786b4a138490378d265412a8c6141db7719c4754","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars0.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"repo":{"id":45006379,"name":"bitcoin","full_name":"achow101/bitcoin","owner":{"login":"achow101","id":3782274,"avatar_url":"https://avatars0.githubusercontent.com/u/3782274?v=3","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achow101/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/achow101/bitcoin","forks_url":"https://api.github.com/repos/achow101/bitcoin/forks","keys_url":"https://api.github.com/repos/achow101/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achow101/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achow101/bitcoin/teams","hooks_url":"https://api.github.com/repos/achow101/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/achow101/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/achow101/bitcoin/events","assignees_url":"https://api.github.com/repos/achow101/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/achow101/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/achow101/bitcoin/tags","blobs_url":"https://api.github.com/repos/achow101/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achow101/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achow101/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/achow101/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achow101/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/achow101/bitcoin/languages","stargazers_url":"https://api.github.com/repos/achow101/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/achow101/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/achow101/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/achow101/bitcoin/subscription","commits_url":"https://api.github.com/repos/achow101/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/achow101/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/achow101/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/achow101/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/achow101/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/achow101/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achow101/bitcoin/merges","archive_url":"https://api.github.com/repos/achow101/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achow101/bitcoin/downloads","issues_url":"https://api.github.com/repos/achow101/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/achow101/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/achow101/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/achow101/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achow101/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/achow101/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/achow101/bitcoin/deployments","created_at":"2015-10-27T00:20:28Z","updated_at":"2016-10-27T14:10:02Z","pushed_at":"2017-06-12T22:20:22Z","git_url":"git://github.com/achow101/bitcoin.git","ssh_url":"git@github.com:achow101/bitcoin.git","clone_url":"https://github.com/achow101/bitcoin.git","svn_url":"https://github.com/achow101/bitcoin","homepage":"https://bitcoin.org/en/download","size":83187,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"29f80cd230c38d7e424810e986c160ddba9b53ac","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars1.githubusercontent.com/u/528860?v=3","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-06-12T20:54:32Z","pushed_at":"2017-06-12T22:18:03Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":83204,"stargazers_count":13354,"watchers_count":13354,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":8521,"mirror_url":null,"open_issues_count":686,"forks":8521,"open_issues":686,"watchers":13354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/10565"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10565"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/10565/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10565/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/786b4a138490378d265412a8c6141db7719c4754"}}}}
|
{
"id": 1181927,
"name": "bitcoin/bitcoin",
"url": "https://api.github.com/repos/bitcoin/bitcoin"
}
|
{
"id": 548488,
"login": "sipa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/548488?",
"url": "https://api.github.com/users/sipa"
}
|
{
"id": 528860,
"login": "bitcoin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/528860?",
"url": "https://api.github.com/orgs/bitcoin"
}
| 2017-06-12T22:26:26 |
6050982595
|
{"actor":{"display_login":"sipa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ca-cwds/CALS/pulls/comments/148081618","pull_request_review_id":73268225,"id":148081618,"diff_hunk":"@@ -4,25 +4,36 @@\n RSpec.feature 'Facilities', js: true do\n before(:each) do\n allow_any_instance_of(CalsBaseController).to receive(:authenticate_with_cwds).and_return(true)\n+ allow_any_instance_of(CalsBaseController).to receive(:get_session_token).and_return(ENV['TOKEN'])","path":"spec/features/show_facility_test_spec.rb","position":4,"original_position":4,"commit_id":"9c9ae8dc53c3c4c10b5de2be234346152b0041b7","original_commit_id":"7e115cca1bade5865b9e4680ae748c8a36d13542","user":{"login":"lauherkcambria","id":25331026,"avatar_url":"https://avatars2.githubusercontent.com/u/25331026?v=4","gravatar_id":"","url":"https://api.github.com/users/lauherkcambria","html_url":"https://github.com/lauherkcambria","followers_url":"https://api.github.com/users/lauherkcambria/followers","following_url":"https://api.github.com/users/lauherkcambria/following{/other_user}","gists_url":"https://api.github.com/users/lauherkcambria/gists{/gist_id}","starred_url":"https://api.github.com/users/lauherkcambria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauherkcambria/subscriptions","organizations_url":"https://api.github.com/users/lauherkcambria/orgs","repos_url":"https://api.github.com/users/lauherkcambria/repos","events_url":"https://api.github.com/users/lauherkcambria/events{/privacy}","received_events_url":"https://api.github.com/users/lauherkcambria/received_events","type":"User","site_admin":false},"body":"what about tests for rendering children and complaints? ","created_at":"2017-10-31T18:09:38Z","updated_at":"2017-10-31T18:09:45Z","html_url":"https://github.com/ca-cwds/CALS/pull/220#discussion_r148081618","pull_request_url":"https://api.github.com/repos/ca-cwds/CALS/pulls/220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/comments/148081618"},"html":{"href":"https://github.com/ca-cwds/CALS/pull/220#discussion_r148081618"},"pull_request":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/ca-cwds/CALS/pulls/220","id":149250934,"html_url":"https://github.com/ca-cwds/CALS/pull/220","diff_url":"https://github.com/ca-cwds/CALS/pull/220.diff","patch_url":"https://github.com/ca-cwds/CALS/pull/220.patch","issue_url":"https://api.github.com/repos/ca-cwds/CALS/issues/220","number":220,"state":"open","locked":false,"title":"Facility profile update","user":{"login":"Nasir2712","id":8887704,"avatar_url":"https://avatars1.githubusercontent.com/u/8887704?v=4","gravatar_id":"","url":"https://api.github.com/users/Nasir2712","html_url":"https://github.com/Nasir2712","followers_url":"https://api.github.com/users/Nasir2712/followers","following_url":"https://api.github.com/users/Nasir2712/following{/other_user}","gists_url":"https://api.github.com/users/Nasir2712/gists{/gist_id}","starred_url":"https://api.github.com/users/Nasir2712/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nasir2712/subscriptions","organizations_url":"https://api.github.com/users/Nasir2712/orgs","repos_url":"https://api.github.com/users/Nasir2712/repos","events_url":"https://api.github.com/users/Nasir2712/events{/privacy}","received_events_url":"https://api.github.com/users/Nasir2712/received_events","type":"User","site_admin":false},"body":"#### What tests were added (if relevant), and do all tests (rspec, karma, and integration CALS tests) pass?\r\n- rspec tests were modified \r\n\r\n#### Which User story does this relate to?\r\n- https://www.pivotaltracker.com/n/projects/1662141/stories/147303887\r\n\r\n#### Brief feature description\r\n- able to see children, complaints for the selected facility\r\n\r\n#### Does this PR block/effect other stories?\r\n- no\r\n\r\n#### Do any commands needs to be run in order to run the project with this PR?\r\n- N/A\r\n\r\n#### Code coverage percent diff as a result of this PR?\r\n- 66.54%\r\n\r\n#### JS errors diff as a result of this PR?\r\n- 13\r\n","created_at":"2017-10-27T18:02:07Z","updated_at":"2017-10-31T18:09:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bd0da0e8d474db4dbbe8805ad506c2c3e97917f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lavanyareddyreddy","id":15152893,"avatar_url":"https://avatars2.githubusercontent.com/u/15152893?v=4","gravatar_id":"","url":"https://api.github.com/users/lavanyareddyreddy","html_url":"https://github.com/lavanyareddyreddy","followers_url":"https://api.github.com/users/lavanyareddyreddy/followers","following_url":"https://api.github.com/users/lavanyareddyreddy/following{/other_user}","gists_url":"https://api.github.com/users/lavanyareddyreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/lavanyareddyreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavanyareddyreddy/subscriptions","organizations_url":"https://api.github.com/users/lavanyareddyreddy/orgs","repos_url":"https://api.github.com/users/lavanyareddyreddy/repos","events_url":"https://api.github.com/users/lavanyareddyreddy/events{/privacy}","received_events_url":"https://api.github.com/users/lavanyareddyreddy/received_events","type":"User","site_admin":false},{"login":"anuroop15","id":21377582,"avatar_url":"https://avatars2.githubusercontent.com/u/21377582?v=4","gravatar_id":"","url":"https://api.github.com/users/anuroop15","html_url":"https://github.com/anuroop15","followers_url":"https://api.github.com/users/anuroop15/followers","following_url":"https://api.github.com/users/anuroop15/following{/other_user}","gists_url":"https://api.github.com/users/anuroop15/gists{/gist_id}","starred_url":"https://api.github.com/users/anuroop15/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuroop15/subscriptions","organizations_url":"https://api.github.com/users/anuroop15/orgs","repos_url":"https://api.github.com/users/anuroop15/repos","events_url":"https://api.github.com/users/anuroop15/events{/privacy}","received_events_url":"https://api.github.com/users/anuroop15/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ca-cwds/CALS/pulls/220/commits","review_comments_url":"https://api.github.com/repos/ca-cwds/CALS/pulls/220/comments","review_comment_url":"https://api.github.com/repos/ca-cwds/CALS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ca-cwds/CALS/issues/220/comments","statuses_url":"https://api.github.com/repos/ca-cwds/CALS/statuses/9c9ae8dc53c3c4c10b5de2be234346152b0041b7","head":{"label":"ca-cwds:facility_profile_update","ref":"facility_profile_update","sha":"9c9ae8dc53c3c4c10b5de2be234346152b0041b7","user":{"login":"ca-cwds","id":16274270,"avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":85239919,"name":"CALS","full_name":"ca-cwds/CALS","owner":{"login":"ca-cwds","id":16274270,"avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ca-cwds/CALS","description":null,"fork":false,"url":"https://api.github.com/repos/ca-cwds/CALS","forks_url":"https://api.github.com/repos/ca-cwds/CALS/forks","keys_url":"https://api.github.com/repos/ca-cwds/CALS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/CALS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/CALS/teams","hooks_url":"https://api.github.com/repos/ca-cwds/CALS/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/CALS/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/CALS/events","assignees_url":"https://api.github.com/repos/ca-cwds/CALS/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/CALS/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/CALS/tags","blobs_url":"https://api.github.com/repos/ca-cwds/CALS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/CALS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/CALS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/CALS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/CALS/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/CALS/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/CALS/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/CALS/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/CALS/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/CALS/subscription","commits_url":"https://api.github.com/repos/ca-cwds/CALS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/CALS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/CALS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/CALS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/CALS/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/CALS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/CALS/merges","archive_url":"https://api.github.com/repos/ca-cwds/CALS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/CALS/downloads","issues_url":"https://api.github.com/repos/ca-cwds/CALS/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/CALS/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/CALS/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/CALS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/CALS/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/CALS/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/CALS/deployments","created_at":"2017-03-16T20:43:57Z","updated_at":"2017-09-13T21:20:33Z","pushed_at":"2017-10-31T18:00:03Z","git_url":"git://github.com/ca-cwds/CALS.git","ssh_url":"git@github.com:ca-cwds/CALS.git","clone_url":"https://github.com/ca-cwds/CALS.git","svn_url":"https://github.com/ca-cwds/CALS","homepage":null,"size":30721,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":1,"default_branch":"development"}},"base":{"label":"ca-cwds:development","ref":"development","sha":"32665169497116d807ec5c3bc16800e5735d31d1","user":{"login":"ca-cwds","id":16274270,"avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":85239919,"name":"CALS","full_name":"ca-cwds/CALS","owner":{"login":"ca-cwds","id":16274270,"avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ca-cwds/CALS","description":null,"fork":false,"url":"https://api.github.com/repos/ca-cwds/CALS","forks_url":"https://api.github.com/repos/ca-cwds/CALS/forks","keys_url":"https://api.github.com/repos/ca-cwds/CALS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/CALS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/CALS/teams","hooks_url":"https://api.github.com/repos/ca-cwds/CALS/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/CALS/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/CALS/events","assignees_url":"https://api.github.com/repos/ca-cwds/CALS/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/CALS/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/CALS/tags","blobs_url":"https://api.github.com/repos/ca-cwds/CALS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/CALS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/CALS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/CALS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/CALS/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/CALS/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/CALS/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/CALS/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/CALS/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/CALS/subscription","commits_url":"https://api.github.com/repos/ca-cwds/CALS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/CALS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/CALS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/CALS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/CALS/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/CALS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/CALS/merges","archive_url":"https://api.github.com/repos/ca-cwds/CALS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/CALS/downloads","issues_url":"https://api.github.com/repos/ca-cwds/CALS/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/CALS/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/CALS/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/CALS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/CALS/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/CALS/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/CALS/deployments","created_at":"2017-03-16T20:43:57Z","updated_at":"2017-09-13T21:20:33Z","pushed_at":"2017-10-31T18:00:03Z","git_url":"git://github.com/ca-cwds/CALS.git","ssh_url":"git@github.com:ca-cwds/CALS.git","clone_url":"https://github.com/ca-cwds/CALS.git","svn_url":"https://github.com/ca-cwds/CALS","homepage":null,"size":30721,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/220"},"html":{"href":"https://github.com/ca-cwds/CALS/pull/220"},"issue":{"href":"https://api.github.com/repos/ca-cwds/CALS/issues/220"},"comments":{"href":"https://api.github.com/repos/ca-cwds/CALS/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ca-cwds/CALS/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/ca-cwds/CALS/statuses/9c9ae8dc53c3c4c10b5de2be234346152b0041b7"}},"author_association":"COLLABORATOR"}}
|
{
"id": 85239919,
"name": "ca-cwds/CALS",
"url": "https://api.github.com/repos/ca-cwds/CALS"
}
|
{
"id": 25331026,
"login": "lauherkcambria",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25331026?",
"url": "https://api.github.com/users/lauherkcambria"
}
|
{
"id": 16274270,
"login": "ca-cwds",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16274270?",
"url": "https://api.github.com/orgs/ca-cwds"
}
| 2017-10-31T18:09:38 |
6791008951
|
{"actor":{"display_login":"lauherkcambria"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chainer/chainer/pulls/comments/136744078","pull_request_review_id":60323806,"id":136744078,"diff_hunk":"@@ -148,6 +148,14 @@ def evaluate(self):\n \n Users can override this method to customize the evaluation routine.\n \n+ .. note::\n+\n+ This method encloses :meth:`eval_func` calls with\n+ `with function.no_backprop_mode()` context. So, all calculations","path":"chainer/training/extensions/evaluator.py","position":7,"original_position":7,"commit_id":"6751975c713e8d03b6526740bd61fb8ffdacf5b6","original_commit_id":"6751975c713e8d03b6526740bd61fb8ffdacf5b6","user":{"login":"niboshi","id":635436,"avatar_url":"https://avatars0.githubusercontent.com/u/635436?v=4","gravatar_id":"","url":"https://api.github.com/users/niboshi","html_url":"https://github.com/niboshi","followers_url":"https://api.github.com/users/niboshi/followers","following_url":"https://api.github.com/users/niboshi/following{/other_user}","gists_url":"https://api.github.com/users/niboshi/gists{/gist_id}","starred_url":"https://api.github.com/users/niboshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niboshi/subscriptions","organizations_url":"https://api.github.com/users/niboshi/orgs","repos_url":"https://api.github.com/users/niboshi/repos","events_url":"https://api.github.com/users/niboshi/events{/privacy}","received_events_url":"https://api.github.com/users/niboshi/received_events","type":"User","site_admin":false},"body":"It's not linked. How about\r\n``` `with function.no_backprop_mode()` context.```\r\n->\r\n```:func:`chainer.no_backprop_mode` context.```","created_at":"2017-09-04T04:58:55Z","updated_at":"2017-09-04T05:01:57Z","html_url":"https://github.com/chainer/chainer/pull/3203#discussion_r136744078","pull_request_url":"https://api.github.com/repos/chainer/chainer/pulls/3203","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments/136744078"},"html":{"href":"https://github.com/chainer/chainer/pull/3203#discussion_r136744078"},"pull_request":{"href":"https://api.github.com/repos/chainer/chainer/pulls/3203"}}},"pull_request":{"url":"https://api.github.com/repos/chainer/chainer/pulls/3203","id":136727611,"html_url":"https://github.com/chainer/chainer/pull/3203","diff_url":"https://github.com/chainer/chainer/pull/3203.diff","patch_url":"https://github.com/chainer/chainer/pull/3203.patch","issue_url":"https://api.github.com/repos/chainer/chainer/issues/3203","number":3203,"state":"open","locked":false,"title":"Add a note to the doc of Evaluator.evaluate","user":{"login":"mitmul","id":666535,"avatar_url":"https://avatars0.githubusercontent.com/u/666535?v=4","gravatar_id":"","url":"https://api.github.com/users/mitmul","html_url":"https://github.com/mitmul","followers_url":"https://api.github.com/users/mitmul/followers","following_url":"https://api.github.com/users/mitmul/following{/other_user}","gists_url":"https://api.github.com/users/mitmul/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmul/subscriptions","organizations_url":"https://api.github.com/users/mitmul/orgs","repos_url":"https://api.github.com/users/mitmul/repos","events_url":"https://api.github.com/users/mitmul/events{/privacy}","received_events_url":"https://api.github.com/users/mitmul/received_events","type":"User","site_admin":false},"body":"In Chainer, \"no backprop\" and \"evaluation\" are orthogonal concept, but chainer.training.extensions.Evaluator.evaluate calls `chainer.no_backprop_mode()` before executing `eval_func`. It should be explicitly explained in the document.","created_at":"2017-08-21T10:28:27Z","updated_at":"2017-09-04T05:01:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"683321b97b8e2e60a5a6b537af732e7deab227b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/chainer/chainer/milestones/50","html_url":"https://github.com/chainer/chainer/milestone/50","labels_url":"https://api.github.com/repos/chainer/chainer/milestones/50/labels","id":2673153,"number":50,"title":"v3.0.0rc1","description":"","creator":{"login":"mitmul","id":666535,"avatar_url":"https://avatars0.githubusercontent.com/u/666535?v=4","gravatar_id":"","url":"https://api.github.com/users/mitmul","html_url":"https://github.com/mitmul","followers_url":"https://api.github.com/users/mitmul/followers","following_url":"https://api.github.com/users/mitmul/following{/other_user}","gists_url":"https://api.github.com/users/mitmul/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmul/subscriptions","organizations_url":"https://api.github.com/users/mitmul/orgs","repos_url":"https://api.github.com/users/mitmul/repos","events_url":"https://api.github.com/users/mitmul/events{/privacy}","received_events_url":"https://api.github.com/users/mitmul/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":83,"state":"open","created_at":"2017-08-01T07:32:16Z","updated_at":"2017-09-04T04:30:45Z","due_on":"2017-08-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/chainer/chainer/pulls/3203/commits","review_comments_url":"https://api.github.com/repos/chainer/chainer/pulls/3203/comments","review_comment_url":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chainer/chainer/issues/3203/comments","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/6751975c713e8d03b6526740bd61fb8ffdacf5b6","head":{"label":"mitmul:improve-evaluator-doc","ref":"improve-evaluator-doc","sha":"6751975c713e8d03b6526740bd61fb8ffdacf5b6","user":{"login":"mitmul","id":666535,"avatar_url":"https://avatars0.githubusercontent.com/u/666535?v=4","gravatar_id":"","url":"https://api.github.com/users/mitmul","html_url":"https://github.com/mitmul","followers_url":"https://api.github.com/users/mitmul/followers","following_url":"https://api.github.com/users/mitmul/following{/other_user}","gists_url":"https://api.github.com/users/mitmul/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmul/subscriptions","organizations_url":"https://api.github.com/users/mitmul/orgs","repos_url":"https://api.github.com/users/mitmul/repos","events_url":"https://api.github.com/users/mitmul/events{/privacy}","received_events_url":"https://api.github.com/users/mitmul/received_events","type":"User","site_admin":false},"repo":{"id":37115816,"name":"chainer","full_name":"mitmul/chainer","owner":{"login":"mitmul","id":666535,"avatar_url":"https://avatars0.githubusercontent.com/u/666535?v=4","gravatar_id":"","url":"https://api.github.com/users/mitmul","html_url":"https://github.com/mitmul","followers_url":"https://api.github.com/users/mitmul/followers","following_url":"https://api.github.com/users/mitmul/following{/other_user}","gists_url":"https://api.github.com/users/mitmul/gists{/gist_id}","starred_url":"https://api.github.com/users/mitmul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitmul/subscriptions","organizations_url":"https://api.github.com/users/mitmul/orgs","repos_url":"https://api.github.com/users/mitmul/repos","events_url":"https://api.github.com/users/mitmul/events{/privacy}","received_events_url":"https://api.github.com/users/mitmul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitmul/chainer","description":"A flexible framework of neural networks","fork":true,"url":"https://api.github.com/repos/mitmul/chainer","forks_url":"https://api.github.com/repos/mitmul/chainer/forks","keys_url":"https://api.github.com/repos/mitmul/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitmul/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitmul/chainer/teams","hooks_url":"https://api.github.com/repos/mitmul/chainer/hooks","issue_events_url":"https://api.github.com/repos/mitmul/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/mitmul/chainer/events","assignees_url":"https://api.github.com/repos/mitmul/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/mitmul/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/mitmul/chainer/tags","blobs_url":"https://api.github.com/repos/mitmul/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitmul/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitmul/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitmul/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitmul/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/mitmul/chainer/languages","stargazers_url":"https://api.github.com/repos/mitmul/chainer/stargazers","contributors_url":"https://api.github.com/repos/mitmul/chainer/contributors","subscribers_url":"https://api.github.com/repos/mitmul/chainer/subscribers","subscription_url":"https://api.github.com/repos/mitmul/chainer/subscription","commits_url":"https://api.github.com/repos/mitmul/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitmul/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitmul/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitmul/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitmul/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/mitmul/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitmul/chainer/merges","archive_url":"https://api.github.com/repos/mitmul/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitmul/chainer/downloads","issues_url":"https://api.github.com/repos/mitmul/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/mitmul/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/mitmul/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/mitmul/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitmul/chainer/labels{/name}","releases_url":"https://api.github.com/repos/mitmul/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/mitmul/chainer/deployments","created_at":"2015-06-09T06:59:10Z","updated_at":"2017-06-01T06:07:46Z","pushed_at":"2017-09-04T04:46:31Z","git_url":"git://github.com/mitmul/chainer.git","ssh_url":"git@github.com:mitmul/chainer.git","clone_url":"https://github.com/mitmul/chainer.git","svn_url":"https://github.com/mitmul/chainer","homepage":"http://chainer.org","size":21255,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"nccl-multiprocess-updater"}},"base":{"label":"chainer:master","ref":"master","sha":"0d0d2df6f4f181a42a318ebce2d12b7158f6957f","user":{"login":"chainer","id":23183003,"avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"repo":{"id":36914478,"name":"chainer","full_name":"chainer/chainer","owner":{"login":"chainer","id":23183003,"avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chainer/chainer","description":"A flexible framework of neural networks for deep learning","fork":false,"url":"https://api.github.com/repos/chainer/chainer","forks_url":"https://api.github.com/repos/chainer/chainer/forks","keys_url":"https://api.github.com/repos/chainer/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chainer/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chainer/chainer/teams","hooks_url":"https://api.github.com/repos/chainer/chainer/hooks","issue_events_url":"https://api.github.com/repos/chainer/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/chainer/chainer/events","assignees_url":"https://api.github.com/repos/chainer/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/chainer/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/chainer/chainer/tags","blobs_url":"https://api.github.com/repos/chainer/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chainer/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chainer/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/chainer/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/chainer/chainer/languages","stargazers_url":"https://api.github.com/repos/chainer/chainer/stargazers","contributors_url":"https://api.github.com/repos/chainer/chainer/contributors","subscribers_url":"https://api.github.com/repos/chainer/chainer/subscribers","subscription_url":"https://api.github.com/repos/chainer/chainer/subscription","commits_url":"https://api.github.com/repos/chainer/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/chainer/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/chainer/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/chainer/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/chainer/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/chainer/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chainer/chainer/merges","archive_url":"https://api.github.com/repos/chainer/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chainer/chainer/downloads","issues_url":"https://api.github.com/repos/chainer/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/chainer/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/chainer/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/chainer/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chainer/chainer/labels{/name}","releases_url":"https://api.github.com/repos/chainer/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/chainer/chainer/deployments","created_at":"2015-06-05T05:50:37Z","updated_at":"2017-09-04T04:14:13Z","pushed_at":"2017-09-04T04:46:33Z","git_url":"git://github.com/chainer/chainer.git","ssh_url":"git@github.com:chainer/chainer.git","clone_url":"https://github.com/chainer/chainer.git","svn_url":"https://github.com/chainer/chainer","homepage":"https://chainer.org","size":17208,"stargazers_count":2882,"watchers_count":2882,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":758,"mirror_url":null,"open_issues_count":440,"forks":758,"open_issues":440,"watchers":2882,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/3203"},"html":{"href":"https://github.com/chainer/chainer/pull/3203"},"issue":{"href":"https://api.github.com/repos/chainer/chainer/issues/3203"},"comments":{"href":"https://api.github.com/repos/chainer/chainer/issues/3203/comments"},"review_comments":{"href":"https://api.github.com/repos/chainer/chainer/pulls/3203/comments"},"review_comment":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chainer/chainer/pulls/3203/commits"},"statuses":{"href":"https://api.github.com/repos/chainer/chainer/statuses/6751975c713e8d03b6526740bd61fb8ffdacf5b6"}},"author_association":"OWNER"}}
|
{
"id": 36914478,
"name": "chainer/chainer",
"url": "https://api.github.com/repos/chainer/chainer"
}
|
{
"id": 635436,
"login": "niboshi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/635436?",
"url": "https://api.github.com/users/niboshi"
}
|
{
"id": 23183003,
"login": "chainer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23183003?",
"url": "https://api.github.com/orgs/chainer"
}
| 2017-09-04T04:58:55 |
6545449478
|
{"actor":{"display_login":"niboshi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/comments/102417139","pull_request_review_id":23170358,"id":102417139,"diff_hunk":"@@ -278,7 +277,7 @@ define([\n leave_request_id: leaveRequestID,\n text: comment.text,\n contact_id: comment.contact_id,\n- created_at: moment(comment.created_at, sharedSettings.serverDateFormat).format(sharedSettings.serverDateTimeFormat)\n+ created_at: comment.created_at","path":"uk.co.compucorp.civicrm.hrleaveandabsences/js/angular/src/leave-absences/shared/apis/leave-request-api.js","position":null,"original_position":21,"commit_id":"44cf1faeb0286d326c282ca0e105db7b7518e6f8","original_commit_id":"44cf1faeb0286d326c282ca0e105db7b7518e6f8","user":{"login":"deb1990","id":5058867,"avatar_url":"https://avatars.githubusercontent.com/u/5058867?v=3","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"> We would create the time in proper format when the comment is generated from UI, so changed the logic . Thanks for pointing it out.\r\n\r\nIt will be done when user comments.","created_at":"2017-02-22T09:32:50Z","updated_at":"2017-02-22T09:32:50Z","html_url":"https://github.com/civicrm/civihr/pull/1498#discussion_r102417139","pull_request_url":"https://api.github.com/repos/civicrm/civihr/pulls/1498","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments/102417139"},"html":{"href":"https://github.com/civicrm/civihr/pull/1498#discussion_r102417139"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1498"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civihr/pulls/1498","id":107346900,"html_url":"https://github.com/civicrm/civihr/pull/1498","diff_url":"https://github.com/civicrm/civihr/pull/1498.diff","patch_url":"https://github.com/civicrm/civihr/pull/1498.patch","issue_url":"https://api.github.com/repos/civicrm/civihr/issues/1498","number":1498,"state":"open","locked":false,"title":"PCHR-1422: Comment amended to Leave Request Instance","user":{"login":"deb1990","id":5058867,"avatar_url":"https://avatars.githubusercontent.com/u/5058867?v=3","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"As part of this PR comments support has been added to `LeaveRequestInstance`","created_at":"2017-02-22T07:03:20Z","updated_at":"2017-02-22T09:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01fee2b0b33f4664ad76c470e3e80deb018ad2ed","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civihr/pulls/1498/commits","review_comments_url":"https://api.github.com/repos/civicrm/civihr/pulls/1498/comments","review_comment_url":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civihr/issues/1498/comments","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/44cf1faeb0286d326c282ca0e105db7b7518e6f8","head":{"label":"civicrm:PCHR-1422-comment-leave-request-instance","ref":"PCHR-1422-comment-leave-request-instance","sha":"44cf1faeb0286d326c282ca0e105db7b7518e6f8","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-01-22T10:49:09Z","pushed_at":"2017-02-22T09:05:33Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":41043,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":35,"forks":30,"open_issues":35,"watchers":7,"default_branch":"staging"}},"base":{"label":"civicrm:la-milestone-3","ref":"la-milestone-3","sha":"c4c6d01eeed4a8020d14eb9fe549001191598eee","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":10086903,"name":"civihr","full_name":"civicrm/civihr","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civihr","description":"CiviHR","fork":false,"url":"https://api.github.com/repos/civicrm/civihr","forks_url":"https://api.github.com/repos/civicrm/civihr/forks","keys_url":"https://api.github.com/repos/civicrm/civihr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civihr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civihr/teams","hooks_url":"https://api.github.com/repos/civicrm/civihr/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civihr/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civihr/events","assignees_url":"https://api.github.com/repos/civicrm/civihr/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civihr/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civihr/tags","blobs_url":"https://api.github.com/repos/civicrm/civihr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civihr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civihr/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civihr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civihr/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civihr/languages","stargazers_url":"https://api.github.com/repos/civicrm/civihr/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civihr/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civihr/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civihr/subscription","commits_url":"https://api.github.com/repos/civicrm/civihr/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civihr/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civihr/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civihr/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civihr/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civihr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civihr/merges","archive_url":"https://api.github.com/repos/civicrm/civihr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civihr/downloads","issues_url":"https://api.github.com/repos/civicrm/civihr/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civihr/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civihr/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civihr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civihr/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civihr/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civihr/deployments","created_at":"2013-05-15T20:06:06Z","updated_at":"2017-01-22T10:49:09Z","pushed_at":"2017-02-22T09:05:33Z","git_url":"git://github.com/civicrm/civihr.git","ssh_url":"git@github.com:civicrm/civihr.git","clone_url":"https://github.com/civicrm/civihr.git","svn_url":"https://github.com/civicrm/civihr","homepage":null,"size":41043,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":35,"forks":30,"open_issues":35,"watchers":7,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1498"},"html":{"href":"https://github.com/civicrm/civihr/pull/1498"},"issue":{"href":"https://api.github.com/repos/civicrm/civihr/issues/1498"},"comments":{"href":"https://api.github.com/repos/civicrm/civihr/issues/1498/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1498/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civihr/pulls/1498/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civihr/statuses/44cf1faeb0286d326c282ca0e105db7b7518e6f8"}}}}
|
{
"id": 10086903,
"name": "civicrm/civihr",
"url": "https://api.github.com/repos/civicrm/civihr"
}
|
{
"id": 5058867,
"login": "deb1990",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5058867?",
"url": "https://api.github.com/users/deb1990"
}
|
{
"id": 136373,
"login": "civicrm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/136373?",
"url": "https://api.github.com/orgs/civicrm"
}
| 2017-02-22T09:32:50 |
5368684784
|
{"actor":{"display_login":"deb1990"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/118823511","pull_request_review_id":40655765,"id":118823511,"diff_hunk":"@@ -5669,4 +5674,79 @@ public static function replaceContributionTokens(\n return $contributionDetails;\n }\n \n+ /**\n+ * Record adjusted amount.\n+ *\n+ * @param int $updatedAmount\n+ * @param int $paidAmount\n+ * @param int $contributionId\n+ *\n+ * @param int $taxAmount\n+ * @param bool $updateAmountLevel\n+ *\n+ * @return bool|\\CRM_Core_BAO_FinancialTrxn\n+ */\n+ public static function recordAdjustedAmt($updatedAmount, $paidAmount, $contributionId, $taxAmount = NULL, $updateAmountLevel = NULL) {","path":"CRM/Contribute/BAO/Contribution.php","position":28,"original_position":28,"commit_id":"614a435d02fb7d58a85cd1216f226a8ac05edf2d","original_commit_id":"614a435d02fb7d58a85cd1216f226a8ac05edf2d","user":{"login":"monishdeb","id":3735621,"avatar_url":"https://avatars0.githubusercontent.com/u/3735621?v=3","gravatar_id":"","url":"https://api.github.com/users/monishdeb","html_url":"https://github.com/monishdeb","followers_url":"https://api.github.com/users/monishdeb/followers","following_url":"https://api.github.com/users/monishdeb/following{/other_user}","gists_url":"https://api.github.com/users/monishdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/monishdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monishdeb/subscriptions","organizations_url":"https://api.github.com/users/monishdeb/orgs","repos_url":"https://api.github.com/users/monishdeb/repos","events_url":"https://api.github.com/users/monishdeb/events{/privacy}","received_events_url":"https://api.github.com/users/monishdeb/received_events","type":"User","site_admin":false},"body":"@JoeMurray actually I have only moved the ```CRM_Event_BAO_Participant::recordAdjustAmt(..)``` to this class. The function body isn't changed at all which is used to record financial trxn on the adjustment made upon event's fee change and now membership type change too, via backoffice form. Also ensured that the correct tax amount is recorded in DB.In fact. Change in the price of related line item(s) is handled in another BAO function ```changeFeeSelction(..)``` where this fn is called, please check below in LineItem BAO file. \r\n\r\n I am afraid I cannot change the accessibility of this function since it's been called by LineItem BAO function [here](https://github.com/civicrm/civicrm-core/pull/10370/files#diff-e57ed384488b5985e5a0a5c166a6b0f0R816) ","created_at":"2017-05-27T16:01:00Z","updated_at":"2017-05-27T16:01:00Z","html_url":"https://github.com/civicrm/civicrm-core/pull/10370#discussion_r118823511","pull_request_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370","_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments/118823511"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/10370#discussion_r118823511"},"pull_request":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370"}}},"pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370","id":121053314,"html_url":"https://github.com/civicrm/civicrm-core/pull/10370","diff_url":"https://github.com/civicrm/civicrm-core/pull/10370.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/10370.patch","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10370","number":10370,"state":"open","locked":false,"title":"CRM-20321: Changing membership type should change related contribution","user":{"login":"monishdeb","id":3735621,"avatar_url":"https://avatars0.githubusercontent.com/u/3735621?v=3","gravatar_id":"","url":"https://api.github.com/users/monishdeb","html_url":"https://github.com/monishdeb","followers_url":"https://api.github.com/users/monishdeb/followers","following_url":"https://api.github.com/users/monishdeb/following{/other_user}","gists_url":"https://api.github.com/users/monishdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/monishdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monishdeb/subscriptions","organizations_url":"https://api.github.com/users/monishdeb/orgs","repos_url":"https://api.github.com/users/monishdeb/repos","events_url":"https://api.github.com/users/monishdeb/events{/privacy}","received_events_url":"https://api.github.com/users/monishdeb/received_events","type":"User","site_admin":false},"body":"* [CRM-20321: Changing membership type should change related contribution](https://issues.civicrm.org/jira/browse/CRM-20321)","created_at":"2017-05-17T13:10:37Z","updated_at":"2017-05-27T16:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0587b3eda528f3822dc8fb089cb3b715f33f422","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370/commits","review_comments_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370/comments","review_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10370/comments","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/614a435d02fb7d58a85cd1216f226a8ac05edf2d","head":{"label":"JMAConsulting:CRM-20321","ref":"CRM-20321","sha":"614a435d02fb7d58a85cd1216f226a8ac05edf2d","user":{"login":"JMAConsulting","id":2036425,"avatar_url":"https://avatars3.githubusercontent.com/u/2036425?v=3","gravatar_id":"","url":"https://api.github.com/users/JMAConsulting","html_url":"https://github.com/JMAConsulting","followers_url":"https://api.github.com/users/JMAConsulting/followers","following_url":"https://api.github.com/users/JMAConsulting/following{/other_user}","gists_url":"https://api.github.com/users/JMAConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/JMAConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMAConsulting/subscriptions","organizations_url":"https://api.github.com/users/JMAConsulting/orgs","repos_url":"https://api.github.com/users/JMAConsulting/repos","events_url":"https://api.github.com/users/JMAConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/JMAConsulting/received_events","type":"Organization","site_admin":false},"repo":{"id":16546304,"name":"civicrm-core","full_name":"JMAConsulting/civicrm-core","owner":{"login":"JMAConsulting","id":2036425,"avatar_url":"https://avatars3.githubusercontent.com/u/2036425?v=3","gravatar_id":"","url":"https://api.github.com/users/JMAConsulting","html_url":"https://github.com/JMAConsulting","followers_url":"https://api.github.com/users/JMAConsulting/followers","following_url":"https://api.github.com/users/JMAConsulting/following{/other_user}","gists_url":"https://api.github.com/users/JMAConsulting/gists{/gist_id}","starred_url":"https://api.github.com/users/JMAConsulting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMAConsulting/subscriptions","organizations_url":"https://api.github.com/users/JMAConsulting/orgs","repos_url":"https://api.github.com/users/JMAConsulting/repos","events_url":"https://api.github.com/users/JMAConsulting/events{/privacy}","received_events_url":"https://api.github.com/users/JMAConsulting/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JMAConsulting/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":true,"url":"https://api.github.com/repos/JMAConsulting/civicrm-core","forks_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/forks","keys_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/teams","hooks_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/events","assignees_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/tags","blobs_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/subscription","commits_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/merges","archive_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/downloads","issues_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/JMAConsulting/civicrm-core/deployments","created_at":"2014-02-05T14:01:01Z","updated_at":"2015-03-25T16:46:36Z","pushed_at":"2017-05-25T12:53:46Z","git_url":"git://github.com/JMAConsulting/civicrm-core.git","ssh_url":"git@github.com:JMAConsulting/civicrm-core.git","clone_url":"https://github.com/JMAConsulting/civicrm-core.git","svn_url":"https://github.com/JMAConsulting/civicrm-core","homepage":null,"size":167445,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"civicrm:master","ref":"master","sha":"b5bc44021489c12c1f220671e6aafdb52b5126ba","user":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"repo":{"id":8495499,"name":"civicrm-core","full_name":"civicrm/civicrm-core","owner":{"login":"civicrm","id":136373,"avatar_url":"https://avatars1.githubusercontent.com/u/136373?v=3","gravatar_id":"","url":"https://api.github.com/users/civicrm","html_url":"https://github.com/civicrm","followers_url":"https://api.github.com/users/civicrm/followers","following_url":"https://api.github.com/users/civicrm/following{/other_user}","gists_url":"https://api.github.com/users/civicrm/gists{/gist_id}","starred_url":"https://api.github.com/users/civicrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civicrm/subscriptions","organizations_url":"https://api.github.com/users/civicrm/orgs","repos_url":"https://api.github.com/users/civicrm/repos","events_url":"https://api.github.com/users/civicrm/events{/privacy}","received_events_url":"https://api.github.com/users/civicrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/civicrm/civicrm-core","description":"CiviCRM (Core Application and Framework)","fork":false,"url":"https://api.github.com/repos/civicrm/civicrm-core","forks_url":"https://api.github.com/repos/civicrm/civicrm-core/forks","keys_url":"https://api.github.com/repos/civicrm/civicrm-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/civicrm/civicrm-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/civicrm/civicrm-core/teams","hooks_url":"https://api.github.com/repos/civicrm/civicrm-core/hooks","issue_events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/events{/number}","events_url":"https://api.github.com/repos/civicrm/civicrm-core/events","assignees_url":"https://api.github.com/repos/civicrm/civicrm-core/assignees{/user}","branches_url":"https://api.github.com/repos/civicrm/civicrm-core/branches{/branch}","tags_url":"https://api.github.com/repos/civicrm/civicrm-core/tags","blobs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/civicrm/civicrm-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/civicrm/civicrm-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/civicrm/civicrm-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/civicrm/civicrm-core/statuses/{sha}","languages_url":"https://api.github.com/repos/civicrm/civicrm-core/languages","stargazers_url":"https://api.github.com/repos/civicrm/civicrm-core/stargazers","contributors_url":"https://api.github.com/repos/civicrm/civicrm-core/contributors","subscribers_url":"https://api.github.com/repos/civicrm/civicrm-core/subscribers","subscription_url":"https://api.github.com/repos/civicrm/civicrm-core/subscription","commits_url":"https://api.github.com/repos/civicrm/civicrm-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/civicrm/civicrm-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/civicrm/civicrm-core/contents/{+path}","compare_url":"https://api.github.com/repos/civicrm/civicrm-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/civicrm/civicrm-core/merges","archive_url":"https://api.github.com/repos/civicrm/civicrm-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/civicrm/civicrm-core/downloads","issues_url":"https://api.github.com/repos/civicrm/civicrm-core/issues{/number}","pulls_url":"https://api.github.com/repos/civicrm/civicrm-core/pulls{/number}","milestones_url":"https://api.github.com/repos/civicrm/civicrm-core/milestones{/number}","notifications_url":"https://api.github.com/repos/civicrm/civicrm-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/labels{/name}","releases_url":"https://api.github.com/repos/civicrm/civicrm-core/releases{/id}","deployments_url":"https://api.github.com/repos/civicrm/civicrm-core/deployments","created_at":"2013-03-01T06:11:56Z","updated_at":"2017-05-22T01:09:45Z","pushed_at":"2017-05-27T14:52:31Z","git_url":"git://github.com/civicrm/civicrm-core.git","ssh_url":"git@github.com:civicrm/civicrm-core.git","clone_url":"https://github.com/civicrm/civicrm-core.git","svn_url":"https://github.com/civicrm/civicrm-core","homepage":null,"size":146278,"stargazers_count":195,"watchers_count":195,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":542,"mirror_url":null,"open_issues_count":182,"forks":542,"open_issues":182,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370"},"html":{"href":"https://github.com/civicrm/civicrm-core/pull/10370"},"issue":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/10370"},"comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/issues/10370/comments"},"review_comments":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370/comments"},"review_comment":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10370/commits"},"statuses":{"href":"https://api.github.com/repos/civicrm/civicrm-core/statuses/614a435d02fb7d58a85cd1216f226a8ac05edf2d"}}}}
|
{
"id": 8495499,
"name": "civicrm/civicrm-core",
"url": "https://api.github.com/repos/civicrm/civicrm-core"
}
|
{
"id": 3735621,
"login": "monishdeb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3735621?",
"url": "https://api.github.com/users/monishdeb"
}
|
{
"id": 136373,
"login": "civicrm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/136373?",
"url": "https://api.github.com/orgs/civicrm"
}
| 2017-05-27T16:01:00 |
5954244404
|
{"actor":{"display_login":"monishdeb"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/compose/transporter/pulls/comments/97353695","pull_request_review_id":17954316,"id":97353695,"diff_hunk":"@@ -0,0 +1,91 @@\n+package v2","path":"pkg/adaptor/elasticsearch/clients/v2/writer.go","position":1,"original_position":1,"commit_id":"42a01226c956e3a7022a7c7fa66cc9553a041432","original_commit_id":"42a01226c956e3a7022a7c7fa66cc9553a041432","user":{"login":"trinchan","id":3772659,"avatar_url":"https://avatars.githubusercontent.com/u/3772659?v=3","gravatar_id":"","url":"https://api.github.com/users/trinchan","html_url":"https://github.com/trinchan","followers_url":"https://api.github.com/users/trinchan/followers","following_url":"https://api.github.com/users/trinchan/following{/other_user}","gists_url":"https://api.github.com/users/trinchan/gists{/gist_id}","starred_url":"https://api.github.com/users/trinchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trinchan/subscriptions","organizations_url":"https://api.github.com/users/trinchan/orgs","repos_url":"https://api.github.com/users/trinchan/repos","events_url":"https://api.github.com/users/trinchan/events{/privacy}","received_events_url":"https://api.github.com/users/trinchan/received_events","type":"User","site_admin":false},"body":"I know you're aware of all the code duplication, just want to make sure we track it in an issue to investigate clever ways to do the versioning.","created_at":"2017-01-23T16:16:51Z","updated_at":"2017-01-23T16:23:52Z","html_url":"https://github.com/compose/transporter/pull/233#discussion_r97353695","pull_request_url":"https://api.github.com/repos/compose/transporter/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/compose/transporter/pulls/comments/97353695"},"html":{"href":"https://github.com/compose/transporter/pull/233#discussion_r97353695"},"pull_request":{"href":"https://api.github.com/repos/compose/transporter/pulls/233"}}},"pull_request":{"url":"https://api.github.com/repos/compose/transporter/pulls/233","id":102321749,"html_url":"https://github.com/compose/transporter/pull/233","diff_url":"https://github.com/compose/transporter/pull/233.diff","patch_url":"https://github.com/compose/transporter/pull/233.patch","issue_url":"https://api.github.com/repos/compose/transporter/issues/233","number":233,"state":"open","locked":false,"title":"209 ES adaptor stability","user":{"login":"jipperinbham","id":829493,"avatar_url":"https://avatars.githubusercontent.com/u/829493?v=3","gravatar_id":"","url":"https://api.github.com/users/jipperinbham","html_url":"https://github.com/jipperinbham","followers_url":"https://api.github.com/users/jipperinbham/followers","following_url":"https://api.github.com/users/jipperinbham/following{/other_user}","gists_url":"https://api.github.com/users/jipperinbham/gists{/gist_id}","starred_url":"https://api.github.com/users/jipperinbham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jipperinbham/subscriptions","organizations_url":"https://api.github.com/users/jipperinbham/orgs","repos_url":"https://api.github.com/users/jipperinbham/repos","events_url":"https://api.github.com/users/jipperinbham/events{/privacy}","received_events_url":"https://api.github.com/users/jipperinbham/received_events","type":"User","site_admin":false},"body":"- [ ] CHANGELOG.md updated (feel free to wait until changes have been reviewed by a maintainer)\r\n- [ ] README.md updated (if needed)\r\n\r\nswitch from `elastigo` to `elastic` library and create underlying clients for each major version of elasticsearch.\r\n\r\nfixes #209 ","created_at":"2017-01-19T18:26:16Z","updated_at":"2017-01-23T16:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6169377fd24d999715a06da60879d159b719a09","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/compose/transporter/pulls/233/commits","review_comments_url":"https://api.github.com/repos/compose/transporter/pulls/233/comments","review_comment_url":"https://api.github.com/repos/compose/transporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compose/transporter/issues/233/comments","statuses_url":"https://api.github.com/repos/compose/transporter/statuses/42a01226c956e3a7022a7c7fa66cc9553a041432","head":{"label":"compose:209-es-stability","ref":"209-es-stability","sha":"42a01226c956e3a7022a7c7fa66cc9553a041432","user":{"login":"compose","id":9220126,"avatar_url":"https://avatars.githubusercontent.com/u/9220126?v=3","gravatar_id":"","url":"https://api.github.com/users/compose","html_url":"https://github.com/compose","followers_url":"https://api.github.com/users/compose/followers","following_url":"https://api.github.com/users/compose/following{/other_user}","gists_url":"https://api.github.com/users/compose/gists{/gist_id}","starred_url":"https://api.github.com/users/compose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compose/subscriptions","organizations_url":"https://api.github.com/users/compose/orgs","repos_url":"https://api.github.com/users/compose/repos","events_url":"https://api.github.com/users/compose/events{/privacy}","received_events_url":"https://api.github.com/users/compose/received_events","type":"Organization","site_admin":false},"repo":{"id":25216563,"name":"transporter","full_name":"compose/transporter","owner":{"login":"compose","id":9220126,"avatar_url":"https://avatars.githubusercontent.com/u/9220126?v=3","gravatar_id":"","url":"https://api.github.com/users/compose","html_url":"https://github.com/compose","followers_url":"https://api.github.com/users/compose/followers","following_url":"https://api.github.com/users/compose/following{/other_user}","gists_url":"https://api.github.com/users/compose/gists{/gist_id}","starred_url":"https://api.github.com/users/compose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compose/subscriptions","organizations_url":"https://api.github.com/users/compose/orgs","repos_url":"https://api.github.com/users/compose/repos","events_url":"https://api.github.com/users/compose/events{/privacy}","received_events_url":"https://api.github.com/users/compose/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compose/transporter","description":"Sync data between persistence engines, like ETL only not stodgy","fork":false,"url":"https://api.github.com/repos/compose/transporter","forks_url":"https://api.github.com/repos/compose/transporter/forks","keys_url":"https://api.github.com/repos/compose/transporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compose/transporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compose/transporter/teams","hooks_url":"https://api.github.com/repos/compose/transporter/hooks","issue_events_url":"https://api.github.com/repos/compose/transporter/issues/events{/number}","events_url":"https://api.github.com/repos/compose/transporter/events","assignees_url":"https://api.github.com/repos/compose/transporter/assignees{/user}","branches_url":"https://api.github.com/repos/compose/transporter/branches{/branch}","tags_url":"https://api.github.com/repos/compose/transporter/tags","blobs_url":"https://api.github.com/repos/compose/transporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compose/transporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compose/transporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/compose/transporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compose/transporter/statuses/{sha}","languages_url":"https://api.github.com/repos/compose/transporter/languages","stargazers_url":"https://api.github.com/repos/compose/transporter/stargazers","contributors_url":"https://api.github.com/repos/compose/transporter/contributors","subscribers_url":"https://api.github.com/repos/compose/transporter/subscribers","subscription_url":"https://api.github.com/repos/compose/transporter/subscription","commits_url":"https://api.github.com/repos/compose/transporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/compose/transporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/compose/transporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/compose/transporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/compose/transporter/contents/{+path}","compare_url":"https://api.github.com/repos/compose/transporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compose/transporter/merges","archive_url":"https://api.github.com/repos/compose/transporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compose/transporter/downloads","issues_url":"https://api.github.com/repos/compose/transporter/issues{/number}","pulls_url":"https://api.github.com/repos/compose/transporter/pulls{/number}","milestones_url":"https://api.github.com/repos/compose/transporter/milestones{/number}","notifications_url":"https://api.github.com/repos/compose/transporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compose/transporter/labels{/name}","releases_url":"https://api.github.com/repos/compose/transporter/releases{/id}","deployments_url":"https://api.github.com/repos/compose/transporter/deployments","created_at":"2014-10-14T16:48:05Z","updated_at":"2017-01-23T15:56:13Z","pushed_at":"2017-01-21T04:18:45Z","git_url":"git://github.com/compose/transporter.git","ssh_url":"git@github.com:compose/transporter.git","clone_url":"https://github.com/compose/transporter.git","svn_url":"https://github.com/compose/transporter","homepage":null,"size":8747,"stargazers_count":469,"watchers_count":469,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":33,"forks":85,"open_issues":33,"watchers":469,"default_branch":"master"}},"base":{"label":"compose:experimental","ref":"experimental","sha":"cdcf4b99bb3b9bafff8bedc8aebe4f411d089876","user":{"login":"compose","id":9220126,"avatar_url":"https://avatars.githubusercontent.com/u/9220126?v=3","gravatar_id":"","url":"https://api.github.com/users/compose","html_url":"https://github.com/compose","followers_url":"https://api.github.com/users/compose/followers","following_url":"https://api.github.com/users/compose/following{/other_user}","gists_url":"https://api.github.com/users/compose/gists{/gist_id}","starred_url":"https://api.github.com/users/compose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compose/subscriptions","organizations_url":"https://api.github.com/users/compose/orgs","repos_url":"https://api.github.com/users/compose/repos","events_url":"https://api.github.com/users/compose/events{/privacy}","received_events_url":"https://api.github.com/users/compose/received_events","type":"Organization","site_admin":false},"repo":{"id":25216563,"name":"transporter","full_name":"compose/transporter","owner":{"login":"compose","id":9220126,"avatar_url":"https://avatars.githubusercontent.com/u/9220126?v=3","gravatar_id":"","url":"https://api.github.com/users/compose","html_url":"https://github.com/compose","followers_url":"https://api.github.com/users/compose/followers","following_url":"https://api.github.com/users/compose/following{/other_user}","gists_url":"https://api.github.com/users/compose/gists{/gist_id}","starred_url":"https://api.github.com/users/compose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compose/subscriptions","organizations_url":"https://api.github.com/users/compose/orgs","repos_url":"https://api.github.com/users/compose/repos","events_url":"https://api.github.com/users/compose/events{/privacy}","received_events_url":"https://api.github.com/users/compose/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/compose/transporter","description":"Sync data between persistence engines, like ETL only not stodgy","fork":false,"url":"https://api.github.com/repos/compose/transporter","forks_url":"https://api.github.com/repos/compose/transporter/forks","keys_url":"https://api.github.com/repos/compose/transporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compose/transporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compose/transporter/teams","hooks_url":"https://api.github.com/repos/compose/transporter/hooks","issue_events_url":"https://api.github.com/repos/compose/transporter/issues/events{/number}","events_url":"https://api.github.com/repos/compose/transporter/events","assignees_url":"https://api.github.com/repos/compose/transporter/assignees{/user}","branches_url":"https://api.github.com/repos/compose/transporter/branches{/branch}","tags_url":"https://api.github.com/repos/compose/transporter/tags","blobs_url":"https://api.github.com/repos/compose/transporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compose/transporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compose/transporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/compose/transporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compose/transporter/statuses/{sha}","languages_url":"https://api.github.com/repos/compose/transporter/languages","stargazers_url":"https://api.github.com/repos/compose/transporter/stargazers","contributors_url":"https://api.github.com/repos/compose/transporter/contributors","subscribers_url":"https://api.github.com/repos/compose/transporter/subscribers","subscription_url":"https://api.github.com/repos/compose/transporter/subscription","commits_url":"https://api.github.com/repos/compose/transporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/compose/transporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/compose/transporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/compose/transporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/compose/transporter/contents/{+path}","compare_url":"https://api.github.com/repos/compose/transporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compose/transporter/merges","archive_url":"https://api.github.com/repos/compose/transporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compose/transporter/downloads","issues_url":"https://api.github.com/repos/compose/transporter/issues{/number}","pulls_url":"https://api.github.com/repos/compose/transporter/pulls{/number}","milestones_url":"https://api.github.com/repos/compose/transporter/milestones{/number}","notifications_url":"https://api.github.com/repos/compose/transporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compose/transporter/labels{/name}","releases_url":"https://api.github.com/repos/compose/transporter/releases{/id}","deployments_url":"https://api.github.com/repos/compose/transporter/deployments","created_at":"2014-10-14T16:48:05Z","updated_at":"2017-01-23T15:56:13Z","pushed_at":"2017-01-21T04:18:45Z","git_url":"git://github.com/compose/transporter.git","ssh_url":"git@github.com:compose/transporter.git","clone_url":"https://github.com/compose/transporter.git","svn_url":"https://github.com/compose/transporter","homepage":null,"size":8747,"stargazers_count":469,"watchers_count":469,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":85,"mirror_url":null,"open_issues_count":33,"forks":85,"open_issues":33,"watchers":469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compose/transporter/pulls/233"},"html":{"href":"https://github.com/compose/transporter/pull/233"},"issue":{"href":"https://api.github.com/repos/compose/transporter/issues/233"},"comments":{"href":"https://api.github.com/repos/compose/transporter/issues/233/comments"},"review_comments":{"href":"https://api.github.com/repos/compose/transporter/pulls/233/comments"},"review_comment":{"href":"https://api.github.com/repos/compose/transporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compose/transporter/pulls/233/commits"},"statuses":{"href":"https://api.github.com/repos/compose/transporter/statuses/42a01226c956e3a7022a7c7fa66cc9553a041432"}}}}
|
{
"id": 25216563,
"name": "compose/transporter",
"url": "https://api.github.com/repos/compose/transporter"
}
|
{
"id": 3772659,
"login": "trinchan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3772659?",
"url": "https://api.github.com/users/trinchan"
}
|
{
"id": 9220126,
"login": "compose",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9220126?",
"url": "https://api.github.com/orgs/compose"
}
| 2017-01-23T16:16:51 |
5197755957
|
{"actor":{"display_login":"trinchan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/decidim/decidim/pulls/comments/131127407","pull_request_review_id":54076659,"id":131127407,"diff_hunk":"@@ -0,0 +1,42 @@\n+# frozen_string_literal: true\n+\n+module Decidim\n+ #\n+ # Makes a class behave as an engine router. It needs to specify the\n+ # mounted_engine and the default\n+ #\n+ class EngineRouter\n+ include Rails.application.routes.mounted_helpers\n+\n+ def self.main_proxy(target)\n+ new(target.mounted_engine, target.mounted_params)\n+ end\n+\n+ def self.admin_proxy(target)\n+ new(target.mounted_admin_engine, target.mounted_params)\n+ end\n+\n+ attr_reader :default_url_options\n+\n+ def initialize(engine, default_url_options)\n+ @engine = engine\n+ @default_url_options = default_url_options\n+ end\n+\n+ def respond_to_missing?(method_name, include_private = false)\n+ route_helper?(method_name) || super\n+ end\n+\n+ def method_missing(method_name, *args)\n+ return super unless route_helper?(method_name)\n+\n+ send(@engine).send(method_name, *args)\n+ end\n+\n+ private\n+\n+ def route_helper?(method_name)\n+ method_name.to_s.match?(/_(url|path)/)","path":"decidim-core/lib/decidim/engine_router.rb","position":39,"original_position":39,"commit_id":"6bbdad7b35cc1cd3d0659d92eadf93061b775db5","original_commit_id":"ba020aa0e2c1525a3e067a47e18b88802a0594a3","user":{"login":"mrcasals","id":491891,"avatar_url":"https://avatars3.githubusercontent.com/u/491891?v=4","gravatar_id":"","url":"https://api.github.com/users/mrcasals","html_url":"https://github.com/mrcasals","followers_url":"https://api.github.com/users/mrcasals/followers","following_url":"https://api.github.com/users/mrcasals/following{/other_user}","gists_url":"https://api.github.com/users/mrcasals/gists{/gist_id}","starred_url":"https://api.github.com/users/mrcasals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrcasals/subscriptions","organizations_url":"https://api.github.com/users/mrcasals/orgs","repos_url":"https://api.github.com/users/mrcasals/repos","events_url":"https://api.github.com/users/mrcasals/events{/privacy}","received_events_url":"https://api.github.com/users/mrcasals/received_events","type":"User","site_admin":false},"body":"`/_(url|path)$/` maybe?","created_at":"2017-08-03T12:30:10Z","updated_at":"2017-08-03T12:30:10Z","html_url":"https://github.com/decidim/decidim/pull/1683#discussion_r131127407","pull_request_url":"https://api.github.com/repos/decidim/decidim/pulls/1683","_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments/131127407"},"html":{"href":"https://github.com/decidim/decidim/pull/1683#discussion_r131127407"},"pull_request":{"href":"https://api.github.com/repos/decidim/decidim/pulls/1683"}}},"pull_request":{"url":"https://api.github.com/repos/decidim/decidim/pulls/1683","id":133928956,"html_url":"https://github.com/decidim/decidim/pull/1683","diff_url":"https://github.com/decidim/decidim/pull/1683.diff","patch_url":"https://github.com/decidim/decidim/pull/1683.patch","issue_url":"https://api.github.com/repos/decidim/decidim/issues/1683","number":1683,"state":"open","locked":false,"title":"\"Featurable\" support & participatory processes plugin","user":{"login":"deivid-rodriguez","id":2887858,"avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false},"body":"#### :tophat: What? Why?\r\n\r\nThis PR adds support for multiple \"featurable\" objects (or however we end up calling them), and extracts participatory process as a first example of a featurable plugin.\r\n\r\nThis is a big PR involving a lot of namespacing. To try to make reviewing it easier, I've introduced the namespacing _without_ changing indentation. RuboCop won't like it, but it makes diffs a lot simpler. Once this is reviewed, I'll do a RuboCop auto-correct pass to fix indentations. \r\n\r\n#### :pushpin: Related Issues\r\n- Related to #1346.\r\n\r\n#### :clipboard: Subtasks\r\n_None_.\r\n\r\n### :camera: Screenshots (optional)\r\n_None_.\r\n\r\n#### :ghost: GIF\r\n","created_at":"2017-08-03T12:11:49Z","updated_at":"2017-08-03T12:30:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dea9bc41045bd56997a7952464a5e1323d980362","assignee":{"login":"deivid-rodriguez","id":2887858,"avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false},"assignees":[{"login":"deivid-rodriguez","id":2887858,"avatar_url":"https://avatars2.githubusercontent.com/u/2887858?v=4","gravatar_id":"","url":"https://api.github.com/users/deivid-rodriguez","html_url":"https://github.com/deivid-rodriguez","followers_url":"https://api.github.com/users/deivid-rodriguez/followers","following_url":"https://api.github.com/users/deivid-rodriguez/following{/other_user}","gists_url":"https://api.github.com/users/deivid-rodriguez/gists{/gist_id}","starred_url":"https://api.github.com/users/deivid-rodriguez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deivid-rodriguez/subscriptions","organizations_url":"https://api.github.com/users/deivid-rodriguez/orgs","repos_url":"https://api.github.com/users/deivid-rodriguez/repos","events_url":"https://api.github.com/users/deivid-rodriguez/events{/privacy}","received_events_url":"https://api.github.com/users/deivid-rodriguez/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/decidim/decidim/pulls/1683/commits","review_comments_url":"https://api.github.com/repos/decidim/decidim/pulls/1683/comments","review_comment_url":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/decidim/decidim/issues/1683/comments","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/6bbdad7b35cc1cd3d0659d92eadf93061b775db5","head":{"label":"decidim:feature/extract_participatory_processes_plugin","ref":"feature/extract_participatory_processes_plugin","sha":"6bbdad7b35cc1cd3d0659d92eadf93061b775db5","user":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2017-08-02T03:06:17Z","pushed_at":"2017-08-03T12:27:40Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":13419,"stargazers_count":52,"watchers_count":52,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":172,"forks":23,"open_issues":172,"watchers":52,"default_branch":"master"}},"base":{"label":"decidim:milestone/assemblies","ref":"milestone/assemblies","sha":"1c1e504fb56d3269a071de904420ab41440fb6ef","user":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"repo":{"id":65914086,"name":"decidim","full_name":"decidim/decidim","owner":{"login":"decidim","id":22474646,"avatar_url":"https://avatars3.githubusercontent.com/u/22474646?v=4","gravatar_id":"","url":"https://api.github.com/users/decidim","html_url":"https://github.com/decidim","followers_url":"https://api.github.com/users/decidim/followers","following_url":"https://api.github.com/users/decidim/following{/other_user}","gists_url":"https://api.github.com/users/decidim/gists{/gist_id}","starred_url":"https://api.github.com/users/decidim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decidim/subscriptions","organizations_url":"https://api.github.com/users/decidim/orgs","repos_url":"https://api.github.com/users/decidim/repos","events_url":"https://api.github.com/users/decidim/events{/privacy}","received_events_url":"https://api.github.com/users/decidim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/decidim/decidim","description":"The participatory democracy framework. A generator and multiple gems made with Ruby on Rails. ","fork":false,"url":"https://api.github.com/repos/decidim/decidim","forks_url":"https://api.github.com/repos/decidim/decidim/forks","keys_url":"https://api.github.com/repos/decidim/decidim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/decidim/decidim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/decidim/decidim/teams","hooks_url":"https://api.github.com/repos/decidim/decidim/hooks","issue_events_url":"https://api.github.com/repos/decidim/decidim/issues/events{/number}","events_url":"https://api.github.com/repos/decidim/decidim/events","assignees_url":"https://api.github.com/repos/decidim/decidim/assignees{/user}","branches_url":"https://api.github.com/repos/decidim/decidim/branches{/branch}","tags_url":"https://api.github.com/repos/decidim/decidim/tags","blobs_url":"https://api.github.com/repos/decidim/decidim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/decidim/decidim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/decidim/decidim/git/refs{/sha}","trees_url":"https://api.github.com/repos/decidim/decidim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/decidim/decidim/statuses/{sha}","languages_url":"https://api.github.com/repos/decidim/decidim/languages","stargazers_url":"https://api.github.com/repos/decidim/decidim/stargazers","contributors_url":"https://api.github.com/repos/decidim/decidim/contributors","subscribers_url":"https://api.github.com/repos/decidim/decidim/subscribers","subscription_url":"https://api.github.com/repos/decidim/decidim/subscription","commits_url":"https://api.github.com/repos/decidim/decidim/commits{/sha}","git_commits_url":"https://api.github.com/repos/decidim/decidim/git/commits{/sha}","comments_url":"https://api.github.com/repos/decidim/decidim/comments{/number}","issue_comment_url":"https://api.github.com/repos/decidim/decidim/issues/comments{/number}","contents_url":"https://api.github.com/repos/decidim/decidim/contents/{+path}","compare_url":"https://api.github.com/repos/decidim/decidim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/decidim/decidim/merges","archive_url":"https://api.github.com/repos/decidim/decidim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/decidim/decidim/downloads","issues_url":"https://api.github.com/repos/decidim/decidim/issues{/number}","pulls_url":"https://api.github.com/repos/decidim/decidim/pulls{/number}","milestones_url":"https://api.github.com/repos/decidim/decidim/milestones{/number}","notifications_url":"https://api.github.com/repos/decidim/decidim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/decidim/decidim/labels{/name}","releases_url":"https://api.github.com/repos/decidim/decidim/releases{/id}","deployments_url":"https://api.github.com/repos/decidim/decidim/deployments","created_at":"2016-08-17T14:27:06Z","updated_at":"2017-08-02T03:06:17Z","pushed_at":"2017-08-03T12:27:40Z","git_url":"git://github.com/decidim/decidim.git","ssh_url":"git@github.com:decidim/decidim.git","clone_url":"https://github.com/decidim/decidim.git","svn_url":"https://github.com/decidim/decidim","homepage":"http://www.decidim.org","size":13419,"stargazers_count":52,"watchers_count":52,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":172,"forks":23,"open_issues":172,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/decidim/decidim/pulls/1683"},"html":{"href":"https://github.com/decidim/decidim/pull/1683"},"issue":{"href":"https://api.github.com/repos/decidim/decidim/issues/1683"},"comments":{"href":"https://api.github.com/repos/decidim/decidim/issues/1683/comments"},"review_comments":{"href":"https://api.github.com/repos/decidim/decidim/pulls/1683/comments"},"review_comment":{"href":"https://api.github.com/repos/decidim/decidim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/decidim/decidim/pulls/1683/commits"},"statuses":{"href":"https://api.github.com/repos/decidim/decidim/statuses/6bbdad7b35cc1cd3d0659d92eadf93061b775db5"}}}}
|
{
"id": 65914086,
"name": "decidim/decidim",
"url": "https://api.github.com/repos/decidim/decidim"
}
|
{
"id": 491891,
"login": "mrcasals",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/491891?",
"url": "https://api.github.com/users/mrcasals"
}
|
{
"id": 22474646,
"login": "decidim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22474646?",
"url": "https://api.github.com/orgs/decidim"
}
| 2017-08-03T12:30:10 |
6386930139
|
{"actor":{"display_login":"mrcasals"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/doczhcn/istio/pulls/comments/146746010","pull_request_review_id":71731891,"id":146746010,"diff_hunk":"@@ -0,0 +1,156 @@\n+此任务将为您展示如何根据权重和HTTP header配置动态请求路由。\n+\n+## 前提条件\n+\n+* 参照该文档中的步骤安装Istio [Installation guide](../../setup/index.md)。\n+\n+* 部署 [BookInfo](../../guides/bookinfo.md) 示例应用程序。\n+\n+> 请注意：本文档假设示例应用程序通过kubernetes进行部署。所有的示例命令行都采用规则yaml文件指定的kubernetes版本（例如`samples/bookinfo/kube/route-rule-all-v1.yaml`)。如果您在不同的环境下运行本任务，请将`kube`修改为您运行环境中相应的目录（例如，对基于Consul的运行环境，目录就是`samples/bookinfo/consul/route-rule-all-v1.yaml`）。\n+\n+## 基于内容的路由\n+\n+BookInfo示例部署了三个版本的reviews服务，因此我们需要设置一个缺省路由。否则当你多次访问该应用程序时，你会发现有时输出会包含带星级的评价内容，有时又没有。出现该现象的原因是当没有为应用显示指定缺省路由时，Istio会将请求随机路由到所有版本的可用服务上。","path":"docs/tasks/traffic-management/request-routing.md","position":13,"original_position":13,"commit_id":"9d6319f7051183cf1d3d504a608aad0180a2a9e6","original_commit_id":"9d6319f7051183cf1d3d504a608aad0180a2a9e6","user":{"login":"zhaohuabing","id":1321762,"avatar_url":"https://avatars3.githubusercontent.com/u/1321762?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaohuabing","html_url":"https://github.com/zhaohuabing","followers_url":"https://api.github.com/users/zhaohuabing/followers","following_url":"https://api.github.com/users/zhaohuabing/following{/other_user}","gists_url":"https://api.github.com/users/zhaohuabing/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaohuabing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaohuabing/subscriptions","organizations_url":"https://api.github.com/users/zhaohuabing/orgs","repos_url":"https://api.github.com/users/zhaohuabing/repos","events_url":"https://api.github.com/users/zhaohuabing/events{/privacy}","received_events_url":"https://api.github.com/users/zhaohuabing/received_events","type":"User","site_admin":false},"body":"已修改。","created_at":"2017-10-25T03:15:16Z","updated_at":"2017-10-25T03:15:16Z","html_url":"https://github.com/doczhcn/istio/pull/40#discussion_r146746010","pull_request_url":"https://api.github.com/repos/doczhcn/istio/pulls/40","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/comments/146746010"},"html":{"href":"https://github.com/doczhcn/istio/pull/40#discussion_r146746010"},"pull_request":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/40"}},"in_reply_to_id":146736727},"pull_request":{"url":"https://api.github.com/repos/doczhcn/istio/pulls/40","id":148324113,"html_url":"https://github.com/doczhcn/istio/pull/40","diff_url":"https://github.com/doczhcn/istio/pull/40.diff","patch_url":"https://github.com/doczhcn/istio/pull/40.patch","issue_url":"https://api.github.com/repos/doczhcn/istio/issues/40","number":40,"state":"open","locked":false,"title":"translation for traffic management request routing","user":{"login":"zhaohuabing","id":1321762,"avatar_url":"https://avatars3.githubusercontent.com/u/1321762?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaohuabing","html_url":"https://github.com/zhaohuabing","followers_url":"https://api.github.com/users/zhaohuabing/followers","following_url":"https://api.github.com/users/zhaohuabing/following{/other_user}","gists_url":"https://api.github.com/users/zhaohuabing/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaohuabing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaohuabing/subscriptions","organizations_url":"https://api.github.com/users/zhaohuabing/orgs","repos_url":"https://api.github.com/users/zhaohuabing/repos","events_url":"https://api.github.com/users/zhaohuabing/events{/privacy}","received_events_url":"https://api.github.com/users/zhaohuabing/received_events","type":"User","site_admin":false},"body":"#38 ","created_at":"2017-10-24T08:06:14Z","updated_at":"2017-10-25T03:15:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f66039b1224d60255f1c9f30666f0cc65649f25","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/doczhcn/istio/pulls/40/commits","review_comments_url":"https://api.github.com/repos/doczhcn/istio/pulls/40/comments","review_comment_url":"https://api.github.com/repos/doczhcn/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doczhcn/istio/issues/40/comments","statuses_url":"https://api.github.com/repos/doczhcn/istio/statuses/9d6319f7051183cf1d3d504a608aad0180a2a9e6","head":{"label":"zhaohuabing:zhaohuabing-traffic-management-request-routing","ref":"zhaohuabing-traffic-management-request-routing","sha":"9d6319f7051183cf1d3d504a608aad0180a2a9e6","user":{"login":"zhaohuabing","id":1321762,"avatar_url":"https://avatars3.githubusercontent.com/u/1321762?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaohuabing","html_url":"https://github.com/zhaohuabing","followers_url":"https://api.github.com/users/zhaohuabing/followers","following_url":"https://api.github.com/users/zhaohuabing/following{/other_user}","gists_url":"https://api.github.com/users/zhaohuabing/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaohuabing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaohuabing/subscriptions","organizations_url":"https://api.github.com/users/zhaohuabing/orgs","repos_url":"https://api.github.com/users/zhaohuabing/repos","events_url":"https://api.github.com/users/zhaohuabing/events{/privacy}","received_events_url":"https://api.github.com/users/zhaohuabing/received_events","type":"User","site_admin":false},"repo":{"id":107510253,"name":"istio","full_name":"zhaohuabing/istio","owner":{"login":"zhaohuabing","id":1321762,"avatar_url":"https://avatars3.githubusercontent.com/u/1321762?v=4","gravatar_id":"","url":"https://api.github.com/users/zhaohuabing","html_url":"https://github.com/zhaohuabing","followers_url":"https://api.github.com/users/zhaohuabing/followers","following_url":"https://api.github.com/users/zhaohuabing/following{/other_user}","gists_url":"https://api.github.com/users/zhaohuabing/gists{/gist_id}","starred_url":"https://api.github.com/users/zhaohuabing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhaohuabing/subscriptions","organizations_url":"https://api.github.com/users/zhaohuabing/orgs","repos_url":"https://api.github.com/users/zhaohuabing/repos","events_url":"https://api.github.com/users/zhaohuabing/events{/privacy}","received_events_url":"https://api.github.com/users/zhaohuabing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zhaohuabing/istio","description":"Istio官方文档中文版","fork":true,"url":"https://api.github.com/repos/zhaohuabing/istio","forks_url":"https://api.github.com/repos/zhaohuabing/istio/forks","keys_url":"https://api.github.com/repos/zhaohuabing/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhaohuabing/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhaohuabing/istio/teams","hooks_url":"https://api.github.com/repos/zhaohuabing/istio/hooks","issue_events_url":"https://api.github.com/repos/zhaohuabing/istio/issues/events{/number}","events_url":"https://api.github.com/repos/zhaohuabing/istio/events","assignees_url":"https://api.github.com/repos/zhaohuabing/istio/assignees{/user}","branches_url":"https://api.github.com/repos/zhaohuabing/istio/branches{/branch}","tags_url":"https://api.github.com/repos/zhaohuabing/istio/tags","blobs_url":"https://api.github.com/repos/zhaohuabing/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhaohuabing/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhaohuabing/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhaohuabing/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhaohuabing/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/zhaohuabing/istio/languages","stargazers_url":"https://api.github.com/repos/zhaohuabing/istio/stargazers","contributors_url":"https://api.github.com/repos/zhaohuabing/istio/contributors","subscribers_url":"https://api.github.com/repos/zhaohuabing/istio/subscribers","subscription_url":"https://api.github.com/repos/zhaohuabing/istio/subscription","commits_url":"https://api.github.com/repos/zhaohuabing/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhaohuabing/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhaohuabing/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhaohuabing/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhaohuabing/istio/contents/{+path}","compare_url":"https://api.github.com/repos/zhaohuabing/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhaohuabing/istio/merges","archive_url":"https://api.github.com/repos/zhaohuabing/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhaohuabing/istio/downloads","issues_url":"https://api.github.com/repos/zhaohuabing/istio/issues{/number}","pulls_url":"https://api.github.com/repos/zhaohuabing/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/zhaohuabing/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/zhaohuabing/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhaohuabing/istio/labels{/name}","releases_url":"https://api.github.com/repos/zhaohuabing/istio/releases{/id}","deployments_url":"https://api.github.com/repos/zhaohuabing/istio/deployments","created_at":"2017-10-19T07:04:46Z","updated_at":"2017-10-20T15:43:11Z","pushed_at":"2017-10-24T11:58:45Z","git_url":"git://github.com/zhaohuabing/istio.git","ssh_url":"git@github.com:zhaohuabing/istio.git","clone_url":"https://github.com/zhaohuabing/istio.git","svn_url":"https://github.com/zhaohuabing/istio","homepage":"http://istio.doczh.cn/","size":1093,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doczhcn:master","ref":"master","sha":"30893697e8d0bc7ebae76d4b25efa738bfb1e788","user":{"login":"doczhcn","id":29801046,"avatar_url":"https://avatars2.githubusercontent.com/u/29801046?v=4","gravatar_id":"","url":"https://api.github.com/users/doczhcn","html_url":"https://github.com/doczhcn","followers_url":"https://api.github.com/users/doczhcn/followers","following_url":"https://api.github.com/users/doczhcn/following{/other_user}","gists_url":"https://api.github.com/users/doczhcn/gists{/gist_id}","starred_url":"https://api.github.com/users/doczhcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doczhcn/subscriptions","organizations_url":"https://api.github.com/users/doczhcn/orgs","repos_url":"https://api.github.com/users/doczhcn/repos","events_url":"https://api.github.com/users/doczhcn/events{/privacy}","received_events_url":"https://api.github.com/users/doczhcn/received_events","type":"Organization","site_admin":false},"repo":{"id":101855207,"name":"istio","full_name":"doczhcn/istio","owner":{"login":"doczhcn","id":29801046,"avatar_url":"https://avatars2.githubusercontent.com/u/29801046?v=4","gravatar_id":"","url":"https://api.github.com/users/doczhcn","html_url":"https://github.com/doczhcn","followers_url":"https://api.github.com/users/doczhcn/followers","following_url":"https://api.github.com/users/doczhcn/following{/other_user}","gists_url":"https://api.github.com/users/doczhcn/gists{/gist_id}","starred_url":"https://api.github.com/users/doczhcn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doczhcn/subscriptions","organizations_url":"https://api.github.com/users/doczhcn/orgs","repos_url":"https://api.github.com/users/doczhcn/repos","events_url":"https://api.github.com/users/doczhcn/events{/privacy}","received_events_url":"https://api.github.com/users/doczhcn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doczhcn/istio","description":"Istio官方文档中文版","fork":false,"url":"https://api.github.com/repos/doczhcn/istio","forks_url":"https://api.github.com/repos/doczhcn/istio/forks","keys_url":"https://api.github.com/repos/doczhcn/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doczhcn/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doczhcn/istio/teams","hooks_url":"https://api.github.com/repos/doczhcn/istio/hooks","issue_events_url":"https://api.github.com/repos/doczhcn/istio/issues/events{/number}","events_url":"https://api.github.com/repos/doczhcn/istio/events","assignees_url":"https://api.github.com/repos/doczhcn/istio/assignees{/user}","branches_url":"https://api.github.com/repos/doczhcn/istio/branches{/branch}","tags_url":"https://api.github.com/repos/doczhcn/istio/tags","blobs_url":"https://api.github.com/repos/doczhcn/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doczhcn/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doczhcn/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/doczhcn/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doczhcn/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/doczhcn/istio/languages","stargazers_url":"https://api.github.com/repos/doczhcn/istio/stargazers","contributors_url":"https://api.github.com/repos/doczhcn/istio/contributors","subscribers_url":"https://api.github.com/repos/doczhcn/istio/subscribers","subscription_url":"https://api.github.com/repos/doczhcn/istio/subscription","commits_url":"https://api.github.com/repos/doczhcn/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/doczhcn/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/doczhcn/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/doczhcn/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/doczhcn/istio/contents/{+path}","compare_url":"https://api.github.com/repos/doczhcn/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doczhcn/istio/merges","archive_url":"https://api.github.com/repos/doczhcn/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doczhcn/istio/downloads","issues_url":"https://api.github.com/repos/doczhcn/istio/issues{/number}","pulls_url":"https://api.github.com/repos/doczhcn/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/doczhcn/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/doczhcn/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doczhcn/istio/labels{/name}","releases_url":"https://api.github.com/repos/doczhcn/istio/releases{/id}","deployments_url":"https://api.github.com/repos/doczhcn/istio/deployments","created_at":"2017-08-30T08:10:43Z","updated_at":"2017-10-25T03:08:09Z","pushed_at":"2017-10-25T01:58:16Z","git_url":"git://github.com/doczhcn/istio.git","ssh_url":"git@github.com:doczhcn/istio.git","clone_url":"https://github.com/doczhcn/istio.git","svn_url":"https://github.com/doczhcn/istio","homepage":"https://doczhcn.gitbooks.io/istio/","size":1073,"stargazers_count":26,"watchers_count":26,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":31,"forks":7,"open_issues":31,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/40"},"html":{"href":"https://github.com/doczhcn/istio/pull/40"},"issue":{"href":"https://api.github.com/repos/doczhcn/istio/issues/40"},"comments":{"href":"https://api.github.com/repos/doczhcn/istio/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doczhcn/istio/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/doczhcn/istio/statuses/9d6319f7051183cf1d3d504a608aad0180a2a9e6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101855207,
"name": "doczhcn/istio",
"url": "https://api.github.com/repos/doczhcn/istio"
}
|
{
"id": 1321762,
"login": "zhaohuabing",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1321762?",
"url": "https://api.github.com/users/zhaohuabing"
}
|
{
"id": 29801046,
"login": "doczhcn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29801046?",
"url": "https://api.github.com/orgs/doczhcn"
}
| 2017-10-25T03:15:16 |
6761664867
|
{"actor":{"display_login":"zhaohuabing"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/147243035","pull_request_review_id":72312855,"id":147243035,"diff_hunk":"@@ -0,0 +1,61 @@\n+/*******************************************************************************\r\n+* Copyright (c) 2017, 2017 IBM Corp. and others\r\n+*\r\n+* This program and the accompanying materials are made available under\r\n+* the terms of the Eclipse Public License 2.0 which accompanies this\r\n+* distribution and is available at http://eclipse.org/legal/epl-2.0\r\n+* or the Apache License, Version 2.0 which accompanies this distribution\r\n+* and is available at https://www.apache.org/licenses/LICENSE-2.0.\r\n+*\r\n+* This Source Code may also be made available under the following Secondary\r\n+* Licenses when the conditions for such availability set forth in the\r\n+* Eclipse Public License, v. 2.0 are satisfied: GNU General Public License,\r\n+* version 2 with the GNU Classpath Exception [1] and GNU General Public\r\n+* License, version 2 with the OpenJDK Assembly Exception [2].\r\n+*\r\n+* [1] https://www.gnu.org/software/classpath/license.html\r\n+* [2] http://openjdk.java.net/legal/assembly-exception.html\r\n+*\r\n+* SPDX-License-Identifier: EPL-2.0 OR Apache-2.0\r\n+*******************************************************************************/\r\n+\r\n+#include \"optimizer/RecognizedCallTransformer.hpp\"\r\n+\r\n+#include \"il/Node.hpp\"\r\n+#include \"il/Node_inlines.hpp\"\r\n+#include \"il/TreeTop.hpp\"\r\n+#include \"il/TreeTop_inlines.hpp\"\r\n+#include \"codegen/CodeGenerator.hpp\" // for CodeGenerator\r\n+#include \"il/ILOpCodes.hpp\"\r\n+#include \"il/ILOps.hpp\" // for ILOpCode, etc\r\n+#include \"ilgen/IlGenRequest.hpp\"\r\n+#include \"ilgen/IlGeneratorMethodDetails.hpp\"\r\n+#include \"ilgen/IlGeneratorMethodDetails_inlines.hpp\"\r\n+\r\n+TR::Optimization* OMR::RecognizedCallTransformer::create(TR::OptimizationManager *manager)\r\n+ {\r\n+ return new (manager->allocator()) TR::RecognizedCallTransformer(manager);\r\n+ }\r\n+\r\n+int32_t OMR::RecognizedCallTransformer::perform()\r\n+ {\r\n+ auto methodSymbol = comp()->getMethodSymbol();\r\n+ for (_treetop = methodSymbol->getFirstTreeTop(); _treetop != NULL; _treetop = _treetop->getNextTreeTop())\r\n+ {\r\n+ _node = treetop()->getNode()->getChild(0); // Get the first child of the tree\r","path":"compiler/optimizer/OMRRecognizedCallTransformer.cpp","position":null,"original_position":45,"commit_id":"b93dcdae79f542e70202713ac0f374848ab54fbe","original_commit_id":"e911033ff5a90f56d06958d78c9da4f65ff15aa0","user":{"login":"0dvictor","id":14084856,"avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"body":"Updated.","created_at":"2017-10-26T19:27:43Z","updated_at":"2017-10-26T19:27:43Z","html_url":"https://github.com/eclipse/omr/pull/1836#discussion_r147243035","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/1836","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/147243035"},"html":{"href":"https://github.com/eclipse/omr/pull/1836#discussion_r147243035"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1836"}},"in_reply_to_id":147134806},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/1836","id":148207070,"html_url":"https://github.com/eclipse/omr/pull/1836","diff_url":"https://github.com/eclipse/omr/pull/1836.diff","patch_url":"https://github.com/eclipse/omr/pull/1836.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/1836","number":1836,"state":"open","locked":false,"title":"Introducing Recognized Call Transformer","user":{"login":"0dvictor","id":14084856,"avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"body":"Recognized Call Transformer is a new optimization pass which\r\nprovides a unified place for downstream projects to convert\r\ncertain calls into ILOps and/or intrinsics.\r\n\r\nSigned-off-by: Victor Ding <dvictor@ca.ibm.com>","created_at":"2017-10-23T18:33:41Z","updated_at":"2017-10-26T19:27:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d9e63271f085931681340b5b40d84aade0bc828","assignee":{"login":"vijaysun-omr","id":22303775,"avatar_url":"https://avatars0.githubusercontent.com/u/22303775?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false},"assignees":[{"login":"vijaysun-omr","id":22303775,"avatar_url":"https://avatars0.githubusercontent.com/u/22303775?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaysun-omr","html_url":"https://github.com/vijaysun-omr","followers_url":"https://api.github.com/users/vijaysun-omr/followers","following_url":"https://api.github.com/users/vijaysun-omr/following{/other_user}","gists_url":"https://api.github.com/users/vijaysun-omr/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaysun-omr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaysun-omr/subscriptions","organizations_url":"https://api.github.com/users/vijaysun-omr/orgs","repos_url":"https://api.github.com/users/vijaysun-omr/repos","events_url":"https://api.github.com/users/vijaysun-omr/events{/privacy}","received_events_url":"https://api.github.com/users/vijaysun-omr/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/1836/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/1836/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/1836/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/b93dcdae79f542e70202713ac0f374848ab54fbe","head":{"label":"0dvictor:RCT","ref":"RCT","sha":"b93dcdae79f542e70202713ac0f374848ab54fbe","user":{"login":"0dvictor","id":14084856,"avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"repo":{"id":72220821,"name":"omr","full_name":"0dvictor/omr","owner":{"login":"0dvictor","id":14084856,"avatar_url":"https://avatars3.githubusercontent.com/u/14084856?v=4","gravatar_id":"","url":"https://api.github.com/users/0dvictor","html_url":"https://github.com/0dvictor","followers_url":"https://api.github.com/users/0dvictor/followers","following_url":"https://api.github.com/users/0dvictor/following{/other_user}","gists_url":"https://api.github.com/users/0dvictor/gists{/gist_id}","starred_url":"https://api.github.com/users/0dvictor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0dvictor/subscriptions","organizations_url":"https://api.github.com/users/0dvictor/orgs","repos_url":"https://api.github.com/users/0dvictor/repos","events_url":"https://api.github.com/users/0dvictor/events{/privacy}","received_events_url":"https://api.github.com/users/0dvictor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0dvictor/omr","description":"Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/0dvictor/omr","forks_url":"https://api.github.com/repos/0dvictor/omr/forks","keys_url":"https://api.github.com/repos/0dvictor/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0dvictor/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0dvictor/omr/teams","hooks_url":"https://api.github.com/repos/0dvictor/omr/hooks","issue_events_url":"https://api.github.com/repos/0dvictor/omr/issues/events{/number}","events_url":"https://api.github.com/repos/0dvictor/omr/events","assignees_url":"https://api.github.com/repos/0dvictor/omr/assignees{/user}","branches_url":"https://api.github.com/repos/0dvictor/omr/branches{/branch}","tags_url":"https://api.github.com/repos/0dvictor/omr/tags","blobs_url":"https://api.github.com/repos/0dvictor/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0dvictor/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0dvictor/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/0dvictor/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0dvictor/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/0dvictor/omr/languages","stargazers_url":"https://api.github.com/repos/0dvictor/omr/stargazers","contributors_url":"https://api.github.com/repos/0dvictor/omr/contributors","subscribers_url":"https://api.github.com/repos/0dvictor/omr/subscribers","subscription_url":"https://api.github.com/repos/0dvictor/omr/subscription","commits_url":"https://api.github.com/repos/0dvictor/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/0dvictor/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/0dvictor/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/0dvictor/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/0dvictor/omr/contents/{+path}","compare_url":"https://api.github.com/repos/0dvictor/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0dvictor/omr/merges","archive_url":"https://api.github.com/repos/0dvictor/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0dvictor/omr/downloads","issues_url":"https://api.github.com/repos/0dvictor/omr/issues{/number}","pulls_url":"https://api.github.com/repos/0dvictor/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/0dvictor/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/0dvictor/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0dvictor/omr/labels{/name}","releases_url":"https://api.github.com/repos/0dvictor/omr/releases{/id}","deployments_url":"https://api.github.com/repos/0dvictor/omr/deployments","created_at":"2016-10-28T15:47:22Z","updated_at":"2016-10-28T15:47:29Z","pushed_at":"2017-10-26T19:27:10Z","git_url":"git://github.com/0dvictor/omr.git","ssh_url":"git@github.com:0dvictor/omr.git","clone_url":"https://github.com/0dvictor/omr.git","svn_url":"https://github.com/0dvictor/omr","homepage":"","size":19151,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"470bcf78c72a72a2d71fef6f314ad28f3f338e13","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2017-10-26T11:39:40Z","pushed_at":"2017-10-26T19:27:12Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":19111,"stargazers_count":414,"watchers_count":414,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":285,"forks":167,"open_issues":285,"watchers":414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1836"},"html":{"href":"https://github.com/eclipse/omr/pull/1836"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/1836"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/1836/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1836/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/1836/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/b93dcdae79f542e70202713ac0f374848ab54fbe"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 53077478,
"name": "eclipse/omr",
"url": "https://api.github.com/repos/eclipse/omr"
}
|
{
"id": 14084856,
"login": "0dvictor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14084856?",
"url": "https://api.github.com/users/0dvictor"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2017-10-26T19:27:43 |
6771582911
|
{"actor":{"display_login":"0dvictor"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/winery/pulls/comments/104600764","pull_request_review_id":25443289,"id":104600764,"diff_hunk":"@@ -0,0 +1,61 @@\n+/*******************************************************************************\n+ * Copyright 2017 ZTE Corporation.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");","path":"org.eclipse.winery.bpmn4tosca.converter.tobpel/src/main/java/org/eclipse/winery/bpmn2bpel/model/GatewayBranch.java","position":4,"original_position":4,"commit_id":"538eb3734768c417bc2ca5f38fed7e2e18b3ac45","original_commit_id":"538eb3734768c417bc2ca5f38fed7e2e18b3ac45","user":{"login":"koppor","id":1366654,"avatar_url":"https://avatars3.githubusercontent.com/u/1366654?v=3","gravatar_id":"","url":"https://api.github.com/users/koppor","html_url":"https://github.com/koppor","followers_url":"https://api.github.com/users/koppor/followers","following_url":"https://api.github.com/users/koppor/following{/other_user}","gists_url":"https://api.github.com/users/koppor/gists{/gist_id}","starred_url":"https://api.github.com/users/koppor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koppor/subscriptions","organizations_url":"https://api.github.com/users/koppor/orgs","repos_url":"https://api.github.com/users/koppor/repos","events_url":"https://api.github.com/users/koppor/events{/privacy}","received_events_url":"https://api.github.com/users/koppor/received_events","type":"User","site_admin":false},"body":"No EPL here. Please addit.","created_at":"2017-03-07T07:06:39Z","updated_at":"2017-03-07T07:10:21Z","html_url":"https://github.com/eclipse/winery/pull/43#discussion_r104600764","pull_request_url":"https://api.github.com/repos/eclipse/winery/pulls/43","_links":{"self":{"href":"https://api.github.com/repos/eclipse/winery/pulls/comments/104600764"},"html":{"href":"https://github.com/eclipse/winery/pull/43#discussion_r104600764"},"pull_request":{"href":"https://api.github.com/repos/eclipse/winery/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/winery/pulls/43","id":107546907,"html_url":"https://github.com/eclipse/winery/pull/43","diff_url":"https://github.com/eclipse/winery/pull/43.diff","patch_url":"https://github.com/eclipse/winery/pull/43.patch","issue_url":"https://api.github.com/repos/eclipse/winery/issues/43","number":43,"state":"open","locked":false,"title":"add or-gateway support","user":{"login":"Lvbo163","id":23048127,"avatar_url":"https://avatars3.githubusercontent.com/u/23048127?v=3","gravatar_id":"","url":"https://api.github.com/users/Lvbo163","html_url":"https://github.com/Lvbo163","followers_url":"https://api.github.com/users/Lvbo163/followers","following_url":"https://api.github.com/users/Lvbo163/following{/other_user}","gists_url":"https://api.github.com/users/Lvbo163/gists{/gist_id}","starred_url":"https://api.github.com/users/Lvbo163/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lvbo163/subscriptions","organizations_url":"https://api.github.com/users/Lvbo163/orgs","repos_url":"https://api.github.com/users/Lvbo163/repos","events_url":"https://api.github.com/users/Lvbo163/events{/privacy}","received_events_url":"https://api.github.com/users/Lvbo163/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Lv Bo <lv.bo163@zte.com.cn>\r\n\r\n<!-- describe the changes you have made here: what, why, ... -->\r\n\r\n\r\n- [ ] Change in CHANGELOG.md described\r\n- [ ] Tests created for changes\r\n- [ ] Screenshots added (for UI changes)\r\n","created_at":"2017-02-23T03:09:20Z","updated_at":"2017-03-07T07:10:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f5ccc152a1e4c43158b0fc4afe24b8d25604e2e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/winery/pulls/43/commits","review_comments_url":"https://api.github.com/repos/eclipse/winery/pulls/43/comments","review_comment_url":"https://api.github.com/repos/eclipse/winery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/winery/issues/43/comments","statuses_url":"https://api.github.com/repos/eclipse/winery/statuses/538eb3734768c417bc2ca5f38fed7e2e18b3ac45","head":{"label":"ZTE:or-gateway","ref":"or-gateway","sha":"538eb3734768c417bc2ca5f38fed7e2e18b3ac45","user":{"login":"ZTE","id":25337368,"avatar_url":"https://avatars0.githubusercontent.com/u/25337368?v=3","gravatar_id":"","url":"https://api.github.com/users/ZTE","html_url":"https://github.com/ZTE","followers_url":"https://api.github.com/users/ZTE/followers","following_url":"https://api.github.com/users/ZTE/following{/other_user}","gists_url":"https://api.github.com/users/ZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/ZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZTE/subscriptions","organizations_url":"https://api.github.com/users/ZTE/orgs","repos_url":"https://api.github.com/users/ZTE/repos","events_url":"https://api.github.com/users/ZTE/events{/privacy}","received_events_url":"https://api.github.com/users/ZTE/received_events","type":"Organization","site_admin":false},"repo":{"id":80260739,"name":"winery","full_name":"ZTE/winery","owner":{"login":"ZTE","id":25337368,"avatar_url":"https://avatars0.githubusercontent.com/u/25337368?v=3","gravatar_id":"","url":"https://api.github.com/users/ZTE","html_url":"https://github.com/ZTE","followers_url":"https://api.github.com/users/ZTE/followers","following_url":"https://api.github.com/users/ZTE/following{/other_user}","gists_url":"https://api.github.com/users/ZTE/gists{/gist_id}","starred_url":"https://api.github.com/users/ZTE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZTE/subscriptions","organizations_url":"https://api.github.com/users/ZTE/orgs","repos_url":"https://api.github.com/users/ZTE/repos","events_url":"https://api.github.com/users/ZTE/events{/privacy}","received_events_url":"https://api.github.com/users/ZTE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ZTE/winery","description":"Winery project -","fork":true,"url":"https://api.github.com/repos/ZTE/winery","forks_url":"https://api.github.com/repos/ZTE/winery/forks","keys_url":"https://api.github.com/repos/ZTE/winery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZTE/winery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZTE/winery/teams","hooks_url":"https://api.github.com/repos/ZTE/winery/hooks","issue_events_url":"https://api.github.com/repos/ZTE/winery/issues/events{/number}","events_url":"https://api.github.com/repos/ZTE/winery/events","assignees_url":"https://api.github.com/repos/ZTE/winery/assignees{/user}","branches_url":"https://api.github.com/repos/ZTE/winery/branches{/branch}","tags_url":"https://api.github.com/repos/ZTE/winery/tags","blobs_url":"https://api.github.com/repos/ZTE/winery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZTE/winery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZTE/winery/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZTE/winery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZTE/winery/statuses/{sha}","languages_url":"https://api.github.com/repos/ZTE/winery/languages","stargazers_url":"https://api.github.com/repos/ZTE/winery/stargazers","contributors_url":"https://api.github.com/repos/ZTE/winery/contributors","subscribers_url":"https://api.github.com/repos/ZTE/winery/subscribers","subscription_url":"https://api.github.com/repos/ZTE/winery/subscription","commits_url":"https://api.github.com/repos/ZTE/winery/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZTE/winery/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZTE/winery/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZTE/winery/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZTE/winery/contents/{+path}","compare_url":"https://api.github.com/repos/ZTE/winery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZTE/winery/merges","archive_url":"https://api.github.com/repos/ZTE/winery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZTE/winery/downloads","issues_url":"https://api.github.com/repos/ZTE/winery/issues{/number}","pulls_url":"https://api.github.com/repos/ZTE/winery/pulls{/number}","milestones_url":"https://api.github.com/repos/ZTE/winery/milestones{/number}","notifications_url":"https://api.github.com/repos/ZTE/winery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZTE/winery/labels{/name}","releases_url":"https://api.github.com/repos/ZTE/winery/releases{/id}","deployments_url":"https://api.github.com/repos/ZTE/winery/deployments","created_at":"2017-01-28T01:54:39Z","updated_at":"2017-01-28T01:54:42Z","pushed_at":"2017-03-06T11:35:42Z","git_url":"git://github.com/ZTE/winery.git","ssh_url":"git@github.com:ZTE/winery.git","clone_url":"https://github.com/ZTE/winery.git","svn_url":"https://github.com/ZTE/winery","homepage":"https://eclipse.org/winery","size":2241,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"0186474dd0653faf02466b9a389c6a79767b2de1","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":42622157,"name":"winery","full_name":"eclipse/winery","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars2.githubusercontent.com/u/56974?v=3","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/winery","description":"Winery project -","fork":false,"url":"https://api.github.com/repos/eclipse/winery","forks_url":"https://api.github.com/repos/eclipse/winery/forks","keys_url":"https://api.github.com/repos/eclipse/winery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/winery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/winery/teams","hooks_url":"https://api.github.com/repos/eclipse/winery/hooks","issue_events_url":"https://api.github.com/repos/eclipse/winery/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/winery/events","assignees_url":"https://api.github.com/repos/eclipse/winery/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/winery/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/winery/tags","blobs_url":"https://api.github.com/repos/eclipse/winery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/winery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/winery/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/winery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/winery/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/winery/languages","stargazers_url":"https://api.github.com/repos/eclipse/winery/stargazers","contributors_url":"https://api.github.com/repos/eclipse/winery/contributors","subscribers_url":"https://api.github.com/repos/eclipse/winery/subscribers","subscription_url":"https://api.github.com/repos/eclipse/winery/subscription","commits_url":"https://api.github.com/repos/eclipse/winery/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/winery/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/winery/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/winery/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/winery/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/winery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/winery/merges","archive_url":"https://api.github.com/repos/eclipse/winery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/winery/downloads","issues_url":"https://api.github.com/repos/eclipse/winery/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/winery/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/winery/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/winery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/winery/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/winery/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/winery/deployments","created_at":"2015-09-17T00:31:44Z","updated_at":"2017-01-28T00:06:18Z","pushed_at":"2017-03-06T11:38:25Z","git_url":"git://github.com/eclipse/winery.git","ssh_url":"git@github.com:eclipse/winery.git","clone_url":"https://github.com/eclipse/winery.git","svn_url":"https://github.com/eclipse/winery","homepage":"https://eclipse.org/winery","size":2127,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":20,"forks":11,"open_issues":20,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/winery/pulls/43"},"html":{"href":"https://github.com/eclipse/winery/pull/43"},"issue":{"href":"https://api.github.com/repos/eclipse/winery/issues/43"},"comments":{"href":"https://api.github.com/repos/eclipse/winery/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/winery/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/winery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/winery/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/winery/statuses/538eb3734768c417bc2ca5f38fed7e2e18b3ac45"}}}}
|
{
"id": 42622157,
"name": "eclipse/winery",
"url": "https://api.github.com/repos/eclipse/winery"
}
|
{
"id": 1366654,
"login": "koppor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1366654?",
"url": "https://api.github.com/users/koppor"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2017-03-07T07:06:39 |
5445343670
|
{"actor":{"display_login":"koppor"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/113974461","pull_request_review_id":35410018,"id":113974461,"diff_hunk":"@@ -33,68 +33,59 @@ NOTE: In Elasticsearch releases 1.4.3 and later, this functionality requires you\n \n The availability of these options varies depending on the aggregation you choose.\n \n-=== Options\n+=== Metrics & Axes\n \n-Select the *Options* tab to change the way your data is visualized. Customization options are grouped into areas to provide easier access:\n+Select the *Metrics & Axes* tab to change the way each individual metric is shown on the chart. \n+The data series are styled in the _Metrics_ section, while the axes are styled in the X and Y axis sections.\n \n-==== General Settings\n+==== Metrics\n+Modify how each metric from the Data panel is visualized on the chart.\n \n-*Legend Position*:: Allows you to move your legend to the *left*, *right*, *top* or *bottom*\n-*Show Tooltip*:: Enables or disables the display of tooltip on hovering over chart objects\n-*Order buckets by descending sum*:: Check this box to enforce sorting of buckets by descending sum in the visualization\n+*Chart type*:: Choose between *Area*, *Line* and *Bar* types.\n+*Mode*:: stack the different metrics, or plot them next to each other \n+*Value Axis*:: choose the axis you want to plot this data too (the properties of each are configured under Y-axes).\n+*Line mode*:: should the outline of lines or bars appear *smooth*, *straight*, or *stepped*. \n+\n+==== Y-axis\n \n-==== Category Axis\n-The category axis is defined by the bucket aggregation you chose under Data tab. Here you can customize how its displayed:\n+Style up to two Y-axes.\n \n-*Show*:: You can chose if you want to display category axis or not\n-*Position*:: You can choose where you want to display category axis. If you position your category axis on the left or right the chart will turn to the horizontal type.\n+*Position*:: position of the Y-axis (*left* or *right* for vertical charts, and *top* or *bottom* for horizontal charts).\n+*Scale type*:: scaling of the values (*linear*, *log*, or *square root*)\n *Advanced Options*::\n *Labels - Show Labels*:::: Allows you to hide axis labels\n *Labels - Filter Labels*:::: If filter labels is enabled some labels will be hidden in case there is not enough space to display them\n *Labels - Rotate*:::: You can enter the number in degrees for how much you want to rotate labels\n *Labels - Truncate*:::: You can enter the size in pixels to which the label is truncated\n+*Scale to Data Bounds*:::: The default Y axis bounds are zero and the maximum value returned in the data. Check\n+ this box to change both upper and lower bounds to match the values returned in the data.\n+*Custom Extents*:::: You can define custom minimum and maximum for each axis\n \n-==== Grid\n-You can enable grid on the chart. By default grid is displayed on the category axis only.\n-\n-*Category Lines*:: You can disable the display of grid lines on category axis\n-*Value Axis*:: You can choose on which (if any) of the value axes you want to display grid lines\n-*Color*:: You can specify the color for gird lines \n-\n-==== Value Axes\n+==== X-Axis\n By default one value axis is defined on a chart, but you can add as much as you need. Clicking on the + sign will create a new value axis.\n \n-Each value axis has this options:\n-\n-*Show*:: You can decide to hide the value axis completely\n-*Label*:: Allows to define a custom label\n-*Position*:: Options for position depend on the position of your category axis. If category axis is positioned on the top or bottom you can position value axis on the left or right. In the opposite case you can position your value axis on the top or bottom.\n-*Mode*:: Mode allows you to define how value axis represents the values. You can choose among the following:\n-_wiggle_:::: Displays the aggregations as a https://en.wikipedia.org/wiki/Streamgraph[streamgraph].\n-_percentage_:::: Displays each aggregation as a proportion of the total.\n-_silhouette_:::: Displays each aggregation as variance from a central line.\n-*Scale Type*:: Allows you to choose between *linear*, *square root* and *log* scale\n-\n+*Position*:: position of the X-axis (*left* or *right* for horizontal charts, and *top* or *bottom* for vertical charts).","path":"docs/visualize/xychart.asciidoc","position":73,"original_position":73,"commit_id":"429ee50b06dd91cb6d3b78f9f0bdd7d0088a8733","original_commit_id":"429ee50b06dd91cb6d3b78f9f0bdd7d0088a8733","user":{"login":"tbragin","id":933397,"avatar_url":"https://avatars1.githubusercontent.com/u/933397?v=3","gravatar_id":"","url":"https://api.github.com/users/tbragin","html_url":"https://github.com/tbragin","followers_url":"https://api.github.com/users/tbragin/followers","following_url":"https://api.github.com/users/tbragin/following{/other_user}","gists_url":"https://api.github.com/users/tbragin/gists{/gist_id}","starred_url":"https://api.github.com/users/tbragin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbragin/subscriptions","organizations_url":"https://api.github.com/users/tbragin/orgs","repos_url":"https://api.github.com/users/tbragin/repos","events_url":"https://api.github.com/users/tbragin/events{/privacy}","received_events_url":"https://api.github.com/users/tbragin/received_events","type":"User","site_admin":false},"body":"X-Axis","created_at":"2017-04-28T16:56:24Z","updated_at":"2017-04-28T16:56:24Z","html_url":"https://github.com/elastic/kibana/pull/11426#discussion_r113974461","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/11426","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/113974461"},"html":{"href":"https://github.com/elastic/kibana/pull/11426#discussion_r113974461"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11426"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/11426","id":117594763,"html_url":"https://github.com/elastic/kibana/pull/11426","diff_url":"https://github.com/elastic/kibana/pull/11426.diff","patch_url":"https://github.com/elastic/kibana/pull/11426.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/11426","number":11426,"state":"open","locked":false,"title":"Visualization doc updates","user":{"login":"thomasneirynck","id":1833023,"avatar_url":"https://avatars1.githubusercontent.com/u/1833023?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasneirynck","html_url":"https://github.com/thomasneirynck","followers_url":"https://api.github.com/users/thomasneirynck/followers","following_url":"https://api.github.com/users/thomasneirynck/following{/other_user}","gists_url":"https://api.github.com/users/thomasneirynck/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasneirynck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasneirynck/subscriptions","organizations_url":"https://api.github.com/users/thomasneirynck/orgs","repos_url":"https://api.github.com/users/thomasneirynck/repos","events_url":"https://api.github.com/users/thomasneirynck/events{/privacy}","received_events_url":"https://api.github.com/users/thomasneirynck/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/elastic/kibana/issues/11244\r\n\r\n- rename xy charts to line, bar, area charts\r\n- organizes visualizations according to the landing page\r\n- organize point-series page to reflect panel-structure from kibana UI\r\n\r\n\r\ntodo:\r\n- [ ] add links to TSVB and timelion pages\r\n- [ ] update screenshots ","created_at":"2017-04-25T22:27:48Z","updated_at":"2017-04-28T16:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6a78b4237c42481e5962cfae5b4385398e9630a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/11426/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/11426/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/11426/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/429ee50b06dd91cb6d3b78f9f0bdd7d0088a8733","head":{"label":"thomasneirynck:docs/viz","ref":"docs/viz","sha":"429ee50b06dd91cb6d3b78f9f0bdd7d0088a8733","user":{"login":"thomasneirynck","id":1833023,"avatar_url":"https://avatars1.githubusercontent.com/u/1833023?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasneirynck","html_url":"https://github.com/thomasneirynck","followers_url":"https://api.github.com/users/thomasneirynck/followers","following_url":"https://api.github.com/users/thomasneirynck/following{/other_user}","gists_url":"https://api.github.com/users/thomasneirynck/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasneirynck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasneirynck/subscriptions","organizations_url":"https://api.github.com/users/thomasneirynck/orgs","repos_url":"https://api.github.com/users/thomasneirynck/repos","events_url":"https://api.github.com/users/thomasneirynck/events{/privacy}","received_events_url":"https://api.github.com/users/thomasneirynck/received_events","type":"User","site_admin":false},"repo":{"id":63882657,"name":"kibana","full_name":"thomasneirynck/kibana","owner":{"login":"thomasneirynck","id":1833023,"avatar_url":"https://avatars1.githubusercontent.com/u/1833023?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasneirynck","html_url":"https://github.com/thomasneirynck","followers_url":"https://api.github.com/users/thomasneirynck/followers","following_url":"https://api.github.com/users/thomasneirynck/following{/other_user}","gists_url":"https://api.github.com/users/thomasneirynck/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasneirynck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasneirynck/subscriptions","organizations_url":"https://api.github.com/users/thomasneirynck/orgs","repos_url":"https://api.github.com/users/thomasneirynck/repos","events_url":"https://api.github.com/users/thomasneirynck/events{/privacy}","received_events_url":"https://api.github.com/users/thomasneirynck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thomasneirynck/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/thomasneirynck/kibana","forks_url":"https://api.github.com/repos/thomasneirynck/kibana/forks","keys_url":"https://api.github.com/repos/thomasneirynck/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thomasneirynck/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thomasneirynck/kibana/teams","hooks_url":"https://api.github.com/repos/thomasneirynck/kibana/hooks","issue_events_url":"https://api.github.com/repos/thomasneirynck/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/thomasneirynck/kibana/events","assignees_url":"https://api.github.com/repos/thomasneirynck/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/thomasneirynck/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/thomasneirynck/kibana/tags","blobs_url":"https://api.github.com/repos/thomasneirynck/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thomasneirynck/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thomasneirynck/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/thomasneirynck/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thomasneirynck/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/thomasneirynck/kibana/languages","stargazers_url":"https://api.github.com/repos/thomasneirynck/kibana/stargazers","contributors_url":"https://api.github.com/repos/thomasneirynck/kibana/contributors","subscribers_url":"https://api.github.com/repos/thomasneirynck/kibana/subscribers","subscription_url":"https://api.github.com/repos/thomasneirynck/kibana/subscription","commits_url":"https://api.github.com/repos/thomasneirynck/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/thomasneirynck/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/thomasneirynck/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/thomasneirynck/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/thomasneirynck/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/thomasneirynck/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thomasneirynck/kibana/merges","archive_url":"https://api.github.com/repos/thomasneirynck/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thomasneirynck/kibana/downloads","issues_url":"https://api.github.com/repos/thomasneirynck/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/thomasneirynck/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/thomasneirynck/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/thomasneirynck/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thomasneirynck/kibana/labels{/name}","releases_url":"https://api.github.com/repos/thomasneirynck/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/thomasneirynck/kibana/deployments","created_at":"2016-07-21T15:51:25Z","updated_at":"2016-07-21T15:51:31Z","pushed_at":"2017-04-27T21:48:29Z","git_url":"git://github.com/thomasneirynck/kibana.git","ssh_url":"git@github.com:thomasneirynck/kibana.git","clone_url":"https://github.com/thomasneirynck/kibana.git","svn_url":"https://github.com/thomasneirynck/kibana","homepage":"https://www.elastic.co/products/kibana","size":262987,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"55ba578a1e3db619b62c64057b24d0e6ecdc84e9","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-04-28T14:39:59Z","pushed_at":"2017-04-28T16:56:07Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":254024,"stargazers_count":7199,"watchers_count":7199,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2721,"mirror_url":null,"open_issues_count":1595,"forks":2721,"open_issues":1595,"watchers":7199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11426"},"html":{"href":"https://github.com/elastic/kibana/pull/11426"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/11426"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/11426/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11426/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/11426/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/429ee50b06dd91cb6d3b78f9f0bdd7d0088a8733"}}}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 933397,
"login": "tbragin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/933397?",
"url": "https://api.github.com/users/tbragin"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2017-04-28T16:56:24 |
5778012607
|
{"actor":{"display_login":"tbragin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/123998937","pull_request_review_id":46241717,"id":123998937,"diff_hunk":"@@ -1,23 +1,43 @@\n-/* eslint-disable */\n+import React from 'react';\n \n-const $tabs = $('.kuiTab');\n-let $selectedTab = undefined;\n+import {\n+ KuiTabs\n+} from '../../../../components';\n \n-if (!$tabs.length) {\n- throw new Error('$tabs missing');\n-}\n+class KuiTabsExample extends React.Component {\n+ constructor(props) {\n+ super(props);\n+\n+ this.tabs = [\n+ 'Cobalt',\n+ 'Dextrose',\n+ 'Helium-3',\n+ 'Monosodium Glutamate',\n+ ];\n \n-function selectTab(tab) {\n- if ($selectedTab) {\n- $selectedTab.removeClass('kuiTab-isSelected');\n+ this.state = {\n+ selectedTabIndex: 0,\n+ };\n+\n+ this.onSelectedTabChanged = this.onSelectedTabChanged.bind(this);","path":"ui_framework/doc_site/src/views/tabs/tabs.js","position":31,"original_position":31,"commit_id":"51b12c0255063c2a75e7b385c039b577649268af","original_commit_id":"51b12c0255063c2a75e7b385c039b577649268af","user":{"login":"weltenwort","id":973741,"avatar_url":"https://avatars0.githubusercontent.com/u/973741?v=3","gravatar_id":"","url":"https://api.github.com/users/weltenwort","html_url":"https://github.com/weltenwort","followers_url":"https://api.github.com/users/weltenwort/followers","following_url":"https://api.github.com/users/weltenwort/following{/other_user}","gists_url":"https://api.github.com/users/weltenwort/gists{/gist_id}","starred_url":"https://api.github.com/users/weltenwort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weltenwort/subscriptions","organizations_url":"https://api.github.com/users/weltenwort/orgs","repos_url":"https://api.github.com/users/weltenwort/repos","events_url":"https://api.github.com/users/weltenwort/events{/privacy}","received_events_url":"https://api.github.com/users/weltenwort/received_events","type":"User","site_admin":false},"body":"We can get rid of this if we define `onSelectedTabChanged` like that:\r\n\r\n```javascript\r\nonSelectedTabChanged = (index) => {\r\n // ...\r\n}\r\n```","created_at":"2017-06-26T12:44:13Z","updated_at":"2017-06-26T12:45:44Z","html_url":"https://github.com/elastic/kibana/pull/12302#discussion_r123998937","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/12302","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/123998937"},"html":{"href":"https://github.com/elastic/kibana/pull/12302#discussion_r123998937"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12302"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/12302","id":125343510,"html_url":"https://github.com/elastic/kibana/pull/12302","diff_url":"https://github.com/elastic/kibana/pull/12302.diff","patch_url":"https://github.com/elastic/kibana/pull/12302.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/12302","number":12302,"state":"open","locked":false,"title":"[UI Framework] Reactify kuiTabs and related CSS components","user":{"login":"PopradiArpad","id":4144816,"avatar_url":"https://avatars0.githubusercontent.com/u/4144816?v=3","gravatar_id":"","url":"https://api.github.com/users/PopradiArpad","html_url":"https://github.com/PopradiArpad","followers_url":"https://api.github.com/users/PopradiArpad/followers","following_url":"https://api.github.com/users/PopradiArpad/following{/other_user}","gists_url":"https://api.github.com/users/PopradiArpad/gists{/gist_id}","starred_url":"https://api.github.com/users/PopradiArpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopradiArpad/subscriptions","organizations_url":"https://api.github.com/users/PopradiArpad/orgs","repos_url":"https://api.github.com/users/PopradiArpad/repos","events_url":"https://api.github.com/users/PopradiArpad/events{/privacy}","received_events_url":"https://api.github.com/users/PopradiArpad/received_events","type":"User","site_admin":false},"body":"Implement\r\n\r\n- KuiTabs\r\n- KuiTab\r\n\r\nand theirs test.\r\nUpdate docs examples.","created_at":"2017-06-13T11:47:36Z","updated_at":"2017-06-26T12:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f4530e788de58cc23c2120da336eabcd215aceb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/12302/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/12302/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/12302/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/51b12c0255063c2a75e7b385c039b577649268af","head":{"label":"PopradiArpad:uiframework/feature/reactify-tabs","ref":"uiframework/feature/reactify-tabs","sha":"51b12c0255063c2a75e7b385c039b577649268af","user":{"login":"PopradiArpad","id":4144816,"avatar_url":"https://avatars0.githubusercontent.com/u/4144816?v=3","gravatar_id":"","url":"https://api.github.com/users/PopradiArpad","html_url":"https://github.com/PopradiArpad","followers_url":"https://api.github.com/users/PopradiArpad/followers","following_url":"https://api.github.com/users/PopradiArpad/following{/other_user}","gists_url":"https://api.github.com/users/PopradiArpad/gists{/gist_id}","starred_url":"https://api.github.com/users/PopradiArpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopradiArpad/subscriptions","organizations_url":"https://api.github.com/users/PopradiArpad/orgs","repos_url":"https://api.github.com/users/PopradiArpad/repos","events_url":"https://api.github.com/users/PopradiArpad/events{/privacy}","received_events_url":"https://api.github.com/users/PopradiArpad/received_events","type":"User","site_admin":false},"repo":{"id":93143014,"name":"kibana","full_name":"PopradiArpad/kibana","owner":{"login":"PopradiArpad","id":4144816,"avatar_url":"https://avatars0.githubusercontent.com/u/4144816?v=3","gravatar_id":"","url":"https://api.github.com/users/PopradiArpad","html_url":"https://github.com/PopradiArpad","followers_url":"https://api.github.com/users/PopradiArpad/followers","following_url":"https://api.github.com/users/PopradiArpad/following{/other_user}","gists_url":"https://api.github.com/users/PopradiArpad/gists{/gist_id}","starred_url":"https://api.github.com/users/PopradiArpad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopradiArpad/subscriptions","organizations_url":"https://api.github.com/users/PopradiArpad/orgs","repos_url":"https://api.github.com/users/PopradiArpad/repos","events_url":"https://api.github.com/users/PopradiArpad/events{/privacy}","received_events_url":"https://api.github.com/users/PopradiArpad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PopradiArpad/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/PopradiArpad/kibana","forks_url":"https://api.github.com/repos/PopradiArpad/kibana/forks","keys_url":"https://api.github.com/repos/PopradiArpad/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopradiArpad/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopradiArpad/kibana/teams","hooks_url":"https://api.github.com/repos/PopradiArpad/kibana/hooks","issue_events_url":"https://api.github.com/repos/PopradiArpad/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/PopradiArpad/kibana/events","assignees_url":"https://api.github.com/repos/PopradiArpad/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/PopradiArpad/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/PopradiArpad/kibana/tags","blobs_url":"https://api.github.com/repos/PopradiArpad/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopradiArpad/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopradiArpad/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopradiArpad/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopradiArpad/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/PopradiArpad/kibana/languages","stargazers_url":"https://api.github.com/repos/PopradiArpad/kibana/stargazers","contributors_url":"https://api.github.com/repos/PopradiArpad/kibana/contributors","subscribers_url":"https://api.github.com/repos/PopradiArpad/kibana/subscribers","subscription_url":"https://api.github.com/repos/PopradiArpad/kibana/subscription","commits_url":"https://api.github.com/repos/PopradiArpad/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopradiArpad/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopradiArpad/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopradiArpad/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/PopradiArpad/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/PopradiArpad/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopradiArpad/kibana/merges","archive_url":"https://api.github.com/repos/PopradiArpad/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopradiArpad/kibana/downloads","issues_url":"https://api.github.com/repos/PopradiArpad/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/PopradiArpad/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/PopradiArpad/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/PopradiArpad/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopradiArpad/kibana/labels{/name}","releases_url":"https://api.github.com/repos/PopradiArpad/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/PopradiArpad/kibana/deployments","created_at":"2017-06-02T08:11:17Z","updated_at":"2017-06-02T08:11:25Z","pushed_at":"2017-06-25T11:11:07Z","git_url":"git://github.com/PopradiArpad/kibana.git","ssh_url":"git@github.com:PopradiArpad/kibana.git","clone_url":"https://github.com/PopradiArpad/kibana.git","svn_url":"https://github.com/PopradiArpad/kibana","homepage":"https://www.elastic.co/products/kibana","size":258394,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"37ece1c8d0ab33fdfc613b61c53ceba996534c9c","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-06-26T12:06:17Z","pushed_at":"2017-06-26T12:37:55Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":259474,"stargazers_count":7522,"watchers_count":7522,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2900,"mirror_url":null,"open_issues_count":1792,"forks":2900,"open_issues":1792,"watchers":7522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12302"},"html":{"href":"https://github.com/elastic/kibana/pull/12302"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/12302"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/12302/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12302/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12302/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/51b12c0255063c2a75e7b385c039b577649268af"}}}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 973741,
"login": "weltenwort",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/973741?",
"url": "https://api.github.com/users/weltenwort"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2017-06-26T12:44:13 |
6137595685
|
{"actor":{"display_login":"weltenwort"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/118722891","pull_request_review_id":40544827,"id":118722891,"diff_hunk":"@@ -4,18 +4,37 @@ export default function (kbnServer, server, config) {\n const disabled = config.get('server.xsrf.disableProtection');\n const versionHeader = 'kbn-version';\n const xsrfHeader = 'kbn-xsrf';\n+ const contentTypeHeader = 'content-type';\n+ const allowedRequestMediaTypes = ['application/json', 'application/x-ndjson'];\n \n server.ext('onPostAuth', function (req, reply) {\n if (disabled) {\n return reply.continue();\n }\n \n const isSafeMethod = req.method === 'get' || req.method === 'head';\n- const hasVersionHeader = versionHeader in req.headers;\n- const hasXsrfHeader = xsrfHeader in req.headers;\n+ if (!isSafeMethod) {\n+ const hasVersionHeader = versionHeader in req.headers;\n+ const hasXsrfHeader = xsrfHeader in req.headers;\n \n- if (!isSafeMethod && !hasVersionHeader && !hasXsrfHeader) {\n- return reply(badRequest(`Request must contain an ${xsrfHeader} header`));\n+ if (hasXsrfHeader || hasVersionHeader) {\n+ server.log(\n+ ['warning', 'deprecation'],\n+ `Both ${versionHeader} and ${xsrfHeader} headers are deprecated and not used for CSRF protection anymore. ` +\n+ `Please use proper ${contentTypeHeader} header instead.`\n+ );\n+ }\n+\n+ const hasContentTypeHeader = contentTypeHeader in req.headers;\n+ // Since we're only interested in media type let's extract it from the content type (\"media type [;parameter]\")\n+ // and leave leave off parameter portion (e.g. charset) of the header.\n+ const hasAllowedMediaType = hasContentTypeHeader && allowedRequestMediaTypes.includes(\n+ req.headers[contentTypeHeader].split(';')[0]\n+ );\n+\n+ if (!hasAllowedMediaType && !hasVersionHeader && !hasXsrfHeader) {\n+ return reply(badRequest(`Request must contain a proper ${contentTypeHeader} header.`));","path":"src/server/http/xsrf.js","position":37,"original_position":37,"commit_id":"3910ba66802eebf3cfb76efedab6d87b883c5823","original_commit_id":"3910ba66802eebf3cfb76efedab6d87b883c5823","user":{"login":"kjbekkelund","id":5259,"avatar_url":"https://avatars1.githubusercontent.com/u/5259?v=3","gravatar_id":"","url":"https://api.github.com/users/kjbekkelund","html_url":"https://github.com/kjbekkelund","followers_url":"https://api.github.com/users/kjbekkelund/followers","following_url":"https://api.github.com/users/kjbekkelund/following{/other_user}","gists_url":"https://api.github.com/users/kjbekkelund/gists{/gist_id}","starred_url":"https://api.github.com/users/kjbekkelund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjbekkelund/subscriptions","organizations_url":"https://api.github.com/users/kjbekkelund/orgs","repos_url":"https://api.github.com/users/kjbekkelund/repos","events_url":"https://api.github.com/users/kjbekkelund/events{/privacy}","received_events_url":"https://api.github.com/users/kjbekkelund/received_events","type":"User","site_admin":false},"body":"++ We should include both the allowed content-types and the received content type in the error message.","created_at":"2017-05-26T15:06:41Z","updated_at":"2017-05-26T15:06:42Z","html_url":"https://github.com/elastic/kibana/pull/12019#discussion_r118722891","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/12019","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/118722891"},"html":{"href":"https://github.com/elastic/kibana/pull/12019#discussion_r118722891"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12019"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/12019","id":122651086,"html_url":"https://github.com/elastic/kibana/pull/12019","diff_url":"https://github.com/elastic/kibana/pull/12019.diff","patch_url":"https://github.com/elastic/kibana/pull/12019.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/12019","number":12019,"state":"open","locked":false,"title":"[WIP] Use proper Content-Type request header instead of kbn-version and kbnx-srf for server CSRF check.","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars2.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"body":"Here is WIP PR that covers server side part of https://github.com/elastic/kibana/issues/11821","created_at":"2017-05-26T14:11:47Z","updated_at":"2017-05-26T15:06:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf6289528435e330838f6d04c92fd89d674406f7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/12019/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/12019/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/12019/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/3910ba66802eebf3cfb76efedab6d87b883c5823","head":{"label":"azasypkin:issue-11821-verify-content-type","ref":"issue-11821-verify-content-type","sha":"3910ba66802eebf3cfb76efedab6d87b883c5823","user":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars2.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"repo":{"id":92031734,"name":"kibana","full_name":"azasypkin/kibana","owner":{"login":"azasypkin","id":1713708,"avatar_url":"https://avatars2.githubusercontent.com/u/1713708?v=3","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/azasypkin/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/azasypkin/kibana","forks_url":"https://api.github.com/repos/azasypkin/kibana/forks","keys_url":"https://api.github.com/repos/azasypkin/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azasypkin/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azasypkin/kibana/teams","hooks_url":"https://api.github.com/repos/azasypkin/kibana/hooks","issue_events_url":"https://api.github.com/repos/azasypkin/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/azasypkin/kibana/events","assignees_url":"https://api.github.com/repos/azasypkin/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/azasypkin/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/azasypkin/kibana/tags","blobs_url":"https://api.github.com/repos/azasypkin/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azasypkin/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azasypkin/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/azasypkin/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azasypkin/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/azasypkin/kibana/languages","stargazers_url":"https://api.github.com/repos/azasypkin/kibana/stargazers","contributors_url":"https://api.github.com/repos/azasypkin/kibana/contributors","subscribers_url":"https://api.github.com/repos/azasypkin/kibana/subscribers","subscription_url":"https://api.github.com/repos/azasypkin/kibana/subscription","commits_url":"https://api.github.com/repos/azasypkin/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/azasypkin/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/azasypkin/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/azasypkin/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/azasypkin/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/azasypkin/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azasypkin/kibana/merges","archive_url":"https://api.github.com/repos/azasypkin/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azasypkin/kibana/downloads","issues_url":"https://api.github.com/repos/azasypkin/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/azasypkin/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/azasypkin/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/azasypkin/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azasypkin/kibana/labels{/name}","releases_url":"https://api.github.com/repos/azasypkin/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/azasypkin/kibana/deployments","created_at":"2017-05-22T08:45:03Z","updated_at":"2017-05-22T08:45:11Z","pushed_at":"2017-05-26T13:20:52Z","git_url":"git://github.com/azasypkin/kibana.git","ssh_url":"git@github.com:azasypkin/kibana.git","clone_url":"https://github.com/azasypkin/kibana.git","svn_url":"https://github.com/azasypkin/kibana","homepage":"https://www.elastic.co/products/kibana","size":257022,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"ee1178f2e4b28b6cb5f7ab3f389e1425a12543b9","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2017-05-26T15:03:36Z","pushed_at":"2017-05-26T14:11:48Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":257103,"stargazers_count":7354,"watchers_count":7354,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2803,"mirror_url":null,"open_issues_count":1701,"forks":2803,"open_issues":1701,"watchers":7354,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12019"},"html":{"href":"https://github.com/elastic/kibana/pull/12019"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/12019"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/12019/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12019/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/12019/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/3910ba66802eebf3cfb76efedab6d87b883c5823"}}}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 5259,
"login": "kjbekkelund",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5259?",
"url": "https://api.github.com/users/kjbekkelund"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2017-05-26T15:06:41 |
5949788006
|
{"actor":{"display_login":"kjbekkelund"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/125755334","pull_request_review_id":48176093,"id":125755334,"diff_hunk":"@@ -0,0 +1,80 @@\n+/*\n+ * Licensed to Elasticsearch under one or more contributor\n+ * license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright\n+ * ownership. Elasticsearch licenses this file to you under\n+ * the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package org.elasticsearch.rest;\n+\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.Optional;\n+import java.util.Set;\n+\n+/**\n+ * Encapsulate multiple handlers for the same path, allowing different handlers for different HTTP verbs.\n+ */\n+public class MethodHandlers {","path":"core/src/main/java/org/elasticsearch/rest/MethodHandlers.java","position":30,"original_position":30,"commit_id":"8837b87e3a80ec0364c1cacebefaa720227cde89","original_commit_id":"8837b87e3a80ec0364c1cacebefaa720227cde89","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"body":"Definitely can!","created_at":"2017-07-05T20:55:45Z","updated_at":"2017-07-05T20:55:45Z","html_url":"https://github.com/elastic/elasticsearch/pull/25459#discussion_r125755334","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/125755334"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25459#discussion_r125755334"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459","id":128039120,"html_url":"https://github.com/elastic/elasticsearch/pull/25459","diff_url":"https://github.com/elastic/elasticsearch/pull/25459.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/25459.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25459","number":25459,"state":"open","locked":false,"title":"Refactor PathTrie and RestController to use a single trie for all methods","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"body":"This changes `PathTrie` and `RestController` to use a single `PathTrie` for all\r\nendpoints, it also allows retrieving the endpoints' supported HTTP methods more\r\neasily.\r\n\r\nThis is a spin-off and prerequisite of #24437\r\n","created_at":"2017-06-28T23:09:03Z","updated_at":"2017-07-05T20:55:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8bf5afd9619f51a3c50e4a9413ac9fb4b0a3b1fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25459/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/8837b87e3a80ec0364c1cacebefaa720227cde89","head":{"label":"dakrone:path-trie-reorg","ref":"path-trie-reorg","sha":"8837b87e3a80ec0364c1cacebefaa720227cde89","user":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"repo":{"id":3037278,"name":"elasticsearch","full_name":"dakrone/elasticsearch","owner":{"login":"dakrone","id":19060,"avatar_url":"https://avatars0.githubusercontent.com/u/19060?v=3","gravatar_id":"","url":"https://api.github.com/users/dakrone","html_url":"https://github.com/dakrone","followers_url":"https://api.github.com/users/dakrone/followers","following_url":"https://api.github.com/users/dakrone/following{/other_user}","gists_url":"https://api.github.com/users/dakrone/gists{/gist_id}","starred_url":"https://api.github.com/users/dakrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dakrone/subscriptions","organizations_url":"https://api.github.com/users/dakrone/orgs","repos_url":"https://api.github.com/users/dakrone/repos","events_url":"https://api.github.com/users/dakrone/events{/privacy}","received_events_url":"https://api.github.com/users/dakrone/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dakrone/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/dakrone/elasticsearch","forks_url":"https://api.github.com/repos/dakrone/elasticsearch/forks","keys_url":"https://api.github.com/repos/dakrone/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dakrone/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dakrone/elasticsearch/teams","hooks_url":"https://api.github.com/repos/dakrone/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/dakrone/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/dakrone/elasticsearch/events","assignees_url":"https://api.github.com/repos/dakrone/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/dakrone/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/dakrone/elasticsearch/tags","blobs_url":"https://api.github.com/repos/dakrone/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dakrone/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dakrone/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/dakrone/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dakrone/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/dakrone/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/dakrone/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/dakrone/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/dakrone/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/dakrone/elasticsearch/subscription","commits_url":"https://api.github.com/repos/dakrone/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/dakrone/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/dakrone/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/dakrone/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/dakrone/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/dakrone/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dakrone/elasticsearch/merges","archive_url":"https://api.github.com/repos/dakrone/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dakrone/elasticsearch/downloads","issues_url":"https://api.github.com/repos/dakrone/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/dakrone/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/dakrone/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/dakrone/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dakrone/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/dakrone/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/dakrone/elasticsearch/deployments","created_at":"2011-12-22T23:14:00Z","updated_at":"2017-02-17T09:39:58Z","pushed_at":"2017-06-29T23:07:57Z","git_url":"git://github.com/dakrone/elasticsearch.git","ssh_url":"git@github.com:dakrone/elasticsearch.git","clone_url":"https://github.com/dakrone/elasticsearch.git","svn_url":"https://github.com/dakrone/elasticsearch","homepage":"http://elasticsearch.org","size":278647,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b18bfd6062f616da7443a7682f05eb8bbf598cee","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-07-05T20:30:20Z","pushed_at":"2017-07-05T20:52:47Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":355043,"stargazers_count":23579,"watchers_count":23579,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8337,"mirror_url":null,"open_issues_count":1305,"forks":8337,"open_issues":1305,"watchers":23579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25459"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25459"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25459/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25459/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/8837b87e3a80ec0364c1cacebefaa720227cde89"}}}}
|
{
"id": 507775,
"name": "elastic/elasticsearch",
"url": "https://api.github.com/repos/elastic/elasticsearch"
}
|
{
"id": 19060,
"login": "dakrone",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19060?",
"url": "https://api.github.com/users/dakrone"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2017-07-05T20:55:45 |
6199171827
|
{"actor":{"display_login":"dakrone"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/125839695","pull_request_review_id":48261881,"id":125839695,"diff_hunk":"@@ -222,325 +262,407 @@ synchronized void updateGlobalCheckpointOnReplica(final long globalCheckpoint) {\n this.globalCheckpoint = globalCheckpoint;\n logger.trace(\"global checkpoint updated from primary to [{}]\", globalCheckpoint);\n }\n+ assert invariant();\n }\n \n /**\n- * Notifies the service of the current allocation ids in the cluster state. This method trims any shards that have been removed.\n+ * Initializes the global checkpoint tracker in primary mode (see {@link #primaryMode}. Called on primary activation or promotion.\n+ */\n+ public synchronized void initializeAsPrimary(final String allocationId, final long localCheckpoint) {\n+ assert invariant();\n+ assert primaryMode == false;\n+ assert localCheckpoints.get(allocationId) != null && localCheckpoints.get(allocationId).inSync &&\n+ localCheckpoints.get(allocationId).localCheckPoint == SequenceNumbersService.UNASSIGNED_SEQ_NO;\n+ assert localCheckpoint >= SequenceNumbersService.NO_OPS_PERFORMED;\n+ primaryMode = true;\n+ updateLocalCheckpoint(allocationId, localCheckpoints.get(allocationId), localCheckpoint);\n+ updateGlobalCheckpointOnPrimary();\n+ assert invariant();\n+ }\n+\n+ /**\n+ * Notifies the tracker of the current allocation IDs in the cluster state.\n *\n * @param applyingClusterStateVersion the cluster state version being applied when updating the allocation IDs from the master\n- * @param activeAllocationIds the allocation IDs of the currently active shard copies\n+ * @param inSyncAllocationIds the allocation IDs of the currently in-sync shard copies\n * @param initializingAllocationIds the allocation IDs of the currently initializing shard copies\n+ * @param pre60AllocationIds the allocation IDs of shards that are allocated to pre-6.0 nodes\n */\n- public synchronized void updateAllocationIdsFromMaster(\n- final long applyingClusterStateVersion, final Set<String> activeAllocationIds, final Set<String> initializingAllocationIds) {\n- if (applyingClusterStateVersion < appliedClusterStateVersion) {\n- return;\n- }\n-\n- appliedClusterStateVersion = applyingClusterStateVersion;\n-\n- // remove shards whose allocation ID no longer exists\n- inSyncLocalCheckpoints.removeAll(a -> !activeAllocationIds.contains(a) && !initializingAllocationIds.contains(a));\n-\n- // add any new active allocation IDs\n- for (final String a : activeAllocationIds) {\n- if (!inSyncLocalCheckpoints.containsKey(a)) {\n- final long localCheckpoint = trackingLocalCheckpoints.getOrDefault(a, SequenceNumbersService.UNASSIGNED_SEQ_NO);\n- inSyncLocalCheckpoints.put(a, localCheckpoint);\n- logger.trace(\"marked [{}] as in-sync with local checkpoint [{}] via cluster state update from master\", a, localCheckpoint);\n- }\n- }\n-\n- trackingLocalCheckpoints.removeAll(a -> !initializingAllocationIds.contains(a));\n- for (final String a : initializingAllocationIds) {\n- if (inSyncLocalCheckpoints.containsKey(a)) {\n- /*\n- * This can happen if we mark the allocation ID as in sync at the end of recovery before seeing a cluster state update from\n- * marking the shard as active.\n- */\n- continue;\n+ public synchronized void updateFromMaster(final long applyingClusterStateVersion, final Set<String> inSyncAllocationIds,\n+ final Set<String> initializingAllocationIds, final Set<String> pre60AllocationIds) {\n+ assert invariant();\n+ if (applyingClusterStateVersion > appliedClusterStateVersion) {\n+ // check that the master does not fabricate new in-sync entries out of thin air once we are in primary mode\n+ assert !primaryMode || inSyncAllocationIds.stream().allMatch(\n+ inSyncId -> localCheckpoints.containsKey(inSyncId) && localCheckpoints.get(inSyncId).inSync);\n+ // remove entries which don't exist on master\n+ boolean removedEntries = localCheckpoints.keySet().removeIf(\n+ aid -> !inSyncAllocationIds.contains(aid) && !initializingAllocationIds.contains(aid));\n+\n+ if (primaryMode) {\n+ // add new initializingIds that are missing locally. These are fresh shard copies - and not in-sync\n+ for (String initializingId : initializingAllocationIds) {\n+ if (localCheckpoints.containsKey(initializingId) == false) {\n+ final boolean inSync = inSyncAllocationIds.contains(initializingId);\n+ assert inSync == false;\n+ final long localCheckpoint = pre60AllocationIds.contains(initializingId) ?\n+ SequenceNumbersService.PRE_60_NODE_LOCAL_CHECKPOINT : SequenceNumbersService.UNASSIGNED_SEQ_NO;\n+ localCheckpoints.put(initializingId, new LocalCheckPointState(localCheckpoint, inSync));\n+ }\n+ }\n+ } else {\n+ for (String initializingId : initializingAllocationIds) {\n+ final long localCheckpoint = pre60AllocationIds.contains(initializingId) ?\n+ SequenceNumbersService.PRE_60_NODE_LOCAL_CHECKPOINT : SequenceNumbersService.UNASSIGNED_SEQ_NO;\n+ localCheckpoints.put(initializingId, new LocalCheckPointState(localCheckpoint, false));\n+ }\n+ for (String inSyncId : inSyncAllocationIds) {\n+ final long localCheckpoint = pre60AllocationIds.contains(inSyncId) ?\n+ SequenceNumbersService.PRE_60_NODE_LOCAL_CHECKPOINT : SequenceNumbersService.UNASSIGNED_SEQ_NO;\n+ localCheckpoints.put(inSyncId, new LocalCheckPointState(localCheckpoint, true));\n+ }\n }\n- if (trackingLocalCheckpoints.containsKey(a)) {\n- // we are already tracking this allocation ID\n- continue;\n+ appliedClusterStateVersion = applyingClusterStateVersion;\n+ if (primaryMode && removedEntries) {\n+ updateGlobalCheckpointOnPrimary();\n }\n- // this is a new allocation ID\n- trackingLocalCheckpoints.put(a, SequenceNumbersService.UNASSIGNED_SEQ_NO);\n- logger.trace(\"tracking [{}] via cluster state update from master\", a);\n }\n-\n- updateGlobalCheckpointOnPrimary();\n+ assert invariant();\n }\n \n /**\n- * Get the primary context for the shard. This includes the state of the global checkpoint tracker.\n+ * Called when the recovery process for a shard is ready to open the engine on the target shard. Ensures that the right data structures\n+ * have been set up locally to track local checkpoint information for the shard.\n *\n- * @return the primary context\n+ * @param allocationId the allocation ID of the shard for which recovery was initiated\n */\n- synchronized PrimaryContext primaryContext() {\n- if (sealed) {\n- throw new IllegalStateException(\"global checkpoint tracker is sealed\");\n+ public synchronized void initiateTracking(final String allocationId) {\n+ assert invariant();\n+ assert primaryMode;\n+ LocalCheckPointState lcps = localCheckpoints.get(allocationId);\n+ if (lcps == null) {\n+ // can happen if replica was removed from cluster but recovery process is unaware of it yet\n+ throw new IllegalStateException(\"no local checkpoint tracking information available\");\n }\n- sealed = true;\n- final ObjectLongMap<String> inSyncLocalCheckpoints = new ObjectLongHashMap<>(this.inSyncLocalCheckpoints);\n- final ObjectLongMap<String> trackingLocalCheckpoints = new ObjectLongHashMap<>(this.trackingLocalCheckpoints);\n- return new PrimaryContext(appliedClusterStateVersion, inSyncLocalCheckpoints, trackingLocalCheckpoints);\n+ assert invariant();\n }\n \n /**\n- * Releases a previously acquired primary context.\n+ * Marks the shard with the provided allocation ID as in-sync with the primary shard. This method will block until the local checkpoint\n+ * on the specified shard advances above the current global checkpoint.\n+ *\n+ * @param allocationId the allocation ID of the shard to mark as in-sync\n+ * @param localCheckpoint the current local checkpoint on the shard\n */\n- synchronized void releasePrimaryContext() {\n- assert sealed;\n- sealed = false;\n+ public synchronized void markAllocationIdAsInSync(final String allocationId, final long localCheckpoint) throws InterruptedException {\n+ assert invariant();\n+ assert primaryMode;\n+ assert handOffInProgress == false;\n+ LocalCheckPointState lcps = localCheckpoints.get(allocationId);\n+ if (lcps == null) {\n+ // can happen if replica was removed from cluster but recovery process is unaware of it yet\n+ throw new IllegalStateException(\"no local checkpoint tracking information available\");\n+ }\n+ assert pendingInSync.contains(allocationId) == false;\n+ updateLocalCheckpoint(allocationId, lcps, localCheckpoint);\n+ // if it was already in-sync (because of a previously failed recovery attempt), global checkpoint must have been\n+ // stuck from advancing\n+ assert !lcps.inSync || (lcps.localCheckPoint >= globalCheckpoint);","path":"core/src/main/java/org/elasticsearch/index/seqno/GlobalCheckpointTracker.java","position":519,"original_position":519,"commit_id":"f413758cd2ff1dd7111ffa89fdec0e14925ad9f0","original_commit_id":"f413758cd2ff1dd7111ffa89fdec0e14925ad9f0","user":{"login":"bleskes","id":1006375,"avatar_url":"https://avatars2.githubusercontent.com/u/1006375?v=3","gravatar_id":"","url":"https://api.github.com/users/bleskes","html_url":"https://github.com/bleskes","followers_url":"https://api.github.com/users/bleskes/followers","following_url":"https://api.github.com/users/bleskes/following{/other_user}","gists_url":"https://api.github.com/users/bleskes/gists{/gist_id}","starred_url":"https://api.github.com/users/bleskes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleskes/subscriptions","organizations_url":"https://api.github.com/users/bleskes/orgs","repos_url":"https://api.github.com/users/bleskes/repos","events_url":"https://api.github.com/users/bleskes/events{/privacy}","received_events_url":"https://api.github.com/users/bleskes/received_events","type":"User","site_admin":false},"body":"can we add a message with the local checkpoint, the aid and the global checkpoint?","created_at":"2017-07-06T08:29:38Z","updated_at":"2017-07-06T09:02:06Z","html_url":"https://github.com/elastic/elasticsearch/pull/25468#discussion_r125839695","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/125839695"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25468#discussion_r125839695"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468","id":128114734,"html_url":"https://github.com/elastic/elasticsearch/pull/25468","diff_url":"https://github.com/elastic/elasticsearch/pull/25468.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/25468.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25468","number":25468,"state":"open","locked":false,"title":"Introduce primary/replica mode for GlobalCheckPointTracker","user":{"login":"ywelsch","id":3718355,"avatar_url":"https://avatars0.githubusercontent.com/u/3718355?v=3","gravatar_id":"","url":"https://api.github.com/users/ywelsch","html_url":"https://github.com/ywelsch","followers_url":"https://api.github.com/users/ywelsch/followers","following_url":"https://api.github.com/users/ywelsch/following{/other_user}","gists_url":"https://api.github.com/users/ywelsch/gists{/gist_id}","starred_url":"https://api.github.com/users/ywelsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywelsch/subscriptions","organizations_url":"https://api.github.com/users/ywelsch/orgs","repos_url":"https://api.github.com/users/ywelsch/repos","events_url":"https://api.github.com/users/ywelsch/events{/privacy}","received_events_url":"https://api.github.com/users/ywelsch/received_events","type":"User","site_admin":false},"body":"This PR refactors the GlobalCheckPointTracker to make it more resilient. The main idea is to make it more explicit what state is actually captured and how that state is updated through replication / cluster state updates etc. It also fixes the issue where the local checkpoint information is not being updated when a shard becomes primary. The primary relocation handoff becomes very simple too, we can just verbatim copy over the internal state.\r\n\r\nThe PR still misses some tests, which I will address soon. The main reason for opening it as is to get initial feedback.","created_at":"2017-06-29T10:10:40Z","updated_at":"2017-07-06T09:02:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae014bd5be860ceaa88f7962cd245253497bcd55","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jasontedor","id":4744941,"avatar_url":"https://avatars0.githubusercontent.com/u/4744941?v=3","gravatar_id":"","url":"https://api.github.com/users/jasontedor","html_url":"https://github.com/jasontedor","followers_url":"https://api.github.com/users/jasontedor/followers","following_url":"https://api.github.com/users/jasontedor/following{/other_user}","gists_url":"https://api.github.com/users/jasontedor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasontedor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasontedor/subscriptions","organizations_url":"https://api.github.com/users/jasontedor/orgs","repos_url":"https://api.github.com/users/jasontedor/repos","events_url":"https://api.github.com/users/jasontedor/events{/privacy}","received_events_url":"https://api.github.com/users/jasontedor/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25468/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/f413758cd2ff1dd7111ffa89fdec0e14925ad9f0","head":{"label":"ywelsch:enhance/harden-globalcheckpoint-tracker","ref":"enhance/harden-globalcheckpoint-tracker","sha":"f413758cd2ff1dd7111ffa89fdec0e14925ad9f0","user":{"login":"ywelsch","id":3718355,"avatar_url":"https://avatars0.githubusercontent.com/u/3718355?v=3","gravatar_id":"","url":"https://api.github.com/users/ywelsch","html_url":"https://github.com/ywelsch","followers_url":"https://api.github.com/users/ywelsch/followers","following_url":"https://api.github.com/users/ywelsch/following{/other_user}","gists_url":"https://api.github.com/users/ywelsch/gists{/gist_id}","starred_url":"https://api.github.com/users/ywelsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywelsch/subscriptions","organizations_url":"https://api.github.com/users/ywelsch/orgs","repos_url":"https://api.github.com/users/ywelsch/repos","events_url":"https://api.github.com/users/ywelsch/events{/privacy}","received_events_url":"https://api.github.com/users/ywelsch/received_events","type":"User","site_admin":false},"repo":{"id":43299643,"name":"elasticsearch","full_name":"ywelsch/elasticsearch","owner":{"login":"ywelsch","id":3718355,"avatar_url":"https://avatars0.githubusercontent.com/u/3718355?v=3","gravatar_id":"","url":"https://api.github.com/users/ywelsch","html_url":"https://github.com/ywelsch","followers_url":"https://api.github.com/users/ywelsch/followers","following_url":"https://api.github.com/users/ywelsch/following{/other_user}","gists_url":"https://api.github.com/users/ywelsch/gists{/gist_id}","starred_url":"https://api.github.com/users/ywelsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywelsch/subscriptions","organizations_url":"https://api.github.com/users/ywelsch/orgs","repos_url":"https://api.github.com/users/ywelsch/repos","events_url":"https://api.github.com/users/ywelsch/events{/privacy}","received_events_url":"https://api.github.com/users/ywelsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ywelsch/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/ywelsch/elasticsearch","forks_url":"https://api.github.com/repos/ywelsch/elasticsearch/forks","keys_url":"https://api.github.com/repos/ywelsch/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywelsch/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywelsch/elasticsearch/teams","hooks_url":"https://api.github.com/repos/ywelsch/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/ywelsch/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/ywelsch/elasticsearch/events","assignees_url":"https://api.github.com/repos/ywelsch/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/ywelsch/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/ywelsch/elasticsearch/tags","blobs_url":"https://api.github.com/repos/ywelsch/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywelsch/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywelsch/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywelsch/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywelsch/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/ywelsch/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/ywelsch/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/ywelsch/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/ywelsch/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/ywelsch/elasticsearch/subscription","commits_url":"https://api.github.com/repos/ywelsch/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywelsch/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywelsch/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywelsch/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywelsch/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/ywelsch/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywelsch/elasticsearch/merges","archive_url":"https://api.github.com/repos/ywelsch/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywelsch/elasticsearch/downloads","issues_url":"https://api.github.com/repos/ywelsch/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/ywelsch/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/ywelsch/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/ywelsch/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywelsch/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/ywelsch/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/ywelsch/elasticsearch/deployments","created_at":"2015-09-28T12:30:36Z","updated_at":"2016-08-12T13:51:10Z","pushed_at":"2017-07-05T07:51:50Z","git_url":"git://github.com/ywelsch/elasticsearch.git","ssh_url":"git@github.com:ywelsch/elasticsearch.git","clone_url":"https://github.com/ywelsch/elasticsearch.git","svn_url":"https://github.com/ywelsch/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":342780,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"bb23d3b2c5c9be8026705dd24229ebabf2935775","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-07-06T09:00:02Z","pushed_at":"2017-07-06T08:53:57Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":355120,"stargazers_count":23596,"watchers_count":23596,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8340,"mirror_url":null,"open_issues_count":1305,"forks":8340,"open_issues":1305,"watchers":23596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25468"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25468"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25468/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25468/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/f413758cd2ff1dd7111ffa89fdec0e14925ad9f0"}}}}
|
{
"id": 507775,
"name": "elastic/elasticsearch",
"url": "https://api.github.com/repos/elastic/elasticsearch"
}
|
{
"id": 1006375,
"login": "bleskes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1006375?",
"url": "https://api.github.com/users/bleskes"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2017-07-06T08:29:38 |
6202363265
|
{"actor":{"display_login":"bleskes"}}
|