type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/comments/266216028","pull_request_review_id":215330779,"id":266216028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjIxNjAyOA==","diff_hunk":"@@ -0,0 +1,117 @@\n+val scan = java.util.Scanner(System.`in`)\n+\n+const val INF = 1000001\n+\n+fun addGraph(size: Int, numOfEdges: Int): Array<Array<Int>>{\n+\n+ val matrix: Array<Array<Int>> = Array(size) {Array(size) {0}}\n+ var i = 0\n+\n+ while(i != numOfEdges) {\n+ val rnd1 = (0..(size - 1)).random()\n+ val rnd2 = (0..(size - 1)).random()\n+ val value = (1..99).random()\n+ if ((matrix[rnd1][rnd2] == 0) && (rnd1 != rnd2)) {\n+ matrix[rnd1][rnd2] = value\n+ matrix[rnd2][rnd1] = value\n+ i++\n+ }\n+ }\n+\n+ return matrix\n+}\n+\n+fun printInformationAboutGraph(matrix: Array<Array<Int>>){\n+\n+ println(\"Num of vertices = ${matrix.size}\")\n+\n+ var numOfEdges = 0\n+ for(i in 0..(matrix.size - 1)){","path":"Task01/Task01.kt","position":29,"original_position":29,"commit_id":"e0655ce03882c3949e8c8d0e3740765743c7e7c4","original_commit_id":"e0655ce03882c3949e8c8d0e3740765743c7e7c4","user":{"login":"EgorkaKulikov","id":29856383,"node_id":"MDQ6VXNlcjI5ODU2Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/29856383?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorkaKulikov","html_url":"https://github.com/EgorkaKulikov","followers_url":"https://api.github.com/users/EgorkaKulikov/followers","following_url":"https://api.github.com/users/EgorkaKulikov/following{/other_user}","gists_url":"https://api.github.com/users/EgorkaKulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorkaKulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorkaKulikov/subscriptions","organizations_url":"https://api.github.com/users/EgorkaKulikov/orgs","repos_url":"https://api.github.com/users/EgorkaKulikov/repos","events_url":"https://api.github.com/users/EgorkaKulikov/events{/privacy}","received_events_url":"https://api.github.com/users/EgorkaKulikov/received_events","type":"User","site_admin":false},"body":"until","created_at":"2019-03-16T21:39:02Z","updated_at":"2019-03-16T21:45:06Z","html_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9#discussion_r266216028","pull_request_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/comments/266216028"},"html":{"href":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9#discussion_r266216028"},"pull_request":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9","id":260743388,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNzQzMzg4","html_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9","diff_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9.diff","patch_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9.patch","issue_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/9","number":9,"state":"open","locked":false,"title":"Task01_Konnov","user":{"login":"KirillKonnov","id":43007860,"node_id":"MDQ6VXNlcjQzMDA3ODYw","avatar_url":"https://avatars1.githubusercontent.com/u/43007860?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillKonnov","html_url":"https://github.com/KirillKonnov","followers_url":"https://api.github.com/users/KirillKonnov/followers","following_url":"https://api.github.com/users/KirillKonnov/following{/other_user}","gists_url":"https://api.github.com/users/KirillKonnov/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillKonnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillKonnov/subscriptions","organizations_url":"https://api.github.com/users/KirillKonnov/orgs","repos_url":"https://api.github.com/users/KirillKonnov/repos","events_url":"https://api.github.com/users/KirillKonnov/events{/privacy}","received_events_url":"https://api.github.com/users/KirillKonnov/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-13T12:22:52Z","updated_at":"2019-03-16T21:45:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25e9aa35a90f65984e53385b1130d0e23433a131","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9/commits","review_comments_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9/comments","review_comment_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/9/comments","statuses_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/statuses/e0655ce03882c3949e8c8d0e3740765743c7e7c4","head":{"label":"KirillKonnov:Konnov","ref":"Konnov","sha":"e0655ce03882c3949e8c8d0e3740765743c7e7c4","user":{"login":"KirillKonnov","id":43007860,"node_id":"MDQ6VXNlcjQzMDA3ODYw","avatar_url":"https://avatars1.githubusercontent.com/u/43007860?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillKonnov","html_url":"https://github.com/KirillKonnov","followers_url":"https://api.github.com/users/KirillKonnov/followers","following_url":"https://api.github.com/users/KirillKonnov/following{/other_user}","gists_url":"https://api.github.com/users/KirillKonnov/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillKonnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillKonnov/subscriptions","organizations_url":"https://api.github.com/users/KirillKonnov/orgs","repos_url":"https://api.github.com/users/KirillKonnov/repos","events_url":"https://api.github.com/users/KirillKonnov/events{/privacy}","received_events_url":"https://api.github.com/users/KirillKonnov/received_events","type":"User","site_admin":false},"repo":{"id":175409853,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU0MDk4NTM=","name":"spbu-se2019-spring","full_name":"KirillKonnov/spbu-se2019-spring","private":false,"owner":{"login":"KirillKonnov","id":43007860,"node_id":"MDQ6VXNlcjQzMDA3ODYw","avatar_url":"https://avatars1.githubusercontent.com/u/43007860?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillKonnov","html_url":"https://github.com/KirillKonnov","followers_url":"https://api.github.com/users/KirillKonnov/followers","following_url":"https://api.github.com/users/KirillKonnov/following{/other_user}","gists_url":"https://api.github.com/users/KirillKonnov/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillKonnov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillKonnov/subscriptions","organizations_url":"https://api.github.com/users/KirillKonnov/orgs","repos_url":"https://api.github.com/users/KirillKonnov/repos","events_url":"https://api.github.com/users/KirillKonnov/events{/privacy}","received_events_url":"https://api.github.com/users/KirillKonnov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KirillKonnov/spbu-se2019-spring","description":null,"fork":true,"url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring","forks_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/forks","keys_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/teams","hooks_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/hooks","issue_events_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/issues/events{/number}","events_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/events","assignees_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/assignees{/user}","branches_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/branches{/branch}","tags_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/tags","blobs_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/languages","stargazers_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/stargazers","contributors_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/contributors","subscribers_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/subscribers","subscription_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/subscription","commits_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/contents/{+path}","compare_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/merges","archive_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/downloads","issues_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/issues{/number}","pulls_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/labels{/name}","releases_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/releases{/id}","deployments_url":"https://api.github.com/repos/KirillKonnov/spbu-se2019-spring/deployments","created_at":"2019-03-13T11:45:33Z","updated_at":"2019-03-13T11:45:35Z","pushed_at":"2019-03-13T11:54:44Z","git_url":"git://github.com/KirillKonnov/spbu-se2019-spring.git","ssh_url":"git@github.com:KirillKonnov/spbu-se2019-spring.git","clone_url":"https://github.com/KirillKonnov/spbu-se2019-spring.git","svn_url":"https://github.com/KirillKonnov/spbu-se2019-spring","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EgorkaKulikov:Konnov","ref":"Konnov","sha":"e1dc0792bf36e86c7def2df131bc751947aa5b37","user":{"login":"EgorkaKulikov","id":29856383,"node_id":"MDQ6VXNlcjI5ODU2Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/29856383?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorkaKulikov","html_url":"https://github.com/EgorkaKulikov","followers_url":"https://api.github.com/users/EgorkaKulikov/followers","following_url":"https://api.github.com/users/EgorkaKulikov/following{/other_user}","gists_url":"https://api.github.com/users/EgorkaKulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorkaKulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorkaKulikov/subscriptions","organizations_url":"https://api.github.com/users/EgorkaKulikov/orgs","repos_url":"https://api.github.com/users/EgorkaKulikov/repos","events_url":"https://api.github.com/users/EgorkaKulikov/events{/privacy}","received_events_url":"https://api.github.com/users/EgorkaKulikov/received_events","type":"User","site_admin":false},"repo":{"id":174021121,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQwMjExMjE=","name":"spbu-se2019-spring","full_name":"EgorkaKulikov/spbu-se2019-spring","private":false,"owner":{"login":"EgorkaKulikov","id":29856383,"node_id":"MDQ6VXNlcjI5ODU2Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/29856383?v=4","gravatar_id":"","url":"https://api.github.com/users/EgorkaKulikov","html_url":"https://github.com/EgorkaKulikov","followers_url":"https://api.github.com/users/EgorkaKulikov/followers","following_url":"https://api.github.com/users/EgorkaKulikov/following{/other_user}","gists_url":"https://api.github.com/users/EgorkaKulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/EgorkaKulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EgorkaKulikov/subscriptions","organizations_url":"https://api.github.com/users/EgorkaKulikov/orgs","repos_url":"https://api.github.com/users/EgorkaKulikov/repos","events_url":"https://api.github.com/users/EgorkaKulikov/events{/privacy}","received_events_url":"https://api.github.com/users/EgorkaKulikov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring","description":null,"fork":false,"url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring","forks_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/forks","keys_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/teams","hooks_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/hooks","issue_events_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/events{/number}","events_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/events","assignees_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/assignees{/user}","branches_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/branches{/branch}","tags_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/tags","blobs_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/git/refs{/sha}","trees_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/statuses/{sha}","languages_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/languages","stargazers_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/stargazers","contributors_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/contributors","subscribers_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/subscribers","subscription_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/subscription","commits_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/commits{/sha}","git_commits_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/git/commits{/sha}","comments_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/comments{/number}","issue_comment_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/comments{/number}","contents_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/contents/{+path}","compare_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/merges","archive_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/downloads","issues_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues{/number}","pulls_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls{/number}","milestones_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/milestones{/number}","notifications_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/labels{/name}","releases_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/releases{/id}","deployments_url":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/deployments","created_at":"2019-03-05T21:10:08Z","updated_at":"2019-03-05T21:15:17Z","pushed_at":"2019-03-16T18:30:28Z","git_url":"git://github.com/EgorkaKulikov/spbu-se2019-spring.git","ssh_url":"git@github.com:EgorkaKulikov/spbu-se2019-spring.git","clone_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring.git","svn_url":"https://github.com/EgorkaKulikov/spbu-se2019-spring","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":14,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9"},"html":{"href":"https://github.com/EgorkaKulikov/spbu-se2019-spring/pull/9"},"issue":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/9"},"comments":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring/statuses/e0655ce03882c3949e8c8d0e3740765743c7e7c4"}},"author_association":"NONE"}}
|
{
"id": 174021121,
"name": "EgorkaKulikov/spbu-se2019-spring",
"url": "https://api.github.com/repos/EgorkaKulikov/spbu-se2019-spring"
}
|
{
"id": 29856383,
"login": "EgorkaKulikov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29856383?",
"url": "https://api.github.com/users/EgorkaKulikov"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-03-16T21:39:02 |
9256730466
|
{"actor":{"display_login":"EgorkaKulikov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fitzgen/dodrio/pulls/comments/352819985","pull_request_review_id":325712132,"id":352819985,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjgxOTk4NQ==","diff_hunk":"@@ -371,50 +371,36 @@ impl VdomWeak {\n /// Replace the root rendering component with the new `root`.\n ///\n /// Returns a future that resolves to the *old* root component.\n- pub fn set_component(\n+ pub async fn set_component(\n self,\n root: Box<dyn RootRender>,\n- ) -> impl Future<Item = Box<dyn RootRender + 'static>, Error = VdomDroppedError> {\n- futures::future::ok(self.inner.upgrade())\n- .and_then(|inner| inner.ok_or(()))\n- .map_err(|_| VdomDroppedError {})\n- .and_then(|inner| {\n- let promise = js_sys::Promise::resolve(&JsValue::null());\n- JsFuture::from(promise)\n- .map_err(|_| VdomDroppedError {})\n- .and_then(move |_| {\n- let old = {\n- let mut exclusive = inner.exclusive.borrow_mut();\n- mem::replace(&mut *exclusive.component.as_mut().unwrap_throw(), root)\n- };\n- VdomWeak::new(&inner).render().map(|_| old)\n- })\n- })\n+ ) -> Result<Box<dyn RootRender + 'static>, VdomDroppedError> {\n+ let inner = self.inner.upgrade().ok_or(VdomDroppedError {})?;\n+\n+ let old = {\n+ let mut exclusive = inner.exclusive.borrow_mut();","path":"src/vdom.rs","position":104,"original_position":41,"commit_id":"2907079c92c32be6464a8a7c02643af8c9823f1c","original_commit_id":"957fec48a238bb88d673cd655a6f204b4abaefdd","user":{"login":"fitzgen","id":74571,"node_id":"MDQ6VXNlcjc0NTcx","avatar_url":"https://avatars2.githubusercontent.com/u/74571?v=4","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"body":"Yeah, and similar for the other spot as well :+1: ","created_at":"2019-12-02T20:46:41Z","updated_at":"2019-12-02T20:46:41Z","html_url":"https://github.com/fitzgen/dodrio/pull/113#discussion_r352819985","pull_request_url":"https://api.github.com/repos/fitzgen/dodrio/pulls/113","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/comments/352819985"},"html":{"href":"https://github.com/fitzgen/dodrio/pull/113#discussion_r352819985"},"pull_request":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/113"}},"in_reply_to_id":352768165},"pull_request":{"url":"https://api.github.com/repos/fitzgen/dodrio/pulls/113","id":347249708,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjQ5NzA4","html_url":"https://github.com/fitzgen/dodrio/pull/113","diff_url":"https://github.com/fitzgen/dodrio/pull/113.diff","patch_url":"https://github.com/fitzgen/dodrio/pull/113.patch","issue_url":"https://api.github.com/repos/fitzgen/dodrio/issues/113","number":113,"state":"open","locked":false,"title":"Port to std::future","user":{"login":"ldesgoui","id":2472678,"node_id":"MDQ6VXNlcjI0NzI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2472678?v=4","gravatar_id":"","url":"https://api.github.com/users/ldesgoui","html_url":"https://github.com/ldesgoui","followers_url":"https://api.github.com/users/ldesgoui/followers","following_url":"https://api.github.com/users/ldesgoui/following{/other_user}","gists_url":"https://api.github.com/users/ldesgoui/gists{/gist_id}","starred_url":"https://api.github.com/users/ldesgoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldesgoui/subscriptions","organizations_url":"https://api.github.com/users/ldesgoui/orgs","repos_url":"https://api.github.com/users/ldesgoui/repos","events_url":"https://api.github.com/users/ldesgoui/events{/privacy}","received_events_url":"https://api.github.com/users/ldesgoui/received_events","type":"User","site_admin":false},"body":"Hello!\r\n\r\nI've done the bulk work of:\r\n- Updating dependencies\r\n- Porting crates, tests, benches and examples to std::future\r\n- Fixing some Rust 2018 idioms\r\n\r\nThese are breaking changes that I believe warrant an update to `0.2.0`, I could include the necessary changes to version numbers if you would like.\r\n\r\nA couple points are blocking me, I will make notes of it using the comments feature, \r\n\r\nI hope that this helps, bests.","created_at":"2019-11-30T18:46:47Z","updated_at":"2019-12-02T20:46:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2d3fd7aa6b78470cb93f42609b36e978c28d584","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fitzgen/dodrio/pulls/113/commits","review_comments_url":"https://api.github.com/repos/fitzgen/dodrio/pulls/113/comments","review_comment_url":"https://api.github.com/repos/fitzgen/dodrio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fitzgen/dodrio/issues/113/comments","statuses_url":"https://api.github.com/repos/fitzgen/dodrio/statuses/2907079c92c32be6464a8a7c02643af8c9823f1c","head":{"label":"ldesgoui:std-futures","ref":"std-futures","sha":"2907079c92c32be6464a8a7c02643af8c9823f1c","user":{"login":"ldesgoui","id":2472678,"node_id":"MDQ6VXNlcjI0NzI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2472678?v=4","gravatar_id":"","url":"https://api.github.com/users/ldesgoui","html_url":"https://github.com/ldesgoui","followers_url":"https://api.github.com/users/ldesgoui/followers","following_url":"https://api.github.com/users/ldesgoui/following{/other_user}","gists_url":"https://api.github.com/users/ldesgoui/gists{/gist_id}","starred_url":"https://api.github.com/users/ldesgoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldesgoui/subscriptions","organizations_url":"https://api.github.com/users/ldesgoui/orgs","repos_url":"https://api.github.com/users/ldesgoui/repos","events_url":"https://api.github.com/users/ldesgoui/events{/privacy}","received_events_url":"https://api.github.com/users/ldesgoui/received_events","type":"User","site_admin":false},"repo":{"id":224915410,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ5MTU0MTA=","name":"dodrio","full_name":"ldesgoui/dodrio","private":false,"owner":{"login":"ldesgoui","id":2472678,"node_id":"MDQ6VXNlcjI0NzI2Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/2472678?v=4","gravatar_id":"","url":"https://api.github.com/users/ldesgoui","html_url":"https://github.com/ldesgoui","followers_url":"https://api.github.com/users/ldesgoui/followers","following_url":"https://api.github.com/users/ldesgoui/following{/other_user}","gists_url":"https://api.github.com/users/ldesgoui/gists{/gist_id}","starred_url":"https://api.github.com/users/ldesgoui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldesgoui/subscriptions","organizations_url":"https://api.github.com/users/ldesgoui/orgs","repos_url":"https://api.github.com/users/ldesgoui/repos","events_url":"https://api.github.com/users/ldesgoui/events{/privacy}","received_events_url":"https://api.github.com/users/ldesgoui/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ldesgoui/dodrio","description":"A fast, bump-allocated virtual DOM library for Rust and WebAssembly.","fork":true,"url":"https://api.github.com/repos/ldesgoui/dodrio","forks_url":"https://api.github.com/repos/ldesgoui/dodrio/forks","keys_url":"https://api.github.com/repos/ldesgoui/dodrio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldesgoui/dodrio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldesgoui/dodrio/teams","hooks_url":"https://api.github.com/repos/ldesgoui/dodrio/hooks","issue_events_url":"https://api.github.com/repos/ldesgoui/dodrio/issues/events{/number}","events_url":"https://api.github.com/repos/ldesgoui/dodrio/events","assignees_url":"https://api.github.com/repos/ldesgoui/dodrio/assignees{/user}","branches_url":"https://api.github.com/repos/ldesgoui/dodrio/branches{/branch}","tags_url":"https://api.github.com/repos/ldesgoui/dodrio/tags","blobs_url":"https://api.github.com/repos/ldesgoui/dodrio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldesgoui/dodrio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldesgoui/dodrio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldesgoui/dodrio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldesgoui/dodrio/statuses/{sha}","languages_url":"https://api.github.com/repos/ldesgoui/dodrio/languages","stargazers_url":"https://api.github.com/repos/ldesgoui/dodrio/stargazers","contributors_url":"https://api.github.com/repos/ldesgoui/dodrio/contributors","subscribers_url":"https://api.github.com/repos/ldesgoui/dodrio/subscribers","subscription_url":"https://api.github.com/repos/ldesgoui/dodrio/subscription","commits_url":"https://api.github.com/repos/ldesgoui/dodrio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldesgoui/dodrio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldesgoui/dodrio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldesgoui/dodrio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldesgoui/dodrio/contents/{+path}","compare_url":"https://api.github.com/repos/ldesgoui/dodrio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldesgoui/dodrio/merges","archive_url":"https://api.github.com/repos/ldesgoui/dodrio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldesgoui/dodrio/downloads","issues_url":"https://api.github.com/repos/ldesgoui/dodrio/issues{/number}","pulls_url":"https://api.github.com/repos/ldesgoui/dodrio/pulls{/number}","milestones_url":"https://api.github.com/repos/ldesgoui/dodrio/milestones{/number}","notifications_url":"https://api.github.com/repos/ldesgoui/dodrio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldesgoui/dodrio/labels{/name}","releases_url":"https://api.github.com/repos/ldesgoui/dodrio/releases{/id}","deployments_url":"https://api.github.com/repos/ldesgoui/dodrio/deployments","created_at":"2019-11-29T20:02:04Z","updated_at":"2019-11-29T20:02:06Z","pushed_at":"2019-12-02T20:31:03Z","git_url":"git://github.com/ldesgoui/dodrio.git","ssh_url":"git@github.com:ldesgoui/dodrio.git","clone_url":"https://github.com/ldesgoui/dodrio.git","svn_url":"https://github.com/ldesgoui/dodrio","homepage":"https://docs.rs/dodrio","size":644,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fitzgen:master","ref":"master","sha":"83d5581900d20dafa20a4d365282fb9c0a0ed00c","user":{"login":"fitzgen","id":74571,"node_id":"MDQ6VXNlcjc0NTcx","avatar_url":"https://avatars2.githubusercontent.com/u/74571?v=4","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"repo":{"id":159237509,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkyMzc1MDk=","name":"dodrio","full_name":"fitzgen/dodrio","private":false,"owner":{"login":"fitzgen","id":74571,"node_id":"MDQ6VXNlcjc0NTcx","avatar_url":"https://avatars2.githubusercontent.com/u/74571?v=4","gravatar_id":"","url":"https://api.github.com/users/fitzgen","html_url":"https://github.com/fitzgen","followers_url":"https://api.github.com/users/fitzgen/followers","following_url":"https://api.github.com/users/fitzgen/following{/other_user}","gists_url":"https://api.github.com/users/fitzgen/gists{/gist_id}","starred_url":"https://api.github.com/users/fitzgen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fitzgen/subscriptions","organizations_url":"https://api.github.com/users/fitzgen/orgs","repos_url":"https://api.github.com/users/fitzgen/repos","events_url":"https://api.github.com/users/fitzgen/events{/privacy}","received_events_url":"https://api.github.com/users/fitzgen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fitzgen/dodrio","description":"A fast, bump-allocated virtual DOM library for Rust and WebAssembly.","fork":false,"url":"https://api.github.com/repos/fitzgen/dodrio","forks_url":"https://api.github.com/repos/fitzgen/dodrio/forks","keys_url":"https://api.github.com/repos/fitzgen/dodrio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fitzgen/dodrio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fitzgen/dodrio/teams","hooks_url":"https://api.github.com/repos/fitzgen/dodrio/hooks","issue_events_url":"https://api.github.com/repos/fitzgen/dodrio/issues/events{/number}","events_url":"https://api.github.com/repos/fitzgen/dodrio/events","assignees_url":"https://api.github.com/repos/fitzgen/dodrio/assignees{/user}","branches_url":"https://api.github.com/repos/fitzgen/dodrio/branches{/branch}","tags_url":"https://api.github.com/repos/fitzgen/dodrio/tags","blobs_url":"https://api.github.com/repos/fitzgen/dodrio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fitzgen/dodrio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fitzgen/dodrio/git/refs{/sha}","trees_url":"https://api.github.com/repos/fitzgen/dodrio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fitzgen/dodrio/statuses/{sha}","languages_url":"https://api.github.com/repos/fitzgen/dodrio/languages","stargazers_url":"https://api.github.com/repos/fitzgen/dodrio/stargazers","contributors_url":"https://api.github.com/repos/fitzgen/dodrio/contributors","subscribers_url":"https://api.github.com/repos/fitzgen/dodrio/subscribers","subscription_url":"https://api.github.com/repos/fitzgen/dodrio/subscription","commits_url":"https://api.github.com/repos/fitzgen/dodrio/commits{/sha}","git_commits_url":"https://api.github.com/repos/fitzgen/dodrio/git/commits{/sha}","comments_url":"https://api.github.com/repos/fitzgen/dodrio/comments{/number}","issue_comment_url":"https://api.github.com/repos/fitzgen/dodrio/issues/comments{/number}","contents_url":"https://api.github.com/repos/fitzgen/dodrio/contents/{+path}","compare_url":"https://api.github.com/repos/fitzgen/dodrio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fitzgen/dodrio/merges","archive_url":"https://api.github.com/repos/fitzgen/dodrio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fitzgen/dodrio/downloads","issues_url":"https://api.github.com/repos/fitzgen/dodrio/issues{/number}","pulls_url":"https://api.github.com/repos/fitzgen/dodrio/pulls{/number}","milestones_url":"https://api.github.com/repos/fitzgen/dodrio/milestones{/number}","notifications_url":"https://api.github.com/repos/fitzgen/dodrio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fitzgen/dodrio/labels{/name}","releases_url":"https://api.github.com/repos/fitzgen/dodrio/releases{/id}","deployments_url":"https://api.github.com/repos/fitzgen/dodrio/deployments","created_at":"2018-11-26T21:50:59Z","updated_at":"2019-12-01T17:46:16Z","pushed_at":"2019-12-02T20:31:04Z","git_url":"git://github.com/fitzgen/dodrio.git","ssh_url":"git@github.com:fitzgen/dodrio.git","clone_url":"https://github.com/fitzgen/dodrio.git","svn_url":"https://github.com/fitzgen/dodrio","homepage":"https://docs.rs/dodrio","size":625,"stargazers_count":860,"watchers_count":860,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":20,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":32,"open_issues":20,"watchers":860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/113"},"html":{"href":"https://github.com/fitzgen/dodrio/pull/113"},"issue":{"href":"https://api.github.com/repos/fitzgen/dodrio/issues/113"},"comments":{"href":"https://api.github.com/repos/fitzgen/dodrio/issues/113/comments"},"review_comments":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/113/comments"},"review_comment":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fitzgen/dodrio/pulls/113/commits"},"statuses":{"href":"https://api.github.com/repos/fitzgen/dodrio/statuses/2907079c92c32be6464a8a7c02643af8c9823f1c"}},"author_association":"NONE"}}
|
{
"id": 159237509,
"name": "fitzgen/dodrio",
"url": "https://api.github.com/repos/fitzgen/dodrio"
}
|
{
"id": 74571,
"login": "fitzgen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/74571?",
"url": "https://api.github.com/users/fitzgen"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-02T20:46:41 |
10993229557
|
{"actor":{"display_login":"fitzgen"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/comments/296623567","pull_request_review_id":253287142,"id":296623567,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjYyMzU2Nw==","diff_hunk":"@@ -1,4 +1,7 @@\n+<<<<<<< HEAD","path":"MovieDBTests/Scenes/Movie/MovieNavigatorMock.swift","position":1,"original_position":1,"commit_id":"409c777d37c5d5e5ef0a17e6ee6ac9b57d83a38f","original_commit_id":"409c777d37c5d5e5ef0a17e6ee6ac9b57d83a38f","user":{"login":"tgdong2296","id":38901305,"node_id":"MDQ6VXNlcjM4OTAxMzA1","avatar_url":"https://avatars0.githubusercontent.com/u/38901305?v=4","gravatar_id":"","url":"https://api.github.com/users/tgdong2296","html_url":"https://github.com/tgdong2296","followers_url":"https://api.github.com/users/tgdong2296/followers","following_url":"https://api.github.com/users/tgdong2296/following{/other_user}","gists_url":"https://api.github.com/users/tgdong2296/gists{/gist_id}","starred_url":"https://api.github.com/users/tgdong2296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgdong2296/subscriptions","organizations_url":"https://api.github.com/users/tgdong2296/orgs","repos_url":"https://api.github.com/users/tgdong2296/repos","events_url":"https://api.github.com/users/tgdong2296/events{/privacy}","received_events_url":"https://api.github.com/users/tgdong2296/received_events","type":"User","site_admin":false},"body":"conlifct here","created_at":"2019-06-24T09:08:27Z","updated_at":"2019-06-24T09:08:27Z","html_url":"https://github.com/tgdong2296/MovieDB-07062019/pull/5#discussion_r296623567","pull_request_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/comments/296623567"},"html":{"href":"https://github.com/tgdong2296/MovieDB-07062019/pull/5#discussion_r296623567"},"pull_request":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5","id":291035005,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMDM1MDA1","html_url":"https://github.com/tgdong2296/MovieDB-07062019/pull/5","diff_url":"https://github.com/tgdong2296/MovieDB-07062019/pull/5.diff","patch_url":"https://github.com/tgdong2296/MovieDB-07062019/pull/5.patch","issue_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/5","number":5,"state":"open","locked":false,"title":"[Task003]create Movie Screen","user":{"login":"ando-andy","id":36369031,"node_id":"MDQ6VXNlcjM2MzY5MDMx","avatar_url":"https://avatars3.githubusercontent.com/u/36369031?v=4","gravatar_id":"","url":"https://api.github.com/users/ando-andy","html_url":"https://github.com/ando-andy","followers_url":"https://api.github.com/users/ando-andy/followers","following_url":"https://api.github.com/users/ando-andy/following{/other_user}","gists_url":"https://api.github.com/users/ando-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/ando-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ando-andy/subscriptions","organizations_url":"https://api.github.com/users/ando-andy/orgs","repos_url":"https://api.github.com/users/ando-andy/repos","events_url":"https://api.github.com/users/ando-andy/events{/privacy}","received_events_url":"https://api.github.com/users/ando-andy/received_events","type":"User","site_admin":false},"body":"## Related Tickets\r\n\r\n- [#Ticket ID](https://docs.google.com/spreadsheets/d/1F5V2sIUMGej3Wrp8qYRscf0KaVSlccBmqkRx49_hUVo/edit#gid=935273790)\r\n\r\nCreate UI for Movies screen\r\n - List movies now playing using CollectionView\r\n - List popular movies using CollectionView\r\n - Title label\r\n - Search button\r\n\r\nCreate a UI action\r\n - Click movie cell to view detail of the selected movie\r\n - Click the Search button to go to Search screen\r\n - Click More to view all list\r\n\r\nFetch data from API and display to the UI\r\n\r\n## What's this PR do ?\r\nInit base API and models \r\n\r\n## Library\r\n*(List gem, library third party add new)*\r\nAlamofire: https://github.com/Alamofire/Alamofire\r\nWenchaoD / FSPagerView: https://github.com/WenchaoD/FSPagerView\r\n\r\n## Impacted Areas in Application\r\n*(List features, api, models or services that this PR will affect)*\r\n\r\nAPI document: https://developers.themoviedb.org/3/authentication/create-session\r\n\r\n## Performance\r\n## Checklist\r\n- [x] It was tested in local success ?\r\n- [x] Updated rake task, environment variable at [here](https://???)\r\n- [x] Fill link PR into ticket and the opposite\r\n- [x] Note reason, scope of influence, solution into ticket\r\n- [x] Validate UI/Model/API\r\n\r\n## screenshot (optional)\r\n## Notes\r\n*(Other notes)*","created_at":"2019-06-24T08:54:08Z","updated_at":"2019-06-24T09:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a1566371adc8d11f8daf95bae728e4fb791a47f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5/commits","review_comments_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5/comments","review_comment_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/5/comments","statuses_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/statuses/409c777d37c5d5e5ef0a17e6ee6ac9b57d83a38f","head":{"label":"ando-andy:task003","ref":"task003","sha":"409c777d37c5d5e5ef0a17e6ee6ac9b57d83a38f","user":{"login":"ando-andy","id":36369031,"node_id":"MDQ6VXNlcjM2MzY5MDMx","avatar_url":"https://avatars3.githubusercontent.com/u/36369031?v=4","gravatar_id":"","url":"https://api.github.com/users/ando-andy","html_url":"https://github.com/ando-andy","followers_url":"https://api.github.com/users/ando-andy/followers","following_url":"https://api.github.com/users/ando-andy/following{/other_user}","gists_url":"https://api.github.com/users/ando-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/ando-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ando-andy/subscriptions","organizations_url":"https://api.github.com/users/ando-andy/orgs","repos_url":"https://api.github.com/users/ando-andy/repos","events_url":"https://api.github.com/users/ando-andy/events{/privacy}","received_events_url":"https://api.github.com/users/ando-andy/received_events","type":"User","site_admin":false},"repo":{"id":191074048,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEwNzQwNDg=","name":"MovieDB-07062019","full_name":"ando-andy/MovieDB-07062019","private":false,"owner":{"login":"ando-andy","id":36369031,"node_id":"MDQ6VXNlcjM2MzY5MDMx","avatar_url":"https://avatars3.githubusercontent.com/u/36369031?v=4","gravatar_id":"","url":"https://api.github.com/users/ando-andy","html_url":"https://github.com/ando-andy","followers_url":"https://api.github.com/users/ando-andy/followers","following_url":"https://api.github.com/users/ando-andy/following{/other_user}","gists_url":"https://api.github.com/users/ando-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/ando-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ando-andy/subscriptions","organizations_url":"https://api.github.com/users/ando-andy/orgs","repos_url":"https://api.github.com/users/ando-andy/repos","events_url":"https://api.github.com/users/ando-andy/events{/privacy}","received_events_url":"https://api.github.com/users/ando-andy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ando-andy/MovieDB-07062019","description":"Kazutaka Ando - RxSwift + MVVM","fork":true,"url":"https://api.github.com/repos/ando-andy/MovieDB-07062019","forks_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/forks","keys_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/teams","hooks_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/hooks","issue_events_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/issues/events{/number}","events_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/events","assignees_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/assignees{/user}","branches_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/branches{/branch}","tags_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/tags","blobs_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/git/refs{/sha}","trees_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/statuses/{sha}","languages_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/languages","stargazers_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/stargazers","contributors_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/contributors","subscribers_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/subscribers","subscription_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/subscription","commits_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/commits{/sha}","git_commits_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/git/commits{/sha}","comments_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/comments{/number}","issue_comment_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/issues/comments{/number}","contents_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/contents/{+path}","compare_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/merges","archive_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/downloads","issues_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/issues{/number}","pulls_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/pulls{/number}","milestones_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/milestones{/number}","notifications_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/labels{/name}","releases_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/releases{/id}","deployments_url":"https://api.github.com/repos/ando-andy/MovieDB-07062019/deployments","created_at":"2019-06-10T01:16:03Z","updated_at":"2019-06-10T01:16:06Z","pushed_at":"2019-06-24T08:51:05Z","git_url":"git://github.com/ando-andy/MovieDB-07062019.git","ssh_url":"git@github.com:ando-andy/MovieDB-07062019.git","clone_url":"https://github.com/ando-andy/MovieDB-07062019.git","svn_url":"https://github.com/ando-andy/MovieDB-07062019","homepage":null,"size":959,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tgdong2296:master","ref":"master","sha":"ee7043069fe62a377a757a34c5158b400368a303","user":{"login":"tgdong2296","id":38901305,"node_id":"MDQ6VXNlcjM4OTAxMzA1","avatar_url":"https://avatars0.githubusercontent.com/u/38901305?v=4","gravatar_id":"","url":"https://api.github.com/users/tgdong2296","html_url":"https://github.com/tgdong2296","followers_url":"https://api.github.com/users/tgdong2296/followers","following_url":"https://api.github.com/users/tgdong2296/following{/other_user}","gists_url":"https://api.github.com/users/tgdong2296/gists{/gist_id}","starred_url":"https://api.github.com/users/tgdong2296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgdong2296/subscriptions","organizations_url":"https://api.github.com/users/tgdong2296/orgs","repos_url":"https://api.github.com/users/tgdong2296/repos","events_url":"https://api.github.com/users/tgdong2296/events{/privacy}","received_events_url":"https://api.github.com/users/tgdong2296/received_events","type":"User","site_admin":false},"repo":{"id":190727158,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA3MjcxNTg=","name":"MovieDB-07062019","full_name":"tgdong2296/MovieDB-07062019","private":false,"owner":{"login":"tgdong2296","id":38901305,"node_id":"MDQ6VXNlcjM4OTAxMzA1","avatar_url":"https://avatars0.githubusercontent.com/u/38901305?v=4","gravatar_id":"","url":"https://api.github.com/users/tgdong2296","html_url":"https://github.com/tgdong2296","followers_url":"https://api.github.com/users/tgdong2296/followers","following_url":"https://api.github.com/users/tgdong2296/following{/other_user}","gists_url":"https://api.github.com/users/tgdong2296/gists{/gist_id}","starred_url":"https://api.github.com/users/tgdong2296/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgdong2296/subscriptions","organizations_url":"https://api.github.com/users/tgdong2296/orgs","repos_url":"https://api.github.com/users/tgdong2296/repos","events_url":"https://api.github.com/users/tgdong2296/events{/privacy}","received_events_url":"https://api.github.com/users/tgdong2296/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tgdong2296/MovieDB-07062019","description":"Kazutaka Ando - RxSwift + MVVM","fork":false,"url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019","forks_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/forks","keys_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/teams","hooks_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/hooks","issue_events_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/events{/number}","events_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/events","assignees_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/assignees{/user}","branches_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/branches{/branch}","tags_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/tags","blobs_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/statuses/{sha}","languages_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/languages","stargazers_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/stargazers","contributors_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/contributors","subscribers_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/subscribers","subscription_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/subscription","commits_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/contents/{+path}","compare_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/merges","archive_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/downloads","issues_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues{/number}","pulls_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls{/number}","milestones_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/milestones{/number}","notifications_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/labels{/name}","releases_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/releases{/id}","deployments_url":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/deployments","created_at":"2019-06-07T10:39:42Z","updated_at":"2019-06-18T03:55:12Z","pushed_at":"2019-06-24T08:54:08Z","git_url":"git://github.com/tgdong2296/MovieDB-07062019.git","ssh_url":"git@github.com:tgdong2296/MovieDB-07062019.git","clone_url":"https://github.com/tgdong2296/MovieDB-07062019.git","svn_url":"https://github.com/tgdong2296/MovieDB-07062019","homepage":null,"size":943,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5"},"html":{"href":"https://github.com/tgdong2296/MovieDB-07062019/pull/5"},"issue":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/5"},"comments":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/tgdong2296/MovieDB-07062019/statuses/409c777d37c5d5e5ef0a17e6ee6ac9b57d83a38f"}},"author_association":"NONE"}}
|
{
"id": 190727158,
"name": "tgdong2296/MovieDB-07062019",
"url": "https://api.github.com/repos/tgdong2296/MovieDB-07062019"
}
|
{
"id": 38901305,
"login": "tgdong2296",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/38901305?",
"url": "https://api.github.com/users/tgdong2296"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-06-24T09:08:27 |
9879058799
|
{"actor":{"display_login":"tgdong2296"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/comments/345137721","pull_request_review_id":315445407,"id":345137721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NTEzNzcyMQ==","diff_hunk":"@@ -1,18 +1,18 @@\n import { BrowserModule } from '@angular/platform-browser';\n import { NgModule } from '@angular/core';\n-\n import { AppRoutingModule } from './app-routing.module';\n import { AppComponent } from './app.component';\n+import { FirstDummyComponent } from './first-dummy/first-dummy.component';","path":"src/app/app.module.ts","position":6,"original_position":6,"commit_id":"b4701609ce656a7548e6b98540a00a1f09883b94","original_commit_id":"b4701609ce656a7548e6b98540a00a1f09883b94","user":{"login":"mdybich","id":15029165,"node_id":"MDQ6VXNlcjE1MDI5MTY1","avatar_url":"https://avatars1.githubusercontent.com/u/15029165?v=4","gravatar_id":"","url":"https://api.github.com/users/mdybich","html_url":"https://github.com/mdybich","followers_url":"https://api.github.com/users/mdybich/followers","following_url":"https://api.github.com/users/mdybich/following{/other_user}","gists_url":"https://api.github.com/users/mdybich/gists{/gist_id}","starred_url":"https://api.github.com/users/mdybich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdybich/subscriptions","organizations_url":"https://api.github.com/users/mdybich/orgs","repos_url":"https://api.github.com/users/mdybich/repos","events_url":"https://api.github.com/users/mdybich/events{/privacy}","received_events_url":"https://api.github.com/users/mdybich/received_events","type":"User","site_admin":false},"body":"Please delete this component - it is not needed anymore. ","created_at":"2019-11-12T10:52:57Z","updated_at":"2019-11-12T10:54:16Z","html_url":"https://github.com/romatowskak/examp-ng-app/pull/1#discussion_r345137721","pull_request_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/comments/345137721"},"html":{"href":"https://github.com/romatowskak/examp-ng-app/pull/1#discussion_r345137721"},"pull_request":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1","id":336651304,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NjUxMzA0","html_url":"https://github.com/romatowskak/examp-ng-app/pull/1","diff_url":"https://github.com/romatowskak/examp-ng-app/pull/1.diff","patch_url":"https://github.com/romatowskak/examp-ng-app/pull/1.patch","issue_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/1","number":1,"state":"open","locked":false,"title":"adding the list of action items","user":{"login":"romatowskak","id":50733393,"node_id":"MDQ6VXNlcjUwNzMzMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/50733393?v=4","gravatar_id":"","url":"https://api.github.com/users/romatowskak","html_url":"https://github.com/romatowskak","followers_url":"https://api.github.com/users/romatowskak/followers","following_url":"https://api.github.com/users/romatowskak/following{/other_user}","gists_url":"https://api.github.com/users/romatowskak/gists{/gist_id}","starred_url":"https://api.github.com/users/romatowskak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romatowskak/subscriptions","organizations_url":"https://api.github.com/users/romatowskak/orgs","repos_url":"https://api.github.com/users/romatowskak/repos","events_url":"https://api.github.com/users/romatowskak/events{/privacy}","received_events_url":"https://api.github.com/users/romatowskak/received_events","type":"User","site_admin":false},"body":"- creation of service holding all data (action tasks)\r\n- creation of ActionItemsComponent (with data table where displayed all action tasks got from the service)","created_at":"2019-11-05T08:27:14Z","updated_at":"2019-11-12T10:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17e62ad7f1f78100aa62f8c46b789672ce25c5e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1/commits","review_comments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1/comments","review_comment_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/1/comments","statuses_url":"https://api.github.com/repos/romatowskak/examp-ng-app/statuses/b4701609ce656a7548e6b98540a00a1f09883b94","head":{"label":"romatowskak:tasks-branch","ref":"tasks-branch","sha":"b4701609ce656a7548e6b98540a00a1f09883b94","user":{"login":"romatowskak","id":50733393,"node_id":"MDQ6VXNlcjUwNzMzMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/50733393?v=4","gravatar_id":"","url":"https://api.github.com/users/romatowskak","html_url":"https://github.com/romatowskak","followers_url":"https://api.github.com/users/romatowskak/followers","following_url":"https://api.github.com/users/romatowskak/following{/other_user}","gists_url":"https://api.github.com/users/romatowskak/gists{/gist_id}","starred_url":"https://api.github.com/users/romatowskak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romatowskak/subscriptions","organizations_url":"https://api.github.com/users/romatowskak/orgs","repos_url":"https://api.github.com/users/romatowskak/repos","events_url":"https://api.github.com/users/romatowskak/events{/privacy}","received_events_url":"https://api.github.com/users/romatowskak/received_events","type":"User","site_admin":false},"repo":{"id":219468936,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk0Njg5MzY=","name":"examp-ng-app","full_name":"romatowskak/examp-ng-app","private":false,"owner":{"login":"romatowskak","id":50733393,"node_id":"MDQ6VXNlcjUwNzMzMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/50733393?v=4","gravatar_id":"","url":"https://api.github.com/users/romatowskak","html_url":"https://github.com/romatowskak","followers_url":"https://api.github.com/users/romatowskak/followers","following_url":"https://api.github.com/users/romatowskak/following{/other_user}","gists_url":"https://api.github.com/users/romatowskak/gists{/gist_id}","starred_url":"https://api.github.com/users/romatowskak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romatowskak/subscriptions","organizations_url":"https://api.github.com/users/romatowskak/orgs","repos_url":"https://api.github.com/users/romatowskak/repos","events_url":"https://api.github.com/users/romatowskak/events{/privacy}","received_events_url":"https://api.github.com/users/romatowskak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romatowskak/examp-ng-app","description":null,"fork":false,"url":"https://api.github.com/repos/romatowskak/examp-ng-app","forks_url":"https://api.github.com/repos/romatowskak/examp-ng-app/forks","keys_url":"https://api.github.com/repos/romatowskak/examp-ng-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romatowskak/examp-ng-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romatowskak/examp-ng-app/teams","hooks_url":"https://api.github.com/repos/romatowskak/examp-ng-app/hooks","issue_events_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/events{/number}","events_url":"https://api.github.com/repos/romatowskak/examp-ng-app/events","assignees_url":"https://api.github.com/repos/romatowskak/examp-ng-app/assignees{/user}","branches_url":"https://api.github.com/repos/romatowskak/examp-ng-app/branches{/branch}","tags_url":"https://api.github.com/repos/romatowskak/examp-ng-app/tags","blobs_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romatowskak/examp-ng-app/statuses/{sha}","languages_url":"https://api.github.com/repos/romatowskak/examp-ng-app/languages","stargazers_url":"https://api.github.com/repos/romatowskak/examp-ng-app/stargazers","contributors_url":"https://api.github.com/repos/romatowskak/examp-ng-app/contributors","subscribers_url":"https://api.github.com/repos/romatowskak/examp-ng-app/subscribers","subscription_url":"https://api.github.com/repos/romatowskak/examp-ng-app/subscription","commits_url":"https://api.github.com/repos/romatowskak/examp-ng-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/romatowskak/examp-ng-app/contents/{+path}","compare_url":"https://api.github.com/repos/romatowskak/examp-ng-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romatowskak/examp-ng-app/merges","archive_url":"https://api.github.com/repos/romatowskak/examp-ng-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romatowskak/examp-ng-app/downloads","issues_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues{/number}","pulls_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls{/number}","milestones_url":"https://api.github.com/repos/romatowskak/examp-ng-app/milestones{/number}","notifications_url":"https://api.github.com/repos/romatowskak/examp-ng-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romatowskak/examp-ng-app/labels{/name}","releases_url":"https://api.github.com/repos/romatowskak/examp-ng-app/releases{/id}","deployments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/deployments","created_at":"2019-11-04T09:56:08Z","updated_at":"2019-11-04T11:21:20Z","pushed_at":"2019-11-08T13:19:40Z","git_url":"git://github.com/romatowskak/examp-ng-app.git","ssh_url":"git@github.com:romatowskak/examp-ng-app.git","clone_url":"https://github.com/romatowskak/examp-ng-app.git","svn_url":"https://github.com/romatowskak/examp-ng-app","homepage":null,"size":178,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"romatowskak:master","ref":"master","sha":"796a03c99c46dd3cba77b260acc48796920f2765","user":{"login":"romatowskak","id":50733393,"node_id":"MDQ6VXNlcjUwNzMzMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/50733393?v=4","gravatar_id":"","url":"https://api.github.com/users/romatowskak","html_url":"https://github.com/romatowskak","followers_url":"https://api.github.com/users/romatowskak/followers","following_url":"https://api.github.com/users/romatowskak/following{/other_user}","gists_url":"https://api.github.com/users/romatowskak/gists{/gist_id}","starred_url":"https://api.github.com/users/romatowskak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romatowskak/subscriptions","organizations_url":"https://api.github.com/users/romatowskak/orgs","repos_url":"https://api.github.com/users/romatowskak/repos","events_url":"https://api.github.com/users/romatowskak/events{/privacy}","received_events_url":"https://api.github.com/users/romatowskak/received_events","type":"User","site_admin":false},"repo":{"id":219468936,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk0Njg5MzY=","name":"examp-ng-app","full_name":"romatowskak/examp-ng-app","private":false,"owner":{"login":"romatowskak","id":50733393,"node_id":"MDQ6VXNlcjUwNzMzMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/50733393?v=4","gravatar_id":"","url":"https://api.github.com/users/romatowskak","html_url":"https://github.com/romatowskak","followers_url":"https://api.github.com/users/romatowskak/followers","following_url":"https://api.github.com/users/romatowskak/following{/other_user}","gists_url":"https://api.github.com/users/romatowskak/gists{/gist_id}","starred_url":"https://api.github.com/users/romatowskak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romatowskak/subscriptions","organizations_url":"https://api.github.com/users/romatowskak/orgs","repos_url":"https://api.github.com/users/romatowskak/repos","events_url":"https://api.github.com/users/romatowskak/events{/privacy}","received_events_url":"https://api.github.com/users/romatowskak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romatowskak/examp-ng-app","description":null,"fork":false,"url":"https://api.github.com/repos/romatowskak/examp-ng-app","forks_url":"https://api.github.com/repos/romatowskak/examp-ng-app/forks","keys_url":"https://api.github.com/repos/romatowskak/examp-ng-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romatowskak/examp-ng-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romatowskak/examp-ng-app/teams","hooks_url":"https://api.github.com/repos/romatowskak/examp-ng-app/hooks","issue_events_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/events{/number}","events_url":"https://api.github.com/repos/romatowskak/examp-ng-app/events","assignees_url":"https://api.github.com/repos/romatowskak/examp-ng-app/assignees{/user}","branches_url":"https://api.github.com/repos/romatowskak/examp-ng-app/branches{/branch}","tags_url":"https://api.github.com/repos/romatowskak/examp-ng-app/tags","blobs_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romatowskak/examp-ng-app/statuses/{sha}","languages_url":"https://api.github.com/repos/romatowskak/examp-ng-app/languages","stargazers_url":"https://api.github.com/repos/romatowskak/examp-ng-app/stargazers","contributors_url":"https://api.github.com/repos/romatowskak/examp-ng-app/contributors","subscribers_url":"https://api.github.com/repos/romatowskak/examp-ng-app/subscribers","subscription_url":"https://api.github.com/repos/romatowskak/examp-ng-app/subscription","commits_url":"https://api.github.com/repos/romatowskak/examp-ng-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/romatowskak/examp-ng-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/romatowskak/examp-ng-app/contents/{+path}","compare_url":"https://api.github.com/repos/romatowskak/examp-ng-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romatowskak/examp-ng-app/merges","archive_url":"https://api.github.com/repos/romatowskak/examp-ng-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romatowskak/examp-ng-app/downloads","issues_url":"https://api.github.com/repos/romatowskak/examp-ng-app/issues{/number}","pulls_url":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls{/number}","milestones_url":"https://api.github.com/repos/romatowskak/examp-ng-app/milestones{/number}","notifications_url":"https://api.github.com/repos/romatowskak/examp-ng-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romatowskak/examp-ng-app/labels{/name}","releases_url":"https://api.github.com/repos/romatowskak/examp-ng-app/releases{/id}","deployments_url":"https://api.github.com/repos/romatowskak/examp-ng-app/deployments","created_at":"2019-11-04T09:56:08Z","updated_at":"2019-11-04T11:21:20Z","pushed_at":"2019-11-08T13:19:40Z","git_url":"git://github.com/romatowskak/examp-ng-app.git","ssh_url":"git@github.com:romatowskak/examp-ng-app.git","clone_url":"https://github.com/romatowskak/examp-ng-app.git","svn_url":"https://github.com/romatowskak/examp-ng-app","homepage":null,"size":178,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1"},"html":{"href":"https://github.com/romatowskak/examp-ng-app/pull/1"},"issue":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/1"},"comments":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/romatowskak/examp-ng-app/statuses/b4701609ce656a7548e6b98540a00a1f09883b94"}},"author_association":"OWNER"}}
|
{
"id": 219468936,
"name": "romatowskak/examp-ng-app",
"url": "https://api.github.com/repos/romatowskak/examp-ng-app"
}
|
{
"id": 15029165,
"login": "mdybich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15029165?",
"url": "https://api.github.com/users/mdybich"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-12T10:52:57 |
10841672990
|
{"actor":{"display_login":"mdybich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/comments/330849344","pull_request_review_id":296624140,"id":330849344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDg0OTM0NA==","diff_hunk":"@@ -0,0 +1,77 @@\n+ ### The places where I have been\n+\n+- [x] Bhaktapur\n+- [] Dhading\n+- [x] Kathmandu\n+- [] Kavrepalanchok\n+- [x] Lalitpur\n+- [x] Nuwakot\n+- [] Rasuwa\n+- [] Sindhupalchok\n+- [] Banke\n+- [] Bardiya\n+- [] Dailekh","path":"SocialLife/Travel/Places/Nepal/places.md","position":13,"original_position":13,"commit_id":"8f778f0b0477237284a1c73ea817188ec57756e3","original_commit_id":"8f778f0b0477237284a1c73ea817188ec57756e3","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":" Issue found: [[list-item-indent] Incorrect list-item indent: add 2 spaces](https://app.codacy.com/app/nguyenngochai.shipagent/SharingKnowledge/pullRequest?prid=4258908)","created_at":"2019-10-03T03:13:35Z","updated_at":"2019-10-03T03:13:35Z","html_url":"https://github.com/hoasung01/SharingKnowledge/pull/17#discussion_r330849344","pull_request_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/comments/330849344"},"html":{"href":"https://github.com/hoasung01/SharingKnowledge/pull/17#discussion_r330849344"},"pull_request":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17","id":324023949,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MDIzOTQ5","html_url":"https://github.com/hoasung01/SharingKnowledge/pull/17","diff_url":"https://github.com/hoasung01/SharingKnowledge/pull/17.diff","patch_url":"https://github.com/hoasung01/SharingKnowledge/pull/17.patch","issue_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/17","number":17,"state":"open","locked":false,"title":"Places in nepal","user":{"login":"sa77","id":4640354,"node_id":"MDQ6VXNlcjQ2NDAzNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4640354?v=4","gravatar_id":"","url":"https://api.github.com/users/sa77","html_url":"https://github.com/sa77","followers_url":"https://api.github.com/users/sa77/followers","following_url":"https://api.github.com/users/sa77/following{/other_user}","gists_url":"https://api.github.com/users/sa77/gists{/gist_id}","starred_url":"https://api.github.com/users/sa77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa77/subscriptions","organizations_url":"https://api.github.com/users/sa77/orgs","repos_url":"https://api.github.com/users/sa77/repos","events_url":"https://api.github.com/users/sa77/events{/privacy}","received_events_url":"https://api.github.com/users/sa77/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-03T03:08:27Z","updated_at":"2019-10-03T03:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b11449d93cf09713676c530e7cacd0ca04ceebe4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17/commits","review_comments_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17/comments","review_comment_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/17/comments","statuses_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/statuses/8f778f0b0477237284a1c73ea817188ec57756e3","head":{"label":"sa77:places-in-nepal","ref":"places-in-nepal","sha":"8f778f0b0477237284a1c73ea817188ec57756e3","user":{"login":"sa77","id":4640354,"node_id":"MDQ6VXNlcjQ2NDAzNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4640354?v=4","gravatar_id":"","url":"https://api.github.com/users/sa77","html_url":"https://github.com/sa77","followers_url":"https://api.github.com/users/sa77/followers","following_url":"https://api.github.com/users/sa77/following{/other_user}","gists_url":"https://api.github.com/users/sa77/gists{/gist_id}","starred_url":"https://api.github.com/users/sa77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa77/subscriptions","organizations_url":"https://api.github.com/users/sa77/orgs","repos_url":"https://api.github.com/users/sa77/repos","events_url":"https://api.github.com/users/sa77/events{/privacy}","received_events_url":"https://api.github.com/users/sa77/received_events","type":"User","site_admin":false},"repo":{"id":212214106,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIyMTQxMDY=","name":"SharingKnowledge","full_name":"sa77/SharingKnowledge","private":false,"owner":{"login":"sa77","id":4640354,"node_id":"MDQ6VXNlcjQ2NDAzNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4640354?v=4","gravatar_id":"","url":"https://api.github.com/users/sa77","html_url":"https://github.com/sa77","followers_url":"https://api.github.com/users/sa77/followers","following_url":"https://api.github.com/users/sa77/following{/other_user}","gists_url":"https://api.github.com/users/sa77/gists{/gist_id}","starred_url":"https://api.github.com/users/sa77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa77/subscriptions","organizations_url":"https://api.github.com/users/sa77/orgs","repos_url":"https://api.github.com/users/sa77/repos","events_url":"https://api.github.com/users/sa77/events{/privacy}","received_events_url":"https://api.github.com/users/sa77/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sa77/SharingKnowledge","description":"sharing and make it better","fork":true,"url":"https://api.github.com/repos/sa77/SharingKnowledge","forks_url":"https://api.github.com/repos/sa77/SharingKnowledge/forks","keys_url":"https://api.github.com/repos/sa77/SharingKnowledge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sa77/SharingKnowledge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sa77/SharingKnowledge/teams","hooks_url":"https://api.github.com/repos/sa77/SharingKnowledge/hooks","issue_events_url":"https://api.github.com/repos/sa77/SharingKnowledge/issues/events{/number}","events_url":"https://api.github.com/repos/sa77/SharingKnowledge/events","assignees_url":"https://api.github.com/repos/sa77/SharingKnowledge/assignees{/user}","branches_url":"https://api.github.com/repos/sa77/SharingKnowledge/branches{/branch}","tags_url":"https://api.github.com/repos/sa77/SharingKnowledge/tags","blobs_url":"https://api.github.com/repos/sa77/SharingKnowledge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sa77/SharingKnowledge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sa77/SharingKnowledge/git/refs{/sha}","trees_url":"https://api.github.com/repos/sa77/SharingKnowledge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sa77/SharingKnowledge/statuses/{sha}","languages_url":"https://api.github.com/repos/sa77/SharingKnowledge/languages","stargazers_url":"https://api.github.com/repos/sa77/SharingKnowledge/stargazers","contributors_url":"https://api.github.com/repos/sa77/SharingKnowledge/contributors","subscribers_url":"https://api.github.com/repos/sa77/SharingKnowledge/subscribers","subscription_url":"https://api.github.com/repos/sa77/SharingKnowledge/subscription","commits_url":"https://api.github.com/repos/sa77/SharingKnowledge/commits{/sha}","git_commits_url":"https://api.github.com/repos/sa77/SharingKnowledge/git/commits{/sha}","comments_url":"https://api.github.com/repos/sa77/SharingKnowledge/comments{/number}","issue_comment_url":"https://api.github.com/repos/sa77/SharingKnowledge/issues/comments{/number}","contents_url":"https://api.github.com/repos/sa77/SharingKnowledge/contents/{+path}","compare_url":"https://api.github.com/repos/sa77/SharingKnowledge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sa77/SharingKnowledge/merges","archive_url":"https://api.github.com/repos/sa77/SharingKnowledge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sa77/SharingKnowledge/downloads","issues_url":"https://api.github.com/repos/sa77/SharingKnowledge/issues{/number}","pulls_url":"https://api.github.com/repos/sa77/SharingKnowledge/pulls{/number}","milestones_url":"https://api.github.com/repos/sa77/SharingKnowledge/milestones{/number}","notifications_url":"https://api.github.com/repos/sa77/SharingKnowledge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sa77/SharingKnowledge/labels{/name}","releases_url":"https://api.github.com/repos/sa77/SharingKnowledge/releases{/id}","deployments_url":"https://api.github.com/repos/sa77/SharingKnowledge/deployments","created_at":"2019-10-01T22:52:03Z","updated_at":"2019-10-01T22:52:05Z","pushed_at":"2019-10-03T03:11:48Z","git_url":"git://github.com/sa77/SharingKnowledge.git","ssh_url":"git@github.com:sa77/SharingKnowledge.git","clone_url":"https://github.com/sa77/SharingKnowledge.git","svn_url":"https://github.com/sa77/SharingKnowledge","homepage":"","size":807,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hoasung01:master","ref":"master","sha":"8f9d9db6ddd123b89b892a33e3d6ddaa072fa206","user":{"login":"hoasung01","id":4177327,"node_id":"MDQ6VXNlcjQxNzczMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4177327?v=4","gravatar_id":"","url":"https://api.github.com/users/hoasung01","html_url":"https://github.com/hoasung01","followers_url":"https://api.github.com/users/hoasung01/followers","following_url":"https://api.github.com/users/hoasung01/following{/other_user}","gists_url":"https://api.github.com/users/hoasung01/gists{/gist_id}","starred_url":"https://api.github.com/users/hoasung01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoasung01/subscriptions","organizations_url":"https://api.github.com/users/hoasung01/orgs","repos_url":"https://api.github.com/users/hoasung01/repos","events_url":"https://api.github.com/users/hoasung01/events{/privacy}","received_events_url":"https://api.github.com/users/hoasung01/received_events","type":"User","site_admin":false},"repo":{"id":183343697,"node_id":"MDEwOlJlcG9zaXRvcnkxODMzNDM2OTc=","name":"SharingKnowledge","full_name":"hoasung01/SharingKnowledge","private":false,"owner":{"login":"hoasung01","id":4177327,"node_id":"MDQ6VXNlcjQxNzczMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4177327?v=4","gravatar_id":"","url":"https://api.github.com/users/hoasung01","html_url":"https://github.com/hoasung01","followers_url":"https://api.github.com/users/hoasung01/followers","following_url":"https://api.github.com/users/hoasung01/following{/other_user}","gists_url":"https://api.github.com/users/hoasung01/gists{/gist_id}","starred_url":"https://api.github.com/users/hoasung01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoasung01/subscriptions","organizations_url":"https://api.github.com/users/hoasung01/orgs","repos_url":"https://api.github.com/users/hoasung01/repos","events_url":"https://api.github.com/users/hoasung01/events{/privacy}","received_events_url":"https://api.github.com/users/hoasung01/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hoasung01/SharingKnowledge","description":"sharing and make it better","fork":false,"url":"https://api.github.com/repos/hoasung01/SharingKnowledge","forks_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/forks","keys_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/teams","hooks_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/hooks","issue_events_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/events{/number}","events_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/events","assignees_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/assignees{/user}","branches_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/branches{/branch}","tags_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/tags","blobs_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/statuses/{sha}","languages_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/languages","stargazers_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/stargazers","contributors_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/contributors","subscribers_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/subscribers","subscription_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/subscription","commits_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/contents/{+path}","compare_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/merges","archive_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/downloads","issues_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues{/number}","pulls_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls{/number}","milestones_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/milestones{/number}","notifications_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/labels{/name}","releases_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/releases{/id}","deployments_url":"https://api.github.com/repos/hoasung01/SharingKnowledge/deployments","created_at":"2019-04-25T02:45:45Z","updated_at":"2019-10-02T23:45:21Z","pushed_at":"2019-10-03T03:11:50Z","git_url":"git://github.com/hoasung01/SharingKnowledge.git","ssh_url":"git@github.com:hoasung01/SharingKnowledge.git","clone_url":"https://github.com/hoasung01/SharingKnowledge.git","svn_url":"https://github.com/hoasung01/SharingKnowledge","homepage":"","size":821,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":6,"open_issues":13,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17"},"html":{"href":"https://github.com/hoasung01/SharingKnowledge/pull/17"},"issue":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/17"},"comments":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/hoasung01/SharingKnowledge/statuses/8f778f0b0477237284a1c73ea817188ec57756e3"}},"author_association":"NONE"}}
|
{
"id": 183343697,
"name": "hoasung01/SharingKnowledge",
"url": "https://api.github.com/repos/hoasung01/SharingKnowledge"
}
|
{
"id": 19940114,
"login": "codacy-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19940114?",
"url": "https://api.github.com/users/codacy-bot"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-10-03T03:13:35 |
10547881886
|
{"actor":{"display_login":"codacy-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/comments/283187939","pull_request_review_id":236476193,"id":283187939,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzE4NzkzOQ==","diff_hunk":"@@ -82,32 +78,29 @@ private static NBTTagCompound serialize(NBTTagCompound tag, RegionSnapshot snaps\n }\n // Palette serialization ends\n \n- // Hence we record the storage frame after it is completed, the initial values of the counter would be used as a storage frame regardless, therefore we need to skip inorder for this algorithm to function correctly\n- if (firstIteration)\n- firstIteration = false;\n- else {\n- // If the same block state showed up again, increase the number of streaks\n- // If we have more than 255 streaks (maximum integer that can be stored in 8 bits), we force start a new streak, because the current storage frame won't fit that many of them\n- if (state.equals(lastStreak) && streak < 255) {\n- streak++;\n- continue;\n- }\n+ // If the same block state showed up again, increase the number of streaks\n+ // If we have more than 255 streaks (maximum integer that can be stored in 8 bits), we force start a new streak, because the current storage frame won't fit that many of them\n+ if (state.equals(lastStreak) && streak < 255) {\n+ streak++;\n+ continue;\n+ }\n \n- // Note: if the program reached here, it means the current storage frame is completed\n+ // Note: if the program reached here, it means the current storage frame is completed\n \n- // Number of streaks and the ID of the block state that is streaking\n- // - no need to differentiate between single and repeating block states, since the number at the larger endian represents how many repeating block states are there\n- // - if the streaking block state is empty (returns `null` when `get()` is called), it will be mapped to ID 0.\n- // - see initialization of `mapPalettes`\n- frames.add(((streak & 0xff) << 24) | (mapPalettes.get(lastStreak.get()) & 0xffffff));\n- }\n+ // Number of streaks and the ID of the block state that is streaking\n+ // - no need to differentiate between single and repeating block states, since the number at the larger endian represents how many repeating block states are there\n+ // - if the streaking block state is empty (returns `null` when `get()` is called), it will be mapped to ID 0.","path":"src/main/java/com/direwolf20/buildinggadgets/common/util/blocks/RegionSnapshot.java","position":94,"original_position":57,"commit_id":"97a1213fbb3151b75d142eb615fb78dfc103a278","original_commit_id":"1c13f5bfcae07f374e57e2d2af7da718685ffeb2","user":{"login":"MajorTuvok","id":25031360,"node_id":"MDQ6VXNlcjI1MDMxMzYw","avatar_url":"https://avatars2.githubusercontent.com/u/25031360?v=4","gravatar_id":"","url":"https://api.github.com/users/MajorTuvok","html_url":"https://github.com/MajorTuvok","followers_url":"https://api.github.com/users/MajorTuvok/followers","following_url":"https://api.github.com/users/MajorTuvok/following{/other_user}","gists_url":"https://api.github.com/users/MajorTuvok/gists{/gist_id}","starred_url":"https://api.github.com/users/MajorTuvok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MajorTuvok/subscriptions","organizations_url":"https://api.github.com/users/MajorTuvok/orgs","repos_url":"https://api.github.com/users/MajorTuvok/repos","events_url":"https://api.github.com/users/MajorTuvok/events{/privacy}","received_events_url":"https://api.github.com/users/MajorTuvok/received_events","type":"User","site_admin":false},"body":"According to the [docs](https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html#get--, the optional **throws an NoSuchElementException** when it is empty and `get` is called. Thid needs tobeither use `ifPresent` or check if it `isPresent` (presumably the latter, as you want to do something in both cases) ","created_at":"2019-05-13T05:00:01Z","updated_at":"2019-05-13T05:00:01Z","html_url":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300#discussion_r283187939","pull_request_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/comments/283187939"},"html":{"href":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300#discussion_r283187939"},"pull_request":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300"}}},"pull_request":{"url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300","id":276071313,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MDcxMzEz","html_url":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300","diff_url":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300.diff","patch_url":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300.patch","issue_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/300","number":300,"state":"open","locked":false,"title":"World snapshot and undo serialization algorithm","user":{"login":"hnOsmium0001","id":36975818,"node_id":"MDQ6VXNlcjM2OTc1ODE4","avatar_url":"https://avatars3.githubusercontent.com/u/36975818?v=4","gravatar_id":"","url":"https://api.github.com/users/hnOsmium0001","html_url":"https://github.com/hnOsmium0001","followers_url":"https://api.github.com/users/hnOsmium0001/followers","following_url":"https://api.github.com/users/hnOsmium0001/following{/other_user}","gists_url":"https://api.github.com/users/hnOsmium0001/gists{/gist_id}","starred_url":"https://api.github.com/users/hnOsmium0001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnOsmium0001/subscriptions","organizations_url":"https://api.github.com/users/hnOsmium0001/orgs","repos_url":"https://api.github.com/users/hnOsmium0001/repos","events_url":"https://api.github.com/users/hnOsmium0001/events{/privacy}","received_events_url":"https://api.github.com/users/hnOsmium0001/received_events","type":"User","site_admin":false},"body":"This is the serialization method I came up with a \"streak\" system to compress the data. It is untested, and therefore was put here to be examined and improved by the others.\r\n\r\nIf I did something wrong or it won't work from the first place, please point that out.\r\nWhen we accept it, it can be marked as ready and get merged; otherwise please leave as a draft.","created_at":"2019-05-06T06:07:24Z","updated_at":"2019-05-13T05:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aefdcae5b15d20ce28846fc989926e35b85b9996","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300/commits","review_comments_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300/comments","review_comment_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/300/comments","statuses_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/statuses/97a1213fbb3151b75d142eb615fb78dfc103a278","head":{"label":"hnOsmium0001:RegionSnapshot","ref":"RegionSnapshot","sha":"97a1213fbb3151b75d142eb615fb78dfc103a278","user":{"login":"hnOsmium0001","id":36975818,"node_id":"MDQ6VXNlcjM2OTc1ODE4","avatar_url":"https://avatars3.githubusercontent.com/u/36975818?v=4","gravatar_id":"","url":"https://api.github.com/users/hnOsmium0001","html_url":"https://github.com/hnOsmium0001","followers_url":"https://api.github.com/users/hnOsmium0001/followers","following_url":"https://api.github.com/users/hnOsmium0001/following{/other_user}","gists_url":"https://api.github.com/users/hnOsmium0001/gists{/gist_id}","starred_url":"https://api.github.com/users/hnOsmium0001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnOsmium0001/subscriptions","organizations_url":"https://api.github.com/users/hnOsmium0001/orgs","repos_url":"https://api.github.com/users/hnOsmium0001/repos","events_url":"https://api.github.com/users/hnOsmium0001/events{/privacy}","received_events_url":"https://api.github.com/users/hnOsmium0001/received_events","type":"User","site_admin":false},"repo":{"id":169368458,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkzNjg0NTg=","name":"BuildingGadgets","full_name":"hnOsmium0001/BuildingGadgets","private":false,"owner":{"login":"hnOsmium0001","id":36975818,"node_id":"MDQ6VXNlcjM2OTc1ODE4","avatar_url":"https://avatars3.githubusercontent.com/u/36975818?v=4","gravatar_id":"","url":"https://api.github.com/users/hnOsmium0001","html_url":"https://github.com/hnOsmium0001","followers_url":"https://api.github.com/users/hnOsmium0001/followers","following_url":"https://api.github.com/users/hnOsmium0001/following{/other_user}","gists_url":"https://api.github.com/users/hnOsmium0001/gists{/gist_id}","starred_url":"https://api.github.com/users/hnOsmium0001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnOsmium0001/subscriptions","organizations_url":"https://api.github.com/users/hnOsmium0001/orgs","repos_url":"https://api.github.com/users/hnOsmium0001/repos","events_url":"https://api.github.com/users/hnOsmium0001/events{/privacy}","received_events_url":"https://api.github.com/users/hnOsmium0001/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hnOsmium0001/BuildingGadgets","description":null,"fork":true,"url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets","forks_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/forks","keys_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/teams","hooks_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/hooks","issue_events_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/issues/events{/number}","events_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/events","assignees_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/assignees{/user}","branches_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/branches{/branch}","tags_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/tags","blobs_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/statuses/{sha}","languages_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/languages","stargazers_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/stargazers","contributors_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/contributors","subscribers_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/subscribers","subscription_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/subscription","commits_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/contents/{+path}","compare_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/merges","archive_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/downloads","issues_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/issues{/number}","pulls_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/pulls{/number}","milestones_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/milestones{/number}","notifications_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/labels{/name}","releases_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/releases{/id}","deployments_url":"https://api.github.com/repos/hnOsmium0001/BuildingGadgets/deployments","created_at":"2019-02-06T07:16:48Z","updated_at":"2019-03-30T04:14:00Z","pushed_at":"2019-05-12T22:39:14Z","git_url":"git://github.com/hnOsmium0001/BuildingGadgets.git","ssh_url":"git@github.com:hnOsmium0001/BuildingGadgets.git","clone_url":"https://github.com/hnOsmium0001/BuildingGadgets.git","svn_url":"https://github.com/hnOsmium0001/BuildingGadgets","homepage":null,"size":2534,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Direwolf20-MC:1.13.x","ref":"1.13.x","sha":"28b2e4948a60a0d7e27754f2275db6935a98ee31","user":{"login":"Direwolf20-MC","id":39863894,"node_id":"MDQ6VXNlcjM5ODYzODk0","avatar_url":"https://avatars3.githubusercontent.com/u/39863894?v=4","gravatar_id":"","url":"https://api.github.com/users/Direwolf20-MC","html_url":"https://github.com/Direwolf20-MC","followers_url":"https://api.github.com/users/Direwolf20-MC/followers","following_url":"https://api.github.com/users/Direwolf20-MC/following{/other_user}","gists_url":"https://api.github.com/users/Direwolf20-MC/gists{/gist_id}","starred_url":"https://api.github.com/users/Direwolf20-MC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Direwolf20-MC/subscriptions","organizations_url":"https://api.github.com/users/Direwolf20-MC/orgs","repos_url":"https://api.github.com/users/Direwolf20-MC/repos","events_url":"https://api.github.com/users/Direwolf20-MC/events{/privacy}","received_events_url":"https://api.github.com/users/Direwolf20-MC/received_events","type":"User","site_admin":false},"repo":{"id":138338237,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgzMzgyMzc=","name":"BuildingGadgets","full_name":"Direwolf20-MC/BuildingGadgets","private":false,"owner":{"login":"Direwolf20-MC","id":39863894,"node_id":"MDQ6VXNlcjM5ODYzODk0","avatar_url":"https://avatars3.githubusercontent.com/u/39863894?v=4","gravatar_id":"","url":"https://api.github.com/users/Direwolf20-MC","html_url":"https://github.com/Direwolf20-MC","followers_url":"https://api.github.com/users/Direwolf20-MC/followers","following_url":"https://api.github.com/users/Direwolf20-MC/following{/other_user}","gists_url":"https://api.github.com/users/Direwolf20-MC/gists{/gist_id}","starred_url":"https://api.github.com/users/Direwolf20-MC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Direwolf20-MC/subscriptions","organizations_url":"https://api.github.com/users/Direwolf20-MC/orgs","repos_url":"https://api.github.com/users/Direwolf20-MC/repos","events_url":"https://api.github.com/users/Direwolf20-MC/events{/privacy}","received_events_url":"https://api.github.com/users/Direwolf20-MC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Direwolf20-MC/BuildingGadgets","description":null,"fork":false,"url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets","forks_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/forks","keys_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/teams","hooks_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/hooks","issue_events_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/events{/number}","events_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/events","assignees_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/assignees{/user}","branches_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/branches{/branch}","tags_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/tags","blobs_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/languages","stargazers_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/stargazers","contributors_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/contributors","subscribers_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/subscribers","subscription_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/subscription","commits_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/comments{/number}","contents_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/contents/{+path}","compare_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/merges","archive_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/downloads","issues_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues{/number}","pulls_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/labels{/name}","releases_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/releases{/id}","deployments_url":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/deployments","created_at":"2018-06-22T18:56:25Z","updated_at":"2019-05-11T09:33:02Z","pushed_at":"2019-05-12T22:39:15Z","git_url":"git://github.com/Direwolf20-MC/BuildingGadgets.git","ssh_url":"git@github.com:Direwolf20-MC/BuildingGadgets.git","clone_url":"https://github.com/Direwolf20-MC/BuildingGadgets.git","svn_url":"https://github.com/Direwolf20-MC/BuildingGadgets","homepage":null,"size":2479,"stargazers_count":94,"watchers_count":94,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":35,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":38,"open_issues":35,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300"},"html":{"href":"https://github.com/Direwolf20-MC/BuildingGadgets/pull/300"},"issue":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/300"},"comments":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/issues/300/comments"},"review_comments":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300/comments"},"review_comment":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/pulls/300/commits"},"statuses":{"href":"https://api.github.com/repos/Direwolf20-MC/BuildingGadgets/statuses/97a1213fbb3151b75d142eb615fb78dfc103a278"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 138338237,
"name": "Direwolf20-MC/BuildingGadgets",
"url": "https://api.github.com/repos/Direwolf20-MC/BuildingGadgets"
}
|
{
"id": 25031360,
"login": "MajorTuvok",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25031360?",
"url": "https://api.github.com/users/MajorTuvok"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-13T05:00:01 |
9611236340
|
{"actor":{"display_login":"MajorTuvok"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/comments/303366675","pull_request_review_id":261731568,"id":303366675,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzM2NjY3NQ==","diff_hunk":"@@ -7,15 +7,15 @@\n using Xamarin.Forms;\r\n using Xamarin.Forms.Platform.Android;\r\n using System.ComponentModel;\r\n-\r\n+ \r","path":"CarouselView/CarouselView.FormsPlugin.Android/CarouselViewImplementation.cs","position":5,"original_position":5,"commit_id":"4880ef8d0ede6b1026913370f9686159a8343bfe","original_commit_id":"4880ef8d0ede6b1026913370f9686159a8343bfe","user":{"login":"rfsouto","id":1460480,"node_id":"MDQ6VXNlcjE0NjA0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1460480?v=4","gravatar_id":"","url":"https://api.github.com/users/rfsouto","html_url":"https://github.com/rfsouto","followers_url":"https://api.github.com/users/rfsouto/followers","following_url":"https://api.github.com/users/rfsouto/following{/other_user}","gists_url":"https://api.github.com/users/rfsouto/gists{/gist_id}","starred_url":"https://api.github.com/users/rfsouto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfsouto/subscriptions","organizations_url":"https://api.github.com/users/rfsouto/orgs","repos_url":"https://api.github.com/users/rfsouto/repos","events_url":"https://api.github.com/users/rfsouto/events{/privacy}","received_events_url":"https://api.github.com/users/rfsouto/received_events","type":"User","site_admin":false},"body":"no changes ","created_at":"2019-07-15T10:12:14Z","updated_at":"2019-07-15T10:12:14Z","html_url":"https://github.com/alexrainman/CarouselView/pull/533#discussion_r303366675","pull_request_url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/comments/303366675"},"html":{"href":"https://github.com/alexrainman/CarouselView/pull/533#discussion_r303366675"},"pull_request":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533"}}},"pull_request":{"url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533","id":297552003,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NTUyMDAz","html_url":"https://github.com/alexrainman/CarouselView/pull/533","diff_url":"https://github.com/alexrainman/CarouselView/pull/533.diff","patch_url":"https://github.com/alexrainman/CarouselView/pull/533.patch","issue_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/533","number":533,"state":"open","locked":false,"title":"ISSUE: [Android] CarouselView not showing after back navigation #421 ","user":{"login":"rfsouto","id":1460480,"node_id":"MDQ6VXNlcjE0NjA0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1460480?v=4","gravatar_id":"","url":"https://api.github.com/users/rfsouto","html_url":"https://github.com/rfsouto","followers_url":"https://api.github.com/users/rfsouto/followers","following_url":"https://api.github.com/users/rfsouto/following{/other_user}","gists_url":"https://api.github.com/users/rfsouto/gists{/gist_id}","starred_url":"https://api.github.com/users/rfsouto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfsouto/subscriptions","organizations_url":"https://api.github.com/users/rfsouto/orgs","repos_url":"https://api.github.com/users/rfsouto/repos","events_url":"https://api.github.com/users/rfsouto/events{/privacy}","received_events_url":"https://api.github.com/users/rfsouto/received_events","type":"User","site_admin":false},"body":"Your line ends seems not correctly when i edit from mac. \r\nSo i will write the line comments to non-changed lines or groups. ","created_at":"2019-07-15T10:09:02Z","updated_at":"2019-07-15T10:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4ad41079c6a6958b268b3cf49d59da19811abd5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533/commits","review_comments_url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533/comments","review_comment_url":"https://api.github.com/repos/alexrainman/CarouselView/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/533/comments","statuses_url":"https://api.github.com/repos/alexrainman/CarouselView/statuses/4880ef8d0ede6b1026913370f9686159a8343bfe","head":{"label":"rfsouto:master","ref":"master","sha":"4880ef8d0ede6b1026913370f9686159a8343bfe","user":{"login":"rfsouto","id":1460480,"node_id":"MDQ6VXNlcjE0NjA0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1460480?v=4","gravatar_id":"","url":"https://api.github.com/users/rfsouto","html_url":"https://github.com/rfsouto","followers_url":"https://api.github.com/users/rfsouto/followers","following_url":"https://api.github.com/users/rfsouto/following{/other_user}","gists_url":"https://api.github.com/users/rfsouto/gists{/gist_id}","starred_url":"https://api.github.com/users/rfsouto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfsouto/subscriptions","organizations_url":"https://api.github.com/users/rfsouto/orgs","repos_url":"https://api.github.com/users/rfsouto/repos","events_url":"https://api.github.com/users/rfsouto/events{/privacy}","received_events_url":"https://api.github.com/users/rfsouto/received_events","type":"User","site_admin":false},"repo":{"id":171453347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE0NTMzNDc=","name":"CarouselView","full_name":"rfsouto/CarouselView","private":false,"owner":{"login":"rfsouto","id":1460480,"node_id":"MDQ6VXNlcjE0NjA0ODA=","avatar_url":"https://avatars1.githubusercontent.com/u/1460480?v=4","gravatar_id":"","url":"https://api.github.com/users/rfsouto","html_url":"https://github.com/rfsouto","followers_url":"https://api.github.com/users/rfsouto/followers","following_url":"https://api.github.com/users/rfsouto/following{/other_user}","gists_url":"https://api.github.com/users/rfsouto/gists{/gist_id}","starred_url":"https://api.github.com/users/rfsouto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfsouto/subscriptions","organizations_url":"https://api.github.com/users/rfsouto/orgs","repos_url":"https://api.github.com/users/rfsouto/repos","events_url":"https://api.github.com/users/rfsouto/events{/privacy}","received_events_url":"https://api.github.com/users/rfsouto/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rfsouto/CarouselView","description":"CarouselView control for Xamarin Forms","fork":true,"url":"https://api.github.com/repos/rfsouto/CarouselView","forks_url":"https://api.github.com/repos/rfsouto/CarouselView/forks","keys_url":"https://api.github.com/repos/rfsouto/CarouselView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rfsouto/CarouselView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rfsouto/CarouselView/teams","hooks_url":"https://api.github.com/repos/rfsouto/CarouselView/hooks","issue_events_url":"https://api.github.com/repos/rfsouto/CarouselView/issues/events{/number}","events_url":"https://api.github.com/repos/rfsouto/CarouselView/events","assignees_url":"https://api.github.com/repos/rfsouto/CarouselView/assignees{/user}","branches_url":"https://api.github.com/repos/rfsouto/CarouselView/branches{/branch}","tags_url":"https://api.github.com/repos/rfsouto/CarouselView/tags","blobs_url":"https://api.github.com/repos/rfsouto/CarouselView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rfsouto/CarouselView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rfsouto/CarouselView/git/refs{/sha}","trees_url":"https://api.github.com/repos/rfsouto/CarouselView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rfsouto/CarouselView/statuses/{sha}","languages_url":"https://api.github.com/repos/rfsouto/CarouselView/languages","stargazers_url":"https://api.github.com/repos/rfsouto/CarouselView/stargazers","contributors_url":"https://api.github.com/repos/rfsouto/CarouselView/contributors","subscribers_url":"https://api.github.com/repos/rfsouto/CarouselView/subscribers","subscription_url":"https://api.github.com/repos/rfsouto/CarouselView/subscription","commits_url":"https://api.github.com/repos/rfsouto/CarouselView/commits{/sha}","git_commits_url":"https://api.github.com/repos/rfsouto/CarouselView/git/commits{/sha}","comments_url":"https://api.github.com/repos/rfsouto/CarouselView/comments{/number}","issue_comment_url":"https://api.github.com/repos/rfsouto/CarouselView/issues/comments{/number}","contents_url":"https://api.github.com/repos/rfsouto/CarouselView/contents/{+path}","compare_url":"https://api.github.com/repos/rfsouto/CarouselView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rfsouto/CarouselView/merges","archive_url":"https://api.github.com/repos/rfsouto/CarouselView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rfsouto/CarouselView/downloads","issues_url":"https://api.github.com/repos/rfsouto/CarouselView/issues{/number}","pulls_url":"https://api.github.com/repos/rfsouto/CarouselView/pulls{/number}","milestones_url":"https://api.github.com/repos/rfsouto/CarouselView/milestones{/number}","notifications_url":"https://api.github.com/repos/rfsouto/CarouselView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rfsouto/CarouselView/labels{/name}","releases_url":"https://api.github.com/repos/rfsouto/CarouselView/releases{/id}","deployments_url":"https://api.github.com/repos/rfsouto/CarouselView/deployments","created_at":"2019-02-19T10:25:44Z","updated_at":"2019-07-15T10:04:55Z","pushed_at":"2019-07-15T10:04:53Z","git_url":"git://github.com/rfsouto/CarouselView.git","ssh_url":"git@github.com:rfsouto/CarouselView.git","clone_url":"https://github.com/rfsouto/CarouselView.git","svn_url":"https://github.com/rfsouto/CarouselView","homepage":"","size":290403,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexrainman:master","ref":"master","sha":"5296971a52b1cbc36dfac4053f155a69729bd3cd","user":{"login":"alexrainman","id":3793554,"node_id":"MDQ6VXNlcjM3OTM1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3793554?v=4","gravatar_id":"","url":"https://api.github.com/users/alexrainman","html_url":"https://github.com/alexrainman","followers_url":"https://api.github.com/users/alexrainman/followers","following_url":"https://api.github.com/users/alexrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrainman/subscriptions","organizations_url":"https://api.github.com/users/alexrainman/orgs","repos_url":"https://api.github.com/users/alexrainman/repos","events_url":"https://api.github.com/users/alexrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexrainman/received_events","type":"User","site_admin":false},"repo":{"id":50325493,"node_id":"MDEwOlJlcG9zaXRvcnk1MDMyNTQ5Mw==","name":"CarouselView","full_name":"alexrainman/CarouselView","private":false,"owner":{"login":"alexrainman","id":3793554,"node_id":"MDQ6VXNlcjM3OTM1NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3793554?v=4","gravatar_id":"","url":"https://api.github.com/users/alexrainman","html_url":"https://github.com/alexrainman","followers_url":"https://api.github.com/users/alexrainman/followers","following_url":"https://api.github.com/users/alexrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexrainman/subscriptions","organizations_url":"https://api.github.com/users/alexrainman/orgs","repos_url":"https://api.github.com/users/alexrainman/repos","events_url":"https://api.github.com/users/alexrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexrainman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexrainman/CarouselView","description":"CarouselView control for Xamarin Forms","fork":false,"url":"https://api.github.com/repos/alexrainman/CarouselView","forks_url":"https://api.github.com/repos/alexrainman/CarouselView/forks","keys_url":"https://api.github.com/repos/alexrainman/CarouselView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexrainman/CarouselView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexrainman/CarouselView/teams","hooks_url":"https://api.github.com/repos/alexrainman/CarouselView/hooks","issue_events_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/events{/number}","events_url":"https://api.github.com/repos/alexrainman/CarouselView/events","assignees_url":"https://api.github.com/repos/alexrainman/CarouselView/assignees{/user}","branches_url":"https://api.github.com/repos/alexrainman/CarouselView/branches{/branch}","tags_url":"https://api.github.com/repos/alexrainman/CarouselView/tags","blobs_url":"https://api.github.com/repos/alexrainman/CarouselView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexrainman/CarouselView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexrainman/CarouselView/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexrainman/CarouselView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexrainman/CarouselView/statuses/{sha}","languages_url":"https://api.github.com/repos/alexrainman/CarouselView/languages","stargazers_url":"https://api.github.com/repos/alexrainman/CarouselView/stargazers","contributors_url":"https://api.github.com/repos/alexrainman/CarouselView/contributors","subscribers_url":"https://api.github.com/repos/alexrainman/CarouselView/subscribers","subscription_url":"https://api.github.com/repos/alexrainman/CarouselView/subscription","commits_url":"https://api.github.com/repos/alexrainman/CarouselView/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexrainman/CarouselView/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexrainman/CarouselView/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexrainman/CarouselView/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexrainman/CarouselView/contents/{+path}","compare_url":"https://api.github.com/repos/alexrainman/CarouselView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexrainman/CarouselView/merges","archive_url":"https://api.github.com/repos/alexrainman/CarouselView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexrainman/CarouselView/downloads","issues_url":"https://api.github.com/repos/alexrainman/CarouselView/issues{/number}","pulls_url":"https://api.github.com/repos/alexrainman/CarouselView/pulls{/number}","milestones_url":"https://api.github.com/repos/alexrainman/CarouselView/milestones{/number}","notifications_url":"https://api.github.com/repos/alexrainman/CarouselView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexrainman/CarouselView/labels{/name}","releases_url":"https://api.github.com/repos/alexrainman/CarouselView/releases{/id}","deployments_url":"https://api.github.com/repos/alexrainman/CarouselView/deployments","created_at":"2016-01-25T04:13:44Z","updated_at":"2019-07-12T05:48:02Z","pushed_at":"2019-07-15T10:09:03Z","git_url":"git://github.com/alexrainman/CarouselView.git","ssh_url":"git@github.com:alexrainman/CarouselView.git","clone_url":"https://github.com/alexrainman/CarouselView.git","svn_url":"https://github.com/alexrainman/CarouselView","homepage":"","size":290397,"stargazers_count":344,"watchers_count":344,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":43,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":159,"open_issues":43,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533"},"html":{"href":"https://github.com/alexrainman/CarouselView/pull/533"},"issue":{"href":"https://api.github.com/repos/alexrainman/CarouselView/issues/533"},"comments":{"href":"https://api.github.com/repos/alexrainman/CarouselView/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexrainman/CarouselView/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/alexrainman/CarouselView/statuses/4880ef8d0ede6b1026913370f9686159a8343bfe"}},"author_association":"NONE"}}
|
{
"id": 50325493,
"name": "alexrainman/CarouselView",
"url": "https://api.github.com/repos/alexrainman/CarouselView"
}
|
{
"id": 1460480,
"login": "rfsouto",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1460480?",
"url": "https://api.github.com/users/rfsouto"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-07-15T10:12:14 |
10011294634
|
{"actor":{"display_login":"rfsouto"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/comments/337131752","pull_request_review_id":304710149,"id":337131752,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzEzMTc1Mg==","diff_hunk":"@@ -0,0 +1,21 @@\n+{\n+ \"version\": \"3.4.3\",\n+ \"description\": \"Gremlin Server provides a way to remotely execute Gremlin against one or more Graph instances hosted within it.\",\n+ \"homepage\": \"https://tinkerpop.apache.org/\",","path":"bucket/apache-tinkerpop-gremlin-server.json","position":4,"original_position":4,"commit_id":"2140e2bef5fae9b29e9837dbc34b0269ed92e6c3","original_commit_id":"2140e2bef5fae9b29e9837dbc34b0269ed92e6c3","user":{"login":"Ash258","id":13260377,"node_id":"MDQ6VXNlcjEzMjYwMzc3","avatar_url":"https://avatars0.githubusercontent.com/u/13260377?v=4","gravatar_id":"","url":"https://api.github.com/users/Ash258","html_url":"https://github.com/Ash258","followers_url":"https://api.github.com/users/Ash258/followers","following_url":"https://api.github.com/users/Ash258/following{/other_user}","gists_url":"https://api.github.com/users/Ash258/gists{/gist_id}","starred_url":"https://api.github.com/users/Ash258/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ash258/subscriptions","organizations_url":"https://api.github.com/users/Ash258/orgs","repos_url":"https://api.github.com/users/Ash258/repos","events_url":"https://api.github.com/users/Ash258/events{/privacy}","received_events_url":"https://api.github.com/users/Ash258/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n \"homepage\": \"https://tinkerpop.apache.org\",\r\n```","created_at":"2019-10-21T17:02:16Z","updated_at":"2019-10-21T17:02:45Z","html_url":"https://github.com/lukesampson/scoop-extras/pull/2919#discussion_r337131752","pull_request_url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/comments/337131752"},"html":{"href":"https://github.com/lukesampson/scoop-extras/pull/2919#discussion_r337131752"},"pull_request":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919"}}},"pull_request":{"url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919","id":323151859,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzMTUxODU5","html_url":"https://github.com/lukesampson/scoop-extras/pull/2919","diff_url":"https://github.com/lukesampson/scoop-extras/pull/2919.diff","patch_url":"https://github.com/lukesampson/scoop-extras/pull/2919.patch","issue_url":"https://api.github.com/repos/lukesampson/scoop-extras/issues/2919","number":2919,"state":"open","locked":false,"title":"gremlin server","user":{"login":"hanabi1224","id":6546635,"node_id":"MDQ6VXNlcjY1NDY2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6546635?v=4","gravatar_id":"","url":"https://api.github.com/users/hanabi1224","html_url":"https://github.com/hanabi1224","followers_url":"https://api.github.com/users/hanabi1224/followers","following_url":"https://api.github.com/users/hanabi1224/following{/other_user}","gists_url":"https://api.github.com/users/hanabi1224/gists{/gist_id}","starred_url":"https://api.github.com/users/hanabi1224/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanabi1224/subscriptions","organizations_url":"https://api.github.com/users/hanabi1224/orgs","repos_url":"https://api.github.com/users/hanabi1224/repos","events_url":"https://api.github.com/users/hanabi1224/events{/privacy}","received_events_url":"https://api.github.com/users/hanabi1224/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-01T08:39:07Z","updated_at":"2019-10-21T17:02:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c91a11ebb7110d959cbdeffb4f032d38c74d32cd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919/commits","review_comments_url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919/comments","review_comment_url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lukesampson/scoop-extras/issues/2919/comments","statuses_url":"https://api.github.com/repos/lukesampson/scoop-extras/statuses/2140e2bef5fae9b29e9837dbc34b0269ed92e6c3","head":{"label":"hanabi1224:gremlin-server","ref":"gremlin-server","sha":"2140e2bef5fae9b29e9837dbc34b0269ed92e6c3","user":{"login":"hanabi1224","id":6546635,"node_id":"MDQ6VXNlcjY1NDY2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6546635?v=4","gravatar_id":"","url":"https://api.github.com/users/hanabi1224","html_url":"https://github.com/hanabi1224","followers_url":"https://api.github.com/users/hanabi1224/followers","following_url":"https://api.github.com/users/hanabi1224/following{/other_user}","gists_url":"https://api.github.com/users/hanabi1224/gists{/gist_id}","starred_url":"https://api.github.com/users/hanabi1224/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanabi1224/subscriptions","organizations_url":"https://api.github.com/users/hanabi1224/orgs","repos_url":"https://api.github.com/users/hanabi1224/repos","events_url":"https://api.github.com/users/hanabi1224/events{/privacy}","received_events_url":"https://api.github.com/users/hanabi1224/received_events","type":"User","site_admin":false},"repo":{"id":157702096,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc3MDIwOTY=","name":"scoop-extras","full_name":"hanabi1224/scoop-extras","private":false,"owner":{"login":"hanabi1224","id":6546635,"node_id":"MDQ6VXNlcjY1NDY2MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/6546635?v=4","gravatar_id":"","url":"https://api.github.com/users/hanabi1224","html_url":"https://github.com/hanabi1224","followers_url":"https://api.github.com/users/hanabi1224/followers","following_url":"https://api.github.com/users/hanabi1224/following{/other_user}","gists_url":"https://api.github.com/users/hanabi1224/gists{/gist_id}","starred_url":"https://api.github.com/users/hanabi1224/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanabi1224/subscriptions","organizations_url":"https://api.github.com/users/hanabi1224/orgs","repos_url":"https://api.github.com/users/hanabi1224/repos","events_url":"https://api.github.com/users/hanabi1224/events{/privacy}","received_events_url":"https://api.github.com/users/hanabi1224/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hanabi1224/scoop-extras","description":"\"Extras\" bucket for Scoop","fork":true,"url":"https://api.github.com/repos/hanabi1224/scoop-extras","forks_url":"https://api.github.com/repos/hanabi1224/scoop-extras/forks","keys_url":"https://api.github.com/repos/hanabi1224/scoop-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hanabi1224/scoop-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hanabi1224/scoop-extras/teams","hooks_url":"https://api.github.com/repos/hanabi1224/scoop-extras/hooks","issue_events_url":"https://api.github.com/repos/hanabi1224/scoop-extras/issues/events{/number}","events_url":"https://api.github.com/repos/hanabi1224/scoop-extras/events","assignees_url":"https://api.github.com/repos/hanabi1224/scoop-extras/assignees{/user}","branches_url":"https://api.github.com/repos/hanabi1224/scoop-extras/branches{/branch}","tags_url":"https://api.github.com/repos/hanabi1224/scoop-extras/tags","blobs_url":"https://api.github.com/repos/hanabi1224/scoop-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hanabi1224/scoop-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hanabi1224/scoop-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/hanabi1224/scoop-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hanabi1224/scoop-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/hanabi1224/scoop-extras/languages","stargazers_url":"https://api.github.com/repos/hanabi1224/scoop-extras/stargazers","contributors_url":"https://api.github.com/repos/hanabi1224/scoop-extras/contributors","subscribers_url":"https://api.github.com/repos/hanabi1224/scoop-extras/subscribers","subscription_url":"https://api.github.com/repos/hanabi1224/scoop-extras/subscription","commits_url":"https://api.github.com/repos/hanabi1224/scoop-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/hanabi1224/scoop-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/hanabi1224/scoop-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/hanabi1224/scoop-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/hanabi1224/scoop-extras/contents/{+path}","compare_url":"https://api.github.com/repos/hanabi1224/scoop-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hanabi1224/scoop-extras/merges","archive_url":"https://api.github.com/repos/hanabi1224/scoop-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hanabi1224/scoop-extras/downloads","issues_url":"https://api.github.com/repos/hanabi1224/scoop-extras/issues{/number}","pulls_url":"https://api.github.com/repos/hanabi1224/scoop-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/hanabi1224/scoop-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/hanabi1224/scoop-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hanabi1224/scoop-extras/labels{/name}","releases_url":"https://api.github.com/repos/hanabi1224/scoop-extras/releases{/id}","deployments_url":"https://api.github.com/repos/hanabi1224/scoop-extras/deployments","created_at":"2018-11-15T11:43:26Z","updated_at":"2019-10-01T08:38:13Z","pushed_at":"2019-10-01T08:43:45Z","git_url":"git://github.com/hanabi1224/scoop-extras.git","ssh_url":"git@github.com:hanabi1224/scoop-extras.git","clone_url":"https://github.com/hanabi1224/scoop-extras.git","svn_url":"https://github.com/hanabi1224/scoop-extras","homepage":null,"size":8502,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lukesampson:master","ref":"master","sha":"eaa70c55c42df0d9f19bf76909811621ee0c5b92","user":{"login":"lukesampson","id":103446,"node_id":"MDQ6VXNlcjEwMzQ0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/103446?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesampson","html_url":"https://github.com/lukesampson","followers_url":"https://api.github.com/users/lukesampson/followers","following_url":"https://api.github.com/users/lukesampson/following{/other_user}","gists_url":"https://api.github.com/users/lukesampson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesampson/subscriptions","organizations_url":"https://api.github.com/users/lukesampson/orgs","repos_url":"https://api.github.com/users/lukesampson/repos","events_url":"https://api.github.com/users/lukesampson/events{/privacy}","received_events_url":"https://api.github.com/users/lukesampson/received_events","type":"User","site_admin":false},"repo":{"id":11914939,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxNDkzOQ==","name":"scoop-extras","full_name":"lukesampson/scoop-extras","private":false,"owner":{"login":"lukesampson","id":103446,"node_id":"MDQ6VXNlcjEwMzQ0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/103446?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesampson","html_url":"https://github.com/lukesampson","followers_url":"https://api.github.com/users/lukesampson/followers","following_url":"https://api.github.com/users/lukesampson/following{/other_user}","gists_url":"https://api.github.com/users/lukesampson/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesampson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesampson/subscriptions","organizations_url":"https://api.github.com/users/lukesampson/orgs","repos_url":"https://api.github.com/users/lukesampson/repos","events_url":"https://api.github.com/users/lukesampson/events{/privacy}","received_events_url":"https://api.github.com/users/lukesampson/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukesampson/scoop-extras","description":"\"Extras\" bucket for Scoop","fork":false,"url":"https://api.github.com/repos/lukesampson/scoop-extras","forks_url":"https://api.github.com/repos/lukesampson/scoop-extras/forks","keys_url":"https://api.github.com/repos/lukesampson/scoop-extras/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukesampson/scoop-extras/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukesampson/scoop-extras/teams","hooks_url":"https://api.github.com/repos/lukesampson/scoop-extras/hooks","issue_events_url":"https://api.github.com/repos/lukesampson/scoop-extras/issues/events{/number}","events_url":"https://api.github.com/repos/lukesampson/scoop-extras/events","assignees_url":"https://api.github.com/repos/lukesampson/scoop-extras/assignees{/user}","branches_url":"https://api.github.com/repos/lukesampson/scoop-extras/branches{/branch}","tags_url":"https://api.github.com/repos/lukesampson/scoop-extras/tags","blobs_url":"https://api.github.com/repos/lukesampson/scoop-extras/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukesampson/scoop-extras/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukesampson/scoop-extras/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukesampson/scoop-extras/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukesampson/scoop-extras/statuses/{sha}","languages_url":"https://api.github.com/repos/lukesampson/scoop-extras/languages","stargazers_url":"https://api.github.com/repos/lukesampson/scoop-extras/stargazers","contributors_url":"https://api.github.com/repos/lukesampson/scoop-extras/contributors","subscribers_url":"https://api.github.com/repos/lukesampson/scoop-extras/subscribers","subscription_url":"https://api.github.com/repos/lukesampson/scoop-extras/subscription","commits_url":"https://api.github.com/repos/lukesampson/scoop-extras/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukesampson/scoop-extras/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukesampson/scoop-extras/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukesampson/scoop-extras/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukesampson/scoop-extras/contents/{+path}","compare_url":"https://api.github.com/repos/lukesampson/scoop-extras/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukesampson/scoop-extras/merges","archive_url":"https://api.github.com/repos/lukesampson/scoop-extras/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukesampson/scoop-extras/downloads","issues_url":"https://api.github.com/repos/lukesampson/scoop-extras/issues{/number}","pulls_url":"https://api.github.com/repos/lukesampson/scoop-extras/pulls{/number}","milestones_url":"https://api.github.com/repos/lukesampson/scoop-extras/milestones{/number}","notifications_url":"https://api.github.com/repos/lukesampson/scoop-extras/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukesampson/scoop-extras/labels{/name}","releases_url":"https://api.github.com/repos/lukesampson/scoop-extras/releases{/id}","deployments_url":"https://api.github.com/repos/lukesampson/scoop-extras/deployments","created_at":"2013-08-06T03:27:50Z","updated_at":"2019-10-21T17:01:54Z","pushed_at":"2019-10-21T17:01:52Z","git_url":"git://github.com/lukesampson/scoop-extras.git","ssh_url":"git@github.com:lukesampson/scoop-extras.git","clone_url":"https://github.com/lukesampson/scoop-extras.git","svn_url":"https://github.com/lukesampson/scoop-extras","homepage":null,"size":8901,"stargazers_count":604,"watchers_count":604,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":199,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":427,"open_issues":199,"watchers":604,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919"},"html":{"href":"https://github.com/lukesampson/scoop-extras/pull/2919"},"issue":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/issues/2919"},"comments":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/issues/2919/comments"},"review_comments":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919/comments"},"review_comment":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/pulls/2919/commits"},"statuses":{"href":"https://api.github.com/repos/lukesampson/scoop-extras/statuses/2140e2bef5fae9b29e9837dbc34b0269ed92e6c3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 11914939,
"name": "lukesampson/scoop-extras",
"url": "https://api.github.com/repos/lukesampson/scoop-extras"
}
|
{
"id": 13260377,
"login": "Ash258",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13260377?",
"url": "https://api.github.com/users/Ash258"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-10-21T17:02:16 |
10678323390
|
{"actor":{"display_login":"Ash258"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mqueirolo/sync/pulls/comments/312616864","pull_request_review_id":273318855,"id":312616864,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjYxNjg2NA==","diff_hunk":"@@ -185,13 +205,13 @@ function sync_getcourses_fromomega($academicids, $syncinfo, $options = null){\n \treturn array($courses, $syncinfo);\n }\n \n-function sync_getacademicperiod(){\n+function sync_getacademicperiod($academicPeriodId = 0){","path":"locallib.php","position":69,"original_position":69,"commit_id":"033d0487377a4b172f257d24ece9b1c5b8bf8d73","original_commit_id":"033d0487377a4b172f257d24ece9b1c5b8bf8d73","user":{"login":"mqueirolo","id":18581031,"node_id":"MDQ6VXNlcjE4NTgxMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/18581031?v=4","gravatar_id":"","url":"https://api.github.com/users/mqueirolo","html_url":"https://github.com/mqueirolo","followers_url":"https://api.github.com/users/mqueirolo/followers","following_url":"https://api.github.com/users/mqueirolo/following{/other_user}","gists_url":"https://api.github.com/users/mqueirolo/gists{/gist_id}","starred_url":"https://api.github.com/users/mqueirolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqueirolo/subscriptions","organizations_url":"https://api.github.com/users/mqueirolo/orgs","repos_url":"https://api.github.com/users/mqueirolo/repos","events_url":"https://api.github.com/users/mqueirolo/events{/privacy}","received_events_url":"https://api.github.com/users/mqueirolo/received_events","type":"User","site_admin":false},"body":"En minusculas :P","created_at":"2019-08-09T19:19:53Z","updated_at":"2019-08-09T19:19:53Z","html_url":"https://github.com/mqueirolo/sync/pull/3#discussion_r312616864","pull_request_url":"https://api.github.com/repos/mqueirolo/sync/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/comments/312616864"},"html":{"href":"https://github.com/mqueirolo/sync/pull/3#discussion_r312616864"},"pull_request":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/mqueirolo/sync/pulls/3","id":305661434,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NjYxNDM0","html_url":"https://github.com/mqueirolo/sync/pull/3","diff_url":"https://github.com/mqueirolo/sync/pull/3.diff","patch_url":"https://github.com/mqueirolo/sync/pull/3.patch","issue_url":"https://api.github.com/repos/mqueirolo/sync/issues/3","number":3,"state":"open","locked":false,"title":"Sincronización Omega","user":{"login":"jcerdar","id":37182110,"node_id":"MDQ6VXNlcjM3MTgyMTEw","avatar_url":"https://avatars1.githubusercontent.com/u/37182110?v=4","gravatar_id":"","url":"https://api.github.com/users/jcerdar","html_url":"https://github.com/jcerdar","followers_url":"https://api.github.com/users/jcerdar/followers","following_url":"https://api.github.com/users/jcerdar/following{/other_user}","gists_url":"https://api.github.com/users/jcerdar/gists{/gist_id}","starred_url":"https://api.github.com/users/jcerdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcerdar/subscriptions","organizations_url":"https://api.github.com/users/jcerdar/orgs","repos_url":"https://api.github.com/users/jcerdar/repos","events_url":"https://api.github.com/users/jcerdar/events{/privacy}","received_events_url":"https://api.github.com/users/jcerdar/received_events","type":"User","site_admin":false},"body":"Se agregan funcionalidades:\r\n1.- Habilitar la opción para sincronizar un solo periodo académico\r\n2.- Correo de notificación de errores de sincronización\r\n3.- Correos a varios usuarios\r\n4.- Intentos de comunicación en los llamados a las apis de omega\r\n5.- Se corrije mensaje en idioma ingles","created_at":"2019-08-08T16:43:34Z","updated_at":"2019-08-09T19:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2171697bcf5ab1ac04f524bd7db757729d286a9b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mqueirolo/sync/pulls/3/commits","review_comments_url":"https://api.github.com/repos/mqueirolo/sync/pulls/3/comments","review_comment_url":"https://api.github.com/repos/mqueirolo/sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mqueirolo/sync/issues/3/comments","statuses_url":"https://api.github.com/repos/mqueirolo/sync/statuses/033d0487377a4b172f257d24ece9b1c5b8bf8d73","head":{"label":"jcerdar:master","ref":"master","sha":"033d0487377a4b172f257d24ece9b1c5b8bf8d73","user":{"login":"jcerdar","id":37182110,"node_id":"MDQ6VXNlcjM3MTgyMTEw","avatar_url":"https://avatars1.githubusercontent.com/u/37182110?v=4","gravatar_id":"","url":"https://api.github.com/users/jcerdar","html_url":"https://github.com/jcerdar","followers_url":"https://api.github.com/users/jcerdar/followers","following_url":"https://api.github.com/users/jcerdar/following{/other_user}","gists_url":"https://api.github.com/users/jcerdar/gists{/gist_id}","starred_url":"https://api.github.com/users/jcerdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcerdar/subscriptions","organizations_url":"https://api.github.com/users/jcerdar/orgs","repos_url":"https://api.github.com/users/jcerdar/repos","events_url":"https://api.github.com/users/jcerdar/events{/privacy}","received_events_url":"https://api.github.com/users/jcerdar/received_events","type":"User","site_admin":false},"repo":{"id":200122877,"node_id":"MDEwOlJlcG9zaXRvcnkyMDAxMjI4Nzc=","name":"sync","full_name":"jcerdar/sync","private":false,"owner":{"login":"jcerdar","id":37182110,"node_id":"MDQ6VXNlcjM3MTgyMTEw","avatar_url":"https://avatars1.githubusercontent.com/u/37182110?v=4","gravatar_id":"","url":"https://api.github.com/users/jcerdar","html_url":"https://github.com/jcerdar","followers_url":"https://api.github.com/users/jcerdar/followers","following_url":"https://api.github.com/users/jcerdar/following{/other_user}","gists_url":"https://api.github.com/users/jcerdar/gists{/gist_id}","starred_url":"https://api.github.com/users/jcerdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcerdar/subscriptions","organizations_url":"https://api.github.com/users/jcerdar/orgs","repos_url":"https://api.github.com/users/jcerdar/repos","events_url":"https://api.github.com/users/jcerdar/events{/privacy}","received_events_url":"https://api.github.com/users/jcerdar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jcerdar/sync","description":"Synchronizations plugin with Omega for Moodle 3.0+","fork":true,"url":"https://api.github.com/repos/jcerdar/sync","forks_url":"https://api.github.com/repos/jcerdar/sync/forks","keys_url":"https://api.github.com/repos/jcerdar/sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcerdar/sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcerdar/sync/teams","hooks_url":"https://api.github.com/repos/jcerdar/sync/hooks","issue_events_url":"https://api.github.com/repos/jcerdar/sync/issues/events{/number}","events_url":"https://api.github.com/repos/jcerdar/sync/events","assignees_url":"https://api.github.com/repos/jcerdar/sync/assignees{/user}","branches_url":"https://api.github.com/repos/jcerdar/sync/branches{/branch}","tags_url":"https://api.github.com/repos/jcerdar/sync/tags","blobs_url":"https://api.github.com/repos/jcerdar/sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcerdar/sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcerdar/sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcerdar/sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcerdar/sync/statuses/{sha}","languages_url":"https://api.github.com/repos/jcerdar/sync/languages","stargazers_url":"https://api.github.com/repos/jcerdar/sync/stargazers","contributors_url":"https://api.github.com/repos/jcerdar/sync/contributors","subscribers_url":"https://api.github.com/repos/jcerdar/sync/subscribers","subscription_url":"https://api.github.com/repos/jcerdar/sync/subscription","commits_url":"https://api.github.com/repos/jcerdar/sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcerdar/sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcerdar/sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcerdar/sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcerdar/sync/contents/{+path}","compare_url":"https://api.github.com/repos/jcerdar/sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcerdar/sync/merges","archive_url":"https://api.github.com/repos/jcerdar/sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcerdar/sync/downloads","issues_url":"https://api.github.com/repos/jcerdar/sync/issues{/number}","pulls_url":"https://api.github.com/repos/jcerdar/sync/pulls{/number}","milestones_url":"https://api.github.com/repos/jcerdar/sync/milestones{/number}","notifications_url":"https://api.github.com/repos/jcerdar/sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcerdar/sync/labels{/name}","releases_url":"https://api.github.com/repos/jcerdar/sync/releases{/id}","deployments_url":"https://api.github.com/repos/jcerdar/sync/deployments","created_at":"2019-08-01T21:43:32Z","updated_at":"2019-08-08T16:38:32Z","pushed_at":"2019-08-08T16:38:30Z","git_url":"git://github.com/jcerdar/sync.git","ssh_url":"git@github.com:jcerdar/sync.git","clone_url":"https://github.com/jcerdar/sync.git","svn_url":"https://github.com/jcerdar/sync","homepage":"","size":144,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mqueirolo:master","ref":"master","sha":"5378734dcba32468f170de5fca18cf4fa3d79575","user":{"login":"mqueirolo","id":18581031,"node_id":"MDQ6VXNlcjE4NTgxMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/18581031?v=4","gravatar_id":"","url":"https://api.github.com/users/mqueirolo","html_url":"https://github.com/mqueirolo","followers_url":"https://api.github.com/users/mqueirolo/followers","following_url":"https://api.github.com/users/mqueirolo/following{/other_user}","gists_url":"https://api.github.com/users/mqueirolo/gists{/gist_id}","starred_url":"https://api.github.com/users/mqueirolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqueirolo/subscriptions","organizations_url":"https://api.github.com/users/mqueirolo/orgs","repos_url":"https://api.github.com/users/mqueirolo/repos","events_url":"https://api.github.com/users/mqueirolo/events{/privacy}","received_events_url":"https://api.github.com/users/mqueirolo/received_events","type":"User","site_admin":false},"repo":{"id":185464775,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0NjQ3NzU=","name":"sync","full_name":"mqueirolo/sync","private":false,"owner":{"login":"mqueirolo","id":18581031,"node_id":"MDQ6VXNlcjE4NTgxMDMx","avatar_url":"https://avatars2.githubusercontent.com/u/18581031?v=4","gravatar_id":"","url":"https://api.github.com/users/mqueirolo","html_url":"https://github.com/mqueirolo","followers_url":"https://api.github.com/users/mqueirolo/followers","following_url":"https://api.github.com/users/mqueirolo/following{/other_user}","gists_url":"https://api.github.com/users/mqueirolo/gists{/gist_id}","starred_url":"https://api.github.com/users/mqueirolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqueirolo/subscriptions","organizations_url":"https://api.github.com/users/mqueirolo/orgs","repos_url":"https://api.github.com/users/mqueirolo/repos","events_url":"https://api.github.com/users/mqueirolo/events{/privacy}","received_events_url":"https://api.github.com/users/mqueirolo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mqueirolo/sync","description":"Synchronizations plugin with Omega for Moodle 3.0+","fork":true,"url":"https://api.github.com/repos/mqueirolo/sync","forks_url":"https://api.github.com/repos/mqueirolo/sync/forks","keys_url":"https://api.github.com/repos/mqueirolo/sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqueirolo/sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqueirolo/sync/teams","hooks_url":"https://api.github.com/repos/mqueirolo/sync/hooks","issue_events_url":"https://api.github.com/repos/mqueirolo/sync/issues/events{/number}","events_url":"https://api.github.com/repos/mqueirolo/sync/events","assignees_url":"https://api.github.com/repos/mqueirolo/sync/assignees{/user}","branches_url":"https://api.github.com/repos/mqueirolo/sync/branches{/branch}","tags_url":"https://api.github.com/repos/mqueirolo/sync/tags","blobs_url":"https://api.github.com/repos/mqueirolo/sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqueirolo/sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqueirolo/sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqueirolo/sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqueirolo/sync/statuses/{sha}","languages_url":"https://api.github.com/repos/mqueirolo/sync/languages","stargazers_url":"https://api.github.com/repos/mqueirolo/sync/stargazers","contributors_url":"https://api.github.com/repos/mqueirolo/sync/contributors","subscribers_url":"https://api.github.com/repos/mqueirolo/sync/subscribers","subscription_url":"https://api.github.com/repos/mqueirolo/sync/subscription","commits_url":"https://api.github.com/repos/mqueirolo/sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqueirolo/sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqueirolo/sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqueirolo/sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqueirolo/sync/contents/{+path}","compare_url":"https://api.github.com/repos/mqueirolo/sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqueirolo/sync/merges","archive_url":"https://api.github.com/repos/mqueirolo/sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqueirolo/sync/downloads","issues_url":"https://api.github.com/repos/mqueirolo/sync/issues{/number}","pulls_url":"https://api.github.com/repos/mqueirolo/sync/pulls{/number}","milestones_url":"https://api.github.com/repos/mqueirolo/sync/milestones{/number}","notifications_url":"https://api.github.com/repos/mqueirolo/sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqueirolo/sync/labels{/name}","releases_url":"https://api.github.com/repos/mqueirolo/sync/releases{/id}","deployments_url":"https://api.github.com/repos/mqueirolo/sync/deployments","created_at":"2019-05-07T19:22:24Z","updated_at":"2019-05-07T19:22:27Z","pushed_at":"2019-08-08T16:43:35Z","git_url":"git://github.com/mqueirolo/sync.git","ssh_url":"git@github.com:mqueirolo/sync.git","clone_url":"https://github.com/mqueirolo/sync.git","svn_url":"https://github.com/mqueirolo/sync","homepage":"","size":142,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/3"},"html":{"href":"https://github.com/mqueirolo/sync/pull/3"},"issue":{"href":"https://api.github.com/repos/mqueirolo/sync/issues/3"},"comments":{"href":"https://api.github.com/repos/mqueirolo/sync/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mqueirolo/sync/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/mqueirolo/sync/statuses/033d0487377a4b172f257d24ece9b1c5b8bf8d73"}},"author_association":"NONE"}}
|
{
"id": 185464775,
"name": "mqueirolo/sync",
"url": "https://api.github.com/repos/mqueirolo/sync"
}
|
{
"id": 18581031,
"login": "mqueirolo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18581031?",
"url": "https://api.github.com/users/mqueirolo"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-09T19:19:53 |
10183898947
|
{"actor":{"display_login":"mqueirolo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/comments/307101638","pull_request_review_id":266384183,"id":307101638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzEwMTYzOA==","diff_hunk":"@@ -107,10 +124,12 @@ def image_params\n params.require(:image).permit({images:[]})\n end\n \n- def update_item_params\n- params.require(:item).permit(:name, :description, :size_id,:brand,:condition_id,:shipping_payer_id,:shipping_way_id,:shipping_address_id,:shipping_day_id,:price,images_attributes:[:image,:_destroy,:id])\n+ def search\n+ # redirect_to root_path if params[:keyword] == \"\"\n+ # @items = Item.where('name LIKE(?)',\"%#{params[:keyword]}%\")\n end","path":"app/controllers/items_controller.rb","position":67,"original_position":67,"commit_id":"0ec9ddcbaf882acbe75548e818cb603f6b2e857a","original_commit_id":"0ec9ddcbaf882acbe75548e818cb603f6b2e857a","user":{"login":"uratomo","id":51257200,"node_id":"MDQ6VXNlcjUxMjU3MjAw","avatar_url":"https://avatars2.githubusercontent.com/u/51257200?v=4","gravatar_id":"","url":"https://api.github.com/users/uratomo","html_url":"https://github.com/uratomo","followers_url":"https://api.github.com/users/uratomo/followers","following_url":"https://api.github.com/users/uratomo/following{/other_user}","gists_url":"https://api.github.com/users/uratomo/gists{/gist_id}","starred_url":"https://api.github.com/users/uratomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uratomo/subscriptions","organizations_url":"https://api.github.com/users/uratomo/orgs","repos_url":"https://api.github.com/users/uratomo/repos","events_url":"https://api.github.com/users/uratomo/events{/privacy}","received_events_url":"https://api.github.com/users/uratomo/received_events","type":"User","site_admin":false},"body":"他ブランチで使用しております。","created_at":"2019-07-25T03:28:20Z","updated_at":"2019-07-25T03:28:20Z","html_url":"https://github.com/k1taka/freemarket_sample_54c/pull/62#discussion_r307101638","pull_request_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/comments/307101638"},"html":{"href":"https://github.com/k1taka/freemarket_sample_54c/pull/62#discussion_r307101638"},"pull_request":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62"}},"in_reply_to_id":307100380},"pull_request":{"url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62","id":300687242,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNjg3MjQy","html_url":"https://github.com/k1taka/freemarket_sample_54c/pull/62","diff_url":"https://github.com/k1taka/freemarket_sample_54c/pull/62.diff","patch_url":"https://github.com/k1taka/freemarket_sample_54c/pull/62.patch","issue_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/62","number":62,"state":"open","locked":false,"title":"出品編集ページ","user":{"login":"uratomo","id":51257200,"node_id":"MDQ6VXNlcjUxMjU3MjAw","avatar_url":"https://avatars2.githubusercontent.com/u/51257200?v=4","gravatar_id":"","url":"https://api.github.com/users/uratomo","html_url":"https://github.com/uratomo","followers_url":"https://api.github.com/users/uratomo/followers","following_url":"https://api.github.com/users/uratomo/following{/other_user}","gists_url":"https://api.github.com/users/uratomo/gists{/gist_id}","starred_url":"https://api.github.com/users/uratomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uratomo/subscriptions","organizations_url":"https://api.github.com/users/uratomo/orgs","repos_url":"https://api.github.com/users/uratomo/repos","events_url":"https://api.github.com/users/uratomo/events{/privacy}","received_events_url":"https://api.github.com/users/uratomo/received_events","type":"User","site_admin":false},"body":"# What \r\n出品した商品の更新をするページ\r\n\r\n\r\n# Why\r\n出品の内容に変更があった場合に、調整ができるようにするため","created_at":"2019-07-24T11:47:48Z","updated_at":"2019-07-25T03:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfb8b30cbc9906224bb90c8b59e3b8547e78b1a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62/commits","review_comments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62/comments","review_comment_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/62/comments","statuses_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/statuses/0ec9ddcbaf882acbe75548e818cb603f6b2e857a","head":{"label":"k1taka:画像関連","ref":"画像関連","sha":"0ec9ddcbaf882acbe75548e818cb603f6b2e857a","user":{"login":"k1taka","id":33143111,"node_id":"MDQ6VXNlcjMzMTQzMTEx","avatar_url":"https://avatars1.githubusercontent.com/u/33143111?v=4","gravatar_id":"","url":"https://api.github.com/users/k1taka","html_url":"https://github.com/k1taka","followers_url":"https://api.github.com/users/k1taka/followers","following_url":"https://api.github.com/users/k1taka/following{/other_user}","gists_url":"https://api.github.com/users/k1taka/gists{/gist_id}","starred_url":"https://api.github.com/users/k1taka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k1taka/subscriptions","organizations_url":"https://api.github.com/users/k1taka/orgs","repos_url":"https://api.github.com/users/k1taka/repos","events_url":"https://api.github.com/users/k1taka/events{/privacy}","received_events_url":"https://api.github.com/users/k1taka/received_events","type":"User","site_admin":false},"repo":{"id":195515114,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU1MTUxMTQ=","name":"freemarket_sample_54c","full_name":"k1taka/freemarket_sample_54c","private":false,"owner":{"login":"k1taka","id":33143111,"node_id":"MDQ6VXNlcjMzMTQzMTEx","avatar_url":"https://avatars1.githubusercontent.com/u/33143111?v=4","gravatar_id":"","url":"https://api.github.com/users/k1taka","html_url":"https://github.com/k1taka","followers_url":"https://api.github.com/users/k1taka/followers","following_url":"https://api.github.com/users/k1taka/following{/other_user}","gists_url":"https://api.github.com/users/k1taka/gists{/gist_id}","starred_url":"https://api.github.com/users/k1taka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k1taka/subscriptions","organizations_url":"https://api.github.com/users/k1taka/orgs","repos_url":"https://api.github.com/users/k1taka/repos","events_url":"https://api.github.com/users/k1taka/events{/privacy}","received_events_url":"https://api.github.com/users/k1taka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/k1taka/freemarket_sample_54c","description":null,"fork":false,"url":"https://api.github.com/repos/k1taka/freemarket_sample_54c","forks_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/forks","keys_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/teams","hooks_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/hooks","issue_events_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/events{/number}","events_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/events","assignees_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/assignees{/user}","branches_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/branches{/branch}","tags_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/tags","blobs_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/refs{/sha}","trees_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/statuses/{sha}","languages_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/languages","stargazers_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/stargazers","contributors_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/contributors","subscribers_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/subscribers","subscription_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/subscription","commits_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/commits{/sha}","git_commits_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/commits{/sha}","comments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/comments{/number}","issue_comment_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/comments{/number}","contents_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/contents/{+path}","compare_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/merges","archive_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/downloads","issues_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues{/number}","pulls_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls{/number}","milestones_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/milestones{/number}","notifications_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/labels{/name}","releases_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/releases{/id}","deployments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/deployments","created_at":"2019-07-06T08:13:01Z","updated_at":"2019-07-24T13:11:30Z","pushed_at":"2019-07-25T03:10:51Z","git_url":"git://github.com/k1taka/freemarket_sample_54c.git","ssh_url":"git@github.com:k1taka/freemarket_sample_54c.git","clone_url":"https://github.com/k1taka/freemarket_sample_54c.git","svn_url":"https://github.com/k1taka/freemarket_sample_54c","homepage":null,"size":4049,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"k1taka:master","ref":"master","sha":"ef1fe990564f31ae3dc59c90060cc0e6a5720a76","user":{"login":"k1taka","id":33143111,"node_id":"MDQ6VXNlcjMzMTQzMTEx","avatar_url":"https://avatars1.githubusercontent.com/u/33143111?v=4","gravatar_id":"","url":"https://api.github.com/users/k1taka","html_url":"https://github.com/k1taka","followers_url":"https://api.github.com/users/k1taka/followers","following_url":"https://api.github.com/users/k1taka/following{/other_user}","gists_url":"https://api.github.com/users/k1taka/gists{/gist_id}","starred_url":"https://api.github.com/users/k1taka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k1taka/subscriptions","organizations_url":"https://api.github.com/users/k1taka/orgs","repos_url":"https://api.github.com/users/k1taka/repos","events_url":"https://api.github.com/users/k1taka/events{/privacy}","received_events_url":"https://api.github.com/users/k1taka/received_events","type":"User","site_admin":false},"repo":{"id":195515114,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU1MTUxMTQ=","name":"freemarket_sample_54c","full_name":"k1taka/freemarket_sample_54c","private":false,"owner":{"login":"k1taka","id":33143111,"node_id":"MDQ6VXNlcjMzMTQzMTEx","avatar_url":"https://avatars1.githubusercontent.com/u/33143111?v=4","gravatar_id":"","url":"https://api.github.com/users/k1taka","html_url":"https://github.com/k1taka","followers_url":"https://api.github.com/users/k1taka/followers","following_url":"https://api.github.com/users/k1taka/following{/other_user}","gists_url":"https://api.github.com/users/k1taka/gists{/gist_id}","starred_url":"https://api.github.com/users/k1taka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k1taka/subscriptions","organizations_url":"https://api.github.com/users/k1taka/orgs","repos_url":"https://api.github.com/users/k1taka/repos","events_url":"https://api.github.com/users/k1taka/events{/privacy}","received_events_url":"https://api.github.com/users/k1taka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/k1taka/freemarket_sample_54c","description":null,"fork":false,"url":"https://api.github.com/repos/k1taka/freemarket_sample_54c","forks_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/forks","keys_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/teams","hooks_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/hooks","issue_events_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/events{/number}","events_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/events","assignees_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/assignees{/user}","branches_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/branches{/branch}","tags_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/tags","blobs_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/refs{/sha}","trees_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/statuses/{sha}","languages_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/languages","stargazers_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/stargazers","contributors_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/contributors","subscribers_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/subscribers","subscription_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/subscription","commits_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/commits{/sha}","git_commits_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/git/commits{/sha}","comments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/comments{/number}","issue_comment_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/comments{/number}","contents_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/contents/{+path}","compare_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/merges","archive_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/downloads","issues_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues{/number}","pulls_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls{/number}","milestones_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/milestones{/number}","notifications_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/labels{/name}","releases_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/releases{/id}","deployments_url":"https://api.github.com/repos/k1taka/freemarket_sample_54c/deployments","created_at":"2019-07-06T08:13:01Z","updated_at":"2019-07-24T13:11:30Z","pushed_at":"2019-07-25T03:10:51Z","git_url":"git://github.com/k1taka/freemarket_sample_54c.git","ssh_url":"git@github.com:k1taka/freemarket_sample_54c.git","clone_url":"https://github.com/k1taka/freemarket_sample_54c.git","svn_url":"https://github.com/k1taka/freemarket_sample_54c","homepage":null,"size":4049,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62"},"html":{"href":"https://github.com/k1taka/freemarket_sample_54c/pull/62"},"issue":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/62"},"comments":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/k1taka/freemarket_sample_54c/statuses/0ec9ddcbaf882acbe75548e818cb603f6b2e857a"}},"author_association":"COLLABORATOR"}}
|
{
"id": 195515114,
"name": "k1taka/freemarket_sample_54c",
"url": "https://api.github.com/repos/k1taka/freemarket_sample_54c"
}
|
{
"id": 51257200,
"login": "uratomo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51257200?",
"url": "https://api.github.com/users/uratomo"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-07-25T03:28:20 |
10079923467
|
{"actor":{"display_login":"uratomo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/comments/281004204","pull_request_review_id":233761177,"id":281004204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTAwNDIwNA==","diff_hunk":"@@ -0,0 +1,48 @@\n+import React from 'react';\n+import { mount } from 'enzyme';\n+import { MemoryRouter } from 'react-router-dom';\n+import { Provider } from 'react-redux';\n+import configureStore from 'redux-mock-store';\n+import thunk from 'redux-thunk';\n+import SignInPage from '../../containers/signInPage';\n+\n+\n+describe('Signin page', () => {\n+ const mockStore = configureStore([thunk]);\n+ let component;\n+ const stat = {\n+ redFlagDraft: '2',\n+ redFlagResolved: '0',\n+ redFlagInvestigation: '0',\n+ redFlagRejected: '0',\n+ interventionDraft: '5',\n+ interventionResolved: '0',\n+ interventionRejected: '0',\n+ interventionInvestigation: '0'\n+ };\n+ it('should render signin page correctly', () => {\n+ const store = mockStore({\n+ user: {\n+ isLoggedIn: false,\n+ currentUser: {}\n+ },\n+ recordsReducer: {\n+ records: {},\n+ record: {}\n+ },\n+ statReducer: stat\n+ });\n+\n+ component = mount(\n+ <Provider store={store}>\n+ <MemoryRouter>\n+ <SignInPage />\n+ , context:\n+ {}\n+ , attachTo: DOMElement\n+ </MemoryRouter>\n+ </Provider>\n+ );","path":"src/__test__/containers/signInPage.spec.js","position":45,"original_position":45,"commit_id":"086f3e49951a788f3d28917e424e01db619a2a00","original_commit_id":"086f3e49951a788f3d28917e424e01db619a2a00","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unexpected newline before ')' function-paren-newline","created_at":"2019-05-05T04:53:36Z","updated_at":"2019-05-05T04:53:38Z","html_url":"https://github.com/olajide1234/iReporter-in-React/pull/10#discussion_r281004204","pull_request_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/comments/281004204"},"html":{"href":"https://github.com/olajide1234/iReporter-in-React/pull/10#discussion_r281004204"},"pull_request":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10","id":275968527,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1OTY4NTI3","html_url":"https://github.com/olajide1234/iReporter-in-React/pull/10","diff_url":"https://github.com/olajide1234/iReporter-in-React/pull/10.diff","patch_url":"https://github.com/olajide1234/iReporter-in-React/pull/10.patch","issue_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/10","number":10,"state":"open","locked":false,"title":"#165809697: Improve test coverage","user":{"login":"olajide1234","id":42445456,"node_id":"MDQ6VXNlcjQyNDQ1NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/42445456?v=4","gravatar_id":"","url":"https://api.github.com/users/olajide1234","html_url":"https://github.com/olajide1234","followers_url":"https://api.github.com/users/olajide1234/followers","following_url":"https://api.github.com/users/olajide1234/following{/other_user}","gists_url":"https://api.github.com/users/olajide1234/gists{/gist_id}","starred_url":"https://api.github.com/users/olajide1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olajide1234/subscriptions","organizations_url":"https://api.github.com/users/olajide1234/orgs","repos_url":"https://api.github.com/users/olajide1234/repos","events_url":"https://api.github.com/users/olajide1234/events{/privacy}","received_events_url":"https://api.github.com/users/olajide1234/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n- Improve test coverage\r\n\r\n#### Description of the task to be completed?\r\n- Improve test coverage\r\n\r\n#### How should this be manually tested?\r\n- View test coverage in the readme badge\r\n\r\n#### Any background context you want to provide?\r\n- None\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#165809697](https://www.pivotaltracker.com/story/show/165809697)\r\n\r\n#### Screenshots (if appropriate)\r\n- N/A\r\n\r\n#### Questions:\r\n- N/A","created_at":"2019-05-05T04:53:17Z","updated_at":"2019-05-05T04:53:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10/commits","review_comments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10/comments","review_comment_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/comments{/number}","comments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/10/comments","statuses_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/statuses/086f3e49951a788f3d28917e424e01db619a2a00","head":{"label":"olajide1234:bg-improve-testing-#165809697","ref":"bg-improve-testing-#165809697","sha":"086f3e49951a788f3d28917e424e01db619a2a00","user":{"login":"olajide1234","id":42445456,"node_id":"MDQ6VXNlcjQyNDQ1NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/42445456?v=4","gravatar_id":"","url":"https://api.github.com/users/olajide1234","html_url":"https://github.com/olajide1234","followers_url":"https://api.github.com/users/olajide1234/followers","following_url":"https://api.github.com/users/olajide1234/following{/other_user}","gists_url":"https://api.github.com/users/olajide1234/gists{/gist_id}","starred_url":"https://api.github.com/users/olajide1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olajide1234/subscriptions","organizations_url":"https://api.github.com/users/olajide1234/orgs","repos_url":"https://api.github.com/users/olajide1234/repos","events_url":"https://api.github.com/users/olajide1234/events{/privacy}","received_events_url":"https://api.github.com/users/olajide1234/received_events","type":"User","site_admin":false},"repo":{"id":170152987,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNTI5ODc=","name":"iReporter-in-React","full_name":"olajide1234/iReporter-in-React","private":false,"owner":{"login":"olajide1234","id":42445456,"node_id":"MDQ6VXNlcjQyNDQ1NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/42445456?v=4","gravatar_id":"","url":"https://api.github.com/users/olajide1234","html_url":"https://github.com/olajide1234","followers_url":"https://api.github.com/users/olajide1234/followers","following_url":"https://api.github.com/users/olajide1234/following{/other_user}","gists_url":"https://api.github.com/users/olajide1234/gists{/gist_id}","starred_url":"https://api.github.com/users/olajide1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olajide1234/subscriptions","organizations_url":"https://api.github.com/users/olajide1234/orgs","repos_url":"https://api.github.com/users/olajide1234/repos","events_url":"https://api.github.com/users/olajide1234/events{/privacy}","received_events_url":"https://api.github.com/users/olajide1234/received_events","type":"User","site_admin":false},"html_url":"https://github.com/olajide1234/iReporter-in-React","description":"Implementation of iReporter Project in React","fork":false,"url":"https://api.github.com/repos/olajide1234/iReporter-in-React","forks_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/forks","keys_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/teams","hooks_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/hooks","issue_events_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/events{/number}","events_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/events","assignees_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/assignees{/user}","branches_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/branches{/branch}","tags_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/tags","blobs_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/refs{/sha}","trees_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/statuses/{sha}","languages_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/languages","stargazers_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/stargazers","contributors_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/contributors","subscribers_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/subscribers","subscription_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/subscription","commits_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/commits{/sha}","git_commits_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/commits{/sha}","comments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/comments{/number}","issue_comment_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/comments{/number}","contents_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/contents/{+path}","compare_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/merges","archive_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/downloads","issues_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues{/number}","pulls_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls{/number}","milestones_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/milestones{/number}","notifications_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/labels{/name}","releases_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/releases{/id}","deployments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/deployments","created_at":"2019-02-11T15:31:29Z","updated_at":"2019-05-05T04:40:12Z","pushed_at":"2019-05-05T04:53:17Z","git_url":"git://github.com/olajide1234/iReporter-in-React.git","ssh_url":"git@github.com:olajide1234/iReporter-in-React.git","clone_url":"https://github.com/olajide1234/iReporter-in-React.git","svn_url":"https://github.com/olajide1234/iReporter-in-React","homepage":null,"size":779,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"olajide1234:develop","ref":"develop","sha":"2d90c43c32b98530f0f5a0b5f4c95cde70aa5ab1","user":{"login":"olajide1234","id":42445456,"node_id":"MDQ6VXNlcjQyNDQ1NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/42445456?v=4","gravatar_id":"","url":"https://api.github.com/users/olajide1234","html_url":"https://github.com/olajide1234","followers_url":"https://api.github.com/users/olajide1234/followers","following_url":"https://api.github.com/users/olajide1234/following{/other_user}","gists_url":"https://api.github.com/users/olajide1234/gists{/gist_id}","starred_url":"https://api.github.com/users/olajide1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olajide1234/subscriptions","organizations_url":"https://api.github.com/users/olajide1234/orgs","repos_url":"https://api.github.com/users/olajide1234/repos","events_url":"https://api.github.com/users/olajide1234/events{/privacy}","received_events_url":"https://api.github.com/users/olajide1234/received_events","type":"User","site_admin":false},"repo":{"id":170152987,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNTI5ODc=","name":"iReporter-in-React","full_name":"olajide1234/iReporter-in-React","private":false,"owner":{"login":"olajide1234","id":42445456,"node_id":"MDQ6VXNlcjQyNDQ1NDU2","avatar_url":"https://avatars0.githubusercontent.com/u/42445456?v=4","gravatar_id":"","url":"https://api.github.com/users/olajide1234","html_url":"https://github.com/olajide1234","followers_url":"https://api.github.com/users/olajide1234/followers","following_url":"https://api.github.com/users/olajide1234/following{/other_user}","gists_url":"https://api.github.com/users/olajide1234/gists{/gist_id}","starred_url":"https://api.github.com/users/olajide1234/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olajide1234/subscriptions","organizations_url":"https://api.github.com/users/olajide1234/orgs","repos_url":"https://api.github.com/users/olajide1234/repos","events_url":"https://api.github.com/users/olajide1234/events{/privacy}","received_events_url":"https://api.github.com/users/olajide1234/received_events","type":"User","site_admin":false},"html_url":"https://github.com/olajide1234/iReporter-in-React","description":"Implementation of iReporter Project in React","fork":false,"url":"https://api.github.com/repos/olajide1234/iReporter-in-React","forks_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/forks","keys_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/teams","hooks_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/hooks","issue_events_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/events{/number}","events_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/events","assignees_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/assignees{/user}","branches_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/branches{/branch}","tags_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/tags","blobs_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/refs{/sha}","trees_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/statuses/{sha}","languages_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/languages","stargazers_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/stargazers","contributors_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/contributors","subscribers_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/subscribers","subscription_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/subscription","commits_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/commits{/sha}","git_commits_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/git/commits{/sha}","comments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/comments{/number}","issue_comment_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/comments{/number}","contents_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/contents/{+path}","compare_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/merges","archive_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/downloads","issues_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues{/number}","pulls_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls{/number}","milestones_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/milestones{/number}","notifications_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/labels{/name}","releases_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/releases{/id}","deployments_url":"https://api.github.com/repos/olajide1234/iReporter-in-React/deployments","created_at":"2019-02-11T15:31:29Z","updated_at":"2019-05-05T04:40:12Z","pushed_at":"2019-05-05T04:53:17Z","git_url":"git://github.com/olajide1234/iReporter-in-React.git","ssh_url":"git@github.com:olajide1234/iReporter-in-React.git","clone_url":"https://github.com/olajide1234/iReporter-in-React.git","svn_url":"https://github.com/olajide1234/iReporter-in-React","homepage":null,"size":779,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10"},"html":{"href":"https://github.com/olajide1234/iReporter-in-React/pull/10"},"issue":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/10"},"comments":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/olajide1234/iReporter-in-React/statuses/086f3e49951a788f3d28917e424e01db619a2a00"}},"author_association":"OWNER"}}
|
{
"id": 170152987,
"name": "olajide1234/iReporter-in-React",
"url": "https://api.github.com/repos/olajide1234/iReporter-in-React"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-05T04:53:36 |
9564560325
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tnminh00/sample_app/pulls/comments/343513275","pull_request_review_id":313156449,"id":343513275,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MzUxMzI3NQ==","diff_hunk":"@@ -36,23 +36,23 @@ def edit; end\n \n private\n \n- def user_params\n- params.require(:user).permit User::PASSWORD_PARAMS\n- end\n+ def user_params\n+ params.require(:user).permit User::PASSWORD_PARAMS\n+ end\n \n- def get_user\n- @user = User.find_by email: params[:email]\n- end\n+ def get_user\n+ @user = User.find_by email: params[:email]","path":"app/controllers/password_resets_controller.rb","position":15,"original_position":15,"commit_id":"8082c680e525d060b44e6413424010ab6f285296","original_commit_id":"8082c680e525d060b44e6413424010ab6f285296","user":{"login":"hungct-1121","id":49508133,"node_id":"MDQ6VXNlcjQ5NTA4MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/49508133?v=4","gravatar_id":"","url":"https://api.github.com/users/hungct-1121","html_url":"https://github.com/hungct-1121","followers_url":"https://api.github.com/users/hungct-1121/followers","following_url":"https://api.github.com/users/hungct-1121/following{/other_user}","gists_url":"https://api.github.com/users/hungct-1121/gists{/gist_id}","starred_url":"https://api.github.com/users/hungct-1121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungct-1121/subscriptions","organizations_url":"https://api.github.com/users/hungct-1121/orgs","repos_url":"https://api.github.com/users/hungct-1121/repos","events_url":"https://api.github.com/users/hungct-1121/events{/privacy}","received_events_url":"https://api.github.com/users/hungct-1121/received_events","type":"User","site_admin":false},"body":"nếu ko tìm thấy user thì sao em","created_at":"2019-11-07T07:51:52Z","updated_at":"2019-11-07T07:53:48Z","html_url":"https://github.com/tnminh00/sample_app/pull/13#discussion_r343513275","pull_request_url":"https://api.github.com/repos/tnminh00/sample_app/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/comments/343513275"},"html":{"href":"https://github.com/tnminh00/sample_app/pull/13#discussion_r343513275"},"pull_request":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/tnminh00/sample_app/pulls/13","id":337813195,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM3ODEzMTk1","html_url":"https://github.com/tnminh00/sample_app/pull/13","diff_url":"https://github.com/tnminh00/sample_app/pull/13.diff","patch_url":"https://github.com/tnminh00/sample_app/pull/13.patch","issue_url":"https://api.github.com/repos/tnminh00/sample_app/issues/13","number":13,"state":"open","locked":false,"title":"User microposts","user":{"login":"tnminh00","id":39358652,"node_id":"MDQ6VXNlcjM5MzU4NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/39358652?v=4","gravatar_id":"","url":"https://api.github.com/users/tnminh00","html_url":"https://github.com/tnminh00","followers_url":"https://api.github.com/users/tnminh00/followers","following_url":"https://api.github.com/users/tnminh00/following{/other_user}","gists_url":"https://api.github.com/users/tnminh00/gists{/gist_id}","starred_url":"https://api.github.com/users/tnminh00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnminh00/subscriptions","organizations_url":"https://api.github.com/users/tnminh00/orgs","repos_url":"https://api.github.com/users/tnminh00/repos","events_url":"https://api.github.com/users/tnminh00/events{/privacy}","received_events_url":"https://api.github.com/users/tnminh00/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-07T01:38:17Z","updated_at":"2019-11-07T07:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f57a1c4e946620451cc10950fca2ad2009c2cf67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tnminh00/sample_app/pulls/13/commits","review_comments_url":"https://api.github.com/repos/tnminh00/sample_app/pulls/13/comments","review_comment_url":"https://api.github.com/repos/tnminh00/sample_app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tnminh00/sample_app/issues/13/comments","statuses_url":"https://api.github.com/repos/tnminh00/sample_app/statuses/8082c680e525d060b44e6413424010ab6f285296","head":{"label":"tnminh00:user-microposts","ref":"user-microposts","sha":"8082c680e525d060b44e6413424010ab6f285296","user":{"login":"tnminh00","id":39358652,"node_id":"MDQ6VXNlcjM5MzU4NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/39358652?v=4","gravatar_id":"","url":"https://api.github.com/users/tnminh00","html_url":"https://github.com/tnminh00","followers_url":"https://api.github.com/users/tnminh00/followers","following_url":"https://api.github.com/users/tnminh00/following{/other_user}","gists_url":"https://api.github.com/users/tnminh00/gists{/gist_id}","starred_url":"https://api.github.com/users/tnminh00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnminh00/subscriptions","organizations_url":"https://api.github.com/users/tnminh00/orgs","repos_url":"https://api.github.com/users/tnminh00/repos","events_url":"https://api.github.com/users/tnminh00/events{/privacy}","received_events_url":"https://api.github.com/users/tnminh00/received_events","type":"User","site_admin":false},"repo":{"id":215222116,"node_id":"MDEwOlJlcG9zaXRvcnkyMTUyMjIxMTY=","name":"sample_app","full_name":"tnminh00/sample_app","private":false,"owner":{"login":"tnminh00","id":39358652,"node_id":"MDQ6VXNlcjM5MzU4NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/39358652?v=4","gravatar_id":"","url":"https://api.github.com/users/tnminh00","html_url":"https://github.com/tnminh00","followers_url":"https://api.github.com/users/tnminh00/followers","following_url":"https://api.github.com/users/tnminh00/following{/other_user}","gists_url":"https://api.github.com/users/tnminh00/gists{/gist_id}","starred_url":"https://api.github.com/users/tnminh00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnminh00/subscriptions","organizations_url":"https://api.github.com/users/tnminh00/orgs","repos_url":"https://api.github.com/users/tnminh00/repos","events_url":"https://api.github.com/users/tnminh00/events{/privacy}","received_events_url":"https://api.github.com/users/tnminh00/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tnminh00/sample_app","description":null,"fork":false,"url":"https://api.github.com/repos/tnminh00/sample_app","forks_url":"https://api.github.com/repos/tnminh00/sample_app/forks","keys_url":"https://api.github.com/repos/tnminh00/sample_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnminh00/sample_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnminh00/sample_app/teams","hooks_url":"https://api.github.com/repos/tnminh00/sample_app/hooks","issue_events_url":"https://api.github.com/repos/tnminh00/sample_app/issues/events{/number}","events_url":"https://api.github.com/repos/tnminh00/sample_app/events","assignees_url":"https://api.github.com/repos/tnminh00/sample_app/assignees{/user}","branches_url":"https://api.github.com/repos/tnminh00/sample_app/branches{/branch}","tags_url":"https://api.github.com/repos/tnminh00/sample_app/tags","blobs_url":"https://api.github.com/repos/tnminh00/sample_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnminh00/sample_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnminh00/sample_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnminh00/sample_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnminh00/sample_app/statuses/{sha}","languages_url":"https://api.github.com/repos/tnminh00/sample_app/languages","stargazers_url":"https://api.github.com/repos/tnminh00/sample_app/stargazers","contributors_url":"https://api.github.com/repos/tnminh00/sample_app/contributors","subscribers_url":"https://api.github.com/repos/tnminh00/sample_app/subscribers","subscription_url":"https://api.github.com/repos/tnminh00/sample_app/subscription","commits_url":"https://api.github.com/repos/tnminh00/sample_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnminh00/sample_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnminh00/sample_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnminh00/sample_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/tnminh00/sample_app/contents/{+path}","compare_url":"https://api.github.com/repos/tnminh00/sample_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnminh00/sample_app/merges","archive_url":"https://api.github.com/repos/tnminh00/sample_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnminh00/sample_app/downloads","issues_url":"https://api.github.com/repos/tnminh00/sample_app/issues{/number}","pulls_url":"https://api.github.com/repos/tnminh00/sample_app/pulls{/number}","milestones_url":"https://api.github.com/repos/tnminh00/sample_app/milestones{/number}","notifications_url":"https://api.github.com/repos/tnminh00/sample_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnminh00/sample_app/labels{/name}","releases_url":"https://api.github.com/repos/tnminh00/sample_app/releases{/id}","deployments_url":"https://api.github.com/repos/tnminh00/sample_app/deployments","created_at":"2019-10-15T06:20:57Z","updated_at":"2019-11-06T02:07:08Z","pushed_at":"2019-11-07T01:56:43Z","git_url":"git://github.com/tnminh00/sample_app.git","ssh_url":"git@github.com:tnminh00/sample_app.git","clone_url":"https://github.com/tnminh00/sample_app.git","svn_url":"https://github.com/tnminh00/sample_app","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"tnminh00:master","ref":"master","sha":"2e0e0451aa7aa4ef2b4853e48eb1fdb27811c5b5","user":{"login":"tnminh00","id":39358652,"node_id":"MDQ6VXNlcjM5MzU4NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/39358652?v=4","gravatar_id":"","url":"https://api.github.com/users/tnminh00","html_url":"https://github.com/tnminh00","followers_url":"https://api.github.com/users/tnminh00/followers","following_url":"https://api.github.com/users/tnminh00/following{/other_user}","gists_url":"https://api.github.com/users/tnminh00/gists{/gist_id}","starred_url":"https://api.github.com/users/tnminh00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnminh00/subscriptions","organizations_url":"https://api.github.com/users/tnminh00/orgs","repos_url":"https://api.github.com/users/tnminh00/repos","events_url":"https://api.github.com/users/tnminh00/events{/privacy}","received_events_url":"https://api.github.com/users/tnminh00/received_events","type":"User","site_admin":false},"repo":{"id":215222116,"node_id":"MDEwOlJlcG9zaXRvcnkyMTUyMjIxMTY=","name":"sample_app","full_name":"tnminh00/sample_app","private":false,"owner":{"login":"tnminh00","id":39358652,"node_id":"MDQ6VXNlcjM5MzU4NjUy","avatar_url":"https://avatars1.githubusercontent.com/u/39358652?v=4","gravatar_id":"","url":"https://api.github.com/users/tnminh00","html_url":"https://github.com/tnminh00","followers_url":"https://api.github.com/users/tnminh00/followers","following_url":"https://api.github.com/users/tnminh00/following{/other_user}","gists_url":"https://api.github.com/users/tnminh00/gists{/gist_id}","starred_url":"https://api.github.com/users/tnminh00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnminh00/subscriptions","organizations_url":"https://api.github.com/users/tnminh00/orgs","repos_url":"https://api.github.com/users/tnminh00/repos","events_url":"https://api.github.com/users/tnminh00/events{/privacy}","received_events_url":"https://api.github.com/users/tnminh00/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tnminh00/sample_app","description":null,"fork":false,"url":"https://api.github.com/repos/tnminh00/sample_app","forks_url":"https://api.github.com/repos/tnminh00/sample_app/forks","keys_url":"https://api.github.com/repos/tnminh00/sample_app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tnminh00/sample_app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tnminh00/sample_app/teams","hooks_url":"https://api.github.com/repos/tnminh00/sample_app/hooks","issue_events_url":"https://api.github.com/repos/tnminh00/sample_app/issues/events{/number}","events_url":"https://api.github.com/repos/tnminh00/sample_app/events","assignees_url":"https://api.github.com/repos/tnminh00/sample_app/assignees{/user}","branches_url":"https://api.github.com/repos/tnminh00/sample_app/branches{/branch}","tags_url":"https://api.github.com/repos/tnminh00/sample_app/tags","blobs_url":"https://api.github.com/repos/tnminh00/sample_app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tnminh00/sample_app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tnminh00/sample_app/git/refs{/sha}","trees_url":"https://api.github.com/repos/tnminh00/sample_app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tnminh00/sample_app/statuses/{sha}","languages_url":"https://api.github.com/repos/tnminh00/sample_app/languages","stargazers_url":"https://api.github.com/repos/tnminh00/sample_app/stargazers","contributors_url":"https://api.github.com/repos/tnminh00/sample_app/contributors","subscribers_url":"https://api.github.com/repos/tnminh00/sample_app/subscribers","subscription_url":"https://api.github.com/repos/tnminh00/sample_app/subscription","commits_url":"https://api.github.com/repos/tnminh00/sample_app/commits{/sha}","git_commits_url":"https://api.github.com/repos/tnminh00/sample_app/git/commits{/sha}","comments_url":"https://api.github.com/repos/tnminh00/sample_app/comments{/number}","issue_comment_url":"https://api.github.com/repos/tnminh00/sample_app/issues/comments{/number}","contents_url":"https://api.github.com/repos/tnminh00/sample_app/contents/{+path}","compare_url":"https://api.github.com/repos/tnminh00/sample_app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tnminh00/sample_app/merges","archive_url":"https://api.github.com/repos/tnminh00/sample_app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tnminh00/sample_app/downloads","issues_url":"https://api.github.com/repos/tnminh00/sample_app/issues{/number}","pulls_url":"https://api.github.com/repos/tnminh00/sample_app/pulls{/number}","milestones_url":"https://api.github.com/repos/tnminh00/sample_app/milestones{/number}","notifications_url":"https://api.github.com/repos/tnminh00/sample_app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tnminh00/sample_app/labels{/name}","releases_url":"https://api.github.com/repos/tnminh00/sample_app/releases{/id}","deployments_url":"https://api.github.com/repos/tnminh00/sample_app/deployments","created_at":"2019-10-15T06:20:57Z","updated_at":"2019-11-06T02:07:08Z","pushed_at":"2019-11-07T01:56:43Z","git_url":"git://github.com/tnminh00/sample_app.git","ssh_url":"git@github.com:tnminh00/sample_app.git","clone_url":"https://github.com/tnminh00/sample_app.git","svn_url":"https://github.com/tnminh00/sample_app","homepage":null,"size":105,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/13"},"html":{"href":"https://github.com/tnminh00/sample_app/pull/13"},"issue":{"href":"https://api.github.com/repos/tnminh00/sample_app/issues/13"},"comments":{"href":"https://api.github.com/repos/tnminh00/sample_app/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tnminh00/sample_app/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/tnminh00/sample_app/statuses/8082c680e525d060b44e6413424010ab6f285296"}},"author_association":"OWNER"}}
|
{
"id": 215222116,
"name": "tnminh00/sample_app",
"url": "https://api.github.com/repos/tnminh00/sample_app"
}
|
{
"id": 49508133,
"login": "hungct-1121",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49508133?",
"url": "https://api.github.com/users/hungct-1121"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-07T07:51:52 |
10807244522
|
{"actor":{"display_login":"hungct-1121"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/alonthedark/lesson/pulls/comments/328553193","pull_request_review_id":293637706,"id":328553193,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODU1MzE5Mw==","diff_hunk":"@@ -90,6 +92,12 @@ public void pemissionGranted() {\n }\n }\n \n+ private void setAdapter(RecyclerView recycler, List<ContactDB> contactDBS) {\n+ Log.d(TAG, \"adapter\");\n+ ContactListAdapter adapter = new ContactListAdapter(context, mOnCliclListner, contactDBS);\n+ recycler.setAdapter(adapter);\n+ recycler.getAdapter().notifyDataSetChanged();","path":"app/src/main/java/com/example/lesson/ContactListFragment.java","position":99,"original_position":59,"commit_id":"53bcc38bf8a477d13d62f9d082d13f74a35a590b","original_commit_id":"53bcc38bf8a477d13d62f9d082d13f74a35a590b","user":{"login":"goblinr","id":2997073,"node_id":"MDQ6VXNlcjI5OTcwNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/2997073?v=4","gravatar_id":"","url":"https://api.github.com/users/goblinr","html_url":"https://github.com/goblinr","followers_url":"https://api.github.com/users/goblinr/followers","following_url":"https://api.github.com/users/goblinr/following{/other_user}","gists_url":"https://api.github.com/users/goblinr/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinr/subscriptions","organizations_url":"https://api.github.com/users/goblinr/orgs","repos_url":"https://api.github.com/users/goblinr/repos","events_url":"https://api.github.com/users/goblinr/events{/privacy}","received_events_url":"https://api.github.com/users/goblinr/received_events","type":"User","site_admin":false},"body":"`notifyDataSetChanged` вызывать уже не нужно, т.к. ты создаешь здесь абсолютно новый инстанс `ContactListAdapter` - что приводит всякий раз к полной перерисовке списка.\r\n\r\n`notifyDataSetChanged` будет работать только для уже существующего и зарегистрированного в RecyclerView адаптера.","created_at":"2019-09-26T10:43:56Z","updated_at":"2019-09-26T10:46:34Z","html_url":"https://github.com/alonthedark/lesson/pull/1#discussion_r328553193","pull_request_url":"https://api.github.com/repos/alonthedark/lesson/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/comments/328553193"},"html":{"href":"https://github.com/alonthedark/lesson/pull/1#discussion_r328553193"},"pull_request":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/alonthedark/lesson/pulls/1","id":319838633,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5ODM4NjMz","html_url":"https://github.com/alonthedark/lesson/pull/1","diff_url":"https://github.com/alonthedark/lesson/pull/1.diff","patch_url":"https://github.com/alonthedark/lesson/pull/1.patch","issue_url":"https://api.github.com/repos/alonthedark/lesson/issues/1","number":1,"state":"open","locked":false,"title":"Lesson","user":{"login":"alonthedark","id":55486074,"node_id":"MDQ6VXNlcjU1NDg2MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/55486074?v=4","gravatar_id":"","url":"https://api.github.com/users/alonthedark","html_url":"https://github.com/alonthedark","followers_url":"https://api.github.com/users/alonthedark/followers","following_url":"https://api.github.com/users/alonthedark/following{/other_user}","gists_url":"https://api.github.com/users/alonthedark/gists{/gist_id}","starred_url":"https://api.github.com/users/alonthedark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonthedark/subscriptions","organizations_url":"https://api.github.com/users/alonthedark/orgs","repos_url":"https://api.github.com/users/alonthedark/repos","events_url":"https://api.github.com/users/alonthedark/events{/privacy}","received_events_url":"https://api.github.com/users/alonthedark/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-20T18:44:58Z","updated_at":"2019-09-26T10:46:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ac25be1b27b4057d9369e461e9f5089ec3c9315","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alonthedark/lesson/pulls/1/commits","review_comments_url":"https://api.github.com/repos/alonthedark/lesson/pulls/1/comments","review_comment_url":"https://api.github.com/repos/alonthedark/lesson/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alonthedark/lesson/issues/1/comments","statuses_url":"https://api.github.com/repos/alonthedark/lesson/statuses/53bcc38bf8a477d13d62f9d082d13f74a35a590b","head":{"label":"alonthedark:lesson","ref":"lesson","sha":"53bcc38bf8a477d13d62f9d082d13f74a35a590b","user":{"login":"alonthedark","id":55486074,"node_id":"MDQ6VXNlcjU1NDg2MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/55486074?v=4","gravatar_id":"","url":"https://api.github.com/users/alonthedark","html_url":"https://github.com/alonthedark","followers_url":"https://api.github.com/users/alonthedark/followers","following_url":"https://api.github.com/users/alonthedark/following{/other_user}","gists_url":"https://api.github.com/users/alonthedark/gists{/gist_id}","starred_url":"https://api.github.com/users/alonthedark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonthedark/subscriptions","organizations_url":"https://api.github.com/users/alonthedark/orgs","repos_url":"https://api.github.com/users/alonthedark/repos","events_url":"https://api.github.com/users/alonthedark/events{/privacy}","received_events_url":"https://api.github.com/users/alonthedark/received_events","type":"User","site_admin":false},"repo":{"id":209805725,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk4MDU3MjU=","name":"lesson","full_name":"alonthedark/lesson","private":false,"owner":{"login":"alonthedark","id":55486074,"node_id":"MDQ6VXNlcjU1NDg2MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/55486074?v=4","gravatar_id":"","url":"https://api.github.com/users/alonthedark","html_url":"https://github.com/alonthedark","followers_url":"https://api.github.com/users/alonthedark/followers","following_url":"https://api.github.com/users/alonthedark/following{/other_user}","gists_url":"https://api.github.com/users/alonthedark/gists{/gist_id}","starred_url":"https://api.github.com/users/alonthedark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonthedark/subscriptions","organizations_url":"https://api.github.com/users/alonthedark/orgs","repos_url":"https://api.github.com/users/alonthedark/repos","events_url":"https://api.github.com/users/alonthedark/events{/privacy}","received_events_url":"https://api.github.com/users/alonthedark/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alonthedark/lesson","description":null,"fork":false,"url":"https://api.github.com/repos/alonthedark/lesson","forks_url":"https://api.github.com/repos/alonthedark/lesson/forks","keys_url":"https://api.github.com/repos/alonthedark/lesson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alonthedark/lesson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alonthedark/lesson/teams","hooks_url":"https://api.github.com/repos/alonthedark/lesson/hooks","issue_events_url":"https://api.github.com/repos/alonthedark/lesson/issues/events{/number}","events_url":"https://api.github.com/repos/alonthedark/lesson/events","assignees_url":"https://api.github.com/repos/alonthedark/lesson/assignees{/user}","branches_url":"https://api.github.com/repos/alonthedark/lesson/branches{/branch}","tags_url":"https://api.github.com/repos/alonthedark/lesson/tags","blobs_url":"https://api.github.com/repos/alonthedark/lesson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alonthedark/lesson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alonthedark/lesson/git/refs{/sha}","trees_url":"https://api.github.com/repos/alonthedark/lesson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alonthedark/lesson/statuses/{sha}","languages_url":"https://api.github.com/repos/alonthedark/lesson/languages","stargazers_url":"https://api.github.com/repos/alonthedark/lesson/stargazers","contributors_url":"https://api.github.com/repos/alonthedark/lesson/contributors","subscribers_url":"https://api.github.com/repos/alonthedark/lesson/subscribers","subscription_url":"https://api.github.com/repos/alonthedark/lesson/subscription","commits_url":"https://api.github.com/repos/alonthedark/lesson/commits{/sha}","git_commits_url":"https://api.github.com/repos/alonthedark/lesson/git/commits{/sha}","comments_url":"https://api.github.com/repos/alonthedark/lesson/comments{/number}","issue_comment_url":"https://api.github.com/repos/alonthedark/lesson/issues/comments{/number}","contents_url":"https://api.github.com/repos/alonthedark/lesson/contents/{+path}","compare_url":"https://api.github.com/repos/alonthedark/lesson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alonthedark/lesson/merges","archive_url":"https://api.github.com/repos/alonthedark/lesson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alonthedark/lesson/downloads","issues_url":"https://api.github.com/repos/alonthedark/lesson/issues{/number}","pulls_url":"https://api.github.com/repos/alonthedark/lesson/pulls{/number}","milestones_url":"https://api.github.com/repos/alonthedark/lesson/milestones{/number}","notifications_url":"https://api.github.com/repos/alonthedark/lesson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alonthedark/lesson/labels{/name}","releases_url":"https://api.github.com/repos/alonthedark/lesson/releases{/id}","deployments_url":"https://api.github.com/repos/alonthedark/lesson/deployments","created_at":"2019-09-20T14:09:01Z","updated_at":"2019-09-20T14:13:04Z","pushed_at":"2019-09-26T10:06:57Z","git_url":"git://github.com/alonthedark/lesson.git","ssh_url":"git@github.com:alonthedark/lesson.git","clone_url":"https://github.com/alonthedark/lesson.git","svn_url":"https://github.com/alonthedark/lesson","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alonthedark:master","ref":"master","sha":"e8912105d017aad6291cf60239ffea6d028c78b7","user":{"login":"alonthedark","id":55486074,"node_id":"MDQ6VXNlcjU1NDg2MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/55486074?v=4","gravatar_id":"","url":"https://api.github.com/users/alonthedark","html_url":"https://github.com/alonthedark","followers_url":"https://api.github.com/users/alonthedark/followers","following_url":"https://api.github.com/users/alonthedark/following{/other_user}","gists_url":"https://api.github.com/users/alonthedark/gists{/gist_id}","starred_url":"https://api.github.com/users/alonthedark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonthedark/subscriptions","organizations_url":"https://api.github.com/users/alonthedark/orgs","repos_url":"https://api.github.com/users/alonthedark/repos","events_url":"https://api.github.com/users/alonthedark/events{/privacy}","received_events_url":"https://api.github.com/users/alonthedark/received_events","type":"User","site_admin":false},"repo":{"id":209805725,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk4MDU3MjU=","name":"lesson","full_name":"alonthedark/lesson","private":false,"owner":{"login":"alonthedark","id":55486074,"node_id":"MDQ6VXNlcjU1NDg2MDc0","avatar_url":"https://avatars3.githubusercontent.com/u/55486074?v=4","gravatar_id":"","url":"https://api.github.com/users/alonthedark","html_url":"https://github.com/alonthedark","followers_url":"https://api.github.com/users/alonthedark/followers","following_url":"https://api.github.com/users/alonthedark/following{/other_user}","gists_url":"https://api.github.com/users/alonthedark/gists{/gist_id}","starred_url":"https://api.github.com/users/alonthedark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alonthedark/subscriptions","organizations_url":"https://api.github.com/users/alonthedark/orgs","repos_url":"https://api.github.com/users/alonthedark/repos","events_url":"https://api.github.com/users/alonthedark/events{/privacy}","received_events_url":"https://api.github.com/users/alonthedark/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alonthedark/lesson","description":null,"fork":false,"url":"https://api.github.com/repos/alonthedark/lesson","forks_url":"https://api.github.com/repos/alonthedark/lesson/forks","keys_url":"https://api.github.com/repos/alonthedark/lesson/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alonthedark/lesson/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alonthedark/lesson/teams","hooks_url":"https://api.github.com/repos/alonthedark/lesson/hooks","issue_events_url":"https://api.github.com/repos/alonthedark/lesson/issues/events{/number}","events_url":"https://api.github.com/repos/alonthedark/lesson/events","assignees_url":"https://api.github.com/repos/alonthedark/lesson/assignees{/user}","branches_url":"https://api.github.com/repos/alonthedark/lesson/branches{/branch}","tags_url":"https://api.github.com/repos/alonthedark/lesson/tags","blobs_url":"https://api.github.com/repos/alonthedark/lesson/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alonthedark/lesson/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alonthedark/lesson/git/refs{/sha}","trees_url":"https://api.github.com/repos/alonthedark/lesson/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alonthedark/lesson/statuses/{sha}","languages_url":"https://api.github.com/repos/alonthedark/lesson/languages","stargazers_url":"https://api.github.com/repos/alonthedark/lesson/stargazers","contributors_url":"https://api.github.com/repos/alonthedark/lesson/contributors","subscribers_url":"https://api.github.com/repos/alonthedark/lesson/subscribers","subscription_url":"https://api.github.com/repos/alonthedark/lesson/subscription","commits_url":"https://api.github.com/repos/alonthedark/lesson/commits{/sha}","git_commits_url":"https://api.github.com/repos/alonthedark/lesson/git/commits{/sha}","comments_url":"https://api.github.com/repos/alonthedark/lesson/comments{/number}","issue_comment_url":"https://api.github.com/repos/alonthedark/lesson/issues/comments{/number}","contents_url":"https://api.github.com/repos/alonthedark/lesson/contents/{+path}","compare_url":"https://api.github.com/repos/alonthedark/lesson/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alonthedark/lesson/merges","archive_url":"https://api.github.com/repos/alonthedark/lesson/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alonthedark/lesson/downloads","issues_url":"https://api.github.com/repos/alonthedark/lesson/issues{/number}","pulls_url":"https://api.github.com/repos/alonthedark/lesson/pulls{/number}","milestones_url":"https://api.github.com/repos/alonthedark/lesson/milestones{/number}","notifications_url":"https://api.github.com/repos/alonthedark/lesson/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alonthedark/lesson/labels{/name}","releases_url":"https://api.github.com/repos/alonthedark/lesson/releases{/id}","deployments_url":"https://api.github.com/repos/alonthedark/lesson/deployments","created_at":"2019-09-20T14:09:01Z","updated_at":"2019-09-20T14:13:04Z","pushed_at":"2019-09-26T10:06:57Z","git_url":"git://github.com/alonthedark/lesson.git","ssh_url":"git@github.com:alonthedark/lesson.git","clone_url":"https://github.com/alonthedark/lesson.git","svn_url":"https://github.com/alonthedark/lesson","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/1"},"html":{"href":"https://github.com/alonthedark/lesson/pull/1"},"issue":{"href":"https://api.github.com/repos/alonthedark/lesson/issues/1"},"comments":{"href":"https://api.github.com/repos/alonthedark/lesson/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alonthedark/lesson/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/alonthedark/lesson/statuses/53bcc38bf8a477d13d62f9d082d13f74a35a590b"}},"author_association":"OWNER"}}
|
{
"id": 209805725,
"name": "alonthedark/lesson",
"url": "https://api.github.com/repos/alonthedark/lesson"
}
|
{
"id": 2997073,
"login": "goblinr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2997073?",
"url": "https://api.github.com/users/goblinr"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-09-26T10:43:56 |
10500555207
|
{"actor":{"display_login":"goblinr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/comments/288952106","pull_request_review_id":243742652,"id":288952106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODk1MjEwNg==","diff_hunk":"@@ -221,18 +221,18 @@ def variance(col: ColumnOrName) -> Column: ...\n \n class UserDefinedFunction:\n func = ... # type: Callable[..., Any]\n- returnType = ... # type: DataType\n- def __init__(self, func: Callable[..., Any], returnType: DataType, name: Optional[str] = ...) -> None: ...\n+ returnType = ... # type: DataTypeOrString\n+ def __init__(self, func: Callable[..., Any], returnType: DataTypeOrString, name: Optional[str] = ...) -> None: ...\n def __call__(self, *cols: ColumnOrName) -> Column: ...\n \n-def udf(f: Callable[..., Any], returnType: DataType = ...) -> Callable[..., Column]: ...\n+def udf(f: Callable[..., Any], returnType: DataTypeOrString = ...) -> Callable[..., Column]: ...\n \n class PandasUDFType:\n SCALAR: int = ...\n GROUPED_MAP: int = ...\n GROUPED_AGG: int = ...\n \n @overload\n-def pandas_udf(f: Callable[..., pandas.core.series.Series], returnType: StructField, functionType: int) -> Callable[..., Column]: ...\n+def pandas_udf(f: Callable[..., pandas.core.series.Series], returnType: DataTypeOrString, functionType: int = ...) -> Callable[..., Column]: ...\n @overload\n-def pandas_udf(f: Callable[[pandas.core.frame.DataFrame], pandas.core.frame.DataFrame], returnType: StructType, functionType: int) -> Callable[..., Column]: ... # type: ignore\n+def pandas_udf(f: Callable[[pandas.core.frame.DataFrame], pandas.core.frame.DataFrame], returnType: DataTypeOrString, functionType: int = ...) -> Callable[..., Column]: ... # type: ignore","path":"third_party/3/pyspark/sql/functions.pyi","position":36,"original_position":36,"commit_id":"b7776979442d67c371898e5f1f12a1a3c36fde27","original_commit_id":"b7776979442d67c371898e5f1f12a1a3c36fde27","user":{"login":"zero323","id":1554276,"node_id":"MDQ6VXNlcjE1NTQyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554276?v=4","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"body":"ditto","created_at":"2019-05-30T11:18:53Z","updated_at":"2019-05-30T11:21:47Z","html_url":"https://github.com/zero323/pyspark-stubs/pull/137#discussion_r288952106","pull_request_url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/comments/288952106"},"html":{"href":"https://github.com/zero323/pyspark-stubs/pull/137#discussion_r288952106"},"pull_request":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137","id":281636297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxNjM2Mjk3","html_url":"https://github.com/zero323/pyspark-stubs/pull/137","diff_url":"https://github.com/zero323/pyspark-stubs/pull/137.diff","patch_url":"https://github.com/zero323/pyspark-stubs/pull/137.patch","issue_url":"https://api.github.com/repos/zero323/pyspark-stubs/issues/137","number":137,"state":"open","locked":false,"title":"Fix python UDF functions","user":{"login":"harpaj","id":5003144,"node_id":"MDQ6VXNlcjUwMDMxNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5003144?v=4","gravatar_id":"","url":"https://api.github.com/users/harpaj","html_url":"https://github.com/harpaj","followers_url":"https://api.github.com/users/harpaj/followers","following_url":"https://api.github.com/users/harpaj/following{/other_user}","gists_url":"https://api.github.com/users/harpaj/gists{/gist_id}","starred_url":"https://api.github.com/users/harpaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harpaj/subscriptions","organizations_url":"https://api.github.com/users/harpaj/orgs","repos_url":"https://api.github.com/users/harpaj/repos","events_url":"https://api.github.com/users/harpaj/events{/privacy}","received_events_url":"https://api.github.com/users/harpaj/received_events","type":"User","site_admin":false},"body":"Fixes several things around Spark SQL Python UDF functions:\r\n- the `returnType` of both `pandas_udf` overloads was (completely) wrong\r\n- the `functionType` of both `pandas_udf` overloads was not optional\r\n- the `returnType` of all UDF related functions did not allow for type strings - I added a helper for that","created_at":"2019-05-23T14:20:41Z","updated_at":"2019-05-30T11:21:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e374e87f60d0ff968d120a776636a8e7b2e8fe6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137/commits","review_comments_url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137/comments","review_comment_url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zero323/pyspark-stubs/issues/137/comments","statuses_url":"https://api.github.com/repos/zero323/pyspark-stubs/statuses/b7776979442d67c371898e5f1f12a1a3c36fde27","head":{"label":"harpaj:master","ref":"master","sha":"b7776979442d67c371898e5f1f12a1a3c36fde27","user":{"login":"harpaj","id":5003144,"node_id":"MDQ6VXNlcjUwMDMxNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5003144?v=4","gravatar_id":"","url":"https://api.github.com/users/harpaj","html_url":"https://github.com/harpaj","followers_url":"https://api.github.com/users/harpaj/followers","following_url":"https://api.github.com/users/harpaj/following{/other_user}","gists_url":"https://api.github.com/users/harpaj/gists{/gist_id}","starred_url":"https://api.github.com/users/harpaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harpaj/subscriptions","organizations_url":"https://api.github.com/users/harpaj/orgs","repos_url":"https://api.github.com/users/harpaj/repos","events_url":"https://api.github.com/users/harpaj/events{/privacy}","received_events_url":"https://api.github.com/users/harpaj/received_events","type":"User","site_admin":false},"repo":{"id":188247384,"node_id":"MDEwOlJlcG9zaXRvcnkxODgyNDczODQ=","name":"pyspark-stubs","full_name":"harpaj/pyspark-stubs","private":false,"owner":{"login":"harpaj","id":5003144,"node_id":"MDQ6VXNlcjUwMDMxNDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5003144?v=4","gravatar_id":"","url":"https://api.github.com/users/harpaj","html_url":"https://github.com/harpaj","followers_url":"https://api.github.com/users/harpaj/followers","following_url":"https://api.github.com/users/harpaj/following{/other_user}","gists_url":"https://api.github.com/users/harpaj/gists{/gist_id}","starred_url":"https://api.github.com/users/harpaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harpaj/subscriptions","organizations_url":"https://api.github.com/users/harpaj/orgs","repos_url":"https://api.github.com/users/harpaj/repos","events_url":"https://api.github.com/users/harpaj/events{/privacy}","received_events_url":"https://api.github.com/users/harpaj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harpaj/pyspark-stubs","description":"A collection of the Apache Spark stub files. ","fork":true,"url":"https://api.github.com/repos/harpaj/pyspark-stubs","forks_url":"https://api.github.com/repos/harpaj/pyspark-stubs/forks","keys_url":"https://api.github.com/repos/harpaj/pyspark-stubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harpaj/pyspark-stubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harpaj/pyspark-stubs/teams","hooks_url":"https://api.github.com/repos/harpaj/pyspark-stubs/hooks","issue_events_url":"https://api.github.com/repos/harpaj/pyspark-stubs/issues/events{/number}","events_url":"https://api.github.com/repos/harpaj/pyspark-stubs/events","assignees_url":"https://api.github.com/repos/harpaj/pyspark-stubs/assignees{/user}","branches_url":"https://api.github.com/repos/harpaj/pyspark-stubs/branches{/branch}","tags_url":"https://api.github.com/repos/harpaj/pyspark-stubs/tags","blobs_url":"https://api.github.com/repos/harpaj/pyspark-stubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harpaj/pyspark-stubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harpaj/pyspark-stubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/harpaj/pyspark-stubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harpaj/pyspark-stubs/statuses/{sha}","languages_url":"https://api.github.com/repos/harpaj/pyspark-stubs/languages","stargazers_url":"https://api.github.com/repos/harpaj/pyspark-stubs/stargazers","contributors_url":"https://api.github.com/repos/harpaj/pyspark-stubs/contributors","subscribers_url":"https://api.github.com/repos/harpaj/pyspark-stubs/subscribers","subscription_url":"https://api.github.com/repos/harpaj/pyspark-stubs/subscription","commits_url":"https://api.github.com/repos/harpaj/pyspark-stubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/harpaj/pyspark-stubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/harpaj/pyspark-stubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/harpaj/pyspark-stubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/harpaj/pyspark-stubs/contents/{+path}","compare_url":"https://api.github.com/repos/harpaj/pyspark-stubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harpaj/pyspark-stubs/merges","archive_url":"https://api.github.com/repos/harpaj/pyspark-stubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harpaj/pyspark-stubs/downloads","issues_url":"https://api.github.com/repos/harpaj/pyspark-stubs/issues{/number}","pulls_url":"https://api.github.com/repos/harpaj/pyspark-stubs/pulls{/number}","milestones_url":"https://api.github.com/repos/harpaj/pyspark-stubs/milestones{/number}","notifications_url":"https://api.github.com/repos/harpaj/pyspark-stubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harpaj/pyspark-stubs/labels{/name}","releases_url":"https://api.github.com/repos/harpaj/pyspark-stubs/releases{/id}","deployments_url":"https://api.github.com/repos/harpaj/pyspark-stubs/deployments","created_at":"2019-05-23T14:12:37Z","updated_at":"2019-05-23T14:14:22Z","pushed_at":"2019-05-23T14:14:20Z","git_url":"git://github.com/harpaj/pyspark-stubs.git","ssh_url":"git@github.com:harpaj/pyspark-stubs.git","clone_url":"https://github.com/harpaj/pyspark-stubs.git","svn_url":"https://github.com/harpaj/pyspark-stubs","homepage":"","size":394,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zero323:master","ref":"master","sha":"d342ecf191872f6d13bfcf81d8ed915d7c25f0c8","user":{"login":"zero323","id":1554276,"node_id":"MDQ6VXNlcjE1NTQyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554276?v=4","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"repo":{"id":80480364,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQ4MDM2NA==","name":"pyspark-stubs","full_name":"zero323/pyspark-stubs","private":false,"owner":{"login":"zero323","id":1554276,"node_id":"MDQ6VXNlcjE1NTQyNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/1554276?v=4","gravatar_id":"","url":"https://api.github.com/users/zero323","html_url":"https://github.com/zero323","followers_url":"https://api.github.com/users/zero323/followers","following_url":"https://api.github.com/users/zero323/following{/other_user}","gists_url":"https://api.github.com/users/zero323/gists{/gist_id}","starred_url":"https://api.github.com/users/zero323/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero323/subscriptions","organizations_url":"https://api.github.com/users/zero323/orgs","repos_url":"https://api.github.com/users/zero323/repos","events_url":"https://api.github.com/users/zero323/events{/privacy}","received_events_url":"https://api.github.com/users/zero323/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zero323/pyspark-stubs","description":"A collection of the Apache Spark stub files. ","fork":false,"url":"https://api.github.com/repos/zero323/pyspark-stubs","forks_url":"https://api.github.com/repos/zero323/pyspark-stubs/forks","keys_url":"https://api.github.com/repos/zero323/pyspark-stubs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero323/pyspark-stubs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero323/pyspark-stubs/teams","hooks_url":"https://api.github.com/repos/zero323/pyspark-stubs/hooks","issue_events_url":"https://api.github.com/repos/zero323/pyspark-stubs/issues/events{/number}","events_url":"https://api.github.com/repos/zero323/pyspark-stubs/events","assignees_url":"https://api.github.com/repos/zero323/pyspark-stubs/assignees{/user}","branches_url":"https://api.github.com/repos/zero323/pyspark-stubs/branches{/branch}","tags_url":"https://api.github.com/repos/zero323/pyspark-stubs/tags","blobs_url":"https://api.github.com/repos/zero323/pyspark-stubs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero323/pyspark-stubs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero323/pyspark-stubs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero323/pyspark-stubs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero323/pyspark-stubs/statuses/{sha}","languages_url":"https://api.github.com/repos/zero323/pyspark-stubs/languages","stargazers_url":"https://api.github.com/repos/zero323/pyspark-stubs/stargazers","contributors_url":"https://api.github.com/repos/zero323/pyspark-stubs/contributors","subscribers_url":"https://api.github.com/repos/zero323/pyspark-stubs/subscribers","subscription_url":"https://api.github.com/repos/zero323/pyspark-stubs/subscription","commits_url":"https://api.github.com/repos/zero323/pyspark-stubs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero323/pyspark-stubs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero323/pyspark-stubs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero323/pyspark-stubs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero323/pyspark-stubs/contents/{+path}","compare_url":"https://api.github.com/repos/zero323/pyspark-stubs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero323/pyspark-stubs/merges","archive_url":"https://api.github.com/repos/zero323/pyspark-stubs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero323/pyspark-stubs/downloads","issues_url":"https://api.github.com/repos/zero323/pyspark-stubs/issues{/number}","pulls_url":"https://api.github.com/repos/zero323/pyspark-stubs/pulls{/number}","milestones_url":"https://api.github.com/repos/zero323/pyspark-stubs/milestones{/number}","notifications_url":"https://api.github.com/repos/zero323/pyspark-stubs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero323/pyspark-stubs/labels{/name}","releases_url":"https://api.github.com/repos/zero323/pyspark-stubs/releases{/id}","deployments_url":"https://api.github.com/repos/zero323/pyspark-stubs/deployments","created_at":"2017-01-31T01:13:15Z","updated_at":"2019-05-22T10:48:28Z","pushed_at":"2019-05-23T21:29:05Z","git_url":"git://github.com/zero323/pyspark-stubs.git","ssh_url":"git@github.com:zero323/pyspark-stubs.git","clone_url":"https://github.com/zero323/pyspark-stubs.git","svn_url":"https://github.com/zero323/pyspark-stubs","homepage":"","size":393,"stargazers_count":35,"watchers_count":35,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":14,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137"},"html":{"href":"https://github.com/zero323/pyspark-stubs/pull/137"},"issue":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/issues/137"},"comments":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/zero323/pyspark-stubs/statuses/b7776979442d67c371898e5f1f12a1a3c36fde27"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 80480364,
"name": "zero323/pyspark-stubs",
"url": "https://api.github.com/repos/zero323/pyspark-stubs"
}
|
{
"id": 1554276,
"login": "zero323",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1554276?",
"url": "https://api.github.com/users/zero323"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-30T11:18:53 |
9726389020
|
{"actor":{"display_login":"zero323"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/comments/263930664","pull_request_review_id":212480547,"id":263930664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzkzMDY2NA==","diff_hunk":"@@ -47,92 +47,143 @@\n \n (require 'gnus-sum)\n (require 'org-gnus)\n+(require 'rfc2047)\n+(require 'helm-lib)","path":"gnus-recent.el","position":5,"original_position":5,"commit_id":"de30e56651e1c8fdb497a6e80ce877cdb4acaf67","original_commit_id":"de30e56651e1c8fdb497a6e80ce877cdb4acaf67","user":{"login":"deusmax","id":142019,"node_id":"MDQ6VXNlcjE0MjAxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/142019?v=4","gravatar_id":"","url":"https://api.github.com/users/deusmax","html_url":"https://github.com/deusmax","followers_url":"https://api.github.com/users/deusmax/followers","following_url":"https://api.github.com/users/deusmax/following{/other_user}","gists_url":"https://api.github.com/users/deusmax/gists{/gist_id}","starred_url":"https://api.github.com/users/deusmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusmax/subscriptions","organizations_url":"https://api.github.com/users/deusmax/orgs","repos_url":"https://api.github.com/users/deusmax/repos","events_url":"https://api.github.com/users/deusmax/events{/privacy}","received_events_url":"https://api.github.com/users/deusmax/received_events","type":"User","site_admin":false},"body":"replaced use of helm-aif in code.","created_at":"2019-03-08T21:09:22Z","updated_at":"2019-03-08T21:09:22Z","html_url":"https://github.com/unhammer/gnus-recent/pull/11#discussion_r263930664","pull_request_url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/comments/263930664"},"html":{"href":"https://github.com/unhammer/gnus-recent/pull/11#discussion_r263930664"},"pull_request":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11"}},"in_reply_to_id":263695492},"pull_request":{"url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11","id":258703686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4NzAzNjg2","html_url":"https://github.com/unhammer/gnus-recent/pull/11","diff_url":"https://github.com/unhammer/gnus-recent/pull/11.diff","patch_url":"https://github.com/unhammer/gnus-recent/pull/11.patch","issue_url":"https://api.github.com/repos/unhammer/gnus-recent/issues/11","number":11,"state":"open","locked":false,"title":"Featuretrack has some new features","user":{"login":"deusmax","id":142019,"node_id":"MDQ6VXNlcjE0MjAxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/142019?v=4","gravatar_id":"","url":"https://api.github.com/users/deusmax","html_url":"https://github.com/deusmax","followers_url":"https://api.github.com/users/deusmax/followers","following_url":"https://api.github.com/users/deusmax/following{/other_user}","gists_url":"https://api.github.com/users/deusmax/gists{/gist_id}","starred_url":"https://api.github.com/users/deusmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusmax/subscriptions","organizations_url":"https://api.github.com/users/deusmax/orgs","repos_url":"https://api.github.com/users/deusmax/repos","events_url":"https://api.github.com/users/deusmax/events{/privacy}","received_events_url":"https://api.github.com/users/deusmax/received_events","type":"User","site_admin":false},"body":"This includes:\r\n- save-to/read-from file: for persistence between sessions (mostly manual actions)\r\n- hydra for multiple helm persistent actions (keeping session). Key C-j.\r\n- tracking of outgoing messages\r\n- customize interface for some customizations.\r\n- other minor edits.","created_at":"2019-03-06T12:40:52Z","updated_at":"2019-03-08T21:09:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"629e09b3e82560ed9e3bcb401fc1265f6ca371f3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11/commits","review_comments_url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11/comments","review_comment_url":"https://api.github.com/repos/unhammer/gnus-recent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unhammer/gnus-recent/issues/11/comments","statuses_url":"https://api.github.com/repos/unhammer/gnus-recent/statuses/de30e56651e1c8fdb497a6e80ce877cdb4acaf67","head":{"label":"deusmax:featuretrack","ref":"featuretrack","sha":"de30e56651e1c8fdb497a6e80ce877cdb4acaf67","user":{"login":"deusmax","id":142019,"node_id":"MDQ6VXNlcjE0MjAxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/142019?v=4","gravatar_id":"","url":"https://api.github.com/users/deusmax","html_url":"https://github.com/deusmax","followers_url":"https://api.github.com/users/deusmax/followers","following_url":"https://api.github.com/users/deusmax/following{/other_user}","gists_url":"https://api.github.com/users/deusmax/gists{/gist_id}","starred_url":"https://api.github.com/users/deusmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusmax/subscriptions","organizations_url":"https://api.github.com/users/deusmax/orgs","repos_url":"https://api.github.com/users/deusmax/repos","events_url":"https://api.github.com/users/deusmax/events{/privacy}","received_events_url":"https://api.github.com/users/deusmax/received_events","type":"User","site_admin":false},"repo":{"id":163195899,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMxOTU4OTk=","name":"gnus-recent","full_name":"deusmax/gnus-recent","private":false,"owner":{"login":"deusmax","id":142019,"node_id":"MDQ6VXNlcjE0MjAxOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/142019?v=4","gravatar_id":"","url":"https://api.github.com/users/deusmax","html_url":"https://github.com/deusmax","followers_url":"https://api.github.com/users/deusmax/followers","following_url":"https://api.github.com/users/deusmax/following{/other_user}","gists_url":"https://api.github.com/users/deusmax/gists{/gist_id}","starred_url":"https://api.github.com/users/deusmax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deusmax/subscriptions","organizations_url":"https://api.github.com/users/deusmax/orgs","repos_url":"https://api.github.com/users/deusmax/repos","events_url":"https://api.github.com/users/deusmax/events{/privacy}","received_events_url":"https://api.github.com/users/deusmax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/deusmax/gnus-recent","description":"Avoid having to open Gnus and find the right group just to get back to that e-mail you were reading.","fork":true,"url":"https://api.github.com/repos/deusmax/gnus-recent","forks_url":"https://api.github.com/repos/deusmax/gnus-recent/forks","keys_url":"https://api.github.com/repos/deusmax/gnus-recent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deusmax/gnus-recent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deusmax/gnus-recent/teams","hooks_url":"https://api.github.com/repos/deusmax/gnus-recent/hooks","issue_events_url":"https://api.github.com/repos/deusmax/gnus-recent/issues/events{/number}","events_url":"https://api.github.com/repos/deusmax/gnus-recent/events","assignees_url":"https://api.github.com/repos/deusmax/gnus-recent/assignees{/user}","branches_url":"https://api.github.com/repos/deusmax/gnus-recent/branches{/branch}","tags_url":"https://api.github.com/repos/deusmax/gnus-recent/tags","blobs_url":"https://api.github.com/repos/deusmax/gnus-recent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deusmax/gnus-recent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deusmax/gnus-recent/git/refs{/sha}","trees_url":"https://api.github.com/repos/deusmax/gnus-recent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deusmax/gnus-recent/statuses/{sha}","languages_url":"https://api.github.com/repos/deusmax/gnus-recent/languages","stargazers_url":"https://api.github.com/repos/deusmax/gnus-recent/stargazers","contributors_url":"https://api.github.com/repos/deusmax/gnus-recent/contributors","subscribers_url":"https://api.github.com/repos/deusmax/gnus-recent/subscribers","subscription_url":"https://api.github.com/repos/deusmax/gnus-recent/subscription","commits_url":"https://api.github.com/repos/deusmax/gnus-recent/commits{/sha}","git_commits_url":"https://api.github.com/repos/deusmax/gnus-recent/git/commits{/sha}","comments_url":"https://api.github.com/repos/deusmax/gnus-recent/comments{/number}","issue_comment_url":"https://api.github.com/repos/deusmax/gnus-recent/issues/comments{/number}","contents_url":"https://api.github.com/repos/deusmax/gnus-recent/contents/{+path}","compare_url":"https://api.github.com/repos/deusmax/gnus-recent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deusmax/gnus-recent/merges","archive_url":"https://api.github.com/repos/deusmax/gnus-recent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deusmax/gnus-recent/downloads","issues_url":"https://api.github.com/repos/deusmax/gnus-recent/issues{/number}","pulls_url":"https://api.github.com/repos/deusmax/gnus-recent/pulls{/number}","milestones_url":"https://api.github.com/repos/deusmax/gnus-recent/milestones{/number}","notifications_url":"https://api.github.com/repos/deusmax/gnus-recent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deusmax/gnus-recent/labels{/name}","releases_url":"https://api.github.com/repos/deusmax/gnus-recent/releases{/id}","deployments_url":"https://api.github.com/repos/deusmax/gnus-recent/deployments","created_at":"2018-12-26T15:58:52Z","updated_at":"2019-01-14T09:29:39Z","pushed_at":"2019-03-06T12:17:09Z","git_url":"git://github.com/deusmax/gnus-recent.git","ssh_url":"git@github.com:deusmax/gnus-recent.git","clone_url":"https://github.com/deusmax/gnus-recent.git","svn_url":"https://github.com/deusmax/gnus-recent","homepage":null,"size":361,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unhammer:master","ref":"master","sha":"aa705052072b069709714229a8021dae01933d23","user":{"login":"unhammer","id":56868,"node_id":"MDQ6VXNlcjU2ODY4","avatar_url":"https://avatars1.githubusercontent.com/u/56868?v=4","gravatar_id":"","url":"https://api.github.com/users/unhammer","html_url":"https://github.com/unhammer","followers_url":"https://api.github.com/users/unhammer/followers","following_url":"https://api.github.com/users/unhammer/following{/other_user}","gists_url":"https://api.github.com/users/unhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/unhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unhammer/subscriptions","organizations_url":"https://api.github.com/users/unhammer/orgs","repos_url":"https://api.github.com/users/unhammer/repos","events_url":"https://api.github.com/users/unhammer/events{/privacy}","received_events_url":"https://api.github.com/users/unhammer/received_events","type":"User","site_admin":false},"repo":{"id":158598762,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1OTg3NjI=","name":"gnus-recent","full_name":"unhammer/gnus-recent","private":false,"owner":{"login":"unhammer","id":56868,"node_id":"MDQ6VXNlcjU2ODY4","avatar_url":"https://avatars1.githubusercontent.com/u/56868?v=4","gravatar_id":"","url":"https://api.github.com/users/unhammer","html_url":"https://github.com/unhammer","followers_url":"https://api.github.com/users/unhammer/followers","following_url":"https://api.github.com/users/unhammer/following{/other_user}","gists_url":"https://api.github.com/users/unhammer/gists{/gist_id}","starred_url":"https://api.github.com/users/unhammer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unhammer/subscriptions","organizations_url":"https://api.github.com/users/unhammer/orgs","repos_url":"https://api.github.com/users/unhammer/repos","events_url":"https://api.github.com/users/unhammer/events{/privacy}","received_events_url":"https://api.github.com/users/unhammer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/unhammer/gnus-recent","description":"Avoid having to open Gnus and find the right group just to get back to that e-mail you were reading.","fork":false,"url":"https://api.github.com/repos/unhammer/gnus-recent","forks_url":"https://api.github.com/repos/unhammer/gnus-recent/forks","keys_url":"https://api.github.com/repos/unhammer/gnus-recent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unhammer/gnus-recent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unhammer/gnus-recent/teams","hooks_url":"https://api.github.com/repos/unhammer/gnus-recent/hooks","issue_events_url":"https://api.github.com/repos/unhammer/gnus-recent/issues/events{/number}","events_url":"https://api.github.com/repos/unhammer/gnus-recent/events","assignees_url":"https://api.github.com/repos/unhammer/gnus-recent/assignees{/user}","branches_url":"https://api.github.com/repos/unhammer/gnus-recent/branches{/branch}","tags_url":"https://api.github.com/repos/unhammer/gnus-recent/tags","blobs_url":"https://api.github.com/repos/unhammer/gnus-recent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unhammer/gnus-recent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unhammer/gnus-recent/git/refs{/sha}","trees_url":"https://api.github.com/repos/unhammer/gnus-recent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unhammer/gnus-recent/statuses/{sha}","languages_url":"https://api.github.com/repos/unhammer/gnus-recent/languages","stargazers_url":"https://api.github.com/repos/unhammer/gnus-recent/stargazers","contributors_url":"https://api.github.com/repos/unhammer/gnus-recent/contributors","subscribers_url":"https://api.github.com/repos/unhammer/gnus-recent/subscribers","subscription_url":"https://api.github.com/repos/unhammer/gnus-recent/subscription","commits_url":"https://api.github.com/repos/unhammer/gnus-recent/commits{/sha}","git_commits_url":"https://api.github.com/repos/unhammer/gnus-recent/git/commits{/sha}","comments_url":"https://api.github.com/repos/unhammer/gnus-recent/comments{/number}","issue_comment_url":"https://api.github.com/repos/unhammer/gnus-recent/issues/comments{/number}","contents_url":"https://api.github.com/repos/unhammer/gnus-recent/contents/{+path}","compare_url":"https://api.github.com/repos/unhammer/gnus-recent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unhammer/gnus-recent/merges","archive_url":"https://api.github.com/repos/unhammer/gnus-recent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unhammer/gnus-recent/downloads","issues_url":"https://api.github.com/repos/unhammer/gnus-recent/issues{/number}","pulls_url":"https://api.github.com/repos/unhammer/gnus-recent/pulls{/number}","milestones_url":"https://api.github.com/repos/unhammer/gnus-recent/milestones{/number}","notifications_url":"https://api.github.com/repos/unhammer/gnus-recent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unhammer/gnus-recent/labels{/name}","releases_url":"https://api.github.com/repos/unhammer/gnus-recent/releases{/id}","deployments_url":"https://api.github.com/repos/unhammer/gnus-recent/deployments","created_at":"2018-11-21T19:49:39Z","updated_at":"2019-03-06T23:05:44Z","pushed_at":"2019-03-06T12:40:53Z","git_url":"git://github.com/unhammer/gnus-recent.git","ssh_url":"git@github.com:unhammer/gnus-recent.git","clone_url":"https://github.com/unhammer/gnus-recent.git","svn_url":"https://github.com/unhammer/gnus-recent","homepage":null,"size":324,"stargazers_count":7,"watchers_count":7,"language":"Emacs Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":4,"open_issues":4,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11"},"html":{"href":"https://github.com/unhammer/gnus-recent/pull/11"},"issue":{"href":"https://api.github.com/repos/unhammer/gnus-recent/issues/11"},"comments":{"href":"https://api.github.com/repos/unhammer/gnus-recent/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unhammer/gnus-recent/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/unhammer/gnus-recent/statuses/de30e56651e1c8fdb497a6e80ce877cdb4acaf67"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 158598762,
"name": "unhammer/gnus-recent",
"url": "https://api.github.com/repos/unhammer/gnus-recent"
}
|
{
"id": 142019,
"login": "deusmax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/142019?",
"url": "https://api.github.com/users/deusmax"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-03-08T21:09:22 |
9209093863
|
{"actor":{"display_login":"deusmax"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Lv385/Task1_list/pulls/comments/259636629","pull_request_review_id":207167999,"id":259636629,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTYzNjYyOQ==","diff_hunk":"@@ -0,0 +1,189 @@\n+#include \"stdafx.h\"\n+#include \"StringList.h\"\n+\n+#define SIZE_OF_NODE (sizeof(char *) * 2)\n+\n+void StringListInit(char** list)\n+{\n+\t*list = NULL;\n+}\n+\n+void StringListDestroy(char** list)\n+{\n+\tint* prevString = NULL;\n+\tint tmp = get_StringListSize(list);\n+\tint count_strings = 0;\n+\twhile ((int*)*list != NULL)\n+\t{\n+\t\tint* next = (int*)*list;\n+\t\twhile ((int*)*next != NULL)\n+\t\t{\n+\t\t\tcount_strings++;\n+\t\t\tif (count_strings == tmp && tmp != 0)\n+\t\t\t{\n+\t\t\t\tprevString = next;\n+\t\t\t\ttmp--;\n+\t\t\t}\n+\t\t\tnext = (int*)*next;\n+\t\t}\n+\t\t\n+\t\tcount_strings = 0;\n+\t\tfree((void*)((int*)*(next + 1)));\n+\t\tfree((void*)next);\n+\t\t*(int*)(list) = NULL;\t\t\n+\t}\n+}\n+\n+void StringListAdd(char** list, char* str)\n+{\n+\tif (*list)\n+\t{\n+\t\tint* next = (int*)*list;\n+\t\twhile (*next != NULL) next = (int*)*next;\n+\n+\t\tchar* newNode = (char*)malloc(SIZE_OF_NODE);\n+\t\tint* value = (int*)(newNode + sizeof(char*));\n+\t\t*value = (int)malloc(strlen(str) + 1);\n+\t\tstrcpy((char *)*value, str);\n+\t\t*next = (int)newNode;\n+\t\t*((int*)newNode) = NULL;\n+\t}\n+\telse\n+\t{\n+\t\tchar* newNode = (char*)malloc(SIZE_OF_NODE);\n+\t\tint* value = (int*)(newNode + sizeof(char*));\n+\t\t*value = (int)malloc(strlen(str) + 1);\n+\t\tstrcpy((char *)*value, str);\n+\t\t*((int*)newNode) = NULL;\n+\t\t*list = (char*)newNode;\n+","path":"StringList.cpp","position":59,"original_position":59,"commit_id":"ae832c30242313b0e4fc358d164c9dd46341eaee","original_commit_id":"ae832c30242313b0e4fc358d164c9dd46341eaee","user":{"login":"FedorenkoAndriy","id":47578266,"node_id":"MDQ6VXNlcjQ3NTc4MjY2","avatar_url":"https://avatars0.githubusercontent.com/u/47578266?v=4","gravatar_id":"","url":"https://api.github.com/users/FedorenkoAndriy","html_url":"https://github.com/FedorenkoAndriy","followers_url":"https://api.github.com/users/FedorenkoAndriy/followers","following_url":"https://api.github.com/users/FedorenkoAndriy/following{/other_user}","gists_url":"https://api.github.com/users/FedorenkoAndriy/gists{/gist_id}","starred_url":"https://api.github.com/users/FedorenkoAndriy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FedorenkoAndriy/subscriptions","organizations_url":"https://api.github.com/users/FedorenkoAndriy/orgs","repos_url":"https://api.github.com/users/FedorenkoAndriy/repos","events_url":"https://api.github.com/users/FedorenkoAndriy/events{/privacy}","received_events_url":"https://api.github.com/users/FedorenkoAndriy/received_events","type":"User","site_admin":false},"body":"Please remove the empty line","created_at":"2019-02-24T19:34:13Z","updated_at":"2019-02-24T19:34:13Z","html_url":"https://github.com/Lv385/Task1_list/pull/4#discussion_r259636629","pull_request_url":"https://api.github.com/repos/Lv385/Task1_list/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/comments/259636629"},"html":{"href":"https://github.com/Lv385/Task1_list/pull/4#discussion_r259636629"},"pull_request":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Lv385/Task1_list/pulls/4","id":253190026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMTkwMDI2","html_url":"https://github.com/Lv385/Task1_list/pull/4","diff_url":"https://github.com/Lv385/Task1_list/pull/4.diff","patch_url":"https://github.com/Lv385/Task1_list/pull/4.patch","issue_url":"https://api.github.com/repos/Lv385/Task1_list/issues/4","number":4,"state":"open","locked":false,"title":"StringList added","user":{"login":"Lv385","id":47474407,"node_id":"MDQ6VXNlcjQ3NDc0NDA3","avatar_url":"https://avatars2.githubusercontent.com/u/47474407?v=4","gravatar_id":"","url":"https://api.github.com/users/Lv385","html_url":"https://github.com/Lv385","followers_url":"https://api.github.com/users/Lv385/followers","following_url":"https://api.github.com/users/Lv385/following{/other_user}","gists_url":"https://api.github.com/users/Lv385/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv385/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv385/subscriptions","organizations_url":"https://api.github.com/users/Lv385/orgs","repos_url":"https://api.github.com/users/Lv385/repos","events_url":"https://api.github.com/users/Lv385/events{/privacy}","received_events_url":"https://api.github.com/users/Lv385/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-14T19:15:53Z","updated_at":"2019-02-24T19:34:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28400b9753a9ef78a997822efc48c3e12331b715","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lv385/Task1_list/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Lv385/Task1_list/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Lv385/Task1_list/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lv385/Task1_list/issues/4/comments","statuses_url":"https://api.github.com/repos/Lv385/Task1_list/statuses/ae832c30242313b0e4fc358d164c9dd46341eaee","head":{"label":"Lv385:Markiyan","ref":"Markiyan","sha":"ae832c30242313b0e4fc358d164c9dd46341eaee","user":{"login":"Lv385","id":47474407,"node_id":"MDQ6VXNlcjQ3NDc0NDA3","avatar_url":"https://avatars2.githubusercontent.com/u/47474407?v=4","gravatar_id":"","url":"https://api.github.com/users/Lv385","html_url":"https://github.com/Lv385","followers_url":"https://api.github.com/users/Lv385/followers","following_url":"https://api.github.com/users/Lv385/following{/other_user}","gists_url":"https://api.github.com/users/Lv385/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv385/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv385/subscriptions","organizations_url":"https://api.github.com/users/Lv385/orgs","repos_url":"https://api.github.com/users/Lv385/repos","events_url":"https://api.github.com/users/Lv385/events{/privacy}","received_events_url":"https://api.github.com/users/Lv385/received_events","type":"User","site_admin":false},"repo":{"id":170546236,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA1NDYyMzY=","name":"Task1_list","full_name":"Lv385/Task1_list","private":false,"owner":{"login":"Lv385","id":47474407,"node_id":"MDQ6VXNlcjQ3NDc0NDA3","avatar_url":"https://avatars2.githubusercontent.com/u/47474407?v=4","gravatar_id":"","url":"https://api.github.com/users/Lv385","html_url":"https://github.com/Lv385","followers_url":"https://api.github.com/users/Lv385/followers","following_url":"https://api.github.com/users/Lv385/following{/other_user}","gists_url":"https://api.github.com/users/Lv385/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv385/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv385/subscriptions","organizations_url":"https://api.github.com/users/Lv385/orgs","repos_url":"https://api.github.com/users/Lv385/repos","events_url":"https://api.github.com/users/Lv385/events{/privacy}","received_events_url":"https://api.github.com/users/Lv385/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lv385/Task1_list","description":"Linked list implementation without using struct by Lv385.C++","fork":false,"url":"https://api.github.com/repos/Lv385/Task1_list","forks_url":"https://api.github.com/repos/Lv385/Task1_list/forks","keys_url":"https://api.github.com/repos/Lv385/Task1_list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lv385/Task1_list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lv385/Task1_list/teams","hooks_url":"https://api.github.com/repos/Lv385/Task1_list/hooks","issue_events_url":"https://api.github.com/repos/Lv385/Task1_list/issues/events{/number}","events_url":"https://api.github.com/repos/Lv385/Task1_list/events","assignees_url":"https://api.github.com/repos/Lv385/Task1_list/assignees{/user}","branches_url":"https://api.github.com/repos/Lv385/Task1_list/branches{/branch}","tags_url":"https://api.github.com/repos/Lv385/Task1_list/tags","blobs_url":"https://api.github.com/repos/Lv385/Task1_list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lv385/Task1_list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lv385/Task1_list/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lv385/Task1_list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lv385/Task1_list/statuses/{sha}","languages_url":"https://api.github.com/repos/Lv385/Task1_list/languages","stargazers_url":"https://api.github.com/repos/Lv385/Task1_list/stargazers","contributors_url":"https://api.github.com/repos/Lv385/Task1_list/contributors","subscribers_url":"https://api.github.com/repos/Lv385/Task1_list/subscribers","subscription_url":"https://api.github.com/repos/Lv385/Task1_list/subscription","commits_url":"https://api.github.com/repos/Lv385/Task1_list/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lv385/Task1_list/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lv385/Task1_list/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lv385/Task1_list/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lv385/Task1_list/contents/{+path}","compare_url":"https://api.github.com/repos/Lv385/Task1_list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lv385/Task1_list/merges","archive_url":"https://api.github.com/repos/Lv385/Task1_list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lv385/Task1_list/downloads","issues_url":"https://api.github.com/repos/Lv385/Task1_list/issues{/number}","pulls_url":"https://api.github.com/repos/Lv385/Task1_list/pulls{/number}","milestones_url":"https://api.github.com/repos/Lv385/Task1_list/milestones{/number}","notifications_url":"https://api.github.com/repos/Lv385/Task1_list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lv385/Task1_list/labels{/name}","releases_url":"https://api.github.com/repos/Lv385/Task1_list/releases{/id}","deployments_url":"https://api.github.com/repos/Lv385/Task1_list/deployments","created_at":"2019-02-13T17:05:33Z","updated_at":"2019-02-13T17:05:36Z","pushed_at":"2019-02-24T18:34:26Z","git_url":"git://github.com/Lv385/Task1_list.git","ssh_url":"git@github.com:Lv385/Task1_list.git","clone_url":"https://github.com/Lv385/Task1_list.git","svn_url":"https://github.com/Lv385/Task1_list","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"Lv385:master","ref":"master","sha":"7f10a29f08a83606d6b67b1a5c61e7701edcd33f","user":{"login":"Lv385","id":47474407,"node_id":"MDQ6VXNlcjQ3NDc0NDA3","avatar_url":"https://avatars2.githubusercontent.com/u/47474407?v=4","gravatar_id":"","url":"https://api.github.com/users/Lv385","html_url":"https://github.com/Lv385","followers_url":"https://api.github.com/users/Lv385/followers","following_url":"https://api.github.com/users/Lv385/following{/other_user}","gists_url":"https://api.github.com/users/Lv385/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv385/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv385/subscriptions","organizations_url":"https://api.github.com/users/Lv385/orgs","repos_url":"https://api.github.com/users/Lv385/repos","events_url":"https://api.github.com/users/Lv385/events{/privacy}","received_events_url":"https://api.github.com/users/Lv385/received_events","type":"User","site_admin":false},"repo":{"id":170546236,"node_id":"MDEwOlJlcG9zaXRvcnkxNzA1NDYyMzY=","name":"Task1_list","full_name":"Lv385/Task1_list","private":false,"owner":{"login":"Lv385","id":47474407,"node_id":"MDQ6VXNlcjQ3NDc0NDA3","avatar_url":"https://avatars2.githubusercontent.com/u/47474407?v=4","gravatar_id":"","url":"https://api.github.com/users/Lv385","html_url":"https://github.com/Lv385","followers_url":"https://api.github.com/users/Lv385/followers","following_url":"https://api.github.com/users/Lv385/following{/other_user}","gists_url":"https://api.github.com/users/Lv385/gists{/gist_id}","starred_url":"https://api.github.com/users/Lv385/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lv385/subscriptions","organizations_url":"https://api.github.com/users/Lv385/orgs","repos_url":"https://api.github.com/users/Lv385/repos","events_url":"https://api.github.com/users/Lv385/events{/privacy}","received_events_url":"https://api.github.com/users/Lv385/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lv385/Task1_list","description":"Linked list implementation without using struct by Lv385.C++","fork":false,"url":"https://api.github.com/repos/Lv385/Task1_list","forks_url":"https://api.github.com/repos/Lv385/Task1_list/forks","keys_url":"https://api.github.com/repos/Lv385/Task1_list/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lv385/Task1_list/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lv385/Task1_list/teams","hooks_url":"https://api.github.com/repos/Lv385/Task1_list/hooks","issue_events_url":"https://api.github.com/repos/Lv385/Task1_list/issues/events{/number}","events_url":"https://api.github.com/repos/Lv385/Task1_list/events","assignees_url":"https://api.github.com/repos/Lv385/Task1_list/assignees{/user}","branches_url":"https://api.github.com/repos/Lv385/Task1_list/branches{/branch}","tags_url":"https://api.github.com/repos/Lv385/Task1_list/tags","blobs_url":"https://api.github.com/repos/Lv385/Task1_list/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lv385/Task1_list/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lv385/Task1_list/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lv385/Task1_list/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lv385/Task1_list/statuses/{sha}","languages_url":"https://api.github.com/repos/Lv385/Task1_list/languages","stargazers_url":"https://api.github.com/repos/Lv385/Task1_list/stargazers","contributors_url":"https://api.github.com/repos/Lv385/Task1_list/contributors","subscribers_url":"https://api.github.com/repos/Lv385/Task1_list/subscribers","subscription_url":"https://api.github.com/repos/Lv385/Task1_list/subscription","commits_url":"https://api.github.com/repos/Lv385/Task1_list/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lv385/Task1_list/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lv385/Task1_list/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lv385/Task1_list/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lv385/Task1_list/contents/{+path}","compare_url":"https://api.github.com/repos/Lv385/Task1_list/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lv385/Task1_list/merges","archive_url":"https://api.github.com/repos/Lv385/Task1_list/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lv385/Task1_list/downloads","issues_url":"https://api.github.com/repos/Lv385/Task1_list/issues{/number}","pulls_url":"https://api.github.com/repos/Lv385/Task1_list/pulls{/number}","milestones_url":"https://api.github.com/repos/Lv385/Task1_list/milestones{/number}","notifications_url":"https://api.github.com/repos/Lv385/Task1_list/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lv385/Task1_list/labels{/name}","releases_url":"https://api.github.com/repos/Lv385/Task1_list/releases{/id}","deployments_url":"https://api.github.com/repos/Lv385/Task1_list/deployments","created_at":"2019-02-13T17:05:33Z","updated_at":"2019-02-13T17:05:36Z","pushed_at":"2019-02-24T18:34:26Z","git_url":"git://github.com/Lv385/Task1_list.git","ssh_url":"git@github.com:Lv385/Task1_list.git","clone_url":"https://github.com/Lv385/Task1_list.git","svn_url":"https://github.com/Lv385/Task1_list","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/4"},"html":{"href":"https://github.com/Lv385/Task1_list/pull/4"},"issue":{"href":"https://api.github.com/repos/Lv385/Task1_list/issues/4"},"comments":{"href":"https://api.github.com/repos/Lv385/Task1_list/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lv385/Task1_list/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Lv385/Task1_list/statuses/ae832c30242313b0e4fc358d164c9dd46341eaee"}},"author_association":"OWNER"}}
|
{
"id": 170546236,
"name": "Lv385/Task1_list",
"url": "https://api.github.com/repos/Lv385/Task1_list"
}
|
{
"id": 47578266,
"login": "FedorenkoAndriy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47578266?",
"url": "https://api.github.com/users/FedorenkoAndriy"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-02-24T19:34:13 |
9126176588
|
{"actor":{"display_login":"FedorenkoAndriy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/comments/361844426","pull_request_review_id":336952794,"id":361844426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTg0NDQyNg==","diff_hunk":"@@ -29,13 +36,23 @@ if (place_meeting(x, y + vsp, oWall)) {\n y = y + vsp;\n \n // fire bullet\n+<<<<<<< HEAD\n+if (firingDelay < 0 && distance_to_object(oPlayer) < oEnemies.fireRange) {","path":"objects/oEnemyShooter/Step_0.gml","position":23,"original_position":23,"commit_id":"041781e17956840ba88023712cc0a9b4d7fb258c","original_commit_id":"041781e17956840ba88023712cc0a9b4d7fb258c","user":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"body":"You suck!","created_at":"2019-12-29T11:45:51Z","updated_at":"2019-12-29T11:45:52Z","html_url":"https://github.com/ledzappa/seiken-x/pull/22#discussion_r361844426","pull_request_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/comments/361844426"},"html":{"href":"https://github.com/ledzappa/seiken-x/pull/22#discussion_r361844426"},"pull_request":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22"}},"in_reply_to_id":361844402},"pull_request":{"url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22","id":357648925,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NjQ4OTI1","html_url":"https://github.com/ledzappa/seiken-x/pull/22","diff_url":"https://github.com/ledzappa/seiken-x/pull/22.diff","patch_url":"https://github.com/ledzappa/seiken-x/pull/22.patch","issue_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/22","number":22,"state":"open","locked":false,"title":"4 create map 1","user":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-29T11:43:36Z","updated_at":"2019-12-29T11:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8d25494b797eaf584f5b3525df3b4fbb2d7b525","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22/commits","review_comments_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22/comments","review_comment_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/22/comments","statuses_url":"https://api.github.com/repos/ledzappa/seiken-x/statuses/041781e17956840ba88023712cc0a9b4d7fb258c","head":{"label":"ledzappa:4_create_map_1","ref":"4_create_map_1","sha":"041781e17956840ba88023712cc0a9b4d7fb258c","user":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"repo":{"id":162620737,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI2MjA3Mzc=","name":"seiken-x","full_name":"ledzappa/seiken-x","private":false,"owner":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ledzappa/seiken-x","description":null,"fork":false,"url":"https://api.github.com/repos/ledzappa/seiken-x","forks_url":"https://api.github.com/repos/ledzappa/seiken-x/forks","keys_url":"https://api.github.com/repos/ledzappa/seiken-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ledzappa/seiken-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ledzappa/seiken-x/teams","hooks_url":"https://api.github.com/repos/ledzappa/seiken-x/hooks","issue_events_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/events{/number}","events_url":"https://api.github.com/repos/ledzappa/seiken-x/events","assignees_url":"https://api.github.com/repos/ledzappa/seiken-x/assignees{/user}","branches_url":"https://api.github.com/repos/ledzappa/seiken-x/branches{/branch}","tags_url":"https://api.github.com/repos/ledzappa/seiken-x/tags","blobs_url":"https://api.github.com/repos/ledzappa/seiken-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ledzappa/seiken-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ledzappa/seiken-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/ledzappa/seiken-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ledzappa/seiken-x/statuses/{sha}","languages_url":"https://api.github.com/repos/ledzappa/seiken-x/languages","stargazers_url":"https://api.github.com/repos/ledzappa/seiken-x/stargazers","contributors_url":"https://api.github.com/repos/ledzappa/seiken-x/contributors","subscribers_url":"https://api.github.com/repos/ledzappa/seiken-x/subscribers","subscription_url":"https://api.github.com/repos/ledzappa/seiken-x/subscription","commits_url":"https://api.github.com/repos/ledzappa/seiken-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/ledzappa/seiken-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/ledzappa/seiken-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/ledzappa/seiken-x/contents/{+path}","compare_url":"https://api.github.com/repos/ledzappa/seiken-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ledzappa/seiken-x/merges","archive_url":"https://api.github.com/repos/ledzappa/seiken-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ledzappa/seiken-x/downloads","issues_url":"https://api.github.com/repos/ledzappa/seiken-x/issues{/number}","pulls_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls{/number}","milestones_url":"https://api.github.com/repos/ledzappa/seiken-x/milestones{/number}","notifications_url":"https://api.github.com/repos/ledzappa/seiken-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ledzappa/seiken-x/labels{/name}","releases_url":"https://api.github.com/repos/ledzappa/seiken-x/releases{/id}","deployments_url":"https://api.github.com/repos/ledzappa/seiken-x/deployments","created_at":"2018-12-20T19:04:07Z","updated_at":"2019-06-24T20:37:13Z","pushed_at":"2019-12-29T11:43:37Z","git_url":"git://github.com/ledzappa/seiken-x.git","ssh_url":"git@github.com:ledzappa/seiken-x.git","clone_url":"https://github.com/ledzappa/seiken-x.git","svn_url":"https://github.com/ledzappa/seiken-x","homepage":null,"size":9740,"stargazers_count":0,"watchers_count":0,"language":"Game Maker Language","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"ledzappa:master","ref":"master","sha":"7307485cbea017eca804e7cd863bec7704352b00","user":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"repo":{"id":162620737,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI2MjA3Mzc=","name":"seiken-x","full_name":"ledzappa/seiken-x","private":false,"owner":{"login":"ledzappa","id":17250052,"node_id":"MDQ6VXNlcjE3MjUwMDUy","avatar_url":"https://avatars1.githubusercontent.com/u/17250052?v=4","gravatar_id":"","url":"https://api.github.com/users/ledzappa","html_url":"https://github.com/ledzappa","followers_url":"https://api.github.com/users/ledzappa/followers","following_url":"https://api.github.com/users/ledzappa/following{/other_user}","gists_url":"https://api.github.com/users/ledzappa/gists{/gist_id}","starred_url":"https://api.github.com/users/ledzappa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ledzappa/subscriptions","organizations_url":"https://api.github.com/users/ledzappa/orgs","repos_url":"https://api.github.com/users/ledzappa/repos","events_url":"https://api.github.com/users/ledzappa/events{/privacy}","received_events_url":"https://api.github.com/users/ledzappa/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ledzappa/seiken-x","description":null,"fork":false,"url":"https://api.github.com/repos/ledzappa/seiken-x","forks_url":"https://api.github.com/repos/ledzappa/seiken-x/forks","keys_url":"https://api.github.com/repos/ledzappa/seiken-x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ledzappa/seiken-x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ledzappa/seiken-x/teams","hooks_url":"https://api.github.com/repos/ledzappa/seiken-x/hooks","issue_events_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/events{/number}","events_url":"https://api.github.com/repos/ledzappa/seiken-x/events","assignees_url":"https://api.github.com/repos/ledzappa/seiken-x/assignees{/user}","branches_url":"https://api.github.com/repos/ledzappa/seiken-x/branches{/branch}","tags_url":"https://api.github.com/repos/ledzappa/seiken-x/tags","blobs_url":"https://api.github.com/repos/ledzappa/seiken-x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ledzappa/seiken-x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ledzappa/seiken-x/git/refs{/sha}","trees_url":"https://api.github.com/repos/ledzappa/seiken-x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ledzappa/seiken-x/statuses/{sha}","languages_url":"https://api.github.com/repos/ledzappa/seiken-x/languages","stargazers_url":"https://api.github.com/repos/ledzappa/seiken-x/stargazers","contributors_url":"https://api.github.com/repos/ledzappa/seiken-x/contributors","subscribers_url":"https://api.github.com/repos/ledzappa/seiken-x/subscribers","subscription_url":"https://api.github.com/repos/ledzappa/seiken-x/subscription","commits_url":"https://api.github.com/repos/ledzappa/seiken-x/commits{/sha}","git_commits_url":"https://api.github.com/repos/ledzappa/seiken-x/git/commits{/sha}","comments_url":"https://api.github.com/repos/ledzappa/seiken-x/comments{/number}","issue_comment_url":"https://api.github.com/repos/ledzappa/seiken-x/issues/comments{/number}","contents_url":"https://api.github.com/repos/ledzappa/seiken-x/contents/{+path}","compare_url":"https://api.github.com/repos/ledzappa/seiken-x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ledzappa/seiken-x/merges","archive_url":"https://api.github.com/repos/ledzappa/seiken-x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ledzappa/seiken-x/downloads","issues_url":"https://api.github.com/repos/ledzappa/seiken-x/issues{/number}","pulls_url":"https://api.github.com/repos/ledzappa/seiken-x/pulls{/number}","milestones_url":"https://api.github.com/repos/ledzappa/seiken-x/milestones{/number}","notifications_url":"https://api.github.com/repos/ledzappa/seiken-x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ledzappa/seiken-x/labels{/name}","releases_url":"https://api.github.com/repos/ledzappa/seiken-x/releases{/id}","deployments_url":"https://api.github.com/repos/ledzappa/seiken-x/deployments","created_at":"2018-12-20T19:04:07Z","updated_at":"2019-06-24T20:37:13Z","pushed_at":"2019-12-29T11:43:37Z","git_url":"git://github.com/ledzappa/seiken-x.git","ssh_url":"git@github.com:ledzappa/seiken-x.git","clone_url":"https://github.com/ledzappa/seiken-x.git","svn_url":"https://github.com/ledzappa/seiken-x","homepage":null,"size":9740,"stargazers_count":0,"watchers_count":0,"language":"Game Maker Language","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22"},"html":{"href":"https://github.com/ledzappa/seiken-x/pull/22"},"issue":{"href":"https://api.github.com/repos/ledzappa/seiken-x/issues/22"},"comments":{"href":"https://api.github.com/repos/ledzappa/seiken-x/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ledzappa/seiken-x/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/ledzappa/seiken-x/statuses/041781e17956840ba88023712cc0a9b4d7fb258c"}},"author_association":"OWNER"}}
|
{
"id": 162620737,
"name": "ledzappa/seiken-x",
"url": "https://api.github.com/repos/ledzappa/seiken-x"
}
|
{
"id": 17250052,
"login": "ledzappa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17250052?",
"url": "https://api.github.com/users/ledzappa"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-29T11:45:51 |
11173055309
|
{"actor":{"display_login":"ledzappa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/comments/322077812","pull_request_review_id":285296082,"id":322077812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjA3NzgxMg==","diff_hunk":"@@ -0,0 +1,170 @@\n+/* This function is working on Validating employee registartion form\n+*/\n+function register(){\n+ var isValid = true;\n+ resetRegisterElementColor();\n+ var name = document.getElementById(\"name\").value;\n+ // validating name's format\n+ if(!validateName(name)){\n+ document.getElementById(\"name\").style.borderColor = 'orange';\n+ document.getElementById(\"errorname\").innerHTML = \"Invalid Name\";\n+ isValid = false;\n+ }\n+ var empid = document.getElementById(\"id\").value;\n+ if(empid.length == 0){\n+ document.getElementById(\"id\").style.borderColor = 'orange';\n+ document.getElementById(\"errorid\").innerHTML = \"Employee Id Can't Be Null\";\n+ isValid = false;\n+ }\n+ // validating email format\n+ var email = document.getElementById(\"email\").value;\n+ if(!validateEmail(email)){\n+ document.getElementById(\"email\").style.borderColor = 'orange';\n+ document.getElementById(\"erroremail\").innerHTML = \"Invalid Email\";\n+ isValid = false;\n+ }\n+ var password = document.getElementById(\"password\").value;\n+ var confirmPassword = document.getElementById(\"confirm\".value);\n+ // validating passwords\n+ if(!validatePassword(password,confirmPassword)){\n+ document.getElementById(\"password\").style.borderColor = 'orange';\n+ document.getElementById(\"confirm\").style.borderColor = 'orange';\n+ document.getElementById(\"errorpassword\").innerHTML = \"Password Mismatch<br> Invalid Password Format <br>Password must >= 8 <br>password must be alpha numeric<br> it must at least apecial character\";\n+ isValid = false;\n+ }\n+ // validating password\n+ if(isValid){\n+ document.getElementById(\"register\").innerHTML = \"\";\n+ document.getElementById(\"message\").innerHTML = \"You Are Registerd Sucessfully, Your Registration Id is:\"+empid;\n+ document.getElementById(\"message\").style.color = \"#90ee90\";\n+ document.getElementById(\"vehical\").style.display = \"block\";\n+ document.getElementById(\"employeeName\").value = name;\n+ document.getElementById(\"employeeId\").value = empid;\n+ document.getElementById(\"employeeName\").disabled = true;\n+ document.getElementById(\"employeeId\").disabled = true;\n+ }\n+}\n+// checking name validation\n+function validateName(name){\n+ var validName = /^[a-zA-Z ]{2,30}$/;\n+ return validName.test(name);\n+}\n+// checking email validation\n+function validateEmail(email) {\n+ var validMAilExpression = /^[^\\s@]+@[^\\s@]+\\.[^\\s@]+$/;\n+ if(email.length<6 && email.length > 250){\n+ return false;\n+ }\n+ return validMAilExpression.test(String(email).toLowerCase());\n+}\n+// checking password validation\n+function validatePassword(password,confirmPassword){\n+ var validPassword = new RegExp(\"^(?=.*[a-z])(?=.*[A-Z])(?=.*[0-9])(?=.*[!@#\\$%\\^&\\*])(?=.{8,})\");\n+ if(password.localeCompare(confirmPassword)>=1){\n+ return false;\n+ }\n+ return validPassword.test(password);\n+}\n+// resetting all error values, so we can get only occuorange errors on resubmit\n+function resetRegisterElementColor(){\n+ document.getElementById(\"name\").style.borderColor = '';\n+ document.getElementById(\"errorname\").innerHTML = \"\";\n+ document.getElementById(\"email\").style.borderColor = '';\n+ document.getElementById(\"erroremail\").innerHTML = \"\";\n+ document.getElementById(\"password\").style.borderColor = '';\n+ document.getElementById(\"confirm\").style.borderColor = '';\n+ document.getElementById(\"errorpassword\").innerHTML = \"\";\n+ document.getElementById(\"id\").style.borderColor = '';\n+ document.getElementById(\"errorid\").innerHTML = \"\";\n+}\n+\n+/**\n+*/\n+function addVehicle(){","path":"form.js","position":83,"original_position":83,"commit_id":"954e1b47d32c8e5a0eafcc29c0270fef5edcbe77","original_commit_id":"954e1b47d32c8e5a0eafcc29c0270fef5edcbe77","user":{"login":"shobhit-m","id":7247850,"node_id":"MDQ6VXNlcjcyNDc4NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7247850?v=4","gravatar_id":"","url":"https://api.github.com/users/shobhit-m","html_url":"https://github.com/shobhit-m","followers_url":"https://api.github.com/users/shobhit-m/followers","following_url":"https://api.github.com/users/shobhit-m/following{/other_user}","gists_url":"https://api.github.com/users/shobhit-m/gists{/gist_id}","starred_url":"https://api.github.com/users/shobhit-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shobhit-m/subscriptions","organizations_url":"https://api.github.com/users/shobhit-m/orgs","repos_url":"https://api.github.com/users/shobhit-m/repos","events_url":"https://api.github.com/users/shobhit-m/events{/privacy}","received_events_url":"https://api.github.com/users/shobhit-m/received_events","type":"User","site_admin":false},"body":"We can break this into smaller functions.","created_at":"2019-09-09T06:18:07Z","updated_at":"2019-09-09T06:19:40Z","html_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42#discussion_r322077812","pull_request_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/comments/322077812"},"html":{"href":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42#discussion_r322077812"},"pull_request":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42","id":310658384,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwNjU4Mzg0","html_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42","diff_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42.diff","patch_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42.patch","issue_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/42","number":42,"state":"open","locked":false,"title":"EAD Session 2","user":{"login":"meta-abhishek-bishnoi","id":52683670,"node_id":"MDQ6VXNlcjUyNjgzNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/52683670?v=4","gravatar_id":"","url":"https://api.github.com/users/meta-abhishek-bishnoi","html_url":"https://github.com/meta-abhishek-bishnoi","followers_url":"https://api.github.com/users/meta-abhishek-bishnoi/followers","following_url":"https://api.github.com/users/meta-abhishek-bishnoi/following{/other_user}","gists_url":"https://api.github.com/users/meta-abhishek-bishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-abhishek-bishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-abhishek-bishnoi/subscriptions","organizations_url":"https://api.github.com/users/meta-abhishek-bishnoi/orgs","repos_url":"https://api.github.com/users/meta-abhishek-bishnoi/repos","events_url":"https://api.github.com/users/meta-abhishek-bishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/meta-abhishek-bishnoi/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-25T04:57:06Z","updated_at":"2019-09-09T06:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d6ef338b2e438f22a07e1d1ee7b1269ea32785e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42/commits","review_comments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42/comments","review_comment_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/42/comments","statuses_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/statuses/954e1b47d32c8e5a0eafcc29c0270fef5edcbe77","head":{"label":"meta-abhishek-bishnoi:EAD-Session2","ref":"EAD-Session2","sha":"954e1b47d32c8e5a0eafcc29c0270fef5edcbe77","user":{"login":"meta-abhishek-bishnoi","id":52683670,"node_id":"MDQ6VXNlcjUyNjgzNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/52683670?v=4","gravatar_id":"","url":"https://api.github.com/users/meta-abhishek-bishnoi","html_url":"https://github.com/meta-abhishek-bishnoi","followers_url":"https://api.github.com/users/meta-abhishek-bishnoi/followers","following_url":"https://api.github.com/users/meta-abhishek-bishnoi/following{/other_user}","gists_url":"https://api.github.com/users/meta-abhishek-bishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-abhishek-bishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-abhishek-bishnoi/subscriptions","organizations_url":"https://api.github.com/users/meta-abhishek-bishnoi/orgs","repos_url":"https://api.github.com/users/meta-abhishek-bishnoi/repos","events_url":"https://api.github.com/users/meta-abhishek-bishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/meta-abhishek-bishnoi/received_events","type":"User","site_admin":false},"repo":{"id":196382564,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzODI1NjQ=","name":"GET-2019-Batch","full_name":"meta-abhishek-bishnoi/GET-2019-Batch","private":false,"owner":{"login":"meta-abhishek-bishnoi","id":52683670,"node_id":"MDQ6VXNlcjUyNjgzNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/52683670?v=4","gravatar_id":"","url":"https://api.github.com/users/meta-abhishek-bishnoi","html_url":"https://github.com/meta-abhishek-bishnoi","followers_url":"https://api.github.com/users/meta-abhishek-bishnoi/followers","following_url":"https://api.github.com/users/meta-abhishek-bishnoi/following{/other_user}","gists_url":"https://api.github.com/users/meta-abhishek-bishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-abhishek-bishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-abhishek-bishnoi/subscriptions","organizations_url":"https://api.github.com/users/meta-abhishek-bishnoi/orgs","repos_url":"https://api.github.com/users/meta-abhishek-bishnoi/repos","events_url":"https://api.github.com/users/meta-abhishek-bishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/meta-abhishek-bishnoi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch","description":"This repository is for assignment in GET program of metacube 2019","fork":false,"url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch","forks_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/forks","keys_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/teams","hooks_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/hooks","issue_events_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/events{/number}","events_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/events","assignees_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/assignees{/user}","branches_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/branches{/branch}","tags_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/tags","blobs_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/statuses/{sha}","languages_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/languages","stargazers_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/stargazers","contributors_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/contributors","subscribers_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/subscribers","subscription_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/subscription","commits_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/contents/{+path}","compare_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/merges","archive_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/downloads","issues_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues{/number}","pulls_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls{/number}","milestones_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/milestones{/number}","notifications_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/labels{/name}","releases_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/releases{/id}","deployments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/deployments","created_at":"2019-07-11T11:36:37Z","updated_at":"2019-08-20T08:53:48Z","pushed_at":"2019-09-06T10:53:55Z","git_url":"git://github.com/meta-abhishek-bishnoi/GET-2019-Batch.git","ssh_url":"git@github.com:meta-abhishek-bishnoi/GET-2019-Batch.git","clone_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch.git","svn_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch","homepage":null,"size":842,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":null,"forks":0,"open_issues":41,"watchers":0,"default_branch":"master"}},"base":{"label":"meta-abhishek-bishnoi:master","ref":"master","sha":"0e1c44b6adcc2ae33a20083249208ac3d475366a","user":{"login":"meta-abhishek-bishnoi","id":52683670,"node_id":"MDQ6VXNlcjUyNjgzNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/52683670?v=4","gravatar_id":"","url":"https://api.github.com/users/meta-abhishek-bishnoi","html_url":"https://github.com/meta-abhishek-bishnoi","followers_url":"https://api.github.com/users/meta-abhishek-bishnoi/followers","following_url":"https://api.github.com/users/meta-abhishek-bishnoi/following{/other_user}","gists_url":"https://api.github.com/users/meta-abhishek-bishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-abhishek-bishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-abhishek-bishnoi/subscriptions","organizations_url":"https://api.github.com/users/meta-abhishek-bishnoi/orgs","repos_url":"https://api.github.com/users/meta-abhishek-bishnoi/repos","events_url":"https://api.github.com/users/meta-abhishek-bishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/meta-abhishek-bishnoi/received_events","type":"User","site_admin":false},"repo":{"id":196382564,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYzODI1NjQ=","name":"GET-2019-Batch","full_name":"meta-abhishek-bishnoi/GET-2019-Batch","private":false,"owner":{"login":"meta-abhishek-bishnoi","id":52683670,"node_id":"MDQ6VXNlcjUyNjgzNjcw","avatar_url":"https://avatars3.githubusercontent.com/u/52683670?v=4","gravatar_id":"","url":"https://api.github.com/users/meta-abhishek-bishnoi","html_url":"https://github.com/meta-abhishek-bishnoi","followers_url":"https://api.github.com/users/meta-abhishek-bishnoi/followers","following_url":"https://api.github.com/users/meta-abhishek-bishnoi/following{/other_user}","gists_url":"https://api.github.com/users/meta-abhishek-bishnoi/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-abhishek-bishnoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-abhishek-bishnoi/subscriptions","organizations_url":"https://api.github.com/users/meta-abhishek-bishnoi/orgs","repos_url":"https://api.github.com/users/meta-abhishek-bishnoi/repos","events_url":"https://api.github.com/users/meta-abhishek-bishnoi/events{/privacy}","received_events_url":"https://api.github.com/users/meta-abhishek-bishnoi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch","description":"This repository is for assignment in GET program of metacube 2019","fork":false,"url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch","forks_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/forks","keys_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/teams","hooks_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/hooks","issue_events_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/events{/number}","events_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/events","assignees_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/assignees{/user}","branches_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/branches{/branch}","tags_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/tags","blobs_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/refs{/sha}","trees_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/statuses/{sha}","languages_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/languages","stargazers_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/stargazers","contributors_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/contributors","subscribers_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/subscribers","subscription_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/subscription","commits_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/commits{/sha}","git_commits_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/git/commits{/sha}","comments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/comments{/number}","issue_comment_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/comments{/number}","contents_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/contents/{+path}","compare_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/merges","archive_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/downloads","issues_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues{/number}","pulls_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls{/number}","milestones_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/milestones{/number}","notifications_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/labels{/name}","releases_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/releases{/id}","deployments_url":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/deployments","created_at":"2019-07-11T11:36:37Z","updated_at":"2019-08-20T08:53:48Z","pushed_at":"2019-09-06T10:53:55Z","git_url":"git://github.com/meta-abhishek-bishnoi/GET-2019-Batch.git","ssh_url":"git@github.com:meta-abhishek-bishnoi/GET-2019-Batch.git","clone_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch.git","svn_url":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch","homepage":null,"size":842,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":41,"license":null,"forks":0,"open_issues":41,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42"},"html":{"href":"https://github.com/meta-abhishek-bishnoi/GET-2019-Batch/pull/42"},"issue":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/42"},"comments":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch/statuses/954e1b47d32c8e5a0eafcc29c0270fef5edcbe77"}},"author_association":"OWNER"}}
|
{
"id": 196382564,
"name": "meta-abhishek-bishnoi/GET-2019-Batch",
"url": "https://api.github.com/repos/meta-abhishek-bishnoi/GET-2019-Batch"
}
|
{
"id": 7247850,
"login": "shobhit-m",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7247850?",
"url": "https://api.github.com/users/shobhit-m"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-09-09T06:18:07 |
10373135655
|
{"actor":{"display_login":"shobhit-m"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Lereena/ocaml/pulls/comments/291350351","pull_request_review_id":246788000,"id":291350351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTM1MDM1MQ==","diff_hunk":"@@ -1,11 +1,23 @@\n-ROOTROOT = ../..\n ROOTDIR = ..\n \n include $(ROOTDIR)/Makefile.config\n include $(ROOTDIR)/Makefile.common\n \n-ocamlc := $(ROOTROOT)/runtime/ocamlrun $(ROOTROOT)/ocamlc\n+directories := $(addprefix $(ROOTDIR)/,utils bytecomp parsing stdlib \\\n+ compilerlibs typing)\n+\n+include_directories := $(addprefix -I , $(directories))\n+\n+flags := -g -nostdlib $(include_directories) \\\n+ -strict-sequence -safe-string -strict-formats \\\n+ -w +a-4-9-40-41-42-44-45-48 -warn-error A\n+\n+ocamlc := $(ROOTDIR)/runtime/ocamlrun $(ROOTDIR)/ocamlc $(flags)\n+\n+libraries := ocamlbytecomp.cma ocamlcommon.cma","path":"ppx/Makefile","position":19,"original_position":19,"commit_id":"19789a36c063597ba6b68cc27d72290283fa90a8","original_commit_id":"19789a36c063597ba6b68cc27d72290283fa90a8","user":{"login":"Lereena","id":23419187,"node_id":"MDQ6VXNlcjIzNDE5MTg3","avatar_url":"https://avatars1.githubusercontent.com/u/23419187?v=4","gravatar_id":"","url":"https://api.github.com/users/Lereena","html_url":"https://github.com/Lereena","followers_url":"https://api.github.com/users/Lereena/followers","following_url":"https://api.github.com/users/Lereena/following{/other_user}","gists_url":"https://api.github.com/users/Lereena/gists{/gist_id}","starred_url":"https://api.github.com/users/Lereena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lereena/subscriptions","organizations_url":"https://api.github.com/users/Lereena/orgs","repos_url":"https://api.github.com/users/Lereena/repos","events_url":"https://api.github.com/users/Lereena/events{/privacy}","received_events_url":"https://api.github.com/users/Lereena/received_events","type":"User","site_admin":false},"body":"Why do we need these libraries? Because of Asttypes and so on in ppx?","created_at":"2019-06-06T20:07:41Z","updated_at":"2019-06-06T20:07:42Z","html_url":"https://github.com/Lereena/ocaml/pull/1#discussion_r291350351","pull_request_url":"https://api.github.com/repos/Lereena/ocaml/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/comments/291350351"},"html":{"href":"https://github.com/Lereena/ocaml/pull/1#discussion_r291350351"},"pull_request":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Lereena/ocaml/pulls/1","id":285941796,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1OTQxNzk2","html_url":"https://github.com/Lereena/ocaml/pull/1","diff_url":"https://github.com/Lereena/ocaml/pull/1.diff","patch_url":"https://github.com/Lereena/ocaml/pull/1.patch","issue_url":"https://api.github.com/repos/Lereena/ocaml/issues/1","number":1,"state":"open","locked":false,"title":"Fix build of toy ppx","user":{"login":"shindere","id":5877758,"node_id":"MDQ6VXNlcjU4Nzc3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5877758?v=4","gravatar_id":"","url":"https://api.github.com/users/shindere","html_url":"https://github.com/shindere","followers_url":"https://api.github.com/users/shindere/followers","following_url":"https://api.github.com/users/shindere/following{/other_user}","gists_url":"https://api.github.com/users/shindere/gists{/gist_id}","starred_url":"https://api.github.com/users/shindere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shindere/subscriptions","organizations_url":"https://api.github.com/users/shindere/orgs","repos_url":"https://api.github.com/users/shindere/repos","events_url":"https://api.github.com/users/shindere/events{/privacy}","received_events_url":"https://api.github.com/users/shindere/received_events","type":"User","site_admin":false},"body":"This is an example of how things could be made to work","created_at":"2019-06-06T19:39:27Z","updated_at":"2019-06-06T20:07:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5365612b9f32aad2fd3d9a7e8842dcc9dd7b8a76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lereena/ocaml/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Lereena/ocaml/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Lereena/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lereena/ocaml/issues/1/comments","statuses_url":"https://api.github.com/repos/Lereena/ocaml/statuses/19789a36c063597ba6b68cc27d72290283fa90a8","head":{"label":"shindere:toy_ppx_fixed","ref":"toy_ppx_fixed","sha":"19789a36c063597ba6b68cc27d72290283fa90a8","user":{"login":"shindere","id":5877758,"node_id":"MDQ6VXNlcjU4Nzc3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5877758?v=4","gravatar_id":"","url":"https://api.github.com/users/shindere","html_url":"https://github.com/shindere","followers_url":"https://api.github.com/users/shindere/followers","following_url":"https://api.github.com/users/shindere/following{/other_user}","gists_url":"https://api.github.com/users/shindere/gists{/gist_id}","starred_url":"https://api.github.com/users/shindere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shindere/subscriptions","organizations_url":"https://api.github.com/users/shindere/orgs","repos_url":"https://api.github.com/users/shindere/repos","events_url":"https://api.github.com/users/shindere/events{/privacy}","received_events_url":"https://api.github.com/users/shindere/received_events","type":"User","site_admin":false},"repo":{"id":57305191,"node_id":"MDEwOlJlcG9zaXRvcnk1NzMwNTE5MQ==","name":"ocaml","full_name":"shindere/ocaml","private":false,"owner":{"login":"shindere","id":5877758,"node_id":"MDQ6VXNlcjU4Nzc3NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5877758?v=4","gravatar_id":"","url":"https://api.github.com/users/shindere","html_url":"https://github.com/shindere","followers_url":"https://api.github.com/users/shindere/followers","following_url":"https://api.github.com/users/shindere/following{/other_user}","gists_url":"https://api.github.com/users/shindere/gists{/gist_id}","starred_url":"https://api.github.com/users/shindere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shindere/subscriptions","organizations_url":"https://api.github.com/users/shindere/orgs","repos_url":"https://api.github.com/users/shindere/repos","events_url":"https://api.github.com/users/shindere/events{/privacy}","received_events_url":"https://api.github.com/users/shindere/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shindere/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/shindere/ocaml","forks_url":"https://api.github.com/repos/shindere/ocaml/forks","keys_url":"https://api.github.com/repos/shindere/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shindere/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shindere/ocaml/teams","hooks_url":"https://api.github.com/repos/shindere/ocaml/hooks","issue_events_url":"https://api.github.com/repos/shindere/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/shindere/ocaml/events","assignees_url":"https://api.github.com/repos/shindere/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/shindere/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/shindere/ocaml/tags","blobs_url":"https://api.github.com/repos/shindere/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shindere/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shindere/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/shindere/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shindere/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/shindere/ocaml/languages","stargazers_url":"https://api.github.com/repos/shindere/ocaml/stargazers","contributors_url":"https://api.github.com/repos/shindere/ocaml/contributors","subscribers_url":"https://api.github.com/repos/shindere/ocaml/subscribers","subscription_url":"https://api.github.com/repos/shindere/ocaml/subscription","commits_url":"https://api.github.com/repos/shindere/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/shindere/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/shindere/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/shindere/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/shindere/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/shindere/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shindere/ocaml/merges","archive_url":"https://api.github.com/repos/shindere/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shindere/ocaml/downloads","issues_url":"https://api.github.com/repos/shindere/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/shindere/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/shindere/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/shindere/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shindere/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/shindere/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/shindere/ocaml/deployments","created_at":"2016-04-28T13:45:56Z","updated_at":"2019-05-23T08:42:57Z","pushed_at":"2019-06-06T19:30:57Z","git_url":"git://github.com/shindere/ocaml.git","ssh_url":"git@github.com:shindere/ocaml.git","clone_url":"https://github.com/shindere/ocaml.git","svn_url":"https://github.com/shindere/ocaml","homepage":"","size":182334,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"Lereena:toy_ppx","ref":"toy_ppx","sha":"3cad1a8988bf0f8f2b5ddcb18750e5ba29c16b82","user":{"login":"Lereena","id":23419187,"node_id":"MDQ6VXNlcjIzNDE5MTg3","avatar_url":"https://avatars1.githubusercontent.com/u/23419187?v=4","gravatar_id":"","url":"https://api.github.com/users/Lereena","html_url":"https://github.com/Lereena","followers_url":"https://api.github.com/users/Lereena/followers","following_url":"https://api.github.com/users/Lereena/following{/other_user}","gists_url":"https://api.github.com/users/Lereena/gists{/gist_id}","starred_url":"https://api.github.com/users/Lereena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lereena/subscriptions","organizations_url":"https://api.github.com/users/Lereena/orgs","repos_url":"https://api.github.com/users/Lereena/repos","events_url":"https://api.github.com/users/Lereena/events{/privacy}","received_events_url":"https://api.github.com/users/Lereena/received_events","type":"User","site_admin":false},"repo":{"id":189984257,"node_id":"MDEwOlJlcG9zaXRvcnkxODk5ODQyNTc=","name":"ocaml","full_name":"Lereena/ocaml","private":false,"owner":{"login":"Lereena","id":23419187,"node_id":"MDQ6VXNlcjIzNDE5MTg3","avatar_url":"https://avatars1.githubusercontent.com/u/23419187?v=4","gravatar_id":"","url":"https://api.github.com/users/Lereena","html_url":"https://github.com/Lereena","followers_url":"https://api.github.com/users/Lereena/followers","following_url":"https://api.github.com/users/Lereena/following{/other_user}","gists_url":"https://api.github.com/users/Lereena/gists{/gist_id}","starred_url":"https://api.github.com/users/Lereena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lereena/subscriptions","organizations_url":"https://api.github.com/users/Lereena/orgs","repos_url":"https://api.github.com/users/Lereena/repos","events_url":"https://api.github.com/users/Lereena/events{/privacy}","received_events_url":"https://api.github.com/users/Lereena/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Lereena/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/Lereena/ocaml","forks_url":"https://api.github.com/repos/Lereena/ocaml/forks","keys_url":"https://api.github.com/repos/Lereena/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lereena/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lereena/ocaml/teams","hooks_url":"https://api.github.com/repos/Lereena/ocaml/hooks","issue_events_url":"https://api.github.com/repos/Lereena/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/Lereena/ocaml/events","assignees_url":"https://api.github.com/repos/Lereena/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/Lereena/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/Lereena/ocaml/tags","blobs_url":"https://api.github.com/repos/Lereena/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lereena/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lereena/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lereena/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lereena/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Lereena/ocaml/languages","stargazers_url":"https://api.github.com/repos/Lereena/ocaml/stargazers","contributors_url":"https://api.github.com/repos/Lereena/ocaml/contributors","subscribers_url":"https://api.github.com/repos/Lereena/ocaml/subscribers","subscription_url":"https://api.github.com/repos/Lereena/ocaml/subscription","commits_url":"https://api.github.com/repos/Lereena/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lereena/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lereena/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lereena/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lereena/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/Lereena/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lereena/ocaml/merges","archive_url":"https://api.github.com/repos/Lereena/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lereena/ocaml/downloads","issues_url":"https://api.github.com/repos/Lereena/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/Lereena/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Lereena/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Lereena/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lereena/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/Lereena/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/Lereena/ocaml/deployments","created_at":"2019-06-03T10:27:25Z","updated_at":"2019-06-03T10:27:37Z","pushed_at":"2019-06-06T19:39:28Z","git_url":"git://github.com/Lereena/ocaml.git","ssh_url":"git@github.com:Lereena/ocaml.git","clone_url":"https://github.com/Lereena/ocaml.git","svn_url":"https://github.com/Lereena/ocaml","homepage":"","size":192460,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/1"},"html":{"href":"https://github.com/Lereena/ocaml/pull/1"},"issue":{"href":"https://api.github.com/repos/Lereena/ocaml/issues/1"},"comments":{"href":"https://api.github.com/repos/Lereena/ocaml/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lereena/ocaml/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Lereena/ocaml/statuses/19789a36c063597ba6b68cc27d72290283fa90a8"}},"author_association":"NONE"}}
|
{
"id": 189984257,
"name": "Lereena/ocaml",
"url": "https://api.github.com/repos/Lereena/ocaml"
}
|
{
"id": 23419187,
"login": "Lereena",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23419187?",
"url": "https://api.github.com/users/Lereena"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-06-06T20:07:41 |
9774309965
|
{"actor":{"display_login":"Lereena"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/comments/359204324","pull_request_review_id":333792194,"id":359204324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTIwNDMyNA==","diff_hunk":"@@ -0,0 +1,222 @@\n+#include <stdio.h>\n+#include <stdbool.h>\n+#include <stdlib.h>\n+\n+typedef enum Errors\n+{\n+ normalCompletion = 0,\n+ mismatchWithCondition = -1,\n+ incorrectReading = -2,\n+ incorrectAccess = -3,\n+ loopingProgram = -4,\n+} Errors;\n+\n+bool isComplianceWithCondition(int numberOfStudent, int numberOfHelper)\n+{\n+ return !((numberOfStudent == 1 && numberOfHelper != 1) ||\n+ (numberOfStudent == 2 && numberOfHelper != 2) ||\n+ (numberOfStudent == 3 && numberOfHelper != 3));\n+}\n+\n+Errors scanNumberOfStudents(int* numberOfStudents)\n+{\n+ bool isCorrectInput = scanf(\"%d\", numberOfStudents) == 1;","path":"Tasks_8/Task_8_1.c","position":23,"original_position":23,"commit_id":"dcc5759c49e52bbc2df37122d72a64cc90661b22","original_commit_id":"dcc5759c49e52bbc2df37122d72a64cc90661b22","user":{"login":"SpirinEgor","id":22539802,"node_id":"MDQ6VXNlcjIyNTM5ODAy","avatar_url":"https://avatars3.githubusercontent.com/u/22539802?v=4","gravatar_id":"","url":"https://api.github.com/users/SpirinEgor","html_url":"https://github.com/SpirinEgor","followers_url":"https://api.github.com/users/SpirinEgor/followers","following_url":"https://api.github.com/users/SpirinEgor/following{/other_user}","gists_url":"https://api.github.com/users/SpirinEgor/gists{/gist_id}","starred_url":"https://api.github.com/users/SpirinEgor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpirinEgor/subscriptions","organizations_url":"https://api.github.com/users/SpirinEgor/orgs","repos_url":"https://api.github.com/users/SpirinEgor/repos","events_url":"https://api.github.com/users/SpirinEgor/events{/privacy}","received_events_url":"https://api.github.com/users/SpirinEgor/received_events","type":"User","site_admin":false},"body":"Лучше сохранить возвращаемое значени -- количество прочитанных аргументов, а в if уже проверить, что это число равняется 1","created_at":"2019-12-18T08:11:07Z","updated_at":"2019-12-18T08:16:19Z","html_url":"https://github.com/ArtVyatkin/HomeWork/pull/25#discussion_r359204324","pull_request_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/comments/359204324"},"html":{"href":"https://github.com/ArtVyatkin/HomeWork/pull/25#discussion_r359204324"},"pull_request":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25","id":353305670,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMzA1Njcw","html_url":"https://github.com/ArtVyatkin/HomeWork/pull/25","diff_url":"https://github.com/ArtVyatkin/HomeWork/pull/25.diff","patch_url":"https://github.com/ArtVyatkin/HomeWork/pull/25.patch","issue_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/25","number":25,"state":"open","locked":false,"title":"added a solution to task 8.1","user":{"login":"ArtVyatkin","id":55441803,"node_id":"MDQ6VXNlcjU1NDQxODAz","avatar_url":"https://avatars1.githubusercontent.com/u/55441803?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtVyatkin","html_url":"https://github.com/ArtVyatkin","followers_url":"https://api.github.com/users/ArtVyatkin/followers","following_url":"https://api.github.com/users/ArtVyatkin/following{/other_user}","gists_url":"https://api.github.com/users/ArtVyatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtVyatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtVyatkin/subscriptions","organizations_url":"https://api.github.com/users/ArtVyatkin/orgs","repos_url":"https://api.github.com/users/ArtVyatkin/repos","events_url":"https://api.github.com/users/ArtVyatkin/events{/privacy}","received_events_url":"https://api.github.com/users/ArtVyatkin/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-15T19:22:10Z","updated_at":"2019-12-18T08:16:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26fde05d6176877839a74c4b374dc349a35d7e89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25/commits","review_comments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25/comments","review_comment_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/25/comments","statuses_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/statuses/dcc5759c49e52bbc2df37122d72a64cc90661b22","head":{"label":"ArtVyatkin:task_8_1","ref":"task_8_1","sha":"dcc5759c49e52bbc2df37122d72a64cc90661b22","user":{"login":"ArtVyatkin","id":55441803,"node_id":"MDQ6VXNlcjU1NDQxODAz","avatar_url":"https://avatars1.githubusercontent.com/u/55441803?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtVyatkin","html_url":"https://github.com/ArtVyatkin","followers_url":"https://api.github.com/users/ArtVyatkin/followers","following_url":"https://api.github.com/users/ArtVyatkin/following{/other_user}","gists_url":"https://api.github.com/users/ArtVyatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtVyatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtVyatkin/subscriptions","organizations_url":"https://api.github.com/users/ArtVyatkin/orgs","repos_url":"https://api.github.com/users/ArtVyatkin/repos","events_url":"https://api.github.com/users/ArtVyatkin/events{/privacy}","received_events_url":"https://api.github.com/users/ArtVyatkin/received_events","type":"User","site_admin":false},"repo":{"id":211945301,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE5NDUzMDE=","name":"HomeWork","full_name":"ArtVyatkin/HomeWork","private":false,"owner":{"login":"ArtVyatkin","id":55441803,"node_id":"MDQ6VXNlcjU1NDQxODAz","avatar_url":"https://avatars1.githubusercontent.com/u/55441803?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtVyatkin","html_url":"https://github.com/ArtVyatkin","followers_url":"https://api.github.com/users/ArtVyatkin/followers","following_url":"https://api.github.com/users/ArtVyatkin/following{/other_user}","gists_url":"https://api.github.com/users/ArtVyatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtVyatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtVyatkin/subscriptions","organizations_url":"https://api.github.com/users/ArtVyatkin/orgs","repos_url":"https://api.github.com/users/ArtVyatkin/repos","events_url":"https://api.github.com/users/ArtVyatkin/events{/privacy}","received_events_url":"https://api.github.com/users/ArtVyatkin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ArtVyatkin/HomeWork","description":null,"fork":false,"url":"https://api.github.com/repos/ArtVyatkin/HomeWork","forks_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/forks","keys_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/teams","hooks_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/hooks","issue_events_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/events{/number}","events_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/events","assignees_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/assignees{/user}","branches_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/branches{/branch}","tags_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/tags","blobs_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/languages","stargazers_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/stargazers","contributors_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/contributors","subscribers_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/subscribers","subscription_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/subscription","commits_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/contents/{+path}","compare_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/merges","archive_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/downloads","issues_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues{/number}","pulls_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/labels{/name}","releases_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/releases{/id}","deployments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/deployments","created_at":"2019-09-30T20:01:30Z","updated_at":"2019-12-10T12:14:46Z","pushed_at":"2019-12-17T12:45:51Z","git_url":"git://github.com/ArtVyatkin/HomeWork.git","ssh_url":"git@github.com:ArtVyatkin/HomeWork.git","clone_url":"https://github.com/ArtVyatkin/HomeWork.git","svn_url":"https://github.com/ArtVyatkin/HomeWork","homepage":null,"size":99,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"ArtVyatkin:master","ref":"master","sha":"918817bec551610a78138e737472f8f629ea0192","user":{"login":"ArtVyatkin","id":55441803,"node_id":"MDQ6VXNlcjU1NDQxODAz","avatar_url":"https://avatars1.githubusercontent.com/u/55441803?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtVyatkin","html_url":"https://github.com/ArtVyatkin","followers_url":"https://api.github.com/users/ArtVyatkin/followers","following_url":"https://api.github.com/users/ArtVyatkin/following{/other_user}","gists_url":"https://api.github.com/users/ArtVyatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtVyatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtVyatkin/subscriptions","organizations_url":"https://api.github.com/users/ArtVyatkin/orgs","repos_url":"https://api.github.com/users/ArtVyatkin/repos","events_url":"https://api.github.com/users/ArtVyatkin/events{/privacy}","received_events_url":"https://api.github.com/users/ArtVyatkin/received_events","type":"User","site_admin":false},"repo":{"id":211945301,"node_id":"MDEwOlJlcG9zaXRvcnkyMTE5NDUzMDE=","name":"HomeWork","full_name":"ArtVyatkin/HomeWork","private":false,"owner":{"login":"ArtVyatkin","id":55441803,"node_id":"MDQ6VXNlcjU1NDQxODAz","avatar_url":"https://avatars1.githubusercontent.com/u/55441803?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtVyatkin","html_url":"https://github.com/ArtVyatkin","followers_url":"https://api.github.com/users/ArtVyatkin/followers","following_url":"https://api.github.com/users/ArtVyatkin/following{/other_user}","gists_url":"https://api.github.com/users/ArtVyatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtVyatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtVyatkin/subscriptions","organizations_url":"https://api.github.com/users/ArtVyatkin/orgs","repos_url":"https://api.github.com/users/ArtVyatkin/repos","events_url":"https://api.github.com/users/ArtVyatkin/events{/privacy}","received_events_url":"https://api.github.com/users/ArtVyatkin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ArtVyatkin/HomeWork","description":null,"fork":false,"url":"https://api.github.com/repos/ArtVyatkin/HomeWork","forks_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/forks","keys_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/teams","hooks_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/hooks","issue_events_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/events{/number}","events_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/events","assignees_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/assignees{/user}","branches_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/branches{/branch}","tags_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/tags","blobs_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/languages","stargazers_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/stargazers","contributors_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/contributors","subscribers_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/subscribers","subscription_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/subscription","commits_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/contents/{+path}","compare_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/merges","archive_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/downloads","issues_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues{/number}","pulls_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/labels{/name}","releases_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/releases{/id}","deployments_url":"https://api.github.com/repos/ArtVyatkin/HomeWork/deployments","created_at":"2019-09-30T20:01:30Z","updated_at":"2019-12-10T12:14:46Z","pushed_at":"2019-12-17T12:45:51Z","git_url":"git://github.com/ArtVyatkin/HomeWork.git","ssh_url":"git@github.com:ArtVyatkin/HomeWork.git","clone_url":"https://github.com/ArtVyatkin/HomeWork.git","svn_url":"https://github.com/ArtVyatkin/HomeWork","homepage":null,"size":99,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25"},"html":{"href":"https://github.com/ArtVyatkin/HomeWork/pull/25"},"issue":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/25"},"comments":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/ArtVyatkin/HomeWork/statuses/dcc5759c49e52bbc2df37122d72a64cc90661b22"}},"author_association":"OWNER"}}
|
{
"id": 211945301,
"name": "ArtVyatkin/HomeWork",
"url": "https://api.github.com/repos/ArtVyatkin/HomeWork"
}
|
{
"id": 22539802,
"login": "SpirinEgor",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22539802?",
"url": "https://api.github.com/users/SpirinEgor"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-18T08:11:07 |
11114275803
|
{"actor":{"display_login":"SpirinEgor"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/comments/287267238","pull_request_review_id":241618631,"id":287267238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzI2NzIzOA==","diff_hunk":"@@ -0,0 +1,6 @@\n+---\n+layout: slide\n+title: \"Welcome to our second slide!\"\n+---\n+Your text","path":"_posts/0000-01-02-ProgramerMyFirstChoice.md","position":5,"original_position":5,"commit_id":"ae5ebe82dea2511ee4a15e080fbe396af4cfe666","original_commit_id":"ae5ebe82dea2511ee4a15e080fbe396af4cfe666","user":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"body":"hlkjk","created_at":"2019-05-24T08:41:17Z","updated_at":"2019-05-24T08:41:31Z","html_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3#discussion_r287267238","pull_request_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/comments/287267238"},"html":{"href":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3#discussion_r287267238"},"pull_request":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3","id":281354865,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxMzU0ODY1","html_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3","diff_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3.diff","patch_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3.patch","issue_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/3","number":3,"state":"open","locked":false,"title":"Add ProgramerMyFirstChoice's file","user":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"body":"I have: created a branch, created a file and made a commit, and opened a pull request","created_at":"2019-05-22T20:50:57Z","updated_at":"2019-05-24T08:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef5c43a8fe06ff7c158259543ad66e2543880714","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/3/comments","statuses_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/statuses/ae5ebe82dea2511ee4a15e080fbe396af4cfe666","head":{"label":"ProgramingMyFirstChoice:ProgramerMyFirstChoice-patch-1","ref":"ProgramerMyFirstChoice-patch-1","sha":"ae5ebe82dea2511ee4a15e080fbe396af4cfe666","user":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"repo":{"id":187939077,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5MzkwNzc=","name":"github-slideshow","full_name":"ProgramingMyFirstChoice/github-slideshow","private":false,"owner":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow","description":"A robot powered training repository :robot:","fork":false,"url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow","forks_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/forks","keys_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/teams","hooks_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/hooks","issue_events_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/events{/number}","events_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/events","assignees_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/assignees{/user}","branches_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/branches{/branch}","tags_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/tags","blobs_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/statuses/{sha}","languages_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/languages","stargazers_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/stargazers","contributors_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/contributors","subscribers_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/subscribers","subscription_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/subscription","commits_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/contents/{+path}","compare_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/merges","archive_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/downloads","issues_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues{/number}","pulls_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls{/number}","milestones_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/milestones{/number}","notifications_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/labels{/name}","releases_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/releases{/id}","deployments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/deployments","created_at":"2019-05-22T01:22:44Z","updated_at":"2019-05-22T01:23:16Z","pushed_at":"2019-05-22T20:50:57Z","git_url":"git://github.com/ProgramingMyFirstChoice/github-slideshow.git","ssh_url":"git@github.com:ProgramingMyFirstChoice/github-slideshow.git","clone_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow.git","svn_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow","homepage":"https://lab.github.com/githubtraining/introduction-to-github","size":1670,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ProgramingMyFirstChoice:master","ref":"master","sha":"c06403ff4035df3fe2bd5f16600eab2fbff0e35c","user":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"repo":{"id":187939077,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5MzkwNzc=","name":"github-slideshow","full_name":"ProgramingMyFirstChoice/github-slideshow","private":false,"owner":{"login":"ProgramingMyFirstChoice","id":34608992,"node_id":"MDQ6VXNlcjM0NjA4OTky","avatar_url":"https://avatars3.githubusercontent.com/u/34608992?v=4","gravatar_id":"","url":"https://api.github.com/users/ProgramingMyFirstChoice","html_url":"https://github.com/ProgramingMyFirstChoice","followers_url":"https://api.github.com/users/ProgramingMyFirstChoice/followers","following_url":"https://api.github.com/users/ProgramingMyFirstChoice/following{/other_user}","gists_url":"https://api.github.com/users/ProgramingMyFirstChoice/gists{/gist_id}","starred_url":"https://api.github.com/users/ProgramingMyFirstChoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProgramingMyFirstChoice/subscriptions","organizations_url":"https://api.github.com/users/ProgramingMyFirstChoice/orgs","repos_url":"https://api.github.com/users/ProgramingMyFirstChoice/repos","events_url":"https://api.github.com/users/ProgramingMyFirstChoice/events{/privacy}","received_events_url":"https://api.github.com/users/ProgramingMyFirstChoice/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow","description":"A robot powered training repository :robot:","fork":false,"url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow","forks_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/forks","keys_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/teams","hooks_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/hooks","issue_events_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/events{/number}","events_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/events","assignees_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/assignees{/user}","branches_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/branches{/branch}","tags_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/tags","blobs_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/statuses/{sha}","languages_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/languages","stargazers_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/stargazers","contributors_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/contributors","subscribers_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/subscribers","subscription_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/subscription","commits_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/contents/{+path}","compare_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/merges","archive_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/downloads","issues_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues{/number}","pulls_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls{/number}","milestones_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/milestones{/number}","notifications_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/labels{/name}","releases_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/releases{/id}","deployments_url":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/deployments","created_at":"2019-05-22T01:22:44Z","updated_at":"2019-05-22T01:23:16Z","pushed_at":"2019-05-22T20:50:57Z","git_url":"git://github.com/ProgramingMyFirstChoice/github-slideshow.git","ssh_url":"git@github.com:ProgramingMyFirstChoice/github-slideshow.git","clone_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow.git","svn_url":"https://github.com/ProgramingMyFirstChoice/github-slideshow","homepage":"https://lab.github.com/githubtraining/introduction-to-github","size":1670,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3"},"html":{"href":"https://github.com/ProgramingMyFirstChoice/github-slideshow/pull/3"},"issue":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/3"},"comments":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow/statuses/ae5ebe82dea2511ee4a15e080fbe396af4cfe666"}},"author_association":"OWNER"}}
|
{
"id": 187939077,
"name": "ProgramingMyFirstChoice/github-slideshow",
"url": "https://api.github.com/repos/ProgramingMyFirstChoice/github-slideshow"
}
|
{
"id": 34608992,
"login": "ProgramingMyFirstChoice",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/34608992?",
"url": "https://api.github.com/users/ProgramingMyFirstChoice"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-24T08:41:17 |
9690457008
|
{"actor":{"display_login":"ProgramingMyFirstChoice"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/comments/314177113","pull_request_review_id":275263937,"id":314177113,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDE3NzExMw==","diff_hunk":"@@ -4,6 +4,7 @@\n use App\\Service\\AddressService;","path":"app/Helpers/ProductHelper.php","position":1,"original_position":1,"commit_id":"9cfca090ca854e03d2239291fcc3c9ecc563775e","original_commit_id":"9cfca090ca854e03d2239291fcc3c9ecc563775e","user":{"login":"cuongdv-1677","id":48075341,"node_id":"MDQ6VXNlcjQ4MDc1MzQx","avatar_url":"https://avatars0.githubusercontent.com/u/48075341?v=4","gravatar_id":"","url":"https://api.github.com/users/cuongdv-1677","html_url":"https://github.com/cuongdv-1677","followers_url":"https://api.github.com/users/cuongdv-1677/followers","following_url":"https://api.github.com/users/cuongdv-1677/following{/other_user}","gists_url":"https://api.github.com/users/cuongdv-1677/gists{/gist_id}","starred_url":"https://api.github.com/users/cuongdv-1677/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cuongdv-1677/subscriptions","organizations_url":"https://api.github.com/users/cuongdv-1677/orgs","repos_url":"https://api.github.com/users/cuongdv-1677/repos","events_url":"https://api.github.com/users/cuongdv-1677/events{/privacy}","received_events_url":"https://api.github.com/users/cuongdv-1677/received_events","type":"User","site_admin":false},"body":"đây này vẫn một đống service ở helper này ","created_at":"2019-08-15T05:17:53Z","updated_at":"2019-08-15T05:18:01Z","html_url":"https://github.com/phamphuong1710/bai3/pull/6#discussion_r314177113","pull_request_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/comments/314177113"},"html":{"href":"https://github.com/phamphuong1710/bai3/pull/6#discussion_r314177113"},"pull_request":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6","id":307373921,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MzczOTIx","html_url":"https://github.com/phamphuong1710/bai3/pull/6","diff_url":"https://github.com/phamphuong1710/bai3/pull/6.diff","patch_url":"https://github.com/phamphuong1710/bai3/pull/6.patch","issue_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/6","number":6,"state":"open","locked":false,"title":"Rating","user":{"login":"phamphuong1710","id":33455010,"node_id":"MDQ6VXNlcjMzNDU1MDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33455010?v=4","gravatar_id":"","url":"https://api.github.com/users/phamphuong1710","html_url":"https://github.com/phamphuong1710","followers_url":"https://api.github.com/users/phamphuong1710/followers","following_url":"https://api.github.com/users/phamphuong1710/following{/other_user}","gists_url":"https://api.github.com/users/phamphuong1710/gists{/gist_id}","starred_url":"https://api.github.com/users/phamphuong1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamphuong1710/subscriptions","organizations_url":"https://api.github.com/users/phamphuong1710/orgs","repos_url":"https://api.github.com/users/phamphuong1710/repos","events_url":"https://api.github.com/users/phamphuong1710/events{/privacy}","received_events_url":"https://api.github.com/users/phamphuong1710/received_events","type":"User","site_admin":false},"body":"rating product\r\nrating store","created_at":"2019-08-14T15:08:36Z","updated_at":"2019-08-15T05:18:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e782daae317f956b41532938d6cd9bbb960f98ca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6/commits","review_comments_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6/comments","review_comment_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/6/comments","statuses_url":"https://api.github.com/repos/phamphuong1710/bai3/statuses/9cfca090ca854e03d2239291fcc3c9ecc563775e","head":{"label":"phamphuong1710:rating","ref":"rating","sha":"9cfca090ca854e03d2239291fcc3c9ecc563775e","user":{"login":"phamphuong1710","id":33455010,"node_id":"MDQ6VXNlcjMzNDU1MDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33455010?v=4","gravatar_id":"","url":"https://api.github.com/users/phamphuong1710","html_url":"https://github.com/phamphuong1710","followers_url":"https://api.github.com/users/phamphuong1710/followers","following_url":"https://api.github.com/users/phamphuong1710/following{/other_user}","gists_url":"https://api.github.com/users/phamphuong1710/gists{/gist_id}","starred_url":"https://api.github.com/users/phamphuong1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamphuong1710/subscriptions","organizations_url":"https://api.github.com/users/phamphuong1710/orgs","repos_url":"https://api.github.com/users/phamphuong1710/repos","events_url":"https://api.github.com/users/phamphuong1710/events{/privacy}","received_events_url":"https://api.github.com/users/phamphuong1710/received_events","type":"User","site_admin":false},"repo":{"id":198024774,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgwMjQ3NzQ=","name":"bai3","full_name":"phamphuong1710/bai3","private":false,"owner":{"login":"phamphuong1710","id":33455010,"node_id":"MDQ6VXNlcjMzNDU1MDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33455010?v=4","gravatar_id":"","url":"https://api.github.com/users/phamphuong1710","html_url":"https://github.com/phamphuong1710","followers_url":"https://api.github.com/users/phamphuong1710/followers","following_url":"https://api.github.com/users/phamphuong1710/following{/other_user}","gists_url":"https://api.github.com/users/phamphuong1710/gists{/gist_id}","starred_url":"https://api.github.com/users/phamphuong1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamphuong1710/subscriptions","organizations_url":"https://api.github.com/users/phamphuong1710/orgs","repos_url":"https://api.github.com/users/phamphuong1710/repos","events_url":"https://api.github.com/users/phamphuong1710/events{/privacy}","received_events_url":"https://api.github.com/users/phamphuong1710/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phamphuong1710/bai3","description":null,"fork":false,"url":"https://api.github.com/repos/phamphuong1710/bai3","forks_url":"https://api.github.com/repos/phamphuong1710/bai3/forks","keys_url":"https://api.github.com/repos/phamphuong1710/bai3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phamphuong1710/bai3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phamphuong1710/bai3/teams","hooks_url":"https://api.github.com/repos/phamphuong1710/bai3/hooks","issue_events_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/events{/number}","events_url":"https://api.github.com/repos/phamphuong1710/bai3/events","assignees_url":"https://api.github.com/repos/phamphuong1710/bai3/assignees{/user}","branches_url":"https://api.github.com/repos/phamphuong1710/bai3/branches{/branch}","tags_url":"https://api.github.com/repos/phamphuong1710/bai3/tags","blobs_url":"https://api.github.com/repos/phamphuong1710/bai3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phamphuong1710/bai3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phamphuong1710/bai3/git/refs{/sha}","trees_url":"https://api.github.com/repos/phamphuong1710/bai3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phamphuong1710/bai3/statuses/{sha}","languages_url":"https://api.github.com/repos/phamphuong1710/bai3/languages","stargazers_url":"https://api.github.com/repos/phamphuong1710/bai3/stargazers","contributors_url":"https://api.github.com/repos/phamphuong1710/bai3/contributors","subscribers_url":"https://api.github.com/repos/phamphuong1710/bai3/subscribers","subscription_url":"https://api.github.com/repos/phamphuong1710/bai3/subscription","commits_url":"https://api.github.com/repos/phamphuong1710/bai3/commits{/sha}","git_commits_url":"https://api.github.com/repos/phamphuong1710/bai3/git/commits{/sha}","comments_url":"https://api.github.com/repos/phamphuong1710/bai3/comments{/number}","issue_comment_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/comments{/number}","contents_url":"https://api.github.com/repos/phamphuong1710/bai3/contents/{+path}","compare_url":"https://api.github.com/repos/phamphuong1710/bai3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phamphuong1710/bai3/merges","archive_url":"https://api.github.com/repos/phamphuong1710/bai3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phamphuong1710/bai3/downloads","issues_url":"https://api.github.com/repos/phamphuong1710/bai3/issues{/number}","pulls_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls{/number}","milestones_url":"https://api.github.com/repos/phamphuong1710/bai3/milestones{/number}","notifications_url":"https://api.github.com/repos/phamphuong1710/bai3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phamphuong1710/bai3/labels{/name}","releases_url":"https://api.github.com/repos/phamphuong1710/bai3/releases{/id}","deployments_url":"https://api.github.com/repos/phamphuong1710/bai3/deployments","created_at":"2019-07-21T07:11:06Z","updated_at":"2019-08-09T15:11:38Z","pushed_at":"2019-08-14T15:08:37Z","git_url":"git://github.com/phamphuong1710/bai3.git","ssh_url":"git@github.com:phamphuong1710/bai3.git","clone_url":"https://github.com/phamphuong1710/bai3.git","svn_url":"https://github.com/phamphuong1710/bai3","homepage":null,"size":2433,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"phamphuong1710:master","ref":"master","sha":"952e47c777cacad29aad633acc59b5274d8ebb00","user":{"login":"phamphuong1710","id":33455010,"node_id":"MDQ6VXNlcjMzNDU1MDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33455010?v=4","gravatar_id":"","url":"https://api.github.com/users/phamphuong1710","html_url":"https://github.com/phamphuong1710","followers_url":"https://api.github.com/users/phamphuong1710/followers","following_url":"https://api.github.com/users/phamphuong1710/following{/other_user}","gists_url":"https://api.github.com/users/phamphuong1710/gists{/gist_id}","starred_url":"https://api.github.com/users/phamphuong1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamphuong1710/subscriptions","organizations_url":"https://api.github.com/users/phamphuong1710/orgs","repos_url":"https://api.github.com/users/phamphuong1710/repos","events_url":"https://api.github.com/users/phamphuong1710/events{/privacy}","received_events_url":"https://api.github.com/users/phamphuong1710/received_events","type":"User","site_admin":false},"repo":{"id":198024774,"node_id":"MDEwOlJlcG9zaXRvcnkxOTgwMjQ3NzQ=","name":"bai3","full_name":"phamphuong1710/bai3","private":false,"owner":{"login":"phamphuong1710","id":33455010,"node_id":"MDQ6VXNlcjMzNDU1MDEw","avatar_url":"https://avatars1.githubusercontent.com/u/33455010?v=4","gravatar_id":"","url":"https://api.github.com/users/phamphuong1710","html_url":"https://github.com/phamphuong1710","followers_url":"https://api.github.com/users/phamphuong1710/followers","following_url":"https://api.github.com/users/phamphuong1710/following{/other_user}","gists_url":"https://api.github.com/users/phamphuong1710/gists{/gist_id}","starred_url":"https://api.github.com/users/phamphuong1710/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phamphuong1710/subscriptions","organizations_url":"https://api.github.com/users/phamphuong1710/orgs","repos_url":"https://api.github.com/users/phamphuong1710/repos","events_url":"https://api.github.com/users/phamphuong1710/events{/privacy}","received_events_url":"https://api.github.com/users/phamphuong1710/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phamphuong1710/bai3","description":null,"fork":false,"url":"https://api.github.com/repos/phamphuong1710/bai3","forks_url":"https://api.github.com/repos/phamphuong1710/bai3/forks","keys_url":"https://api.github.com/repos/phamphuong1710/bai3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phamphuong1710/bai3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phamphuong1710/bai3/teams","hooks_url":"https://api.github.com/repos/phamphuong1710/bai3/hooks","issue_events_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/events{/number}","events_url":"https://api.github.com/repos/phamphuong1710/bai3/events","assignees_url":"https://api.github.com/repos/phamphuong1710/bai3/assignees{/user}","branches_url":"https://api.github.com/repos/phamphuong1710/bai3/branches{/branch}","tags_url":"https://api.github.com/repos/phamphuong1710/bai3/tags","blobs_url":"https://api.github.com/repos/phamphuong1710/bai3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phamphuong1710/bai3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phamphuong1710/bai3/git/refs{/sha}","trees_url":"https://api.github.com/repos/phamphuong1710/bai3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phamphuong1710/bai3/statuses/{sha}","languages_url":"https://api.github.com/repos/phamphuong1710/bai3/languages","stargazers_url":"https://api.github.com/repos/phamphuong1710/bai3/stargazers","contributors_url":"https://api.github.com/repos/phamphuong1710/bai3/contributors","subscribers_url":"https://api.github.com/repos/phamphuong1710/bai3/subscribers","subscription_url":"https://api.github.com/repos/phamphuong1710/bai3/subscription","commits_url":"https://api.github.com/repos/phamphuong1710/bai3/commits{/sha}","git_commits_url":"https://api.github.com/repos/phamphuong1710/bai3/git/commits{/sha}","comments_url":"https://api.github.com/repos/phamphuong1710/bai3/comments{/number}","issue_comment_url":"https://api.github.com/repos/phamphuong1710/bai3/issues/comments{/number}","contents_url":"https://api.github.com/repos/phamphuong1710/bai3/contents/{+path}","compare_url":"https://api.github.com/repos/phamphuong1710/bai3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phamphuong1710/bai3/merges","archive_url":"https://api.github.com/repos/phamphuong1710/bai3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phamphuong1710/bai3/downloads","issues_url":"https://api.github.com/repos/phamphuong1710/bai3/issues{/number}","pulls_url":"https://api.github.com/repos/phamphuong1710/bai3/pulls{/number}","milestones_url":"https://api.github.com/repos/phamphuong1710/bai3/milestones{/number}","notifications_url":"https://api.github.com/repos/phamphuong1710/bai3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phamphuong1710/bai3/labels{/name}","releases_url":"https://api.github.com/repos/phamphuong1710/bai3/releases{/id}","deployments_url":"https://api.github.com/repos/phamphuong1710/bai3/deployments","created_at":"2019-07-21T07:11:06Z","updated_at":"2019-08-09T15:11:38Z","pushed_at":"2019-08-14T15:08:37Z","git_url":"git://github.com/phamphuong1710/bai3.git","ssh_url":"git@github.com:phamphuong1710/bai3.git","clone_url":"https://github.com/phamphuong1710/bai3.git","svn_url":"https://github.com/phamphuong1710/bai3","homepage":null,"size":2433,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6"},"html":{"href":"https://github.com/phamphuong1710/bai3/pull/6"},"issue":{"href":"https://api.github.com/repos/phamphuong1710/bai3/issues/6"},"comments":{"href":"https://api.github.com/repos/phamphuong1710/bai3/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phamphuong1710/bai3/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/phamphuong1710/bai3/statuses/9cfca090ca854e03d2239291fcc3c9ecc563775e"}},"author_association":"OWNER"}}
|
{
"id": 198024774,
"name": "phamphuong1710/bai3",
"url": "https://api.github.com/repos/phamphuong1710/bai3"
}
|
{
"id": 48075341,
"login": "cuongdv-1677",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48075341?",
"url": "https://api.github.com/users/cuongdv-1677"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-15T05:17:53 |
10214915613
|
{"actor":{"display_login":"cuongdv-1677"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/comments/366353636","pull_request_review_id":342548638,"id":366353636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NjM1MzYzNg==","diff_hunk":"@@ -0,0 +1,133 @@\n+package com.epam.university;\n+\n+import java.util.Arrays;\n+\n+public class Group\n+{\n+ private Student[] studentsInGroup=new Student[3];\n+ private String groupName;\n+ static String[] courses = new String[] {\"Accounting\", \"Math\", \"English\", \"Art\",\"History\", \"Marketing\", \"Music\", \"Literature\"};\n+\n+ public Group(String name)\n+ {\n+ groupName=name;\n+ }\n+\n+\n+ public void setStudentsInGroup(Student[] studentsInGroup) {\n+ this.studentsInGroup = studentsInGroup;\n+ }\n+\n+ public Student[] getStudentsInGroup() {\n+ return studentsInGroup;\n+ }\n+\n+\n+ public void setGroupName(String groupName) {\n+ this.groupName = groupName;\n+ }\n+\n+ public String getGroupName() {\n+ return groupName;\n+ }\n+\n+\n+ //Get average grade of every subject in a particular group\n+\n+ public static double[] averageOfSubjectsInGroup(Group group)","path":"src/com/epam/university/Group.java","position":37,"original_position":37,"commit_id":"0c5ec472014422122e28c5b9b2ba77fe48fe527b","original_commit_id":"0c5ec472014422122e28c5b9b2ba77fe48fe527b","user":{"login":"naira-tamrazyan","id":59051228,"node_id":"MDQ6VXNlcjU5MDUxMjI4","avatar_url":"https://avatars3.githubusercontent.com/u/59051228?v=4","gravatar_id":"","url":"https://api.github.com/users/naira-tamrazyan","html_url":"https://github.com/naira-tamrazyan","followers_url":"https://api.github.com/users/naira-tamrazyan/followers","following_url":"https://api.github.com/users/naira-tamrazyan/following{/other_user}","gists_url":"https://api.github.com/users/naira-tamrazyan/gists{/gist_id}","starred_url":"https://api.github.com/users/naira-tamrazyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naira-tamrazyan/subscriptions","organizations_url":"https://api.github.com/users/naira-tamrazyan/orgs","repos_url":"https://api.github.com/users/naira-tamrazyan/repos","events_url":"https://api.github.com/users/naira-tamrazyan/events{/privacy}","received_events_url":"https://api.github.com/users/naira-tamrazyan/received_events","type":"User","site_admin":false},"body":"This method should not work with hardcoded values. The subjects should be initialized outside of main method and not in Group class, so there will be no need to store all this local variables.","created_at":"2020-01-14T14:02:03Z","updated_at":"2020-01-14T14:04:47Z","html_url":"https://github.com/ZaruhiAvagyan/Homework/pull/1#discussion_r366353636","pull_request_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/comments/366353636"},"html":{"href":"https://github.com/ZaruhiAvagyan/Homework/pull/1#discussion_r366353636"},"pull_request":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1","id":362600496,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYyNjAwNDk2","html_url":"https://github.com/ZaruhiAvagyan/Homework/pull/1","diff_url":"https://github.com/ZaruhiAvagyan/Homework/pull/1.diff","patch_url":"https://github.com/ZaruhiAvagyan/Homework/pull/1.patch","issue_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/1","number":1,"state":"open","locked":false,"title":"Faculty, Group, Student and University classes added","user":{"login":"ZaruhiAvagyan","id":57710778,"node_id":"MDQ6VXNlcjU3NzEwNzc4","avatar_url":"https://avatars2.githubusercontent.com/u/57710778?v=4","gravatar_id":"","url":"https://api.github.com/users/ZaruhiAvagyan","html_url":"https://github.com/ZaruhiAvagyan","followers_url":"https://api.github.com/users/ZaruhiAvagyan/followers","following_url":"https://api.github.com/users/ZaruhiAvagyan/following{/other_user}","gists_url":"https://api.github.com/users/ZaruhiAvagyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaruhiAvagyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaruhiAvagyan/subscriptions","organizations_url":"https://api.github.com/users/ZaruhiAvagyan/orgs","repos_url":"https://api.github.com/users/ZaruhiAvagyan/repos","events_url":"https://api.github.com/users/ZaruhiAvagyan/events{/privacy}","received_events_url":"https://api.github.com/users/ZaruhiAvagyan/received_events","type":"User","site_admin":false},"body":"","created_at":"2020-01-14T12:07:45Z","updated_at":"2020-01-14T14:04:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52fbe09f956d738bc868fba090ecbfff46d666a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/1/comments","statuses_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/statuses/0c5ec472014422122e28c5b9b2ba77fe48fe527b","head":{"label":"ZaruhiAvagyan:develop","ref":"develop","sha":"0c5ec472014422122e28c5b9b2ba77fe48fe527b","user":{"login":"ZaruhiAvagyan","id":57710778,"node_id":"MDQ6VXNlcjU3NzEwNzc4","avatar_url":"https://avatars2.githubusercontent.com/u/57710778?v=4","gravatar_id":"","url":"https://api.github.com/users/ZaruhiAvagyan","html_url":"https://github.com/ZaruhiAvagyan","followers_url":"https://api.github.com/users/ZaruhiAvagyan/followers","following_url":"https://api.github.com/users/ZaruhiAvagyan/following{/other_user}","gists_url":"https://api.github.com/users/ZaruhiAvagyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaruhiAvagyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaruhiAvagyan/subscriptions","organizations_url":"https://api.github.com/users/ZaruhiAvagyan/orgs","repos_url":"https://api.github.com/users/ZaruhiAvagyan/repos","events_url":"https://api.github.com/users/ZaruhiAvagyan/events{/privacy}","received_events_url":"https://api.github.com/users/ZaruhiAvagyan/received_events","type":"User","site_admin":false},"repo":{"id":233828216,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM4MjgyMTY=","name":"Homework","full_name":"ZaruhiAvagyan/Homework","private":false,"owner":{"login":"ZaruhiAvagyan","id":57710778,"node_id":"MDQ6VXNlcjU3NzEwNzc4","avatar_url":"https://avatars2.githubusercontent.com/u/57710778?v=4","gravatar_id":"","url":"https://api.github.com/users/ZaruhiAvagyan","html_url":"https://github.com/ZaruhiAvagyan","followers_url":"https://api.github.com/users/ZaruhiAvagyan/followers","following_url":"https://api.github.com/users/ZaruhiAvagyan/following{/other_user}","gists_url":"https://api.github.com/users/ZaruhiAvagyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaruhiAvagyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaruhiAvagyan/subscriptions","organizations_url":"https://api.github.com/users/ZaruhiAvagyan/orgs","repos_url":"https://api.github.com/users/ZaruhiAvagyan/repos","events_url":"https://api.github.com/users/ZaruhiAvagyan/events{/privacy}","received_events_url":"https://api.github.com/users/ZaruhiAvagyan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ZaruhiAvagyan/Homework","description":null,"fork":false,"url":"https://api.github.com/repos/ZaruhiAvagyan/Homework","forks_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/forks","keys_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/teams","hooks_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/hooks","issue_events_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/events{/number}","events_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/events","assignees_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/assignees{/user}","branches_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/branches{/branch}","tags_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/tags","blobs_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/statuses/{sha}","languages_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/languages","stargazers_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/stargazers","contributors_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/contributors","subscribers_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/subscribers","subscription_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/subscription","commits_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/contents/{+path}","compare_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/merges","archive_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/downloads","issues_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues{/number}","pulls_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls{/number}","milestones_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/milestones{/number}","notifications_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/labels{/name}","releases_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/releases{/id}","deployments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/deployments","created_at":"2020-01-14T11:40:22Z","updated_at":"2020-01-14T11:45:20Z","pushed_at":"2020-01-14T12:07:46Z","git_url":"git://github.com/ZaruhiAvagyan/Homework.git","ssh_url":"git@github.com:ZaruhiAvagyan/Homework.git","clone_url":"https://github.com/ZaruhiAvagyan/Homework.git","svn_url":"https://github.com/ZaruhiAvagyan/Homework","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ZaruhiAvagyan:master","ref":"master","sha":"168b57c0b664954916a060eb0a50625c10d327a4","user":{"login":"ZaruhiAvagyan","id":57710778,"node_id":"MDQ6VXNlcjU3NzEwNzc4","avatar_url":"https://avatars2.githubusercontent.com/u/57710778?v=4","gravatar_id":"","url":"https://api.github.com/users/ZaruhiAvagyan","html_url":"https://github.com/ZaruhiAvagyan","followers_url":"https://api.github.com/users/ZaruhiAvagyan/followers","following_url":"https://api.github.com/users/ZaruhiAvagyan/following{/other_user}","gists_url":"https://api.github.com/users/ZaruhiAvagyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaruhiAvagyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaruhiAvagyan/subscriptions","organizations_url":"https://api.github.com/users/ZaruhiAvagyan/orgs","repos_url":"https://api.github.com/users/ZaruhiAvagyan/repos","events_url":"https://api.github.com/users/ZaruhiAvagyan/events{/privacy}","received_events_url":"https://api.github.com/users/ZaruhiAvagyan/received_events","type":"User","site_admin":false},"repo":{"id":233828216,"node_id":"MDEwOlJlcG9zaXRvcnkyMzM4MjgyMTY=","name":"Homework","full_name":"ZaruhiAvagyan/Homework","private":false,"owner":{"login":"ZaruhiAvagyan","id":57710778,"node_id":"MDQ6VXNlcjU3NzEwNzc4","avatar_url":"https://avatars2.githubusercontent.com/u/57710778?v=4","gravatar_id":"","url":"https://api.github.com/users/ZaruhiAvagyan","html_url":"https://github.com/ZaruhiAvagyan","followers_url":"https://api.github.com/users/ZaruhiAvagyan/followers","following_url":"https://api.github.com/users/ZaruhiAvagyan/following{/other_user}","gists_url":"https://api.github.com/users/ZaruhiAvagyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ZaruhiAvagyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZaruhiAvagyan/subscriptions","organizations_url":"https://api.github.com/users/ZaruhiAvagyan/orgs","repos_url":"https://api.github.com/users/ZaruhiAvagyan/repos","events_url":"https://api.github.com/users/ZaruhiAvagyan/events{/privacy}","received_events_url":"https://api.github.com/users/ZaruhiAvagyan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ZaruhiAvagyan/Homework","description":null,"fork":false,"url":"https://api.github.com/repos/ZaruhiAvagyan/Homework","forks_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/forks","keys_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/teams","hooks_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/hooks","issue_events_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/events{/number}","events_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/events","assignees_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/assignees{/user}","branches_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/branches{/branch}","tags_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/tags","blobs_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/statuses/{sha}","languages_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/languages","stargazers_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/stargazers","contributors_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/contributors","subscribers_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/subscribers","subscription_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/subscription","commits_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/contents/{+path}","compare_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/merges","archive_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/downloads","issues_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues{/number}","pulls_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls{/number}","milestones_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/milestones{/number}","notifications_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/labels{/name}","releases_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/releases{/id}","deployments_url":"https://api.github.com/repos/ZaruhiAvagyan/Homework/deployments","created_at":"2020-01-14T11:40:22Z","updated_at":"2020-01-14T11:45:20Z","pushed_at":"2020-01-14T12:07:46Z","git_url":"git://github.com/ZaruhiAvagyan/Homework.git","ssh_url":"git@github.com:ZaruhiAvagyan/Homework.git","clone_url":"https://github.com/ZaruhiAvagyan/Homework.git","svn_url":"https://github.com/ZaruhiAvagyan/Homework","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1"},"html":{"href":"https://github.com/ZaruhiAvagyan/Homework/pull/1"},"issue":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/1"},"comments":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ZaruhiAvagyan/Homework/statuses/0c5ec472014422122e28c5b9b2ba77fe48fe527b"}},"author_association":"OWNER"}}
|
{
"id": 233828216,
"name": "ZaruhiAvagyan/Homework",
"url": "https://api.github.com/repos/ZaruhiAvagyan/Homework"
}
|
{
"id": 59051228,
"login": "naira-tamrazyan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/59051228?",
"url": "https://api.github.com/users/naira-tamrazyan"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2020-01-14T14:02:03 |
11271972755
|
{"actor":{"display_login":"naira-tamrazyan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/comments/314589380","pull_request_review_id":275782153,"id":314589380,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDU4OTM4MA==","diff_hunk":"@@ -15,6 +15,8 @@\n \n BOOST_AUTO_TEST_SUITE(test_property)\n \n+using namespace mqtt::literals;","path":"test/property.cpp","position":4,"original_position":4,"commit_id":"6ebc699aa471c8dea5b3c24e77673bf21a7ee159","original_commit_id":"e470402a1bf3ed40efcfb7d1bb6a95032e7b88a1","user":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"body":"I didn't come up with that. I will fix it.","created_at":"2019-08-16T05:43:01Z","updated_at":"2019-08-16T05:43:01Z","html_url":"https://github.com/redboltz/mqtt_cpp/pull/337#discussion_r314589380","pull_request_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/comments/314589380"},"html":{"href":"https://github.com/redboltz/mqtt_cpp/pull/337#discussion_r314589380"},"pull_request":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337"}},"in_reply_to_id":314580946},"pull_request":{"url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337","id":307136011,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3MTM2MDEx","html_url":"https://github.com/redboltz/mqtt_cpp/pull/337","diff_url":"https://github.com/redboltz/mqtt_cpp/pull/337.diff","patch_url":"https://github.com/redboltz/mqtt_cpp/pull/337.patch","issue_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/337","number":337,"state":"open","locked":false,"title":"Implemented #320.","user":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"body":"Added buffer class that supports `mqtt::string_view` compatible\r\nbehavior and life keekping mechanism (optional).\r\n\r\nCallback functions for users hold receive buffer directly via\r\n`buffer`.\r\n\r\nRemoved `*_ref` properties. Ref or not ref is hidden by `buffer`.","created_at":"2019-08-14T01:25:49Z","updated_at":"2019-08-16T05:43:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfb4546431c495ae22b6316ab42be945d2ecd40b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337/commits","review_comments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337/comments","review_comment_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/337/comments","statuses_url":"https://api.github.com/repos/redboltz/mqtt_cpp/statuses/6ebc699aa471c8dea5b3c24e77673bf21a7ee159","head":{"label":"redboltz:impl_320","ref":"impl_320","sha":"6ebc699aa471c8dea5b3c24e77673bf21a7ee159","user":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"repo":{"id":47496286,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ5NjI4Ng==","name":"mqtt_cpp","full_name":"redboltz/mqtt_cpp","private":false,"owner":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/redboltz/mqtt_cpp","description":null,"fork":false,"url":"https://api.github.com/repos/redboltz/mqtt_cpp","forks_url":"https://api.github.com/repos/redboltz/mqtt_cpp/forks","keys_url":"https://api.github.com/repos/redboltz/mqtt_cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redboltz/mqtt_cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redboltz/mqtt_cpp/teams","hooks_url":"https://api.github.com/repos/redboltz/mqtt_cpp/hooks","issue_events_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/events{/number}","events_url":"https://api.github.com/repos/redboltz/mqtt_cpp/events","assignees_url":"https://api.github.com/repos/redboltz/mqtt_cpp/assignees{/user}","branches_url":"https://api.github.com/repos/redboltz/mqtt_cpp/branches{/branch}","tags_url":"https://api.github.com/repos/redboltz/mqtt_cpp/tags","blobs_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redboltz/mqtt_cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/redboltz/mqtt_cpp/languages","stargazers_url":"https://api.github.com/repos/redboltz/mqtt_cpp/stargazers","contributors_url":"https://api.github.com/repos/redboltz/mqtt_cpp/contributors","subscribers_url":"https://api.github.com/repos/redboltz/mqtt_cpp/subscribers","subscription_url":"https://api.github.com/repos/redboltz/mqtt_cpp/subscription","commits_url":"https://api.github.com/repos/redboltz/mqtt_cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/redboltz/mqtt_cpp/contents/{+path}","compare_url":"https://api.github.com/repos/redboltz/mqtt_cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redboltz/mqtt_cpp/merges","archive_url":"https://api.github.com/repos/redboltz/mqtt_cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redboltz/mqtt_cpp/downloads","issues_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues{/number}","pulls_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/redboltz/mqtt_cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/redboltz/mqtt_cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redboltz/mqtt_cpp/labels{/name}","releases_url":"https://api.github.com/repos/redboltz/mqtt_cpp/releases{/id}","deployments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/deployments","created_at":"2015-12-06T12:43:23Z","updated_at":"2019-08-16T01:01:59Z","pushed_at":"2019-08-16T05:18:16Z","git_url":"git://github.com/redboltz/mqtt_cpp.git","ssh_url":"git@github.com:redboltz/mqtt_cpp.git","clone_url":"https://github.com/redboltz/mqtt_cpp.git","svn_url":"https://github.com/redboltz/mqtt_cpp","homepage":null,"size":1651,"stargazers_count":89,"watchers_count":89,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":37,"open_issues":24,"watchers":89,"default_branch":"master"}},"base":{"label":"redboltz:master","ref":"master","sha":"757cba16da08018cce603f840d61f7824681debf","user":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"repo":{"id":47496286,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ5NjI4Ng==","name":"mqtt_cpp","full_name":"redboltz/mqtt_cpp","private":false,"owner":{"login":"redboltz","id":275959,"node_id":"MDQ6VXNlcjI3NTk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/275959?v=4","gravatar_id":"","url":"https://api.github.com/users/redboltz","html_url":"https://github.com/redboltz","followers_url":"https://api.github.com/users/redboltz/followers","following_url":"https://api.github.com/users/redboltz/following{/other_user}","gists_url":"https://api.github.com/users/redboltz/gists{/gist_id}","starred_url":"https://api.github.com/users/redboltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redboltz/subscriptions","organizations_url":"https://api.github.com/users/redboltz/orgs","repos_url":"https://api.github.com/users/redboltz/repos","events_url":"https://api.github.com/users/redboltz/events{/privacy}","received_events_url":"https://api.github.com/users/redboltz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/redboltz/mqtt_cpp","description":null,"fork":false,"url":"https://api.github.com/repos/redboltz/mqtt_cpp","forks_url":"https://api.github.com/repos/redboltz/mqtt_cpp/forks","keys_url":"https://api.github.com/repos/redboltz/mqtt_cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redboltz/mqtt_cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redboltz/mqtt_cpp/teams","hooks_url":"https://api.github.com/repos/redboltz/mqtt_cpp/hooks","issue_events_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/events{/number}","events_url":"https://api.github.com/repos/redboltz/mqtt_cpp/events","assignees_url":"https://api.github.com/repos/redboltz/mqtt_cpp/assignees{/user}","branches_url":"https://api.github.com/repos/redboltz/mqtt_cpp/branches{/branch}","tags_url":"https://api.github.com/repos/redboltz/mqtt_cpp/tags","blobs_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redboltz/mqtt_cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/redboltz/mqtt_cpp/languages","stargazers_url":"https://api.github.com/repos/redboltz/mqtt_cpp/stargazers","contributors_url":"https://api.github.com/repos/redboltz/mqtt_cpp/contributors","subscribers_url":"https://api.github.com/repos/redboltz/mqtt_cpp/subscribers","subscription_url":"https://api.github.com/repos/redboltz/mqtt_cpp/subscription","commits_url":"https://api.github.com/repos/redboltz/mqtt_cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/redboltz/mqtt_cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/redboltz/mqtt_cpp/contents/{+path}","compare_url":"https://api.github.com/repos/redboltz/mqtt_cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redboltz/mqtt_cpp/merges","archive_url":"https://api.github.com/repos/redboltz/mqtt_cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redboltz/mqtt_cpp/downloads","issues_url":"https://api.github.com/repos/redboltz/mqtt_cpp/issues{/number}","pulls_url":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/redboltz/mqtt_cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/redboltz/mqtt_cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redboltz/mqtt_cpp/labels{/name}","releases_url":"https://api.github.com/repos/redboltz/mqtt_cpp/releases{/id}","deployments_url":"https://api.github.com/repos/redboltz/mqtt_cpp/deployments","created_at":"2015-12-06T12:43:23Z","updated_at":"2019-08-16T01:01:59Z","pushed_at":"2019-08-16T05:18:16Z","git_url":"git://github.com/redboltz/mqtt_cpp.git","ssh_url":"git@github.com:redboltz/mqtt_cpp.git","clone_url":"https://github.com/redboltz/mqtt_cpp.git","svn_url":"https://github.com/redboltz/mqtt_cpp","homepage":null,"size":1651,"stargazers_count":89,"watchers_count":89,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":37,"open_issues":24,"watchers":89,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337"},"html":{"href":"https://github.com/redboltz/mqtt_cpp/pull/337"},"issue":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/337"},"comments":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/redboltz/mqtt_cpp/statuses/6ebc699aa471c8dea5b3c24e77673bf21a7ee159"}},"author_association":"OWNER"}}
|
{
"id": 47496286,
"name": "redboltz/mqtt_cpp",
"url": "https://api.github.com/repos/redboltz/mqtt_cpp"
}
|
{
"id": 275959,
"login": "redboltz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/275959?",
"url": "https://api.github.com/users/redboltz"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-16T05:43:01 |
10222216108
|
{"actor":{"display_login":"redboltz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/comments/285568590","pull_request_review_id":239469283,"id":285568590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTU2ODU5MA==","diff_hunk":"@@ -1,4 +1,4 @@\n-class CreateMenuHistory < ActiveRecord::Migration\n+class CreateMenuHistory < ActiveRecord::Migration[4.2]","path":"db/migrate/20180605013851_create_menu_history.rb","position":2,"original_position":2,"commit_id":"1f71385f889936f6309f0450f4c3e097b3623165","original_commit_id":"1f71385f889936f6309f0450f4c3e097b3623165","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/Documentation: Missing top-level class documentation comment.<br>Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.","created_at":"2019-05-20T12:34:37Z","updated_at":"2019-05-20T12:34:41Z","html_url":"https://github.com/vutienduong/order_lunch/pull/13#discussion_r285568590","pull_request_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/comments/285568590"},"html":{"href":"https://github.com/vutienduong/order_lunch/pull/13#discussion_r285568590"},"pull_request":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13","id":278652206,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4NjUyMjA2","html_url":"https://github.com/vutienduong/order_lunch/pull/13","diff_url":"https://github.com/vutienduong/order_lunch/pull/13.diff","patch_url":"https://github.com/vutienduong/order_lunch/pull/13.patch","issue_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/13","number":13,"state":"open","locked":false,"title":"[WIP] Update new UI","user":{"login":"vutienduongeh","id":32259322,"node_id":"MDQ6VXNlcjMyMjU5MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/32259322?v=4","gravatar_id":"","url":"https://api.github.com/users/vutienduongeh","html_url":"https://github.com/vutienduongeh","followers_url":"https://api.github.com/users/vutienduongeh/followers","following_url":"https://api.github.com/users/vutienduongeh/following{/other_user}","gists_url":"https://api.github.com/users/vutienduongeh/gists{/gist_id}","starred_url":"https://api.github.com/users/vutienduongeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutienduongeh/subscriptions","organizations_url":"https://api.github.com/users/vutienduongeh/orgs","repos_url":"https://api.github.com/users/vutienduongeh/repos","events_url":"https://api.github.com/users/vutienduongeh/events{/privacy}","received_events_url":"https://api.github.com/users/vutienduongeh/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-14T12:07:13Z","updated_at":"2019-05-20T12:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3e15071d5d0fffc413eb08350ffbd554e38b7c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1361011590,"node_id":"MDU6TGFiZWwxMzYxMDExNTkw","url":"https://api.github.com/repos/vutienduong/order_lunch/labels/WIP","name":"WIP","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13/commits","review_comments_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13/comments","review_comment_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/13/comments","statuses_url":"https://api.github.com/repos/vutienduong/order_lunch/statuses/1f71385f889936f6309f0450f4c3e097b3623165","head":{"label":"vutienduong:develop","ref":"develop","sha":"1f71385f889936f6309f0450f4c3e097b3623165","user":{"login":"vutienduong","id":4931188,"node_id":"MDQ6VXNlcjQ5MzExODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4931188?v=4","gravatar_id":"","url":"https://api.github.com/users/vutienduong","html_url":"https://github.com/vutienduong","followers_url":"https://api.github.com/users/vutienduong/followers","following_url":"https://api.github.com/users/vutienduong/following{/other_user}","gists_url":"https://api.github.com/users/vutienduong/gists{/gist_id}","starred_url":"https://api.github.com/users/vutienduong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutienduong/subscriptions","organizations_url":"https://api.github.com/users/vutienduong/orgs","repos_url":"https://api.github.com/users/vutienduong/repos","events_url":"https://api.github.com/users/vutienduong/events{/privacy}","received_events_url":"https://api.github.com/users/vutienduong/received_events","type":"User","site_admin":false},"repo":{"id":106387894,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzODc4OTQ=","name":"order_lunch","full_name":"vutienduong/order_lunch","private":false,"owner":{"login":"vutienduong","id":4931188,"node_id":"MDQ6VXNlcjQ5MzExODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4931188?v=4","gravatar_id":"","url":"https://api.github.com/users/vutienduong","html_url":"https://github.com/vutienduong","followers_url":"https://api.github.com/users/vutienduong/followers","following_url":"https://api.github.com/users/vutienduong/following{/other_user}","gists_url":"https://api.github.com/users/vutienduong/gists{/gist_id}","starred_url":"https://api.github.com/users/vutienduong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutienduong/subscriptions","organizations_url":"https://api.github.com/users/vutienduong/orgs","repos_url":"https://api.github.com/users/vutienduong/repos","events_url":"https://api.github.com/users/vutienduong/events{/privacy}","received_events_url":"https://api.github.com/users/vutienduong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vutienduong/order_lunch","description":null,"fork":false,"url":"https://api.github.com/repos/vutienduong/order_lunch","forks_url":"https://api.github.com/repos/vutienduong/order_lunch/forks","keys_url":"https://api.github.com/repos/vutienduong/order_lunch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vutienduong/order_lunch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vutienduong/order_lunch/teams","hooks_url":"https://api.github.com/repos/vutienduong/order_lunch/hooks","issue_events_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/events{/number}","events_url":"https://api.github.com/repos/vutienduong/order_lunch/events","assignees_url":"https://api.github.com/repos/vutienduong/order_lunch/assignees{/user}","branches_url":"https://api.github.com/repos/vutienduong/order_lunch/branches{/branch}","tags_url":"https://api.github.com/repos/vutienduong/order_lunch/tags","blobs_url":"https://api.github.com/repos/vutienduong/order_lunch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vutienduong/order_lunch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vutienduong/order_lunch/git/refs{/sha}","trees_url":"https://api.github.com/repos/vutienduong/order_lunch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vutienduong/order_lunch/statuses/{sha}","languages_url":"https://api.github.com/repos/vutienduong/order_lunch/languages","stargazers_url":"https://api.github.com/repos/vutienduong/order_lunch/stargazers","contributors_url":"https://api.github.com/repos/vutienduong/order_lunch/contributors","subscribers_url":"https://api.github.com/repos/vutienduong/order_lunch/subscribers","subscription_url":"https://api.github.com/repos/vutienduong/order_lunch/subscription","commits_url":"https://api.github.com/repos/vutienduong/order_lunch/commits{/sha}","git_commits_url":"https://api.github.com/repos/vutienduong/order_lunch/git/commits{/sha}","comments_url":"https://api.github.com/repos/vutienduong/order_lunch/comments{/number}","issue_comment_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/comments{/number}","contents_url":"https://api.github.com/repos/vutienduong/order_lunch/contents/{+path}","compare_url":"https://api.github.com/repos/vutienduong/order_lunch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vutienduong/order_lunch/merges","archive_url":"https://api.github.com/repos/vutienduong/order_lunch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vutienduong/order_lunch/downloads","issues_url":"https://api.github.com/repos/vutienduong/order_lunch/issues{/number}","pulls_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls{/number}","milestones_url":"https://api.github.com/repos/vutienduong/order_lunch/milestones{/number}","notifications_url":"https://api.github.com/repos/vutienduong/order_lunch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vutienduong/order_lunch/labels{/name}","releases_url":"https://api.github.com/repos/vutienduong/order_lunch/releases{/id}","deployments_url":"https://api.github.com/repos/vutienduong/order_lunch/deployments","created_at":"2017-10-10T08:11:57Z","updated_at":"2018-12-14T03:27:33Z","pushed_at":"2019-05-20T12:33:46Z","git_url":"git://github.com/vutienduong/order_lunch.git","ssh_url":"git@github.com:vutienduong/order_lunch.git","clone_url":"https://github.com/vutienduong/order_lunch.git","svn_url":"https://github.com/vutienduong/order_lunch","homepage":null,"size":17047,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"vutienduong:master","ref":"master","sha":"45cbf0217c6fdb5fd9620e5e9f37c74ef9b1fa8e","user":{"login":"vutienduong","id":4931188,"node_id":"MDQ6VXNlcjQ5MzExODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4931188?v=4","gravatar_id":"","url":"https://api.github.com/users/vutienduong","html_url":"https://github.com/vutienduong","followers_url":"https://api.github.com/users/vutienduong/followers","following_url":"https://api.github.com/users/vutienduong/following{/other_user}","gists_url":"https://api.github.com/users/vutienduong/gists{/gist_id}","starred_url":"https://api.github.com/users/vutienduong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutienduong/subscriptions","organizations_url":"https://api.github.com/users/vutienduong/orgs","repos_url":"https://api.github.com/users/vutienduong/repos","events_url":"https://api.github.com/users/vutienduong/events{/privacy}","received_events_url":"https://api.github.com/users/vutienduong/received_events","type":"User","site_admin":false},"repo":{"id":106387894,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzODc4OTQ=","name":"order_lunch","full_name":"vutienduong/order_lunch","private":false,"owner":{"login":"vutienduong","id":4931188,"node_id":"MDQ6VXNlcjQ5MzExODg=","avatar_url":"https://avatars0.githubusercontent.com/u/4931188?v=4","gravatar_id":"","url":"https://api.github.com/users/vutienduong","html_url":"https://github.com/vutienduong","followers_url":"https://api.github.com/users/vutienduong/followers","following_url":"https://api.github.com/users/vutienduong/following{/other_user}","gists_url":"https://api.github.com/users/vutienduong/gists{/gist_id}","starred_url":"https://api.github.com/users/vutienduong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vutienduong/subscriptions","organizations_url":"https://api.github.com/users/vutienduong/orgs","repos_url":"https://api.github.com/users/vutienduong/repos","events_url":"https://api.github.com/users/vutienduong/events{/privacy}","received_events_url":"https://api.github.com/users/vutienduong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vutienduong/order_lunch","description":null,"fork":false,"url":"https://api.github.com/repos/vutienduong/order_lunch","forks_url":"https://api.github.com/repos/vutienduong/order_lunch/forks","keys_url":"https://api.github.com/repos/vutienduong/order_lunch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vutienduong/order_lunch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vutienduong/order_lunch/teams","hooks_url":"https://api.github.com/repos/vutienduong/order_lunch/hooks","issue_events_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/events{/number}","events_url":"https://api.github.com/repos/vutienduong/order_lunch/events","assignees_url":"https://api.github.com/repos/vutienduong/order_lunch/assignees{/user}","branches_url":"https://api.github.com/repos/vutienduong/order_lunch/branches{/branch}","tags_url":"https://api.github.com/repos/vutienduong/order_lunch/tags","blobs_url":"https://api.github.com/repos/vutienduong/order_lunch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vutienduong/order_lunch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vutienduong/order_lunch/git/refs{/sha}","trees_url":"https://api.github.com/repos/vutienduong/order_lunch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vutienduong/order_lunch/statuses/{sha}","languages_url":"https://api.github.com/repos/vutienduong/order_lunch/languages","stargazers_url":"https://api.github.com/repos/vutienduong/order_lunch/stargazers","contributors_url":"https://api.github.com/repos/vutienduong/order_lunch/contributors","subscribers_url":"https://api.github.com/repos/vutienduong/order_lunch/subscribers","subscription_url":"https://api.github.com/repos/vutienduong/order_lunch/subscription","commits_url":"https://api.github.com/repos/vutienduong/order_lunch/commits{/sha}","git_commits_url":"https://api.github.com/repos/vutienduong/order_lunch/git/commits{/sha}","comments_url":"https://api.github.com/repos/vutienduong/order_lunch/comments{/number}","issue_comment_url":"https://api.github.com/repos/vutienduong/order_lunch/issues/comments{/number}","contents_url":"https://api.github.com/repos/vutienduong/order_lunch/contents/{+path}","compare_url":"https://api.github.com/repos/vutienduong/order_lunch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vutienduong/order_lunch/merges","archive_url":"https://api.github.com/repos/vutienduong/order_lunch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vutienduong/order_lunch/downloads","issues_url":"https://api.github.com/repos/vutienduong/order_lunch/issues{/number}","pulls_url":"https://api.github.com/repos/vutienduong/order_lunch/pulls{/number}","milestones_url":"https://api.github.com/repos/vutienduong/order_lunch/milestones{/number}","notifications_url":"https://api.github.com/repos/vutienduong/order_lunch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vutienduong/order_lunch/labels{/name}","releases_url":"https://api.github.com/repos/vutienduong/order_lunch/releases{/id}","deployments_url":"https://api.github.com/repos/vutienduong/order_lunch/deployments","created_at":"2017-10-10T08:11:57Z","updated_at":"2018-12-14T03:27:33Z","pushed_at":"2019-05-20T12:33:46Z","git_url":"git://github.com/vutienduong/order_lunch.git","ssh_url":"git@github.com:vutienduong/order_lunch.git","clone_url":"https://github.com/vutienduong/order_lunch.git","svn_url":"https://github.com/vutienduong/order_lunch","homepage":null,"size":17047,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13"},"html":{"href":"https://github.com/vutienduong/order_lunch/pull/13"},"issue":{"href":"https://api.github.com/repos/vutienduong/order_lunch/issues/13"},"comments":{"href":"https://api.github.com/repos/vutienduong/order_lunch/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vutienduong/order_lunch/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/vutienduong/order_lunch/statuses/1f71385f889936f6309f0450f4c3e097b3623165"}},"author_association":"COLLABORATOR"}}
|
{
"id": 106387894,
"name": "vutienduong/order_lunch",
"url": "https://api.github.com/repos/vutienduong/order_lunch"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-20T12:34:37 |
9659044399
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/comments/261033902","pull_request_review_id":208874664,"id":261033902,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTAzMzkwMg==","diff_hunk":"@@ -2,9 +2,21 @@ version: 2.1\n executors:\n ci-executor:\n docker:\n- - image: REPLACE-ME-WITH-DOCKER-IMAGE\n+ - image: githubtraining/ci-custom:latest\n jobs:\n build:\n executor: ci-executor\n steps:\n - checkout\n+\n+ - run:\n+ name: build dependencies\n+ command: bundle install\n+\n+ - run:\n+ name: build the jekyll site\n+ command: REPLACE-ME-WITH-BUILD-COMMAND","path":".circleci/config.yml","position":18,"original_position":18,"commit_id":"074b7720b02e2925bd69970bc118a1eb7e1f8130","original_commit_id":"074b7720b02e2925bd69970bc118a1eb7e1f8130","user":{"login":"github-learning-lab[bot]","id":37936606,"node_id":"MDM6Qm90Mzc5MzY2MDY=","avatar_url":"https://avatars0.githubusercontent.com/in/10572?v=4","gravatar_id":"","url":"https://api.github.com/users/github-learning-lab%5Bbot%5D","html_url":"https://github.com/apps/github-learning-lab","followers_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/followers","following_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/repos","events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"```suggestion\n command: bundle exec jekyll build\n```\n","created_at":"2019-02-28T03:17:45Z","updated_at":"2019-02-28T03:17:45Z","html_url":"https://github.com/dooberstein/continuous-integration-circle/pull/3#discussion_r261033902","pull_request_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/comments/261033902"},"html":{"href":"https://github.com/dooberstein/continuous-integration-circle/pull/3#discussion_r261033902"},"pull_request":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3","id":256917868,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2OTE3ODY4","html_url":"https://github.com/dooberstein/continuous-integration-circle/pull/3","diff_url":"https://github.com/dooberstein/continuous-integration-circle/pull/3.diff","patch_url":"https://github.com/dooberstein/continuous-integration-circle/pull/3.patch","issue_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/3","number":3,"state":"open","locked":false,"title":"Configure the build","user":{"login":"github-learning-lab[bot]","id":37936606,"node_id":"MDM6Qm90Mzc5MzY2MDY=","avatar_url":"https://avatars0.githubusercontent.com/in/10572?v=4","gravatar_id":"","url":"https://api.github.com/users/github-learning-lab%5Bbot%5D","html_url":"https://github.com/apps/github-learning-lab","followers_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/followers","following_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/repos","events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/github-learning-lab%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"In this pull request, I've added some tests to help ensure the project builds. This is one example of how you can customize specific validations to run when your CI starts a build. I need you to add a **run action** to your `.circleci/config.yml` file.\n\nIn this example, we'll build the project with `bundle exec jekyll build`. Depending on the programming language and project, you might use a different command, like `yarn run android` or `nvm package`. You can find more specific information on CircleCI configuration [in their documentation](https://circleci.com/docs/2.0/tutorials/).\n\n## Step 5: Add validation\n\nBuild your site.\n\n### :keyboard: Activity: Add some automated validation to your project\n\n1. In this pull request, add the following code to the placeholder in your `.circleci/config.yml` file. **You can do this by editing the file from the _Files changed_ tab, or by scrolling down and accepting the suggested change.**\n\n```yaml\n bundle exec jekyll build\n```\n\n2. Commit your change.\n\n<hr>\n<h3 align=\"center\">I'll respond below with your next step.</h3>\n\n> _Sometimes I respond too fast for the page to update! If you perform an expected action and don't see a response, wait a few seconds and refresh the page for your next steps._\n","created_at":"2019-02-28T03:17:43Z","updated_at":"2019-02-28T03:17:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd78c8a19737e0cc9fc66da8c6e5b1aba917e16b","assignee":{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false},"assignees":[{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3/commits","review_comments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3/comments","review_comment_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/3/comments","statuses_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/statuses/074b7720b02e2925bd69970bc118a1eb7e1f8130","head":{"label":"dooberstein:custom-build","ref":"custom-build","sha":"074b7720b02e2925bd69970bc118a1eb7e1f8130","user":{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false},"repo":{"id":173021069,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMwMjEwNjk=","name":"continuous-integration-circle","full_name":"dooberstein/continuous-integration-circle","private":false,"owner":{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dooberstein/continuous-integration-circle","description":null,"fork":false,"url":"https://api.github.com/repos/dooberstein/continuous-integration-circle","forks_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/forks","keys_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/teams","hooks_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/hooks","issue_events_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/events{/number}","events_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/events","assignees_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/assignees{/user}","branches_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/branches{/branch}","tags_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/tags","blobs_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/refs{/sha}","trees_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/statuses/{sha}","languages_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/languages","stargazers_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/stargazers","contributors_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/contributors","subscribers_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/subscribers","subscription_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/subscription","commits_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/commits{/sha}","git_commits_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/commits{/sha}","comments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/comments{/number}","issue_comment_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/comments{/number}","contents_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/contents/{+path}","compare_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/merges","archive_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/downloads","issues_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues{/number}","pulls_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls{/number}","milestones_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/milestones{/number}","notifications_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/labels{/name}","releases_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/releases{/id}","deployments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/deployments","created_at":"2019-02-28T01:49:55Z","updated_at":"2019-02-28T03:17:44Z","pushed_at":"2019-02-28T03:17:44Z","git_url":"git://github.com/dooberstein/continuous-integration-circle.git","ssh_url":"git@github.com:dooberstein/continuous-integration-circle.git","clone_url":"https://github.com/dooberstein/continuous-integration-circle.git","svn_url":"https://github.com/dooberstein/continuous-integration-circle","homepage":"https://lab.github.com/githubtraining/continuous-integration-with-circleci","size":8,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dooberstein:master","ref":"master","sha":"a1042df2702f83e1c90a116644aebd7714bad6ef","user":{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false},"repo":{"id":173021069,"node_id":"MDEwOlJlcG9zaXRvcnkxNzMwMjEwNjk=","name":"continuous-integration-circle","full_name":"dooberstein/continuous-integration-circle","private":false,"owner":{"login":"dooberstein","id":17889671,"node_id":"MDQ6VXNlcjE3ODg5Njcx","avatar_url":"https://avatars1.githubusercontent.com/u/17889671?v=4","gravatar_id":"","url":"https://api.github.com/users/dooberstein","html_url":"https://github.com/dooberstein","followers_url":"https://api.github.com/users/dooberstein/followers","following_url":"https://api.github.com/users/dooberstein/following{/other_user}","gists_url":"https://api.github.com/users/dooberstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dooberstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooberstein/subscriptions","organizations_url":"https://api.github.com/users/dooberstein/orgs","repos_url":"https://api.github.com/users/dooberstein/repos","events_url":"https://api.github.com/users/dooberstein/events{/privacy}","received_events_url":"https://api.github.com/users/dooberstein/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dooberstein/continuous-integration-circle","description":null,"fork":false,"url":"https://api.github.com/repos/dooberstein/continuous-integration-circle","forks_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/forks","keys_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/teams","hooks_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/hooks","issue_events_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/events{/number}","events_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/events","assignees_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/assignees{/user}","branches_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/branches{/branch}","tags_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/tags","blobs_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/refs{/sha}","trees_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/statuses/{sha}","languages_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/languages","stargazers_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/stargazers","contributors_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/contributors","subscribers_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/subscribers","subscription_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/subscription","commits_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/commits{/sha}","git_commits_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/git/commits{/sha}","comments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/comments{/number}","issue_comment_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/comments{/number}","contents_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/contents/{+path}","compare_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/merges","archive_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/downloads","issues_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues{/number}","pulls_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls{/number}","milestones_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/milestones{/number}","notifications_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/labels{/name}","releases_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/releases{/id}","deployments_url":"https://api.github.com/repos/dooberstein/continuous-integration-circle/deployments","created_at":"2019-02-28T01:49:55Z","updated_at":"2019-02-28T03:17:44Z","pushed_at":"2019-02-28T03:17:44Z","git_url":"git://github.com/dooberstein/continuous-integration-circle.git","ssh_url":"git@github.com:dooberstein/continuous-integration-circle.git","clone_url":"https://github.com/dooberstein/continuous-integration-circle.git","svn_url":"https://github.com/dooberstein/continuous-integration-circle","homepage":"https://lab.github.com/githubtraining/continuous-integration-with-circleci","size":8,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3"},"html":{"href":"https://github.com/dooberstein/continuous-integration-circle/pull/3"},"issue":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/3"},"comments":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/dooberstein/continuous-integration-circle/statuses/074b7720b02e2925bd69970bc118a1eb7e1f8130"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 173021069,
"name": "dooberstein/continuous-integration-circle",
"url": "https://api.github.com/repos/dooberstein/continuous-integration-circle"
}
|
{
"id": 37936606,
"login": "github-learning-lab[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37936606?",
"url": "https://api.github.com/users/github-learning-lab[bot]"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-02-28T03:17:45 |
9151611721
|
{"actor":{"display_login":"github-learning-lab"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/comments/347701813","pull_request_review_id":318746896,"id":347701813,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzcwMTgxMw==","diff_hunk":"@@ -35,6 +32,10 @@ runs:\n args:\n - ${{ inputs.version }}\n - ${{ inputs.additional_gems }}\n+ - ${{ inputs.file_paths }}","path":"action.yml","position":21,"original_position":21,"commit_id":"02139c328a985a0ae4ceec5eed8899cbfd1a3279","original_commit_id":"02139c328a985a0ae4ceec5eed8899cbfd1a3279","user":{"login":"chiefpansancolt","id":5841177,"node_id":"MDQ6VXNlcjU4NDExNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5841177?v=4","gravatar_id":"","url":"https://api.github.com/users/chiefpansancolt","html_url":"https://github.com/chiefpansancolt","followers_url":"https://api.github.com/users/chiefpansancolt/followers","following_url":"https://api.github.com/users/chiefpansancolt/following{/other_user}","gists_url":"https://api.github.com/users/chiefpansancolt/gists{/gist_id}","starred_url":"https://api.github.com/users/chiefpansancolt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chiefpansancolt/subscriptions","organizations_url":"https://api.github.com/users/chiefpansancolt/orgs","repos_url":"https://api.github.com/users/chiefpansancolt/repos","events_url":"https://api.github.com/users/chiefpansancolt/events{/privacy}","received_events_url":"https://api.github.com/users/chiefpansancolt/received_events","type":"User","site_admin":false},"body":"from what i can tell without them then they still show available when running, but from other useages out there they were only added to args when used in the docker and entrypoint files all others were just inputs, but def double check","created_at":"2019-11-19T02:12:48Z","updated_at":"2019-11-19T02:12:49Z","html_url":"https://github.com/andrewmcodes/haml-lint-action/pull/7#discussion_r347701813","pull_request_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/comments/347701813"},"html":{"href":"https://github.com/andrewmcodes/haml-lint-action/pull/7#discussion_r347701813"},"pull_request":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7"}},"in_reply_to_id":347696043},"pull_request":{"url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7","id":342427715,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyNDI3NzE1","html_url":"https://github.com/andrewmcodes/haml-lint-action/pull/7","diff_url":"https://github.com/andrewmcodes/haml-lint-action/pull/7.diff","patch_url":"https://github.com/andrewmcodes/haml-lint-action/pull/7.patch","issue_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/7","number":7,"state":"open","locked":false,"title":"fix build error, update documentation, and add shell lint action","user":{"login":"andrewmcodes","id":18423853,"node_id":"MDQ6VXNlcjE4NDIzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/18423853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmcodes","html_url":"https://github.com/andrewmcodes","followers_url":"https://api.github.com/users/andrewmcodes/followers","following_url":"https://api.github.com/users/andrewmcodes/following{/other_user}","gists_url":"https://api.github.com/users/andrewmcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmcodes/subscriptions","organizations_url":"https://api.github.com/users/andrewmcodes/orgs","repos_url":"https://api.github.com/users/andrewmcodes/repos","events_url":"https://api.github.com/users/andrewmcodes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmcodes/received_events","type":"User","site_admin":false},"body":"# Bug Fix\r\n\r\n## Description\r\n\r\nThe action-ci test does not like the `action.yml` file currently.\r\n\r\nError:\r\n```\r\n/usr/local/lib/ruby/2.6.0/json/common.rb:156:in `parse': 767: unexpected token at 'File path 'app/**/*.html.haml' does not exist (JSON::ParserError)\r\n110\r\n'\r\n```\r\n\r\n## Why should this be added\r\n\r\nThis will fix the issue causing the syntax verification to fail and also adds some updates to the documentation. Also adds shell lint to hopefully avoid `sh` issues in the future.\r\n\r\n## Checklist\r\n\r\n- [x] My code follows the style guidelines of this project\r\n- [ ] Actions are passing\r\n","created_at":"2019-11-19T00:26:50Z","updated_at":"2019-11-19T02:12:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a831c8187e560cd4a50336fe1f4c89547ddb8ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7/commits","review_comments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7/comments","review_comment_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/7/comments","statuses_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/statuses/02139c328a985a0ae4ceec5eed8899cbfd1a3279","head":{"label":"andrewmcodes:fix-build-error","ref":"fix-build-error","sha":"02139c328a985a0ae4ceec5eed8899cbfd1a3279","user":{"login":"andrewmcodes","id":18423853,"node_id":"MDQ6VXNlcjE4NDIzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/18423853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmcodes","html_url":"https://github.com/andrewmcodes","followers_url":"https://api.github.com/users/andrewmcodes/followers","following_url":"https://api.github.com/users/andrewmcodes/following{/other_user}","gists_url":"https://api.github.com/users/andrewmcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmcodes/subscriptions","organizations_url":"https://api.github.com/users/andrewmcodes/orgs","repos_url":"https://api.github.com/users/andrewmcodes/repos","events_url":"https://api.github.com/users/andrewmcodes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmcodes/received_events","type":"User","site_admin":false},"repo":{"id":220346078,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAzNDYwNzg=","name":"haml-lint-action","full_name":"andrewmcodes/haml-lint-action","private":false,"owner":{"login":"andrewmcodes","id":18423853,"node_id":"MDQ6VXNlcjE4NDIzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/18423853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmcodes","html_url":"https://github.com/andrewmcodes","followers_url":"https://api.github.com/users/andrewmcodes/followers","following_url":"https://api.github.com/users/andrewmcodes/following{/other_user}","gists_url":"https://api.github.com/users/andrewmcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmcodes/subscriptions","organizations_url":"https://api.github.com/users/andrewmcodes/orgs","repos_url":"https://api.github.com/users/andrewmcodes/repos","events_url":"https://api.github.com/users/andrewmcodes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmcodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andrewmcodes/haml-lint-action","description":"A GitHub Action that lints your HAML code with HAML Lint!","fork":false,"url":"https://api.github.com/repos/andrewmcodes/haml-lint-action","forks_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/forks","keys_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/teams","hooks_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/hooks","issue_events_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/events{/number}","events_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/events","assignees_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/assignees{/user}","branches_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/branches{/branch}","tags_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/tags","blobs_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/languages","stargazers_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/stargazers","contributors_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/contributors","subscribers_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/subscribers","subscription_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/subscription","commits_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/contents/{+path}","compare_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/merges","archive_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/downloads","issues_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues{/number}","pulls_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/labels{/name}","releases_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/releases{/id}","deployments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/deployments","created_at":"2019-11-07T23:17:48Z","updated_at":"2019-11-18T17:17:38Z","pushed_at":"2019-11-19T01:07:24Z","git_url":"git://github.com/andrewmcodes/haml-lint-action.git","ssh_url":"git@github.com:andrewmcodes/haml-lint-action.git","clone_url":"https://github.com/andrewmcodes/haml-lint-action.git","svn_url":"https://github.com/andrewmcodes/haml-lint-action","homepage":null,"size":209,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"andrewmcodes:master","ref":"master","sha":"3062d005855a8e047f19e3f511bf4295be38ae27","user":{"login":"andrewmcodes","id":18423853,"node_id":"MDQ6VXNlcjE4NDIzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/18423853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmcodes","html_url":"https://github.com/andrewmcodes","followers_url":"https://api.github.com/users/andrewmcodes/followers","following_url":"https://api.github.com/users/andrewmcodes/following{/other_user}","gists_url":"https://api.github.com/users/andrewmcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmcodes/subscriptions","organizations_url":"https://api.github.com/users/andrewmcodes/orgs","repos_url":"https://api.github.com/users/andrewmcodes/repos","events_url":"https://api.github.com/users/andrewmcodes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmcodes/received_events","type":"User","site_admin":false},"repo":{"id":220346078,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAzNDYwNzg=","name":"haml-lint-action","full_name":"andrewmcodes/haml-lint-action","private":false,"owner":{"login":"andrewmcodes","id":18423853,"node_id":"MDQ6VXNlcjE4NDIzODUz","avatar_url":"https://avatars1.githubusercontent.com/u/18423853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmcodes","html_url":"https://github.com/andrewmcodes","followers_url":"https://api.github.com/users/andrewmcodes/followers","following_url":"https://api.github.com/users/andrewmcodes/following{/other_user}","gists_url":"https://api.github.com/users/andrewmcodes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmcodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmcodes/subscriptions","organizations_url":"https://api.github.com/users/andrewmcodes/orgs","repos_url":"https://api.github.com/users/andrewmcodes/repos","events_url":"https://api.github.com/users/andrewmcodes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmcodes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andrewmcodes/haml-lint-action","description":"A GitHub Action that lints your HAML code with HAML Lint!","fork":false,"url":"https://api.github.com/repos/andrewmcodes/haml-lint-action","forks_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/forks","keys_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/teams","hooks_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/hooks","issue_events_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/events{/number}","events_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/events","assignees_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/assignees{/user}","branches_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/branches{/branch}","tags_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/tags","blobs_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/languages","stargazers_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/stargazers","contributors_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/contributors","subscribers_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/subscribers","subscription_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/subscription","commits_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/contents/{+path}","compare_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/merges","archive_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/downloads","issues_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues{/number}","pulls_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/labels{/name}","releases_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/releases{/id}","deployments_url":"https://api.github.com/repos/andrewmcodes/haml-lint-action/deployments","created_at":"2019-11-07T23:17:48Z","updated_at":"2019-11-18T17:17:38Z","pushed_at":"2019-11-19T01:07:24Z","git_url":"git://github.com/andrewmcodes/haml-lint-action.git","ssh_url":"git@github.com:andrewmcodes/haml-lint-action.git","clone_url":"https://github.com/andrewmcodes/haml-lint-action.git","svn_url":"https://github.com/andrewmcodes/haml-lint-action","homepage":null,"size":209,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7"},"html":{"href":"https://github.com/andrewmcodes/haml-lint-action/pull/7"},"issue":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/7"},"comments":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/andrewmcodes/haml-lint-action/statuses/02139c328a985a0ae4ceec5eed8899cbfd1a3279"}},"author_association":"OWNER"}}
|
{
"id": 220346078,
"name": "andrewmcodes/haml-lint-action",
"url": "https://api.github.com/repos/andrewmcodes/haml-lint-action"
}
|
{
"id": 5841177,
"login": "chiefpansancolt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5841177?",
"url": "https://api.github.com/users/chiefpansancolt"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-19T02:12:48 |
10892487346
|
{"actor":{"display_login":"chiefpansancolt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/comments/286641209","pull_request_review_id":240821612,"id":286641209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjY0MTIwOQ==","diff_hunk":"@@ -3352,16 +3347,7 @@ let BattleMovedex = {\n \t\tflags: {},\n \t\tterrain: 'nightmarefield',","path":"data/mods/ssb/moves.js","position":null,"original_position":22,"commit_id":"fca25f65cf82389e1090c690362f6074187c1310","original_commit_id":"6765c87572ed93056416ccc4bc60cf852a432211","user":{"login":"Torracat","id":49970341,"node_id":"MDQ6VXNlcjQ5OTcwMzQx","avatar_url":"https://avatars2.githubusercontent.com/u/49970341?v=4","gravatar_id":"","url":"https://api.github.com/users/Torracat","html_url":"https://github.com/Torracat","followers_url":"https://api.github.com/users/Torracat/followers","following_url":"https://api.github.com/users/Torracat/following{/other_user}","gists_url":"https://api.github.com/users/Torracat/gists{/gist_id}","starred_url":"https://api.github.com/users/Torracat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Torracat/subscriptions","organizations_url":"https://api.github.com/users/Torracat/orgs","repos_url":"https://api.github.com/users/Torracat/repos","events_url":"https://api.github.com/users/Torracat/events{/privacy}","received_events_url":"https://api.github.com/users/Torracat/received_events","type":"User","site_admin":false},"body":"Make sure its properly tabbed ofc","created_at":"2019-05-22T19:05:41Z","updated_at":"2019-05-22T19:05:41Z","html_url":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147#discussion_r286641209","pull_request_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/comments/286641209"},"html":{"href":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147#discussion_r286641209"},"pull_request":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147"}},"in_reply_to_id":286596683},"pull_request":{"url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147","id":281005775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxMDA1Nzc1","html_url":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147","diff_url":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147.diff","patch_url":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147.patch","issue_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/147","number":147,"state":"open","locked":false,"title":"Teclis","user":{"login":"tmagicturtle","id":24866009,"node_id":"MDQ6VXNlcjI0ODY2MDA5","avatar_url":"https://avatars1.githubusercontent.com/u/24866009?v=4","gravatar_id":"","url":"https://api.github.com/users/tmagicturtle","html_url":"https://github.com/tmagicturtle","followers_url":"https://api.github.com/users/tmagicturtle/followers","following_url":"https://api.github.com/users/tmagicturtle/following{/other_user}","gists_url":"https://api.github.com/users/tmagicturtle/gists{/gist_id}","starred_url":"https://api.github.com/users/tmagicturtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmagicturtle/subscriptions","organizations_url":"https://api.github.com/users/tmagicturtle/orgs","repos_url":"https://api.github.com/users/tmagicturtle/repos","events_url":"https://api.github.com/users/tmagicturtle/events{/privacy}","received_events_url":"https://api.github.com/users/tmagicturtle/received_events","type":"User","site_admin":false},"body":"I'm not entirely sure what [Rewind] in his thread title meant. If it _didn't_ mean that he didn't want to use it anymore, then this pull request should be good. I updated his Pokemon to Darkrai, added the Z-Crystal, Z-Move, and terrain effect.","created_at":"2019-05-22T01:53:21Z","updated_at":"2019-05-22T19:05:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c80b376fa7b894c2f932d392eba1e4e570e9ae7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147/commits","review_comments_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147/comments","review_comment_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/147/comments","statuses_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/statuses/fca25f65cf82389e1090c690362f6074187c1310","head":{"label":"tmagicturtle:teclis1","ref":"teclis1","sha":"fca25f65cf82389e1090c690362f6074187c1310","user":{"login":"tmagicturtle","id":24866009,"node_id":"MDQ6VXNlcjI0ODY2MDA5","avatar_url":"https://avatars1.githubusercontent.com/u/24866009?v=4","gravatar_id":"","url":"https://api.github.com/users/tmagicturtle","html_url":"https://github.com/tmagicturtle","followers_url":"https://api.github.com/users/tmagicturtle/followers","following_url":"https://api.github.com/users/tmagicturtle/following{/other_user}","gists_url":"https://api.github.com/users/tmagicturtle/gists{/gist_id}","starred_url":"https://api.github.com/users/tmagicturtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmagicturtle/subscriptions","organizations_url":"https://api.github.com/users/tmagicturtle/orgs","repos_url":"https://api.github.com/users/tmagicturtle/repos","events_url":"https://api.github.com/users/tmagicturtle/events{/privacy}","received_events_url":"https://api.github.com/users/tmagicturtle/received_events","type":"User","site_admin":false},"repo":{"id":187910953,"node_id":"MDEwOlJlcG9zaXRvcnkxODc5MTA5NTM=","name":"Pokemon-Showdown","full_name":"tmagicturtle/Pokemon-Showdown","private":false,"owner":{"login":"tmagicturtle","id":24866009,"node_id":"MDQ6VXNlcjI0ODY2MDA5","avatar_url":"https://avatars1.githubusercontent.com/u/24866009?v=4","gravatar_id":"","url":"https://api.github.com/users/tmagicturtle","html_url":"https://github.com/tmagicturtle","followers_url":"https://api.github.com/users/tmagicturtle/followers","following_url":"https://api.github.com/users/tmagicturtle/following{/other_user}","gists_url":"https://api.github.com/users/tmagicturtle/gists{/gist_id}","starred_url":"https://api.github.com/users/tmagicturtle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmagicturtle/subscriptions","organizations_url":"https://api.github.com/users/tmagicturtle/orgs","repos_url":"https://api.github.com/users/tmagicturtle/repos","events_url":"https://api.github.com/users/tmagicturtle/events{/privacy}","received_events_url":"https://api.github.com/users/tmagicturtle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tmagicturtle/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown","forks_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/tmagicturtle/Pokemon-Showdown/deployments","created_at":"2019-05-21T20:44:50Z","updated_at":"2019-05-21T20:44:55Z","pushed_at":"2019-05-22T18:49:46Z","git_url":"git://github.com/tmagicturtle/Pokemon-Showdown.git","ssh_url":"git@github.com:tmagicturtle/Pokemon-Showdown.git","clone_url":"https://github.com/tmagicturtle/Pokemon-Showdown.git","svn_url":"https://github.com/tmagicturtle/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":78506,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HoeenCoder:master","ref":"master","sha":"01804f988e5eed2f1256d487eb0ad883d93bb4f8","user":{"login":"HoeenCoder","id":11671268,"node_id":"MDQ6VXNlcjExNjcxMjY4","avatar_url":"https://avatars2.githubusercontent.com/u/11671268?v=4","gravatar_id":"","url":"https://api.github.com/users/HoeenCoder","html_url":"https://github.com/HoeenCoder","followers_url":"https://api.github.com/users/HoeenCoder/followers","following_url":"https://api.github.com/users/HoeenCoder/following{/other_user}","gists_url":"https://api.github.com/users/HoeenCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/HoeenCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoeenCoder/subscriptions","organizations_url":"https://api.github.com/users/HoeenCoder/orgs","repos_url":"https://api.github.com/users/HoeenCoder/repos","events_url":"https://api.github.com/users/HoeenCoder/events{/privacy}","received_events_url":"https://api.github.com/users/HoeenCoder/received_events","type":"User","site_admin":false},"repo":{"id":87460200,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQ2MDIwMA==","name":"Pokemon-Showdown","full_name":"HoeenCoder/Pokemon-Showdown","private":false,"owner":{"login":"HoeenCoder","id":11671268,"node_id":"MDQ6VXNlcjExNjcxMjY4","avatar_url":"https://avatars2.githubusercontent.com/u/11671268?v=4","gravatar_id":"","url":"https://api.github.com/users/HoeenCoder","html_url":"https://github.com/HoeenCoder","followers_url":"https://api.github.com/users/HoeenCoder/followers","following_url":"https://api.github.com/users/HoeenCoder/following{/other_user}","gists_url":"https://api.github.com/users/HoeenCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/HoeenCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HoeenCoder/subscriptions","organizations_url":"https://api.github.com/users/HoeenCoder/orgs","repos_url":"https://api.github.com/users/HoeenCoder/repos","events_url":"https://api.github.com/users/HoeenCoder/events{/privacy}","received_events_url":"https://api.github.com/users/HoeenCoder/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HoeenCoder/Pokemon-Showdown","description":"Pokémon battle simulator.","fork":true,"url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown","forks_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/forks","keys_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/teams","hooks_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/hooks","issue_events_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/events{/number}","events_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/events","assignees_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/assignees{/user}","branches_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/branches{/branch}","tags_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/tags","blobs_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/statuses/{sha}","languages_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/languages","stargazers_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/stargazers","contributors_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/contributors","subscribers_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/subscribers","subscription_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/subscription","commits_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/contents/{+path}","compare_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/merges","archive_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/downloads","issues_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues{/number}","pulls_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls{/number}","milestones_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/milestones{/number}","notifications_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/labels{/name}","releases_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/releases{/id}","deployments_url":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/deployments","created_at":"2017-04-06T18:10:57Z","updated_at":"2019-05-16T13:11:42Z","pushed_at":"2019-05-22T18:49:46Z","git_url":"git://github.com/HoeenCoder/Pokemon-Showdown.git","ssh_url":"git@github.com:HoeenCoder/Pokemon-Showdown.git","clone_url":"https://github.com/HoeenCoder/Pokemon-Showdown.git","svn_url":"https://github.com/HoeenCoder/Pokemon-Showdown","homepage":"http://pokemonshowdown.com","size":78479,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147"},"html":{"href":"https://github.com/HoeenCoder/Pokemon-Showdown/pull/147"},"issue":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/147"},"comments":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/HoeenCoder/Pokemon-Showdown/statuses/fca25f65cf82389e1090c690362f6074187c1310"}},"author_association":"NONE"}}
|
{
"id": 87460200,
"name": "HoeenCoder/Pokemon-Showdown",
"url": "https://api.github.com/repos/HoeenCoder/Pokemon-Showdown"
}
|
{
"id": 49970341,
"login": "Torracat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49970341?",
"url": "https://api.github.com/users/Torracat"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-05-22T19:05:41 |
9678478354
|
{"actor":{"display_login":"Torracat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/comments/253262903","pull_request_review_id":199344793,"id":253262903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzI2MjkwMw==","diff_hunk":"@@ -3,7 +3,11 @@ class UsersController < ApplicationController\n def index\n end\n \n+<<<<<<< HEAD\n+ def login\n+=======\n def new\n+>>>>>>> nagomuohta/master","path":"app/controllers/users_controller.rb","position":8,"original_position":8,"commit_id":"c61408ce48e8ad86dc158b642761f47599bd2d15","original_commit_id":"c61408ce48e8ad86dc158b642761f47599bd2d15","user":{"login":"kuroko918","id":16913756,"node_id":"MDQ6VXNlcjE2OTEzNzU2","avatar_url":"https://avatars3.githubusercontent.com/u/16913756?v=4","gravatar_id":"","url":"https://api.github.com/users/kuroko918","html_url":"https://github.com/kuroko918","followers_url":"https://api.github.com/users/kuroko918/followers","following_url":"https://api.github.com/users/kuroko918/following{/other_user}","gists_url":"https://api.github.com/users/kuroko918/gists{/gist_id}","starred_url":"https://api.github.com/users/kuroko918/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuroko918/subscriptions","organizations_url":"https://api.github.com/users/kuroko918/orgs","repos_url":"https://api.github.com/users/kuroko918/repos","events_url":"https://api.github.com/users/kuroko918/events{/privacy}","received_events_url":"https://api.github.com/users/kuroko918/received_events","type":"User","site_admin":false},"body":"conflictが起きています！","created_at":"2019-02-02T11:31:39Z","updated_at":"2019-02-02T11:32:20Z","html_url":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16#discussion_r253262903","pull_request_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/comments/253262903"},"html":{"href":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16#discussion_r253262903"},"pull_request":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16","id":249805021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5ODA1MDIx","html_url":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16","diff_url":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16.diff","patch_url":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16.patch","issue_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/16","number":16,"state":"open","locked":false,"title":"Add login view","user":{"login":"tomoyahiraki","id":46123872,"node_id":"MDQ6VXNlcjQ2MTIzODcy","avatar_url":"https://avatars0.githubusercontent.com/u/46123872?v=4","gravatar_id":"","url":"https://api.github.com/users/tomoyahiraki","html_url":"https://github.com/tomoyahiraki","followers_url":"https://api.github.com/users/tomoyahiraki/followers","following_url":"https://api.github.com/users/tomoyahiraki/following{/other_user}","gists_url":"https://api.github.com/users/tomoyahiraki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoyahiraki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoyahiraki/subscriptions","organizations_url":"https://api.github.com/users/tomoyahiraki/orgs","repos_url":"https://api.github.com/users/tomoyahiraki/repos","events_url":"https://api.github.com/users/tomoyahiraki/events{/privacy}","received_events_url":"https://api.github.com/users/tomoyahiraki/received_events","type":"User","site_admin":false},"body":"# What\nメルカリのログインページのビュー実装\n\n# Why\nログインするために必要なビューのため","created_at":"2019-02-02T10:20:06Z","updated_at":"2019-02-02T11:32:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f168d2f86ddbbe50c0744b413a048169d79997","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16/commits","review_comments_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16/comments","review_comment_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/16/comments","statuses_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/statuses/c61408ce48e8ad86dc158b642761f47599bd2d15","head":{"label":"tomoyahiraki:add-login-view","ref":"add-login-view","sha":"c61408ce48e8ad86dc158b642761f47599bd2d15","user":{"login":"tomoyahiraki","id":46123872,"node_id":"MDQ6VXNlcjQ2MTIzODcy","avatar_url":"https://avatars0.githubusercontent.com/u/46123872?v=4","gravatar_id":"","url":"https://api.github.com/users/tomoyahiraki","html_url":"https://github.com/tomoyahiraki","followers_url":"https://api.github.com/users/tomoyahiraki/followers","following_url":"https://api.github.com/users/tomoyahiraki/following{/other_user}","gists_url":"https://api.github.com/users/tomoyahiraki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoyahiraki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoyahiraki/subscriptions","organizations_url":"https://api.github.com/users/tomoyahiraki/orgs","repos_url":"https://api.github.com/users/tomoyahiraki/repos","events_url":"https://api.github.com/users/tomoyahiraki/events{/privacy}","received_events_url":"https://api.github.com/users/tomoyahiraki/received_events","type":"User","site_admin":false},"repo":{"id":168692079,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg2OTIwNzk=","name":"freemarket_sample_43d","full_name":"tomoyahiraki/freemarket_sample_43d","private":false,"owner":{"login":"tomoyahiraki","id":46123872,"node_id":"MDQ6VXNlcjQ2MTIzODcy","avatar_url":"https://avatars0.githubusercontent.com/u/46123872?v=4","gravatar_id":"","url":"https://api.github.com/users/tomoyahiraki","html_url":"https://github.com/tomoyahiraki","followers_url":"https://api.github.com/users/tomoyahiraki/followers","following_url":"https://api.github.com/users/tomoyahiraki/following{/other_user}","gists_url":"https://api.github.com/users/tomoyahiraki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomoyahiraki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomoyahiraki/subscriptions","organizations_url":"https://api.github.com/users/tomoyahiraki/orgs","repos_url":"https://api.github.com/users/tomoyahiraki/repos","events_url":"https://api.github.com/users/tomoyahiraki/events{/privacy}","received_events_url":"https://api.github.com/users/tomoyahiraki/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tomoyahiraki/freemarket_sample_43d","description":null,"fork":true,"url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d","forks_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/forks","keys_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/teams","hooks_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/hooks","issue_events_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/issues/events{/number}","events_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/events","assignees_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/assignees{/user}","branches_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/branches{/branch}","tags_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/tags","blobs_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/statuses/{sha}","languages_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/languages","stargazers_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/stargazers","contributors_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/contributors","subscribers_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/subscribers","subscription_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/subscription","commits_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/contents/{+path}","compare_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/merges","archive_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/downloads","issues_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/issues{/number}","pulls_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/pulls{/number}","milestones_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/milestones{/number}","notifications_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/labels{/name}","releases_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/releases{/id}","deployments_url":"https://api.github.com/repos/tomoyahiraki/freemarket_sample_43d/deployments","created_at":"2019-02-01T12:08:48Z","updated_at":"2019-02-02T06:13:00Z","pushed_at":"2019-02-02T10:50:25Z","git_url":"git://github.com/tomoyahiraki/freemarket_sample_43d.git","ssh_url":"git@github.com:tomoyahiraki/freemarket_sample_43d.git","clone_url":"https://github.com/tomoyahiraki/freemarket_sample_43d.git","svn_url":"https://github.com/tomoyahiraki/freemarket_sample_43d","homepage":null,"size":5741,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nagomuohta:master","ref":"master","sha":"ea54f83544ca585cb9d51ab9d0cf8fb5e9bf59fb","user":{"login":"nagomuohta","id":46256865,"node_id":"MDQ6VXNlcjQ2MjU2ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/46256865?v=4","gravatar_id":"","url":"https://api.github.com/users/nagomuohta","html_url":"https://github.com/nagomuohta","followers_url":"https://api.github.com/users/nagomuohta/followers","following_url":"https://api.github.com/users/nagomuohta/following{/other_user}","gists_url":"https://api.github.com/users/nagomuohta/gists{/gist_id}","starred_url":"https://api.github.com/users/nagomuohta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagomuohta/subscriptions","organizations_url":"https://api.github.com/users/nagomuohta/orgs","repos_url":"https://api.github.com/users/nagomuohta/repos","events_url":"https://api.github.com/users/nagomuohta/events{/privacy}","received_events_url":"https://api.github.com/users/nagomuohta/received_events","type":"User","site_admin":false},"repo":{"id":167775730,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc3NzU3MzA=","name":"freemarket_sample_43d","full_name":"nagomuohta/freemarket_sample_43d","private":false,"owner":{"login":"nagomuohta","id":46256865,"node_id":"MDQ6VXNlcjQ2MjU2ODY1","avatar_url":"https://avatars3.githubusercontent.com/u/46256865?v=4","gravatar_id":"","url":"https://api.github.com/users/nagomuohta","html_url":"https://github.com/nagomuohta","followers_url":"https://api.github.com/users/nagomuohta/followers","following_url":"https://api.github.com/users/nagomuohta/following{/other_user}","gists_url":"https://api.github.com/users/nagomuohta/gists{/gist_id}","starred_url":"https://api.github.com/users/nagomuohta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagomuohta/subscriptions","organizations_url":"https://api.github.com/users/nagomuohta/orgs","repos_url":"https://api.github.com/users/nagomuohta/repos","events_url":"https://api.github.com/users/nagomuohta/events{/privacy}","received_events_url":"https://api.github.com/users/nagomuohta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nagomuohta/freemarket_sample_43d","description":null,"fork":false,"url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d","forks_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/forks","keys_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/teams","hooks_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/hooks","issue_events_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/events{/number}","events_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/events","assignees_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/assignees{/user}","branches_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/branches{/branch}","tags_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/tags","blobs_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/git/refs{/sha}","trees_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/statuses/{sha}","languages_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/languages","stargazers_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/stargazers","contributors_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/contributors","subscribers_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/subscribers","subscription_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/subscription","commits_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/commits{/sha}","git_commits_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/git/commits{/sha}","comments_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/comments{/number}","issue_comment_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/comments{/number}","contents_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/contents/{+path}","compare_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/merges","archive_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/downloads","issues_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues{/number}","pulls_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls{/number}","milestones_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/milestones{/number}","notifications_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/labels{/name}","releases_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/releases{/id}","deployments_url":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/deployments","created_at":"2019-01-27T05:54:48Z","updated_at":"2019-02-02T10:51:03Z","pushed_at":"2019-02-02T10:51:01Z","git_url":"git://github.com/nagomuohta/freemarket_sample_43d.git","ssh_url":"git@github.com:nagomuohta/freemarket_sample_43d.git","clone_url":"https://github.com/nagomuohta/freemarket_sample_43d.git","svn_url":"https://github.com/nagomuohta/freemarket_sample_43d","homepage":null,"size":5744,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":3,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16"},"html":{"href":"https://github.com/nagomuohta/freemarket_sample_43d/pull/16"},"issue":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/16"},"comments":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/nagomuohta/freemarket_sample_43d/statuses/c61408ce48e8ad86dc158b642761f47599bd2d15"}},"author_association":"NONE"}}
|
{
"id": 167775730,
"name": "nagomuohta/freemarket_sample_43d",
"url": "https://api.github.com/repos/nagomuohta/freemarket_sample_43d"
}
|
{
"id": 16913756,
"login": "kuroko918",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16913756?",
"url": "https://api.github.com/users/kuroko918"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-02-02T11:31:39 |
8997370692
|
{"actor":{"display_login":"kuroko918"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/comments/347088057","pull_request_review_id":317966431,"id":347088057,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzA4ODA1Nw==","diff_hunk":"@@ -0,0 +1,91 @@\n+import '../sass/styles.scss';\n+\n+import config from './config';\n+\n+window.onload = function() {\n+ //draw_4();\n+\n+ let canvas = document.getElementById(\"canvas\"),\n+ ctx = canvas.getContext(\"2d\");\n+\n+ ctx.fillStyle = \"#e6e6e6\";\n+ ctx.fillRect(0, 0, 512, 512);\n+\n+ let s_4x4 = document.querySelector(\".small\");\n+ s_4x4.addEventListener(\"click\", draw_4);\n+ let s_32x32 = document.querySelector(\".medium\");\n+ s_32x32.addEventListener(\"click\", draw_32)\n+ let s_512x512 = document.querySelector(\".large\");\n+ s_512x512.addEventListener(\"click\", draw_512);\n+}\n+\n+//4x4\n+function draw_4() { \n+ let A = [[\"00BCD4\", \"FFEB3B\",\"FFEB3B\",\"00BCD4\"],\n+ [\"FFEB3B\", \"FFC107\",\"FFC107\",\"FFEB3B\"],\n+ [\"FFEB3B\", \"FFC107\",\"FFC107\",\"FFEB3B\"],\n+ [\"00BCD4\", \"FFEB3B\",\"FFEB3B\",\"00BCD4\"]];\n+\n+ let canvas = document.getElementById(\"canvas\"),\n+ ctx = canvas.getContext(\"2d\"),\n+ width = A[0].length,\n+ height = A.length,\n+ scale = 128;\n+\n+ canvas.width = width * scale; \n+ canvas.height = height * scale; \n+\n+ for(let i = 0; i < A.length; i++){","path":"src/javascript/index.js","position":38,"original_position":38,"commit_id":"bf5cdeed0e7d113836361ce6602c7b7525f663c0","original_commit_id":"bf5cdeed0e7d113836361ce6602c7b7525f663c0","user":{"login":"vpanteleev","id":3331329,"node_id":"MDQ6VXNlcjMzMzEzMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/3331329?v=4","gravatar_id":"","url":"https://api.github.com/users/vpanteleev","html_url":"https://github.com/vpanteleev","followers_url":"https://api.github.com/users/vpanteleev/followers","following_url":"https://api.github.com/users/vpanteleev/following{/other_user}","gists_url":"https://api.github.com/users/vpanteleev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpanteleev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpanteleev/subscriptions","organizations_url":"https://api.github.com/users/vpanteleev/orgs","repos_url":"https://api.github.com/users/vpanteleev/repos","events_url":"https://api.github.com/users/vpanteleev/events{/privacy}","received_events_url":"https://api.github.com/users/vpanteleev/received_events","type":"User","site_admin":false},"body":"Why do we need such loop? Maybe we can initialize this array with # originally?","created_at":"2019-11-16T11:39:14Z","updated_at":"2019-11-16T11:44:12Z","html_url":"https://github.com/a-popova/codejam-canvas/pull/1#discussion_r347088057","pull_request_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/comments/347088057"},"html":{"href":"https://github.com/a-popova/codejam-canvas/pull/1#discussion_r347088057"},"pull_request":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1","id":332797979,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNzk3OTc5","html_url":"https://github.com/a-popova/codejam-canvas/pull/1","diff_url":"https://github.com/a-popova/codejam-canvas/pull/1.diff","patch_url":"https://github.com/a-popova/codejam-canvas/pull/1.patch","issue_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/1","number":1,"state":"open","locked":false,"title":"Add canvas","user":{"login":"a-popova","id":48322888,"node_id":"MDQ6VXNlcjQ4MzIyODg4","avatar_url":"https://avatars1.githubusercontent.com/u/48322888?v=4","gravatar_id":"","url":"https://api.github.com/users/a-popova","html_url":"https://github.com/a-popova","followers_url":"https://api.github.com/users/a-popova/followers","following_url":"https://api.github.com/users/a-popova/following{/other_user}","gists_url":"https://api.github.com/users/a-popova/gists{/gist_id}","starred_url":"https://api.github.com/users/a-popova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-popova/subscriptions","organizations_url":"https://api.github.com/users/a-popova/orgs","repos_url":"https://api.github.com/users/a-popova/repos","events_url":"https://api.github.com/users/a-popova/events{/privacy}","received_events_url":"https://api.github.com/users/a-popova/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-26T20:15:59Z","updated_at":"2019-11-16T11:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd05debcf830f78a7d281bb0abd162e227c79830","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1/commits","review_comments_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1/comments","review_comment_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/1/comments","statuses_url":"https://api.github.com/repos/a-popova/codejam-canvas/statuses/bf5cdeed0e7d113836361ce6602c7b7525f663c0","head":{"label":"a-popova:codejam-canvas","ref":"codejam-canvas","sha":"bf5cdeed0e7d113836361ce6602c7b7525f663c0","user":{"login":"a-popova","id":48322888,"node_id":"MDQ6VXNlcjQ4MzIyODg4","avatar_url":"https://avatars1.githubusercontent.com/u/48322888?v=4","gravatar_id":"","url":"https://api.github.com/users/a-popova","html_url":"https://github.com/a-popova","followers_url":"https://api.github.com/users/a-popova/followers","following_url":"https://api.github.com/users/a-popova/following{/other_user}","gists_url":"https://api.github.com/users/a-popova/gists{/gist_id}","starred_url":"https://api.github.com/users/a-popova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-popova/subscriptions","organizations_url":"https://api.github.com/users/a-popova/orgs","repos_url":"https://api.github.com/users/a-popova/repos","events_url":"https://api.github.com/users/a-popova/events{/privacy}","received_events_url":"https://api.github.com/users/a-popova/received_events","type":"User","site_admin":false},"repo":{"id":217352707,"node_id":"MDEwOlJlcG9zaXRvcnkyMTczNTI3MDc=","name":"codejam-canvas","full_name":"a-popova/codejam-canvas","private":false,"owner":{"login":"a-popova","id":48322888,"node_id":"MDQ6VXNlcjQ4MzIyODg4","avatar_url":"https://avatars1.githubusercontent.com/u/48322888?v=4","gravatar_id":"","url":"https://api.github.com/users/a-popova","html_url":"https://github.com/a-popova","followers_url":"https://api.github.com/users/a-popova/followers","following_url":"https://api.github.com/users/a-popova/following{/other_user}","gists_url":"https://api.github.com/users/a-popova/gists{/gist_id}","starred_url":"https://api.github.com/users/a-popova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-popova/subscriptions","organizations_url":"https://api.github.com/users/a-popova/orgs","repos_url":"https://api.github.com/users/a-popova/repos","events_url":"https://api.github.com/users/a-popova/events{/privacy}","received_events_url":"https://api.github.com/users/a-popova/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a-popova/codejam-canvas","description":null,"fork":false,"url":"https://api.github.com/repos/a-popova/codejam-canvas","forks_url":"https://api.github.com/repos/a-popova/codejam-canvas/forks","keys_url":"https://api.github.com/repos/a-popova/codejam-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-popova/codejam-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-popova/codejam-canvas/teams","hooks_url":"https://api.github.com/repos/a-popova/codejam-canvas/hooks","issue_events_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/a-popova/codejam-canvas/events","assignees_url":"https://api.github.com/repos/a-popova/codejam-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/a-popova/codejam-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/a-popova/codejam-canvas/tags","blobs_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-popova/codejam-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/a-popova/codejam-canvas/languages","stargazers_url":"https://api.github.com/repos/a-popova/codejam-canvas/stargazers","contributors_url":"https://api.github.com/repos/a-popova/codejam-canvas/contributors","subscribers_url":"https://api.github.com/repos/a-popova/codejam-canvas/subscribers","subscription_url":"https://api.github.com/repos/a-popova/codejam-canvas/subscription","commits_url":"https://api.github.com/repos/a-popova/codejam-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-popova/codejam-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-popova/codejam-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/a-popova/codejam-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-popova/codejam-canvas/merges","archive_url":"https://api.github.com/repos/a-popova/codejam-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-popova/codejam-canvas/downloads","issues_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/a-popova/codejam-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/a-popova/codejam-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-popova/codejam-canvas/labels{/name}","releases_url":"https://api.github.com/repos/a-popova/codejam-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/a-popova/codejam-canvas/deployments","created_at":"2019-10-24T17:13:23Z","updated_at":"2019-10-26T20:14:52Z","pushed_at":"2019-10-26T20:16:00Z","git_url":"git://github.com/a-popova/codejam-canvas.git","ssh_url":"git@github.com:a-popova/codejam-canvas.git","clone_url":"https://github.com/a-popova/codejam-canvas.git","svn_url":"https://github.com/a-popova/codejam-canvas","homepage":null,"size":395,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"a-popova:master","ref":"master","sha":"48bfe9e46d454839fee0369fbe7f39be2d48eab7","user":{"login":"a-popova","id":48322888,"node_id":"MDQ6VXNlcjQ4MzIyODg4","avatar_url":"https://avatars1.githubusercontent.com/u/48322888?v=4","gravatar_id":"","url":"https://api.github.com/users/a-popova","html_url":"https://github.com/a-popova","followers_url":"https://api.github.com/users/a-popova/followers","following_url":"https://api.github.com/users/a-popova/following{/other_user}","gists_url":"https://api.github.com/users/a-popova/gists{/gist_id}","starred_url":"https://api.github.com/users/a-popova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-popova/subscriptions","organizations_url":"https://api.github.com/users/a-popova/orgs","repos_url":"https://api.github.com/users/a-popova/repos","events_url":"https://api.github.com/users/a-popova/events{/privacy}","received_events_url":"https://api.github.com/users/a-popova/received_events","type":"User","site_admin":false},"repo":{"id":217352707,"node_id":"MDEwOlJlcG9zaXRvcnkyMTczNTI3MDc=","name":"codejam-canvas","full_name":"a-popova/codejam-canvas","private":false,"owner":{"login":"a-popova","id":48322888,"node_id":"MDQ6VXNlcjQ4MzIyODg4","avatar_url":"https://avatars1.githubusercontent.com/u/48322888?v=4","gravatar_id":"","url":"https://api.github.com/users/a-popova","html_url":"https://github.com/a-popova","followers_url":"https://api.github.com/users/a-popova/followers","following_url":"https://api.github.com/users/a-popova/following{/other_user}","gists_url":"https://api.github.com/users/a-popova/gists{/gist_id}","starred_url":"https://api.github.com/users/a-popova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-popova/subscriptions","organizations_url":"https://api.github.com/users/a-popova/orgs","repos_url":"https://api.github.com/users/a-popova/repos","events_url":"https://api.github.com/users/a-popova/events{/privacy}","received_events_url":"https://api.github.com/users/a-popova/received_events","type":"User","site_admin":false},"html_url":"https://github.com/a-popova/codejam-canvas","description":null,"fork":false,"url":"https://api.github.com/repos/a-popova/codejam-canvas","forks_url":"https://api.github.com/repos/a-popova/codejam-canvas/forks","keys_url":"https://api.github.com/repos/a-popova/codejam-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-popova/codejam-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-popova/codejam-canvas/teams","hooks_url":"https://api.github.com/repos/a-popova/codejam-canvas/hooks","issue_events_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/a-popova/codejam-canvas/events","assignees_url":"https://api.github.com/repos/a-popova/codejam-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/a-popova/codejam-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/a-popova/codejam-canvas/tags","blobs_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-popova/codejam-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/a-popova/codejam-canvas/languages","stargazers_url":"https://api.github.com/repos/a-popova/codejam-canvas/stargazers","contributors_url":"https://api.github.com/repos/a-popova/codejam-canvas/contributors","subscribers_url":"https://api.github.com/repos/a-popova/codejam-canvas/subscribers","subscription_url":"https://api.github.com/repos/a-popova/codejam-canvas/subscription","commits_url":"https://api.github.com/repos/a-popova/codejam-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-popova/codejam-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-popova/codejam-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-popova/codejam-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/a-popova/codejam-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-popova/codejam-canvas/merges","archive_url":"https://api.github.com/repos/a-popova/codejam-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-popova/codejam-canvas/downloads","issues_url":"https://api.github.com/repos/a-popova/codejam-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/a-popova/codejam-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/a-popova/codejam-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/a-popova/codejam-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-popova/codejam-canvas/labels{/name}","releases_url":"https://api.github.com/repos/a-popova/codejam-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/a-popova/codejam-canvas/deployments","created_at":"2019-10-24T17:13:23Z","updated_at":"2019-10-26T20:14:52Z","pushed_at":"2019-10-26T20:16:00Z","git_url":"git://github.com/a-popova/codejam-canvas.git","ssh_url":"git@github.com:a-popova/codejam-canvas.git","clone_url":"https://github.com/a-popova/codejam-canvas.git","svn_url":"https://github.com/a-popova/codejam-canvas","homepage":null,"size":395,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1"},"html":{"href":"https://github.com/a-popova/codejam-canvas/pull/1"},"issue":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/issues/1"},"comments":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/a-popova/codejam-canvas/statuses/bf5cdeed0e7d113836361ce6602c7b7525f663c0"}},"author_association":"OWNER"}}
|
{
"id": 217352707,
"name": "a-popova/codejam-canvas",
"url": "https://api.github.com/repos/a-popova/codejam-canvas"
}
|
{
"id": 3331329,
"login": "vpanteleev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3331329?",
"url": "https://api.github.com/users/vpanteleev"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-16T11:39:14 |
10877620533
|
{"actor":{"display_login":"vpanteleev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/comments/293777908","pull_request_review_id":249862340,"id":293777908,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Mzc3NzkwOA==","diff_hunk":"@@ -30,34 +35,56 @@\n \"\"\"Set up the Sonoff LAN Mode Switch platform.\"\"\"\n host = config.get(CONF_HOST)\n name = config.get(CONF_NAME)\n+ icon = config.get(CONF_ICON)\n+ device_id = config.get(CONF_DEVICE_ID)\n+ api_key = config.get(CONF_API_KEY)\n \n- async_add_entities([HassSonoffSwitch(hass, host, name)], True)\n+ # todo: remove once we have packaged correctly\n+ # Add path so we can load dependant component (pysonofflan) from custom_components directory\n+ # this support side by side execution \n+ import sys\n+ path = hass.config.path('custom_components/sonoff_lan_mode_r3')\n+ if path not in sys.path:\n+ sys.path.insert(0, path)\n \n+ async_add_entities([HassSonoffSwitchR3(hass, host, name, icon, device_id, api_key)], True)\n \n-class HassSonoffSwitch(SwitchDevice):\n- \"\"\"Home Assistant representation of a Sonoff LAN Mode device.\"\"\"\n \n- def __init__(self, hass, host, name):\n- from pysonofflan import SonoffSwitch\n+class HassSonoffSwitchR3(SwitchDevice):\n+ \"\"\"Home Assistant representation of a Sonoff LAN Mode device.\"\"\"\n \n- _LOGGER.setLevel(logging.DEBUG)\n+ def __init__(self, hass, host, name, icon, device_id, api_key):\n+ \n+ from pysonofflan3 import SonoffSwitch","path":"switch.py","position":56,"original_position":56,"commit_id":"bc6f8f1ca1c567b1c9d938770495756665081d3c","original_commit_id":"0280eac6313a498f311097afafc5965330b08d1e","user":{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false},"body":"I've made some improvements, but please feel free to refine","created_at":"2019-06-14T12:01:45Z","updated_at":"2019-06-14T12:01:45Z","html_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71#discussion_r293777908","pull_request_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/comments/293777908"},"html":{"href":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71#discussion_r293777908"},"pull_request":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71"}},"in_reply_to_id":293753350},"pull_request":{"url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71","id":286985860,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2OTg1ODYw","html_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71","diff_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71.diff","patch_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71.patch","issue_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/71","number":71,"state":"open","locked":false,"title":"V3 changes","user":{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false},"body":"This PR has 2 commits in it. The first is to cover V3 firmware assuming that pysonofflan is upgraded to V3 on PyPi. The second supports deployment of this in a local directory (outside of PyPi).\r\n\r\nNote it also contains previous PRs (on icons and removal of unecessary update calls) that have yet to be accepted into the main branch. https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/65","created_at":"2019-06-11T08:52:50Z","updated_at":"2019-06-14T12:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc1cbaa273d46504cb449a0816c76dca7a067b55","assignee":{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71/commits","review_comments_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71/comments","review_comment_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/71/comments","statuses_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/statuses/bc6f8f1ca1c567b1c9d938770495756665081d3c","head":{"label":"mattsaxon:master","ref":"master","sha":"bc6f8f1ca1c567b1c9d938770495756665081d3c","user":{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false},"repo":{"id":191329586,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEzMjk1ODY=","name":"sonoff-lan-mode-homeassistant","full_name":"mattsaxon/sonoff-lan-mode-homeassistant","private":false,"owner":{"login":"mattsaxon","id":11351127,"node_id":"MDQ6VXNlcjExMzUxMTI3","avatar_url":"https://avatars2.githubusercontent.com/u/11351127?v=4","gravatar_id":"","url":"https://api.github.com/users/mattsaxon","html_url":"https://github.com/mattsaxon","followers_url":"https://api.github.com/users/mattsaxon/followers","following_url":"https://api.github.com/users/mattsaxon/following{/other_user}","gists_url":"https://api.github.com/users/mattsaxon/gists{/gist_id}","starred_url":"https://api.github.com/users/mattsaxon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattsaxon/subscriptions","organizations_url":"https://api.github.com/users/mattsaxon/orgs","repos_url":"https://api.github.com/users/mattsaxon/repos","events_url":"https://api.github.com/users/mattsaxon/events{/privacy}","received_events_url":"https://api.github.com/users/mattsaxon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattsaxon/sonoff-lan-mode-homeassistant","description":"Home Assistant platform to control Sonoff switches running the latest Itead firmware, locally (LAN mode).","fork":true,"url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant","forks_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/forks","keys_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/teams","hooks_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/hooks","issue_events_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/issues/events{/number}","events_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/events","assignees_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/assignees{/user}","branches_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/branches{/branch}","tags_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/tags","blobs_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/statuses/{sha}","languages_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/languages","stargazers_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/stargazers","contributors_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/contributors","subscribers_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/subscribers","subscription_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/subscription","commits_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/contents/{+path}","compare_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/merges","archive_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/downloads","issues_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/issues{/number}","pulls_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/pulls{/number}","milestones_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/milestones{/number}","notifications_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/labels{/name}","releases_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/releases{/id}","deployments_url":"https://api.github.com/repos/mattsaxon/sonoff-lan-mode-homeassistant/deployments","created_at":"2019-06-11T08:39:04Z","updated_at":"2019-06-14T12:00:24Z","pushed_at":"2019-06-14T12:00:22Z","git_url":"git://github.com/mattsaxon/sonoff-lan-mode-homeassistant.git","ssh_url":"git@github.com:mattsaxon/sonoff-lan-mode-homeassistant.git","clone_url":"https://github.com/mattsaxon/sonoff-lan-mode-homeassistant.git","svn_url":"https://github.com/mattsaxon/sonoff-lan-mode-homeassistant","homepage":null,"size":109,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"beveradb:master","ref":"master","sha":"08fa7a433bdcc39739bba151f61166f820a2ebdf","user":{"login":"beveradb","id":757713,"node_id":"MDQ6VXNlcjc1NzcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/757713?v=4","gravatar_id":"","url":"https://api.github.com/users/beveradb","html_url":"https://github.com/beveradb","followers_url":"https://api.github.com/users/beveradb/followers","following_url":"https://api.github.com/users/beveradb/following{/other_user}","gists_url":"https://api.github.com/users/beveradb/gists{/gist_id}","starred_url":"https://api.github.com/users/beveradb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beveradb/subscriptions","organizations_url":"https://api.github.com/users/beveradb/orgs","repos_url":"https://api.github.com/users/beveradb/repos","events_url":"https://api.github.com/users/beveradb/events{/privacy}","received_events_url":"https://api.github.com/users/beveradb/received_events","type":"User","site_admin":false},"repo":{"id":163598349,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM1OTgzNDk=","name":"sonoff-lan-mode-homeassistant","full_name":"beveradb/sonoff-lan-mode-homeassistant","private":false,"owner":{"login":"beveradb","id":757713,"node_id":"MDQ6VXNlcjc1NzcxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/757713?v=4","gravatar_id":"","url":"https://api.github.com/users/beveradb","html_url":"https://github.com/beveradb","followers_url":"https://api.github.com/users/beveradb/followers","following_url":"https://api.github.com/users/beveradb/following{/other_user}","gists_url":"https://api.github.com/users/beveradb/gists{/gist_id}","starred_url":"https://api.github.com/users/beveradb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beveradb/subscriptions","organizations_url":"https://api.github.com/users/beveradb/orgs","repos_url":"https://api.github.com/users/beveradb/repos","events_url":"https://api.github.com/users/beveradb/events{/privacy}","received_events_url":"https://api.github.com/users/beveradb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant","description":"Home Assistant platform to control Sonoff switches running the latest Itead firmware, locally (LAN mode).","fork":false,"url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant","forks_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/forks","keys_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/teams","hooks_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/hooks","issue_events_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/events{/number}","events_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/events","assignees_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/assignees{/user}","branches_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/branches{/branch}","tags_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/tags","blobs_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/statuses/{sha}","languages_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/languages","stargazers_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/stargazers","contributors_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/contributors","subscribers_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/subscribers","subscription_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/subscription","commits_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/contents/{+path}","compare_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/merges","archive_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/downloads","issues_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues{/number}","pulls_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls{/number}","milestones_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/milestones{/number}","notifications_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/labels{/name}","releases_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/releases{/id}","deployments_url":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/deployments","created_at":"2018-12-30T15:41:57Z","updated_at":"2019-06-14T10:18:01Z","pushed_at":"2019-06-14T12:00:24Z","git_url":"git://github.com/beveradb/sonoff-lan-mode-homeassistant.git","ssh_url":"git@github.com:beveradb/sonoff-lan-mode-homeassistant.git","clone_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant.git","svn_url":"https://github.com/beveradb/sonoff-lan-mode-homeassistant","homepage":null,"size":91,"stargazers_count":31,"watchers_count":31,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":10,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71"},"html":{"href":"https://github.com/beveradb/sonoff-lan-mode-homeassistant/pull/71"},"issue":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/71"},"comments":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant/statuses/bc6f8f1ca1c567b1c9d938770495756665081d3c"}},"author_association":"COLLABORATOR"}}
|
{
"id": 163598349,
"name": "beveradb/sonoff-lan-mode-homeassistant",
"url": "https://api.github.com/repos/beveradb/sonoff-lan-mode-homeassistant"
}
|
{
"id": 11351127,
"login": "mattsaxon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11351127?",
"url": "https://api.github.com/users/mattsaxon"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-06-14T12:01:45 |
9823265044
|
{"actor":{"display_login":"mattsaxon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ulysseB/telamon/pulls/comments/316707358","pull_request_review_id":278457309,"id":316707358,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjcwNzM1OA==","diff_hunk":"@@ -262,8 +260,8 @@ mod cuda_reference {\n let stride_c = (m * n) as libc::c_long;\n time_cuda(|| {\n check_cublas(cublasSgemmStridedBatched(\n- handle.0, op_b, op_a, n, m, k, &2., b, ldb, stride_b, a, lda,\n- stride_a, &3., c, n, stride_c, batch,\n+ handle.0, op_b, op_a, n, m, k, &1., b, ldb, stride_b, a, lda,\n+ stride_a, &0., c, n, stride_c, batch,\n ));","path":"telamon-cli/src/lib.rs","position":28,"original_position":28,"commit_id":"64191a1795e597966797f694d3ece46cf4fdd0c8","original_commit_id":"64191a1795e597966797f694d3ece46cf4fdd0c8","user":{"login":"Elarnon","id":146210,"node_id":"MDQ6VXNlcjE0NjIxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/146210?v=4","gravatar_id":"","url":"https://api.github.com/users/Elarnon","html_url":"https://github.com/Elarnon","followers_url":"https://api.github.com/users/Elarnon/followers","following_url":"https://api.github.com/users/Elarnon/following{/other_user}","gists_url":"https://api.github.com/users/Elarnon/gists{/gist_id}","starred_url":"https://api.github.com/users/Elarnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elarnon/subscriptions","organizations_url":"https://api.github.com/users/Elarnon/orgs","repos_url":"https://api.github.com/users/Elarnon/repos","events_url":"https://api.github.com/users/Elarnon/events{/privacy}","received_events_url":"https://api.github.com/users/Elarnon/received_events","type":"User","site_admin":false},"body":"See above","created_at":"2019-08-22T14:24:19Z","updated_at":"2019-08-22T14:24:19Z","html_url":"https://github.com/ulysseB/telamon/pull/290#discussion_r316707358","pull_request_url":"https://api.github.com/repos/ulysseB/telamon/pulls/290","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/comments/316707358"},"html":{"href":"https://github.com/ulysseB/telamon/pull/290#discussion_r316707358"},"pull_request":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/290"}},"in_reply_to_id":316696184},"pull_request":{"url":"https://api.github.com/repos/ulysseB/telamon/pulls/290","id":309465695,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NDY1Njk1","html_url":"https://github.com/ulysseB/telamon/pull/290","diff_url":"https://github.com/ulysseB/telamon/pull/290.diff","patch_url":"https://github.com/ulysseB/telamon/pull/290.patch","issue_url":"https://api.github.com/repos/ulysseB/telamon/issues/290","number":290,"state":"open","locked":false,"title":"[tlcli] Add a `benchmark` command","user":{"login":"Elarnon","id":146210,"node_id":"MDQ6VXNlcjE0NjIxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/146210?v=4","gravatar_id":"","url":"https://api.github.com/users/Elarnon","html_url":"https://github.com/Elarnon","followers_url":"https://api.github.com/users/Elarnon/followers","following_url":"https://api.github.com/users/Elarnon/following{/other_user}","gists_url":"https://api.github.com/users/Elarnon/gists{/gist_id}","starred_url":"https://api.github.com/users/Elarnon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elarnon/subscriptions","organizations_url":"https://api.github.com/users/Elarnon/orgs","repos_url":"https://api.github.com/users/Elarnon/repos","events_url":"https://api.github.com/users/Elarnon/events{/privacy}","received_events_url":"https://api.github.com/users/Elarnon/received_events","type":"User","site_admin":false},"body":"This patch adds a `benchmark` command to the telamon CLI, allowing to\r\nre-run benchmarks (both of the generated code, and the reference code)\r\nfor a given kernel and replay file after-the-fact.\r\n\r\nThis will print the same information as in the `benchmark.txt` generated\r\nduring the search, namely the average runtime of the benchmarked kernel\r\nand the reference. The bound for the fixed candidate generated is also\r\ndisplayed.\r\n\r\nA batch mode is also provided, for running the same kernel with\r\ndifferent replays. In that case, the output (to stdout) is a .csv\r\ncontaining one line per replay, with the raw measurements.","created_at":"2019-08-21T12:01:35Z","updated_at":"2019-08-22T14:24:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04d221a8c72dc8d3b3a7ed50a31857498eb5f16d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ulysseB/telamon/pulls/290/commits","review_comments_url":"https://api.github.com/repos/ulysseB/telamon/pulls/290/comments","review_comment_url":"https://api.github.com/repos/ulysseB/telamon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ulysseB/telamon/issues/290/comments","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/64191a1795e597966797f694d3ece46cf4fdd0c8","head":{"label":"ulysseB:bclement/tlbench","ref":"bclement/tlbench","sha":"64191a1795e597966797f694d3ece46cf4fdd0c8","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"repo":{"id":125530367,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1MzAzNjc=","name":"telamon","full_name":"ulysseB/telamon","private":false,"owner":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ulysseB/telamon","description":"A framework to find good combinations of optimizations for computational kernels on GPUs.","fork":false,"url":"https://api.github.com/repos/ulysseB/telamon","forks_url":"https://api.github.com/repos/ulysseB/telamon/forks","keys_url":"https://api.github.com/repos/ulysseB/telamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulysseB/telamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulysseB/telamon/teams","hooks_url":"https://api.github.com/repos/ulysseB/telamon/hooks","issue_events_url":"https://api.github.com/repos/ulysseB/telamon/issues/events{/number}","events_url":"https://api.github.com/repos/ulysseB/telamon/events","assignees_url":"https://api.github.com/repos/ulysseB/telamon/assignees{/user}","branches_url":"https://api.github.com/repos/ulysseB/telamon/branches{/branch}","tags_url":"https://api.github.com/repos/ulysseB/telamon/tags","blobs_url":"https://api.github.com/repos/ulysseB/telamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulysseB/telamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulysseB/telamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulysseB/telamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/{sha}","languages_url":"https://api.github.com/repos/ulysseB/telamon/languages","stargazers_url":"https://api.github.com/repos/ulysseB/telamon/stargazers","contributors_url":"https://api.github.com/repos/ulysseB/telamon/contributors","subscribers_url":"https://api.github.com/repos/ulysseB/telamon/subscribers","subscription_url":"https://api.github.com/repos/ulysseB/telamon/subscription","commits_url":"https://api.github.com/repos/ulysseB/telamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulysseB/telamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulysseB/telamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulysseB/telamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulysseB/telamon/contents/{+path}","compare_url":"https://api.github.com/repos/ulysseB/telamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulysseB/telamon/merges","archive_url":"https://api.github.com/repos/ulysseB/telamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulysseB/telamon/downloads","issues_url":"https://api.github.com/repos/ulysseB/telamon/issues{/number}","pulls_url":"https://api.github.com/repos/ulysseB/telamon/pulls{/number}","milestones_url":"https://api.github.com/repos/ulysseB/telamon/milestones{/number}","notifications_url":"https://api.github.com/repos/ulysseB/telamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulysseB/telamon/labels{/name}","releases_url":"https://api.github.com/repos/ulysseB/telamon/releases{/id}","deployments_url":"https://api.github.com/repos/ulysseB/telamon/deployments","created_at":"2018-03-16T14:52:10Z","updated_at":"2019-08-22T13:51:45Z","pushed_at":"2019-08-22T13:51:44Z","git_url":"git://github.com/ulysseB/telamon.git","ssh_url":"git@github.com:ulysseB/telamon.git","clone_url":"https://github.com/ulysseB/telamon.git","svn_url":"https://github.com/ulysseB/telamon","homepage":"https://ulysseb.github.io/telamon/telamon","size":71533,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":25,"watchers":11,"default_branch":"master"}},"base":{"label":"ulysseB:bclement/tlcodegen","ref":"bclement/tlcodegen","sha":"e3240d5e6d093ea2612af890c8a3785beef33253","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"repo":{"id":125530367,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1MzAzNjc=","name":"telamon","full_name":"ulysseB/telamon","private":false,"owner":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ulysseB/telamon","description":"A framework to find good combinations of optimizations for computational kernels on GPUs.","fork":false,"url":"https://api.github.com/repos/ulysseB/telamon","forks_url":"https://api.github.com/repos/ulysseB/telamon/forks","keys_url":"https://api.github.com/repos/ulysseB/telamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulysseB/telamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulysseB/telamon/teams","hooks_url":"https://api.github.com/repos/ulysseB/telamon/hooks","issue_events_url":"https://api.github.com/repos/ulysseB/telamon/issues/events{/number}","events_url":"https://api.github.com/repos/ulysseB/telamon/events","assignees_url":"https://api.github.com/repos/ulysseB/telamon/assignees{/user}","branches_url":"https://api.github.com/repos/ulysseB/telamon/branches{/branch}","tags_url":"https://api.github.com/repos/ulysseB/telamon/tags","blobs_url":"https://api.github.com/repos/ulysseB/telamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulysseB/telamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulysseB/telamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulysseB/telamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/{sha}","languages_url":"https://api.github.com/repos/ulysseB/telamon/languages","stargazers_url":"https://api.github.com/repos/ulysseB/telamon/stargazers","contributors_url":"https://api.github.com/repos/ulysseB/telamon/contributors","subscribers_url":"https://api.github.com/repos/ulysseB/telamon/subscribers","subscription_url":"https://api.github.com/repos/ulysseB/telamon/subscription","commits_url":"https://api.github.com/repos/ulysseB/telamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulysseB/telamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulysseB/telamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulysseB/telamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulysseB/telamon/contents/{+path}","compare_url":"https://api.github.com/repos/ulysseB/telamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulysseB/telamon/merges","archive_url":"https://api.github.com/repos/ulysseB/telamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulysseB/telamon/downloads","issues_url":"https://api.github.com/repos/ulysseB/telamon/issues{/number}","pulls_url":"https://api.github.com/repos/ulysseB/telamon/pulls{/number}","milestones_url":"https://api.github.com/repos/ulysseB/telamon/milestones{/number}","notifications_url":"https://api.github.com/repos/ulysseB/telamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulysseB/telamon/labels{/name}","releases_url":"https://api.github.com/repos/ulysseB/telamon/releases{/id}","deployments_url":"https://api.github.com/repos/ulysseB/telamon/deployments","created_at":"2018-03-16T14:52:10Z","updated_at":"2019-08-22T13:51:45Z","pushed_at":"2019-08-22T13:51:44Z","git_url":"git://github.com/ulysseB/telamon.git","ssh_url":"git@github.com:ulysseB/telamon.git","clone_url":"https://github.com/ulysseB/telamon.git","svn_url":"https://github.com/ulysseB/telamon","homepage":"https://ulysseb.github.io/telamon/telamon","size":71533,"stargazers_count":11,"watchers_count":11,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":25,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/290"},"html":{"href":"https://github.com/ulysseB/telamon/pull/290"},"issue":{"href":"https://api.github.com/repos/ulysseB/telamon/issues/290"},"comments":{"href":"https://api.github.com/repos/ulysseB/telamon/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/ulysseB/telamon/statuses/64191a1795e597966797f694d3ece46cf4fdd0c8"}},"author_association":"COLLABORATOR"}}
|
{
"id": 125530367,
"name": "ulysseB/telamon",
"url": "https://api.github.com/repos/ulysseB/telamon"
}
|
{
"id": 146210,
"login": "Elarnon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/146210?",
"url": "https://api.github.com/users/Elarnon"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-22T14:24:19 |
10263456717
|
{"actor":{"display_login":"Elarnon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/comments/275405036","pull_request_review_id":226702807,"id":275405036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTQwNTAzNg==","diff_hunk":"@@ -0,0 +1,78 @@\n+import React from \"react\";\n+import styled from \"styled-components\";\n+\n+function Panel({ name, url, description, clone, ownerAvatar }) {\n+ return (\n+ <PanelContent>\n+ <div className=\"header\">\n+ <img src={ownerAvatar} alt={name} />\n+ <a className=\"panel-url\" href={url} alt=\"avatar\">\n+ {name}\n+ </a>\n+ </div>\n+ <div className=\"content\">\n+ <h4>\n+ <a href={clone}>{name}</a>\n+ </h4>\n+ <p>{description}</p>\n+ </div>\n+ </PanelContent>\n+ );\n+}\n+\n+const PanelContent = styled.div`\n+ width: 45%;\n+ display: flex;\n+ justify-content: flex-start;\n+ box-sizing: border-box;","path":"client/src/components/Panel.js","position":27,"original_position":27,"commit_id":"50397310e50d47be40877b31ff6397a84b88656c","original_commit_id":"50397310e50d47be40877b31ff6397a84b88656c","user":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"body":"Shhh... We don't want to be in the minority:\r\nhttps://css-tricks.com/poll-results-how-do-you-order-your-css-properties/","created_at":"2019-04-15T15:01:50Z","updated_at":"2019-04-15T15:01:50Z","html_url":"https://github.com/CodyPredy/dockerifi/pull/6#discussion_r275405036","pull_request_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/comments/275405036"},"html":{"href":"https://github.com/CodyPredy/dockerifi/pull/6#discussion_r275405036"},"pull_request":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6"}},"in_reply_to_id":275390413},"pull_request":{"url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6","id":270504009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTA0MDA5","html_url":"https://github.com/CodyPredy/dockerifi/pull/6","diff_url":"https://github.com/CodyPredy/dockerifi/pull/6.diff","patch_url":"https://github.com/CodyPredy/dockerifi/pull/6.patch","issue_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/6","number":6,"state":"open","locked":false,"title":"Added some meat to the bone :D","user":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"body":"Added repo app with client and node support\r\nAdded support for styled components\r\nSome updates to docker for node debugging","created_at":"2019-04-15T12:54:40Z","updated_at":"2019-04-15T15:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7194c5f71d757edb4c1c604b7907502a7bbd220","assignee":null,"assignees":[],"requested_reviewers":[{"login":"robert-damoc","id":17988801,"node_id":"MDQ6VXNlcjE3OTg4ODAx","avatar_url":"https://avatars0.githubusercontent.com/u/17988801?v=4","gravatar_id":"","url":"https://api.github.com/users/robert-damoc","html_url":"https://github.com/robert-damoc","followers_url":"https://api.github.com/users/robert-damoc/followers","following_url":"https://api.github.com/users/robert-damoc/following{/other_user}","gists_url":"https://api.github.com/users/robert-damoc/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-damoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-damoc/subscriptions","organizations_url":"https://api.github.com/users/robert-damoc/orgs","repos_url":"https://api.github.com/users/robert-damoc/repos","events_url":"https://api.github.com/users/robert-damoc/events{/privacy}","received_events_url":"https://api.github.com/users/robert-damoc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6/commits","review_comments_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6/comments","review_comment_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/6/comments","statuses_url":"https://api.github.com/repos/CodyPredy/dockerifi/statuses/50397310e50d47be40877b31ff6397a84b88656c","head":{"label":"CodyPredy:Add_repo_app","ref":"Add_repo_app","sha":"50397310e50d47be40877b31ff6397a84b88656c","user":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"repo":{"id":178026439,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgwMjY0Mzk=","name":"dockerifi","full_name":"CodyPredy/dockerifi","private":false,"owner":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CodyPredy/dockerifi","description":"Dockering React and NodeJS Environment","fork":false,"url":"https://api.github.com/repos/CodyPredy/dockerifi","forks_url":"https://api.github.com/repos/CodyPredy/dockerifi/forks","keys_url":"https://api.github.com/repos/CodyPredy/dockerifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodyPredy/dockerifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodyPredy/dockerifi/teams","hooks_url":"https://api.github.com/repos/CodyPredy/dockerifi/hooks","issue_events_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/events{/number}","events_url":"https://api.github.com/repos/CodyPredy/dockerifi/events","assignees_url":"https://api.github.com/repos/CodyPredy/dockerifi/assignees{/user}","branches_url":"https://api.github.com/repos/CodyPredy/dockerifi/branches{/branch}","tags_url":"https://api.github.com/repos/CodyPredy/dockerifi/tags","blobs_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodyPredy/dockerifi/statuses/{sha}","languages_url":"https://api.github.com/repos/CodyPredy/dockerifi/languages","stargazers_url":"https://api.github.com/repos/CodyPredy/dockerifi/stargazers","contributors_url":"https://api.github.com/repos/CodyPredy/dockerifi/contributors","subscribers_url":"https://api.github.com/repos/CodyPredy/dockerifi/subscribers","subscription_url":"https://api.github.com/repos/CodyPredy/dockerifi/subscription","commits_url":"https://api.github.com/repos/CodyPredy/dockerifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodyPredy/dockerifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodyPredy/dockerifi/contents/{+path}","compare_url":"https://api.github.com/repos/CodyPredy/dockerifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodyPredy/dockerifi/merges","archive_url":"https://api.github.com/repos/CodyPredy/dockerifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodyPredy/dockerifi/downloads","issues_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues{/number}","pulls_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls{/number}","milestones_url":"https://api.github.com/repos/CodyPredy/dockerifi/milestones{/number}","notifications_url":"https://api.github.com/repos/CodyPredy/dockerifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodyPredy/dockerifi/labels{/name}","releases_url":"https://api.github.com/repos/CodyPredy/dockerifi/releases{/id}","deployments_url":"https://api.github.com/repos/CodyPredy/dockerifi/deployments","created_at":"2019-03-27T15:46:50Z","updated_at":"2019-04-10T12:06:58Z","pushed_at":"2019-04-15T12:54:41Z","git_url":"git://github.com/CodyPredy/dockerifi.git","ssh_url":"git@github.com:CodyPredy/dockerifi.git","clone_url":"https://github.com/CodyPredy/dockerifi.git","svn_url":"https://github.com/CodyPredy/dockerifi","homepage":null,"size":215,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"CodyPredy:master","ref":"master","sha":"8f92bf2b2737e62fe173f929b961d1db36166a8e","user":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"repo":{"id":178026439,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgwMjY0Mzk=","name":"dockerifi","full_name":"CodyPredy/dockerifi","private":false,"owner":{"login":"CodyPredy","id":4159073,"node_id":"MDQ6VXNlcjQxNTkwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4159073?v=4","gravatar_id":"","url":"https://api.github.com/users/CodyPredy","html_url":"https://github.com/CodyPredy","followers_url":"https://api.github.com/users/CodyPredy/followers","following_url":"https://api.github.com/users/CodyPredy/following{/other_user}","gists_url":"https://api.github.com/users/CodyPredy/gists{/gist_id}","starred_url":"https://api.github.com/users/CodyPredy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CodyPredy/subscriptions","organizations_url":"https://api.github.com/users/CodyPredy/orgs","repos_url":"https://api.github.com/users/CodyPredy/repos","events_url":"https://api.github.com/users/CodyPredy/events{/privacy}","received_events_url":"https://api.github.com/users/CodyPredy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CodyPredy/dockerifi","description":"Dockering React and NodeJS Environment","fork":false,"url":"https://api.github.com/repos/CodyPredy/dockerifi","forks_url":"https://api.github.com/repos/CodyPredy/dockerifi/forks","keys_url":"https://api.github.com/repos/CodyPredy/dockerifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CodyPredy/dockerifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CodyPredy/dockerifi/teams","hooks_url":"https://api.github.com/repos/CodyPredy/dockerifi/hooks","issue_events_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/events{/number}","events_url":"https://api.github.com/repos/CodyPredy/dockerifi/events","assignees_url":"https://api.github.com/repos/CodyPredy/dockerifi/assignees{/user}","branches_url":"https://api.github.com/repos/CodyPredy/dockerifi/branches{/branch}","tags_url":"https://api.github.com/repos/CodyPredy/dockerifi/tags","blobs_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CodyPredy/dockerifi/statuses/{sha}","languages_url":"https://api.github.com/repos/CodyPredy/dockerifi/languages","stargazers_url":"https://api.github.com/repos/CodyPredy/dockerifi/stargazers","contributors_url":"https://api.github.com/repos/CodyPredy/dockerifi/contributors","subscribers_url":"https://api.github.com/repos/CodyPredy/dockerifi/subscribers","subscription_url":"https://api.github.com/repos/CodyPredy/dockerifi/subscription","commits_url":"https://api.github.com/repos/CodyPredy/dockerifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/CodyPredy/dockerifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/CodyPredy/dockerifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/CodyPredy/dockerifi/contents/{+path}","compare_url":"https://api.github.com/repos/CodyPredy/dockerifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CodyPredy/dockerifi/merges","archive_url":"https://api.github.com/repos/CodyPredy/dockerifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CodyPredy/dockerifi/downloads","issues_url":"https://api.github.com/repos/CodyPredy/dockerifi/issues{/number}","pulls_url":"https://api.github.com/repos/CodyPredy/dockerifi/pulls{/number}","milestones_url":"https://api.github.com/repos/CodyPredy/dockerifi/milestones{/number}","notifications_url":"https://api.github.com/repos/CodyPredy/dockerifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CodyPredy/dockerifi/labels{/name}","releases_url":"https://api.github.com/repos/CodyPredy/dockerifi/releases{/id}","deployments_url":"https://api.github.com/repos/CodyPredy/dockerifi/deployments","created_at":"2019-03-27T15:46:50Z","updated_at":"2019-04-10T12:06:58Z","pushed_at":"2019-04-15T12:54:41Z","git_url":"git://github.com/CodyPredy/dockerifi.git","ssh_url":"git@github.com:CodyPredy/dockerifi.git","clone_url":"https://github.com/CodyPredy/dockerifi.git","svn_url":"https://github.com/CodyPredy/dockerifi","homepage":null,"size":215,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6"},"html":{"href":"https://github.com/CodyPredy/dockerifi/pull/6"},"issue":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/issues/6"},"comments":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/CodyPredy/dockerifi/statuses/50397310e50d47be40877b31ff6397a84b88656c"}},"author_association":"OWNER"}}
|
{
"id": 178026439,
"name": "CodyPredy/dockerifi",
"url": "https://api.github.com/repos/CodyPredy/dockerifi"
}
|
{
"id": 4159073,
"login": "CodyPredy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4159073?",
"url": "https://api.github.com/users/CodyPredy"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-04-15T15:01:50 |
9445821385
|
{"actor":{"display_login":"CodyPredy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/woubuc/node-updown/pulls/comments/314710815","pull_request_review_id":275937557,"id":314710815,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNDcxMDgxNQ==","diff_hunk":"@@ -11,7 +11,7 @@ export interface Options {\n \n /** An object with primitive values (i.e. no arrays/objects) */\n interface PrimitiveObject {\n-\t[key : string] : string | number;\n+\t[key: string]: string | number;","path":"src/Updown.ts","position":5,"original_position":5,"commit_id":"0e43b08b4cbe9ac6a261205c69e81b10a317ab70","original_commit_id":"0e43b08b4cbe9ac6a261205c69e81b10a317ab70","user":{"login":"MichaelDeBoey","id":6643991,"node_id":"MDQ6VXNlcjY2NDM5OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6643991?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelDeBoey","html_url":"https://github.com/MichaelDeBoey","followers_url":"https://api.github.com/users/MichaelDeBoey/followers","following_url":"https://api.github.com/users/MichaelDeBoey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDeBoey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDeBoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDeBoey/subscriptions","organizations_url":"https://api.github.com/users/MichaelDeBoey/orgs","repos_url":"https://api.github.com/users/MichaelDeBoey/repos","events_url":"https://api.github.com/users/MichaelDeBoey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDeBoey/received_events","type":"User","site_admin":false},"body":"> @woubuc:\r\n> There should always be a space before and after the : for type notations, as in the original code. This is to more easily see the difference between `{ prop : type }` and `{ prop: value }` even out of context.\r\n\r\nIt's more commonly used this way instead of the way you're saying if you look at other (big) projects.","created_at":"2019-08-16T13:04:29Z","updated_at":"2019-08-16T13:17:37Z","html_url":"https://github.com/woubuc/node-updown/pull/4#discussion_r314710815","pull_request_url":"https://api.github.com/repos/woubuc/node-updown/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/comments/314710815"},"html":{"href":"https://github.com/woubuc/node-updown/pull/4#discussion_r314710815"},"pull_request":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/woubuc/node-updown/pulls/4","id":307912395,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3OTEyMzk1","html_url":"https://github.com/woubuc/node-updown/pull/4","diff_url":"https://github.com/woubuc/node-updown/pull/4.diff","patch_url":"https://github.com/woubuc/node-updown/pull/4.patch","issue_url":"https://api.github.com/repos/woubuc/node-updown/issues/4","number":4,"state":"open","locked":false,"title":"Use ESLint instead of TSLint","user":{"login":"MichaelDeBoey","id":6643991,"node_id":"MDQ6VXNlcjY2NDM5OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6643991?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelDeBoey","html_url":"https://github.com/MichaelDeBoey","followers_url":"https://api.github.com/users/MichaelDeBoey/followers","following_url":"https://api.github.com/users/MichaelDeBoey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDeBoey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDeBoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDeBoey/subscriptions","organizations_url":"https://api.github.com/users/MichaelDeBoey/orgs","repos_url":"https://api.github.com/users/MichaelDeBoey/repos","events_url":"https://api.github.com/users/MichaelDeBoey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDeBoey/received_events","type":"User","site_admin":false},"body":"- Use ESLint instead of TSLint\r\n- Fix ESLint","created_at":"2019-08-16T01:45:36Z","updated_at":"2019-08-16T13:17:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aa5d58b443ed35b9a179a44c48adc82b5bb8e9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/woubuc/node-updown/pulls/4/commits","review_comments_url":"https://api.github.com/repos/woubuc/node-updown/pulls/4/comments","review_comment_url":"https://api.github.com/repos/woubuc/node-updown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woubuc/node-updown/issues/4/comments","statuses_url":"https://api.github.com/repos/woubuc/node-updown/statuses/0e43b08b4cbe9ac6a261205c69e81b10a317ab70","head":{"label":"MichaelDeBoey:convert-to-eslint","ref":"convert-to-eslint","sha":"0e43b08b4cbe9ac6a261205c69e81b10a317ab70","user":{"login":"MichaelDeBoey","id":6643991,"node_id":"MDQ6VXNlcjY2NDM5OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6643991?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelDeBoey","html_url":"https://github.com/MichaelDeBoey","followers_url":"https://api.github.com/users/MichaelDeBoey/followers","following_url":"https://api.github.com/users/MichaelDeBoey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDeBoey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDeBoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDeBoey/subscriptions","organizations_url":"https://api.github.com/users/MichaelDeBoey/orgs","repos_url":"https://api.github.com/users/MichaelDeBoey/repos","events_url":"https://api.github.com/users/MichaelDeBoey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDeBoey/received_events","type":"User","site_admin":false},"repo":{"id":202627505,"node_id":"MDEwOlJlcG9zaXRvcnkyMDI2Mjc1MDU=","name":"node-updown","full_name":"MichaelDeBoey/node-updown","private":false,"owner":{"login":"MichaelDeBoey","id":6643991,"node_id":"MDQ6VXNlcjY2NDM5OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6643991?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelDeBoey","html_url":"https://github.com/MichaelDeBoey","followers_url":"https://api.github.com/users/MichaelDeBoey/followers","following_url":"https://api.github.com/users/MichaelDeBoey/following{/other_user}","gists_url":"https://api.github.com/users/MichaelDeBoey/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelDeBoey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelDeBoey/subscriptions","organizations_url":"https://api.github.com/users/MichaelDeBoey/orgs","repos_url":"https://api.github.com/users/MichaelDeBoey/repos","events_url":"https://api.github.com/users/MichaelDeBoey/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelDeBoey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MichaelDeBoey/node-updown","description":"Simple Node.js API wrapper for updown.io","fork":true,"url":"https://api.github.com/repos/MichaelDeBoey/node-updown","forks_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/forks","keys_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/teams","hooks_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/hooks","issue_events_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/issues/events{/number}","events_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/events","assignees_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/assignees{/user}","branches_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/branches{/branch}","tags_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/tags","blobs_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/git/refs{/sha}","trees_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/statuses/{sha}","languages_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/languages","stargazers_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/stargazers","contributors_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/contributors","subscribers_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/subscribers","subscription_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/subscription","commits_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/commits{/sha}","git_commits_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/git/commits{/sha}","comments_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/comments{/number}","issue_comment_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/issues/comments{/number}","contents_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/contents/{+path}","compare_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/merges","archive_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/downloads","issues_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/issues{/number}","pulls_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/pulls{/number}","milestones_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/milestones{/number}","notifications_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/labels{/name}","releases_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/releases{/id}","deployments_url":"https://api.github.com/repos/MichaelDeBoey/node-updown/deployments","created_at":"2019-08-15T23:59:54Z","updated_at":"2019-08-16T12:42:10Z","pushed_at":"2019-08-16T12:45:33Z","git_url":"git://github.com/MichaelDeBoey/node-updown.git","ssh_url":"git@github.com:MichaelDeBoey/node-updown.git","clone_url":"https://github.com/MichaelDeBoey/node-updown.git","svn_url":"https://github.com/MichaelDeBoey/node-updown","homepage":"https://www.npmjs.com/package/node-updown","size":186,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"woubuc:master","ref":"master","sha":"4c5ec121790db477aa6caf7a159ee87c909d1f6b","user":{"login":"woubuc","id":1015540,"node_id":"MDQ6VXNlcjEwMTU1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015540?v=4","gravatar_id":"","url":"https://api.github.com/users/woubuc","html_url":"https://github.com/woubuc","followers_url":"https://api.github.com/users/woubuc/followers","following_url":"https://api.github.com/users/woubuc/following{/other_user}","gists_url":"https://api.github.com/users/woubuc/gists{/gist_id}","starred_url":"https://api.github.com/users/woubuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woubuc/subscriptions","organizations_url":"https://api.github.com/users/woubuc/orgs","repos_url":"https://api.github.com/users/woubuc/repos","events_url":"https://api.github.com/users/woubuc/events{/privacy}","received_events_url":"https://api.github.com/users/woubuc/received_events","type":"User","site_admin":false},"repo":{"id":49686370,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY4NjM3MA==","name":"node-updown","full_name":"woubuc/node-updown","private":false,"owner":{"login":"woubuc","id":1015540,"node_id":"MDQ6VXNlcjEwMTU1NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015540?v=4","gravatar_id":"","url":"https://api.github.com/users/woubuc","html_url":"https://github.com/woubuc","followers_url":"https://api.github.com/users/woubuc/followers","following_url":"https://api.github.com/users/woubuc/following{/other_user}","gists_url":"https://api.github.com/users/woubuc/gists{/gist_id}","starred_url":"https://api.github.com/users/woubuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woubuc/subscriptions","organizations_url":"https://api.github.com/users/woubuc/orgs","repos_url":"https://api.github.com/users/woubuc/repos","events_url":"https://api.github.com/users/woubuc/events{/privacy}","received_events_url":"https://api.github.com/users/woubuc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/woubuc/node-updown","description":"Simple Node.js API wrapper for updown.io","fork":false,"url":"https://api.github.com/repos/woubuc/node-updown","forks_url":"https://api.github.com/repos/woubuc/node-updown/forks","keys_url":"https://api.github.com/repos/woubuc/node-updown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woubuc/node-updown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woubuc/node-updown/teams","hooks_url":"https://api.github.com/repos/woubuc/node-updown/hooks","issue_events_url":"https://api.github.com/repos/woubuc/node-updown/issues/events{/number}","events_url":"https://api.github.com/repos/woubuc/node-updown/events","assignees_url":"https://api.github.com/repos/woubuc/node-updown/assignees{/user}","branches_url":"https://api.github.com/repos/woubuc/node-updown/branches{/branch}","tags_url":"https://api.github.com/repos/woubuc/node-updown/tags","blobs_url":"https://api.github.com/repos/woubuc/node-updown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woubuc/node-updown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woubuc/node-updown/git/refs{/sha}","trees_url":"https://api.github.com/repos/woubuc/node-updown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woubuc/node-updown/statuses/{sha}","languages_url":"https://api.github.com/repos/woubuc/node-updown/languages","stargazers_url":"https://api.github.com/repos/woubuc/node-updown/stargazers","contributors_url":"https://api.github.com/repos/woubuc/node-updown/contributors","subscribers_url":"https://api.github.com/repos/woubuc/node-updown/subscribers","subscription_url":"https://api.github.com/repos/woubuc/node-updown/subscription","commits_url":"https://api.github.com/repos/woubuc/node-updown/commits{/sha}","git_commits_url":"https://api.github.com/repos/woubuc/node-updown/git/commits{/sha}","comments_url":"https://api.github.com/repos/woubuc/node-updown/comments{/number}","issue_comment_url":"https://api.github.com/repos/woubuc/node-updown/issues/comments{/number}","contents_url":"https://api.github.com/repos/woubuc/node-updown/contents/{+path}","compare_url":"https://api.github.com/repos/woubuc/node-updown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woubuc/node-updown/merges","archive_url":"https://api.github.com/repos/woubuc/node-updown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woubuc/node-updown/downloads","issues_url":"https://api.github.com/repos/woubuc/node-updown/issues{/number}","pulls_url":"https://api.github.com/repos/woubuc/node-updown/pulls{/number}","milestones_url":"https://api.github.com/repos/woubuc/node-updown/milestones{/number}","notifications_url":"https://api.github.com/repos/woubuc/node-updown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woubuc/node-updown/labels{/name}","releases_url":"https://api.github.com/repos/woubuc/node-updown/releases{/id}","deployments_url":"https://api.github.com/repos/woubuc/node-updown/deployments","created_at":"2016-01-15T01:15:40Z","updated_at":"2019-08-16T12:38:16Z","pushed_at":"2019-08-16T12:45:34Z","git_url":"git://github.com/woubuc/node-updown.git","ssh_url":"git@github.com:woubuc/node-updown.git","clone_url":"https://github.com/woubuc/node-updown.git","svn_url":"https://github.com/woubuc/node-updown","homepage":"https://www.npmjs.com/package/node-updown","size":25,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/4"},"html":{"href":"https://github.com/woubuc/node-updown/pull/4"},"issue":{"href":"https://api.github.com/repos/woubuc/node-updown/issues/4"},"comments":{"href":"https://api.github.com/repos/woubuc/node-updown/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woubuc/node-updown/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/woubuc/node-updown/statuses/0e43b08b4cbe9ac6a261205c69e81b10a317ab70"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 49686370,
"name": "woubuc/node-updown",
"url": "https://api.github.com/repos/woubuc/node-updown"
}
|
{
"id": 6643991,
"login": "MichaelDeBoey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6643991?",
"url": "https://api.github.com/users/MichaelDeBoey"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-16T13:04:29 |
10224636677
|
{"actor":{"display_login":"MichaelDeBoey"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/comments/353411925","pull_request_review_id":326436050,"id":353411925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzQxMTkyNQ==","diff_hunk":"@@ -1,16 +1,32 @@\n [](https://travis-ci.com/mdellweg/ansible_modules_pulp)\n \n-ansible modules for Pulp aka Squeeze\n+ansible modules for Pulp aka Squeezer\n ===\n \n This project project aims to provide a complete set of ansible modules to control a pulp3 server in a descriptive way.\n This is neither to be confused with ansible-pulp to install pulp, nor pulp\\_ansible to manage ansible content in pulp.\n+It has been wildly inspired by the sister project [foreman-ansible-modules](https://github.com/theforeman/foreman-ansible-modules).\n \n Testing\n ---\n \n-Testing infrastructure has been wildly inspired by the sister project [foreman-ansible-modules](https://github.com/theforeman/foreman-ansible-modules).\n-Look at the documentation there for now.\n+Testing is done by running handcrafted playbooks while playing back prerecorded server answers.\n+\n+Those playbooks are meant to test one specific module, and are usually structured in three sections:","path":"README.md","position":18,"original_position":18,"commit_id":"f2f7da7c5e044d1f1d687588284ea1c371902398","original_commit_id":"78e9711209f2515899a836516e83388748b06179","user":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"body":"good catch!","created_at":"2019-12-03T20:44:42Z","updated_at":"2019-12-03T20:44:42Z","html_url":"https://github.com/mdellweg/ansible_modules_pulp/pull/8#discussion_r353411925","pull_request_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/comments/353411925"},"html":{"href":"https://github.com/mdellweg/ansible_modules_pulp/pull/8#discussion_r353411925"},"pull_request":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8"}},"in_reply_to_id":353345344},"pull_request":{"url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8","id":348026199,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MDI2MTk5","html_url":"https://github.com/mdellweg/ansible_modules_pulp/pull/8","diff_url":"https://github.com/mdellweg/ansible_modules_pulp/pull/8.diff","patch_url":"https://github.com/mdellweg/ansible_modules_pulp/pull/8.patch","issue_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/8","number":8,"state":"open","locked":false,"title":"Add check_mode tests and test docs","user":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-02T23:11:05Z","updated_at":"2019-12-03T20:44:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"454b0bd3b0f98c49fae79437c0ff42dbb4456616","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8/commits","review_comments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8/comments","review_comment_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/8/comments","statuses_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/statuses/f2f7da7c5e044d1f1d687588284ea1c371902398","head":{"label":"mdellweg:test_check_mode","ref":"test_check_mode","sha":"f2f7da7c5e044d1f1d687588284ea1c371902398","user":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"repo":{"id":189855081,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4NTUwODE=","name":"ansible_modules_pulp","full_name":"mdellweg/ansible_modules_pulp","private":false,"owner":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mdellweg/ansible_modules_pulp","description":"Ansible modules to control a pulp3 server","fork":false,"url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp","forks_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/forks","keys_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/teams","hooks_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/hooks","issue_events_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/events{/number}","events_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/events","assignees_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/assignees{/user}","branches_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/branches{/branch}","tags_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/tags","blobs_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/languages","stargazers_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/stargazers","contributors_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/contributors","subscribers_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/subscribers","subscription_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/subscription","commits_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/contents/{+path}","compare_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/merges","archive_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/downloads","issues_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues{/number}","pulls_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/labels{/name}","releases_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/releases{/id}","deployments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/deployments","created_at":"2019-06-02T14:15:51Z","updated_at":"2019-11-17T17:20:35Z","pushed_at":"2019-12-03T20:34:37Z","git_url":"git://github.com/mdellweg/ansible_modules_pulp.git","ssh_url":"git@github.com:mdellweg/ansible_modules_pulp.git","clone_url":"https://github.com/mdellweg/ansible_modules_pulp.git","svn_url":"https://github.com/mdellweg/ansible_modules_pulp","homepage":"","size":151,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"base":{"label":"mdellweg:master","ref":"master","sha":"819cd3c7a57c1ecb34bc71d687d63d29aca3afd0","user":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"repo":{"id":189855081,"node_id":"MDEwOlJlcG9zaXRvcnkxODk4NTUwODE=","name":"ansible_modules_pulp","full_name":"mdellweg/ansible_modules_pulp","private":false,"owner":{"login":"mdellweg","id":25984076,"node_id":"MDQ6VXNlcjI1OTg0MDc2","avatar_url":"https://avatars1.githubusercontent.com/u/25984076?v=4","gravatar_id":"","url":"https://api.github.com/users/mdellweg","html_url":"https://github.com/mdellweg","followers_url":"https://api.github.com/users/mdellweg/followers","following_url":"https://api.github.com/users/mdellweg/following{/other_user}","gists_url":"https://api.github.com/users/mdellweg/gists{/gist_id}","starred_url":"https://api.github.com/users/mdellweg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdellweg/subscriptions","organizations_url":"https://api.github.com/users/mdellweg/orgs","repos_url":"https://api.github.com/users/mdellweg/repos","events_url":"https://api.github.com/users/mdellweg/events{/privacy}","received_events_url":"https://api.github.com/users/mdellweg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mdellweg/ansible_modules_pulp","description":"Ansible modules to control a pulp3 server","fork":false,"url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp","forks_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/forks","keys_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/teams","hooks_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/hooks","issue_events_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/events{/number}","events_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/events","assignees_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/assignees{/user}","branches_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/branches{/branch}","tags_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/tags","blobs_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/statuses/{sha}","languages_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/languages","stargazers_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/stargazers","contributors_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/contributors","subscribers_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/subscribers","subscription_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/subscription","commits_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/contents/{+path}","compare_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/merges","archive_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/downloads","issues_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues{/number}","pulls_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls{/number}","milestones_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/milestones{/number}","notifications_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/labels{/name}","releases_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/releases{/id}","deployments_url":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/deployments","created_at":"2019-06-02T14:15:51Z","updated_at":"2019-11-17T17:20:35Z","pushed_at":"2019-12-03T20:34:37Z","git_url":"git://github.com/mdellweg/ansible_modules_pulp.git","ssh_url":"git@github.com:mdellweg/ansible_modules_pulp.git","clone_url":"https://github.com/mdellweg/ansible_modules_pulp.git","svn_url":"https://github.com/mdellweg/ansible_modules_pulp","homepage":"","size":151,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":4,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8"},"html":{"href":"https://github.com/mdellweg/ansible_modules_pulp/pull/8"},"issue":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/8"},"comments":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/mdellweg/ansible_modules_pulp/statuses/f2f7da7c5e044d1f1d687588284ea1c371902398"}},"author_association":"OWNER"}}
|
{
"id": 189855081,
"name": "mdellweg/ansible_modules_pulp",
"url": "https://api.github.com/repos/mdellweg/ansible_modules_pulp"
}
|
{
"id": 25984076,
"login": "mdellweg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25984076?",
"url": "https://api.github.com/users/mdellweg"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-03T20:44:42 |
11003532517
|
{"actor":{"display_login":"mdellweg"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/danielpaul/writter/pulls/comments/265107409","pull_request_review_id":213926070,"id":265107409,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTEwNzQwOQ==","diff_hunk":"@@ -10,11 +10,46 @@\n #\n # It's strongly recommended that you check this file into your version control system.\n \n-ActiveRecord::Schema.define(version: 2019_03_07_172648) do\n+ActiveRecord::Schema.define(version: 2019_03_13_103855) do\n \n # These are extensions that must be enabled in order to support this database\n enable_extension \"plpgsql\"\n \n+ create_table \"active_admin_comments\", force: :cascade do |t|\n+ t.string \"namespace\"\n+ t.text \"body\"\n+ t.string \"resource_type\"\n+ t.bigint \"resource_id\"\n+ t.string \"author_type\"\n+ t.bigint \"author_id\"\n+ t.datetime \"created_at\", null: false","path":"db/schema.rb","position":17,"original_position":17,"commit_id":"c5f6b7b3c5602e1c3949ea0a070b6de5bac4dec9","original_commit_id":"c5f6b7b3c5602e1c3949ea0a070b6de5bac4dec9","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2019-03-13T12:44:34Z","updated_at":"2019-03-13T12:44:35Z","html_url":"https://github.com/danielpaul/writter/pull/27#discussion_r265107409","pull_request_url":"https://api.github.com/repos/danielpaul/writter/pulls/27","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/comments/265107409"},"html":{"href":"https://github.com/danielpaul/writter/pull/27#discussion_r265107409"},"pull_request":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/danielpaul/writter/pulls/27","id":260476997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNDc2OTk3","html_url":"https://github.com/danielpaul/writter/pull/27","diff_url":"https://github.com/danielpaul/writter/pull/27.diff","patch_url":"https://github.com/danielpaul/writter/pull/27.patch","issue_url":"https://api.github.com/repos/danielpaul/writter/issues/27","number":27,"state":"closed","locked":false,"title":"Sidekiq","user":{"login":"iJohnPaul","id":25507937,"node_id":"MDQ6VXNlcjI1NTA3OTM3","avatar_url":"https://avatars1.githubusercontent.com/u/25507937?v=4","gravatar_id":"","url":"https://api.github.com/users/iJohnPaul","html_url":"https://github.com/iJohnPaul","followers_url":"https://api.github.com/users/iJohnPaul/followers","following_url":"https://api.github.com/users/iJohnPaul/following{/other_user}","gists_url":"https://api.github.com/users/iJohnPaul/gists{/gist_id}","starred_url":"https://api.github.com/users/iJohnPaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iJohnPaul/subscriptions","organizations_url":"https://api.github.com/users/iJohnPaul/orgs","repos_url":"https://api.github.com/users/iJohnPaul/repos","events_url":"https://api.github.com/users/iJohnPaul/events{/privacy}","received_events_url":"https://api.github.com/users/iJohnPaul/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-12T18:03:34Z","updated_at":"2019-03-13T12:44:35Z","closed_at":"2019-03-13T12:43:26Z","merged_at":"2019-03-13T12:43:26Z","merge_commit_sha":"7c5894647738976ffc08033de11d7e209deefdb2","assignee":{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false},"assignees":[{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/danielpaul/writter/pulls/27/commits","review_comments_url":"https://api.github.com/repos/danielpaul/writter/pulls/27/comments","review_comment_url":"https://api.github.com/repos/danielpaul/writter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielpaul/writter/issues/27/comments","statuses_url":"https://api.github.com/repos/danielpaul/writter/statuses/c5f6b7b3c5602e1c3949ea0a070b6de5bac4dec9","head":{"label":"danielpaul:sidekiq","ref":"sidekiq","sha":"c5f6b7b3c5602e1c3949ea0a070b6de5bac4dec9","user":{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false},"repo":{"id":174326381,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQzMjYzODE=","name":"writter","full_name":"danielpaul/writter","private":false,"owner":{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielpaul/writter","description":"A simple & clean blogging system.","fork":false,"url":"https://api.github.com/repos/danielpaul/writter","forks_url":"https://api.github.com/repos/danielpaul/writter/forks","keys_url":"https://api.github.com/repos/danielpaul/writter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpaul/writter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpaul/writter/teams","hooks_url":"https://api.github.com/repos/danielpaul/writter/hooks","issue_events_url":"https://api.github.com/repos/danielpaul/writter/issues/events{/number}","events_url":"https://api.github.com/repos/danielpaul/writter/events","assignees_url":"https://api.github.com/repos/danielpaul/writter/assignees{/user}","branches_url":"https://api.github.com/repos/danielpaul/writter/branches{/branch}","tags_url":"https://api.github.com/repos/danielpaul/writter/tags","blobs_url":"https://api.github.com/repos/danielpaul/writter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpaul/writter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpaul/writter/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpaul/writter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpaul/writter/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpaul/writter/languages","stargazers_url":"https://api.github.com/repos/danielpaul/writter/stargazers","contributors_url":"https://api.github.com/repos/danielpaul/writter/contributors","subscribers_url":"https://api.github.com/repos/danielpaul/writter/subscribers","subscription_url":"https://api.github.com/repos/danielpaul/writter/subscription","commits_url":"https://api.github.com/repos/danielpaul/writter/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpaul/writter/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpaul/writter/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpaul/writter/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpaul/writter/contents/{+path}","compare_url":"https://api.github.com/repos/danielpaul/writter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpaul/writter/merges","archive_url":"https://api.github.com/repos/danielpaul/writter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpaul/writter/downloads","issues_url":"https://api.github.com/repos/danielpaul/writter/issues{/number}","pulls_url":"https://api.github.com/repos/danielpaul/writter/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpaul/writter/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpaul/writter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpaul/writter/labels{/name}","releases_url":"https://api.github.com/repos/danielpaul/writter/releases{/id}","deployments_url":"https://api.github.com/repos/danielpaul/writter/deployments","created_at":"2019-03-07T10:52:05Z","updated_at":"2019-03-13T12:43:28Z","pushed_at":"2019-03-13T12:43:28Z","git_url":"git://github.com/danielpaul/writter.git","ssh_url":"git@github.com:danielpaul/writter.git","clone_url":"https://github.com/danielpaul/writter.git","svn_url":"https://github.com/danielpaul/writter","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"danielpaul:master","ref":"master","sha":"bafd41d5e91d1335b64b2a31bc0d6497528882c4","user":{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false},"repo":{"id":174326381,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQzMjYzODE=","name":"writter","full_name":"danielpaul/writter","private":false,"owner":{"login":"danielpaul","id":333233,"node_id":"MDQ6VXNlcjMzMzIzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/333233?v=4","gravatar_id":"","url":"https://api.github.com/users/danielpaul","html_url":"https://github.com/danielpaul","followers_url":"https://api.github.com/users/danielpaul/followers","following_url":"https://api.github.com/users/danielpaul/following{/other_user}","gists_url":"https://api.github.com/users/danielpaul/gists{/gist_id}","starred_url":"https://api.github.com/users/danielpaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielpaul/subscriptions","organizations_url":"https://api.github.com/users/danielpaul/orgs","repos_url":"https://api.github.com/users/danielpaul/repos","events_url":"https://api.github.com/users/danielpaul/events{/privacy}","received_events_url":"https://api.github.com/users/danielpaul/received_events","type":"User","site_admin":false},"html_url":"https://github.com/danielpaul/writter","description":"A simple & clean blogging system.","fork":false,"url":"https://api.github.com/repos/danielpaul/writter","forks_url":"https://api.github.com/repos/danielpaul/writter/forks","keys_url":"https://api.github.com/repos/danielpaul/writter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielpaul/writter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielpaul/writter/teams","hooks_url":"https://api.github.com/repos/danielpaul/writter/hooks","issue_events_url":"https://api.github.com/repos/danielpaul/writter/issues/events{/number}","events_url":"https://api.github.com/repos/danielpaul/writter/events","assignees_url":"https://api.github.com/repos/danielpaul/writter/assignees{/user}","branches_url":"https://api.github.com/repos/danielpaul/writter/branches{/branch}","tags_url":"https://api.github.com/repos/danielpaul/writter/tags","blobs_url":"https://api.github.com/repos/danielpaul/writter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielpaul/writter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielpaul/writter/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielpaul/writter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielpaul/writter/statuses/{sha}","languages_url":"https://api.github.com/repos/danielpaul/writter/languages","stargazers_url":"https://api.github.com/repos/danielpaul/writter/stargazers","contributors_url":"https://api.github.com/repos/danielpaul/writter/contributors","subscribers_url":"https://api.github.com/repos/danielpaul/writter/subscribers","subscription_url":"https://api.github.com/repos/danielpaul/writter/subscription","commits_url":"https://api.github.com/repos/danielpaul/writter/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielpaul/writter/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielpaul/writter/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielpaul/writter/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielpaul/writter/contents/{+path}","compare_url":"https://api.github.com/repos/danielpaul/writter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielpaul/writter/merges","archive_url":"https://api.github.com/repos/danielpaul/writter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielpaul/writter/downloads","issues_url":"https://api.github.com/repos/danielpaul/writter/issues{/number}","pulls_url":"https://api.github.com/repos/danielpaul/writter/pulls{/number}","milestones_url":"https://api.github.com/repos/danielpaul/writter/milestones{/number}","notifications_url":"https://api.github.com/repos/danielpaul/writter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielpaul/writter/labels{/name}","releases_url":"https://api.github.com/repos/danielpaul/writter/releases{/id}","deployments_url":"https://api.github.com/repos/danielpaul/writter/deployments","created_at":"2019-03-07T10:52:05Z","updated_at":"2019-03-13T12:43:28Z","pushed_at":"2019-03-13T12:43:28Z","git_url":"git://github.com/danielpaul/writter.git","ssh_url":"git@github.com:danielpaul/writter.git","clone_url":"https://github.com/danielpaul/writter.git","svn_url":"https://github.com/danielpaul/writter","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/27"},"html":{"href":"https://github.com/danielpaul/writter/pull/27"},"issue":{"href":"https://api.github.com/repos/danielpaul/writter/issues/27"},"comments":{"href":"https://api.github.com/repos/danielpaul/writter/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielpaul/writter/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/danielpaul/writter/statuses/c5f6b7b3c5602e1c3949ea0a070b6de5bac4dec9"}},"author_association":"COLLABORATOR"}}
|
{
"id": 174326381,
"name": "danielpaul/writter",
"url": "https://api.github.com/repos/danielpaul/writter"
}
|
{
"id": 30008653,
"login": "hound[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30008653?",
"url": "https://api.github.com/users/hound[bot]"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-03-13T12:44:34 |
9234511718
|
{"actor":{"display_login":"hound"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/boton/liferay-portal/pulls/comments/364149843","pull_request_review_id":339756937,"id":364149843,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDE0OTg0Mw==","diff_hunk":"@@ -40,13 +40,20 @@ export default ({answer}) => {\n \n \treturn (\n \t\t<>\n-\t\t\t<div className=\"autofit-row autofit-padded\">\n+\t\t\t<div\n+\t\t\t\tclassName={\n+\t\t\t\t\t'autofit-row autofit-padded ' +\n+\t\t\t\t\t(showAsAnswer ? 'question-accepted-answer' : '')","path":"modules/apps/questions/questions-web/src/main/resources/META-INF/resources/js/components/Answer.es.js","position":46,"original_position":25,"commit_id":"65f9657d674b66492fcbe2cbe07522a80e847f42","original_commit_id":"65f9657d674b66492fcbe2cbe07522a80e847f42","user":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"body":"using it here: https://github.com/boton/liferay-portal/pull/123/commits/6d26053ac69fd9bf12fd8b36baacd57acc37d03f#diff-939015cc9d7fcc9b96d84597478f1086","created_at":"2020-01-08T10:01:16Z","updated_at":"2020-01-08T10:01:16Z","html_url":"https://github.com/boton/liferay-portal/pull/122#discussion_r364149843","pull_request_url":"https://api.github.com/repos/boton/liferay-portal/pulls/122","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/comments/364149843"},"html":{"href":"https://github.com/boton/liferay-portal/pull/122#discussion_r364149843"},"pull_request":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/122"}},"in_reply_to_id":364133708},"pull_request":{"url":"https://api.github.com/repos/boton/liferay-portal/pulls/122","id":359989416,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5OTg5NDE2","html_url":"https://github.com/boton/liferay-portal/pull/122","diff_url":"https://github.com/boton/liferay-portal/pull/122.diff","patch_url":"https://github.com/boton/liferay-portal/pull/122.patch","issue_url":"https://api.github.com/repos/boton/liferay-portal/issues/122","number":122,"state":"closed","locked":false,"title":"LPS-102806 questions portlet","user":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"body":"","created_at":"2020-01-07T13:28:42Z","updated_at":"2020-01-08T10:01:16Z","closed_at":"2020-01-08T00:48:41Z","merged_at":null,"merge_commit_sha":"67fbbe6a3e5b11c4dba8685ccc5a5e608da80f0a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/boton/liferay-portal/pulls/122/commits","review_comments_url":"https://api.github.com/repos/boton/liferay-portal/pulls/122/comments","review_comment_url":"https://api.github.com/repos/boton/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boton/liferay-portal/issues/122/comments","statuses_url":"https://api.github.com/repos/boton/liferay-portal/statuses/65f9657d674b66492fcbe2cbe07522a80e847f42","head":{"label":"nhpatt:LPS-102806_questions_portlet","ref":"LPS-102806_questions_portlet","sha":"65f9657d674b66492fcbe2cbe07522a80e847f42","user":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"repo":{"id":37995608,"node_id":"MDEwOlJlcG9zaXRvcnkzNzk5NTYwOA==","name":"liferay-portal","full_name":"nhpatt/liferay-portal","private":false,"owner":{"login":"nhpatt","id":340653,"node_id":"MDQ6VXNlcjM0MDY1Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/340653?v=4","gravatar_id":"","url":"https://api.github.com/users/nhpatt","html_url":"https://github.com/nhpatt","followers_url":"https://api.github.com/users/nhpatt/followers","following_url":"https://api.github.com/users/nhpatt/following{/other_user}","gists_url":"https://api.github.com/users/nhpatt/gists{/gist_id}","starred_url":"https://api.github.com/users/nhpatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhpatt/subscriptions","organizations_url":"https://api.github.com/users/nhpatt/orgs","repos_url":"https://api.github.com/users/nhpatt/repos","events_url":"https://api.github.com/users/nhpatt/events{/privacy}","received_events_url":"https://api.github.com/users/nhpatt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nhpatt/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/nhpatt/liferay-portal","forks_url":"https://api.github.com/repos/nhpatt/liferay-portal/forks","keys_url":"https://api.github.com/repos/nhpatt/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nhpatt/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nhpatt/liferay-portal/teams","hooks_url":"https://api.github.com/repos/nhpatt/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/nhpatt/liferay-portal/events","assignees_url":"https://api.github.com/repos/nhpatt/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/nhpatt/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/nhpatt/liferay-portal/tags","blobs_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nhpatt/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/nhpatt/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/nhpatt/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/nhpatt/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/nhpatt/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/nhpatt/liferay-portal/subscription","commits_url":"https://api.github.com/repos/nhpatt/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/nhpatt/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/nhpatt/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/nhpatt/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/nhpatt/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nhpatt/liferay-portal/merges","archive_url":"https://api.github.com/repos/nhpatt/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nhpatt/liferay-portal/downloads","issues_url":"https://api.github.com/repos/nhpatt/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/nhpatt/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/nhpatt/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/nhpatt/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nhpatt/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/nhpatt/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/nhpatt/liferay-portal/deployments","created_at":"2015-06-24T16:10:32Z","updated_at":"2020-01-08T09:26:14Z","pushed_at":"2020-01-08T09:59:50Z","git_url":"git://github.com/nhpatt/liferay-portal.git","ssh_url":"git@github.com:nhpatt/liferay-portal.git","clone_url":"https://github.com/nhpatt/liferay-portal.git","svn_url":"https://github.com/nhpatt/liferay-portal","homepage":"http://liferay.com","size":13379070,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boton:master","ref":"master","sha":"ae3d63b0a484530a9bf30be727c75ff7083e9400","user":{"login":"boton","id":67901,"node_id":"MDQ6VXNlcjY3OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/67901?v=4","gravatar_id":"","url":"https://api.github.com/users/boton","html_url":"https://github.com/boton","followers_url":"https://api.github.com/users/boton/followers","following_url":"https://api.github.com/users/boton/following{/other_user}","gists_url":"https://api.github.com/users/boton/gists{/gist_id}","starred_url":"https://api.github.com/users/boton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boton/subscriptions","organizations_url":"https://api.github.com/users/boton/orgs","repos_url":"https://api.github.com/users/boton/repos","events_url":"https://api.github.com/users/boton/events{/privacy}","received_events_url":"https://api.github.com/users/boton/received_events","type":"User","site_admin":false},"repo":{"id":138169982,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNjk5ODI=","name":"liferay-portal","full_name":"boton/liferay-portal","private":false,"owner":{"login":"boton","id":67901,"node_id":"MDQ6VXNlcjY3OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/67901?v=4","gravatar_id":"","url":"https://api.github.com/users/boton","html_url":"https://github.com/boton","followers_url":"https://api.github.com/users/boton/followers","following_url":"https://api.github.com/users/boton/following{/other_user}","gists_url":"https://api.github.com/users/boton/gists{/gist_id}","starred_url":"https://api.github.com/users/boton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boton/subscriptions","organizations_url":"https://api.github.com/users/boton/orgs","repos_url":"https://api.github.com/users/boton/repos","events_url":"https://api.github.com/users/boton/events{/privacy}","received_events_url":"https://api.github.com/users/boton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/boton/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/boton/liferay-portal","forks_url":"https://api.github.com/repos/boton/liferay-portal/forks","keys_url":"https://api.github.com/repos/boton/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boton/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boton/liferay-portal/teams","hooks_url":"https://api.github.com/repos/boton/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/boton/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/boton/liferay-portal/events","assignees_url":"https://api.github.com/repos/boton/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/boton/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/boton/liferay-portal/tags","blobs_url":"https://api.github.com/repos/boton/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boton/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boton/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/boton/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boton/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/boton/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/boton/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/boton/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/boton/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/boton/liferay-portal/subscription","commits_url":"https://api.github.com/repos/boton/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/boton/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/boton/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/boton/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/boton/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/boton/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boton/liferay-portal/merges","archive_url":"https://api.github.com/repos/boton/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boton/liferay-portal/downloads","issues_url":"https://api.github.com/repos/boton/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/boton/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/boton/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/boton/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boton/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/boton/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/boton/liferay-portal/deployments","created_at":"2018-06-21T12:53:19Z","updated_at":"2020-01-08T07:08:29Z","pushed_at":"2020-01-08T09:59:55Z","git_url":"git://github.com/boton/liferay-portal.git","ssh_url":"git@github.com:boton/liferay-portal.git","clone_url":"https://github.com/boton/liferay-portal.git","svn_url":"https://github.com/boton/liferay-portal","homepage":"http://liferay.com","size":13082870,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/122"},"html":{"href":"https://github.com/boton/liferay-portal/pull/122"},"issue":{"href":"https://api.github.com/repos/boton/liferay-portal/issues/122"},"comments":{"href":"https://api.github.com/repos/boton/liferay-portal/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boton/liferay-portal/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/boton/liferay-portal/statuses/65f9657d674b66492fcbe2cbe07522a80e847f42"}},"author_association":"NONE"}}
|
{
"id": 138169982,
"name": "boton/liferay-portal",
"url": "https://api.github.com/repos/boton/liferay-portal"
}
|
{
"id": 340653,
"login": "nhpatt",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/340653?",
"url": "https://api.github.com/users/nhpatt"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2020-01-08T10:01:16 |
11226805945
|
{"actor":{"display_login":"nhpatt"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/comments/301705180","pull_request_review_id":259650083,"id":301705180,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTcwNTE4MA==","diff_hunk":"@@ -28,7 +28,7 @@\n <ng-container *ngIf=\"isLoggedIn()\">\n <li class=\"govuk-header__navigation-item\">{{ fullname }}</li>\n <li class=\"govuk-header__navigation-item\">\n- <a routerLink=\"/account-management/your-account\" class=\"govuk-header__link\">Account</a>\n+ <a routerLink=\"/account-management\" class=\"govuk-header__link\">Account</a>","path":"src/app/core/components/header/header.component.html","position":5,"original_position":5,"commit_id":"7a90404d936858f8205b561ad5b37ea44e16a50b","original_commit_id":"7a90404d936858f8205b561ad5b37ea44e16a50b","user":{"login":"omarCreativeDev","id":1694202,"node_id":"MDQ6VXNlcjE2OTQyMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1694202?v=4","gravatar_id":"","url":"https://api.github.com/users/omarCreativeDev","html_url":"https://github.com/omarCreativeDev","followers_url":"https://api.github.com/users/omarCreativeDev/followers","following_url":"https://api.github.com/users/omarCreativeDev/following{/other_user}","gists_url":"https://api.github.com/users/omarCreativeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/omarCreativeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omarCreativeDev/subscriptions","organizations_url":"https://api.github.com/users/omarCreativeDev/orgs","repos_url":"https://api.github.com/users/omarCreativeDev/repos","events_url":"https://api.github.com/users/omarCreativeDev/events{/privacy}","received_events_url":"https://api.github.com/users/omarCreativeDev/received_events","type":"User","site_admin":false},"body":"this change makes sense, keep things consistent with the other modules","created_at":"2019-07-09T17:26:18Z","updated_at":"2019-07-09T17:26:18Z","html_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924#discussion_r301705180","pull_request_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/comments/301705180"},"html":{"href":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924#discussion_r301705180"},"pull_request":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924"}}},"pull_request":{"url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924","id":295835499,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1ODM1NDk5","html_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924","diff_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924.diff","patch_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924.patch","issue_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/924","number":924,"state":"open","locked":false,"title":"Feature | Breadcrumbs","user":{"login":"ChazUK","id":768108,"node_id":"MDQ6VXNlcjc2ODEwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/768108?v=4","gravatar_id":"","url":"https://api.github.com/users/ChazUK","html_url":"https://github.com/ChazUK","followers_url":"https://api.github.com/users/ChazUK/followers","following_url":"https://api.github.com/users/ChazUK/following{/other_user}","gists_url":"https://api.github.com/users/ChazUK/gists{/gist_id}","starred_url":"https://api.github.com/users/ChazUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChazUK/subscriptions","organizations_url":"https://api.github.com/users/ChazUK/orgs","repos_url":"https://api.github.com/users/ChazUK/repos","events_url":"https://api.github.com/users/ChazUK/events{/privacy}","received_events_url":"https://api.github.com/users/ChazUK/received_events","type":"User","site_admin":false},"body":"We're going to have to fiddle around with the routes and titles for pages to make sure we aren't receiving any double pages, and the nesting is working correctly","created_at":"2019-07-09T16:38:26Z","updated_at":"2019-07-09T17:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb2cc47ea205f36d22058f4eadf399a2d9d47af4","assignee":{"login":"ChazUK","id":768108,"node_id":"MDQ6VXNlcjc2ODEwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/768108?v=4","gravatar_id":"","url":"https://api.github.com/users/ChazUK","html_url":"https://github.com/ChazUK","followers_url":"https://api.github.com/users/ChazUK/followers","following_url":"https://api.github.com/users/ChazUK/following{/other_user}","gists_url":"https://api.github.com/users/ChazUK/gists{/gist_id}","starred_url":"https://api.github.com/users/ChazUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChazUK/subscriptions","organizations_url":"https://api.github.com/users/ChazUK/orgs","repos_url":"https://api.github.com/users/ChazUK/repos","events_url":"https://api.github.com/users/ChazUK/events{/privacy}","received_events_url":"https://api.github.com/users/ChazUK/received_events","type":"User","site_admin":false},"assignees":[{"login":"ChazUK","id":768108,"node_id":"MDQ6VXNlcjc2ODEwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/768108?v=4","gravatar_id":"","url":"https://api.github.com/users/ChazUK","html_url":"https://github.com/ChazUK","followers_url":"https://api.github.com/users/ChazUK/followers","following_url":"https://api.github.com/users/ChazUK/following{/other_user}","gists_url":"https://api.github.com/users/ChazUK/gists{/gist_id}","starred_url":"https://api.github.com/users/ChazUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChazUK/subscriptions","organizations_url":"https://api.github.com/users/ChazUK/orgs","repos_url":"https://api.github.com/users/ChazUK/repos","events_url":"https://api.github.com/users/ChazUK/events{/privacy}","received_events_url":"https://api.github.com/users/ChazUK/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"alleypa","id":6833330,"node_id":"MDQ6VXNlcjY4MzMzMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/6833330?v=4","gravatar_id":"","url":"https://api.github.com/users/alleypa","html_url":"https://github.com/alleypa","followers_url":"https://api.github.com/users/alleypa/followers","following_url":"https://api.github.com/users/alleypa/following{/other_user}","gists_url":"https://api.github.com/users/alleypa/gists{/gist_id}","starred_url":"https://api.github.com/users/alleypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alleypa/subscriptions","organizations_url":"https://api.github.com/users/alleypa/orgs","repos_url":"https://api.github.com/users/alleypa/repos","events_url":"https://api.github.com/users/alleypa/events{/privacy}","received_events_url":"https://api.github.com/users/alleypa/received_events","type":"User","site_admin":false},{"login":"tgreyuk","id":11680870,"node_id":"MDQ6VXNlcjExNjgwODcw","avatar_url":"https://avatars3.githubusercontent.com/u/11680870?v=4","gravatar_id":"","url":"https://api.github.com/users/tgreyuk","html_url":"https://github.com/tgreyuk","followers_url":"https://api.github.com/users/tgreyuk/followers","following_url":"https://api.github.com/users/tgreyuk/following{/other_user}","gists_url":"https://api.github.com/users/tgreyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/tgreyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgreyuk/subscriptions","organizations_url":"https://api.github.com/users/tgreyuk/orgs","repos_url":"https://api.github.com/users/tgreyuk/repos","events_url":"https://api.github.com/users/tgreyuk/events{/privacy}","received_events_url":"https://api.github.com/users/tgreyuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924/commits","review_comments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924/comments","review_comment_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/924/comments","statuses_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/statuses/7a90404d936858f8205b561ad5b37ea44e16a50b","head":{"label":"NMDSdevopsServiceAdm:feature/breadcrumbs","ref":"feature/breadcrumbs","sha":"7a90404d936858f8205b561ad5b37ea44e16a50b","user":{"login":"NMDSdevopsServiceAdm","id":42393303,"node_id":"MDQ6VXNlcjQyMzkzMzAz","avatar_url":"https://avatars0.githubusercontent.com/u/42393303?v=4","gravatar_id":"","url":"https://api.github.com/users/NMDSdevopsServiceAdm","html_url":"https://github.com/NMDSdevopsServiceAdm","followers_url":"https://api.github.com/users/NMDSdevopsServiceAdm/followers","following_url":"https://api.github.com/users/NMDSdevopsServiceAdm/following{/other_user}","gists_url":"https://api.github.com/users/NMDSdevopsServiceAdm/gists{/gist_id}","starred_url":"https://api.github.com/users/NMDSdevopsServiceAdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NMDSdevopsServiceAdm/subscriptions","organizations_url":"https://api.github.com/users/NMDSdevopsServiceAdm/orgs","repos_url":"https://api.github.com/users/NMDSdevopsServiceAdm/repos","events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/events{/privacy}","received_events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/received_events","type":"User","site_admin":false},"repo":{"id":143274395,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNzQzOTU=","name":"SopraSteria-SFC","full_name":"NMDSdevopsServiceAdm/SopraSteria-SFC","private":false,"owner":{"login":"NMDSdevopsServiceAdm","id":42393303,"node_id":"MDQ6VXNlcjQyMzkzMzAz","avatar_url":"https://avatars0.githubusercontent.com/u/42393303?v=4","gravatar_id":"","url":"https://api.github.com/users/NMDSdevopsServiceAdm","html_url":"https://github.com/NMDSdevopsServiceAdm","followers_url":"https://api.github.com/users/NMDSdevopsServiceAdm/followers","following_url":"https://api.github.com/users/NMDSdevopsServiceAdm/following{/other_user}","gists_url":"https://api.github.com/users/NMDSdevopsServiceAdm/gists{/gist_id}","starred_url":"https://api.github.com/users/NMDSdevopsServiceAdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NMDSdevopsServiceAdm/subscriptions","organizations_url":"https://api.github.com/users/NMDSdevopsServiceAdm/orgs","repos_url":"https://api.github.com/users/NMDSdevopsServiceAdm/repos","events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/events{/privacy}","received_events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC","description":"SFC Development","fork":false,"url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC","forks_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/forks","keys_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/teams","hooks_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/hooks","issue_events_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/events{/number}","events_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/events","assignees_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/assignees{/user}","branches_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/branches{/branch}","tags_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/tags","blobs_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/refs{/sha}","trees_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/statuses/{sha}","languages_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/languages","stargazers_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/stargazers","contributors_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/contributors","subscribers_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/subscribers","subscription_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/subscription","commits_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/commits{/sha}","git_commits_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/commits{/sha}","comments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/comments{/number}","issue_comment_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/comments{/number}","contents_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/contents/{+path}","compare_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/merges","archive_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/downloads","issues_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues{/number}","pulls_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls{/number}","milestones_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/milestones{/number}","notifications_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/labels{/name}","releases_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/releases{/id}","deployments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/deployments","created_at":"2018-08-02T09:41:08Z","updated_at":"2019-05-28T11:20:55Z","pushed_at":"2019-07-09T17:07:56Z","git_url":"git://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC.git","ssh_url":"git@github.com:NMDSdevopsServiceAdm/SopraSteria-SFC.git","clone_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC.git","svn_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC","homepage":"","size":17157,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"NMDSdevopsServiceAdm:develop","ref":"develop","sha":"291d1ee8d11399dc12dc89bb976cf2a322147bfa","user":{"login":"NMDSdevopsServiceAdm","id":42393303,"node_id":"MDQ6VXNlcjQyMzkzMzAz","avatar_url":"https://avatars0.githubusercontent.com/u/42393303?v=4","gravatar_id":"","url":"https://api.github.com/users/NMDSdevopsServiceAdm","html_url":"https://github.com/NMDSdevopsServiceAdm","followers_url":"https://api.github.com/users/NMDSdevopsServiceAdm/followers","following_url":"https://api.github.com/users/NMDSdevopsServiceAdm/following{/other_user}","gists_url":"https://api.github.com/users/NMDSdevopsServiceAdm/gists{/gist_id}","starred_url":"https://api.github.com/users/NMDSdevopsServiceAdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NMDSdevopsServiceAdm/subscriptions","organizations_url":"https://api.github.com/users/NMDSdevopsServiceAdm/orgs","repos_url":"https://api.github.com/users/NMDSdevopsServiceAdm/repos","events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/events{/privacy}","received_events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/received_events","type":"User","site_admin":false},"repo":{"id":143274395,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyNzQzOTU=","name":"SopraSteria-SFC","full_name":"NMDSdevopsServiceAdm/SopraSteria-SFC","private":false,"owner":{"login":"NMDSdevopsServiceAdm","id":42393303,"node_id":"MDQ6VXNlcjQyMzkzMzAz","avatar_url":"https://avatars0.githubusercontent.com/u/42393303?v=4","gravatar_id":"","url":"https://api.github.com/users/NMDSdevopsServiceAdm","html_url":"https://github.com/NMDSdevopsServiceAdm","followers_url":"https://api.github.com/users/NMDSdevopsServiceAdm/followers","following_url":"https://api.github.com/users/NMDSdevopsServiceAdm/following{/other_user}","gists_url":"https://api.github.com/users/NMDSdevopsServiceAdm/gists{/gist_id}","starred_url":"https://api.github.com/users/NMDSdevopsServiceAdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NMDSdevopsServiceAdm/subscriptions","organizations_url":"https://api.github.com/users/NMDSdevopsServiceAdm/orgs","repos_url":"https://api.github.com/users/NMDSdevopsServiceAdm/repos","events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/events{/privacy}","received_events_url":"https://api.github.com/users/NMDSdevopsServiceAdm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC","description":"SFC Development","fork":false,"url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC","forks_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/forks","keys_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/teams","hooks_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/hooks","issue_events_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/events{/number}","events_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/events","assignees_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/assignees{/user}","branches_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/branches{/branch}","tags_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/tags","blobs_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/refs{/sha}","trees_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/statuses/{sha}","languages_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/languages","stargazers_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/stargazers","contributors_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/contributors","subscribers_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/subscribers","subscription_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/subscription","commits_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/commits{/sha}","git_commits_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/git/commits{/sha}","comments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/comments{/number}","issue_comment_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/comments{/number}","contents_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/contents/{+path}","compare_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/merges","archive_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/downloads","issues_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues{/number}","pulls_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls{/number}","milestones_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/milestones{/number}","notifications_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/labels{/name}","releases_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/releases{/id}","deployments_url":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/deployments","created_at":"2018-08-02T09:41:08Z","updated_at":"2019-05-28T11:20:55Z","pushed_at":"2019-07-09T17:07:56Z","git_url":"git://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC.git","ssh_url":"git@github.com:NMDSdevopsServiceAdm/SopraSteria-SFC.git","clone_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC.git","svn_url":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC","homepage":"","size":17157,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924"},"html":{"href":"https://github.com/NMDSdevopsServiceAdm/SopraSteria-SFC/pull/924"},"issue":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/924"},"comments":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/issues/924/comments"},"review_comments":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924/comments"},"review_comment":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/pulls/924/commits"},"statuses":{"href":"https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC/statuses/7a90404d936858f8205b561ad5b37ea44e16a50b"}},"author_association":"COLLABORATOR"}}
|
{
"id": 143274395,
"name": "NMDSdevopsServiceAdm/SopraSteria-SFC",
"url": "https://api.github.com/repos/NMDSdevopsServiceAdm/SopraSteria-SFC"
}
|
{
"id": 1694202,
"login": "omarCreativeDev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1694202?",
"url": "https://api.github.com/users/omarCreativeDev"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-07-09T17:26:18 |
9977500514
|
{"actor":{"display_login":"omarCreativeDev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/comments/253207262","pull_request_review_id":199277068,"id":253207262,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzIwNzI2Mg==","diff_hunk":"@@ -4,6 +4,7 @@\n \n use Tests\\Fixtures\\Post;\n use Tests\\Fixtures\\UncastPost;\n+use Tests\\Fixtures\\CustomCastUuidPost;","path":"tests/Feature/UuidTest.php","position":4,"original_position":4,"commit_id":"a9a8b750bfcea037e9e606fb76ccc91924075d4c","original_commit_id":"14d35ff63c2af9ed37b124402998e8cf3e10edfb","user":{"login":"kentdahl","id":2970005,"node_id":"MDQ6VXNlcjI5NzAwMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2970005?v=4","gravatar_id":"","url":"https://api.github.com/users/kentdahl","html_url":"https://github.com/kentdahl","followers_url":"https://api.github.com/users/kentdahl/followers","following_url":"https://api.github.com/users/kentdahl/following{/other_user}","gists_url":"https://api.github.com/users/kentdahl/gists{/gist_id}","starred_url":"https://api.github.com/users/kentdahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentdahl/subscriptions","organizations_url":"https://api.github.com/users/kentdahl/orgs","repos_url":"https://api.github.com/users/kentdahl/repos","events_url":"https://api.github.com/users/kentdahl/events{/privacy}","received_events_url":"https://api.github.com/users/kentdahl/received_events","type":"User","site_admin":false},"body":"FYI; you do not normally need to make a new PR if you have more commits to push on the same branch. Only if you need to throw away the branch, make big squashing changes or force-push changes is a new PR needed, methinks. (I'm a fan of PR'ing early and pushing up new commits about a dozen times before I'm happy enough to merge, myself.)","created_at":"2019-02-01T21:33:12Z","updated_at":"2019-02-01T21:33:13Z","html_url":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52#discussion_r253207262","pull_request_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/comments/253207262"},"html":{"href":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52#discussion_r253207262"},"pull_request":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52"}},"in_reply_to_id":253198640},"pull_request":{"url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52","id":249733193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5NzMzMTkz","html_url":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52","diff_url":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52.diff","patch_url":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52.patch","issue_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/52","number":52,"state":"closed","locked":false,"title":"Fixed bug when using custom UUID column and casting","user":{"login":"travisaustin","id":1134334,"node_id":"MDQ6VXNlcjExMzQzMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134334?v=4","gravatar_id":"","url":"https://api.github.com/users/travisaustin","html_url":"https://github.com/travisaustin","followers_url":"https://api.github.com/users/travisaustin/followers","following_url":"https://api.github.com/users/travisaustin/following{/other_user}","gists_url":"https://api.github.com/users/travisaustin/gists{/gist_id}","starred_url":"https://api.github.com/users/travisaustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisaustin/subscriptions","organizations_url":"https://api.github.com/users/travisaustin/orgs","repos_url":"https://api.github.com/users/travisaustin/repos","events_url":"https://api.github.com/users/travisaustin/events{/privacy}","received_events_url":"https://api.github.com/users/travisaustin/received_events","type":"User","site_admin":false},"body":"Casting worked if the UUID field was called \"uuid\", but not if using\r\na custom UUID field name.","created_at":"2019-02-01T20:56:47Z","updated_at":"2019-02-01T21:33:13Z","closed_at":"2019-02-01T21:03:49Z","merged_at":null,"merge_commit_sha":"d6e41037bd6094c6435fe26ad12b6392ee716985","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52/commits","review_comments_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52/comments","review_comment_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/52/comments","statuses_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/statuses/a9a8b750bfcea037e9e606fb76ccc91924075d4c","head":{"label":"travisaustin:master","ref":"master","sha":"a9a8b750bfcea037e9e606fb76ccc91924075d4c","user":{"login":"travisaustin","id":1134334,"node_id":"MDQ6VXNlcjExMzQzMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134334?v=4","gravatar_id":"","url":"https://api.github.com/users/travisaustin","html_url":"https://github.com/travisaustin","followers_url":"https://api.github.com/users/travisaustin/followers","following_url":"https://api.github.com/users/travisaustin/following{/other_user}","gists_url":"https://api.github.com/users/travisaustin/gists{/gist_id}","starred_url":"https://api.github.com/users/travisaustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisaustin/subscriptions","organizations_url":"https://api.github.com/users/travisaustin/orgs","repos_url":"https://api.github.com/users/travisaustin/repos","events_url":"https://api.github.com/users/travisaustin/events{/privacy}","received_events_url":"https://api.github.com/users/travisaustin/received_events","type":"User","site_admin":false},"repo":{"id":168757215,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg3NTcyMTU=","name":"laravel-model-uuid","full_name":"travisaustin/laravel-model-uuid","private":false,"owner":{"login":"travisaustin","id":1134334,"node_id":"MDQ6VXNlcjExMzQzMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134334?v=4","gravatar_id":"","url":"https://api.github.com/users/travisaustin","html_url":"https://github.com/travisaustin","followers_url":"https://api.github.com/users/travisaustin/followers","following_url":"https://api.github.com/users/travisaustin/following{/other_user}","gists_url":"https://api.github.com/users/travisaustin/gists{/gist_id}","starred_url":"https://api.github.com/users/travisaustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisaustin/subscriptions","organizations_url":"https://api.github.com/users/travisaustin/orgs","repos_url":"https://api.github.com/users/travisaustin/repos","events_url":"https://api.github.com/users/travisaustin/events{/privacy}","received_events_url":"https://api.github.com/users/travisaustin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/travisaustin/laravel-model-uuid","description":"This package allows you to easily work with UUIDs in your Laravel models","fork":true,"url":"https://api.github.com/repos/travisaustin/laravel-model-uuid","forks_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/forks","keys_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/teams","hooks_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/hooks","issue_events_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/issues/events{/number}","events_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/events","assignees_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/assignees{/user}","branches_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/branches{/branch}","tags_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/tags","blobs_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/git/refs{/sha}","trees_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/statuses/{sha}","languages_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/languages","stargazers_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/stargazers","contributors_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/contributors","subscribers_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/subscribers","subscription_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/subscription","commits_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/commits{/sha}","git_commits_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/git/commits{/sha}","comments_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/comments{/number}","issue_comment_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/issues/comments{/number}","contents_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/contents/{+path}","compare_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/merges","archive_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/downloads","issues_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/issues{/number}","pulls_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/pulls{/number}","milestones_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/milestones{/number}","notifications_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/labels{/name}","releases_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/releases{/id}","deployments_url":"https://api.github.com/repos/travisaustin/laravel-model-uuid/deployments","created_at":"2019-02-01T20:38:00Z","updated_at":"2019-02-01T21:03:13Z","pushed_at":"2019-02-01T21:03:11Z","git_url":"git://github.com/travisaustin/laravel-model-uuid.git","ssh_url":"git@github.com:travisaustin/laravel-model-uuid.git","clone_url":"https://github.com/travisaustin/laravel-model-uuid.git","svn_url":"https://github.com/travisaustin/laravel-model-uuid","homepage":null,"size":59,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"michaeldyrynda:master","ref":"master","sha":"76d7dd98199b0305ab9a6e085b5962382f16f756","user":{"login":"michaeldyrynda","id":558441,"node_id":"MDQ6VXNlcjU1ODQ0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/558441?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeldyrynda","html_url":"https://github.com/michaeldyrynda","followers_url":"https://api.github.com/users/michaeldyrynda/followers","following_url":"https://api.github.com/users/michaeldyrynda/following{/other_user}","gists_url":"https://api.github.com/users/michaeldyrynda/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeldyrynda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeldyrynda/subscriptions","organizations_url":"https://api.github.com/users/michaeldyrynda/orgs","repos_url":"https://api.github.com/users/michaeldyrynda/repos","events_url":"https://api.github.com/users/michaeldyrynda/events{/privacy}","received_events_url":"https://api.github.com/users/michaeldyrynda/received_events","type":"User","site_admin":false},"repo":{"id":86415012,"node_id":"MDEwOlJlcG9zaXRvcnk4NjQxNTAxMg==","name":"laravel-model-uuid","full_name":"michaeldyrynda/laravel-model-uuid","private":false,"owner":{"login":"michaeldyrynda","id":558441,"node_id":"MDQ6VXNlcjU1ODQ0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/558441?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeldyrynda","html_url":"https://github.com/michaeldyrynda","followers_url":"https://api.github.com/users/michaeldyrynda/followers","following_url":"https://api.github.com/users/michaeldyrynda/following{/other_user}","gists_url":"https://api.github.com/users/michaeldyrynda/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeldyrynda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeldyrynda/subscriptions","organizations_url":"https://api.github.com/users/michaeldyrynda/orgs","repos_url":"https://api.github.com/users/michaeldyrynda/repos","events_url":"https://api.github.com/users/michaeldyrynda/events{/privacy}","received_events_url":"https://api.github.com/users/michaeldyrynda/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michaeldyrynda/laravel-model-uuid","description":"This package allows you to easily work with UUIDs in your Laravel models","fork":false,"url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid","forks_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/forks","keys_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/teams","hooks_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/hooks","issue_events_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/events{/number}","events_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/events","assignees_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/assignees{/user}","branches_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/branches{/branch}","tags_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/tags","blobs_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/statuses/{sha}","languages_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/languages","stargazers_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/stargazers","contributors_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/contributors","subscribers_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/subscribers","subscription_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/subscription","commits_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/contents/{+path}","compare_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/merges","archive_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/downloads","issues_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues{/number}","pulls_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls{/number}","milestones_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/milestones{/number}","notifications_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/labels{/name}","releases_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/releases{/id}","deployments_url":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/deployments","created_at":"2017-03-28T04:31:38Z","updated_at":"2019-01-30T16:23:15Z","pushed_at":"2019-02-01T21:04:57Z","git_url":"git://github.com/michaeldyrynda/laravel-model-uuid.git","ssh_url":"git@github.com:michaeldyrynda/laravel-model-uuid.git","clone_url":"https://github.com/michaeldyrynda/laravel-model-uuid.git","svn_url":"https://github.com/michaeldyrynda/laravel-model-uuid","homepage":null,"size":59,"stargazers_count":141,"watchers_count":141,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":14,"open_issues":4,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52"},"html":{"href":"https://github.com/michaeldyrynda/laravel-model-uuid/pull/52"},"issue":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/52"},"comments":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/michaeldyrynda/laravel-model-uuid/statuses/a9a8b750bfcea037e9e606fb76ccc91924075d4c"}},"author_association":"NONE"}}
|
{
"id": 86415012,
"name": "michaeldyrynda/laravel-model-uuid",
"url": "https://api.github.com/repos/michaeldyrynda/laravel-model-uuid"
}
|
{
"id": 2970005,
"login": "kentdahl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2970005?",
"url": "https://api.github.com/users/kentdahl"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-02-01T21:33:12 |
8995597405
|
{"actor":{"display_login":"kentdahl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/comments/352292368","pull_request_review_id":324898522,"id":352292368,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MjI5MjM2OA==","diff_hunk":"@@ -3,22 +3,63 @@ import {\n Route,\n Switch\n } from \"react-router-dom\";\n+import io from \"socket.io-client\";\n+import { connect } from 'react-redux';\n+import { createStructuredSelector } from 'reselect';\n \n import \"./App.scss\"\n import SocketExample from \"./socket_example\"\n import LandingPage from \"./landingpage/landingpage\"\n import SeatReservationPage from './pages/seat-reservation/seat-reservation.component';\n import HeaderMain from './components/header-main/header-main.component';\n \n-export default function App() {\n- return (\n- <div>\n- <HeaderMain/>\n- <Switch>\n- <Route exact path='/' component={LandingPage}/>\n- <Route path='/reservation' component={SeatReservationPage}/>\n- <Route path='/socket' component={SocketExample}/>\n- </Switch>\n- </div>\n- );\n-}\n\\ No newline at end of file\n+\n+import { setSocket } from './redux/user/user.actions';\n+import { setStateSeat } from './redux/stage/stage.actions';\n+import { selectCurrentUser } from './redux/user/user.selectors';\n+\n+let socket;\n+\n+export class App extends React.Component{\n+ constructor(props){\n+ super(props);\n+ socket = io.connect(\"http://52.70.18.213\");\n+ socket.emit('conectado',{message:'Ha funcionado Perron'});","path":"src/App.js","position":null,"original_position":38,"commit_id":"d51f831d6e0733d9bfbc510810406704b652e5b5","original_commit_id":"f0aa11285e6087f58701d549b6366d1761088dac","user":{"login":"skrillfer","id":20976373,"node_id":"MDQ6VXNlcjIwOTc2Mzcz","avatar_url":"https://avatars2.githubusercontent.com/u/20976373?v=4","gravatar_id":"","url":"https://api.github.com/users/skrillfer","html_url":"https://github.com/skrillfer","followers_url":"https://api.github.com/users/skrillfer/followers","following_url":"https://api.github.com/users/skrillfer/following{/other_user}","gists_url":"https://api.github.com/users/skrillfer/gists{/gist_id}","starred_url":"https://api.github.com/users/skrillfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrillfer/subscriptions","organizations_url":"https://api.github.com/users/skrillfer/orgs","repos_url":"https://api.github.com/users/skrillfer/repos","events_url":"https://api.github.com/users/skrillfer/events{/privacy}","received_events_url":"https://api.github.com/users/skrillfer/received_events","type":"User","site_admin":false},"body":"commit d51f831d6e0733d9bfbc510810406704b652e5b5","created_at":"2019-11-30T16:17:03Z","updated_at":"2019-11-30T16:17:03Z","html_url":"https://github.com/bragonya/TicketsWeb/pull/4#discussion_r352292368","pull_request_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/comments/352292368"},"html":{"href":"https://github.com/bragonya/TicketsWeb/pull/4#discussion_r352292368"},"pull_request":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4"}},"in_reply_to_id":352289417},"pull_request":{"url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4","id":347229904,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjI5OTA0","html_url":"https://github.com/bragonya/TicketsWeb/pull/4","diff_url":"https://github.com/bragonya/TicketsWeb/pull/4.diff","patch_url":"https://github.com/bragonya/TicketsWeb/pull/4.patch","issue_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/4","number":4,"state":"open","locked":false,"title":"Feature/selectingseats","user":{"login":"skrillfer","id":20976373,"node_id":"MDQ6VXNlcjIwOTc2Mzcz","avatar_url":"https://avatars2.githubusercontent.com/u/20976373?v=4","gravatar_id":"","url":"https://api.github.com/users/skrillfer","html_url":"https://github.com/skrillfer","followers_url":"https://api.github.com/users/skrillfer/followers","following_url":"https://api.github.com/users/skrillfer/following{/other_user}","gists_url":"https://api.github.com/users/skrillfer/gists{/gist_id}","starred_url":"https://api.github.com/users/skrillfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrillfer/subscriptions","organizations_url":"https://api.github.com/users/skrillfer/orgs","repos_url":"https://api.github.com/users/skrillfer/repos","events_url":"https://api.github.com/users/skrillfer/events{/privacy}","received_events_url":"https://api.github.com/users/skrillfer/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-30T14:43:14Z","updated_at":"2019-11-30T16:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c1682b4577f774c71b678eb37527752909653dea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4/commits","review_comments_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4/comments","review_comment_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/4/comments","statuses_url":"https://api.github.com/repos/bragonya/TicketsWeb/statuses/d51f831d6e0733d9bfbc510810406704b652e5b5","head":{"label":"bragonya:feature/selectingseats","ref":"feature/selectingseats","sha":"d51f831d6e0733d9bfbc510810406704b652e5b5","user":{"login":"bragonya","id":11150627,"node_id":"MDQ6VXNlcjExMTUwNjI3","avatar_url":"https://avatars3.githubusercontent.com/u/11150627?v=4","gravatar_id":"","url":"https://api.github.com/users/bragonya","html_url":"https://github.com/bragonya","followers_url":"https://api.github.com/users/bragonya/followers","following_url":"https://api.github.com/users/bragonya/following{/other_user}","gists_url":"https://api.github.com/users/bragonya/gists{/gist_id}","starred_url":"https://api.github.com/users/bragonya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bragonya/subscriptions","organizations_url":"https://api.github.com/users/bragonya/orgs","repos_url":"https://api.github.com/users/bragonya/repos","events_url":"https://api.github.com/users/bragonya/events{/privacy}","received_events_url":"https://api.github.com/users/bragonya/received_events","type":"User","site_admin":false},"repo":{"id":223660910,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM2NjA5MTA=","name":"TicketsWeb","full_name":"bragonya/TicketsWeb","private":false,"owner":{"login":"bragonya","id":11150627,"node_id":"MDQ6VXNlcjExMTUwNjI3","avatar_url":"https://avatars3.githubusercontent.com/u/11150627?v=4","gravatar_id":"","url":"https://api.github.com/users/bragonya","html_url":"https://github.com/bragonya","followers_url":"https://api.github.com/users/bragonya/followers","following_url":"https://api.github.com/users/bragonya/following{/other_user}","gists_url":"https://api.github.com/users/bragonya/gists{/gist_id}","starred_url":"https://api.github.com/users/bragonya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bragonya/subscriptions","organizations_url":"https://api.github.com/users/bragonya/orgs","repos_url":"https://api.github.com/users/bragonya/repos","events_url":"https://api.github.com/users/bragonya/events{/privacy}","received_events_url":"https://api.github.com/users/bragonya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bragonya/TicketsWeb","description":null,"fork":false,"url":"https://api.github.com/repos/bragonya/TicketsWeb","forks_url":"https://api.github.com/repos/bragonya/TicketsWeb/forks","keys_url":"https://api.github.com/repos/bragonya/TicketsWeb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bragonya/TicketsWeb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bragonya/TicketsWeb/teams","hooks_url":"https://api.github.com/repos/bragonya/TicketsWeb/hooks","issue_events_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/events{/number}","events_url":"https://api.github.com/repos/bragonya/TicketsWeb/events","assignees_url":"https://api.github.com/repos/bragonya/TicketsWeb/assignees{/user}","branches_url":"https://api.github.com/repos/bragonya/TicketsWeb/branches{/branch}","tags_url":"https://api.github.com/repos/bragonya/TicketsWeb/tags","blobs_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bragonya/TicketsWeb/statuses/{sha}","languages_url":"https://api.github.com/repos/bragonya/TicketsWeb/languages","stargazers_url":"https://api.github.com/repos/bragonya/TicketsWeb/stargazers","contributors_url":"https://api.github.com/repos/bragonya/TicketsWeb/contributors","subscribers_url":"https://api.github.com/repos/bragonya/TicketsWeb/subscribers","subscription_url":"https://api.github.com/repos/bragonya/TicketsWeb/subscription","commits_url":"https://api.github.com/repos/bragonya/TicketsWeb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bragonya/TicketsWeb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bragonya/TicketsWeb/contents/{+path}","compare_url":"https://api.github.com/repos/bragonya/TicketsWeb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bragonya/TicketsWeb/merges","archive_url":"https://api.github.com/repos/bragonya/TicketsWeb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bragonya/TicketsWeb/downloads","issues_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues{/number}","pulls_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls{/number}","milestones_url":"https://api.github.com/repos/bragonya/TicketsWeb/milestones{/number}","notifications_url":"https://api.github.com/repos/bragonya/TicketsWeb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bragonya/TicketsWeb/labels{/name}","releases_url":"https://api.github.com/repos/bragonya/TicketsWeb/releases{/id}","deployments_url":"https://api.github.com/repos/bragonya/TicketsWeb/deployments","created_at":"2019-11-23T22:23:30Z","updated_at":"2019-11-28T22:37:02Z","pushed_at":"2019-11-30T16:16:30Z","git_url":"git://github.com/bragonya/TicketsWeb.git","ssh_url":"git@github.com:bragonya/TicketsWeb.git","clone_url":"https://github.com/bragonya/TicketsWeb.git","svn_url":"https://github.com/bragonya/TicketsWeb","homepage":null,"size":6487,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bragonya:master","ref":"master","sha":"df926b027affe3bad21d7efb4ea4d46c2abde123","user":{"login":"bragonya","id":11150627,"node_id":"MDQ6VXNlcjExMTUwNjI3","avatar_url":"https://avatars3.githubusercontent.com/u/11150627?v=4","gravatar_id":"","url":"https://api.github.com/users/bragonya","html_url":"https://github.com/bragonya","followers_url":"https://api.github.com/users/bragonya/followers","following_url":"https://api.github.com/users/bragonya/following{/other_user}","gists_url":"https://api.github.com/users/bragonya/gists{/gist_id}","starred_url":"https://api.github.com/users/bragonya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bragonya/subscriptions","organizations_url":"https://api.github.com/users/bragonya/orgs","repos_url":"https://api.github.com/users/bragonya/repos","events_url":"https://api.github.com/users/bragonya/events{/privacy}","received_events_url":"https://api.github.com/users/bragonya/received_events","type":"User","site_admin":false},"repo":{"id":223660910,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM2NjA5MTA=","name":"TicketsWeb","full_name":"bragonya/TicketsWeb","private":false,"owner":{"login":"bragonya","id":11150627,"node_id":"MDQ6VXNlcjExMTUwNjI3","avatar_url":"https://avatars3.githubusercontent.com/u/11150627?v=4","gravatar_id":"","url":"https://api.github.com/users/bragonya","html_url":"https://github.com/bragonya","followers_url":"https://api.github.com/users/bragonya/followers","following_url":"https://api.github.com/users/bragonya/following{/other_user}","gists_url":"https://api.github.com/users/bragonya/gists{/gist_id}","starred_url":"https://api.github.com/users/bragonya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bragonya/subscriptions","organizations_url":"https://api.github.com/users/bragonya/orgs","repos_url":"https://api.github.com/users/bragonya/repos","events_url":"https://api.github.com/users/bragonya/events{/privacy}","received_events_url":"https://api.github.com/users/bragonya/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bragonya/TicketsWeb","description":null,"fork":false,"url":"https://api.github.com/repos/bragonya/TicketsWeb","forks_url":"https://api.github.com/repos/bragonya/TicketsWeb/forks","keys_url":"https://api.github.com/repos/bragonya/TicketsWeb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bragonya/TicketsWeb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bragonya/TicketsWeb/teams","hooks_url":"https://api.github.com/repos/bragonya/TicketsWeb/hooks","issue_events_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/events{/number}","events_url":"https://api.github.com/repos/bragonya/TicketsWeb/events","assignees_url":"https://api.github.com/repos/bragonya/TicketsWeb/assignees{/user}","branches_url":"https://api.github.com/repos/bragonya/TicketsWeb/branches{/branch}","tags_url":"https://api.github.com/repos/bragonya/TicketsWeb/tags","blobs_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bragonya/TicketsWeb/statuses/{sha}","languages_url":"https://api.github.com/repos/bragonya/TicketsWeb/languages","stargazers_url":"https://api.github.com/repos/bragonya/TicketsWeb/stargazers","contributors_url":"https://api.github.com/repos/bragonya/TicketsWeb/contributors","subscribers_url":"https://api.github.com/repos/bragonya/TicketsWeb/subscribers","subscription_url":"https://api.github.com/repos/bragonya/TicketsWeb/subscription","commits_url":"https://api.github.com/repos/bragonya/TicketsWeb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bragonya/TicketsWeb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bragonya/TicketsWeb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bragonya/TicketsWeb/contents/{+path}","compare_url":"https://api.github.com/repos/bragonya/TicketsWeb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bragonya/TicketsWeb/merges","archive_url":"https://api.github.com/repos/bragonya/TicketsWeb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bragonya/TicketsWeb/downloads","issues_url":"https://api.github.com/repos/bragonya/TicketsWeb/issues{/number}","pulls_url":"https://api.github.com/repos/bragonya/TicketsWeb/pulls{/number}","milestones_url":"https://api.github.com/repos/bragonya/TicketsWeb/milestones{/number}","notifications_url":"https://api.github.com/repos/bragonya/TicketsWeb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bragonya/TicketsWeb/labels{/name}","releases_url":"https://api.github.com/repos/bragonya/TicketsWeb/releases{/id}","deployments_url":"https://api.github.com/repos/bragonya/TicketsWeb/deployments","created_at":"2019-11-23T22:23:30Z","updated_at":"2019-11-28T22:37:02Z","pushed_at":"2019-11-30T16:16:30Z","git_url":"git://github.com/bragonya/TicketsWeb.git","ssh_url":"git@github.com:bragonya/TicketsWeb.git","clone_url":"https://github.com/bragonya/TicketsWeb.git","svn_url":"https://github.com/bragonya/TicketsWeb","homepage":null,"size":6487,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4"},"html":{"href":"https://github.com/bragonya/TicketsWeb/pull/4"},"issue":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/issues/4"},"comments":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/bragonya/TicketsWeb/statuses/d51f831d6e0733d9bfbc510810406704b652e5b5"}},"author_association":"COLLABORATOR"}}
|
{
"id": 223660910,
"name": "bragonya/TicketsWeb",
"url": "https://api.github.com/repos/bragonya/TicketsWeb"
}
|
{
"id": 20976373,
"login": "skrillfer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20976373?",
"url": "https://api.github.com/users/skrillfer"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-30T16:17:03 |
10980697216
|
{"actor":{"display_login":"skrillfer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Druschyts/first-repo/pulls/comments/335471321","pull_request_review_id":302569958,"id":335471321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTQ3MTMyMQ==","diff_hunk":"@@ -0,0 +1,12 @@\n+\n+public class Task6 {\n+ public static void main(String[] args) {\n+ int count = 5;\n+ int sum = 1;","path":"src/Task6.java","position":5,"original_position":5,"commit_id":"b827ffc6fc645e824f9ea63d62fbd0738b8867a8","original_commit_id":"b827ffc6fc645e824f9ea63d62fbd0738b8867a8","user":{"login":"szakrevskaya","id":11570305,"node_id":"MDQ6VXNlcjExNTcwMzA1","avatar_url":"https://avatars3.githubusercontent.com/u/11570305?v=4","gravatar_id":"","url":"https://api.github.com/users/szakrevskaya","html_url":"https://github.com/szakrevskaya","followers_url":"https://api.github.com/users/szakrevskaya/followers","following_url":"https://api.github.com/users/szakrevskaya/following{/other_user}","gists_url":"https://api.github.com/users/szakrevskaya/gists{/gist_id}","starred_url":"https://api.github.com/users/szakrevskaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szakrevskaya/subscriptions","organizations_url":"https://api.github.com/users/szakrevskaya/orgs","repos_url":"https://api.github.com/users/szakrevskaya/repos","events_url":"https://api.github.com/users/szakrevskaya/events{/privacy}","received_events_url":"https://api.github.com/users/szakrevskaya/received_events","type":"User","site_admin":false},"body":"Почему переменная называется sum, если по факту ты выполняешь умножение?","created_at":"2019-10-16T13:23:33Z","updated_at":"2019-10-16T13:23:33Z","html_url":"https://github.com/Druschyts/first-repo/pull/3#discussion_r335471321","pull_request_url":"https://api.github.com/repos/Druschyts/first-repo/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/comments/335471321"},"html":{"href":"https://github.com/Druschyts/first-repo/pull/3#discussion_r335471321"},"pull_request":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Druschyts/first-repo/pulls/3","id":328603296,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4NjAzMjk2","html_url":"https://github.com/Druschyts/first-repo/pull/3","diff_url":"https://github.com/Druschyts/first-repo/pull/3.diff","patch_url":"https://github.com/Druschyts/first-repo/pull/3.patch","issue_url":"https://api.github.com/repos/Druschyts/first-repo/issues/3","number":3,"state":"open","locked":false,"title":"final_commit","user":{"login":"Druschyts","id":56216346,"node_id":"MDQ6VXNlcjU2MjE2MzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/56216346?v=4","gravatar_id":"","url":"https://api.github.com/users/Druschyts","html_url":"https://github.com/Druschyts","followers_url":"https://api.github.com/users/Druschyts/followers","following_url":"https://api.github.com/users/Druschyts/following{/other_user}","gists_url":"https://api.github.com/users/Druschyts/gists{/gist_id}","starred_url":"https://api.github.com/users/Druschyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druschyts/subscriptions","organizations_url":"https://api.github.com/users/Druschyts/orgs","repos_url":"https://api.github.com/users/Druschyts/repos","events_url":"https://api.github.com/users/Druschyts/events{/privacy}","received_events_url":"https://api.github.com/users/Druschyts/received_events","type":"User","site_admin":false},"body":"HomeWork","created_at":"2019-10-16T07:02:26Z","updated_at":"2019-10-16T13:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24c4fff987c062950f0561e126bae12663b5745c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Druschyts/first-repo/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Druschyts/first-repo/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Druschyts/first-repo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Druschyts/first-repo/issues/3/comments","statuses_url":"https://api.github.com/repos/Druschyts/first-repo/statuses/b827ffc6fc645e824f9ea63d62fbd0738b8867a8","head":{"label":"Druschyts:HomeWork_18.10.2019","ref":"HomeWork_18.10.2019","sha":"b827ffc6fc645e824f9ea63d62fbd0738b8867a8","user":{"login":"Druschyts","id":56216346,"node_id":"MDQ6VXNlcjU2MjE2MzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/56216346?v=4","gravatar_id":"","url":"https://api.github.com/users/Druschyts","html_url":"https://github.com/Druschyts","followers_url":"https://api.github.com/users/Druschyts/followers","following_url":"https://api.github.com/users/Druschyts/following{/other_user}","gists_url":"https://api.github.com/users/Druschyts/gists{/gist_id}","starred_url":"https://api.github.com/users/Druschyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druschyts/subscriptions","organizations_url":"https://api.github.com/users/Druschyts/orgs","repos_url":"https://api.github.com/users/Druschyts/repos","events_url":"https://api.github.com/users/Druschyts/events{/privacy}","received_events_url":"https://api.github.com/users/Druschyts/received_events","type":"User","site_admin":false},"repo":{"id":213154895,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMxNTQ4OTU=","name":"first-repo","full_name":"Druschyts/first-repo","private":false,"owner":{"login":"Druschyts","id":56216346,"node_id":"MDQ6VXNlcjU2MjE2MzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/56216346?v=4","gravatar_id":"","url":"https://api.github.com/users/Druschyts","html_url":"https://github.com/Druschyts","followers_url":"https://api.github.com/users/Druschyts/followers","following_url":"https://api.github.com/users/Druschyts/following{/other_user}","gists_url":"https://api.github.com/users/Druschyts/gists{/gist_id}","starred_url":"https://api.github.com/users/Druschyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druschyts/subscriptions","organizations_url":"https://api.github.com/users/Druschyts/orgs","repos_url":"https://api.github.com/users/Druschyts/repos","events_url":"https://api.github.com/users/Druschyts/events{/privacy}","received_events_url":"https://api.github.com/users/Druschyts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Druschyts/first-repo","description":"First Git project","fork":false,"url":"https://api.github.com/repos/Druschyts/first-repo","forks_url":"https://api.github.com/repos/Druschyts/first-repo/forks","keys_url":"https://api.github.com/repos/Druschyts/first-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Druschyts/first-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Druschyts/first-repo/teams","hooks_url":"https://api.github.com/repos/Druschyts/first-repo/hooks","issue_events_url":"https://api.github.com/repos/Druschyts/first-repo/issues/events{/number}","events_url":"https://api.github.com/repos/Druschyts/first-repo/events","assignees_url":"https://api.github.com/repos/Druschyts/first-repo/assignees{/user}","branches_url":"https://api.github.com/repos/Druschyts/first-repo/branches{/branch}","tags_url":"https://api.github.com/repos/Druschyts/first-repo/tags","blobs_url":"https://api.github.com/repos/Druschyts/first-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Druschyts/first-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Druschyts/first-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Druschyts/first-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Druschyts/first-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/Druschyts/first-repo/languages","stargazers_url":"https://api.github.com/repos/Druschyts/first-repo/stargazers","contributors_url":"https://api.github.com/repos/Druschyts/first-repo/contributors","subscribers_url":"https://api.github.com/repos/Druschyts/first-repo/subscribers","subscription_url":"https://api.github.com/repos/Druschyts/first-repo/subscription","commits_url":"https://api.github.com/repos/Druschyts/first-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Druschyts/first-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Druschyts/first-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Druschyts/first-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Druschyts/first-repo/contents/{+path}","compare_url":"https://api.github.com/repos/Druschyts/first-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Druschyts/first-repo/merges","archive_url":"https://api.github.com/repos/Druschyts/first-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Druschyts/first-repo/downloads","issues_url":"https://api.github.com/repos/Druschyts/first-repo/issues{/number}","pulls_url":"https://api.github.com/repos/Druschyts/first-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/Druschyts/first-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/Druschyts/first-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Druschyts/first-repo/labels{/name}","releases_url":"https://api.github.com/repos/Druschyts/first-repo/releases{/id}","deployments_url":"https://api.github.com/repos/Druschyts/first-repo/deployments","created_at":"2019-10-06T11:18:57Z","updated_at":"2019-10-10T15:52:18Z","pushed_at":"2019-10-16T07:02:26Z","git_url":"git://github.com/Druschyts/first-repo.git","ssh_url":"git@github.com:Druschyts/first-repo.git","clone_url":"https://github.com/Druschyts/first-repo.git","svn_url":"https://github.com/Druschyts/first-repo","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Druschyts:master","ref":"master","sha":"56cc975b63b78ac70a4a0db06d3b24baf8cd6ada","user":{"login":"Druschyts","id":56216346,"node_id":"MDQ6VXNlcjU2MjE2MzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/56216346?v=4","gravatar_id":"","url":"https://api.github.com/users/Druschyts","html_url":"https://github.com/Druschyts","followers_url":"https://api.github.com/users/Druschyts/followers","following_url":"https://api.github.com/users/Druschyts/following{/other_user}","gists_url":"https://api.github.com/users/Druschyts/gists{/gist_id}","starred_url":"https://api.github.com/users/Druschyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druschyts/subscriptions","organizations_url":"https://api.github.com/users/Druschyts/orgs","repos_url":"https://api.github.com/users/Druschyts/repos","events_url":"https://api.github.com/users/Druschyts/events{/privacy}","received_events_url":"https://api.github.com/users/Druschyts/received_events","type":"User","site_admin":false},"repo":{"id":213154895,"node_id":"MDEwOlJlcG9zaXRvcnkyMTMxNTQ4OTU=","name":"first-repo","full_name":"Druschyts/first-repo","private":false,"owner":{"login":"Druschyts","id":56216346,"node_id":"MDQ6VXNlcjU2MjE2MzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/56216346?v=4","gravatar_id":"","url":"https://api.github.com/users/Druschyts","html_url":"https://github.com/Druschyts","followers_url":"https://api.github.com/users/Druschyts/followers","following_url":"https://api.github.com/users/Druschyts/following{/other_user}","gists_url":"https://api.github.com/users/Druschyts/gists{/gist_id}","starred_url":"https://api.github.com/users/Druschyts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Druschyts/subscriptions","organizations_url":"https://api.github.com/users/Druschyts/orgs","repos_url":"https://api.github.com/users/Druschyts/repos","events_url":"https://api.github.com/users/Druschyts/events{/privacy}","received_events_url":"https://api.github.com/users/Druschyts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Druschyts/first-repo","description":"First Git project","fork":false,"url":"https://api.github.com/repos/Druschyts/first-repo","forks_url":"https://api.github.com/repos/Druschyts/first-repo/forks","keys_url":"https://api.github.com/repos/Druschyts/first-repo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Druschyts/first-repo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Druschyts/first-repo/teams","hooks_url":"https://api.github.com/repos/Druschyts/first-repo/hooks","issue_events_url":"https://api.github.com/repos/Druschyts/first-repo/issues/events{/number}","events_url":"https://api.github.com/repos/Druschyts/first-repo/events","assignees_url":"https://api.github.com/repos/Druschyts/first-repo/assignees{/user}","branches_url":"https://api.github.com/repos/Druschyts/first-repo/branches{/branch}","tags_url":"https://api.github.com/repos/Druschyts/first-repo/tags","blobs_url":"https://api.github.com/repos/Druschyts/first-repo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Druschyts/first-repo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Druschyts/first-repo/git/refs{/sha}","trees_url":"https://api.github.com/repos/Druschyts/first-repo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Druschyts/first-repo/statuses/{sha}","languages_url":"https://api.github.com/repos/Druschyts/first-repo/languages","stargazers_url":"https://api.github.com/repos/Druschyts/first-repo/stargazers","contributors_url":"https://api.github.com/repos/Druschyts/first-repo/contributors","subscribers_url":"https://api.github.com/repos/Druschyts/first-repo/subscribers","subscription_url":"https://api.github.com/repos/Druschyts/first-repo/subscription","commits_url":"https://api.github.com/repos/Druschyts/first-repo/commits{/sha}","git_commits_url":"https://api.github.com/repos/Druschyts/first-repo/git/commits{/sha}","comments_url":"https://api.github.com/repos/Druschyts/first-repo/comments{/number}","issue_comment_url":"https://api.github.com/repos/Druschyts/first-repo/issues/comments{/number}","contents_url":"https://api.github.com/repos/Druschyts/first-repo/contents/{+path}","compare_url":"https://api.github.com/repos/Druschyts/first-repo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Druschyts/first-repo/merges","archive_url":"https://api.github.com/repos/Druschyts/first-repo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Druschyts/first-repo/downloads","issues_url":"https://api.github.com/repos/Druschyts/first-repo/issues{/number}","pulls_url":"https://api.github.com/repos/Druschyts/first-repo/pulls{/number}","milestones_url":"https://api.github.com/repos/Druschyts/first-repo/milestones{/number}","notifications_url":"https://api.github.com/repos/Druschyts/first-repo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Druschyts/first-repo/labels{/name}","releases_url":"https://api.github.com/repos/Druschyts/first-repo/releases{/id}","deployments_url":"https://api.github.com/repos/Druschyts/first-repo/deployments","created_at":"2019-10-06T11:18:57Z","updated_at":"2019-10-10T15:52:18Z","pushed_at":"2019-10-16T07:02:26Z","git_url":"git://github.com/Druschyts/first-repo.git","ssh_url":"git@github.com:Druschyts/first-repo.git","clone_url":"https://github.com/Druschyts/first-repo.git","svn_url":"https://github.com/Druschyts/first-repo","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/3"},"html":{"href":"https://github.com/Druschyts/first-repo/pull/3"},"issue":{"href":"https://api.github.com/repos/Druschyts/first-repo/issues/3"},"comments":{"href":"https://api.github.com/repos/Druschyts/first-repo/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Druschyts/first-repo/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Druschyts/first-repo/statuses/b827ffc6fc645e824f9ea63d62fbd0738b8867a8"}},"author_association":"OWNER"}}
|
{
"id": 213154895,
"name": "Druschyts/first-repo",
"url": "https://api.github.com/repos/Druschyts/first-repo"
}
|
{
"id": 11570305,
"login": "szakrevskaya",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11570305?",
"url": "https://api.github.com/users/szakrevskaya"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-10-16T13:23:33 |
10643298340
|
{"actor":{"display_login":"szakrevskaya"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/comments/252901164","pull_request_review_id":198887751,"id":252901164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MjkwMTE2NA==","diff_hunk":"@@ -21,16 +21,16 @@\n }\n ],\n \"menu\": {\n- \"title\": \"betterTypeTool\",\n+ \"title\": \"betterTypePanel\",\n \"items\": [\n \"my-command-identifier\"\n ],","path":"bettertypetool.sketchplugin/Contents/Sketch/manifest.json","position":17,"original_position":17,"commit_id":"bfcb6adfdd9d56cb04aad3a6192279405f4a4b7a","original_commit_id":"bfcb6adfdd9d56cb04aad3a6192279405f4a4b7a","user":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"body":"test","created_at":"2019-02-01T00:55:31Z","updated_at":"2019-02-01T00:55:31Z","html_url":"https://github.com/KevinGutowski/betterTypePanel/pull/7#discussion_r252901164","pull_request_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/comments/252901164"},"html":{"href":"https://github.com/KevinGutowski/betterTypePanel/pull/7#discussion_r252901164"},"pull_request":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7","id":246847449,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ2ODQ3NDQ5","html_url":"https://github.com/KevinGutowski/betterTypePanel/pull/7","diff_url":"https://github.com/KevinGutowski/betterTypePanel/pull/7.diff","patch_url":"https://github.com/KevinGutowski/betterTypePanel/pull/7.patch","issue_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/7","number":7,"state":"closed","locked":false,"title":"Kevin/fix naming","user":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"body":"Fixes #6 ","created_at":"2019-01-23T05:56:51Z","updated_at":"2019-02-01T00:55:31Z","closed_at":"2019-01-23T05:58:50Z","merged_at":"2019-01-23T05:58:49Z","merge_commit_sha":"c90fc757f442003fb6f9f64d19b76caa71c9db54","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7/commits","review_comments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7/comments","review_comment_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/7/comments","statuses_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/statuses/bfcb6adfdd9d56cb04aad3a6192279405f4a4b7a","head":{"label":"KevinGutowski:kevin/fix_naming","ref":"kevin/fix_naming","sha":"bfcb6adfdd9d56cb04aad3a6192279405f4a4b7a","user":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"repo":{"id":164357049,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQzNTcwNDk=","name":"betterTypePanel","full_name":"KevinGutowski/betterTypePanel","private":false,"owner":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KevinGutowski/betterTypePanel","description":"A sketch plugin to help manage common OpenType properties","fork":false,"url":"https://api.github.com/repos/KevinGutowski/betterTypePanel","forks_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/forks","keys_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/teams","hooks_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/hooks","issue_events_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/events{/number}","events_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/events","assignees_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/assignees{/user}","branches_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/branches{/branch}","tags_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/tags","blobs_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/languages","stargazers_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/stargazers","contributors_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/contributors","subscribers_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/subscribers","subscription_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/subscription","commits_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/contents/{+path}","compare_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/merges","archive_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/downloads","issues_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues{/number}","pulls_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/labels{/name}","releases_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/releases{/id}","deployments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/deployments","created_at":"2019-01-07T00:13:13Z","updated_at":"2019-01-30T14:21:40Z","pushed_at":"2019-01-27T05:10:51Z","git_url":"git://github.com/KevinGutowski/betterTypePanel.git","ssh_url":"git@github.com:KevinGutowski/betterTypePanel.git","clone_url":"https://github.com/KevinGutowski/betterTypePanel.git","svn_url":"https://github.com/KevinGutowski/betterTypePanel","homepage":"","size":482,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"KevinGutowski:master","ref":"master","sha":"c205053abf2e9f69a5b77f92111d5f90d6a49674","user":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"repo":{"id":164357049,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQzNTcwNDk=","name":"betterTypePanel","full_name":"KevinGutowski/betterTypePanel","private":false,"owner":{"login":"KevinGutowski","id":4199296,"node_id":"MDQ6VXNlcjQxOTkyOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/4199296?v=4","gravatar_id":"","url":"https://api.github.com/users/KevinGutowski","html_url":"https://github.com/KevinGutowski","followers_url":"https://api.github.com/users/KevinGutowski/followers","following_url":"https://api.github.com/users/KevinGutowski/following{/other_user}","gists_url":"https://api.github.com/users/KevinGutowski/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGutowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGutowski/subscriptions","organizations_url":"https://api.github.com/users/KevinGutowski/orgs","repos_url":"https://api.github.com/users/KevinGutowski/repos","events_url":"https://api.github.com/users/KevinGutowski/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGutowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KevinGutowski/betterTypePanel","description":"A sketch plugin to help manage common OpenType properties","fork":false,"url":"https://api.github.com/repos/KevinGutowski/betterTypePanel","forks_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/forks","keys_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/teams","hooks_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/hooks","issue_events_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/events{/number}","events_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/events","assignees_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/assignees{/user}","branches_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/branches{/branch}","tags_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/tags","blobs_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/refs{/sha}","trees_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/statuses/{sha}","languages_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/languages","stargazers_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/stargazers","contributors_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/contributors","subscribers_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/subscribers","subscription_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/subscription","commits_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/commits{/sha}","git_commits_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/git/commits{/sha}","comments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/comments{/number}","issue_comment_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/comments{/number}","contents_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/contents/{+path}","compare_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/merges","archive_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/downloads","issues_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues{/number}","pulls_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls{/number}","milestones_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/milestones{/number}","notifications_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/labels{/name}","releases_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/releases{/id}","deployments_url":"https://api.github.com/repos/KevinGutowski/betterTypePanel/deployments","created_at":"2019-01-07T00:13:13Z","updated_at":"2019-01-30T14:21:40Z","pushed_at":"2019-01-27T05:10:51Z","git_url":"git://github.com/KevinGutowski/betterTypePanel.git","ssh_url":"git@github.com:KevinGutowski/betterTypePanel.git","clone_url":"https://github.com/KevinGutowski/betterTypePanel.git","svn_url":"https://github.com/KevinGutowski/betterTypePanel","homepage":"","size":482,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7"},"html":{"href":"https://github.com/KevinGutowski/betterTypePanel/pull/7"},"issue":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/7"},"comments":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/KevinGutowski/betterTypePanel/statuses/bfcb6adfdd9d56cb04aad3a6192279405f4a4b7a"}},"author_association":"OWNER"}}
|
{
"id": 164357049,
"name": "KevinGutowski/betterTypePanel",
"url": "https://api.github.com/repos/KevinGutowski/betterTypePanel"
}
|
{
"id": 4199296,
"login": "KevinGutowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4199296?",
"url": "https://api.github.com/users/KevinGutowski"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-02-01T00:55:31 |
8989669113
|
{"actor":{"display_login":"KevinGutowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/comments/357579563","pull_request_review_id":331784401,"id":357579563,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzU3OTU2Mw==","diff_hunk":"@@ -0,0 +1,359 @@\n+select {\n+ width: 100%;\n+ height: 46px;\n+ position: relative;\n+ z-index: 2; \n+ padding: 0 16px;\n+ border-radius: 4px;\n+ border: solid #ccc;\n+ background: 0;\n+ font-size: 16px;\n+ line-height: 1.5;\n+ cursor: pointer;\n+ -webkit-appearance: none;\n+}\n+\n+.containt{\n+ background-color: #F5F5F5;\n+ padding: 0 0 220px;\n+ color: rgb(51, 51, 51);\n+ &__header{\n+ background: #f5f5f5;\n+ font: 14px;\n+ color: #333333;\n+ height:88px;\n+ text-align: center;\n+ padding: 40px 0 0 ;\n+ border-style: solid;\n+ border-width: 0;\n+ font-size: inherit;\n+ line-height: inherit;\n+ box-sizing: inherit;\n+ display: block;\n+ &__logo{\n+ width: 185px;\n+ height: 49px;\n+ line-height: 49px;\n+ &__img{\n+ height: 49px;\n+ width: 185px;\n+ }\n+ }\n+ }\n+ &__main{\n+ background: #f5f5f5;\n+ &__container{\n+ width: 700px;\n+ margin: 0 auto;\n+ background: #ffffff;\n+ padding: 0;\n+ border-style: solid;\n+ border-width: 0;\n+ &__inner{\n+ &__head{\n+ padding: 32px 16px;\n+ font-size: 22px;\n+ text-align: center;\n+ display: block;\n+ font-weight: bold;\n+ line-height: 1.5;\n+ border-style: solid;\n+ border-width: 0;\n+ }\n+ &__sell-form{\n+ border-top: 1px solid #eee;\n+ background-repeat: no-repeat;\n+ margin: 0;\n+ padding: 0;\n+ &__form-require{\n+ background-color: #ea352d;\n+ margin: 0 0 0 8px;\n+ padding: 2px 4px;\n+ border-radius: 2px;\n+ color: #fff;\n+ font-size: 12px;\n+ vertical-align: top;\n+ }\n+ &__select-wrap{\n+ margin: 8px 0 0;\n+ position: relative;\n+ background: #fff;\n+ box-sizing: inherit;\n+ &__icon{\n+ position: absolute;\n+ right: 16px;\n+ top: 40%;\n+ z-index: 2;\n+ color: #888;\n+ font-size: 8px;\n+ }\n+ &__list{\n+ width: 100%;\n+ height: 46px;\n+ position: relative;\n+ z-index: 2; \n+ padding: 0 16px;\n+ border-radius: 4px;\n+ border: solid #ccc;\n+ background: 0;\n+ font-size: 16px;\n+ line-height: 1.5;\n+ cursor: pointer;\n+ -webkit-appearance: none;\n+ }\n+ }\n+ &__question{\n+ display: inline-block;\n+ width: 14px;\n+ height: 14px;\n+ border-radius: 50px;\n+ background: #0099e8;\n+ color: #fff;\n+ line-height: 14px;\n+ font-size: 12px;\n+ text-align: center;\n+ }\n+ &__form-interval{\n+ margin: 40px 0 0;\n+ }\n+ &__upload-box{\n+ width: 620px;\n+ padding: 40px;\n+ background-repeat: no-repeat;\n+ border-style: solid;\n+ border-width: 0;\n+ &__head{\n+ &__drop-box{\n+ position: relative;\n+ border: 1px dashed #ccc;\n+ text-align: center;\n+ cursor: pointer;\n+ width: 540px;\n+ height: 82px;\n+ margin-left: 0;\n+ padding: 40px;\n+ background: #f5f5f5;\n+ &__file{\n+ &__visible-pc{\n+ position: absolute;\n+ top: 50px;\n+ left: 16px;\n+ right: 16px;\n+ text-align: center;\n+ font-size: 14px;\n+ line-height: 1.5;\n+ white-space: pre-wrap;\n+ word-wrap: break-word;\n+ }\n+ }\n+ }\n+ }\n+ }\n+ &__information{\n+ height: 274px;\n+ width: 620px;\n+ padding: 40px;\n+ border-top: 1px solid #eee;\n+ background-repeat: no-repeat;\n+ margin: 0px;\n+ &__name{\n+ height: 70px;\n+ width: 620px;\n+ &__input-form{\n+ &__input-name{\n+ margin: 8px 0 0;\n+ height: 26px;\n+ width: 584px;\n+ padding: 10px 16px 8px;\n+ margin: 8px 0 0;","path":"app/assets/stylesheets/products_new.scss","position":168,"original_position":168,"commit_id":"48140b51e8c06d73e2434de405eda712857a4dd8","original_commit_id":"48140b51e8c06d73e2434de405eda712857a4dd8","user":{"login":"kenta-m821","id":55090384,"node_id":"MDQ6VXNlcjU1MDkwMzg0","avatar_url":"https://avatars1.githubusercontent.com/u/55090384?v=4","gravatar_id":"","url":"https://api.github.com/users/kenta-m821","html_url":"https://github.com/kenta-m821","followers_url":"https://api.github.com/users/kenta-m821/followers","following_url":"https://api.github.com/users/kenta-m821/following{/other_user}","gists_url":"https://api.github.com/users/kenta-m821/gists{/gist_id}","starred_url":"https://api.github.com/users/kenta-m821/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenta-m821/subscriptions","organizations_url":"https://api.github.com/users/kenta-m821/orgs","repos_url":"https://api.github.com/users/kenta-m821/repos","events_url":"https://api.github.com/users/kenta-m821/events{/privacy}","received_events_url":"https://api.github.com/users/kenta-m821/received_events","type":"User","site_admin":false},"body":"重複しているmarginを削除しました！","created_at":"2019-12-13T10:28:35Z","updated_at":"2019-12-13T10:28:35Z","html_url":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20#discussion_r357579563","pull_request_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/comments/357579563"},"html":{"href":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20#discussion_r357579563"},"pull_request":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20"}},"in_reply_to_id":357569548},"pull_request":{"url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20","id":347270717,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MjcwNzE3","html_url":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20","diff_url":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20.diff","patch_url":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20.patch","issue_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/20","number":20,"state":"open","locked":false,"title":"商品出品ページビューの作成","user":{"login":"kenta-m821","id":55090384,"node_id":"MDQ6VXNlcjU1MDkwMzg0","avatar_url":"https://avatars1.githubusercontent.com/u/55090384?v=4","gravatar_id":"","url":"https://api.github.com/users/kenta-m821","html_url":"https://github.com/kenta-m821","followers_url":"https://api.github.com/users/kenta-m821/followers","following_url":"https://api.github.com/users/kenta-m821/following{/other_user}","gists_url":"https://api.github.com/users/kenta-m821/gists{/gist_id}","starred_url":"https://api.github.com/users/kenta-m821/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenta-m821/subscriptions","organizations_url":"https://api.github.com/users/kenta-m821/orgs","repos_url":"https://api.github.com/users/kenta-m821/repos","events_url":"https://api.github.com/users/kenta-m821/events{/privacy}","received_events_url":"https://api.github.com/users/kenta-m821/received_events","type":"User","site_admin":false},"body":"# What\r\n商品出品ページビューの作成\r\n# Why\r\n商品出品において必要なビューであるため。","created_at":"2019-11-30T23:55:37Z","updated_at":"2019-12-13T10:28:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f973b1213abee1c9167e3e0a2390dc7843368f13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20/commits","review_comments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20/comments","review_comment_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/20/comments","statuses_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/statuses/48140b51e8c06d73e2434de405eda712857a4dd8","head":{"label":"tiphp452:add-product-listing-view","ref":"add-product-listing-view","sha":"48140b51e8c06d73e2434de405eda712857a4dd8","user":{"login":"tiphp452","id":54160947,"node_id":"MDQ6VXNlcjU0MTYwOTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/54160947?v=4","gravatar_id":"","url":"https://api.github.com/users/tiphp452","html_url":"https://github.com/tiphp452","followers_url":"https://api.github.com/users/tiphp452/followers","following_url":"https://api.github.com/users/tiphp452/following{/other_user}","gists_url":"https://api.github.com/users/tiphp452/gists{/gist_id}","starred_url":"https://api.github.com/users/tiphp452/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiphp452/subscriptions","organizations_url":"https://api.github.com/users/tiphp452/orgs","repos_url":"https://api.github.com/users/tiphp452/repos","events_url":"https://api.github.com/users/tiphp452/events{/privacy}","received_events_url":"https://api.github.com/users/tiphp452/received_events","type":"User","site_admin":false},"repo":{"id":223552319,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM1NTIzMTk=","name":"freemarket_sample_58a_night","full_name":"tiphp452/freemarket_sample_58a_night","private":false,"owner":{"login":"tiphp452","id":54160947,"node_id":"MDQ6VXNlcjU0MTYwOTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/54160947?v=4","gravatar_id":"","url":"https://api.github.com/users/tiphp452","html_url":"https://github.com/tiphp452","followers_url":"https://api.github.com/users/tiphp452/followers","following_url":"https://api.github.com/users/tiphp452/following{/other_user}","gists_url":"https://api.github.com/users/tiphp452/gists{/gist_id}","starred_url":"https://api.github.com/users/tiphp452/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiphp452/subscriptions","organizations_url":"https://api.github.com/users/tiphp452/orgs","repos_url":"https://api.github.com/users/tiphp452/repos","events_url":"https://api.github.com/users/tiphp452/events{/privacy}","received_events_url":"https://api.github.com/users/tiphp452/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tiphp452/freemarket_sample_58a_night","description":null,"fork":false,"url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night","forks_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/forks","keys_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/teams","hooks_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/hooks","issue_events_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/events{/number}","events_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/events","assignees_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/assignees{/user}","branches_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/branches{/branch}","tags_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/tags","blobs_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/statuses/{sha}","languages_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/languages","stargazers_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/stargazers","contributors_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/contributors","subscribers_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/subscribers","subscription_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/subscription","commits_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/contents/{+path}","compare_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/merges","archive_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/downloads","issues_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues{/number}","pulls_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls{/number}","milestones_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/milestones{/number}","notifications_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/labels{/name}","releases_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/releases{/id}","deployments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/deployments","created_at":"2019-11-23T07:53:48Z","updated_at":"2019-12-11T03:26:40Z","pushed_at":"2019-12-13T09:25:08Z","git_url":"git://github.com/tiphp452/freemarket_sample_58a_night.git","ssh_url":"git@github.com:tiphp452/freemarket_sample_58a_night.git","clone_url":"https://github.com/tiphp452/freemarket_sample_58a_night.git","svn_url":"https://github.com/tiphp452/freemarket_sample_58a_night","homepage":null,"size":246,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"tiphp452:master","ref":"master","sha":"40e72b3bc72ca660cca9138a14f02a6f5e1e6376","user":{"login":"tiphp452","id":54160947,"node_id":"MDQ6VXNlcjU0MTYwOTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/54160947?v=4","gravatar_id":"","url":"https://api.github.com/users/tiphp452","html_url":"https://github.com/tiphp452","followers_url":"https://api.github.com/users/tiphp452/followers","following_url":"https://api.github.com/users/tiphp452/following{/other_user}","gists_url":"https://api.github.com/users/tiphp452/gists{/gist_id}","starred_url":"https://api.github.com/users/tiphp452/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiphp452/subscriptions","organizations_url":"https://api.github.com/users/tiphp452/orgs","repos_url":"https://api.github.com/users/tiphp452/repos","events_url":"https://api.github.com/users/tiphp452/events{/privacy}","received_events_url":"https://api.github.com/users/tiphp452/received_events","type":"User","site_admin":false},"repo":{"id":223552319,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM1NTIzMTk=","name":"freemarket_sample_58a_night","full_name":"tiphp452/freemarket_sample_58a_night","private":false,"owner":{"login":"tiphp452","id":54160947,"node_id":"MDQ6VXNlcjU0MTYwOTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/54160947?v=4","gravatar_id":"","url":"https://api.github.com/users/tiphp452","html_url":"https://github.com/tiphp452","followers_url":"https://api.github.com/users/tiphp452/followers","following_url":"https://api.github.com/users/tiphp452/following{/other_user}","gists_url":"https://api.github.com/users/tiphp452/gists{/gist_id}","starred_url":"https://api.github.com/users/tiphp452/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiphp452/subscriptions","organizations_url":"https://api.github.com/users/tiphp452/orgs","repos_url":"https://api.github.com/users/tiphp452/repos","events_url":"https://api.github.com/users/tiphp452/events{/privacy}","received_events_url":"https://api.github.com/users/tiphp452/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tiphp452/freemarket_sample_58a_night","description":null,"fork":false,"url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night","forks_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/forks","keys_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/teams","hooks_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/hooks","issue_events_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/events{/number}","events_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/events","assignees_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/assignees{/user}","branches_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/branches{/branch}","tags_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/tags","blobs_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/statuses/{sha}","languages_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/languages","stargazers_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/stargazers","contributors_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/contributors","subscribers_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/subscribers","subscription_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/subscription","commits_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/contents/{+path}","compare_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/merges","archive_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/downloads","issues_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues{/number}","pulls_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls{/number}","milestones_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/milestones{/number}","notifications_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/labels{/name}","releases_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/releases{/id}","deployments_url":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/deployments","created_at":"2019-11-23T07:53:48Z","updated_at":"2019-12-11T03:26:40Z","pushed_at":"2019-12-13T09:25:08Z","git_url":"git://github.com/tiphp452/freemarket_sample_58a_night.git","ssh_url":"git@github.com:tiphp452/freemarket_sample_58a_night.git","clone_url":"https://github.com/tiphp452/freemarket_sample_58a_night.git","svn_url":"https://github.com/tiphp452/freemarket_sample_58a_night","homepage":null,"size":246,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20"},"html":{"href":"https://github.com/tiphp452/freemarket_sample_58a_night/pull/20"},"issue":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/20"},"comments":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/tiphp452/freemarket_sample_58a_night/statuses/48140b51e8c06d73e2434de405eda712857a4dd8"}},"author_association":"COLLABORATOR"}}
|
{
"id": 223552319,
"name": "tiphp452/freemarket_sample_58a_night",
"url": "https://api.github.com/repos/tiphp452/freemarket_sample_58a_night"
}
|
{
"id": 55090384,
"login": "kenta-m821",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/55090384?",
"url": "https://api.github.com/users/kenta-m821"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-13T10:28:35 |
11081751325
|
{"actor":{"display_login":"kenta-m821"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/comments/344508040","pull_request_review_id":314633667,"id":344508040,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDUwODA0MA==","diff_hunk":"@@ -0,0 +1,225 @@\n+@font-face {\n+ font-family: \"Roboto\";\n+ src: url('/assets/font/Roboto-Regular.ttf') format('truetype');\n+}\n+@font-face {\n+ font-family: 'FontAwesome Pro';\n+ src: url('/assets/font/FontAwesome_Pro-Solid-900.otf') format('opentype');\n+ font-weight: bold;\n+}\n+\n+@font-face {\n+ font-family: 'FontAwesome Brands';\n+ src: url('/assets/font/FontAwesome_Brands-Regular.otf') format('opentype');\n+}\n+\n+@font-face {\n+ font-family: \"FontAwesome Pro\";\n+ src: url(\"/assets/font/FontAwesome_Pro-Regular.otf\") format(\"opentype\");\n+}\n+\n+body {\n+ max-width: 1441px;\n+ margin-top: auto;\n+ padding: 0;\n+ margin: auto;\n+}\n+\n+.nav-menu {\n+ display: flex;\n+ justify-self: center;\n+ align-self: center;\n+ height: 50px;\n+ box-shadow: 0px 4px 4px rgba(0, 0, 0, 0.24), 0px 0px 4px rgba(0, 0, 0, 0.12);\n+}\n+\n+.nav-menu h1 {\n+ position: absolute;\n+ font-family: 'Roboto';\n+ font-weight: 500;\n+ margin-top: 13px;\n+ margin-left: 72px;\n+ font-size: 1em;\n+}\n+\n+.menu-btn {\n+ position: relative;\n+ margin-left: 19px;\n+ width: 40px;\n+ height: 40px;\n+ margin-top: 3px;\n+}\n+\n+.menu-btn:hover {\n+ transition: 0.5s;\n+ opacity: 0.6;\n+}\n+\n+.menu-btn .start-menu, .menu-btn .start-menu::after, .menu-btn .start-menu::before {\n+ position: absolute;\n+ left: 50%;\n+ top: 50%;\n+ margin-top: -1px;\n+ margin-left: -10px;\n+ width: 20px;\n+ height: 2px;\n+ background-color: rgba(34, 34, 34, 0.616);\n+}\n+\n+.menu-btn .start-menu::after, .menu-btn .start-menu::before {\n+ content: '';\n+}\n+\n+.menu-btn .start-menu::before {\n+ transform: translateY(-5px);\n+}\n+\n+.menu-btn .start-menu::after {\n+ transform: translateY(5px);\n+}\n+\n+.menu-btn-end {\n+ position: relative;\n+ margin-left: calc(100% - 100px);\n+ width: 40px;\n+ height: 40px;\n+ margin-top: 3px;\n+}\n+\n+.menu-btn-end:hover {\n+ transition: 0.5s;","path":"assets/style/style.css","position":90,"original_position":90,"commit_id":"b75950fe141c39180da7a695d8f6674590b87bad","original_commit_id":"b75950fe141c39180da7a695d8f6674590b87bad","user":{"login":"Muskos","id":1798651,"node_id":"MDQ6VXNlcjE3OTg2NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1798651?v=4","gravatar_id":"","url":"https://api.github.com/users/Muskos","html_url":"https://github.com/Muskos","followers_url":"https://api.github.com/users/Muskos/followers","following_url":"https://api.github.com/users/Muskos/following{/other_user}","gists_url":"https://api.github.com/users/Muskos/gists{/gist_id}","starred_url":"https://api.github.com/users/Muskos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Muskos/subscriptions","organizations_url":"https://api.github.com/users/Muskos/orgs","repos_url":"https://api.github.com/users/Muskos/repos","events_url":"https://api.github.com/users/Muskos/events{/privacy}","received_events_url":"https://api.github.com/users/Muskos/received_events","type":"User","site_admin":false},"body":"это не будет так работать, транзишн лучше поместить в сам блок, а на ховере менять опасити","created_at":"2019-11-10T18:49:40Z","updated_at":"2019-11-10T19:00:03Z","html_url":"https://github.com/dmitry-bdg/codejam-canvas/pull/1#discussion_r344508040","pull_request_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/comments/344508040"},"html":{"href":"https://github.com/dmitry-bdg/codejam-canvas/pull/1#discussion_r344508040"},"pull_request":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1","id":332893027,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyODkzMDI3","html_url":"https://github.com/dmitry-bdg/codejam-canvas/pull/1","diff_url":"https://github.com/dmitry-bdg/codejam-canvas/pull/1.diff","patch_url":"https://github.com/dmitry-bdg/codejam-canvas/pull/1.patch","issue_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/1","number":1,"state":"open","locked":false,"title":"Codejam canvas","user":{"login":"dmitry-bdg","id":55161018,"node_id":"MDQ6VXNlcjU1MTYxMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/55161018?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-bdg","html_url":"https://github.com/dmitry-bdg","followers_url":"https://api.github.com/users/dmitry-bdg/followers","following_url":"https://api.github.com/users/dmitry-bdg/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-bdg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-bdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-bdg/subscriptions","organizations_url":"https://api.github.com/users/dmitry-bdg/orgs","repos_url":"https://api.github.com/users/dmitry-bdg/repos","events_url":"https://api.github.com/users/dmitry-bdg/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-bdg/received_events","type":"User","site_admin":false},"body":"Adding solution task","created_at":"2019-10-27T20:59:01Z","updated_at":"2019-11-10T19:00:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21c1081b5b490903f04d9a2f9df57e1c399ea320","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/1/comments","statuses_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/statuses/b75950fe141c39180da7a695d8f6674590b87bad","head":{"label":"dmitry-bdg:codejam-canvas","ref":"codejam-canvas","sha":"b75950fe141c39180da7a695d8f6674590b87bad","user":{"login":"dmitry-bdg","id":55161018,"node_id":"MDQ6VXNlcjU1MTYxMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/55161018?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-bdg","html_url":"https://github.com/dmitry-bdg","followers_url":"https://api.github.com/users/dmitry-bdg/followers","following_url":"https://api.github.com/users/dmitry-bdg/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-bdg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-bdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-bdg/subscriptions","organizations_url":"https://api.github.com/users/dmitry-bdg/orgs","repos_url":"https://api.github.com/users/dmitry-bdg/repos","events_url":"https://api.github.com/users/dmitry-bdg/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-bdg/received_events","type":"User","site_admin":false},"repo":{"id":217606619,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2MDY2MTk=","name":"codejam-canvas","full_name":"dmitry-bdg/codejam-canvas","private":false,"owner":{"login":"dmitry-bdg","id":55161018,"node_id":"MDQ6VXNlcjU1MTYxMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/55161018?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-bdg","html_url":"https://github.com/dmitry-bdg","followers_url":"https://api.github.com/users/dmitry-bdg/followers","following_url":"https://api.github.com/users/dmitry-bdg/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-bdg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-bdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-bdg/subscriptions","organizations_url":"https://api.github.com/users/dmitry-bdg/orgs","repos_url":"https://api.github.com/users/dmitry-bdg/repos","events_url":"https://api.github.com/users/dmitry-bdg/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-bdg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitry-bdg/codejam-canvas","description":null,"fork":false,"url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas","forks_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/forks","keys_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/teams","hooks_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/hooks","issue_events_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/events","assignees_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/tags","blobs_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/languages","stargazers_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/stargazers","contributors_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/contributors","subscribers_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/subscribers","subscription_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/subscription","commits_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/merges","archive_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/downloads","issues_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/labels{/name}","releases_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/deployments","created_at":"2019-10-25T20:02:21Z","updated_at":"2019-11-10T12:26:13Z","pushed_at":"2019-10-28T18:25:01Z","git_url":"git://github.com/dmitry-bdg/codejam-canvas.git","ssh_url":"git@github.com:dmitry-bdg/codejam-canvas.git","clone_url":"https://github.com/dmitry-bdg/codejam-canvas.git","svn_url":"https://github.com/dmitry-bdg/codejam-canvas","homepage":null,"size":1193,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dmitry-bdg:master","ref":"master","sha":"35867bdb20db95be4c6ef30a7dd540642f98c744","user":{"login":"dmitry-bdg","id":55161018,"node_id":"MDQ6VXNlcjU1MTYxMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/55161018?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-bdg","html_url":"https://github.com/dmitry-bdg","followers_url":"https://api.github.com/users/dmitry-bdg/followers","following_url":"https://api.github.com/users/dmitry-bdg/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-bdg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-bdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-bdg/subscriptions","organizations_url":"https://api.github.com/users/dmitry-bdg/orgs","repos_url":"https://api.github.com/users/dmitry-bdg/repos","events_url":"https://api.github.com/users/dmitry-bdg/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-bdg/received_events","type":"User","site_admin":false},"repo":{"id":217606619,"node_id":"MDEwOlJlcG9zaXRvcnkyMTc2MDY2MTk=","name":"codejam-canvas","full_name":"dmitry-bdg/codejam-canvas","private":false,"owner":{"login":"dmitry-bdg","id":55161018,"node_id":"MDQ6VXNlcjU1MTYxMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/55161018?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitry-bdg","html_url":"https://github.com/dmitry-bdg","followers_url":"https://api.github.com/users/dmitry-bdg/followers","following_url":"https://api.github.com/users/dmitry-bdg/following{/other_user}","gists_url":"https://api.github.com/users/dmitry-bdg/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitry-bdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitry-bdg/subscriptions","organizations_url":"https://api.github.com/users/dmitry-bdg/orgs","repos_url":"https://api.github.com/users/dmitry-bdg/repos","events_url":"https://api.github.com/users/dmitry-bdg/events{/privacy}","received_events_url":"https://api.github.com/users/dmitry-bdg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dmitry-bdg/codejam-canvas","description":null,"fork":false,"url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas","forks_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/forks","keys_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/teams","hooks_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/hooks","issue_events_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/events{/number}","events_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/events","assignees_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/assignees{/user}","branches_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/branches{/branch}","tags_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/tags","blobs_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/statuses/{sha}","languages_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/languages","stargazers_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/stargazers","contributors_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/contributors","subscribers_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/subscribers","subscription_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/subscription","commits_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/contents/{+path}","compare_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/merges","archive_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/downloads","issues_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues{/number}","pulls_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls{/number}","milestones_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/milestones{/number}","notifications_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/labels{/name}","releases_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/releases{/id}","deployments_url":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/deployments","created_at":"2019-10-25T20:02:21Z","updated_at":"2019-11-10T12:26:13Z","pushed_at":"2019-10-28T18:25:01Z","git_url":"git://github.com/dmitry-bdg/codejam-canvas.git","ssh_url":"git@github.com:dmitry-bdg/codejam-canvas.git","clone_url":"https://github.com/dmitry-bdg/codejam-canvas.git","svn_url":"https://github.com/dmitry-bdg/codejam-canvas","homepage":null,"size":1193,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1"},"html":{"href":"https://github.com/dmitry-bdg/codejam-canvas/pull/1"},"issue":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/1"},"comments":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dmitry-bdg/codejam-canvas/statuses/b75950fe141c39180da7a695d8f6674590b87bad"}},"author_association":"OWNER"}}
|
{
"id": 217606619,
"name": "dmitry-bdg/codejam-canvas",
"url": "https://api.github.com/repos/dmitry-bdg/codejam-canvas"
}
|
{
"id": 1798651,
"login": "Muskos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1798651?",
"url": "https://api.github.com/users/Muskos"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-11-10T18:49:40 |
10828784080
|
{"actor":{"display_login":"Muskos"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/comments/300868074","pull_request_review_id":258627564,"id":300868074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDg2ODA3NA==","diff_hunk":"@@ -0,0 +1,46 @@\n+package signature\n+\n+import (\n+\t\"bytes\"\n+\t\"crypto\"\n+\t\"crypto/rand\"\n+\t\"crypto/rsa\"\n+\t\"crypto/sha512\"\n+\t\"crypto/x509\"\n+\t\"encoding/json\"\n+\t\"encoding/pem\"\n+\t\"errors\"\n+\t\"fmt\"\n+)\n+\n+// Check verifies whether a report has been signed\n+// with a legitimate version of Astronomer.\n+func Check(report *SignedReport) error {\n+\tdata, err := json.Marshal(report.Report)\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"unable to marshal trust report: %v\", err)\n+\t}\n+\n+\thashedReport := sha512.Sum512(data)\n+\n+\tkeyBlock, _ := pem.Decode([]byte(pemData))\n+\tif err != nil {","path":"pkg/signature/check.go","position":27,"original_position":27,"commit_id":"8a9af4347bc25837f54fb82856fa11c0f061a12b","original_commit_id":"8a9af4347bc25837f54fb82856fa11c0f061a12b","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"nilness: impossible condition: nil != nil (from `govet`)","created_at":"2019-07-07T13:43:38Z","updated_at":"2019-07-07T13:43:38Z","html_url":"https://github.com/Ullaakut/astronomer/pull/27#discussion_r300868074","pull_request_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/comments/300868074"},"html":{"href":"https://github.com/Ullaakut/astronomer/pull/27#discussion_r300868074"},"pull_request":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27","id":295104912,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1MTA0OTEy","html_url":"https://github.com/Ullaakut/astronomer/pull/27","diff_url":"https://github.com/Ullaakut/astronomer/pull/27.diff","patch_url":"https://github.com/Ullaakut/astronomer/pull/27.patch","issue_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/27","number":27,"state":"open","locked":false,"title":"Generate signed reports","user":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"body":"## Goal of this PR\r\n\r\nThis PR is the most important yet. It makes Astronomer sign and send its trust reports to [Astrolab](https://github.com/ullaakut/astrolab), a server in charge of collecting Astronomer reports and serving GitHub badges.\r\n\r\nIn order to achieve this, many changes were necessary:\r\n\r\n* Most of the code is now separated into public packages\r\n\t* `github.com/ullaakut/astronomer/pkg/context`\r\n\t\t* Only contains the astronomer context, used by all other packages to contain data on the current scan\r\n\t* `github.com/ullaakut/astronomer/pkg/gql`\r\n\t\t* Exposes the `FetchStargazers` and `FetchContributions` public methods\r\n\t\t* Is in charge to fetching data from the GitHub GraphQL API\r\n\t\t* Handles caching of this data\r\n\t* `github.com/ullaakut/astronomer/pkg/trust`\r\n\t\t* Is in charge of computing and rendering trust through the `Compute` and `Render` public methods\r\n\t* `github.com/ullaakut/astronomer/pkg/signature`\r\n\t\t* Is used to sign and send trust reports to the Astrolab server\r\n* It is no longer possible for people to build the Astronomer binary by themselves, they must use the released binaries or the public Docker images from DockerHub. This is due to the signing process.\r\n* In order to avoid people using the `--all` to get better trust reports, despite their early users being bot accounts, any scan of a repository with more than 200 users will compare the first 200 users to the rest in a comparative report, and will select the worst trust factors of both reports.\r\n* Astronomer now outputs the URL of the generated GitHub badge from the current scan\r\n\r\nFixes #14 \r\nFixes #22 \r\n\r\n## How to test it\r\n\r\n* `go test ./...`\r\n* Run astronomer on a repository with less than 200 stars\r\n* Run astronomer on a repository with more than 200 stars\r\n* Verify that github badges are generated properly\r\n\r\n## Examples\r\n\r\n<img src=\"https://img.shields.io/endpoint.svg?url=https%3A%2F%2Fastronomer.ullaakut.eu%2Fshields%3Fowner%3Dcontainous%26name%3Dtraefik\" />\r\n<img src=\"https://img.shields.io/endpoint.svg?url=https%3A%2F%2Fastronomer.ullaakut.eu%2Fshields%3Fowner%3Doperator996%26name%3Dyaocl\" />\r\n<img src=\"https://img.shields.io/endpoint.svg?url=https%3A%2F%2Fastronomer.ullaakut.eu%2Fshields%3Fowner%3Denvoyproxy%26name%3Denvoy\" />\r\n<img src=\"https://img.shields.io/endpoint.svg?url=https%3A%2F%2Fastronomer.ullaakut.eu%2Fshields%3Fowner%3Dullaakut%26name%3Dcameradar\" />\r\n<img src=\"https://img.shields.io/endpoint.svg?url=https%3A%2F%2Fastronomer.ullaakut.eu%2Fshields%3Fowner%3Dkataras%26name%3Diris\" />\r\n","created_at":"2019-07-07T13:41:44Z","updated_at":"2019-07-07T13:43:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cef132d5d3ce30f503df024bd4e8caaa2ad36320","assignee":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1416256785,"node_id":"MDU6TGFiZWwxNDE2MjU2Nzg1","url":"https://api.github.com/repos/Ullaakut/astronomer/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/Ullaakut/astronomer/milestones/2","html_url":"https://github.com/Ullaakut/astronomer/milestone/2","labels_url":"https://api.github.com/repos/Ullaakut/astronomer/milestones/2/labels","id":4450593,"node_id":"MDk6TWlsZXN0b25lNDQ1MDU5Mw==","number":2,"title":"v1.1","description":"Extends Astronomer with a web application and a `trust-as-a-service` system to generate GitHub badges for repositories.","creator":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2019-06-29T08:13:49Z","updated_at":"2019-07-07T13:41:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/27/comments","statuses_url":"https://api.github.com/repos/Ullaakut/astronomer/statuses/8a9af4347bc25837f54fb82856fa11c0f061a12b","head":{"label":"Ullaakut:generate-signed-reports","ref":"generate-signed-reports","sha":"8a9af4347bc25837f54fb82856fa11c0f061a12b","user":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"repo":{"id":193044927,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMwNDQ5Mjc=","name":"astronomer","full_name":"Ullaakut/astronomer","private":false,"owner":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ullaakut/astronomer","description":"A tool to detect illegitimate stars from bot accounts on GitHub projects","fork":false,"url":"https://api.github.com/repos/Ullaakut/astronomer","forks_url":"https://api.github.com/repos/Ullaakut/astronomer/forks","keys_url":"https://api.github.com/repos/Ullaakut/astronomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ullaakut/astronomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ullaakut/astronomer/teams","hooks_url":"https://api.github.com/repos/Ullaakut/astronomer/hooks","issue_events_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/events{/number}","events_url":"https://api.github.com/repos/Ullaakut/astronomer/events","assignees_url":"https://api.github.com/repos/Ullaakut/astronomer/assignees{/user}","branches_url":"https://api.github.com/repos/Ullaakut/astronomer/branches{/branch}","tags_url":"https://api.github.com/repos/Ullaakut/astronomer/tags","blobs_url":"https://api.github.com/repos/Ullaakut/astronomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ullaakut/astronomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ullaakut/astronomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ullaakut/astronomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ullaakut/astronomer/statuses/{sha}","languages_url":"https://api.github.com/repos/Ullaakut/astronomer/languages","stargazers_url":"https://api.github.com/repos/Ullaakut/astronomer/stargazers","contributors_url":"https://api.github.com/repos/Ullaakut/astronomer/contributors","subscribers_url":"https://api.github.com/repos/Ullaakut/astronomer/subscribers","subscription_url":"https://api.github.com/repos/Ullaakut/astronomer/subscription","commits_url":"https://api.github.com/repos/Ullaakut/astronomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ullaakut/astronomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ullaakut/astronomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ullaakut/astronomer/contents/{+path}","compare_url":"https://api.github.com/repos/Ullaakut/astronomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ullaakut/astronomer/merges","archive_url":"https://api.github.com/repos/Ullaakut/astronomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ullaakut/astronomer/downloads","issues_url":"https://api.github.com/repos/Ullaakut/astronomer/issues{/number}","pulls_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls{/number}","milestones_url":"https://api.github.com/repos/Ullaakut/astronomer/milestones{/number}","notifications_url":"https://api.github.com/repos/Ullaakut/astronomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ullaakut/astronomer/labels{/name}","releases_url":"https://api.github.com/repos/Ullaakut/astronomer/releases{/id}","deployments_url":"https://api.github.com/repos/Ullaakut/astronomer/deployments","created_at":"2019-06-21T06:39:04Z","updated_at":"2019-07-06T10:50:11Z","pushed_at":"2019-07-07T13:41:45Z","git_url":"git://github.com/Ullaakut/astronomer.git","ssh_url":"git@github.com:Ullaakut/astronomer.git","clone_url":"https://github.com/Ullaakut/astronomer.git","svn_url":"https://github.com/Ullaakut/astronomer","homepage":"","size":3313,"stargazers_count":102,"watchers_count":102,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":102,"default_branch":"master"}},"base":{"label":"Ullaakut:master","ref":"master","sha":"f9f75d945911dfa908a070f39f060c678e5dfad9","user":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"repo":{"id":193044927,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMwNDQ5Mjc=","name":"astronomer","full_name":"Ullaakut/astronomer","private":false,"owner":{"login":"Ullaakut","id":6976628,"node_id":"MDQ6VXNlcjY5NzY2Mjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6976628?v=4","gravatar_id":"","url":"https://api.github.com/users/Ullaakut","html_url":"https://github.com/Ullaakut","followers_url":"https://api.github.com/users/Ullaakut/followers","following_url":"https://api.github.com/users/Ullaakut/following{/other_user}","gists_url":"https://api.github.com/users/Ullaakut/gists{/gist_id}","starred_url":"https://api.github.com/users/Ullaakut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ullaakut/subscriptions","organizations_url":"https://api.github.com/users/Ullaakut/orgs","repos_url":"https://api.github.com/users/Ullaakut/repos","events_url":"https://api.github.com/users/Ullaakut/events{/privacy}","received_events_url":"https://api.github.com/users/Ullaakut/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ullaakut/astronomer","description":"A tool to detect illegitimate stars from bot accounts on GitHub projects","fork":false,"url":"https://api.github.com/repos/Ullaakut/astronomer","forks_url":"https://api.github.com/repos/Ullaakut/astronomer/forks","keys_url":"https://api.github.com/repos/Ullaakut/astronomer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ullaakut/astronomer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ullaakut/astronomer/teams","hooks_url":"https://api.github.com/repos/Ullaakut/astronomer/hooks","issue_events_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/events{/number}","events_url":"https://api.github.com/repos/Ullaakut/astronomer/events","assignees_url":"https://api.github.com/repos/Ullaakut/astronomer/assignees{/user}","branches_url":"https://api.github.com/repos/Ullaakut/astronomer/branches{/branch}","tags_url":"https://api.github.com/repos/Ullaakut/astronomer/tags","blobs_url":"https://api.github.com/repos/Ullaakut/astronomer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ullaakut/astronomer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ullaakut/astronomer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ullaakut/astronomer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ullaakut/astronomer/statuses/{sha}","languages_url":"https://api.github.com/repos/Ullaakut/astronomer/languages","stargazers_url":"https://api.github.com/repos/Ullaakut/astronomer/stargazers","contributors_url":"https://api.github.com/repos/Ullaakut/astronomer/contributors","subscribers_url":"https://api.github.com/repos/Ullaakut/astronomer/subscribers","subscription_url":"https://api.github.com/repos/Ullaakut/astronomer/subscription","commits_url":"https://api.github.com/repos/Ullaakut/astronomer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ullaakut/astronomer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ullaakut/astronomer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ullaakut/astronomer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ullaakut/astronomer/contents/{+path}","compare_url":"https://api.github.com/repos/Ullaakut/astronomer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ullaakut/astronomer/merges","archive_url":"https://api.github.com/repos/Ullaakut/astronomer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ullaakut/astronomer/downloads","issues_url":"https://api.github.com/repos/Ullaakut/astronomer/issues{/number}","pulls_url":"https://api.github.com/repos/Ullaakut/astronomer/pulls{/number}","milestones_url":"https://api.github.com/repos/Ullaakut/astronomer/milestones{/number}","notifications_url":"https://api.github.com/repos/Ullaakut/astronomer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ullaakut/astronomer/labels{/name}","releases_url":"https://api.github.com/repos/Ullaakut/astronomer/releases{/id}","deployments_url":"https://api.github.com/repos/Ullaakut/astronomer/deployments","created_at":"2019-06-21T06:39:04Z","updated_at":"2019-07-06T10:50:11Z","pushed_at":"2019-07-07T13:41:45Z","git_url":"git://github.com/Ullaakut/astronomer.git","ssh_url":"git@github.com:Ullaakut/astronomer.git","clone_url":"https://github.com/Ullaakut/astronomer.git","svn_url":"https://github.com/Ullaakut/astronomer","homepage":"","size":3313,"stargazers_count":102,"watchers_count":102,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27"},"html":{"href":"https://github.com/Ullaakut/astronomer/pull/27"},"issue":{"href":"https://api.github.com/repos/Ullaakut/astronomer/issues/27"},"comments":{"href":"https://api.github.com/repos/Ullaakut/astronomer/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ullaakut/astronomer/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Ullaakut/astronomer/statuses/8a9af4347bc25837f54fb82856fa11c0f061a12b"}},"author_association":"OWNER"}}
|
{
"id": 193044927,
"name": "Ullaakut/astronomer",
"url": "https://api.github.com/repos/Ullaakut/astronomer"
}
|
{
"id": 42910462,
"login": "golangcibot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/42910462?",
"url": "https://api.github.com/users/golangcibot"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-07-07T13:43:38 |
9962332917
|
{"actor":{"display_login":"golangcibot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/comments/358243133","pull_request_review_id":332580701,"id":358243133,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODI0MzEzMw==","diff_hunk":"@@ -0,0 +1,58 @@\n+package com.scriptbasic.executors.commands;\r\n+\r\n+import java.util.ArrayList;\r\n+import java.util.List;\r\n+\r\n+import com.scriptbasic.api.ScriptBasicException;\r\n+import com.scriptbasic.interfaces.Expression;\r\n+import com.scriptbasic.spi.Interpreter;\r\n+\r\n+public class CommandSelect extends AbstractCommandSelectPart {\r\n+\t\r\n+\tstatic public final String CASE_APPLIED = \"SELECT_CASE_APPLIED\";\r\n+\t\r\n+\t/**\r\n+\t * \r\n+\t */\r\n+\tprivate Expression expression;\r\n+\r\n+\tprivate CommandEndSelect commandEndSelect;\r\n+\t\r\n+\tprivate List<CommandCase> cases = new ArrayList<>();\r\n+\r\n+\tpublic void setExpression(final Expression expression) {\r\n+\t\tthis.expression = expression;\t\t\r\n+\t}\t\r\n+\r\n+\t@Override\r\n+\tpublic void execute(Interpreter interpreter) throws ScriptBasicException {\r\n+\t\t// Evaluate expression\r\n+\t\tfinal var expressionValue = expression.evaluate(interpreter);\r\n+\t\t// Mark as not finished\r\n+\t\tinterpreter.getMap().put(CASE_APPLIED, Boolean.FALSE);\r\n+\t\t\r\n+\t\t// Iterate all cases\r\n+\t\tfor(var singleCase: cases) {\r\n+\t\t if(singleCase.matchCase(interpreter, expressionValue)) {\r\n+\t\t\t // run this case\r","path":"src/main/java/com/scriptbasic/executors/commands/CommandSelect.java","position":37,"original_position":37,"commit_id":"42e6cc062a7b620084bf430adaa7c1d1a9fddc63","original_commit_id":"42e6cc062a7b620084bf430adaa7c1d1a9fddc63","user":{"login":"verhas","id":1597979,"node_id":"MDQ6VXNlcjE1OTc5Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1597979?v=4","gravatar_id":"","url":"https://api.github.com/users/verhas","html_url":"https://github.com/verhas","followers_url":"https://api.github.com/users/verhas/followers","following_url":"https://api.github.com/users/verhas/following{/other_user}","gists_url":"https://api.github.com/users/verhas/gists{/gist_id}","starred_url":"https://api.github.com/users/verhas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verhas/subscriptions","organizations_url":"https://api.github.com/users/verhas/orgs","repos_url":"https://api.github.com/users/verhas/repos","events_url":"https://api.github.com/users/verhas/events{/privacy}","received_events_url":"https://api.github.com/users/verhas/received_events","type":"User","site_admin":false},"body":"This is documented in the JavaDoc of `setNextCommand`.","created_at":"2019-12-16T13:52:56Z","updated_at":"2019-12-16T13:52:56Z","html_url":"https://github.com/verhas/jScriptBasic/pull/5#discussion_r358243133","pull_request_url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/comments/358243133"},"html":{"href":"https://github.com/verhas/jScriptBasic/pull/5#discussion_r358243133"},"pull_request":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5","id":353159139,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMTU5MTM5","html_url":"https://github.com/verhas/jScriptBasic/pull/5","diff_url":"https://github.com/verhas/jScriptBasic/pull/5.diff","patch_url":"https://github.com/verhas/jScriptBasic/pull/5.patch","issue_url":"https://api.github.com/repos/verhas/jScriptBasic/issues/5","number":5,"state":"open","locked":false,"title":"Add colon as multi-line separator, see: https://docs.microsoft.com/en…","user":{"login":"PetrPytelka","id":3627640,"node_id":"MDQ6VXNlcjM2Mjc2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3627640?v=4","gravatar_id":"","url":"https://api.github.com/users/PetrPytelka","html_url":"https://github.com/PetrPytelka","followers_url":"https://api.github.com/users/PetrPytelka/followers","following_url":"https://api.github.com/users/PetrPytelka/following{/other_user}","gists_url":"https://api.github.com/users/PetrPytelka/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrPytelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrPytelka/subscriptions","organizations_url":"https://api.github.com/users/PetrPytelka/orgs","repos_url":"https://api.github.com/users/PetrPytelka/repos","events_url":"https://api.github.com/users/PetrPytelka/events{/privacy}","received_events_url":"https://api.github.com/users/PetrPytelka/received_events","type":"User","site_admin":false},"body":"…-us/dotnet/visual-basic/programming-guide/program-structure/how-to-break-and-combine-statements-in-code#to-place-multiple-statements-on-the-same-line","created_at":"2019-12-14T09:24:57Z","updated_at":"2019-12-16T13:52:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db2659ddc9b308c4fc1d8a0991e3db2d8eea9f43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5/commits","review_comments_url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5/comments","review_comment_url":"https://api.github.com/repos/verhas/jScriptBasic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/verhas/jScriptBasic/issues/5/comments","statuses_url":"https://api.github.com/repos/verhas/jScriptBasic/statuses/42e6cc062a7b620084bf430adaa7c1d1a9fddc63","head":{"label":"PetrPytelka:master","ref":"master","sha":"42e6cc062a7b620084bf430adaa7c1d1a9fddc63","user":{"login":"PetrPytelka","id":3627640,"node_id":"MDQ6VXNlcjM2Mjc2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3627640?v=4","gravatar_id":"","url":"https://api.github.com/users/PetrPytelka","html_url":"https://github.com/PetrPytelka","followers_url":"https://api.github.com/users/PetrPytelka/followers","following_url":"https://api.github.com/users/PetrPytelka/following{/other_user}","gists_url":"https://api.github.com/users/PetrPytelka/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrPytelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrPytelka/subscriptions","organizations_url":"https://api.github.com/users/PetrPytelka/orgs","repos_url":"https://api.github.com/users/PetrPytelka/repos","events_url":"https://api.github.com/users/PetrPytelka/events{/privacy}","received_events_url":"https://api.github.com/users/PetrPytelka/received_events","type":"User","site_admin":false},"repo":{"id":227988650,"node_id":"MDEwOlJlcG9zaXRvcnkyMjc5ODg2NTA=","name":"jScriptBasic","full_name":"PetrPytelka/jScriptBasic","private":false,"owner":{"login":"PetrPytelka","id":3627640,"node_id":"MDQ6VXNlcjM2Mjc2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3627640?v=4","gravatar_id":"","url":"https://api.github.com/users/PetrPytelka","html_url":"https://github.com/PetrPytelka","followers_url":"https://api.github.com/users/PetrPytelka/followers","following_url":"https://api.github.com/users/PetrPytelka/following{/other_user}","gists_url":"https://api.github.com/users/PetrPytelka/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrPytelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrPytelka/subscriptions","organizations_url":"https://api.github.com/users/PetrPytelka/orgs","repos_url":"https://api.github.com/users/PetrPytelka/repos","events_url":"https://api.github.com/users/PetrPytelka/events{/privacy}","received_events_url":"https://api.github.com/users/PetrPytelka/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PetrPytelka/jScriptBasic","description":"ScriptBasic for Java","fork":true,"url":"https://api.github.com/repos/PetrPytelka/jScriptBasic","forks_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/forks","keys_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/teams","hooks_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/hooks","issue_events_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/issues/events{/number}","events_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/events","assignees_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/assignees{/user}","branches_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/branches{/branch}","tags_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/tags","blobs_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/git/refs{/sha}","trees_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/statuses/{sha}","languages_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/languages","stargazers_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/stargazers","contributors_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/contributors","subscribers_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/subscribers","subscription_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/subscription","commits_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/commits{/sha}","git_commits_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/git/commits{/sha}","comments_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/comments{/number}","issue_comment_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/issues/comments{/number}","contents_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/contents/{+path}","compare_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/merges","archive_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/downloads","issues_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/issues{/number}","pulls_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/pulls{/number}","milestones_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/milestones{/number}","notifications_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/labels{/name}","releases_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/releases{/id}","deployments_url":"https://api.github.com/repos/PetrPytelka/jScriptBasic/deployments","created_at":"2019-12-14T08:14:02Z","updated_at":"2019-12-16T11:37:40Z","pushed_at":"2019-12-16T11:37:37Z","git_url":"git://github.com/PetrPytelka/jScriptBasic.git","ssh_url":"git@github.com:PetrPytelka/jScriptBasic.git","clone_url":"https://github.com/PetrPytelka/jScriptBasic.git","svn_url":"https://github.com/PetrPytelka/jScriptBasic","homepage":null,"size":7167,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"verhas:master","ref":"master","sha":"136d9da876c02ec535e4f08f4f3fc0b6b311c989","user":{"login":"verhas","id":1597979,"node_id":"MDQ6VXNlcjE1OTc5Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1597979?v=4","gravatar_id":"","url":"https://api.github.com/users/verhas","html_url":"https://github.com/verhas","followers_url":"https://api.github.com/users/verhas/followers","following_url":"https://api.github.com/users/verhas/following{/other_user}","gists_url":"https://api.github.com/users/verhas/gists{/gist_id}","starred_url":"https://api.github.com/users/verhas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verhas/subscriptions","organizations_url":"https://api.github.com/users/verhas/orgs","repos_url":"https://api.github.com/users/verhas/repos","events_url":"https://api.github.com/users/verhas/events{/privacy}","received_events_url":"https://api.github.com/users/verhas/received_events","type":"User","site_admin":false},"repo":{"id":4337710,"node_id":"MDEwOlJlcG9zaXRvcnk0MzM3NzEw","name":"jScriptBasic","full_name":"verhas/jScriptBasic","private":false,"owner":{"login":"verhas","id":1597979,"node_id":"MDQ6VXNlcjE1OTc5Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1597979?v=4","gravatar_id":"","url":"https://api.github.com/users/verhas","html_url":"https://github.com/verhas","followers_url":"https://api.github.com/users/verhas/followers","following_url":"https://api.github.com/users/verhas/following{/other_user}","gists_url":"https://api.github.com/users/verhas/gists{/gist_id}","starred_url":"https://api.github.com/users/verhas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verhas/subscriptions","organizations_url":"https://api.github.com/users/verhas/orgs","repos_url":"https://api.github.com/users/verhas/repos","events_url":"https://api.github.com/users/verhas/events{/privacy}","received_events_url":"https://api.github.com/users/verhas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/verhas/jScriptBasic","description":"ScriptBasic for Java","fork":false,"url":"https://api.github.com/repos/verhas/jScriptBasic","forks_url":"https://api.github.com/repos/verhas/jScriptBasic/forks","keys_url":"https://api.github.com/repos/verhas/jScriptBasic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verhas/jScriptBasic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verhas/jScriptBasic/teams","hooks_url":"https://api.github.com/repos/verhas/jScriptBasic/hooks","issue_events_url":"https://api.github.com/repos/verhas/jScriptBasic/issues/events{/number}","events_url":"https://api.github.com/repos/verhas/jScriptBasic/events","assignees_url":"https://api.github.com/repos/verhas/jScriptBasic/assignees{/user}","branches_url":"https://api.github.com/repos/verhas/jScriptBasic/branches{/branch}","tags_url":"https://api.github.com/repos/verhas/jScriptBasic/tags","blobs_url":"https://api.github.com/repos/verhas/jScriptBasic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verhas/jScriptBasic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verhas/jScriptBasic/git/refs{/sha}","trees_url":"https://api.github.com/repos/verhas/jScriptBasic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verhas/jScriptBasic/statuses/{sha}","languages_url":"https://api.github.com/repos/verhas/jScriptBasic/languages","stargazers_url":"https://api.github.com/repos/verhas/jScriptBasic/stargazers","contributors_url":"https://api.github.com/repos/verhas/jScriptBasic/contributors","subscribers_url":"https://api.github.com/repos/verhas/jScriptBasic/subscribers","subscription_url":"https://api.github.com/repos/verhas/jScriptBasic/subscription","commits_url":"https://api.github.com/repos/verhas/jScriptBasic/commits{/sha}","git_commits_url":"https://api.github.com/repos/verhas/jScriptBasic/git/commits{/sha}","comments_url":"https://api.github.com/repos/verhas/jScriptBasic/comments{/number}","issue_comment_url":"https://api.github.com/repos/verhas/jScriptBasic/issues/comments{/number}","contents_url":"https://api.github.com/repos/verhas/jScriptBasic/contents/{+path}","compare_url":"https://api.github.com/repos/verhas/jScriptBasic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verhas/jScriptBasic/merges","archive_url":"https://api.github.com/repos/verhas/jScriptBasic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verhas/jScriptBasic/downloads","issues_url":"https://api.github.com/repos/verhas/jScriptBasic/issues{/number}","pulls_url":"https://api.github.com/repos/verhas/jScriptBasic/pulls{/number}","milestones_url":"https://api.github.com/repos/verhas/jScriptBasic/milestones{/number}","notifications_url":"https://api.github.com/repos/verhas/jScriptBasic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verhas/jScriptBasic/labels{/name}","releases_url":"https://api.github.com/repos/verhas/jScriptBasic/releases{/id}","deployments_url":"https://api.github.com/repos/verhas/jScriptBasic/deployments","created_at":"2012-05-15T16:03:16Z","updated_at":"2019-05-08T16:01:09Z","pushed_at":"2019-12-16T11:37:39Z","git_url":"git://github.com/verhas/jScriptBasic.git","ssh_url":"git@github.com:verhas/jScriptBasic.git","clone_url":"https://github.com/verhas/jScriptBasic.git","svn_url":"https://github.com/verhas/jScriptBasic","homepage":null,"size":7180,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":1,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5"},"html":{"href":"https://github.com/verhas/jScriptBasic/pull/5"},"issue":{"href":"https://api.github.com/repos/verhas/jScriptBasic/issues/5"},"comments":{"href":"https://api.github.com/repos/verhas/jScriptBasic/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/verhas/jScriptBasic/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/verhas/jScriptBasic/statuses/42e6cc062a7b620084bf430adaa7c1d1a9fddc63"}},"author_association":"NONE"}}
|
{
"id": 4337710,
"name": "verhas/jScriptBasic",
"url": "https://api.github.com/repos/verhas/jScriptBasic"
}
|
{
"id": 1597979,
"login": "verhas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1597979?",
"url": "https://api.github.com/users/verhas"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-16T13:52:56 |
11097698980
|
{"actor":{"display_login":"verhas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/comments/309328892","pull_request_review_id":269150832,"id":309328892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTMyODg5Mg==","diff_hunk":"@@ -1,5 +1,5 @@\n <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n-<document type=\"com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB\" version=\"3.0\" toolsVersion=\"14490.70\" targetRuntime=\"iOS.CocoaTouch\" propertyAccessControl=\"none\" useAutolayout=\"YES\" useTraitCollections=\"YES\" useSafeAreas=\"YES\" colorMatched=\"YES\" initialViewController=\"PF2-HB-Htm\">\n+<document type=\"com.apple.InterfaceBuilder3.CocoaTouch.Storyboard.XIB\" version=\"3.0\" toolsVersion=\"14490.70\" targetRuntime=\"iOS.CocoaTouch\" propertyAccessControl=\"none\" useAutolayout=\"YES\" useTraitCollections=\"YES\" useSafeAreas=\"YES\" colorMatched=\"YES\" initialViewController=\"jF7-bd-CYk\">","path":"PokemonApp/PokemonApp/Base.lproj/Main.storyboard","position":3,"original_position":3,"commit_id":"6418eb7505ac145e4d15bc67ce662c20b551dec5","original_commit_id":"f2cf05082e6f9cb4b876b810c50521076cd25713","user":{"login":"prrenfrew","id":17123826,"node_id":"MDQ6VXNlcjE3MTIzODI2","avatar_url":"https://avatars3.githubusercontent.com/u/17123826?v=4","gravatar_id":"","url":"https://api.github.com/users/prrenfrew","html_url":"https://github.com/prrenfrew","followers_url":"https://api.github.com/users/prrenfrew/followers","following_url":"https://api.github.com/users/prrenfrew/following{/other_user}","gists_url":"https://api.github.com/users/prrenfrew/gists{/gist_id}","starred_url":"https://api.github.com/users/prrenfrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prrenfrew/subscriptions","organizations_url":"https://api.github.com/users/prrenfrew/orgs","repos_url":"https://api.github.com/users/prrenfrew/repos","events_url":"https://api.github.com/users/prrenfrew/events{/privacy}","received_events_url":"https://api.github.com/users/prrenfrew/received_events","type":"User","site_admin":false},"body":"This was changed back. Please revert back to the original starting view controller.","created_at":"2019-07-31T16:57:14Z","updated_at":"2019-07-31T16:57:14Z","html_url":"https://github.com/prrenfrew/PokemonApp/pull/22#discussion_r309328892","pull_request_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/comments/309328892"},"html":{"href":"https://github.com/prrenfrew/PokemonApp/pull/22#discussion_r309328892"},"pull_request":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22"}},"in_reply_to_id":303130878},"pull_request":{"url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22","id":297192464,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MTkyNDY0","html_url":"https://github.com/prrenfrew/PokemonApp/pull/22","diff_url":"https://github.com/prrenfrew/PokemonApp/pull/22.diff","patch_url":"https://github.com/prrenfrew/PokemonApp/pull/22.patch","issue_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/22","number":22,"state":"open","locked":false,"title":"Starter pokemon branch","user":{"login":"grm121616","id":50636201,"node_id":"MDQ6VXNlcjUwNjM2MjAx","avatar_url":"https://avatars0.githubusercontent.com/u/50636201?v=4","gravatar_id":"","url":"https://api.github.com/users/grm121616","html_url":"https://github.com/grm121616","followers_url":"https://api.github.com/users/grm121616/followers","following_url":"https://api.github.com/users/grm121616/following{/other_user}","gists_url":"https://api.github.com/users/grm121616/gists{/gist_id}","starred_url":"https://api.github.com/users/grm121616/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grm121616/subscriptions","organizations_url":"https://api.github.com/users/grm121616/orgs","repos_url":"https://api.github.com/users/grm121616/repos","events_url":"https://api.github.com/users/grm121616/events{/privacy}","received_events_url":"https://api.github.com/users/grm121616/received_events","type":"User","site_admin":false},"body":"1st PR","created_at":"2019-07-12T19:17:24Z","updated_at":"2019-07-31T16:57:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1507d9030918ff2549b87e04424e9b958c0b81f9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22/commits","review_comments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22/comments","review_comment_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/22/comments","statuses_url":"https://api.github.com/repos/prrenfrew/PokemonApp/statuses/6418eb7505ac145e4d15bc67ce662c20b551dec5","head":{"label":"prrenfrew:starterPokemonBranch","ref":"starterPokemonBranch","sha":"6418eb7505ac145e4d15bc67ce662c20b551dec5","user":{"login":"prrenfrew","id":17123826,"node_id":"MDQ6VXNlcjE3MTIzODI2","avatar_url":"https://avatars3.githubusercontent.com/u/17123826?v=4","gravatar_id":"","url":"https://api.github.com/users/prrenfrew","html_url":"https://github.com/prrenfrew","followers_url":"https://api.github.com/users/prrenfrew/followers","following_url":"https://api.github.com/users/prrenfrew/following{/other_user}","gists_url":"https://api.github.com/users/prrenfrew/gists{/gist_id}","starred_url":"https://api.github.com/users/prrenfrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prrenfrew/subscriptions","organizations_url":"https://api.github.com/users/prrenfrew/orgs","repos_url":"https://api.github.com/users/prrenfrew/repos","events_url":"https://api.github.com/users/prrenfrew/events{/privacy}","received_events_url":"https://api.github.com/users/prrenfrew/received_events","type":"User","site_admin":false},"repo":{"id":190640280,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2NDAyODA=","name":"PokemonApp","full_name":"prrenfrew/PokemonApp","private":false,"owner":{"login":"prrenfrew","id":17123826,"node_id":"MDQ6VXNlcjE3MTIzODI2","avatar_url":"https://avatars3.githubusercontent.com/u/17123826?v=4","gravatar_id":"","url":"https://api.github.com/users/prrenfrew","html_url":"https://github.com/prrenfrew","followers_url":"https://api.github.com/users/prrenfrew/followers","following_url":"https://api.github.com/users/prrenfrew/following{/other_user}","gists_url":"https://api.github.com/users/prrenfrew/gists{/gist_id}","starred_url":"https://api.github.com/users/prrenfrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prrenfrew/subscriptions","organizations_url":"https://api.github.com/users/prrenfrew/orgs","repos_url":"https://api.github.com/users/prrenfrew/repos","events_url":"https://api.github.com/users/prrenfrew/events{/privacy}","received_events_url":"https://api.github.com/users/prrenfrew/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prrenfrew/PokemonApp","description":null,"fork":false,"url":"https://api.github.com/repos/prrenfrew/PokemonApp","forks_url":"https://api.github.com/repos/prrenfrew/PokemonApp/forks","keys_url":"https://api.github.com/repos/prrenfrew/PokemonApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prrenfrew/PokemonApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prrenfrew/PokemonApp/teams","hooks_url":"https://api.github.com/repos/prrenfrew/PokemonApp/hooks","issue_events_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/events{/number}","events_url":"https://api.github.com/repos/prrenfrew/PokemonApp/events","assignees_url":"https://api.github.com/repos/prrenfrew/PokemonApp/assignees{/user}","branches_url":"https://api.github.com/repos/prrenfrew/PokemonApp/branches{/branch}","tags_url":"https://api.github.com/repos/prrenfrew/PokemonApp/tags","blobs_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prrenfrew/PokemonApp/statuses/{sha}","languages_url":"https://api.github.com/repos/prrenfrew/PokemonApp/languages","stargazers_url":"https://api.github.com/repos/prrenfrew/PokemonApp/stargazers","contributors_url":"https://api.github.com/repos/prrenfrew/PokemonApp/contributors","subscribers_url":"https://api.github.com/repos/prrenfrew/PokemonApp/subscribers","subscription_url":"https://api.github.com/repos/prrenfrew/PokemonApp/subscription","commits_url":"https://api.github.com/repos/prrenfrew/PokemonApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/prrenfrew/PokemonApp/contents/{+path}","compare_url":"https://api.github.com/repos/prrenfrew/PokemonApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prrenfrew/PokemonApp/merges","archive_url":"https://api.github.com/repos/prrenfrew/PokemonApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prrenfrew/PokemonApp/downloads","issues_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues{/number}","pulls_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls{/number}","milestones_url":"https://api.github.com/repos/prrenfrew/PokemonApp/milestones{/number}","notifications_url":"https://api.github.com/repos/prrenfrew/PokemonApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prrenfrew/PokemonApp/labels{/name}","releases_url":"https://api.github.com/repos/prrenfrew/PokemonApp/releases{/id}","deployments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/deployments","created_at":"2019-06-06T19:46:43Z","updated_at":"2019-06-16T18:28:25Z","pushed_at":"2019-07-31T16:52:18Z","git_url":"git://github.com/prrenfrew/PokemonApp.git","ssh_url":"git@github.com:prrenfrew/PokemonApp.git","clone_url":"https://github.com/prrenfrew/PokemonApp.git","svn_url":"https://github.com/prrenfrew/PokemonApp","homepage":null,"size":432,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"prrenfrew:develop","ref":"develop","sha":"e1a0072da8a09ea27c0c04257691e406daf1c754","user":{"login":"prrenfrew","id":17123826,"node_id":"MDQ6VXNlcjE3MTIzODI2","avatar_url":"https://avatars3.githubusercontent.com/u/17123826?v=4","gravatar_id":"","url":"https://api.github.com/users/prrenfrew","html_url":"https://github.com/prrenfrew","followers_url":"https://api.github.com/users/prrenfrew/followers","following_url":"https://api.github.com/users/prrenfrew/following{/other_user}","gists_url":"https://api.github.com/users/prrenfrew/gists{/gist_id}","starred_url":"https://api.github.com/users/prrenfrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prrenfrew/subscriptions","organizations_url":"https://api.github.com/users/prrenfrew/orgs","repos_url":"https://api.github.com/users/prrenfrew/repos","events_url":"https://api.github.com/users/prrenfrew/events{/privacy}","received_events_url":"https://api.github.com/users/prrenfrew/received_events","type":"User","site_admin":false},"repo":{"id":190640280,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2NDAyODA=","name":"PokemonApp","full_name":"prrenfrew/PokemonApp","private":false,"owner":{"login":"prrenfrew","id":17123826,"node_id":"MDQ6VXNlcjE3MTIzODI2","avatar_url":"https://avatars3.githubusercontent.com/u/17123826?v=4","gravatar_id":"","url":"https://api.github.com/users/prrenfrew","html_url":"https://github.com/prrenfrew","followers_url":"https://api.github.com/users/prrenfrew/followers","following_url":"https://api.github.com/users/prrenfrew/following{/other_user}","gists_url":"https://api.github.com/users/prrenfrew/gists{/gist_id}","starred_url":"https://api.github.com/users/prrenfrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prrenfrew/subscriptions","organizations_url":"https://api.github.com/users/prrenfrew/orgs","repos_url":"https://api.github.com/users/prrenfrew/repos","events_url":"https://api.github.com/users/prrenfrew/events{/privacy}","received_events_url":"https://api.github.com/users/prrenfrew/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prrenfrew/PokemonApp","description":null,"fork":false,"url":"https://api.github.com/repos/prrenfrew/PokemonApp","forks_url":"https://api.github.com/repos/prrenfrew/PokemonApp/forks","keys_url":"https://api.github.com/repos/prrenfrew/PokemonApp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prrenfrew/PokemonApp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prrenfrew/PokemonApp/teams","hooks_url":"https://api.github.com/repos/prrenfrew/PokemonApp/hooks","issue_events_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/events{/number}","events_url":"https://api.github.com/repos/prrenfrew/PokemonApp/events","assignees_url":"https://api.github.com/repos/prrenfrew/PokemonApp/assignees{/user}","branches_url":"https://api.github.com/repos/prrenfrew/PokemonApp/branches{/branch}","tags_url":"https://api.github.com/repos/prrenfrew/PokemonApp/tags","blobs_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/refs{/sha}","trees_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prrenfrew/PokemonApp/statuses/{sha}","languages_url":"https://api.github.com/repos/prrenfrew/PokemonApp/languages","stargazers_url":"https://api.github.com/repos/prrenfrew/PokemonApp/stargazers","contributors_url":"https://api.github.com/repos/prrenfrew/PokemonApp/contributors","subscribers_url":"https://api.github.com/repos/prrenfrew/PokemonApp/subscribers","subscription_url":"https://api.github.com/repos/prrenfrew/PokemonApp/subscription","commits_url":"https://api.github.com/repos/prrenfrew/PokemonApp/commits{/sha}","git_commits_url":"https://api.github.com/repos/prrenfrew/PokemonApp/git/commits{/sha}","comments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/comments{/number}","issue_comment_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/comments{/number}","contents_url":"https://api.github.com/repos/prrenfrew/PokemonApp/contents/{+path}","compare_url":"https://api.github.com/repos/prrenfrew/PokemonApp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prrenfrew/PokemonApp/merges","archive_url":"https://api.github.com/repos/prrenfrew/PokemonApp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prrenfrew/PokemonApp/downloads","issues_url":"https://api.github.com/repos/prrenfrew/PokemonApp/issues{/number}","pulls_url":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls{/number}","milestones_url":"https://api.github.com/repos/prrenfrew/PokemonApp/milestones{/number}","notifications_url":"https://api.github.com/repos/prrenfrew/PokemonApp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prrenfrew/PokemonApp/labels{/name}","releases_url":"https://api.github.com/repos/prrenfrew/PokemonApp/releases{/id}","deployments_url":"https://api.github.com/repos/prrenfrew/PokemonApp/deployments","created_at":"2019-06-06T19:46:43Z","updated_at":"2019-06-16T18:28:25Z","pushed_at":"2019-07-31T16:52:18Z","git_url":"git://github.com/prrenfrew/PokemonApp.git","ssh_url":"git@github.com:prrenfrew/PokemonApp.git","clone_url":"https://github.com/prrenfrew/PokemonApp.git","svn_url":"https://github.com/prrenfrew/PokemonApp","homepage":null,"size":432,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22"},"html":{"href":"https://github.com/prrenfrew/PokemonApp/pull/22"},"issue":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/22"},"comments":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/prrenfrew/PokemonApp/statuses/6418eb7505ac145e4d15bc67ce662c20b551dec5"}},"author_association":"COLLABORATOR"}}
|
{
"id": 190640280,
"name": "prrenfrew/PokemonApp",
"url": "https://api.github.com/repos/prrenfrew/PokemonApp"
}
|
{
"id": 17123826,
"login": "prrenfrew",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17123826?",
"url": "https://api.github.com/users/prrenfrew"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-07-31T16:57:14 |
10122031176
|
{"actor":{"display_login":"prrenfrew"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/comments/359114196","pull_request_review_id":333685085,"id":359114196,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTExNDE5Ng==","diff_hunk":"@@ -11,7 +11,18 @@ export class CloudSeeding implements IProjectCard {\n public tags: Array<Tags> = [];\n public name: string = 'Cloud Seeding';\n public cardType: CardType = CardType.AUTOMATED;\n+ \n+ private playersWithHeatProduction(game: Game): boolean {\n+ for (const player of game.getPlayers()) {\n+ if (player.heatProduction >= 1) return true;\n+ }\n+ return false;\n+ }\n+ \n public canPlay(player: Player, game: Game): boolean {\n+\n+ if ( ! this.playersWithHeatProduction(game)) return false;","path":"src/cards/CloudSeeding.ts","position":14,"original_position":14,"commit_id":"75e8c9d7256eae764aab0be559403823d614f6fd","original_commit_id":"75e8c9d7256eae764aab0be559403823d614f6fd","user":{"login":"bafolts","id":2707843,"node_id":"MDQ6VXNlcjI3MDc4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2707843?v=4","gravatar_id":"","url":"https://api.github.com/users/bafolts","html_url":"https://github.com/bafolts","followers_url":"https://api.github.com/users/bafolts/followers","following_url":"https://api.github.com/users/bafolts/following{/other_user}","gists_url":"https://api.github.com/users/bafolts/gists{/gist_id}","starred_url":"https://api.github.com/users/bafolts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bafolts/subscriptions","organizations_url":"https://api.github.com/users/bafolts/orgs","repos_url":"https://api.github.com/users/bafolts/repos","events_url":"https://api.github.com/users/bafolts/events{/privacy}","received_events_url":"https://api.github.com/users/bafolts/received_events","type":"User","site_admin":false},"body":"https://github.com/bafolts/terraforming-mars/blob/master/src/cards/CloudSeeding.ts#L30\r\n\r\nI would return the array of players with heat production and only allow those players to be selected. With that change an error no longer needs to be thrown and `canPlay` can check if the array is empty.","created_at":"2019-12-18T01:34:04Z","updated_at":"2019-12-18T01:34:05Z","html_url":"https://github.com/bafolts/terraforming-mars/pull/98#discussion_r359114196","pull_request_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/comments/359114196"},"html":{"href":"https://github.com/bafolts/terraforming-mars/pull/98#discussion_r359114196"},"pull_request":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98","id":354156661,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MTU2NjYx","html_url":"https://github.com/bafolts/terraforming-mars/pull/98","diff_url":"https://github.com/bafolts/terraforming-mars/pull/98.diff","patch_url":"https://github.com/bafolts/terraforming-mars/pull/98.patch","issue_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/98","number":98,"state":"open","locked":false,"title":"Issue 81","user":{"login":"alrusdi","id":394311,"node_id":"MDQ6VXNlcjM5NDMxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/394311?v=4","gravatar_id":"","url":"https://api.github.com/users/alrusdi","html_url":"https://github.com/alrusdi","followers_url":"https://api.github.com/users/alrusdi/followers","following_url":"https://api.github.com/users/alrusdi/following{/other_user}","gists_url":"https://api.github.com/users/alrusdi/gists{/gist_id}","starred_url":"https://api.github.com/users/alrusdi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrusdi/subscriptions","organizations_url":"https://api.github.com/users/alrusdi/orgs","repos_url":"https://api.github.com/users/alrusdi/repos","events_url":"https://api.github.com/users/alrusdi/events{/privacy}","received_events_url":"https://api.github.com/users/alrusdi/received_events","type":"User","site_admin":false},"body":"8 more cards fixed. Please merge, but do not remove a branch","created_at":"2019-12-17T15:10:50Z","updated_at":"2019-12-18T01:34:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9819bdcd30765e552c48b0a44ff79fe5b2ab63db","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vincentneko","id":56086992,"node_id":"MDQ6VXNlcjU2MDg2OTky","avatar_url":"https://avatars3.githubusercontent.com/u/56086992?v=4","gravatar_id":"","url":"https://api.github.com/users/vincentneko","html_url":"https://github.com/vincentneko","followers_url":"https://api.github.com/users/vincentneko/followers","following_url":"https://api.github.com/users/vincentneko/following{/other_user}","gists_url":"https://api.github.com/users/vincentneko/gists{/gist_id}","starred_url":"https://api.github.com/users/vincentneko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincentneko/subscriptions","organizations_url":"https://api.github.com/users/vincentneko/orgs","repos_url":"https://api.github.com/users/vincentneko/repos","events_url":"https://api.github.com/users/vincentneko/events{/privacy}","received_events_url":"https://api.github.com/users/vincentneko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98/commits","review_comments_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98/comments","review_comment_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/98/comments","statuses_url":"https://api.github.com/repos/bafolts/terraforming-mars/statuses/75e8c9d7256eae764aab0be559403823d614f6fd","head":{"label":"bafolts:issue-81","ref":"issue-81","sha":"75e8c9d7256eae764aab0be559403823d614f6fd","user":{"login":"bafolts","id":2707843,"node_id":"MDQ6VXNlcjI3MDc4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2707843?v=4","gravatar_id":"","url":"https://api.github.com/users/bafolts","html_url":"https://github.com/bafolts","followers_url":"https://api.github.com/users/bafolts/followers","following_url":"https://api.github.com/users/bafolts/following{/other_user}","gists_url":"https://api.github.com/users/bafolts/gists{/gist_id}","starred_url":"https://api.github.com/users/bafolts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bafolts/subscriptions","organizations_url":"https://api.github.com/users/bafolts/orgs","repos_url":"https://api.github.com/users/bafolts/repos","events_url":"https://api.github.com/users/bafolts/events{/privacy}","received_events_url":"https://api.github.com/users/bafolts/received_events","type":"User","site_admin":false},"repo":{"id":123862990,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM4NjI5OTA=","name":"terraforming-mars","full_name":"bafolts/terraforming-mars","private":false,"owner":{"login":"bafolts","id":2707843,"node_id":"MDQ6VXNlcjI3MDc4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2707843?v=4","gravatar_id":"","url":"https://api.github.com/users/bafolts","html_url":"https://github.com/bafolts","followers_url":"https://api.github.com/users/bafolts/followers","following_url":"https://api.github.com/users/bafolts/following{/other_user}","gists_url":"https://api.github.com/users/bafolts/gists{/gist_id}","starred_url":"https://api.github.com/users/bafolts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bafolts/subscriptions","organizations_url":"https://api.github.com/users/bafolts/orgs","repos_url":"https://api.github.com/users/bafolts/repos","events_url":"https://api.github.com/users/bafolts/events{/privacy}","received_events_url":"https://api.github.com/users/bafolts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bafolts/terraforming-mars","description":"Terraforming Mars Boardgame","fork":false,"url":"https://api.github.com/repos/bafolts/terraforming-mars","forks_url":"https://api.github.com/repos/bafolts/terraforming-mars/forks","keys_url":"https://api.github.com/repos/bafolts/terraforming-mars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bafolts/terraforming-mars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bafolts/terraforming-mars/teams","hooks_url":"https://api.github.com/repos/bafolts/terraforming-mars/hooks","issue_events_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/events{/number}","events_url":"https://api.github.com/repos/bafolts/terraforming-mars/events","assignees_url":"https://api.github.com/repos/bafolts/terraforming-mars/assignees{/user}","branches_url":"https://api.github.com/repos/bafolts/terraforming-mars/branches{/branch}","tags_url":"https://api.github.com/repos/bafolts/terraforming-mars/tags","blobs_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/refs{/sha}","trees_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bafolts/terraforming-mars/statuses/{sha}","languages_url":"https://api.github.com/repos/bafolts/terraforming-mars/languages","stargazers_url":"https://api.github.com/repos/bafolts/terraforming-mars/stargazers","contributors_url":"https://api.github.com/repos/bafolts/terraforming-mars/contributors","subscribers_url":"https://api.github.com/repos/bafolts/terraforming-mars/subscribers","subscription_url":"https://api.github.com/repos/bafolts/terraforming-mars/subscription","commits_url":"https://api.github.com/repos/bafolts/terraforming-mars/commits{/sha}","git_commits_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/commits{/sha}","comments_url":"https://api.github.com/repos/bafolts/terraforming-mars/comments{/number}","issue_comment_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/comments{/number}","contents_url":"https://api.github.com/repos/bafolts/terraforming-mars/contents/{+path}","compare_url":"https://api.github.com/repos/bafolts/terraforming-mars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bafolts/terraforming-mars/merges","archive_url":"https://api.github.com/repos/bafolts/terraforming-mars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bafolts/terraforming-mars/downloads","issues_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues{/number}","pulls_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls{/number}","milestones_url":"https://api.github.com/repos/bafolts/terraforming-mars/milestones{/number}","notifications_url":"https://api.github.com/repos/bafolts/terraforming-mars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bafolts/terraforming-mars/labels{/name}","releases_url":"https://api.github.com/repos/bafolts/terraforming-mars/releases{/id}","deployments_url":"https://api.github.com/repos/bafolts/terraforming-mars/deployments","created_at":"2018-03-05T04:05:51Z","updated_at":"2019-12-17T20:29:24Z","pushed_at":"2019-12-17T20:56:11Z","git_url":"git://github.com/bafolts/terraforming-mars.git","ssh_url":"git@github.com:bafolts/terraforming-mars.git","clone_url":"https://github.com/bafolts/terraforming-mars.git","svn_url":"https://github.com/bafolts/terraforming-mars","homepage":null,"size":2389,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":3,"open_issues":14,"watchers":10,"default_branch":"master"}},"base":{"label":"bafolts:master","ref":"master","sha":"2690541a6cb452b92db0c563dd848c415d366847","user":{"login":"bafolts","id":2707843,"node_id":"MDQ6VXNlcjI3MDc4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2707843?v=4","gravatar_id":"","url":"https://api.github.com/users/bafolts","html_url":"https://github.com/bafolts","followers_url":"https://api.github.com/users/bafolts/followers","following_url":"https://api.github.com/users/bafolts/following{/other_user}","gists_url":"https://api.github.com/users/bafolts/gists{/gist_id}","starred_url":"https://api.github.com/users/bafolts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bafolts/subscriptions","organizations_url":"https://api.github.com/users/bafolts/orgs","repos_url":"https://api.github.com/users/bafolts/repos","events_url":"https://api.github.com/users/bafolts/events{/privacy}","received_events_url":"https://api.github.com/users/bafolts/received_events","type":"User","site_admin":false},"repo":{"id":123862990,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM4NjI5OTA=","name":"terraforming-mars","full_name":"bafolts/terraforming-mars","private":false,"owner":{"login":"bafolts","id":2707843,"node_id":"MDQ6VXNlcjI3MDc4NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2707843?v=4","gravatar_id":"","url":"https://api.github.com/users/bafolts","html_url":"https://github.com/bafolts","followers_url":"https://api.github.com/users/bafolts/followers","following_url":"https://api.github.com/users/bafolts/following{/other_user}","gists_url":"https://api.github.com/users/bafolts/gists{/gist_id}","starred_url":"https://api.github.com/users/bafolts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bafolts/subscriptions","organizations_url":"https://api.github.com/users/bafolts/orgs","repos_url":"https://api.github.com/users/bafolts/repos","events_url":"https://api.github.com/users/bafolts/events{/privacy}","received_events_url":"https://api.github.com/users/bafolts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bafolts/terraforming-mars","description":"Terraforming Mars Boardgame","fork":false,"url":"https://api.github.com/repos/bafolts/terraforming-mars","forks_url":"https://api.github.com/repos/bafolts/terraforming-mars/forks","keys_url":"https://api.github.com/repos/bafolts/terraforming-mars/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bafolts/terraforming-mars/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bafolts/terraforming-mars/teams","hooks_url":"https://api.github.com/repos/bafolts/terraforming-mars/hooks","issue_events_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/events{/number}","events_url":"https://api.github.com/repos/bafolts/terraforming-mars/events","assignees_url":"https://api.github.com/repos/bafolts/terraforming-mars/assignees{/user}","branches_url":"https://api.github.com/repos/bafolts/terraforming-mars/branches{/branch}","tags_url":"https://api.github.com/repos/bafolts/terraforming-mars/tags","blobs_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/refs{/sha}","trees_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bafolts/terraforming-mars/statuses/{sha}","languages_url":"https://api.github.com/repos/bafolts/terraforming-mars/languages","stargazers_url":"https://api.github.com/repos/bafolts/terraforming-mars/stargazers","contributors_url":"https://api.github.com/repos/bafolts/terraforming-mars/contributors","subscribers_url":"https://api.github.com/repos/bafolts/terraforming-mars/subscribers","subscription_url":"https://api.github.com/repos/bafolts/terraforming-mars/subscription","commits_url":"https://api.github.com/repos/bafolts/terraforming-mars/commits{/sha}","git_commits_url":"https://api.github.com/repos/bafolts/terraforming-mars/git/commits{/sha}","comments_url":"https://api.github.com/repos/bafolts/terraforming-mars/comments{/number}","issue_comment_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues/comments{/number}","contents_url":"https://api.github.com/repos/bafolts/terraforming-mars/contents/{+path}","compare_url":"https://api.github.com/repos/bafolts/terraforming-mars/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bafolts/terraforming-mars/merges","archive_url":"https://api.github.com/repos/bafolts/terraforming-mars/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bafolts/terraforming-mars/downloads","issues_url":"https://api.github.com/repos/bafolts/terraforming-mars/issues{/number}","pulls_url":"https://api.github.com/repos/bafolts/terraforming-mars/pulls{/number}","milestones_url":"https://api.github.com/repos/bafolts/terraforming-mars/milestones{/number}","notifications_url":"https://api.github.com/repos/bafolts/terraforming-mars/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bafolts/terraforming-mars/labels{/name}","releases_url":"https://api.github.com/repos/bafolts/terraforming-mars/releases{/id}","deployments_url":"https://api.github.com/repos/bafolts/terraforming-mars/deployments","created_at":"2018-03-05T04:05:51Z","updated_at":"2019-12-17T20:29:24Z","pushed_at":"2019-12-17T20:56:11Z","git_url":"git://github.com/bafolts/terraforming-mars.git","ssh_url":"git@github.com:bafolts/terraforming-mars.git","clone_url":"https://github.com/bafolts/terraforming-mars.git","svn_url":"https://github.com/bafolts/terraforming-mars","homepage":null,"size":2389,"stargazers_count":10,"watchers_count":10,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":14,"license":null,"forks":3,"open_issues":14,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98"},"html":{"href":"https://github.com/bafolts/terraforming-mars/pull/98"},"issue":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/issues/98"},"comments":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/bafolts/terraforming-mars/statuses/75e8c9d7256eae764aab0be559403823d614f6fd"}},"author_association":"COLLABORATOR"}}
|
{
"id": 123862990,
"name": "bafolts/terraforming-mars",
"url": "https://api.github.com/repos/bafolts/terraforming-mars"
}
|
{
"id": 2707843,
"login": "bafolts",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2707843?",
"url": "https://api.github.com/users/bafolts"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-18T01:34:04 |
11112445358
|
{"actor":{"display_login":"bafolts"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/comments/319607320","pull_request_review_id":282157697,"id":319607320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTYwNzMyMA==","diff_hunk":"@@ -9,24 +11,23 @@\n android:roundIcon=\"@mipmap/ic_launcher_round\"\n android:supportsRtl=\"true\"\n android:theme=\"@style/AppTheme\">\n+ <activity android:name=\".movieList.view.MovieListActivity\"","path":"app/src/main/AndroidManifest.xml","position":14,"original_position":14,"commit_id":"90d21d0a626e695ec63dfde35d923772b7d102bc","original_commit_id":"90d21d0a626e695ec63dfde35d923772b7d102bc","user":{"login":"ricardomorsch","id":12687768,"node_id":"MDQ6VXNlcjEyNjg3NzY4","avatar_url":"https://avatars2.githubusercontent.com/u/12687768?v=4","gravatar_id":"","url":"https://api.github.com/users/ricardomorsch","html_url":"https://github.com/ricardomorsch","followers_url":"https://api.github.com/users/ricardomorsch/followers","following_url":"https://api.github.com/users/ricardomorsch/following{/other_user}","gists_url":"https://api.github.com/users/ricardomorsch/gists{/gist_id}","starred_url":"https://api.github.com/users/ricardomorsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricardomorsch/subscriptions","organizations_url":"https://api.github.com/users/ricardomorsch/orgs","repos_url":"https://api.github.com/users/ricardomorsch/repos","events_url":"https://api.github.com/users/ricardomorsch/events{/privacy}","received_events_url":"https://api.github.com/users/ricardomorsch/received_events","type":"User","site_admin":false},"body":"inserir espaco entre as tags","created_at":"2019-08-30T17:26:08Z","updated_at":"2019-08-30T17:26:08Z","html_url":"https://github.com/mayara21/MoviePlayer/pull/12#discussion_r319607320","pull_request_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/comments/319607320"},"html":{"href":"https://github.com/mayara21/MoviePlayer/pull/12#discussion_r319607320"},"pull_request":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12","id":312755406,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyNzU1NDA2","html_url":"https://github.com/mayara21/MoviePlayer/pull/12","diff_url":"https://github.com/mayara21/MoviePlayer/pull/12.diff","patch_url":"https://github.com/mayara21/MoviePlayer/pull/12.patch","issue_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/12","number":12,"state":"open","locked":false,"title":"Feature/use case show movies","user":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"body":"Closes #8 ","created_at":"2019-08-30T14:06:30Z","updated_at":"2019-08-30T17:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02568834c1dd066ebd863c69e0c5e8a65628a687","assignee":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"assignees":[{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"LuisIacob","id":7443772,"node_id":"MDQ6VXNlcjc0NDM3NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/7443772?v=4","gravatar_id":"","url":"https://api.github.com/users/LuisIacob","html_url":"https://github.com/LuisIacob","followers_url":"https://api.github.com/users/LuisIacob/followers","following_url":"https://api.github.com/users/LuisIacob/following{/other_user}","gists_url":"https://api.github.com/users/LuisIacob/gists{/gist_id}","starred_url":"https://api.github.com/users/LuisIacob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuisIacob/subscriptions","organizations_url":"https://api.github.com/users/LuisIacob/orgs","repos_url":"https://api.github.com/users/LuisIacob/repos","events_url":"https://api.github.com/users/LuisIacob/events{/privacy}","received_events_url":"https://api.github.com/users/LuisIacob/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12/commits","review_comments_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12/comments","review_comment_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/12/comments","statuses_url":"https://api.github.com/repos/mayara21/MoviePlayer/statuses/90d21d0a626e695ec63dfde35d923772b7d102bc","head":{"label":"mayara21:feature/use_case_show_movies","ref":"feature/use_case_show_movies","sha":"90d21d0a626e695ec63dfde35d923772b7d102bc","user":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"repo":{"id":201113679,"node_id":"MDEwOlJlcG9zaXRvcnkyMDExMTM2Nzk=","name":"MoviePlayer","full_name":"mayara21/MoviePlayer","private":false,"owner":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mayara21/MoviePlayer","description":null,"fork":false,"url":"https://api.github.com/repos/mayara21/MoviePlayer","forks_url":"https://api.github.com/repos/mayara21/MoviePlayer/forks","keys_url":"https://api.github.com/repos/mayara21/MoviePlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayara21/MoviePlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayara21/MoviePlayer/teams","hooks_url":"https://api.github.com/repos/mayara21/MoviePlayer/hooks","issue_events_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/events{/number}","events_url":"https://api.github.com/repos/mayara21/MoviePlayer/events","assignees_url":"https://api.github.com/repos/mayara21/MoviePlayer/assignees{/user}","branches_url":"https://api.github.com/repos/mayara21/MoviePlayer/branches{/branch}","tags_url":"https://api.github.com/repos/mayara21/MoviePlayer/tags","blobs_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayara21/MoviePlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/mayara21/MoviePlayer/languages","stargazers_url":"https://api.github.com/repos/mayara21/MoviePlayer/stargazers","contributors_url":"https://api.github.com/repos/mayara21/MoviePlayer/contributors","subscribers_url":"https://api.github.com/repos/mayara21/MoviePlayer/subscribers","subscription_url":"https://api.github.com/repos/mayara21/MoviePlayer/subscription","commits_url":"https://api.github.com/repos/mayara21/MoviePlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayara21/MoviePlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mayara21/MoviePlayer/contents/{+path}","compare_url":"https://api.github.com/repos/mayara21/MoviePlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayara21/MoviePlayer/merges","archive_url":"https://api.github.com/repos/mayara21/MoviePlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayara21/MoviePlayer/downloads","issues_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues{/number}","pulls_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/mayara21/MoviePlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/mayara21/MoviePlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayara21/MoviePlayer/labels{/name}","releases_url":"https://api.github.com/repos/mayara21/MoviePlayer/releases{/id}","deployments_url":"https://api.github.com/repos/mayara21/MoviePlayer/deployments","created_at":"2019-08-07T19:19:41Z","updated_at":"2019-08-27T21:12:01Z","pushed_at":"2019-08-30T14:06:31Z","git_url":"git://github.com/mayara21/MoviePlayer.git","ssh_url":"git@github.com:mayara21/MoviePlayer.git","clone_url":"https://github.com/mayara21/MoviePlayer.git","svn_url":"https://github.com/mayara21/MoviePlayer","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"mayara21:master","ref":"master","sha":"6579042c4f6b2b0147807517dfb9c673de9eb439","user":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"repo":{"id":201113679,"node_id":"MDEwOlJlcG9zaXRvcnkyMDExMTM2Nzk=","name":"MoviePlayer","full_name":"mayara21/MoviePlayer","private":false,"owner":{"login":"mayara21","id":18338001,"node_id":"MDQ6VXNlcjE4MzM4MDAx","avatar_url":"https://avatars1.githubusercontent.com/u/18338001?v=4","gravatar_id":"","url":"https://api.github.com/users/mayara21","html_url":"https://github.com/mayara21","followers_url":"https://api.github.com/users/mayara21/followers","following_url":"https://api.github.com/users/mayara21/following{/other_user}","gists_url":"https://api.github.com/users/mayara21/gists{/gist_id}","starred_url":"https://api.github.com/users/mayara21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayara21/subscriptions","organizations_url":"https://api.github.com/users/mayara21/orgs","repos_url":"https://api.github.com/users/mayara21/repos","events_url":"https://api.github.com/users/mayara21/events{/privacy}","received_events_url":"https://api.github.com/users/mayara21/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mayara21/MoviePlayer","description":null,"fork":false,"url":"https://api.github.com/repos/mayara21/MoviePlayer","forks_url":"https://api.github.com/repos/mayara21/MoviePlayer/forks","keys_url":"https://api.github.com/repos/mayara21/MoviePlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mayara21/MoviePlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mayara21/MoviePlayer/teams","hooks_url":"https://api.github.com/repos/mayara21/MoviePlayer/hooks","issue_events_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/events{/number}","events_url":"https://api.github.com/repos/mayara21/MoviePlayer/events","assignees_url":"https://api.github.com/repos/mayara21/MoviePlayer/assignees{/user}","branches_url":"https://api.github.com/repos/mayara21/MoviePlayer/branches{/branch}","tags_url":"https://api.github.com/repos/mayara21/MoviePlayer/tags","blobs_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mayara21/MoviePlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/mayara21/MoviePlayer/languages","stargazers_url":"https://api.github.com/repos/mayara21/MoviePlayer/stargazers","contributors_url":"https://api.github.com/repos/mayara21/MoviePlayer/contributors","subscribers_url":"https://api.github.com/repos/mayara21/MoviePlayer/subscribers","subscription_url":"https://api.github.com/repos/mayara21/MoviePlayer/subscription","commits_url":"https://api.github.com/repos/mayara21/MoviePlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mayara21/MoviePlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mayara21/MoviePlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mayara21/MoviePlayer/contents/{+path}","compare_url":"https://api.github.com/repos/mayara21/MoviePlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mayara21/MoviePlayer/merges","archive_url":"https://api.github.com/repos/mayara21/MoviePlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mayara21/MoviePlayer/downloads","issues_url":"https://api.github.com/repos/mayara21/MoviePlayer/issues{/number}","pulls_url":"https://api.github.com/repos/mayara21/MoviePlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/mayara21/MoviePlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/mayara21/MoviePlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mayara21/MoviePlayer/labels{/name}","releases_url":"https://api.github.com/repos/mayara21/MoviePlayer/releases{/id}","deployments_url":"https://api.github.com/repos/mayara21/MoviePlayer/deployments","created_at":"2019-08-07T19:19:41Z","updated_at":"2019-08-27T21:12:01Z","pushed_at":"2019-08-30T14:06:31Z","git_url":"git://github.com/mayara21/MoviePlayer.git","ssh_url":"git@github.com:mayara21/MoviePlayer.git","clone_url":"https://github.com/mayara21/MoviePlayer.git","svn_url":"https://github.com/mayara21/MoviePlayer","homepage":null,"size":175,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12"},"html":{"href":"https://github.com/mayara21/MoviePlayer/pull/12"},"issue":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/issues/12"},"comments":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/mayara21/MoviePlayer/statuses/90d21d0a626e695ec63dfde35d923772b7d102bc"}},"author_association":"OWNER"}}
|
{
"id": 201113679,
"name": "mayara21/MoviePlayer",
"url": "https://api.github.com/repos/mayara21/MoviePlayer"
}
|
{
"id": 12687768,
"login": "ricardomorsch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12687768?",
"url": "https://api.github.com/users/ricardomorsch"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-08-30T17:26:08 |
10319408259
|
{"actor":{"display_login":"ricardomorsch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/JYPark09/OGo/pulls/comments/361792551","pull_request_review_id":336913816,"id":361792551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTc5MjU1MQ==","diff_hunk":"@@ -0,0 +1,427 @@\n+// Copyright(C) 2019 Junyeong Park\n+\n+#include <OGo/Board/Board.hpp>\n+\n+#include <iomanip>\n+#include <numeric>\n+#include <sstream>\n+\n+namespace OGo\n+{\n+Board::Board(float komi) : komi_(komi)\n+{\n+ Clear();\n+}\n+\n+void Board::Clear()\n+{\n+ std::fill(begin(board_), end(board_), StoneType::INVALID);\n+ std::fill(begin(parent_), end(parent_), EXTENDED_BOARD_POINTS);\n+ std::fill(begin(neighbors_), end(neighbors_), 0);\n+ std::fill(begin(liberties_), end(liberties_), 0);\n+\n+ for (int y = 0; y < BOARD_SIZE; ++y)\n+ {\n+ for (int x = 0; x < BOARD_SIZE; ++x)\n+ {\n+ const Action pt(x, y);\n+\n+ board_[pt] = StoneType::NONE;\n+\n+ if (x == 0 || x == BOARD_SIZE - 1)\n+ {\n+ neighbors_[pt] += (1 << shift(StoneType::NONE));\n+ }\n+ else\n+ {\n+ neighbors_[pt] += (2 << shift(StoneType::NONE));\n+ }\n+\n+ if (y == 0 || y == BOARD_SIZE - 1)\n+ {\n+ neighbors_[pt] += (1 << shift(StoneType::NONE));\n+ }\n+ else\n+ {\n+ neighbors_[pt] += (2 << shift(StoneType::NONE));\n+ }\n+ }\n+ }\n+\n+ current_ = StoneType::BLACK;\n+ std::fill(begin(prisoners_), end(prisoners_), 0u);\n+ history_.clear();\n+ past_.clear();\n+ finish_ = false;\n+ winner_ = StoneType::INVALID;\n+ ko_ = Pass;\n+\n+ next_[EXTENDED_BOARD_POINTS] = EXTENDED_BOARD_POINTS;\n+ parent_[EXTENDED_BOARD_POINTS] = EXTENDED_BOARD_POINTS;\n+ liberties_[EXTENDED_BOARD_POINTS] = std::numeric_limits<std::size_t>::max();\n+}\n+\n+std::string Board::ToString() const\n+{\n+ std::stringstream ss;\n+ static std::string coord_str = \"ABCDEFGHJKLMNOPQRSTUVWXYZ\";\n+\n+ ss << \" \";\n+ for (int i = 0; i < BOARD_SIZE; ++i)\n+ ss << coord_str[i] << ' ';\n+\n+ ss << std::endl;\n+\n+ for (int y = BOARD_SIZE - 1; y >= 0; --y)\n+ {\n+ ss << std::setw(2) << std::setfill('0') << y + 1 << ' ';\n+\n+ for (int x = 0; x < BOARD_SIZE; ++x)\n+ {\n+ const auto color = At(Action(x, y));\n+\n+ if (color == StoneType::NONE)\n+ ss << \"��\";","path":"Sources/OGo/Board/Board.cc","position":84,"original_position":84,"commit_id":"e20ad4d32a5909257c1e41ec0c696bb4bb4c5be6","original_commit_id":"e20ad4d32a5909257c1e41ec0c696bb4bb4c5be6","user":{"login":"ShyRoute","id":51230706,"node_id":"MDQ6VXNlcjUxMjMwNzA2","avatar_url":"https://avatars2.githubusercontent.com/u/51230706?v=4","gravatar_id":"","url":"https://api.github.com/users/ShyRoute","html_url":"https://github.com/ShyRoute","followers_url":"https://api.github.com/users/ShyRoute/followers","following_url":"https://api.github.com/users/ShyRoute/following{/other_user}","gists_url":"https://api.github.com/users/ShyRoute/gists{/gist_id}","starred_url":"https://api.github.com/users/ShyRoute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShyRoute/subscriptions","organizations_url":"https://api.github.com/users/ShyRoute/orgs","repos_url":"https://api.github.com/users/ShyRoute/repos","events_url":"https://api.github.com/users/ShyRoute/events{/privacy}","received_events_url":"https://api.github.com/users/ShyRoute/received_events","type":"User","site_admin":false},"body":"인코딩이 깨진 것 같습니다.","created_at":"2019-12-28T12:17:48Z","updated_at":"2019-12-28T12:17:48Z","html_url":"https://github.com/JYPark09/OGo/pull/1#discussion_r361792551","pull_request_url":"https://api.github.com/repos/JYPark09/OGo/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/comments/361792551"},"html":{"href":"https://github.com/JYPark09/OGo/pull/1#discussion_r361792551"},"pull_request":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/JYPark09/OGo/pulls/1","id":357441708,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NDQxNzA4","html_url":"https://github.com/JYPark09/OGo/pull/1","diff_url":"https://github.com/JYPark09/OGo/pull/1.diff","patch_url":"https://github.com/JYPark09/OGo/pull/1.patch","issue_url":"https://api.github.com/repos/JYPark09/OGo/issues/1","number":1,"state":"open","locked":false,"title":"Implementation Board","user":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"body":"This revision includes:\r\n\r\n- Create `Board` class\r\n- Create `Action` class","created_at":"2019-12-28T11:11:32Z","updated_at":"2019-12-28T12:17:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78859bbe84be6355883d047cc95db32a19e63141","assignee":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"assignees":[{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JYPark09/OGo/pulls/1/commits","review_comments_url":"https://api.github.com/repos/JYPark09/OGo/pulls/1/comments","review_comment_url":"https://api.github.com/repos/JYPark09/OGo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JYPark09/OGo/issues/1/comments","statuses_url":"https://api.github.com/repos/JYPark09/OGo/statuses/e20ad4d32a5909257c1e41ec0c696bb4bb4c5be6","head":{"label":"JYPark09:board","ref":"board","sha":"e20ad4d32a5909257c1e41ec0c696bb4bb4c5be6","user":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"repo":{"id":230443201,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA0NDMyMDE=","name":"OGo","full_name":"JYPark09/OGo","private":false,"owner":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JYPark09/OGo","description":null,"fork":false,"url":"https://api.github.com/repos/JYPark09/OGo","forks_url":"https://api.github.com/repos/JYPark09/OGo/forks","keys_url":"https://api.github.com/repos/JYPark09/OGo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JYPark09/OGo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JYPark09/OGo/teams","hooks_url":"https://api.github.com/repos/JYPark09/OGo/hooks","issue_events_url":"https://api.github.com/repos/JYPark09/OGo/issues/events{/number}","events_url":"https://api.github.com/repos/JYPark09/OGo/events","assignees_url":"https://api.github.com/repos/JYPark09/OGo/assignees{/user}","branches_url":"https://api.github.com/repos/JYPark09/OGo/branches{/branch}","tags_url":"https://api.github.com/repos/JYPark09/OGo/tags","blobs_url":"https://api.github.com/repos/JYPark09/OGo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JYPark09/OGo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JYPark09/OGo/git/refs{/sha}","trees_url":"https://api.github.com/repos/JYPark09/OGo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JYPark09/OGo/statuses/{sha}","languages_url":"https://api.github.com/repos/JYPark09/OGo/languages","stargazers_url":"https://api.github.com/repos/JYPark09/OGo/stargazers","contributors_url":"https://api.github.com/repos/JYPark09/OGo/contributors","subscribers_url":"https://api.github.com/repos/JYPark09/OGo/subscribers","subscription_url":"https://api.github.com/repos/JYPark09/OGo/subscription","commits_url":"https://api.github.com/repos/JYPark09/OGo/commits{/sha}","git_commits_url":"https://api.github.com/repos/JYPark09/OGo/git/commits{/sha}","comments_url":"https://api.github.com/repos/JYPark09/OGo/comments{/number}","issue_comment_url":"https://api.github.com/repos/JYPark09/OGo/issues/comments{/number}","contents_url":"https://api.github.com/repos/JYPark09/OGo/contents/{+path}","compare_url":"https://api.github.com/repos/JYPark09/OGo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JYPark09/OGo/merges","archive_url":"https://api.github.com/repos/JYPark09/OGo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JYPark09/OGo/downloads","issues_url":"https://api.github.com/repos/JYPark09/OGo/issues{/number}","pulls_url":"https://api.github.com/repos/JYPark09/OGo/pulls{/number}","milestones_url":"https://api.github.com/repos/JYPark09/OGo/milestones{/number}","notifications_url":"https://api.github.com/repos/JYPark09/OGo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JYPark09/OGo/labels{/name}","releases_url":"https://api.github.com/repos/JYPark09/OGo/releases{/id}","deployments_url":"https://api.github.com/repos/JYPark09/OGo/deployments","created_at":"2019-12-27T12:49:39Z","updated_at":"2019-12-27T12:49:43Z","pushed_at":"2019-12-28T11:59:59Z","git_url":"git://github.com/JYPark09/OGo.git","ssh_url":"git@github.com:JYPark09/OGo.git","clone_url":"https://github.com/JYPark09/OGo.git","svn_url":"https://github.com/JYPark09/OGo","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"JYPark09:master","ref":"master","sha":"401dace09306957573d6c82a68d1cf11db4a4522","user":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"repo":{"id":230443201,"node_id":"MDEwOlJlcG9zaXRvcnkyMzA0NDMyMDE=","name":"OGo","full_name":"JYPark09/OGo","private":false,"owner":{"login":"JYPark09","id":48042206,"node_id":"MDQ6VXNlcjQ4MDQyMjA2","avatar_url":"https://avatars2.githubusercontent.com/u/48042206?v=4","gravatar_id":"","url":"https://api.github.com/users/JYPark09","html_url":"https://github.com/JYPark09","followers_url":"https://api.github.com/users/JYPark09/followers","following_url":"https://api.github.com/users/JYPark09/following{/other_user}","gists_url":"https://api.github.com/users/JYPark09/gists{/gist_id}","starred_url":"https://api.github.com/users/JYPark09/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JYPark09/subscriptions","organizations_url":"https://api.github.com/users/JYPark09/orgs","repos_url":"https://api.github.com/users/JYPark09/repos","events_url":"https://api.github.com/users/JYPark09/events{/privacy}","received_events_url":"https://api.github.com/users/JYPark09/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JYPark09/OGo","description":null,"fork":false,"url":"https://api.github.com/repos/JYPark09/OGo","forks_url":"https://api.github.com/repos/JYPark09/OGo/forks","keys_url":"https://api.github.com/repos/JYPark09/OGo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JYPark09/OGo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JYPark09/OGo/teams","hooks_url":"https://api.github.com/repos/JYPark09/OGo/hooks","issue_events_url":"https://api.github.com/repos/JYPark09/OGo/issues/events{/number}","events_url":"https://api.github.com/repos/JYPark09/OGo/events","assignees_url":"https://api.github.com/repos/JYPark09/OGo/assignees{/user}","branches_url":"https://api.github.com/repos/JYPark09/OGo/branches{/branch}","tags_url":"https://api.github.com/repos/JYPark09/OGo/tags","blobs_url":"https://api.github.com/repos/JYPark09/OGo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JYPark09/OGo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JYPark09/OGo/git/refs{/sha}","trees_url":"https://api.github.com/repos/JYPark09/OGo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JYPark09/OGo/statuses/{sha}","languages_url":"https://api.github.com/repos/JYPark09/OGo/languages","stargazers_url":"https://api.github.com/repos/JYPark09/OGo/stargazers","contributors_url":"https://api.github.com/repos/JYPark09/OGo/contributors","subscribers_url":"https://api.github.com/repos/JYPark09/OGo/subscribers","subscription_url":"https://api.github.com/repos/JYPark09/OGo/subscription","commits_url":"https://api.github.com/repos/JYPark09/OGo/commits{/sha}","git_commits_url":"https://api.github.com/repos/JYPark09/OGo/git/commits{/sha}","comments_url":"https://api.github.com/repos/JYPark09/OGo/comments{/number}","issue_comment_url":"https://api.github.com/repos/JYPark09/OGo/issues/comments{/number}","contents_url":"https://api.github.com/repos/JYPark09/OGo/contents/{+path}","compare_url":"https://api.github.com/repos/JYPark09/OGo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JYPark09/OGo/merges","archive_url":"https://api.github.com/repos/JYPark09/OGo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JYPark09/OGo/downloads","issues_url":"https://api.github.com/repos/JYPark09/OGo/issues{/number}","pulls_url":"https://api.github.com/repos/JYPark09/OGo/pulls{/number}","milestones_url":"https://api.github.com/repos/JYPark09/OGo/milestones{/number}","notifications_url":"https://api.github.com/repos/JYPark09/OGo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JYPark09/OGo/labels{/name}","releases_url":"https://api.github.com/repos/JYPark09/OGo/releases{/id}","deployments_url":"https://api.github.com/repos/JYPark09/OGo/deployments","created_at":"2019-12-27T12:49:39Z","updated_at":"2019-12-27T12:49:43Z","pushed_at":"2019-12-28T11:59:59Z","git_url":"git://github.com/JYPark09/OGo.git","ssh_url":"git@github.com:JYPark09/OGo.git","clone_url":"https://github.com/JYPark09/OGo.git","svn_url":"https://github.com/JYPark09/OGo","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/1"},"html":{"href":"https://github.com/JYPark09/OGo/pull/1"},"issue":{"href":"https://api.github.com/repos/JYPark09/OGo/issues/1"},"comments":{"href":"https://api.github.com/repos/JYPark09/OGo/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JYPark09/OGo/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/JYPark09/OGo/statuses/e20ad4d32a5909257c1e41ec0c696bb4bb4c5be6"}},"author_association":"OWNER"}}
|
{
"id": 230443201,
"name": "JYPark09/OGo",
"url": "https://api.github.com/repos/JYPark09/OGo"
}
|
{
"id": 51230706,
"login": "ShyRoute",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/51230706?",
"url": "https://api.github.com/users/ShyRoute"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-28T12:17:48 |
11170259999
|
{"actor":{"display_login":"ShyRoute"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments/279203664","pull_request_review_id":231477710,"id":279203664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTIwMzY2NA==","diff_hunk":"@@ -655,149 +655,288 @@ mission \"Remnant: Learn Sign Follow Up\"\n \n \n \n+mission \"Remnant: Tech Retrieval\"\n+\tname \"Remnant Human Tech Retrieval\"\n+\tdescription \"The Remnant are interested in learning what advances humanity has made over the past centuries. Bring them samples of advanced technology.\"\n+\tsource \"Viminal\"\n+\tto offer\n+\t\thas \"Remnant: Technology Available: offered\"\n+\t\trandom < 30\n+\ton offer\n+\t\t\"remnant taely\" ++\n+\t\tconversation\n+\t\t\t`As you enter the spaceport, you notice someone across the plaza appears to have been waiting for you. A tall, solidly built woman in short sleaved coveralls stands up from where she was sitting at the information desk. With a few quick gestures at the person behind the counter, she heads towards you with a confident stride. As she approaches you note that the crowds of people moving around the plaza seem to staying out of her way as if she was somone important. In contrast, the tools at her belt and the wear marks on her clothing suggest someone who is more comfortable inside a ship access duct than behind a desk.`\n+\t\t\t`\tBefore you can decide if you want to avoid this person or not, she is standing in front of you, clearing her throat. \"You are captain <first> <last> of the <ship>?\" She asks in a lyrical chant.`\n+\t\t\tchoice\n+\t\t\t\t`\t\"That's me.\"`\n+\t\t\t\t\tgoto admit\n+\t\t\t\t`\t\"I don't know who that is.\"`\n+\t\t\t`\tShe looks at you with an unscrutable expression for a moment. \"Trying to be inconspicuous is admirable. Being oblivious to the fact that you stand out like a star in empty space is not.\"`\n+\t\t\tlabel admit\n+\t\t\t`\t\"I have an opportunity for you, if you are interested in being helpful to the Remnant.\" When you express your interest she leads you over to a balcony overlooking the primary shipyards. As she leans on the railing a cold breeze makes you shiver, but she seems oblivious to it. \"As a prefect among the Remnant, I am responsible for this,\" she gestures at the shipyards, where you can see a myriad of the Remnant's alien-looking ships in various stages of construction or repair. \"The ships we have serve us well, but they are old designs. Only the Gull is comparatively new. We need new ideas, new inspiration.\" She pauses, focusing briefly on a small bay where several people appear to be pulling what looks like a supercapacitor out of a gascraft.`\n+\t\t\tchoice\n+\t\t\t\t`\t\"So, what are you asking?\"`\n+\t\t\t\t\tgoto request\n+\t\t\t\t`\t\"What are they doing?\"`\n+\t\t\t`\t\"Oh, those are apprentices,\" she trills with a touch of amusement. \"They need to learn how to handle unusual tech. One of the first steps is to deal with old tech. Like salvaging an obslete supercapacitor out of that grascraft so it can be reprocessed into something useful, and replacing it with newer integrated energy storage.\" She glances at you in amusement. \"You've flown the gascraft, you know how old that ship is: Primitive energy systems, antique 'hard-shell' shields that have to be manually raised and lowered...\" she trails off into momentary silence. \"Be glad that you got one that had already been refurbished for your visit to Nenia. At least it had modern engines and an updated sensor array.\"`\n+\t\t\tlabel request\n+\t\t\t`\t\"To the point,\" her tone shifts to a more martial cadence. \"We want to know how humanity has advanced in the past five and a half centuries. If you found us, I am sure it is only a matter of time until the Alphas, their servants, or others intent on galactic domination discover us. We need to know what sort of weapons they will be wielding, how their ships will be protected, and how fast they can travel in deep space.\"`\n+\t\t\tchoice\n+\t\t\t\t`\"Could you elaborate on 'how fast they can travel in deep space?\"`\n+\t\t\t\t`\"OK, I will see what I can find.\"`\n+\t\t\t\t\tgoto find\n+\t\t\t\t`\"No, I don't want to get involved in this.\"`\n+\t\t\t\t\tgoto nothelp\n+\t\t\t`\tShe considers her thoughts briefly, then chants, \"How fast a ship can move through an area of deep space basically depends on how fast they can collect fuel. Ramscoops were common at the time of the exodus, and if humanity has developped better ramscoops or other means of generating fuel, these would significantly improve their speed at exploring or crossing large volumes of space.\"`\n+\t\t\tchoice\n+\t\t\t\t`\"OK, I will see what I can find.\"`\n+\t\t\t\t`\"No, I don't want to get involved in this.\"`\n+\t\t\t\t\tgoto nothelp\n+\t\t\tlabel find\n+\t\t\t`\tTaely nods \"I will look forward to seeing what you find. In the meantime, I should get back to work.\" With that, she swings over the railing and climbs quickly down the wall in the direction of the shipyard, seemingly unconcerned about the height.`\n+\t\t\tlabel nothelp\n+\t\t\t`\tTaely looks at you with a blank expression, then chants in a monotone voice \"If that is your choice, you are unlikely to find much of interest to do among us.\" With that, she vaults over the edge of the railing and drops from view. As you quickly peer over the railing, you discover that she had must have caught a handhold somehow, as she is rapidly moving down the wall in a controlled fashion with ease of a spider.`\n+\t\t\t\tdecline\n+\tto complete\n+\t\tor\n+\t\t\thas \"Remnant: Heavy Laser: done\"\n+\t\t\thas \"Remnant: Catalytic Ramscoop: done\"\n+\t\t\thas \"Remnant: Plasma Cannons: done\"\n+\t\t\thas \"Remnant: Electron Beam: done\"\n+\t\t\thas \"Remnant: D94-YV Shield Generator: done\"\n+\t\t\thas \"Remnant: S-970 Regenerator: done\"\n+\n+\n+\n mission \"Remnant: Heavy Laser\"\n \tname \"Retrieve Heavy Lasers for the Remnant\"\n-\tdescription \"A Remnant engineer on <planet> has offered to pay you <payment> in exchange for obtaining two heavy lasers for them to study.\"\n+\tdescription \"A Remnant engineer has offered to pay you <payment> in return for delivering two heavy lasers to <planet> for them to study.\"\n \tminor\n-\tsource\n+\tsource \"Viminal\"\n+\tdestination\n \t\tgovernment \"Remnant\"\n \tto offer\n-\t\thas \"Remnant: Technology Available: offered\"\n-\t\tnot \"Remnant: Catalytic Ramscoop: active\"\n-\t\tnot \"Remnant: Catalytic Ramscoop: done\"\n-\t\tnot \"Remnant: Plasma Cannons: active\"\n-\t\tnot \"Remnant: Plasma Cannons: done\"\n-\t\trandom < 50\n+\t\tor\n+\t\t\thas \"Remnant: Tech Retrieval: active\"\n+\t\t\thas \"Remnant: Tech Retrieval: done\"\n \ton offer\n \t\trequire \"Heavy Laser\"\n \t\tconversation\n-\t\t\t`As you are browsing the spaceport shops, a woman approaches you and introduces herself as a researcher at one of the Remnant weapons facilities. She awkwardly pauses before beginning to recite a quick tune: \"We can see that your ship has beam weapons that match human techniques, but are unlike anything we have record of. What kind of weapons are they?\"`\n+\t\t\t`You remember that Taely was interested in seeing examples of technology from human space. Would you like to show her your heavy laser canons?`\n \t\t\tchoice\n-\t\t\t\t`\t\"They're heavy lasers.\"`\n-\t\t\t\t`\t\"I'd rather not share that.\"`\n-\t\t\t\t\tdecline\n-\t\t\t\n-\t\t\t`\t\"Really? Our records indicate that humanity had primitive laser technology at the time of the Exodus, but nothing that would be considered useful as weapons.\" She pauses to look down at her scanner. \"And yet our scans indicate that they are capable of significant power output.`\n-\t\t\t`\t\"Based on these scans, we may well be able to learn quite a bit from these weapons. Would you be able to acquire a pair of them for us? We could offer you very good compensation for doing so.\"`\n-\t\t\tchoice\n-\t\t\t\t`\t\"Sure, I would be glad to accept that deal.\"`\n-\t\t\t\t`\t\"Sorry, I'm not really interested in helping Remnant research.\"`\n-\t\t\t\t\tdecline\n-\n-\t\t\t`\tAfter a bit of haggling, she agrees to pay you <payment> in exchange for two heavy lasers.`\n+\t\t\t\t`\tNot now.`\n+\t\t\t\t\tdefer\n+\t\t\t\t`\tYes.`\n+\t\t\tbranch stuff\n+\t\t\t\thas \"Remnant Tech Retrieval: done\"\n+\t\t\t`\tAfter asking a few people, you finally get directed to a bay in the shipyard where you find Taely just finishing the installation of a thrasher cannon in a starling. \"Greetings, <first>. I'll be down in a minute.\" She does a few more things inside a panel, reseals the hatch, and slides down a fin to land next to you. \"So, do you have something for me?\"`\n+\t\t\t\tgoto the_rest\n+\t\t\tlabel stuff\n+\t\t\t`\tRemembering that she spends most of her time in the shipyard, you head straight there and ask the nearest mechanic. They direct you to a large hanger tucked into a cliff face, where you find her working at a terminal filled with schematics. Behind her, the room fades quickly into darkness where you can faintly make out what appears to be a large tank and a lot of whirring machinery. As you approach she looks up from her work and turns to face you. \"Ah, you have returned. Do you have something new for me?\"`\n+\t\t\tlabel the_rest\n+\t\t\t`\tYou lead her back to your ship, where you show her the heavy laser cannon. \"A laser cannon?\" she asks. \"Our records indicate that humanity had primitive laser technology at the time of the Exodus, but nothing that would be considered useful as weapons.\" She pauses to look down at her scanner. \"And yet my scans indicate that they are capable of significant power output.\" She pauses for a moment before continuing, \"These could be quite useful to examine more thoroughly. Please deliver two of these heavy laser cannons to a research team on <planet>.\"`\n \t\t\t\taccept\n \ton complete\n \t\toutfit \"Heavy Laser\" -2\n \t\tpayment 870000\n \t\t\"remnant met taely\" ++\n \t\tconversation\n-\t\t\t`As you land on a pad adjacent to the research center, a group of researchers mount some kind of weapon on a platform aimed down a firing range. The researcher that asked you for the heavy lasers presses a button from behind a thick barrier to activate the weapon. A flash of light erupts from the muzzle as the target downrange is cut in half. The barrel of the weapon raises into the air and the researchers rush out onto the range with tools and devices to inspect the damage.`\n-\t\t\t`\tThe researcher approaches you while the heavy lasers are being unloaded from your ship. She's dusty, but appears pleased with the results of her experiments. \"Captain <first>, I see you have the lasers as we agreed.\" You aren't sure if Remnant rub their hands in eagerness, but she looks ready to do so.`\n-\t\t\t`\tShe taps her commlink, and moments later another Remnant appears from the scaffolding around a nearby Starling. The researcher straightens up and switches to a more stately melody. \"Captain <last>, this is Prefect Taely. She is our most experienced engineer for dealing with alien tech.\"`\n-\t\t\t`\tTaely steps forward and makes what seems to be a kind of welcoming gesture. \"Greetings Captain. We appreciate your help in acquiring these samples. It looks like we are far behind the rest of humanity in some respects. We have a lot of work to do if we are to catch up with them.\"`\n+\t\t\t`As you land on a pad adjacent to the research center, a group of researchers mount some kind of weapon on a platform aimed down a firing range. The researchers retreat behind a thick barrier and press a button to activate the weapon. A flash of light erupts from the muzzle as the target downrange is cut in half. The barrel of the weapon raises into the air and the researchers rush out onto the range with tools and devices to inspect the damage. Noticing your arrival, one of the researchers veers off and heads towards you. \"So, you are the one with the samples of humanity's laser weapons?\" chants the researcher. \"Always interesting to see new things.\" He turns and waves at a remnant standing near the edge of the landing pad with a camel hitched to a wagon.`\n+\t\t\t`\tThe researchers quickly unload the heavy lasers from your ship, and hand you a credstick with <payment>. \"Thank you for bringing us something new to examine. We appreciate the breath of fresh air.\" With that, they quickly head off into a nearby lab, escorting their cargo of weaponry on the oddly archaic transportation.`\n \n \n \n-mission \"Remnant: Catalytic Ramscoop\"\n-\tname \"Retrieve Ramscoops for the Remnant\"\n-\tdescription \"A Remnant engineer on <planet> has offered to pay you <payment> in exchange for obtaining two catalytic ramscoops for them to study.\"\n+mission \"Remnant: Plasma Cannon\"\n+\tname \"Retrieve Plasma Cannons for the Remnant\"\n+\tdescription \"A Remnant engineer has offered to pay you <payment> in exchange for delivering two plasma cannons to a team on <planet>.\"\n \tminor\n-\tsource\n+\tsource \"Viminal\"\n+\tdestination\n \t\tgovernment \"Remnant\"\n \tto offer\n-\t\thas \"Remnant: Technology Available: offered\"\n-\t\tnot \"Remnant: Plasma Cannons: active\"\n-\t\tnot \"Remnant: Plasma Cannons: done\"\n-\t\tnot \"Remnant: Heavy Laser: active\"\n-\t\tnot \"Remnant: Heavy Laser: done\"\n-\t\trandom < 50\n+\t\tor\n+\t\t\thas \"Remnant: Tech Retrieval: active\"\n+\t\t\thas \"Remnant: Tech Retrieval: done\"\n \ton offer\n-\t\trequire \"Catalytic Ramscoop\"\n+\t\trequire \"Plasma Cannon\"\n \t\tconversation\n-\t\t\t`As you are walking through the spaceport, a woman comes up to you and introduces herself as an engineer at one of the Remnant development labs. She pauses awkwardly before beginning to chant: \"As your ship is the only one we have seen in many decades that has outfits from ancestral space, we are intrigued by it. Could we take a closer look?\"`\n+\t\t\t`You remember that Taely was interested in seeing examples of technology from human space. Would you like to show her the plasma cannons you retrieved?`\n \t\t\tchoice\n-\t\t\t\t`\t\"Yes, you are welcome to examine it.\"`\n-\t\t\t\t\tgoto deep\n-\t\t\t\t`\t\"Yes, but don't touch anything.\"`\n-\t\t\t\t`\t\"No, stay away from my ship.\"`\n-\t\t\t\t\tdecline\n+\t\t\t\t`\tNot now.`\n+\t\t\t\t\tdefer\n+\t\t\t\t`\tYes.`\n+\t\t\tbranch stuff\n+\t\t\t\thas \"Remnant Tech Retrieval: done\"\n+\t\t\t`\tAfter asking a few people, you finally get directed to a bay in the shipyard where you find Taely just finishing the installation of a thrasher cannon in a starling. \"Greetings, <first>. I will be down in a minute.\" She does a few more things inside a panel, reseals the hatch, and slides down a fin to land next to you. \"So, do you have something for me?\"`\n+\t\t\t\tgoto the_rest\n+\t\t\tlabel stuff\n+\t\t\t`\tRemembering that she spends most of her time in the shipyard, you head straight there and have almost arrived when you are approached by another remnant who introduces herself as one of Taely's aides. \"Greetings, Captain\" she trills. \"Our scans picked up indications of uncatalogued human weaponry. Were you bringing it to show us?\"`\n+\t\t\tlabel the_rest\n+\t\t\t`\tYou lead her back to your ship, where you show her the plasma cannon. \"I have never seen weapons designed to handle such a high heat output! Is this some kind of plasma based weapon?\" she asks, gesturing at a cannon. You nod, and she continues, \"Intriguing. We have noticed that the Korath ships seem to run particularly hot, and have speculated that overheating them might be an effective means of disabling them. I would enjoy researching these a bit more. If you could deliver two to <planet> for us you would be well compensated.\"`\n+\t\t\t\taccept\n+\ton complete\n+\t\toutfit \"Plasma Cannon\" -2\n+\t\tpayment 1130000\n+\t\t\"remnant met taely\" ++\n+\t\tconversation\n+\t\t\t`As the <ship> settles onto the pad closest to the research facility, you can see a weapons specialist checking over a large cannon on a platform beneath a nearby Albatross. When he sees you starting to unload the two plasma cannons, he snaps the casing closed and gestures to someone out of sight. Within moments both him and an empty flatbed are there to pick up the weapons.`\n+\t\t\t`\t\"Thank you for your help,\" he says. \"Our Inhibitors provide us with something of a mobility advantage against the Korath, but they aren't particularly effective at disabling them. These plasma cannons will open new avenues of research for us.\" He pauses, then continues. \"I also included a bonus for you. It is a 'finder's fee,' as we always appreciate new tech.\"`\n+\t\t\tbranch wave\n+\t\t\t\thas \"Remnant: Learn Sign 1: done\"\n+\t\t\t`\tThe weapons technician finishes strapping down the plasma cannons and makes a gesture towards you, then heads off toward the lab.`\n+\t\t\tgoto end\n+\t\t\tlabel wave\n+\t\t\t`\tThe weapons technician finishes strapping down the plasma cannons and makes a gesture that you recognize as \"farewell,\" then heads off toward the lab.`\n+\t\t\tlabel end\n+\t\t\t`\tAs you watch the remnant heading off with their new weapons to study, you can not help but wonder what will be the result of it.`","path":"data/remnant missions.txt","position":179,"original_position":179,"commit_id":"24dea6eb732401ae7ef4dd35e02950eae05db78d","original_commit_id":"24dea6eb732401ae7ef4dd35e02950eae05db78d","user":{"login":"Fzzr","id":1037883,"node_id":"MDQ6VXNlcjEwMzc4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1037883?v=4","gravatar_id":"","url":"https://api.github.com/users/Fzzr","html_url":"https://github.com/Fzzr","followers_url":"https://api.github.com/users/Fzzr/followers","following_url":"https://api.github.com/users/Fzzr/following{/other_user}","gists_url":"https://api.github.com/users/Fzzr/gists{/gist_id}","starred_url":"https://api.github.com/users/Fzzr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fzzr/subscriptions","organizations_url":"https://api.github.com/users/Fzzr/orgs","repos_url":"https://api.github.com/users/Fzzr/repos","events_url":"https://api.github.com/users/Fzzr/events{/privacy}","received_events_url":"https://api.github.com/users/Fzzr/received_events","type":"User","site_admin":false},"body":"Capitalize \"remnant\"? There are multiple cases of this throughout the PR.","created_at":"2019-04-28T17:17:03Z","updated_at":"2019-04-28T17:19:43Z","html_url":"https://github.com/endless-sky/endless-sky/pull/4269#discussion_r279203664","pull_request_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments/279203664"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/4269#discussion_r279203664"},"pull_request":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269"}}},"pull_request":{"url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269","id":274193044,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MTkzMDQ0","html_url":"https://github.com/endless-sky/endless-sky/pull/4269","diff_url":"https://github.com/endless-sky/endless-sky/pull/4269.diff","patch_url":"https://github.com/endless-sky/endless-sky/pull/4269.patch","issue_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4269","number":4269,"state":"open","locked":false,"title":"Remnant Tech Retrieval Rewrite","user":{"login":"Zitchas","id":32169904,"node_id":"MDQ6VXNlcjMyMTY5OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/32169904?v=4","gravatar_id":"","url":"https://api.github.com/users/Zitchas","html_url":"https://github.com/Zitchas","followers_url":"https://api.github.com/users/Zitchas/followers","following_url":"https://api.github.com/users/Zitchas/following{/other_user}","gists_url":"https://api.github.com/users/Zitchas/gists{/gist_id}","starred_url":"https://api.github.com/users/Zitchas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zitchas/subscriptions","organizations_url":"https://api.github.com/users/Zitchas/orgs","repos_url":"https://api.github.com/users/Zitchas/repos","events_url":"https://api.github.com/users/Zitchas/events{/privacy}","received_events_url":"https://api.github.com/users/Zitchas/received_events","type":"User","site_admin":false},"body":"Given how many people have had problems at the human Tech Retrieval set of missions, this mission rewrites that section. It replaces the current set of three mutually exclusive and independent missions with a set of six, wherein the first mission is the first meeting with Taely and and a conversation about what the Remnant are looking for. There is then a mission for each of the subsequent five items. Completing this mission will complete the initial mission that asks the player to bring back samples of human tech.\r\n\r\nThe five tech retrieval missions are for:\r\n- Heavy Laser\r\n- Catalytic Ramscoop\r\n- Plasma Cannons\r\n- Electron Beam\r\n- D94-YV Shield Generator\r\n- S-970 Regenerator\r\n\r\nThese missions can all be done by the player, but only one is required to complete the requirement for continuing on to the salvage set. The payouts for all of them is equal to the cost for the two outfits in question + 750000\r\n\r\nNote for `Remnant: Salvage 1`: I have left the `to offer` as being an or statement including the initial three retrieval missions, and simply added the `Remnant: Tech Retrieval: done` to the list, as that retains compatibility for players who have already done those missions.","created_at":"2019-04-28T16:48:09Z","updated_at":"2019-04-28T17:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ab6821493bdca099518d40d47e31faad49b946","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269/commits","review_comments_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269/comments","review_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/4269/comments","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/24dea6eb732401ae7ef4dd35e02950eae05db78d","head":{"label":"Zitchas:RemnantTechRetrieval","ref":"RemnantTechRetrieval","sha":"24dea6eb732401ae7ef4dd35e02950eae05db78d","user":{"login":"Zitchas","id":32169904,"node_id":"MDQ6VXNlcjMyMTY5OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/32169904?v=4","gravatar_id":"","url":"https://api.github.com/users/Zitchas","html_url":"https://github.com/Zitchas","followers_url":"https://api.github.com/users/Zitchas/followers","following_url":"https://api.github.com/users/Zitchas/following{/other_user}","gists_url":"https://api.github.com/users/Zitchas/gists{/gist_id}","starred_url":"https://api.github.com/users/Zitchas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zitchas/subscriptions","organizations_url":"https://api.github.com/users/Zitchas/orgs","repos_url":"https://api.github.com/users/Zitchas/repos","events_url":"https://api.github.com/users/Zitchas/events{/privacy}","received_events_url":"https://api.github.com/users/Zitchas/received_events","type":"User","site_admin":false},"repo":{"id":136527243,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1MjcyNDM=","name":"endless-sky","full_name":"Zitchas/endless-sky","private":false,"owner":{"login":"Zitchas","id":32169904,"node_id":"MDQ6VXNlcjMyMTY5OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/32169904?v=4","gravatar_id":"","url":"https://api.github.com/users/Zitchas","html_url":"https://github.com/Zitchas","followers_url":"https://api.github.com/users/Zitchas/followers","following_url":"https://api.github.com/users/Zitchas/following{/other_user}","gists_url":"https://api.github.com/users/Zitchas/gists{/gist_id}","starred_url":"https://api.github.com/users/Zitchas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zitchas/subscriptions","organizations_url":"https://api.github.com/users/Zitchas/orgs","repos_url":"https://api.github.com/users/Zitchas/repos","events_url":"https://api.github.com/users/Zitchas/events{/privacy}","received_events_url":"https://api.github.com/users/Zitchas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Zitchas/endless-sky","description":"Space exploration, trading, and combat game.","fork":true,"url":"https://api.github.com/repos/Zitchas/endless-sky","forks_url":"https://api.github.com/repos/Zitchas/endless-sky/forks","keys_url":"https://api.github.com/repos/Zitchas/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zitchas/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zitchas/endless-sky/teams","hooks_url":"https://api.github.com/repos/Zitchas/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/Zitchas/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/Zitchas/endless-sky/events","assignees_url":"https://api.github.com/repos/Zitchas/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/Zitchas/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/Zitchas/endless-sky/tags","blobs_url":"https://api.github.com/repos/Zitchas/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zitchas/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zitchas/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zitchas/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zitchas/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/Zitchas/endless-sky/languages","stargazers_url":"https://api.github.com/repos/Zitchas/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/Zitchas/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/Zitchas/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/Zitchas/endless-sky/subscription","commits_url":"https://api.github.com/repos/Zitchas/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zitchas/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zitchas/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zitchas/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zitchas/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/Zitchas/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zitchas/endless-sky/merges","archive_url":"https://api.github.com/repos/Zitchas/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zitchas/endless-sky/downloads","issues_url":"https://api.github.com/repos/Zitchas/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/Zitchas/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/Zitchas/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/Zitchas/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zitchas/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/Zitchas/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/Zitchas/endless-sky/deployments","created_at":"2018-06-07T20:23:37Z","updated_at":"2019-04-28T00:45:57Z","pushed_at":"2019-04-28T16:52:01Z","git_url":"git://github.com/Zitchas/endless-sky.git","ssh_url":"git@github.com:Zitchas/endless-sky.git","clone_url":"https://github.com/Zitchas/endless-sky.git","svn_url":"https://github.com/Zitchas/endless-sky","homepage":"http://endless-sky.github.io/","size":175035,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"endless-sky:master","ref":"master","sha":"bcc1eff05352241e5d4bc6e06a72511245a5bf05","user":{"login":"endless-sky","id":11450262,"node_id":"MDQ6VXNlcjExNDUwMjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"repo":{"id":32231207,"node_id":"MDEwOlJlcG9zaXRvcnkzMjIzMTIwNw==","name":"endless-sky","full_name":"endless-sky/endless-sky","private":false,"owner":{"login":"endless-sky","id":11450262,"node_id":"MDQ6VXNlcjExNDUwMjYy","avatar_url":"https://avatars2.githubusercontent.com/u/11450262?v=4","gravatar_id":"","url":"https://api.github.com/users/endless-sky","html_url":"https://github.com/endless-sky","followers_url":"https://api.github.com/users/endless-sky/followers","following_url":"https://api.github.com/users/endless-sky/following{/other_user}","gists_url":"https://api.github.com/users/endless-sky/gists{/gist_id}","starred_url":"https://api.github.com/users/endless-sky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endless-sky/subscriptions","organizations_url":"https://api.github.com/users/endless-sky/orgs","repos_url":"https://api.github.com/users/endless-sky/repos","events_url":"https://api.github.com/users/endless-sky/events{/privacy}","received_events_url":"https://api.github.com/users/endless-sky/received_events","type":"User","site_admin":false},"html_url":"https://github.com/endless-sky/endless-sky","description":"Space exploration, trading, and combat game.","fork":false,"url":"https://api.github.com/repos/endless-sky/endless-sky","forks_url":"https://api.github.com/repos/endless-sky/endless-sky/forks","keys_url":"https://api.github.com/repos/endless-sky/endless-sky/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endless-sky/endless-sky/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endless-sky/endless-sky/teams","hooks_url":"https://api.github.com/repos/endless-sky/endless-sky/hooks","issue_events_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/events{/number}","events_url":"https://api.github.com/repos/endless-sky/endless-sky/events","assignees_url":"https://api.github.com/repos/endless-sky/endless-sky/assignees{/user}","branches_url":"https://api.github.com/repos/endless-sky/endless-sky/branches{/branch}","tags_url":"https://api.github.com/repos/endless-sky/endless-sky/tags","blobs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endless-sky/endless-sky/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endless-sky/endless-sky/git/refs{/sha}","trees_url":"https://api.github.com/repos/endless-sky/endless-sky/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endless-sky/endless-sky/statuses/{sha}","languages_url":"https://api.github.com/repos/endless-sky/endless-sky/languages","stargazers_url":"https://api.github.com/repos/endless-sky/endless-sky/stargazers","contributors_url":"https://api.github.com/repos/endless-sky/endless-sky/contributors","subscribers_url":"https://api.github.com/repos/endless-sky/endless-sky/subscribers","subscription_url":"https://api.github.com/repos/endless-sky/endless-sky/subscription","commits_url":"https://api.github.com/repos/endless-sky/endless-sky/commits{/sha}","git_commits_url":"https://api.github.com/repos/endless-sky/endless-sky/git/commits{/sha}","comments_url":"https://api.github.com/repos/endless-sky/endless-sky/comments{/number}","issue_comment_url":"https://api.github.com/repos/endless-sky/endless-sky/issues/comments{/number}","contents_url":"https://api.github.com/repos/endless-sky/endless-sky/contents/{+path}","compare_url":"https://api.github.com/repos/endless-sky/endless-sky/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endless-sky/endless-sky/merges","archive_url":"https://api.github.com/repos/endless-sky/endless-sky/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endless-sky/endless-sky/downloads","issues_url":"https://api.github.com/repos/endless-sky/endless-sky/issues{/number}","pulls_url":"https://api.github.com/repos/endless-sky/endless-sky/pulls{/number}","milestones_url":"https://api.github.com/repos/endless-sky/endless-sky/milestones{/number}","notifications_url":"https://api.github.com/repos/endless-sky/endless-sky/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endless-sky/endless-sky/labels{/name}","releases_url":"https://api.github.com/repos/endless-sky/endless-sky/releases{/id}","deployments_url":"https://api.github.com/repos/endless-sky/endless-sky/deployments","created_at":"2015-03-14T20:44:39Z","updated_at":"2019-04-28T03:08:33Z","pushed_at":"2019-04-28T16:52:03Z","git_url":"git://github.com/endless-sky/endless-sky.git","ssh_url":"git@github.com:endless-sky/endless-sky.git","clone_url":"https://github.com/endless-sky/endless-sky.git","svn_url":"https://github.com/endless-sky/endless-sky","homepage":"http://endless-sky.github.io/","size":165134,"stargazers_count":1775,"watchers_count":1775,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":457,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":509,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":457,"open_issues":509,"watchers":1775,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269"},"html":{"href":"https://github.com/endless-sky/endless-sky/pull/4269"},"issue":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/4269"},"comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/issues/4269/comments"},"review_comments":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269/comments"},"review_comment":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endless-sky/endless-sky/pulls/4269/commits"},"statuses":{"href":"https://api.github.com/repos/endless-sky/endless-sky/statuses/24dea6eb732401ae7ef4dd35e02950eae05db78d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 32231207,
"name": "endless-sky/endless-sky",
"url": "https://api.github.com/repos/endless-sky/endless-sky"
}
|
{
"id": 1037883,
"login": "Fzzr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1037883?",
"url": "https://api.github.com/users/Fzzr"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-04-28T17:17:03 |
9526098564
|
{"actor":{"display_login":"Fzzr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/comments/263988415","pull_request_review_id":212549742,"id":263988415,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Mzk4ODQxNQ==","diff_hunk":"@@ -7,6 +7,15 @@ def show\n end\n \n def edit\n+ @user = User.find(params[:id])\n+ end\n+\n+ def update\n+ user = User.find(params[:id])","path":"app/controllers/users_controller.rb","position":16,"original_position":8,"commit_id":"c5f87954f01411d8883e158327421b75b10de653","original_commit_id":"67111fa139d4af7ba2fe48316c80db3cd53b0b91","user":{"login":"097yuji","id":47240340,"node_id":"MDQ6VXNlcjQ3MjQwMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/47240340?v=4","gravatar_id":"","url":"https://api.github.com/users/097yuji","html_url":"https://github.com/097yuji","followers_url":"https://api.github.com/users/097yuji/followers","following_url":"https://api.github.com/users/097yuji/following{/other_user}","gists_url":"https://api.github.com/users/097yuji/gists{/gist_id}","starred_url":"https://api.github.com/users/097yuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/097yuji/subscriptions","organizations_url":"https://api.github.com/users/097yuji/orgs","repos_url":"https://api.github.com/users/097yuji/repos","events_url":"https://api.github.com/users/097yuji/events{/privacy}","received_events_url":"https://api.github.com/users/097yuji/received_events","type":"User","site_admin":false},"body":"before_action定義にて修正しました。","created_at":"2019-03-09T06:16:39Z","updated_at":"2019-03-09T06:16:39Z","html_url":"https://github.com/Ykum4/freemarket_sample_45b/pull/71#discussion_r263988415","pull_request_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/comments/263988415"},"html":{"href":"https://github.com/Ykum4/freemarket_sample_45b/pull/71#discussion_r263988415"},"pull_request":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71"}},"in_reply_to_id":263981622},"pull_request":{"url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71","id":259657459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NjU3NDU5","html_url":"https://github.com/Ykum4/freemarket_sample_45b/pull/71","diff_url":"https://github.com/Ykum4/freemarket_sample_45b/pull/71.diff","patch_url":"https://github.com/Ykum4/freemarket_sample_45b/pull/71.patch","issue_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/71","number":71,"state":"open","locked":false,"title":"add_function_edit-introduction","user":{"login":"097yuji","id":47240340,"node_id":"MDQ6VXNlcjQ3MjQwMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/47240340?v=4","gravatar_id":"","url":"https://api.github.com/users/097yuji","html_url":"https://github.com/097yuji","followers_url":"https://api.github.com/users/097yuji/followers","following_url":"https://api.github.com/users/097yuji/following{/other_user}","gists_url":"https://api.github.com/users/097yuji/gists{/gist_id}","starred_url":"https://api.github.com/users/097yuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/097yuji/subscriptions","organizations_url":"https://api.github.com/users/097yuji/orgs","repos_url":"https://api.github.com/users/097yuji/repos","events_url":"https://api.github.com/users/097yuji/events{/privacy}","received_events_url":"https://api.github.com/users/097yuji/received_events","type":"User","site_admin":false},"body":"#what\n\nuser/id/edit のページでnicknameとintroductionを入力・更新できるように\n\n#why\n\n本家に近づけたくて","created_at":"2019-03-09T02:09:08Z","updated_at":"2019-03-09T06:16:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df19ead1edd32043a03315ca363e02314b5f9057","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71/commits","review_comments_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71/comments","review_comment_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/71/comments","statuses_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/statuses/c5f87954f01411d8883e158327421b75b10de653","head":{"label":"097yuji:edit_view_user-edit","ref":"edit_view_user-edit","sha":"c5f87954f01411d8883e158327421b75b10de653","user":{"login":"097yuji","id":47240340,"node_id":"MDQ6VXNlcjQ3MjQwMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/47240340?v=4","gravatar_id":"","url":"https://api.github.com/users/097yuji","html_url":"https://github.com/097yuji","followers_url":"https://api.github.com/users/097yuji/followers","following_url":"https://api.github.com/users/097yuji/following{/other_user}","gists_url":"https://api.github.com/users/097yuji/gists{/gist_id}","starred_url":"https://api.github.com/users/097yuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/097yuji/subscriptions","organizations_url":"https://api.github.com/users/097yuji/orgs","repos_url":"https://api.github.com/users/097yuji/repos","events_url":"https://api.github.com/users/097yuji/events{/privacy}","received_events_url":"https://api.github.com/users/097yuji/received_events","type":"User","site_admin":false},"repo":{"id":171991290,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE5OTEyOTA=","name":"freemarket_sample_45b","full_name":"097yuji/freemarket_sample_45b","private":false,"owner":{"login":"097yuji","id":47240340,"node_id":"MDQ6VXNlcjQ3MjQwMzQw","avatar_url":"https://avatars2.githubusercontent.com/u/47240340?v=4","gravatar_id":"","url":"https://api.github.com/users/097yuji","html_url":"https://github.com/097yuji","followers_url":"https://api.github.com/users/097yuji/followers","following_url":"https://api.github.com/users/097yuji/following{/other_user}","gists_url":"https://api.github.com/users/097yuji/gists{/gist_id}","starred_url":"https://api.github.com/users/097yuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/097yuji/subscriptions","organizations_url":"https://api.github.com/users/097yuji/orgs","repos_url":"https://api.github.com/users/097yuji/repos","events_url":"https://api.github.com/users/097yuji/events{/privacy}","received_events_url":"https://api.github.com/users/097yuji/received_events","type":"User","site_admin":false},"html_url":"https://github.com/097yuji/freemarket_sample_45b","description":null,"fork":true,"url":"https://api.github.com/repos/097yuji/freemarket_sample_45b","forks_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/forks","keys_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/keys{/key_id}","collaborators_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/teams","hooks_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/hooks","issue_events_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/issues/events{/number}","events_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/events","assignees_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/assignees{/user}","branches_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/branches{/branch}","tags_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/tags","blobs_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/git/refs{/sha}","trees_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/git/trees{/sha}","statuses_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/statuses/{sha}","languages_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/languages","stargazers_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/stargazers","contributors_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/contributors","subscribers_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/subscribers","subscription_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/subscription","commits_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/commits{/sha}","git_commits_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/git/commits{/sha}","comments_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/comments{/number}","issue_comment_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/issues/comments{/number}","contents_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/contents/{+path}","compare_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/compare/{base}...{head}","merges_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/merges","archive_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/downloads","issues_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/issues{/number}","pulls_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/pulls{/number}","milestones_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/milestones{/number}","notifications_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/labels{/name}","releases_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/releases{/id}","deployments_url":"https://api.github.com/repos/097yuji/freemarket_sample_45b/deployments","created_at":"2019-02-22T03:55:10Z","updated_at":"2019-03-09T06:04:38Z","pushed_at":"2019-03-09T06:04:37Z","git_url":"git://github.com/097yuji/freemarket_sample_45b.git","ssh_url":"git@github.com:097yuji/freemarket_sample_45b.git","clone_url":"https://github.com/097yuji/freemarket_sample_45b.git","svn_url":"https://github.com/097yuji/freemarket_sample_45b","homepage":null,"size":464,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ykum4:master","ref":"master","sha":"c5b35df5378f7d1b7ae755b0ee79156c88f80522","user":{"login":"Ykum4","id":47135114,"node_id":"MDQ6VXNlcjQ3MTM1MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/47135114?v=4","gravatar_id":"","url":"https://api.github.com/users/Ykum4","html_url":"https://github.com/Ykum4","followers_url":"https://api.github.com/users/Ykum4/followers","following_url":"https://api.github.com/users/Ykum4/following{/other_user}","gists_url":"https://api.github.com/users/Ykum4/gists{/gist_id}","starred_url":"https://api.github.com/users/Ykum4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ykum4/subscriptions","organizations_url":"https://api.github.com/users/Ykum4/orgs","repos_url":"https://api.github.com/users/Ykum4/repos","events_url":"https://api.github.com/users/Ykum4/events{/privacy}","received_events_url":"https://api.github.com/users/Ykum4/received_events","type":"User","site_admin":false},"repo":{"id":171990906,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE5OTA5MDY=","name":"freemarket_sample_45b","full_name":"Ykum4/freemarket_sample_45b","private":false,"owner":{"login":"Ykum4","id":47135114,"node_id":"MDQ6VXNlcjQ3MTM1MTE0","avatar_url":"https://avatars2.githubusercontent.com/u/47135114?v=4","gravatar_id":"","url":"https://api.github.com/users/Ykum4","html_url":"https://github.com/Ykum4","followers_url":"https://api.github.com/users/Ykum4/followers","following_url":"https://api.github.com/users/Ykum4/following{/other_user}","gists_url":"https://api.github.com/users/Ykum4/gists{/gist_id}","starred_url":"https://api.github.com/users/Ykum4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ykum4/subscriptions","organizations_url":"https://api.github.com/users/Ykum4/orgs","repos_url":"https://api.github.com/users/Ykum4/repos","events_url":"https://api.github.com/users/Ykum4/events{/privacy}","received_events_url":"https://api.github.com/users/Ykum4/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ykum4/freemarket_sample_45b","description":null,"fork":false,"url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b","forks_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/forks","keys_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/teams","hooks_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/hooks","issue_events_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/events{/number}","events_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/events","assignees_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/assignees{/user}","branches_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/branches{/branch}","tags_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/tags","blobs_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/statuses/{sha}","languages_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/languages","stargazers_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/stargazers","contributors_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/contributors","subscribers_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/subscribers","subscription_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/subscription","commits_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/contents/{+path}","compare_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/merges","archive_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/downloads","issues_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues{/number}","pulls_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls{/number}","milestones_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/milestones{/number}","notifications_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/labels{/name}","releases_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/releases{/id}","deployments_url":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/deployments","created_at":"2019-02-22T03:51:57Z","updated_at":"2019-03-09T05:55:48Z","pushed_at":"2019-03-09T06:00:05Z","git_url":"git://github.com/Ykum4/freemarket_sample_45b.git","ssh_url":"git@github.com:Ykum4/freemarket_sample_45b.git","clone_url":"https://github.com/Ykum4/freemarket_sample_45b.git","svn_url":"https://github.com/Ykum4/freemarket_sample_45b","homepage":null,"size":475,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71"},"html":{"href":"https://github.com/Ykum4/freemarket_sample_45b/pull/71"},"issue":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/71"},"comments":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/Ykum4/freemarket_sample_45b/statuses/c5f87954f01411d8883e158327421b75b10de653"}},"author_association":"COLLABORATOR"}}
|
{
"id": 171990906,
"name": "Ykum4/freemarket_sample_45b",
"url": "https://api.github.com/repos/Ykum4/freemarket_sample_45b"
}
|
{
"id": 47240340,
"login": "097yuji",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47240340?",
"url": "https://api.github.com/users/097yuji"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-03-09T06:16:39 |
9210527831
|
{"actor":{"display_login":"097yuji"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/comments/270142443","pull_request_review_id":220200858,"id":270142443,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDE0MjQ0Mw==","diff_hunk":"@@ -30,6 +30,16 @@\n t.datetime \"updated_at\", null: false\n end\n \n+ create_table \"gists\", force: :cascade do |t|\n+ t.bigint \"question_id\", null: false\n+ t.string \"url\", null: false\n+ t.bigint \"user_id\", null: false\n+ t.datetime \"created_at\", null: false\n+ t.datetime \"updated_at\", null: false","path":"db/schema.rb","position":18,"original_position":18,"commit_id":"c38197afa3132f06c5bdce382ca797db617bd4d0","original_commit_id":"c38197afa3132f06c5bdce382ca797db617bd4d0","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2019-03-28T18:27:22Z","updated_at":"2019-03-28T18:27:24Z","html_url":"https://github.com/DmitryKilin/test-guru/pull/14#discussion_r270142443","pull_request_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/comments/270142443"},"html":{"href":"https://github.com/DmitryKilin/test-guru/pull/14#discussion_r270142443"},"pull_request":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14","id":264619297,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NjE5Mjk3","html_url":"https://github.com/DmitryKilin/test-guru/pull/14","diff_url":"https://github.com/DmitryKilin/test-guru/pull/14.diff","patch_url":"https://github.com/DmitryKilin/test-guru/pull/14.patch","issue_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/14","number":14,"state":"open","locked":false,"title":"Lesson 14","user":{"login":"DmitryKilin","id":46634431,"node_id":"MDQ6VXNlcjQ2NjM0NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/46634431?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKilin","html_url":"https://github.com/DmitryKilin","followers_url":"https://api.github.com/users/DmitryKilin/followers","following_url":"https://api.github.com/users/DmitryKilin/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKilin/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKilin/subscriptions","organizations_url":"https://api.github.com/users/DmitryKilin/orgs","repos_url":"https://api.github.com/users/DmitryKilin/repos","events_url":"https://api.github.com/users/DmitryKilin/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKilin/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-26T17:19:41Z","updated_at":"2019-03-28T18:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"278326a7b1f8f39f13bbe7718fc07f43a8522916","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14/commits","review_comments_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14/comments","review_comment_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/14/comments","statuses_url":"https://api.github.com/repos/DmitryKilin/test-guru/statuses/c38197afa3132f06c5bdce382ca797db617bd4d0","head":{"label":"DmitryKilin:Lesson-14","ref":"Lesson-14","sha":"c38197afa3132f06c5bdce382ca797db617bd4d0","user":{"login":"DmitryKilin","id":46634431,"node_id":"MDQ6VXNlcjQ2NjM0NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/46634431?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKilin","html_url":"https://github.com/DmitryKilin","followers_url":"https://api.github.com/users/DmitryKilin/followers","following_url":"https://api.github.com/users/DmitryKilin/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKilin/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKilin/subscriptions","organizations_url":"https://api.github.com/users/DmitryKilin/orgs","repos_url":"https://api.github.com/users/DmitryKilin/repos","events_url":"https://api.github.com/users/DmitryKilin/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKilin/received_events","type":"User","site_admin":false},"repo":{"id":166541348,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1NDEzNDg=","name":"test-guru","full_name":"DmitryKilin/test-guru","private":false,"owner":{"login":"DmitryKilin","id":46634431,"node_id":"MDQ6VXNlcjQ2NjM0NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/46634431?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKilin","html_url":"https://github.com/DmitryKilin","followers_url":"https://api.github.com/users/DmitryKilin/followers","following_url":"https://api.github.com/users/DmitryKilin/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKilin/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKilin/subscriptions","organizations_url":"https://api.github.com/users/DmitryKilin/orgs","repos_url":"https://api.github.com/users/DmitryKilin/repos","events_url":"https://api.github.com/users/DmitryKilin/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKilin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DmitryKilin/test-guru","description":"Мой учебный проект Test-guru приложения Rails www.thinknetica.com ","fork":false,"url":"https://api.github.com/repos/DmitryKilin/test-guru","forks_url":"https://api.github.com/repos/DmitryKilin/test-guru/forks","keys_url":"https://api.github.com/repos/DmitryKilin/test-guru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DmitryKilin/test-guru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DmitryKilin/test-guru/teams","hooks_url":"https://api.github.com/repos/DmitryKilin/test-guru/hooks","issue_events_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/events{/number}","events_url":"https://api.github.com/repos/DmitryKilin/test-guru/events","assignees_url":"https://api.github.com/repos/DmitryKilin/test-guru/assignees{/user}","branches_url":"https://api.github.com/repos/DmitryKilin/test-guru/branches{/branch}","tags_url":"https://api.github.com/repos/DmitryKilin/test-guru/tags","blobs_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/refs{/sha}","trees_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DmitryKilin/test-guru/statuses/{sha}","languages_url":"https://api.github.com/repos/DmitryKilin/test-guru/languages","stargazers_url":"https://api.github.com/repos/DmitryKilin/test-guru/stargazers","contributors_url":"https://api.github.com/repos/DmitryKilin/test-guru/contributors","subscribers_url":"https://api.github.com/repos/DmitryKilin/test-guru/subscribers","subscription_url":"https://api.github.com/repos/DmitryKilin/test-guru/subscription","commits_url":"https://api.github.com/repos/DmitryKilin/test-guru/commits{/sha}","git_commits_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/commits{/sha}","comments_url":"https://api.github.com/repos/DmitryKilin/test-guru/comments{/number}","issue_comment_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/comments{/number}","contents_url":"https://api.github.com/repos/DmitryKilin/test-guru/contents/{+path}","compare_url":"https://api.github.com/repos/DmitryKilin/test-guru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DmitryKilin/test-guru/merges","archive_url":"https://api.github.com/repos/DmitryKilin/test-guru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DmitryKilin/test-guru/downloads","issues_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues{/number}","pulls_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls{/number}","milestones_url":"https://api.github.com/repos/DmitryKilin/test-guru/milestones{/number}","notifications_url":"https://api.github.com/repos/DmitryKilin/test-guru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DmitryKilin/test-guru/labels{/name}","releases_url":"https://api.github.com/repos/DmitryKilin/test-guru/releases{/id}","deployments_url":"https://api.github.com/repos/DmitryKilin/test-guru/deployments","created_at":"2019-01-19T11:54:07Z","updated_at":"2019-03-23T21:15:29Z","pushed_at":"2019-03-28T18:25:39Z","git_url":"git://github.com/DmitryKilin/test-guru.git","ssh_url":"git@github.com:DmitryKilin/test-guru.git","clone_url":"https://github.com/DmitryKilin/test-guru.git","svn_url":"https://github.com/DmitryKilin/test-guru","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"DmitryKilin:master","ref":"master","sha":"7f1d45e6fec6a058d2293711b8e63567cc59265c","user":{"login":"DmitryKilin","id":46634431,"node_id":"MDQ6VXNlcjQ2NjM0NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/46634431?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKilin","html_url":"https://github.com/DmitryKilin","followers_url":"https://api.github.com/users/DmitryKilin/followers","following_url":"https://api.github.com/users/DmitryKilin/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKilin/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKilin/subscriptions","organizations_url":"https://api.github.com/users/DmitryKilin/orgs","repos_url":"https://api.github.com/users/DmitryKilin/repos","events_url":"https://api.github.com/users/DmitryKilin/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKilin/received_events","type":"User","site_admin":false},"repo":{"id":166541348,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1NDEzNDg=","name":"test-guru","full_name":"DmitryKilin/test-guru","private":false,"owner":{"login":"DmitryKilin","id":46634431,"node_id":"MDQ6VXNlcjQ2NjM0NDMx","avatar_url":"https://avatars1.githubusercontent.com/u/46634431?v=4","gravatar_id":"","url":"https://api.github.com/users/DmitryKilin","html_url":"https://github.com/DmitryKilin","followers_url":"https://api.github.com/users/DmitryKilin/followers","following_url":"https://api.github.com/users/DmitryKilin/following{/other_user}","gists_url":"https://api.github.com/users/DmitryKilin/gists{/gist_id}","starred_url":"https://api.github.com/users/DmitryKilin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DmitryKilin/subscriptions","organizations_url":"https://api.github.com/users/DmitryKilin/orgs","repos_url":"https://api.github.com/users/DmitryKilin/repos","events_url":"https://api.github.com/users/DmitryKilin/events{/privacy}","received_events_url":"https://api.github.com/users/DmitryKilin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DmitryKilin/test-guru","description":"Мой учебный проект Test-guru приложения Rails www.thinknetica.com ","fork":false,"url":"https://api.github.com/repos/DmitryKilin/test-guru","forks_url":"https://api.github.com/repos/DmitryKilin/test-guru/forks","keys_url":"https://api.github.com/repos/DmitryKilin/test-guru/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DmitryKilin/test-guru/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DmitryKilin/test-guru/teams","hooks_url":"https://api.github.com/repos/DmitryKilin/test-guru/hooks","issue_events_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/events{/number}","events_url":"https://api.github.com/repos/DmitryKilin/test-guru/events","assignees_url":"https://api.github.com/repos/DmitryKilin/test-guru/assignees{/user}","branches_url":"https://api.github.com/repos/DmitryKilin/test-guru/branches{/branch}","tags_url":"https://api.github.com/repos/DmitryKilin/test-guru/tags","blobs_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/refs{/sha}","trees_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DmitryKilin/test-guru/statuses/{sha}","languages_url":"https://api.github.com/repos/DmitryKilin/test-guru/languages","stargazers_url":"https://api.github.com/repos/DmitryKilin/test-guru/stargazers","contributors_url":"https://api.github.com/repos/DmitryKilin/test-guru/contributors","subscribers_url":"https://api.github.com/repos/DmitryKilin/test-guru/subscribers","subscription_url":"https://api.github.com/repos/DmitryKilin/test-guru/subscription","commits_url":"https://api.github.com/repos/DmitryKilin/test-guru/commits{/sha}","git_commits_url":"https://api.github.com/repos/DmitryKilin/test-guru/git/commits{/sha}","comments_url":"https://api.github.com/repos/DmitryKilin/test-guru/comments{/number}","issue_comment_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues/comments{/number}","contents_url":"https://api.github.com/repos/DmitryKilin/test-guru/contents/{+path}","compare_url":"https://api.github.com/repos/DmitryKilin/test-guru/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DmitryKilin/test-guru/merges","archive_url":"https://api.github.com/repos/DmitryKilin/test-guru/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DmitryKilin/test-guru/downloads","issues_url":"https://api.github.com/repos/DmitryKilin/test-guru/issues{/number}","pulls_url":"https://api.github.com/repos/DmitryKilin/test-guru/pulls{/number}","milestones_url":"https://api.github.com/repos/DmitryKilin/test-guru/milestones{/number}","notifications_url":"https://api.github.com/repos/DmitryKilin/test-guru/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DmitryKilin/test-guru/labels{/name}","releases_url":"https://api.github.com/repos/DmitryKilin/test-guru/releases{/id}","deployments_url":"https://api.github.com/repos/DmitryKilin/test-guru/deployments","created_at":"2019-01-19T11:54:07Z","updated_at":"2019-03-23T21:15:29Z","pushed_at":"2019-03-28T18:25:39Z","git_url":"git://github.com/DmitryKilin/test-guru.git","ssh_url":"git@github.com:DmitryKilin/test-guru.git","clone_url":"https://github.com/DmitryKilin/test-guru.git","svn_url":"https://github.com/DmitryKilin/test-guru","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14"},"html":{"href":"https://github.com/DmitryKilin/test-guru/pull/14"},"issue":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/issues/14"},"comments":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/DmitryKilin/test-guru/statuses/c38197afa3132f06c5bdce382ca797db617bd4d0"}},"author_association":"OWNER"}}
|
{
"id": 166541348,
"name": "DmitryKilin/test-guru",
"url": "https://api.github.com/repos/DmitryKilin/test-guru"
}
|
{
"id": 6697940,
"login": "houndci-bot",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6697940?",
"url": "https://api.github.com/users/houndci-bot"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-03-28T18:27:22 |
9335391435
|
{"actor":{"display_login":"houndci-bot"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/comments/361784047","pull_request_review_id":336907023,"id":361784047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTc4NDA0Nw==","diff_hunk":"@@ -0,0 +1,22 @@\n+package com.ishikota.photoviewerandroid.infra.paging\n+\n+import androidx.recyclerview.widget.RecyclerView\n+import com.ishikota.photoviewerandroid.databinding.PagingNetworkStateViewHolderBinding\n+\n+class PagingNetworkStateViewHolder(","path":"app/src/main/java/com/ishikota/photoviewerandroid/infra/paging/PagingNetworkStateViewHolder.kt","position":6,"original_position":6,"commit_id":"70f4dfa716a64fd4ec3677081f1b24315c83ac3d","original_commit_id":"70f4dfa716a64fd4ec3677081f1b24315c83ac3d","user":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"body":"https://github.com/android/architecture-components-samples/blob/07dfe3e1c129ad5479f75bb07dec8ba7a7a475ec/PagingWithNetworkSample/lib/src/main/java/com/android/example/paging/pagingwithnetwork/reddit/ui/NetworkStateItemViewHolder.kt\r\n\r\nと同じことをしてるが、DataBinding使うように修正したりした","created_at":"2019-12-28T08:32:27Z","updated_at":"2019-12-28T08:32:27Z","html_url":"https://github.com/ishikota/photo-viewer-android/pull/12#discussion_r361784047","pull_request_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/comments/361784047"},"html":{"href":"https://github.com/ishikota/photo-viewer-android/pull/12#discussion_r361784047"},"pull_request":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12","id":357416507,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU3NDE2NTA3","html_url":"https://github.com/ishikota/photo-viewer-android/pull/12","diff_url":"https://github.com/ishikota/photo-viewer-android/pull/12.diff","patch_url":"https://github.com/ishikota/photo-viewer-android/pull/12.patch","issue_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/12","number":12,"state":"open","locked":false,"title":"Implement photo list","user":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"body":"無限スクロールできるリスト表示画面を作成。\r\npaging周りの実装は、googleのサンプルを真似してる。\r\n\r\nhttps://github.com/android/architecture-components-samples/tree/master/PagingWithNetworkSample","created_at":"2019-12-28T08:22:03Z","updated_at":"2019-12-28T08:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b89e8e4e18b731b1e7bf7e92ddaa90eb8c8b525","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/12/comments","statuses_url":"https://api.github.com/repos/ishikota/photo-viewer-android/statuses/70f4dfa716a64fd4ec3677081f1b24315c83ac3d","head":{"label":"ishikota:implement-photo-list","ref":"implement-photo-list","sha":"70f4dfa716a64fd4ec3677081f1b24315c83ac3d","user":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"repo":{"id":229181357,"node_id":"MDEwOlJlcG9zaXRvcnkyMjkxODEzNTc=","name":"photo-viewer-android","full_name":"ishikota/photo-viewer-android","private":false,"owner":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ishikota/photo-viewer-android","description":"pet project to showcase my android skills","fork":false,"url":"https://api.github.com/repos/ishikota/photo-viewer-android","forks_url":"https://api.github.com/repos/ishikota/photo-viewer-android/forks","keys_url":"https://api.github.com/repos/ishikota/photo-viewer-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishikota/photo-viewer-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishikota/photo-viewer-android/teams","hooks_url":"https://api.github.com/repos/ishikota/photo-viewer-android/hooks","issue_events_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/events{/number}","events_url":"https://api.github.com/repos/ishikota/photo-viewer-android/events","assignees_url":"https://api.github.com/repos/ishikota/photo-viewer-android/assignees{/user}","branches_url":"https://api.github.com/repos/ishikota/photo-viewer-android/branches{/branch}","tags_url":"https://api.github.com/repos/ishikota/photo-viewer-android/tags","blobs_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishikota/photo-viewer-android/statuses/{sha}","languages_url":"https://api.github.com/repos/ishikota/photo-viewer-android/languages","stargazers_url":"https://api.github.com/repos/ishikota/photo-viewer-android/stargazers","contributors_url":"https://api.github.com/repos/ishikota/photo-viewer-android/contributors","subscribers_url":"https://api.github.com/repos/ishikota/photo-viewer-android/subscribers","subscription_url":"https://api.github.com/repos/ishikota/photo-viewer-android/subscription","commits_url":"https://api.github.com/repos/ishikota/photo-viewer-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishikota/photo-viewer-android/contents/{+path}","compare_url":"https://api.github.com/repos/ishikota/photo-viewer-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishikota/photo-viewer-android/merges","archive_url":"https://api.github.com/repos/ishikota/photo-viewer-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishikota/photo-viewer-android/downloads","issues_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues{/number}","pulls_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls{/number}","milestones_url":"https://api.github.com/repos/ishikota/photo-viewer-android/milestones{/number}","notifications_url":"https://api.github.com/repos/ishikota/photo-viewer-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishikota/photo-viewer-android/labels{/name}","releases_url":"https://api.github.com/repos/ishikota/photo-viewer-android/releases{/id}","deployments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/deployments","created_at":"2019-12-20T03:15:52Z","updated_at":"2019-12-24T23:37:03Z","pushed_at":"2019-12-28T08:22:04Z","git_url":"git://github.com/ishikota/photo-viewer-android.git","ssh_url":"git@github.com:ishikota/photo-viewer-android.git","clone_url":"https://github.com/ishikota/photo-viewer-android.git","svn_url":"https://github.com/ishikota/photo-viewer-android","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ishikota:master","ref":"master","sha":"2a9a5a5042672ade4b0c7fe6d2e7ffc007ec4002","user":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"repo":{"id":229181357,"node_id":"MDEwOlJlcG9zaXRvcnkyMjkxODEzNTc=","name":"photo-viewer-android","full_name":"ishikota/photo-viewer-android","private":false,"owner":{"login":"ishikota","id":8199616,"node_id":"MDQ6VXNlcjgxOTk2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8199616?v=4","gravatar_id":"","url":"https://api.github.com/users/ishikota","html_url":"https://github.com/ishikota","followers_url":"https://api.github.com/users/ishikota/followers","following_url":"https://api.github.com/users/ishikota/following{/other_user}","gists_url":"https://api.github.com/users/ishikota/gists{/gist_id}","starred_url":"https://api.github.com/users/ishikota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ishikota/subscriptions","organizations_url":"https://api.github.com/users/ishikota/orgs","repos_url":"https://api.github.com/users/ishikota/repos","events_url":"https://api.github.com/users/ishikota/events{/privacy}","received_events_url":"https://api.github.com/users/ishikota/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ishikota/photo-viewer-android","description":"pet project to showcase my android skills","fork":false,"url":"https://api.github.com/repos/ishikota/photo-viewer-android","forks_url":"https://api.github.com/repos/ishikota/photo-viewer-android/forks","keys_url":"https://api.github.com/repos/ishikota/photo-viewer-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ishikota/photo-viewer-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ishikota/photo-viewer-android/teams","hooks_url":"https://api.github.com/repos/ishikota/photo-viewer-android/hooks","issue_events_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/events{/number}","events_url":"https://api.github.com/repos/ishikota/photo-viewer-android/events","assignees_url":"https://api.github.com/repos/ishikota/photo-viewer-android/assignees{/user}","branches_url":"https://api.github.com/repos/ishikota/photo-viewer-android/branches{/branch}","tags_url":"https://api.github.com/repos/ishikota/photo-viewer-android/tags","blobs_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ishikota/photo-viewer-android/statuses/{sha}","languages_url":"https://api.github.com/repos/ishikota/photo-viewer-android/languages","stargazers_url":"https://api.github.com/repos/ishikota/photo-viewer-android/stargazers","contributors_url":"https://api.github.com/repos/ishikota/photo-viewer-android/contributors","subscribers_url":"https://api.github.com/repos/ishikota/photo-viewer-android/subscribers","subscription_url":"https://api.github.com/repos/ishikota/photo-viewer-android/subscription","commits_url":"https://api.github.com/repos/ishikota/photo-viewer-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/ishikota/photo-viewer-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/ishikota/photo-viewer-android/contents/{+path}","compare_url":"https://api.github.com/repos/ishikota/photo-viewer-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ishikota/photo-viewer-android/merges","archive_url":"https://api.github.com/repos/ishikota/photo-viewer-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ishikota/photo-viewer-android/downloads","issues_url":"https://api.github.com/repos/ishikota/photo-viewer-android/issues{/number}","pulls_url":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls{/number}","milestones_url":"https://api.github.com/repos/ishikota/photo-viewer-android/milestones{/number}","notifications_url":"https://api.github.com/repos/ishikota/photo-viewer-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ishikota/photo-viewer-android/labels{/name}","releases_url":"https://api.github.com/repos/ishikota/photo-viewer-android/releases{/id}","deployments_url":"https://api.github.com/repos/ishikota/photo-viewer-android/deployments","created_at":"2019-12-20T03:15:52Z","updated_at":"2019-12-24T23:37:03Z","pushed_at":"2019-12-28T08:22:04Z","git_url":"git://github.com/ishikota/photo-viewer-android.git","ssh_url":"git@github.com:ishikota/photo-viewer-android.git","clone_url":"https://github.com/ishikota/photo-viewer-android.git","svn_url":"https://github.com/ishikota/photo-viewer-android","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12"},"html":{"href":"https://github.com/ishikota/photo-viewer-android/pull/12"},"issue":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/12"},"comments":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ishikota/photo-viewer-android/statuses/70f4dfa716a64fd4ec3677081f1b24315c83ac3d"}},"author_association":"OWNER"}}
|
{
"id": 229181357,
"name": "ishikota/photo-viewer-android",
"url": "https://api.github.com/repos/ishikota/photo-viewer-android"
}
|
{
"id": 8199616,
"login": "ishikota",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8199616?",
"url": "https://api.github.com/users/ishikota"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-12-28T08:32:27 |
11169780022
|
{"actor":{"display_login":"ishikota"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/comments/328617537","pull_request_review_id":293725856,"id":328617537,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODYxNzUzNw==","diff_hunk":"@@ -5,21 +5,38 @@\n <title>Netflix Series Collection</title>\n </head>\n <body>\n+<h2>Complete all fields to add a new series to your collection</h2>\n+<!-- -->\n+<form method=\"post\" action=\"adddata.php\">\n+ Series Title:\n+ <input type=\"text\" name=\"seriestitle\">","path":"index.php","position":8,"original_position":8,"commit_id":"409fa6537c63b4769071346ed963482b83114c8a","original_commit_id":"409fa6537c63b4769071346ed963482b83114c8a","user":{"login":"sjr-mayden","id":46319526,"node_id":"MDQ6VXNlcjQ2MzE5NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/46319526?v=4","gravatar_id":"","url":"https://api.github.com/users/sjr-mayden","html_url":"https://github.com/sjr-mayden","followers_url":"https://api.github.com/users/sjr-mayden/followers","following_url":"https://api.github.com/users/sjr-mayden/following{/other_user}","gists_url":"https://api.github.com/users/sjr-mayden/gists{/gist_id}","starred_url":"https://api.github.com/users/sjr-mayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjr-mayden/subscriptions","organizations_url":"https://api.github.com/users/sjr-mayden/orgs","repos_url":"https://api.github.com/users/sjr-mayden/repos","events_url":"https://api.github.com/users/sjr-mayden/events{/privacy}","received_events_url":"https://api.github.com/users/sjr-mayden/received_events","type":"User","site_admin":false},"body":"Can use the `required` attribute for these input fields (step 1 of the 4 that we talked about)","created_at":"2019-09-26T13:38:12Z","updated_at":"2019-09-26T13:38:27Z","html_url":"https://github.com/jasonrees1/collector-app/pull/8#discussion_r328617537","pull_request_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/comments/328617537"},"html":{"href":"https://github.com/jasonrees1/collector-app/pull/8#discussion_r328617537"},"pull_request":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8","id":321715951,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxNzE1OTUx","html_url":"https://github.com/jasonrees1/collector-app/pull/8","diff_url":"https://github.com/jasonrees1/collector-app/pull/8.diff","patch_url":"https://github.com/jasonrees1/collector-app/pull/8.patch","issue_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/8","number":8,"state":"open","locked":false,"title":"Story2","user":{"login":"jasonrees1","id":54410421,"node_id":"MDQ6VXNlcjU0NDEwNDIx","avatar_url":"https://avatars3.githubusercontent.com/u/54410421?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrees1","html_url":"https://github.com/jasonrees1","followers_url":"https://api.github.com/users/jasonrees1/followers","following_url":"https://api.github.com/users/jasonrees1/following{/other_user}","gists_url":"https://api.github.com/users/jasonrees1/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrees1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrees1/subscriptions","organizations_url":"https://api.github.com/users/jasonrees1/orgs","repos_url":"https://api.github.com/users/jasonrees1/repos","events_url":"https://api.github.com/users/jasonrees1/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrees1/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-26T13:19:39Z","updated_at":"2019-09-26T13:38:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee0b8220256a2bf31795a571ee0af021c9361582","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8/commits","review_comments_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8/comments","review_comment_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/8/comments","statuses_url":"https://api.github.com/repos/jasonrees1/collector-app/statuses/409fa6537c63b4769071346ed963482b83114c8a","head":{"label":"jasonrees1:story2","ref":"story2","sha":"409fa6537c63b4769071346ed963482b83114c8a","user":{"login":"jasonrees1","id":54410421,"node_id":"MDQ6VXNlcjU0NDEwNDIx","avatar_url":"https://avatars3.githubusercontent.com/u/54410421?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrees1","html_url":"https://github.com/jasonrees1","followers_url":"https://api.github.com/users/jasonrees1/followers","following_url":"https://api.github.com/users/jasonrees1/following{/other_user}","gists_url":"https://api.github.com/users/jasonrees1/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrees1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrees1/subscriptions","organizations_url":"https://api.github.com/users/jasonrees1/orgs","repos_url":"https://api.github.com/users/jasonrees1/repos","events_url":"https://api.github.com/users/jasonrees1/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrees1/received_events","type":"User","site_admin":false},"repo":{"id":210326791,"node_id":"MDEwOlJlcG9zaXRvcnkyMTAzMjY3OTE=","name":"collector-app","full_name":"jasonrees1/collector-app","private":false,"owner":{"login":"jasonrees1","id":54410421,"node_id":"MDQ6VXNlcjU0NDEwNDIx","avatar_url":"https://avatars3.githubusercontent.com/u/54410421?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrees1","html_url":"https://github.com/jasonrees1","followers_url":"https://api.github.com/users/jasonrees1/followers","following_url":"https://api.github.com/users/jasonrees1/following{/other_user}","gists_url":"https://api.github.com/users/jasonrees1/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrees1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrees1/subscriptions","organizations_url":"https://api.github.com/users/jasonrees1/orgs","repos_url":"https://api.github.com/users/jasonrees1/repos","events_url":"https://api.github.com/users/jasonrees1/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrees1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jasonrees1/collector-app","description":null,"fork":false,"url":"https://api.github.com/repos/jasonrees1/collector-app","forks_url":"https://api.github.com/repos/jasonrees1/collector-app/forks","keys_url":"https://api.github.com/repos/jasonrees1/collector-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonrees1/collector-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonrees1/collector-app/teams","hooks_url":"https://api.github.com/repos/jasonrees1/collector-app/hooks","issue_events_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/events{/number}","events_url":"https://api.github.com/repos/jasonrees1/collector-app/events","assignees_url":"https://api.github.com/repos/jasonrees1/collector-app/assignees{/user}","branches_url":"https://api.github.com/repos/jasonrees1/collector-app/branches{/branch}","tags_url":"https://api.github.com/repos/jasonrees1/collector-app/tags","blobs_url":"https://api.github.com/repos/jasonrees1/collector-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonrees1/collector-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonrees1/collector-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonrees1/collector-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonrees1/collector-app/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonrees1/collector-app/languages","stargazers_url":"https://api.github.com/repos/jasonrees1/collector-app/stargazers","contributors_url":"https://api.github.com/repos/jasonrees1/collector-app/contributors","subscribers_url":"https://api.github.com/repos/jasonrees1/collector-app/subscribers","subscription_url":"https://api.github.com/repos/jasonrees1/collector-app/subscription","commits_url":"https://api.github.com/repos/jasonrees1/collector-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonrees1/collector-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonrees1/collector-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonrees1/collector-app/contents/{+path}","compare_url":"https://api.github.com/repos/jasonrees1/collector-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonrees1/collector-app/merges","archive_url":"https://api.github.com/repos/jasonrees1/collector-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonrees1/collector-app/downloads","issues_url":"https://api.github.com/repos/jasonrees1/collector-app/issues{/number}","pulls_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonrees1/collector-app/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonrees1/collector-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonrees1/collector-app/labels{/name}","releases_url":"https://api.github.com/repos/jasonrees1/collector-app/releases{/id}","deployments_url":"https://api.github.com/repos/jasonrees1/collector-app/deployments","created_at":"2019-09-23T10:24:10Z","updated_at":"2019-09-24T14:03:22Z","pushed_at":"2019-09-26T13:19:39Z","git_url":"git://github.com/jasonrees1/collector-app.git","ssh_url":"git@github.com:jasonrees1/collector-app.git","clone_url":"https://github.com/jasonrees1/collector-app.git","svn_url":"https://github.com/jasonrees1/collector-app","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jasonrees1:master","ref":"master","sha":"60c3d005d7b212120901ab38c2592a32594446b6","user":{"login":"jasonrees1","id":54410421,"node_id":"MDQ6VXNlcjU0NDEwNDIx","avatar_url":"https://avatars3.githubusercontent.com/u/54410421?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrees1","html_url":"https://github.com/jasonrees1","followers_url":"https://api.github.com/users/jasonrees1/followers","following_url":"https://api.github.com/users/jasonrees1/following{/other_user}","gists_url":"https://api.github.com/users/jasonrees1/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrees1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrees1/subscriptions","organizations_url":"https://api.github.com/users/jasonrees1/orgs","repos_url":"https://api.github.com/users/jasonrees1/repos","events_url":"https://api.github.com/users/jasonrees1/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrees1/received_events","type":"User","site_admin":false},"repo":{"id":210326791,"node_id":"MDEwOlJlcG9zaXRvcnkyMTAzMjY3OTE=","name":"collector-app","full_name":"jasonrees1/collector-app","private":false,"owner":{"login":"jasonrees1","id":54410421,"node_id":"MDQ6VXNlcjU0NDEwNDIx","avatar_url":"https://avatars3.githubusercontent.com/u/54410421?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrees1","html_url":"https://github.com/jasonrees1","followers_url":"https://api.github.com/users/jasonrees1/followers","following_url":"https://api.github.com/users/jasonrees1/following{/other_user}","gists_url":"https://api.github.com/users/jasonrees1/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrees1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrees1/subscriptions","organizations_url":"https://api.github.com/users/jasonrees1/orgs","repos_url":"https://api.github.com/users/jasonrees1/repos","events_url":"https://api.github.com/users/jasonrees1/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrees1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jasonrees1/collector-app","description":null,"fork":false,"url":"https://api.github.com/repos/jasonrees1/collector-app","forks_url":"https://api.github.com/repos/jasonrees1/collector-app/forks","keys_url":"https://api.github.com/repos/jasonrees1/collector-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonrees1/collector-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonrees1/collector-app/teams","hooks_url":"https://api.github.com/repos/jasonrees1/collector-app/hooks","issue_events_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/events{/number}","events_url":"https://api.github.com/repos/jasonrees1/collector-app/events","assignees_url":"https://api.github.com/repos/jasonrees1/collector-app/assignees{/user}","branches_url":"https://api.github.com/repos/jasonrees1/collector-app/branches{/branch}","tags_url":"https://api.github.com/repos/jasonrees1/collector-app/tags","blobs_url":"https://api.github.com/repos/jasonrees1/collector-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonrees1/collector-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonrees1/collector-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonrees1/collector-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonrees1/collector-app/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonrees1/collector-app/languages","stargazers_url":"https://api.github.com/repos/jasonrees1/collector-app/stargazers","contributors_url":"https://api.github.com/repos/jasonrees1/collector-app/contributors","subscribers_url":"https://api.github.com/repos/jasonrees1/collector-app/subscribers","subscription_url":"https://api.github.com/repos/jasonrees1/collector-app/subscription","commits_url":"https://api.github.com/repos/jasonrees1/collector-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonrees1/collector-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonrees1/collector-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonrees1/collector-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonrees1/collector-app/contents/{+path}","compare_url":"https://api.github.com/repos/jasonrees1/collector-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonrees1/collector-app/merges","archive_url":"https://api.github.com/repos/jasonrees1/collector-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonrees1/collector-app/downloads","issues_url":"https://api.github.com/repos/jasonrees1/collector-app/issues{/number}","pulls_url":"https://api.github.com/repos/jasonrees1/collector-app/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonrees1/collector-app/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonrees1/collector-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonrees1/collector-app/labels{/name}","releases_url":"https://api.github.com/repos/jasonrees1/collector-app/releases{/id}","deployments_url":"https://api.github.com/repos/jasonrees1/collector-app/deployments","created_at":"2019-09-23T10:24:10Z","updated_at":"2019-09-24T14:03:22Z","pushed_at":"2019-09-26T13:19:39Z","git_url":"git://github.com/jasonrees1/collector-app.git","ssh_url":"git@github.com:jasonrees1/collector-app.git","clone_url":"https://github.com/jasonrees1/collector-app.git","svn_url":"https://github.com/jasonrees1/collector-app","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8"},"html":{"href":"https://github.com/jasonrees1/collector-app/pull/8"},"issue":{"href":"https://api.github.com/repos/jasonrees1/collector-app/issues/8"},"comments":{"href":"https://api.github.com/repos/jasonrees1/collector-app/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasonrees1/collector-app/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/jasonrees1/collector-app/statuses/409fa6537c63b4769071346ed963482b83114c8a"}},"author_association":"OWNER"}}
|
{
"id": 210326791,
"name": "jasonrees1/collector-app",
"url": "https://api.github.com/repos/jasonrees1/collector-app"
}
|
{
"id": 46319526,
"login": "sjr-mayden",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/46319526?",
"url": "https://api.github.com/users/sjr-mayden"
}
|
{
"id": null,
"login": null,
"gravatar_id": null,
"avatar_url": null,
"url": null
}
| 2019-09-26T13:38:12 |
10501850764
|
{"actor":{"display_login":"sjr-mayden"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/351852167","pull_request_review_id":324370509,"id":351852167,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTg1MjE2Nw==","diff_hunk":"@@ -956,11 +963,26 @@ public function getLogger()\n {\n if ($this->_logger === null) {\n $this->_logger = new QueryLogger();\n+ $this->_logger->setConnectionId($this->getConnectionId());\n }\n \n return $this->_logger;\n }\n \n+ /**\n+ * Gets the database connection id.\n+ *\n+ * @return int|null\n+ */\n+ public function getConnectionId()\n+ {\n+ if ($this->_connectionId === null) {\n+ $this->_connectionId = $this->_driver->getConnectionId();","path":"src/Database/Connection.php","position":32,"original_position":32,"commit_id":"cf9209c429c397eb5445337a7b983dd73072f071","original_commit_id":"cf9209c429c397eb5445337a7b983dd73072f071","user":{"login":"bancer","id":3830106,"node_id":"MDQ6VXNlcjM4MzAxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3830106?v=4","gravatar_id":"","url":"https://api.github.com/users/bancer","html_url":"https://github.com/bancer","followers_url":"https://api.github.com/users/bancer/followers","following_url":"https://api.github.com/users/bancer/following{/other_user}","gists_url":"https://api.github.com/users/bancer/gists{/gist_id}","starred_url":"https://api.github.com/users/bancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bancer/subscriptions","organizations_url":"https://api.github.com/users/bancer/orgs","repos_url":"https://api.github.com/users/bancer/repos","events_url":"https://api.github.com/users/bancer/events{/privacy}","received_events_url":"https://api.github.com/users/bancer/received_events","type":"User","site_admin":false},"body":"There is no other way to get the connection id per my knowledge.","created_at":"2019-11-28T15:54:45Z","updated_at":"2019-11-28T15:54:46Z","html_url":"https://github.com/cakephp/cakephp/pull/13954#discussion_r351852167","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13954","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/351852167"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13954#discussion_r351852167"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13954"}},"in_reply_to_id":351842681},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/13954","id":346615663,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2NjE1NjYz","html_url":"https://github.com/cakephp/cakephp/pull/13954","diff_url":"https://github.com/cakephp/cakephp/pull/13954.diff","patch_url":"https://github.com/cakephp/cakephp/pull/13954.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/13954","number":13954,"state":"open","locked":false,"title":"Add connection id to the queries log","user":{"login":"bancer","id":3830106,"node_id":"MDQ6VXNlcjM4MzAxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3830106?v=4","gravatar_id":"","url":"https://api.github.com/users/bancer","html_url":"https://github.com/bancer","followers_url":"https://api.github.com/users/bancer/followers","following_url":"https://api.github.com/users/bancer/following{/other_user}","gists_url":"https://api.github.com/users/bancer/gists{/gist_id}","starred_url":"https://api.github.com/users/bancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bancer/subscriptions","organizations_url":"https://api.github.com/users/bancer/orgs","repos_url":"https://api.github.com/users/bancer/repos","events_url":"https://api.github.com/users/bancer/events{/privacy}","received_events_url":"https://api.github.com/users/bancer/received_events","type":"User","site_admin":false},"body":"Fixes #13768","created_at":"2019-11-28T10:00:53Z","updated_at":"2019-11-28T15:54:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b3be29c23ac300e0c23d5f128c19a8613641cf3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60504144,"node_id":"MDU6TGFiZWw2MDUwNDE0NA==","url":"https://api.github.com/repos/cakephp/cakephp/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true,"description":""}],"milestone":{"url":"https://api.github.com/repos/cakephp/cakephp/milestones/202","html_url":"https://github.com/cakephp/cakephp/milestone/202","labels_url":"https://api.github.com/repos/cakephp/cakephp/milestones/202/labels","id":4446782,"node_id":"MDk6TWlsZXN0b25lNDQ0Njc4Mg==","number":202,"title":"3.9.0","description":null,"creator":{"login":"ravage84","id":625761,"node_id":"MDQ6VXNlcjYyNTc2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/625761?v=4","gravatar_id":"","url":"https://api.github.com/users/ravage84","html_url":"https://github.com/ravage84","followers_url":"https://api.github.com/users/ravage84/followers","following_url":"https://api.github.com/users/ravage84/following{/other_user}","gists_url":"https://api.github.com/users/ravage84/gists{/gist_id}","starred_url":"https://api.github.com/users/ravage84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravage84/subscriptions","organizations_url":"https://api.github.com/users/ravage84/orgs","repos_url":"https://api.github.com/users/ravage84/repos","events_url":"https://api.github.com/users/ravage84/events{/privacy}","received_events_url":"https://api.github.com/users/ravage84/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":47,"state":"open","created_at":"2019-06-27T16:30:16Z","updated_at":"2019-11-28T15:07:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13954/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/13954/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/13954/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/cf9209c429c397eb5445337a7b983dd73072f071","head":{"label":"bancer:issue-13768-query-logger","ref":"issue-13768-query-logger","sha":"cf9209c429c397eb5445337a7b983dd73072f071","user":{"login":"bancer","id":3830106,"node_id":"MDQ6VXNlcjM4MzAxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3830106?v=4","gravatar_id":"","url":"https://api.github.com/users/bancer","html_url":"https://github.com/bancer","followers_url":"https://api.github.com/users/bancer/followers","following_url":"https://api.github.com/users/bancer/following{/other_user}","gists_url":"https://api.github.com/users/bancer/gists{/gist_id}","starred_url":"https://api.github.com/users/bancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bancer/subscriptions","organizations_url":"https://api.github.com/users/bancer/orgs","repos_url":"https://api.github.com/users/bancer/repos","events_url":"https://api.github.com/users/bancer/events{/privacy}","received_events_url":"https://api.github.com/users/bancer/received_events","type":"User","site_admin":false},"repo":{"id":57134037,"node_id":"MDEwOlJlcG9zaXRvcnk1NzEzNDAzNw==","name":"CakePHP-framework","full_name":"bancer/CakePHP-framework","private":false,"owner":{"login":"bancer","id":3830106,"node_id":"MDQ6VXNlcjM4MzAxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3830106?v=4","gravatar_id":"","url":"https://api.github.com/users/bancer","html_url":"https://github.com/bancer","followers_url":"https://api.github.com/users/bancer/followers","following_url":"https://api.github.com/users/bancer/following{/other_user}","gists_url":"https://api.github.com/users/bancer/gists{/gist_id}","starred_url":"https://api.github.com/users/bancer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bancer/subscriptions","organizations_url":"https://api.github.com/users/bancer/orgs","repos_url":"https://api.github.com/users/bancer/repos","events_url":"https://api.github.com/users/bancer/events{/privacy}","received_events_url":"https://api.github.com/users/bancer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bancer/CakePHP-framework","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/bancer/CakePHP-framework","forks_url":"https://api.github.com/repos/bancer/CakePHP-framework/forks","keys_url":"https://api.github.com/repos/bancer/CakePHP-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bancer/CakePHP-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bancer/CakePHP-framework/teams","hooks_url":"https://api.github.com/repos/bancer/CakePHP-framework/hooks","issue_events_url":"https://api.github.com/repos/bancer/CakePHP-framework/issues/events{/number}","events_url":"https://api.github.com/repos/bancer/CakePHP-framework/events","assignees_url":"https://api.github.com/repos/bancer/CakePHP-framework/assignees{/user}","branches_url":"https://api.github.com/repos/bancer/CakePHP-framework/branches{/branch}","tags_url":"https://api.github.com/repos/bancer/CakePHP-framework/tags","blobs_url":"https://api.github.com/repos/bancer/CakePHP-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bancer/CakePHP-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bancer/CakePHP-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/bancer/CakePHP-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bancer/CakePHP-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/bancer/CakePHP-framework/languages","stargazers_url":"https://api.github.com/repos/bancer/CakePHP-framework/stargazers","contributors_url":"https://api.github.com/repos/bancer/CakePHP-framework/contributors","subscribers_url":"https://api.github.com/repos/bancer/CakePHP-framework/subscribers","subscription_url":"https://api.github.com/repos/bancer/CakePHP-framework/subscription","commits_url":"https://api.github.com/repos/bancer/CakePHP-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/bancer/CakePHP-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/bancer/CakePHP-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/bancer/CakePHP-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/bancer/CakePHP-framework/contents/{+path}","compare_url":"https://api.github.com/repos/bancer/CakePHP-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bancer/CakePHP-framework/merges","archive_url":"https://api.github.com/repos/bancer/CakePHP-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bancer/CakePHP-framework/downloads","issues_url":"https://api.github.com/repos/bancer/CakePHP-framework/issues{/number}","pulls_url":"https://api.github.com/repos/bancer/CakePHP-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/bancer/CakePHP-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/bancer/CakePHP-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bancer/CakePHP-framework/labels{/name}","releases_url":"https://api.github.com/repos/bancer/CakePHP-framework/releases{/id}","deployments_url":"https://api.github.com/repos/bancer/CakePHP-framework/deployments","created_at":"2016-04-26T14:15:51Z","updated_at":"2019-08-07T11:37:08Z","pushed_at":"2019-11-28T10:49:53Z","git_url":"git://github.com/bancer/CakePHP-framework.git","ssh_url":"git@github.com:bancer/CakePHP-framework.git","clone_url":"https://github.com/bancer/CakePHP-framework.git","svn_url":"https://github.com/bancer/CakePHP-framework","homepage":"http://cakephp.org","size":87902,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:3.next","ref":"3.next","sha":"d02de91af82b5f23980020f3298e451a85310ae1","user":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"node_id":"MDEwOlJlcG9zaXRvcnk2NTY0OTQ=","name":"cakephp","full_name":"cakephp/cakephp","private":false,"owner":{"login":"cakephp","id":23666,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjY2","avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2019-11-28T08:40:26Z","pushed_at":"2019-11-28T10:49:55Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":89098,"stargazers_count":8033,"watchers_count":8033,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3436,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":100,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3436,"open_issues":100,"watchers":8033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13954"},"html":{"href":"https://github.com/cakephp/cakephp/pull/13954"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13954"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/13954/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13954/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/13954/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/cf9209c429c397eb5445337a7b983dd73072f071"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 656494,
"name": "cakephp/cakephp",
"url": "https://api.github.com/repos/cakephp/cakephp"
}
|
{
"id": 3830106,
"login": "bancer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3830106?",
"url": "https://api.github.com/users/bancer"
}
|
{
"id": 23666,
"login": "cakephp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/23666?",
"url": "https://api.github.com/orgs/cakephp"
}
| 2019-11-28T15:54:45 |
10970407439
|
{"actor":{"display_login":"bancer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/348526951","pull_request_review_id":319915949,"id":348526951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODUyNjk1MQ==","diff_hunk":"@@ -28,17 +32,16 @@ echo \"END\\n\";\n ?>\n --EXPECTF--\n Warning: proc_open(): pi is not a valid descriptor spec/mode in %s on line %d\n-\n-Warning: proc_open(): Descriptor item must be either an array or a File-Handle in %s on line %d\n+Descriptor item must be either an array or a File-Handle\n array(4) {\n [3]=>\n- resource(%d) of type (Unknown)\n+ resource(4) of type (Unknown)","path":"ext/standard/tests/general_functions/proc_open_pipes3.phpt","position":23,"original_position":23,"commit_id":"19a2cc37805f52945d12766a249a9b268c91209c","original_commit_id":"19a2cc37805f52945d12766a249a9b268c91209c","user":{"login":"kocsismate","id":6057627,"node_id":"MDQ6VXNlcjYwNTc2Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6057627?v=4","gravatar_id":"","url":"https://api.github.com/users/kocsismate","html_url":"https://github.com/kocsismate","followers_url":"https://api.github.com/users/kocsismate/followers","following_url":"https://api.github.com/users/kocsismate/following{/other_user}","gists_url":"https://api.github.com/users/kocsismate/gists{/gist_id}","starred_url":"https://api.github.com/users/kocsismate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocsismate/subscriptions","organizations_url":"https://api.github.com/users/kocsismate/orgs","repos_url":"https://api.github.com/users/kocsismate/repos","events_url":"https://api.github.com/users/kocsismate/events{/privacy}","received_events_url":"https://api.github.com/users/kocsismate/received_events","type":"User","site_admin":false},"body":"Yeah, sure. Somehow, it screwed them up.","created_at":"2019-11-20T14:54:05Z","updated_at":"2019-11-20T14:54:05Z","html_url":"https://github.com/php/php-src/pull/4937#discussion_r348526951","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/4937","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/348526951"},"html":{"href":"https://github.com/php/php-src/pull/4937#discussion_r348526951"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/4937"}},"in_reply_to_id":348511119},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/4937","id":343256774,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQzMjU2Nzc0","html_url":"https://github.com/php/php-src/pull/4937","diff_url":"https://github.com/php/php-src/pull/4937.diff","patch_url":"https://github.com/php/php-src/pull/4937.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/4937","number":4937,"state":"open","locked":false,"title":"Promote warnings to exceptions in the standard lib","user":{"login":"kocsismate","id":6057627,"node_id":"MDQ6VXNlcjYwNTc2Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6057627?v=4","gravatar_id":"","url":"https://api.github.com/users/kocsismate","html_url":"https://github.com/kocsismate","followers_url":"https://api.github.com/users/kocsismate/followers","following_url":"https://api.github.com/users/kocsismate/following{/other_user}","gists_url":"https://api.github.com/users/kocsismate/gists{/gist_id}","starred_url":"https://api.github.com/users/kocsismate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocsismate/subscriptions","organizations_url":"https://api.github.com/users/kocsismate/orgs","repos_url":"https://api.github.com/users/kocsismate/repos","events_url":"https://api.github.com/users/kocsismate/events{/privacy}","received_events_url":"https://api.github.com/users/kocsismate/received_events","type":"User","site_admin":false},"body":"I tried to choose warnings where promotion didn't seem problematic. I committed all the promotions separately, but I can also `explode()` the PR into smaller ones.\r\n\r\nP.S. I'll fix the rest of the tests later tonight.","created_at":"2019-11-20T09:36:30Z","updated_at":"2019-11-20T14:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f56f1e593f68bec4d27107c6916b19c820e1397","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/4937/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/4937/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/4937/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/19a2cc37805f52945d12766a249a9b268c91209c","head":{"label":"kocsismate:standard-exceptions","ref":"standard-exceptions","sha":"19a2cc37805f52945d12766a249a9b268c91209c","user":{"login":"kocsismate","id":6057627,"node_id":"MDQ6VXNlcjYwNTc2Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6057627?v=4","gravatar_id":"","url":"https://api.github.com/users/kocsismate","html_url":"https://github.com/kocsismate","followers_url":"https://api.github.com/users/kocsismate/followers","following_url":"https://api.github.com/users/kocsismate/following{/other_user}","gists_url":"https://api.github.com/users/kocsismate/gists{/gist_id}","starred_url":"https://api.github.com/users/kocsismate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocsismate/subscriptions","organizations_url":"https://api.github.com/users/kocsismate/orgs","repos_url":"https://api.github.com/users/kocsismate/repos","events_url":"https://api.github.com/users/kocsismate/events{/privacy}","received_events_url":"https://api.github.com/users/kocsismate/received_events","type":"User","site_admin":false},"repo":{"id":213848847,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM4NDg4NDc=","name":"php-src","full_name":"kocsismate/php-src","private":false,"owner":{"login":"kocsismate","id":6057627,"node_id":"MDQ6VXNlcjYwNTc2Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/6057627?v=4","gravatar_id":"","url":"https://api.github.com/users/kocsismate","html_url":"https://github.com/kocsismate","followers_url":"https://api.github.com/users/kocsismate/followers","following_url":"https://api.github.com/users/kocsismate/following{/other_user}","gists_url":"https://api.github.com/users/kocsismate/gists{/gist_id}","starred_url":"https://api.github.com/users/kocsismate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocsismate/subscriptions","organizations_url":"https://api.github.com/users/kocsismate/orgs","repos_url":"https://api.github.com/users/kocsismate/repos","events_url":"https://api.github.com/users/kocsismate/events{/privacy}","received_events_url":"https://api.github.com/users/kocsismate/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kocsismate/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/kocsismate/php-src","forks_url":"https://api.github.com/repos/kocsismate/php-src/forks","keys_url":"https://api.github.com/repos/kocsismate/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kocsismate/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kocsismate/php-src/teams","hooks_url":"https://api.github.com/repos/kocsismate/php-src/hooks","issue_events_url":"https://api.github.com/repos/kocsismate/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/kocsismate/php-src/events","assignees_url":"https://api.github.com/repos/kocsismate/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/kocsismate/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/kocsismate/php-src/tags","blobs_url":"https://api.github.com/repos/kocsismate/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kocsismate/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kocsismate/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/kocsismate/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kocsismate/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/kocsismate/php-src/languages","stargazers_url":"https://api.github.com/repos/kocsismate/php-src/stargazers","contributors_url":"https://api.github.com/repos/kocsismate/php-src/contributors","subscribers_url":"https://api.github.com/repos/kocsismate/php-src/subscribers","subscription_url":"https://api.github.com/repos/kocsismate/php-src/subscription","commits_url":"https://api.github.com/repos/kocsismate/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/kocsismate/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/kocsismate/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/kocsismate/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/kocsismate/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/kocsismate/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kocsismate/php-src/merges","archive_url":"https://api.github.com/repos/kocsismate/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kocsismate/php-src/downloads","issues_url":"https://api.github.com/repos/kocsismate/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/kocsismate/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/kocsismate/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/kocsismate/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kocsismate/php-src/labels{/name}","releases_url":"https://api.github.com/repos/kocsismate/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/kocsismate/php-src/deployments","created_at":"2019-10-09T07:21:02Z","updated_at":"2019-11-18T14:34:08Z","pushed_at":"2019-11-20T13:50:09Z","git_url":"git://github.com/kocsismate/php-src.git","ssh_url":"git@github.com:kocsismate/php-src.git","clone_url":"https://github.com/kocsismate/php-src.git","svn_url":"https://github.com/kocsismate/php-src","homepage":"https://www.php.net","size":380158,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"f7c44ef2a0e1e1e5bed5527b8899c66b00416f43","user":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzNTIy","name":"php-src","full_name":"php/php-src","private":false,"owner":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2019-11-20T14:32:00Z","pushed_at":"2019-11-20T14:46:21Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"https://www.php.net","size":379903,"stargazers_count":25579,"watchers_count":25579,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5824,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":181,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5824,"open_issues":181,"watchers":25579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/4937"},"html":{"href":"https://github.com/php/php-src/pull/4937"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/4937"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/4937/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/4937/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/4937/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/19a2cc37805f52945d12766a249a9b268c91209c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 1903522,
"name": "php/php-src",
"url": "https://api.github.com/repos/php/php-src"
}
|
{
"id": 6057627,
"login": "kocsismate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6057627?",
"url": "https://api.github.com/users/kocsismate"
}
|
{
"id": 25158,
"login": "php",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25158?",
"url": "https://api.github.com/orgs/php"
}
| 2019-11-20T14:54:05 |
10907473860
|
{"actor":{"display_login":"kocsismate"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chef/chef/pulls/comments/263988426","pull_request_review_id":212549759,"id":263988426,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2Mzk4ODQyNg==","diff_hunk":"@@ -0,0 +1,117 @@\n+---\n+title: Data Collector\n+---\n+\n+# Data Collector RFC\n+\n+The Data Collector design and API is covered in:\n+\n+https://github.com/chef/chef-rfc/blob/master/rfc077-mode-agnostic-data-collection.md","path":"docs/dev/data_collector.md","position":9,"original_position":9,"commit_id":"64875e2d9e68dfb0f20b61494320a2c78c885937","original_commit_id":"64875e2d9e68dfb0f20b61494320a2c78c885937","user":{"login":"tas50","id":1015200,"node_id":"MDQ6VXNlcjEwMTUyMDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1015200?v=4","gravatar_id":"","url":"https://api.github.com/users/tas50","html_url":"https://github.com/tas50","followers_url":"https://api.github.com/users/tas50/followers","following_url":"https://api.github.com/users/tas50/following{/other_user}","gists_url":"https://api.github.com/users/tas50/gists{/gist_id}","starred_url":"https://api.github.com/users/tas50/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tas50/subscriptions","organizations_url":"https://api.github.com/users/tas50/orgs","repos_url":"https://api.github.com/users/tas50/repos","events_url":"https://api.github.com/users/tas50/events{/privacy}","received_events_url":"https://api.github.com/users/tas50/received_events","type":"User","site_admin":false},"body":"I'd assume this repo is going to go away in the near future and dump the contents here if they're still valid","created_at":"2019-03-09T06:17:06Z","updated_at":"2019-03-09T06:17:06Z","html_url":"https://github.com/chef/chef/pull/8063#discussion_r263988426","pull_request_url":"https://api.github.com/repos/chef/chef/pulls/8063","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/comments/263988426"},"html":{"href":"https://github.com/chef/chef/pull/8063#discussion_r263988426"},"pull_request":{"href":"https://api.github.com/repos/chef/chef/pulls/8063"}}},"pull_request":{"url":"https://api.github.com/repos/chef/chef/pulls/8063","id":239607223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjA3MjIz","html_url":"https://github.com/chef/chef/pull/8063","diff_url":"https://github.com/chef/chef/pull/8063.diff","patch_url":"https://github.com/chef/chef/pull/8063.patch","issue_url":"https://api.github.com/repos/chef/chef/issues/8063","number":8063,"state":"open","locked":false,"title":"Extract ActionCollection out of ResourceReporter, overhaul DataCollector","user":{"login":"lamont-granquist","id":454857,"node_id":"MDQ6VXNlcjQ1NDg1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/454857?v=4","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"This overhauls the ResourceReporter and DataCollector code, and extracts an ActionCollection class which is common code (which can also be used for zap-like utilities to inspect the sequence of actions chef-client takes).\r\n\r\n- The tight coupling between Chef::Client and the DataCollector has been removed. The DataCollector and the ResourceReporter have been made responsible for disabling themselves.\r\n\r\n- For the ActionCollection, users are expected to register with the ActionCollection by hooking the action_collection_registration event. If no objects have registered themselves with the ActionCollection then the ActionCollection will deregister itself with the Dispatcher, which will save piles of useless work + memory consumption if nobody cares. Users may also call the ActionCollection directly to register (e.g. at library class loading time -- if writing an event handler is too \"heavy\").\r\n\r\n- Users must register by the time that recipe compile time is starting. The cookbook_compilation_start event is hooked by the ActionCollection which is where it enqueues the action_collection_registration action, passing itself as an argument. The Dispatcher has been modified to support this kind of event chaining. What this means is that the action_collection_registration hook is sent at the latest possible time, and users must have made a decision at that point as to if they are interested in the action collection tracking or not.\r\n\r\n- The DataCollector now sends its output format to a file in JSON format instead of a largely-unusable un-marshalled puts of a Hash object with complex sub-objects that cannot be parsed (considered a bugfix since the prior format was un-parseable)\r\n\r\n- The DataCollector now sends all resources and sub-resources in its output. The sub-resources appear before the wrapping resource (in the same order as the resource_completed calls).\r\n\r\n- The DataCollector count of updated and total resources should match the client-client run, along with being internally consistent with the resource report.\r\n\r\n- In the DataCollector, failed resources that successfully loaded their current state now report their current state.\r\n\r\n- Early failures to the client in e.g. client registration, node loading, run_list expansion, cookbook resolution and cookbook synchronization are now handled by the data collector. Failures to parse the config will still cause nodes to disappear (with no config where should the report be sent to? what should the token be?)\r\n\r\n- EventDispatcher has been extended to be able for registered objects to unregister\r\n\r\n- EventDispatcher has been extended to be able to chain an event from a current event\r\n\r\n- chef_guid code has been extracted from the Chef::Client and made the sole responsibility of the DataCollector\r\n\r\n- Chef::Resources now have an executed_by_runner flag which is set to true by the Runner when the resource is fired. If execution of the ResourceCollection aborts untouched resources will have this flag unset. This is now used by the DataCollector to report \"unprocessed\" resources -- considerably simplifying that logic.\r\n\r\n- The run_context gains an action_collection accessor which is what cookbook-consumers of the action_collection are expected to use.\r\n\r\n- Various tweaks to events and signatures and the run_state clock were necessary for resilience in the face of early failures.","created_at":"2018-12-18T19:38:46Z","updated_at":"2019-03-09T06:17:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f488fa785b6db6915a6f8b05d365bd04107ccea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1178430868,"node_id":"MDU6TGFiZWwxMTc4NDMwODY4","url":"https://api.github.com/repos/chef/chef/labels/Type:%20Tech%20Debt","name":"Type: Tech Debt","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chef/chef/pulls/8063/commits","review_comments_url":"https://api.github.com/repos/chef/chef/pulls/8063/comments","review_comment_url":"https://api.github.com/repos/chef/chef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/chef/issues/8063/comments","statuses_url":"https://api.github.com/repos/chef/chef/statuses/64875e2d9e68dfb0f20b61494320a2c78c885937","head":{"label":"chef:lcg/action_collection","ref":"lcg/action_collection","sha":"64875e2d9e68dfb0f20b61494320a2c78c885937","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzg=","name":"chef","full_name":"chef/chef","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2019-03-09T04:12:40Z","pushed_at":"2019-03-09T02:17:24Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":110008,"stargazers_count":5680,"watchers_count":5680,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2296,"mirror_url":null,"archived":false,"open_issues_count":573,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2296,"open_issues":573,"watchers":5680,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"4037976199b728d4bdc18fd428e8d40a84c97e2b","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":108278,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzg=","name":"chef","full_name":"chef/chef","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/chef","description":"A systems integration framework, built to bring the benefits of configuration management to your entire infrastructure.","fork":false,"url":"https://api.github.com/repos/chef/chef","forks_url":"https://api.github.com/repos/chef/chef/forks","keys_url":"https://api.github.com/repos/chef/chef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/chef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/chef/teams","hooks_url":"https://api.github.com/repos/chef/chef/hooks","issue_events_url":"https://api.github.com/repos/chef/chef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/chef/events","assignees_url":"https://api.github.com/repos/chef/chef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/chef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/chef/tags","blobs_url":"https://api.github.com/repos/chef/chef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/chef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/chef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/chef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/chef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/chef/languages","stargazers_url":"https://api.github.com/repos/chef/chef/stargazers","contributors_url":"https://api.github.com/repos/chef/chef/contributors","subscribers_url":"https://api.github.com/repos/chef/chef/subscribers","subscription_url":"https://api.github.com/repos/chef/chef/subscription","commits_url":"https://api.github.com/repos/chef/chef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/chef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/chef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/chef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/chef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/chef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/chef/merges","archive_url":"https://api.github.com/repos/chef/chef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/chef/downloads","issues_url":"https://api.github.com/repos/chef/chef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/chef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/chef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/chef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/chef/labels{/name}","releases_url":"https://api.github.com/repos/chef/chef/releases{/id}","deployments_url":"https://api.github.com/repos/chef/chef/deployments","created_at":"2009-01-15T20:40:48Z","updated_at":"2019-03-09T04:12:40Z","pushed_at":"2019-03-09T02:17:24Z","git_url":"git://github.com/chef/chef.git","ssh_url":"git@github.com:chef/chef.git","clone_url":"https://github.com/chef/chef.git","svn_url":"https://github.com/chef/chef","homepage":"http://www.chef.io/chef/","size":110008,"stargazers_count":5680,"watchers_count":5680,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2296,"mirror_url":null,"archived":false,"open_issues_count":573,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2296,"open_issues":573,"watchers":5680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/chef/pulls/8063"},"html":{"href":"https://github.com/chef/chef/pull/8063"},"issue":{"href":"https://api.github.com/repos/chef/chef/issues/8063"},"comments":{"href":"https://api.github.com/repos/chef/chef/issues/8063/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/chef/pulls/8063/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/chef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/chef/pulls/8063/commits"},"statuses":{"href":"https://api.github.com/repos/chef/chef/statuses/64875e2d9e68dfb0f20b61494320a2c78c885937"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 108278,
"name": "chef/chef",
"url": "https://api.github.com/repos/chef/chef"
}
|
{
"id": 1015200,
"login": "tas50",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1015200?",
"url": "https://api.github.com/users/tas50"
}
|
{
"id": 29740,
"login": "chef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29740?",
"url": "https://api.github.com/orgs/chef"
}
| 2019-03-09T06:17:06 |
9210528467
|
{"actor":{"display_login":"tas50"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chef/automate/pulls/comments/293753646","pull_request_review_id":249830085,"id":293753646,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Mzc1MzY0Ng==","diff_hunk":"@@ -0,0 +1,30 @@\n+ALTER TABLE service ADD COLUMN full_pkg_ident TEXT NOT NULL DEFAULT '';","path":"components/applications-service/pkg/storage/postgres/schema/sql/03_service_group_view.up.sql","position":1,"original_position":1,"commit_id":"ca6f80a8152ac73a14ddd26b287b3bee0a8c1eb4","original_commit_id":"ca6f80a8152ac73a14ddd26b287b3bee0a8c1eb4","user":{"login":"afiune","id":5712253,"node_id":"MDQ6VXNlcjU3MTIyNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/5712253?v=4","gravatar_id":"","url":"https://api.github.com/users/afiune","html_url":"https://github.com/afiune","followers_url":"https://api.github.com/users/afiune/followers","following_url":"https://api.github.com/users/afiune/following{/other_user}","gists_url":"https://api.github.com/users/afiune/gists{/gist_id}","starred_url":"https://api.github.com/users/afiune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afiune/subscriptions","organizations_url":"https://api.github.com/users/afiune/orgs","repos_url":"https://api.github.com/users/afiune/repos","events_url":"https://api.github.com/users/afiune/events{/privacy}","received_events_url":"https://api.github.com/users/afiune/received_events","type":"User","site_admin":false},"body":"What happens with existing records? \r\n\r\nExample: How would this impact our dev environment? https://a2-perf-test-single-local-inplace-upgrade-dev.cd.chef.co/applications","created_at":"2019-06-14T10:35:47Z","updated_at":"2019-06-14T10:35:47Z","html_url":"https://github.com/chef/automate/pull/580#discussion_r293753646","pull_request_url":"https://api.github.com/repos/chef/automate/pulls/580","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chef/automate/pulls/comments/293753646"},"html":{"href":"https://github.com/chef/automate/pull/580#discussion_r293753646"},"pull_request":{"href":"https://api.github.com/repos/chef/automate/pulls/580"}}},"pull_request":{"url":"https://api.github.com/repos/chef/automate/pulls/580","id":287663445,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3NjYzNDQ1","html_url":"https://github.com/chef/automate/pull/580","diff_url":"https://github.com/chef/automate/pull/580.diff","patch_url":"https://github.com/chef/automate/pull/580.patch","issue_url":"https://api.github.com/repos/chef/automate/issues/580","number":580,"state":"open","locked":false,"title":"Improved service group query to use a view","user":{"login":"kmacgugan","id":11166450,"node_id":"MDQ6VXNlcjExMTY2NDUw","avatar_url":"https://avatars0.githubusercontent.com/u/11166450?v=4","gravatar_id":"","url":"https://api.github.com/users/kmacgugan","html_url":"https://github.com/kmacgugan","followers_url":"https://api.github.com/users/kmacgugan/followers","following_url":"https://api.github.com/users/kmacgugan/following{/other_user}","gists_url":"https://api.github.com/users/kmacgugan/gists{/gist_id}","starred_url":"https://api.github.com/users/kmacgugan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmacgugan/subscriptions","organizations_url":"https://api.github.com/users/kmacgugan/orgs","repos_url":"https://api.github.com/users/kmacgugan/repos","events_url":"https://api.github.com/users/kmacgugan/events{/privacy}","received_events_url":"https://api.github.com/users/kmacgugan/received_events","type":"User","site_admin":false},"body":"Added column for full package identity so the query doesn't have to re-concat it\r\nSigned-off-by: kmacgugan <kmacgugan@chef.io>\r\n\r\n### :nut_and_bolt: Description\r\n\r\n### :+1: Definition of Done\r\n\r\n### :athletic_shoe: Demo Script / Repro Steps\r\n\r\n### :chains: Related Resources\r\n\r\n### :white_check_mark: Checklist\r\n\r\n- [ ] Necessary tests added/updated?\r\n- [ ] Necessary docs added/updated?\r\n- [ ] Code actually executed?\r\n- [ ] Vetting performed (unit tests, lint, etc.)?\r\n","created_at":"2019-06-12T20:27:13Z","updated_at":"2019-06-14T10:35:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ea3acb57410a34c49d2b074c5e25cb04ee84989","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chef/automate/pulls/580/commits","review_comments_url":"https://api.github.com/repos/chef/automate/pulls/580/comments","review_comment_url":"https://api.github.com/repos/chef/automate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/automate/issues/580/comments","statuses_url":"https://api.github.com/repos/chef/automate/statuses/ca6f80a8152ac73a14ddd26b287b3bee0a8c1eb4","head":{"label":"chef:km/sg-view-refactor","ref":"km/sg-view-refactor","sha":"ca6f80a8152ac73a14ddd26b287b3bee0a8c1eb4","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":179318179,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzMTgxNzk=","name":"automate","full_name":"chef/automate","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/automate","description":"Chef Automate","fork":false,"url":"https://api.github.com/repos/chef/automate","forks_url":"https://api.github.com/repos/chef/automate/forks","keys_url":"https://api.github.com/repos/chef/automate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/automate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/automate/teams","hooks_url":"https://api.github.com/repos/chef/automate/hooks","issue_events_url":"https://api.github.com/repos/chef/automate/issues/events{/number}","events_url":"https://api.github.com/repos/chef/automate/events","assignees_url":"https://api.github.com/repos/chef/automate/assignees{/user}","branches_url":"https://api.github.com/repos/chef/automate/branches{/branch}","tags_url":"https://api.github.com/repos/chef/automate/tags","blobs_url":"https://api.github.com/repos/chef/automate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/automate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/automate/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/automate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/automate/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/automate/languages","stargazers_url":"https://api.github.com/repos/chef/automate/stargazers","contributors_url":"https://api.github.com/repos/chef/automate/contributors","subscribers_url":"https://api.github.com/repos/chef/automate/subscribers","subscription_url":"https://api.github.com/repos/chef/automate/subscription","commits_url":"https://api.github.com/repos/chef/automate/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/automate/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/automate/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/automate/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/automate/contents/{+path}","compare_url":"https://api.github.com/repos/chef/automate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/automate/merges","archive_url":"https://api.github.com/repos/chef/automate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/automate/downloads","issues_url":"https://api.github.com/repos/chef/automate/issues{/number}","pulls_url":"https://api.github.com/repos/chef/automate/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/automate/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/automate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/automate/labels{/name}","releases_url":"https://api.github.com/repos/chef/automate/releases{/id}","deployments_url":"https://api.github.com/repos/chef/automate/deployments","created_at":"2019-04-03T15:26:38Z","updated_at":"2019-06-14T06:08:06Z","pushed_at":"2019-06-14T10:31:47Z","git_url":"git://github.com/chef/automate.git","ssh_url":"git@github.com:chef/automate.git","clone_url":"https://github.com/chef/automate.git","svn_url":"https://github.com/chef/automate","homepage":"https://automate.chef.io/","size":67598,"stargazers_count":61,"watchers_count":61,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":138,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":138,"watchers":61,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"5bb5a95486109dbe62df3325908ed8c4a4a23d94","user":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":179318179,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkzMTgxNzk=","name":"automate","full_name":"chef/automate","private":false,"owner":{"login":"chef","id":29740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzQw","avatar_url":"https://avatars3.githubusercontent.com/u/29740?v=4","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chef/automate","description":"Chef Automate","fork":false,"url":"https://api.github.com/repos/chef/automate","forks_url":"https://api.github.com/repos/chef/automate/forks","keys_url":"https://api.github.com/repos/chef/automate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/automate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/automate/teams","hooks_url":"https://api.github.com/repos/chef/automate/hooks","issue_events_url":"https://api.github.com/repos/chef/automate/issues/events{/number}","events_url":"https://api.github.com/repos/chef/automate/events","assignees_url":"https://api.github.com/repos/chef/automate/assignees{/user}","branches_url":"https://api.github.com/repos/chef/automate/branches{/branch}","tags_url":"https://api.github.com/repos/chef/automate/tags","blobs_url":"https://api.github.com/repos/chef/automate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/automate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/automate/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/automate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/automate/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/automate/languages","stargazers_url":"https://api.github.com/repos/chef/automate/stargazers","contributors_url":"https://api.github.com/repos/chef/automate/contributors","subscribers_url":"https://api.github.com/repos/chef/automate/subscribers","subscription_url":"https://api.github.com/repos/chef/automate/subscription","commits_url":"https://api.github.com/repos/chef/automate/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/automate/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/automate/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/automate/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/automate/contents/{+path}","compare_url":"https://api.github.com/repos/chef/automate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/automate/merges","archive_url":"https://api.github.com/repos/chef/automate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/automate/downloads","issues_url":"https://api.github.com/repos/chef/automate/issues{/number}","pulls_url":"https://api.github.com/repos/chef/automate/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/automate/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/automate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/automate/labels{/name}","releases_url":"https://api.github.com/repos/chef/automate/releases{/id}","deployments_url":"https://api.github.com/repos/chef/automate/deployments","created_at":"2019-04-03T15:26:38Z","updated_at":"2019-06-14T06:08:06Z","pushed_at":"2019-06-14T10:31:47Z","git_url":"git://github.com/chef/automate.git","ssh_url":"git@github.com:chef/automate.git","clone_url":"https://github.com/chef/automate.git","svn_url":"https://github.com/chef/automate","homepage":"https://automate.chef.io/","size":67598,"stargazers_count":61,"watchers_count":61,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":138,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":138,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/automate/pulls/580"},"html":{"href":"https://github.com/chef/automate/pull/580"},"issue":{"href":"https://api.github.com/repos/chef/automate/issues/580"},"comments":{"href":"https://api.github.com/repos/chef/automate/issues/580/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/automate/pulls/580/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/automate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/automate/pulls/580/commits"},"statuses":{"href":"https://api.github.com/repos/chef/automate/statuses/ca6f80a8152ac73a14ddd26b287b3bee0a8c1eb4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179318179,
"name": "chef/automate",
"url": "https://api.github.com/repos/chef/automate"
}
|
{
"id": 5712253,
"login": "afiune",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5712253?",
"url": "https://api.github.com/users/afiune"
}
|
{
"id": 29740,
"login": "chef",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29740?",
"url": "https://api.github.com/orgs/chef"
}
| 2019-06-14T10:35:47 |
9822771989
|
{"actor":{"display_login":"afiune"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/rentpath/avro_ex/pulls/comments/284859441","pull_request_review_id":238588785,"id":284859441,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NDg1OTQ0MQ==","diff_hunk":"@@ -157,12 +157,15 @@ defmodule AvroEx.Encode do\n size ->\n acc = do_encode(%Primitive{type: :long}, context, size)\n \n- Enum.reduce(map, acc, fn {k, v}, acc ->\n- key = do_encode(%Primitive{type: :string}, context, k)\n- value = do_encode(values, context, v)\n+ encoded_map =\n+ Enum.reduce(map, acc, fn {k, v}, acc ->\n+ key = do_encode(%Primitive{type: :string}, context, k)\n+ value = do_encode(values, context, v)\n \n- acc <> key <> value\n- end)\n+ acc <> key <> value\n+ end)\n+\n+ encoded_map <> <<0>>","path":"lib/avro_ex/encode.ex","position":17,"original_position":17,"commit_id":"2fa2fdeaeea8abd99164011955cc0c72bd847583","original_commit_id":"2fa2fdeaeea8abd99164011955cc0c72bd847583","user":{"login":"michaelstalker","id":636342,"node_id":"MDQ6VXNlcjYzNjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/636342?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelstalker","html_url":"https://github.com/michaelstalker","followers_url":"https://api.github.com/users/michaelstalker/followers","following_url":"https://api.github.com/users/michaelstalker/following{/other_user}","gists_url":"https://api.github.com/users/michaelstalker/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelstalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelstalker/subscriptions","organizations_url":"https://api.github.com/users/michaelstalker/orgs","repos_url":"https://api.github.com/users/michaelstalker/repos","events_url":"https://api.github.com/users/michaelstalker/events{/privacy}","received_events_url":"https://api.github.com/users/michaelstalker/received_events","type":"User","site_admin":false},"body":"The spec doesn't mention a 0 terminator for [maps](https://avro.apache.org/docs/current/spec.html#map_encoding) like it does with [arrays](https://avro.apache.org/docs/current/spec.html#array_encoding). Have you tested these changes to the map implementation yet?","created_at":"2019-05-16T19:18:32Z","updated_at":"2019-05-16T19:27:03Z","html_url":"https://github.com/rentpath/avro_ex/pull/2#discussion_r284859441","pull_request_url":"https://api.github.com/repos/rentpath/avro_ex/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/comments/284859441"},"html":{"href":"https://github.com/rentpath/avro_ex/pull/2#discussion_r284859441"},"pull_request":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/rentpath/avro_ex/pulls/2","id":279627075,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc5NjI3MDc1","html_url":"https://github.com/rentpath/avro_ex/pull/2","diff_url":"https://github.com/rentpath/avro_ex/pull/2.diff","patch_url":"https://github.com/rentpath/avro_ex/pull/2.patch","issue_url":"https://api.github.com/repos/rentpath/avro_ex/issues/2","number":2,"state":"open","locked":false,"title":"Encoding fixes","user":{"login":"doomspork","id":73386,"node_id":"MDQ6VXNlcjczMzg2","avatar_url":"https://avatars0.githubusercontent.com/u/73386?v=4","gravatar_id":"","url":"https://api.github.com/users/doomspork","html_url":"https://github.com/doomspork","followers_url":"https://api.github.com/users/doomspork/followers","following_url":"https://api.github.com/users/doomspork/following{/other_user}","gists_url":"https://api.github.com/users/doomspork/gists{/gist_id}","starred_url":"https://api.github.com/users/doomspork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doomspork/subscriptions","organizations_url":"https://api.github.com/users/doomspork/orgs","repos_url":"https://api.github.com/users/doomspork/repos","events_url":"https://api.github.com/users/doomspork/events{/privacy}","received_events_url":"https://api.github.com/users/doomspork/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-16T18:50:01Z","updated_at":"2019-05-16T19:27:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"572850bb7294d8d2f6b9709c4f72f2176d17253a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mmaiza","id":823430,"node_id":"MDQ6VXNlcjgyMzQzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/823430?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaiza","html_url":"https://github.com/mmaiza","followers_url":"https://api.github.com/users/mmaiza/followers","following_url":"https://api.github.com/users/mmaiza/following{/other_user}","gists_url":"https://api.github.com/users/mmaiza/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaiza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaiza/subscriptions","organizations_url":"https://api.github.com/users/mmaiza/orgs","repos_url":"https://api.github.com/users/mmaiza/repos","events_url":"https://api.github.com/users/mmaiza/events{/privacy}","received_events_url":"https://api.github.com/users/mmaiza/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rentpath/avro_ex/pulls/2/commits","review_comments_url":"https://api.github.com/repos/rentpath/avro_ex/pulls/2/comments","review_comment_url":"https://api.github.com/repos/rentpath/avro_ex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rentpath/avro_ex/issues/2/comments","statuses_url":"https://api.github.com/repos/rentpath/avro_ex/statuses/2fa2fdeaeea8abd99164011955cc0c72bd847583","head":{"label":"rentpath:fix/add-array-terminating-byte","ref":"fix/add-array-terminating-byte","sha":"2fa2fdeaeea8abd99164011955cc0c72bd847583","user":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"repo":{"id":178256761,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyNTY3NjE=","name":"avro_ex","full_name":"rentpath/avro_ex","private":false,"owner":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rentpath/avro_ex","description":"An Avro Library that emphasizes testability and ease of use.","fork":true,"url":"https://api.github.com/repos/rentpath/avro_ex","forks_url":"https://api.github.com/repos/rentpath/avro_ex/forks","keys_url":"https://api.github.com/repos/rentpath/avro_ex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rentpath/avro_ex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rentpath/avro_ex/teams","hooks_url":"https://api.github.com/repos/rentpath/avro_ex/hooks","issue_events_url":"https://api.github.com/repos/rentpath/avro_ex/issues/events{/number}","events_url":"https://api.github.com/repos/rentpath/avro_ex/events","assignees_url":"https://api.github.com/repos/rentpath/avro_ex/assignees{/user}","branches_url":"https://api.github.com/repos/rentpath/avro_ex/branches{/branch}","tags_url":"https://api.github.com/repos/rentpath/avro_ex/tags","blobs_url":"https://api.github.com/repos/rentpath/avro_ex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rentpath/avro_ex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rentpath/avro_ex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rentpath/avro_ex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rentpath/avro_ex/statuses/{sha}","languages_url":"https://api.github.com/repos/rentpath/avro_ex/languages","stargazers_url":"https://api.github.com/repos/rentpath/avro_ex/stargazers","contributors_url":"https://api.github.com/repos/rentpath/avro_ex/contributors","subscribers_url":"https://api.github.com/repos/rentpath/avro_ex/subscribers","subscription_url":"https://api.github.com/repos/rentpath/avro_ex/subscription","commits_url":"https://api.github.com/repos/rentpath/avro_ex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rentpath/avro_ex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rentpath/avro_ex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rentpath/avro_ex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rentpath/avro_ex/contents/{+path}","compare_url":"https://api.github.com/repos/rentpath/avro_ex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rentpath/avro_ex/merges","archive_url":"https://api.github.com/repos/rentpath/avro_ex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rentpath/avro_ex/downloads","issues_url":"https://api.github.com/repos/rentpath/avro_ex/issues{/number}","pulls_url":"https://api.github.com/repos/rentpath/avro_ex/pulls{/number}","milestones_url":"https://api.github.com/repos/rentpath/avro_ex/milestones{/number}","notifications_url":"https://api.github.com/repos/rentpath/avro_ex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rentpath/avro_ex/labels{/name}","releases_url":"https://api.github.com/repos/rentpath/avro_ex/releases{/id}","deployments_url":"https://api.github.com/repos/rentpath/avro_ex/deployments","created_at":"2019-03-28T17:59:53Z","updated_at":"2019-04-09T19:00:39Z","pushed_at":"2019-05-16T19:05:56Z","git_url":"git://github.com/rentpath/avro_ex.git","ssh_url":"git@github.com:rentpath/avro_ex.git","clone_url":"https://github.com/rentpath/avro_ex.git","svn_url":"https://github.com/rentpath/avro_ex","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"rentpath:master","ref":"master","sha":"d1aae412804f308df5dff7e719a6a80d2dc24fe5","user":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"repo":{"id":178256761,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgyNTY3NjE=","name":"avro_ex","full_name":"rentpath/avro_ex","private":false,"owner":{"login":"rentpath","id":37622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjIy","avatar_url":"https://avatars3.githubusercontent.com/u/37622?v=4","gravatar_id":"","url":"https://api.github.com/users/rentpath","html_url":"https://github.com/rentpath","followers_url":"https://api.github.com/users/rentpath/followers","following_url":"https://api.github.com/users/rentpath/following{/other_user}","gists_url":"https://api.github.com/users/rentpath/gists{/gist_id}","starred_url":"https://api.github.com/users/rentpath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rentpath/subscriptions","organizations_url":"https://api.github.com/users/rentpath/orgs","repos_url":"https://api.github.com/users/rentpath/repos","events_url":"https://api.github.com/users/rentpath/events{/privacy}","received_events_url":"https://api.github.com/users/rentpath/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rentpath/avro_ex","description":"An Avro Library that emphasizes testability and ease of use.","fork":true,"url":"https://api.github.com/repos/rentpath/avro_ex","forks_url":"https://api.github.com/repos/rentpath/avro_ex/forks","keys_url":"https://api.github.com/repos/rentpath/avro_ex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rentpath/avro_ex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rentpath/avro_ex/teams","hooks_url":"https://api.github.com/repos/rentpath/avro_ex/hooks","issue_events_url":"https://api.github.com/repos/rentpath/avro_ex/issues/events{/number}","events_url":"https://api.github.com/repos/rentpath/avro_ex/events","assignees_url":"https://api.github.com/repos/rentpath/avro_ex/assignees{/user}","branches_url":"https://api.github.com/repos/rentpath/avro_ex/branches{/branch}","tags_url":"https://api.github.com/repos/rentpath/avro_ex/tags","blobs_url":"https://api.github.com/repos/rentpath/avro_ex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rentpath/avro_ex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rentpath/avro_ex/git/refs{/sha}","trees_url":"https://api.github.com/repos/rentpath/avro_ex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rentpath/avro_ex/statuses/{sha}","languages_url":"https://api.github.com/repos/rentpath/avro_ex/languages","stargazers_url":"https://api.github.com/repos/rentpath/avro_ex/stargazers","contributors_url":"https://api.github.com/repos/rentpath/avro_ex/contributors","subscribers_url":"https://api.github.com/repos/rentpath/avro_ex/subscribers","subscription_url":"https://api.github.com/repos/rentpath/avro_ex/subscription","commits_url":"https://api.github.com/repos/rentpath/avro_ex/commits{/sha}","git_commits_url":"https://api.github.com/repos/rentpath/avro_ex/git/commits{/sha}","comments_url":"https://api.github.com/repos/rentpath/avro_ex/comments{/number}","issue_comment_url":"https://api.github.com/repos/rentpath/avro_ex/issues/comments{/number}","contents_url":"https://api.github.com/repos/rentpath/avro_ex/contents/{+path}","compare_url":"https://api.github.com/repos/rentpath/avro_ex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rentpath/avro_ex/merges","archive_url":"https://api.github.com/repos/rentpath/avro_ex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rentpath/avro_ex/downloads","issues_url":"https://api.github.com/repos/rentpath/avro_ex/issues{/number}","pulls_url":"https://api.github.com/repos/rentpath/avro_ex/pulls{/number}","milestones_url":"https://api.github.com/repos/rentpath/avro_ex/milestones{/number}","notifications_url":"https://api.github.com/repos/rentpath/avro_ex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rentpath/avro_ex/labels{/name}","releases_url":"https://api.github.com/repos/rentpath/avro_ex/releases{/id}","deployments_url":"https://api.github.com/repos/rentpath/avro_ex/deployments","created_at":"2019-03-28T17:59:53Z","updated_at":"2019-04-09T19:00:39Z","pushed_at":"2019-05-16T19:05:56Z","git_url":"git://github.com/rentpath/avro_ex.git","ssh_url":"git@github.com:rentpath/avro_ex.git","clone_url":"https://github.com/rentpath/avro_ex.git","svn_url":"https://github.com/rentpath/avro_ex","homepage":null,"size":68,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/2"},"html":{"href":"https://github.com/rentpath/avro_ex/pull/2"},"issue":{"href":"https://api.github.com/repos/rentpath/avro_ex/issues/2"},"comments":{"href":"https://api.github.com/repos/rentpath/avro_ex/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rentpath/avro_ex/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/rentpath/avro_ex/statuses/2fa2fdeaeea8abd99164011955cc0c72bd847583"}},"author_association":"MEMBER"}}
|
{
"id": 178256761,
"name": "rentpath/avro_ex",
"url": "https://api.github.com/repos/rentpath/avro_ex"
}
|
{
"id": 636342,
"login": "michaelstalker",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/636342?",
"url": "https://api.github.com/users/michaelstalker"
}
|
{
"id": 37622,
"login": "rentpath",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37622?",
"url": "https://api.github.com/orgs/rentpath"
}
| 2019-05-16T19:18:32 |
9642028914
|
{"actor":{"display_login":"michaelstalker"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/comments/263117081","pull_request_review_id":211451611,"id":263117081,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzExNzA4MQ==","diff_hunk":"@@ -397,3 +397,31 @@ resource \"aws_route53_record\" \"master\" {\n records = [\"${aws_eip.master.public_ip}\"]\n ttl = 300\n }\n+\n+## This null resource depends on the aws master instance\n+resource \"null_resource\" \"copy_kubeconfig\" {\n+ depends_on = [\"aws_instance.master\"]\n+\n+## This remote exec waits for the file to exist on the remote because it takes the instance\n+## a while to do all the things\n+ provisioner \"remote-exec\" {\n+ inline = [\"while [ ! -f /home/centos/kubeconfig ]; do sleep 2; done\"]\n+\n+ connection {\n+ host = \"${aws_eip.master.public_ip}\"\n+ type = \"ssh\"\n+ user = \"centos\"\n+ #this works by using your local ssh agent to pull in the PK\n+ agent = true\n+ }\n+ }\n+\n+## this actually gets the file - the private key needs to be in your ssh-agent\n+ provisioner \"local-exec\" {\n+ command = <<EOT","path":"main.tf","position":25,"original_position":25,"commit_id":"0808c98dacec308cc91513db023d20a1ea4d16bc","original_commit_id":"0808c98dacec308cc91513db023d20a1ea4d16bc","user":{"login":"vaxinate","id":85638,"node_id":"MDQ6VXNlcjg1NjM4","avatar_url":"https://avatars3.githubusercontent.com/u/85638?v=4","gravatar_id":"","url":"https://api.github.com/users/vaxinate","html_url":"https://github.com/vaxinate","followers_url":"https://api.github.com/users/vaxinate/followers","following_url":"https://api.github.com/users/vaxinate/following{/other_user}","gists_url":"https://api.github.com/users/vaxinate/gists{/gist_id}","starred_url":"https://api.github.com/users/vaxinate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaxinate/subscriptions","organizations_url":"https://api.github.com/users/vaxinate/orgs","repos_url":"https://api.github.com/users/vaxinate/repos","events_url":"https://api.github.com/users/vaxinate/events{/privacy}","received_events_url":"https://api.github.com/users/vaxinate/received_events","type":"User","site_admin":false},"body":"could we eliminate the need for the whole remote-exec provisioner if we just made this `ssh` call here before the `scp` call? \r\n```\r\nssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null \\\r\n centos@${aws_eip.master.public_ip}:/home/centos/kubeconfig \\\r\n 'cloud-init status --wait'\r\n```\r\n\r\nAssuming the `cloud-init status --wait` command does what I think it does, this should ssh into the instance, run the status command, then exit as soon as the status command does.","created_at":"2019-03-06T20:17:26Z","updated_at":"2019-03-06T20:17:26Z","html_url":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1#discussion_r263117081","pull_request_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/comments/263117081"},"html":{"href":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1#discussion_r263117081"},"pull_request":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1","id":258861669,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU4ODYxNjY5","html_url":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1","diff_url":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1.diff","patch_url":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1.patch","issue_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/1","number":1,"state":"open","locked":false,"title":"Get kubeconfig from the master node","user":{"login":"bit-herder","id":1189465,"node_id":"MDQ6VXNlcjExODk0NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/1189465?v=4","gravatar_id":"","url":"https://api.github.com/users/bit-herder","html_url":"https://github.com/bit-herder","followers_url":"https://api.github.com/users/bit-herder/followers","following_url":"https://api.github.com/users/bit-herder/following{/other_user}","gists_url":"https://api.github.com/users/bit-herder/gists{/gist_id}","starred_url":"https://api.github.com/users/bit-herder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bit-herder/subscriptions","organizations_url":"https://api.github.com/users/bit-herder/orgs","repos_url":"https://api.github.com/users/bit-herder/repos","events_url":"https://api.github.com/users/bit-herder/events{/privacy}","received_events_url":"https://api.github.com/users/bit-herder/received_events","type":"User","site_admin":false},"body":"this gets the kubeconfig from the master node. ","created_at":"2019-03-06T20:06:36Z","updated_at":"2019-03-06T20:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3f5fdde6a6dfffe3da86f84c94f924a0c73504c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1/commits","review_comments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1/comments","review_comment_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/1/comments","statuses_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/statuses/0808c98dacec308cc91513db023d20a1ea4d16bc","head":{"label":"revelrylabs:get-kubeconfig","ref":"get-kubeconfig","sha":"0808c98dacec308cc91513db023d20a1ea4d16bc","user":{"login":"revelrylabs","id":43271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/43271?v=4","gravatar_id":"","url":"https://api.github.com/users/revelrylabs","html_url":"https://github.com/revelrylabs","followers_url":"https://api.github.com/users/revelrylabs/followers","following_url":"https://api.github.com/users/revelrylabs/following{/other_user}","gists_url":"https://api.github.com/users/revelrylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/revelrylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revelrylabs/subscriptions","organizations_url":"https://api.github.com/users/revelrylabs/orgs","repos_url":"https://api.github.com/users/revelrylabs/repos","events_url":"https://api.github.com/users/revelrylabs/events{/privacy}","received_events_url":"https://api.github.com/users/revelrylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":169472624,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0NzI2MjQ=","name":"terraform-aws-kubernetes","full_name":"revelrylabs/terraform-aws-kubernetes","private":false,"owner":{"login":"revelrylabs","id":43271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/43271?v=4","gravatar_id":"","url":"https://api.github.com/users/revelrylabs","html_url":"https://github.com/revelrylabs","followers_url":"https://api.github.com/users/revelrylabs/followers","following_url":"https://api.github.com/users/revelrylabs/following{/other_user}","gists_url":"https://api.github.com/users/revelrylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/revelrylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revelrylabs/subscriptions","organizations_url":"https://api.github.com/users/revelrylabs/orgs","repos_url":"https://api.github.com/users/revelrylabs/repos","events_url":"https://api.github.com/users/revelrylabs/events{/privacy}","received_events_url":"https://api.github.com/users/revelrylabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/revelrylabs/terraform-aws-kubernetes","description":"Terraform module for Kubernetes setup on AWS","fork":true,"url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes","forks_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/forks","keys_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/teams","hooks_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/events","assignees_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/tags","blobs_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/languages","stargazers_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/subscription","commits_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/merges","archive_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/downloads","issues_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/deployments","created_at":"2019-02-06T20:34:16Z","updated_at":"2019-02-07T17:52:00Z","pushed_at":"2019-03-06T20:06:37Z","git_url":"git://github.com/revelrylabs/terraform-aws-kubernetes.git","ssh_url":"git@github.com:revelrylabs/terraform-aws-kubernetes.git","clone_url":"https://github.com/revelrylabs/terraform-aws-kubernetes.git","svn_url":"https://github.com/revelrylabs/terraform-aws-kubernetes","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"revelrylabs:master","ref":"master","sha":"0e2ba8094b15009756f0ad3e4409629a62a51d63","user":{"login":"revelrylabs","id":43271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/43271?v=4","gravatar_id":"","url":"https://api.github.com/users/revelrylabs","html_url":"https://github.com/revelrylabs","followers_url":"https://api.github.com/users/revelrylabs/followers","following_url":"https://api.github.com/users/revelrylabs/following{/other_user}","gists_url":"https://api.github.com/users/revelrylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/revelrylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revelrylabs/subscriptions","organizations_url":"https://api.github.com/users/revelrylabs/orgs","repos_url":"https://api.github.com/users/revelrylabs/repos","events_url":"https://api.github.com/users/revelrylabs/events{/privacy}","received_events_url":"https://api.github.com/users/revelrylabs/received_events","type":"Organization","site_admin":false},"repo":{"id":169472624,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0NzI2MjQ=","name":"terraform-aws-kubernetes","full_name":"revelrylabs/terraform-aws-kubernetes","private":false,"owner":{"login":"revelrylabs","id":43271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/43271?v=4","gravatar_id":"","url":"https://api.github.com/users/revelrylabs","html_url":"https://github.com/revelrylabs","followers_url":"https://api.github.com/users/revelrylabs/followers","following_url":"https://api.github.com/users/revelrylabs/following{/other_user}","gists_url":"https://api.github.com/users/revelrylabs/gists{/gist_id}","starred_url":"https://api.github.com/users/revelrylabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revelrylabs/subscriptions","organizations_url":"https://api.github.com/users/revelrylabs/orgs","repos_url":"https://api.github.com/users/revelrylabs/repos","events_url":"https://api.github.com/users/revelrylabs/events{/privacy}","received_events_url":"https://api.github.com/users/revelrylabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/revelrylabs/terraform-aws-kubernetes","description":"Terraform module for Kubernetes setup on AWS","fork":true,"url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes","forks_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/forks","keys_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/teams","hooks_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/events","assignees_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/tags","blobs_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/languages","stargazers_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/subscription","commits_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/merges","archive_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/downloads","issues_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/deployments","created_at":"2019-02-06T20:34:16Z","updated_at":"2019-02-07T17:52:00Z","pushed_at":"2019-03-06T20:06:37Z","git_url":"git://github.com/revelrylabs/terraform-aws-kubernetes.git","ssh_url":"git@github.com:revelrylabs/terraform-aws-kubernetes.git","clone_url":"https://github.com/revelrylabs/terraform-aws-kubernetes.git","svn_url":"https://github.com/revelrylabs/terraform-aws-kubernetes","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1"},"html":{"href":"https://github.com/revelrylabs/terraform-aws-kubernetes/pull/1"},"issue":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/1"},"comments":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes/statuses/0808c98dacec308cc91513db023d20a1ea4d16bc"}},"author_association":"COLLABORATOR"}}
|
{
"id": 169472624,
"name": "revelrylabs/terraform-aws-kubernetes",
"url": "https://api.github.com/repos/revelrylabs/terraform-aws-kubernetes"
}
|
{
"id": 85638,
"login": "vaxinate",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/85638?",
"url": "https://api.github.com/users/vaxinate"
}
|
{
"id": 43271,
"login": "revelrylabs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43271?",
"url": "https://api.github.com/orgs/revelrylabs"
}
| 2019-03-06T20:17:26 |
9193652768
|
{"actor":{"display_login":"vaxinate"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mongodb/specifications/pulls/comments/253706558","pull_request_review_id":199881791,"id":253706558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzcwNjU1OA==","diff_hunk":"@@ -54,34 +42,56 @@ Each YAML file has the following keys:\n \n - ``description``: The name of the test.\n \n- - ``operation``: Document describing the operation to be executed. This will\n- have the following fields:\n+ - ``skipReason`` (optional): If present, the test should be skipped and the\n+ string value will specify a reason.\n \n- - ``name``: The name of the operation as defined in the specification. The\n- name `db-aggregate` refers to database-level aggregation.\n+ - ``failPoint`` (optional): The ``configureFailPoint`` command document to run\n+ to configure a fail point on the primary server.\n \n- - ``object``: The name of the object to perform the operation on. Can be\n+ - ``clientOptions`` (optional): Names and values of options used to construct\n+ the MongoClient for this test.\n+\n+ - ``operations``: Array of documents, each describing an operation to be\n+ executed. Each document has the following fields:\n+\n+ - ``object`` (optional): The name of the object to perform the operation on. Can be\n \"database\" or \"collection\". Defaults to \"collection\" if undefined.\n \n- - ``arguments``: The names and values of arguments from the specification.\n+ - ``collectionOptions`` (optional): Names and values of options used to\n+ construct the collection object for this test.\n \n- - ``outcome``: Document describing the return value and/or expected state of\n- the collection after the operation is executed. This will have some or all\n- of the following fields:\n+ - ``name``: The name of the operation as defined in the specification.\n \n- - ``error``: If ``true``, the test should expect an error or exception. Note\n- that some drivers may report server-side errors as a write error within a\n- write result object.\n+ - ``arguments``: The names and values of arguments from the specification.\n+\n+ - ``error`` (optional): If ``true``, the test should expect the operation\n+ to emit an error or exception. If ``false`` or omitted, drivers MUST\n+ assert that no error occurred.\n \n- - ``result``: The return value from the operation. This will correspond to\n- an operation's result object as defined in the CRUD specification. This\n- field may be omitted if ``error`` is ``true``. If this field is present\n- and ``error`` is ``true`` (generally for multi-statement tests), the\n- result reports information about operations that succeeded before an\n+ - ``result`` (optional): The result of executing the operation. This will","path":"source/crud/tests/README.rst","position":85,"original_position":85,"commit_id":"517d8510340fc225b4e61a790e098869aef528a8","original_commit_id":"517d8510340fc225b4e61a790e098869aef528a8","user":{"login":"ShaneHarvey","id":5015933,"node_id":"MDQ6VXNlcjUwMTU5MzM=","avatar_url":"https://avatars3.githubusercontent.com/u/5015933?v=4","gravatar_id":"","url":"https://api.github.com/users/ShaneHarvey","html_url":"https://github.com/ShaneHarvey","followers_url":"https://api.github.com/users/ShaneHarvey/followers","following_url":"https://api.github.com/users/ShaneHarvey/following{/other_user}","gists_url":"https://api.github.com/users/ShaneHarvey/gists{/gist_id}","starred_url":"https://api.github.com/users/ShaneHarvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShaneHarvey/subscriptions","organizations_url":"https://api.github.com/users/ShaneHarvey/orgs","repos_url":"https://api.github.com/users/ShaneHarvey/repos","events_url":"https://api.github.com/users/ShaneHarvey/events{/privacy}","received_events_url":"https://api.github.com/users/ShaneHarvey/received_events","type":"User","site_admin":false},"body":"Each item in the \"operations\" list is its own \"operation\" which contains its own \"result\" field. For example: https://github.com/mongodb/specifications/blob/master/source/transactions/tests/delete.yml#L17-L32","created_at":"2019-02-05T01:03:50Z","updated_at":"2019-02-05T01:03:50Z","html_url":"https://github.com/mongodb/specifications/pull/453#discussion_r253706558","pull_request_url":"https://api.github.com/repos/mongodb/specifications/pulls/453","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/comments/253706558"},"html":{"href":"https://github.com/mongodb/specifications/pull/453#discussion_r253706558"},"pull_request":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/453"}},"in_reply_to_id":253704395},"pull_request":{"url":"https://api.github.com/repos/mongodb/specifications/pulls/453","id":248324142,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ4MzI0MTQy","html_url":"https://github.com/mongodb/specifications/pull/453","diff_url":"https://github.com/mongodb/specifications/pull/453.diff","patch_url":"https://github.com/mongodb/specifications/pull/453.patch","issue_url":"https://api.github.com/repos/mongodb/specifications/issues/453","number":453,"state":"open","locked":false,"title":"SPEC-1210: Document multi-operation CRUD test format with APM","user":{"login":"jmikola","id":244663,"node_id":"MDQ6VXNlcjI0NDY2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/244663?v=4","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"body":"https://jira.mongodb.org/browse/SPEC-1210","created_at":"2019-01-28T23:30:18Z","updated_at":"2019-02-05T01:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f68de9ddfdcf8155f410e44cb35c1a47f308b78","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mbroadst","id":312966,"node_id":"MDQ6VXNlcjMxMjk2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/312966?v=4","gravatar_id":"","url":"https://api.github.com/users/mbroadst","html_url":"https://github.com/mbroadst","followers_url":"https://api.github.com/users/mbroadst/followers","following_url":"https://api.github.com/users/mbroadst/following{/other_user}","gists_url":"https://api.github.com/users/mbroadst/gists{/gist_id}","starred_url":"https://api.github.com/users/mbroadst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbroadst/subscriptions","organizations_url":"https://api.github.com/users/mbroadst/orgs","repos_url":"https://api.github.com/users/mbroadst/repos","events_url":"https://api.github.com/users/mbroadst/events{/privacy}","received_events_url":"https://api.github.com/users/mbroadst/received_events","type":"User","site_admin":false},{"login":"xdg","id":7625322,"node_id":"MDQ6VXNlcjc2MjUzMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7625322?v=4","gravatar_id":"","url":"https://api.github.com/users/xdg","html_url":"https://github.com/xdg","followers_url":"https://api.github.com/users/xdg/followers","following_url":"https://api.github.com/users/xdg/following{/other_user}","gists_url":"https://api.github.com/users/xdg/gists{/gist_id}","starred_url":"https://api.github.com/users/xdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdg/subscriptions","organizations_url":"https://api.github.com/users/xdg/orgs","repos_url":"https://api.github.com/users/xdg/repos","events_url":"https://api.github.com/users/xdg/events{/privacy}","received_events_url":"https://api.github.com/users/xdg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mongodb/specifications/pulls/453/commits","review_comments_url":"https://api.github.com/repos/mongodb/specifications/pulls/453/comments","review_comment_url":"https://api.github.com/repos/mongodb/specifications/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mongodb/specifications/issues/453/comments","statuses_url":"https://api.github.com/repos/mongodb/specifications/statuses/517d8510340fc225b4e61a790e098869aef528a8","head":{"label":"jmikola:spec-1133","ref":"spec-1133","sha":"517d8510340fc225b4e61a790e098869aef528a8","user":{"login":"jmikola","id":244663,"node_id":"MDQ6VXNlcjI0NDY2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/244663?v=4","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"repo":{"id":94802993,"node_id":"MDEwOlJlcG9zaXRvcnk5NDgwMjk5Mw==","name":"specifications","full_name":"jmikola/specifications","private":false,"owner":{"login":"jmikola","id":244663,"node_id":"MDQ6VXNlcjI0NDY2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/244663?v=4","gravatar_id":"","url":"https://api.github.com/users/jmikola","html_url":"https://github.com/jmikola","followers_url":"https://api.github.com/users/jmikola/followers","following_url":"https://api.github.com/users/jmikola/following{/other_user}","gists_url":"https://api.github.com/users/jmikola/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikola/subscriptions","organizations_url":"https://api.github.com/users/jmikola/orgs","repos_url":"https://api.github.com/users/jmikola/repos","events_url":"https://api.github.com/users/jmikola/events{/privacy}","received_events_url":"https://api.github.com/users/jmikola/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmikola/specifications","description":"Specifications related to MongoDB","fork":true,"url":"https://api.github.com/repos/jmikola/specifications","forks_url":"https://api.github.com/repos/jmikola/specifications/forks","keys_url":"https://api.github.com/repos/jmikola/specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmikola/specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmikola/specifications/teams","hooks_url":"https://api.github.com/repos/jmikola/specifications/hooks","issue_events_url":"https://api.github.com/repos/jmikola/specifications/issues/events{/number}","events_url":"https://api.github.com/repos/jmikola/specifications/events","assignees_url":"https://api.github.com/repos/jmikola/specifications/assignees{/user}","branches_url":"https://api.github.com/repos/jmikola/specifications/branches{/branch}","tags_url":"https://api.github.com/repos/jmikola/specifications/tags","blobs_url":"https://api.github.com/repos/jmikola/specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmikola/specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmikola/specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmikola/specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmikola/specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/jmikola/specifications/languages","stargazers_url":"https://api.github.com/repos/jmikola/specifications/stargazers","contributors_url":"https://api.github.com/repos/jmikola/specifications/contributors","subscribers_url":"https://api.github.com/repos/jmikola/specifications/subscribers","subscription_url":"https://api.github.com/repos/jmikola/specifications/subscription","commits_url":"https://api.github.com/repos/jmikola/specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmikola/specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmikola/specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmikola/specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmikola/specifications/contents/{+path}","compare_url":"https://api.github.com/repos/jmikola/specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmikola/specifications/merges","archive_url":"https://api.github.com/repos/jmikola/specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmikola/specifications/downloads","issues_url":"https://api.github.com/repos/jmikola/specifications/issues{/number}","pulls_url":"https://api.github.com/repos/jmikola/specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/jmikola/specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/jmikola/specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmikola/specifications/labels{/name}","releases_url":"https://api.github.com/repos/jmikola/specifications/releases{/id}","deployments_url":"https://api.github.com/repos/jmikola/specifications/deployments","created_at":"2017-06-19T17:29:43Z","updated_at":"2019-02-04T17:10:34Z","pushed_at":"2019-02-04T19:05:12Z","git_url":"git://github.com/jmikola/specifications.git","ssh_url":"git@github.com:jmikola/specifications.git","clone_url":"https://github.com/jmikola/specifications.git","svn_url":"https://github.com/jmikola/specifications","homepage":null,"size":4136,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mongodb:master","ref":"master","sha":"31c7157cd6207e1f5010100427778264b76a5079","user":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"repo":{"id":19244865,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI0NDg2NQ==","name":"specifications","full_name":"mongodb/specifications","private":false,"owner":{"login":"mongodb","id":45120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/45120?v=4","gravatar_id":"","url":"https://api.github.com/users/mongodb","html_url":"https://github.com/mongodb","followers_url":"https://api.github.com/users/mongodb/followers","following_url":"https://api.github.com/users/mongodb/following{/other_user}","gists_url":"https://api.github.com/users/mongodb/gists{/gist_id}","starred_url":"https://api.github.com/users/mongodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mongodb/subscriptions","organizations_url":"https://api.github.com/users/mongodb/orgs","repos_url":"https://api.github.com/users/mongodb/repos","events_url":"https://api.github.com/users/mongodb/events{/privacy}","received_events_url":"https://api.github.com/users/mongodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mongodb/specifications","description":"Specifications related to MongoDB","fork":false,"url":"https://api.github.com/repos/mongodb/specifications","forks_url":"https://api.github.com/repos/mongodb/specifications/forks","keys_url":"https://api.github.com/repos/mongodb/specifications/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mongodb/specifications/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mongodb/specifications/teams","hooks_url":"https://api.github.com/repos/mongodb/specifications/hooks","issue_events_url":"https://api.github.com/repos/mongodb/specifications/issues/events{/number}","events_url":"https://api.github.com/repos/mongodb/specifications/events","assignees_url":"https://api.github.com/repos/mongodb/specifications/assignees{/user}","branches_url":"https://api.github.com/repos/mongodb/specifications/branches{/branch}","tags_url":"https://api.github.com/repos/mongodb/specifications/tags","blobs_url":"https://api.github.com/repos/mongodb/specifications/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mongodb/specifications/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mongodb/specifications/git/refs{/sha}","trees_url":"https://api.github.com/repos/mongodb/specifications/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mongodb/specifications/statuses/{sha}","languages_url":"https://api.github.com/repos/mongodb/specifications/languages","stargazers_url":"https://api.github.com/repos/mongodb/specifications/stargazers","contributors_url":"https://api.github.com/repos/mongodb/specifications/contributors","subscribers_url":"https://api.github.com/repos/mongodb/specifications/subscribers","subscription_url":"https://api.github.com/repos/mongodb/specifications/subscription","commits_url":"https://api.github.com/repos/mongodb/specifications/commits{/sha}","git_commits_url":"https://api.github.com/repos/mongodb/specifications/git/commits{/sha}","comments_url":"https://api.github.com/repos/mongodb/specifications/comments{/number}","issue_comment_url":"https://api.github.com/repos/mongodb/specifications/issues/comments{/number}","contents_url":"https://api.github.com/repos/mongodb/specifications/contents/{+path}","compare_url":"https://api.github.com/repos/mongodb/specifications/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mongodb/specifications/merges","archive_url":"https://api.github.com/repos/mongodb/specifications/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mongodb/specifications/downloads","issues_url":"https://api.github.com/repos/mongodb/specifications/issues{/number}","pulls_url":"https://api.github.com/repos/mongodb/specifications/pulls{/number}","milestones_url":"https://api.github.com/repos/mongodb/specifications/milestones{/number}","notifications_url":"https://api.github.com/repos/mongodb/specifications/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mongodb/specifications/labels{/name}","releases_url":"https://api.github.com/repos/mongodb/specifications/releases{/id}","deployments_url":"https://api.github.com/repos/mongodb/specifications/deployments","created_at":"2014-04-28T16:04:56Z","updated_at":"2019-02-01T21:10:41Z","pushed_at":"2019-02-04T22:33:32Z","git_url":"git://github.com/mongodb/specifications.git","ssh_url":"git@github.com:mongodb/specifications.git","clone_url":"https://github.com/mongodb/specifications.git","svn_url":"https://github.com/mongodb/specifications","homepage":null,"size":4159,"stargazers_count":134,"watchers_count":134,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":11,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/453"},"html":{"href":"https://github.com/mongodb/specifications/pull/453"},"issue":{"href":"https://api.github.com/repos/mongodb/specifications/issues/453"},"comments":{"href":"https://api.github.com/repos/mongodb/specifications/issues/453/comments"},"review_comments":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/453/comments"},"review_comment":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mongodb/specifications/pulls/453/commits"},"statuses":{"href":"https://api.github.com/repos/mongodb/specifications/statuses/517d8510340fc225b4e61a790e098869aef528a8"}},"author_association":"MEMBER"}}
|
{
"id": 19244865,
"name": "mongodb/specifications",
"url": "https://api.github.com/repos/mongodb/specifications"
}
|
{
"id": 5015933,
"login": "ShaneHarvey",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5015933?",
"url": "https://api.github.com/users/ShaneHarvey"
}
|
{
"id": 45120,
"login": "mongodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/45120?",
"url": "https://api.github.com/orgs/mongodb"
}
| 2019-02-05T01:03:50 |
9007911362
|
{"actor":{"display_login":"ShaneHarvey"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/airflow/pulls/comments/358641668","pull_request_review_id":333081787,"id":358641668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODY0MTY2OA==","diff_hunk":"@@ -123,11 +129,43 @@ def _run_image(self):\n \n self.log.info('Service started: %s', str(self.service))\n \n- status = None\n # wait for the service to start the task\n while not self.cli.tasks(filters={'service': self.service['ID']}):\n continue\n- while True:\n+\n+ logs = self.cli.service_logs(\n+ self.service['ID'], follow=True, stdout=True, stderr=True, is_tty=self.tty\n+ )\n+ line = ''\n+ _stream_logs = self.enable_logging # Status of the service_logs' generator\n+ while True: # pylint: disable=too-many-nested-blocks\n+ if self.enable_logging:","path":"airflow/contrib/operators/docker_swarm_operator.py","position":48,"original_position":48,"commit_id":"ee4daac85028a8b15526146f847d42b6c4795d8b","original_commit_id":"ee4daac85028a8b15526146f847d42b6c4795d8b","user":{"login":"akki","id":4801628,"node_id":"MDQ6VXNlcjQ4MDE2Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4801628?v=4","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"body":"I had tried that earlier but this whole block makes sense only if put together. The `while True` has 2 responsibilities - log things and check if the service still running - but I don't see any straightforward way to decouple them.\r\nAlso, this block waits for the service to stop which doesn't make sens without the part where the service is started.\r\n\r\nDo you have any particular ideas in mind?","created_at":"2019-12-17T07:49:53Z","updated_at":"2019-12-17T07:49:53Z","html_url":"https://github.com/apache/airflow/pull/6552#discussion_r358641668","pull_request_url":"https://api.github.com/repos/apache/airflow/pulls/6552","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/airflow/pulls/comments/358641668"},"html":{"href":"https://github.com/apache/airflow/pull/6552#discussion_r358641668"},"pull_request":{"href":"https://api.github.com/repos/apache/airflow/pulls/6552"}},"in_reply_to_id":358596484},"pull_request":{"url":"https://api.github.com/repos/apache/airflow/pulls/6552","id":339689297,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5Njg5Mjk3","html_url":"https://github.com/apache/airflow/pull/6552","diff_url":"https://github.com/apache/airflow/pull/6552.diff","patch_url":"https://github.com/apache/airflow/pull/6552.patch","issue_url":"https://api.github.com/repos/apache/airflow/issues/6552","number":6552,"state":"open","locked":false,"title":"AIRFLOW-5850: Capture task logs in DockerSwarmOperator","user":{"login":"akki","id":4801628,"node_id":"MDQ6VXNlcjQ4MDE2Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4801628?v=4","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n - https://issues.apache.org/jira/browse/AIRFLOW-5850\r\n - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).\r\n - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit test:\r\n `test_logging`\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n 1. Subject is separated from body by a blank line\r\n 1. Subject is limited to 50 characters (not including Jira issue reference)\r\n 1. Subject does not end with a period\r\n 1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n 1. Body wraps at 72 characters\r\n 1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n - All the public functions and the classes in the PR contain docstrings that explain what it does\r\n - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release\r\n","created_at":"2019-11-12T01:48:04Z","updated_at":"2019-12-17T07:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085d2b873a0ff6acbd7db18d753df54304ce2a71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/airflow/pulls/6552/commits","review_comments_url":"https://api.github.com/repos/apache/airflow/pulls/6552/comments","review_comment_url":"https://api.github.com/repos/apache/airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/airflow/issues/6552/comments","statuses_url":"https://api.github.com/repos/apache/airflow/statuses/ee4daac85028a8b15526146f847d42b6c4795d8b","head":{"label":"akki:AIRFLOW-5850","ref":"AIRFLOW-5850","sha":"ee4daac85028a8b15526146f847d42b6c4795d8b","user":{"login":"akki","id":4801628,"node_id":"MDQ6VXNlcjQ4MDE2Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4801628?v=4","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"repo":{"id":191476179,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0NzYxNzk=","name":"airflow","full_name":"akki/airflow","private":false,"owner":{"login":"akki","id":4801628,"node_id":"MDQ6VXNlcjQ4MDE2Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/4801628?v=4","gravatar_id":"","url":"https://api.github.com/users/akki","html_url":"https://github.com/akki","followers_url":"https://api.github.com/users/akki/followers","following_url":"https://api.github.com/users/akki/following{/other_user}","gists_url":"https://api.github.com/users/akki/gists{/gist_id}","starred_url":"https://api.github.com/users/akki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akki/subscriptions","organizations_url":"https://api.github.com/users/akki/orgs","repos_url":"https://api.github.com/users/akki/repos","events_url":"https://api.github.com/users/akki/events{/privacy}","received_events_url":"https://api.github.com/users/akki/received_events","type":"User","site_admin":false},"html_url":"https://github.com/akki/airflow","description":"Apache Airflow","fork":true,"url":"https://api.github.com/repos/akki/airflow","forks_url":"https://api.github.com/repos/akki/airflow/forks","keys_url":"https://api.github.com/repos/akki/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akki/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akki/airflow/teams","hooks_url":"https://api.github.com/repos/akki/airflow/hooks","issue_events_url":"https://api.github.com/repos/akki/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/akki/airflow/events","assignees_url":"https://api.github.com/repos/akki/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/akki/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/akki/airflow/tags","blobs_url":"https://api.github.com/repos/akki/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akki/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akki/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/akki/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akki/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/akki/airflow/languages","stargazers_url":"https://api.github.com/repos/akki/airflow/stargazers","contributors_url":"https://api.github.com/repos/akki/airflow/contributors","subscribers_url":"https://api.github.com/repos/akki/airflow/subscribers","subscription_url":"https://api.github.com/repos/akki/airflow/subscription","commits_url":"https://api.github.com/repos/akki/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/akki/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/akki/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/akki/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/akki/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/akki/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akki/airflow/merges","archive_url":"https://api.github.com/repos/akki/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akki/airflow/downloads","issues_url":"https://api.github.com/repos/akki/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/akki/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/akki/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/akki/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akki/airflow/labels{/name}","releases_url":"https://api.github.com/repos/akki/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/akki/airflow/deployments","created_at":"2019-06-12T01:37:49Z","updated_at":"2019-06-12T01:37:55Z","pushed_at":"2019-11-20T15:40:06Z","git_url":"git://github.com/akki/airflow.git","ssh_url":"git@github.com:akki/airflow.git","clone_url":"https://github.com/akki/airflow.git","svn_url":"https://github.com/akki/airflow","homepage":"https://airflow.apache.org","size":46079,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9ed4895263f8683a576c3fb332598c5efb26284b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"airflow","full_name":"apache/airflow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/airflow","description":"Apache Airflow - A platform to programmatically author, schedule, and monitor workflows","fork":false,"url":"https://api.github.com/repos/apache/airflow","forks_url":"https://api.github.com/repos/apache/airflow/forks","keys_url":"https://api.github.com/repos/apache/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/airflow/teams","hooks_url":"https://api.github.com/repos/apache/airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/airflow/events","assignees_url":"https://api.github.com/repos/apache/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/airflow/tags","blobs_url":"https://api.github.com/repos/apache/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/airflow/languages","stargazers_url":"https://api.github.com/repos/apache/airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/airflow/subscription","commits_url":"https://api.github.com/repos/apache/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/airflow/merges","archive_url":"https://api.github.com/repos/apache/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/airflow/downloads","issues_url":"https://api.github.com/repos/apache/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2019-12-17T07:17:29Z","pushed_at":"2019-12-17T06:33:37Z","git_url":"git://github.com/apache/airflow.git","ssh_url":"git@github.com:apache/airflow.git","clone_url":"https://github.com/apache/airflow.git","svn_url":"https://github.com/apache/airflow","homepage":"https://airflow.apache.org/","size":50597,"stargazers_count":14967,"watchers_count":14967,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5661,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":286,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5661,"open_issues":286,"watchers":14967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/airflow/pulls/6552"},"html":{"href":"https://github.com/apache/airflow/pull/6552"},"issue":{"href":"https://api.github.com/repos/apache/airflow/issues/6552"},"comments":{"href":"https://api.github.com/repos/apache/airflow/issues/6552/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/airflow/pulls/6552/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/airflow/pulls/6552/commits"},"statuses":{"href":"https://api.github.com/repos/apache/airflow/statuses/ee4daac85028a8b15526146f847d42b6c4795d8b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 33884891,
"name": "apache/airflow",
"url": "https://api.github.com/repos/apache/airflow"
}
|
{
"id": 4801628,
"login": "akki",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4801628?",
"url": "https://api.github.com/users/akki"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-12-17T07:49:53 |
11104540482
|
{"actor":{"display_login":"akki"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/261667949","pull_request_review_id":209668214,"id":261667949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTY2Nzk0OQ==","diff_hunk":"@@ -187,6 +187,103 @@ table Interval {\n unit: IntervalUnit;\n }\n \n+\n+/// ----------------------------------------------------------------------\n+/// user defined key value pairs to add custom metadata to arrow\n+/// key namespacing is the responsibility of the user\n+\n+table KeyValue {\n+ key: string;\n+ value: string;\n+}\n+\n+/// ------------------------------------------------------------------------\n+/// Types used to represent a packed c-like structs. These are experimental\n+/// and maybe subject to change.\n+/// IMPORTANT: COMPATIBILITY MAY BE BROKEN IN FUTURE release.\n+/// They are not required to be implemented.\n+\n+/// Similar to a c-union, takes the byte-width\n+/// of its longest sub-type. To record type of union\n+/// use the \"tagged union\" pattern.\n+table PackedUnion {\n+}\n+\n+/// A binary string of a maximum size. Fields are layed out as\n+/// [length][UTF8 bytes]. The number of bytes used is maxSize +\n+/// lengthType.bitWidth/8.\n+table PackedBinary {\n+ /// Maximum number of bytes (not characters) used. This\n+ /// amount of bytes will always be used.\n+ maxSize: int;\n+\n+ /// If not set all binary data are of maxSize. If set use specified","path":"format/Schema.fbs","position":34,"original_position":34,"commit_id":"9ee218491bb1f897ef25aebcfba56bd7feb6d6ce","original_commit_id":"9ee218491bb1f897ef25aebcfba56bd7feb6d6ce","user":{"login":"emkornfield","id":17869838,"node_id":"MDQ6VXNlcjE3ODY5ODM4","avatar_url":"https://avatars1.githubusercontent.com/u/17869838?v=4","gravatar_id":"","url":"https://api.github.com/users/emkornfield","html_url":"https://github.com/emkornfield","followers_url":"https://api.github.com/users/emkornfield/followers","following_url":"https://api.github.com/users/emkornfield/following{/other_user}","gists_url":"https://api.github.com/users/emkornfield/gists{/gist_id}","starred_url":"https://api.github.com/users/emkornfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkornfield/subscriptions","organizations_url":"https://api.github.com/users/emkornfield/orgs","repos_url":"https://api.github.com/users/emkornfield/repos","events_url":"https://api.github.com/users/emkornfield/events{/privacy}","received_events_url":"https://api.github.com/users/emkornfield/received_events","type":"User","site_admin":false},"body":"Since this is a flabtbuffer Table type, I thought one option was for it to be nullable (i.e. not set). Is this not the case.","created_at":"2019-03-01T16:24:39Z","updated_at":"2019-03-01T16:24:39Z","html_url":"https://github.com/apache/arrow/pull/3785#discussion_r261667949","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/3785","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/261667949"},"html":{"href":"https://github.com/apache/arrow/pull/3785#discussion_r261667949"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/3785"}},"in_reply_to_id":261529262},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/3785","id":257330314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MzMwMzE0","html_url":"https://github.com/apache/arrow/pull/3785","diff_url":"https://github.com/apache/arrow/pull/3785.diff","patch_url":"https://github.com/apache/arrow/pull/3785.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/3785","number":3785,"state":"open","locked":false,"title":"ARROW-1790: [Format] Proposal for c-like struct.","user":{"login":"emkornfield","id":17869838,"node_id":"MDQ6VXNlcjE3ODY5ODM4","avatar_url":"https://avatars1.githubusercontent.com/u/17869838?v=4","gravatar_id":"","url":"https://api.github.com/users/emkornfield","html_url":"https://github.com/emkornfield","followers_url":"https://api.github.com/users/emkornfield/followers","following_url":"https://api.github.com/users/emkornfield/following{/other_user}","gists_url":"https://api.github.com/users/emkornfield/gists{/gist_id}","starred_url":"https://api.github.com/users/emkornfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkornfield/subscriptions","organizations_url":"https://api.github.com/users/emkornfield/orgs","repos_url":"https://api.github.com/users/emkornfield/repos","events_url":"https://api.github.com/users/emkornfield/events{/privacy}","received_events_url":"https://api.github.com/users/emkornfield/received_events","type":"User","site_admin":false},"body":"Some things worth discussing:\r\n1. General design.\r\n2. Should higher level fixed width logical types (e.g. time, timestamp be included).\r\nOn the other size is UTF-8 to high level?\r\n3. Should offset be overridable to allow for field overlap (numpy seems allow this)","created_at":"2019-03-01T06:06:57Z","updated_at":"2019-03-01T16:24:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0025d1414e10cc770165d35c0ef307637b3219cf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/3785/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/3785/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/3785/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/9ee218491bb1f897ef25aebcfba56bd7feb6d6ce","head":{"label":"emkornfield:ARROW-1790","ref":"ARROW-1790","sha":"9ee218491bb1f897ef25aebcfba56bd7feb6d6ce","user":{"login":"emkornfield","id":17869838,"node_id":"MDQ6VXNlcjE3ODY5ODM4","avatar_url":"https://avatars1.githubusercontent.com/u/17869838?v=4","gravatar_id":"","url":"https://api.github.com/users/emkornfield","html_url":"https://github.com/emkornfield","followers_url":"https://api.github.com/users/emkornfield/followers","following_url":"https://api.github.com/users/emkornfield/following{/other_user}","gists_url":"https://api.github.com/users/emkornfield/gists{/gist_id}","starred_url":"https://api.github.com/users/emkornfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkornfield/subscriptions","organizations_url":"https://api.github.com/users/emkornfield/orgs","repos_url":"https://api.github.com/users/emkornfield/repos","events_url":"https://api.github.com/users/emkornfield/events{/privacy}","received_events_url":"https://api.github.com/users/emkornfield/received_events","type":"User","site_admin":false},"repo":{"id":54009687,"node_id":"MDEwOlJlcG9zaXRvcnk1NDAwOTY4Nw==","name":"arrow","full_name":"emkornfield/arrow","private":false,"owner":{"login":"emkornfield","id":17869838,"node_id":"MDQ6VXNlcjE3ODY5ODM4","avatar_url":"https://avatars1.githubusercontent.com/u/17869838?v=4","gravatar_id":"","url":"https://api.github.com/users/emkornfield","html_url":"https://github.com/emkornfield","followers_url":"https://api.github.com/users/emkornfield/followers","following_url":"https://api.github.com/users/emkornfield/following{/other_user}","gists_url":"https://api.github.com/users/emkornfield/gists{/gist_id}","starred_url":"https://api.github.com/users/emkornfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkornfield/subscriptions","organizations_url":"https://api.github.com/users/emkornfield/orgs","repos_url":"https://api.github.com/users/emkornfield/repos","events_url":"https://api.github.com/users/emkornfield/events{/privacy}","received_events_url":"https://api.github.com/users/emkornfield/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emkornfield/arrow","description":"Mirror of Apache Arrow","fork":true,"url":"https://api.github.com/repos/emkornfield/arrow","forks_url":"https://api.github.com/repos/emkornfield/arrow/forks","keys_url":"https://api.github.com/repos/emkornfield/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emkornfield/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emkornfield/arrow/teams","hooks_url":"https://api.github.com/repos/emkornfield/arrow/hooks","issue_events_url":"https://api.github.com/repos/emkornfield/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/emkornfield/arrow/events","assignees_url":"https://api.github.com/repos/emkornfield/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/emkornfield/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/emkornfield/arrow/tags","blobs_url":"https://api.github.com/repos/emkornfield/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emkornfield/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emkornfield/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/emkornfield/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emkornfield/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/emkornfield/arrow/languages","stargazers_url":"https://api.github.com/repos/emkornfield/arrow/stargazers","contributors_url":"https://api.github.com/repos/emkornfield/arrow/contributors","subscribers_url":"https://api.github.com/repos/emkornfield/arrow/subscribers","subscription_url":"https://api.github.com/repos/emkornfield/arrow/subscription","commits_url":"https://api.github.com/repos/emkornfield/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/emkornfield/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/emkornfield/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/emkornfield/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/emkornfield/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/emkornfield/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emkornfield/arrow/merges","archive_url":"https://api.github.com/repos/emkornfield/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emkornfield/arrow/downloads","issues_url":"https://api.github.com/repos/emkornfield/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/emkornfield/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/emkornfield/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/emkornfield/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emkornfield/arrow/labels{/name}","releases_url":"https://api.github.com/repos/emkornfield/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/emkornfield/arrow/deployments","created_at":"2016-03-16T07:22:02Z","updated_at":"2019-03-01T04:29:00Z","pushed_at":"2019-03-01T06:06:10Z","git_url":"git://github.com/emkornfield/arrow.git","ssh_url":"git@github.com:emkornfield/arrow.git","clone_url":"https://github.com/emkornfield/arrow.git","svn_url":"https://github.com/emkornfield/arrow","homepage":null,"size":26441,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b766bff34b7d85034d26cebef5b3aeef1eb2fd82","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2019-03-01T15:34:51Z","pushed_at":"2019-03-01T16:07:16Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":26332,"stargazers_count":3393,"watchers_count":3393,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":847,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":847,"open_issues":81,"watchers":3393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/3785"},"html":{"href":"https://github.com/apache/arrow/pull/3785"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/3785"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/3785/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/3785/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/3785/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/9ee218491bb1f897ef25aebcfba56bd7feb6d6ce"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 51905353,
"name": "apache/arrow",
"url": "https://api.github.com/repos/apache/arrow"
}
|
{
"id": 17869838,
"login": "emkornfield",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17869838?",
"url": "https://api.github.com/users/emkornfield"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-03-01T16:24:39 |
9163652119
|
{"actor":{"display_login":"emkornfield"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/336285903","pull_request_review_id":303621473,"id":336285903,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjI4NTkwMw==","diff_hunk":"@@ -30,12 +30,32 @@\n public enum WriteFlag {\n \n /**\n- * Writes will be acknowledged after writing to the filesystem\n+ * Bit 0 - Writes will be acknowledged after writing to the filesystem\n * but not yet been persisted to disks.\n *\n * @see ForceableHandle#force()\n */\n- DEFERRED_SYNC(0x1 << 0);\n+ DEFERRED_SYNC(0x1 << 0),\n+ /**\n+ * Bits 1,2,3 - value 0.","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java","position":null,"original_position":13,"commit_id":"4eca065a8c9adc9028261b455184c5c6e41ea1cc","original_commit_id":"01eb1ce6afee1035d7dce45d469dc3d0fd22c700","user":{"login":"reddycharan","id":13989266,"node_id":"MDQ6VXNlcjEzOTg5MjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13989266?v=4","gravatar_id":"","url":"https://api.github.com/users/reddycharan","html_url":"https://github.com/reddycharan","followers_url":"https://api.github.com/users/reddycharan/followers","following_url":"https://api.github.com/users/reddycharan/following{/other_user}","gists_url":"https://api.github.com/users/reddycharan/gists{/gist_id}","starred_url":"https://api.github.com/users/reddycharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reddycharan/subscriptions","organizations_url":"https://api.github.com/users/reddycharan/orgs","repos_url":"https://api.github.com/users/reddycharan/repos","events_url":"https://api.github.com/users/reddycharan/events{/privacy}","received_events_url":"https://api.github.com/users/reddycharan/received_events","type":"User","site_admin":false},"body":"yes, we have to use this `static final int DIGEST_TYPE_BITS = 0x7 << 2;` in `getWriteFlags()` method. Basically to know the digestType we should do logical and with DIGEST_TYPE_BITS first and then do the logical and with the corresponding enum value. Basically we are making it clear in getWriteFlags method that these bits are considered to be related to DigestType. \r\n\r\n","created_at":"2019-10-18T01:04:41Z","updated_at":"2019-10-18T01:04:41Z","html_url":"https://github.com/apache/bookkeeper/pull/2182#discussion_r336285903","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/2182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/336285903"},"html":{"href":"https://github.com/apache/bookkeeper/pull/2182#discussion_r336285903"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/2182"}},"in_reply_to_id":336281376},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/2182","id":329017482,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MDE3NDgy","html_url":"https://github.com/apache/bookkeeper/pull/2182","diff_url":"https://github.com/apache/bookkeeper/pull/2182.diff","patch_url":"https://github.com/apache/bookkeeper/pull/2182.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/2182","number":2182,"state":"open","locked":false,"title":"Add API for Bookie checksum verification writeFlags","user":{"login":"karanmehta93","id":6191256,"node_id":"MDQ6VXNlcjYxOTEyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6191256?v=4","gravatar_id":"","url":"https://api.github.com/users/karanmehta93","html_url":"https://github.com/karanmehta93","followers_url":"https://api.github.com/users/karanmehta93/followers","following_url":"https://api.github.com/users/karanmehta93/following{/other_user}","gists_url":"https://api.github.com/users/karanmehta93/gists{/gist_id}","starred_url":"https://api.github.com/users/karanmehta93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanmehta93/subscriptions","organizations_url":"https://api.github.com/users/karanmehta93/orgs","repos_url":"https://api.github.com/users/karanmehta93/repos","events_url":"https://api.github.com/users/karanmehta93/events{/privacy}","received_events_url":"https://api.github.com/users/karanmehta93/received_events","type":"User","site_admin":false},"body":"Descriptions of the changes in this PR:\r\n\r\n### Motivation\r\n\r\nReserving the bits from `WriteFlag` so that clients can send the checksum information to the bookies\r\n\r\n### Changes\r\n\r\nUpdated `WriteFlag` class\r\nBit no 2-4 (from the right) indicates checksum type.\r\n0 --> No verification enabled\r\n1 --> DIGEST_TYPE_CRC32\r\n2 --> DIGEST_TYPE_MAC\r\n3 -->DIGEST_TYPE_CRC32C\r\n\r\nBit no 0 (from the right) is currently being used for `DEFERRED_SYNC` option.\r\n\r\nMaster Issue: #2174","created_at":"2019-10-17T00:49:26Z","updated_at":"2019-10-18T01:04:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"114f4976b008ca56a0fe723589215e7b535c8927","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/2182/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/2182/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/2182/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/4eca065a8c9adc9028261b455184c5c6e41ea1cc","head":{"label":"karanmehta93:checksumWriteFlags","ref":"checksumWriteFlags","sha":"4eca065a8c9adc9028261b455184c5c6e41ea1cc","user":{"login":"karanmehta93","id":6191256,"node_id":"MDQ6VXNlcjYxOTEyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6191256?v=4","gravatar_id":"","url":"https://api.github.com/users/karanmehta93","html_url":"https://github.com/karanmehta93","followers_url":"https://api.github.com/users/karanmehta93/followers","following_url":"https://api.github.com/users/karanmehta93/following{/other_user}","gists_url":"https://api.github.com/users/karanmehta93/gists{/gist_id}","starred_url":"https://api.github.com/users/karanmehta93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanmehta93/subscriptions","organizations_url":"https://api.github.com/users/karanmehta93/orgs","repos_url":"https://api.github.com/users/karanmehta93/repos","events_url":"https://api.github.com/users/karanmehta93/events{/privacy}","received_events_url":"https://api.github.com/users/karanmehta93/received_events","type":"User","site_admin":false},"repo":{"id":183738115,"node_id":"MDEwOlJlcG9zaXRvcnkxODM3MzgxMTU=","name":"bookkeeper","full_name":"karanmehta93/bookkeeper","private":false,"owner":{"login":"karanmehta93","id":6191256,"node_id":"MDQ6VXNlcjYxOTEyNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6191256?v=4","gravatar_id":"","url":"https://api.github.com/users/karanmehta93","html_url":"https://github.com/karanmehta93","followers_url":"https://api.github.com/users/karanmehta93/followers","following_url":"https://api.github.com/users/karanmehta93/following{/other_user}","gists_url":"https://api.github.com/users/karanmehta93/gists{/gist_id}","starred_url":"https://api.github.com/users/karanmehta93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karanmehta93/subscriptions","organizations_url":"https://api.github.com/users/karanmehta93/orgs","repos_url":"https://api.github.com/users/karanmehta93/repos","events_url":"https://api.github.com/users/karanmehta93/events{/privacy}","received_events_url":"https://api.github.com/users/karanmehta93/received_events","type":"User","site_admin":false},"html_url":"https://github.com/karanmehta93/bookkeeper","description":"Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/karanmehta93/bookkeeper","forks_url":"https://api.github.com/repos/karanmehta93/bookkeeper/forks","keys_url":"https://api.github.com/repos/karanmehta93/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/karanmehta93/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/karanmehta93/bookkeeper/teams","hooks_url":"https://api.github.com/repos/karanmehta93/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/karanmehta93/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/karanmehta93/bookkeeper/events","assignees_url":"https://api.github.com/repos/karanmehta93/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/karanmehta93/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/karanmehta93/bookkeeper/tags","blobs_url":"https://api.github.com/repos/karanmehta93/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/karanmehta93/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/karanmehta93/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/karanmehta93/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/karanmehta93/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/karanmehta93/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/karanmehta93/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/karanmehta93/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/karanmehta93/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/karanmehta93/bookkeeper/subscription","commits_url":"https://api.github.com/repos/karanmehta93/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/karanmehta93/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/karanmehta93/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/karanmehta93/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/karanmehta93/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/karanmehta93/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/karanmehta93/bookkeeper/merges","archive_url":"https://api.github.com/repos/karanmehta93/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/karanmehta93/bookkeeper/downloads","issues_url":"https://api.github.com/repos/karanmehta93/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/karanmehta93/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/karanmehta93/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/karanmehta93/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/karanmehta93/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/karanmehta93/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/karanmehta93/bookkeeper/deployments","created_at":"2019-04-27T06:40:14Z","updated_at":"2019-10-15T06:53:06Z","pushed_at":"2019-10-18T00:53:12Z","git_url":"git://github.com/karanmehta93/bookkeeper.git","ssh_url":"git@github.com:karanmehta93/bookkeeper.git","clone_url":"https://github.com/karanmehta93/bookkeeper.git","svn_url":"https://github.com/karanmehta93/bookkeeper","homepage":"https://bookkeeper.apache.org","size":45624,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"7c24301856fcc502ae2c595195cf48ac62ffe47d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1OTU2","name":"bookkeeper","full_name":"apache/bookkeeper","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2019-10-17T21:38:41Z","pushed_at":"2019-10-18T00:53:14Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":47280,"stargazers_count":768,"watchers_count":768,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":193,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":295,"open_issues":193,"watchers":768,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/2182"},"html":{"href":"https://github.com/apache/bookkeeper/pull/2182"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/2182"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/2182/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/2182/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/2182/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/4eca065a8c9adc9028261b455184c5c6e41ea1cc"}},"author_association":"MEMBER"}}
|
{
"id": 1575956,
"name": "apache/bookkeeper",
"url": "https://api.github.com/repos/apache/bookkeeper"
}
|
{
"id": 13989266,
"login": "reddycharan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13989266?",
"url": "https://api.github.com/users/reddycharan"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-10-18T01:04:41 |
10657765255
|
{"actor":{"display_login":"reddycharan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/comments/341890596","pull_request_review_id":310861885,"id":341890596,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTg5MDU5Ng==","diff_hunk":"@@ -184,6 +184,7 @@ struct TSFetchMetadataResp{\n \t\t8: optional set<string> devices\n \t\t9: optional list<string> nodesList\n \t\t10: optional map<string, string> nodeTimeseriesNum\n+\t\t11: optional set<string> childPaths","path":"service-rpc/src/main/thrift/rpc.thrift","position":4,"original_position":4,"commit_id":"429ef0548fb3b7633868c3200af5a83e69961158","original_commit_id":"429ef0548fb3b7633868c3200af5a83e69961158","user":{"login":"HTHou","id":25913899,"node_id":"MDQ6VXNlcjI1OTEzODk5","avatar_url":"https://avatars1.githubusercontent.com/u/25913899?v=4","gravatar_id":"","url":"https://api.github.com/users/HTHou","html_url":"https://github.com/HTHou","followers_url":"https://api.github.com/users/HTHou/followers","following_url":"https://api.github.com/users/HTHou/following{/other_user}","gists_url":"https://api.github.com/users/HTHou/gists{/gist_id}","starred_url":"https://api.github.com/users/HTHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTHou/subscriptions","organizations_url":"https://api.github.com/users/HTHou/orgs","repos_url":"https://api.github.com/users/HTHou/repos","events_url":"https://api.github.com/users/HTHou/events{/privacy}","received_events_url":"https://api.github.com/users/HTHou/received_events","type":"User","site_admin":false},"body":"> It is not much related to this PR, but seeing this, I think maybe we should break down this Resp into several smaller ones so that it is more clear what it responds to.\r\n\r\nDid you mean we can separate `TSFetchMetadataResp` into some ones like `TSFetchDevicesResp`, `TSFetchNodeListResp`, etc? \r\nThat's a good point.","created_at":"2019-11-04T02:25:13Z","updated_at":"2019-11-04T02:25:13Z","html_url":"https://github.com/apache/incubator-iotdb/pull/506#discussion_r341890596","pull_request_url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/comments/341890596"},"html":{"href":"https://github.com/apache/incubator-iotdb/pull/506#discussion_r341890596"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506"}},"in_reply_to_id":341889647},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506","id":335307484,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM1MzA3NDg0","html_url":"https://github.com/apache/incubator-iotdb/pull/506","diff_url":"https://github.com/apache/incubator-iotdb/pull/506.diff","patch_url":"https://github.com/apache/incubator-iotdb/pull/506.patch","issue_url":"https://api.github.com/repos/apache/incubator-iotdb/issues/506","number":506,"state":"open","locked":false,"title":"[IOTDB-259] level query of path","user":{"login":"HTHou","id":25913899,"node_id":"MDQ6VXNlcjI1OTEzODk5","avatar_url":"https://avatars1.githubusercontent.com/u/25913899?v=4","gravatar_id":"","url":"https://api.github.com/users/HTHou","html_url":"https://github.com/HTHou","followers_url":"https://api.github.com/users/HTHou/followers","following_url":"https://api.github.com/users/HTHou/following{/other_user}","gists_url":"https://api.github.com/users/HTHou/gists{/gist_id}","starred_url":"https://api.github.com/users/HTHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTHou/subscriptions","organizations_url":"https://api.github.com/users/HTHou/orgs","repos_url":"https://api.github.com/users/HTHou/repos","events_url":"https://api.github.com/users/HTHou/events{/privacy}","received_events_url":"https://api.github.com/users/HTHou/received_events","type":"User","site_admin":false},"body":"when we don't know a specific timeseries path, we'd like to complete the optional path level by level(like the dir auto-complete in Linux), so we need the level query capcity of path.\r\n\r\nFor example, given there're two timeseries: root.a.s1.d1, root.a.s2.d1, we know the storage group root.a, but we are not sure the optional path of the next level. so we want the level query: give the prefix root.a, iotdb can return the already exist optional path of the next level : {s1,s2} , then we can get the new path root.a.s1\r\n\r\njira link: [https://issues.apache.org/jira/browse/IOTDB-259](https://issues.apache.org/jira/browse/IOTDB-259)","created_at":"2019-11-01T07:28:01Z","updated_at":"2019-11-04T02:25:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c9cbbd3c5c2e44752426423ef72ef6efb6c5708","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-iotdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-iotdb/issues/506/comments","statuses_url":"https://api.github.com/repos/apache/incubator-iotdb/statuses/429ef0548fb3b7633868c3200af5a83e69961158","head":{"label":"HTHou:show_child_paths","ref":"show_child_paths","sha":"429ef0548fb3b7633868c3200af5a83e69961158","user":{"login":"HTHou","id":25913899,"node_id":"MDQ6VXNlcjI1OTEzODk5","avatar_url":"https://avatars1.githubusercontent.com/u/25913899?v=4","gravatar_id":"","url":"https://api.github.com/users/HTHou","html_url":"https://github.com/HTHou","followers_url":"https://api.github.com/users/HTHou/followers","following_url":"https://api.github.com/users/HTHou/following{/other_user}","gists_url":"https://api.github.com/users/HTHou/gists{/gist_id}","starred_url":"https://api.github.com/users/HTHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTHou/subscriptions","organizations_url":"https://api.github.com/users/HTHou/orgs","repos_url":"https://api.github.com/users/HTHou/repos","events_url":"https://api.github.com/users/HTHou/events{/privacy}","received_events_url":"https://api.github.com/users/HTHou/received_events","type":"User","site_admin":false},"repo":{"id":218678527,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg2Nzg1Mjc=","name":"incubator-iotdb","full_name":"HTHou/incubator-iotdb","private":false,"owner":{"login":"HTHou","id":25913899,"node_id":"MDQ6VXNlcjI1OTEzODk5","avatar_url":"https://avatars1.githubusercontent.com/u/25913899?v=4","gravatar_id":"","url":"https://api.github.com/users/HTHou","html_url":"https://github.com/HTHou","followers_url":"https://api.github.com/users/HTHou/followers","following_url":"https://api.github.com/users/HTHou/following{/other_user}","gists_url":"https://api.github.com/users/HTHou/gists{/gist_id}","starred_url":"https://api.github.com/users/HTHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTHou/subscriptions","organizations_url":"https://api.github.com/users/HTHou/orgs","repos_url":"https://api.github.com/users/HTHou/repos","events_url":"https://api.github.com/users/HTHou/events{/privacy}","received_events_url":"https://api.github.com/users/HTHou/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HTHou/incubator-iotdb","description":"Apache iotdb","fork":true,"url":"https://api.github.com/repos/HTHou/incubator-iotdb","forks_url":"https://api.github.com/repos/HTHou/incubator-iotdb/forks","keys_url":"https://api.github.com/repos/HTHou/incubator-iotdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HTHou/incubator-iotdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HTHou/incubator-iotdb/teams","hooks_url":"https://api.github.com/repos/HTHou/incubator-iotdb/hooks","issue_events_url":"https://api.github.com/repos/HTHou/incubator-iotdb/issues/events{/number}","events_url":"https://api.github.com/repos/HTHou/incubator-iotdb/events","assignees_url":"https://api.github.com/repos/HTHou/incubator-iotdb/assignees{/user}","branches_url":"https://api.github.com/repos/HTHou/incubator-iotdb/branches{/branch}","tags_url":"https://api.github.com/repos/HTHou/incubator-iotdb/tags","blobs_url":"https://api.github.com/repos/HTHou/incubator-iotdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HTHou/incubator-iotdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HTHou/incubator-iotdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/HTHou/incubator-iotdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HTHou/incubator-iotdb/statuses/{sha}","languages_url":"https://api.github.com/repos/HTHou/incubator-iotdb/languages","stargazers_url":"https://api.github.com/repos/HTHou/incubator-iotdb/stargazers","contributors_url":"https://api.github.com/repos/HTHou/incubator-iotdb/contributors","subscribers_url":"https://api.github.com/repos/HTHou/incubator-iotdb/subscribers","subscription_url":"https://api.github.com/repos/HTHou/incubator-iotdb/subscription","commits_url":"https://api.github.com/repos/HTHou/incubator-iotdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/HTHou/incubator-iotdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/HTHou/incubator-iotdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/HTHou/incubator-iotdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/HTHou/incubator-iotdb/contents/{+path}","compare_url":"https://api.github.com/repos/HTHou/incubator-iotdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HTHou/incubator-iotdb/merges","archive_url":"https://api.github.com/repos/HTHou/incubator-iotdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HTHou/incubator-iotdb/downloads","issues_url":"https://api.github.com/repos/HTHou/incubator-iotdb/issues{/number}","pulls_url":"https://api.github.com/repos/HTHou/incubator-iotdb/pulls{/number}","milestones_url":"https://api.github.com/repos/HTHou/incubator-iotdb/milestones{/number}","notifications_url":"https://api.github.com/repos/HTHou/incubator-iotdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HTHou/incubator-iotdb/labels{/name}","releases_url":"https://api.github.com/repos/HTHou/incubator-iotdb/releases{/id}","deployments_url":"https://api.github.com/repos/HTHou/incubator-iotdb/deployments","created_at":"2019-10-31T03:38:48Z","updated_at":"2019-11-01T12:34:05Z","pushed_at":"2019-11-01T12:42:48Z","git_url":"git://github.com/HTHou/incubator-iotdb.git","ssh_url":"git@github.com:HTHou/incubator-iotdb.git","clone_url":"https://github.com/HTHou/incubator-iotdb.git","svn_url":"https://github.com/HTHou/incubator-iotdb","homepage":"https://iotdb.apache.org/","size":22223,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d7dcfbfba309545111c0eca658729c8dfbe60c17","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":158975124,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg5NzUxMjQ=","name":"incubator-iotdb","full_name":"apache/incubator-iotdb","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-iotdb","description":"Apache iotdb","fork":false,"url":"https://api.github.com/repos/apache/incubator-iotdb","forks_url":"https://api.github.com/repos/apache/incubator-iotdb/forks","keys_url":"https://api.github.com/repos/apache/incubator-iotdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-iotdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-iotdb/teams","hooks_url":"https://api.github.com/repos/apache/incubator-iotdb/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-iotdb/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-iotdb/events","assignees_url":"https://api.github.com/repos/apache/incubator-iotdb/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-iotdb/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-iotdb/tags","blobs_url":"https://api.github.com/repos/apache/incubator-iotdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-iotdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-iotdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-iotdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-iotdb/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-iotdb/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-iotdb/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-iotdb/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-iotdb/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-iotdb/subscription","commits_url":"https://api.github.com/repos/apache/incubator-iotdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-iotdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-iotdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-iotdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-iotdb/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-iotdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-iotdb/merges","archive_url":"https://api.github.com/repos/apache/incubator-iotdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-iotdb/downloads","issues_url":"https://api.github.com/repos/apache/incubator-iotdb/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-iotdb/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-iotdb/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-iotdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-iotdb/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-iotdb/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-iotdb/deployments","created_at":"2018-11-24T21:29:17Z","updated_at":"2019-11-04T02:15:23Z","pushed_at":"2019-11-04T02:17:44Z","git_url":"git://github.com/apache/incubator-iotdb.git","ssh_url":"git@github.com:apache/incubator-iotdb.git","clone_url":"https://github.com/apache/incubator-iotdb.git","svn_url":"https://github.com/apache/incubator-iotdb","homepage":"https://iotdb.apache.org/","size":22188,"stargazers_count":227,"watchers_count":227,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":86,"open_issues":16,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506"},"html":{"href":"https://github.com/apache/incubator-iotdb/pull/506"},"issue":{"href":"https://api.github.com/repos/apache/incubator-iotdb/issues/506"},"comments":{"href":"https://api.github.com/repos/apache/incubator-iotdb/issues/506/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-iotdb/pulls/506/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-iotdb/statuses/429ef0548fb3b7633868c3200af5a83e69961158"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 158975124,
"name": "apache/incubator-iotdb",
"url": "https://api.github.com/repos/apache/incubator-iotdb"
}
|
{
"id": 25913899,
"login": "HTHou",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25913899?",
"url": "https://api.github.com/users/HTHou"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-11-04T02:25:13 |
10777265598
|
{"actor":{"display_login":"HTHou"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink-web/pulls/comments/313787735","pull_request_review_id":274773033,"id":313787735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzc4NzczNQ==","diff_hunk":"@@ -0,0 +1,352 @@\n+---\n+layout: post \n+title: \"Apache Flink 1.9.0 Release Announcement\" \n+date: 2019-8-11 12:00:00 \n+categories: news\n+---\n+\n+\n+The Apache Flink community is proud to announce the release of Apache Flink\n+1.9.0.\n+\n+The Apache Flink project's goal is to develop a stream processing system to\n+unify and power many forms of real-time and offline data processing\n+applications as well as event-driven applications. In this release, we have\n+made a huge step forward in that effort, by integrating Flink’s stream and\n+batch processing capabilities under a single, unified runtime.\n+\n+Significant features on this path are batch-style recovery for batch jobs and\n+a preview of the new Blink-based query engine for Table API and SQL queries.\n+We are also excited to announce the availability of the State Processor API,\n+which is one of the most frequently requested features and enables users to\n+read and write savepoints with Flink DataSet jobs. Finally, Flink 1.9 includes\n+a reworked WebUI and previews of Flink’s new Python Table API and its\n+integration with the Apache Hive ecosystem.\n+\n+This blog post describes all major new features and improvements, important\n+changes to be aware of and what to expect moving forward. For more details,\n+check the [complete release\n+changelog](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12315522&version=12344601).\n+\n+The binary distribution and source artifacts for this release are now\n+available via the [Downloads](https://flink.apache.org/downloads.html) page of\n+the Flink project, along with the updated\n+[documentation](https://ci.apache.org/projects/flink/flink-docs-release-1.9/).\n+Flink 1.9 is API-compatible with previous 1.x releases for APIs annotated with\n+the @Public annotation.\n+\n+Please feel encouraged to download the release and share your thoughts with\n+the community through the Flink [mailing\n+lists](https://flink.apache.org/community.html#mailing-lists) or\n+[JIRA](https://issues.apache.org/jira/projects/FLINK/summary). As always,\n+feedback is very much appreciated!\n+\n+\n+{% toc %}\n+\n+\n+## New Features and Improvements\n+\n+\n+### Fine-grained Batch Recovery (FLIP-1)\n+\n+The time to recover a batch (DataSet, Table API and SQL) job from a task\n+failure was significantly reduced. Until Flink 1.9, task failures in batch\n+jobs were recovered by canceling all tasks and restarting the whole job, i.e,\n+the job was started from scratch and all progress was voided. With this\n+release, Flink persists intermediate results at network shuffle boundaries and\n+use this data to limit the recovery to only those tasks that are affected by\n+the failure. So-called failover regions of tasks which are connected via\n+pipelined data exchanges define the boundaries among which tasks are affected\n+by failures. More details are available in\n+[FLIP-1](https://cwiki.apache.org/confluence/display/FLINK/FLIP-1+%3A+Fine+Grained+Recovery+from+Task+Failures).\n+\n+![alt_text]({{site.baseurl}}/img/blog/release-19-flip1.png \"Fine-grained Batch\n+Recovery\")\n+\n+To use this new failover strategy, you need to do the following settings:\n+\n+ * Make sure you have the entry `jobmanager.execution.failover-strategy:\n+ region` in your `flink-conf.yaml`.\n+ * Set the `ExecutionMode` to `BATCH` in the `ExecutionConfig`.\n+\n+**Note:** The configuration of the 1.9 distribution has that entry by default,\n+but when reusing a configuration file from previous setups, you have to add it\n+manually.\n+\n+The \"Region\" failover strategy also improves the recovery of “embarrassingly\n+parallel” streaming jobs, i.e., jobs without any shuffle like keyBy() or\n+rebalance. When such a job is recovered, only the tasks of the affected\n+pipeline (failover region) are restarted. For all other streaming jobs, the\n+recovery behavior is the same as in prior Flink versions.\n+\n+\n+### State Processor API (FLIP-43)\n+\n+Up to Flink 1.9, accessing the state of a job from the outside was limited to\n+the (still) experimental [Queryable\n+State](https://ci.apache.org/projects/flink/flink-docs-stable/dev/stream/state/queryable_state.html).\n+This release introduces a new, powerful library to read, write and modify\n+state snapshots using the batch DataSet API. In practice, this means:\n+\n+ * Flink job state can be bootstrapped by reading data from external systems,\n+ such as external databases, and converting it into a savepoint.\n+ * State in savepoints can be queried using any of Flink’s batch APIs\n+ (DataSet, Table, SQL), for example to analyze relevant state patterns or\n+ check for discrepancies in state that can support application auditing or\n+ troubleshooting.\n+ * The schema of state in savepoints can be migrated offline, compared to the\n+ previous approach requiring online migration on schema access.\n+ * Invalid data in savepoints can be identified and corrected.\n+\n+The new State Processor API covers all variations of snapshots: savepoints,\n+full checkpoints and incremental checkpoints. More details are available in\n+[FLIP-43](https://cwiki.apache.org/confluence/display/FLINK/FLIP-43%3A+State+Processor+API)\n+\n+\n+### Stop-with-Savepoint (FLIP-34)","path":"_posts/2019-08-15-release-1.9.0.md","position":107,"original_position":107,"commit_id":"195b7137a058ca549ee6af45cf4cb220480dc749","original_commit_id":"195b7137a058ca549ee6af45cf4cb220480dc749","user":{"login":"rmetzger","id":89049,"node_id":"MDQ6VXNlcjg5MDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/89049?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"What do you think @aljoscha @kl0u?","created_at":"2019-08-14T09:36:00Z","updated_at":"2019-08-14T09:36:00Z","html_url":"https://github.com/apache/flink-web/pull/244#discussion_r313787735","pull_request_url":"https://api.github.com/repos/apache/flink-web/pulls/244","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink-web/pulls/comments/313787735"},"html":{"href":"https://github.com/apache/flink-web/pull/244#discussion_r313787735"},"pull_request":{"href":"https://api.github.com/repos/apache/flink-web/pulls/244"}},"in_reply_to_id":313627576},"pull_request":{"url":"https://api.github.com/repos/apache/flink-web/pulls/244","id":306872445,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2ODcyNDQ1","html_url":"https://github.com/apache/flink-web/pull/244","diff_url":"https://github.com/apache/flink-web/pull/244.diff","patch_url":"https://github.com/apache/flink-web/pull/244.patch","issue_url":"https://api.github.com/repos/apache/flink-web/issues/244","number":244,"state":"open","locked":false,"title":"Add 1.9.0 Release Announcement","user":{"login":"rmetzger","id":89049,"node_id":"MDQ6VXNlcjg5MDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/89049?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-13T11:55:37Z","updated_at":"2019-08-14T09:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cb9ef787438a0900b6ab81c564e64f62fa01a1c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink-web/pulls/244/commits","review_comments_url":"https://api.github.com/repos/apache/flink-web/pulls/244/comments","review_comment_url":"https://api.github.com/repos/apache/flink-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink-web/issues/244/comments","statuses_url":"https://api.github.com/repos/apache/flink-web/statuses/195b7137a058ca549ee6af45cf4cb220480dc749","head":{"label":"rmetzger:rel19ann","ref":"rel19ann","sha":"195b7137a058ca549ee6af45cf4cb220480dc749","user":{"login":"rmetzger","id":89049,"node_id":"MDQ6VXNlcjg5MDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/89049?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"repo":{"id":41426432,"node_id":"MDEwOlJlcG9zaXRvcnk0MTQyNjQzMg==","name":"flink-web","full_name":"rmetzger/flink-web","private":false,"owner":{"login":"rmetzger","id":89049,"node_id":"MDQ6VXNlcjg5MDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/89049?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetzger","html_url":"https://github.com/rmetzger","followers_url":"https://api.github.com/users/rmetzger/followers","following_url":"https://api.github.com/users/rmetzger/following{/other_user}","gists_url":"https://api.github.com/users/rmetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetzger/subscriptions","organizations_url":"https://api.github.com/users/rmetzger/orgs","repos_url":"https://api.github.com/users/rmetzger/repos","events_url":"https://api.github.com/users/rmetzger/events{/privacy}","received_events_url":"https://api.github.com/users/rmetzger/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rmetzger/flink-web","description":"Mirror of Apache Flink Website","fork":true,"url":"https://api.github.com/repos/rmetzger/flink-web","forks_url":"https://api.github.com/repos/rmetzger/flink-web/forks","keys_url":"https://api.github.com/repos/rmetzger/flink-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmetzger/flink-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmetzger/flink-web/teams","hooks_url":"https://api.github.com/repos/rmetzger/flink-web/hooks","issue_events_url":"https://api.github.com/repos/rmetzger/flink-web/issues/events{/number}","events_url":"https://api.github.com/repos/rmetzger/flink-web/events","assignees_url":"https://api.github.com/repos/rmetzger/flink-web/assignees{/user}","branches_url":"https://api.github.com/repos/rmetzger/flink-web/branches{/branch}","tags_url":"https://api.github.com/repos/rmetzger/flink-web/tags","blobs_url":"https://api.github.com/repos/rmetzger/flink-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmetzger/flink-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmetzger/flink-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmetzger/flink-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmetzger/flink-web/statuses/{sha}","languages_url":"https://api.github.com/repos/rmetzger/flink-web/languages","stargazers_url":"https://api.github.com/repos/rmetzger/flink-web/stargazers","contributors_url":"https://api.github.com/repos/rmetzger/flink-web/contributors","subscribers_url":"https://api.github.com/repos/rmetzger/flink-web/subscribers","subscription_url":"https://api.github.com/repos/rmetzger/flink-web/subscription","commits_url":"https://api.github.com/repos/rmetzger/flink-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmetzger/flink-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmetzger/flink-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmetzger/flink-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmetzger/flink-web/contents/{+path}","compare_url":"https://api.github.com/repos/rmetzger/flink-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmetzger/flink-web/merges","archive_url":"https://api.github.com/repos/rmetzger/flink-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmetzger/flink-web/downloads","issues_url":"https://api.github.com/repos/rmetzger/flink-web/issues{/number}","pulls_url":"https://api.github.com/repos/rmetzger/flink-web/pulls{/number}","milestones_url":"https://api.github.com/repos/rmetzger/flink-web/milestones{/number}","notifications_url":"https://api.github.com/repos/rmetzger/flink-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmetzger/flink-web/labels{/name}","releases_url":"https://api.github.com/repos/rmetzger/flink-web/releases{/id}","deployments_url":"https://api.github.com/repos/rmetzger/flink-web/deployments","created_at":"2015-08-26T13:14:15Z","updated_at":"2019-01-25T16:39:01Z","pushed_at":"2019-08-13T11:55:12Z","git_url":"git://github.com/rmetzger/flink-web.git","ssh_url":"git@github.com:rmetzger/flink-web.git","clone_url":"https://github.com/rmetzger/flink-web.git","svn_url":"https://github.com/rmetzger/flink-web","homepage":null,"size":78180,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"asf-site"}},"base":{"label":"apache:asf-site","ref":"asf-site","sha":"4eb2b1e9d7da623fadbac3cea3cd63b121eeaa6f","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":35755560,"node_id":"MDEwOlJlcG9zaXRvcnkzNTc1NTU2MA==","name":"flink-web","full_name":"apache/flink-web","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink-web","description":"Apache Flink Website","fork":false,"url":"https://api.github.com/repos/apache/flink-web","forks_url":"https://api.github.com/repos/apache/flink-web/forks","keys_url":"https://api.github.com/repos/apache/flink-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink-web/teams","hooks_url":"https://api.github.com/repos/apache/flink-web/hooks","issue_events_url":"https://api.github.com/repos/apache/flink-web/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink-web/events","assignees_url":"https://api.github.com/repos/apache/flink-web/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink-web/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink-web/tags","blobs_url":"https://api.github.com/repos/apache/flink-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink-web/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink-web/languages","stargazers_url":"https://api.github.com/repos/apache/flink-web/stargazers","contributors_url":"https://api.github.com/repos/apache/flink-web/contributors","subscribers_url":"https://api.github.com/repos/apache/flink-web/subscribers","subscription_url":"https://api.github.com/repos/apache/flink-web/subscription","commits_url":"https://api.github.com/repos/apache/flink-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink-web/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink-web/merges","archive_url":"https://api.github.com/repos/apache/flink-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink-web/downloads","issues_url":"https://api.github.com/repos/apache/flink-web/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink-web/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink-web/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink-web/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink-web/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink-web/deployments","created_at":"2015-05-17T07:00:05Z","updated_at":"2019-08-13T14:56:04Z","pushed_at":"2019-08-13T13:52:07Z","git_url":"git://github.com/apache/flink-web.git","ssh_url":"git@github.com:apache/flink-web.git","clone_url":"https://github.com/apache/flink-web.git","svn_url":"https://github.com/apache/flink-web","homepage":"","size":77802,"stargazers_count":53,"watchers_count":53,"language":"HTML","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":115,"open_issues":8,"watchers":53,"default_branch":"asf-site"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink-web/pulls/244"},"html":{"href":"https://github.com/apache/flink-web/pull/244"},"issue":{"href":"https://api.github.com/repos/apache/flink-web/issues/244"},"comments":{"href":"https://api.github.com/repos/apache/flink-web/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink-web/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink-web/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink-web/statuses/195b7137a058ca549ee6af45cf4cb220480dc749"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 35755560,
"name": "apache/flink-web",
"url": "https://api.github.com/repos/apache/flink-web"
}
|
{
"id": 89049,
"login": "rmetzger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/89049?",
"url": "https://api.github.com/users/rmetzger"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-08-14T09:36:00 |
10208221454
|
{"actor":{"display_login":"rmetzger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/airflow/pulls/comments/276511788","pull_request_review_id":228093691,"id":276511788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NjUxMTc4OA==","diff_hunk":"@@ -330,34 +350,44 @@ def pool_export_helper(filepath):\n \n \n @cli_utils.action_logging\n-def variables(args):\n- if args.get:\n- try:\n- var = Variable.get(args.get,\n- deserialize_json=args.json,\n- default_var=args.default)\n- print(var)\n- except ValueError as e:\n- print(e)\n- if args.delete:\n- Variable.delete(args.delete)\n- if args.set:\n- Variable.set(args.set[0], args.set[1])\n- # Work around 'import' as a reserved keyword\n- imp = getattr(args, 'import')\n- if imp:\n- if os.path.exists(imp):\n- import_helper(imp)\n- else:\n- print(\"Missing variables file.\")\n- if args.export:\n- export_helper(args.export)\n- if not (args.set or args.get or imp or args.export or args.delete):\n- # list all variables\n- with db.create_session() as session:\n- vars = session.query(Variable)\n- msg = \"\\n\".join(var.key for var in vars)\n- print(msg)\n+def variables_list(args):\n+ with db.create_session() as session:\n+ vars = session.query(Variable)\n+ print(\"\\n\".join(var.key for var in vars))\n+\n+\n+@cli_utils.action_logging\n+def variables_get(args):\n+ try:\n+ var = Variable.get(args.key,\n+ deserialize_json=args.json,\n+ default_var=args.default)\n+ print(var)\n+ except ValueError as e:\n+ print(e)\n+\n+\n+@cli_utils.action_logging\n+def variables_set(args):\n+ Variable.set(args.key, args.value, serialize_json=args.json)\n+\n+\n+@cli_utils.action_logging\n+def variables_delete(args):\n+ Variable.delete(args.key)\n+\n+\n+@cli_utils.action_logging\n+def variables_import(args):\n+ if os.path.exists(args.file):\n+ import_helper(args.file)\n+ else:\n+ print(\"Missing variables file.\")\n+\n+\n+@cli_utils.action_logging\n+def variables_export(args):\n+ export_helper(args.file)","path":"airflow/bin/cli.py","position":null,"original_position":162,"commit_id":"c723d9a86593e4f9e6588c65197375cb780a4f8d","original_commit_id":"7edf4f1b533d85a550f53cf7d9944b5420b43559","user":{"login":"jmcarp","id":1633460,"node_id":"MDQ6VXNlcjE2MzM0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1633460?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"body":"Made this change.","created_at":"2019-04-18T04:10:34Z","updated_at":"2019-04-18T04:10:34Z","html_url":"https://github.com/apache/airflow/pull/4821#discussion_r276511788","pull_request_url":"https://api.github.com/repos/apache/airflow/pulls/4821","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/airflow/pulls/comments/276511788"},"html":{"href":"https://github.com/apache/airflow/pull/4821#discussion_r276511788"},"pull_request":{"href":"https://api.github.com/repos/apache/airflow/pulls/4821"}},"in_reply_to_id":275443226},"pull_request":{"url":"https://api.github.com/repos/apache/airflow/pulls/4821","id":257691929,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NjkxOTI5","html_url":"https://github.com/apache/airflow/pull/4821","diff_url":"https://github.com/apache/airflow/pull/4821.diff","patch_url":"https://github.com/apache/airflow/pull/4821.patch","issue_url":"https://api.github.com/repos/apache/airflow/issues/4821","number":4821,"state":"open","locked":false,"title":"[AIRFLOW-3998] Use nested commands in cli.","user":{"login":"jmcarp","id":1633460,"node_id":"MDQ6VXNlcjE2MzM0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1633460?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"body":"Make sure you have checked _all_ steps below.\r\n\r\n### Jira\r\n\r\n- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, \"\\[AIRFLOW-XXX\\] My Airflow PR\"\r\n - https://issues.apache.org/jira/browse/AIRFLOW-3998\r\n - In case you are fixing a typo in the documentation you can prepend your commit with \\[AIRFLOW-XXX\\], code changes always need a Jira issue.\r\n - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).\r\n\r\n### Description\r\n\r\n- [x] Here are some details about my PR, including screenshots of any UI changes:\r\n\r\nThis is a proof of concept for https://issues.apache.org/jira/browse/AIRFLOW-3998 / https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-16%3A+Use+nested+commands+in+CLI.\r\n\r\n### Tests\r\n\r\n- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:\r\n\r\n### Commits\r\n\r\n- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from \"[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)\":\r\n 1. Subject is separated from body by a blank line\r\n 1. Subject is limited to 50 characters (not including Jira issue reference)\r\n 1. Subject does not end with a period\r\n 1. Subject uses the imperative mood (\"add\", not \"adding\")\r\n 1. Body wraps at 72 characters\r\n 1. Body explains \"what\" and \"why\", not \"how\"\r\n\r\n### Documentation\r\n\r\n- [x] In case of new functionality, my PR adds documentation that describes how to use it.\r\n - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.\r\n - All the public functions and the classes in the PR contain docstrings that explain what it does\r\n\r\n### Code Quality\r\n\r\n- [x] Passes `flake8`\r\n","created_at":"2019-03-02T20:56:37Z","updated_at":"2019-04-18T04:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8684f2cb61d0641bf5411a4e70ae87cded63bdd5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/airflow/pulls/4821/commits","review_comments_url":"https://api.github.com/repos/apache/airflow/pulls/4821/comments","review_comment_url":"https://api.github.com/repos/apache/airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/airflow/issues/4821/comments","statuses_url":"https://api.github.com/repos/apache/airflow/statuses/c723d9a86593e4f9e6588c65197375cb780a4f8d","head":{"label":"jmcarp:cli-nested-commands","ref":"cli-nested-commands","sha":"c723d9a86593e4f9e6588c65197375cb780a4f8d","user":{"login":"jmcarp","id":1633460,"node_id":"MDQ6VXNlcjE2MzM0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1633460?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"repo":{"id":53240459,"node_id":"MDEwOlJlcG9zaXRvcnk1MzI0MDQ1OQ==","name":"airflow","full_name":"jmcarp/airflow","private":false,"owner":{"login":"jmcarp","id":1633460,"node_id":"MDQ6VXNlcjE2MzM0NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1633460?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcarp","html_url":"https://github.com/jmcarp","followers_url":"https://api.github.com/users/jmcarp/followers","following_url":"https://api.github.com/users/jmcarp/following{/other_user}","gists_url":"https://api.github.com/users/jmcarp/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcarp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcarp/subscriptions","organizations_url":"https://api.github.com/users/jmcarp/orgs","repos_url":"https://api.github.com/users/jmcarp/repos","events_url":"https://api.github.com/users/jmcarp/events{/privacy}","received_events_url":"https://api.github.com/users/jmcarp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmcarp/airflow","description":"Airflow is a system to programmatically author, schedule and monitor data pipelines.","fork":true,"url":"https://api.github.com/repos/jmcarp/airflow","forks_url":"https://api.github.com/repos/jmcarp/airflow/forks","keys_url":"https://api.github.com/repos/jmcarp/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcarp/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcarp/airflow/teams","hooks_url":"https://api.github.com/repos/jmcarp/airflow/hooks","issue_events_url":"https://api.github.com/repos/jmcarp/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/jmcarp/airflow/events","assignees_url":"https://api.github.com/repos/jmcarp/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/jmcarp/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/jmcarp/airflow/tags","blobs_url":"https://api.github.com/repos/jmcarp/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcarp/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcarp/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcarp/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcarp/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcarp/airflow/languages","stargazers_url":"https://api.github.com/repos/jmcarp/airflow/stargazers","contributors_url":"https://api.github.com/repos/jmcarp/airflow/contributors","subscribers_url":"https://api.github.com/repos/jmcarp/airflow/subscribers","subscription_url":"https://api.github.com/repos/jmcarp/airflow/subscription","commits_url":"https://api.github.com/repos/jmcarp/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcarp/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcarp/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcarp/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcarp/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/jmcarp/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcarp/airflow/merges","archive_url":"https://api.github.com/repos/jmcarp/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcarp/airflow/downloads","issues_url":"https://api.github.com/repos/jmcarp/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/jmcarp/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcarp/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcarp/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcarp/airflow/labels{/name}","releases_url":"https://api.github.com/repos/jmcarp/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/jmcarp/airflow/deployments","created_at":"2016-03-06T06:04:27Z","updated_at":"2018-08-18T15:04:25Z","pushed_at":"2019-04-18T04:09:49Z","git_url":"git://github.com/jmcarp/airflow.git","ssh_url":"git@github.com:jmcarp/airflow.git","clone_url":"https://github.com/jmcarp/airflow.git","svn_url":"https://github.com/jmcarp/airflow","homepage":"","size":30990,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a71d4b861302db6101a399db9ef562d716f3c26e","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":33884891,"node_id":"MDEwOlJlcG9zaXRvcnkzMzg4NDg5MQ==","name":"airflow","full_name":"apache/airflow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/airflow","description":"Apache Airflow","fork":false,"url":"https://api.github.com/repos/apache/airflow","forks_url":"https://api.github.com/repos/apache/airflow/forks","keys_url":"https://api.github.com/repos/apache/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/airflow/teams","hooks_url":"https://api.github.com/repos/apache/airflow/hooks","issue_events_url":"https://api.github.com/repos/apache/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/airflow/events","assignees_url":"https://api.github.com/repos/apache/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/airflow/tags","blobs_url":"https://api.github.com/repos/apache/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/airflow/languages","stargazers_url":"https://api.github.com/repos/apache/airflow/stargazers","contributors_url":"https://api.github.com/repos/apache/airflow/contributors","subscribers_url":"https://api.github.com/repos/apache/airflow/subscribers","subscription_url":"https://api.github.com/repos/apache/airflow/subscription","commits_url":"https://api.github.com/repos/apache/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/airflow/merges","archive_url":"https://api.github.com/repos/apache/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/airflow/downloads","issues_url":"https://api.github.com/repos/apache/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/airflow/labels{/name}","releases_url":"https://api.github.com/repos/apache/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/airflow/deployments","created_at":"2015-04-13T18:04:58Z","updated_at":"2019-04-18T02:26:42Z","pushed_at":"2019-04-18T04:09:53Z","git_url":"git://github.com/apache/airflow.git","ssh_url":"git@github.com:apache/airflow.git","clone_url":"https://github.com/apache/airflow.git","svn_url":"https://github.com/apache/airflow","homepage":"https://airflow.apache.org","size":35256,"stargazers_count":11864,"watchers_count":11864,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4250,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":298,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4250,"open_issues":298,"watchers":11864,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/airflow/pulls/4821"},"html":{"href":"https://github.com/apache/airflow/pull/4821"},"issue":{"href":"https://api.github.com/repos/apache/airflow/issues/4821"},"comments":{"href":"https://api.github.com/repos/apache/airflow/issues/4821/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/airflow/pulls/4821/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/airflow/pulls/4821/commits"},"statuses":{"href":"https://api.github.com/repos/apache/airflow/statuses/c723d9a86593e4f9e6588c65197375cb780a4f8d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 33884891,
"name": "apache/airflow",
"url": "https://api.github.com/repos/apache/airflow"
}
|
{
"id": 1633460,
"login": "jmcarp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1633460?",
"url": "https://api.github.com/users/jmcarp"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-04-18T04:10:34 |
9466373550
|
{"actor":{"display_login":"jmcarp"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/metron/pulls/comments/286716947","pull_request_review_id":240916328,"id":286716947,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjcxNjk0Nw==","diff_hunk":"@@ -0,0 +1,113 @@\n+/**\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.metron.enrichment.cache;\n+\n+import org.apache.commons.io.IOUtils;\n+import org.apache.hadoop.conf.Configuration;\n+import org.apache.hadoop.fs.FileSystem;\n+import org.apache.hadoop.fs.Path;\n+import org.apache.metron.common.utils.SerDeUtils;\n+import org.junit.Assert;\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.rules.ExpectedException;\n+\n+import java.io.BufferedOutputStream;\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+\n+public class ObjectCacheTest {\n+\n+ @Rule\n+ public ExpectedException thrown = ExpectedException.none();\n+\n+ FileSystem fs;\n+ List<String> data;\n+ ObjectCache cache;\n+\n+ @Before\n+ public void setup() throws IOException {\n+ fs = FileSystem.get(new Configuration());\n+ data = new ArrayList<>();\n+ {\n+ data.add(\"apache\");\n+ data.add(\"metron\");\n+ data.add(\"is\");\n+ data.add(\"great\");\n+ }\n+ cache = new ObjectCache();\n+ }\n+\n+ @Test\n+ public void test() throws Exception {\n+ String filename = \"target/ogt/test.ser\";\n+ Assert.assertTrue(cache.getCache() == null || !cache.getCache().asMap().containsKey(filename));\n+ assertDataIsReadCorrectly(filename);\n+ }\n+\n+ public void assertDataIsReadCorrectly(String filename) throws IOException {\n+ try(BufferedOutputStream bos = new BufferedOutputStream(fs.create(new Path(filename), true))) {\n+ IOUtils.write(SerDeUtils.toBytes(data), bos);\n+ }\n+ cache.initialize(ObjectCacheConfig.fromGlobalConfig(new HashMap<>()));","path":"metron-platform/metron-enrichment/metron-enrichment-common/src/test/java/org/apache/metron/enrichment/cache/ObjectCacheTest.java","position":72,"original_position":72,"commit_id":"f1e47c605368b2f0277476b9e0b85dce261a88f6","original_commit_id":"f1e47c605368b2f0277476b9e0b85dce261a88f6","user":{"login":"merrimanr","id":311928,"node_id":"MDQ6VXNlcjMxMTkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/311928?v=4","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"body":"You're right. The no arg constructor doesn't really serve any purpose. I will change `fromGlobalConfig` to a constructor (should have done this in the first place).\r\n\r\nThe NPE comes from Caffeine code. As long as we're not passing in null values to the cache builder it's not an issue. ","created_at":"2019-05-22T22:45:39Z","updated_at":"2019-05-22T22:45:39Z","html_url":"https://github.com/apache/metron/pull/1399#discussion_r286716947","pull_request_url":"https://api.github.com/repos/apache/metron/pulls/1399","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/comments/286716947"},"html":{"href":"https://github.com/apache/metron/pull/1399#discussion_r286716947"},"pull_request":{"href":"https://api.github.com/repos/apache/metron/pulls/1399"}},"in_reply_to_id":286657195},"pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/1399","id":275824933,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1ODI0OTMz","html_url":"https://github.com/apache/metron/pull/1399","diff_url":"https://github.com/apache/metron/pull/1399.diff","patch_url":"https://github.com/apache/metron/pull/1399.patch","issue_url":"https://api.github.com/repos/apache/metron/issues/1399","number":1399,"state":"open","locked":false,"title":"METRON-2073: Create in-memory use case for enrichment with map type and flatfile summarizer","user":{"login":"merrimanr","id":311928,"node_id":"MDQ6VXNlcjMxMTkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/311928?v=4","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"body":"## Contributor Comments\r\nThis PR adds a Stellar function for performing in-memory enrichments. Similar to `ENRICHMENT_GET`, which performs lookups in HBase, this function performs lookups from an in-memory map that is loaded from HDFS. The `nosql_table`, `enrichment_type`, and `column_family` parameters in `ENRICHMENT_GET` are similar to the `ENRICHMENT_IN_MEMORY_GET` `path` parameter in that they uniquely identify the data source. The `indicator` parameter is the same (the key used to lookup an enrichment). The new function is very similar to the `OBJECT_GET` function (they use the same cache abstraction) except that it performs the lookup, offers configuration specifically for in-memory enrichments, and potentially more. The in-memory objects are lazy-loaded, meaning they are loaded the first time an `ENRICHMENT_IN_MEMORY_GET` is executed.\r\n\r\nThe Jira states the first pass should be a 1-time load but it wasn't difficult to expose cache expiration settings. This allows cached enrichments to be refreshed at an interval and will support streaming enrichments. \r\n\r\nCache settings are applied in the following order:\r\n\r\n1. Hardcoded defaults defined in constants\r\n2. Top-level global config settings (used by the `OBJECT_GET` function)\r\n3. Global config settings specific for `ENRICHMENT_IN_MEMORY_GET`\r\n\r\nThese settings are passed into the Guava `CacheBuilder` when the function is initialized. \r\n\r\n### Changes Included\r\n\r\n- An `ObjectCache` abstraction was created from the code in the Stellar `OBJECT_GET` function. This abstraction is shared by both the `OBJECT_GET` and `ENRICHMENT_IN_MEMORY_GET` functions. The current settings used in `OBJECT_GET` should be backwards compatible.\r\n- Dedicated cache settings for `ENRICHMENT_IN_MEMORY_GET` can be configured in the global config with the `in.memory.enrichment.settings` key. \r\n- Unit tests were added for new code and expanded for existing code.\r\n- Logging was added in various places to make it easier to determine when entries are being flushed and for what reason.\r\n\r\n### Testing Instructions\r\nThis has been tested in full dev with the Stellar CLI.\r\n\r\n1. Spin up full dev and ensure data is flowing with no errors.\r\n2. Create a `enrichments.csv` file with enrichment data:\r\n```\r\nkey,value\r\n```\r\n3. Create a `enrichments_updated.csv` file with updated enrichment data:\r\n```\r\nkey,updated value\r\n```\r\n4. Create a `summarizer.json` file that will serialize this data as a map in HDFS:\r\n```\r\n{\r\n \"config\" : {\r\n \"columns\" : {\r\n \"key\" : 0,\r\n \"value\" : 1\r\n },\r\n \"state_init\" : \"{}\",\r\n \"state_update\" : {\r\n \"state\" : \"MAP_PUT(key, value, state)\"\r\n },\r\n \"separator\" : \",\"\r\n },\r\n \"extractor\" : \"CSV\"\r\n}\r\n```\r\n5. Use the `flatfile_summarizer.sh` script to create serialized files:\r\n```\r\n/usr/metron/0.7.1/bin/flatfile_summarizer.sh -i ./enrichments.csv -o ./enrichments.ser -e summarizer.json -p 1\r\n/usr/metron/0.7.1/bin/flatfile_summarizer.sh -i ./enrichments_updated.csv -o ./enrichments_updated.ser -e summarizer.json -p 1\r\n```\r\n6. Put the first file in HDFS:\r\n```\r\nhdfs dfs -put enrichments.ser /tmp/enrichments.ser\r\n```\r\n7. Start the Stellar shell and define a field we can use for the enrichments:\r\n```\r\n[root@node1 tmp]# /usr/metron/0.7.1/bin/stellar --zookeeper node1:2181\r\nSLF4J: Class path contains multiple SLF4J bindings.\r\nSLF4J: Found binding in [jar:file:/usr/metron/0.7.1/lib/metron-profiler-repl-0.7.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]\r\nSLF4J: Found binding in [jar:file:/usr/hdp/2.6.5.1050-37/hadoop/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]\r\nSLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.\r\nSLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]\r\nStellar, Go!\r\nFunctions are loading lazily in the background and will be unavailable until loaded fully.\r\n{es.clustername=metron, es.ip=node1:9200, es.date.format=yyyy.MM.dd.HH, parser.error.topic=indexing, update.hbase.table=metron_update, update.hbase.cf=t, es.client.settings={}, profiler.client.period.duration=15, profiler.client.period.duration.units=MINUTES, enrichment.list.hbase.provider.impl=org.apache.metron.hbase.HTableProvider, enrichment.list.hbase.table=enrichment_list, enrichment.list.hbase.cf=t, user.settings.hbase.table=user_settings, user.settings.hbase.cf=cf, bootstrap.servers=node1:6667, source.type.field=source:type, threat.triage.score.field=threat:triage:score, enrichment.writer.batchSize=15, enrichment.writer.batchTimeout=0, profiler.writer.batchSize=15, profiler.writer.batchTimeout=0, geo.hdfs.file=/apps/metron/geo/default/GeoLite2-City.tar.gz, asn.hdfs.file=/apps/metron/asn/default/GeoLite2-ASN.tar.gz, object.cache.expiration.minutes=1, in.memory.enrichment.settings={cache.expiration=15, time.unit=SECONDS}}\r\n[Stellar]>>> field := 'key'\r\nkey\r\n```\r\n7. Perform an in-memory enrichment. There should be a slight delay (for the initial load) but subsequent calls should return immediately:\r\n```\r\n[Stellar]>>> ENRICHMENT_IN_MEMORY_GET('/tmp/enrichments.ser', field)\r\nvalue\r\n```\r\n8. The default cache expiration is 24 hours. Exit the Stellar CLI and set the object cache expiration to 1 minutes in the global config:\r\n```\r\ncurl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{\r\n ...\r\n \"object.cache.expiration.minutes\": 1\r\n}' 'http://user:password@node1:8082/api/v1/global/config'\r\n```\r\nNote the `object.cache.expiration.minutes` setting is maintained for backwards compatibility. You can also set the expiration to 1 minute with these settings:\r\n```\r\n{\r\n \"object.cache.expiration\": 1,\r\n \"object.cache.time.unit\": \"MINUTES\"\r\n}\r\n```\r\n9. Start the Stellar CLI again and perform the enrichment again. You should get the same result:\r\n```\r\n[root@node1 tmp]# /usr/metron/0.7.1/bin/stellar --zookeeper node1:2181\r\nSLF4J: Class path contains multiple SLF4J bindings.\r\nSLF4J: Found binding in [jar:file:/usr/metron/0.7.1/lib/metron-profiler-repl-0.7.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]\r\nSLF4J: Found binding in [jar:file:/usr/hdp/2.6.5.1050-37/hadoop/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]\r\nSLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.\r\nSLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]\r\nStellar, Go!\r\nFunctions are loading lazily in the background and will be unavailable until loaded fully.\r\n{es.clustername=metron, es.ip=node1:9200, es.date.format=yyyy.MM.dd.HH, parser.error.topic=indexing, update.hbase.table=metron_update, update.hbase.cf=t, es.client.settings={}, profiler.client.period.duration=15, profiler.client.period.duration.units=MINUTES, enrichment.list.hbase.provider.impl=org.apache.metron.hbase.HTableProvider, enrichment.list.hbase.table=enrichment_list, enrichment.list.hbase.cf=t, user.settings.hbase.table=user_settings, user.settings.hbase.cf=cf, bootstrap.servers=node1:6667, source.type.field=source:type, threat.triage.score.field=threat:triage:score, enrichment.writer.batchSize=15, enrichment.writer.batchTimeout=0, profiler.writer.batchSize=15, profiler.writer.batchTimeout=0, geo.hdfs.file=/apps/metron/geo/default/GeoLite2-City.tar.gz, asn.hdfs.file=/apps/metron/asn/default/GeoLite2-ASN.tar.gz, object.cache.expiration.minutes=1, in.memory.enrichment.settings={cache.expiration=15, time.unit=SECONDS}}\r\n[Stellar]>>> field := 'key'\r\nkey\r\n[Stellar]>>> ENRICHMENT_IN_MEMORY_GET('/tmp/enrichments.ser', field)\r\nvalue\r\n```\r\n10. In a separate window, upload the updated enrichment file to HDFS:\r\n```\r\nhdfs dfs -put -f /tmp/enrichments_updated.ser /tmp/enrichments.ser\r\n```\r\n11. After a minute the value should change to the value in `enrichments_updated.ser`:\r\n```\r\n[Stellar]>>> ENRICHMENT_IN_MEMORY_GET('/tmp/enrichments.ser', field)\r\nupdated value\r\n```\r\n12. The cache expiration can also be set specifically for `ENRICHMENT_IN_MEMORY_GET`. Put the previous `enrichments.ser` back in HDFS and change the cache settings to 15 seconds:\r\n```\r\ncurl -X POST --header 'Content-Type: application/json' --header 'Accept: application/json' -d '{\r\n ...\r\n \"object.cache.expiration.minutes\": 1,\r\n \"in.memory.enrichment.settings\": {\r\n \"cache.expiration\": 15,\r\n \"time.unit\": \"SECONDS\"\r\n }\r\n}' 'http://user:password@node1:8082/api/v1/global/config'\r\n```\r\n13. Perform steps 9 - 11. Now the value should be updated after 15 seconds.\r\n\r\n### Next Steps\r\nThis is intended to be a first pass and there are still some outstanding items. I am planning on adding javadocs and a section in our READMEs describing how to do in-memory enrichments. \r\n\r\nAre there other features people would like to see added here? I think it could be useful to set cache settings for each object in HDFS (currently they are global to all objects and can only be changed on initialization). This would make things more complex and require some design work.\r\n\r\nDoes anyone have suggestions for more appropriate function and setting names?\r\n\r\nWhat else would you change about this?\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron. \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).\r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [x] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:\r\n ```\r\n mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh \r\n ```\r\n\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n ```\r\n cd site-book\r\n mvn site\r\n ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n","created_at":"2019-05-03T19:32:52Z","updated_at":"2019-05-22T22:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da913cf15fa7435810340aa25b3b0c3615ffea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/metron/pulls/1399/commits","review_comments_url":"https://api.github.com/repos/apache/metron/pulls/1399/comments","review_comment_url":"https://api.github.com/repos/apache/metron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/metron/issues/1399/comments","statuses_url":"https://api.github.com/repos/apache/metron/statuses/f1e47c605368b2f0277476b9e0b85dce261a88f6","head":{"label":"merrimanr:METRON-2073","ref":"METRON-2073","sha":"f1e47c605368b2f0277476b9e0b85dce261a88f6","user":{"login":"merrimanr","id":311928,"node_id":"MDQ6VXNlcjMxMTkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/311928?v=4","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"repo":{"id":62420865,"node_id":"MDEwOlJlcG9zaXRvcnk2MjQyMDg2NQ==","name":"incubator-metron","full_name":"merrimanr/incubator-metron","private":false,"owner":{"login":"merrimanr","id":311928,"node_id":"MDQ6VXNlcjMxMTkyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/311928?v=4","gravatar_id":"","url":"https://api.github.com/users/merrimanr","html_url":"https://github.com/merrimanr","followers_url":"https://api.github.com/users/merrimanr/followers","following_url":"https://api.github.com/users/merrimanr/following{/other_user}","gists_url":"https://api.github.com/users/merrimanr/gists{/gist_id}","starred_url":"https://api.github.com/users/merrimanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merrimanr/subscriptions","organizations_url":"https://api.github.com/users/merrimanr/orgs","repos_url":"https://api.github.com/users/merrimanr/repos","events_url":"https://api.github.com/users/merrimanr/events{/privacy}","received_events_url":"https://api.github.com/users/merrimanr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/merrimanr/incubator-metron","description":"Mirror of Apache Metron (Incubating)","fork":true,"url":"https://api.github.com/repos/merrimanr/incubator-metron","forks_url":"https://api.github.com/repos/merrimanr/incubator-metron/forks","keys_url":"https://api.github.com/repos/merrimanr/incubator-metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/merrimanr/incubator-metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/merrimanr/incubator-metron/teams","hooks_url":"https://api.github.com/repos/merrimanr/incubator-metron/hooks","issue_events_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues/events{/number}","events_url":"https://api.github.com/repos/merrimanr/incubator-metron/events","assignees_url":"https://api.github.com/repos/merrimanr/incubator-metron/assignees{/user}","branches_url":"https://api.github.com/repos/merrimanr/incubator-metron/branches{/branch}","tags_url":"https://api.github.com/repos/merrimanr/incubator-metron/tags","blobs_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/merrimanr/incubator-metron/statuses/{sha}","languages_url":"https://api.github.com/repos/merrimanr/incubator-metron/languages","stargazers_url":"https://api.github.com/repos/merrimanr/incubator-metron/stargazers","contributors_url":"https://api.github.com/repos/merrimanr/incubator-metron/contributors","subscribers_url":"https://api.github.com/repos/merrimanr/incubator-metron/subscribers","subscription_url":"https://api.github.com/repos/merrimanr/incubator-metron/subscription","commits_url":"https://api.github.com/repos/merrimanr/incubator-metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/merrimanr/incubator-metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/merrimanr/incubator-metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/merrimanr/incubator-metron/contents/{+path}","compare_url":"https://api.github.com/repos/merrimanr/incubator-metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/merrimanr/incubator-metron/merges","archive_url":"https://api.github.com/repos/merrimanr/incubator-metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/merrimanr/incubator-metron/downloads","issues_url":"https://api.github.com/repos/merrimanr/incubator-metron/issues{/number}","pulls_url":"https://api.github.com/repos/merrimanr/incubator-metron/pulls{/number}","milestones_url":"https://api.github.com/repos/merrimanr/incubator-metron/milestones{/number}","notifications_url":"https://api.github.com/repos/merrimanr/incubator-metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/merrimanr/incubator-metron/labels{/name}","releases_url":"https://api.github.com/repos/merrimanr/incubator-metron/releases{/id}","deployments_url":"https://api.github.com/repos/merrimanr/incubator-metron/deployments","created_at":"2016-07-01T21:33:17Z","updated_at":"2018-11-14T16:20:57Z","pushed_at":"2019-05-21T17:15:31Z","git_url":"git://github.com/merrimanr/incubator-metron.git","ssh_url":"git@github.com:merrimanr/incubator-metron.git","clone_url":"https://github.com/merrimanr/incubator-metron.git","svn_url":"https://github.com/merrimanr/incubator-metron","homepage":null,"size":98674,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f3f5c9743f515d8902b4580c765ad9d2b64aa63b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47607561,"node_id":"MDEwOlJlcG9zaXRvcnk0NzYwNzU2MQ==","name":"metron","full_name":"apache/metron","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/metron","description":"Apache Metron","fork":false,"url":"https://api.github.com/repos/apache/metron","forks_url":"https://api.github.com/repos/apache/metron/forks","keys_url":"https://api.github.com/repos/apache/metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/metron/teams","hooks_url":"https://api.github.com/repos/apache/metron/hooks","issue_events_url":"https://api.github.com/repos/apache/metron/issues/events{/number}","events_url":"https://api.github.com/repos/apache/metron/events","assignees_url":"https://api.github.com/repos/apache/metron/assignees{/user}","branches_url":"https://api.github.com/repos/apache/metron/branches{/branch}","tags_url":"https://api.github.com/repos/apache/metron/tags","blobs_url":"https://api.github.com/repos/apache/metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/metron/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/metron/languages","stargazers_url":"https://api.github.com/repos/apache/metron/stargazers","contributors_url":"https://api.github.com/repos/apache/metron/contributors","subscribers_url":"https://api.github.com/repos/apache/metron/subscribers","subscription_url":"https://api.github.com/repos/apache/metron/subscription","commits_url":"https://api.github.com/repos/apache/metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/metron/contents/{+path}","compare_url":"https://api.github.com/repos/apache/metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/metron/merges","archive_url":"https://api.github.com/repos/apache/metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/metron/downloads","issues_url":"https://api.github.com/repos/apache/metron/issues{/number}","pulls_url":"https://api.github.com/repos/apache/metron/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/metron/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/metron/labels{/name}","releases_url":"https://api.github.com/repos/apache/metron/releases{/id}","deployments_url":"https://api.github.com/repos/apache/metron/deployments","created_at":"2015-12-08T08:00:05Z","updated_at":"2019-05-22T19:31:13Z","pushed_at":"2019-05-22T19:31:06Z","git_url":"git://github.com/apache/metron.git","ssh_url":"git@github.com:apache/metron.git","clone_url":"https://github.com/apache/metron.git","svn_url":"https://github.com/apache/metron","homepage":"","size":94961,"stargazers_count":627,"watchers_count":627,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":436,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":436,"open_issues":33,"watchers":627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/1399"},"html":{"href":"https://github.com/apache/metron/pull/1399"},"issue":{"href":"https://api.github.com/repos/apache/metron/issues/1399"},"comments":{"href":"https://api.github.com/repos/apache/metron/issues/1399/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/metron/pulls/1399/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/metron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/metron/pulls/1399/commits"},"statuses":{"href":"https://api.github.com/repos/apache/metron/statuses/f1e47c605368b2f0277476b9e0b85dce261a88f6"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 47607561,
"name": "apache/metron",
"url": "https://api.github.com/repos/apache/metron"
}
|
{
"id": 311928,
"login": "merrimanr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/311928?",
"url": "https://api.github.com/users/merrimanr"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-05-22T22:45:39 |
9679767182
|
{"actor":{"display_login":"merrimanr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/289584046","pull_request_review_id":244562657,"id":289584046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTU4NDA0Ng==","diff_hunk":"@@ -0,0 +1,81 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.scheduler\n+\n+import scala.collection.mutable.ArrayBuffer\n+\n+/**\n+ * Class to hold information about a type of Resource on an Executor. This information is managed\n+ * by SchedulerBackend, and TaskScheduler shall schedule tasks on idle Executors based on the\n+ * information.\n+ */\n+private[spark] class ExecutorResourceInfo(\n+ private val name: String,\n+ private[scheduler] val addresses: ArrayBuffer[String]) extends Serializable {\n+\n+ // Addresses of resource that has not been acquired.\n+ // Exposed for testing only.\n+ private[scheduler] var idleAddresses: ArrayBuffer[String] = addresses.clone()\n+\n+ // Addresses of resource that has been assigned to running tasks.\n+ // Exposed for testing only.\n+ private[scheduler] val allocatedAddresses: ArrayBuffer[String] = ArrayBuffer.empty\n+\n+ def getName(): String = name","path":"core/src/main/scala/org/apache/spark/scheduler/ExecutorResourceInfo.scala","position":null,"original_position":39,"commit_id":"d15a51d37e4bfd29230253a88defcdc6d0f2ef26","original_commit_id":"a3c1db51da4e6f426aa978faff9449f331f56dec","user":{"login":"jiangxb1987","id":4784782,"node_id":"MDQ6VXNlcjQ3ODQ3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/4784782?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"body":"updated","created_at":"2019-06-01T00:33:11Z","updated_at":"2019-06-01T00:33:11Z","html_url":"https://github.com/apache/spark/pull/24374#discussion_r289584046","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/24374","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/289584046"},"html":{"href":"https://github.com/apache/spark/pull/24374#discussion_r289584046"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/24374"}},"in_reply_to_id":289455670},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/24374","id":270503900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNTAzOTAw","html_url":"https://github.com/apache/spark/pull/24374","diff_url":"https://github.com/apache/spark/pull/24374.diff","patch_url":"https://github.com/apache/spark/pull/24374.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/24374","number":24374,"state":"open","locked":false,"title":"[SPARK-27366][CORE] Support GPU Resources in Spark job scheduling","user":{"login":"jiangxb1987","id":4784782,"node_id":"MDQ6VXNlcjQ3ODQ3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/4784782?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR adds support to schedule tasks with extra resource requirements (eg. GPUs) on executors with available resources. It also introduce a new method `TaskContext.resources()` so tasks can access available resource addresses allocated to them.\r\n\r\n## How was this patch tested?\r\n\r\n* Added new end-to-end test cases in `SparkContextSuite`;\r\n* Added new test case in `CoarseGrainedSchedulerBackendSuite`;\r\n* Added new test case in `CoarseGrainedExecutorBackendSuite`;\r\n* Added new test case in `TaskSchedulerImplSuite`;\r\n* Added new test case in `TaskSetManagerSuite`;\r\n* Updated existing tests.","created_at":"2019-04-15T12:54:21Z","updated_at":"2019-06-01T00:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1723c48b541f06bd3eb27bcb4c246afd8ab5c107","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/24374/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/24374/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/24374/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/d15a51d37e4bfd29230253a88defcdc6d0f2ef26","head":{"label":"jiangxb1987:gpu","ref":"gpu","sha":"d15a51d37e4bfd29230253a88defcdc6d0f2ef26","user":{"login":"jiangxb1987","id":4784782,"node_id":"MDQ6VXNlcjQ3ODQ3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/4784782?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"repo":{"id":35214686,"node_id":"MDEwOlJlcG9zaXRvcnkzNTIxNDY4Ng==","name":"spark","full_name":"jiangxb1987/spark","private":false,"owner":{"login":"jiangxb1987","id":4784782,"node_id":"MDQ6VXNlcjQ3ODQ3ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/4784782?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jiangxb1987/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/jiangxb1987/spark","forks_url":"https://api.github.com/repos/jiangxb1987/spark/forks","keys_url":"https://api.github.com/repos/jiangxb1987/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiangxb1987/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiangxb1987/spark/teams","hooks_url":"https://api.github.com/repos/jiangxb1987/spark/hooks","issue_events_url":"https://api.github.com/repos/jiangxb1987/spark/issues/events{/number}","events_url":"https://api.github.com/repos/jiangxb1987/spark/events","assignees_url":"https://api.github.com/repos/jiangxb1987/spark/assignees{/user}","branches_url":"https://api.github.com/repos/jiangxb1987/spark/branches{/branch}","tags_url":"https://api.github.com/repos/jiangxb1987/spark/tags","blobs_url":"https://api.github.com/repos/jiangxb1987/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiangxb1987/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiangxb1987/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiangxb1987/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiangxb1987/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/jiangxb1987/spark/languages","stargazers_url":"https://api.github.com/repos/jiangxb1987/spark/stargazers","contributors_url":"https://api.github.com/repos/jiangxb1987/spark/contributors","subscribers_url":"https://api.github.com/repos/jiangxb1987/spark/subscribers","subscription_url":"https://api.github.com/repos/jiangxb1987/spark/subscription","commits_url":"https://api.github.com/repos/jiangxb1987/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiangxb1987/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiangxb1987/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiangxb1987/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiangxb1987/spark/contents/{+path}","compare_url":"https://api.github.com/repos/jiangxb1987/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiangxb1987/spark/merges","archive_url":"https://api.github.com/repos/jiangxb1987/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiangxb1987/spark/downloads","issues_url":"https://api.github.com/repos/jiangxb1987/spark/issues{/number}","pulls_url":"https://api.github.com/repos/jiangxb1987/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/jiangxb1987/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/jiangxb1987/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiangxb1987/spark/labels{/name}","releases_url":"https://api.github.com/repos/jiangxb1987/spark/releases{/id}","deployments_url":"https://api.github.com/repos/jiangxb1987/spark/deployments","created_at":"2015-05-07T10:48:35Z","updated_at":"2019-05-02T22:37:07Z","pushed_at":"2019-06-01T00:32:08Z","git_url":"git://github.com/jiangxb1987/spark.git","ssh_url":"git@github.com:jiangxb1987/spark.git","clone_url":"https://github.com/jiangxb1987/spark.git","svn_url":"https://github.com/jiangxb1987/spark","homepage":null,"size":285107,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f94247ec9072e0e417bf7585af1a74e93511b3c5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2019-05-31T23:31:00Z","pushed_at":"2019-06-01T00:32:13Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":"","size":298396,"stargazers_count":22066,"watchers_count":22066,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19092,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":484,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19092,"open_issues":484,"watchers":22066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/24374"},"html":{"href":"https://github.com/apache/spark/pull/24374"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/24374"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/24374/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/24374/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/24374/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/d15a51d37e4bfd29230253a88defcdc6d0f2ef26"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
}
|
{
"id": 4784782,
"login": "jiangxb1987",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4784782?",
"url": "https://api.github.com/users/jiangxb1987"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-06-01T00:33:11 |
9738379712
|
{"actor":{"display_login":"jiangxb1987"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/hbase/pulls/comments/328926322","pull_request_review_id":294130325,"id":328926322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODkyNjMyMg==","diff_hunk":"@@ -2254,4 +2256,70 @@ boolean snapshotCleanupSwitch(final boolean on, final boolean synchronous)\n */\n boolean isSnapshotCleanupEnabled() throws IOException;\n \n+ /**\n+ * Gets group info for the given group name\n+ * @param groupName the group name\n+ * @return group info\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ RSGroupInfo getRSGroupInfo(String groupName) throws IOException;\n+\n+ /**\n+ * Move given set of servers to the specified target RegionServer group\n+ * @param servers set of servers to move\n+ * @param targetGroup the group to move servers to\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ void moveServers(Set<Address> servers, String targetGroup) throws IOException;\n+\n+ /**\n+ * Creates a new RegionServer group with the given name\n+ * @param groupName the name of the group\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ void addRSGroup(String groupName) throws IOException;\n+\n+ /**\n+ * Removes RegionServer group associated with the given name\n+ * @param groupName the group name\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ void removeRSGroup(String groupName) throws IOException;\n+\n+ /**\n+ * Balance regions in the given RegionServer group\n+ * @param groupName the group name\n+ * @return boolean Whether balance ran or not\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ boolean balanceRSGroup(String groupName) throws IOException;\n+\n+ /**\n+ * Lists current set of RegionServer groups\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ List<RSGroupInfo> listRSGroups() throws IOException;\n+\n+ /**\n+ * Retrieve the RSGroupInfo a server is affiliated to\n+ * @param hostPort HostPort to get RSGroupInfo for\n+ * @throws IOException if a remote or network exception occurs\n+ */\n+ RSGroupInfo getRSGroupOfServer(Address hostPort) throws IOException;","path":"hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java","position":69,"original_position":69,"commit_id":"90f725349dd4127d21c416e28faf418237528b16","original_commit_id":"90f725349dd4127d21c416e28faf418237528b16","user":{"login":"sunhelly","id":10123703,"node_id":"MDQ6VXNlcjEwMTIzNzAz","avatar_url":"https://avatars2.githubusercontent.com/u/10123703?v=4","gravatar_id":"","url":"https://api.github.com/users/sunhelly","html_url":"https://github.com/sunhelly","followers_url":"https://api.github.com/users/sunhelly/followers","following_url":"https://api.github.com/users/sunhelly/following{/other_user}","gists_url":"https://api.github.com/users/sunhelly/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhelly/subscriptions","organizations_url":"https://api.github.com/users/sunhelly/orgs","repos_url":"https://api.github.com/users/sunhelly/repos","events_url":"https://api.github.com/users/sunhelly/events{/privacy}","received_events_url":"https://api.github.com/users/sunhelly/received_events","type":"User","site_admin":false},"body":"OK. Thanks.","created_at":"2019-09-27T06:17:09Z","updated_at":"2019-09-27T06:17:09Z","html_url":"https://github.com/apache/hbase/pull/657#discussion_r328926322","pull_request_url":"https://api.github.com/repos/apache/hbase/pulls/657","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/hbase/pulls/comments/328926322"},"html":{"href":"https://github.com/apache/hbase/pull/657#discussion_r328926322"},"pull_request":{"href":"https://api.github.com/repos/apache/hbase/pulls/657"}},"in_reply_to_id":328711777},"pull_request":{"url":"https://api.github.com/repos/apache/hbase/pulls/657","id":320628503,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwNjI4NTAz","html_url":"https://github.com/apache/hbase/pull/657","diff_url":"https://github.com/apache/hbase/pull/657.diff","patch_url":"https://github.com/apache/hbase/pull/657.patch","issue_url":"https://api.github.com/repos/apache/hbase/issues/657","number":657,"state":"open","locked":false,"title":"Hbase 22932 Add rs group management methods in Admin and AsyncAdmin","user":{"login":"sunhelly","id":10123703,"node_id":"MDQ6VXNlcjEwMTIzNzAz","avatar_url":"https://avatars2.githubusercontent.com/u/10123703?v=4","gravatar_id":"","url":"https://api.github.com/users/sunhelly","html_url":"https://github.com/sunhelly","followers_url":"https://api.github.com/users/sunhelly/followers","following_url":"https://api.github.com/users/sunhelly/following{/other_user}","gists_url":"https://api.github.com/users/sunhelly/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhelly/subscriptions","organizations_url":"https://api.github.com/users/sunhelly/orgs","repos_url":"https://api.github.com/users/sunhelly/repos","events_url":"https://api.github.com/users/sunhelly/events{/privacy}","received_events_url":"https://api.github.com/users/sunhelly/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-09-24T07:39:07Z","updated_at":"2019-09-27T06:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b4298ada08034702ff78d182a31a879331372ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/hbase/pulls/657/commits","review_comments_url":"https://api.github.com/repos/apache/hbase/pulls/657/comments","review_comment_url":"https://api.github.com/repos/apache/hbase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/hbase/issues/657/comments","statuses_url":"https://api.github.com/repos/apache/hbase/statuses/90f725349dd4127d21c416e28faf418237528b16","head":{"label":"sunhelly:HBASE-22932","ref":"HBASE-22932","sha":"90f725349dd4127d21c416e28faf418237528b16","user":{"login":"sunhelly","id":10123703,"node_id":"MDQ6VXNlcjEwMTIzNzAz","avatar_url":"https://avatars2.githubusercontent.com/u/10123703?v=4","gravatar_id":"","url":"https://api.github.com/users/sunhelly","html_url":"https://github.com/sunhelly","followers_url":"https://api.github.com/users/sunhelly/followers","following_url":"https://api.github.com/users/sunhelly/following{/other_user}","gists_url":"https://api.github.com/users/sunhelly/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhelly/subscriptions","organizations_url":"https://api.github.com/users/sunhelly/orgs","repos_url":"https://api.github.com/users/sunhelly/repos","events_url":"https://api.github.com/users/sunhelly/events{/privacy}","received_events_url":"https://api.github.com/users/sunhelly/received_events","type":"User","site_admin":false},"repo":{"id":192639851,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI2Mzk4NTE=","name":"hbase","full_name":"sunhelly/hbase","private":false,"owner":{"login":"sunhelly","id":10123703,"node_id":"MDQ6VXNlcjEwMTIzNzAz","avatar_url":"https://avatars2.githubusercontent.com/u/10123703?v=4","gravatar_id":"","url":"https://api.github.com/users/sunhelly","html_url":"https://github.com/sunhelly","followers_url":"https://api.github.com/users/sunhelly/followers","following_url":"https://api.github.com/users/sunhelly/following{/other_user}","gists_url":"https://api.github.com/users/sunhelly/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhelly/subscriptions","organizations_url":"https://api.github.com/users/sunhelly/orgs","repos_url":"https://api.github.com/users/sunhelly/repos","events_url":"https://api.github.com/users/sunhelly/events{/privacy}","received_events_url":"https://api.github.com/users/sunhelly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sunhelly/hbase","description":"Mirror of Apache HBase","fork":true,"url":"https://api.github.com/repos/sunhelly/hbase","forks_url":"https://api.github.com/repos/sunhelly/hbase/forks","keys_url":"https://api.github.com/repos/sunhelly/hbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sunhelly/hbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sunhelly/hbase/teams","hooks_url":"https://api.github.com/repos/sunhelly/hbase/hooks","issue_events_url":"https://api.github.com/repos/sunhelly/hbase/issues/events{/number}","events_url":"https://api.github.com/repos/sunhelly/hbase/events","assignees_url":"https://api.github.com/repos/sunhelly/hbase/assignees{/user}","branches_url":"https://api.github.com/repos/sunhelly/hbase/branches{/branch}","tags_url":"https://api.github.com/repos/sunhelly/hbase/tags","blobs_url":"https://api.github.com/repos/sunhelly/hbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sunhelly/hbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sunhelly/hbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/sunhelly/hbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sunhelly/hbase/statuses/{sha}","languages_url":"https://api.github.com/repos/sunhelly/hbase/languages","stargazers_url":"https://api.github.com/repos/sunhelly/hbase/stargazers","contributors_url":"https://api.github.com/repos/sunhelly/hbase/contributors","subscribers_url":"https://api.github.com/repos/sunhelly/hbase/subscribers","subscription_url":"https://api.github.com/repos/sunhelly/hbase/subscription","commits_url":"https://api.github.com/repos/sunhelly/hbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/sunhelly/hbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/sunhelly/hbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/sunhelly/hbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/sunhelly/hbase/contents/{+path}","compare_url":"https://api.github.com/repos/sunhelly/hbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sunhelly/hbase/merges","archive_url":"https://api.github.com/repos/sunhelly/hbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sunhelly/hbase/downloads","issues_url":"https://api.github.com/repos/sunhelly/hbase/issues{/number}","pulls_url":"https://api.github.com/repos/sunhelly/hbase/pulls{/number}","milestones_url":"https://api.github.com/repos/sunhelly/hbase/milestones{/number}","notifications_url":"https://api.github.com/repos/sunhelly/hbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sunhelly/hbase/labels{/name}","releases_url":"https://api.github.com/repos/sunhelly/hbase/releases{/id}","deployments_url":"https://api.github.com/repos/sunhelly/hbase/deployments","created_at":"2019-06-19T01:55:27Z","updated_at":"2019-09-02T09:36:44Z","pushed_at":"2019-09-26T05:54:37Z","git_url":"git://github.com/sunhelly/hbase.git","ssh_url":"git@github.com:sunhelly/hbase.git","clone_url":"https://github.com/sunhelly/hbase.git","svn_url":"https://github.com/sunhelly/hbase","homepage":null,"size":377272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:HBASE-22514","ref":"HBASE-22514","sha":"9bcb64bbe74b6a3cf9afc1926553a82250eee5c2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20089857,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA4OTg1Nw==","name":"hbase","full_name":"apache/hbase","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/hbase","description":"Mirror of Apache HBase","fork":false,"url":"https://api.github.com/repos/apache/hbase","forks_url":"https://api.github.com/repos/apache/hbase/forks","keys_url":"https://api.github.com/repos/apache/hbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/hbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/hbase/teams","hooks_url":"https://api.github.com/repos/apache/hbase/hooks","issue_events_url":"https://api.github.com/repos/apache/hbase/issues/events{/number}","events_url":"https://api.github.com/repos/apache/hbase/events","assignees_url":"https://api.github.com/repos/apache/hbase/assignees{/user}","branches_url":"https://api.github.com/repos/apache/hbase/branches{/branch}","tags_url":"https://api.github.com/repos/apache/hbase/tags","blobs_url":"https://api.github.com/repos/apache/hbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/hbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/hbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/hbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/hbase/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/hbase/languages","stargazers_url":"https://api.github.com/repos/apache/hbase/stargazers","contributors_url":"https://api.github.com/repos/apache/hbase/contributors","subscribers_url":"https://api.github.com/repos/apache/hbase/subscribers","subscription_url":"https://api.github.com/repos/apache/hbase/subscription","commits_url":"https://api.github.com/repos/apache/hbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/hbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/hbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/hbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/hbase/contents/{+path}","compare_url":"https://api.github.com/repos/apache/hbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/hbase/merges","archive_url":"https://api.github.com/repos/apache/hbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/hbase/downloads","issues_url":"https://api.github.com/repos/apache/hbase/issues{/number}","pulls_url":"https://api.github.com/repos/apache/hbase/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/hbase/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/hbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/hbase/labels{/name}","releases_url":"https://api.github.com/repos/apache/hbase/releases{/id}","deployments_url":"https://api.github.com/repos/apache/hbase/deployments","created_at":"2014-05-23T07:00:07Z","updated_at":"2019-09-27T03:22:15Z","pushed_at":"2019-09-27T05:59:38Z","git_url":"git://github.com/apache/hbase.git","ssh_url":"git@github.com:apache/hbase.git","clone_url":"https://github.com/apache/hbase.git","svn_url":"https://github.com/apache/hbase","homepage":null,"size":378757,"stargazers_count":3121,"watchers_count":3121,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2139,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2139,"open_issues":25,"watchers":3121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/hbase/pulls/657"},"html":{"href":"https://github.com/apache/hbase/pull/657"},"issue":{"href":"https://api.github.com/repos/apache/hbase/issues/657"},"comments":{"href":"https://api.github.com/repos/apache/hbase/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/hbase/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/hbase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/hbase/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/apache/hbase/statuses/90f725349dd4127d21c416e28faf418237528b16"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20089857,
"name": "apache/hbase",
"url": "https://api.github.com/repos/apache/hbase"
}
|
{
"id": 10123703,
"login": "sunhelly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10123703?",
"url": "https://api.github.com/users/sunhelly"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-09-27T06:17:09 |
10507581271
|
{"actor":{"display_login":"sunhelly"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/skywalking/pulls/comments/344981354","pull_request_review_id":315248710,"id":344981354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDk4MTM1NA==","diff_hunk":"@@ -0,0 +1,41 @@\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache License, Version 2.0 (the\n+# \"License\"); you may not use this file except in compliance\n+# with the License. You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+name: istio-mixer-ci\n+\n+on: [push]","path":".github/workflows/istio-mixer-ci.yaml","position":19,"original_position":19,"commit_id":"dbe5457c0f6d8ee1e2851c9325923c4314146dd1","original_commit_id":"80d89f6671d24d7ab04c2852f3a310f87de27db6","user":{"login":"hanahmily","id":1960537,"node_id":"MDQ6VXNlcjE5NjA1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1960537?v=4","gravatar_id":"","url":"https://api.github.com/users/hanahmily","html_url":"https://github.com/hanahmily","followers_url":"https://api.github.com/users/hanahmily/followers","following_url":"https://api.github.com/users/hanahmily/following{/other_user}","gists_url":"https://api.github.com/users/hanahmily/gists{/gist_id}","starred_url":"https://api.github.com/users/hanahmily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanahmily/subscriptions","organizations_url":"https://api.github.com/users/hanahmily/orgs","repos_url":"https://api.github.com/users/hanahmily/repos","events_url":"https://api.github.com/users/hanahmily/events{/privacy}","received_events_url":"https://api.github.com/users/hanahmily/received_events","type":"User","site_admin":false},"body":"make sense, but I pick up `push` just for testing. Since `istio-ci` branch is a dev one, I want to leave it alone until it's been merged into master.","created_at":"2019-11-12T01:28:58Z","updated_at":"2019-11-12T01:28:59Z","html_url":"https://github.com/apache/skywalking/pull/3836#discussion_r344981354","pull_request_url":"https://api.github.com/repos/apache/skywalking/pulls/3836","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/skywalking/pulls/comments/344981354"},"html":{"href":"https://github.com/apache/skywalking/pull/3836#discussion_r344981354"},"pull_request":{"href":"https://api.github.com/repos/apache/skywalking/pulls/3836"}},"in_reply_to_id":344979769},"pull_request":{"url":"https://api.github.com/repos/apache/skywalking/pulls/3836","id":339523587,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5NTIzNTg3","html_url":"https://github.com/apache/skywalking/pull/3836","diff_url":"https://github.com/apache/skywalking/pull/3836.diff","patch_url":"https://github.com/apache/skywalking/pull/3836.patch","issue_url":"https://api.github.com/repos/apache/skywalking/issues/3836","number":3836,"state":"open","locked":false,"title":"Add minikube to CI","user":{"login":"hanahmily","id":1960537,"node_id":"MDQ6VXNlcjE5NjA1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1960537?v=4","gravatar_id":"","url":"https://api.github.com/users/hanahmily","html_url":"https://github.com/hanahmily","followers_url":"https://api.github.com/users/hanahmily/followers","following_url":"https://api.github.com/users/hanahmily/following{/other_user}","gists_url":"https://api.github.com/users/hanahmily/gists{/gist_id}","starred_url":"https://api.github.com/users/hanahmily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanahmily/subscriptions","organizations_url":"https://api.github.com/users/hanahmily/orgs","repos_url":"https://api.github.com/users/hanahmily/repos","events_url":"https://api.github.com/users/hanahmily/events{/privacy}","received_events_url":"https://api.github.com/users/hanahmily/received_events","type":"User","site_admin":false},"body":"Intend to solve some steps in #3771, including to start minikube and setup tunnel.","created_at":"2019-11-11T16:49:10Z","updated_at":"2019-11-12T01:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ced8ba84c067bafc0afac6c7624d5f60b1e6282","assignee":{"login":"hanahmily","id":1960537,"node_id":"MDQ6VXNlcjE5NjA1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1960537?v=4","gravatar_id":"","url":"https://api.github.com/users/hanahmily","html_url":"https://github.com/hanahmily","followers_url":"https://api.github.com/users/hanahmily/followers","following_url":"https://api.github.com/users/hanahmily/following{/other_user}","gists_url":"https://api.github.com/users/hanahmily/gists{/gist_id}","starred_url":"https://api.github.com/users/hanahmily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanahmily/subscriptions","organizations_url":"https://api.github.com/users/hanahmily/orgs","repos_url":"https://api.github.com/users/hanahmily/repos","events_url":"https://api.github.com/users/hanahmily/events{/privacy}","received_events_url":"https://api.github.com/users/hanahmily/received_events","type":"User","site_admin":false},"assignees":[{"login":"hanahmily","id":1960537,"node_id":"MDQ6VXNlcjE5NjA1Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1960537?v=4","gravatar_id":"","url":"https://api.github.com/users/hanahmily","html_url":"https://github.com/hanahmily","followers_url":"https://api.github.com/users/hanahmily/followers","following_url":"https://api.github.com/users/hanahmily/following{/other_user}","gists_url":"https://api.github.com/users/hanahmily/gists{/gist_id}","starred_url":"https://api.github.com/users/hanahmily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hanahmily/subscriptions","organizations_url":"https://api.github.com/users/hanahmily/orgs","repos_url":"https://api.github.com/users/hanahmily/repos","events_url":"https://api.github.com/users/hanahmily/events{/privacy}","received_events_url":"https://api.github.com/users/hanahmily/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kezhenxu94","id":15965696,"node_id":"MDQ6VXNlcjE1OTY1Njk2","avatar_url":"https://avatars3.githubusercontent.com/u/15965696?v=4","gravatar_id":"","url":"https://api.github.com/users/kezhenxu94","html_url":"https://github.com/kezhenxu94","followers_url":"https://api.github.com/users/kezhenxu94/followers","following_url":"https://api.github.com/users/kezhenxu94/following{/other_user}","gists_url":"https://api.github.com/users/kezhenxu94/gists{/gist_id}","starred_url":"https://api.github.com/users/kezhenxu94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kezhenxu94/subscriptions","organizations_url":"https://api.github.com/users/kezhenxu94/orgs","repos_url":"https://api.github.com/users/kezhenxu94/repos","events_url":"https://api.github.com/users/kezhenxu94/events{/privacy}","received_events_url":"https://api.github.com/users/kezhenxu94/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1570831071,"node_id":"MDU6TGFiZWwxNTcwODMxMDcx","url":"https://api.github.com/repos/apache/skywalking/labels/CI%20settings","name":"CI settings","color":"25d2db","default":false}],"milestone":{"url":"https://api.github.com/repos/apache/skywalking/milestones/37","html_url":"https://github.com/apache/skywalking/milestone/37","labels_url":"https://api.github.com/repos/apache/skywalking/milestones/37/labels","id":4746738,"node_id":"MDk6TWlsZXN0b25lNDc0NjczOA==","number":37,"title":"6.6.0","description":"","creator":{"login":"wu-sheng","id":5441976,"node_id":"MDQ6VXNlcjU0NDE5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5441976?v=4","gravatar_id":"","url":"https://api.github.com/users/wu-sheng","html_url":"https://github.com/wu-sheng","followers_url":"https://api.github.com/users/wu-sheng/followers","following_url":"https://api.github.com/users/wu-sheng/following{/other_user}","gists_url":"https://api.github.com/users/wu-sheng/gists{/gist_id}","starred_url":"https://api.github.com/users/wu-sheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wu-sheng/subscriptions","organizations_url":"https://api.github.com/users/wu-sheng/orgs","repos_url":"https://api.github.com/users/wu-sheng/repos","events_url":"https://api.github.com/users/wu-sheng/events{/privacy}","received_events_url":"https://api.github.com/users/wu-sheng/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":4,"state":"open","created_at":"2019-10-13T06:09:23Z","updated_at":"2019-11-11T16:49:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apache/skywalking/pulls/3836/commits","review_comments_url":"https://api.github.com/repos/apache/skywalking/pulls/3836/comments","review_comment_url":"https://api.github.com/repos/apache/skywalking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/skywalking/issues/3836/comments","statuses_url":"https://api.github.com/repos/apache/skywalking/statuses/dbe5457c0f6d8ee1e2851c9325923c4314146dd1","head":{"label":"apache:minikube","ref":"minikube","sha":"dbe5457c0f6d8ee1e2851c9325923c4314146dd1","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45721011,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcyMTAxMQ==","name":"skywalking","full_name":"apache/skywalking","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/skywalking","description":"APM, Application Performance Monitoring System","fork":false,"url":"https://api.github.com/repos/apache/skywalking","forks_url":"https://api.github.com/repos/apache/skywalking/forks","keys_url":"https://api.github.com/repos/apache/skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/skywalking/teams","hooks_url":"https://api.github.com/repos/apache/skywalking/hooks","issue_events_url":"https://api.github.com/repos/apache/skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/apache/skywalking/events","assignees_url":"https://api.github.com/repos/apache/skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/apache/skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/apache/skywalking/tags","blobs_url":"https://api.github.com/repos/apache/skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/skywalking/languages","stargazers_url":"https://api.github.com/repos/apache/skywalking/stargazers","contributors_url":"https://api.github.com/repos/apache/skywalking/contributors","subscribers_url":"https://api.github.com/repos/apache/skywalking/subscribers","subscription_url":"https://api.github.com/repos/apache/skywalking/subscription","commits_url":"https://api.github.com/repos/apache/skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/apache/skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/skywalking/merges","archive_url":"https://api.github.com/repos/apache/skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/skywalking/downloads","issues_url":"https://api.github.com/repos/apache/skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/apache/skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/skywalking/labels{/name}","releases_url":"https://api.github.com/repos/apache/skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/apache/skywalking/deployments","created_at":"2015-11-07T03:30:36Z","updated_at":"2019-11-11T22:23:23Z","pushed_at":"2019-11-12T01:26:37Z","git_url":"git://github.com/apache/skywalking.git","ssh_url":"git@github.com:apache/skywalking.git","clone_url":"https://github.com/apache/skywalking.git","svn_url":"https://github.com/apache/skywalking","homepage":"https://skywalking.apache.org/","size":146464,"stargazers_count":11119,"watchers_count":11119,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3214,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3214,"open_issues":70,"watchers":11119,"default_branch":"master"}},"base":{"label":"apache:istio-ci","ref":"istio-ci","sha":"f6378a5346baa87f60996b0fc5068bcdfffa83a5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45721011,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcyMTAxMQ==","name":"skywalking","full_name":"apache/skywalking","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/skywalking","description":"APM, Application Performance Monitoring System","fork":false,"url":"https://api.github.com/repos/apache/skywalking","forks_url":"https://api.github.com/repos/apache/skywalking/forks","keys_url":"https://api.github.com/repos/apache/skywalking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/skywalking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/skywalking/teams","hooks_url":"https://api.github.com/repos/apache/skywalking/hooks","issue_events_url":"https://api.github.com/repos/apache/skywalking/issues/events{/number}","events_url":"https://api.github.com/repos/apache/skywalking/events","assignees_url":"https://api.github.com/repos/apache/skywalking/assignees{/user}","branches_url":"https://api.github.com/repos/apache/skywalking/branches{/branch}","tags_url":"https://api.github.com/repos/apache/skywalking/tags","blobs_url":"https://api.github.com/repos/apache/skywalking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/skywalking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/skywalking/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/skywalking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/skywalking/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/skywalking/languages","stargazers_url":"https://api.github.com/repos/apache/skywalking/stargazers","contributors_url":"https://api.github.com/repos/apache/skywalking/contributors","subscribers_url":"https://api.github.com/repos/apache/skywalking/subscribers","subscription_url":"https://api.github.com/repos/apache/skywalking/subscription","commits_url":"https://api.github.com/repos/apache/skywalking/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/skywalking/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/skywalking/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/skywalking/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/skywalking/contents/{+path}","compare_url":"https://api.github.com/repos/apache/skywalking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/skywalking/merges","archive_url":"https://api.github.com/repos/apache/skywalking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/skywalking/downloads","issues_url":"https://api.github.com/repos/apache/skywalking/issues{/number}","pulls_url":"https://api.github.com/repos/apache/skywalking/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/skywalking/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/skywalking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/skywalking/labels{/name}","releases_url":"https://api.github.com/repos/apache/skywalking/releases{/id}","deployments_url":"https://api.github.com/repos/apache/skywalking/deployments","created_at":"2015-11-07T03:30:36Z","updated_at":"2019-11-11T22:23:23Z","pushed_at":"2019-11-12T01:26:37Z","git_url":"git://github.com/apache/skywalking.git","ssh_url":"git@github.com:apache/skywalking.git","clone_url":"https://github.com/apache/skywalking.git","svn_url":"https://github.com/apache/skywalking","homepage":"https://skywalking.apache.org/","size":146464,"stargazers_count":11119,"watchers_count":11119,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3214,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":70,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3214,"open_issues":70,"watchers":11119,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/skywalking/pulls/3836"},"html":{"href":"https://github.com/apache/skywalking/pull/3836"},"issue":{"href":"https://api.github.com/repos/apache/skywalking/issues/3836"},"comments":{"href":"https://api.github.com/repos/apache/skywalking/issues/3836/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/skywalking/pulls/3836/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/skywalking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/skywalking/pulls/3836/commits"},"statuses":{"href":"https://api.github.com/repos/apache/skywalking/statuses/dbe5457c0f6d8ee1e2851c9325923c4314146dd1"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 45721011,
"name": "apache/skywalking",
"url": "https://api.github.com/repos/apache/skywalking"
}
|
{
"id": 1960537,
"login": "hanahmily",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1960537?",
"url": "https://api.github.com/users/hanahmily"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-11-12T01:28:58 |
10838547618
|
{"actor":{"display_login":"hanahmily"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/327551382","pull_request_review_id":292337136,"id":327551382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzU1MTM4Mg==","diff_hunk":"@@ -209,41 +176,34 @@ else if (element.isLatencyMarker()) {\n \t}\n \n \t@Override\n-\tpublic void processElement(StreamRecord<IN> element) throws Exception {\n-\t\tfinal StreamRecordQueueEntry<OUT> streamRecordBufferEntry = new StreamRecordQueueEntry<>(element);\n+\tpublic void processElement(final StreamRecord<IN> element) throws Exception {\n+\t\t// add element first to the queue\n+\t\tfinal ResultFuture<OUT> entry = addToWorkQueue(element);\n+\n+\t\tfinal ResultHandler resultHandler = new ResultHandler(element, entry);\n \n+\t\t// register a timeout for the entry if timeout is configured\n \t\tif (timeout > 0L) {\n-\t\t\t// register a timeout for this AsyncStreamRecordBufferEntry\n-\t\t\tlong timeoutTimestamp = timeout + getProcessingTimeService().getCurrentProcessingTime();\n-\n-\t\t\tfinal ScheduledFuture<?> timerFuture = getProcessingTimeService().registerTimer(\n-\t\t\t\ttimeoutTimestamp,\n-\t\t\t\tnew ProcessingTimeCallback() {\n-\t\t\t\t\t@Override\n-\t\t\t\t\tpublic void onProcessingTime(long timestamp) throws Exception {\n-\t\t\t\t\t\tuserFunction.timeout(element.getValue(), streamRecordBufferEntry);\n-\t\t\t\t\t}\n-\t\t\t\t});\n-\n-\t\t\t// Cancel the timer once we've completed the stream record buffer entry. This will remove\n-\t\t\t// the register trigger task\n-\t\t\tstreamRecordBufferEntry.onComplete(\n-\t\t\t\t(StreamElementQueueEntry<Collection<OUT>> value) -> {\n-\t\t\t\t\ttimerFuture.cancel(true);\n-\t\t\t\t},\n-\t\t\t\texecutor);\n-\t\t}\n+\t\t\tfinal long timeoutTimestamp = timeout + getProcessingTimeService().getCurrentProcessingTime();\n \n-\t\taddAsyncBufferEntry(streamRecordBufferEntry);\n+\t\t\tfinal ScheduledFuture<?> timeoutTimer = getProcessingTimeService().registerTimer(\n+\t\t\t\t\ttimeoutTimestamp,\n+\t\t\t\t\ttimestamp -> userFunction.timeout(element.getValue(), resultHandler));\n \n-\t\tuserFunction.asyncInvoke(element.getValue(), streamRecordBufferEntry);\n+\t\t\tresultHandler.setTimeoutTimer(timeoutTimer);","path":"flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java","position":158,"original_position":158,"commit_id":"911bdd80f4b1cbb6cee2ffb517cafc5e3c83ee0b","original_commit_id":"9b68b170db9c96c45fabee57079da0eca60a3ec9","user":{"login":"zhijiangW","id":12387855,"node_id":"MDQ6VXNlcjEyMzg3ODU1","avatar_url":"https://avatars0.githubusercontent.com/u/12387855?v=4","gravatar_id":"","url":"https://api.github.com/users/zhijiangW","html_url":"https://github.com/zhijiangW","followers_url":"https://api.github.com/users/zhijiangW/followers","following_url":"https://api.github.com/users/zhijiangW/following{/other_user}","gists_url":"https://api.github.com/users/zhijiangW/gists{/gist_id}","starred_url":"https://api.github.com/users/zhijiangW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhijiangW/subscriptions","organizations_url":"https://api.github.com/users/zhijiangW/orgs","repos_url":"https://api.github.com/users/zhijiangW/repos","events_url":"https://api.github.com/users/zhijiangW/events{/privacy}","received_events_url":"https://api.github.com/users/zhijiangW/received_events","type":"User","site_admin":false},"body":"I have potential worries of setting timer delay here. I mean if above `registerTimer` happens before this setting, and during `ResultHandler#complete` if `mailboxExecutor.execute` also happens immediately, then the un-set timers would not be canceled any more. \r\n\r\nI know it would not happen atm because `mailboxExecutor.execute` just inserts into queue and would not execute right now. Maybe my worry could be ignored.","created_at":"2019-09-24T11:00:07Z","updated_at":"2019-09-24T11:00:07Z","html_url":"https://github.com/apache/flink/pull/9717#discussion_r327551382","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/9717","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/327551382"},"html":{"href":"https://github.com/apache/flink/pull/9717#discussion_r327551382"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/9717"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/9717","id":319193900,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MTkzOTAw","html_url":"https://github.com/apache/flink/pull/9717","diff_url":"https://github.com/apache/flink/pull/9717.diff","patch_url":"https://github.com/apache/flink/pull/9717.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/9717","number":9717,"state":"open","locked":false,"title":"[FLINK-14044] [runtime] Reducing synchronization in AsyncWaitOperator","user":{"login":"AHeise","id":4559103,"node_id":"MDQ6VXNlcjQ1NTkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/4559103?v=4","gravatar_id":"","url":"https://api.github.com/users/AHeise","html_url":"https://github.com/AHeise","followers_url":"https://api.github.com/users/AHeise/followers","following_url":"https://api.github.com/users/AHeise/following{/other_user}","gists_url":"https://api.github.com/users/AHeise/gists{/gist_id}","starred_url":"https://api.github.com/users/AHeise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AHeise/subscriptions","organizations_url":"https://api.github.com/users/AHeise/orgs","repos_url":"https://api.github.com/users/AHeise/repos","events_url":"https://api.github.com/users/AHeise/events{/privacy}","received_events_url":"https://api.github.com/users/AHeise/received_events","type":"User","site_admin":false},"body":"<!--\r\n*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*\r\n\r\n*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*\r\n\r\n## Contribution Checklist\r\n\r\n - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.\r\n \r\n - Name the pull request in the form \"[FLINK-XXXX] [component] Title of the pull request\", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.\r\n Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.\r\n\r\n - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.\r\n \r\n - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).\r\n\r\n - Each pull request should address only one issue, not mix up code from multiple issues.\r\n \r\n - Each commit in the pull request has a meaningful commit message (including the JIRA id)\r\n\r\n - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.\r\n\r\n\r\n**(The sections below can be removed for hotfixes of typos)**\r\n-->\r\n\r\n## What is the purpose of the change\r\n\r\nCurrently, AsyncWaitOperator receives computed results from a user thread and puts it in StreamElementQueue. This queue is synchronized as the emitter thread pulls available elements in a blocking fashion. With the recent migration to mailbox model, these elements are then put into a letter to be outputted in the mailbox thread.\r\n\r\nIf we directly send the results from the user thread to the mailbox, we can get rid of any synchronization as everything happens in the user thread. That will slim down the code heavily.\r\n\r\n## Brief change log\r\n\r\n*(for example:)*\r\n - Put results from asyncUserFunction into mailbox thread.\r\n - Remove all synchronizations from StreamElementQueue\r\n - Remove emitter and emitter thread\r\n - Remove executor from AsyncWaitOperator\r\n\r\n## Verifying this change\r\n\r\nThis change is already covered by existing tests, such as *(please describe tests)*.\r\nAsyncWaitOperatorTest\r\n(Ordered/Unordered)StreamElementQueueTest\r\nMany IT tests\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): no\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no\r\n - The serializers: no\r\n - The runtime per-record code paths (performance sensitive): yes\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no\r\n - The S3 file system connector: no\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? no\r\n - If yes, how is the feature documented? not applicable\r\n","created_at":"2019-09-19T09:59:32Z","updated_at":"2019-09-24T11:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eff685bf7d8644bce289818115fa6d31a5e4b361","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1401080710,"node_id":"MDU6TGFiZWwxNDAxMDgwNzEw","url":"https://api.github.com/repos/apache/flink/labels/component=Runtime/Task","name":"component=Runtime/Task","color":"175fb7","default":false},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/9717/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/9717/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/9717/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/911bdd80f4b1cbb6cee2ffb517cafc5e3c83ee0b","head":{"label":"AHeise:FLINK-14044","ref":"FLINK-14044","sha":"911bdd80f4b1cbb6cee2ffb517cafc5e3c83ee0b","user":{"login":"AHeise","id":4559103,"node_id":"MDQ6VXNlcjQ1NTkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/4559103?v=4","gravatar_id":"","url":"https://api.github.com/users/AHeise","html_url":"https://github.com/AHeise","followers_url":"https://api.github.com/users/AHeise/followers","following_url":"https://api.github.com/users/AHeise/following{/other_user}","gists_url":"https://api.github.com/users/AHeise/gists{/gist_id}","starred_url":"https://api.github.com/users/AHeise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AHeise/subscriptions","organizations_url":"https://api.github.com/users/AHeise/orgs","repos_url":"https://api.github.com/users/AHeise/repos","events_url":"https://api.github.com/users/AHeise/events{/privacy}","received_events_url":"https://api.github.com/users/AHeise/received_events","type":"User","site_admin":false},"repo":{"id":201067444,"node_id":"MDEwOlJlcG9zaXRvcnkyMDEwNjc0NDQ=","name":"flink","full_name":"AHeise/flink","private":false,"owner":{"login":"AHeise","id":4559103,"node_id":"MDQ6VXNlcjQ1NTkxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/4559103?v=4","gravatar_id":"","url":"https://api.github.com/users/AHeise","html_url":"https://github.com/AHeise","followers_url":"https://api.github.com/users/AHeise/followers","following_url":"https://api.github.com/users/AHeise/following{/other_user}","gists_url":"https://api.github.com/users/AHeise/gists{/gist_id}","starred_url":"https://api.github.com/users/AHeise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AHeise/subscriptions","organizations_url":"https://api.github.com/users/AHeise/orgs","repos_url":"https://api.github.com/users/AHeise/repos","events_url":"https://api.github.com/users/AHeise/events{/privacy}","received_events_url":"https://api.github.com/users/AHeise/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AHeise/flink","description":"Apache Flink","fork":true,"url":"https://api.github.com/repos/AHeise/flink","forks_url":"https://api.github.com/repos/AHeise/flink/forks","keys_url":"https://api.github.com/repos/AHeise/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AHeise/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AHeise/flink/teams","hooks_url":"https://api.github.com/repos/AHeise/flink/hooks","issue_events_url":"https://api.github.com/repos/AHeise/flink/issues/events{/number}","events_url":"https://api.github.com/repos/AHeise/flink/events","assignees_url":"https://api.github.com/repos/AHeise/flink/assignees{/user}","branches_url":"https://api.github.com/repos/AHeise/flink/branches{/branch}","tags_url":"https://api.github.com/repos/AHeise/flink/tags","blobs_url":"https://api.github.com/repos/AHeise/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AHeise/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AHeise/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/AHeise/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AHeise/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/AHeise/flink/languages","stargazers_url":"https://api.github.com/repos/AHeise/flink/stargazers","contributors_url":"https://api.github.com/repos/AHeise/flink/contributors","subscribers_url":"https://api.github.com/repos/AHeise/flink/subscribers","subscription_url":"https://api.github.com/repos/AHeise/flink/subscription","commits_url":"https://api.github.com/repos/AHeise/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/AHeise/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/AHeise/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/AHeise/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/AHeise/flink/contents/{+path}","compare_url":"https://api.github.com/repos/AHeise/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AHeise/flink/merges","archive_url":"https://api.github.com/repos/AHeise/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AHeise/flink/downloads","issues_url":"https://api.github.com/repos/AHeise/flink/issues{/number}","pulls_url":"https://api.github.com/repos/AHeise/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/AHeise/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/AHeise/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AHeise/flink/labels{/name}","releases_url":"https://api.github.com/repos/AHeise/flink/releases{/id}","deployments_url":"https://api.github.com/repos/AHeise/flink/deployments","created_at":"2019-08-07T14:31:59Z","updated_at":"2019-09-20T08:05:11Z","pushed_at":"2019-09-23T21:41:32Z","git_url":"git://github.com/AHeise/flink.git","ssh_url":"git@github.com:AHeise/flink.git","clone_url":"https://github.com/AHeise/flink.git","svn_url":"https://github.com/AHeise/flink","homepage":"","size":261193,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"af37ae7607f93c3dd14f8eca55dd69af0dc3675d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2019-09-24T10:25:50Z","pushed_at":"2019-09-24T10:39:45Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":261636,"stargazers_count":10424,"watchers_count":10424,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5584,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":545,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5584,"open_issues":545,"watchers":10424,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/9717"},"html":{"href":"https://github.com/apache/flink/pull/9717"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/9717"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/9717/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/9717/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/9717/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/911bdd80f4b1cbb6cee2ffb517cafc5e3c83ee0b"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
}
|
{
"id": 12387855,
"login": "zhijiangW",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12387855?",
"url": "https://api.github.com/users/zhijiangW"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-09-24T11:00:07 |
10482029025
|
{"actor":{"display_login":"zhijiangW"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/277175488","pull_request_review_id":228920332,"id":277175488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NzE3NTQ4OA==","diff_hunk":"@@ -1485,20 +1503,21 @@ class PinotEngineSpec(BaseEngineSpec):\n inner_joins = False\n supports_column_aliases = False\n \n- _time_grain_to_datetimeconvert = {\n+ # Pinot does its own conversion below\n+ time_grain_functions: Dict[Optional[str], str] = {","path":"superset/db_engine_specs.py","position":145,"original_position":145,"commit_id":"27c7a3d37bfa69c6e3c2a3e281097a9d5f4fcfef","original_commit_id":"27c7a3d37bfa69c6e3c2a3e281097a9d5f4fcfef","user":{"login":"agrawaldevesh","id":20564223,"node_id":"MDQ6VXNlcjIwNTY0MjIz","avatar_url":"https://avatars1.githubusercontent.com/u/20564223?v=4","gravatar_id":"","url":"https://api.github.com/users/agrawaldevesh","html_url":"https://github.com/agrawaldevesh","followers_url":"https://api.github.com/users/agrawaldevesh/followers","following_url":"https://api.github.com/users/agrawaldevesh/following{/other_user}","gists_url":"https://api.github.com/users/agrawaldevesh/gists{/gist_id}","starred_url":"https://api.github.com/users/agrawaldevesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrawaldevesh/subscriptions","organizations_url":"https://api.github.com/users/agrawaldevesh/orgs","repos_url":"https://api.github.com/users/agrawaldevesh/repos","events_url":"https://api.github.com/users/agrawaldevesh/events{/privacy}","received_events_url":"https://api.github.com/users/agrawaldevesh/received_events","type":"User","site_admin":false},"body":"My concern is renaming this to time_grain_functions is that they are not really behaving like \"functions\" (like in the rest of the db engine specs). \r\n\r\nFor example if someone (other than the pinot specific get_timestamp_expr) starts using them, then they wouldn't be getting a function. So I would be wary of changing this. \r\n\r\nIf anything, we can make time_grain_functions = None (in case they are set in the BaseEngineSpec), so that no one can use them. \r\n\r\nAnd switch this back to its internal name that the below pinot specific get_timestamp_expr can use.","created_at":"2019-04-21T17:17:11Z","updated_at":"2019-04-21T17:17:11Z","html_url":"https://github.com/apache/incubator-superset/pull/7131#discussion_r277175488","pull_request_url":"https://api.github.com/repos/apache/incubator-superset/pulls/7131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments/277175488"},"html":{"href":"https://github.com/apache/incubator-superset/pull/7131#discussion_r277175488"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/7131"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-superset/pulls/7131","id":264618575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0NjE4NTc1","html_url":"https://github.com/apache/incubator-superset/pull/7131","diff_url":"https://github.com/apache/incubator-superset/pull/7131.diff","patch_url":"https://github.com/apache/incubator-superset/pull/7131.patch","issue_url":"https://api.github.com/repos/apache/incubator-superset/issues/7131","number":7131,"state":"open","locked":false,"title":"Make timestamp expression native SQLAlchemy element","user":{"login":"villebro","id":33317356,"node_id":"MDQ6VXNlcjMzMzE3MzU2","avatar_url":"https://avatars2.githubusercontent.com/u/33317356?v=4","gravatar_id":"","url":"https://api.github.com/users/villebro","html_url":"https://github.com/villebro","followers_url":"https://api.github.com/users/villebro/followers","following_url":"https://api.github.com/users/villebro/following{/other_user}","gists_url":"https://api.github.com/users/villebro/gists{/gist_id}","starred_url":"https://api.github.com/users/villebro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villebro/subscriptions","organizations_url":"https://api.github.com/users/villebro/orgs","repos_url":"https://api.github.com/users/villebro/repos","events_url":"https://api.github.com/users/villebro/events{/privacy}","received_events_url":"https://api.github.com/users/villebro/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\n\r\nThe functional part of this PR makes the timestamp expression a native SQLAlchemy element that respects quoting rules for column names (based largely on https://docs.sqlalchemy.org/en/latest/core/compiler.html) . This is a continuation of what was started in #6897, which was really just a hack to make `Postgres` work, but didn't address e.g. reserved keywords or similar problems that might arise in other dbs. This PR adds a new class `TimestampExpression`, which can be used in a SQLAlchemy query, which keeps the target column as a native Core element. The column name is only rendered to text once the query is compiled, which ensures that engine specific quoting rules are respected.\r\n\r\nRefactoring:\r\n\r\n- Added mypy typing where code was changed.\r\n- Moved some functional parts of `sqla/models/get_timestamp_expression()` to `db_engine_specs/get_timestamp_expr()`.\r\n- Removed `models/core/grains()` which was no longer needed.\r\n\r\n##### TEST PLAN\r\nAdded unit tests that test the central features and tested timeseries graphs using both column and expression, both with and without time grains.\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue --> \r\n<!--- Check any relevant boxes with \"x\" -->\r\n [ ] Has associated issue:\r\n [ ] Changes UI\r\n [ ] Requires DB Migration. Confirm DB Migration upgrade and downgrade tested.\r\n [ ] Introduces new feature or API\r\n [ ] Removes existing feature or API\r\n [x] Fixes bug\r\n [x] Refactors code\r\n [x] Adds test(s)\r\n\r\n##### REVIEWERS\r\nComments much appreciated @betodealmeida @john-bodley. Also @agrawaldevesh: I had to change the Pinot logic for this PR. Do you have the opportunity to test if this works on your Pinot deployment (I don't have a Pinot installation handy right now)? I also added a few grains while at it, do they work?\r\n","created_at":"2019-03-26T17:17:46Z","updated_at":"2019-04-21T17:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"081bd6df9715648464ee301dd34deb1b33a08bc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":238899552,"node_id":"MDU6TGFiZWwyMzg4OTk1NTI=","url":"https://api.github.com/repos/apache/incubator-superset/labels/%23enhancement","name":"#enhancement","color":"1d76db","default":false},{"id":1145053911,"node_id":"MDU6TGFiZWwxMTQ1MDUzOTEx","url":"https://api.github.com/repos/apache/incubator-superset/labels/review","name":"review","color":"ed82dd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-superset/pulls/7131/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-superset/pulls/7131/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-superset/issues/7131/comments","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/27c7a3d37bfa69c6e3c2a3e281097a9d5f4fcfef","head":{"label":"villebro:time_expression","ref":"time_expression","sha":"27c7a3d37bfa69c6e3c2a3e281097a9d5f4fcfef","user":{"login":"villebro","id":33317356,"node_id":"MDQ6VXNlcjMzMzE3MzU2","avatar_url":"https://avatars2.githubusercontent.com/u/33317356?v=4","gravatar_id":"","url":"https://api.github.com/users/villebro","html_url":"https://github.com/villebro","followers_url":"https://api.github.com/users/villebro/followers","following_url":"https://api.github.com/users/villebro/following{/other_user}","gists_url":"https://api.github.com/users/villebro/gists{/gist_id}","starred_url":"https://api.github.com/users/villebro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villebro/subscriptions","organizations_url":"https://api.github.com/users/villebro/orgs","repos_url":"https://api.github.com/users/villebro/repos","events_url":"https://api.github.com/users/villebro/events{/privacy}","received_events_url":"https://api.github.com/users/villebro/received_events","type":"User","site_admin":false},"repo":{"id":121288529,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyODg1Mjk=","name":"incubator-superset","full_name":"villebro/incubator-superset","private":false,"owner":{"login":"villebro","id":33317356,"node_id":"MDQ6VXNlcjMzMzE3MzU2","avatar_url":"https://avatars2.githubusercontent.com/u/33317356?v=4","gravatar_id":"","url":"https://api.github.com/users/villebro","html_url":"https://github.com/villebro","followers_url":"https://api.github.com/users/villebro/followers","following_url":"https://api.github.com/users/villebro/following{/other_user}","gists_url":"https://api.github.com/users/villebro/gists{/gist_id}","starred_url":"https://api.github.com/users/villebro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villebro/subscriptions","organizations_url":"https://api.github.com/users/villebro/orgs","repos_url":"https://api.github.com/users/villebro/repos","events_url":"https://api.github.com/users/villebro/events{/privacy}","received_events_url":"https://api.github.com/users/villebro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/villebro/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":true,"url":"https://api.github.com/repos/villebro/incubator-superset","forks_url":"https://api.github.com/repos/villebro/incubator-superset/forks","keys_url":"https://api.github.com/repos/villebro/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/villebro/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/villebro/incubator-superset/teams","hooks_url":"https://api.github.com/repos/villebro/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/villebro/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/villebro/incubator-superset/events","assignees_url":"https://api.github.com/repos/villebro/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/villebro/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/villebro/incubator-superset/tags","blobs_url":"https://api.github.com/repos/villebro/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/villebro/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/villebro/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/villebro/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/villebro/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/villebro/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/villebro/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/villebro/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/villebro/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/villebro/incubator-superset/subscription","commits_url":"https://api.github.com/repos/villebro/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/villebro/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/villebro/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/villebro/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/villebro/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/villebro/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/villebro/incubator-superset/merges","archive_url":"https://api.github.com/repos/villebro/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/villebro/incubator-superset/downloads","issues_url":"https://api.github.com/repos/villebro/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/villebro/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/villebro/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/villebro/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/villebro/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/villebro/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/villebro/incubator-superset/deployments","created_at":"2018-02-12T19:00:48Z","updated_at":"2019-03-29T18:56:01Z","pushed_at":"2019-04-19T18:15:06Z","git_url":"git://github.com/villebro/incubator-superset.git","ssh_url":"git@github.com:villebro/incubator-superset.git","clone_url":"https://github.com/villebro/incubator-superset.git","svn_url":"https://github.com/villebro/incubator-superset","homepage":"","size":97409,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ceb86df063aaabc71f7aff6005c5d65202757b97","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":39464018,"node_id":"MDEwOlJlcG9zaXRvcnkzOTQ2NDAxOA==","name":"incubator-superset","full_name":"apache/incubator-superset","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-superset","description":"Apache Superset (incubating) is a modern, enterprise-ready business intelligence web application","fork":false,"url":"https://api.github.com/repos/apache/incubator-superset","forks_url":"https://api.github.com/repos/apache/incubator-superset/forks","keys_url":"https://api.github.com/repos/apache/incubator-superset/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-superset/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-superset/teams","hooks_url":"https://api.github.com/repos/apache/incubator-superset/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-superset/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-superset/events","assignees_url":"https://api.github.com/repos/apache/incubator-superset/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-superset/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-superset/tags","blobs_url":"https://api.github.com/repos/apache/incubator-superset/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-superset/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-superset/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-superset/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-superset/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-superset/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-superset/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-superset/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-superset/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-superset/subscription","commits_url":"https://api.github.com/repos/apache/incubator-superset/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-superset/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-superset/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-superset/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-superset/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-superset/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-superset/merges","archive_url":"https://api.github.com/repos/apache/incubator-superset/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-superset/downloads","issues_url":"https://api.github.com/repos/apache/incubator-superset/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-superset/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-superset/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-superset/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-superset/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-superset/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-superset/deployments","created_at":"2015-07-21T18:55:34Z","updated_at":"2019-04-21T15:01:16Z","pushed_at":"2019-04-20T20:17:53Z","git_url":"git://github.com/apache/incubator-superset.git","ssh_url":"git@github.com:apache/incubator-superset.git","clone_url":"https://github.com/apache/incubator-superset.git","svn_url":"https://github.com/apache/incubator-superset","homepage":"","size":101461,"stargazers_count":24032,"watchers_count":24032,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4497,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":329,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4497,"open_issues":329,"watchers":24032,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/7131"},"html":{"href":"https://github.com/apache/incubator-superset/pull/7131"},"issue":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/7131"},"comments":{"href":"https://api.github.com/repos/apache/incubator-superset/issues/7131/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/7131/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-superset/pulls/7131/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-superset/statuses/27c7a3d37bfa69c6e3c2a3e281097a9d5f4fcfef"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 39464018,
"name": "apache/incubator-superset",
"url": "https://api.github.com/repos/apache/incubator-superset"
}
|
{
"id": 20564223,
"login": "agrawaldevesh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20564223?",
"url": "https://api.github.com/users/agrawaldevesh"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-04-21T17:17:11 |
9482715436
|
{"actor":{"display_login":"agrawaldevesh"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/pulsar/pulls/comments/285412473","pull_request_review_id":239269226,"id":285412473,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTQxMjQ3Mw==","diff_hunk":"@@ -209,6 +276,87 @@ public void acknowledgeMessage(List<Position> positions, AckType ackType, Map<St\n }\n }\n \n+ /**\n+ * Acknowledge message(s) for an ongoing transaction.\n+ * <p>\n+ * It can be of {@link AckType#Individual} or {@link AckType#Cumulative}. Single messages acked by ongoing\n+ * transaction will be put in pending_ack state and only marked as deleted after transaction is committed.\n+ * <p>\n+ * Only one transaction is allowed to do cumulative ack on a subscription at a given time.\n+ * If a transaction do multiple cumulative ack, only the one with largest position determined by\n+ * {@link PositionImpl#compareTo(PositionImpl)} will be kept as it cover all position smaller than it.\n+ * <p>\n+ * If an ongoing transaction cumulative acked a message and then try to ack single message which is\n+ * smaller than that one it cumulative acked, it'll succeed.\n+ * <p>\n+ * If transaction is aborted all messages acked by it will be put back to pending state.\n+ *\n+ * @param txnID TransactionID of an ongoing transaction trying to sck message.\n+ * @param positions {@link Position}(s) it try to ack.\n+ * @param ackType {@link AckType}.\n+ * @throws TransactionConflictException\n+ * @throws IllegalArgumentException\n+ */\n+ public synchronized void acknowledgeMessage(TxnID txnID, List<Position> positions, AckType ackType) throws TransactionConflictException {\n+ checkArgument(txnID != null, \"TransactionID can not be null.\");\n+ if (AckType.Cumulative == ackType) {\n+ // Check if another transaction is already using cumulative ack on this subscription.\n+ if (this.txnID != null && this.txnID != txnID) {\n+ String errorMsg = \"[\" + topicName + \"][\" + subName + \"] Transaction:\" + txnID.getMostSigBits() +\n+ txnID.getLeastSigBits() + \" try to cumulative ack message while transaction:\"\n+ + this.txnID.getMostSigBits() + this.txnID.getLeastSigBits()\n+ + \" already cumulative acked messages.\";\n+ log.error(errorMsg);\n+ throw new TransactionConflictException(errorMsg);\n+ }\n+\n+ if (positions.size() != 1) {\n+ String errorMsg = \"[\" + topicName + \"][\" + subName + \"] Transaction:\" + txnID.getMostSigBits() +\n+ txnID.getLeastSigBits() + \" invalid cumulative ack received with multiple message ids.\";\n+ log.error(errorMsg);\n+ throw new IllegalArgumentException(errorMsg);","path":"pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java","position":169,"original_position":169,"commit_id":"1509dc13918475c88e39515d9fb1e4a2f139d84d","original_commit_id":"1509dc13918475c88e39515d9fb1e4a2f139d84d","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"should this be TransactionConflictException?","created_at":"2019-05-20T02:09:35Z","updated_at":"2019-05-20T02:27:48Z","html_url":"https://github.com/apache/pulsar/pull/4265#discussion_r285412473","pull_request_url":"https://api.github.com/repos/apache/pulsar/pulls/4265","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/pulsar/pulls/comments/285412473"},"html":{"href":"https://github.com/apache/pulsar/pull/4265#discussion_r285412473"},"pull_request":{"href":"https://api.github.com/repos/apache/pulsar/pulls/4265"}}},"pull_request":{"url":"https://api.github.com/repos/apache/pulsar/pulls/4265","id":278082074,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc4MDgyMDc0","html_url":"https://github.com/apache/pulsar/pull/4265","diff_url":"https://github.com/apache/pulsar/pull/4265.diff","patch_url":"https://github.com/apache/pulsar/pull/4265.patch","issue_url":"https://api.github.com/repos/apache/pulsar/issues/4265","number":4265,"state":"open","locked":false,"title":"[transaction][acknowledge] Introduce PENDING_ACK state in acknowledgement path","user":{"login":"MarvinCai","id":13480084,"node_id":"MDQ6VXNlcjEzNDgwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13480084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarvinCai","html_url":"https://github.com/MarvinCai","followers_url":"https://api.github.com/users/MarvinCai/followers","following_url":"https://api.github.com/users/MarvinCai/following{/other_user}","gists_url":"https://api.github.com/users/MarvinCai/gists{/gist_id}","starred_url":"https://api.github.com/users/MarvinCai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarvinCai/subscriptions","organizations_url":"https://api.github.com/users/MarvinCai/orgs","repos_url":"https://api.github.com/users/MarvinCai/repos","events_url":"https://api.github.com/users/MarvinCai/events{/privacy}","received_events_url":"https://api.github.com/users/MarvinCai/received_events","type":"User","site_admin":false},"body":"Master Issue: #2664\r\n\r\nMotivation:\r\nAdd acknowledgeMessage, commit, abort for transaction in PersistentSubscription.\r\n\r\nChanges:\r\nWill put message in Pending_ACK status when acknowledgeMessage is called with TxnID.\r\nNo real status class introduced, only added collection to hold messages in Pending_ACK status.\r\n\r\nAdd commitTxn to put message to Deleted status.\r\nAdd abortTxn to put message to Pending status.\r\n\r\nFor normal acknowledgeMessage and redeliverUnacknowledgedMessages, will check to see if \r\nmessage if message is in Pending_ACK first. If true, will **ignore** those acks/redeliverys.\r\n\r\nAdd unit test.\r\n","created_at":"2019-05-12T21:25:08Z","updated_at":"2019-05-20T02:27:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a4587935b7035e183fe83cba468a7e23b067b0","assignee":{"login":"MarvinCai","id":13480084,"node_id":"MDQ6VXNlcjEzNDgwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13480084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarvinCai","html_url":"https://github.com/MarvinCai","followers_url":"https://api.github.com/users/MarvinCai/followers","following_url":"https://api.github.com/users/MarvinCai/following{/other_user}","gists_url":"https://api.github.com/users/MarvinCai/gists{/gist_id}","starred_url":"https://api.github.com/users/MarvinCai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarvinCai/subscriptions","organizations_url":"https://api.github.com/users/MarvinCai/orgs","repos_url":"https://api.github.com/users/MarvinCai/repos","events_url":"https://api.github.com/users/MarvinCai/events{/privacy}","received_events_url":"https://api.github.com/users/MarvinCai/received_events","type":"User","site_admin":false},"assignees":[{"login":"MarvinCai","id":13480084,"node_id":"MDQ6VXNlcjEzNDgwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13480084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarvinCai","html_url":"https://github.com/MarvinCai","followers_url":"https://api.github.com/users/MarvinCai/followers","following_url":"https://api.github.com/users/MarvinCai/following{/other_user}","gists_url":"https://api.github.com/users/MarvinCai/gists{/gist_id}","starred_url":"https://api.github.com/users/MarvinCai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarvinCai/subscriptions","organizations_url":"https://api.github.com/users/MarvinCai/orgs","repos_url":"https://api.github.com/users/MarvinCai/repos","events_url":"https://api.github.com/users/MarvinCai/events{/privacy}","received_events_url":"https://api.github.com/users/MarvinCai/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":978303574,"node_id":"MDU6TGFiZWw5NzgzMDM1NzQ=","url":"https://api.github.com/repos/apache/pulsar/labels/component/broker","name":"component/broker","color":"1d76db","default":false},{"id":447781389,"node_id":"MDU6TGFiZWw0NDc3ODEzODk=","url":"https://api.github.com/repos/apache/pulsar/labels/component/client","name":"component/client","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/pulsar/pulls/4265/commits","review_comments_url":"https://api.github.com/repos/apache/pulsar/pulls/4265/comments","review_comment_url":"https://api.github.com/repos/apache/pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/pulsar/issues/4265/comments","statuses_url":"https://api.github.com/repos/apache/pulsar/statuses/1509dc13918475c88e39515d9fb1e4a2f139d84d","head":{"label":"MarvinCai:zxc-txn-ack-review","ref":"zxc-txn-ack-review","sha":"1509dc13918475c88e39515d9fb1e4a2f139d84d","user":{"login":"MarvinCai","id":13480084,"node_id":"MDQ6VXNlcjEzNDgwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13480084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarvinCai","html_url":"https://github.com/MarvinCai","followers_url":"https://api.github.com/users/MarvinCai/followers","following_url":"https://api.github.com/users/MarvinCai/following{/other_user}","gists_url":"https://api.github.com/users/MarvinCai/gists{/gist_id}","starred_url":"https://api.github.com/users/MarvinCai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarvinCai/subscriptions","organizations_url":"https://api.github.com/users/MarvinCai/orgs","repos_url":"https://api.github.com/users/MarvinCai/repos","events_url":"https://api.github.com/users/MarvinCai/events{/privacy}","received_events_url":"https://api.github.com/users/MarvinCai/received_events","type":"User","site_admin":false},"repo":{"id":152883723,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4ODM3MjM=","name":"pulsar","full_name":"MarvinCai/pulsar","private":false,"owner":{"login":"MarvinCai","id":13480084,"node_id":"MDQ6VXNlcjEzNDgwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/13480084?v=4","gravatar_id":"","url":"https://api.github.com/users/MarvinCai","html_url":"https://github.com/MarvinCai","followers_url":"https://api.github.com/users/MarvinCai/followers","following_url":"https://api.github.com/users/MarvinCai/following{/other_user}","gists_url":"https://api.github.com/users/MarvinCai/gists{/gist_id}","starred_url":"https://api.github.com/users/MarvinCai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarvinCai/subscriptions","organizations_url":"https://api.github.com/users/MarvinCai/orgs","repos_url":"https://api.github.com/users/MarvinCai/repos","events_url":"https://api.github.com/users/MarvinCai/events{/privacy}","received_events_url":"https://api.github.com/users/MarvinCai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MarvinCai/pulsar","description":"Apache Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/MarvinCai/pulsar","forks_url":"https://api.github.com/repos/MarvinCai/pulsar/forks","keys_url":"https://api.github.com/repos/MarvinCai/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarvinCai/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarvinCai/pulsar/teams","hooks_url":"https://api.github.com/repos/MarvinCai/pulsar/hooks","issue_events_url":"https://api.github.com/repos/MarvinCai/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/MarvinCai/pulsar/events","assignees_url":"https://api.github.com/repos/MarvinCai/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/MarvinCai/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/MarvinCai/pulsar/tags","blobs_url":"https://api.github.com/repos/MarvinCai/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarvinCai/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarvinCai/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarvinCai/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarvinCai/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/MarvinCai/pulsar/languages","stargazers_url":"https://api.github.com/repos/MarvinCai/pulsar/stargazers","contributors_url":"https://api.github.com/repos/MarvinCai/pulsar/contributors","subscribers_url":"https://api.github.com/repos/MarvinCai/pulsar/subscribers","subscription_url":"https://api.github.com/repos/MarvinCai/pulsar/subscription","commits_url":"https://api.github.com/repos/MarvinCai/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarvinCai/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarvinCai/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarvinCai/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarvinCai/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/MarvinCai/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarvinCai/pulsar/merges","archive_url":"https://api.github.com/repos/MarvinCai/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarvinCai/pulsar/downloads","issues_url":"https://api.github.com/repos/MarvinCai/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/MarvinCai/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/MarvinCai/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/MarvinCai/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarvinCai/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/MarvinCai/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/MarvinCai/pulsar/deployments","created_at":"2018-10-13T15:06:12Z","updated_at":"2019-02-27T05:35:30Z","pushed_at":"2019-05-17T02:53:09Z","git_url":"git://github.com/MarvinCai/pulsar.git","ssh_url":"git@github.com:MarvinCai/pulsar.git","clone_url":"https://github.com/MarvinCai/pulsar.git","svn_url":"https://github.com/MarvinCai/pulsar","homepage":"https://pulsar.apache.org","size":70872,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"db66df2dd835d736ea3556e7585747ed8b665835","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxMg==","name":"pulsar","full_name":"apache/pulsar","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/pulsar","description":"Apache Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/pulsar","forks_url":"https://api.github.com/repos/apache/pulsar/forks","keys_url":"https://api.github.com/repos/apache/pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/pulsar/teams","hooks_url":"https://api.github.com/repos/apache/pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/pulsar/events","assignees_url":"https://api.github.com/repos/apache/pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/pulsar/tags","blobs_url":"https://api.github.com/repos/apache/pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/pulsar/subscription","commits_url":"https://api.github.com/repos/apache/pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/pulsar/merges","archive_url":"https://api.github.com/repos/apache/pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/pulsar/downloads","issues_url":"https://api.github.com/repos/apache/pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2019-05-19T13:16:34Z","pushed_at":"2019-05-20T02:23:52Z","git_url":"git://github.com/apache/pulsar.git","ssh_url":"git@github.com:apache/pulsar.git","clone_url":"https://github.com/apache/pulsar.git","svn_url":"https://github.com/apache/pulsar","homepage":"https://pulsar.apache.org","size":92949,"stargazers_count":3393,"watchers_count":3393,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":767,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":376,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":767,"open_issues":376,"watchers":3393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/pulsar/pulls/4265"},"html":{"href":"https://github.com/apache/pulsar/pull/4265"},"issue":{"href":"https://api.github.com/repos/apache/pulsar/issues/4265"},"comments":{"href":"https://api.github.com/repos/apache/pulsar/issues/4265/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/pulsar/pulls/4265/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/pulsar/pulls/4265/commits"},"statuses":{"href":"https://api.github.com/repos/apache/pulsar/statuses/1509dc13918475c88e39515d9fb1e4a2f139d84d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 62117812,
"name": "apache/pulsar",
"url": "https://api.github.com/repos/apache/pulsar"
}
|
{
"id": 1217863,
"login": "sijie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1217863?",
"url": "https://api.github.com/users/sijie"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-05-20T02:09:35 |
9655970561
|
{"actor":{"display_login":"sijie"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/phoenix/pulls/comments/295506030","pull_request_review_id":251948790,"id":295506030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTUwNjAzMA==","diff_hunk":"@@ -0,0 +1,459 @@\n+package org.apache.phoenix.mapreduce.index;\n+\n+import org.apache.commons.cli.CommandLine;\n+import org.apache.commons.cli.CommandLineParser;\n+import org.apache.commons.cli.DefaultParser;\n+import org.apache.commons.cli.HelpFormatter;\n+import org.apache.commons.cli.Option;\n+import org.apache.commons.cli.Options;\n+import org.apache.commons.cli.ParseException;\n+import org.apache.hadoop.conf.Configured;\n+\n+import org.apache.hadoop.hbase.TableName;\n+import org.apache.hadoop.hbase.client.Admin;\n+import org.apache.hadoop.hbase.client.CompactionState;\n+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;\n+import org.apache.phoenix.hbase.index.IndexRegionObserver;\n+import org.apache.phoenix.hbase.index.Indexer;\n+import org.apache.phoenix.hbase.index.covered.NonTxIndexBuilder;\n+import org.apache.phoenix.index.GlobalIndexChecker;\n+import org.apache.phoenix.index.PhoenixIndexBuilder;\n+import org.apache.phoenix.index.PhoenixIndexCodec;\n+import org.apache.phoenix.jdbc.PhoenixConnection;\n+import org.apache.phoenix.query.ConnectionQueryServices;\n+import org.apache.phoenix.query.QueryServices;\n+import org.apache.phoenix.query.QueryServicesOptions;\n+import org.apache.phoenix.schema.PTable;\n+import org.apache.phoenix.util.PhoenixRuntime;\n+\n+import java.util.logging.Logger;\n+import org.apache.hadoop.conf.Configuration;\n+import java.io.IOException;\n+import java.nio.file.Files;\n+import java.nio.file.Paths;\n+import java.sql.Connection;\n+import java.sql.DriverManager;\n+import java.sql.SQLException;\n+import java.util.ArrayList;\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.Properties;\n+import java.util.UUID;\n+import java.util.logging.FileHandler;\n+import java.util.logging.SimpleFormatter;\n+\n+\n+public class IndexUpgradeTool extends Configured {\n+\n+ private static final Logger LOGGER = Logger.getLogger(IndexUpgradeTool.class.getName());\n+\n+ private static final Option OPERATION_OPTION = new Option(\"o\", \"operation\", true,\n+ \"[Required]Operation to perform (upgrade/rollback)\");\n+ private static final Option TABLE_OPTION = new Option(\"tb\", \"table\", true,\n+ \"[Required]Tables and indexes list ex. table1: index1, index2, index3; table2: index4, index5\");\n+ private static final Option TABLE_CSV_FILE_OPTION = new Option(\"f\", \"file\", true,\n+ \"[Optional]Tables and indexes list in a csv file\");\n+ private static final Option DRY_RUN_OPTION = new Option(\"s\", \"show\", false,\n+ \"[Optional]If passed this will output steps that will be executed\");\n+ private static final Option HELP_OPTION = new Option(\"h\", \"help\", false, \"Help\");\n+ private static final Option CONNECTION_STRING_OPTION = new Option(\"c\", \"connection-string\", true, \"Connection string\");\n+ private static final Option LOG_FILE_OPTION = new Option(\"lf\", \"logfile\", true,\n+ \"Log file path where the logs are written\");\n+ private static final Option HOST_OPTION = new Option(\"ho\", \"host\", true, \"[Required]zookeeper quorum host\");\n+ private static final Option PORT_OPTION = new Option(\"po\", \"port\", true, \"[Required]zookeeper port\");\n+\n+ private static final String UPGRADE_OP = \"upgrade\";\n+ private static final String ROLLBACK_OP = \"rollback\";\n+\n+\n+ private static HashMap <String, Boolean> tableMC = new HashMap<>();\n+ private static Map<String, String> prop = new HashMap<>();\n+\n+ private static String connectionURL;\n+ private static boolean dryRun;\n+\n+ public static void main (String[] args) {\n+ CommandLine cmdLine = null;\n+ try {\n+ try {\n+ cmdLine = parseOptions(args);\n+ } catch (IllegalStateException e) {\n+ printHelpAndExit(e.getMessage(), getOptions());\n+ }\n+ String operation = cmdLine.getOptionValue(OPERATION_OPTION.getOpt());\n+ String tables = cmdLine.getOptionValue(TABLE_OPTION.getOpt());\n+ String host = cmdLine.getOptionValue(HOST_OPTION.getOpt());\n+ String port = cmdLine.getOptionValue(PORT_OPTION.getOpt());\n+ dryRun = Boolean.valueOf(cmdLine.getOptionValue(DRY_RUN_OPTION.getOpt()));\n+\n+ String logFile = cmdLine.getOptionValue(LOG_FILE_OPTION.getOpt());\n+ if (logFile != null) {\n+ FileHandler fh = new FileHandler(logFile);\n+ fh.setFormatter(new SimpleFormatter());\n+ LOGGER.addHandler(fh);\n+ }\n+ if (dryRun) {\n+ LOGGER.info(\"This is the beginning of the tool with dry run.\");\n+ }\n+ LOGGER.info(\"Index Upgrade tool initiated: \"+ String.join(\",\", args));\n+\n+ prop.put(Indexer.INDEX_BUILDER_CONF_KEY, PhoenixIndexBuilder.class.getName());\n+ prop.put(NonTxIndexBuilder.CODEC_CLASS_NAME_KEY, PhoenixIndexCodec.class.getName());\n+\n+ connectionURL = cmdLine.getOptionValue(CONNECTION_STRING_OPTION.getOpt());\n+\n+ if (connectionURL == null) {\n+ connectionURL = \"jdbc:phoenix:\"+host+\":\"+port;\n+ }\n+\n+ if (tables == null) {\n+ String tablesCsv = cmdLine.getOptionValue(TABLE_CSV_FILE_OPTION.getOpt());\n+ tables = new String(Files.readAllBytes(Paths.get(tablesCsv)));\n+ }\n+ LOGGER.info(\"list of tables/indexes passed: \"+ tables);\n+\n+ if (tables == null) {\n+ LOGGER.severe(\"tables' list is not available; use -tb or -f option\");\n+ System.exit(1);\n+ }\n+\n+ HashMap<String, ArrayList<String>> tablesAndIndexes = getTablesAndIndexes(tables);\n+\n+ if (operation.equalsIgnoreCase(UPGRADE_OP)) {\n+ LOGGER.info(\"Executing upgrade\");\n+ upgradeConsistencyFeature(tablesAndIndexes);\n+ } else if (operation.equalsIgnoreCase(ROLLBACK_OP)) {\n+ LOGGER.info(\"Executing rollback\");\n+ rollbackConsistencyFeature(tablesAndIndexes);\n+ } else {\n+ throw new IllegalStateException(\"Invalid option provided for \"+OPERATION_OPTION.getOpt()+\" expected values: {upgrade, rollback}\");\n+ }\n+\n+ } catch (IOException e) {\n+ LOGGER.severe(\"Something went wrong \"+e);\n+ }\n+ }\n+\n+ private static void upgradeConsistencyFeature(HashMap<String, ArrayList<String>> tablesAndIndexes) {\n+\n+ try {\n+ Connection conn = DriverManager.getConnection(connectionURL, new Properties());\n+ ConnectionQueryServices queryServices = conn.unwrap(PhoenixConnection.class).getQueryServices();\n+ Configuration conf = queryServices.getConfiguration();\n+ tablesAndIndexes.entrySet().parallelStream().forEach(entry -> {\n+\n+ try (Admin admin = queryServices.getAdmin()) {\n+\n+ String fullTableName = entry.getKey();\n+ PTable dataTable = PhoenixRuntime.getTableNoCache(conn, fullTableName);\n+ LOGGER.fine(\"Executing upgrade for \"+ fullTableName);\n+\n+ boolean mutable = !(dataTable.isImmutableRows());\n+\n+ checkAndWaitForMajorCompaction(admin, entry);\n+\n+ resetMajorCompaction(admin, entry);","path":"phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java","position":155,"original_position":155,"commit_id":"1ee11bfdcb2e9e5116e1f355e39dd471b4f2cd1a","original_commit_id":"1ee11bfdcb2e9e5116e1f355e39dd471b4f2cd1a","user":{"login":"priyankporwal","id":13446993,"node_id":"MDQ6VXNlcjEzNDQ2OTkz","avatar_url":"https://avatars0.githubusercontent.com/u/13446993?v=4","gravatar_id":"","url":"https://api.github.com/users/priyankporwal","html_url":"https://github.com/priyankporwal","followers_url":"https://api.github.com/users/priyankporwal/followers","following_url":"https://api.github.com/users/priyankporwal/following{/other_user}","gists_url":"https://api.github.com/users/priyankporwal/gists{/gist_id}","starred_url":"https://api.github.com/users/priyankporwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyankporwal/subscriptions","organizations_url":"https://api.github.com/users/priyankporwal/orgs","repos_url":"https://api.github.com/users/priyankporwal/repos","events_url":"https://api.github.com/users/priyankporwal/events{/privacy}","received_events_url":"https://api.github.com/users/priyankporwal/received_events","type":"User","site_admin":false},"body":"Don't we need to disable major compaction first and then wait for currently running ones to end? Otherwise, there's a slim window that another one can start between the two.","created_at":"2019-06-19T20:19:59Z","updated_at":"2019-06-19T20:20:00Z","html_url":"https://github.com/apache/phoenix/pull/520#discussion_r295506030","pull_request_url":"https://api.github.com/repos/apache/phoenix/pulls/520","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments/295506030"},"html":{"href":"https://github.com/apache/phoenix/pull/520#discussion_r295506030"},"pull_request":{"href":"https://api.github.com/repos/apache/phoenix/pulls/520"}}},"pull_request":{"url":"https://api.github.com/repos/apache/phoenix/pulls/520","id":289383896,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MzgzODk2","html_url":"https://github.com/apache/phoenix/pull/520","diff_url":"https://github.com/apache/phoenix/pull/520.diff","patch_url":"https://github.com/apache/phoenix/pull/520.patch","issue_url":"https://api.github.com/repos/apache/phoenix/issues/520","number":520,"state":"open","locked":false,"title":"PHOENIX-5333: A tool to upgrade existing tables/indexes to use self-c…","user":{"login":"swaroopak","id":3919279,"node_id":"MDQ6VXNlcjM5MTkyNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3919279?v=4","gravatar_id":"","url":"https://api.github.com/users/swaroopak","html_url":"https://github.com/swaroopak","followers_url":"https://api.github.com/users/swaroopak/followers","following_url":"https://api.github.com/users/swaroopak/following{/other_user}","gists_url":"https://api.github.com/users/swaroopak/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroopak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroopak/subscriptions","organizations_url":"https://api.github.com/users/swaroopak/orgs","repos_url":"https://api.github.com/users/swaroopak/repos","events_url":"https://api.github.com/users/swaroopak/events{/privacy}","received_events_url":"https://api.github.com/users/swaroopak/received_events","type":"User","site_admin":false},"body":"…onsistent global indexes design","created_at":"2019-06-18T17:38:41Z","updated_at":"2019-06-19T20:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9008cf411d4e1b0e1b78dd98a12b9d5530579058","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/phoenix/pulls/520/commits","review_comments_url":"https://api.github.com/repos/apache/phoenix/pulls/520/comments","review_comment_url":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/phoenix/issues/520/comments","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/1ee11bfdcb2e9e5116e1f355e39dd471b4f2cd1a","head":{"label":"swaroopak:PHOENIX-5333_master","ref":"PHOENIX-5333_master","sha":"1ee11bfdcb2e9e5116e1f355e39dd471b4f2cd1a","user":{"login":"swaroopak","id":3919279,"node_id":"MDQ6VXNlcjM5MTkyNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3919279?v=4","gravatar_id":"","url":"https://api.github.com/users/swaroopak","html_url":"https://github.com/swaroopak","followers_url":"https://api.github.com/users/swaroopak/followers","following_url":"https://api.github.com/users/swaroopak/following{/other_user}","gists_url":"https://api.github.com/users/swaroopak/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroopak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroopak/subscriptions","organizations_url":"https://api.github.com/users/swaroopak/orgs","repos_url":"https://api.github.com/users/swaroopak/repos","events_url":"https://api.github.com/users/swaroopak/events{/privacy}","received_events_url":"https://api.github.com/users/swaroopak/received_events","type":"User","site_admin":false},"repo":{"id":145614256,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MTQyNTY=","name":"phoenix","full_name":"swaroopak/phoenix","private":false,"owner":{"login":"swaroopak","id":3919279,"node_id":"MDQ6VXNlcjM5MTkyNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3919279?v=4","gravatar_id":"","url":"https://api.github.com/users/swaroopak","html_url":"https://github.com/swaroopak","followers_url":"https://api.github.com/users/swaroopak/followers","following_url":"https://api.github.com/users/swaroopak/following{/other_user}","gists_url":"https://api.github.com/users/swaroopak/gists{/gist_id}","starred_url":"https://api.github.com/users/swaroopak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaroopak/subscriptions","organizations_url":"https://api.github.com/users/swaroopak/orgs","repos_url":"https://api.github.com/users/swaroopak/repos","events_url":"https://api.github.com/users/swaroopak/events{/privacy}","received_events_url":"https://api.github.com/users/swaroopak/received_events","type":"User","site_admin":false},"html_url":"https://github.com/swaroopak/phoenix","description":"Mirror of Apache Phoenix","fork":true,"url":"https://api.github.com/repos/swaroopak/phoenix","forks_url":"https://api.github.com/repos/swaroopak/phoenix/forks","keys_url":"https://api.github.com/repos/swaroopak/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaroopak/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaroopak/phoenix/teams","hooks_url":"https://api.github.com/repos/swaroopak/phoenix/hooks","issue_events_url":"https://api.github.com/repos/swaroopak/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/swaroopak/phoenix/events","assignees_url":"https://api.github.com/repos/swaroopak/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/swaroopak/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/swaroopak/phoenix/tags","blobs_url":"https://api.github.com/repos/swaroopak/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaroopak/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaroopak/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaroopak/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaroopak/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/swaroopak/phoenix/languages","stargazers_url":"https://api.github.com/repos/swaroopak/phoenix/stargazers","contributors_url":"https://api.github.com/repos/swaroopak/phoenix/contributors","subscribers_url":"https://api.github.com/repos/swaroopak/phoenix/subscribers","subscription_url":"https://api.github.com/repos/swaroopak/phoenix/subscription","commits_url":"https://api.github.com/repos/swaroopak/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaroopak/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaroopak/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaroopak/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaroopak/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/swaroopak/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaroopak/phoenix/merges","archive_url":"https://api.github.com/repos/swaroopak/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaroopak/phoenix/downloads","issues_url":"https://api.github.com/repos/swaroopak/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/swaroopak/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/swaroopak/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/swaroopak/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaroopak/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/swaroopak/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/swaroopak/phoenix/deployments","created_at":"2018-08-21T20:11:14Z","updated_at":"2019-06-16T20:42:07Z","pushed_at":"2019-06-19T18:02:07Z","git_url":"git://github.com/swaroopak/phoenix.git","ssh_url":"git@github.com:swaroopak/phoenix.git","clone_url":"https://github.com/swaroopak/phoenix.git","svn_url":"https://github.com/swaroopak/phoenix","homepage":null,"size":50813,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"1f2508dbde365aaedac628c89df237e8b6b46df8","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20473418,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ3MzQxOA==","name":"phoenix","full_name":"apache/phoenix","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/phoenix","description":"Mirror of Apache Phoenix","fork":false,"url":"https://api.github.com/repos/apache/phoenix","forks_url":"https://api.github.com/repos/apache/phoenix/forks","keys_url":"https://api.github.com/repos/apache/phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/phoenix/teams","hooks_url":"https://api.github.com/repos/apache/phoenix/hooks","issue_events_url":"https://api.github.com/repos/apache/phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/apache/phoenix/events","assignees_url":"https://api.github.com/repos/apache/phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/apache/phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/apache/phoenix/tags","blobs_url":"https://api.github.com/repos/apache/phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/phoenix/languages","stargazers_url":"https://api.github.com/repos/apache/phoenix/stargazers","contributors_url":"https://api.github.com/repos/apache/phoenix/contributors","subscribers_url":"https://api.github.com/repos/apache/phoenix/subscribers","subscription_url":"https://api.github.com/repos/apache/phoenix/subscription","commits_url":"https://api.github.com/repos/apache/phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/apache/phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/phoenix/merges","archive_url":"https://api.github.com/repos/apache/phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/phoenix/downloads","issues_url":"https://api.github.com/repos/apache/phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/apache/phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/phoenix/labels{/name}","releases_url":"https://api.github.com/repos/apache/phoenix/releases{/id}","deployments_url":"https://api.github.com/repos/apache/phoenix/deployments","created_at":"2014-06-04T07:00:08Z","updated_at":"2019-06-19T05:51:31Z","pushed_at":"2019-06-19T18:34:17Z","git_url":"git://github.com/apache/phoenix.git","ssh_url":"git@github.com:apache/phoenix.git","clone_url":"https://github.com/apache/phoenix.git","svn_url":"https://github.com/apache/phoenix","homepage":null,"size":52664,"stargazers_count":643,"watchers_count":643,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":735,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":210,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":735,"open_issues":210,"watchers":643,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/phoenix/pulls/520"},"html":{"href":"https://github.com/apache/phoenix/pull/520"},"issue":{"href":"https://api.github.com/repos/apache/phoenix/issues/520"},"comments":{"href":"https://api.github.com/repos/apache/phoenix/issues/520/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/phoenix/pulls/520/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/phoenix/pulls/520/commits"},"statuses":{"href":"https://api.github.com/repos/apache/phoenix/statuses/1ee11bfdcb2e9e5116e1f355e39dd471b4f2cd1a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20473418,
"name": "apache/phoenix",
"url": "https://api.github.com/repos/apache/phoenix"
}
|
{
"id": 13446993,
"login": "priyankporwal",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13446993?",
"url": "https://api.github.com/users/priyankporwal"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-06-19T20:19:59 |
9855793108
|
{"actor":{"display_login":"priyankporwal"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/353331623","pull_request_review_id":326334492,"id":353331623,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzMzMTYyMw==","diff_hunk":"@@ -0,0 +1,31 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.solr.common.patterns;\n+\n+import static java.lang.annotation.ElementType.TYPE;\n+import static java.lang.annotation.RetentionPolicy.SOURCE;\n+\n+import java.lang.annotation.Documented;\n+import java.lang.annotation.Retention;\n+import java.lang.annotation.Target;\n+\n+@Documented\n+@Retention(SOURCE)\n+@Target(TYPE)\n+public @interface SolrSingleThreaded {","path":"solr/solrj/src/java/org/apache/solr/common/patterns/SolrSingleThreaded.java","position":29,"original_position":29,"commit_id":"b30c92c5d5a3877e0aec545dc2b6f9be548ec359","original_commit_id":"b30c92c5d5a3877e0aec545dc2b6f9be548ec359","user":{"login":"bruno-roustant","id":33934988,"node_id":"MDQ6VXNlcjMzOTM0OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/33934988?v=4","gravatar_id":"","url":"https://api.github.com/users/bruno-roustant","html_url":"https://github.com/bruno-roustant","followers_url":"https://api.github.com/users/bruno-roustant/followers","following_url":"https://api.github.com/users/bruno-roustant/following{/other_user}","gists_url":"https://api.github.com/users/bruno-roustant/gists{/gist_id}","starred_url":"https://api.github.com/users/bruno-roustant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruno-roustant/subscriptions","organizations_url":"https://api.github.com/users/bruno-roustant/orgs","repos_url":"https://api.github.com/users/bruno-roustant/repos","events_url":"https://api.github.com/users/bruno-roustant/events{/privacy}","received_events_url":"https://api.github.com/users/bruno-roustant/received_events","type":"User","site_admin":false},"body":"Can we add a small javadoc explaining the intention and expected usage of this annotation?","created_at":"2019-12-03T17:53:42Z","updated_at":"2019-12-03T17:56:17Z","html_url":"https://github.com/apache/lucene-solr/pull/1053#discussion_r353331623","pull_request_url":"https://api.github.com/repos/apache/lucene-solr/pulls/1053","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments/353331623"},"html":{"href":"https://github.com/apache/lucene-solr/pull/1053#discussion_r353331623"},"pull_request":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/1053","id":348244820,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4MjQ0ODIw","html_url":"https://github.com/apache/lucene-solr/pull/1053","diff_url":"https://github.com/apache/lucene-solr/pull/1053.diff","patch_url":"https://github.com/apache/lucene-solr/pull/1053.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/1053","number":1053,"state":"open","locked":false,"title":"SOLR-13998: Add thread safety annotations to classes","user":{"login":"anshumg","id":3208161,"node_id":"MDQ6VXNlcjMyMDgxNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3208161?v=4","gravatar_id":"","url":"https://api.github.com/users/anshumg","html_url":"https://github.com/anshumg","followers_url":"https://api.github.com/users/anshumg/followers","following_url":"https://api.github.com/users/anshumg/following{/other_user}","gists_url":"https://api.github.com/users/anshumg/gists{/gist_id}","starred_url":"https://api.github.com/users/anshumg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshumg/subscriptions","organizations_url":"https://api.github.com/users/anshumg/orgs","repos_url":"https://api.github.com/users/anshumg/repos","events_url":"https://api.github.com/users/anshumg/events{/privacy}","received_events_url":"https://api.github.com/users/anshumg/received_events","type":"User","site_admin":false},"body":"Add thread safety annotations to classes. \r\n\r\nThe current commit only introduces the annotations, but the actual annotations will take some time but are wip. We can then use these to add information to existing classes, as well as new classes.\r\n\r\n# Checklist\r\n\r\nPlease review the following and check all that apply:\r\n\r\n- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.\r\n- [ ] I have created a Jira issue and added the issue ID to my pull request title.\r\n- [ ] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.\r\n- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)\r\n- [ ] I have developed this patch against the `master` branch.\r\n- [ ] I have run `ant precommit` and the appropriate test suite.\r\n- [ ] I have added tests for my changes.\r\n- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).\r\n","created_at":"2019-12-03T10:24:17Z","updated_at":"2019-12-03T17:56:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3df8106eba821aa533bd11e794755e6e664120a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/1053/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/b30c92c5d5a3877e0aec545dc2b6f9be548ec359","head":{"label":"anshumg:multithreading-annotations","ref":"multithreading-annotations","sha":"b30c92c5d5a3877e0aec545dc2b6f9be548ec359","user":{"login":"anshumg","id":3208161,"node_id":"MDQ6VXNlcjMyMDgxNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3208161?v=4","gravatar_id":"","url":"https://api.github.com/users/anshumg","html_url":"https://github.com/anshumg","followers_url":"https://api.github.com/users/anshumg/followers","following_url":"https://api.github.com/users/anshumg/following{/other_user}","gists_url":"https://api.github.com/users/anshumg/gists{/gist_id}","starred_url":"https://api.github.com/users/anshumg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshumg/subscriptions","organizations_url":"https://api.github.com/users/anshumg/orgs","repos_url":"https://api.github.com/users/anshumg/repos","events_url":"https://api.github.com/users/anshumg/events{/privacy}","received_events_url":"https://api.github.com/users/anshumg/received_events","type":"User","site_admin":false},"repo":{"id":191051444,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEwNTE0NDQ=","name":"lucene-solr","full_name":"anshumg/lucene-solr","private":false,"owner":{"login":"anshumg","id":3208161,"node_id":"MDQ6VXNlcjMyMDgxNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3208161?v=4","gravatar_id":"","url":"https://api.github.com/users/anshumg","html_url":"https://github.com/anshumg","followers_url":"https://api.github.com/users/anshumg/followers","following_url":"https://api.github.com/users/anshumg/following{/other_user}","gists_url":"https://api.github.com/users/anshumg/gists{/gist_id}","starred_url":"https://api.github.com/users/anshumg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshumg/subscriptions","organizations_url":"https://api.github.com/users/anshumg/orgs","repos_url":"https://api.github.com/users/anshumg/repos","events_url":"https://api.github.com/users/anshumg/events{/privacy}","received_events_url":"https://api.github.com/users/anshumg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anshumg/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/anshumg/lucene-solr","forks_url":"https://api.github.com/repos/anshumg/lucene-solr/forks","keys_url":"https://api.github.com/repos/anshumg/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anshumg/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anshumg/lucene-solr/teams","hooks_url":"https://api.github.com/repos/anshumg/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/anshumg/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/anshumg/lucene-solr/events","assignees_url":"https://api.github.com/repos/anshumg/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/anshumg/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/anshumg/lucene-solr/tags","blobs_url":"https://api.github.com/repos/anshumg/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anshumg/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anshumg/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/anshumg/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anshumg/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/anshumg/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/anshumg/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/anshumg/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/anshumg/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/anshumg/lucene-solr/subscription","commits_url":"https://api.github.com/repos/anshumg/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/anshumg/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/anshumg/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/anshumg/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/anshumg/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/anshumg/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anshumg/lucene-solr/merges","archive_url":"https://api.github.com/repos/anshumg/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anshumg/lucene-solr/downloads","issues_url":"https://api.github.com/repos/anshumg/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/anshumg/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/anshumg/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/anshumg/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anshumg/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/anshumg/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/anshumg/lucene-solr/deployments","created_at":"2019-06-09T20:18:37Z","updated_at":"2019-12-03T09:15:26Z","pushed_at":"2019-12-03T11:06:10Z","git_url":"git://github.com/anshumg/lucene-solr.git","ssh_url":"git@github.com:anshumg/lucene-solr.git","clone_url":"https://github.com/anshumg/lucene-solr.git","svn_url":"https://github.com/anshumg/lucene-solr","homepage":null,"size":419507,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"441abb83199088a9fd08adbd40f3ab8a73ac5a36","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIyOTQ4Nw==","name":"lucene-solr","full_name":"apache/lucene-solr","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/lucene-solr","description":"Apache Lucene and Solr open-source search software","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2019-12-03T17:23:42Z","pushed_at":"2019-12-03T17:46:30Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":"https://lucene.apache.org/","size":490362,"stargazers_count":3095,"watchers_count":3095,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2173,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":236,"license":null,"forks":2173,"open_issues":236,"watchers":3095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/1053"},"html":{"href":"https://github.com/apache/lucene-solr/pull/1053"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/1053"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/b30c92c5d5a3877e0aec545dc2b6f9be548ec359"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 50229487,
"name": "apache/lucene-solr",
"url": "https://api.github.com/repos/apache/lucene-solr"
}
|
{
"id": 33934988,
"login": "bruno-roustant",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33934988?",
"url": "https://api.github.com/users/bruno-roustant"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-12-03T17:53:42 |
11002196966
|
{"actor":{"display_login":"bruno-roustant"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/comments/329003103","pull_request_review_id":294231164,"id":329003103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTAwMzEwMw==","diff_hunk":"@@ -201,6 +201,11 @@\n <groupId>org.hamcrest</groupId>\n <artifactId>hamcrest-all</artifactId>\n </dependency>\n+ <dependency>\n+ <groupId>org.apache.kafka</groupId>\n+ <artifactId>kafka-clients</artifactId>\n+ <version>2.1.1</version>","path":"alpha/alpha-server/pom.xml","position":null,"original_position":7,"commit_id":"31c67d016e3c7cfa53810d609ee0eed91a08c4d3","original_commit_id":"694623f87478cf8b9a3ea9069c0257d8f939383c","user":{"login":"coolbeevip","id":4271525,"node_id":"MDQ6VXNlcjQyNzE1MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4271525?v=4","gravatar_id":"","url":"https://api.github.com/users/coolbeevip","html_url":"https://github.com/coolbeevip","followers_url":"https://api.github.com/users/coolbeevip/followers","following_url":"https://api.github.com/users/coolbeevip/following{/other_user}","gists_url":"https://api.github.com/users/coolbeevip/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbeevip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbeevip/subscriptions","organizations_url":"https://api.github.com/users/coolbeevip/orgs","repos_url":"https://api.github.com/users/coolbeevip/repos","events_url":"https://api.github.com/users/coolbeevip/events{/privacy}","received_events_url":"https://api.github.com/users/coolbeevip/received_events","type":"User","site_admin":false},"body":"Thank you for reminding me，I have just fixed it","created_at":"2019-09-27T10:07:10Z","updated_at":"2019-09-27T10:07:10Z","html_url":"https://github.com/apache/servicecomb-pack/pull/564#discussion_r329003103","pull_request_url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/comments/329003103"},"html":{"href":"https://github.com/apache/servicecomb-pack/pull/564#discussion_r329003103"},"pull_request":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564"}},"in_reply_to_id":328996005},"pull_request":{"url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564","id":322076176,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyMDc2MTc2","html_url":"https://github.com/apache/servicecomb-pack/pull/564","diff_url":"https://github.com/apache/servicecomb-pack/pull/564.diff","patch_url":"https://github.com/apache/servicecomb-pack/pull/564.patch","issue_url":"https://api.github.com/repos/apache/servicecomb-pack/issues/564","number":564,"state":"open","locked":false,"title":"[SCB-1368] Scalability using Sharding from Akka Cluster","user":{"login":"coolbeevip","id":4271525,"node_id":"MDQ6VXNlcjQyNzE1MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4271525?v=4","gravatar_id":"","url":"https://api.github.com/users/coolbeevip","html_url":"https://github.com/coolbeevip","followers_url":"https://api.github.com/users/coolbeevip/followers","following_url":"https://api.github.com/users/coolbeevip/following{/other_user}","gists_url":"https://api.github.com/users/coolbeevip/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbeevip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbeevip/subscriptions","organizations_url":"https://api.github.com/users/coolbeevip/orgs","repos_url":"https://api.github.com/users/coolbeevip/repos","events_url":"https://api.github.com/users/coolbeevip/events{/privacy}","received_events_url":"https://api.github.com/users/coolbeevip/received_events","type":"User","site_admin":false},"body":"1. manage to distribute actors across several nodes in the cluster\r\n2. SagaActor automatically recovers when JVM crashes","created_at":"2019-09-27T09:24:18Z","updated_at":"2019-09-27T10:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf71741db7e6bb44ab3490be85a35e19f81504fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564/commits","review_comments_url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564/comments","review_comment_url":"https://api.github.com/repos/apache/servicecomb-pack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/servicecomb-pack/issues/564/comments","statuses_url":"https://api.github.com/repos/apache/servicecomb-pack/statuses/31c67d016e3c7cfa53810d609ee0eed91a08c4d3","head":{"label":"coolbeevip:SCB-1368","ref":"SCB-1368","sha":"31c67d016e3c7cfa53810d609ee0eed91a08c4d3","user":{"login":"coolbeevip","id":4271525,"node_id":"MDQ6VXNlcjQyNzE1MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4271525?v=4","gravatar_id":"","url":"https://api.github.com/users/coolbeevip","html_url":"https://github.com/coolbeevip","followers_url":"https://api.github.com/users/coolbeevip/followers","following_url":"https://api.github.com/users/coolbeevip/following{/other_user}","gists_url":"https://api.github.com/users/coolbeevip/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbeevip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbeevip/subscriptions","organizations_url":"https://api.github.com/users/coolbeevip/orgs","repos_url":"https://api.github.com/users/coolbeevip/repos","events_url":"https://api.github.com/users/coolbeevip/events{/privacy}","received_events_url":"https://api.github.com/users/coolbeevip/received_events","type":"User","site_admin":false},"repo":{"id":166359852,"node_id":"MDEwOlJlcG9zaXRvcnkxNjYzNTk4NTI=","name":"servicecomb-pack","full_name":"coolbeevip/servicecomb-pack","private":false,"owner":{"login":"coolbeevip","id":4271525,"node_id":"MDQ6VXNlcjQyNzE1MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4271525?v=4","gravatar_id":"","url":"https://api.github.com/users/coolbeevip","html_url":"https://github.com/coolbeevip","followers_url":"https://api.github.com/users/coolbeevip/followers","following_url":"https://api.github.com/users/coolbeevip/following{/other_user}","gists_url":"https://api.github.com/users/coolbeevip/gists{/gist_id}","starred_url":"https://api.github.com/users/coolbeevip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coolbeevip/subscriptions","organizations_url":"https://api.github.com/users/coolbeevip/orgs","repos_url":"https://api.github.com/users/coolbeevip/repos","events_url":"https://api.github.com/users/coolbeevip/events{/privacy}","received_events_url":"https://api.github.com/users/coolbeevip/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coolbeevip/servicecomb-pack","description":"Apache ServiceComb Saga","fork":true,"url":"https://api.github.com/repos/coolbeevip/servicecomb-pack","forks_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/forks","keys_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/teams","hooks_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/hooks","issue_events_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/issues/events{/number}","events_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/events","assignees_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/assignees{/user}","branches_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/branches{/branch}","tags_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/tags","blobs_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/languages","stargazers_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/stargazers","contributors_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/contributors","subscribers_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/subscribers","subscription_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/subscription","commits_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/contents/{+path}","compare_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/merges","archive_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/downloads","issues_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/issues{/number}","pulls_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/labels{/name}","releases_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/releases{/id}","deployments_url":"https://api.github.com/repos/coolbeevip/servicecomb-pack/deployments","created_at":"2019-01-18T07:02:44Z","updated_at":"2019-08-28T01:45:28Z","pushed_at":"2019-09-27T10:06:06Z","git_url":"git://github.com/coolbeevip/servicecomb-pack.git","ssh_url":"git@github.com:coolbeevip/servicecomb-pack.git","clone_url":"https://github.com/coolbeevip/servicecomb-pack.git","svn_url":"https://github.com/coolbeevip/servicecomb-pack","homepage":"https://servicecomb.apache.org/","size":13769,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"6d5bef913b49d221cfc755e3e7eb3e9d7e6d38fe","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":97573661,"node_id":"MDEwOlJlcG9zaXRvcnk5NzU3MzY2MQ==","name":"servicecomb-pack","full_name":"apache/servicecomb-pack","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/servicecomb-pack","description":"Apache ServiceComb Pack is an eventually data consistency solution for micro-service applications. ServiceComb Pack currently provides TCC and Saga distributed transaction co-ordination solutions by using Alpha as a transaction coordinator and Omega as an transaction agent .","fork":false,"url":"https://api.github.com/repos/apache/servicecomb-pack","forks_url":"https://api.github.com/repos/apache/servicecomb-pack/forks","keys_url":"https://api.github.com/repos/apache/servicecomb-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/servicecomb-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/servicecomb-pack/teams","hooks_url":"https://api.github.com/repos/apache/servicecomb-pack/hooks","issue_events_url":"https://api.github.com/repos/apache/servicecomb-pack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/servicecomb-pack/events","assignees_url":"https://api.github.com/repos/apache/servicecomb-pack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/servicecomb-pack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/servicecomb-pack/tags","blobs_url":"https://api.github.com/repos/apache/servicecomb-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/servicecomb-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/servicecomb-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/servicecomb-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/servicecomb-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/servicecomb-pack/languages","stargazers_url":"https://api.github.com/repos/apache/servicecomb-pack/stargazers","contributors_url":"https://api.github.com/repos/apache/servicecomb-pack/contributors","subscribers_url":"https://api.github.com/repos/apache/servicecomb-pack/subscribers","subscription_url":"https://api.github.com/repos/apache/servicecomb-pack/subscription","commits_url":"https://api.github.com/repos/apache/servicecomb-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/servicecomb-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/servicecomb-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/servicecomb-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/servicecomb-pack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/servicecomb-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/servicecomb-pack/merges","archive_url":"https://api.github.com/repos/apache/servicecomb-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/servicecomb-pack/downloads","issues_url":"https://api.github.com/repos/apache/servicecomb-pack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/servicecomb-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/servicecomb-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/servicecomb-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/servicecomb-pack/labels{/name}","releases_url":"https://api.github.com/repos/apache/servicecomb-pack/releases{/id}","deployments_url":"https://api.github.com/repos/apache/servicecomb-pack/deployments","created_at":"2017-07-18T08:27:38Z","updated_at":"2019-09-27T06:02:14Z","pushed_at":"2019-09-27T10:06:08Z","git_url":"git://github.com/apache/servicecomb-pack.git","ssh_url":"git@github.com:apache/servicecomb-pack.git","clone_url":"https://github.com/apache/servicecomb-pack.git","svn_url":"https://github.com/apache/servicecomb-pack","homepage":"https://servicecomb.apache.org/","size":13728,"stargazers_count":1072,"watchers_count":1072,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":316,"open_issues":44,"watchers":1072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564"},"html":{"href":"https://github.com/apache/servicecomb-pack/pull/564"},"issue":{"href":"https://api.github.com/repos/apache/servicecomb-pack/issues/564"},"comments":{"href":"https://api.github.com/repos/apache/servicecomb-pack/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/servicecomb-pack/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/apache/servicecomb-pack/statuses/31c67d016e3c7cfa53810d609ee0eed91a08c4d3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 97573661,
"name": "apache/servicecomb-pack",
"url": "https://api.github.com/repos/apache/servicecomb-pack"
}
|
{
"id": 4271525,
"login": "coolbeevip",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4271525?",
"url": "https://api.github.com/users/coolbeevip"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-09-27T10:07:10 |
10509089148
|
{"actor":{"display_login":"coolbeevip"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/354142252","pull_request_review_id":327347380,"id":354142252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDE0MjI1Mg==","diff_hunk":"@@ -0,0 +1,172 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements. See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership. The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.flink.table.util;\n+\n+import org.apache.flink.annotation.Experimental;\n+import org.apache.flink.api.common.ExecutionConfig;\n+import org.apache.flink.api.common.JobExecutionResult;\n+import org.apache.flink.api.common.accumulators.Accumulator;\n+import org.apache.flink.api.common.accumulators.SerializedListAccumulator;\n+import org.apache.flink.api.common.typeinfo.TypeInformation;\n+import org.apache.flink.api.common.typeutils.TypeSerializer;\n+import org.apache.flink.api.java.Utils;\n+import org.apache.flink.streaming.api.datastream.DataStream;\n+import org.apache.flink.streaming.api.datastream.DataStreamSink;\n+import org.apache.flink.table.api.DataTypes;\n+import org.apache.flink.table.api.Table;\n+import org.apache.flink.table.api.TableEnvironment;\n+import org.apache.flink.table.api.TableSchema;\n+import org.apache.flink.table.api.internal.TableImpl;\n+import org.apache.flink.table.runtime.types.LogicalTypeDataTypeConverter;\n+import org.apache.flink.table.runtime.types.TypeInfoDataTypeConverter;\n+import org.apache.flink.table.sinks.AppendStreamTableSink;\n+import org.apache.flink.table.sinks.TableSink;\n+import org.apache.flink.table.types.DataType;\n+import org.apache.flink.table.types.logical.TimestampKind;\n+import org.apache.flink.table.types.logical.TimestampType;\n+import org.apache.flink.types.Row;\n+import org.apache.flink.util.AbstractID;\n+\n+import java.util.ArrayList;\n+import java.util.List;\n+\n+/**\n+ * A collection of utilities for fetching table results.\n+ *\n+ * <p>NOTE: Methods in this utility class are experimental and can only be used for demonstration or testing\n+ * small table results. Please DO NOT use them in production or on large tables.\n+ *\n+ * <p>We ought to put this class in the api module, but as converting high precision timestamp data type\n+ * to type information is not possible in flink planner, we have to put this class in blink planner.\n+ */\n+@Experimental\n+public class TableResultUtils {\n+\n+\t/**\n+\t * Convert Flink table to Java list.\n+\t * This method is only applicable for small batch jobs and small finite append only stream jobs.\n+\t *\n+\t * @param table\t\tFlink table to convert\n+\t * @return\t\t\tConverted Java list\n+\t */\n+\t@SuppressWarnings(\"unchecked\")\n+\tpublic static List<Row> tableResultToList(Table table) throws Exception {","path":"flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/util/TableResultUtils.java","position":69,"original_position":69,"commit_id":"bc4de56bf139c87490c24c8bcb6424a52292ead9","original_commit_id":"bc4de56bf139c87490c24c8bcb6424a52292ead9","user":{"login":"TsReaper","id":19909549,"node_id":"MDQ6VXNlcjE5OTA5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/19909549?v=4","gravatar_id":"","url":"https://api.github.com/users/TsReaper","html_url":"https://github.com/TsReaper","followers_url":"https://api.github.com/users/TsReaper/followers","following_url":"https://api.github.com/users/TsReaper/following{/other_user}","gists_url":"https://api.github.com/users/TsReaper/gists{/gist_id}","starred_url":"https://api.github.com/users/TsReaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsReaper/subscriptions","organizations_url":"https://api.github.com/users/TsReaper/orgs","repos_url":"https://api.github.com/users/TsReaper/repos","events_url":"https://api.github.com/users/TsReaper/events{/privacy}","received_events_url":"https://api.github.com/users/TsReaper/received_events","type":"User","site_admin":false},"body":"We might want to change table result to iterator in the future, so it is necessary to distinct them from method names.","created_at":"2019-12-05T07:22:27Z","updated_at":"2019-12-05T07:22:27Z","html_url":"https://github.com/apache/flink/pull/10306#discussion_r354142252","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/10306","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/354142252"},"html":{"href":"https://github.com/apache/flink/pull/10306#discussion_r354142252"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/10306"}},"in_reply_to_id":354135147},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/10306","id":345053301,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1MDUzMzAx","html_url":"https://github.com/apache/flink/pull/10306","diff_url":"https://github.com/apache/flink/pull/10306.diff","patch_url":"https://github.com/apache/flink/pull/10306.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/10306","number":10306,"state":"open","locked":false,"title":"[FLINK-13943][table-api] Provide utility method to convert Flink table to Java List","user":{"login":"TsReaper","id":19909549,"node_id":"MDQ6VXNlcjE5OTA5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/19909549?v=4","gravatar_id":"","url":"https://api.github.com/users/TsReaper","html_url":"https://github.com/TsReaper","followers_url":"https://api.github.com/users/TsReaper/followers","following_url":"https://api.github.com/users/TsReaper/following{/other_user}","gists_url":"https://api.github.com/users/TsReaper/gists{/gist_id}","starred_url":"https://api.github.com/users/TsReaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsReaper/subscriptions","organizations_url":"https://api.github.com/users/TsReaper/orgs","repos_url":"https://api.github.com/users/TsReaper/repos","events_url":"https://api.github.com/users/TsReaper/events{/privacy}","received_events_url":"https://api.github.com/users/TsReaper/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\n\r\nSome users would like to convert Flink table to Java List for demo or testing purpose. This PR introduces a utility method `TableResultUtils#tableResultToList` to convert Flink tables to lists.\r\n\r\nAs the new utility method is experimental, we currently are not going to introduce a new `Table#collect` API. If users find this utility method satisfying to use, we will then propose a FLIP for `Table#collect`.\r\n\r\n## Brief change log\r\n\r\n - Introduce `TableResultUtils#tableResultToList`\r\n\r\n## Verifying this change\r\n\r\nThis change added tests and can be verified as follows: run the newly added `TableResultUtilsITCase`.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): no\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no\r\n - The serializers: no\r\n - The runtime per-record code paths (performance sensitive): no\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no\r\n - The S3 file system connector: no\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? no\r\n - If yes, how is the feature documented? not applicable\r\n","created_at":"2019-11-25T07:03:12Z","updated_at":"2019-12-05T07:22:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"516946b1ff2f4cfbfd7784e5d282b496420f04ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1289893384,"node_id":"MDU6TGFiZWwxMjg5ODkzMzg0","url":"https://api.github.com/repos/apache/flink/labels/component=TableSQL/API","name":"component=TableSQL/API","color":"175fb7","default":false,"description":null},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/10306/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/10306/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/10306/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/bc4de56bf139c87490c24c8bcb6424a52292ead9","head":{"label":"TsReaper:table-collect","ref":"table-collect","sha":"bc4de56bf139c87490c24c8bcb6424a52292ead9","user":{"login":"TsReaper","id":19909549,"node_id":"MDQ6VXNlcjE5OTA5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/19909549?v=4","gravatar_id":"","url":"https://api.github.com/users/TsReaper","html_url":"https://github.com/TsReaper","followers_url":"https://api.github.com/users/TsReaper/followers","following_url":"https://api.github.com/users/TsReaper/following{/other_user}","gists_url":"https://api.github.com/users/TsReaper/gists{/gist_id}","starred_url":"https://api.github.com/users/TsReaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsReaper/subscriptions","organizations_url":"https://api.github.com/users/TsReaper/orgs","repos_url":"https://api.github.com/users/TsReaper/repos","events_url":"https://api.github.com/users/TsReaper/events{/privacy}","received_events_url":"https://api.github.com/users/TsReaper/received_events","type":"User","site_admin":false},"repo":{"id":195961779,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU5NjE3Nzk=","name":"flink","full_name":"TsReaper/flink","private":false,"owner":{"login":"TsReaper","id":19909549,"node_id":"MDQ6VXNlcjE5OTA5NTQ5","avatar_url":"https://avatars3.githubusercontent.com/u/19909549?v=4","gravatar_id":"","url":"https://api.github.com/users/TsReaper","html_url":"https://github.com/TsReaper","followers_url":"https://api.github.com/users/TsReaper/followers","following_url":"https://api.github.com/users/TsReaper/following{/other_user}","gists_url":"https://api.github.com/users/TsReaper/gists{/gist_id}","starred_url":"https://api.github.com/users/TsReaper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsReaper/subscriptions","organizations_url":"https://api.github.com/users/TsReaper/orgs","repos_url":"https://api.github.com/users/TsReaper/repos","events_url":"https://api.github.com/users/TsReaper/events{/privacy}","received_events_url":"https://api.github.com/users/TsReaper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TsReaper/flink","description":"Apache Flink","fork":true,"url":"https://api.github.com/repos/TsReaper/flink","forks_url":"https://api.github.com/repos/TsReaper/flink/forks","keys_url":"https://api.github.com/repos/TsReaper/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TsReaper/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TsReaper/flink/teams","hooks_url":"https://api.github.com/repos/TsReaper/flink/hooks","issue_events_url":"https://api.github.com/repos/TsReaper/flink/issues/events{/number}","events_url":"https://api.github.com/repos/TsReaper/flink/events","assignees_url":"https://api.github.com/repos/TsReaper/flink/assignees{/user}","branches_url":"https://api.github.com/repos/TsReaper/flink/branches{/branch}","tags_url":"https://api.github.com/repos/TsReaper/flink/tags","blobs_url":"https://api.github.com/repos/TsReaper/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TsReaper/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TsReaper/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/TsReaper/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TsReaper/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/TsReaper/flink/languages","stargazers_url":"https://api.github.com/repos/TsReaper/flink/stargazers","contributors_url":"https://api.github.com/repos/TsReaper/flink/contributors","subscribers_url":"https://api.github.com/repos/TsReaper/flink/subscribers","subscription_url":"https://api.github.com/repos/TsReaper/flink/subscription","commits_url":"https://api.github.com/repos/TsReaper/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/TsReaper/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/TsReaper/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/TsReaper/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/TsReaper/flink/contents/{+path}","compare_url":"https://api.github.com/repos/TsReaper/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TsReaper/flink/merges","archive_url":"https://api.github.com/repos/TsReaper/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TsReaper/flink/downloads","issues_url":"https://api.github.com/repos/TsReaper/flink/issues{/number}","pulls_url":"https://api.github.com/repos/TsReaper/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/TsReaper/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/TsReaper/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TsReaper/flink/labels{/name}","releases_url":"https://api.github.com/repos/TsReaper/flink/releases{/id}","deployments_url":"https://api.github.com/repos/TsReaper/flink/deployments","created_at":"2019-07-09T08:02:30Z","updated_at":"2019-07-09T08:03:11Z","pushed_at":"2019-12-05T06:41:02Z","git_url":"git://github.com/TsReaper/flink.git","ssh_url":"git@github.com:TsReaper/flink.git","clone_url":"https://github.com/TsReaper/flink.git","svn_url":"https://github.com/TsReaper/flink","homepage":"","size":269795,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f49e632bb290ded45b320f5d00ceaa1543a6bb1c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2019-12-05T07:19:25Z","pushed_at":"2019-12-05T07:19:20Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":271587,"stargazers_count":11307,"watchers_count":11307,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6034,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":470,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6034,"open_issues":470,"watchers":11307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/10306"},"html":{"href":"https://github.com/apache/flink/pull/10306"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/10306"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/10306/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/10306/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/10306/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/bc4de56bf139c87490c24c8bcb6424a52292ead9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
}
|
{
"id": 19909549,
"login": "TsReaper",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19909549?",
"url": "https://api.github.com/users/TsReaper"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-12-05T07:22:27 |
11017046447
|
{"actor":{"display_login":"TsReaper"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-doris/pulls/comments/324232218","pull_request_review_id":288070302,"id":324232218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDIzMjIxOA==","diff_hunk":"@@ -165,8 +173,7 @@ protected void runPendingJob() {\n try {\n OlapTable tbl = (OlapTable) db.getTable(tableId);\n if (tbl == null) {\n- cancelImpl(\"Table \" + tableId + \" does not exist\");\n- return;\n+ return new Status(TStatusCode.CANCELLED, \"Table \" + tableId + \" does not exist\");","path":"fe/src/main/java/org/apache/doris/alter/RollupJobV2.java","position":null,"original_position":42,"commit_id":"b8746a3edf0897a773e831de10bfcdf419376cb7","original_commit_id":"27e96e30cdcd844e7edd78a1037653041aaa97f9","user":{"login":"morningman","id":2899462,"node_id":"MDQ6VXNlcjI4OTk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2899462?v=4","gravatar_id":"","url":"https://api.github.com/users/morningman","html_url":"https://github.com/morningman","followers_url":"https://api.github.com/users/morningman/followers","following_url":"https://api.github.com/users/morningman/following{/other_user}","gists_url":"https://api.github.com/users/morningman/gists{/gist_id}","starred_url":"https://api.github.com/users/morningman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morningman/subscriptions","organizations_url":"https://api.github.com/users/morningman/orgs","repos_url":"https://api.github.com/users/morningman/repos","events_url":"https://api.github.com/users/morningman/events{/privacy}","received_events_url":"https://api.github.com/users/morningman/received_events","type":"User","site_admin":false},"body":"As you wish","created_at":"2019-09-13T14:54:06Z","updated_at":"2019-09-13T14:54:06Z","html_url":"https://github.com/apache/incubator-doris/pull/1800#discussion_r324232218","pull_request_url":"https://api.github.com/repos/apache/incubator-doris/pulls/1800","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/comments/324232218"},"html":{"href":"https://github.com/apache/incubator-doris/pull/1800#discussion_r324232218"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/1800"}},"in_reply_to_id":323807996},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-doris/pulls/1800","id":316953145,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2OTUzMTQ1","html_url":"https://github.com/apache/incubator-doris/pull/1800","diff_url":"https://github.com/apache/incubator-doris/pull/1800.diff","patch_url":"https://github.com/apache/incubator-doris/pull/1800.patch","issue_url":"https://api.github.com/repos/apache/incubator-doris/issues/1800","number":1800,"state":"open","locked":false,"title":"Fix bug that dead lock may happen when drop table during alter table process","user":{"login":"morningman","id":2899462,"node_id":"MDQ6VXNlcjI4OTk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2899462?v=4","gravatar_id":"","url":"https://api.github.com/users/morningman","html_url":"https://github.com/morningman","followers_url":"https://api.github.com/users/morningman/followers","following_url":"https://api.github.com/users/morningman/following{/other_user}","gists_url":"https://api.github.com/users/morningman/gists{/gist_id}","starred_url":"https://api.github.com/users/morningman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morningman/subscriptions","organizations_url":"https://api.github.com/users/morningman/orgs","repos_url":"https://api.github.com/users/morningman/repos","events_url":"https://api.github.com/users/morningman/events{/privacy}","received_events_url":"https://api.github.com/users/morningman/received_events","type":"User","site_admin":false},"body":"The cancel() function will try get database's write lock, while its caller may already\r\nhold the database's read lock.","created_at":"2019-09-12T15:02:09Z","updated_at":"2019-09-13T14:54:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ed1bd965b08cda211a6e41f7cf00f55e4a599d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-doris/pulls/1800/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-doris/pulls/1800/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-doris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-doris/issues/1800/comments","statuses_url":"https://api.github.com/repos/apache/incubator-doris/statuses/b8746a3edf0897a773e831de10bfcdf419376cb7","head":{"label":"morningman:fix_alter_job_v2_deadlock","ref":"fix_alter_job_v2_deadlock","sha":"b8746a3edf0897a773e831de10bfcdf419376cb7","user":{"login":"morningman","id":2899462,"node_id":"MDQ6VXNlcjI4OTk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2899462?v=4","gravatar_id":"","url":"https://api.github.com/users/morningman","html_url":"https://github.com/morningman","followers_url":"https://api.github.com/users/morningman/followers","following_url":"https://api.github.com/users/morningman/following{/other_user}","gists_url":"https://api.github.com/users/morningman/gists{/gist_id}","starred_url":"https://api.github.com/users/morningman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morningman/subscriptions","organizations_url":"https://api.github.com/users/morningman/orgs","repos_url":"https://api.github.com/users/morningman/repos","events_url":"https://api.github.com/users/morningman/events{/privacy}","received_events_url":"https://api.github.com/users/morningman/received_events","type":"User","site_admin":false},"repo":{"id":155175398,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNzUzOTg=","name":"incubator-doris","full_name":"morningman/incubator-doris","private":false,"owner":{"login":"morningman","id":2899462,"node_id":"MDQ6VXNlcjI4OTk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/2899462?v=4","gravatar_id":"","url":"https://api.github.com/users/morningman","html_url":"https://github.com/morningman","followers_url":"https://api.github.com/users/morningman/followers","following_url":"https://api.github.com/users/morningman/following{/other_user}","gists_url":"https://api.github.com/users/morningman/gists{/gist_id}","starred_url":"https://api.github.com/users/morningman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morningman/subscriptions","organizations_url":"https://api.github.com/users/morningman/orgs","repos_url":"https://api.github.com/users/morningman/repos","events_url":"https://api.github.com/users/morningman/events{/privacy}","received_events_url":"https://api.github.com/users/morningman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/morningman/incubator-doris","description":"Apache Doris (Incubating)","fork":true,"url":"https://api.github.com/repos/morningman/incubator-doris","forks_url":"https://api.github.com/repos/morningman/incubator-doris/forks","keys_url":"https://api.github.com/repos/morningman/incubator-doris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/morningman/incubator-doris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/morningman/incubator-doris/teams","hooks_url":"https://api.github.com/repos/morningman/incubator-doris/hooks","issue_events_url":"https://api.github.com/repos/morningman/incubator-doris/issues/events{/number}","events_url":"https://api.github.com/repos/morningman/incubator-doris/events","assignees_url":"https://api.github.com/repos/morningman/incubator-doris/assignees{/user}","branches_url":"https://api.github.com/repos/morningman/incubator-doris/branches{/branch}","tags_url":"https://api.github.com/repos/morningman/incubator-doris/tags","blobs_url":"https://api.github.com/repos/morningman/incubator-doris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/morningman/incubator-doris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/morningman/incubator-doris/git/refs{/sha}","trees_url":"https://api.github.com/repos/morningman/incubator-doris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/morningman/incubator-doris/statuses/{sha}","languages_url":"https://api.github.com/repos/morningman/incubator-doris/languages","stargazers_url":"https://api.github.com/repos/morningman/incubator-doris/stargazers","contributors_url":"https://api.github.com/repos/morningman/incubator-doris/contributors","subscribers_url":"https://api.github.com/repos/morningman/incubator-doris/subscribers","subscription_url":"https://api.github.com/repos/morningman/incubator-doris/subscription","commits_url":"https://api.github.com/repos/morningman/incubator-doris/commits{/sha}","git_commits_url":"https://api.github.com/repos/morningman/incubator-doris/git/commits{/sha}","comments_url":"https://api.github.com/repos/morningman/incubator-doris/comments{/number}","issue_comment_url":"https://api.github.com/repos/morningman/incubator-doris/issues/comments{/number}","contents_url":"https://api.github.com/repos/morningman/incubator-doris/contents/{+path}","compare_url":"https://api.github.com/repos/morningman/incubator-doris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/morningman/incubator-doris/merges","archive_url":"https://api.github.com/repos/morningman/incubator-doris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/morningman/incubator-doris/downloads","issues_url":"https://api.github.com/repos/morningman/incubator-doris/issues{/number}","pulls_url":"https://api.github.com/repos/morningman/incubator-doris/pulls{/number}","milestones_url":"https://api.github.com/repos/morningman/incubator-doris/milestones{/number}","notifications_url":"https://api.github.com/repos/morningman/incubator-doris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/morningman/incubator-doris/labels{/name}","releases_url":"https://api.github.com/repos/morningman/incubator-doris/releases{/id}","deployments_url":"https://api.github.com/repos/morningman/incubator-doris/deployments","created_at":"2018-10-29T08:15:04Z","updated_at":"2019-09-12T08:33:26Z","pushed_at":"2019-09-13T14:53:37Z","git_url":"git://github.com/morningman/incubator-doris.git","ssh_url":"git@github.com:morningman/incubator-doris.git","clone_url":"https://github.com/morningman/incubator-doris.git","svn_url":"https://github.com/morningman/incubator-doris","homepage":"","size":269395,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"dcea6daf4f737494f715dffa105b362e09011305","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":99919302,"node_id":"MDEwOlJlcG9zaXRvcnk5OTkxOTMwMg==","name":"incubator-doris","full_name":"apache/incubator-doris","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-doris","description":"Apache Doris (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-doris","forks_url":"https://api.github.com/repos/apache/incubator-doris/forks","keys_url":"https://api.github.com/repos/apache/incubator-doris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-doris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-doris/teams","hooks_url":"https://api.github.com/repos/apache/incubator-doris/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-doris/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-doris/events","assignees_url":"https://api.github.com/repos/apache/incubator-doris/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-doris/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-doris/tags","blobs_url":"https://api.github.com/repos/apache/incubator-doris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-doris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-doris/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-doris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-doris/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-doris/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-doris/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-doris/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-doris/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-doris/subscription","commits_url":"https://api.github.com/repos/apache/incubator-doris/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-doris/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-doris/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-doris/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-doris/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-doris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-doris/merges","archive_url":"https://api.github.com/repos/apache/incubator-doris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-doris/downloads","issues_url":"https://api.github.com/repos/apache/incubator-doris/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-doris/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-doris/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-doris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-doris/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-doris/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-doris/deployments","created_at":"2017-08-10T12:13:30Z","updated_at":"2019-09-13T14:06:59Z","pushed_at":"2019-09-13T14:53:39Z","git_url":"git://github.com/apache/incubator-doris.git","ssh_url":"git@github.com:apache/incubator-doris.git","clone_url":"https://github.com/apache/incubator-doris.git","svn_url":"https://github.com/apache/incubator-doris","homepage":"http://doris.incubator.apache.org","size":268650,"stargazers_count":1346,"watchers_count":1346,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":189,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":358,"open_issues":189,"watchers":1346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/1800"},"html":{"href":"https://github.com/apache/incubator-doris/pull/1800"},"issue":{"href":"https://api.github.com/repos/apache/incubator-doris/issues/1800"},"comments":{"href":"https://api.github.com/repos/apache/incubator-doris/issues/1800/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/1800/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-doris/pulls/1800/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-doris/statuses/b8746a3edf0897a773e831de10bfcdf419376cb7"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 99919302,
"name": "apache/incubator-doris",
"url": "https://api.github.com/repos/apache/incubator-doris"
}
|
{
"id": 2899462,
"login": "morningman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2899462?",
"url": "https://api.github.com/users/morningman"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-09-13T14:54:06 |
10411948059
|
{"actor":{"display_login":"morningman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/318498764","pull_request_review_id":280723716,"id":318498764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODQ5ODc2NA==","diff_hunk":"@@ -62,6 +60,23 @@ private ArrowVectorIterator(ResultSet resultSet, JdbcToArrowConfig config) throw\n this.compositeConsumer = new CompositeJdbcConsumer(consumers);\n }\n \n+ private void initialize() throws SQLException {\n+ try {\n+ nextBatch = VectorSchemaRoot.create(schema, config.getAllocator());\n+ JdbcToArrowUtils.allocateVectors(nextBatch, JdbcToArrowUtils.DEFAULT_BUFFER_SIZE);\n+ } catch (Exception e) {\n+ close();\n+ throw new RuntimeException(\"Error occurs while initializing.\", e);\n+ }\n+\n+ for (int i = 1; i <= consumers.length; i++) {\n+ consumers[i - 1] = JdbcToArrowUtils.getConsumer(resultSet, i, resultSet.getMetaData().getColumnType(i),","path":"java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/ArrowVectorIterator.java","position":23,"original_position":30,"commit_id":"48a3440c44ae53bb0e1858ad56d9af3fac4061a2","original_commit_id":"0e53ffc9cddc3419672e7a3f609dba219c36def7","user":{"login":"tianchen92","id":25814127,"node_id":"MDQ6VXNlcjI1ODE0MTI3","avatar_url":"https://avatars3.githubusercontent.com/u/25814127?v=4","gravatar_id":"","url":"https://api.github.com/users/tianchen92","html_url":"https://github.com/tianchen92","followers_url":"https://api.github.com/users/tianchen92/followers","following_url":"https://api.github.com/users/tianchen92/following{/other_user}","gists_url":"https://api.github.com/users/tianchen92/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchen92/subscriptions","organizations_url":"https://api.github.com/users/tianchen92/orgs","repos_url":"https://api.github.com/users/tianchen92/repos","events_url":"https://api.github.com/users/tianchen92/events{/privacy}","received_events_url":"https://api.github.com/users/tianchen92/received_events","type":"User","site_admin":false},"body":"Sounds good, looks cleaner, fixed.","created_at":"2019-08-28T10:08:30Z","updated_at":"2019-08-28T10:08:30Z","html_url":"https://github.com/apache/arrow/pull/5152#discussion_r318498764","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/5152","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/318498764"},"html":{"href":"https://github.com/apache/arrow/pull/5152#discussion_r318498764"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/5152"}},"in_reply_to_id":316975398},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/5152","id":309418240,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5NDE4MjQw","html_url":"https://github.com/apache/arrow/pull/5152","diff_url":"https://github.com/apache/arrow/pull/5152.diff","patch_url":"https://github.com/apache/arrow/pull/5152.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/5152","number":5152,"state":"open","locked":false,"title":"ARROW-6296: [Java] Cleanup JDBC interfaces and eliminate one memcopy for binary/varchar fields","user":{"login":"tianchen92","id":25814127,"node_id":"MDQ6VXNlcjI1ODE0MTI3","avatar_url":"https://avatars3.githubusercontent.com/u/25814127?v=4","gravatar_id":"","url":"https://api.github.com/users/tianchen92","html_url":"https://github.com/tianchen92","followers_url":"https://api.github.com/users/tianchen92/followers","following_url":"https://api.github.com/users/tianchen92/following{/other_user}","gists_url":"https://api.github.com/users/tianchen92/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchen92/subscriptions","organizations_url":"https://api.github.com/users/tianchen92/orgs","repos_url":"https://api.github.com/users/tianchen92/repos","events_url":"https://api.github.com/users/tianchen92/events{/privacy}","received_events_url":"https://api.github.com/users/tianchen92/received_events","type":"User","site_admin":false},"body":"Related to [ARROW-6296](https://issues.apache.org/jira/browse/ARROW-6296).\r\ni. If we use direct setting of fields, we can avoid the extra temporary buffer and memcpy by setting bytes directly.\r\nii. We should overwrite existing vectors in consumers before returning results, to avoid the possibility of closing vectors in use (or alternatively make sure we retain the underlying buffers).\r\niii. Try to eliminate some of the state in load() by moving initialization to the constructor.","created_at":"2019-08-21T09:53:31Z","updated_at":"2019-08-28T10:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1938bda1460b2203fcafd6026df08d535b90ab44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1146973547,"node_id":"MDU6TGFiZWwxMTQ2OTczNTQ3","url":"https://api.github.com/repos/apache/arrow/labels/lang-java","name":"lang-java","color":"b07219","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/5152/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/5152/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/5152/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/48a3440c44ae53bb0e1858ad56d9af3fac4061a2","head":{"label":"tianchen92:ARROW-6296","ref":"ARROW-6296","sha":"48a3440c44ae53bb0e1858ad56d9af3fac4061a2","user":{"login":"tianchen92","id":25814127,"node_id":"MDQ6VXNlcjI1ODE0MTI3","avatar_url":"https://avatars3.githubusercontent.com/u/25814127?v=4","gravatar_id":"","url":"https://api.github.com/users/tianchen92","html_url":"https://github.com/tianchen92","followers_url":"https://api.github.com/users/tianchen92/followers","following_url":"https://api.github.com/users/tianchen92/following{/other_user}","gists_url":"https://api.github.com/users/tianchen92/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchen92/subscriptions","organizations_url":"https://api.github.com/users/tianchen92/orgs","repos_url":"https://api.github.com/users/tianchen92/repos","events_url":"https://api.github.com/users/tianchen92/events{/privacy}","received_events_url":"https://api.github.com/users/tianchen92/received_events","type":"User","site_admin":false},"repo":{"id":182950977,"node_id":"MDEwOlJlcG9zaXRvcnkxODI5NTA5Nzc=","name":"arrow","full_name":"tianchen92/arrow","private":false,"owner":{"login":"tianchen92","id":25814127,"node_id":"MDQ6VXNlcjI1ODE0MTI3","avatar_url":"https://avatars3.githubusercontent.com/u/25814127?v=4","gravatar_id":"","url":"https://api.github.com/users/tianchen92","html_url":"https://github.com/tianchen92","followers_url":"https://api.github.com/users/tianchen92/followers","following_url":"https://api.github.com/users/tianchen92/following{/other_user}","gists_url":"https://api.github.com/users/tianchen92/gists{/gist_id}","starred_url":"https://api.github.com/users/tianchen92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tianchen92/subscriptions","organizations_url":"https://api.github.com/users/tianchen92/orgs","repos_url":"https://api.github.com/users/tianchen92/repos","events_url":"https://api.github.com/users/tianchen92/events{/privacy}","received_events_url":"https://api.github.com/users/tianchen92/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tianchen92/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":true,"url":"https://api.github.com/repos/tianchen92/arrow","forks_url":"https://api.github.com/repos/tianchen92/arrow/forks","keys_url":"https://api.github.com/repos/tianchen92/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tianchen92/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tianchen92/arrow/teams","hooks_url":"https://api.github.com/repos/tianchen92/arrow/hooks","issue_events_url":"https://api.github.com/repos/tianchen92/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/tianchen92/arrow/events","assignees_url":"https://api.github.com/repos/tianchen92/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/tianchen92/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/tianchen92/arrow/tags","blobs_url":"https://api.github.com/repos/tianchen92/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tianchen92/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tianchen92/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tianchen92/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tianchen92/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/tianchen92/arrow/languages","stargazers_url":"https://api.github.com/repos/tianchen92/arrow/stargazers","contributors_url":"https://api.github.com/repos/tianchen92/arrow/contributors","subscribers_url":"https://api.github.com/repos/tianchen92/arrow/subscribers","subscription_url":"https://api.github.com/repos/tianchen92/arrow/subscription","commits_url":"https://api.github.com/repos/tianchen92/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tianchen92/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tianchen92/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tianchen92/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tianchen92/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/tianchen92/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tianchen92/arrow/merges","archive_url":"https://api.github.com/repos/tianchen92/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tianchen92/arrow/downloads","issues_url":"https://api.github.com/repos/tianchen92/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/tianchen92/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/tianchen92/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/tianchen92/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tianchen92/arrow/labels{/name}","releases_url":"https://api.github.com/repos/tianchen92/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/tianchen92/arrow/deployments","created_at":"2019-04-23T06:43:10Z","updated_at":"2019-07-11T04:57:00Z","pushed_at":"2019-08-28T10:03:43Z","git_url":"git://github.com/tianchen92/arrow.git","ssh_url":"git@github.com:tianchen92/arrow.git","clone_url":"https://github.com/tianchen92/arrow.git","svn_url":"https://github.com/tianchen92/arrow","homepage":"https://arrow.apache.org","size":35469,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"d4d4a12ed028ac606fff56cc24c2c8d06d0bf91b","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2019-08-28T06:58:51Z","pushed_at":"2019-08-28T10:03:45Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":35317,"stargazers_count":4420,"watchers_count":4420,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1088,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1088,"open_issues":73,"watchers":4420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/5152"},"html":{"href":"https://github.com/apache/arrow/pull/5152"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/5152"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/5152/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/5152/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/5152/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/48a3440c44ae53bb0e1858ad56d9af3fac4061a2"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 51905353,
"name": "apache/arrow",
"url": "https://api.github.com/repos/apache/arrow"
}
|
{
"id": 25814127,
"login": "tianchen92",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25814127?",
"url": "https://api.github.com/users/tianchen92"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-08-28T18:08:30 |
10299256607
|
{"actor":{"display_login":"tianchen92"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/302302559","pull_request_review_id":260394279,"id":302302559,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjMwMjU1OQ==","diff_hunk":"@@ -61,6 +62,31 @@ terminator - :arg:`length` must be used to correctly display the string.\n This function is useful to guarantee a URL that is as complete as possible given the specific\n request.\n \n+:func:`TSHttpHdrEffectiveUrlBuffGet` returns the effective URL for any HTTP request (not just the client request).\n+If the request has a Host header field (and the URL does not contain a host specifier), the host specifier the header\n+provides is inserted into the URL. The host and\n+scheme in the returned URL will be normalized to lower case letters (to make URL comparisons simple and fast).\n+This prints the effective URL for the header specified by :arg:`hdr_buf` and\n+:arg:`hdr_loc` to the buffer starting at :arg:`buff`. If the effective URL is longer than :arg:`size`, nothing is\n+written to :arg:`buff`. Note that this is not considered an error case, the function will still reeturn `TS_SUCCESS`.\n+It is the responsibility of the caller to check this result to determine if output was generated.\n+The full length of the URL is always returned in :arg:`*length` when the function returns `TS_SUCCESS`.\n+\n+The typical usage would be\n+::\n+\n+ TSMBuffer hdr_buff;\n+ TSMLoc hdr_loc;\n+ TSHttpTxnServerReqGet(txn, &hdr_buff, &hdr_loc);\n+ int64_t length;\n+ char store[2048];\n+ char *buff = store;\n+ TSHttpHdrEffectiveUrlBuffGet(hdr_buff, hdr_loc, buff, sizeof(store), &length);\n+ if (length > sizeof(store)) {\n+ buff = malloc(length);","path":"doc/developer-guide/api/functions/TSUrlStringGet.en.rst","position":42,"original_position":42,"commit_id":"bc6ee9c922d59682d73c2f356483836147d99f24","original_commit_id":"bc6ee9c922d59682d73c2f356483836147d99f24","user":{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"body":"Does it matter since it will convert implicitly: https://godbolt.org/z/EMfhaj","created_at":"2019-07-10T22:46:44Z","updated_at":"2019-07-10T22:46:44Z","html_url":"https://github.com/apache/trafficserver/pull/5706#discussion_r302302559","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/5706","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/302302559"},"html":{"href":"https://github.com/apache/trafficserver/pull/5706#discussion_r302302559"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/5706"}},"in_reply_to_id":302299476},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/5706","id":296296271,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2Mjk2Mjcx","html_url":"https://github.com/apache/trafficserver/pull/5706","diff_url":"https://github.com/apache/trafficserver/pull/5706.diff","patch_url":"https://github.com/apache/trafficserver/pull/5706.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/5706","number":5706,"state":"open","locked":false,"title":"Add optional normalization of scheme and host to lower case letters in effective URLs.","user":{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"body":"- Adds new TS API function TSHttpHdrEffectiveUrlBuffGet() (which also puts the URL in a user-allocated buffer).\r\n- Adds 'normalized' parameter (defaults to false) to HTTPHdr::url_string_get().\r\n- Adds 'normalized' parameter (defaults to false) to url_print(), url_string_get(), url_string_get_ref().\r\n- Adds 'normalized' parameter (defaults to false) to URL::string_get(), URL::string_get_ref(), URL::print().\r\n\r\nThis will make it possible to check URLs output by these functions for equivalence by doing a simple string compare.","created_at":"2019-07-10T18:43:41Z","updated_at":"2019-07-10T22:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99adde388a04cec28a227c4dc9541e302e58fbcb","assignee":{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"assignees":[{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/19","html_url":"https://github.com/apache/trafficserver/milestone/19","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/19/labels","id":3358032,"node_id":"MDk6TWlsZXN0b25lMzM1ODAzMg==","number":19,"title":"9.0.0","description":"","creator":{"login":"bryancall","id":216749,"node_id":"MDQ6VXNlcjIxNjc0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/216749?v=4","gravatar_id":"","url":"https://api.github.com/users/bryancall","html_url":"https://github.com/bryancall","followers_url":"https://api.github.com/users/bryancall/followers","following_url":"https://api.github.com/users/bryancall/following{/other_user}","gists_url":"https://api.github.com/users/bryancall/gists{/gist_id}","starred_url":"https://api.github.com/users/bryancall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryancall/subscriptions","organizations_url":"https://api.github.com/users/bryancall/orgs","repos_url":"https://api.github.com/users/bryancall/repos","events_url":"https://api.github.com/users/bryancall/events{/privacy}","received_events_url":"https://api.github.com/users/bryancall/received_events","type":"User","site_admin":false},"open_issues":115,"closed_issues":733,"state":"open","created_at":"2018-05-18T19:12:59Z","updated_at":"2019-07-10T22:41:33Z","due_on":"2019-06-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/5706/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/5706/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/5706/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/bc6ee9c922d59682d73c2f356483836147d99f24","head":{"label":"ywkaras:TSHttpHdrEffectiveUrlBuffGet","ref":"TSHttpHdrEffectiveUrlBuffGet","sha":"bc6ee9c922d59682d73c2f356483836147d99f24","user":{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"repo":{"id":93207586,"node_id":"MDEwOlJlcG9zaXRvcnk5MzIwNzU4Ng==","name":"trafficserver","full_name":"ywkaras/trafficserver","private":false,"owner":{"login":"ywkaras","id":29132227,"node_id":"MDQ6VXNlcjI5MTMyMjI3","avatar_url":"https://avatars2.githubusercontent.com/u/29132227?v=4","gravatar_id":"","url":"https://api.github.com/users/ywkaras","html_url":"https://github.com/ywkaras","followers_url":"https://api.github.com/users/ywkaras/followers","following_url":"https://api.github.com/users/ywkaras/following{/other_user}","gists_url":"https://api.github.com/users/ywkaras/gists{/gist_id}","starred_url":"https://api.github.com/users/ywkaras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ywkaras/subscriptions","organizations_url":"https://api.github.com/users/ywkaras/orgs","repos_url":"https://api.github.com/users/ywkaras/repos","events_url":"https://api.github.com/users/ywkaras/events{/privacy}","received_events_url":"https://api.github.com/users/ywkaras/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ywkaras/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/ywkaras/trafficserver","forks_url":"https://api.github.com/repos/ywkaras/trafficserver/forks","keys_url":"https://api.github.com/repos/ywkaras/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ywkaras/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ywkaras/trafficserver/teams","hooks_url":"https://api.github.com/repos/ywkaras/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/ywkaras/trafficserver/events","assignees_url":"https://api.github.com/repos/ywkaras/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/ywkaras/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/ywkaras/trafficserver/tags","blobs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ywkaras/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ywkaras/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ywkaras/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ywkaras/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/ywkaras/trafficserver/languages","stargazers_url":"https://api.github.com/repos/ywkaras/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/ywkaras/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/ywkaras/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/ywkaras/trafficserver/subscription","commits_url":"https://api.github.com/repos/ywkaras/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ywkaras/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ywkaras/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ywkaras/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ywkaras/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/ywkaras/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ywkaras/trafficserver/merges","archive_url":"https://api.github.com/repos/ywkaras/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ywkaras/trafficserver/downloads","issues_url":"https://api.github.com/repos/ywkaras/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/ywkaras/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/ywkaras/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/ywkaras/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ywkaras/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/ywkaras/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/ywkaras/trafficserver/deployments","created_at":"2017-06-02T22:13:24Z","updated_at":"2019-01-29T00:01:18Z","pushed_at":"2019-07-10T21:57:02Z","git_url":"git://github.com/ywkaras/trafficserver.git","ssh_url":"git@github.com:ywkaras/trafficserver.git","clone_url":"https://github.com/ywkaras/trafficserver.git","svn_url":"https://github.com/ywkaras/trafficserver","homepage":null,"size":101367,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8510a1c244894b1582f112f1eccd1d5fa9e977b3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYwNjY=","name":"trafficserver","full_name":"apache/trafficserver","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/trafficserver","description":"Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2019-07-10T22:23:17Z","pushed_at":"2019-07-10T22:23:03Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":"http://trafficserver.apache.org/","size":102903,"stargazers_count":989,"watchers_count":989,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":586,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":298,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":586,"open_issues":298,"watchers":989,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/5706"},"html":{"href":"https://github.com/apache/trafficserver/pull/5706"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/5706"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/5706/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/5706/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/5706/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/bc6ee9c922d59682d73c2f356483836147d99f24"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 356066,
"name": "apache/trafficserver",
"url": "https://api.github.com/repos/apache/trafficserver"
}
|
{
"id": 29132227,
"login": "ywkaras",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/29132227?",
"url": "https://api.github.com/users/ywkaras"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-07-10T22:46:44 |
9987743555
|
{"actor":{"display_login":"ywkaras"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/arrow/pulls/comments/317404480","pull_request_review_id":279342516,"id":317404480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzQwNDQ4MA==","diff_hunk":"@@ -177,4 +177,26 @@ Result<std::shared_ptr<Array>> ArrayFromBuilderVisitor(\n return ArrayFromBuilderVisitor(type, length, length, std::forward<Fn>(fn));\n }\n \n+class RepeatedRecordBatch : public RecordBatchReader {\n+ public:\n+ RepeatedRecordBatch(int64_t repetitions, std::shared_ptr<RecordBatch> batch)\n+ : repetitions_(repetitions), batch_(std::move(batch)) {}\n+\n+ std::shared_ptr<Schema> schema() const override { return batch_->schema(); }\n+\n+ Status ReadNext(std::shared_ptr<RecordBatch>* batch) override {\n+ if (repetitions_ > 0) {\n+ *batch = batch_;\n+ --repetitions_;\n+ } else {\n+ *batch = nullptr;\n+ }\n+ return Status::OK();\n+ }\n+\n+ private:\n+ int64_t repetitions_;\n+ std::shared_ptr<RecordBatch> batch_;\n+};","path":"cpp/src/arrow/testing/util.h","position":24,"original_position":24,"commit_id":"2d415666c88c336cfdabce3f7f41c44b83b253ea","original_commit_id":"2d415666c88c336cfdabce3f7f41c44b83b253ea","user":{"login":"wesm","id":329591,"node_id":"MDQ6VXNlcjMyOTU5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/329591?v=4","gravatar_id":"","url":"https://api.github.com/users/wesm","html_url":"https://github.com/wesm","followers_url":"https://api.github.com/users/wesm/followers","following_url":"https://api.github.com/users/wesm/following{/other_user}","gists_url":"https://api.github.com/users/wesm/gists{/gist_id}","starred_url":"https://api.github.com/users/wesm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesm/subscriptions","organizations_url":"https://api.github.com/users/wesm/orgs","repos_url":"https://api.github.com/users/wesm/repos","events_url":"https://api.github.com/users/wesm/events{/privacy}","received_events_url":"https://api.github.com/users/wesm/received_events","type":"User","site_admin":false},"body":"I still find this really narrow -- I commented on ARROW-6161 about this. Wouldn't passing `std::vector<shared_ptr<RecordBatch>>` be more generally useful? You can even create a function `RepeatVector(val, num)` to make generating the vector easy","created_at":"2019-08-25T15:55:27Z","updated_at":"2019-08-25T15:58:51Z","html_url":"https://github.com/apache/arrow/pull/5140#discussion_r317404480","pull_request_url":"https://api.github.com/repos/apache/arrow/pulls/5140","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments/317404480"},"html":{"href":"https://github.com/apache/arrow/pull/5140#discussion_r317404480"},"pull_request":{"href":"https://api.github.com/repos/apache/arrow/pulls/5140"}}},"pull_request":{"url":"https://api.github.com/repos/apache/arrow/pulls/5140","id":309150457,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MTUwNDU3","html_url":"https://github.com/apache/arrow/pull/5140","diff_url":"https://github.com/apache/arrow/pull/5140.diff","patch_url":"https://github.com/apache/arrow/pull/5140.patch","issue_url":"https://api.github.com/repos/apache/arrow/issues/5140","number":5140,"state":"open","locked":false,"title":"ARROW-6238: [C++][Dataset] Implement SimpleDataSource, SimpleDataFragment and SimpleScanTask","user":{"login":"fsaintjacques","id":662469,"node_id":"MDQ6VXNlcjY2MjQ2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/662469?v=4","gravatar_id":"","url":"https://api.github.com/users/fsaintjacques","html_url":"https://github.com/fsaintjacques","followers_url":"https://api.github.com/users/fsaintjacques/followers","following_url":"https://api.github.com/users/fsaintjacques/following{/other_user}","gists_url":"https://api.github.com/users/fsaintjacques/gists{/gist_id}","starred_url":"https://api.github.com/users/fsaintjacques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsaintjacques/subscriptions","organizations_url":"https://api.github.com/users/fsaintjacques/orgs","repos_url":"https://api.github.com/users/fsaintjacques/repos","events_url":"https://api.github.com/users/fsaintjacques/events{/privacy}","received_events_url":"https://api.github.com/users/fsaintjacques/received_events","type":"User","site_admin":false},"body":"The Simple* family of classes are iterator backed by explicit vectors. This can be useful to represent a memory datasource that rarely changes, e.g. a constant join table.\r\n\r\n- SimpleDataSource is backed by a vector<DataFragment>.\r\n- SimpleDataFragment is backed by a vector<RecordBatch>.\r\n- SimpleScanTask is backed by a vector<RecordBatch>.\r\n","created_at":"2019-08-20T17:16:53Z","updated_at":"2019-08-25T15:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"912ddcc1f9a9dd13e9839f41ce91ba736dc82258","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/arrow/pulls/5140/commits","review_comments_url":"https://api.github.com/repos/apache/arrow/pulls/5140/comments","review_comment_url":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/arrow/issues/5140/comments","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/2d415666c88c336cfdabce3f7f41c44b83b253ea","head":{"label":"fsaintjacques:ARROW-6238-simple-datasource-datafragment","ref":"ARROW-6238-simple-datasource-datafragment","sha":"2d415666c88c336cfdabce3f7f41c44b83b253ea","user":{"login":"fsaintjacques","id":662469,"node_id":"MDQ6VXNlcjY2MjQ2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/662469?v=4","gravatar_id":"","url":"https://api.github.com/users/fsaintjacques","html_url":"https://github.com/fsaintjacques","followers_url":"https://api.github.com/users/fsaintjacques/followers","following_url":"https://api.github.com/users/fsaintjacques/following{/other_user}","gists_url":"https://api.github.com/users/fsaintjacques/gists{/gist_id}","starred_url":"https://api.github.com/users/fsaintjacques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsaintjacques/subscriptions","organizations_url":"https://api.github.com/users/fsaintjacques/orgs","repos_url":"https://api.github.com/users/fsaintjacques/repos","events_url":"https://api.github.com/users/fsaintjacques/events{/privacy}","received_events_url":"https://api.github.com/users/fsaintjacques/received_events","type":"User","site_admin":false},"repo":{"id":158748329,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3NDgzMjk=","name":"arrow","full_name":"fsaintjacques/arrow","private":false,"owner":{"login":"fsaintjacques","id":662469,"node_id":"MDQ6VXNlcjY2MjQ2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/662469?v=4","gravatar_id":"","url":"https://api.github.com/users/fsaintjacques","html_url":"https://github.com/fsaintjacques","followers_url":"https://api.github.com/users/fsaintjacques/followers","following_url":"https://api.github.com/users/fsaintjacques/following{/other_user}","gists_url":"https://api.github.com/users/fsaintjacques/gists{/gist_id}","starred_url":"https://api.github.com/users/fsaintjacques/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsaintjacques/subscriptions","organizations_url":"https://api.github.com/users/fsaintjacques/orgs","repos_url":"https://api.github.com/users/fsaintjacques/repos","events_url":"https://api.github.com/users/fsaintjacques/events{/privacy}","received_events_url":"https://api.github.com/users/fsaintjacques/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fsaintjacques/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":true,"url":"https://api.github.com/repos/fsaintjacques/arrow","forks_url":"https://api.github.com/repos/fsaintjacques/arrow/forks","keys_url":"https://api.github.com/repos/fsaintjacques/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsaintjacques/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsaintjacques/arrow/teams","hooks_url":"https://api.github.com/repos/fsaintjacques/arrow/hooks","issue_events_url":"https://api.github.com/repos/fsaintjacques/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/fsaintjacques/arrow/events","assignees_url":"https://api.github.com/repos/fsaintjacques/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/fsaintjacques/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/fsaintjacques/arrow/tags","blobs_url":"https://api.github.com/repos/fsaintjacques/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsaintjacques/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsaintjacques/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsaintjacques/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsaintjacques/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/fsaintjacques/arrow/languages","stargazers_url":"https://api.github.com/repos/fsaintjacques/arrow/stargazers","contributors_url":"https://api.github.com/repos/fsaintjacques/arrow/contributors","subscribers_url":"https://api.github.com/repos/fsaintjacques/arrow/subscribers","subscription_url":"https://api.github.com/repos/fsaintjacques/arrow/subscription","commits_url":"https://api.github.com/repos/fsaintjacques/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsaintjacques/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsaintjacques/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsaintjacques/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsaintjacques/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/fsaintjacques/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsaintjacques/arrow/merges","archive_url":"https://api.github.com/repos/fsaintjacques/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsaintjacques/arrow/downloads","issues_url":"https://api.github.com/repos/fsaintjacques/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/fsaintjacques/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/fsaintjacques/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/fsaintjacques/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsaintjacques/arrow/labels{/name}","releases_url":"https://api.github.com/repos/fsaintjacques/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/fsaintjacques/arrow/deployments","created_at":"2018-11-22T20:42:04Z","updated_at":"2019-08-23T18:41:37Z","pushed_at":"2019-08-23T21:21:57Z","git_url":"git://github.com/fsaintjacques/arrow.git","ssh_url":"git@github.com:fsaintjacques/arrow.git","clone_url":"https://github.com/fsaintjacques/arrow.git","svn_url":"https://github.com/fsaintjacques/arrow","homepage":"https://arrow.apache.org","size":35385,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3c9236d198b93ae3f59d39ce958909a1909078f5","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":51905353,"node_id":"MDEwOlJlcG9zaXRvcnk1MTkwNTM1Mw==","name":"arrow","full_name":"apache/arrow","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/arrow","description":"Apache Arrow is a cross-language development platform for in-memory data. It specifies a standardized language-independent columnar memory format for flat and hierarchical data, organized for efficient analytic operations on modern hardware. It also provides computational libraries and zero-copy streaming messaging and interprocess communication. Languages currently supported include C, C++, Java, JavaScript, Python, and Ruby.","fork":false,"url":"https://api.github.com/repos/apache/arrow","forks_url":"https://api.github.com/repos/apache/arrow/forks","keys_url":"https://api.github.com/repos/apache/arrow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/arrow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/arrow/teams","hooks_url":"https://api.github.com/repos/apache/arrow/hooks","issue_events_url":"https://api.github.com/repos/apache/arrow/issues/events{/number}","events_url":"https://api.github.com/repos/apache/arrow/events","assignees_url":"https://api.github.com/repos/apache/arrow/assignees{/user}","branches_url":"https://api.github.com/repos/apache/arrow/branches{/branch}","tags_url":"https://api.github.com/repos/apache/arrow/tags","blobs_url":"https://api.github.com/repos/apache/arrow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/arrow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/arrow/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/arrow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/arrow/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/arrow/languages","stargazers_url":"https://api.github.com/repos/apache/arrow/stargazers","contributors_url":"https://api.github.com/repos/apache/arrow/contributors","subscribers_url":"https://api.github.com/repos/apache/arrow/subscribers","subscription_url":"https://api.github.com/repos/apache/arrow/subscription","commits_url":"https://api.github.com/repos/apache/arrow/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/arrow/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/arrow/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/arrow/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/arrow/contents/{+path}","compare_url":"https://api.github.com/repos/apache/arrow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/arrow/merges","archive_url":"https://api.github.com/repos/apache/arrow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/arrow/downloads","issues_url":"https://api.github.com/repos/apache/arrow/issues{/number}","pulls_url":"https://api.github.com/repos/apache/arrow/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/arrow/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/arrow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/arrow/labels{/name}","releases_url":"https://api.github.com/repos/apache/arrow/releases{/id}","deployments_url":"https://api.github.com/repos/apache/arrow/deployments","created_at":"2016-02-17T08:00:23Z","updated_at":"2019-08-25T05:03:53Z","pushed_at":"2019-08-25T14:28:32Z","git_url":"git://github.com/apache/arrow.git","ssh_url":"git@github.com:apache/arrow.git","clone_url":"https://github.com/apache/arrow.git","svn_url":"https://github.com/apache/arrow","homepage":"https://arrow.apache.org","size":35165,"stargazers_count":4400,"watchers_count":4400,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1088,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":74,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1088,"open_issues":74,"watchers":4400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/arrow/pulls/5140"},"html":{"href":"https://github.com/apache/arrow/pull/5140"},"issue":{"href":"https://api.github.com/repos/apache/arrow/issues/5140"},"comments":{"href":"https://api.github.com/repos/apache/arrow/issues/5140/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/arrow/pulls/5140/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/arrow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/arrow/pulls/5140/commits"},"statuses":{"href":"https://api.github.com/repos/apache/arrow/statuses/2d415666c88c336cfdabce3f7f41c44b83b253ea"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 51905353,
"name": "apache/arrow",
"url": "https://api.github.com/repos/apache/arrow"
}
|
{
"id": 329591,
"login": "wesm",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/329591?",
"url": "https://api.github.com/users/wesm"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-08-25T15:55:27 |
10278633502
|
{"actor":{"display_login":"wesm"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/290953433","pull_request_review_id":246281780,"id":290953433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDk1MzQzMw==","diff_hunk":"@@ -27,52 +27,79 @@ def test_log():\n def log(x):\n return nd.log(x)\n \n+ def grad_op(x):\n+ return 1/x\n+\n def grad_grad_op(x):\n return -1/(x**2)\n \n arrays = random_arrays((2, 2), (2, 3), (4, 5, 2), (3, 1, 4, 5))\n \n for array in arrays:\n- check_second_order_unary(array, log, grad_grad_op)\n+ check_second_order_unary(array, log, grad_op, grad_grad_op)\n \n \n @with_seed()\n def test_log2():\n def log2(x):\n return nd.log2(x)\n \n+ def grad_op(x):\n+ return 1/(x * math.log(2))\n+\n def grad_grad_op(x):\n return -1/((x**2) * math.log(2))\n \n arrays = random_arrays((2, 2), (2, 3), (4, 5, 2), (3, 1, 4, 5))\n \n for array in arrays:\n- check_second_order_unary(array, log2, grad_grad_op)\n+ check_second_order_unary(array, log2, grad_op, grad_grad_op)\n \n \n @with_seed()\n def test_log10():\n def log10(x):\n return nd.log10(x)\n \n+ def grad_op(x):\n+ return 1/(x * math.log(10))\n+\n def grad_grad_op(x):\n return -1/((x**2) * math.log(10))\n \n arrays = random_arrays((2, 2), (2, 3), (4, 5, 2), (3, 1, 4, 5))\n \n for array in arrays:\n- check_second_order_unary(array, log10, grad_grad_op)\n+ check_second_order_unary(array, log10, grad_op, grad_grad_op)\n \n \n-def check_second_order_unary(x, op, grad_grad_op):\n+def check_second_order_unary(x, op, grad_op, grad_grad_op):\n x = nd.array(x)\n- expect_grad_grad = grad_grad_op(x)\n+ grad_x = grad_op(x)\n+ grad_grad_x = grad_grad_op(x)\n x.attach_grad()\n+\n+ # Manual head_grads.\n+ head_grads = nd.random.normal(shape=x.shape)","path":"tests/python/unittest/test_higher_order_grad.py","position":62,"original_position":62,"commit_id":"37ce3b87268a8154f5c0ad97ce2522478038ee06","original_commit_id":"37ce3b87268a8154f5c0ad97ce2522478038ee06","user":{"login":"kshitij12345","id":19503980,"node_id":"MDQ6VXNlcjE5NTAzOTgw","avatar_url":"https://avatars3.githubusercontent.com/u/19503980?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij12345","html_url":"https://github.com/kshitij12345","followers_url":"https://api.github.com/users/kshitij12345/followers","following_url":"https://api.github.com/users/kshitij12345/following{/other_user}","gists_url":"https://api.github.com/users/kshitij12345/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij12345/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij12345/subscriptions","organizations_url":"https://api.github.com/users/kshitij12345/orgs","repos_url":"https://api.github.com/users/kshitij12345/repos","events_url":"https://api.github.com/users/kshitij12345/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij12345/received_events","type":"User","site_admin":false},"body":"Sure.","created_at":"2019-06-05T22:02:49Z","updated_at":"2019-06-05T22:02:50Z","html_url":"https://github.com/apache/incubator-mxnet/pull/15120#discussion_r290953433","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/290953433"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/15120#discussion_r290953433"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120"}},"in_reply_to_id":290902765},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120","id":284288235,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0Mjg4MjM1","html_url":"https://github.com/apache/incubator-mxnet/pull/15120","diff_url":"https://github.com/apache/incubator-mxnet/pull/15120.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/15120.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/15120","number":15120,"state":"open","locked":false,"title":"[bug] fix higher grad log ","user":{"login":"kshitij12345","id":19503980,"node_id":"MDQ6VXNlcjE5NTAzOTgw","avatar_url":"https://avatars3.githubusercontent.com/u/19503980?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij12345","html_url":"https://github.com/kshitij12345","followers_url":"https://api.github.com/users/kshitij12345/followers","following_url":"https://api.github.com/users/kshitij12345/following{/other_user}","gists_url":"https://api.github.com/users/kshitij12345/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij12345/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij12345/subscriptions","organizations_url":"https://api.github.com/users/kshitij12345/orgs","repos_url":"https://api.github.com/users/kshitij12345/repos","events_url":"https://api.github.com/users/kshitij12345/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij12345/received_events","type":"User","site_admin":false},"body":"There is a bug in the implementation for higher order gradient of `log`.\r\n\r\nhttps://github.com/apache/incubator-mxnet/blob/7b343d1fcde73b61322985580080333d9eee9e82/src/operator/tensor/elemwise_unary_op_basic.cc#L1077-L1079\r\n\r\nWe multiply `gx * gx` where `gx = ograd * f'(x)`, getting `ograd^2 * f'(x)^2`, however we want only `ograd * f'(x)^2` which can be achieved in a similar fashion to the implementation of `_backward_log10/2`.\r\n\r\nI have validated the expected results for grad on `x`.\r\n```python\r\nfrom mxnet import nd, autograd\r\nimport numpy\r\nimport math\r\n\r\nop = lambda x: nd.log(x)\r\ngrad_op = lambda x: 1/x\r\ngrad_grad_op = lambda x: (-1/x**2)\r\n\r\nx = nd.random.normal(0,1,(3,3))\r\nhead_grads = nd.random.normal(0,1,(3,3))\r\nhead_grad_grads = nd.random.normal(0,1,(3,3))\r\n\r\nx.attach_grad()\r\nhead_grads.attach_grad()\r\n\r\n\r\nwith autograd.record():\r\n y = nd.cos(x)\r\n y_grad = autograd.grad(y, x, head_grads=head_grads, create_graph=True, retain_graph=True)[0]\r\ny_grad.backward(head_grad_grads)\r\n\r\n\r\nexpected_grad_grad_x = (grad_grad_op(x) * head_grad_grads * head_grads).asnumpy()\r\nexpected_head_grad = (grad_op(x) * head_grad_grads).asnumpy()\r\n\r\nnumpy.testing.assert_allclose(x.grad.asnumpy(), expected_grad_grad_x, rtol=1e-7, atol=1e-7)\r\nnumpy.testing.assert_allclose(head_grads.grad.asnumpy(), expected_head_grad, rtol=1e-7, atol=1e-7)\r\n```\r\nWhich fails with current code.\r\n\r\nHave confirmed the behaviour with Pytorch as well.\r\n```python\r\nimport torch\r\nimport numpy\r\nimport math\r\n\r\nop = lambda x: torch.log(x)\r\ngrad_op = lambda x: 1/x\r\ngrad_grad_op = lambda x: (-1/x**2)\r\n\r\nx = torch.randn(2,3)\r\nhead_grads = torch.randn(2,3)\r\nhead_grad_grads = torch.randn(2,3)\r\nx.requires_grad = True\r\nhead_grads.requires_grad = True\r\n\r\ny = op(x)\r\ny_grad = torch.autograd.grad(y, x, grad_outputs= head_grads, create_graph=True, retain_graph=True)[0]\r\ny_grad.backward(head_grad_grads)\r\n\r\nexpected_grad_grad_x = (grad_grad_op(x) * head_grad_grads * head_grads).detach().numpy()\r\nexpected_head_grad = (grad_op(x) * head_grad_grads).detach().numpy()\r\n\r\nnumpy.testing.assert_allclose(x.grad.detach().numpy(), expected_grad_grad_x, rtol=1e-7, atol=1e-7)\r\nnumpy.testing.assert_allclose(head_grads.grad.detach().numpy(), expected_head_grad, rtol=1e-7, atol=1e-7)```\r\n\r\n","created_at":"2019-06-01T18:07:33Z","updated_at":"2019-06-05T22:02:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7218e8c9bad21743e795073c357e298b5c685e2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":707556574,"node_id":"MDU6TGFiZWw3MDc1NTY1NzQ=","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/Operator","name":"Operator","color":"fbca04","default":false},{"id":1018798522,"node_id":"MDU6TGFiZWwxMDE4Nzk4NTIy","url":"https://api.github.com/repos/apache/incubator-mxnet/labels/pr-awaiting-review","name":"pr-awaiting-review","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/15120/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/37ce3b87268a8154f5c0ad97ce2522478038ee06","head":{"label":"kshitij12345:fix-higher-grad-log-bug","ref":"fix-higher-grad-log-bug","sha":"37ce3b87268a8154f5c0ad97ce2522478038ee06","user":{"login":"kshitij12345","id":19503980,"node_id":"MDQ6VXNlcjE5NTAzOTgw","avatar_url":"https://avatars3.githubusercontent.com/u/19503980?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij12345","html_url":"https://github.com/kshitij12345","followers_url":"https://api.github.com/users/kshitij12345/followers","following_url":"https://api.github.com/users/kshitij12345/following{/other_user}","gists_url":"https://api.github.com/users/kshitij12345/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij12345/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij12345/subscriptions","organizations_url":"https://api.github.com/users/kshitij12345/orgs","repos_url":"https://api.github.com/users/kshitij12345/repos","events_url":"https://api.github.com/users/kshitij12345/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij12345/received_events","type":"User","site_admin":false},"repo":{"id":187360245,"node_id":"MDEwOlJlcG9zaXRvcnkxODczNjAyNDU=","name":"incubator-mxnet","full_name":"kshitij12345/incubator-mxnet","private":false,"owner":{"login":"kshitij12345","id":19503980,"node_id":"MDQ6VXNlcjE5NTAzOTgw","avatar_url":"https://avatars3.githubusercontent.com/u/19503980?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij12345","html_url":"https://github.com/kshitij12345","followers_url":"https://api.github.com/users/kshitij12345/followers","following_url":"https://api.github.com/users/kshitij12345/following{/other_user}","gists_url":"https://api.github.com/users/kshitij12345/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij12345/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij12345/subscriptions","organizations_url":"https://api.github.com/users/kshitij12345/orgs","repos_url":"https://api.github.com/users/kshitij12345/repos","events_url":"https://api.github.com/users/kshitij12345/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij12345/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kshitij12345/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/kshitij12345/incubator-mxnet","forks_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/kshitij12345/incubator-mxnet/deployments","created_at":"2019-05-18T13:18:36Z","updated_at":"2019-05-18T13:18:48Z","pushed_at":"2019-06-01T17:50:28Z","git_url":"git://github.com/kshitij12345/incubator-mxnet.git","ssh_url":"git@github.com:kshitij12345/incubator-mxnet.git","clone_url":"https://github.com/kshitij12345/incubator-mxnet.git","svn_url":"https://github.com/kshitij12345/incubator-mxnet","homepage":"https://mxnet.apache.org","size":58382,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"866ec108ea12a48770bdd864e3f4788ee24a70bf","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2NDQwMg==","name":"incubator-mxnet","full_name":"apache/incubator-mxnet","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2019-06-05T13:06:33Z","pushed_at":"2019-06-05T21:51:43Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"https://mxnet.apache.org","size":58515,"stargazers_count":17072,"watchers_count":17072,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6073,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1200,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6073,"open_issues":1200,"watchers":17072,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/15120"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/15120"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/15120/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/15120/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/37ce3b87268a8154f5c0ad97ce2522478038ee06"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 34864402,
"name": "apache/incubator-mxnet",
"url": "https://api.github.com/repos/apache/incubator-mxnet"
}
|
{
"id": 19503980,
"login": "kshitij12345",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19503980?",
"url": "https://api.github.com/users/kshitij12345"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-06-05T22:02:49 |
9766916610
|
{"actor":{"display_login":"kshitij12345"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/334732819","pull_request_review_id":301628535,"id":334732819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDczMjgxOQ==","diff_hunk":"@@ -472,7 +472,9 @@ public static String getStartCommand(String template,\n \t\tfor (Map.Entry<String, String> variable : startCommandValues\n \t\t\t.entrySet()) {\n \t\t\ttemplate = template\n-\t\t\t\t.replace(\"%\" + variable.getKey() + \"%\", variable.getValue());\n+\t\t\t\t.replace(\"%\" + variable.getKey() + \"%\", variable.getValue())","path":"flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java","position":31,"original_position":5,"commit_id":"768101e26760ce3dbdcaa6d216dc77ca86b4f96e","original_commit_id":"b31f9802d89a4d07b48eae3fce8c7061e2f712a1","user":{"login":"xintongsong","id":6509172,"node_id":"MDQ6VXNlcjY1MDkxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6509172?v=4","gravatar_id":"","url":"https://api.github.com/users/xintongsong","html_url":"https://github.com/xintongsong","followers_url":"https://api.github.com/users/xintongsong/followers","following_url":"https://api.github.com/users/xintongsong/following{/other_user}","gists_url":"https://api.github.com/users/xintongsong/gists{/gist_id}","starred_url":"https://api.github.com/users/xintongsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xintongsong/subscriptions","organizations_url":"https://api.github.com/users/xintongsong/orgs","repos_url":"https://api.github.com/users/xintongsong/repos","events_url":"https://api.github.com/users/xintongsong/events{/privacy}","received_events_url":"https://api.github.com/users/xintongsong/received_events","type":"User","site_admin":false},"body":"I think for the test cases that verifies the generated shell command, the main purpose is to verified the command values and their order. How many spaces between tokens is rather an unconcerned implementation detail.\r\nPreviously, we need to carefully put one or multiple sequential spaces between the command values when writing test cases. Compared to that, I think it would be easier to always have one space between each pair of adjacent command values.","created_at":"2019-10-15T02:50:54Z","updated_at":"2019-10-15T02:50:54Z","html_url":"https://github.com/apache/flink/pull/9801#discussion_r334732819","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/9801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/334732819"},"html":{"href":"https://github.com/apache/flink/pull/9801#discussion_r334732819"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/9801"}},"in_reply_to_id":334590287},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/9801","id":322477978,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyNDc3OTc4","html_url":"https://github.com/apache/flink/pull/9801","diff_url":"https://github.com/apache/flink/pull/9801.diff","patch_url":"https://github.com/apache/flink/pull/9801.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/9801","number":9801,"state":"open","locked":false,"title":"[FLINK-13983][runtime] Launch task executor with new memory calculation logics","user":{"login":"xintongsong","id":6509172,"node_id":"MDQ6VXNlcjY1MDkxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6509172?v=4","gravatar_id":"","url":"https://api.github.com/users/xintongsong","html_url":"https://github.com/xintongsong","followers_url":"https://api.github.com/users/xintongsong/followers","following_url":"https://api.github.com/users/xintongsong/following{/other_user}","gists_url":"https://api.github.com/users/xintongsong/gists{/gist_id}","starred_url":"https://api.github.com/users/xintongsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xintongsong/subscriptions","organizations_url":"https://api.github.com/users/xintongsong/orgs","repos_url":"https://api.github.com/users/xintongsong/repos","events_url":"https://api.github.com/users/xintongsong/events{/privacy}","received_events_url":"https://api.github.com/users/xintongsong/received_events","type":"User","site_admin":false},"body":"## What is the purpose of the change\r\nThis PR is part of FLIP-49. It uses the new memory configuration and calculation logics for launching task executors.\r\n\r\nNOTE: Changes to the Mesos deployment should be manually verified. This is not yet done due to lack of Mesos environment.\r\n\r\nThis PR is based on #9693 & #9760.\r\n\r\n## Brief change log\r\n- 723e82fb6058a96fc078d3147acb22ddf7332f01..c681c67b99d8afd714aa7e5afd75cf83a4ccb23b: Commits of previous PR #9693.\r\n- 3529c027776e94031790c192cca3ea3e84cc86d0..27ae6ed6aaa27b2e8c5da941b33dbd8aad719f23: Commits of previous PR #9760.\r\n- 42605e8d6106dff86031551e0e1e57c8667c3df2: Refactor `TaskManagerHeapSizeCalculationJavaBashTest`, extract common `JavaBashTestBase` for executing testing bash scripts from java test cases.\r\n- b31f9802d89a4d07b48eae3fce8c7061e2f712a1: Remove heading/trailing/duplicated whitespaces from shell command generated by `BootstrapTools`. This simplifies relevant test cases from carefully dealing with white space counts.\r\n- b6fd6ddaeb9179ebf9459025f66dceccf43caa3b: Introduce `BashJavaUtils`, which allows to call java implemented utils from bash scripts.\r\n- 3a881444799e763544a75c3eb6d282df7a844ece: TM startup bash scripts use new memory configuration and calculation logics to launch task executors (when flip49 is enabled)\r\n- c2487f6a6e87e958f33f1d145963062e2c60342a: Launch task executors on Yarn/Mesos with new memory configuration and calculation logics (when flip49 is enabled)\r\n- 3cdeedcbc6f05fae27ab4f98765c044d67cca5ca: TM decide memory size of `ShuffleEnvironment` with new memory configuration and calculation logics (when flip49 is enabled)\r\n- 768101e26760ce3dbdcaa6d216dc77ca86b4f96e: TM decide memory size of `MemoryManager` with new memory configuration and calculation logics (when flip49 is enabled)\r\n\r\n\r\n## Verifying this change\r\n- Add `BashJavaUtilsTest` to creating dynamic configs and JVM parameters by calling java codes from bash scripts.\r\n- Manually test launching task executors with proper dynamic configs and JVM parameters when using FLIP-49 new configurations.\r\n- Add `BootstrapTools#testGetTaskManagerShellCommand` to test generating task executor launching command with proper dynamic configs and JVM parameters on Yarn.\r\n- **NOT YET**: Manually test launching task executors with proper dynamic configs and JVM parameters when using FLIP-49 new configurations.\r\n\r\n## Does this pull request potentially affect one of the following parts:\r\n\r\n - Dependencies (does it add or upgrade a dependency): (no)\r\n - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)\r\n - The serializers: (no)\r\n - The runtime per-record code paths (performance sensitive): (no)\r\n - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)\r\n - The S3 file system connector: (no)\r\n\r\n## Documentation\r\n\r\n - Does this pull request introduce a new feature? (no)\r\n - If yes, how is the feature documented? (not applicable)\r\nf","created_at":"2019-09-29T06:53:29Z","updated_at":"2019-10-15T02:50:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44ed6784e2ee495d9e96112ed393f7f738a56570","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1272993074,"node_id":"MDU6TGFiZWwxMjcyOTkzMDc0","url":"https://api.github.com/repos/apache/flink/labels/component=%3Cnone%3E","name":"component=<none>","color":"175fb7","default":false},{"id":1244454690,"node_id":"MDU6TGFiZWwxMjQ0NDU0Njkw","url":"https://api.github.com/repos/apache/flink/labels/review=description?","name":"review=description?","color":"bcf5db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/9801/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/9801/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/9801/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/768101e26760ce3dbdcaa6d216dc77ca86b4f96e","head":{"label":"xintongsong:FLINK-13983-flip49-launch-tm","ref":"FLINK-13983-flip49-launch-tm","sha":"768101e26760ce3dbdcaa6d216dc77ca86b4f96e","user":{"login":"xintongsong","id":6509172,"node_id":"MDQ6VXNlcjY1MDkxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6509172?v=4","gravatar_id":"","url":"https://api.github.com/users/xintongsong","html_url":"https://github.com/xintongsong","followers_url":"https://api.github.com/users/xintongsong/followers","following_url":"https://api.github.com/users/xintongsong/following{/other_user}","gists_url":"https://api.github.com/users/xintongsong/gists{/gist_id}","starred_url":"https://api.github.com/users/xintongsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xintongsong/subscriptions","organizations_url":"https://api.github.com/users/xintongsong/orgs","repos_url":"https://api.github.com/users/xintongsong/repos","events_url":"https://api.github.com/users/xintongsong/events{/privacy}","received_events_url":"https://api.github.com/users/xintongsong/received_events","type":"User","site_admin":false},"repo":{"id":185968889,"node_id":"MDEwOlJlcG9zaXRvcnkxODU5Njg4ODk=","name":"flink","full_name":"xintongsong/flink","private":false,"owner":{"login":"xintongsong","id":6509172,"node_id":"MDQ6VXNlcjY1MDkxNzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6509172?v=4","gravatar_id":"","url":"https://api.github.com/users/xintongsong","html_url":"https://github.com/xintongsong","followers_url":"https://api.github.com/users/xintongsong/followers","following_url":"https://api.github.com/users/xintongsong/following{/other_user}","gists_url":"https://api.github.com/users/xintongsong/gists{/gist_id}","starred_url":"https://api.github.com/users/xintongsong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xintongsong/subscriptions","organizations_url":"https://api.github.com/users/xintongsong/orgs","repos_url":"https://api.github.com/users/xintongsong/repos","events_url":"https://api.github.com/users/xintongsong/events{/privacy}","received_events_url":"https://api.github.com/users/xintongsong/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xintongsong/flink","description":"Apache Flink","fork":true,"url":"https://api.github.com/repos/xintongsong/flink","forks_url":"https://api.github.com/repos/xintongsong/flink/forks","keys_url":"https://api.github.com/repos/xintongsong/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xintongsong/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xintongsong/flink/teams","hooks_url":"https://api.github.com/repos/xintongsong/flink/hooks","issue_events_url":"https://api.github.com/repos/xintongsong/flink/issues/events{/number}","events_url":"https://api.github.com/repos/xintongsong/flink/events","assignees_url":"https://api.github.com/repos/xintongsong/flink/assignees{/user}","branches_url":"https://api.github.com/repos/xintongsong/flink/branches{/branch}","tags_url":"https://api.github.com/repos/xintongsong/flink/tags","blobs_url":"https://api.github.com/repos/xintongsong/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xintongsong/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xintongsong/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/xintongsong/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xintongsong/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/xintongsong/flink/languages","stargazers_url":"https://api.github.com/repos/xintongsong/flink/stargazers","contributors_url":"https://api.github.com/repos/xintongsong/flink/contributors","subscribers_url":"https://api.github.com/repos/xintongsong/flink/subscribers","subscription_url":"https://api.github.com/repos/xintongsong/flink/subscription","commits_url":"https://api.github.com/repos/xintongsong/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/xintongsong/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/xintongsong/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/xintongsong/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/xintongsong/flink/contents/{+path}","compare_url":"https://api.github.com/repos/xintongsong/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xintongsong/flink/merges","archive_url":"https://api.github.com/repos/xintongsong/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xintongsong/flink/downloads","issues_url":"https://api.github.com/repos/xintongsong/flink/issues{/number}","pulls_url":"https://api.github.com/repos/xintongsong/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/xintongsong/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/xintongsong/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xintongsong/flink/labels{/name}","releases_url":"https://api.github.com/repos/xintongsong/flink/releases{/id}","deployments_url":"https://api.github.com/repos/xintongsong/flink/deployments","created_at":"2019-05-10T10:26:58Z","updated_at":"2019-09-12T09:11:01Z","pushed_at":"2019-10-14T11:43:42Z","git_url":"git://github.com/xintongsong/flink.git","ssh_url":"git@github.com:xintongsong/flink.git","clone_url":"https://github.com/xintongsong/flink.git","svn_url":"https://github.com/xintongsong/flink","homepage":"","size":262697,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3da95400b8ba2e7aadfc83d6de106b1dfa884831","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4NzU5OQ==","name":"flink","full_name":"apache/flink","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/flink","description":"Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2019-10-15T02:41:57Z","pushed_at":"2019-10-15T02:23:36Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":"","size":263273,"stargazers_count":10646,"watchers_count":10646,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5703,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":522,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5703,"open_issues":522,"watchers":10646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/9801"},"html":{"href":"https://github.com/apache/flink/pull/9801"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/9801"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/9801/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/9801/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/9801/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/768101e26760ce3dbdcaa6d216dc77ca86b4f96e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 20587599,
"name": "apache/flink",
"url": "https://api.github.com/repos/apache/flink"
}
|
{
"id": 6509172,
"login": "xintongsong",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6509172?",
"url": "https://api.github.com/users/xintongsong"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2019-10-15T02:50:54 |
10629739285
|
{"actor":{"display_login":"xintongsong"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/365631790","pull_request_review_id":341620573,"id":365631790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTYzMTc5MA==","diff_hunk":"@@ -231,34 +205,6 @@ def test_createDataFrame_toggle(self):\n df_no_arrow, df_arrow = self._createDataFrame_toggle(pdf, schema=self.schema)\n self.assertEquals(df_no_arrow.collect(), df_arrow.collect())\n \n- def test_createDataFrame_respect_session_timezone(self):\n- from datetime import timedelta\n- pdf = self.create_pandas_data_frame()\n- timezone = \"America/New_York\"\n- with self.sql_conf({","path":"python/pyspark/sql/tests/test_arrow.py","position":41,"original_position":41,"commit_id":"5068b22df978cdcd456bebdd0239ca5bcd46ba8c","original_commit_id":"5068b22df978cdcd456bebdd0239ca5bcd46ba8c","user":{"login":"HyukjinKwon","id":6477701,"node_id":"MDQ6VXNlcjY0Nzc3MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6477701?v=4","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"body":"Same, I think we should only remove this test case.","created_at":"2020-01-13T02:20:03Z","updated_at":"2020-01-13T02:20:04Z","html_url":"https://github.com/apache/spark/pull/27169#discussion_r365631790","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/27169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/365631790"},"html":{"href":"https://github.com/apache/spark/pull/27169#discussion_r365631790"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/27169"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/27169","id":361642048,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNjQyMDQ4","html_url":"https://github.com/apache/spark/pull/27169","diff_url":"https://github.com/apache/spark/pull/27169.diff","patch_url":"https://github.com/apache/spark/pull/27169.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/27169","number":27169,"state":"open","locked":false,"title":"[SPARK-30485][SQL] Remove SQL configs deprecated in Spark 2.1 and 2.3","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"body":"### What changes were proposed in this pull request?\r\nIn the PR, I propose to remove already deprecated SQL configs:\r\n- `spark.sql.variable.substitute.depth` deprecated in Spark 2.1\r\n- `spark.sql.execution.pandas.respectSessionTimeZone` deprecated in Spark 2.3\r\n- `spark.sql.parquet.int64AsTimestampMillis` deprecated in Spark 2.3\r\n\r\n### Why are the changes needed?\r\nTo improve code maintainability. \r\n\r\n### Does this PR introduce any user-facing change?\r\nYes.\r\n\r\n### How was this patch tested?\r\nBy existing test suites `ParquetQuerySuite` and `SQLConfSuite`.","created_at":"2020-01-10T22:09:59Z","updated_at":"2020-01-13T02:20:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70a22f0f571b3d46d8824e6907adeb3cb2c251fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/27169/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/27169/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/27169/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/5068b22df978cdcd456bebdd0239ca5bcd46ba8c","head":{"label":"MaxGekk:remove-deprecated-conf-2.4","ref":"remove-deprecated-conf-2.4","sha":"5068b22df978cdcd456bebdd0239ca5bcd46ba8c","user":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"repo":{"id":123690489,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2OTA0ODk=","name":"spark","full_name":"MaxGekk/spark","private":false,"owner":{"login":"MaxGekk","id":1580697,"node_id":"MDQ6VXNlcjE1ODA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1580697?v=4","gravatar_id":"","url":"https://api.github.com/users/MaxGekk","html_url":"https://github.com/MaxGekk","followers_url":"https://api.github.com/users/MaxGekk/followers","following_url":"https://api.github.com/users/MaxGekk/following{/other_user}","gists_url":"https://api.github.com/users/MaxGekk/gists{/gist_id}","starred_url":"https://api.github.com/users/MaxGekk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaxGekk/subscriptions","organizations_url":"https://api.github.com/users/MaxGekk/orgs","repos_url":"https://api.github.com/users/MaxGekk/repos","events_url":"https://api.github.com/users/MaxGekk/events{/privacy}","received_events_url":"https://api.github.com/users/MaxGekk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/MaxGekk/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/MaxGekk/spark","forks_url":"https://api.github.com/repos/MaxGekk/spark/forks","keys_url":"https://api.github.com/repos/MaxGekk/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MaxGekk/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MaxGekk/spark/teams","hooks_url":"https://api.github.com/repos/MaxGekk/spark/hooks","issue_events_url":"https://api.github.com/repos/MaxGekk/spark/issues/events{/number}","events_url":"https://api.github.com/repos/MaxGekk/spark/events","assignees_url":"https://api.github.com/repos/MaxGekk/spark/assignees{/user}","branches_url":"https://api.github.com/repos/MaxGekk/spark/branches{/branch}","tags_url":"https://api.github.com/repos/MaxGekk/spark/tags","blobs_url":"https://api.github.com/repos/MaxGekk/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MaxGekk/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MaxGekk/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/MaxGekk/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MaxGekk/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/MaxGekk/spark/languages","stargazers_url":"https://api.github.com/repos/MaxGekk/spark/stargazers","contributors_url":"https://api.github.com/repos/MaxGekk/spark/contributors","subscribers_url":"https://api.github.com/repos/MaxGekk/spark/subscribers","subscription_url":"https://api.github.com/repos/MaxGekk/spark/subscription","commits_url":"https://api.github.com/repos/MaxGekk/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/MaxGekk/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/MaxGekk/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/MaxGekk/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/MaxGekk/spark/contents/{+path}","compare_url":"https://api.github.com/repos/MaxGekk/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MaxGekk/spark/merges","archive_url":"https://api.github.com/repos/MaxGekk/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MaxGekk/spark/downloads","issues_url":"https://api.github.com/repos/MaxGekk/spark/issues{/number}","pulls_url":"https://api.github.com/repos/MaxGekk/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/MaxGekk/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/MaxGekk/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MaxGekk/spark/labels{/name}","releases_url":"https://api.github.com/repos/MaxGekk/spark/releases{/id}","deployments_url":"https://api.github.com/repos/MaxGekk/spark/deployments","created_at":"2018-03-03T12:37:00Z","updated_at":"2020-01-08T11:16:11Z","pushed_at":"2020-01-12T20:52:54Z","git_url":"git://github.com/MaxGekk/spark.git","ssh_url":"git@github.com:MaxGekk/spark.git","clone_url":"https://github.com/MaxGekk/spark.git","svn_url":"https://github.com/MaxGekk/spark","homepage":null,"size":319787,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b5bc3e12a629e547e32e340ee0439bc53745d862","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/spark","description":"Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2020-01-13T01:48:10Z","pushed_at":"2020-01-13T02:16:11Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":"","size":322402,"stargazers_count":24859,"watchers_count":24859,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20948,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":347,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20948,"open_issues":347,"watchers":24859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/27169"},"html":{"href":"https://github.com/apache/spark/pull/27169"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/27169"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/27169/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/27169/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/27169/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/5068b22df978cdcd456bebdd0239ca5bcd46ba8c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 17165658,
"name": "apache/spark",
"url": "https://api.github.com/repos/apache/spark"
}
|
{
"id": 6477701,
"login": "HyukjinKwon",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6477701?",
"url": "https://api.github.com/users/HyukjinKwon"
}
|
{
"id": 47359,
"login": "apache",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47359?",
"url": "https://api.github.com/orgs/apache"
}
| 2020-01-13T02:20:03 |
11257982009
|
{"actor":{"display_login":"HyukjinKwon"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/comments/359585556","pull_request_review_id":334284669,"id":359585556,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTU4NTU1Ng==","diff_hunk":"@@ -147,6 +152,193 @@ protected static function define_properties() {\n 'default' => '',\n 'null' => NULL_ALLOWED,\n ],\n+ 'config' => [\n+ 'type' => PARAM_RAW,\n+ 'default' => '',\n+ 'null' => NULL_ALLOWED,\n+ ],\n+ ];\n+ }\n+\n+ /**\n+ * Hook to execute before an update.\n+ *\n+ * Please note that at this stage the data has already been validated and therefore\n+ * any new data being set will not be validated before it is sent to the database.\n+ */\n+ protected function before_update() {\n+ $this->before_save();\n+ }\n+\n+ /**\n+ * Hook to execute before a create.\n+ *\n+ * Please note that at this stage the data has already been validated and therefore\n+ * any new data being set will not be validated before it is sent to the database.\n+ */\n+ protected function before_create() {\n+ $this->before_save();\n+ }\n+\n+ /**\n+ * As there is no hook for before both create and update, this function is called by both hooks.\n+ *\n+ * @throws \\CFPropertyList\\IOException\n+ * @throws \\CFPropertyList\\PListException\n+ * @throws \\DOMException\n+ * @throws \\coding_exception\n+ */\n+ private function before_save() {\n+ // Recalculate config and config key.\n+ $this->compute_config();\n+ $this->compute_config_key();\n+ }\n+\n+ /**\n+ * Generate the config key from the config string.\n+ *\n+ * @throws \\CFPropertyList\\IOException\n+ * @throws \\CFPropertyList\\PListException\n+ * @throws \\DOMException\n+ * @throws \\coding_exception\n+ */\n+ private function compute_config_key() {\n+ $config = $this->get('config');\n+ if (!empty($config)) {\n+ $configkey = config_key::generate($config)->get_hash();\n+ $this->set('configkey', $configkey);\n+ }\n+ }\n+\n+ /**\n+ * Create or update the config string based on the current quiz settings.\n+ *\n+ * @throws \\CFPropertyList\\IOException\n+ * @throws \\CFPropertyList\\PListException\n+ * @throws \\DOMException\n+ * @throws \\coding_exception\n+ */\n+ private function compute_config() {\n+ $settings = $this->to_record();\n+ // Get existing config.\n+ $config = $this->get('config');\n+ // Parse basic settings into a property list.\n+ $plist = new property_list($config);\n+\n+ // Process all settings that are boolean.\n+ $this->process_bool_settings($plist, $settings);\n+\n+ // Process quit settings.\n+ $this->process_quit_settings($plist, $settings);\n+\n+ // Add all the URL filters.\n+ $this->process_url_filters($plist, $settings);\n+\n+ // Export and save the config, ready for DB.\n+ $this->set('config', $plist->to_xml());\n+ }\n+\n+ /**\n+ * Use the boolean map to add Moodle boolean setting to config PList.\n+ *\n+ * @param property_list $plist The config PList.\n+ * @param \\stdClass $settings The quiz settings.\n+ */\n+ private function process_bool_settings(property_list $plist, \\stdClass $settings) {\n+ $map = $this->get_bool_seb_setting_map();\n+ foreach ($settings as $setting => $value) {\n+ if (isset($map[$setting])) {\n+ $enabled = $value === 1 ? true : false;\n+ $plist->add_element_to_root($map[$setting], new CFBoolean($enabled));\n+ }\n+ }\n+ }\n+\n+ /**\n+ * Turn hashed quit password and quit link into PList strings and add to config PList.\n+ *\n+ * @param property_list $plist The config PList.\n+ * @param \\stdClass $settings The quiz settings.\n+ */\n+ private function process_quit_settings(property_list $plist, \\stdClass $settings) {\n+ if (!empty($settings->quitpassword) && is_string($settings->quitpassword)) {\n+ // Hash quit password.\n+ $hashedpassword = hash('SHA256', $settings->quitpassword);\n+ $plist->add_element_to_root('hashedQuitPassword', new CFString($hashedpassword));\n+ }\n+\n+ if (!empty($settings->linkquitseb) && is_string($settings->linkquitseb)) {\n+ $plist->add_element_to_root('quitURL', new CFString($settings->linkquitseb));\n+ }\n+ }\n+\n+ /**\n+ * Turn return separated strings for URL filters into a PList array and add to config PList.\n+ *\n+ * @param property_list $plist The config PList.\n+ * @param \\stdClass $settings The quiz settings.\n+ */\n+ private function process_url_filters(property_list $plist, \\stdClass $settings) {\n+ // Create rules to each expression provided and add to config.\n+ $urlfilterrules = [];\n+ // Get all rules separated by newlines and remove empty rules.\n+ $expallowed = array_filter(explode(PHP_EOL, $settings->expressionsallowed));\n+ $expblocked = array_filter(explode(PHP_EOL, $settings->expressionsblocked));\n+ $regallowed = array_filter(explode(PHP_EOL, $settings->regexallowed));\n+ $regblocked = array_filter(explode(PHP_EOL, $settings->regexblocked));\n+ foreach ($expallowed as $exp) {\n+ $urlfilterrules[] = $this->create_filter_rule(true, false, $exp);\n+ }\n+ foreach ($expblocked as $exp) {\n+ $urlfilterrules[] = $this->create_filter_rule(false, false, $exp);\n+ }\n+ foreach ($regallowed as $exp) {\n+ $urlfilterrules[] = $this->create_filter_rule(true, true, $exp);\n+ }\n+ foreach ($regblocked as $exp) {\n+ $urlfilterrules[] = $this->create_filter_rule(false, true, $exp);\n+ }\n+ $plist->add_element_to_root('URLFilterRules', new CFArray($urlfilterrules));\n+ }\n+\n+ /**\n+ * Create a CFDictionary represeting a URL filter rule.\n+ *\n+ * @param bool $allowed Allowed or blocked.\n+ * @param bool $regex Regex or simple.\n+ * @param string $exp The expression to filter with.\n+ * @return CFDictionary A PList dictionary.\n+ */\n+ private function create_filter_rule(bool $allowed, bool $regex, string $exp) : CFDictionary {","path":"classes/quiz_settings.php","position":173,"original_position":173,"commit_id":"681fd76af3f48e321e96fcf7ba12c98b039c2925","original_commit_id":"681fd76af3f48e321e96fcf7ba12c98b039c2925","user":{"login":"dmitriim","id":4626431,"node_id":"MDQ6VXNlcjQ2MjY0MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/4626431?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitriim","html_url":"https://github.com/dmitriim","followers_url":"https://api.github.com/users/dmitriim/followers","following_url":"https://api.github.com/users/dmitriim/following{/other_user}","gists_url":"https://api.github.com/users/dmitriim/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitriim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitriim/subscriptions","organizations_url":"https://api.github.com/users/dmitriim/orgs","repos_url":"https://api.github.com/users/dmitriim/repos","events_url":"https://api.github.com/users/dmitriim/events{/privacy}","received_events_url":"https://api.github.com/users/dmitriim/received_events","type":"User","site_admin":false},"body":"I'd suggest to change the order of the vars: to create_filter_rule(string $exp, bool $allowed, bool $regex)\r\nFirst we tell what the rule is, then we tell what to do with the rule and then we tell how to read the rule.","created_at":"2019-12-18T21:48:06Z","updated_at":"2019-12-18T21:48:07Z","html_url":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34#discussion_r359585556","pull_request_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/comments/359585556"},"html":{"href":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34#discussion_r359585556"},"pull_request":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34","id":354452840,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0NDUyODQw","html_url":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34","diff_url":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34.diff","patch_url":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34.patch","issue_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/34","number":34,"state":"open","locked":false,"title":"Issue #27 Generate config and config key on saving quiz settings","user":{"login":"andrewmadden","id":36656753,"node_id":"MDQ6VXNlcjM2NjU2NzUz","avatar_url":"https://avatars1.githubusercontent.com/u/36656753?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmadden","html_url":"https://github.com/andrewmadden","followers_url":"https://api.github.com/users/andrewmadden/followers","following_url":"https://api.github.com/users/andrewmadden/following{/other_user}","gists_url":"https://api.github.com/users/andrewmadden/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmadden/subscriptions","organizations_url":"https://api.github.com/users/andrewmadden/orgs","repos_url":"https://api.github.com/users/andrewmadden/repos","events_url":"https://api.github.com/users/andrewmadden/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmadden/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-18T06:49:41Z","updated_at":"2019-12-18T21:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00074a9e2a786c44cb21b569c2d1465cb9f6c8e8","assignee":{"login":"andrewmadden","id":36656753,"node_id":"MDQ6VXNlcjM2NjU2NzUz","avatar_url":"https://avatars1.githubusercontent.com/u/36656753?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmadden","html_url":"https://github.com/andrewmadden","followers_url":"https://api.github.com/users/andrewmadden/followers","following_url":"https://api.github.com/users/andrewmadden/following{/other_user}","gists_url":"https://api.github.com/users/andrewmadden/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmadden/subscriptions","organizations_url":"https://api.github.com/users/andrewmadden/orgs","repos_url":"https://api.github.com/users/andrewmadden/repos","events_url":"https://api.github.com/users/andrewmadden/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmadden/received_events","type":"User","site_admin":false},"assignees":[{"login":"andrewmadden","id":36656753,"node_id":"MDQ6VXNlcjM2NjU2NzUz","avatar_url":"https://avatars1.githubusercontent.com/u/36656753?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewmadden","html_url":"https://github.com/andrewmadden","followers_url":"https://api.github.com/users/andrewmadden/followers","following_url":"https://api.github.com/users/andrewmadden/following{/other_user}","gists_url":"https://api.github.com/users/andrewmadden/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewmadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewmadden/subscriptions","organizations_url":"https://api.github.com/users/andrewmadden/orgs","repos_url":"https://api.github.com/users/andrewmadden/repos","events_url":"https://api.github.com/users/andrewmadden/events{/privacy}","received_events_url":"https://api.github.com/users/andrewmadden/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34/commits","review_comments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34/comments","review_comment_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/34/comments","statuses_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/statuses/681fd76af3f48e321e96fcf7ba12c98b039c2925","head":{"label":"catalyst:issue_#27_generate_config","ref":"issue_#27_generate_config","sha":"681fd76af3f48e321e96fcf7ba12c98b039c2925","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":225766401,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU3NjY0MDE=","name":"moodle-quizaccess_seb","full_name":"catalyst/moodle-quizaccess_seb","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-quizaccess_seb","description":"Plugin to integrate Safe Exam Browser into the quiz activity.","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb","forks_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/deployments","created_at":"2019-12-04T03:00:29Z","updated_at":"2019-12-18T21:22:56Z","pushed_at":"2019-12-18T21:22:53Z","git_url":"git://github.com/catalyst/moodle-quizaccess_seb.git","ssh_url":"git@github.com:catalyst/moodle-quizaccess_seb.git","clone_url":"https://github.com/catalyst/moodle-quizaccess_seb.git","svn_url":"https://github.com/catalyst/moodle-quizaccess_seb","homepage":"","size":355,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"base":{"label":"catalyst:master","ref":"master","sha":"5775910b27a62411db913f6d87f1390a2d84b06c","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":225766401,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU3NjY0MDE=","name":"moodle-quizaccess_seb","full_name":"catalyst/moodle-quizaccess_seb","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-quizaccess_seb","description":"Plugin to integrate Safe Exam Browser into the quiz activity.","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb","forks_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/deployments","created_at":"2019-12-04T03:00:29Z","updated_at":"2019-12-18T21:22:56Z","pushed_at":"2019-12-18T21:22:53Z","git_url":"git://github.com/catalyst/moodle-quizaccess_seb.git","ssh_url":"git@github.com:catalyst/moodle-quizaccess_seb.git","clone_url":"https://github.com/catalyst/moodle-quizaccess_seb.git","svn_url":"https://github.com/catalyst/moodle-quizaccess_seb","homepage":"","size":355,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34"},"html":{"href":"https://github.com/catalyst/moodle-quizaccess_seb/pull/34"},"issue":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/34"},"comments":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/catalyst/moodle-quizaccess_seb/statuses/681fd76af3f48e321e96fcf7ba12c98b039c2925"}},"author_association":"COLLABORATOR"}}
|
{
"id": 225766401,
"name": "catalyst/moodle-quizaccess_seb",
"url": "https://api.github.com/repos/catalyst/moodle-quizaccess_seb"
}
|
{
"id": 4626431,
"login": "dmitriim",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4626431?",
"url": "https://api.github.com/users/dmitriim"
}
|
{
"id": 47789,
"login": "catalyst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47789?",
"url": "https://api.github.com/orgs/catalyst"
}
| 2019-12-18T21:48:06 |
11120671829
|
{"actor":{"display_login":"dmitriim"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/comments/338341136","pull_request_review_id":306267395,"id":338341136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODM0MTEzNg==","diff_hunk":"@@ -196,12 +200,71 @@ def create(self, kube_client: KubeClient) -> None:\n self.ensure_pod_disruption_budget(kube_client)\n self.sync_horizontal_pod_autoscaler(kube_client)\n \n+ def deep_delete_and_create(self, kube_client: KubeClient) -> None:\n+ self.logging.debug(\n+ f\"Deep Delete {self.kube_deployment.service} {self.kube_deployment.instance}.\"\n+ )\n+ self.deep_delete(kube_client)\n+ self.logging.debug(\n+ f\"waiting for instance {self.kube_deployment.service} {self.kube_deployment.instance} to die.\"\n+ )\n+\n+ timer = 0\n+ while (\n+ self.kube_deployment in set(list_all_deployments(kube_client))\n+ and timer < 60\n+ ):\n+ sleep(1)\n+ timer += 1\n+\n+ if timer >= 60 and self.kube_deployment in set(\n+ list_all_deployments(kube_client)\n+ ):\n+ try:\n+ force_delete_pods(\n+ self.item.metadata.name,\n+ self.kube_deployment.service,\n+ self.kube_deployment.instance,\n+ self.item.metadata.namespace,\n+ kube_client,\n+ )\n+ except ApiException as e:\n+ if e.status == 404:\n+ # Deployment does not exist, nothing to delete but\n+ # we can consider this a success.\n+ self.logging.debug(\n+ \"not deleting nonexistent deploy/{} from namespace/{}\".format(\n+ self.kube_deployment.service, self.item.metadata.namespace\n+ )\n+ )\n+ else:\n+ raise\n+ else:\n+ self.logging.info(\n+ \"deleted deploy/{} from namespace/{}\".format(\n+ self.kube_deployment.service, self.item.metadata.namespace\n+ )\n+ )\n+ self.logging.debug(\n+ f\"{self.kube_deployment.service} {self.kube_deployment.instance} are deleted, creating new one.\"","path":"paasta_tools/kubernetes/application/controller_wrappers.py","position":72,"original_position":72,"commit_id":"720ad7f530ce3397914819bd544d0ab4929e7b2e","original_commit_id":"720ad7f530ce3397914819bd544d0ab4929e7b2e","user":{"login":"EmanekaT","id":25218586,"node_id":"MDQ6VXNlcjI1MjE4NTg2","avatar_url":"https://avatars0.githubusercontent.com/u/25218586?v=4","gravatar_id":"","url":"https://api.github.com/users/EmanekaT","html_url":"https://github.com/EmanekaT","followers_url":"https://api.github.com/users/EmanekaT/followers","following_url":"https://api.github.com/users/EmanekaT/following{/other_user}","gists_url":"https://api.github.com/users/EmanekaT/gists{/gist_id}","starred_url":"https://api.github.com/users/EmanekaT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmanekaT/subscriptions","organizations_url":"https://api.github.com/users/EmanekaT/orgs","repos_url":"https://api.github.com/users/EmanekaT/repos","events_url":"https://api.github.com/users/EmanekaT/events{/privacy}","received_events_url":"https://api.github.com/users/EmanekaT/received_events","type":"User","site_admin":false},"body":"Make sure to clean up logging. We already have longs in deep_delete and create. So you don't need so many logs. i think just logs in force_delte_pods and exception are enough. \r\nLooks good overall. Just remove redundant things, and test it again. ","created_at":"2019-10-24T00:55:13Z","updated_at":"2019-10-24T00:55:22Z","html_url":"https://github.com/Yelp/paasta/pull/2455#discussion_r338341136","pull_request_url":"https://api.github.com/repos/Yelp/paasta/pulls/2455","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments/338341136"},"html":{"href":"https://github.com/Yelp/paasta/pull/2455#discussion_r338341136"},"pull_request":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/2455"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/paasta/pulls/2455","id":324338976,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MzM4OTc2","html_url":"https://github.com/Yelp/paasta/pull/2455","diff_url":"https://github.com/Yelp/paasta/pull/2455.diff","patch_url":"https://github.com/Yelp/paasta/pull/2455.patch","issue_url":"https://api.github.com/repos/Yelp/paasta/issues/2455","number":2455,"state":"open","locked":false,"title":"Paasta 15597 bounce brutally b8s","user":{"login":"felfilali","id":8510312,"node_id":"MDQ6VXNlcjg1MTAzMTI=","avatar_url":"https://avatars1.githubusercontent.com/u/8510312?v=4","gravatar_id":"","url":"https://api.github.com/users/felfilali","html_url":"https://github.com/felfilali","followers_url":"https://api.github.com/users/felfilali/followers","following_url":"https://api.github.com/users/felfilali/following{/other_user}","gists_url":"https://api.github.com/users/felfilali/gists{/gist_id}","starred_url":"https://api.github.com/users/felfilali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felfilali/subscriptions","organizations_url":"https://api.github.com/users/felfilali/orgs","repos_url":"https://api.github.com/users/felfilali/repos","events_url":"https://api.github.com/users/felfilali/events{/privacy}","received_events_url":"https://api.github.com/users/felfilali/received_events","type":"User","site_admin":false},"body":"Opening as a Draft pull request to get early review/discussion goin with chl && mingqi","created_at":"2019-10-03T18:03:11Z","updated_at":"2019-10-24T00:55:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c002c1e437147d68af403d0d24067e9df3ce7057","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/paasta/pulls/2455/commits","review_comments_url":"https://api.github.com/repos/Yelp/paasta/pulls/2455/comments","review_comment_url":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/paasta/issues/2455/comments","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/720ad7f530ce3397914819bd544d0ab4929e7b2e","head":{"label":"Yelp:PAASTA-15597_bounce_brutally_b8s","ref":"PAASTA-15597_bounce_brutally_b8s","sha":"720ad7f530ce3397914819bd544d0ab4929e7b2e","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","private":false,"owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2019-10-23T20:29:32Z","pushed_at":"2019-10-23T23:50:37Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":65527,"stargazers_count":1380,"watchers_count":1380,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":171,"open_issues":93,"watchers":1380,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"dc56a80e80ea69aa633505f682bbf8a860a186f1","user":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":44998824,"node_id":"MDEwOlJlcG9zaXRvcnk0NDk5ODgyNA==","name":"paasta","full_name":"Yelp/paasta","private":false,"owner":{"login":"Yelp","id":49071,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/49071?v=4","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yelp/paasta","description":"An open, distributed platform as a service","fork":false,"url":"https://api.github.com/repos/Yelp/paasta","forks_url":"https://api.github.com/repos/Yelp/paasta/forks","keys_url":"https://api.github.com/repos/Yelp/paasta/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/paasta/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/paasta/teams","hooks_url":"https://api.github.com/repos/Yelp/paasta/hooks","issue_events_url":"https://api.github.com/repos/Yelp/paasta/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/paasta/events","assignees_url":"https://api.github.com/repos/Yelp/paasta/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/paasta/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/paasta/tags","blobs_url":"https://api.github.com/repos/Yelp/paasta/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/paasta/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/paasta/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/paasta/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/paasta/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/paasta/languages","stargazers_url":"https://api.github.com/repos/Yelp/paasta/stargazers","contributors_url":"https://api.github.com/repos/Yelp/paasta/contributors","subscribers_url":"https://api.github.com/repos/Yelp/paasta/subscribers","subscription_url":"https://api.github.com/repos/Yelp/paasta/subscription","commits_url":"https://api.github.com/repos/Yelp/paasta/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/paasta/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/paasta/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/paasta/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/paasta/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/paasta/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/paasta/merges","archive_url":"https://api.github.com/repos/Yelp/paasta/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/paasta/downloads","issues_url":"https://api.github.com/repos/Yelp/paasta/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/paasta/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/paasta/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/paasta/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/paasta/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/paasta/releases{/id}","deployments_url":"https://api.github.com/repos/Yelp/paasta/deployments","created_at":"2015-10-26T21:35:53Z","updated_at":"2019-10-23T20:29:32Z","pushed_at":"2019-10-23T23:50:37Z","git_url":"git://github.com/Yelp/paasta.git","ssh_url":"git@github.com:Yelp/paasta.git","clone_url":"https://github.com/Yelp/paasta.git","svn_url":"https://github.com/Yelp/paasta","homepage":"","size":65527,"stargazers_count":1380,"watchers_count":1380,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":171,"open_issues":93,"watchers":1380,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/2455"},"html":{"href":"https://github.com/Yelp/paasta/pull/2455"},"issue":{"href":"https://api.github.com/repos/Yelp/paasta/issues/2455"},"comments":{"href":"https://api.github.com/repos/Yelp/paasta/issues/2455/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/2455/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/paasta/pulls/2455/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/paasta/statuses/720ad7f530ce3397914819bd544d0ab4929e7b2e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44998824,
"name": "Yelp/paasta",
"url": "https://api.github.com/repos/Yelp/paasta"
}
|
{
"id": 25218586,
"login": "EmanekaT",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25218586?",
"url": "https://api.github.com/users/EmanekaT"
}
|
{
"id": 49071,
"login": "Yelp",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/49071?",
"url": "https://api.github.com/orgs/Yelp"
}
| 2019-10-24T00:55:13 |
10700658838
|
{"actor":{"display_login":"EmanekaT"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/comments/256796036","pull_request_review_id":203690208,"id":256796036,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1Njc5NjAzNg==","diff_hunk":"@@ -3,6 +3,7 @@ import { By } from '@angular/platform-browser';\n import { CarouselComponent } from './carousel.component';\n import { SharedModule } from '../../shared.module';\n import { ProductDetailsPageModule } from 'src/app/product-details-page/product-details-page.module';\n+import { LazyLoadComponent } from '../lazy-load/lazy-load.component';","path":"src/app/shared/components/carousel/carousel.component.spec.ts","position":4,"original_position":4,"commit_id":"2451d398b80f5350a008feed362e11f229e5549c","original_commit_id":"2451d398b80f5350a008feed362e11f229e5549c","user":{"login":"dverbovyi","id":9499109,"node_id":"MDQ6VXNlcjk0OTkxMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/9499109?v=4","gravatar_id":"","url":"https://api.github.com/users/dverbovyi","html_url":"https://github.com/dverbovyi","followers_url":"https://api.github.com/users/dverbovyi/followers","following_url":"https://api.github.com/users/dverbovyi/following{/other_user}","gists_url":"https://api.github.com/users/dverbovyi/gists{/gist_id}","starred_url":"https://api.github.com/users/dverbovyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dverbovyi/subscriptions","organizations_url":"https://api.github.com/users/dverbovyi/orgs","repos_url":"https://api.github.com/users/dverbovyi/repos","events_url":"https://api.github.com/users/dverbovyi/events{/privacy}","received_events_url":"https://api.github.com/users/dverbovyi/received_events","type":"User","site_admin":false},"body":"this component has not being used in this file","created_at":"2019-02-14T11:37:44Z","updated_at":"2019-02-14T11:41:16Z","html_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34#discussion_r256796036","pull_request_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/comments/256796036"},"html":{"href":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34#discussion_r256796036"},"pull_request":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34","id":251508115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxNTA4MTE1","html_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34","diff_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34.diff","patch_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34.patch","issue_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/34","number":34,"state":"open","locked":false,"title":"[Natalia Falinska] lazy load","user":{"login":"NFalinska","id":24520240,"node_id":"MDQ6VXNlcjI0NTIwMjQw","avatar_url":"https://avatars0.githubusercontent.com/u/24520240?v=4","gravatar_id":"","url":"https://api.github.com/users/NFalinska","html_url":"https://github.com/NFalinska","followers_url":"https://api.github.com/users/NFalinska/followers","following_url":"https://api.github.com/users/NFalinska/following{/other_user}","gists_url":"https://api.github.com/users/NFalinska/gists{/gist_id}","starred_url":"https://api.github.com/users/NFalinska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NFalinska/subscriptions","organizations_url":"https://api.github.com/users/NFalinska/orgs","repos_url":"https://api.github.com/users/NFalinska/repos","events_url":"https://api.github.com/users/NFalinska/events{/privacy}","received_events_url":"https://api.github.com/users/NFalinska/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-08T15:44:55Z","updated_at":"2019-02-14T11:41:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb927995eb01c04f066967ba2675dc9eb5d7d0fd","assignee":{"login":"NFalinska","id":24520240,"node_id":"MDQ6VXNlcjI0NTIwMjQw","avatar_url":"https://avatars0.githubusercontent.com/u/24520240?v=4","gravatar_id":"","url":"https://api.github.com/users/NFalinska","html_url":"https://github.com/NFalinska","followers_url":"https://api.github.com/users/NFalinska/followers","following_url":"https://api.github.com/users/NFalinska/following{/other_user}","gists_url":"https://api.github.com/users/NFalinska/gists{/gist_id}","starred_url":"https://api.github.com/users/NFalinska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NFalinska/subscriptions","organizations_url":"https://api.github.com/users/NFalinska/orgs","repos_url":"https://api.github.com/users/NFalinska/repos","events_url":"https://api.github.com/users/NFalinska/events{/privacy}","received_events_url":"https://api.github.com/users/NFalinska/received_events","type":"User","site_admin":false},"assignees":[{"login":"NFalinska","id":24520240,"node_id":"MDQ6VXNlcjI0NTIwMjQw","avatar_url":"https://avatars0.githubusercontent.com/u/24520240?v=4","gravatar_id":"","url":"https://api.github.com/users/NFalinska","html_url":"https://github.com/NFalinska","followers_url":"https://api.github.com/users/NFalinska/followers","following_url":"https://api.github.com/users/NFalinska/following{/other_user}","gists_url":"https://api.github.com/users/NFalinska/gists{/gist_id}","starred_url":"https://api.github.com/users/NFalinska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NFalinska/subscriptions","organizations_url":"https://api.github.com/users/NFalinska/orgs","repos_url":"https://api.github.com/users/NFalinska/repos","events_url":"https://api.github.com/users/NFalinska/events{/privacy}","received_events_url":"https://api.github.com/users/NFalinska/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1186462494,"node_id":"MDU6TGFiZWwxMTg2NDYyNDk0","url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/labels/Ready%20for%20review","name":"Ready for review","color":"a9f9b1","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34/commits","review_comments_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34/comments","review_comment_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/34/comments","statuses_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/statuses/2451d398b80f5350a008feed362e11f229e5549c","head":{"label":"NFalinska:uit-40-lazy-load","ref":"uit-40-lazy-load","sha":"2451d398b80f5350a008feed362e11f229e5549c","user":{"login":"NFalinska","id":24520240,"node_id":"MDQ6VXNlcjI0NTIwMjQw","avatar_url":"https://avatars0.githubusercontent.com/u/24520240?v=4","gravatar_id":"","url":"https://api.github.com/users/NFalinska","html_url":"https://github.com/NFalinska","followers_url":"https://api.github.com/users/NFalinska/followers","following_url":"https://api.github.com/users/NFalinska/following{/other_user}","gists_url":"https://api.github.com/users/NFalinska/gists{/gist_id}","starred_url":"https://api.github.com/users/NFalinska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NFalinska/subscriptions","organizations_url":"https://api.github.com/users/NFalinska/orgs","repos_url":"https://api.github.com/users/NFalinska/repos","events_url":"https://api.github.com/users/NFalinska/events{/privacy}","received_events_url":"https://api.github.com/users/NFalinska/received_events","type":"User","site_admin":false},"repo":{"id":163405342,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM0MDUzNDI=","name":"ui-intshp2-cp-okapi","full_name":"NFalinska/ui-intshp2-cp-okapi","private":false,"owner":{"login":"NFalinska","id":24520240,"node_id":"MDQ6VXNlcjI0NTIwMjQw","avatar_url":"https://avatars0.githubusercontent.com/u/24520240?v=4","gravatar_id":"","url":"https://api.github.com/users/NFalinska","html_url":"https://github.com/NFalinska","followers_url":"https://api.github.com/users/NFalinska/followers","following_url":"https://api.github.com/users/NFalinska/following{/other_user}","gists_url":"https://api.github.com/users/NFalinska/gists{/gist_id}","starred_url":"https://api.github.com/users/NFalinska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NFalinska/subscriptions","organizations_url":"https://api.github.com/users/NFalinska/orgs","repos_url":"https://api.github.com/users/NFalinska/repos","events_url":"https://api.github.com/users/NFalinska/events{/privacy}","received_events_url":"https://api.github.com/users/NFalinska/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NFalinska/ui-intshp2-cp-okapi","description":"IT-44060","fork":true,"url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi","forks_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/forks","keys_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/teams","hooks_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/hooks","issue_events_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/issues/events{/number}","events_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/events","assignees_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/assignees{/user}","branches_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/branches{/branch}","tags_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/tags","blobs_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/statuses/{sha}","languages_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/languages","stargazers_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/stargazers","contributors_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/contributors","subscribers_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/subscribers","subscription_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/subscription","commits_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/contents/{+path}","compare_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/merges","archive_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/downloads","issues_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/issues{/number}","pulls_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/pulls{/number}","milestones_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/milestones{/number}","notifications_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/labels{/name}","releases_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/releases{/id}","deployments_url":"https://api.github.com/repos/NFalinska/ui-intshp2-cp-okapi/deployments","created_at":"2018-12-28T11:57:51Z","updated_at":"2018-12-28T11:57:53Z","pushed_at":"2019-02-14T11:33:03Z","git_url":"git://github.com/NFalinska/ui-intshp2-cp-okapi.git","ssh_url":"git@github.com:NFalinska/ui-intshp2-cp-okapi.git","clone_url":"https://github.com/NFalinska/ui-intshp2-cp-okapi.git","svn_url":"https://github.com/NFalinska/ui-intshp2-cp-okapi","homepage":null,"size":2861,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"griddynamics:development","ref":"development","sha":"1a0899c3e787151f7123400de8964687f363d80b","user":{"login":"griddynamics","id":54911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTEx","avatar_url":"https://avatars1.githubusercontent.com/u/54911?v=4","gravatar_id":"","url":"https://api.github.com/users/griddynamics","html_url":"https://github.com/griddynamics","followers_url":"https://api.github.com/users/griddynamics/followers","following_url":"https://api.github.com/users/griddynamics/following{/other_user}","gists_url":"https://api.github.com/users/griddynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/griddynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griddynamics/subscriptions","organizations_url":"https://api.github.com/users/griddynamics/orgs","repos_url":"https://api.github.com/users/griddynamics/repos","events_url":"https://api.github.com/users/griddynamics/events{/privacy}","received_events_url":"https://api.github.com/users/griddynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":162117890,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxMTc4OTA=","name":"ui-intshp2-cp-okapi","full_name":"griddynamics/ui-intshp2-cp-okapi","private":false,"owner":{"login":"griddynamics","id":54911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0OTEx","avatar_url":"https://avatars1.githubusercontent.com/u/54911?v=4","gravatar_id":"","url":"https://api.github.com/users/griddynamics","html_url":"https://github.com/griddynamics","followers_url":"https://api.github.com/users/griddynamics/followers","following_url":"https://api.github.com/users/griddynamics/following{/other_user}","gists_url":"https://api.github.com/users/griddynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/griddynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/griddynamics/subscriptions","organizations_url":"https://api.github.com/users/griddynamics/orgs","repos_url":"https://api.github.com/users/griddynamics/repos","events_url":"https://api.github.com/users/griddynamics/events{/privacy}","received_events_url":"https://api.github.com/users/griddynamics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi","description":"IT-44060","fork":false,"url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi","forks_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/forks","keys_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/teams","hooks_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/hooks","issue_events_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/events{/number}","events_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/events","assignees_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/assignees{/user}","branches_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/branches{/branch}","tags_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/tags","blobs_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/statuses/{sha}","languages_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/languages","stargazers_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/stargazers","contributors_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/contributors","subscribers_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/subscribers","subscription_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/subscription","commits_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/contents/{+path}","compare_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/merges","archive_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/downloads","issues_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues{/number}","pulls_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls{/number}","milestones_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/milestones{/number}","notifications_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/labels{/name}","releases_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/releases{/id}","deployments_url":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/deployments","created_at":"2018-12-17T11:06:50Z","updated_at":"2019-02-01T19:39:36Z","pushed_at":"2019-02-14T11:33:04Z","git_url":"git://github.com/griddynamics/ui-intshp2-cp-okapi.git","ssh_url":"git@github.com:griddynamics/ui-intshp2-cp-okapi.git","clone_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi.git","svn_url":"https://github.com/griddynamics/ui-intshp2-cp-okapi","homepage":null,"size":3006,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":6,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34"},"html":{"href":"https://github.com/griddynamics/ui-intshp2-cp-okapi/pull/34"},"issue":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/34"},"comments":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi/statuses/2451d398b80f5350a008feed362e11f229e5549c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 162117890,
"name": "griddynamics/ui-intshp2-cp-okapi",
"url": "https://api.github.com/repos/griddynamics/ui-intshp2-cp-okapi"
}
|
{
"id": 9499109,
"login": "dverbovyi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9499109?",
"url": "https://api.github.com/users/dverbovyi"
}
|
{
"id": 54911,
"login": "griddynamics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/54911?",
"url": "https://api.github.com/orgs/griddynamics"
}
| 2019-02-14T11:37:44 |
9067297681
|
{"actor":{"display_login":"dverbovyi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/297315175","pull_request_review_id":254170293,"id":297315175,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzMxNTE3NQ==","diff_hunk":"@@ -0,0 +1,233 @@\n+/*******************************************************************************\n+ * Copyright (c) 2019, 2019 IBM Corp. and others\n+ *\n+ * This program and the accompanying materials are made available under\n+ * the terms of the Eclipse Public License 2.0 which accompanies this\n+ * distribution and is available at https://www.eclipse.org/legal/epl-2.0/\n+ * or the Apache License, Version 2.0 which accompanies this distribution and\n+ * is available at https://www.apache.org/licenses/LICENSE-2.0.\n+ *\n+ * This Source Code may also be made available under the following\n+ * Secondary Licenses when the conditions for such availability set\n+ * forth in the Eclipse Public License, v. 2.0 are satisfied: GNU\n+ * General Public License, version 2 with the GNU Classpath\n+ * Exception [1] and GNU General Public License, version 2 with the\n+ * OpenJDK Assembly Exception [2].\n+ *\n+ * [1] https://www.gnu.org/software/classpath/license.html\n+ * [2] http://openjdk.java.net/legal/assembly-exception.html\n+ *\n+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception\n+ *******************************************************************************/\n+\n+#include <errno.h>\n+#include \"jvmti_test.h\"\n+#include <stdio.h>\n+#include <string.h>\n+\n+jvmtiEnv *globalEnv;\n+jfieldID currentFieldBeingWatched;\n+const char * testClassName;\n+jstring testClassString;\n+\n+\n+/* Find the correct API to increment the number of reports we have seen and return the new value. */\n+jint\n+incAndGetNumReports(JNIEnv* jni_env)\n+{\n+\tjmethodID mID;\n+\tjclass clazz = (*jni_env)->FindClass(jni_env, testClassName);\n+\n+\tif (NULL == clazz) {\n+\t\tprintf(\"Unable to find class: %s\\n\", testClassName);\n+\t\treturn JNI_ERR;\n+\t}\n+\n+\tmID = (*jni_env)->GetStaticMethodID(jni_env, clazz, \"incrementNumReports\", \"()I\");\n+\tif (NULL == mID) {\n+\t\tprintf(\"Unable to find methodID for class: %s and method: %s\\n\", testClassName, \"incrementNumReports\");\n+\t\treturn JNI_ERR;\n+\t}\n+\n+\treturn (*jni_env)->CallStaticIntMethod(jni_env, clazz, mID);\n+}\n+\n+/* Callback routine invoked by the VM to report a field read event. */\n+void JNICALL\n+fieldAccessCallback(jvmtiEnv *jvmti_env, JNIEnv* jni_env, jthread thread, jmethodID method, jlocation location, jclass field_klass, jobject object, jfieldID field)\n+{\n+\t/* Only increment the count if the field ID matches with the same field we added the watch for. */\n+\tif (currentFieldBeingWatched == field) {\n+\t\tjint numReports = incAndGetNumReports(jni_env);\n+\t\tif (numReports >= JNI_ERR) {","path":"runtime/tests/jvmtitests/src/com/ibm/jvmti/tests/fieldwatch/fw001.c","position":62,"original_position":62,"commit_id":"51f520f619971c81c5bd5710d7327f8f9e58ca54","original_commit_id":"51f520f619971c81c5bd5710d7327f8f9e58ca54","user":{"login":"gacholio","id":18033688,"node_id":"MDQ6VXNlcjE4MDMzNjg4","avatar_url":"https://avatars2.githubusercontent.com/u/18033688?v=4","gravatar_id":"","url":"https://api.github.com/users/gacholio","html_url":"https://github.com/gacholio","followers_url":"https://api.github.com/users/gacholio/followers","following_url":"https://api.github.com/users/gacholio/following{/other_user}","gists_url":"https://api.github.com/users/gacholio/gists{/gist_id}","starred_url":"https://api.github.com/users/gacholio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gacholio/subscriptions","organizations_url":"https://api.github.com/users/gacholio/orgs","repos_url":"https://api.github.com/users/gacholio/repos","events_url":"https://api.github.com/users/gacholio/events{/privacy}","received_events_url":"https://api.github.com/users/gacholio/received_events","type":"User","site_admin":false},"body":"If fixed, for equiality comparisions, we prefer the constant on the left `JNI_ERR != numReports`","created_at":"2019-06-25T17:51:11Z","updated_at":"2019-06-25T17:51:11Z","html_url":"https://github.com/eclipse/openj9/pull/6257#discussion_r297315175","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/6257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/297315175"},"html":{"href":"https://github.com/eclipse/openj9/pull/6257#discussion_r297315175"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/6257"}},"in_reply_to_id":297314682},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/6257","id":291259290,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMjU5Mjkw","html_url":"https://github.com/eclipse/openj9/pull/6257","diff_url":"https://github.com/eclipse/openj9/pull/6257.diff","patch_url":"https://github.com/eclipse/openj9/pull/6257.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/6257","number":6257,"state":"open","locked":false,"title":"Add tests for fieldwatch","user":{"login":"dchopra001","id":11260919,"node_id":"MDQ6VXNlcjExMjYwOTE5","avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"body":"This commit was recently reverted here: #6148. I have fixed the issues and so am opening another PR.","created_at":"2019-06-24T19:10:02Z","updated_at":"2019-06-25T17:51:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44241c2cf9197d01d1b49bcbd2f5ad5b3d88a90e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962334,"node_id":"MDU6TGFiZWw2OTc5NjIzMzQ=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:test","name":"comp:test","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/6257/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/6257/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/6257/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/51f520f619971c81c5bd5710d7327f8f9e58ca54","head":{"label":"dchopra001:fwTests","ref":"fwTests","sha":"51f520f619971c81c5bd5710d7327f8f9e58ca54","user":{"login":"dchopra001","id":11260919,"node_id":"MDQ6VXNlcjExMjYwOTE5","avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"repo":{"id":104248426,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyNDg0MjY=","name":"openj9","full_name":"dchopra001/openj9","private":false,"owner":{"login":"dchopra001","id":11260919,"node_id":"MDQ6VXNlcjExMjYwOTE5","avatar_url":"https://avatars3.githubusercontent.com/u/11260919?v=4","gravatar_id":"","url":"https://api.github.com/users/dchopra001","html_url":"https://github.com/dchopra001","followers_url":"https://api.github.com/users/dchopra001/followers","following_url":"https://api.github.com/users/dchopra001/following{/other_user}","gists_url":"https://api.github.com/users/dchopra001/gists{/gist_id}","starred_url":"https://api.github.com/users/dchopra001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dchopra001/subscriptions","organizations_url":"https://api.github.com/users/dchopra001/orgs","repos_url":"https://api.github.com/users/dchopra001/repos","events_url":"https://api.github.com/users/dchopra001/events{/privacy}","received_events_url":"https://api.github.com/users/dchopra001/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dchopra001/openj9","description":"Eclipse OpenJ9","fork":true,"url":"https://api.github.com/repos/dchopra001/openj9","forks_url":"https://api.github.com/repos/dchopra001/openj9/forks","keys_url":"https://api.github.com/repos/dchopra001/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dchopra001/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dchopra001/openj9/teams","hooks_url":"https://api.github.com/repos/dchopra001/openj9/hooks","issue_events_url":"https://api.github.com/repos/dchopra001/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/dchopra001/openj9/events","assignees_url":"https://api.github.com/repos/dchopra001/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/dchopra001/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/dchopra001/openj9/tags","blobs_url":"https://api.github.com/repos/dchopra001/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dchopra001/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dchopra001/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/dchopra001/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dchopra001/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/dchopra001/openj9/languages","stargazers_url":"https://api.github.com/repos/dchopra001/openj9/stargazers","contributors_url":"https://api.github.com/repos/dchopra001/openj9/contributors","subscribers_url":"https://api.github.com/repos/dchopra001/openj9/subscribers","subscription_url":"https://api.github.com/repos/dchopra001/openj9/subscription","commits_url":"https://api.github.com/repos/dchopra001/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/dchopra001/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/dchopra001/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/dchopra001/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/dchopra001/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/dchopra001/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dchopra001/openj9/merges","archive_url":"https://api.github.com/repos/dchopra001/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dchopra001/openj9/downloads","issues_url":"https://api.github.com/repos/dchopra001/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/dchopra001/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/dchopra001/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/dchopra001/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dchopra001/openj9/labels{/name}","releases_url":"https://api.github.com/repos/dchopra001/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/dchopra001/openj9/deployments","created_at":"2017-09-20T17:44:29Z","updated_at":"2018-05-17T17:07:16Z","pushed_at":"2019-06-25T17:22:20Z","git_url":"git://github.com/dchopra001/openj9.git","ssh_url":"git@github.com:dchopra001/openj9.git","clone_url":"https://github.com/dchopra001/openj9.git","svn_url":"https://github.com/dchopra001/openj9","homepage":"","size":54841,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"0e1ea309243220dd71e5fc377a90b1b7f807c2de","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2019-06-25T17:08:41Z","pushed_at":"2019-06-25T17:49:11Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":54431,"stargazers_count":1840,"watchers_count":1840,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":371,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":785,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":371,"open_issues":785,"watchers":1840,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/6257"},"html":{"href":"https://github.com/eclipse/openj9/pull/6257"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/6257"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/6257/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/6257/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/6257/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/51f520f619971c81c5bd5710d7327f8f9e58ca54"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101408117,
"name": "eclipse/openj9",
"url": "https://api.github.com/repos/eclipse/openj9"
}
|
{
"id": 18033688,
"login": "gacholio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18033688?",
"url": "https://api.github.com/users/gacholio"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2019-06-25T17:51:11 |
9891409399
|
{"actor":{"display_login":"gacholio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/334059732","pull_request_review_id":300771659,"id":334059732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDA1OTczMg==","diff_hunk":"@@ -27,67 +27,93 @@ void arm64CodeSync(unsigned char *codeStart, unsigned int codeSize);\n uint8_t *\n TR_ARM64RelocationTarget::eipBaseForCallOffset(uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n- return NULL;\n+ // reloLocation points at the start of the call offset\n+ return reloLocation;\n }\n \n void\n TR_ARM64RelocationTarget::storeCallTarget(uintptr_t callTarget, uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n+ // reloLocation points at the start of the call offset, so just store the uint8_t * at reloLocation\n+ storePointer((uint8_t *)callTarget, reloLocation);;\n }\n \n uint32_t\n TR_ARM64RelocationTarget::loadCPIndex(uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n- return 0;\n+ // reloLocation points at the cpAddress in snippet, need to find cpIndex location\n+ reloLocation += sizeof(uintptr_t);\n+ return (uint32_t)(((uintptr_t )loadPointer(reloLocation)) & 0xFFFFFFFFUL); // Mask out lower 32 bits for index\n }\n \n uintptr_t\n TR_ARM64RelocationTarget::loadThunkCPIndex(uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n- return 0;\n+ // reloLocation points at the cpAddress in snippet, need to find cpIndex location\n+ reloLocation += sizeof(uintptr_t);\n+ return (uintptr_t )loadPointer(reloLocation);\n }\n \n void\n TR_ARM64RelocationTarget::performThunkRelocation(uint8_t *thunkBase, uintptr_t vmHelper)\n {\n- TR_UNIMPLEMENTED();\n+ uintptr_t sendTarget = vmHelper;\n+ int32_t *thunkRelocationData = (int32_t *)(thunkBase - sizeof(int32_t));\n+\n+ storeAddressSequence((uint8_t *)vmHelper, thunkBase + *thunkRelocationData, 1);\n+\n+ arm64CodeSync(thunkBase, *((int32_t*)(thunkBase - 2*sizeof(int32_t))));\n }\n \n uint8_t *\n TR_ARM64RelocationTarget::loadAddressSequence(uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n- return NULL;\n+ TR_ASSERT(0, \"AOT New Relo Runtime: don't expect loadAddressSequence to be called!\\n\");\n+ uintptr_t value = 0;\n+ return (uint8_t *)value;\n }\n \n void\n TR_ARM64RelocationTarget::storeAddressSequence(uint8_t *address, uint8_t *reloLocation, uint32_t seqNumber)\n {\n- TR_UNIMPLEMENTED();\n+ uintptr_t value = (uintptr_t)address;\n+ uint32_t *movInstruction = (uint32_t *) reloLocation;\n+ // immediate offset is at bit 20:5\n+ *movInstruction = (*movInstruction & (~((uint32_t)0xFFFF << 5))) | ((value & 0x0000FFFF) << 5);\n+ *(movInstruction + 1) = (*(movInstruction + 1) & (~((uint32_t)0xFFFF << 5))) | (((value >> 16) & 0x0000FFFF) << 5);\n+ *(movInstruction + 2) = (*(movInstruction + 2) & (~((uint32_t)0xFFFF << 5))) | (((value >> 32) & 0x0000FFFF) << 5);\n+ *(movInstruction + 3) = (*(movInstruction + 3) & (~((uint32_t)0xFFFF << 5))) | (((value >> 48) & 0x0000FFFF) << 5);\n }\n \n void\n TR_ARM64RelocationTarget::storeRelativeTarget(uintptr_t callTarget, uint8_t *reloLocation)\n {\n- TR_UNIMPLEMENTED();\n+ // reloLocation points at the start of the call offset, so just store the uint8_t * at reloLocation\n+ int32_t instruction = *((int32_t *)reloLocation);\n+\n+ instruction &= (int32_t)0xFC000000;\n+ // labels will always be 4 aligned, CPU shifts # left by 2\n+ // during execution (26 bits -> 28 bit branch reach)\n+ instruction |= (callTarget >> 2) & 0x03FFFFFF;\n+\n+ storeSigned32b(instruction, (uint8_t *)reloLocation);\n }\n \n bool\n-TR_ARM64RelocationTarget::useTrampoline(uint8_t * helperAddress, uint8_t *baseLocation)\n+TR_ARM64RelocationTarget::useTrampoline(uint8_t *helperAddress, uint8_t *baseLocation)\n {\n- TR_UNIMPLEMENTED();\n- return false;\n+ return\n+ !TR::Compiler->target.cpu.isTargetWithinUnconditionalBranchImmediateRange((intptrj_t)helperAddress, (intptrj_t)baseLocation) ||\n+ TR::Options::getCmdLineOptions()->getOption(TR_StressTrampolines);\n }\n \n uint8_t *\n TR_ARM64RelocationTarget::arrayCopyHelperAddress(J9JavaVM *javaVM)\n {\n- TR_UNIMPLEMENTED();\n- return NULL;\n+ uintptr_t *funcdescrptr = (UDATA *)javaVM->memoryManagerFunctions->referenceArrayCopy;\n+ uintptr_t value = (UDATA)funcdescrptr;\n+\n+ return (uint8_t *)value;","path":"runtime/compiler/aarch64/runtime/ARM64RelocationTarget.cpp","position":107,"original_position":107,"commit_id":"ac72f20b4826e7e72876362487418dc3952aa36e","original_commit_id":"ac72f20b4826e7e72876362487418dc3952aa36e","user":{"login":"dsouzai","id":18743715,"node_id":"MDQ6VXNlcjE4NzQzNzE1","avatar_url":"https://avatars3.githubusercontent.com/u/18743715?v=4","gravatar_id":"","url":"https://api.github.com/users/dsouzai","html_url":"https://github.com/dsouzai","followers_url":"https://api.github.com/users/dsouzai/followers","following_url":"https://api.github.com/users/dsouzai/following{/other_user}","gists_url":"https://api.github.com/users/dsouzai/gists{/gist_id}","starred_url":"https://api.github.com/users/dsouzai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsouzai/subscriptions","organizations_url":"https://api.github.com/users/dsouzai/orgs","repos_url":"https://api.github.com/users/dsouzai/repos","events_url":"https://api.github.com/users/dsouzai/events{/privacy}","received_events_url":"https://api.github.com/users/dsouzai/received_events","type":"User","site_admin":false},"body":"Might be more concise if it was just:\r\n```\r\n return reinterpret_cast<uint8_t *>(javaVM->memoryManagerFunctions->referenceArrayCopy);\r\n```","created_at":"2019-10-11T15:51:04Z","updated_at":"2019-10-11T15:52:29Z","html_url":"https://github.com/eclipse/openj9/pull/7202#discussion_r334059732","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/7202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/334059732"},"html":{"href":"https://github.com/eclipse/openj9/pull/7202#discussion_r334059732"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7202"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/7202","id":320604233,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIwNjA0MjMz","html_url":"https://github.com/eclipse/openj9/pull/7202","diff_url":"https://github.com/eclipse/openj9/pull/7202.diff","patch_url":"https://github.com/eclipse/openj9/pull/7202.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/7202","number":7202,"state":"open","locked":false,"title":"AArch64: Implement functions of TR_ARM64RelocationTarget","user":{"login":"Akira1Saitoh","id":35320034,"node_id":"MDQ6VXNlcjM1MzIwMDM0","avatar_url":"https://avatars1.githubusercontent.com/u/35320034?v=4","gravatar_id":"","url":"https://api.github.com/users/Akira1Saitoh","html_url":"https://github.com/Akira1Saitoh","followers_url":"https://api.github.com/users/Akira1Saitoh/followers","following_url":"https://api.github.com/users/Akira1Saitoh/following{/other_user}","gists_url":"https://api.github.com/users/Akira1Saitoh/gists{/gist_id}","starred_url":"https://api.github.com/users/Akira1Saitoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akira1Saitoh/subscriptions","organizations_url":"https://api.github.com/users/Akira1Saitoh/orgs","repos_url":"https://api.github.com/users/Akira1Saitoh/repos","events_url":"https://api.github.com/users/Akira1Saitoh/events{/privacy}","received_events_url":"https://api.github.com/users/Akira1Saitoh/received_events","type":"User","site_admin":false},"body":"This commit adds implementation of TR_ARM64RelocationTarget and\r\nchanges patch offset encoded in TR::ARM64CallSnippet::generateVIThunk.\r\n\r\nSigned-off-by: Akira Saitoh <saiaki@jp.ibm.com>","created_at":"2019-09-24T06:23:34Z","updated_at":"2019-10-11T15:52:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32ce5413e3091f973508144e35a33d319cc54e14","assignee":{"login":"dsouzai","id":18743715,"node_id":"MDQ6VXNlcjE4NzQzNzE1","avatar_url":"https://avatars3.githubusercontent.com/u/18743715?v=4","gravatar_id":"","url":"https://api.github.com/users/dsouzai","html_url":"https://github.com/dsouzai","followers_url":"https://api.github.com/users/dsouzai/followers","following_url":"https://api.github.com/users/dsouzai/following{/other_user}","gists_url":"https://api.github.com/users/dsouzai/gists{/gist_id}","starred_url":"https://api.github.com/users/dsouzai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsouzai/subscriptions","organizations_url":"https://api.github.com/users/dsouzai/orgs","repos_url":"https://api.github.com/users/dsouzai/repos","events_url":"https://api.github.com/users/dsouzai/events{/privacy}","received_events_url":"https://api.github.com/users/dsouzai/received_events","type":"User","site_admin":false},"assignees":[{"login":"dsouzai","id":18743715,"node_id":"MDQ6VXNlcjE4NzQzNzE1","avatar_url":"https://avatars3.githubusercontent.com/u/18743715?v=4","gravatar_id":"","url":"https://api.github.com/users/dsouzai","html_url":"https://github.com/dsouzai","followers_url":"https://api.github.com/users/dsouzai/followers","following_url":"https://api.github.com/users/dsouzai/following{/other_user}","gists_url":"https://api.github.com/users/dsouzai/gists{/gist_id}","starred_url":"https://api.github.com/users/dsouzai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsouzai/subscriptions","organizations_url":"https://api.github.com/users/dsouzai/orgs","repos_url":"https://api.github.com/users/dsouzai/repos","events_url":"https://api.github.com/users/dsouzai/events{/privacy}","received_events_url":"https://api.github.com/users/dsouzai/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1421127916,"node_id":"MDU6TGFiZWwxNDIxMTI3OTE2","url":"https://api.github.com/repos/eclipse/openj9/labels/arch:aarch64","name":"arch:aarch64","color":"32c9b5","default":false},{"id":697962585,"node_id":"MDU6TGFiZWw2OTc5NjI1ODU=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:jit","name":"comp:jit","color":"1d76db","default":false},{"id":1225570417,"node_id":"MDU6TGFiZWwxMjI1NTcwNDE3","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:jit:aot","name":"comp:jit:aot","color":"e99695","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/7202/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/7202/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/7202/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/ac72f20b4826e7e72876362487418dc3952aa36e","head":{"label":"Akira1Saitoh:aarch64RelocationTarget","ref":"aarch64RelocationTarget","sha":"ac72f20b4826e7e72876362487418dc3952aa36e","user":{"login":"Akira1Saitoh","id":35320034,"node_id":"MDQ6VXNlcjM1MzIwMDM0","avatar_url":"https://avatars1.githubusercontent.com/u/35320034?v=4","gravatar_id":"","url":"https://api.github.com/users/Akira1Saitoh","html_url":"https://github.com/Akira1Saitoh","followers_url":"https://api.github.com/users/Akira1Saitoh/followers","following_url":"https://api.github.com/users/Akira1Saitoh/following{/other_user}","gists_url":"https://api.github.com/users/Akira1Saitoh/gists{/gist_id}","starred_url":"https://api.github.com/users/Akira1Saitoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akira1Saitoh/subscriptions","organizations_url":"https://api.github.com/users/Akira1Saitoh/orgs","repos_url":"https://api.github.com/users/Akira1Saitoh/repos","events_url":"https://api.github.com/users/Akira1Saitoh/events{/privacy}","received_events_url":"https://api.github.com/users/Akira1Saitoh/received_events","type":"User","site_admin":false},"repo":{"id":203123680,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMxMjM2ODA=","name":"openj9","full_name":"Akira1Saitoh/openj9","private":false,"owner":{"login":"Akira1Saitoh","id":35320034,"node_id":"MDQ6VXNlcjM1MzIwMDM0","avatar_url":"https://avatars1.githubusercontent.com/u/35320034?v=4","gravatar_id":"","url":"https://api.github.com/users/Akira1Saitoh","html_url":"https://github.com/Akira1Saitoh","followers_url":"https://api.github.com/users/Akira1Saitoh/followers","following_url":"https://api.github.com/users/Akira1Saitoh/following{/other_user}","gists_url":"https://api.github.com/users/Akira1Saitoh/gists{/gist_id}","starred_url":"https://api.github.com/users/Akira1Saitoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Akira1Saitoh/subscriptions","organizations_url":"https://api.github.com/users/Akira1Saitoh/orgs","repos_url":"https://api.github.com/users/Akira1Saitoh/repos","events_url":"https://api.github.com/users/Akira1Saitoh/events{/privacy}","received_events_url":"https://api.github.com/users/Akira1Saitoh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Akira1Saitoh/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/Akira1Saitoh/openj9","forks_url":"https://api.github.com/repos/Akira1Saitoh/openj9/forks","keys_url":"https://api.github.com/repos/Akira1Saitoh/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Akira1Saitoh/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Akira1Saitoh/openj9/teams","hooks_url":"https://api.github.com/repos/Akira1Saitoh/openj9/hooks","issue_events_url":"https://api.github.com/repos/Akira1Saitoh/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/Akira1Saitoh/openj9/events","assignees_url":"https://api.github.com/repos/Akira1Saitoh/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/Akira1Saitoh/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/Akira1Saitoh/openj9/tags","blobs_url":"https://api.github.com/repos/Akira1Saitoh/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Akira1Saitoh/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Akira1Saitoh/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/Akira1Saitoh/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Akira1Saitoh/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/Akira1Saitoh/openj9/languages","stargazers_url":"https://api.github.com/repos/Akira1Saitoh/openj9/stargazers","contributors_url":"https://api.github.com/repos/Akira1Saitoh/openj9/contributors","subscribers_url":"https://api.github.com/repos/Akira1Saitoh/openj9/subscribers","subscription_url":"https://api.github.com/repos/Akira1Saitoh/openj9/subscription","commits_url":"https://api.github.com/repos/Akira1Saitoh/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/Akira1Saitoh/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/Akira1Saitoh/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/Akira1Saitoh/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/Akira1Saitoh/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/Akira1Saitoh/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Akira1Saitoh/openj9/merges","archive_url":"https://api.github.com/repos/Akira1Saitoh/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Akira1Saitoh/openj9/downloads","issues_url":"https://api.github.com/repos/Akira1Saitoh/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/Akira1Saitoh/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/Akira1Saitoh/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/Akira1Saitoh/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Akira1Saitoh/openj9/labels{/name}","releases_url":"https://api.github.com/repos/Akira1Saitoh/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/Akira1Saitoh/openj9/deployments","created_at":"2019-08-19T07:44:52Z","updated_at":"2019-09-25T00:47:22Z","pushed_at":"2019-10-09T06:47:59Z","git_url":"git://github.com/Akira1Saitoh/openj9.git","ssh_url":"git@github.com:Akira1Saitoh/openj9.git","clone_url":"https://github.com/Akira1Saitoh/openj9.git","svn_url":"https://github.com/Akira1Saitoh/openj9","homepage":"","size":60394,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"201ce8257bd538020ec37ee4ed3857677e53c265","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2019-10-11T15:01:29Z","pushed_at":"2019-10-11T15:50:49Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":62071,"stargazers_count":2108,"watchers_count":2108,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":970,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":425,"open_issues":970,"watchers":2108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7202"},"html":{"href":"https://github.com/eclipse/openj9/pull/7202"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/7202"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/7202/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7202/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7202/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/ac72f20b4826e7e72876362487418dc3952aa36e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101408117,
"name": "eclipse/openj9",
"url": "https://api.github.com/repos/eclipse/openj9"
}
|
{
"id": 18743715,
"login": "dsouzai",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/18743715?",
"url": "https://api.github.com/users/dsouzai"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2019-10-11T15:51:04 |
10612174451
|
{"actor":{"display_login":"dsouzai"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/316013817","pull_request_review_id":277577306,"id":316013817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjAxMzgxNw==","diff_hunk":"@@ -232,7 +234,7 @@ export class Ide {\n }\n \n async getApplicationUrlFromNotification(notificationText: string) {\n- const notificationTextLocator: By = By.xpath(`//div[@class='theia-Notification']//p[contains(@id,'${notificationText}')]`);\n+ const notificationTextLocator: By = By.xpath(`//div[@class='theia-notification-message']/span[contains(.,'${notificationText}')]`);","path":"e2e/pageobjects/ide/Ide.ts","position":49,"original_position":49,"commit_id":"7d16bd5028c6c792df7c932bf7da29bbd23f119e","original_commit_id":"7d16bd5028c6c792df7c932bf7da29bbd23f119e","user":{"login":"Ohrimenko1988","id":22724619,"node_id":"MDQ6VXNlcjIyNzI0NjE5","avatar_url":"https://avatars1.githubusercontent.com/u/22724619?v=4","gravatar_id":"","url":"https://api.github.com/users/Ohrimenko1988","html_url":"https://github.com/Ohrimenko1988","followers_url":"https://api.github.com/users/Ohrimenko1988/followers","following_url":"https://api.github.com/users/Ohrimenko1988/following{/other_user}","gists_url":"https://api.github.com/users/Ohrimenko1988/gists{/gist_id}","starred_url":"https://api.github.com/users/Ohrimenko1988/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ohrimenko1988/subscriptions","organizations_url":"https://api.github.com/users/Ohrimenko1988/orgs","repos_url":"https://api.github.com/users/Ohrimenko1988/repos","events_url":"https://api.github.com/users/Ohrimenko1988/events{/privacy}","received_events_url":"https://api.github.com/users/Ohrimenko1988/received_events","type":"User","site_admin":false},"body":"Could you explain what does \".\" mean instead of \"@id\"","created_at":"2019-08-21T06:20:54Z","updated_at":"2019-08-21T06:20:54Z","html_url":"https://github.com/eclipse/che/pull/14285#discussion_r316013817","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/14285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/316013817"},"html":{"href":"https://github.com/eclipse/che/pull/14285#discussion_r316013817"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/14285"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/14285","id":308621760,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA4NjIxNzYw","html_url":"https://github.com/eclipse/che/pull/14285","diff_url":"https://github.com/eclipse/che/pull/14285.diff","patch_url":"https://github.com/eclipse/che/pull/14285.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/14285","number":14285,"state":"open","locked":false,"title":"[DO NOT MERGE] use the latest nightly image","user":{"login":"vparfonov","id":1636592,"node_id":"MDQ6VXNlcjE2MzY1OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1636592?v=4","gravatar_id":"","url":"https://api.github.com/users/vparfonov","html_url":"https://github.com/vparfonov","followers_url":"https://api.github.com/users/vparfonov/followers","following_url":"https://api.github.com/users/vparfonov/following{/other_user}","gists_url":"https://api.github.com/users/vparfonov/gists{/gist_id}","starred_url":"https://api.github.com/users/vparfonov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vparfonov/subscriptions","organizations_url":"https://api.github.com/users/vparfonov/orgs","repos_url":"https://api.github.com/users/vparfonov/repos","events_url":"https://api.github.com/users/vparfonov/events{/privacy}","received_events_url":"https://api.github.com/users/vparfonov/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>\r\n\r\n<!-- Please review the following before submitting a PR:\r\nChe's Contributing Guide: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md\r\nPull Request Policy: https://github.com/eclipse/che/wiki/Development-Workflow#pull-requests\r\n\r\nCOMMITTERS: please include labels on each PR. Labels are listed here: https://github.com/eclipse/che/wiki/Labels but at a minimum you should include `kind/..` and `Dev Open Pull Request Status` labels.\r\n-->\r\n\r\n### What does this PR do?\r\nuse the latest nightly image, don't merge until not fixed following issues:\r\n\r\n- [ ] Java LS server initialization was failed #14283\r\n- [ ] Fix Happy path tests to run against Che with next version for default plugins. #14248\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n<!-- #### Changelog -->\r\n<!-- The changelog will be pulled from the PR's title. \r\n Please provide a clear and meaningful title to the PR and don't include issue number -->\r\n\r\n\r\n#### Release Notes\r\n<!-- markdown to be included in marketing announcement - N/A for bugs -->\r\n\r\n\r\n#### Docs PR\r\n<!-- Please add a matching PR to [the docs repo](https://github.com/eclipse/che-docs) and link that PR to this issue.\r\nBoth will be merged at the same time. -->\r\n","created_at":"2019-08-19T13:53:39Z","updated_at":"2019-08-21T06:20:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02a389375dc7aad24b5f7b7163ef060a1c7816eb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nickboldt","id":227597,"node_id":"MDQ6VXNlcjIyNzU5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/227597?v=4","gravatar_id":"","url":"https://api.github.com/users/nickboldt","html_url":"https://github.com/nickboldt","followers_url":"https://api.github.com/users/nickboldt/followers","following_url":"https://api.github.com/users/nickboldt/following{/other_user}","gists_url":"https://api.github.com/users/nickboldt/gists{/gist_id}","starred_url":"https://api.github.com/users/nickboldt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickboldt/subscriptions","organizations_url":"https://api.github.com/users/nickboldt/orgs","repos_url":"https://api.github.com/users/nickboldt/repos","events_url":"https://api.github.com/users/nickboldt/events{/privacy}","received_events_url":"https://api.github.com/users/nickboldt/received_events","type":"User","site_admin":false},{"login":"l0rd","id":606959,"node_id":"MDQ6VXNlcjYwNjk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/606959?v=4","gravatar_id":"","url":"https://api.github.com/users/l0rd","html_url":"https://github.com/l0rd","followers_url":"https://api.github.com/users/l0rd/followers","following_url":"https://api.github.com/users/l0rd/following{/other_user}","gists_url":"https://api.github.com/users/l0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0rd/subscriptions","organizations_url":"https://api.github.com/users/l0rd/orgs","repos_url":"https://api.github.com/users/l0rd/repos","events_url":"https://api.github.com/users/l0rd/events{/privacy}","received_events_url":"https://api.github.com/users/l0rd/received_events","type":"User","site_admin":false},{"login":"rhopp","id":1215011,"node_id":"MDQ6VXNlcjEyMTUwMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1215011?v=4","gravatar_id":"","url":"https://api.github.com/users/rhopp","html_url":"https://github.com/rhopp","followers_url":"https://api.github.com/users/rhopp/followers","following_url":"https://api.github.com/users/rhopp/following{/other_user}","gists_url":"https://api.github.com/users/rhopp/gists{/gist_id}","starred_url":"https://api.github.com/users/rhopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhopp/subscriptions","organizations_url":"https://api.github.com/users/rhopp/orgs","repos_url":"https://api.github.com/users/rhopp/repos","events_url":"https://api.github.com/users/rhopp/events{/privacy}","received_events_url":"https://api.github.com/users/rhopp/received_events","type":"User","site_admin":false},{"login":"ibuziuk","id":1461122,"node_id":"MDQ6VXNlcjE0NjExMjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1461122?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuziuk","html_url":"https://github.com/ibuziuk","followers_url":"https://api.github.com/users/ibuziuk/followers","following_url":"https://api.github.com/users/ibuziuk/following{/other_user}","gists_url":"https://api.github.com/users/ibuziuk/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuziuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuziuk/subscriptions","organizations_url":"https://api.github.com/users/ibuziuk/orgs","repos_url":"https://api.github.com/users/ibuziuk/repos","events_url":"https://api.github.com/users/ibuziuk/events{/privacy}","received_events_url":"https://api.github.com/users/ibuziuk/received_events","type":"User","site_admin":false},{"login":"musienko-maxim","id":1640058,"node_id":"MDQ6VXNlcjE2NDAwNTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1640058?v=4","gravatar_id":"","url":"https://api.github.com/users/musienko-maxim","html_url":"https://github.com/musienko-maxim","followers_url":"https://api.github.com/users/musienko-maxim/followers","following_url":"https://api.github.com/users/musienko-maxim/following{/other_user}","gists_url":"https://api.github.com/users/musienko-maxim/gists{/gist_id}","starred_url":"https://api.github.com/users/musienko-maxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musienko-maxim/subscriptions","organizations_url":"https://api.github.com/users/musienko-maxim/orgs","repos_url":"https://api.github.com/users/musienko-maxim/repos","events_url":"https://api.github.com/users/musienko-maxim/events{/privacy}","received_events_url":"https://api.github.com/users/musienko-maxim/received_events","type":"User","site_admin":false},{"login":"sleshchenko","id":5887312,"node_id":"MDQ6VXNlcjU4ODczMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5887312?v=4","gravatar_id":"","url":"https://api.github.com/users/sleshchenko","html_url":"https://github.com/sleshchenko","followers_url":"https://api.github.com/users/sleshchenko/followers","following_url":"https://api.github.com/users/sleshchenko/following{/other_user}","gists_url":"https://api.github.com/users/sleshchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sleshchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleshchenko/subscriptions","organizations_url":"https://api.github.com/users/sleshchenko/orgs","repos_url":"https://api.github.com/users/sleshchenko/repos","events_url":"https://api.github.com/users/sleshchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sleshchenko/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/14285/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/14285/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/14285/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/7d16bd5028c6c792df7c932bf7da29bbd23f119e","head":{"label":"eclipse:che#14253","ref":"che#14253","sha":"7d16bd5028c6c792df7c932bf7da29bbd23f119e","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE. Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2019-08-20T14:22:34Z","pushed_at":"2019-08-20T21:24:27Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":109960,"stargazers_count":5649,"watchers_count":5649,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1051,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":1051,"open_issues":1382,"watchers":5649,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"29e9dc415719944033faf8cf5eb3be1904752159","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE. Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2019-08-20T14:22:34Z","pushed_at":"2019-08-20T21:24:27Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":109960,"stargazers_count":5649,"watchers_count":5649,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1051,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1382,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":1051,"open_issues":1382,"watchers":5649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/14285"},"html":{"href":"https://github.com/eclipse/che/pull/14285"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/14285"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/14285/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/14285/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/14285/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/7d16bd5028c6c792df7c932bf7da29bbd23f119e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 32935745,
"name": "eclipse/che",
"url": "https://api.github.com/repos/eclipse/che"
}
|
{
"id": 22724619,
"login": "Ohrimenko1988",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22724619?",
"url": "https://api.github.com/users/Ohrimenko1988"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2019-08-21T06:20:54 |
10251406222
|
{"actor":{"display_login":"Ohrimenko1988"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/364872472","pull_request_review_id":340696916,"id":364872472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDg3MjQ3Mg==","diff_hunk":"@@ -0,0 +1,549 @@\n+/*******************************************************************************\n+ * Copyright (c) 2020, 2020 IBM Corp. and others\n+ *\n+ * This program and the accompanying materials are made available under\n+ * the terms of the Eclipse Public License 2.0 which accompanies this\n+ * distribution and is available at https://www.eclipse.org/legal/epl-2.0/\n+ * or the Apache License, Version 2.0 which accompanies this distribution and\n+ * is available at https://www.apache.org/licenses/LICENSE-2.0.\n+ *\n+ * This Source Code may also be made available under the following\n+ * Secondary Licenses when the conditions for such availability set\n+ * forth in the Eclipse Public License, v. 2.0 are satisfied: GNU\n+ * General Public License, version 2 with the GNU Classpath\n+ * Exception [1] and GNU General Public License, version 2 with the\n+ * OpenJDK Assembly Exception [2].\n+ *\n+ * [1] https://www.gnu.org/software/classpath/license.html\n+ * [2] http://openjdk.java.net/legal/assembly-exception.html\n+ *\n+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 OR LicenseRef-GPL-2.0 WITH Assembly-exception\n+ *******************************************************************************/\n+package org.openj9.test.java.lang;\n+\n+import org.testng.annotations.Test;\n+import org.testng.AssertJUnit;\n+\n+@Test(groups={ \"level.sanity\" }, invocationCount=2)\n+public class Test_Math_Fma \n+ {\n+ @Test\n+\tpublic void test_Math_fma_double() \n+ {\n+ /**\n+ * Testing special case: \n+ * If any argument is NaN, the result is NaN.\n+ */\n+ double a, b, c, r;\n+ a = Double.NaN;\n+ b = Math.random(); \n+ c = Math.random();\n+ r = Math.fma(a, b, c);\n+ AssertJUnit.assertTrue(Double.isNaN(r));","path":"test/functional/Java9andUp/src/org/openj9/test/java/lang/Test_Math_Fma.java","position":42,"original_position":42,"commit_id":"05e6a71547112dbeca63c6b759d4810560d9029d","original_commit_id":"05e6a71547112dbeca63c6b759d4810560d9029d","user":{"login":"fjeremic","id":16259104,"node_id":"MDQ6VXNlcjE2MjU5MTA0","avatar_url":"https://avatars1.githubusercontent.com/u/16259104?v=4","gravatar_id":"","url":"https://api.github.com/users/fjeremic","html_url":"https://github.com/fjeremic","followers_url":"https://api.github.com/users/fjeremic/followers","following_url":"https://api.github.com/users/fjeremic/following{/other_user}","gists_url":"https://api.github.com/users/fjeremic/gists{/gist_id}","starred_url":"https://api.github.com/users/fjeremic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fjeremic/subscriptions","organizations_url":"https://api.github.com/users/fjeremic/orgs","repos_url":"https://api.github.com/users/fjeremic/repos","events_url":"https://api.github.com/users/fjeremic/events{/privacy}","received_events_url":"https://api.github.com/users/fjeremic/received_events","type":"User","site_admin":false},"body":"I'm a little concerned with the use of `random()` above. If this assert ever fires, do you think it would be useful to know the values of `a`, `b`, and `c` so that we can easily debug and reproduce what happened? We should consider using the `String` argument to `assertTrue` [1] to pass a failure message displaying what the values of the inputs were.\r\n\r\n[1] http://junit.sourceforge.net/javadoc/org/junit/Assert.html#assertTrue(java.lang.String,%20boolean)","created_at":"2020-01-09T17:38:40Z","updated_at":"2020-01-09T17:38:50Z","html_url":"https://github.com/eclipse/openj9/pull/7475#discussion_r364872472","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/7475","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/364872472"},"html":{"href":"https://github.com/eclipse/openj9/pull/7475#discussion_r364872472"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7475"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/7475","id":328787360,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4Nzg3MzYw","html_url":"https://github.com/eclipse/openj9/pull/7475","diff_url":"https://github.com/eclipse/openj9/pull/7475.diff","patch_url":"https://github.com/eclipse/openj9/pull/7475.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/7475","number":7475,"state":"open","locked":false,"title":"Recognized fma methods on Power","user":{"login":"wbh123456","id":35285095,"node_id":"MDQ6VXNlcjM1Mjg1MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/35285095?v=4","gravatar_id":"","url":"https://api.github.com/users/wbh123456","html_url":"https://github.com/wbh123456","followers_url":"https://api.github.com/users/wbh123456/followers","following_url":"https://api.github.com/users/wbh123456/following{/other_user}","gists_url":"https://api.github.com/users/wbh123456/gists{/gist_id}","starred_url":"https://api.github.com/users/wbh123456/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbh123456/subscriptions","organizations_url":"https://api.github.com/users/wbh123456/orgs","repos_url":"https://api.github.com/users/wbh123456/repos","events_url":"https://api.github.com/users/wbh123456/events{/privacy}","received_events_url":"https://api.github.com/users/wbh123456/received_events","type":"User","site_admin":false},"body":"Add the following fma methods into J9 Recognized Methods on Power. Also added fma tests cases to test these recognized methods.\r\n- `TR::java_lang_Math_fma_D`\r\n- `TR::java_lang_Math_fma_F`\r\n- `TR::java_lang_StrictMath_fma_D` \r\n- `TR::java_lang_StrictMath_fma_F`\r\n\r\nImplement the methods in function `J9::Power::CodeGenerator::inlineDirectCall()`.\r\nAdd 2 helper functions:\r\n- `static TR::Register *inlineDoublePrecisionFPTrg1Src3(TR::Node *node, TR::InstOpCode::Mnemonic op, TR::CodeGenerator *cg)`\r\n\t--> Return the target register generated by `op` and `node` with 3 children in Double Precision\r\n- `static TR::Register *inlineSinglePrecisionFPTrg1Src3(TR::Node *node, TR::InstOpCode::Mnemonic op, TR::CodeGenerator *cg)`\r\n\t--> Return the target register generated by `op` and `node` with 3 children in Single Precision\r\n\r\nIssue: #7474\r\nSigned-off-by: Bohao(Aaron) Wang <aaronwang0407@gmail.com>","created_at":"2019-10-16T14:20:22Z","updated_at":"2020-01-09T17:38:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd2a03b128155dc5b2fe2e05c781657b5107c8b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962585,"node_id":"MDU6TGFiZWw2OTc5NjI1ODU=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:jit","name":"comp:jit","color":"1d76db","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/7475/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/7475/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/7475/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/05e6a71547112dbeca63c6b759d4810560d9029d","head":{"label":"wbh123456:rcgnz_fma","ref":"rcgnz_fma","sha":"05e6a71547112dbeca63c6b759d4810560d9029d","user":{"login":"wbh123456","id":35285095,"node_id":"MDQ6VXNlcjM1Mjg1MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/35285095?v=4","gravatar_id":"","url":"https://api.github.com/users/wbh123456","html_url":"https://github.com/wbh123456","followers_url":"https://api.github.com/users/wbh123456/followers","following_url":"https://api.github.com/users/wbh123456/following{/other_user}","gists_url":"https://api.github.com/users/wbh123456/gists{/gist_id}","starred_url":"https://api.github.com/users/wbh123456/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbh123456/subscriptions","organizations_url":"https://api.github.com/users/wbh123456/orgs","repos_url":"https://api.github.com/users/wbh123456/repos","events_url":"https://api.github.com/users/wbh123456/events{/privacy}","received_events_url":"https://api.github.com/users/wbh123456/received_events","type":"User","site_admin":false},"repo":{"id":186873967,"node_id":"MDEwOlJlcG9zaXRvcnkxODY4NzM5Njc=","name":"openj9","full_name":"wbh123456/openj9","private":false,"owner":{"login":"wbh123456","id":35285095,"node_id":"MDQ6VXNlcjM1Mjg1MDk1","avatar_url":"https://avatars3.githubusercontent.com/u/35285095?v=4","gravatar_id":"","url":"https://api.github.com/users/wbh123456","html_url":"https://github.com/wbh123456","followers_url":"https://api.github.com/users/wbh123456/followers","following_url":"https://api.github.com/users/wbh123456/following{/other_user}","gists_url":"https://api.github.com/users/wbh123456/gists{/gist_id}","starred_url":"https://api.github.com/users/wbh123456/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbh123456/subscriptions","organizations_url":"https://api.github.com/users/wbh123456/orgs","repos_url":"https://api.github.com/users/wbh123456/repos","events_url":"https://api.github.com/users/wbh123456/events{/privacy}","received_events_url":"https://api.github.com/users/wbh123456/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wbh123456/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":true,"url":"https://api.github.com/repos/wbh123456/openj9","forks_url":"https://api.github.com/repos/wbh123456/openj9/forks","keys_url":"https://api.github.com/repos/wbh123456/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wbh123456/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wbh123456/openj9/teams","hooks_url":"https://api.github.com/repos/wbh123456/openj9/hooks","issue_events_url":"https://api.github.com/repos/wbh123456/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/wbh123456/openj9/events","assignees_url":"https://api.github.com/repos/wbh123456/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/wbh123456/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/wbh123456/openj9/tags","blobs_url":"https://api.github.com/repos/wbh123456/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wbh123456/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wbh123456/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/wbh123456/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wbh123456/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/wbh123456/openj9/languages","stargazers_url":"https://api.github.com/repos/wbh123456/openj9/stargazers","contributors_url":"https://api.github.com/repos/wbh123456/openj9/contributors","subscribers_url":"https://api.github.com/repos/wbh123456/openj9/subscribers","subscription_url":"https://api.github.com/repos/wbh123456/openj9/subscription","commits_url":"https://api.github.com/repos/wbh123456/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/wbh123456/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/wbh123456/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/wbh123456/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/wbh123456/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/wbh123456/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wbh123456/openj9/merges","archive_url":"https://api.github.com/repos/wbh123456/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wbh123456/openj9/downloads","issues_url":"https://api.github.com/repos/wbh123456/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/wbh123456/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/wbh123456/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/wbh123456/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wbh123456/openj9/labels{/name}","releases_url":"https://api.github.com/repos/wbh123456/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/wbh123456/openj9/deployments","created_at":"2019-05-15T17:29:52Z","updated_at":"2020-01-08T16:09:35Z","pushed_at":"2020-01-08T18:14:46Z","git_url":"git://github.com/wbh123456/openj9.git","ssh_url":"git@github.com:wbh123456/openj9.git","clone_url":"https://github.com/wbh123456/openj9.git","svn_url":"https://github.com/wbh123456/openj9","homepage":"","size":63588,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"60ee5fd35a3d5d619d646a98d39fd2fd1b0460ee","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput. Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2020-01-09T16:22:44Z","pushed_at":"2020-01-09T17:07:03Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":66759,"stargazers_count":2192,"watchers_count":2192,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1068,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":444,"open_issues":1068,"watchers":2192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7475"},"html":{"href":"https://github.com/eclipse/openj9/pull/7475"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/7475"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/7475/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7475/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/7475/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/05e6a71547112dbeca63c6b759d4810560d9029d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101408117,
"name": "eclipse/openj9",
"url": "https://api.github.com/repos/eclipse/openj9"
}
|
{
"id": 16259104,
"login": "fjeremic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16259104?",
"url": "https://api.github.com/users/fjeremic"
}
|
{
"id": 56974,
"login": "eclipse",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/56974?",
"url": "https://api.github.com/orgs/eclipse"
}
| 2020-01-09T17:38:40 |
11240078281
|
{"actor":{"display_login":"fjeremic"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/262199110","pull_request_review_id":210313769,"id":262199110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjE5OTExMA==","diff_hunk":"@@ -706,41 +701,52 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {\n \n interactiveUpdates: NoopRenderer.interactiveUpdates,\n \n- // maybe this should exist only in the test file\n- act(callback: () => void): Thenable {\n+ act(callback: () => void | Promise<void>) {\n // note: keep these warning messages in sync with\n // ReactTestRenderer.js and ReactTestUtils.js\n- let result = NoopRenderer.batchedUpdates(callback);\n- if (__DEV__) {\n- if (result !== undefined) {\n- let addendum;\n- if (result !== null && typeof result.then === 'function') {\n- addendum =\n- \"\\n\\nIt looks like you wrote ReactNoop.act(async () => ...) or returned a Promise from it's callback. \" +\n- 'Putting asynchronous logic inside ReactNoop.act(...) is not supported.\\n';\n- } else {\n- addendum = ' You returned: ' + result;\n- }\n- warningWithoutStack(\n- false,\n- 'The callback passed to ReactNoop.act(...) function must not return anything.%s',\n- addendum,\n- );\n+ const result = NoopRenderer.actedUpdates(callback);\n+ if (\n+ result !== null &&\n+ typeof result === 'object' &&\n+ typeof result.then === 'function'\n+ ) {\n+ let called = false;\n+ if (__DEV__) {\n+ // eslint-disable-next-line no-undef\n+ Promise.resolve()","path":"packages/react-noop-renderer/src/createReactNoop.js","position":46,"original_position":46,"commit_id":"91a3ff4cd62a7e052231a4dbc1b567c795388441","original_commit_id":"91a3ff4cd62a7e052231a4dbc1b567c795388441","user":{"login":"acdlite","id":3624098,"node_id":"MDQ6VXNlcjM2MjQwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"body":"Same here","created_at":"2019-03-04T19:04:45Z","updated_at":"2019-03-04T19:04:46Z","html_url":"https://github.com/facebook/react/pull/14853#discussion_r262199110","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/14853","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/262199110"},"html":{"href":"https://github.com/facebook/react/pull/14853#discussion_r262199110"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/14853"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/14853","id":253114353,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUzMTE0MzUz","html_url":"https://github.com/facebook/react/pull/14853","diff_url":"https://github.com/facebook/react/pull/14853.diff","patch_url":"https://github.com/facebook/react/pull/14853.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/14853","number":14853,"state":"open","locked":false,"title":"RFC - await act(async () => ...)","user":{"login":"threepointone","id":18808,"node_id":"MDQ6VXNlcjE4ODA4","avatar_url":"https://avatars2.githubusercontent.com/u/18808?v=4","gravatar_id":"","url":"https://api.github.com/users/threepointone","html_url":"https://github.com/threepointone","followers_url":"https://api.github.com/users/threepointone/followers","following_url":"https://api.github.com/users/threepointone/following{/other_user}","gists_url":"https://api.github.com/users/threepointone/gists{/gist_id}","starred_url":"https://api.github.com/users/threepointone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threepointone/subscriptions","organizations_url":"https://api.github.com/users/threepointone/orgs","repos_url":"https://api.github.com/users/threepointone/repos","events_url":"https://api.github.com/users/threepointone/events{/privacy}","received_events_url":"https://api.github.com/users/threepointone/received_events","type":"User","site_admin":false},"body":"TODO - \r\n- [x] ReactDOM, TestRenderer, NoopRenderer\r\n- [x] tests for other renderers, I missed them last time around \r\n- [x] the warnings are placeholders, still thinking about what would be better, open to suggestions\r\n- [x] implications on concurrent mode\r\n\r\n\r\n\r\n(repasting from the group)\r\n\r\nI hacked together an asynchronous version of `act(...)`, and it's kinda nice. \r\n\r\nYou've seen the synchronous version -\r\n\r\n```js\r\nact(() => {\r\n // updates and stuff\r\n})\r\n// make assertions \r\n```\r\n\r\nThis still works, and gives the same warnings. But if you pass an `async` function - \r\n```js\r\nawait act(async() => {\r\n // updates and stuff\r\n})\r\n// expect commits and effects to be flushed \r\n// make assertions \r\n```\r\nNeat! I set it up so if you *don't* `await` the result from `act`, a warning gets triggered (with `setImmediate`) to do so. That makes it a bit harder to have rogue async `act()` calls in the ether.\r\n\r\nYou can nest `act()` calls - \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n```js\r\nawait act(async() => {\r\n // nest synchronous calls\r\n act(() => {\r\n // updates and such \r\n })\r\n // as before, updates and effects are flushed \r\n\r\n // make assertions \r\n await sleep(500) // or for a promise to resolve, or whatever\r\n // more assertions maybe \r\n\r\n // nest asynchronous calls too \r\n await act(async () => {\r\n // mutations and such \r\n // more awaits \r\n // and maybe an event or two\r\n })\r\n // more assertions \r\n})\r\n```\r\n\r\nI implemented a cheap form of unrolling safety, so if a previous `act()` gets closed before any subsequent `act()` calls, a warning gets triggered. This should prevent most interleaving attempts, and maintain a tree-like shape of `act()` blocks. \r\n\r\npros -\r\n- works with async/await, solves oss problems cleanly \r\n- the sync api is preserved \r\n- the warning is preserved\r\n- works with fake timers/fb \r\n\r\ncons - \r\n- can't guarantee batching after the first await in an act block (this will get better when concurrent?)\r\n- less restrictive than the sync model, and starts to feel more opt-in than opt-out (eg- someone could just wrap their entire test with an `act()` call... which might be fine?)\r\n- exposes a secret api on react dom to implement it, dunno how you feel about that\r\n\r\n\r\n","created_at":"2019-02-14T15:27:09Z","updated_at":"2019-03-04T19:04:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52d41c9caf97b196f89761b0ba6912333e0407ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196858374,"node_id":"MDU6TGFiZWwxOTY4NTgzNzQ=","url":"https://api.github.com/repos/facebook/react/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/14853/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/14853/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/14853/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/91a3ff4cd62a7e052231a4dbc1b567c795388441","head":{"label":"threepointone:async-act","ref":"async-act","sha":"91a3ff4cd62a7e052231a4dbc1b567c795388441","user":{"login":"threepointone","id":18808,"node_id":"MDQ6VXNlcjE4ODA4","avatar_url":"https://avatars2.githubusercontent.com/u/18808?v=4","gravatar_id":"","url":"https://api.github.com/users/threepointone","html_url":"https://github.com/threepointone","followers_url":"https://api.github.com/users/threepointone/followers","following_url":"https://api.github.com/users/threepointone/following{/other_user}","gists_url":"https://api.github.com/users/threepointone/gists{/gist_id}","starred_url":"https://api.github.com/users/threepointone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threepointone/subscriptions","organizations_url":"https://api.github.com/users/threepointone/orgs","repos_url":"https://api.github.com/users/threepointone/repos","events_url":"https://api.github.com/users/threepointone/events{/privacy}","received_events_url":"https://api.github.com/users/threepointone/received_events","type":"User","site_admin":false},"repo":{"id":165256901,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyNTY5MDE=","name":"react","full_name":"threepointone/react","private":false,"owner":{"login":"threepointone","id":18808,"node_id":"MDQ6VXNlcjE4ODA4","avatar_url":"https://avatars2.githubusercontent.com/u/18808?v=4","gravatar_id":"","url":"https://api.github.com/users/threepointone","html_url":"https://github.com/threepointone","followers_url":"https://api.github.com/users/threepointone/followers","following_url":"https://api.github.com/users/threepointone/following{/other_user}","gists_url":"https://api.github.com/users/threepointone/gists{/gist_id}","starred_url":"https://api.github.com/users/threepointone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threepointone/subscriptions","organizations_url":"https://api.github.com/users/threepointone/orgs","repos_url":"https://api.github.com/users/threepointone/repos","events_url":"https://api.github.com/users/threepointone/events{/privacy}","received_events_url":"https://api.github.com/users/threepointone/received_events","type":"User","site_admin":false},"html_url":"https://github.com/threepointone/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/threepointone/react","forks_url":"https://api.github.com/repos/threepointone/react/forks","keys_url":"https://api.github.com/repos/threepointone/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threepointone/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threepointone/react/teams","hooks_url":"https://api.github.com/repos/threepointone/react/hooks","issue_events_url":"https://api.github.com/repos/threepointone/react/issues/events{/number}","events_url":"https://api.github.com/repos/threepointone/react/events","assignees_url":"https://api.github.com/repos/threepointone/react/assignees{/user}","branches_url":"https://api.github.com/repos/threepointone/react/branches{/branch}","tags_url":"https://api.github.com/repos/threepointone/react/tags","blobs_url":"https://api.github.com/repos/threepointone/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threepointone/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threepointone/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/threepointone/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threepointone/react/statuses/{sha}","languages_url":"https://api.github.com/repos/threepointone/react/languages","stargazers_url":"https://api.github.com/repos/threepointone/react/stargazers","contributors_url":"https://api.github.com/repos/threepointone/react/contributors","subscribers_url":"https://api.github.com/repos/threepointone/react/subscribers","subscription_url":"https://api.github.com/repos/threepointone/react/subscription","commits_url":"https://api.github.com/repos/threepointone/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/threepointone/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/threepointone/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/threepointone/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/threepointone/react/contents/{+path}","compare_url":"https://api.github.com/repos/threepointone/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threepointone/react/merges","archive_url":"https://api.github.com/repos/threepointone/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threepointone/react/downloads","issues_url":"https://api.github.com/repos/threepointone/react/issues{/number}","pulls_url":"https://api.github.com/repos/threepointone/react/pulls{/number}","milestones_url":"https://api.github.com/repos/threepointone/react/milestones{/number}","notifications_url":"https://api.github.com/repos/threepointone/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threepointone/react/labels{/name}","releases_url":"https://api.github.com/repos/threepointone/react/releases{/id}","deployments_url":"https://api.github.com/repos/threepointone/react/deployments","created_at":"2019-01-11T14:30:06Z","updated_at":"2019-02-15T15:02:14Z","pushed_at":"2019-03-04T15:21:11Z","git_url":"git://github.com/threepointone/react.git","ssh_url":"git@github.com:threepointone/react.git","clone_url":"https://github.com/threepointone/react.git","svn_url":"https://github.com/threepointone/react","homepage":"https://reactjs.org","size":140925,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"bb2939ccc23c9895d798f889d9c32848be43225e","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDI1MA==","name":"react","full_name":"facebook/react","private":false,"owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2019-03-04T19:02:29Z","pushed_at":"2019-03-04T18:04:47Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":140785,"stargazers_count":123605,"watchers_count":123605,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22446,"mirror_url":null,"archived":false,"open_issues_count":558,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22446,"open_issues":558,"watchers":123605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/14853"},"html":{"href":"https://github.com/facebook/react/pull/14853"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/14853"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/14853/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/14853/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/14853/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/91a3ff4cd62a7e052231a4dbc1b567c795388441"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 10270250,
"name": "facebook/react",
"url": "https://api.github.com/repos/facebook/react"
}
|
{
"id": 3624098,
"login": "acdlite",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3624098?",
"url": "https://api.github.com/users/acdlite"
}
|
{
"id": 69631,
"login": "facebook",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/69631?",
"url": "https://api.github.com/orgs/facebook"
}
| 2019-03-04T19:04:45 |
9177017839
|
{"actor":{"display_login":"acdlite"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/308194544","pull_request_review_id":267739128,"id":308194544,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwODE5NDU0NA==","diff_hunk":"@@ -1,15 +1,13 @@\n hqDefine('hqwebapp/js/base_ace', [\n 'jquery',\n 'ace-builds/src-min-noconflict/ace',\n+ 'ace-builds/src-min-noconflict/mode-json',\n ], function (\n $,\n- ace\n+ ace,\n+ jsonMode\n ) {\n \n- if (!ace.config.get('basePath')) {","path":"corehq/apps/hqwebapp/static/hqwebapp/js/base_ace.js","position":12,"original_position":12,"commit_id":"4c3eb9cbe9297942b2602f82af0d28e4bc462214","original_commit_id":"4c3eb9cbe9297942b2602f82af0d28e4bc462214","user":{"login":"millerdev","id":464726,"node_id":"MDQ6VXNlcjQ2NDcyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/464726?v=4","gravatar_id":"","url":"https://api.github.com/users/millerdev","html_url":"https://github.com/millerdev","followers_url":"https://api.github.com/users/millerdev/followers","following_url":"https://api.github.com/users/millerdev/following{/other_user}","gists_url":"https://api.github.com/users/millerdev/gists{/gist_id}","starred_url":"https://api.github.com/users/millerdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerdev/subscriptions","organizations_url":"https://api.github.com/users/millerdev/orgs","repos_url":"https://api.github.com/users/millerdev/repos","events_url":"https://api.github.com/users/millerdev/events{/privacy}","received_events_url":"https://api.github.com/users/millerdev/received_events","type":"User","site_admin":false},"body":"@rohit-dimagi the problem is that `requirejs.s.contexts._.config.paths` is not a public API as far as I can tell. It would be ideal to find a solution that does not need to reach into requirejs internals.\r\n\r\n@kaapstorm if this solution does not work you might try [this](http://www.howtobuildsoftware.com/index.php/how-do/bSWF/%E2%80%9C). I'm not convinced it will work, but worth a try?","created_at":"2019-07-29T12:10:44Z","updated_at":"2019-07-29T12:10:44Z","html_url":"https://github.com/dimagi/commcare-hq/pull/24955#discussion_r308194544","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/308194544"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24955#discussion_r308194544"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955"}},"in_reply_to_id":308156016},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955","id":301943197,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxOTQzMTk3","html_url":"https://github.com/dimagi/commcare-hq/pull/24955","diff_url":"https://github.com/dimagi/commcare-hq/pull/24955.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/24955.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24955","number":24955,"state":"open","locked":false,"title":"Explicitly sets ACE editor JSON mode as a requirement","user":{"login":"kaapstorm","id":708421,"node_id":"MDQ6VXNlcjcwODQyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/708421?v=4","gravatar_id":"","url":"https://api.github.com/users/kaapstorm","html_url":"https://github.com/kaapstorm","followers_url":"https://api.github.com/users/kaapstorm/followers","following_url":"https://api.github.com/users/kaapstorm/following{/other_user}","gists_url":"https://api.github.com/users/kaapstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaapstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaapstorm/subscriptions","organizations_url":"https://api.github.com/users/kaapstorm/orgs","repos_url":"https://api.github.com/users/kaapstorm/repos","events_url":"https://api.github.com/users/kaapstorm/events{/privacy}","received_events_url":"https://api.github.com/users/kaapstorm/received_events","type":"User","site_admin":false},"body":"Context: [HI-744](https://dimagi-dev.atlassian.net/browse/HI-744)\r\n\r\nThis PR effectively reverts [this commit](https://github.com/dimagi/commcare-hq/commit/16ee0688d7ee48d68c5b9a669e79bee057e09afd/), which removed the explicit requirement of the ACE editor's JSON mode in favour of finding its path.\r\n\r\nThe `build_requirejs` script doesn't parse the requirement of JSON mode, and doesn't include the path \"ace-builds/src-min-noconflict/ace\" in [the `requirejs.s.contexts._.config.paths` dictionary used in base_ace.js on line 10](https://github.com/dimagi/commcare-hq/blob/16ee0688d7ee48d68c5b9a669e79bee057e09afd/corehq/apps/hqwebapp/static/hqwebapp/js/base_ace.js#L10). As a result, `basePath` is set to `undefined` on line 10, and the script errors out on the next line at `basePath.substring` because `undefined` doesn't have a \"substring\" property.\r\n\r\nThe `build_requirejs` script works as expected when we reintroduce JSON mode as an explicit requirement.\r\n","created_at":"2019-07-29T07:29:14Z","updated_at":"2019-07-29T12:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e212c800a12c2b14ea3ffa465c3a59fecc0c2f8b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"millerdev","id":464726,"node_id":"MDQ6VXNlcjQ2NDcyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/464726?v=4","gravatar_id":"","url":"https://api.github.com/users/millerdev","html_url":"https://github.com/millerdev","followers_url":"https://api.github.com/users/millerdev/followers","following_url":"https://api.github.com/users/millerdev/following{/other_user}","gists_url":"https://api.github.com/users/millerdev/gists{/gist_id}","starred_url":"https://api.github.com/users/millerdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/millerdev/subscriptions","organizations_url":"https://api.github.com/users/millerdev/orgs","repos_url":"https://api.github.com/users/millerdev/repos","events_url":"https://api.github.com/users/millerdev/events{/privacy}","received_events_url":"https://api.github.com/users/millerdev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":724787015,"node_id":"MDU6TGFiZWw3MjQ3ODcwMTU=","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/product/invisible","name":"product/invisible","color":"cfd2d6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24955/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/4c3eb9cbe9297942b2602f82af0d28e4bc462214","head":{"label":"dimagi:nh/build_reqjs","ref":"nh/build_reqjs","sha":"4c3eb9cbe9297942b2602f82af0d28e4bc462214","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-07-29T11:30:08Z","pushed_at":"2019-07-29T11:55:04Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":491053,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":142,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":142,"open_issues":107,"watchers":366,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"a4f01227cd509d52b35d858e878c8278b07d72a5","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-07-29T11:30:08Z","pushed_at":"2019-07-29T11:55:04Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":491053,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":142,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":107,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":142,"open_issues":107,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24955"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24955"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24955/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24955/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/4c3eb9cbe9297942b2602f82af0d28e4bc462214"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 247278,
"name": "dimagi/commcare-hq",
"url": "https://api.github.com/repos/dimagi/commcare-hq"
}
|
{
"id": 464726,
"login": "millerdev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/464726?",
"url": "https://api.github.com/users/millerdev"
}
|
{
"id": 94514,
"login": "dimagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94514?",
"url": "https://api.github.com/orgs/dimagi"
}
| 2019-07-29T12:10:44 |
10102803757
|
{"actor":{"display_login":"millerdev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/306675240","pull_request_review_id":265850341,"id":306675240,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjY3NTI0MA==","diff_hunk":"@@ -84,6 +85,9 @@ <h1>\n <a data-bind=\"attr: { href: removeUrl}\" class=\"btn btn-danger\">\n {% trans 'Remove' %}\n </a>\n+ <a data-bind=\"attr: { href: recreateUrl}\" class=\"btn btn-warning\">","path":"custom/icds/templates/icds/manage_hosted_ccz.html","position":42,"original_position":12,"commit_id":"3cd6ee89d58cd3bfdcb5d7835293220845ccc857","original_commit_id":"faeba8f56bd15385fa4d8067cac4cd451eae969d","user":{"login":"mkangia","id":3864163,"node_id":"MDQ6VXNlcjM4NjQxNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3864163?v=4","gravatar_id":"","url":"https://api.github.com/users/mkangia","html_url":"https://github.com/mkangia","followers_url":"https://api.github.com/users/mkangia/followers","following_url":"https://api.github.com/users/mkangia/following{/other_user}","gists_url":"https://api.github.com/users/mkangia/gists{/gist_id}","starred_url":"https://api.github.com/users/mkangia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkangia/subscriptions","organizations_url":"https://api.github.com/users/mkangia/orgs","repos_url":"https://api.github.com/users/mkangia/repos","events_url":"https://api.github.com/users/mkangia/events{/privacy}","received_events_url":"https://api.github.com/users/mkangia/received_events","type":"User","site_admin":false},"body":"umm, i am using that for the colour it provides along with the style.\r\nWhy not use `btn-warning`?","created_at":"2019-07-24T07:59:04Z","updated_at":"2019-07-24T07:59:05Z","html_url":"https://github.com/dimagi/commcare-hq/pull/24920#discussion_r306675240","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/306675240"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24920#discussion_r306675240"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920"}},"in_reply_to_id":306511879},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920","id":300282191,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwMjgyMTkx","html_url":"https://github.com/dimagi/commcare-hq/pull/24920","diff_url":"https://github.com/dimagi/commcare-hq/pull/24920.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/24920.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24920","number":24920,"state":"open","locked":false,"title":"Couple of hosting improvements","user":{"login":"mkangia","id":3864163,"node_id":"MDQ6VXNlcjM4NjQxNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3864163?v=4","gravatar_id":"","url":"https://api.github.com/users/mkangia","html_url":"https://github.com/mkangia","followers_url":"https://api.github.com/users/mkangia/followers","following_url":"https://api.github.com/users/mkangia/following{/other_user}","gists_url":"https://api.github.com/users/mkangia/gists{/gist_id}","starred_url":"https://api.github.com/users/mkangia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkangia/subscriptions","organizations_url":"https://api.github.com/users/mkangia/orgs","repos_url":"https://api.github.com/users/mkangia/repos","events_url":"https://api.github.com/users/mkangia/events{/privacy}","received_events_url":"https://api.github.com/users/mkangia/received_events","type":"User","site_admin":false},"body":"- Share status\r\n- Allow retry/recreate\r\n\r\n[Ticket](https://dimagi-dev.atlassian.net/browse/ICDS-728)\r\n\r\nFF: `MANAGE_CCZ_HOSTING`\r\nfyi @esoergel ","created_at":"2019-07-23T12:52:56Z","updated_at":"2019-07-24T07:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f635580bdd4ddf8a15cee00003037f5140127e1c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gbova","id":15271571,"node_id":"MDQ6VXNlcjE1MjcxNTcx","avatar_url":"https://avatars0.githubusercontent.com/u/15271571?v=4","gravatar_id":"","url":"https://api.github.com/users/gbova","html_url":"https://github.com/gbova","followers_url":"https://api.github.com/users/gbova/followers","following_url":"https://api.github.com/users/gbova/following{/other_user}","gists_url":"https://api.github.com/users/gbova/gists{/gist_id}","starred_url":"https://api.github.com/users/gbova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbova/subscriptions","organizations_url":"https://api.github.com/users/gbova/orgs","repos_url":"https://api.github.com/users/gbova/repos","events_url":"https://api.github.com/users/gbova/events{/privacy}","received_events_url":"https://api.github.com/users/gbova/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":724785251,"node_id":"MDU6TGFiZWw3MjQ3ODUyNTE=","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/product/custom","name":"product/custom","color":"71239b","default":false},{"id":724785066,"node_id":"MDU6TGFiZWw3MjQ3ODUwNjY=","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/product/feature-flag","name":"product/feature-flag","color":"d38737","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24920/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/3cd6ee89d58cd3bfdcb5d7835293220845ccc857","head":{"label":"dimagi:mk/ccz-hosting-improvs","ref":"mk/ccz-hosting-improvs","sha":"3cd6ee89d58cd3bfdcb5d7835293220845ccc857","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-07-24T07:49:20Z","pushed_at":"2019-07-24T07:53:47Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":490572,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":141,"open_issues":110,"watchers":366,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"085e8aed4e253739aa381fde674c0106f364fd54","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-07-24T07:49:20Z","pushed_at":"2019-07-24T07:53:47Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":490572,"stargazers_count":366,"watchers_count":366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":141,"open_issues":110,"watchers":366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24920"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24920"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24920/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24920/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/3cd6ee89d58cd3bfdcb5d7835293220845ccc857"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 247278,
"name": "dimagi/commcare-hq",
"url": "https://api.github.com/repos/dimagi/commcare-hq"
}
|
{
"id": 3864163,
"login": "mkangia",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3864163?",
"url": "https://api.github.com/users/mkangia"
}
|
{
"id": 94514,
"login": "dimagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94514?",
"url": "https://api.github.com/orgs/dimagi"
}
| 2019-07-24T07:59:04 |
10072729778
|
{"actor":{"display_login":"mkangia"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/279105138","pull_request_review_id":231354246,"id":279105138,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3OTEwNTEzOA==","diff_hunk":"@@ -248,42 +248,58 @@ class BulkAppTranslationModulesAndFormsUpdater(BulkAppTranslationUpdater):\n def __init__(self, app, lang=None):\n super(BulkAppTranslationModulesAndFormsUpdater, self).__init__(app, lang)\n \n+ def get_document_by_legacy_identifier(self, identifier):\n+ identifying_parts = identifier.split('_')\n+ if len(identifying_parts) not in (1, 2):\n+ raise ValueError\n+ module_index = int(identifying_parts[0].replace(\"menu\", \"\").replace(\"module\", \"\")) - 1\n+ document = self.app.get_module(module_index)\n+ if len(identifying_parts) == 2:\n+ form_index = int(identifying_parts[1].replace(\"form\", \"\")) - 1\n+ document = document.get_form(form_index)\n+ return document\n+\n+ def get_document_by_identifier(self, identifier):\n+ unique_id = identifier.split(':')[1]\n+ if is_module_sheet(identifier):\n+ return self.app.get_module_by_unique_id(unique_id)\n+ if is_form_sheet(identifier):\n+ return self.app.get_form(unique_id)\n+\n+ def get_document(self, identifier):","path":"corehq/apps/translations/app_translations/upload_app.py","position":146,"original_position":22,"commit_id":"2edf5083ba039acb392a5a25397ceb1983385a6c","original_commit_id":"9a3e934c031de382b54f34d276aef666c07a3814","user":{"login":"orangejenny","id":1486591,"node_id":"MDQ6VXNlcjE0ODY1OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1486591?v=4","gravatar_id":"","url":"https://api.github.com/users/orangejenny","html_url":"https://github.com/orangejenny","followers_url":"https://api.github.com/users/orangejenny/followers","following_url":"https://api.github.com/users/orangejenny/following{/other_user}","gists_url":"https://api.github.com/users/orangejenny/gists{/gist_id}","starred_url":"https://api.github.com/users/orangejenny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orangejenny/subscriptions","organizations_url":"https://api.github.com/users/orangejenny/orgs","repos_url":"https://api.github.com/users/orangejenny/repos","events_url":"https://api.github.com/users/orangejenny/events{/privacy}","received_events_url":"https://api.github.com/users/orangejenny/received_events","type":"User","site_admin":false},"body":"Naming nitpick: what would you think of `get_module_or_form`? It's clunky, but `get_document` is vague and not really accurate.","created_at":"2019-04-26T21:11:43Z","updated_at":"2019-04-26T21:46:07Z","html_url":"https://github.com/dimagi/commcare-hq/pull/24151#discussion_r279105138","pull_request_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments/279105138"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24151#discussion_r279105138"},"pull_request":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151"}}},"pull_request":{"url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151","id":273928240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczOTI4MjQw","html_url":"https://github.com/dimagi/commcare-hq/pull/24151","diff_url":"https://github.com/dimagi/commcare-hq/pull/24151.diff","patch_url":"https://github.com/dimagi/commcare-hq/pull/24151.patch","issue_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24151","number":24151,"state":"open","locked":false,"title":"Use form/module unique IDs for app translations","user":{"login":"kaapstorm","id":708421,"node_id":"MDQ6VXNlcjcwODQyMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/708421?v=4","gravatar_id":"","url":"https://api.github.com/users/kaapstorm","html_url":"https://github.com/kaapstorm","followers_url":"https://api.github.com/users/kaapstorm/followers","following_url":"https://api.github.com/users/kaapstorm/following{/other_user}","gists_url":"https://api.github.com/users/kaapstorm/gists{/gist_id}","starred_url":"https://api.github.com/users/kaapstorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaapstorm/subscriptions","organizations_url":"https://api.github.com/users/kaapstorm/orgs","repos_url":"https://api.github.com/users/kaapstorm/repos","events_url":"https://api.github.com/users/kaapstorm/events{/privacy}","received_events_url":"https://api.github.com/users/kaapstorm/received_events","type":"User","site_admin":false},"body":"Context: [Asana](https://app.asana.com/0/1119457610578860/1113308365578031/f)\r\n\r\nThis changes Bulk App Translation worksheet names to include a unique ID and an English-readable name. (A little uglier, but also a little more useful.) This allows modules and forms to be reorganised in the app while the translations are being done, without breaking things.\r\n\r\n@emord @orangejenny @mkangia \r\n\r\n:tropical_fish: ... I should probably add some totally-not-afterthought tests, shouldn't I?\r\n","created_at":"2019-04-26T14:51:22Z","updated_at":"2019-04-26T21:46:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba180e0ca8f8e3f39e8b34f1964091f4a464f3be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"emord","id":1471773,"node_id":"MDQ6VXNlcjE0NzE3NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1471773?v=4","gravatar_id":"","url":"https://api.github.com/users/emord","html_url":"https://github.com/emord","followers_url":"https://api.github.com/users/emord/followers","following_url":"https://api.github.com/users/emord/following{/other_user}","gists_url":"https://api.github.com/users/emord/gists{/gist_id}","starred_url":"https://api.github.com/users/emord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emord/subscriptions","organizations_url":"https://api.github.com/users/emord/orgs","repos_url":"https://api.github.com/users/emord/repos","events_url":"https://api.github.com/users/emord/events{/privacy}","received_events_url":"https://api.github.com/users/emord/received_events","type":"User","site_admin":false},{"login":"mkangia","id":3864163,"node_id":"MDQ6VXNlcjM4NjQxNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/3864163?v=4","gravatar_id":"","url":"https://api.github.com/users/mkangia","html_url":"https://github.com/mkangia","followers_url":"https://api.github.com/users/mkangia/followers","following_url":"https://api.github.com/users/mkangia/following{/other_user}","gists_url":"https://api.github.com/users/mkangia/gists{/gist_id}","starred_url":"https://api.github.com/users/mkangia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkangia/subscriptions","organizations_url":"https://api.github.com/users/mkangia/orgs","repos_url":"https://api.github.com/users/mkangia/repos","events_url":"https://api.github.com/users/mkangia/events{/privacy}","received_events_url":"https://api.github.com/users/mkangia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":79032211,"node_id":"MDU6TGFiZWw3OTAzMjIxMQ==","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/Open%20for%20review:%20do%20not%20merge","name":"Open for review: do not merge","color":"5319e7","default":false},{"id":724784918,"node_id":"MDU6TGFiZWw3MjQ3ODQ5MTg=","url":"https://api.github.com/repos/dimagi/commcare-hq/labels/product/all-users-all-environments","name":"product/all-users-all-environments","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151/commits","review_comments_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151/comments","review_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/24151/comments","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/2edf5083ba039acb392a5a25397ceb1983385a6c","head":{"label":"dimagi:nh/reach/unique_id","ref":"nh/reach/unique_id","sha":"2edf5083ba039acb392a5a25397ceb1983385a6c","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-04-26T21:35:58Z","pushed_at":"2019-04-26T21:45:59Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":474638,"stargazers_count":357,"watchers_count":357,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":136,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":136,"open_issues":102,"watchers":357,"default_branch":"master"}},"base":{"label":"dimagi:master","ref":"master","sha":"d9242ea5bc310dff7a13c4baa32a1f77c7c27d54","user":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"repo":{"id":247278,"node_id":"MDEwOlJlcG9zaXRvcnkyNDcyNzg=","name":"commcare-hq","full_name":"dimagi/commcare-hq","private":false,"owner":{"login":"dimagi","id":94514,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0NTE0","avatar_url":"https://avatars1.githubusercontent.com/u/94514?v=4","gravatar_id":"","url":"https://api.github.com/users/dimagi","html_url":"https://github.com/dimagi","followers_url":"https://api.github.com/users/dimagi/followers","following_url":"https://api.github.com/users/dimagi/following{/other_user}","gists_url":"https://api.github.com/users/dimagi/gists{/gist_id}","starred_url":"https://api.github.com/users/dimagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimagi/subscriptions","organizations_url":"https://api.github.com/users/dimagi/orgs","repos_url":"https://api.github.com/users/dimagi/repos","events_url":"https://api.github.com/users/dimagi/events{/privacy}","received_events_url":"https://api.github.com/users/dimagi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dimagi/commcare-hq","description":"A server-side tool to help manage community health workers, written in Django","fork":false,"url":"https://api.github.com/repos/dimagi/commcare-hq","forks_url":"https://api.github.com/repos/dimagi/commcare-hq/forks","keys_url":"https://api.github.com/repos/dimagi/commcare-hq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimagi/commcare-hq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimagi/commcare-hq/teams","hooks_url":"https://api.github.com/repos/dimagi/commcare-hq/hooks","issue_events_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/events{/number}","events_url":"https://api.github.com/repos/dimagi/commcare-hq/events","assignees_url":"https://api.github.com/repos/dimagi/commcare-hq/assignees{/user}","branches_url":"https://api.github.com/repos/dimagi/commcare-hq/branches{/branch}","tags_url":"https://api.github.com/repos/dimagi/commcare-hq/tags","blobs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimagi/commcare-hq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimagi/commcare-hq/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimagi/commcare-hq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimagi/commcare-hq/statuses/{sha}","languages_url":"https://api.github.com/repos/dimagi/commcare-hq/languages","stargazers_url":"https://api.github.com/repos/dimagi/commcare-hq/stargazers","contributors_url":"https://api.github.com/repos/dimagi/commcare-hq/contributors","subscribers_url":"https://api.github.com/repos/dimagi/commcare-hq/subscribers","subscription_url":"https://api.github.com/repos/dimagi/commcare-hq/subscription","commits_url":"https://api.github.com/repos/dimagi/commcare-hq/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimagi/commcare-hq/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimagi/commcare-hq/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimagi/commcare-hq/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimagi/commcare-hq/contents/{+path}","compare_url":"https://api.github.com/repos/dimagi/commcare-hq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimagi/commcare-hq/merges","archive_url":"https://api.github.com/repos/dimagi/commcare-hq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimagi/commcare-hq/downloads","issues_url":"https://api.github.com/repos/dimagi/commcare-hq/issues{/number}","pulls_url":"https://api.github.com/repos/dimagi/commcare-hq/pulls{/number}","milestones_url":"https://api.github.com/repos/dimagi/commcare-hq/milestones{/number}","notifications_url":"https://api.github.com/repos/dimagi/commcare-hq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimagi/commcare-hq/labels{/name}","releases_url":"https://api.github.com/repos/dimagi/commcare-hq/releases{/id}","deployments_url":"https://api.github.com/repos/dimagi/commcare-hq/deployments","created_at":"2009-07-09T17:00:07Z","updated_at":"2019-04-26T21:35:58Z","pushed_at":"2019-04-26T21:45:59Z","git_url":"git://github.com/dimagi/commcare-hq.git","ssh_url":"git@github.com:dimagi/commcare-hq.git","clone_url":"https://github.com/dimagi/commcare-hq.git","svn_url":"https://github.com/dimagi/commcare-hq","homepage":"https://www.commcarehq.org","size":474638,"stargazers_count":357,"watchers_count":357,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":136,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":102,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":136,"open_issues":102,"watchers":357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151"},"html":{"href":"https://github.com/dimagi/commcare-hq/pull/24151"},"issue":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24151"},"comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/issues/24151/comments"},"review_comments":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151/comments"},"review_comment":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimagi/commcare-hq/pulls/24151/commits"},"statuses":{"href":"https://api.github.com/repos/dimagi/commcare-hq/statuses/2edf5083ba039acb392a5a25397ceb1983385a6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 247278,
"name": "dimagi/commcare-hq",
"url": "https://api.github.com/repos/dimagi/commcare-hq"
}
|
{
"id": 1486591,
"login": "orangejenny",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1486591?",
"url": "https://api.github.com/users/orangejenny"
}
|
{
"id": 94514,
"login": "dimagi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/94514?",
"url": "https://api.github.com/orgs/dimagi"
}
| 2019-04-26T21:11:43 |
9521147277
|
{"actor":{"display_login":"orangejenny"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/275163332","pull_request_review_id":226401995,"id":275163332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTE2MzMzMg==","diff_hunk":"@@ -1043,6 +1043,17 @@ public PluginWrapper getInstalled() {\n return pm.getPlugin(name);\n }\n \n+ @Exported\n+ public boolean isCompatible() {\n+ return isCompatible(new PluginManager.MetadataCache());\n+ }\n+\n+ public boolean isCompatible(PluginManager.MetadataCache cache) {","path":"core/src/main/java/hudson/model/UpdateSite.java","position":9,"original_position":9,"commit_id":"c1baf411bc80e4a38e65fda952bd64bfef63ee42","original_commit_id":"c1baf411bc80e4a38e65fda952bd64bfef63ee42","user":{"login":"daniel-beck","id":1831569,"node_id":"MDQ6VXNlcjE4MzE1Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1831569?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-beck","html_url":"https://github.com/daniel-beck","followers_url":"https://api.github.com/users/daniel-beck/followers","following_url":"https://api.github.com/users/daniel-beck/following{/other_user}","gists_url":"https://api.github.com/users/daniel-beck/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-beck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-beck/subscriptions","organizations_url":"https://api.github.com/users/daniel-beck/orgs","repos_url":"https://api.github.com/users/daniel-beck/repos","events_url":"https://api.github.com/users/daniel-beck/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-beck/received_events","type":"User","site_admin":false},"body":"Would `@Restricted(NoExternalUse.class)` this, no reason IMO to expose this to plugins.\r\n\r\nIf we end up not doing that, needs Javadoc + `@since TODO`.","created_at":"2019-04-14T16:03:42Z","updated_at":"2019-04-14T16:05:38Z","html_url":"https://github.com/jenkinsci/jenkins/pull/3985#discussion_r275163332","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/275163332"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3985#discussion_r275163332"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985","id":270291185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwMjkxMTg1","html_url":"https://github.com/jenkinsci/jenkins/pull/3985","diff_url":"https://github.com/jenkinsci/jenkins/pull/3985.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/3985.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3985","number":3985,"state":"open","locked":false,"title":"[JENKINS-56477] Fix to allow selecting compatible-only updates for plugins","user":{"login":"romenrg","id":1831480,"node_id":"MDQ6VXNlcjE4MzE0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1831480?v=4","gravatar_id":"","url":"https://api.github.com/users/romenrg","html_url":"https://github.com/romenrg","followers_url":"https://api.github.com/users/romenrg/followers","following_url":"https://api.github.com/users/romenrg/following{/other_user}","gists_url":"https://api.github.com/users/romenrg/gists{/gist_id}","starred_url":"https://api.github.com/users/romenrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romenrg/subscriptions","organizations_url":"https://api.github.com/users/romenrg/orgs","repos_url":"https://api.github.com/users/romenrg/repos","events_url":"https://api.github.com/users/romenrg/events{/privacy}","received_events_url":"https://api.github.com/users/romenrg/received_events","type":"User","site_admin":false},"body":"See [JENKINS-56477](https://issues.jenkins-ci.org/browse/JENKINS-56477).\r\n\r\nIn Nov 2018 [this PR](https://github.com/jenkinsci/jenkins/pull/3715) was approved and merged, but later @daniel-beck noticed there was a bug in the selection of \"compatible plugins\", which was not taking all cases into account.\r\n\r\nIn this PR I have modified the condition to select the compatible plugins, so that it covers all cases and, following @oleg-nenashev suggestion, I've created a separate button to allow users to install either \"All\", \"Compatible\" or \"None\".\r\n\r\n### Proposed changelog entries\r\n\r\n* The Plugin Manager now provides improved selection for plugin updates. Users willing to update plugins can select \"All\", \"Compatible\" or \"None\".\r\n* The selection of \"Compatible\" plugins has been fixed to exclude all that contain any warnings\r\n\r\n### Submitter checklist\r\n\r\n- [X] JIRA issue is well described\r\n- [X] Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). [Examples](https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/weekly.yml)\r\n * Use the `Internal: ` prefix if the change has no user-visible impact (API, test frameworks, etc.)\r\n- [X] Appropriate autotests or explanation to why this change has no tests\r\n- [ ] For dependency updates: links to external changelogs and, if possible, full diffs\r\n\r\n### Desired reviewers\r\n\r\n@daniel-beck - As the original reporter of the ticket\r\n@oleg-nenashev - Your [suggestion to provide a third option for the selection](https://github.com/jenkinsci/jenkins/pull/3715#pullrequestreview-170569822) was taken into account\r\n@batmat - I followed your TO-DO in the UpdateSiteTest and factored out the initialization piece for the UpdateSite creation that was being used in the \"minimumJavaVersion\" test and is now also included in the test I added (isPluginCompatible). Notice I removed the \"sites\" variable, since it seemed to be unused; using just the specific site.","created_at":"2019-04-14T11:53:06Z","updated_at":"2019-04-14T16:05:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9bdd36b643f9b0fa006a8303ac3cd9a45f16edc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/3985/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/c1baf411bc80e4a38e65fda952bd64bfef63ee42","head":{"label":"romenrg:jenkins-56477-update-plugins","ref":"jenkins-56477-update-plugins","sha":"c1baf411bc80e4a38e65fda952bd64bfef63ee42","user":{"login":"romenrg","id":1831480,"node_id":"MDQ6VXNlcjE4MzE0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1831480?v=4","gravatar_id":"","url":"https://api.github.com/users/romenrg","html_url":"https://github.com/romenrg","followers_url":"https://api.github.com/users/romenrg/followers","following_url":"https://api.github.com/users/romenrg/following{/other_user}","gists_url":"https://api.github.com/users/romenrg/gists{/gist_id}","starred_url":"https://api.github.com/users/romenrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romenrg/subscriptions","organizations_url":"https://api.github.com/users/romenrg/orgs","repos_url":"https://api.github.com/users/romenrg/repos","events_url":"https://api.github.com/users/romenrg/events{/privacy}","received_events_url":"https://api.github.com/users/romenrg/received_events","type":"User","site_admin":false},"repo":{"id":149168617,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxNjg2MTc=","name":"jenkins","full_name":"romenrg/jenkins","private":false,"owner":{"login":"romenrg","id":1831480,"node_id":"MDQ6VXNlcjE4MzE0ODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1831480?v=4","gravatar_id":"","url":"https://api.github.com/users/romenrg","html_url":"https://github.com/romenrg","followers_url":"https://api.github.com/users/romenrg/followers","following_url":"https://api.github.com/users/romenrg/following{/other_user}","gists_url":"https://api.github.com/users/romenrg/gists{/gist_id}","starred_url":"https://api.github.com/users/romenrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romenrg/subscriptions","organizations_url":"https://api.github.com/users/romenrg/orgs","repos_url":"https://api.github.com/users/romenrg/repos","events_url":"https://api.github.com/users/romenrg/events{/privacy}","received_events_url":"https://api.github.com/users/romenrg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romenrg/jenkins","description":"Jenkins automation server","fork":true,"url":"https://api.github.com/repos/romenrg/jenkins","forks_url":"https://api.github.com/repos/romenrg/jenkins/forks","keys_url":"https://api.github.com/repos/romenrg/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romenrg/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romenrg/jenkins/teams","hooks_url":"https://api.github.com/repos/romenrg/jenkins/hooks","issue_events_url":"https://api.github.com/repos/romenrg/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/romenrg/jenkins/events","assignees_url":"https://api.github.com/repos/romenrg/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/romenrg/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/romenrg/jenkins/tags","blobs_url":"https://api.github.com/repos/romenrg/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romenrg/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romenrg/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/romenrg/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romenrg/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/romenrg/jenkins/languages","stargazers_url":"https://api.github.com/repos/romenrg/jenkins/stargazers","contributors_url":"https://api.github.com/repos/romenrg/jenkins/contributors","subscribers_url":"https://api.github.com/repos/romenrg/jenkins/subscribers","subscription_url":"https://api.github.com/repos/romenrg/jenkins/subscription","commits_url":"https://api.github.com/repos/romenrg/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/romenrg/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/romenrg/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/romenrg/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/romenrg/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/romenrg/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romenrg/jenkins/merges","archive_url":"https://api.github.com/repos/romenrg/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romenrg/jenkins/downloads","issues_url":"https://api.github.com/repos/romenrg/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/romenrg/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/romenrg/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/romenrg/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romenrg/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/romenrg/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/romenrg/jenkins/deployments","created_at":"2018-09-17T18:17:28Z","updated_at":"2019-04-14T11:15:08Z","pushed_at":"2019-04-14T15:42:34Z","git_url":"git://github.com/romenrg/jenkins.git","ssh_url":"git@github.com:romenrg/jenkins.git","clone_url":"https://github.com/romenrg/jenkins.git","svn_url":"https://github.com/romenrg/jenkins","homepage":"https://jenkins.io/","size":112348,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"e460e6c40b0663165aa81f4420438480a264f1ea","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAzNjA3","name":"jenkins","full_name":"jenkinsci/jenkins","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins automation server","fork":false,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/jenkins/deployments","created_at":"2010-11-22T21:21:23Z","updated_at":"2019-04-14T14:43:56Z","pushed_at":"2019-04-14T15:42:37Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"https://jenkins.io/","size":110240,"stargazers_count":12622,"watchers_count":12622,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":5263,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":61,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5263,"open_issues":61,"watchers":12622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/3985"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3985"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/3985/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/3985/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/c1baf411bc80e4a38e65fda952bd64bfef63ee42"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 1103607,
"name": "jenkinsci/jenkins",
"url": "https://api.github.com/repos/jenkinsci/jenkins"
}
|
{
"id": 1831569,
"login": "daniel-beck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1831569?",
"url": "https://api.github.com/users/daniel-beck"
}
|
{
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
}
| 2019-04-14T16:03:42 |
9440189562
|
{"actor":{"display_login":"daniel-beck"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/comments/363893229","pull_request_review_id":339430070,"id":363893229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2Mzg5MzIyOQ==","diff_hunk":"@@ -111,6 +112,10 @@ boolean isIgnored() {\n return restrictions != null ? restrictions : EMPTY;\n }\n \n+ public void setJsonSchema(boolean jsonSchema) {","path":"plugin/src/main/java/io/jenkins/plugins/casc/Attribute.java","position":16,"original_position":12,"commit_id":"a242048a2e2a745a290c35f3de420c97ddf6c05d","original_commit_id":"6c420557e05e45a1ed17319ae9510953b6e36ce3","user":{"login":"timja","id":21194782,"node_id":"MDQ6VXNlcjIxMTk0Nzgy","avatar_url":"https://avatars3.githubusercontent.com/u/21194782?v=4","gravatar_id":"","url":"https://api.github.com/users/timja","html_url":"https://github.com/timja","followers_url":"https://api.github.com/users/timja/followers","following_url":"https://api.github.com/users/timja/following{/other_user}","gists_url":"https://api.github.com/users/timja/gists{/gist_id}","starred_url":"https://api.github.com/users/timja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timja/subscriptions","organizations_url":"https://api.github.com/users/timja/orgs","repos_url":"https://api.github.com/users/timja/repos","events_url":"https://api.github.com/users/timja/events{/privacy}","received_events_url":"https://api.github.com/users/timja/received_events","type":"User","site_admin":false},"body":"is this still required?","created_at":"2020-01-07T18:44:17Z","updated_at":"2020-01-07T18:46:35Z","html_url":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027#discussion_r363893229","pull_request_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/comments/363893229"},"html":{"href":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027#discussion_r363893229"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027"}},"in_reply_to_id":326520032},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027","id":311557579,"node_id":"MDExOlB1bGxSZXF1ZXN0MzExNTU3NTc5","html_url":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027","diff_url":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027.diff","patch_url":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027.patch","issue_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/1027","number":1027,"state":"open","locked":false,"title":"Schema Generation for nested yml configurations","user":{"login":"sladyn98","id":28837406,"node_id":"MDQ6VXNlcjI4ODM3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/28837406?v=4","gravatar_id":"","url":"https://api.github.com/users/sladyn98","html_url":"https://github.com/sladyn98","followers_url":"https://api.github.com/users/sladyn98/followers","following_url":"https://api.github.com/users/sladyn98/following{/other_user}","gists_url":"https://api.github.com/users/sladyn98/gists{/gist_id}","starred_url":"https://api.github.com/users/sladyn98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sladyn98/subscriptions","organizations_url":"https://api.github.com/users/sladyn98/orgs","repos_url":"https://api.github.com/users/sladyn98/repos","events_url":"https://api.github.com/users/sladyn98/events{/privacy}","received_events_url":"https://api.github.com/users/sladyn98/received_events","type":"User","site_admin":false},"body":"<!-- Please describe your pull request here. -->\r\nThis PR deals with the schema generation for nested yml files.\r\nWe would be focusing on \r\na) Implementation of a `describeStructure` function for all the configurators which would then be used in the schema generation.\\\r\nb) Testing Framework for the Schema\r\nCloses https://github.com/jenkinsci/configuration-as-code-plugin/issues/1038\r\nCloses https://github.com/jenkinsci/configuration-as-code-plugin/issues/997\r\n\r\n<!--\r\nTo mark your pull request as work in progress put the construction emoji 🚧 in your title. (hint: copy it)\r\nHelps us to block accidental merges of unfinished work.\r\n-->\r\n\r\n### Your checklist for this pull request\r\n\r\n🚨 Please review the [guidelines for contributing](../blob/master/docs/CONTRIBUTING.md) to this repository.\r\n\r\n- [x] Make sure you are requesting to **pull a topic/feature/bugfix branch** (right side) and not your master branch!\r\n- [x] Ensure that the pull request title represents the desired changelog entry\r\n- [x] Please describe what you did\r\n- [x] Link to relevant issues in GitHub or in [Jenkins JIRA](https://issues.jenkins-ci.org)\r\n- [x] Link to relevant pull requests, esp. upstream and downstream changes\r\n- [x] Did you provide a test-case? That demonstrates feature works or fixes the issue.\r\n\r\n<!--\r\nPut an `x` into the [ ] to show you have filled the information below\r\nDescribe your pull request below\r\n-->\r\n","created_at":"2019-08-27T20:37:35Z","updated_at":"2020-01-07T18:46:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d23922c8be413423fa72579d5e68fe16c1f8b282","assignee":{"login":"sladyn98","id":28837406,"node_id":"MDQ6VXNlcjI4ODM3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/28837406?v=4","gravatar_id":"","url":"https://api.github.com/users/sladyn98","html_url":"https://github.com/sladyn98","followers_url":"https://api.github.com/users/sladyn98/followers","following_url":"https://api.github.com/users/sladyn98/following{/other_user}","gists_url":"https://api.github.com/users/sladyn98/gists{/gist_id}","starred_url":"https://api.github.com/users/sladyn98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sladyn98/subscriptions","organizations_url":"https://api.github.com/users/sladyn98/orgs","repos_url":"https://api.github.com/users/sladyn98/repos","events_url":"https://api.github.com/users/sladyn98/events{/privacy}","received_events_url":"https://api.github.com/users/sladyn98/received_events","type":"User","site_admin":false},"assignees":[{"login":"sladyn98","id":28837406,"node_id":"MDQ6VXNlcjI4ODM3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/28837406?v=4","gravatar_id":"","url":"https://api.github.com/users/sladyn98","html_url":"https://github.com/sladyn98","followers_url":"https://api.github.com/users/sladyn98/followers","following_url":"https://api.github.com/users/sladyn98/following{/other_user}","gists_url":"https://api.github.com/users/sladyn98/gists{/gist_id}","starred_url":"https://api.github.com/users/sladyn98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sladyn98/subscriptions","organizations_url":"https://api.github.com/users/sladyn98/orgs","repos_url":"https://api.github.com/users/sladyn98/repos","events_url":"https://api.github.com/users/sladyn98/events{/privacy}","received_events_url":"https://api.github.com/users/sladyn98/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"casz","id":1661688,"node_id":"MDQ6VXNlcjE2NjE2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1661688?v=4","gravatar_id":"","url":"https://api.github.com/users/casz","html_url":"https://github.com/casz","followers_url":"https://api.github.com/users/casz/followers","following_url":"https://api.github.com/users/casz/following{/other_user}","gists_url":"https://api.github.com/users/casz/gists{/gist_id}","starred_url":"https://api.github.com/users/casz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/casz/subscriptions","organizations_url":"https://api.github.com/users/casz/orgs","repos_url":"https://api.github.com/users/casz/repos","events_url":"https://api.github.com/users/casz/events{/privacy}","received_events_url":"https://api.github.com/users/casz/received_events","type":"User","site_admin":false},{"login":"oleg-nenashev","id":3000480,"node_id":"MDQ6VXNlcjMwMDA0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/3000480?v=4","gravatar_id":"","url":"https://api.github.com/users/oleg-nenashev","html_url":"https://github.com/oleg-nenashev","followers_url":"https://api.github.com/users/oleg-nenashev/followers","following_url":"https://api.github.com/users/oleg-nenashev/following{/other_user}","gists_url":"https://api.github.com/users/oleg-nenashev/gists{/gist_id}","starred_url":"https://api.github.com/users/oleg-nenashev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleg-nenashev/subscriptions","organizations_url":"https://api.github.com/users/oleg-nenashev/orgs","repos_url":"https://api.github.com/users/oleg-nenashev/repos","events_url":"https://api.github.com/users/oleg-nenashev/events{/privacy}","received_events_url":"https://api.github.com/users/oleg-nenashev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1511604992,"node_id":"MDU6TGFiZWwxNTExNjA0OTky","url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/labels/dev-tools","name":"dev-tools","color":"551a8b","default":false,"description":"JCasC Community Bridge Dev-Tools Project"},{"id":1286814097,"node_id":"MDU6TGFiZWwxMjg2ODE0MDk3","url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/labels/feature","name":"feature","color":"1d00ff","default":false,"description":"A PR that adds a feature - used by Release Drafter"}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/1027/comments","statuses_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/statuses/a242048a2e2a745a290c35f3de420c97ddf6c05d","head":{"label":"sladyn98:nested_yaml_schema","ref":"nested_yaml_schema","sha":"a242048a2e2a745a290c35f3de420c97ddf6c05d","user":{"login":"sladyn98","id":28837406,"node_id":"MDQ6VXNlcjI4ODM3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/28837406?v=4","gravatar_id":"","url":"https://api.github.com/users/sladyn98","html_url":"https://github.com/sladyn98","followers_url":"https://api.github.com/users/sladyn98/followers","following_url":"https://api.github.com/users/sladyn98/following{/other_user}","gists_url":"https://api.github.com/users/sladyn98/gists{/gist_id}","starred_url":"https://api.github.com/users/sladyn98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sladyn98/subscriptions","organizations_url":"https://api.github.com/users/sladyn98/orgs","repos_url":"https://api.github.com/users/sladyn98/repos","events_url":"https://api.github.com/users/sladyn98/events{/privacy}","received_events_url":"https://api.github.com/users/sladyn98/received_events","type":"User","site_admin":false},"repo":{"id":193060684,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMwNjA2ODQ=","name":"configuration-as-code-plugin","full_name":"sladyn98/configuration-as-code-plugin","private":false,"owner":{"login":"sladyn98","id":28837406,"node_id":"MDQ6VXNlcjI4ODM3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/28837406?v=4","gravatar_id":"","url":"https://api.github.com/users/sladyn98","html_url":"https://github.com/sladyn98","followers_url":"https://api.github.com/users/sladyn98/followers","following_url":"https://api.github.com/users/sladyn98/following{/other_user}","gists_url":"https://api.github.com/users/sladyn98/gists{/gist_id}","starred_url":"https://api.github.com/users/sladyn98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sladyn98/subscriptions","organizations_url":"https://api.github.com/users/sladyn98/orgs","repos_url":"https://api.github.com/users/sladyn98/repos","events_url":"https://api.github.com/users/sladyn98/events{/privacy}","received_events_url":"https://api.github.com/users/sladyn98/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sladyn98/configuration-as-code-plugin","description":"Jenkins Configuration as Code Plugin","fork":true,"url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin","forks_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/forks","keys_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/teams","hooks_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/hooks","issue_events_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/events","assignees_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/tags","blobs_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/languages","stargazers_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/stargazers","contributors_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/contributors","subscribers_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/subscribers","subscription_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/subscription","commits_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/merges","archive_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/downloads","issues_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/labels{/name}","releases_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/sladyn98/configuration-as-code-plugin/deployments","created_at":"2019-06-21T08:25:26Z","updated_at":"2019-06-21T08:25:29Z","pushed_at":"2020-01-07T16:10:08Z","git_url":"git://github.com/sladyn98/configuration-as-code-plugin.git","ssh_url":"git@github.com:sladyn98/configuration-as-code-plugin.git","clone_url":"https://github.com/sladyn98/configuration-as-code-plugin.git","svn_url":"https://github.com/sladyn98/configuration-as-code-plugin","homepage":null,"size":4312,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"6cc682ce4d9fcb063078257980edd460b76c25d9","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":107676801,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc2NzY4MDE=","name":"configuration-as-code-plugin","full_name":"jenkinsci/configuration-as-code-plugin","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/configuration-as-code-plugin","description":"Jenkins Configuration as Code Plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin","forks_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/deployments","created_at":"2017-10-20T12:43:10Z","updated_at":"2020-01-07T13:17:46Z","pushed_at":"2020-01-07T16:10:10Z","git_url":"git://github.com/jenkinsci/configuration-as-code-plugin.git","ssh_url":"git@github.com:jenkinsci/configuration-as-code-plugin.git","clone_url":"https://github.com/jenkinsci/configuration-as-code-plugin.git","svn_url":"https://github.com/jenkinsci/configuration-as-code-plugin","homepage":"https://plugins.jenkins.io/configuration-as-code","size":4041,"stargazers_count":1479,"watchers_count":1479,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":87,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":323,"open_issues":87,"watchers":1479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027"},"html":{"href":"https://github.com/jenkinsci/configuration-as-code-plugin/pull/1027"},"issue":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/1027"},"comments":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/issues/1027/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/pulls/1027/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/configuration-as-code-plugin/statuses/a242048a2e2a745a290c35f3de420c97ddf6c05d"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 107676801,
"name": "jenkinsci/configuration-as-code-plugin",
"url": "https://api.github.com/repos/jenkinsci/configuration-as-code-plugin"
}
|
{
"id": 21194782,
"login": "timja",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/21194782?",
"url": "https://api.github.com/users/timja"
}
|
{
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
}
| 2020-01-07T18:44:17 |
11221837012
|
{"actor":{"display_login":"timja"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments/311171649","pull_request_review_id":271481482,"id":311171649,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTE3MTY0OQ==","diff_hunk":"@@ -32,55 +32,29 @@\n \n import java.util.logging.Level;\n \n-import org.jenkinsci.plugins.workflow.flow.FlowExecutionOwner;\n import org.jenkinsci.plugins.workflow.job.WorkflowJob;\n import org.jenkinsci.plugins.workflow.job.WorkflowRun;\n-import org.jenkinsci.plugins.workflow.test.steps.SemaphoreStep;\n \n import static org.junit.Assert.*;\n \n import org.junit.Assert;\n import org.junit.Assume;\n import org.junit.ClassRule;\n-import org.junit.Ignore;\n import org.junit.Rule;\n import org.junit.Test;\n import org.junit.rules.ErrorCollector;\n import org.jvnet.hudson.test.BuildWatcher;\n import org.jvnet.hudson.test.Issue;\n+import org.jvnet.hudson.test.JenkinsRule;\n import org.jvnet.hudson.test.LoggerRule;\n \n-public class CpsFlowDefinition2Test extends AbstractCpsFlowTest {\n+public class CpsFlowDefinition2Test {\n \n @ClassRule public static BuildWatcher buildWatcher = new BuildWatcher();\n+ @ClassRule public static JenkinsRule jenkins = new JenkinsRule();","path":"src/test/java/org/jenkinsci/plugins/workflow/cps/CpsFlowDefinition2Test.java","position":27,"original_position":27,"commit_id":"51277859bd446aa7b5e66da38dea506381ac61ad","original_commit_id":"51277859bd446aa7b5e66da38dea506381ac61ad","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"body":"Cuts the test time from ~65 seconds to ~35 seconds on my machine.","created_at":"2019-08-06T17:00:04Z","updated_at":"2019-08-06T17:00:13Z","html_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310#discussion_r311171649","pull_request_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments/311171649"},"html":{"href":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310#discussion_r311171649"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310","id":302991069,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyOTkxMDY5","html_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310","diff_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310.diff","patch_url":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310.patch","issue_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/310","number":310,"state":"open","locked":false,"title":"Add regression tests for SECURITY-1465","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"body":"Adding some regression tests for SECURITY-1465. Maybe some are unnecessary, but I'd like to have at least `blockLhsInMethodPointerExpression`, `blockRhsInMethodPointerExpression`, and `blockCastingUnsafeUserDefinedImplementationsOfCollection` in case changes to groovy-cps affect those tests. ","created_at":"2019-07-31T14:47:56Z","updated_at":"2019-08-06T17:00:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86428b7ff83c6c6df06b30611fda9617dfe06a9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":356993225,"node_id":"MDU6TGFiZWwzNTY5OTMyMjU=","url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/labels/work-in-progress","name":"work-in-progress","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/310/comments","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/51277859bd446aa7b5e66da38dea506381ac61ad","head":{"label":"dwnusbaum:SECURITY-1465","ref":"SECURITY-1465","sha":"51277859bd446aa7b5e66da38dea506381ac61ad","user":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"repo":{"id":144767158,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NjcxNTg=","name":"workflow-cps-plugin","full_name":"dwnusbaum/workflow-cps-plugin","private":false,"owner":{"login":"dwnusbaum","id":1068968,"node_id":"MDQ6VXNlcjEwNjg5Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/1068968?v=4","gravatar_id":"","url":"https://api.github.com/users/dwnusbaum","html_url":"https://github.com/dwnusbaum","followers_url":"https://api.github.com/users/dwnusbaum/followers","following_url":"https://api.github.com/users/dwnusbaum/following{/other_user}","gists_url":"https://api.github.com/users/dwnusbaum/gists{/gist_id}","starred_url":"https://api.github.com/users/dwnusbaum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwnusbaum/subscriptions","organizations_url":"https://api.github.com/users/dwnusbaum/orgs","repos_url":"https://api.github.com/users/dwnusbaum/repos","events_url":"https://api.github.com/users/dwnusbaum/events{/privacy}","received_events_url":"https://api.github.com/users/dwnusbaum/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dwnusbaum/workflow-cps-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin","forks_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/forks","keys_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/teams","hooks_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/hooks","issue_events_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/events","assignees_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/tags","blobs_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/languages","stargazers_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/stargazers","contributors_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/contributors","subscribers_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/subscribers","subscription_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/subscription","commits_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/merges","archive_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/downloads","issues_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/dwnusbaum/workflow-cps-plugin/deployments","created_at":"2018-08-14T20:07:03Z","updated_at":"2019-07-12T21:42:28Z","pushed_at":"2019-08-06T16:54:19Z","git_url":"git://github.com/dwnusbaum/workflow-cps-plugin.git","ssh_url":"git@github.com:dwnusbaum/workflow-cps-plugin.git","clone_url":"https://github.com/dwnusbaum/workflow-cps-plugin.git","svn_url":"https://github.com/dwnusbaum/workflow-cps-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Groovy+Plugin","size":3453,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"d21748ac6068e1b589b25e7286dcfc02fe07eaaf","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":55543225,"node_id":"MDEwOlJlcG9zaXRvcnk1NTU0MzIyNQ==","name":"workflow-cps-plugin","full_name":"jenkinsci/workflow-cps-plugin","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/workflow-cps-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin","forks_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/deployments","created_at":"2016-04-05T20:24:40Z","updated_at":"2019-08-01T20:07:47Z","pushed_at":"2019-08-06T16:54:20Z","git_url":"git://github.com/jenkinsci/workflow-cps-plugin.git","ssh_url":"git@github.com:jenkinsci/workflow-cps-plugin.git","clone_url":"https://github.com/jenkinsci/workflow-cps-plugin.git","svn_url":"https://github.com/jenkinsci/workflow-cps-plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Pipeline+Groovy+Plugin","size":3420,"stargazers_count":85,"watchers_count":85,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":123,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":null,"forks":123,"open_issues":11,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310"},"html":{"href":"https://github.com/jenkinsci/workflow-cps-plugin/pull/310"},"issue":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/310"},"comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/issues/310/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/pulls/310/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/workflow-cps-plugin/statuses/51277859bd446aa7b5e66da38dea506381ac61ad"}},"author_association":"MEMBER"}}
|
{
"id": 55543225,
"name": "jenkinsci/workflow-cps-plugin",
"url": "https://api.github.com/repos/jenkinsci/workflow-cps-plugin"
}
|
{
"id": 1068968,
"login": "dwnusbaum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1068968?",
"url": "https://api.github.com/users/dwnusbaum"
}
|
{
"id": 107424,
"login": "jenkinsci",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/107424?",
"url": "https://api.github.com/orgs/jenkinsci"
}
| 2019-08-06T17:00:04 |
10158477761
|
{"actor":{"display_login":"dwnusbaum"}}
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.